1. 29 Oct, 2009 3 commits
    • eric@webkit.org's avatar
      2009-10-29 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 216b123d
      eric@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              [Qt] Implement DELETE HTTP method for XmlHttpRequest
              https://bugs.webkit.org/show_bug.cgi?id=30894
      
              No new tests as this functionality is already tested by the
              xmlhttprequest LayoutTests. As this patch depends on an unreleased
              version of the dependent QtNetwork library and the tests will be
              enabled later once the dependent library is released (and the
              buildbot is updated).
      
              * platform/network/qt/QNetworkReplyHandler.cpp:
              (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
              (WebCore::QNetworkReplyHandler::start):
      2009-10-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Tor Arne Vestbø.
      
              [Qt] Implement DELETE HTTP method for XmlHttpRequest
              https://bugs.webkit.org/show_bug.cgi?id=30894
      
              No new tests as this functionality is already tested by the
              xmlhttprequest LayoutTests. As this patch depends on an unreleased
              version of the dependent QtNetwork library and the tests will be
              enabled later once the dependent library is released (and the
              buildbot is updated).
      
              * Api/qwebframe.cpp:
              (QWebFrame::load):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      216b123d
    • kenneth@webkit.org's avatar
      Remove QWebView::guessUrlFromString() and replace its use · 58156c8b
      kenneth@webkit.org authored
      with the new QUrl::fromUserInput() if using Qt 4.6 or newer.
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
      Reviewed by Tor Arne Vestbø.
      
      * Api/qwebview.cpp:
      * Api/qwebview.h:
      * QGVLauncher/main.cpp:
      (urlFromUserInput):
      (WebPage::applyProxy):
      (MainWindow::load):
      * QtLauncher/main.cpp:
      (urlFromUserInput):
      (MainWindow::MainWindow):
      (MainWindow::changeLocation):
      * tests/qwebview/tst_qwebview.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58156c8b
    • kenneth@webkit.org's avatar
      Serialize directly to the stream, and not first to an QByteArray, · 4b623cd7
      kenneth@webkit.org authored
      that is later serialized. That is slower and also uses more bytes.
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
      Reviewed by Tor Arne Vestbø.
      
      * Api/qwebhistory.cpp:
      (operator<<):
      (operator>>):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b623cd7
  2. 28 Oct, 2009 7 commits
    • hamaji@chromium.org's avatar
      2009-10-28 Shinichiro Hamaji <hamaji@chromium.org> · 7f664819
      hamaji@chromium.org authored
              Reviewed by Eric Seidel.
      
              [Qt] WebFrame::counterValueForElementById must not be exposed
              https://bugs.webkit.org/show_bug.cgi?id=30882
      
              * Api/qwebframe.cpp:
              (qt_drt_counterValueForElementById):
              * Api/qwebframe.h:
      2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Eric Seidel.
      
              [Qt] WebFrame::counterValueForElementById must not be exposed
              https://bugs.webkit.org/show_bug.cgi?id=30882
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::counterValueForElementById):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f664819
    • hamaji@chromium.org's avatar
      2009-10-27 Shinichiro Hamaji <hamaji@chromium.org> · 47244a6c
      hamaji@chromium.org authored
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              * Api/qwebframe.cpp:
              (QWebFrame::counterValueForElementById):
              (QWebHitTestResult::frame):
              * Api/qwebframe.h:
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              * webkit/webkitprivate.h:
              * webkit/webkitwebframe.cpp:
              (webkit_web_frame_counter_value_for_element_by_id):
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              * Interfaces/IWebFramePrivate.idl:
              * WebFrame.cpp:
              (WebFrame::counterValueForElementById):
              * WebFrame.h:
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              Add counterValueForElement in WebFrame to call WebCore::counterValueForElement.
      
              * Misc/WebCoreStatistics.h:
              * Misc/WebCoreStatistics.mm:
              (-[WebFrame counterValueForElement:]):
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              Expose WebCore::counterValueForElement as a WebCore API.
      
              * WebCore.base.exp:
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeCounterValuesFromChildren):
              (WebCore::counterValueForElement):
              * rendering/RenderTreeAsText.h:
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              Convert two pixel tests to dumpAsText tests using counterValueForElementById.
      
              * fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
              * fast/css/counters/t1204-increment-00-c-o.html:
              * fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
              * fast/css/counters/t1204-increment-01-c-o.html:
              * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Removed.
              * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Removed.
              * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
              * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Removed.
              * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Removed.
              * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.
              * platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
              * platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.
      2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Provide a way to get counter values with layoutTestContoller
              https://bugs.webkit.org/show_bug.cgi?id=30555
      
              Define layoutTestContoller.counterValueForElementById.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (counterValueForElementByIdCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::counterValueForElementById):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47244a6c
    • kenneth@webkit.org's avatar
      [Qt] QWebHistory::saveState() is inconsistent with the Qt API · 89830b3b
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=30710
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
      Reviewed by Tor Arne Vestbø.
      
      WebCore:
      
      Enforce the versioning, by ignoring any version different
      from 1.
      
      * history/qt/HistoryItemQt.cpp:
      (WebCore::HistoryItem::restoreState):
      (WebCore::HistoryItem::saveState):
      
      WebKit/qt:
      
      Make the versioning internal and enforce it in the WebCore
      part. Adjust the comments, as well as remove now dead code.
      
      * Api/qwebhistory.cpp:
      (operator<<):
      (operator>>):
      * Api/qwebhistory.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89830b3b
    • tonikitoo@webkit.org's avatar
      Pushing missing WebKit/qt/tests/qwebframe/resources/ dir from bug 29248. · 2104160d
      tonikitoo@webkit.org authored
      Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-28
      [Qt] [API] Make it possible to have 'invisible' loads
      https://bugs.webkit.org/show_bug.cgi?id=29248
      
      * tests/qwebframe/resources/image2.png: Copied from WebKit/qt/tests/qwebelement/image.png.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2104160d
    • kenneth@webkit.org's avatar
      [Qt] QWebHistory::saveState() is inconsistent with the Qt API · 6dbdf32f
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=30710
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
      Reviewed by Holger Freyther.
      
      Remove the QWebHistory::saveState() and ::restoreState() as
      they are inconsistent with the Qt API.
      
      Update unittests to reflect the change.
      
      * Api/qwebhistory.cpp:
      (operator<<):
      (operator>>):
      * Api/qwebhistory.h:
      * tests/qwebhistory/tst_qwebhistory.cpp:
      (saveHistory):
      (restoreHistory):
      (tst_QWebHistory::saveAndRestore_crash_1):
      (tst_QWebHistory::saveAndRestore_crash_2):
      (tst_QWebHistory::saveAndRestore_crash_3):
      (tst_QWebHistory::clear):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dbdf32f
    • tonikitoo@webkit.org's avatar
      Complementary fix to bug 30779. · 83aff094
      tonikitoo@webkit.org authored
      Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-27
      Reviewed by Holger Freyther.
      
      By mistake I used QWeakPointer's toStrongRef() method which docs
      explicitly say to not be used in this situation (when the tracked
      pointer is devired from QObject). Instead QWeakPointer's data()
      is recommended.
      
      * Api/qwebpage.cpp:
      (QWebPage::view):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83aff094
    • zecke@webkit.org's avatar
      Fix assertion in SVGRenderBase::mapLocalToContainer resulting from HitTestResult::boundinBox() · 279154a2
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27347
      
      The current HitTestResult methods are not using the (3d)
      transformation aware routines. This can lead to an assertion
      SVGRenderBase::mapLocalToContainer method.
      
      Remove HitTestResult::boundingBox() as it is only used in
      two places and conceptually doesn't belong into a HitTest
      which is operating on points. Update the Qt and Win code
      to determine the rect themselves in a (3d) transformation
      fashion.
      
      Change HitTestResult::imageRect to use the (3d) transformation
      aware RenderBox::absoluteContentQuad to avoid running into
      an assertion with SVG content.
      
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::imageRect):
      * rendering/HitTestResult.h:
      
      * WebElementPropertyBag.cpp:
      (WebElementPropertyBag::Read):
      
      * Api/qwebframe.cpp:
      (QWebHitTestResultPrivate::QWebHitTestResultPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      279154a2
  3. 27 Oct, 2009 5 commits
  4. 26 Oct, 2009 3 commits
    • kenneth@webkit.org's avatar
      Unreviewed documentation fix from David Boddie (Qt Doc Team) · 9779f61e
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
      Removes the check around the RenderHints property documentation
      that was clearly added to synchronize the source and header files
      when the #if !defined(Q_OS_SYMBIAN) guards was added to the
      property.
      
      The documentation has also been updated to ensure that Symbian
      users know that there is no actual RenderHints property on their
      platform.
      
      * Api/qwebview.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9779f61e
    • kenneth@webkit.org's avatar
      Unreviewed documentation fix from David Boddie (Qt Doc Team) · c0d7722c
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
      Ensure that qdoc will always see the RenderHints property.
      
      The property was only defined in the header file if the Q_OS_SYMBIAN
      symbol was not defined, resulting in the property not showing up
      in the Qt documentation just because one platform doesn't support it.
      
      A follow up commit will improve the documentation for the property
      and note that it is not supported on the Symbiam platform.
      
      * Api/qwebview.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0d7722c
    • eric@webkit.org's avatar
      2009-10-26 Benjamin Poulain <benjamin.poulain@nokia.com> · fb528d62
      eric@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              [Qt] Reintroduce QWebElementCollection
      
              Revert the patch that has replaced QWebElementCollection
              with QList<QWebElement>. Update the tests accordingly.
      
              Remove the constness of the return type of QWebElement operator[].
      
              https://bugs.webkit.org/show_bug.cgi?id=30767
      
              * Api/qwebelement.cpp:
              (QWebElement::findAll):
              (QWebElementCollectionPrivate::QWebElementCollectionPrivate):
              (QWebElementCollectionPrivate::create):
              (QWebElementCollection::QWebElementCollection):
              (QWebElementCollection::operator=):
              (QWebElementCollection::~QWebElementCollection):
              (QWebElementCollection::operator+):
              (QWebElementCollection::append):
              (QWebElementCollection::count):
              (QWebElementCollection::at):
              (QWebElementCollection::toList):
              * Api/qwebelement.h:
              (const_iterator::begin):
              (const_iterator::end):
              (const_iterator::operator[]):
              * Api/qwebframe.cpp:
              (QWebFrame::findAllElements):
              * Api/qwebframe.h:
              * QtLauncher/main.cpp:
              (MainWindow::selectElements):
              * tests/qwebelement/tst_qwebelement.cpp:
              (tst_QWebElement::simpleCollection):
              (tst_QWebElement::iteration):
              (tst_QWebElement::emptyCollection):
              (tst_QWebElement::appendCollection):
              (tst_QWebElement::nullSelect):
              (tst_QWebElement::hasSetFocus):
              (tst_QWebElement::render):
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::inputMethods):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb528d62
  5. 24 Oct, 2009 1 commit
    • eric@webkit.org's avatar
      2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 5708acfe
      eric@webkit.org authored
              Reviewed by Holger Freyther.
      
              [Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
              https://bugs.webkit.org/show_bug.cgi?id=30476
      
              Set the stack size to 80 Kb and heap size to the 128kB - 32MB range
              to all executables linking against WebKit library.
      
              * WebKit.pri:
      2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Holger Freyther.
      
              [Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
              https://bugs.webkit.org/show_bug.cgi?id=30476
      
              Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
              to jsc.exe.
      
              * jsc.pro:
      2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Holger Freyther.
      
              [Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
              https://bugs.webkit.org/show_bug.cgi?id=30476
      
              Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
              to all QtWebkit executables.
      
              * QGVLauncher/QGVLauncher.pro:
              * QtLauncher/QtLauncher.pro:
              * tests/benchmarks/loading/tst_loading.pro:
              * tests/benchmarks/painting/tst_painting.pro:
              * tests/qgraphicswebview/qgraphicswebview.pro:
              * tests/qwebelement/qwebelement.pro:
              * tests/qwebframe/qwebframe.pro:
              * tests/qwebhistory/qwebhistory.pro:
              * tests/qwebhistoryinterface/qwebhistoryinterface.pro:
              * tests/qwebpage/qwebpage.pro:
              * tests/qwebplugindatabase/qwebplugindatabase.pro:
              * tests/qwebview/qwebview.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5708acfe
  6. 22 Oct, 2009 5 commits
  7. 20 Oct, 2009 7 commits
  8. 19 Oct, 2009 9 commits