1. 19 Dec, 2011 23 commits
    • ggaren@apple.com's avatar
      Placement new does an unnecessary NULL check · 215589e0
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=74676
      
      Reviewed by Sam Weinig.
      
      Source/JavaScriptCore: 
      
      We can define our own version, which skips the NULL check.
              
      Not a measurable speedup, but code inspection shows better code generated,
      and I believe this is a step toward turning off -fomit-frame-pointer.
      
      * API/JSCallbackConstructor.h:
      (JSC::JSCallbackConstructor::create):
      * API/JSCallbackFunction.h:
      (JSC::JSCallbackFunction::create): Use the NotNull version of placement
      new to skip the NULL check.
      
      * API/JSCallbackObject.h: Removed a conflicting, unnecessaray placement new.
      
      (JSC::JSCallbackObject::create):
      * debugger/DebuggerActivation.h:
      (JSC::DebuggerActivation::create):
      * heap/HandleHeap.cpp:
      (JSC::HandleHeap::grow):
      * heap/HandleHeap.h:
      (JSC::HandleHeap::allocate):
      * heap/MarkedBlock.cpp:
      (JSC::MarkedBlock::create):
      (JSC::MarkedBlock::recycle):
      * jit/JITCode.h:
      (JSC::JITCode::clear):
      * jsc.cpp:
      (GlobalObject::create):
      * profiler/CallIdentifier.h:
      * runtime/Arguments.h:
      (JSC::Arguments::create):
      * runtime/ArrayConstructor.h:
      (JSC::ArrayConstructor::create):
      * runtime/ArrayPrototype.h:
      (JSC::ArrayPrototype::create):
      * runtime/BooleanConstructor.h:
      (JSC::BooleanConstructor::create):
      * runtime/BooleanObject.h:
      (JSC::BooleanObject::create):
      * runtime/BooleanPrototype.h:
      (JSC::BooleanPrototype::create):
      * runtime/DateConstructor.h:
      (JSC::DateConstructor::create):
      * runtime/DateInstance.h:
      (JSC::DateInstance::create):
      * runtime/DatePrototype.h:
      (JSC::DatePrototype::create):
      * runtime/Error.h:
      (JSC::StrictModeTypeErrorFunction::create):
      * runtime/ErrorConstructor.h:
      (JSC::ErrorConstructor::create):
      * runtime/ErrorInstance.h:
      (JSC::ErrorInstance::create):
      * runtime/ErrorPrototype.h:
      (JSC::ErrorPrototype::create):
      * runtime/ExceptionHelpers.h:
      (JSC::InterruptedExecutionError::create):
      (JSC::TerminatedExecutionError::create):
      * runtime/Executable.h:
      (JSC::NativeExecutable::create):
      (JSC::EvalExecutable::create):
      (JSC::ProgramExecutable::create):
      (JSC::FunctionExecutable::create):
      * runtime/FunctionConstructor.h:
      (JSC::FunctionConstructor::create):
      * runtime/FunctionPrototype.h:
      (JSC::FunctionPrototype::create):
      * runtime/GetterSetter.h:
      (JSC::GetterSetter::create):
      * runtime/JSAPIValueWrapper.h:
      (JSC::JSAPIValueWrapper::create):
      * runtime/JSActivation.h:
      (JSC::JSActivation::create):
      * runtime/JSArray.h:
      (JSC::JSArray::create):
      * runtime/JSBoundFunction.cpp:
      (JSC::JSBoundFunction::create):
      * runtime/JSByteArray.h:
      (JSC::JSByteArray::create): Use the NotNull version of placement
      new to skip the NULL check.
      
      * runtime/JSCell.h: Removed a conflicting, unnecessaray placement new.
      
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::create):
      * runtime/JSFunction.h:
      (JSC::JSFunction::create):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::create):
      * runtime/JSGlobalThis.h:
      (JSC::JSGlobalThis::create):
      * runtime/JSNotAnObject.h:
      (JSC::JSNotAnObject::create):
      * runtime/JSONObject.h:
      (JSC::JSONObject::create):
      * runtime/JSObject.h:
      (JSC::JSFinalObject::create):
      * runtime/JSPropertyNameIterator.cpp:
      (JSC::JSPropertyNameIterator::create):
      * runtime/JSPropertyNameIterator.h:
      (JSC::JSPropertyNameIterator::create):
      * runtime/JSStaticScopeObject.h:
      (JSC::JSStaticScopeObject::create):
      * runtime/JSString.cpp:
      (JSC::StringObject::create):
      * runtime/JSString.h:
      (JSC::RopeBuilder::createNull):
      (JSC::RopeBuilder::create):
      (JSC::RopeBuilder::createHasOtherOwner):
      * runtime/MathObject.h:
      (JSC::MathObject::create):
      * runtime/NativeErrorConstructor.h:
      (JSC::NativeErrorConstructor::create):
      * runtime/NativeErrorPrototype.h:
      (JSC::NativeErrorPrototype::create):
      * runtime/NumberConstructor.h:
      (JSC::NumberConstructor::create):
      * runtime/NumberObject.h:
      (JSC::NumberObject::create):
      * runtime/NumberPrototype.h:
      (JSC::NumberPrototype::create):
      * runtime/ObjectConstructor.h:
      (JSC::ObjectConstructor::create):
      * runtime/ObjectPrototype.h:
      (JSC::ObjectPrototype::create):
      * runtime/RegExp.cpp:
      (JSC::RegExp::createWithoutCaching):
      * runtime/RegExpConstructor.h:
      (JSC::RegExpConstructor::create):
      * runtime/RegExpMatchesArray.h:
      (JSC::RegExpMatchesArray::create):
      * runtime/RegExpObject.h:
      (JSC::RegExpObject::create):
      * runtime/RegExpPrototype.h:
      (JSC::RegExpPrototype::create):
      * runtime/ScopeChain.h:
      (JSC::ScopeChainNode::create):
      * runtime/StrictEvalActivation.h:
      (JSC::StrictEvalActivation::create):
      * runtime/StringConstructor.h:
      (JSC::StringConstructor::create):
      * runtime/StringObject.h:
      (JSC::StringObject::create):
      * runtime/StringPrototype.h:
      (JSC::StringPrototype::create):
      * runtime/Structure.h:
      (JSC::Structure::create):
      (JSC::Structure::createStructure):
      * runtime/StructureChain.h:
      (JSC::StructureChain::create):
      * testRegExp.cpp:
      (GlobalObject::create):
      * wtf/BitVector.cpp:
      (WTF::BitVector::OutOfLineBits::create): Use the NotNull version of placement
      new to skip the NULL check.
      
      * wtf/BumpPointerAllocator.h:
      (WTF::BumpPointerPool::create): Standardized spacing to make grep easier.
      
      * wtf/ByteArray.cpp:
      (WTF::ByteArray::create):
      * wtf/Deque.h:
      (WTF::::append):
      (WTF::::prepend): Use NotNull, as above.
      
      * wtf/FastAllocBase.h: Added a placement new, since this class would otherwise
      hide the name of the global placement new.
      
      (WTF::fastNew): Standardized spacing. Most of these functions don't need
      NotNull, since they check for NULL, and the optimizer can see that.
      
      * wtf/HashTable.h:
      * wtf/HashTraits.h:
      (WTF::SimpleClassHashTraits::constructDeletedValue):
      * wtf/MetaAllocator.cpp:
      (WTF::MetaAllocator::allocFreeSpaceNode): NotNull, as above.
      
      * wtf/StdLibExtras.h:
      (throw): This is our NotNull placement new. Declaring that we throw is
      the C++ way to say that operator new will not return NULL.
      
      * wtf/ThreadSpecific.h:
      (WTF::T):
      * wtf/Vector.h:
      (WTF::::append):
      (WTF::::tryAppend):
      (WTF::::uncheckedAppend):
      (WTF::::insert):
      * wtf/text/AtomicStringHash.h:
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::createUninitialized):
      (WTF::StringImpl::reallocate):
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::tryCreateUninitialized):
      * wtf/text/StringStatics.cpp:
      (WTF::AtomicString::init): Use NotNull, as above.
      
      * yarr/YarrInterpreter.cpp:
      (JSC::Yarr::Interpreter::allocDisjunctionContext):
      (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext):
      (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): Standardized
      spacing for easy grep.
      
      Source/WebCore: 
      
      * bindings/js/JSImageConstructor.h:
      (WebCore::JSImageConstructor::create):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateConstructorDeclaration):
      * bridge/c/CRuntimeObject.h:
      (JSC::Bindings::CRuntimeObject::create):
      * bridge/c/c_instance.cpp:
      (JSC::Bindings::CRuntimeMethod::create):
      * bridge/jni/jsc/JavaInstanceJSC.cpp:
      (JavaRuntimeMethod::create):
      * bridge/jni/jsc/JavaRuntimeObject.h:
      (JSC::Bindings::JavaRuntimeObject::create):
      * bridge/objc/ObjCRuntimeObject.h:
      (JSC::Bindings::ObjCRuntimeObject::create):
      * bridge/objc/objc_instance.mm:
      (ObjCRuntimeMethod::create):
      * bridge/objc/objc_runtime.h:
      (JSC::Bindings::ObjcFallbackObjectImp::create):
      * bridge/runtime_array.h:
      (JSC::RuntimeArray::create):
      * bridge/runtime_method.h:
      (JSC::RuntimeMethod::create):
      * bridge/runtime_object.h:
      (JSC::Bindings::RuntimeObject::create):
      * dom/Document.h:
      (WebCore::FormElementKeyHashTraits::constructDeletedValue): Use NotNull
      placement new, as in JavaScriptCore.
      
      * platform/PODArena.h:
      (WebCore::PODArena::allocateObject): No need to check for NULL explicitly,
      since that's the built-in behavior of placement new.
      
      * platform/graphics/FontCache.cpp:
      (WebCore::FontDataCacheKeyTraits::constructDeletedValue):
      * platform/graphics/IntRectHash.h:
      * platform/graphics/IntSizeHash.h: More NotNull.
      
      * rendering/RenderObject.h: Declaring that we throw is the C++ way to say
      that operator new will not return NULL.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      215589e0
    • eric.carlson@apple.com's avatar
      Render text tracks · 3d191a0f
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=62886
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Test: media/track/track-cue-rendering.html
      
      * css/mediaControls.css:
      (video::-webkit-media-text-track-container):
      (video::-webkit-media-text-track-display):
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_haveVisibleTextTrack.
      (WebCore::HTMLMediaElement::updateActiveTextTrackCues): Trigger an update of the text
          track display.
      (WebCore::HTMLMediaElement::textTrackModeChanged): call configureTextTrackDisplay() so 
          the text track display is hidden or shown when necessary.
      (WebCore::HTMLMediaElement::userIsInterestedInThisTrack): Minor cleanup.
      (WebCore::HTMLMediaElement::createMediaControls): configureMediaControls() always called
          reset after creating the controls, do it here instead.
      (WebCore::HTMLMediaElement::configureMediaControls): Simplify and cleanup.
      (WebCore::HTMLMediaElement::configureTextTrackDisplay): Show and hide text track display.
      * html/HTMLMediaElement.h:
      (WebCore::HTMLMediaElement::currentlyVisibleCues):
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::RenderTextTrackContainerElement::RenderTextTrackContainerElement): New.
      (WebCore::RenderTextTrackContainerElement::layout): New. Call the display element so it can
          update the position and font size.
      (WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): New.
      (WebCore::MediaControlTextTrackContainerElement::create): Ditto.
      (WebCore::MediaControlTextTrackContainerElement::createRenderer): Ditto.
      (WebCore::MediaControlTextTrackContainerElement::shadowPseudoId): Ditto.
      (WebCore::MediaControlTextTrackContainerElement::updateSizes): Keep the cue display element
          positioned above the bottom of the video box, and size the font according to the video height.
      (WebCore::MediaControlTextTrackDisplayElement::MediaControlTextTrackDisplayElement): New.
      (WebCore::MediaControlTextTrackDisplayElement::create): Ditto.
      (WebCore::MediaControlTextTrackDisplayElement::shadowPseudoId): Ditto.
      * html/shadow/MediaControlElements.h:
      (WebCore::MediaControlTextTrackContainerElement::displayType):
      (WebCore::MediaControlTextTrackDisplayElement::displayType):
      
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::MediaControlRootElement): New.
      (WebCore::MediaControlRootElement::setMediaController): Ditto.
      (WebCore::MediaControlRootElement::createTextTrackDisplay): Ditto.
      (WebCore::MediaControlRootElement::showTextTrackDisplay): Ditto.
      (WebCore::MediaControlRootElement::hideTextTrackDisplay): Ditto.
      (WebCore::MediaControlRootElement::updateTextTrackDisplay): Ditto.
      * html/shadow/MediaControlRootElement.h:
      
      * html/shadow/MediaControlRootElementChromium.cpp:
      (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium): New.
      (WebCore::MediaControlRootElement::createTextTrackDisplay): Ditto.
      (WebCore::MediaControlRootElement::showTextTrackDisplay): Ditto.
      (WebCore::MediaControlRootElement::hideTextTrackDisplay): Ditto.
      (WebCore::MediaControlRootElement::updateTextTrackDisplay): Ditto.
      * html/shadow/MediaControlRootElementChromium.h:
      * html/shadow/MediaControls.h:
      
      LayoutTests: 
      
      * media/media-controls.js:
      (mediaControlsElement): Don't always look for a controller element.
      (mediaControlsButtonCoordinates):
      (textTrackDisplayElement): Find the cue display element.
      
      * media/track/track-cue-rendering-expected.txt: Added.
      * media/track/track-cue-rendering.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d191a0f
    • ossy@webkit.org's avatar
      [Qt] Test fonts are not used with Qt5 · 068d36cf
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72513
      
      * platform/qt-5.0/Skipped: Unskip now passing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      068d36cf
    • eric.carlson@apple.com's avatar
      Enable <track> for Mac build · a717c8c2
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=74838
      
      Reviewed by Darin Adler.
      
      Source/JavaScriptCore: 
      
      * wtf/Platform.h:
      
      Source/WebCore: 
      
      * Configurations/FeatureDefines.xcconfig:
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      
      Source/WebKit/mac: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a717c8c2
    • ossy@webkit.org's avatar
      [Qt] Test fonts are not used with Qt5 · bb5fdc48
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72513
      
      * platform/qt-5.0/Skipped: Unskip now passing tests.
      * platform/qt-wk2/Skipped: Skip unskipped qt-5.0 tests fail on qt-wk2.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb5fdc48
    • caio.oliveira@openbossa.org's avatar
      [Qt] [WK2] Fix build error due to unused variables · 512c817e
      caio.oliveira@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74862
      
      Reviewed by Kenneth Rohde Christiansen.
      
      * UIProcess/qt/QtWebPageEventHandler.cpp:
      (QtWebPageEventHandler::inputMethodEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      512c817e
    • kenneth@webkit.org's avatar
      Source/WebCore: Make the Editor::setIgnoreCompositionSelectionChange public as it is needed by Qt · 84fb4924
      kenneth@webkit.org authored
      Reviewed by Simon Hausmann.
      
      * editing/Editor.h:
      
      Source/WebKit2: [Qt] Add methods for setting, cancelling and confirming the composition
      
      Reviewed by Simon Hausmann.
      
      * UIProcess/WebPageProxy.h:
      * UIProcess/qt/WebPageProxyQt.cpp:
      (WebKit::WebPageProxy::setComposition):
      (WebKit::WebPageProxy::confirmComposition):
      (WebKit::WebPageProxy::cancelComposition):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/qt/WebPageQt.cpp:
      (WebKit::targetFrameForEditing):
      (WebKit::WebPage::confirmComposition):
      (WebKit::WebPage::setComposition):
      (WebKit::WebPage::cancelComposition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84fb4924
    • apavlov@chromium.org's avatar
      Web Inspector: Implement CSS selector profiler backend · ba905e87
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74603
      
      Reviewed by Pavel Feldman.
      
      No new tests, as the changed code does not result in visible effects yet.
      
      * inspector/Inspector.json:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::RuleMatchingStats::RuleMatchingStats):
      (WebCore::SelectorProfile::SelectorProfile):
      (WebCore::SelectorProfile::~SelectorProfile):
      (WebCore::SelectorProfile::totalMatchingTimeMs):
      (WebCore::SelectorProfile::startSelector):
      (WebCore::SelectorProfile::commitSelector):
      (WebCore::SelectorProfile::commitSelectorTime):
      (WebCore::SelectorProfile::toInspectorObject):
      (WebCore::InspectorCSSAgent::clearFrontend):
      (WebCore::InspectorCSSAgent::restore):
      (WebCore::InspectorCSSAgent::startSelectorProfiler):
      (WebCore::InspectorCSSAgent::stopSelectorProfiler):
      (WebCore::InspectorCSSAgent::willMatchRule):
      (WebCore::InspectorCSSAgent::didMatchRule):
      (WebCore::InspectorCSSAgent::willProcessRule):
      (WebCore::InspectorCSSAgent::didProcessRule):
      * inspector/InspectorCSSAgent.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba905e87
    • apavlov@chromium.org's avatar
      Web Inspector: Status bar button glyph for the "Record" buttons broken · cc2e0ee0
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74861
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/inspector.css:
      (.record-cpu-profile-status-bar-item .glyph, .record-profile-status-bar-item .glyph):
      (.record-cpu-profile-status-bar-item.toggled-on .glyph, .record-profile-status-bar-item.toggled-on .glyph):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc2e0ee0
    • kubo@profusion.mobi's avatar
      [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm · 45204b59
      kubo@profusion.mobi authored
      https://bugs.webkit.org/show_bug.cgi?id=74854
      
      Reviewed by Csaba Osztrogonác.
      
      Since r101052, libewebkit.so is built in a different location, so we
      need to adjust the path returned by builtDylibPathForName.
      
      usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
      port also respects Release/Debug configurations.
      
      These changes should make run-launcher finally work correctly with
      webkit-efl.
      
      * Scripts/webkitdirs.pm:
      (usesPerConfigurationBuildDirectory):
      (builtDylibPathForName):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45204b59
    • kenneth@webkit.org's avatar
      First stab at upstreaming our virtual keyboard code · c216d1b4
      kenneth@webkit.org authored
      Reviewed by Simon Hausmann.
      
      Add basic implementation of inputMethodEvent
      
      * UIProcess/qt/QtWebPageEventHandler.cpp:
      (QtWebPageEventHandler::handleEvent):
      (QtWebPageEventHandler::inputMethodEvent):
      * UIProcess/qt/QtWebPageEventHandler.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c216d1b4
    • commit-queue@webkit.org's avatar
      [Qt] Cleanup QTM_NAMESPACE usage in DeviceOrientationProviderQt · f998fd47
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74853
      
      Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-19
      Reviewed by Simon Hausmann.
      
      * Api/qwebframe_p.h:
      * WebCoreSupport/DeviceOrientationProviderQt.cpp:
      * WebCoreSupport/DeviceOrientationProviderQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f998fd47
    • pfeldman@chromium.org's avatar
      Web Inspector: only the first @rule is highlighted in CSS · 94c1d0e7
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74568
      
      Patch by Pavel Feldman <pavel.feldman@gmail.com> on 2011-12-19
      Reviewed by Timothy Hatcher.
      
      * inspector/front-end/SourceCSSTokenizer.js:
      (WebInspector.SourceCSSTokenizer.prototype.nextToken):
      * inspector/front-end/SourceCSSTokenizer.re2js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94c1d0e7
    • commit-queue@webkit.org's avatar
      [Qt] Cleanup DeviceMotionClientQt and friends. · ae2f8887
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74849
      
      This patch cleans up the DeviceMotionQt class and friends by applying
      the following changes:
      
      - Remove unnecessary pointer to QWebPage. This is needed to be able to
        reuse the code for WebKit2.
      - Remove QObject dependencies and all signals/slots. Instead, we call
        didChangeDeviceMotion() on the controller directly from
        DeviceMotionProviderQt.
      
      Patch by Alexander Færøy <ahf@0x90.dk> on 2011-12-19
      Reviewed by Simon Hausmann.
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::QWebPagePrivate):
      * WebCoreSupport/DeviceMotionClientQt.cpp:
      (WebCore::DeviceMotionClientQt::DeviceMotionClientQt):
      (WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):
      (WebCore::DeviceMotionClientQt::setController):
      * WebCoreSupport/DeviceMotionClientQt.h:
      * WebCoreSupport/DeviceMotionProviderQt.cpp:
      (WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
      (WebCore::DeviceMotionProviderQt::setController):
      (WebCore::DeviceMotionProviderQt::filter):
      * WebCoreSupport/DeviceMotionProviderQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae2f8887
    • loislo@chromium.org's avatar
      Web Inspector: Feature Request: Able to remove all breakpoints. · 4b302265
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63055
      
      Reviewed by Pavel Feldman.
      
      * English.lproj/localizedStrings.js:
      * inspector/front-end/BreakpointManager.js:
      (WebInspector.BreakpointManager.prototype.removeAllBreakpoints):
      * inspector/front-end/BreakpointsSidebarPane.js:
      (WebInspector.JavaScriptBreakpointsSidebarPane):
      (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):
      (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):
      * inspector/front-end/DebuggerPresentationModel.js:
      (WebInspector.DebuggerPresentationModel.prototype.removeAllBreakpoints):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b302265
    • hausmann@webkit.org's avatar
      [Qt][WK2] Add support for modal event loop processing for WTR... · 06440a68
      hausmann@webkit.org authored
      [Qt][WK2] Add support for modal event loop processing for WTR https://bugs.webkit.org/show_bug.cgi?id=74852
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Add support for nested event loops, used by WebPage::runModal().
      
      * Platform/qt/RunLoopQt.cpp:
      (RunLoop::run):
      (RunLoop::stop):
      
      Tools:
      
      Rewrote event loop processing: Instead of terminating the event loop
      in notifyDone() - something no other platform does - we now respect the
      "bool& condition" parameter passed to platformRunUntil. This ensures
      proper termination even when the condition is changed from within a
      nested event loop, because only when we _exit_ from the nested event
      loop we will check the condition and terminate the test properly.
      
      In addition this patch implements TestController::runModal by means of
      a nested event loop, which is passed to the platform webview that is
      supposed to be modal. It is that view's responsibility to exit the
      loop, upon destruction. I believe that's similar to how it works on the Mac,
      where it doesn't seem that NSApp's runModalForWindow is terminate via
      abort/stopModal but simply because the window is closed.
      
      * WebKitTestRunner/PlatformWebView.h:
      (WTR::PlatformWebView::setModalEventLoop):
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::PlatformWebView::PlatformWebView):
      (WTR::PlatformWebView::~PlatformWebView):
      * WebKitTestRunner/qt/TestControllerQt.cpp:
      (WTR::TestController::notifyDone):
      (WTR::TestController::platformRunUntil):
      (WTR::TestController::runModal):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06440a68
    • benjamin@webkit.org's avatar
      Build fix for ScrollingCoordinatorMac.mm when building on a case sensitive system · 7db6c156
      benjamin@webkit.org authored
      Unreviewed build fix for r103180. StdlibExtras.h->StdLibExtras.h to compile on case sensitive system.
      
      * page/mac/ScrollingCoordinatorMac.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7db6c156
    • mnaganov@chromium.org's avatar
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening. · 8946bf4b
      ossy@webkit.org authored
      * platform/qt/Skipped: Skip a new failing test.
      * platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r103217.
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r103217.
      * platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated after r103217.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8946bf4b
    • haraken@chromium.org's avatar
      Remove unnecessary [JSCCustomGetter] IDLs from DOMWindow.idl · 0329d640
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74829
      
      Reviewed by Adam Barth.
      
      Now JSC has implemented the [Constructor] IDL and it generates
      getDOMConstructor() automatically. This patch removes hand-written
      unnecessary getDOMConstructor()s from JSDOMWindowCustom.cpp.
      
      No new tests. No change in behavior.
      
      * bindings/js/JSDOMWindowCustom.cpp:
      * page/DOMWindow.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0329d640
    • abarth@webkit.org's avatar
      The HTML parser doesn't enforce the "Noah's Ark condition" from the HTML5 spec · 22b1b0a3
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74828
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      This patch implement the "Noah's Ark condition" from the HTML5
      specification.  This condition limits the number of identitical
      elements that can be in the list of active formatting elements.  I'm not
      entirely sure that enforcing this condition is worth the complexity,
      but given that we've come this far in support of the HTML5 parsing
      algorithm, we might as well finish it.
      
      After this patch, we pass all but one of the html5lib parsing tests!
      
      Tests: html5lib/runner.html
      
      * html/parser/HTMLFormattingElementList.cpp:
      (WebCore::attributeCount):
      (WebCore::HTMLFormattingElementList::append):
      (WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
      (WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):
      * html/parser/HTMLFormattingElementList.h:
      
      LayoutTests:
      
      Show test progression.
      
      * fast/parser/residual-style-dom-expected.txt:
          - This isn't a great test because it's hard to see how changes
            affect the output.  However, we have good coverage of these
            topics in the HTML5lib tests.
      * html5lib/runner-expected.txt:
      * platform/chromium/html5lib/runner-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22b1b0a3
    • commit-queue@webkit.org's avatar
      Add support for 8 bits strings to Document::isValidName() · 44da6440
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74784
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-19
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Avoid the conversion to 16bits when we are in the ASCII fast path,
      otherwise fallback to the Unicode testing in 16bits.
      
      * dom/Document.cpp:
      (WebCore::isValidNameASCII):
      (WebCore::Document::isValidName):
      
      LayoutTests:
      
      Add tests for valid and invalid names for nodes.
      
      * fast/dom/Document/createElement-invalid-names-expected.txt: Added.
      * fast/dom/Document/createElement-invalid-names.html: Added.
      * fast/dom/Document/createElement-valid-names-expected.txt: Added.
      * fast/dom/Document/createElement-valid-names.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44da6440
    • haraken@chromium.org's avatar
      REGRESSION(r101445): [JSC] Generated code for custom getters and setters · 72a70b22
      haraken@chromium.org authored
      with the [Supplemental] IDL is wrong
      https://bugs.webkit.org/show_bug.cgi?id=74837
      
      Reviewed by Darin Adler.
      
      In bug 73162, we implemented the [Supplemental] IDL, but the generated code
      for custom getters and setters was wrong in JSC. This patch fixes CodeGeneratorJS.pm
      so that the result of WebCore/bindings/scripts/test/TestInterface.idl becomes as follows:
      
      Wrong:
          JSValue jsTestInterfaceStr3(ExecState* exec, JSValue slotBase, const Identifier&)
          {
              JSTestInterface* castedThis = static_cast<JSTestInterface*>(asObject(slotBase));
              return JSTestSupplemental::str3(castedThis, exec);
          }
      
      Correct:
          JSValue jsTestInterfaceStr3(ExecState* exec, JSValue slotBase, const Identifier&)
          {
              JSTestInterface* castedThis = static_cast<JSTestInterface*>(asObject(slotBase));
              TestInterface* imp = static_cast<TestInterface*>(castedThis->impl());
              return castedThis->str3(imp, exec);
          }
      
      Tests: bindings/scripts/test/JS/TestInterface.idl
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests result.
      (WebCore::jsTestInterfaceStr3):
      (WebCore::setJSTestInterfaceStr3):
      * bindings/scripts/test/JS/JSTestInterface.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72a70b22
  2. 18 Dec, 2011 17 commits
    • commit-queue@webkit.org's avatar
      A test that mutation happens when asynchronous spell checking is in process. · 4579b9c5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72940
      
      Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-18
      Reviewed by Hajime Morita.
      
      Added a test that mutation happens when spellchecking.
      This test confirms crash won't happen, and how markers are used.
      
      * editing/spelling/spellcheck-async-mutation-expected.txt: Added.
      * editing/spelling/spellcheck-async-mutation.html: Added.
      * platform/gtk/Skipped:
      * platform/mac-leopard/Skipped:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4579b9c5
    • abarth@webkit.org's avatar
      Fix typo in comment. · 50021968
      abarth@webkit.org authored
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50021968
    • fpizlo@apple.com's avatar
      DFG is too sloppy with register allocation · 390f57c6
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=74835
      
      Reviewed by Gavin Barraclough.
              
      Added assertions that at the end of a successfully generated basic block,
      all use counts should be zero. This revealed a number of bugs:
              
      - Array length optimizations were turning a must-generate node into one
        that is not must-generate, but failing to change the ref count
        accordingly.
                
      - Indexed property storage optimizations were failing to deref their
        children, or to deref the indexed property storage node itself. Also,
        they used the Phantom node as a replacement. But the Phantom node is
        must-generate, which was causing bizarre issues. So this introduces a
        Nop node, which should be used in cases where you want a node that is
        skipped and has no children.
                
      This does not have any significant performance effect, but it should
      relieve some register pressure. The main thing this patch adds, though,
      are the assertions, which should make it easier to do register allocation
      related changes in the future.
      
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::execute):
      * dfg/DFGGenerationInfo.h:
      (JSC::DFG::GenerationInfo::initConstant):
      (JSC::DFG::GenerationInfo::initInteger):
      (JSC::DFG::GenerationInfo::initJSValue):
      (JSC::DFG::GenerationInfo::initCell):
      (JSC::DFG::GenerationInfo::initBoolean):
      (JSC::DFG::GenerationInfo::initDouble):
      (JSC::DFG::GenerationInfo::initStorage):
      (JSC::DFG::GenerationInfo::use):
      * dfg/DFGGraph.h:
      (JSC::DFG::Graph::clearAndDerefChild1):
      (JSC::DFG::Graph::clearAndDerefChild2):
      (JSC::DFG::Graph::clearAndDerefChild3):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::deref):
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      (JSC::DFG::Propagator::fixupNode):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      390f57c6
    • darin@apple.com's avatar
      Fixed some test expectations the best I could using my Lion machine. · cd90668c
      darin@apple.com authored
      Some of these may require additional tuning.
      
      * fast/dom/Window/script-tests/window-property-descriptors.js: Added webkitNotifications to the list of properties
      to not dump, since it's different in different configurations. Also re-sorted the list and improved comments.
      * fast/dom/Window/window-properties.html: Ditto.
      * fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
      
      * platform/mac/fast/dom/Window/window-properties-expected.txt: Updated for the change in WebKitCSSFilterValue constants.
      * platform/win/fast/dom/Window/window-properties-expected.txt: Ditto.
      
      * platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.png: Removed.
      * platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.txt: Removed.
      * platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png: Removed.
      * platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.txt: Removed.
      * platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.png: Removed.
      * platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.txt: Removed.
      * platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.png: Removed.
      * platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.txt: Removed.
      * platform/mac-snowleopard/printing: Removed.
      * platform/mac-snowleopard/printing/width-overflow-expected.png: Removed.
      * platform/mac-snowleopard/printing/width-overflow-expected.txt: Removed.
      * platform/mac/fast/regions/region-style-block-background-color-expected.png: Copied from platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.png.
      * platform/mac/fast/regions/region-style-block-background-color-expected.txt: Copied from platform/mac-snowleopard/fast/regions/region-style-block-background-color-expected.txt.
      * platform/mac/fast/regions/region-style-block-background-color2-expected.png: Copied from platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png.
      * platform/mac/fast/regions/region-style-block-background-color2-expected.txt: Copied from platform/mac-snowleopard/fast/regions/region-style-block-background-color2-expected.txt.
      * platform/mac/fast/regions/region-style-image-background-color-expected.png: Copied from platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.png.
      * platform/mac/fast/regions/region-style-image-background-color-expected.txt: Copied from platform/mac-snowleopard/fast/regions/region-style-image-background-color-expected.txt.
      * platform/mac/fast/regions/region-style-inline-background-color-expected.png: Copied from platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.png.
      * platform/mac/fast/regions/region-style-inline-background-color-expected.txt: Copied from platform/mac-snowleopard/fast/regions/region-style-inline-background-color-expected.txt.
      * platform/mac/printing/width-overflow-expected.png: Copied from platform/mac-snowleopard/printing/width-overflow-expected.png.
      * platform/mac/printing/width-overflow-expected.txt: Copied from platform/mac-snowleopard/printing/width-overflow-expected.txt.
      Moved these test results from mac-snowleopard to mac. There's no reason to assume the results are
      different post-Snow-Leopard.
      
      * platform/mac/fast/text/unicode-variation-selector-expected.txt: Added.
      Landed the result generated on my computer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd90668c
    • morrita@google.com's avatar
      Unreviewed expectations update. · c3b6938c
      morrita@google.com authored
      * platform/chromium-win-xp/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
      * platform/chromium-win-xp/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
      * platform/chromium-win-xp/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
      * platform/chromium-win-xp/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
      * platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
      * platform/chromium-win-xp/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
      * platform/chromium-win-xp/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
      * platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
      * platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
      * platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
      * platform/chromium-win-xp/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
      * platform/chromium-win-xp/svg/text/bidi-tspans-expected.png: Added.
      * platform/chromium-win-xp/tables/mozilla/bugs/bug2479-4-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3b6938c
    • keishi@webkit.org's avatar
      Implement <input type=color> UI WebKit chromium part · 3fa5b866
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65897
      
      Reviewed by Darin Fisher.
      
      Source/WebCore:
      
      * GNUmakefile.list.am: Removed ColorChooser.cpp and added ColorChooserClient.h
      * WebCore.gypi: Added ColorChooser.h and ColorChooserClient.h
      * WebCore.xcodeproj/project.pbxproj: Removed ColorChooser.cpp and added ColorChooserClient.h
      
      Source/WebKit/chromium:
      
      * WebKit.gyp: Added new files.
      * features.gypi: Added ENABLE_INPUT_COLOR.
      * public/WebColorChooser.h: Added. Interface for ColorChooserProxy to call.
      (WebKit::WebColorChooser::~WebColorChooser):
      (WebKit::WebColorChooser::setSelectedColor):
      (WebKit::WebColorChooser::endChooser):
      * public/WebColorChooserClient.h: Added.
      (WebKit::WebColorChooserClient::~WebColorChooserClient):
      (WebKit::WebColorChooserClient::didChooseColor): Only called when user changes the color.
      (WebKit::WebColorChooserClient::didEndChooser): Called when WebColorChooser::endChooser is called.
      * public/WebViewClient.h:
      (WebKit::WebViewClient::createColorChooser): Creates a new color chooser. If there is an old color chooser, this will end it.
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::createColorChooser): Calls WebViewClient::createColorChooser.
      * src/ChromeClientImpl.h:
      * src/ColorChooserProxy.cpp: Proxies calls to WebCore::ColorChooser to WebKit::WebColorChooser.
      (WebKit::ColorChooserProxy::ColorChooserProxy):
      (WebKit::ColorChooserProxy::~ColorChooserProxy):
      (WebKit::ColorChooserProxy::setSelectedColor):
      (WebKit::ColorChooserProxy::endChooser):
      * src/ColorChooserProxy.h:
      * src/WebColorChooserClientImpl.cpp: Proxies calls to WebKit::WebColorChooserClient to WebCore::ColorChooserClient.
      (WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl):
      (WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl):
      (WebKit::WebColorChooserClientImpl::didChooseColor):
      (WebKit::WebColorChooserClientImpl::didEndChooser):
      * src/WebColorChooserClientImpl.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fa5b866
    • morrita@google.com's avatar
      Unreviewed test_expectations.txt update. · cdb68442
      morrita@google.com authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdb68442
    • commit-queue@webkit.org's avatar
      <msup>, <munder>, <mover>, and <munderover> baseline positions are wrong · 9220be84
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72821
      
      Patch by David Barton <dbarton@mathscribe.com> on 2011-12-18
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Tested by rebaselining 8 existing tests. (Pardon the pun.)
      
      * rendering/mathml/RenderMathMLSubSup.cpp:
      (WebCore::RenderMathMLSubSup::baselinePosition):
      Just using the base's (these puns are not my fault) baseline did not leave room for the exponent.
      * rendering/mathml/RenderMathMLUnderOver.cpp:
      (WebCore::RenderMathMLUnderOver::baselinePosition):
      Added a guard condition, and removed some bad lines apparently mistakenly copied from RenderMathMLSubSup.cpp.
      
      LayoutTests:
      
      * platform/mac/mathml/presentation/msup-base-changed-expected.png:
      * platform/mac/mathml/presentation/msup-base-changed-expected.txt:
      * platform/mac/mathml/presentation/msup-sup-changed-expected.png:
      * platform/mac/mathml/presentation/msup-sup-changed-expected.txt:
      * platform/mac/mathml/presentation/over-expected.png:
      * platform/mac/mathml/presentation/over-expected.txt:
      * platform/mac/mathml/presentation/roots-expected.png:
      * platform/mac/mathml/presentation/roots-expected.txt:
      * platform/mac/mathml/presentation/row-alignment-expected.png:
      * platform/mac/mathml/presentation/row-alignment-expected.txt:
      * platform/mac/mathml/presentation/sup-expected.png:
      * platform/mac/mathml/presentation/sup-expected.txt:
      * platform/mac/mathml/presentation/under-expected.png:
      * platform/mac/mathml/presentation/under-expected.txt:
      * platform/mac/mathml/presentation/underover-expected.png:
      * platform/mac/mathml/presentation/underover-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9220be84
    • macpherson@chromium.org's avatar
      Implement CSS line-height property in CSSStyleApplyProperty. · 70a7e6bd
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74561
      
      Reviewed by Andreas Kling.
      
      No new tests / refactoring only.
      
      * css/CSSPrimitiveValue.h:
      (WebCore::CSSPrimitiveValue::isNumber):
      * css/CSSStyleApplyProperty.cpp:
      (WebCore::ApplyPropertyLineHeight::applyValue):
      (WebCore::ApplyPropertyLineHeight::createHandler):
      (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70a7e6bd
    • macpherson@chromium.org's avatar
      Implement CSS outline shorthand property in CSSStyleApplyProperty. · e634aff6
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74467
      
      Reviewed by Andreas Kling.
      
      No new tests / refactoring only.
      
      RenderStyle::resetOutline was removed in favor of explicity expanding to the
      initial values of the shorthand expansion. This improves consistency because
      the initial values to use are more clearly (and singularly) defined.
      
      * css/CSSStyleApplyProperty.cpp:
      (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      * rendering/style/RenderStyle.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e634aff6
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r103205. · a8b91f11
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/103205
      https://bugs.webkit.org/show_bug.cgi?id=74833
      
      There are valid characters above 0x80 when the  string is
      8bits (Requested by benjaminp on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-18
      
      * dom/Document.cpp:
      (WebCore::isValidNameASCII):
      (WebCore::Document::isValidName):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8b91f11
    • macpherson@chromium.org's avatar
      Separate box alignment and box pack values into separate enums. · 3eb5dba5
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74580
      
      Reviewed by Andreas Kling.
      
      No new tests / refactoring only.
      
      Separating these types cleans up the code by removing several assertions that
      values are in the correct ranges, as this is ensured by the type system.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator EBoxPack):
      (WebCore::CSSPrimitiveValue::operator EBoxAlignment):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
      (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
      * rendering/RenderFullScreen.cpp:
      (createFullScreenStyle):
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::boxPack):
      (WebCore::InheritedFlags::setBoxAlign):
      (WebCore::InheritedFlags::setBoxPack):
      (WebCore::InheritedFlags::initialBoxPack):
      * rendering/style/RenderStyleConstants.h:
      * rendering/style/StyleDeprecatedFlexibleBoxData.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3eb5dba5
    • macpherson@chromium.org's avatar
      Implement CSS font-size property in CSSStyleApplyProperty. · 37d83c52
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74368
      
      Reviewed by Andreas Kling.
      
      No new tests / refactoring only.
      
      * css/CSSStyleApplyProperty.cpp:
      (WebCore::ApplyPropertyFontSize::largerFontSize):
      (WebCore::ApplyPropertyFontSize::smallerFontSize):
      (WebCore::ApplyPropertyFontSize::applyInheritValue):
      (WebCore::ApplyPropertyFontSize::applyInitialValue):
      (WebCore::ApplyPropertyFontSize::applyValue):
      (WebCore::ApplyPropertyFontSize::createHandler):
      (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      * css/CSSStyleSelector.h:
      (WebCore::CSSStyleSelector::hasParentNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37d83c52
    • kling@webkit.org's avatar
      Unreviewed, rolling out r103199. · cdff2ca1
      kling@webkit.org authored
      http://trac.webkit.org/changeset/103199
      https://bugs.webkit.org/show_bug.cgi?id=74832
      
      Caused a bot crashiness extravaganza! (Requested by kling on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-18
      
      * platform/KURL.cpp:
      (WebCore::isLetterMatchIgnoringCase):
      (WebCore::protocolIs):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdff2ca1
    • mitz@apple.com's avatar
      Positioned Floats: Assertion hit in... · d67fb21e
      mitz@apple.com authored
      Positioned Floats: Assertion hit in fast/block/positioning/positioned-float-layout-after-image-load.html
      https://bugs.webkit.org/show_bug.cgi?id=67759
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: fast/block/positioning/positioned-float-layout-after-image-load.html
      
      Positioned floats are both floating and positioned. Made the following functions treat them as
      positioned rather than as floats by reordering code.
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace):
      (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
      (WebCore::RenderBlock::LineBreaker::nextLineBreak):
      
      LayoutTests: 
      
      Re-added this test from r94695.
      
      * fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Copied from LayoutTests/fast/block/positioning/positioned-float-layout-after-image-load-expected.txt.
      * fast/block/positioning/positioned-float-layout-after-image-load.html: Copied from LayoutTests/fast/block/positioning/positioned-float-layout-after-image-load.html.
      * fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Copied from LayoutTests/fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d67fb21e
    • benjamin@webkit.org's avatar
      Add support for 8 bits strings to Document::isValidName() · 163ad054
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74784
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-18
      Reviewed by Andreas Kling.
      
      The valid name has a fast path for ASCII, and a slow path
      taking Unicode characters into account.
      
      For 8-bit strings, we don't need to take the non-ASCII path
      as it could never succeed if the ASCII path didn't.
      
      * dom/Document.cpp:
      (WebCore::isValidNameASCII):
      (WebCore::Document::isValidName):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      163ad054
    • morrita@google.com's avatar
      Unreviewed expectations update. · 26f85ced
      morrita@google.com authored
      * platform/chromium-cg-mac-snowleopard/fast/text/drawBidiText-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/text/drawBidiText-expected.png.
      * platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/drawBidiText-expected.png.
      * platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-4-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.png.
      * platform/chromium-win-vista/fast/text/drawBidiText-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
      * platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
      * platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
      * platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.png: Removed.
      * platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
      * platform/chromium-win-vista/svg/text/bidi-tspans-expected.png: Removed.
      * platform/chromium-win-vista/svg/text/bidi-tspans-expected.txt:
      * platform/chromium-win-vista/tables/mozilla/bugs/bug2479-4-expected.png: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26f85ced