Commits · 21368dd43e80709646feecd0fbedfdfe94adfcb4 · App_Technologies / webkit

13 Jun, 2007 29 commits

darin authored Jun 14, 2007

        Reviewed by Mark Rowe.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14132
          array sort with > 10000 elements sets elements > 10000 undefined

        Test: fast/js/sort-large-array.html

        * kjs/array_instance.h: Replaced pushUndefinedObjectsToEnd with
        compactForSorting, and removed ExecState parameters.

        * kjs/array_object.cpp:
        (ArrayInstance::sort): Changed to call compactForSorting.
        (ArrayInstance::compactForSorting): Do the get and delete of the
        properties directly on the property map instead of using public
        calls from JSObject. The public calls would just read the undefined
        values from the compacted sort results array!

LayoutTests:

        Reviewed by Mark Rowe.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14132
          array sort with > 10000 elements sets elements > 10000 undefined

        * fast/js/resources/sort-large-array.js: Added.
        * fast/js/sort-large-array-expected.txt: Added.
        * fast/js/sort-large-array.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

21368dd4

Fix a crash when a request from the plugin resulted · 897f34f2

lars authored Jun 14, 2007

        in a HTTP redirect.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

897f34f2

Work around a bug in Qt's QHttp implementation and · 30e48ce7

lars authored Jun 14, 2007

        get web pages to load again.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

30e48ce7

Fix Mac OS X build · 15fafbe4

staikos authored Jun 14, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15fafbe4

missed this in my last checkin - obsolete line · bfd5b69c

staikos authored Jun 14, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bfd5b69c

Compile without trying to link ourself. · c62cabb5

staikos authored Jun 14, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c62cabb5

Disable FastMalloc for the Qt build and make sure we · cc7d55ce

lars authored Jun 14, 2007

don't reimplement the global new/delete operators
when using the system malloc.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cc7d55ce

Reviewed by Kevin Decker. · a5dc917c

darin authored Jun 14, 2007

        - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
          +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)

        * platform/mac/WebFontCache.mm:
        (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
        Took out the auto-activation code.
        (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
        then calls NSFont to trigger activation if that returned nil, then calls
        internalFontWithFamily again.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a5dc917c

JavaScriptCore: · 89c5d677

andersca authored Jun 14, 2007

        Reviewed by Geoff.

        Make sure that bindings instances get correct root objects.
        
        * JavaScriptCore.exp:
        * bindings/NP_jsobject.cpp:
        (listFromVariantArgs):
        (_NPN_InvokeDefault):
        (_NPN_Invoke):
        (_NPN_SetProperty):
        * bindings/c/c_instance.cpp:
        (KJS::Bindings::CInstance::invokeMethod):
        (KJS::Bindings::CInstance::invokeDefaultMethod):
        * bindings/c/c_runtime.cpp:
        (KJS::Bindings::CField::valueFromInstance):
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertNPVariantToValue):
        * bindings/c/c_utility.h:
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::invokeMethod):
        (ObjcInstance::invokeDefaultMethod):
        (ObjcInstance::getValueOfUndefinedField):
        * bindings/objc/objc_runtime.mm:
        (ObjcField::valueFromInstance):
        (ObjcArray::valueAt):
        * bindings/objc/objc_utility.h:
        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::convertObjcValueToValue):
        * bindings/runtime.h:

WebCore:

        Reviewed by Geoff.

        Pass the root object to methods that end up creating new ObjcInstance objects.
        
        * bindings/objc/WebScriptObject.mm:
        (listFromNSArray):
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):
        (-[WebScriptObject setValue:forKey:]):
        (-[WebScriptObject valueForKey:]):
        (-[WebScriptObject removeWebScriptKey:]):
        (-[WebScriptObject setWebScriptValueAtIndex:value:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

89c5d677

Reviewed by Darin. · 8b2606e4

andersca authored Jun 13, 2007

        <rdar://problem/5267992>
        Make sure an alert doesn't allow loading to continue inside a script.
        
        Make sure to defer all loads where it's possible for a second main loop to be running.
        
        * page/Chrome.cpp:
        (WebCore::Chrome::runModal):
        (WebCore::Chrome::runBeforeUnloadConfirmPanel):
        (WebCore::Chrome::runJavaScriptAlert):
        (WebCore::Chrome::runJavaScriptConfirm):
        (WebCore::Chrome::runJavaScriptPrompt):
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
        
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::setDefersLoading):
        Implement this.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8b2606e4

Reviewed by Adele Peterson · 534741b0

sullivan authored Jun 13, 2007

        
        - fixed <rdar://problem/5267607> Clicking the "Save to Downloads" button in 
          PDF overlay too soon results in corrupt file

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        Just beep if the document isn't available yet, since trying to save it as a file
        really isn't a good idea.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

534741b0

2007-06-13 Alp Toker <alp.toker@collabora.co.uk> · 3cb4d7c6

bdash authored Jun 13, 2007

        Reviewed by Rob.

        http://bugs.webkit.org/show_bug.cgi?id=14060
        Cairo SVG support

        * WebCore.pro: Add new files to the build.
        * platform/graphics/svg/SVGPaintServerPattern.h:
        * platform/graphics/svg/SVGPaintServerSolid.h:
        * platform/graphics/svg/cairo: Added.
        * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
        (WebCore::RenderPath::strokeContains):
        (WebCore::RenderPath::strokeBBox):
        * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
        (WebCore::SVGPaintServer::draw):
        (WebCore::SVGPaintServer::teardown):
        (WebCore::SVGPaintServer::renderPath):
        * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
        (WebCore::SVGPaintServerGradient::setup):
        * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
        (WebCore::SVGPaintServerPattern::setup):
        * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
        (WebCore::SVGPaintServerSolid::setup):
        * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
        (WebCore::SVGResourceClipper::applyClip):
        * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
        (WebCore::SVGResourceMasker::applyMask):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3cb4d7c6

Fix the build: WebKitQt is now called QtWebKit · c14b0062

hausmann authored Jun 13, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c14b0062

Added a make install target that installs the Qt port and renamed · 4eb8676c

hausmann authored Jun 13, 2007

WebKitQt to QtWebKit


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4eb8676c

Added httpHeaderField setter/getter to QWebNetworkRequest for convenience. · e413f96c
hausmann authored Jun 13, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
e413f96c
Changed QWebObjectPluginConnector::requestUrl to take a QWebNetworkRequest as argument. · 67c83645
hausmann authored Jun 13, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
67c83645

Added a QWebNetworkRequest convenience constructor. · d83c45d3

hausmann authored Jun 13, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d83c45d3

Changed the QWebPage::open(const QUrl &url, const QHttpRequestHeader... · ccd61240

hausmann authored Jun 13, 2007

Changed the QWebPage::open(const QUrl &url, const QHttpRequestHeader &httpHeader, const QByteArray &postData)
overload to take a QWebNetworkRequest instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ccd61240

In QWebPage::open(const QUrl &, const QHttpRequestHeader &, ...) don't make the population · 1182ba0c

hausmann authored Jun 13, 2007

of the WebCore::ResourceRequest depend on the validity of the QHttpRequestHeader but just
pick the individual fields if we can use them.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1182ba0c

Minor QWebNetworkRequet API fixlet · 06cba1a7

hausmann authored Jun 13, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

06cba1a7

Use QWebNetworkRequest for QWebPage::navigationRequested. · 7dfac699

hausmann authored Jun 13, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7dfac699

Some docs for QWebNetworkRequest · d2860e09

hausmann authored Jun 13, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d2860e09

Moved QWebNetworkJob::Method enum into QWebNetworkRequest. · 11c73dbb
hausmann authored Jun 13, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
11c73dbb
Rename QWebNetworkJob::request() into QWebNetworkJob::httpHeader() and added · fde85e8d
hausmann authored Jun 13, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
fde85e8d

Introduce QWebNetworkRequest in the public API. · 7c04428b

hausmann authored Jun 13, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7c04428b

Changed QWebNetworkJobPrivate to aggregate a QWebNetworkRequest instead of inheriting from it. · c27c031f
hausmann authored Jun 13, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
c27c031f
Rename QWebNetworkRequest::request into QWebNetworkRequest::httpHeader. · c21a3e62
hausmann authored Jun 13, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
c21a3e62

Fix one more BITMAPINFO/BITMAPINFOHEADER typo. · d1848e4b

aroben authored Jun 13, 2007

        Rubberstamped by Oliver.

        * platform/win/DragImageWin.cpp:
        (WebCore::allocImage):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d1848e4b

WebCore: · 355136e1

oliver authored Jun 13, 2007

        Reviewed by Darin.

        Use correct size for BITMAPINFOHEADER -- whoops.

        * platform/win/CursorWin.cpp:
        (WebCore::Cursor::Cursor):
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeImage):

WebKit:

        Reviewed by Darin.

        Use correct size for BITMAPINFOHEADER -- whoops.

        * win/WebIconDatabase.cpp:
        (createDIB):
        (WebIconDatabase::getOrCreateDefaultIconBitmap):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

355136e1

12 Jun, 2007 11 commits

Another build fix. · 5835026e

andersca authored Jun 13, 2007

        
        * bindings/qt/qt_instance.cpp:
        (KJS::Bindings::QtInstance::invokeMethod):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5835026e

Reviewed by Geoff. · 60ba4e54

andersca authored Jun 13, 2007

        Move the notion of field type to the JNI runtime since that's the only 
        one that was actually using it.
        
        * bindings/c/c_runtime.h:
        (KJS::Bindings::CField::CField):
        * bindings/jni/jni_runtime.h:
        * bindings/objc/objc_runtime.h:
        * bindings/objc/objc_runtime.mm:
        * bindings/qt/qt_runtime.h:
        * bindings/runtime.h:
        * bindings/runtime_method.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

60ba4e54

Build fix. · 1c920040

andersca authored Jun 13, 2007

        
        * bindings/qt/qt_class.cpp:
        (KJS::Bindings::QtClass::methodsNamed):
        * bindings/qt/qt_instance.cpp:
        (KJS::Bindings::QtInstance::invokeMethod):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1c920040

Fix from Lars to remove duplicate symbols. · 9f86543e

staikos authored Jun 13, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9f86543e

Reviewed by Oliver. · 27856417

andersca authored Jun 13, 2007

        
        Get rid of the MethodList class and use a good ol' Vector instead.

        * bindings/c/c_class.cpp:
        (KJS::Bindings::CClass::methodsNamed):
        * bindings/c/c_instance.cpp:
        (KJS::Bindings::CInstance::invokeMethod):
        * bindings/jni/jni_class.cpp:
        (JavaClass::JavaClass):
        (JavaClass::~JavaClass):
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bindings/objc/objc_class.mm:
        (KJS::Bindings::ObjcClass::methodsNamed):
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::invokeMethod):
        * bindings/objc/objc_runtime.mm:
        (ObjcFallbackObjectImp::callAsFunction):
        * bindings/runtime.cpp:
        * bindings/runtime.h:
        * bindings/runtime_method.cpp:
        (RuntimeMethod::lengthGetter):
        (RuntimeMethod::callAsFunction):
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::getOwnPropertySlot):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

27856417

Reviewed by Geoff. · b7e13e4e

andersca authored Jun 13, 2007

        Make RuntimeMethod's method list a pointer so that the object size doesn't
        grow beyond 32 bytes when we later will replace MethodList with a Vector.
        
        * bindings/runtime_method.cpp:
        (RuntimeMethod::RuntimeMethod):
        (RuntimeMethod::lengthGetter):
        (RuntimeMethod::callAsFunction):
        * bindings/runtime_method.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b7e13e4e

Reviewed by Geoff. · 164cf009

andersca authored Jun 13, 2007

        Get rid of the Parameter class.
        
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bindings/jni/jni_runtime.cpp:
        (JavaMethod::signature):
        * bindings/jni/jni_runtime.h:
        (KJS::Bindings::JavaParameter::JavaParameter):
        (KJS::Bindings::JavaParameter::~JavaParameter):
        (KJS::Bindings::JavaParameter::type):
        (KJS::Bindings::JavaMethod::parameterAt):
        (KJS::Bindings::JavaMethod::numParameters):
        * bindings/runtime.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

164cf009

· 99d488c7

andersca authored Jun 13, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

99d488c7

Build fix. · 9cc63ece

andersca authored Jun 13, 2007

        
        * bindings/qt/qt_class.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9cc63ece

2007-06-12 Mark Rowe <mrowe@apple.com> · f1c12864

bdash authored Jun 13, 2007

        Build fix.

        * bindings/objc/objc_runtime.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f1c12864

Reviewed by Geoff. · 255f15f4

andersca authored Jun 13, 2007

        Get rid of Constructor and its only subclass JavaConstructor.
        
        * bindings/c/c_class.h:
        * bindings/jni/jni_class.cpp:
        (JavaClass::JavaClass):
        (JavaClass::~JavaClass):
        * bindings/jni/jni_class.h:
        * bindings/jni/jni_runtime.cpp:
        * bindings/jni/jni_runtime.h:
        * bindings/objc/objc_class.h:
        * bindings/runtime.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

255f15f4