1. 20 May, 2008 12 commits
    • timothy@apple.com's avatar
      Rename sortFileName{Ascending,Descending} to · 21176464
      timothy@apple.com authored
      sortFunctionName{Ascending,Descending}.
      
      Reviewed by Kevin McCullough.
      
      * JavaScriptCore.exp:
      * kjs/config.h:
      * profiler/Profile.h:
      * profiler/ProfileNode.cpp:
      (KJS::functionNameDescendingComparator):
      (KJS::ProfileNode::sortFunctionNameDescending):
      (KJS::functionNameAscendingComparator):
      (KJS::ProfileNode::sortFunctionNameAscending):
      * profiler/ProfileNode.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21176464
    • darin@apple.com's avatar
      2008-05-20 Darin Adler <darin@apple.com> · f3933de7
      darin@apple.com authored
              Reviewed by Mitz.
      
              - a first small step of CSS DOM refactoring -- the eventual goal is to
                reduce StyleBase and possibly eliminate it, since it has multiple
                purposes and unneccessarily ties many classes together
      
              * css/CSSCursorImageValue.cpp:
              (WebCore::isSVGCursorIdentifier): Mark static so it has internal linkage.
              (WebCore::resourceReferencedByCursorElement): Ditto.
              (WebCore::CSSCursorImageValue::CSSCursorImageValue): Removed unused style
              argument.
              (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Removed code to
              check if X and Y changed before changing them -- there's no reason to do
              that. Removed code that depended on the internals of CSSImageValue. The
              new code uses only protected functions rather than going right at the
              fields and uing internal knowledge of the base class.
              * css/CSSCursorImageValue.h: Added a create function, made constructor
              private, removed unused style argument.
      
              * css/CSSImageValue.cpp:
              (WebCore::CSSImageValue::CSSImageValue): Removed unused style argument.
              (WebCore::CSSImageValue::cachedImageURL): Added. A protected function for
              use by CSSCursorImageValue that gives the URL.
              (WebCore::CSSImageValue::clearCachedImage): Added. A protected function for
              use by CSSCursorImageValue that clears the CachedImage.
              * css/CSSImageValue.h: Added create functions, made constructors protected
              and private, removed unused style argument, made data members private, added
              some protected functions for use by CSSCursorImageValue.
      
              * css/CSSImportRule.cpp:
              (WebCore::CSSImportRule::setCSSStyleSheet): Changed to call checkLoaded on
              the parent. This is part of preparation to move the checkLoaded function from
              StyleBase to StyleSheet.
              (WebCore::CSSImportRule::insertedIntoParent): Changed code to check the URL
              of the style sheet to use the href function of the style sheet rather than
              the baseURL function. This eliminates an O(n^2) algorithm here and reduces
              the use of baseURL, part of preparation to move it from StyleBase
              to CSSStyleSheet.
      
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::setImageProperty): Changed to use create
              function instead of a direct call to new for the CSSImageValue classes.
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue): Ditto.
              (WebCore::CSSParser::parseContent): Ditto.
              (WebCore::CSSParser::parseFillImage): Ditto.
              (WebCore::CSSParser::parseBorderImage): Ditto.
      
              * css/CSSStyleSelector.cpp: Removed unneeded include of CSSImageValue.h.
              * rendering/style/RenderStyle.h: Removed unneeded include of
              CSSCursorImageValue.h, which was causing us to rebuild the world way too often.
      
              * xml/XSLImportRule.cpp:
              (WebCore::XSLImportRule::setXSLStyleSheet): See change to CSSImportRule above.
              (WebCore::XSLImportRule::loadSheet): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3933de7
    • kmccullough@apple.com's avatar
      2008-05-20 Kevin McCullough <kmccullough@apple.com> · fe9d0e7b
      kmccullough@apple.com authored
              Rubber stamped by Adam.
      
              -Minor fix. Should not use a reference since the original may disappear.
      
              * page/Console.cpp:
              (WebCore::Console::profile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe9d0e7b
    • kevino@webkit.org's avatar
      wx build fixes for PluginViewWx.cpp and WebKit/wx/WebView.cpp · 82340bb3
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82340bb3
    • timothy@apple.com's avatar
      Expose the ProfileNode sorting functions on JavaScriptProfileNode. · 5a0204ec
      timothy@apple.com authored
      Reviewed by Kevin McCullough.
      
      * page/JavaScriptProfileNode.cpp:
      (WebCore::sortTotalTimeDescending): Call ProfileNode.
      (WebCore::sortTotalTimeAscending): Ditto.
      (WebCore::sortSelfTimeDescending): Ditto.
      (WebCore::sortSelfTimeAscending): Ditto.
      (WebCore::sortCallsDescending): Ditto.
      (WebCore::sortCallsAscending): Ditto.
      (WebCore::ProfileNodeClass): Add static static functions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a0204ec
    • timothy@apple.com's avatar
      Make the profiler use higher than millisecond resolution time-stamps. · 7de48b2e
      timothy@apple.com authored
      Reviewed by Kevin McCullough.
      
      * kjs/DateMath.cpp:
      (KJS::getCurrentUTCTime): Call getCurrentUTCTimeWithMicroseconds and
      floor the result.
      (KJS::getCurrentUTCTimeWithMicroseconds): Copied from the previous
      implementation of getCurrentUTCTime without the floor call.
      * kjs/DateMath.h: Addded getCurrentUTCTimeWithMicroseconds.
      * profiler/ProfileNode.cpp:
      (KJS::ProfileNode::ProfileNode): Use getCurrentUTCTimeWithMicroseconds.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7de48b2e
    • timothy@apple.com's avatar
      * page/InspectorController.cpp: Change the include for · c3f9d123
      timothy@apple.com authored
      JavaScriptProfile.h to sue double quotes instead of backets.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3f9d123
    • timothy@apple.com's avatar
      Fixes a bug in the profiler where call and apply would show up · e4f53f8a
      timothy@apple.com authored
      and double the time spent in a function. We don't want to show call
      and apply at all in the profiles. This change excludes them.
      
      Reviewed by Kevin McCullough.
      
      * profiler/ProfileNode.cpp:
      (KJS::ProfileNode::stopProfiling): Remove a second for loop and
      calculate self time in the existing loop.
      * profiler/Profiler.cpp:
      (KJS::shouldExcludeFunction): Helper inline function that returns
      true in the current function in an InternalFunctionImp and it is
      has the functionName call or apply.
      (KJS::Profiler::willExecute): Call shouldExcludeFunction and return
      early if if returns true.
      (KJS::Profiler::didExecute): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4f53f8a
    • timothy@apple.com's avatar
      Adds a DataGrid object that is used for multi-column data · 96ad88ab
      timothy@apple.com authored
      and can contain hierarchical content with disclosure arrows.
      A lot of DataGrid was copied from treeoutline.js. This change
      makes the database views use the DataGrid. It will later be
      used by the ProfileView.
      
      Reviewed by Adam Roben.
      
      * page/inspector/DataGrid.js: Added. Most copied from treeoutline.js
      and modified to work with table elements.
      * page/inspector/DatabaseQueryView.js:
      (WebInspector.DatabaseQueryView.prototype._queryFinished):
      Call DatabasesPanel.dataGridForResult and adds the inline style to
      the DataGrid element.
      * page/inspector/DatabaseTableView.js:
      (WebInspector.DatabaseTableView.prototype._queryFinished):
      Call DatabasesPanel.dataGridForResult.
      * page/inspector/DatabasesPanel.js:
      (WebInspector.DatabasesPanel.prototype._tableForResult): Removed.
      (WebInspector.DatabasesPanel.prototype.dataGridForResult): Added.
      Similar to the previous _tableForResult function, but makes a DataGrid.
      * page/inspector/inspector.css: Changes to the data-grid
      style rules.
      * WebCore.vcproj/WebCore.vcproj: Add DataGrid.js.
      * page/inspector/WebKit.qrc: Ditto.
      * page/inspector/inspector.html: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96ad88ab
    • jmalonzo@webkit.org's avatar
      2008-05-20 Jan Michael Alonzo <jmalonzo@webkit.org> · 4c3907ae
      jmalonzo@webkit.org authored
              Reviewed by Alp.
      
              http://bugs.webkit.org/show_bug.cgi?id=18483
              [Gtk] Autotools should match build-webkit default flags
      
              * configure.ac:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c3907ae
    • slewis@apple.com's avatar
      fix changelog · 79ddf1b1
      slewis@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79ddf1b1
    • slewis@apple.com's avatar
      2008-05-19 Stephanie Lewis <slewis@apple.com> · 71de81e7
      slewis@apple.com authored
      
              Explicitly set run mode to 32bit unless overridden to avoid
              confusion when running tests
      
              * Scripts/build-dumprendertree:
              * Scripts/gdb-safari:
              * Scripts/run-webkit-tests:
              * Scripts/webkitdirs.pm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71de81e7
  2. 19 May, 2008 28 commits
    • aroben@apple.com's avatar
      Make WebKit.idl rebuild whenever any of its included interfaces are changed · 3ddd9465
      aroben@apple.com authored
              Reviewed by Tim Hatcher.
      
              * WebKit.vcproj/DerivedSources.make: Touch WebKit.idl whenever any
              other IDL file is changed. This will force VS to rebuild WebKit.idl.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ddd9465
    • mitz@apple.com's avatar
      Reviewed by Adam Roben. · 05ec1e26
      mitz@apple.com authored
              - update test results following <http://trac.webkit.org/changeset/33395>
      
              * platform/mac/fast/frames/viewsource-attribute-expected.checksum:
              * platform/mac/fast/frames/viewsource-attribute-expected.png:
              * platform/mac/fast/frames/viewsource-attribute-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05ec1e26
    • kmccullough@apple.com's avatar
      2008-05-19 Kevin McCullough <kmccullough@apple.com> · 2998eb30
      kmccullough@apple.com authored
              Reviewed by Tim.
      
              <rdar://problem/5770054> JavaScript profiler (10928)
              - Implement sorting by function name.
      
              * JavaScriptCore.exp:
              * profiler/Profile.h:
              (KJS::Profile::sortFileNameDescending):
              (KJS::Profile::sortFileNameAscending):
              * profiler/ProfileNode.cpp:
              (KJS::fileNameDescendingComparator):
              (KJS::ProfileNode::sortFileNameDescending):
              (KJS::fileNameAscendingComparator):
              (KJS::ProfileNode::sortFileNameAscending):
              * profiler/ProfileNode.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2998eb30
    • kmccullough@apple.com's avatar
      2008-05-19 Kevin McCullough <kmccullough@apple.com> · f0bae5cd
      kmccullough@apple.com authored
              Reviewed by Adam.
      
              -build fix.
      
              * bindings/js/JSConsoleCustom.cpp:
              (WebCore::JSConsole::profile):
              * page/Console.cpp:
              (WebCore::Console::profile):
              * page/Console.h:
              * page/Console.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0bae5cd
    • alp@webkit.org's avatar
      2008-05-19 Alp Toker <alp@nuanti.com> · 45d20367
      alp@webkit.org authored
              Reviewed by Maciej.
      
              GTK+/soup fixes:
      
              Remove the fragment part of the URL since the file backend doesn't
              deal with it.
      
              Fix a typo in the cleanup function.
      
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::cleanupGioOperation):
              (WebCore::ResourceHandle::startGio):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45d20367
    • kmccullough@apple.com's avatar
      JavaScriptCore: · 6fc919da
      kmccullough@apple.com authored
      2008-05-19  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Adam.
      
              <rdar://problem/5770054> JavaScript profiler (10928)
              - Pass the exec state to profiler when calling startProfiling so that if
              profiling is started within an execution context that location is
              recorded correctly.
      
              * JavaScriptCore.exp:
              * profiler/ProfileNode.cpp:
              (KJS::ProfileNode::printDataInspectorStyle): Dump more info for debugging
              purposes.
              * profiler/Profiler.cpp:
              (KJS::Profiler::startProfiling):
              * profiler/Profiler.h:
      
      WebCore:
      
      2008-05-19  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Adam.
      
              <rdar://problem/5770054> JavaScript profiler (10928)
              - Send the executing context to the profiler so it can attribute time
              correctly to parent functions when calling profile() and profileEnd()
              while nested.
      
              * page/Console.cpp:
              (WebCore::Console::profile):
              (WebCore::Console::profileEnd):
              * page/Console.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fc919da
    • kmccullough@apple.com's avatar
      2008-05-19 Kevin McCullough <kmccullough@apple.com> · 981039f2
      kmccullough@apple.com authored
              Rubberstamped by Geoff.
      
              Turn off the profiler because it is a performance regression.
      
              * kjs/config.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      981039f2
    • alp@webkit.org's avatar
      2008-05-19 Alp Toker <alp@nuanti.com> · 3a5e7caf
      alp@webkit.org authored
              Reviewed by Anders and Beth.
      
              http://bugs.webkit.org/show_bug.cgi?id=16495
              [GTK] Accessibility support with ATK/AT-SPI
      
              Initial ATK/AT-SPI accessibility support for the GTK+ port.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a5e7caf
    • andersca@apple.com's avatar
      WebCore: · a961966a
      andersca@apple.com authored
      2008-05-19  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              <rdar://problem/5946454>
              Support navigator.onLine from HTML5.
      
              Add Windows NetworkStateNotifier implementation using the IP Helper API.
      
              * WebCore.vcproj/WebCore.vcproj:
              * platform/network/NetworkStateNotifier.h:
              (WebCore::updateState):
              * platform/network/win/NetworkStateNotifierWin.cpp: Added.
              (WebCore::NetworkStateNotifier::updateState):
              (WebCore::NetworkStateNotifier::addressChanged):
              (WebCore::NetworkStateNotifier::callAddressChanged):
              (WebCore::NetworkStateNotifier::addrChangeCallback):
              (WebCore::NetworkStateNotifier::registerForAddressChange):
              (WebCore::NetworkStateNotifier::NetworkStateNotifier):
      
      WebKit/win:
      
      2008-05-19  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              <rdar://problem/5946454>
              Support navigator.onLine from HTML5.
              
              Link with iphlpapi.lib, and make iphlpapi.dll a delay loaded library.
              
              * WebKit.vcproj/WebKit.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a961966a
    • sfalken@apple.com's avatar
      Disable C4273, C4565 for CSSGrammar.cpp, XPathGrammar.cpp to fix build. · f1d95df8
      sfalken@apple.com authored
              
              Reviewed by Adam Roben.
      
              * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1d95df8
    • aroben@apple.com's avatar
      Fix Bug 19065: Resources with a space in their URL don't get error/warning bubbles · fe1a3d2e
      aroben@apple.com authored
              <https://bugs.webkit.org/show_bug.cgi?id=19065>
      
              Reviewed by Dan Bernstein.
      
              Test: manual-tests/inspector/errors-with-space in-url.html
      
              * manual-tests/inspector/errors-with-space in-url.html: Added.
              * page/Console.cpp:
              (WebCore::Console::error):
              (WebCore::Console::info):
              (WebCore::Console::log):
              (WebCore::Console::warn):
              Pass the raw URL to the Inspector, not the pretty URL, to match the
              URL that was used when initially telling the Inspector about this
              resource. We continue to pass the pretty URL to the ChromeClient for
              backwards compatibility.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe1a3d2e
    • slewis@apple.com's avatar
      2008-05-19 Stephanie Lewis <slewis@apple.com> · 71dc466b
      slewis@apple.com authored
              Reviewed by Darin.
          
              more fast teardown performance work
      
              * Misc/WebDownload.m:
              (-[WebDownloadInternal downloadDidBegin:]):
              (-[WebDownloadInternal downloadDidFinish:]):
              (-[WebDownloadInternal download:didFailWithError:]):
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::disableSuddenTermination):
              (WebChromeClient::enableSuddenTermination):
      
              more fast teardown performance work, WebCore plumbing
      
              * page/Chrome.cpp:
              (WebCore::Chrome::disableSuddenTermination):
              (WebCore::Chrome::enableSuddenTermination):
              (WebCore::ChromeClient::disableSuddenTermination):
              (WebCore::ChromeClient::enableSuddenTermination):
              * page/Chrome.h:
              * page/ChromeClient.h:
              * page/Page.cpp:
              (WebCore::Page::changePendingUnloadEventCount):
              (WebCore::Page::changePendingBeforeUnloadEventC...
      71dc466b
    • alp@webkit.org's avatar
      2008-05-19 Alp Toker <alp@nuanti.com> · 8cfd6abe
      alp@webkit.org authored
              GTK+ build fix for Mac/Win. Don't check for FreeType/FontConfig when
              the Pango font backend is selected.
      
              * GNUmakefile.am:
              * configure.ac:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cfd6abe
    • justin.garcia@apple.com's avatar
      2008-05-19 Kuchhal <kuchal@yahoo.com> · afc4aa00
      justin.garcia@apple.com authored
              Reviewed by Justin.
      
              <rdar://problem/5863412> Crash when Ctrl C is pressed after a series of specific mouse events (18506)
      
              * editing/markup.cpp:
              (WebCore::createMarkup): Null check.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afc4aa00
    • cfleizach@apple.com's avatar
      <rdar://problem/5912195> CrashTracer: [USER] 1 crash in Mail at... · d7ead7ce
      cfleizach@apple.com authored
      <rdar://problem/5912195> CrashTracer: [USER] 1 crash in Mail at -[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7ead7ce
    • kmccullough@apple.com's avatar
      2008-05-19 Kevin McCullough <kmccullough@apple.com> · 9d534b39
      kmccullough@apple.com authored
              Reviewed by Tim.
      
              <rdar://problem/5770054> JavaScript profiler (10928)
              -In an effort to make the profiler as efficient as possible instead of
              prepending to a vector we keep the vector in reverse order and operate
              over it backwards.
      
              * profiler/Profile.cpp:
              (KJS::Profile::willExecute):
              (KJS::Profile::didExecute):
              * profiler/ProfileNode.cpp:
              (KJS::ProfileNode::didExecute):
              (KJS::ProfileNode::endAndRecordCall):
              * profiler/ProfileNode.h:
              * profiler/Profiler.cpp:
              (KJS::getStackNames):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d534b39
    • andersca@apple.com's avatar
      2008-05-19 Anders Carlsson <andersca@apple.com> · 019be47c
      andersca@apple.com authored
              Reviewed by Darin, Alexey, Jess and Brady.
      
              Set the application cache path.
              
              * WebView.cpp:
              (WebKitSetApplicationCachePathIfNecessary):
              New function that sets the cache path.
              
              (WebView::initWithFrame):
              Set the application cache path.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      019be47c
    • adachan@apple.com's avatar
      Added methods to get/set current cookie storage. · 149c8024
      adachan@apple.com authored
      WebCore:
              Added CookieStorageWin.h/cpp, introducing methods to get/set the current CFHTTPCookieStorageRef.
              When setting cookies-related attributes in CFURLRequest, make sure we get them from the
              current CFHTTPCookieStorageRef.  Also, set the cookie storage in CFURLRequest.
      
              Reviewed by Steve Falkenburg.
      
              * WebCore.vcproj/WebCore.vcproj:
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::makeFinalRequest):
              * platform/network/cf/ResourceRequestCFNet.cpp:
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
              * platform/network/win/CookieJarCFNetWin.cpp:
              (WebCore::setCookies):
              (WebCore::cookies):
              (WebCore::cookiesEnabled):
              * platform/network/win/CookieStorageWin.cpp: Added.
              (WebCore::currentCookieStorage):
              (WebCore::setCurrentCookieStorage):
              * platform/network/win/CookieStorageWin.h: Added.
      
      WebKit/win:
              Added IWebCookieManager interface which allows client to set the
              CFHTTPCookieStorageRef that WebCore should use.
              
              Implement IWebCookieManager interface in WebCookieManager.
              
              Update the cookie accept policy in the current cookie storage.
      
              Reviewed by Steve Falkenburg.
      
              * ForEachCoClass.h:
              * Interfaces/IWebCookieManager.idl: Added.
              * Interfaces/WebKit.idl:
              * WebCookieManager.cpp: Added.
              (WebCookieManager::createInstance):
              (WebCookieManager::WebCookieManager):
              (WebCookieManager::~WebCookieManager):
              (WebCookieManager::QueryInterface):
              (WebCookieManager::AddRef):
              (WebCookieManager::Release):
              (WebCookieManager::cookieStorage):
              (WebCookieManager::setCookieStorage):
              * WebCookieManager.h: Added.
              * WebKit.vcproj/WebKit.vcproj:
              * WebKitClassFactory.cpp:
              * WebView.cpp:
              (updateSharedSettingsFromPreferencesIfNeeded):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      149c8024
    • ap@webkit.org's avatar
      Reviewed by Darin. · da8393a2
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=18308
              SVG Encoding error with fill attribute
      
              This is caused by problems with data: URL loading. Besides what is fixed by this patch,
              I filed <rdar://problem/5845875> for CFNetwork.
      
              While at it, fixed a related javascript: URL issue.
      
              Tests: fast/loader/data-url-encoding-html.html
                     fast/loader/data-url-encoding-svg.html
                     fast/loader/javascript-url-encoding.html
      
              * platform/KURL.cpp:
              (WebCore::KURL::parse): Fix a FIXME, use UTF-8 instead of dropping high bytes. This fixes
              javascript: URL handling.
              (WebCore::encodeRelativeString): Like mailto: URLs, data: ones are all UTF-8. Restructured
              the code to not search for "#" if both parts are to be encoded as UTF-8 anyway.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da8393a2
    • ap@webkit.org's avatar
      Reviewed by Darin. · a8de74c2
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=18421
              <rdar://problem/5857369> XMLHttpRequest does not properly encode & and < in outgoing messages
      
              Test: http/tests/xmlhttprequest/serialize-document.html
      
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::send): Use createMarkup() instead of Document::toString().
      
              * dom/Attr.cpp:
              * dom/Attr.h:
              * dom/Document.cpp:
              * dom/Document.h:
              * dom/DocumentFragment.cpp:
              * dom/DocumentFragment.h:
              * dom/Element.cpp:
              * dom/Element.h:
              * dom/Entity.cpp:
              * dom/Entity.h:
              * dom/EntityReference.cpp:
              * dom/EntityReference.h:
              * dom/Node.h:
              * dom/Text.cpp:
              * dom/Text.h:
              * html/HTMLElement.cpp:
              * html/HTMLElement.h:
              Removed most Node::toString() methods, which were massively wrong, and only used for
              XMLHttpRequest::send(). The remanining ones are still used in markup.cpp, but should probably
              be folded into it for consistency.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8de74c2
    • andersca@apple.com's avatar
      2008-05-19 Anders Carlsson <andersca@apple.com> · 4ff2b98d
      andersca@apple.com authored
              Fix Windows build.
              
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginView::userAgentStatic):
              (WebCore::PluginView::getValueStatic):
              (WebCore::PluginView::getValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ff2b98d
    • cfleizach@apple.com's avatar
      <rdar://problem/5935694> AX: crash in text marker range · fc0f4ac4
      cfleizach@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc0f4ac4
    • darin@apple.com's avatar
      2008-05-19 Darin Adler <darin@apple.com> · cc8bf398
      darin@apple.com authored
              - fix WebKit build
      
              * WebCore.xcodeproj/project.pbxproj: Make CSSReflectionDirection.h "private" instead of "project".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc8bf398
    • cfleizach@apple.com's avatar
      <rdar://problem/5700830> VO: VoiceOver should fall back to title attr if form... · 02df5a3b
      cfleizach@apple.com authored
      <rdar://problem/5700830> VO: VoiceOver should fall back to title attr if form element is not labeled
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02df5a3b
    • darin@apple.com's avatar
      2008-05-19 Darin Adler <darin@apple.com> · a79c5fb7
      darin@apple.com authored
              Reviewed by Mitz.
      
              - tweak CSSReflectValue, possibly fixing the leaks seen on the buildbot
      
              * WebCore.vcproj/WebCore.vcproj: Added CSSReflectionDirection.h. 
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * css/CSSReflectionDirection.h: Added.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::valueForReflection): Changed to use CSSReflectValue::create.
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseReflect): Ditto.
      
              * css/CSSReflectValue.h: Added a create function. Got rid of the setter
              functions, which had const PassRefPtr& arguments -- those probably caused
              the leaks although I'm not exactly sure why. Made the contructor and all
              the data members private.
      
              * rendering/style/RenderStyle.h: Changed to include CSSReflectionDirection.h
              instead of CSSReflectValue.h so we can tweak CSSReflectValue without
              recompiling the world.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a79c5fb7
    • zecke@webkit.org's avatar
      2008-05-19 Holger Hans Peter Freyther <zecke@selfish.org> · 88462144
      zecke@webkit.org authored
              Rubber Stamped by Simon.
      
              Enforce the WebKit Coding Style.
      
              * plugins/PluginView.cpp:
              (WebCore::PluginView::load):
              (WebCore::PluginView::setValue):
              * plugins/gtk/PluginViewGtk.cpp:
              (WebCore::PluginView::setFocus):
              (WebCore::PluginView::show):
              (WebCore::PluginView::hide):
              (WebCore::PluginView::attachToWindow):
              (WebCore::PluginView::detachFromWindow):
              (WebCore::PluginView::getValueStatic):
              (WebCore::PluginView::getValue):
              * plugins/qt/PluginViewQt.cpp:
              (WebCore::PluginView::updateWindow):
              (WebCore::PluginView::detachFromWindow):
              (WebCore::PluginView::handlePostReadFile):
              (WebCore::PluginView::getValueStatic):
              (WebCore::PluginView::getValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88462144
    • zecke@webkit.org's avatar
      2008-05-14 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk> · b3b076ce
      zecke@webkit.org authored
              Reviewed by Holger.
      
              https://bugs.webkit.org/show_bug.cgi?id=18882
              https://bugs.webkit.org/show_bug.cgi?id=18892
              Based also on work by Chris Lord.
      
              Provides support for NPAPI plugins that pass NULL as their instance
              info. There are two kinds:
              - Some call NPN_UserAgent and NPN_GetValue before a PluginView has
              been created. For those we provide static versions of those functions.
              - Others call NPN_* functions with a NULL instance inside NPP_*
              calls, for those we've added extra currentPluginView guards.
      
              * plugins/PluginView.cpp: Add additional currentPluginView guards and
              some small style changes.
              (WebCore::PluginView::start):
              (WebCore::PluginView::performRequest):
              (WebCore::PluginView::bindingInstance):
              (WebCore::PluginView::handlePost):
              * plugins/PluginView.h: Added static versions of NPN_UserAgent and
              NPN_GetValue.
              * plugins/gtk/PluginViewGtk.cpp: Add additional currentPluginView
              guards and some small style changes.
              (WebCore::PluginView::setNPWindowRect):
              (WebCore::PluginView::stop):
              (WebCore::PluginView::userAgentStatic): Added to deal with plugins
              that query this before having a PluginView.
              (WebCore::PluginView::getValueStatic): Added to deal with plugins
              that call this before we have created a PluginView.
              (WebCore::PluginView::getValue): Moved some code to getValueStatic.
              (WebCore::PluginView::init):
              * plugins/npapi.cpp: Call PluginView::userAgentStatic
              and PluginView::getValueStatic if no PluginView is
              present.
              (NPN_UserAgent):
              (NPN_GetValue):
              * plugins/qt/PluginPackageQt.cpp:
              (WebCore::PluginPackage::fetchInfo): Corrected split args because ignoring
              empty entries crashed.
              (WebCore::PluginPackage::load): Resolve all symbols when loading plugins
              to protect against XPCOM dependencies.
              * plugins/qt/PluginViewQt.cpp: Add additional currentPluginView guards and
              some small style changes.
              (WebCore::PluginView::updateWindow):
              (WebCore::PluginView::setNPWindowRect):
              (WebCore::PluginView::stop):
              (WebCore::PluginView::userAgentStatic): Added to deal with plugins
              that query this before having a PluginView.
              (WebCore::PluginView::handlePostReadFile):
              (WebCore::PluginView::getValueStatic): Added to deal with plugins
              that call this before we have created a PluginView.
              (WebCore::PluginView::getValue): Moved some code to getValueStatic.
              (WebCore::PluginView::init): m_needsXEmbed init was moved to constructor.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3b076ce
    • alp@webkit.org's avatar
      2008-05-19 Alp Toker <alp@nuanti.com> · 2649634d
      alp@webkit.org authored
              GTK+ build fix on Mac. Conditionalize XP_UNIX use.
      
              * plugins/gtk/PluginPackageGtk.cpp:
              (WebCore::PluginPackage::fetchInfo):
              (WebCore::PluginPackage::load):
              * plugins/gtk/PluginViewGtk.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2649634d