1. 04 Oct, 2013 31 commits
    • oliver@apple.com's avatar
      Support for-of syntax · 20a9bf08
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122339
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Add support for for-of syntax to JSC.  As part of doing this I had to make
      us support unique empty strings as identifiers.  In a follow on patch i'm
      going to remove the distinction entirely as it's purely a complicating
      separation.
      
      Otherwise the logic here is fairly self-explanatory.
      
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::addConstant):
      (JSC::BytecodeGenerator::emitCall):
      * bytecompiler/BytecodeGenerator.h:
      * bytecompiler/NodesCodegen.cpp:
      (JSC::CallArguments::CallArguments):
      (JSC::ForOfNode::emitBytecode):
      * jit/JITOperations.cpp:
      * parser/ASTBuilder.h:
      (JSC::ASTBuilder::createForOfLoop):
      * parser/NodeConstructors.h:
      (JSC::EnumerationNode::EnumerationNode):
      (JSC::ForInNode::ForInNode):
      (JSC::ForOfNode::ForOfNode):
      * parser/Nodes.h:
      * parser/Parser.cpp:
      (JSC::::parseVarDeclarationList):
      (JSC::::parseForStatement):
      * parser/Parser.h:
      (JSC::Parser::isofToken):
      * parser/SyntaxChecker.h:
      (JSC::SyntaxChecker::createForOfLoop):
      * runtime/ArrayIteratorPrototype.cpp:
      (JSC::ArrayIteratorPrototype::finishCreation):
      (JSC::arrayIteratorPrototypeIterate):
      * runtime/ArrayPrototype.cpp:
      (JSC::ArrayPrototype::create):
      (JSC::ArrayPrototype::finishCreation):
      * runtime/ArrayPrototype.h:
      * runtime/CommonIdentifiers.cpp:
      (JSC::CommonIdentifiers::CommonIdentifiers):
      * runtime/CommonIdentifiers.h:
      * runtime/Identifier.h:
      (JSC::Identifier::from):
      * runtime/JSCJSValue.cpp:
      (JSC::JSValue::dumpInContext):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::reset):
      * runtime/JSObject.cpp:
      (JSC::JSObject::putDirectNativeFunction):
      * runtime/PrivateName.h:
      (JSC::PrivateName::PrivateName):
      * runtime/PropertyName.h:
      (JSC::PropertyName::PropertyName):
      
      Source/WTF:
      
      Update assertions and add a helper function to StringImpl
      to save repeated unique or identifier calls.
      
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::isIdentifierOrUnique):
      (WTF::StringImpl::setIsIdentifier):
      (WTF::StringImpl::setIsAtomic):
      
      LayoutTests:
      
      Add test cases for the one type that supports for-of so far
      
      * js/basic-for-of-expected.txt: Added.
      * js/basic-for-of.html: Added.
      * js/regress/for-of-iterate-array-entries.html: Added.
      * js/regress/for-of-iterate-array-keys.html: Added.
      * js/regress/for-of-iterate-array-values.html: Added.
      * js/regress/script-tests/for-of-iterate-array-entries.js: Added.
      (foo):
      * js/regress/script-tests/for-of-iterate-array-keys.js: Added.
      (foo):
      * js/regress/script-tests/for-of-iterate-array-values.js: Added.
      (foo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20a9bf08
    • zandobersek@gmail.com's avatar
      [WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the... · b684bfaf
      zandobersek@gmail.com authored
      [WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
      https://bugs.webkit.org/show_bug.cgi?id=122275
      
      Reviewed by Darin Adler.
      
      Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
      interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
      doesn't have any effect, but will keep the operations not configurable after the generator is modified
      to preserve the original behavior. The attribute will be removed from each interface after checking
      conformity with other browsers (in terms of configurability of operations of that interface) and the
      WebKit's existing test suites.
      
      This patch covers IDL interfaces under Source/WebCore/fileapi/.
      
      * fileapi/Blob.idl:
      * fileapi/FileException.idl:
      * fileapi/FileList.idl:
      * fileapi/FileReader.idl:
      * fileapi/FileReaderSync.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b684bfaf
    • zandobersek@gmail.com's avatar
      [WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the... · c9ec2964
      zandobersek@gmail.com authored
      [WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute
      https://bugs.webkit.org/show_bug.cgi?id=122271
      
      Reviewed by Darin Adler.
      
      Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
      interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
      doesn't have any effect, but will keep the operations not configurable after the generator is modified
      to preserve the original behavior. The attribute will be removed from each interface after checking
      conformity with other browsers (in terms of configurability of operations of that interface) and the
      WebKit's existing test suites.
      
      This patch covers IDL interfaces under Source/WebCore/dom/.
      
      * dom/CharacterData.idl:
      * dom/ChildNode.idl:
      * dom/ClientRectList.idl:
      * dom/Clipboard.idl:
      * dom/CompositionEvent.idl:
      * dom/CustomEvent.idl:
      * dom/DOMCoreException.idl:
      * dom/DOMImplementation.idl:
      * dom/DOMNamedFlowCollection.idl:
      * dom/DOMStringList.idl:
      * dom/DOMStringMap.idl:
      * dom/DataTransferItem.idl:
      * dom/DataTransferItemList.idl:
      * dom/DeviceMotionEvent.idl:
      * dom/DeviceOrientationEvent.idl:
      * dom/Document.idl:
      * dom/DocumentFragment.idl:
      * dom/DocumentType.idl:
      * dom/Element.idl:
      * dom/Event.idl:
      * dom/EventException.idl:
      * dom/EventListener.idl:
      * dom/EventTarget.idl:
      * dom/KeyboardEvent.idl:
      * dom/MessageEvent.idl:
      * dom/MessagePort.idl:
      * dom/MouseEvent.idl:
      * dom/MutationEvent.idl:
      * dom/MutationObserver.idl:
      * dom/NamedNodeMap.idl:
      * dom/Node.idl:
      * dom/NodeFilter.idl:
      * dom/NodeIterator.idl:
      * dom/NodeList.idl:
      * dom/Range.idl:
      * dom/RangeException.idl:
      * dom/ShadowRoot.idl:
      * dom/Text.idl:
      * dom/TextEvent.idl:
      * dom/TouchEvent.idl:
      * dom/TouchList.idl:
      * dom/TreeWalker.idl:
      * dom/UIEvent.idl:
      * dom/WebKitNamedFlow.idl:
      * dom/WheelEvent.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9ec2964
    • zandobersek@gmail.com's avatar
      [WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the... · 47743007
      zandobersek@gmail.com authored
      [WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
      https://bugs.webkit.org/show_bug.cgi?id=122269
      
      Reviewed by Darin Adler.
      
      Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
      interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
      doesn't have any effect, but will keep the operations not configurable after the generator is modified
      to preserve the original behavior. The attribute will be removed from each interface after checking
      conformity with other browsers (in terms of configurability of operations of that interface) and the
      WebKit's existing test suites.
      
      This patch covers IDL interfaces under Source/WebCore/xml/.
      
      * xml/DOMParser.idl:
      * xml/XMLHttpRequest.idl:
      * xml/XMLHttpRequestException.idl:
      * xml/XMLHttpRequestUpload.idl:
      * xml/XMLSerializer.idl:
      * xml/XPathEvaluator.idl:
      * xml/XPathException.idl:
      * xml/XPathExpression.idl:
      * xml/XPathNSResolver.idl:
      * xml/XPathResult.idl:
      * xml/XSLTProcessor.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47743007
    • msaboff@apple.com's avatar
      FTL::OSRExit::convertToForward() shouldn't misuse Operands<>::operator[] · 911a64dd
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122336
      
      Reviewed by Geoffrey Garen.
      
      Changed code in change set r156900 to use the operand() accessor instead of operator[].
      
      * ftl/FTLOSRExit.cpp:
      (JSC::FTL::OSRExit::convertToForward):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      911a64dd
    • betravis@adobe.com's avatar
      [CSS Shapes] Shape Outside should relayout when set dynamically · c2384d3c
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122197
      
      Reviewed by Alexandru Chiculita.
      
      Source/WebCore:
      
      Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html
             fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html
      
      When shape outside is modified, dependent content needs to relayout. This patch
      removes the float from the float lists and marks dependents for layout using
      RenderBox::removeFloatingOrPositionedChildFromBlockLists(). This is the same
      method used when switching from float: left to float: right and vice versa
      (see RenderElement::styleWillChange).
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Mark shape-outside dependents
      for layout.
      * rendering/RenderBox.h:
      (WebCore::RenderBox::markShapeOutsideDependentsForLayout): Mark all the items that may be
      affected by this shape-outside for relayout.
      
      LayoutTests:
      
      Test that a shape can be dynamically added, modified, or removed and that
      content does a proper relayout.
      
      * fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2384d3c
    • antti@apple.com's avatar
      Tighten markContainingBlocksForLayout · 0e0ef56e
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122326
      
      Reviewed by Anders Carlsson.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e0ef56e
    • akling@apple.com's avatar
      Node: removedFrom() and insertedInto() should use references. · 2e55ebf6
      akling@apple.com authored
      <https://webkit.org/b/122315>
      
      Reviewed by Anders Carlsson.
      
      ContainerNode* -> ContainerNode&
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e55ebf6
    • ap@apple.com's avatar
      Optimize strings copies in srcset parser · d545436f
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121899
      
      Patch by Romain Perier <romain.perier@gmail.com> on 2013-10-04
      Reviewed by Alexey Proskuryakov.
      
      No new tests, covered by existing ones.
      
      * html/parser/HTMLParserIdioms.cpp:
      (WebCore::parseImagesWithScaleFromSrcsetAttribute): Don't copy
      image.imageURL at each loop iteration, save indexes instead.
      (WebCore::bestFitSourceForImageAttributes): Make a String for
      the URL only when the corresponding candidate is chosen
      by the selection algorithm. It reduces the number of copies
      significantly and improves performance
      (around 30% with the "Release" profile and 60% with the "Debug" one).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d545436f
    • g.czajkowski@samsung.com's avatar
      Tests added in r141354 erroneously assume correction suggestion to be in the context menu · d1836068
      g.czajkowski@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113742
      
      Reviewed by Ryosuke Niwa.
      
      Tests from r141354 erroneously assume that all WebKit ports populate
      spell checking suggestion in the context menu.
      
      Remove verification of spell checking suggestion and all context menu stuff from tests
      that do that unnecessarily. Instead of that check whether spelling markers behave correctly,
      for example, after deleting a text, double click or selecting a misspellings.
      
      However, two tests are adapted to verify spell checking suggestions (their availability
      rather than correctness, similarly to context-menu-suggestions.html).
      Those are useful for ports which populate spelling suggestion in the context menu.
      
      * editing/spelling/resources/util.js:
      (initSpellTest):
      Do not assume that the tests are running with "Windows" editing behavior.
      Unix ports do not make a selection for the misspelled word and they don't
      require selection to get spell checking suggestions.
      
      * editing/spelling/spelling-changed-text-expected.txt:
      * editing/spelling/spelling-changed-text.html:
      * editing/spelling/spelling-double-clicked-word-expected.txt:
      * editing/spelling/spelling-double-clicked-word.html:
      * editing/spelling/spelling-exactly-selected-word-expected.txt:
      * editing/spelling/spelling-exactly-selected-word.html:
      Remove verification of correction suggestion.
      Instead of that check whether the spelling markers behave correctly.
      
      * editing/spelling/context-menu-suggestions-multiword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection-expected.txt.
      * editing/spelling/context-menu-suggestions-multiword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection.html.
      * editing/spelling/context-menu-suggestions-subword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-subword-selection-expected.txt.
      * editing/spelling/context-menu-suggestions-subword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-subword-selection.html.
      Adapt those tests for platforms which populate spell check suggestion
      in the context menu.
      
      * platform/efl-wk2/TestExpectations:
      Now context-menu-suggestions-multiword-selection.html and
      context-menu-suggestions-subword-selection.html are passing for EFL.
      
      * platform/gtk-wk2/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac-wk2/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      Update tests path due to rename.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1836068
    • msaboff@apple.com's avatar
      FTL: Crash in OSRExit::convertToForward() using VirtualRegister.offset() as array index · 9969368b
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122332
      
      Reviewed by Oliver Hunt.
      
      Changed the uses of .offset(), which returns a negative number for locals, to be
      toLocal() which returns a local's ordinal number.
      
      * ftl/FTLOSRExit.cpp:
      (JSC::FTL::OSRExit::convertToForward):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9969368b
    • dpranke@chromium.org's avatar
      remove dpranke from webkitpy watchlist · 27adcce1
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122331
      
      Reviewed by Brent Fulgham.
      
      * Scripts/webkitpy/common/config/watchlist:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27adcce1
    • timothy_horton@apple.com's avatar
      [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793 · 4c452551
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122299
      
      Reviewed by Beth Dakin.
      
      * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
      * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
      The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c452551
    • ap@apple.com's avatar
      Watchlist is broken after <http://trac.webkit.org/r156880> · 97894c02
      ap@apple.com authored
      * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97894c02
    • msaboff@apple.com's avatar
      Add callOperation to Baseline JIT · a482c543
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122306
      
      Reviewed by Geoffrey Garen.
      
      Created baseline JIT compatible versions for a few flavors of callOperation().
      Migrated cti_op_new_regexp() and its caller to callOperation(operationNewRegexp()).
      
      * dfg/DFGOperations.cpp: Moved operationNewRegexp() to JITOperations
      * dfg/DFGOperations.h:
      * jit/JIT.h:
      (JSC::JIT::appendCall):
      * jit/JITInlines.h:
      (JSC::JIT::appendCallWithExceptionCheck):
      (JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
      (JSC::JIT::callOperation):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_new_regexp):
      * jit/JITOperations.cpp:
      * jit/JITOperations.h:
      * jit/JITStubs.cpp:
      * jit/JITStubs.h:
      * jit/JSInterfaceJIT.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a482c543
    • bfulgham@apple.com's avatar
      Remove Qt features from build and test tools · bf28c05f
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122312
      
      Reviewed by Anders Carlsson.
      
      * Scripts/build-dumprendertree:
      * Scripts/build-jsc:
      * Scripts/build-webkit:
      * Scripts/build-webkittestrunner:
      * Scripts/old-run-webkit-tests:
      (openDumpTool):
      (buildPlatformResultHierarchy):
      (buildPlatformTestHierarchy):
      (readSkippedFiles):
      * Scripts/run-launcher:
      * Scripts/run-qtwebkit-tests: Removed.
      * Scripts/run-webkit-tests:
      (useNewRunWebKitTests):
      * Scripts/update-webkit:
      * Scripts/webkit-build-directory:
      * Scripts/webkitdirs.pm:
      (argumentsForConfiguration):
      (jscProductDir):
      (builtDylibPathForName):
      (isAppleWebKit):
      (launcherPath):
      (launcherName):
      (checkRequiredSystemConfig):
      (setupCygwinEnv):
      (copyInspectorFrontendFiles):
      (setPathForRunningWebKitApp):
      * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
      * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
      (BaselineOptimizerTest.test_mac_future):
      (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
      (BaselineOptimizerTest.test_common_directory_includes_root):
      (BaselineOptimizerTest.test_virtual_ports_filtered):
      * Scripts/webkitpy/common/checkout/changelog_unittest.py:
      (test_parse_reviewer_text):
      * Scripts/webkitpy/common/config/watchlist:
      * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
      (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
      * Scripts/webkitpy/port/base.py:
      (Port.__init__):
      (Port._port_flag_for_scripts):
      (Port._wk2_port_name):
      * Scripts/webkitpy/port/builders.py:
      * Scripts/webkitpy/port/factory.py:
      (platform_options):
      (PortFactory):
      (PortFactory._default_port):
      * Scripts/webkitpy/port/factory_unittest.py:
      (FactoryTest.test_gtk):
      * Scripts/webkitpy/port/qt.py: Removed.
      * Scripts/webkitpy/port/qt_unittest.py: Removed.
      * Scripts/webkitpy/style/checker.py:
      * Scripts/webkitpy/style/checker_unittest.py:
      (GlobalVariablesTest.test_path_rules_specifier):
      * Scripts/webkitpy/style/checkers/cmake.py:
      (CMakeChecker):
      * Scripts/webkitpy/style/checkers/cpp.py:
      (_classify_include):
      (check_include_line):
      (check_identifier_name_in_declaration):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (OrderOfIncludesTest.test_classify_include):
      (WebKitStyleTest.test_names):
      * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
      (TestExpectationsTestCase.test_determine_port_from_expectations_path):
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      (TestRebaselineTest.test_baseline_directory):
      * Scripts/webkitpy/tool/main.py:
      (WebKitPatch):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf28c05f
    • ap@apple.com's avatar
      Add svn:ignore to *.pyc files in inspector/Scripts directory, so that they don't · 50c5432a
      ap@apple.com authored
      show up as unversioned all the time.
      
      * inspector/Scripts: Added property svn:ignore.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50c5432a
    • commit-queue@webkit.org's avatar
      [Win][WebGL] Crash on exit · ce0fa838
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120764
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-04
      Reviewed by Martin Robinson.
      
      On exit, libGLESv2.dll is detached from the process and relevant memory is released
      before the atexit GL context cleanup handler is called, causing a NULL pointer crash.
      The GL context cleanup code was originally written to avoid a X server crash on exit,
      so it's only needed for PLATFORM(X11).
      
      * platform/graphics/GLContext.cpp: Only clean up active GL contexts on exit for PLATFORM(X11).
      (WebCore::GLContext::cleanupSharedX11Display):
      (WebCore::GLContext::cleanupActiveContextsAtExit):
      (WebCore::GLContext::GLContext):
      (WebCore::GLContext::~GLContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce0fa838
    • commit-queue@webkit.org's avatar
      [GTK] Enable text edition UndoOperations support in WebKit2 · 3ccdea61
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122305
      
      Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-10-04
      Reviewed by Carlos Garcia Campos.
      
      Source/WebKit2:
      
      Replaced the notImplemented() function calls for
      the corresponding implementation of the edit operations
      provided by the DefaultUndoController class.
      
      * GNUmakefile.list.am:
      * UIProcess/API/gtk/PageClientImpl.cpp:
      (WebKit::PageClientImpl::registerEditCommand):
      (WebKit::PageClientImpl::clearAllEditCommands):
      (WebKit::PageClientImpl::canUndoRedo):
      (WebKit::PageClientImpl::executeUndoRedo):
      * UIProcess/API/gtk/PageClientImpl.h:
      
      LayoutTests:
      
      * platform/gtk-wk2/TestExpectations: Corrected the expectations
      with the new results.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ccdea61
    • mihnea@adobe.com's avatar
      [CSSRegions] Regions as stacking contexts should paint over positioned sibling · ed473d20
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122321
      
      Reviewed by Alexandru Chiculita.
      
      Source/WebCore:
      
      Test: fast/regions/layers/region-normalflow-stacking-context.html
      
      Since regions are stacking contexts, they should not be in normal flow list of layers.
      More clean-up after https://bugs.webkit.org/show_bug.cgi?id=117365 and https://bugs.webkit.org/show_bug.cgi?id=121828
      which enabled the layers.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::shouldBeNormalFlowOnly):
      (WebCore::RenderLayer::shouldBeSelfPaintingLayer):
      
      LayoutTests:
      
      Add a new test and modify existing tests to take into account the stacking context behavior
      for non-positioned regions.
      
      * fast/regions/autoheight-regions-mark-expected.txt:
      * fast/regions/layers/region-normalflow-stacking-context-expected.html: Added.
      * fast/regions/layers/region-normalflow-stacking-context.html: Added.
      * fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html:
      * fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed473d20
    • andersca@apple.com's avatar
      Remove WebAssertions.h · ab351299
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122328
      
      Reviewed by Jessie Berlin.
      
      Source/WebKit:
      
      * WebKit.xcodeproj/project.pbxproj:
      
      Source/WebKit/mac:
      
      * Misc/WebAssertions.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab351299
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · edfe1ef7
      m.pakula@samsung.com authored
      Remove failure expectations from tests that are passing.
      
      * platform/efl-wk2/TestExpectations: update js/dom/create-lots-of-workers.html path.
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edfe1ef7
    • commit-queue@webkit.org's avatar
      [EFL] Enable correct behaviour for deleting regional indicator symbols · 773a332e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122209
      
      Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-04
      Reviewed by Gyuyoung Kim.
      
      Source/WebCore:
      
      Regional indicator symbols that are combined should behave as a single character when deleting.
      Removed unused variable initialState.
      
      * rendering/RenderText.cpp:
      (WebCore::RenderText::previousOffsetForBackwardDeletion):
      
      LayoutTests:
      
      Now editing/deleting/regional-indicators.html is passing on EFL port.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      773a332e
    • commit-queue@webkit.org's avatar
      Remove Qt leftovers from WebKit2 · 7ea4fc4f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122317
      
      Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-10-04
      Reviewed by Anders Carlsson.
      
      * Platform/CoreIPC/unix/ConnectionUnix.cpp:
      (CoreIPC::Connection::platformInitialize):
      (CoreIPC::Connection::platformInvalidate):
      (CoreIPC::Connection::readyReadHandler):
      (CoreIPC::Connection::open):
      (CoreIPC::Connection::sendOutgoingMessage):
      * Shared/API/c/WKBase.h:
      * Shared/NativeWebTouchEvent.h:
      * UIProcess/API/C/WebKit2_C.h:
      * UIProcess/BackingStore.h:
      * UIProcess/InspectorServer/WebInspectorServer.cpp:
      (WebKit::WebInspectorServer::inspectorUrlForPageID):
      * UIProcess/InspectorServer/WebInspectorServer.h:
      * UIProcess/InspectorServer/WebSocketServer.cpp:
      * UIProcess/InspectorServer/WebSocketServer.h:
      * UIProcess/WebPageProxy.cpp:
      * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
      (WebKit::getPluginDisplay):
      (WebKit::x11Screen):
      (WebKit::displayDepth):
      (WebKit::rootWindowID):
      (WebKit::NetscapePlugin::x11HostDisplay):
      (WebKit::NetscapePlugin::platformPostInitializeWindowless):
      (WebKit::NetscapePlugin::platformPaint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ea4fc4f
    • zandobersek@gmail.com's avatar
      [WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the... · cc179074
      zandobersek@gmail.com authored
      [WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDeletable attribute
      https://bugs.webkit.org/show_bug.cgi?id=122276
      
      Reviewed by Darin Adler.
      
      Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
      interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
      doesn't have any effect, but will keep the operations not configurable after the generator is modified
      to preserve the original behavior. The attribute will be removed from each interface after checking
      conformity with other browsers (in terms of configurability of operations of that interface) and the
      WebKit's existing test suites.
      
      This patch covers IDL interfaces under Source/WebCore/css/.
      
      * css/CSSHostRule.idl:
      * css/CSSMediaRule.idl:
      * css/CSSPrimitiveValue.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSStyleSheet.idl:
      * css/CSSSupportsRule.idl:
      * css/CSSValueList.idl:
      * css/DOMWindowCSS.idl:
      * css/FontLoader.idl:
      * css/MediaList.idl:
      * css/MediaQueryList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * css/StyleSheet.idl:
      * css/StyleSheetList.idl:
      * css/WebKitCSSFilterValue.idl:
      * css/WebKitCSSKeyframesRule.idl:
      * css/WebKitCSSMatrix.idl:
      * css/WebKitCSSTransformValue.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc179074
    • zandobersek@gmail.com's avatar
      [WebIDL] Annotate IDL interfaces under Source/WebCore/loader/appcache/ with... · cb4ccac2
      zandobersek@gmail.com authored
      [WebIDL] Annotate IDL interfaces under Source/WebCore/loader/appcache/ with the OperationsNotDeletable attribute
      https://bugs.webkit.org/show_bug.cgi?id=122274
      
      Reviewed by Darin Adler.
      
      Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
      interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
      doesn't have any effect, but will keep the operations not configurable after the generator is modified
      to preserve the original behavior. The attribute will be removed from each interface after checking
      conformity with other browsers (in terms of configurability of operations of that interface) and the
      WebKit's existing test suites.
      
      This patch covers IDL interfaces under Source/WebCore/loader/appcache/.
      
      * loader/appcache/DOMApplicationCache.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb4ccac2
    • zandobersek@gmail.com's avatar
      [WebIDL] Annotate IDL interfaces under Source/WebCore/plugins/ with the... · 899e1c64
      zandobersek@gmail.com authored
      [WebIDL] Annotate IDL interfaces under Source/WebCore/plugins/ with the OperationsNotDeletable attribute
      https://bugs.webkit.org/show_bug.cgi?id=122273
      
      Reviewed by Darin Adler.
      
      Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
      interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
      doesn't have any effect, but will keep the operations not configurable after the generator is modified
      to preserve the original behavior. The attribute will be removed from each interface after checking
      conformity with other browsers (in terms of configurability of operations of that interface) and the
      WebKit's existing test suites.
      
      This patch covers IDL interfaces under Source/WebCore/plugins/.
      
      * plugins/DOMMimeTypeArray.idl:
      * plugins/DOMPlugin.idl:
      * plugins/DOMPluginArray.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      899e1c64
    • zandobersek@gmail.com's avatar
      [WebIDL] Annotate IDL interfaces under Source/WebCore/storage/ with the... · e466ecf3
      zandobersek@gmail.com authored
      [WebIDL] Annotate IDL interfaces under Source/WebCore/storage/ with the OperationsNotDeletable attribute
      https://bugs.webkit.org/show_bug.cgi?id=122272
      
      Reviewed by Darin Adler.
      
      Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
      interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
      doesn't have any effect, but will keep the operations not configurable after the generator is modified
      to preserve the original behavior. The attribute will be removed from each interface after checking
      conformity with other browsers (in terms of configurability of operations of that interface) and the
      WebKit's existing test suites.
      
      This patch covers IDL interfaces under Source/WebCore/storage/.
      
      * storage/Storage.idl:
      * storage/StorageEvent.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e466ecf3
    • zandobersek@gmail.com's avatar
      [WebIDL] Annotate IDL interfaces under Source/WebCore/workers/ with the... · 8ee0bab4
      zandobersek@gmail.com authored
      [WebIDL] Annotate IDL interfaces under Source/WebCore/workers/ with the OperationsNotDeletable attribute
      https://bugs.webkit.org/show_bug.cgi?id=122270
      
      Reviewed by Darin Adler.
      
      Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
      interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
      doesn't have any effect, but will keep the operations not configurable after the generator is modified
      to preserve the original behavior. The attribute will be removed from each interface after checking
      conformity with other browsers (in terms of configurability of operations of that interface) and the
      WebKit's existing test suites.
      
      This patch covers IDL interfaces under Source/WebCore/workers/.
      
      * workers/DedicatedWorkerGlobalScope.idl:
      * workers/Worker.idl:
      * workers/WorkerGlobalScope.idl:
      * workers/WorkerLocation.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ee0bab4
    • abucur@adobe.com's avatar
      [CSS Regions] Infinite loop when computing widows · fc49713b
      abucur@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122215
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      The patch ensures it's not possible to relayout a block indefinitely because of widows contraints. You can't
      break a block more than once to account for widows. This can happen if, for example, some lines are moved
      to the next container and there the content breaks in another container again without respecting the widows property.
      This is in line with the idea of not leaving empty fragmentation containers during layout.
      
      Test: fast/regions/regions-widows-stack-overflow.html
      
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::adjustLinePositionForPagination):
      (WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
      (WebCore::RenderBlockFlow::setDidBreakAtLineToAvoidWidow):
      (WebCore::RenderBlockFlow::clearDidBreakAtLineToAvoidWidow):
      (WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):
      
      * rendering/RenderBlockFlow.h:
      (WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData): Rename the m_shouldBreakAtLineToAvoidWidow
      flag to m_didBreakAtLineToAvoidWidow.
      
      (WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow): Use the line index to determine if it should break or not.
      (WebCore::RenderBlockFlow::didBreakAtLineToAvoidWidow): Use to determine if a break already happened because of widows.
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::layoutRunsAndFloatsInRange):
      
      LayoutTests:
      
      Test there is no stack overflow when trying to break for widows that are caused by other widows.
      
      * fast/regions/regions-widows-stack-overflow-expected.html: Added.
      * fast/regions/regions-widows-stack-overflow.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc49713b
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed. Add myself to some watchlists. · 1121f164
      gyuyoung.kim@samsung.com authored
      * Scripts/webkitpy/common/config/watchlist:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1121f164
  2. 03 Oct, 2013 9 commits