1. 13 Dec, 2013 4 commits
    • ap@apple.com's avatar
      WebCrypto Key.usages should be ordered alphabetically · 20890d48
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125696
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      * crypto/CryptoKey.cpp: (WebCore::CryptoKey::usages): Do it.
      
      LayoutTests: 
      
      * crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-generate-key-expected.txt:
      * crypto/subtle/aes-cbc-generate-key.html:
      * crypto/subtle/aes-cbc-invalid-length-expected.txt:
      * crypto/subtle/aes-cbc-invalid-length.html:
      * crypto/subtle/aes-kw-wrap-unwrap-aes-expected.txt:
      * crypto/subtle/aes-kw-wrap-unwrap-aes.html:
      * crypto/subtle/aes-postMessage-expected.txt:
      * crypto/subtle/aes-postMessage.html:
      * crypto/subtle/hmac-postMessage-expected.txt:
      * crypto/subtle/hmac-postMessage.html:
      * crypto/subtle/jwk-import-use-values-expected.txt:
      * crypto/subtle/jwk-import-use-values.html:
      * crypto/subtle/postMessage-worker-expected.txt:
      * crypto/subtle/postMessage-worker.html:
      * crypto/subtle/resources/postMessage-worker.js:
      (onmessage):
      * crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
      * crypto/subtle/rsa-oaep-key-manipulation.html:
      * crypto/subtle/rsa-oaep-wrap-unwrap-aes-expected.txt:
      * crypto/subtle/rsa-oaep-wrap-unwrap-aes.html:
      * crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt:
      * crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20890d48
    • rwlbuis@webkit.org's avatar
      Clean up SVGScriptElement · 3493ab27
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125527
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      From the Blink port of this bug it becomes clear that svg/dom/SVGScriptElement/script-set-href.svg and
      svg/dom/svg-element-attribute-js-null.xhtml still hit an assert in Debug because SVGNames::typeAttr can't
      be used with fastGetAttribute in all cases, because it can be animatable. However for SVGScriptElement
      it is not animatable, so make isAnimatableAttribute virtual (note Debug only method) and allow typeAttr
      in the SVGScriptElement case to be useable for fastGetAttribute.
      
      Test: svg/dom/SVGScriptElement/script-type-attribute.svg
      
      * svg/SVGElement.h:
      * svg/SVGScriptElement.cpp:
      (WebCore::SVGScriptElement::isAnimatableAttribute):
      * svg/SVGScriptElement.h:
      
      LayoutTests:
      
      Add test to verify the new type getter/setter behavior on SVScriptElement.
      Specifically, the old behavior was setting the JS type property did not reflect in
      the actual content attribute being set, the new behavior is to do set the content
      attribute when setting the JS type property.
      
      * svg/dom/SVGScriptElement/script-type-attribute-expected.txt: Added.
      * svg/dom/SVGScriptElement/script-type-attribute.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3493ab27
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 66face18
      m.pakula@samsung.com authored
      Remove wrong http baselines.
      
      * platform/efl/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Removed.
      * platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
      * platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66face18
    • ap@apple.com's avatar
      WebCrypto wrapKey operation doesn't check key usage · 1ab645b4
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125675
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Tests: crypto/subtle/unwrapKey-check-usage.html
             crypto/subtle/wrapKey-check-usage.html
      
      * bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::wrapKey):
      Added accidentally omitted code. Other operations are fine.
      
      LayoutTests: 
      
      * crypto/subtle/unwrapKey-check-usage-expected.txt: Added.
      * crypto/subtle/unwrapKey-check-usage.html: Added.
      * crypto/subtle/wrapKey-check-usage-expected.txt: Added.
      * crypto/subtle/wrapKey-check-usage.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ab645b4
  2. 12 Dec, 2013 8 commits
    • ap@apple.com's avatar
      Add support for RSAES-PKCS1-v1_5 · d79ec0a0
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125647
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Tests: crypto/subtle/rsaes-pkcs1-v1_5-decrypt.html
             crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html
      
      * crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
      * crypto/algorithms/CryptoAlgorithmAES_KW.h:
      Removed meaningless parameters arguments from private functions. The base arguments
      class is always empty.
      
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSCryptoAlgorithmDictionary.cpp:
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
      * bindings/js/JSCryptoKeySerializationJWK.cpp:
      (WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
      (WebCore::JSCryptoKeySerializationJWK::keySizeIsValid):
      (WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
      * crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp: Added.
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::CryptoAlgorithmRSAES_PKCS1_v1_5):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::~CryptoAlgorithmRSAES_PKCS1_v1_5):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::create):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::identifier):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::keyAlgorithmMatches):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::generateKey):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):
      * crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h: Added.
      * crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp: Added.
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
      * crypto/mac/CryptoAlgorithmRegistryMac.cpp:
      (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
      Added support for this algorithm.
      
      LayoutTests: 
      
      * crypto/subtle/rsaes-pkcs1-v1_5-decrypt-expected.txt: Added.
      * crypto/subtle/rsaes-pkcs1-v1_5-decrypt.html: Added.
      * crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt: Added.
      * crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d79ec0a0
    • ap@apple.com's avatar
      Source/WebCore: Replace uses of WTF::BitArray with std::bitset · 5aec375d
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125642
      
      Patch by Sam Weinig <sam@webkit.org> on 2013-12-12
      Reviewed by Anders Carlsson.
      
      * css/CSSParser.cpp:
      (WebCore::filterProperties):
      (WebCore::CSSParser::createStyleProperties):
      * css/StyleProperties.cpp:
      (WebCore::StyleProperties::asText):
      
      LayoutTests: Public key in a generated KeyPair should always be extractable
      https://bugs.webkit.org/show_bug.cgi?id=125643
      
      Reviewed by Sam Weinig.
      
      * crypto/subtle/rsa-oaep-generate-non-extractable-key-expected.txt: Added.
      * crypto/subtle/rsa-oaep-generate-non-extractable-key.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5aec375d
    • ap@apple.com's avatar
      Make algorithm.name return registered name, not normalized one · 8199d8e9
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125641
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Currently, WebCrypto editor's draft stipulates that algorithm name is lowercased
      as part of normalization.
      
      But it makes little sense to register algorithms as mixed (mostly upper) case, yet
      return the name lowercased. Other implementations don't bother respecting this,
      and signs are that the spec will change.
      
      I'd like to match other implementations here, because sticking to the spec only
      makes us fail 3rd party test suites for no good reason.
      
      Updated many existing tests.
      
      * crypto/CryptoAlgorithmRegistry.cpp:
      (WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
      (WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
      * crypto/CryptoAlgorithmRegistry.h:
      * crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
      * crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
      * crypto/algorithms/CryptoAlgorithmHMAC.cpp:
      * crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
      * crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
      * crypto/algorithms/CryptoAlgorithmSHA1.cpp:
      * crypto/algorithms/CryptoAlgorithmSHA224.cpp:
      * crypto/algorithms/CryptoAlgorithmSHA256.cpp:
      * crypto/algorithms/CryptoAlgorithmSHA384.cpp:
      * crypto/algorithms/CryptoAlgorithmSHA512.cpp:
      
      LayoutTests: 
      
      * crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-generate-key-expected.txt:
      * crypto/subtle/aes-cbc-generate-key.html:
      * crypto/subtle/aes-cbc-import-jwk-expected.txt:
      * crypto/subtle/aes-cbc-import-jwk.html:
      * crypto/subtle/aes-cbc-invalid-length-expected.txt:
      * crypto/subtle/aes-cbc-invalid-length.html:
      * crypto/subtle/aes-cbc-unwrap-failure-expected.txt:
      * crypto/subtle/aes-cbc-unwrap-failure.html:
      * crypto/subtle/aes-cbc-unwrap-rsa-expected.txt:
      * crypto/subtle/aes-cbc-unwrap-rsa.html:
      * crypto/subtle/aes-cbc-wrap-rsa-expected.txt:
      * crypto/subtle/aes-cbc-wrap-rsa-non-extractable-expected.txt:
      * crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html:
      * crypto/subtle/aes-cbc-wrap-rsa.html:
      * crypto/subtle/aes-kw-key-manipulation-expected.txt:
      * crypto/subtle/aes-kw-key-manipulation.html:
      * crypto/subtle/aes-kw-wrap-unwrap-aes-expected.txt:
      * crypto/subtle/aes-kw-wrap-unwrap-aes.html:
      * crypto/subtle/aes-postMessage-expected.txt:
      * crypto/subtle/aes-postMessage.html:
      * crypto/subtle/hmac-generate-key-expected.txt:
      * crypto/subtle/hmac-generate-key.html:
      * crypto/subtle/hmac-import-jwk-expected.txt:
      * crypto/subtle/hmac-import-jwk.html:
      * crypto/subtle/hmac-postMessage-expected.txt:
      * crypto/subtle/hmac-postMessage.html:
      * crypto/subtle/hmac-sign-verify-empty-key-expected.txt:
      * crypto/subtle/hmac-sign-verify-empty-key.html:
      * crypto/subtle/hmac-sign-verify-expected.txt:
      * crypto/subtle/hmac-sign-verify.html:
      * crypto/subtle/postMessage-worker-expected.txt:
      * crypto/subtle/postMessage-worker.html:
      * crypto/subtle/resources/postMessage-worker.js:
      * crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
      * crypto/subtle/rsa-oaep-key-manipulation.html:
      * crypto/subtle/rsa-oaep-wrap-unwrap-aes-expected.txt:
      * crypto/subtle/rsa-oaep-wrap-unwrap-aes.html:
      * crypto/subtle/rsa-postMessage-expected.txt:
      * crypto/subtle/rsa-postMessage.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html:
      * crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt:
      * crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8199d8e9
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 755a020d
      m.pakula@samsung.com authored
      Rebaseline fast/table/empty-cells.html after r160410.
      
      * platform/efl/fast/table/empty-cells-expected.png:
      * platform/efl/fast/table/empty-cells-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      755a020d
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 2775d839
      m.pakula@samsung.com authored
      Add test expectations for failing compositing tests.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2775d839
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r160446. · dedc785f
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/160446
      https://bugs.webkit.org/show_bug.cgi?id=125630
      
      The upower-glib-based implementation is using API that was
      recently removed (Requested by zdobersek1 on #webkit).
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      
      LayoutTests:
      
      * platform/gtk/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dedc785f
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r160417. · 3579e7c2
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/160417
      https://bugs.webkit.org/show_bug.cgi?id=125629
      
      The patch is causing crashes (Requested by zdobersek1 on
      #webkit).
      
      Source/WebCore:
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::~AXObjectCache):
      (WebCore::AXObjectCache::remove):
      * accessibility/AXObjectCache.h:
      (WebCore::AXObjectCache::detachWrapper):
      * accessibility/atk/AXObjectCacheAtk.cpp:
      (WebCore::AXObjectCache::detachWrapper):
      (WebCore::AXObjectCache::attachWrapper):
      (WebCore::AXObjectCache::postPlatformNotification):
      * accessibility/ios/AXObjectCacheIOS.mm:
      (WebCore::AXObjectCache::detachWrapper):
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::detachWrapper):
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::detachWrapper):
      
      Tools:
      
      * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
      (axObjectEventListener):
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
      
      LayoutTests:
      
      * accessibility/children-changed-sends-notification-expected.txt: Removed.
      * accessibility/children-changed-sends-notification.html: Removed.
      * accessibility/loading-iframe-sends-notification.html:
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3579e7c2
    • darin@apple.com's avatar
      StylePendingImage needs to correctly manage the CSSValue pointer lifetime · 6b9561a0
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125468
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Test: fast/css/pending-image-crash.xhtml
      
      Disconnect the reference counted StylePendingImage from the CSSValue that owns
      it when it's not needed any more, otherwise we could end up using a pointer
      that might no longer be valid.
      
      * css/CSSCursorImageValue.cpp:
      (WebCore::CSSCursorImageValue::detachPendingImage): Added. Calls detachFromCSSValue
      on the current image if it is a StylePendingImage.
      (WebCore::CSSCursorImageValue::~CSSCursorImageValue): Call detachPendingImage.
      (WebCore::CSSCursorImageValue::cachedImage): Call detachPendingImage before changing
      m_image to a new value.
      (WebCore::CSSCursorImageValue::clearCachedImage): Ditto.
      * css/CSSCursorImageValue.h: Added detachPendingImage.
      
      * css/CSSImageSetValue.cpp:
      (WebCore::CSSImageSetValue::detachPendingImage): Added. Calls detachFromCSSValue
      on the current image set if it is a StylePendingImage.
      (WebCore::CSSImageSetValue::~CSSImageSetValue): Call detachPendingImage.
      (WebCore::CSSImageSetValue::cachedImageSet): Call detachPendingImage before changing
      m_imageSet to a new value.
      * css/CSSImageSetValue.h: Added detachPendingImage.
      
      * css/CSSImageValue.cpp:
      (WebCore::CSSImageValue::detachPendingImage): Added. Calls detachFromCSSValue on the
      current image if it is a StylePendingImage.
      (WebCore::CSSImageValue::~CSSImageValue): Call detachPendingImage.
      (WebCore::CSSImageValue::cachedImage): Call detachPendingImage before changing m_image
      to a new value.
      * css/CSSImageValue.h: Added detachPendingImage.
      
      * rendering/style/StylePendingImage.h:
      (WebCore::StylePendingImage::cssImageValue): Added a null check.
      (WebCore::StylePendingImage::cssImageGeneratorValue): Added a null check.
      (WebCore::StylePendingImage::cssCursorImageValue): Added a null check.
      (WebCore::StylePendingImage::cssImageSetValue): Added a null check.
      (WebCore::StylePendingImage::detachFromCSSValue): Added. Sets m_value to null since
      the style is no longer using this StylePendingImage.
      (WebCore::StylePendingImage::data): Changed to use the "this" pointer since all we
      need is some arbitrary pointer uniquely identifying the image. Before loading the image,
      we have no suitable weak identifier, so it suffices to use the unique pointer to each
      StylePendingImage object. This function is used only in a limited way; it would be nice
      to find a way to make the code less strange long term.
      
      LayoutTests:
      
      * fast/css/pending-image-crash-expected.txt: Added.
      * fast/css/pending-image-crash.xhtml: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b9561a0
  3. 11 Dec, 2013 11 commits
    • ap@apple.com's avatar
      WebCrypto keys should support structured clone · 351ac9ca
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125590
      
      Reviewed by Oliver Hunt.
      
      Source/WebCore: 
      
      Tests: crypto/subtle/aes-postMessage.html
             crypto/subtle/hmac-postMessage.html
             crypto/subtle/postMessage-worker.html
             crypto/subtle/rsa-postMessage.html
      
      * crypto/CryptoAlgorithmIdentifier.h:
      (WebCore::CryptoAlgorithmIdentifier):
      * bindings/js/JSCryptoAlgorithmDictionary.cpp:
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):
      AES_KW was added to WebCrypto spec editor's draft yesterday night. Now that we're
      adding a matching enum for structired clone serialization, it's as good a time as
      any to update the order of values to match.
      
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::countUsages):
      (WebCore::CloneSerializer::dumpIfTerminal):
      (WebCore::CloneSerializer::write):
      (WebCore::CloneDeserializer::read):
      (WebCore::CloneDeserializer::readHMACKey):
      (WebCore::CloneDeserializer::readAESKey):
      (WebCore::CloneDeserializer::readRSAKey):
      (WebCore::CloneDeserializer::readCryptoKey):
      (WebCore::CloneDeserializer::readTerminal):
      Added serialization/deserialization for CryptoKey. This doesn't update version
      number, because we don't currently store structured clones in persistent storage -
      and even if we did, we wouldn't want to invalidate everything users already stored.
      
      * crypto/CryptoAlgorithmRegistry.cpp:
      (WebCore::CryptoAlgorithmRegistry::shared):
      (WebCore::registryMutex):
      (WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
      (WebCore::CryptoAlgorithmRegistry::nameForIdentifier):
      (WebCore::CryptoAlgorithmRegistry::create):
      (WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
      * crypto/CryptoKey.idl:
      With structured clone, it is now possible to send a Key to a web worker. That's
      of no practical use because the crypto API is not exposed in workers, but we
      shouldn't crash anyway.
      
      * crypto/keys/CryptoKeyAES.cpp:
      (WebCore::CryptoKeyAES::CryptoKeyAES):
      (WebCore::CryptoKeyAES::isValidAESAlgorithm):
      * crypto/keys/CryptoKeyAES.h:
      Exposed isValidAESAlgorithm, so that a caller could know whether the constructor
      will assert.
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.vcxproj/WebCoreCommon.props:
      Added crypto/keys to search paths to avoid build breakage.
      
      LayoutTests: 
      
      * crypto/subtle/aes-postMessage-expected.txt: Added.
      * crypto/subtle/aes-postMessage.html: Added.
      * crypto/subtle/hmac-postMessage-expected.txt: Added.
      * crypto/subtle/hmac-postMessage.html: Added.
      * crypto/subtle/postMessage-worker-expected.txt: Added.
      * crypto/subtle/postMessage-worker.html: Added.
      * crypto/subtle/rsa-postMessage-expected.txt: Added.
      * crypto/subtle/rsa-postMessage.html: Added.
      * crypto/subtle/resources/postMessage-worker.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      351ac9ca
    • betravis@adobe.com's avatar
      Web Inspector: [CSS Shapes] Highlight margin-shape for shape-outside · 0c34d471
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125175
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      In addition to highlighting the shape, also highlight the shape created
      by shape-margin with a slightly more transparent color. This patch modifies
      the shape info passed to the Inspector Overlay to include a path for both
      the raw shape and the shape with margin.
      
      Test: inspector-protocol/model/highlight-shape-outside-margin.html
      
      * inspector/InspectorOverlay.cpp:
      (WebCore::buildObjectForShapeOutside): Call Shape::buildDisplayPaths rather than
      Shape::buildPath, and pass along any relevant paths to the Inspector overlay.
      * inspector/InspectorOverlayPage.js:
      (_drawShapeHighlight): Draw the margin shape in addition to the raw shape.
      * rendering/shapes/BoxShape.cpp:
      (WebCore::addRoundedRect): Add a rounded rect to the path.
      (WebCore::BoxShape::buildDisplayPaths): Create the applicable [margin/padding/raw] shapes.
      * rendering/shapes/BoxShape.h:
      * rendering/shapes/PolygonShape.cpp:
      (WebCore::addPolygon): Add a set of vertices as a polygon to the path.
      (WebCore::PolygonShape::buildDisplayPaths): Create the applicable [margin/padding/raw] shapes.
      * rendering/shapes/PolygonShape.h:
      * rendering/shapes/RasterShape.h:
      (WebCore::RasterShape::buildDisplayPaths): Ditto.
      * rendering/shapes/RectangleShape.cpp:
      (WebCore::RectangleShape::buildDisplayPaths): Ditto.
      * rendering/shapes/RectangleShape.h:
      * rendering/shapes/Shape.h:
      
      LayoutTests:
      
      Test that the shape and margin-shape are properly passed to the Inspector Overlay.
      Arcs for rounded rectangles, circles, and ellipses are approximated using the same
      bezier curve method present in Path.cpp.
      
      * inspector-protocol/model/highlight-shape-outside-margin.html: Added.
      * inspector-protocol/model/highlight-shape-outside.html: Updating shape-outside info model.
      * inspector-protocol/resources/shape-info-helper.js: Adding utilities to compare alternate
        path formats.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c34d471
    • mario.prada@samsung.com's avatar
      [ATK] Expose accessibility objects WAI-ARIA landmark roles · e10ceaa5
      mario.prada@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125584
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Exposed accessibility objects with landmark roles with the proper
      AtkRole, to be provided by the next stable release of ATK.
      
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      (webkitAccessibleGetAttributes):
      (atkRole):
      
      Tools:
      
      Add mappings to DRT & WKTR for landmark roles.
      
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (AccessibilityUIElement::role):
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::role):
      * gtk/jhbuild.modules:
      
      LayoutTests:
      
      Update test to unskip landmark elements and update expectations.
      
      * platform/gtk/accessibility/roles-exposed-expected.txt:
      * platform/gtk/accessibility/roles-exposed.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e10ceaa5
    • mario.prada@samsung.com's avatar
      [ATK] Add new layout test to check ATK roles in a central place · 43535967
      mario.prada@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125525
      
      Reviewed by Chris Fleizach.
      
      New test added, with some skipped tests already present in
      platform/mac/accessibility/role-subrole-roledescription.html (this
      test is based in that one) as well as some issues specific to ATK
      that have been reported in bugs, for traceability.
      
      * platform/gtk/accessibility/roles-exposed-expected.txt: Added.
      * platform/gtk/accessibility/roles-exposed.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43535967
    • zandobersek@gmail.com's avatar
      [GTK] Enable Battery Status API · 5046e133
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125453
      
      Reviewed by Martin Robinson.
      
      Tools: 
      
      * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
      
      LayoutTests: 
      
      * platform/gtk/TestExpectations: Remove expectations for the Battery Status API layout tests
      since all the tests pass now that the feature is enabled.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5046e133
    • commit-queue@webkit.org's avatar
      Arithmetic overflow when computing max-height CSS property with subpixel layout · e0b472e9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119273
      
      Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-12-11
      Reviewed by Martin Robinson.
      
      Enabled SATURATED_LAYOUT_ARITHMETIC for the gtk+ port.
      
      .:
      
      * Source/autotools/SetupWebKitFeatures.m4:
      
      LayoutTests:
      
      * platform/gtk/TestExpectations: Removed failure expectation for autoheight-correct-region-for-lines-2.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0b472e9
    • commit-queue@webkit.org's avatar
      Improving createOffer and createAnswer LayoutTests · 403c521e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125568
      
      Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-12-11
      Reviewed by Philippe Normand.
      
      The constraints parameter should be optional in both. Also adding tests to check if we already have a local SDP
      when creating an answer.
      
      Source/WebCore:
      
      Existing tests were updated.
      
      * platform/mock/RTCPeerConnectionHandlerMock.cpp:
      (WebCore::RTCPeerConnectionHandlerMock::createOffer):
      
      LayoutTests:
      
      * fast/mediastream/RTCPeerConnection-createAnswer-expected.txt:
      * fast/mediastream/RTCPeerConnection-createAnswer.html:
      * fast/mediastream/RTCPeerConnection-createOffer-expected.txt:
      * fast/mediastream/RTCPeerConnection-createOffer.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      403c521e
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 6a4ea27c
      m.pakula@samsung.com authored
      Add test expectations for failing ref-tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a4ea27c
    • rwlbuis@webkit.org's avatar
      [CSS Shapes] Take into account fill-rule for polygon interpolation · 93a99751
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125508
      
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Implement the polygon fill-rule part of http://dev.w3.org/csswg/css-shapes/#basic-shape-interpolation.
      
      Adapt fast/shapes/shape-outside-floats/shape-outside-animation.html.
      
      * rendering/style/BasicShapes.cpp:
      (WebCore::BasicShape::canBlend):
      
      LayoutTests:
      
      Adapt fast/shapes/shape-outside-floats/shape-outside-animation.html so it also tests polygon animation
      when using different fill rules.
      
      * animations/resources/animation-test-helpers.js:
      (parseBasicShape): also allow evenodd when parsing the polygon
      * fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
      * fast/shapes/shape-outside-floats/shape-outside-animation.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93a99751
    • commit-queue@webkit.org's avatar
      Test results of postMessage-clone-port-error.html test are broken · 7a54583a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125487
      
      Patch by Michal Poteralski <m.poteralski@samsung.com> on 2013-12-11
      Reviewed by Alexey Proskuryakov.
      
      Improved Layout test checks correctness of value thrown by postMessage:
      
      * fast/dom/Window/postMessage-clone-port-error-expected.txt:
      * fast/dom/Window/postMessage-clone-port-error.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a54583a
    • mario.prada@samsung.com's avatar
      Programmatically-inserted children lack accessibility events · aaeae64a
      mario.prada@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100275
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Test: accessibility/children-changed-sends-notification.html
      
      Emit children-changed::add and children-changed::remove whenever
      an object has been added/removed to the accessibility hierarchy,
      that is, when a new AtkObject is being attached/detached.
      
      * accessibility/AXObjectCache.h: Added new enumeration to know
      when we are detaching a wrapper because of the cache or the
      element is being destroyed, so we can use that information.
      (WebCore::AXObjectCache::detachWrapper): Added a new parameter and
      updated all the prototypes in different ports.
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::~AXObjectCache): Call detachWrapper()
      specifying that we do it because the cache is being destroyed.
      (WebCore::AXObjectCache::remove): Call detachWrapper() specifying
      that we do it because an accessible element is being destroyed.
      
      * accessibility/atk/AXObjectCacheAtk.cpp:
      (WebCore::AXObjectCache::detachWrapper): Emit the children-changed
      signal when needed. We rely on the cached reference to the parent
      AtkObject (using the implementation of atk_object_get_parent from
      the AtkObject class) to find the right object to emit the signal
      from here, since the accessibility hierarchy from WebCore will no
      longer be accessible at this point.
      (WebCore::AXObjectCache::attachWrapper): Emit the children-change
      signal from here unless we are in the middle of a layout update,
      trying to provide as much information (e.g. the offset) as possible.
      (WebCore::AXObjectCache::postPlatformNotification): Make sure we
      update (touch) the subtree under an accessibility object whenever
      we receive AXChildrenChanded from WebCore, to ensure that those
      objects will also be visible rightaway to ATs, and that those get
      properly notified of the event at that very same moment.
      
      * accessibility/ios/AXObjectCacheIOS.mm:
      (WebCore::AXObjectCache::detachWrapper): Updated function signature.
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::detachWrapper): Ditto.
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::detachWrapper): Ditto.
      
      Tools:
      
      Update DRT and WebKitTestRunner to handle the children-changed
      signal properly, considering the detail and optional parameters.
      
      * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
      (axObjectEventListener):
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
      
      LayoutTests:
      
      Add new test to chack that children-changed signals are properly
      emitted when adding/removing elements in the accessibility hierarchy.
      
      * accessibility/children-changed-sends-notification-expected.txt: Added.
      * accessibility/children-changed-sends-notification.html: Added.
      
      Update test to filter out unrelated non-loading events.
      * accessibility/loading-iframe-sends-notification.html: Updated.
      
      Skip the test on the Mac as it does not expose these kind of
      notifications when children are being added or removed.
      * platform/mac/TestExpectations: Skip newly added test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aaeae64a
  4. 10 Dec, 2013 9 commits
    • commit-queue@webkit.org's avatar
      top and bottom black background line not getting displayed · bbff4a2f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=21664
      
      Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-12-10
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      The table cell's background was not being displayed. Since the table
      cell had no child correct offsetWidth was not being set even if table
      width is being defined.
      
      Test: fast/dom/HTMLTableElement/empy-table-cell-with-background-color.html
      
      * rendering/AutoTableLayout.cpp:
      (WebCore::AutoTableLayout::recalcColumn):
      cellHasContent should also be set to true incase background color is
      present.
      
      LayoutTests:
      
      * fast/dom/HTMLTableElement/empy-table-cell-with-background-color-expected.txt: Added.
      * fast/dom/HTMLTableElement/empy-table-cell-with-background-color.html: Added.
      Added new test case to verify that table cell offsetWidth is set even
      when it has no contents but has background color.
      * fast/table/auto-100-percent-width-expected.txt:
      * platform/mac/fast/table/empty-cells-expected.txt:
      * tables/mozilla/bugs/bug1818-6-expected.txt:
      Rebaselining the existing test case as per the new changes. The new
      dimension changes are as per mozilla behaviour. For
      auto-100-percent-width-expected.txt we get 1 px red background because
      if cellHasContent we set columnLayout's minLogicalWidth and
      columnLayout's maxLogicalWidth as 1 initially even if cell is empty.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbff4a2f
    • commit-queue@webkit.org's avatar
      AX: Share accessibility/aria-hidden-negates-no-visibility.html expectation with other ports · 4ceb6521
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125495
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-12-10
      Reviewed by Chris Fleizach.
      
      Expectation of accessibility/aria-hidden-negates-no-visibility.html is the same for EFL and GTK.
      
      * accessibility/aria-hidden-negates-no-visibility-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-hidden-negates-no-visibility-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ceb6521
    • mario.prada@samsung.com's avatar
      [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR · ae97a65b
      mario.prada@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125522
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Expose objects with SplitterRole role as ATK_ROLE_SEPARATOR.
      
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      
      Tools:
      
      Update strings representing ATK_ROLE_SEPARATOR for layout tests.
      
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      
      LayoutTests:
      
      Update expected results in layout test for EFL and GTK.
      
      * platform/efl-wk1/accessibility/lists-expected.txt:
      * platform/efl-wk2/accessibility/lists-expected.txt:
      * platform/gtk/accessibility/lists-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae97a65b
    • mario.prada@samsung.com's avatar
      [ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT · 810148fb
      mario.prada@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125521
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Stop exposing alert dialogs as ATK_ROLE_DIALOG and do it as
      ATK_ROLE_ALERT instead.
      
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      
      LayoutTests:
      
      Update expected result in layout test.
      
      * accessibility/aria-mappings-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      810148fb
    • commit-queue@webkit.org's avatar
      PageConsole::addMessage should automatically determine column number alongside line number · ec979f8f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114319
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-10
      Reviewed by Joseph Pecoraro.
      
      Source/WebCore:
      
      * dom/InlineStyleSheetOwner.cpp:
      (WebCore::InlineStyleSheetOwner::InlineStyleSheetOwner):
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::ScriptElement):
      * dom/ScriptableDocumentParser.h:
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::styleAttributeChanged):
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
      (WebCore::HTMLDocumentParser::pumpPendingSpeculations):
      * html/parser/HTMLDocumentParser.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::buildInitiatorObject):
      * page/Console.cpp:
      (WebCore::internalAddMessage):
      * page/PageConsole.cpp:
      (WebCore::PageConsole::printSourceURLAndPosition):
      (WebCore::PageConsole::addMessage):
      * page/PageConsole.h:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::XMLDocumentParser::error):
      
      LayoutTests:
      
      * inspector-protocol/page/deny-X-FrameOption-expected.txt: Added.
      * inspector-protocol/page/deny-X-FrameOption.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec979f8f
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 0330fb96
      m.pakula@samsung.com authored
      Add failure expectations for tests added in r157725.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0330fb96
    • jdiggs@igalia.com's avatar
      AX: [ATK] Convert the get_text atktest.c unit tests to layout tests · 14bfdfa8
      jdiggs@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125497
      
      Reviewed by Mario Sanchez Prada.
      
      Source/WebKit/gtk:
      
      * tests/testatk.c: Remove the portions of the remaining tests which now exist as
      layout tests.
      (testWebkitAtkCaretOffsets):
      (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces):
      (testWebkitAtkComboBox):
      (testWebkitAtkEmbeddedObjects):
      (testWebkitAtkTextSelections):
      (testWebkitAtkListsOfItems):
      (main):
      
      Tools:
      
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (AccessibilityUIElement::stringForRange): Implemented.
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::stringForRange): Implemented.
      
      LayoutTests:
      
      * platform/gtk/accessibility/text-for-range-combo-box-expected.txt: Added.
      * platform/gtk/accessibility/text-for-range-combo-box.html: Added.
      * platform/gtk/accessibility/text-for-range-embedded-objects-expected.txt: Added.
      * platform/gtk/accessibility/text-for-range-embedded-objects.html: Added.
      * platform/gtk/accessibility/text-for-range-entry-and-password-expected.txt: Added.
      * platform/gtk/accessibility/text-for-range-entry-and-password.html: Added.
      * platform/gtk/accessibility/text-for-range-extraneous-whitespace-expected.txt: Added.
      * platform/gtk/accessibility/text-for-range-extraneous-whitespace.html: Added.
      * platform/gtk/accessibility/text-for-range-formatted-expected.txt: Added.
      * platform/gtk/accessibility/text-for-range-formatted.html: Added.
      * platform/gtk/accessibility/text-for-range-heading-expected.txt: Added.
      * platform/gtk/accessibility/text-for-range-heading.html: Added.
      * platform/gtk/accessibility/text-for-range-list-items-expected.txt: Added.
      * platform/gtk/accessibility/text-for-range-list-items.html: Added.
      * platform/gtk/accessibility/text-for-range-simple-expected.txt: Added.
      * platform/gtk/accessibility/text-for-range-simple.html: Added.
      * platform/gtk/accessibility/text-for-range-table-cells-expected.txt: Added.
      * platform/gtk/accessibility/text-for-range-table-cells.html: Added.
      * platform/gtk/accessibility/text-for-range-with-link-expected.txt: Added.
      * platform/gtk/accessibility/text-for-range-with-link.html: Added.
      * platform/gtk/accessibility/text-for-table-expected.txt: Added.
      * platform/gtk/accessibility/text-for-table.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14bfdfa8
    • commit-queue@webkit.org's avatar
      [ATK] accessibility/alt-tag-on-image-with-nonimage-role.html is failing after r160311 · 20e10e77
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125504
      
      Unreviewed ATK gardening.
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-12-10
      
      * platform/efl/TestExpectations: Marked as failing.
      * platform/gtk/TestExpectations: Marked as failing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20e10e77
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · e440cb8c
      m.pakula@samsung.com authored
      Add failure expectations for tests that started to fail after r154906.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e440cb8c
  5. 09 Dec, 2013 8 commits
    • rniwa@webkit.org's avatar
      REGRESSION(r136280): input[type=image] should assume coords of 0,0 when... · f44b8e53
      rniwa@webkit.org authored
      REGRESSION(r136280): input[type=image] should assume coords of 0,0 when activated without physically clicking
      https://bugs.webkit.org/show_bug.cgi?id=125392
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Merge https://chromium.googlesource.com/chromium/blink/+/3c33d42207cd209bb171083ba66c225f694f2101
      
      Activating an image button with the keyboard or element.click() should result in selected coords of (0,0) per
      http://www.w3.org/TR/2013/CR-html5-20130806/forms.html#image-button-state-(type=image)
      "If the user activates the control without explicitly selecting a coordinate, then the coordinate (0,0) must be assumed."
      
      New behavior also matches that of Internet Explorer and Firefox.
      
      Tests: fast/forms/input-image-submit.html
      
      * html/ImageInputType.cpp:
      (WebCore::ImageInputType::handleDOMActivateEvent): Set m_clickLocation to (0, 0) for simulated events.
      
      LayoutTests: 
      
      * fast/events/stopPropagation-submit-expected.txt:
      * fast/forms/input-image-submit.html:
      * platform/gtk/fast/events/stopPropagation-submit-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f44b8e53
    • jer.noble@apple.com's avatar
      [MSE] Add support for VideoPlaybackMetrics. · 21b76dfd
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125380
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      Test: media/media-source/media-source-video-playback-quality.html
      
      Add a new object type VideoPlaybackQuality to be returned by
      HTMLMediaElement.getVideoPlaybackQuality().
      
      HTMLMediaElements must separately track a droppedVideoFrame count, as
      certain operations on SourceBuffer will drop incoming frames, which must
      be accounted for. Reset this count when the media engine changes, which is
      indicitive of a new media load requset starting.
      
      Add the new VideoPlaybackQuality class:
      * Modules/mediasource/VideoPlaybackQuality.cpp: Added.
      (WebCore::VideoPlaybackQuality::create):
      (WebCore::VideoPlaybackQuality::VideoPlaybackQuality):
      * Modules/mediasource/VideoPlaybackQuality.h: Added.
      (WebCore::VideoPlaybackQuality::creationTime):
      (WebCore::VideoPlaybackQuality::totalVideoFrames):
      (WebCore::VideoPlaybackQuality::droppedVideoFrames):
      (WebCore::VideoPlaybackQuality::corruptedVideoFrames):
      (WebCore::VideoPlaybackQuality::totalFrameDelay):
      * Modules/mediasource/VideoPlaybackQuality.idl: Added.
      
      Add support for the new class to HTMLMediaElement:
      * html/HTMLMediaElement.cpp:
      (HTMLMediaElement::shouldUseVideoPluginProxy):
      (HTMLMediaElement::getVideoPlaybackQuality):
      * html/HTMLMediaElement.h:
      * html/HTMLMediaElement.idl:
      
      Report the video quality metrics from the MediaPlayer:
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::totalVideoFrames):
      (WebCore::MediaPlayer::droppedVideoFrames):
      (WebCore::MediaPlayer::corruptedVideoFrames):
      (WebCore::MediaPlayer::totalFrameDelay):
      * platform/graphics/MediaPlayer.h:
      * platform/graphics/MediaPlayerPrivate.h:
      (WebCore::MediaPlayerPrivateInterface::totalVideoFrames):
      (WebCore::MediaPlayerPrivateInterface::droppedVideoFrames):
      (WebCore::MediaPlayerPrivateInterface::corruptedVideoFrames):
      (WebCore::MediaPlayerPrivateInterface::totalFrameDelay):
      
      Correctly report the dropped frame count:
      * Modules/mediasource/SourceBuffer.cpp:
      (WebCore::SourceBuffer::TrackBuffer::TrackBuffer): needsRandomAccessFlag defaults to true.
      (WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Check the sync status of the incoming sample.
      (WebCore::SourceBuffer::didDropSample): Notify the media element of a dropped frame.
      * Modules/mediasource/SourceBuffer.h:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement):
      (HTMLMediaElement::mediaPlayerEngineUpdated): Reset m_droppedFrameCount.
      (HTMLMediaElement::getVideoPlaybackQuality): Return a new VideoPlaybackQuality object.
      * html/HTMLMediaElement.h:
      (WebCore::HTMLMediaElement::incrementDroppedFrameCount): Simple incrementer.
      * platform/MediaSample.h:
      (WebCore::MediaSample::isSync): Convenience function.
      (WebCore::MediaSample::isNonDisplaying): Ditto.
      
      Add support in the AVFoundation MediaSource Engine:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalVideoFrames):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::droppedVideoFrames):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::corruptedVideoFrames):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalFrameDelay):
      
      Add support in the Mock MediaSource Engine:
      * platform/mock/mediasource/MockBox.h:
      * platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
      (WebCore::MockMediaPlayerMediaSource::totalVideoFrames): Simple accessor.
      (WebCore::MockMediaPlayerMediaSource::droppedVideoFrames): Ditto.
      (WebCore::MockMediaPlayerMediaSource::corruptedVideoFrames): Ditto.
      (WebCore::MockMediaPlayerMediaSource::totalFrameDelay): Ditto.
      * platform/mock/mediasource/MockMediaPlayerMediaSource.h:
      * platform/mock/mediasource/MockMediaSourcePrivate.cpp:
      (WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate):
      * platform/mock/mediasource/MockMediaSourcePrivate.h:
      * platform/mock/mediasource/MockSourceBufferPrivate.cpp:
      (WebCore::MockSourceBufferPrivate::enqueueSample): Increment the frame counts based on
          the incoming sample.
      * platform/mock/mediasource/MockSourceBufferPrivate.h:
      
      Add the new files to the project:
      * bindings/gobject/GNUmakefile.am:
      * DerivedSources.make:
      * WebCore.xcodeproj/project.pbxproj:
      * GNUMakefile.list.am:
      * CMakeLists.txt:
      
      LayoutTests:
      
      * media/media-source/media-source-video-playback-quality-expected.txt: Added.
      * media/media-source/media-source-video-playback-quality.html: Added.
      * media/media-source/mock-media-source.js:
      (var):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21b76dfd
    • rniwa@webkit.org's avatar
      Implement Document.cloneNode() · 62d23d55
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=11646
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Merge https://chromium.googlesource.com/chromium/blink/+/dc7879025e01d63be9fcf6a84ca6c9b8b5768a80
      
      Implement the behavior specified in the current DOM4 working draft:
      http://www.w3.org/TR/2013/WD-dom-20131107/#dom-node-clonenode
      
      Tests: fast/dom/Document/clone-node.html
             fast/dom/HTMLDocument/clone-node-quirks-mode.html
             svg/custom/clone-node.html
      
      * dom/Document.cpp:
      (WebCore::Document::cloneNode):
      (WebCore::Document::cloneDocumentWithoutChildren):
      (WebCore::Document::cloneDataFromDocument):
      * dom/Document.h:
      * html/HTMLDocument.cpp:
      (WebCore::HTMLDocument::cloneDocumentWithoutChildren):
      * html/HTMLDocument.h:
      * svg/SVGDocument.cpp:
      (WebCore::SVGDocument::cloneDocumentWithoutChildren):
      * svg/SVGDocument.h:
      
      LayoutTests: 
      
      * dom/xhtml/level3/core/documentgetinputencoding04-expected.txt:
      * dom/xhtml/level3/core/documentgetxmlencoding05-expected.txt:
      * dom/xhtml/level3/core/nodeisequalnode01-expected.txt:
      * dom/xhtml/level3/core/nodeisequalnode21-expected.txt:
      * dom/xhtml/level3/core/nodeisequalnode25-expected.txt:
      * dom/xhtml/level3/core/nodeisequalnode26-expected.txt:
      * fast/dom/Document/clone-node-expected.txt: Added.
      * fast/dom/Document/clone-node.html: Added.
      * fast/dom/HTMLDocument/clone-node-quirks-mode-expected.txt: Added.
      * fast/dom/HTMLDocument/clone-node-quirks-mode.html: Added.
      * svg/custom/clone-node-expected.txt: Added.
      * svg/custom/clone-node.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62d23d55
    • mario.prada@samsung.com's avatar
      [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR · 477a556f
      mario.prada@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125456
      
      Reviewed by Chris Fleizach.
      
      Tools:
      
      Return 'AXSection' for section roles instead of 'AXDiv'.
      
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      
      LayoutTests:
      
      Update expectations for GTK and EFL that were expecting AXDiv for
      section roles, so they now expect AXSection.
      
      * accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
      * accessibility/div-within-anchors-causes-crash-expected.txt:
      * platform/efl-wk1/accessibility/image-map2-expected.txt:
      * platform/efl-wk1/accessibility/transformed-element-expected.txt:
      * platform/efl-wk2/accessibility/image-map2-expected.txt:
      * platform/efl-wk2/accessibility/transformed-element-expected.txt:
      * platform/efl/accessibility/media-emits-object-replacement-expected.txt:
      * platform/gtk/accessibility/aria-roles-unignored-expected.txt:
      * platform/gtk/accessibility/aria-roles-unignored.html:
      * platform/gtk/accessibility/entry-and-password-expected.txt:
      * platform/gtk/accessibility/image-map2-expected.txt:
      * platform/gtk/accessibility/media-emits-object-replacement-expected.txt:
      * platform/gtk/accessibility/object-with-title-expected.txt:
      * platform/gtk/accessibility/object-with-title.html:
      * platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
      * platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:
      * platform/gtk/accessibility/spans-paragraphs-and-divs.html:
      * platform/gtk/accessibility/transformed-element-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      477a556f
    • commit-queue@webkit.org's avatar
      Fix handling of 'inherit' and 'initial' for grid lines. · 04ecf467
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125223
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-12-09
      Reviewed by Darin Adler.
      
      'initial' and 'inherit' are always allowed values for CSS properties.
      As the CSSParser handles them automatically, those 2 values were never
      taken care of in StyleResolver, leading to crashes.
      
      Source/WebCore:
      
      Added tests cases for 'inherit' and 'initial' to the following tests:
      
      fast/css-grid-layout/grid-item-column-row-get-set.html
      fast/css-grid-layout/grid-item-end-after-get-set.html
      fast/css-grid-layout/grid-item-start-before-get-set.html
      
      Patch backported from Blink: https://src.chromium.org/viewvc/blink?revision=149257&view=revision
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::applyProperty):
      * rendering/style/RenderStyle.h:
      * rendering/style/StyleGridItemData.cpp:
      (WebCore::StyleGridItemData::StyleGridItemData):
      
      LayoutTests:
      
      Patch backported from Blink: https://src.chromium.org/viewvc/blink?revision=149257&view=revision
      
      * fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
      * fast/css-grid-layout/grid-item-column-row-get-set.html:
      * fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
      * fast/css-grid-layout/grid-item-end-after-get-set.html:
      * fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
      * fast/css-grid-layout/grid-item-start-before-get-set.html:
      * fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04ecf467
    • rniwa@webkit.org's avatar
      Add a test for style sharing if grandparents matches different rule chain and nth-last child · df92752f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125397
      
      Reviewed by Darin Adler.
      
      Add the test from https://chromium.googlesource.com/chromium/blink/+/30ff49bf63cdec31070ab4eda8784564f56789d4
      and https://chromium.googlesource.com/chromium/blink/+/3cb1724bb52f3607006ddd0a89d356da23766115
      so that we may not introduce the same regressions in WebKit.
      
      * fast/css/nth-last-child-recalc-expected.html: Added.
      * fast/css/nth-last-child-recalc.html: Added.
      * fast/css/style-sharing-grand-parent-invalidate-expected.txt: Added.
      * fast/css/style-sharing-grand-parent-invalidate.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df92752f
    • jdiggs@igalia.com's avatar
      AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests · 01279e99
      jdiggs@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125451
      
      Reviewed by Mario Sanchez Prada.
      
      Source/WebKit/gtk:
      
      * tests/testatk.c: Remove the tests which now exist as layout tests. Note that the
      tests for atk_text_get_text_{before,after}_offset were removed without equivalents
      added to the layout tests. The same is true for the END AtkTextBoundary types. Both
      have been deprecated in ATK and are not being used by AT-SPI2 assistive technologies.
      (testGetTextFunction):
      (main):
      
      Tools:
      
      Create the needed callbacks for DRT and WKTR.
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (characterAtOffsetCallback): added
      (wordAtOffsetCallback): added
      (lineAtOffsetCallback): added
      (sentenceAtOffsetCallback): added
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (stringAtOffset): added
      (AccessibilityUIElement::characterAtOffset): added
      (AccessibilityUIElement::wordAtOffset): added
      (AccessibilityUIElement::lineAtOffset): added
      (AccessibilityUIElement::sentenceAtOffset): added
      * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
      (WTR::AccessibilityUIElement::characterAtOffset): added
      (WTR::AccessibilityUIElement::wordAtOffset): added
      (WTR::AccessibilityUIElement::lineAtOffset): added
      (WTR::AccessibilityUIElement::sentenceAtOffset): added
      * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
      * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::stringAtOffset): added
      (WTR::AccessibilityUIElement::characterAtOffset): added
      (WTR::AccessibilityUIElement::wordAtOffset): added
      (WTR::AccessibilityUIElement::lineAtOffset): added
      (WTR::AccessibilityUIElement::sentenceAtOffset): added
      
      LayoutTests:
      
      New tests and expectations based on the tests and expectations found in atktest.c.
      These were done as platform-specific tests because only ATK-based assistive technologies
      seem to have any need for this support.
      
      * platform/gtk/accessibility/text-at-offset-embedded-objects-expected.txt: Added.
      * platform/gtk/accessibility/text-at-offset-embedded-objects.html: Added.
      * platform/gtk/accessibility/text-at-offset-newlines-expected.txt: Added.
      * platform/gtk/accessibility/text-at-offset-newlines.html: Added.
      * platform/gtk/accessibility/text-at-offset-preformatted-expected.txt: Added.
      * platform/gtk/accessibility/text-at-offset-preformatted.html: Added.
      * platform/gtk/accessibility/text-at-offset-simple-expected.txt: Added.
      * platform/gtk/accessibility/text-at-offset-simple.html: Added.
      * platform/gtk/accessibility/text-at-offset-special-chars-expected.txt: Added.
      * platform/gtk/accessibility/text-at-offset-special-chars.html: Added.
      * platform/gtk/accessibility/text-at-offset-textarea-expected.txt: Added.
      * platform/gtk/accessibility/text-at-offset-textarea.html: Added.
      * platform/gtk/accessibility/text-at-offset-textinput-expected.txt: Added.
      * platform/gtk/accessibility/text-at-offset-textinput.html: Added.
      * platform/gtk/accessibility/text-at-offset-wrapped-lines-expected.txt: Added.
      * platform/gtk/accessibility/text-at-offset-wrapped-lines.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01279e99
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 075ef665
      m.pakula@samsung.com authored
      Add failure test expectations and rebaselines for failing tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/efl-wk1/fast/forms/validation-message-appearance-expected.png: Rebaseline after r159915.
      * platform/efl-wk2/fast/forms/validation-message-appearance-expected.png: Ditto.
      * platform/efl/fast/forms/validation-message-appearance-expected.txt: Ditto.
      * platform/efl/fast/parser/entity-comment-in-textarea-expected.png: Rebaseline after r159192.
      * platform/efl/fast/parser/entity-comment-in-textarea-expected.txt: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      075ef665