1. 13 Dec, 2013 29 commits
    • ap@apple.com's avatar
      WebCrypto Key.usages should be ordered alphabetically · 20890d48
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125696
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      * crypto/CryptoKey.cpp: (WebCore::CryptoKey::usages): Do it.
      
      LayoutTests: 
      
      * crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
      * crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
      * crypto/subtle/aes-cbc-encrypt-decrypt.html:
      * crypto/subtle/aes-cbc-generate-key-expected.txt:
      * crypto/subtle/aes-cbc-generate-key.html:
      * crypto/subtle/aes-cbc-invalid-length-expected.txt:
      * crypto/subtle/aes-cbc-invalid-length.html:
      * crypto/subtle/aes-kw-wrap-unwrap-aes-expected.txt:
      * crypto/subtle/aes-kw-wrap-unwrap-aes.html:
      * crypto/subtle/aes-postMessage-expected.txt:
      * crypto/subtle/aes-postMessage.html:
      * crypto/subtle/hmac-postMessage-expected.txt:
      * crypto/subtle/hmac-postMessage.html:
      * crypto/subtle/jwk-import-use-values-expected.txt:
      * crypto/subtle/jwk-import-use-values.html:
      * crypto/subtle/postMessage-worker-expected.txt:
      * crypto/subtle/postMessage-worker.html:
      * crypto/subtle/resources/postMessage-worker.js:
      (onmessage):
      * crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
      * crypto/subtle/rsa-oaep-key-manipulation.html:
      * crypto/subtle/rsa-oaep-wrap-unwrap-aes-expected.txt:
      * crypto/subtle/rsa-oaep-wrap-unwrap-aes.html:
      * crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt:
      * crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20890d48
    • darin@apple.com's avatar
      Make some optimizations for DOM bindings involving vectors · d805dc48
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125680
      
      Reviewed by Andreas Kling.
      
      * bindings/js/JSDOMBinding.h:
      (WebCore::toJS): Removed unnecessary copying of vectors when converting them
      to JavaScript values.
      (WebCore::toRefPtrNativeArray): Use reserveInitialCapacity and uncheckedAppend.
      (WebCore::toNativeArray): Ditto.
      (WebCore::toNativeArguments): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d805dc48
    • carlosgc@webkit.org's avatar
      REGRESSION(r155784): [GTK] Some methods incorrectly removed in r155784 and deprecated in r158662 · cb5d2466
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125692
      
      Reviewed by Martin Robinson.
      
      In r155784 the build was fixed by skipping Console::profile() and
      Console::profileEnd(), but the patch also skipped other methods
      containing the profile method name. Those were incorrectly
      deprecated in r158662 thinking that the property had been removed
      in the idl.
      
      * bindings/gobject/WebKitDOMDeprecated.cpp: Undeprecate
      webkit_dom_html_head_element_get_profile and
      webkit_dom_html_head_element_set_profile.
      * bindings/gobject/WebKitDOMDeprecated.h: Ditto.
      * bindings/gobject/WebKitDOMDeprecated.symbols: Ditto.
      * bindings/scripts/CodeGeneratorGObject.pm:
      (SkipFunction): Skip webkit_dom_console_profile and
      webkit_dom_console_profile_end.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb5d2466
    • rwlbuis@webkit.org's avatar
      Clean up SVGScriptElement · 3493ab27
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125527
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      From the Blink port of this bug it becomes clear that svg/dom/SVGScriptElement/script-set-href.svg and
      svg/dom/svg-element-attribute-js-null.xhtml still hit an assert in Debug because SVGNames::typeAttr can't
      be used with fastGetAttribute in all cases, because it can be animatable. However for SVGScriptElement
      it is not animatable, so make isAnimatableAttribute virtual (note Debug only method) and allow typeAttr
      in the SVGScriptElement case to be useable for fastGetAttribute.
      
      Test: svg/dom/SVGScriptElement/script-type-attribute.svg
      
      * svg/SVGElement.h:
      * svg/SVGScriptElement.cpp:
      (WebCore::SVGScriptElement::isAnimatableAttribute):
      * svg/SVGScriptElement.h:
      
      LayoutTests:
      
      Add test to verify the new type getter/setter behavior on SVScriptElement.
      Specifically, the old behavior was setting the JS type property did not reflect in
      the actual content attribute being set, the new behavior is to do set the content
      attribute when setting the JS type property.
      
      * svg/dom/SVGScriptElement/script-type-attribute-expected.txt: Added.
      * svg/dom/SVGScriptElement/script-type-attribute.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3493ab27
    • carlosgc@webkit.org's avatar
      [GTK] Expose also webkit_dom_document_get_url · 35431ffe
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125691
      
      Reviewed by Martin Robinson.
      
      For some reason we expose the URL property, so it can be accessed
      with g_object_get(), but we have a special case to not provide a
      public getter.
      
      * bindings/gobject/webkitdom.symbols: Add new symbol.
      * bindings/scripts/CodeGeneratorGObject.pm:
      (GenerateFunctions): Remove the special case of URL property.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35431ffe
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 66face18
      m.pakula@samsung.com authored
      Remove wrong http baselines.
      
      * platform/efl/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Removed.
      * platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
      * platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66face18
    • akling@apple.com's avatar
      CSSFilterImageValue constructor should require both image and filter. · df0176f3
      akling@apple.com authored
      <https://webkit.org/b/125056>
      
      Make the CSSFilterImageValue::create() helper take both the image and
      filter CSSValues by PassRef since they should never be null.
      
      Tweaked ComputedStyleExtractor::valueForFilter() to return a PassRef
      for this to work.
      
      Reviewed by Anders Carlsson.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df0176f3
    • carlosgc@webkit.org's avatar
      [GTK] Add a unit tests to WebKit2 to test node names · a97fa34f
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125686
      
      Reviewed by Gustavo Noronha Silva.
      
      * UIProcess/API/gtk/tests/DOMNodeTest.cpp:
      (WebKitDOMNodeTest::testTagNames):
      (WebKitDOMNodeTest::runTest):
      (registerTests):
      * UIProcess/API/gtk/tests/TestDOMNode.cpp:
      (testWebKitDOMNodeTagNames):
      (beforeAll):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a97fa34f
    • akling@apple.com's avatar
      StyleResolver::adjustRenderStyle() should take RenderStyle references. · 780a04c0
      akling@apple.com authored
      <https://webkit.org/b/125623>
      
      This function doesn't handle null styles being passed, so prevent
      it at compile time.
      
      Reviewed by Anders Carlsson.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      780a04c0
    • zandobersek@gmail.com's avatar
      [GTK] Remove the -Wno-c++11-extensions compiler option for Clang builds · e6c627e6
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125639
      
      Reviewed by Anders Carlsson.
      
      * Source/autotools/SetupCompilerFlags.m4: The -Wno-c++11-extensions compiler option was in use
      when building with Clang. It is now removed as the C++11 standard is enabled throughout the project.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6c627e6
    • zandobersek@gmail.com's avatar
      Unreviewed. Further GTK WK2 build fixes after r160504. · bdaed19e
      zandobersek@gmail.com authored
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkit_web_view_get_snapshot):
      * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
      (didInitiateLoadForResource):
      (willSendRequestForFrame):
      (didReceiveResponseForResource):
      (didReceiveContentLengthForResource):
      (didFinishLoadForResource):
      (didFailLoadForResource):
      (webkitWebPageDidReceiveMessage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdaed19e
    • darin@apple.com's avatar
      Eliminate awkward virtualComputedStyle construction · d8ecd202
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125681
      
      Reviewed by Andreas Kling.
      
      * dom/Element.cpp:
      (WebCore::Element::computedStyle): Tweak coding style a bit.
      
      * dom/Element.h: Marked computedStyle virtual and got rid of virtualComputedStyle.
      This fixes a bug that we would not call SVGElement::computedStyle if we called
      it through an Element pointer or reference. Not sure how to get test coverage for this.
      
      * dom/Node.cpp:
      (WebCore::Node::computedStyle): Use a loop instead of recursive virtual calls.
      
      * dom/Node.h: Made computedStyle virtual and got rid of virtualComputedStyle.
      
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::computedStyle): Tweak coding style a bit.
      
      * svg/SVGElement.h: Made computedStyle virtual (and FINAL) and got rid fo
      virtualComputedStyle.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8ecd202
    • darin@apple.com's avatar
      Fix a couple stray uses of RefPtr that should release · 03347ab4
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125679
      
      Reviewed by Andreas Kling.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFilter): Add calls to release, in
      one case rearranging the order of operations slightly so we
      don't release the pointer before using it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03347ab4
    • ap@apple.com's avatar
      WebCrypto wrapKey operation doesn't check key usage · 1ab645b4
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125675
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Tests: crypto/subtle/unwrapKey-check-usage.html
             crypto/subtle/wrapKey-check-usage.html
      
      * bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::wrapKey):
      Added accidentally omitted code. Other operations are fine.
      
      LayoutTests: 
      
      * crypto/subtle/unwrapKey-check-usage-expected.txt: Added.
      * crypto/subtle/unwrapKey-check-usage.html: Added.
      * crypto/subtle/wrapKey-check-usage-expected.txt: Added.
      * crypto/subtle/wrapKey-check-usage.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ab645b4
    • zandobersek@gmail.com's avatar
      Unreviewed GTK build fix after r160509. · bca07ebb
      zandobersek@gmail.com authored
      * GNUmakefile.list.am: MessageSender.(cpp|h) files were moved to Platform/IPC.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bca07ebb
    • ossy@webkit.org's avatar
      GTK buildfix after r160504. · 3019ec4f
      ossy@webkit.org authored
      Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-13
      Reviewed by Csaba Osztrogonác.
      
      * UIProcess/API/gtk/WebKitWebContext.cpp:
      (webkit_web_context_prefetch_dns):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3019ec4f
    • mrobinson@webkit.org's avatar
      Adding a .ycm_extra_conf file for webkitGtk · ba9e8de2
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119618
      
      Patch by Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2013-12-11
      Reviewed by Gustavo Noronha Silva.
      
      Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
      read the GTK+ build files to determine dynamically what flags to compile a source
      file with. This allows Vim to provide auto-complete for C++/C language. See
      https://github.com/Valloric/YouCompleteMe for how to use this file.
      
      .:
      
      * .gitignore: Ignore the YCM symlinks in the tree.
      
      Tools:
      
      * gtk/common.py:
      (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
      * gtk/ycm_extra_conf.py: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba9e8de2
    • commit-queue@webkit.org's avatar
      Need ObjC APIs for some InjectedBundle classes. · 5cc119f3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125600
      
      Add ObjC API classes for WebFrame, InjectedBundleScriptWorld, InjectedBundleHitTestResult and InjectedBundleNodeHandle.
      
      Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-12-12
      Reviewed by Dan Bernstein.
      
      * Shared/Cocoa/APIObject.mm: creates API wrapper for WebFrame, InjectedBundleScriptWorld, InjectedBundleHitTestResult
           and InjectedBundleNodeHandle.
      (API::Object::newObject):
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/InjectedBundle/API/Cocoa: Added.
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Added.
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm: Added.
      (-[WKWebProcessPlugInFrame dealloc]):
      (-[WKWebProcessPlugInFrame jsContextForWorld:]): returns the JSContextRef for a ScriptWorld in frame.
      (-[WKWebProcessPlugInFrame hitTest:]): returns hitTestResult (with API type) from a hitTest.
      (-[WKWebProcessPlugInFrame jsWrapperForNodeHandle:inWorld:]):
      (-[WKWebProcessPlugInFrame API::]):
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrameInternal.h: Added.
      (WebKit::wrapper):
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.h: Added.
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm: Added.
      (-[WKWebProcessPlugInHitTestResult dealloc]):
      (-[WKWebProcessPlugInHitTestResult nodeHandle]):
      (-[WKWebProcessPlugInHitTestResult API::]):
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResultInternal.h: Added.
      (WebKit::wrapper):
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h: Added.
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm: Added.
      (-[WKWebProcessPlugInNodeHandle dealloc]):
      (-[WKWebProcessPlugInNodeHandle API::]):
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandleInternal.h: Added.
      (WebKit::wrapper):
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.h: Added.
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm: Added.
      (+[WKWebProcessPlugInScriptWorld world]): returns a new isolated world.
      (+[WKWebProcessPlugInScriptWorld normalWorld]): returns the mainThread normal world.
      (-[WKWebProcessPlugInScriptWorld dealloc]):
      (-[WKWebProcessPlugInScriptWorld API::]):
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorldInternal.h: Added.
      (WebKit::wrapper):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cc119f3
    • benjamin@webkit.org's avatar
      Fix unsafe memory load/store from the argument encoder/decoder affecting ARM · 85710b18
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125674
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-12
      Reviewed by Darin Adler.
      
      Depending on the CPU and CPU config, load and store may have to be aligned.
      The argument buffer has no particular alignment which can cause problems.
      
      In this case, on ARMv7, strd and ldrd can have alignment restriction on 16 bytes.
      The code encoding double and 64 bits integers was causing bugs.
      
      To avoid problems, the encoders/decoders are modified to just use memcpy. The compiler optimizes
      it away for the right instructions (clang uses two ldr/str in the case of 64bits values on ARMv7).
      
      * Platform/CoreIPC/ArgumentDecoder.cpp:
      (CoreIPC::decodeValueFromBuffer):
      (CoreIPC::ArgumentDecoder::decode):
      * Platform/CoreIPC/ArgumentEncoder.cpp:
      (CoreIPC::copyValueToBuffer):
      (CoreIPC::ArgumentEncoder::encode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85710b18
    • darin@apple.com's avatar
      Make some improvements in CSSImageGeneratorValue code · 044e722b
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125676
      
      Reviewed by Simon Fraser.
      
      * css/CSSCrossfadeValue.cpp:
      (WebCore::subimageKnownToBeOpaque): Take a reference to the CSSValue, since
      it's known not to be null. Used checked cast.
      (WebCore::CSSCrossfadeValue::knownToBeOpaque): Updated to pass a reference.
      
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::saveCachedImageForSize): Use
      make_unique instead of adoptPtr.
      (WebCore::CSSImageGeneratorValue::subimageIsPending): Use checked cast.
      (WebCore::CSSImageGeneratorValue::cachedImageForCSSValue): Ditto, also
      use nullptr.
      
      * css/CSSImageGeneratorValue.h: Removed unneeded includes, added some forward
      declarations, used unique_ptr instead of OwnPtr, and used CSS_VALUE_TYPE_CASTS
      macro to create cast functions.
      
      * css/CSSValue.cpp: Removed unneeded include of CSSImageGeneratorValue.h.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::State::clear): Use nullptr instead of 0.
      (WebCore::StyleResolver::applyProperty): Use checked cast and pass references
      instead of pointers to StyleGeneratedImage::create.
      (WebCore::StyleResolver::styleImage): Use checked cast and pass references
      instead of pointers to generatedOrPendingFromValue.
      (WebCore::StyleResolver::generatedOrPendingFromValue): Take the value as a
      reference instead of a pointer.
      (WebCore::StyleResolver::loadPendingImage): Pass a refernece instead of a
      pointer to StyleGeneratedImage::create.
      (WebCore::StyleResolver::loadPendingImages): Use auto for iteration instead of
      a lot type name.
      
      * css/StyleResolver.h: Changed generatedOrPendingFromValue to take the value
      as a reference instead of a pointer.
      
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::blendFilter): Pass a reference insted of a pointer to
      StyleGeneratedImage::create.
      (WebCore::crossfadeBlend): Ditto.
      (WebCore::blendFunc): Ditto. Also use references for local variables.
      
      * rendering/style/StyleGeneratedImage.cpp:
      (WebCore::StyleGeneratedImage::StyleGeneratedImage): Use PassRef instead of
      PassRefPtr for the argument type.
      (WebCore::StyleGeneratedImage::cssValue): Updated since m_imageGeneratorValue
      is now a Ref instead of a RefPtr. Sadly this requires a const_cast that we can
      come back and get rid of later.
      (WebCore::StyleGeneratedImage::imageSize): Ditto.
      (WebCore::StyleGeneratedImage::image): Ditto.
      
      * rendering/style/StyleGeneratedImage.h: Changed create function and constructor
      to take a PassRef. Made imageValue non-const since it returns a non-const value,
      to be consistent with "conceptual const". Changed m_imageGeneratorValue to be a
      Ref instead of a RefPtr.
      
      * rendering/style/StyleImage.h: Made WrappedImagePtr be const void*, since it's
      a pointer used only for equality checks. Not a great idiom, but fine to use a
      const pointer instead of non-const, and avoids the const_cast we'd otherwise
      need in StyleGeneratedImage::data.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      044e722b
    • commit-queue@webkit.org's avatar
      Improve the find word boundary performance · 869a67e6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125619
      
      In endWordBoundary case, the textBreakPrevious call in findWordBoundary is unnecessary.
      So use separate function for endWordBoundary can improve the performance.
      
      Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-12-12
      Reviewed by Darin Adler.
      
      No tests because no operation changes.
      
      * editing/VisibleUnits.cpp: Use findEndWordBoundary in endWordBoundary
      (WebCore::endWordBoundary):
      * platform/text/TextBoundaries.cpp: Add findEndWordBoundary function
      (WebCore::findEndWordBoundary):
      * platform/text/TextBoundaries.h:
      * platform/text/mac/TextBoundaries.mm: Add findEndWordBoundary function
      (WebCore::findEndWordBoundary):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      869a67e6
    • benjamin@webkit.org's avatar
      Fix a silly mistake of r160467 · 85077e17
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125657
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-12
      Reviewed by Alexey Proskuryakov.
      
      Fix a typo. The validity check was missing the logical not.
      
      * platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::shouldUseCredentialStorage):
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
      (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85077e17
    • commit-queue@webkit.org's avatar
      Add a few more ASCIILiterals · ed3ac9b6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125662
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-12-12
      Reviewed by Darin Adler.
      
      * inspector/InspectorBackendDispatcher.cpp:
      (Inspector::InspectorBackendDispatcher::dispatch):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed3ac9b6
    • timothy_horton@apple.com's avatar
      Build fix for 32-bit. · 9abe95ac
      timothy_horton@apple.com authored
      There was no reason for these to be CGFloat.
      
      * UIProcess/mac/ViewGestureController.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9abe95ac
    • timothy_horton@apple.com's avatar
      [wk2] Handle pinch-to-zoom gesture · 9f736b0a
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125604
      
      Reviewed by Simon Fraser.
      
      Add the concept of a "transient" zoom to DrawingArea, which is a zoom
      that affects the content, but does not cause repaint, as would be used
      for a live pinch-zoom gesture.
      
      Add ViewGestureController, which currently only handles magnification
      gestures, and keeps track of the current gesture's scale and origin, and
      forwards relevant events on to the DrawingArea via the transient zoom mechanism.
      
      * DerivedSources.make:
      Add ViewGestureController to the list of message receivers.
      
      * UIProcess/API/Cocoa/WKViewPrivate.h:
      Add shouldHandleMagnificationGesture property, which controls whether WKView will
      attempt to handle magnifyWithEvent:.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView waitForAsyncDrawingAreaSizeUpdate]):
      Fix a typo.
      
      (-[WKView _ensureGestureController]):
      Create our ViewGestureController if it doesn't already exist.
      
      (-[WKView setAllowsMagnification:]):
      (-[WKView allowsMagnification]):
      SPI to enable/disable handling the magnification gesture.
      
      (-[WKView setMagnification:centeredAtPoint:]):
      (-[WKView setMagnification:]):
      (-[WKView magnification]):
      Adjust or retrieve the current page scale.
      The variant of setMagnification that does not take an origin uses the view's center.
      
      (-[WKView magnifyWithEvent:]):
      
      (-[WKView endGestureWithEvent:]):
      Forward gesture methods to ViewGestureController.
      
      * UIProcess/mac/ViewGestureController.cpp: Added.
      (WebKit::ViewGestureController::create):
      (WebKit::ViewGestureController::ViewGestureController):
      (WebKit::ViewGestureController::~ViewGestureController):
      (WebKit::resistanceForDelta):
      Compute a resistance factor, which makes it feel "hard" to zoom out past
      scale=1, and accelerates scaling out before you hit scale=1.
      
      (WebKit::ViewGestureController::scaledMagnificationOrigin):
      Compute the origin of the magnification gesture with the transient zoom unapplied.
      
      (WebKit::ViewGestureController::handleMagnificationGesture):
      The first magnification gesture will send a message to the WebProcess
      to retrieve the visible content rect. Subsequent gestures will
      hand the new magnification and origin to the DrawingArea to apply.
      
      (WebKit::ViewGestureController::didBeginTransientZoom):
      Callback from the WebProcess, with the current visible content rect.
      Subsequent magnification gestures will forward the scale and origin to the DrawingArea.
      
      (WebKit::ViewGestureController::endMagnificationGesture):
      Commit the current transient scale as the actual page scale, which will cause
      a repaint and bring in all the tiles.
      
      (WebKit::ViewGestureController::endActiveGesture):
      If we have an active gesture, call its end function.
      
      * UIProcess/mac/ViewGestureController.h: Added.
      * UIProcess/mac/ViewGestureController.messages.in: Added.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Add new files.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::beginTransientZoom):
      Call back to ViewGestureController with the visibleContentRect.
      
      (WebKit::TiledCoreAnimationDrawingArea::adjustTransientZoom):
      Scale and translate the RenderView's PlatformCALayer.
      Reaching into the layer tree like this is scary, we should consider
      teaching RenderLayerCompositor about transient zoom.
      Hide the content shadow layer for now.
      
      (WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
      Clear our custom transform on the RenderView's layer, and
      change the actual page scale, causing a repaint.
      Un-hide the shadow layer.
      
      * UIProcess/DrawingAreaProxy.h:
      (WebKit::DrawingAreaProxy::beginTransientZoom):
      (WebKit::DrawingAreaProxy::adjustTransientZoom):
      (WebKit::DrawingAreaProxy::commitTransientZoom):
      * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
      * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
      (WebKit::TiledCoreAnimationDrawingAreaProxy::beginTransientZoom):
      (WebKit::TiledCoreAnimationDrawingAreaProxy::adjustTransientZoom):
      (WebKit::TiledCoreAnimationDrawingAreaProxy::commitTransientZoom):
      * WebProcess/WebPage/DrawingArea.h:
      (WebKit::DrawingArea::beginTransientZoom):
      (WebKit::DrawingArea::adjustTransientZoom):
      (WebKit::DrawingArea::commitTransientZoom):
      * WebProcess/WebPage/DrawingArea.messages.in:
      Generic plumbing for {begin, adjust, end}TransientZoom.
      
      * WebCore.exp.in:
      Export some TransformationMatrix functions.
      
      * WebCore.xcodeproj/project.pbxproj:
      Make some headers private so that RenderLayerCompositor/Backing can be used from WebKit2.
      
      * rendering/RenderLayerCompositor.h:
      (WebCore::RenderLayerCompositor::layerForContentShadow):
      Add a getter for the content shadow layer.
      
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController awakeFromNib]):
      Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f736b0a
    • eunmi15.lee@samsung.com's avatar
      Unreviewed. Add myself as a committer. · ee746b16
      eunmi15.lee@samsung.com authored
      * Scripts/webkitpy/common/config/contributors.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee746b16
    • beidson@apple.com's avatar
      DatabaseProcess IndexedDB: Establish a metadata backing store on disk · 72ab4561
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125258
      
      Reviewed by Alexey Proskuryakov, Anders Carlsson, and Tim Horton.
      
      Source/WebCore:
      
      Teach CrossThreadCopier how to handle IDBDatabaseMetadata.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      
      * Modules/indexeddb/IDBDatabaseMetadata.cpp: Added.
      (WebCore::IDBDatabaseMetadata::isolatedCopy):
      (WebCore::IDBObjectStoreMetadata::isolatedCopy):
      (WebCore::IDBIndexMetadata::isolatedCopy):
      * Modules/indexeddb/IDBDatabaseMetadata.h:
      
      * Modules/indexeddb/IDBKeyPath.cpp:
      (WebCore::IDBKeyPath::isolatedCopy):
      * Modules/indexeddb/IDBKeyPath.h:
      
      * platform/CrossThreadCopier.cpp:
      (WebCore::::copy): Add an IDBDatabaseMetadata specialization.
      * platform/CrossThreadCopier.h:
      
      Source/WebKit2:
      
      The DatabaseProcess already has an "Indexed Database path".
      Each SecurityOrigin with indexed databases will have a subdirectory under the path.
      Each indexed database will have a subdirectory under its SecurityOrigin's path.
      Inside that directory will exist (1) metadata database, and 0-N ObjectStore databases.
      
      This patch establishes the directory structure and the (1) metadata database.
      
      * DatabaseProcess/DatabaseProcess.cpp:
      (WebKit::DatabaseProcess::initializeDatabaseProcess): Asynchronously ensure the indexed database directory exists.
      (WebKit::DatabaseProcess::ensureIndexedDatabaseRelativePathExists): Allow anyone to make necessary directories relative to
        the indexed database directory.
      (WebKit::DatabaseProcess::ensurePathExists):
      (WebKit::DatabaseProcess::absoluteIndexedDatabasePathFromDatabaseRelativePath): Instead of exposing the indexed database directory,
        give DatabaseProcess a method to allow others to compute a path relative to the indexed database directory.
      (WebKit::DatabaseProcess::postDatabaseTask):
      (WebKit::DatabaseProcess::performNextDatabaseTask):
      * DatabaseProcess/DatabaseProcess.h:
      (WebKit::DatabaseProcess::queue):
      
      * DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
      (WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):
      
      * DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
      (WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
      (WebKit::UniqueIDBDatabase::filenameForDatabaseName):
      (WebKit::UniqueIDBDatabase::databaseFilenameIdentifier):
      (WebKit::UniqueIDBDatabase::canShareDatabases):
      (WebKit::UniqueIDBDatabase::shutdown): Method to cleanly shutdown a database, emptying its task and request queues.
      (WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata):
      (WebKit::UniqueIDBDatabase::openBackingStoreAndReadMetadata): To be run on the database work queue, establishes a backing store
        and extracts metadata from it.
      (WebKit::UniqueIDBDatabase::didOpenBackingStoreAndReadMetadata): Callback once metadata from the backing store is ready for use.
      (WebKit::UniqueIDBDatabase::absoluteDatabaseDirectory):
      (WebKit::UniqueIDBDatabase::postMainThreadTask): Add a main thread task for this database.
      (WebKit::UniqueIDBDatabase::performNextMainThreadTask):
      (WebKit::UniqueIDBDatabase::postDatabaseTask): Add a database queue task for this database.
      (WebKit::UniqueIDBDatabase::performNextDatabaseTask):
      * DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
      
      Add a virtual backing store interface:
      * DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
      (WebKit::UniqueIDBDatabaseBackingStore::~UniqueIDBDatabaseBackingStore):
      
      Add a SQLite implementation of that interface:
      * DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp: Added.
      (WebKit::UniqueIDBDatabaseBackingStoreSQLite::UniqueIDBDatabaseBackingStoreSQLite):
      (WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata):
      (WebKit::UniqueIDBDatabaseBackingStoreSQLite::extractExistingMetadata):
      (WebKit::UniqueIDBDatabaseBackingStoreSQLite::openSQLiteDatabaseAtPath):
      (WebKit::UniqueIDBDatabaseBackingStoreSQLite::getOrEstablishMetadata):
      * DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
      
      Add a general purpose asynchronous task that does cross thread copying:
      * Shared/AsyncTask.h: Added.
      (WebKit::AsyncTask::~AsyncTask):
      (WebKit::AsyncTask::AsyncTask):
      (WebKit::createAsyncTask):
      
      Add more isolated copiers and introduce WebKit CrossThreadCopier specializations:
      * DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.cpp:
      (WebKit::UniqueIDBDatabaseIdentifier::isolatedCopy):
      * DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h:
      
      * Shared/SecurityOriginData.cpp:
      (WebKit::SecurityOriginData::isolatedCopy):
      * Shared/SecurityOriginData.h:
      
      * Shared/WebCrossThreadCopier.cpp:
      (WebCore::::copy):
      * Shared/WebCrossThreadCopier.h:
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      Source/WTF:
      
      * wtf/text/WTFString.h: Export toUInt64Strict().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72ab4561
    • cfleizach@apple.com's avatar
      AX: HANG: virginamerica.com: Pressing the print button on the boarding pass... · fc808ace
      cfleizach@apple.com authored
      AX: HANG: virginamerica.com: Pressing the print button on the boarding pass page locks up VoiceOver and Safari.
      https://bugs.webkit.org/show_bug.cgi?id=125603
      
      Reviewed by Anders Carlsson.
      
      Allow the print dialog to spin its run loop while accessibility is enabled so that VoiceOver does not hang on the WebProcess.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::print):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc808ace
    • ljaehun.lim@samsung.com's avatar
      Unreviewed CMake build fix after r160509 · 48c3c7f7
      ljaehun.lim@samsung.com authored
      * CMakeLists.txt: Apply MessageSender's changes
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48c3c7f7
  2. 12 Dec, 2013 11 commits
    • mitz@apple.com's avatar
      [Cocoa] Let the load delegate know when the Web process crashes · f451bf4d
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125660
      
      Reviewed by Sam Weinig.
      
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      (processDidCrash):  Implemented this WKPageLoaderClient callback by calling the load
      delegate.
      (setUpPageLoaderClient): Set the above callback in the client structure
      * UIProcess/API/Cocoa/WKBrowsingContextLoadDelegatePrivate.h: Declare new delegate method.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f451bf4d
    • lforschler@apple.com's avatar
      Update hardware for Apple bots. · 3625d47c
      lforschler@apple.com authored
              
      Unreviewed.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3625d47c
    • lforschler@apple.com's avatar
      Remove unused Apple Bots. · 413b2695
      lforschler@apple.com authored
              
      Unreviewed.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      413b2695
    • andersca@apple.com's avatar
      Move MessageSender to Platform/IPC. · 52b0864f
      andersca@apple.com authored
      Rubber-stamped by Andreas Kling.
      
      * Platform/IPC/MessageSender.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/MessageSender.cpp.
      * Platform/IPC/MessageSender.h: Renamed from Source/WebKit2/Platform/CoreIPC/MessageSender.h.
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52b0864f
    • andersca@apple.com's avatar
      WebPageProxy should be a MessageSender · 288faf7d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125654
      
      Reviewed by Sam Weinig.
      
      * Platform/CoreIPC/MessageSender.cpp:
      (CoreIPC::MessageSender::sendMessage):
      * Platform/CoreIPC/MessageSender.h:
      (CoreIPC::MessageSender::send):
      * Shared/ChildProcessProxy.h:
      * Shared/WebConnection.cpp:
      (WebKit::WebConnection::postMessage):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::initializeWebPage):
      (WebKit::WebPageProxy::sendMessage):
      (WebKit::WebPageProxy::messageSenderConnection):
      (WebKit::WebPageProxy::messageSenderDestinationID):
      * UIProcess/WebPageProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      288faf7d
    • thiago.lacerda@openbossa.org's avatar
      committer · 9987625b
      thiago.lacerda@openbossa.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9987625b
    • andersca@apple.com's avatar
      Clean up dictionary handling a little · c3661aa8
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125644
      
      Reviewed by Dan Bernstein.
      
      Add a WKDictionaryCreate function as a first step towards eliminating WKMutableDictionaryRef,
      (in the same way we've eliminated WKMutableArrayRef). Also, rename adopt to create and make it take a Map by value
      so we can use std::move where appropriate.
      
      * Shared/API/c/WKDictionary.cpp:
      (WKDictionaryCreate):
      * Shared/API/c/WKDictionary.h:
      * Shared/Cocoa/WKNSDictionary.mm:
      (-[WKNSDictionary copyWithZone:]):
      * Shared/ImmutableDictionary.cpp:
      (WebKit::ImmutableDictionary::create):
      (WebKit::ImmutableDictionary::ImmutableDictionary):
      * Shared/ImmutableDictionary.h:
      * Shared/MutableDictionary.cpp:
      (WebKit::MutableDictionary::MutableDictionary):
      * Shared/Plugins/Netscape/PluginInformation.cpp:
      (WebKit::createPluginInformationDictionary):
      * Shared/UserData.cpp:
      (WebKit::UserData::transform):
      (WebKit::UserData::decode):
      * Shared/UserMessageCoders.h:
      (WebKit::UserMessageDecoder::baseDecode):
      * UIProcess/Plugins/PlugInAutoStartProvider.cpp:
      (WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy):
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
      * UIProcess/WebDatabaseManagerProxy.cpp:
      (WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
      * UIProcess/WebFormClient.cpp:
      (WebKit::WebFormClient::willSubmitForm):
      * UIProcess/WebUIClient.cpp:
      (WebKit::WebUIClient::createNewPage):
      * WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
      (WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
      (WebKit::InjectedBundlePageFormClient::willSubmitForm):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3661aa8
    • ap@apple.com's avatar
      Add support for RSAES-PKCS1-v1_5 · d6fcbe43
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125647
      
      Build fix.
      
      * crypto/CommonCryptoUtilities.h: Declare a newly used private constant.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6fcbe43
    • ap@apple.com's avatar
      Add support for RSAES-PKCS1-v1_5 · d79ec0a0
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125647
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Tests: crypto/subtle/rsaes-pkcs1-v1_5-decrypt.html
             crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html
      
      * crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
      * crypto/algorithms/CryptoAlgorithmAES_KW.h:
      Removed meaningless parameters arguments from private functions. The base arguments
      class is always empty.
      
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSCryptoAlgorithmDictionary.cpp:
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
      * bindings/js/JSCryptoKeySerializationJWK.cpp:
      (WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
      (WebCore::JSCryptoKeySerializationJWK::keySizeIsValid):
      (WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
      * crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp: Added.
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::CryptoAlgorithmRSAES_PKCS1_v1_5):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::~CryptoAlgorithmRSAES_PKCS1_v1_5):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::create):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::identifier):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::keyAlgorithmMatches):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::generateKey):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):
      * crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h: Added.
      * crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp: Added.
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
      (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
      * crypto/mac/CryptoAlgorithmRegistryMac.cpp:
      (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
      Added support for this algorithm.
      
      LayoutTests: 
      
      * crypto/subtle/rsaes-pkcs1-v1_5-decrypt-expected.txt: Added.
      * crypto/subtle/rsaes-pkcs1-v1_5-decrypt.html: Added.
      * crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt: Added.
      * crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d79ec0a0
    • commit-queue@webkit.org's avatar
      Web Inspector: ES6: JavaScript syntax highlighting and recognition of for..of · c9ff3b34
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122868
      
      Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-12
      Reviewed by Timothy Hatcher.
      
      Update to CodeMirror 3.20 including javascript ES6 updates.
      
      * Tools/PrettyPrinting/codemirror.css:
      * Tools/PrettyPrinting/codemirror.js: Minor local change due to error from jsmin.py
      * Tools/PrettyPrinting/css.js:
      * Tools/PrettyPrinting/javascript.js:
      * UserInterface/External/CodeMirror/codemirror.css:
      * UserInterface/External/CodeMirror/codemirror.js: Minor local change due to error from jsmin.py
      * UserInterface/External/CodeMirror/coffeescript.js:
      * UserInterface/External/CodeMirror/css.js:
      * UserInterface/External/CodeMirror/htmlmixed.js:
      * UserInterface/External/CodeMirror/javascript.js:
      * UserInterface/External/CodeMirror/less.js:
      * UserInterface/External/CodeMirror/matchbrackets.js:
      * UserInterface/External/CodeMirror/placeholder.js:
      * UserInterface/External/CodeMirror/runmode.js:
      * UserInterface/External/CodeMirror/searchcursor.js:
      * UserInterface/External/CodeMirror/sql.js:
      * UserInterface/External/CodeMirror/xml.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9ff3b34
    • akling@apple.com's avatar
      [Mac] Stop not caching HTTP resources with "Vary" header in response. · 1e9e7366
      akling@apple.com authored
      <https://webkit.org/b/125483>
      <rdar://problem/11781097>
      
      Remove the workaround preventing resources with the "Vary" header
      from going into cache, as the CFNetwork cache has supported this
      for quite a while now.
      
      31.5 MB progression on Membuster3, because we can now mmap those
      resources from disk once they are in the cache.
      
      We keep the workaround on PLATFORM(WIN) for now.
      
      Reviewed by Antti Koivisto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e9e7366