1. 08 Nov, 2010 40 commits
    • crogers@google.com's avatar
      2010-11-08 Chris Rogers <crogers@google.com> · 1fc82eaf
      crogers@google.com authored
              Reviewed by Kenneth Russell.
      
              Remove obsolete PASSTHROUGH and MATRIXMIX panner mode
              https://bugs.webkit.org/show_bug.cgi?id=49087
      
              No new tests since audio API is not yet implemented.
      
              * platform/audio/Panner.cpp:
              (WebCore::Panner::create):
              * platform/audio/Panner.h:
              * webaudio/AudioPannerNode.h:
              * webaudio/AudioPannerNode.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fc82eaf
    • beidson@apple.com's avatar
      Part of https://bugs.webkit.org/show_bug.cgi?id=49222 · de4de4cf
      beidson@apple.com authored
      Rename "WebContextMenuItem" to "WebContextMenuItemData"
      
      Reviewed by Anders Carlsson.
      
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      
      * Shared/WebContextMenuItem.cpp: Removed.
      * Shared/WebContextMenuItem.h: Removed.
      * Shared/WebContextMenuItemData.cpp: Copied from Shared/WebContextMenuItem.cpp.
      (WebKit::WebContextMenuItemData::WebContextMenuItemData):
      (WebKit::WebContextMenuItemData::encode):
      (WebKit::WebContextMenuItemData::decode):
      (WebKit::kitItems):
      * Shared/WebContextMenuItemData.h: Copied from Shared/WebContextMenuItem.h.
      (WebKit::WebContextMenuItemData::submenu):
      
      * UIProcess/WebContextMenuProxy.h:
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::showContextMenu):
      (WebKit::WebPageProxy::contextMenuItemSelected):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      
      * UIProcess/mac/WebContextMenuProxyMac.h:
      * UIProcess/mac/WebContextMenuProxyMac.mm:
      (-[WebMenuTarget forwardContextMenuAction:]):
      (WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
      (WebKit::nsMenuItemVector):
      (WebKit::WebContextMenuProxyMac::populate):
      (WebKit::WebContextMenuProxyMac::showContextMenu):
      
      * UIProcess/qt/WebContextMenuProxyQt.cpp:
      (WebKit::WebContextMenuProxyQt::showContextMenu):
      * UIProcess/qt/WebContextMenuProxyQt.h:
      
      * UIProcess/win/WebContextMenuProxyWin.cpp:
      (WebKit::WebContextMenuProxyWin::showContextMenu):
      * UIProcess/win/WebContextMenuProxyWin.h:
      
      * WebProcess/WebPage/WebContextMenu.cpp:
      (WebKit::WebContextMenu::itemSelected):
      * WebProcess/WebPage/WebContextMenu.h:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::didSelectItemFromActiveContextMenu):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de4de4cf
    • paroga@webkit.org's avatar
      2010-11-08 Patrick Gansterer <paroga@webkit.org> · 9646d8b9
      paroga@webkit.org authored
              Reviewed by Adam Roben.
      
              Merge EditorWinCE.cpp into EditorWin.cpp
              https://bugs.webkit.org/show_bug.cgi?id=49095
      
              * platform/win/EditorWin.cpp:
              (WebCore::Editor::newGeneralClipboard):
              * platform/wince/EditorWinCE.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9646d8b9
    • andersca@apple.com's avatar
      Find in Page: scrolling the page with the scrollbar while overlay is up dismisses the overlay · dc2f1bf1
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49219
      <rdar://problem/8569550>
      
      Reviewed by John Sullivan and Dan Bernstein.
      
      * WebProcess/WebPage/FindPageOverlay.cpp:
      (WebKit::FindPageOverlay::bounds):
      Return the bounds of the find page overlay, excluding any scrollbars.
      
      (WebKit::FindPageOverlay::drawRect):
      Call bounds.
      
      (WebKit::FindPageOverlay::mouseEvent):
      Only dismiss the find UI if the mouse down event happens inside the overlay bounds.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc2f1bf1
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=49217 · d350017b
      hyatt@apple.com authored
              
      Reviewed by Simon Fraser.
      
      Fix coordinate space mismatch in RenderReplaced and make sure RenderText retains its old behavior of
      preferring later lines when there is overlap.
      
      WebCore: 
      
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::positionForPoint):
      * rendering/RenderText.cpp:
      (WebCore::RenderText::positionForPoint):
      
      LayoutTests: 
      
      * fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt:
      * fast/dom/Document/CaretRangeFromPoint/replace-element.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d350017b
    • andersca@apple.com's avatar
      Add the ability to send messages to DownloadProxy objects · d06a84ec
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49213
      
      Reviewed by Adam Roben.
      
      * DerivedSources.make:
      * DerivedSources.pro:
      Add Download.messages.in.
      
      * Platform/CoreIPC/MessageID.h:
      Add MessageClassDownloadProxy message class.
      
      * Platform/CoreIPC/MessageSender.h:
      Include Connection.h directly since it's required.
      
      * UIProcess/Downloads/DownloadProxy.cpp:
      (WebKit::DownloadProxy::didBegin):
      (WebKit::DownloadProxy::didCreateDestination):
      (WebKit::DownloadProxy::didFinish):
      Add stubs.
      
      * UIProcess/Downloads/DownloadProxy.messages.in: Added.
      
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::didReceiveMessage):
      Handle DownloadProxy messages.
      
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::didReceiveMessage):
      Hand DownloadProxy messages off to the context.
      
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      Add new files.
      
      * WebProcess/Downloads/Download.cpp:
      (WebKit::Download::didBegin):
      (WebKit::Download::didReceiveData):
      (WebKit::Download::didCreateDestination):
      (WebKit::Download::didFinish):
      Send messages.
      
      * WebProcess/Downloads/mac/DownloadMac.mm:
      (-[WKDownloadAsDelegate download:didCreateDestination:]):
      Call Download::didCreateDestination.
      
      * win/WebKit2.vcproj:
      Add new files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d06a84ec
    • dpranke@chromium.org's avatar
      2010-11-08 Dirk Pranke <dpranke@chromium.org> · 6a1f9591
      dpranke@chromium.org authored
              Reviewed by Eric Seidel.
      
              Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py.
              It turns out that NRWT can't use the code in scm.find_checkout_root()
              because the Chromium bots don't do full checkouts of the WebKit
              tree; they only check out subdirectories like WebKitTools/Scripts.
              Until we can figure out a better approach for this, I've
              restored the base_dir-detecting code from NRWT, which works in
              any directory tree, scm or no.
      
              This also restores the files modified in r71475 and r71474.
      
              https://bugs.webkit.org/show_bug.cgi?id=49151
      
              * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
              * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a1f9591
    • hyatt@apple.com's avatar
      Fix build bustage. · 54ad9018
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54ad9018
    • steveblock@google.com's avatar
      2010-11-08 Steve Block <steveblock@google.com> · 3fc03e36
      steveblock@google.com authored
              Reviewed by David Levin.
      
              Building for Android generates several compiler warnings
              https://bugs.webkit.org/show_bug.cgi?id=49175
      
              Fixes these warnings, most of which are trivial.
              - PREFIX_FOR_WEBCORE was previously required for STL's algorithm, but is no
                longer. See
                http://android.git.kernel.org/?p=platform/external/webkit.git;a=commit;h=a47ab5294213cca2741f453b450b02666e08cac8
              - The definition of EXPORT is required only for the JNI entry point in
                WebKit/android, so does not need to be in WebCorePrefix.h
      
              No new tests, fixes compile warnings only.
      
              * WebCorePrefix.h:
              * bridge/jni/jsc/JNIUtilityPrivate.cpp:
              (JSC::Bindings::convertValueToJValue):
              * platform/android/FileSystemAndroid.cpp:
              (WebCore::listDirectory):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fc03e36
    • noam.rosenthal@nokia.com's avatar
      Unreviewed bot fix. · 282a8380
      noam.rosenthal@nokia.com authored
      Removed a test that was added without results. Will add again later.
      
      * compositing/layer-creation/many-layers.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      282a8380
    • mitz@apple.com's avatar
      <rdar://problem/8119781> Crash zooming into Word document at office.live.com · 44fdccdb
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49203
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: fast/css/zoom-change-triggering-layout.html
      
      RenderBox::styleDidChange() was calling scrollLeft() and scrollTop(), whose RenderTextControlSingleLine
      overrides can trigger layout.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::styleDidChange): Use the layer directly for updating the scroll offsets when
      the zoom factor changes.
      
      LayoutTests: 
      
      * fast/css/zoom-change-triggering-layout-expected.txt: Added.
      * fast/css/zoom-change-triggering-layout.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44fdccdb
    • ossy@webkit.org's avatar
      Unreviewed rolling out r71567. · b721e69b
      ossy@webkit.org authored
      r71567 was incorrect, because fast/js/navigator-mimeTypes-length.html contains relative paths to js files.
      
      * fast/js/navigator-mimeTypes-length-expected.txt: Copied from LayoutTests/plugins/navigator-mimeTypes-length-expected.txt.
      * fast/js/navigator-mimeTypes-length.html: Copied from LayoutTests/plugins/navigator-mimeTypes-length.html.
      * plugins/navigator-mimeTypes-length-expected.txt: Removed.
      * plugins/navigator-mimeTypes-length.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b721e69b
    • andersca@apple.com's avatar
      Add DownloadProxy object · e4e08e28
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49211
      
      Reviewed by Adam Roben.
      
      DownloadProxy will be the implementation of the forthcoming WKDownloadRef object.
      
      * Shared/APIObject.h:
      Add TypeDownload.
      
      * UIProcess/Downloads/DownloadProxy.cpp:
      (WebKit::generateDownloadID):
      Generate a unique download ID.
      
      (WebKit::DownloadProxy::invalidate):
      Null out the web context.
      
      * UIProcess/Downloads/DownloadProxy.h:
      (WebKit::WebContext::processDidClose):
      Invalidate all downloads.
      
      (WebKit::WebContext::createDownloadProxy):
      Create a WebDownload object.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::receivedPolicyDecision):
      Call createDownloadProxy instead.
      
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      Add new files.
      
      * win/WebKit2Common.vsprops:
      Add new include path.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4e08e28
    • senorblanco@chromium.org's avatar
      2010-11-08 Stephen White <senorblanco@chromium.org> · d91c4c3f
      senorblanco@chromium.org authored
              Unreviewed; test expectations update.
      
              Add a test missing results to chromium-gpu test expectations.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d91c4c3f
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=48587 · 13869a61
      hyatt@apple.com authored
              
      Reviewed by Simon Fraser.
      
      Make Ruby work with vertical text.  Ruby already nearly does work.  The only big issue I found was with
      flipped lines writing modes.  Make sure to mutate the writing-mode of the RenderRubyRun to ensure that
      the ruby text is on the correct side of the ruby base.
      
      Added fast/blockflow tests of the various writing modes.
      
      WebCore: 
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::baselinePosition):
      (WebCore::RenderBlock::firstLineBoxBaseline):
      (WebCore::RenderBlock::lastLineBoxBaseline):
      * rendering/RenderRubyRun.cpp:
      (WebCore::RenderRubyRun::staticCreateRubyRun):
      
      LayoutTests: 
      
      * fast/blockflow/japanese-ruby-horizontal-bt.html: Added.
      * fast/blockflow/japanese-ruby-vertical-lr.html: Added.
      * fast/blockflow/japanese-ruby-vertical-rl.html: Added.
      * platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
      * platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
      * platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
      * platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13869a61
    • eric@webkit.org's avatar
      2010-11-08 Eric Seidel <eric@webkit.org> · 1d684e82
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              webkit-patch failure-reason explodes if a build is missing
              https://bugs.webkit.org/show_bug.cgi?id=49195
      
              This is likely a recent regression.  Adding a unit test for this case.
      
              * Scripts/webkitpy/common/net/buildbot.py:
              * Scripts/webkitpy/common/net/buildbot_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d684e82
    • abarth@webkit.org's avatar
      2010-11-08 Adam Barth <abarth@webkit.org> · a9af6788
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Restore normal meaning of double-click on patch review page?
              https://bugs.webkit.org/show_bug.cgi?id=47641
      
              After this patch, you need to click on the line numbers to add a
              comment.
      
              * PrettyPatch/PrettyPatch.rb:
              * code-review.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9af6788
    • bfulgham@webkit.org's avatar
      Unreviewed build correction after @70369/@70846. · e9bcc996
      bfulgham@webkit.org authored
      Please use PLATFORM(CG) to define CG-specific code, not
      PLATFORM(CF).
      
      * platform/image-decoders/ImageDecoder.cpp:
      * platform/image-decoders/ImageDecoder.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9bcc996
    • jamesr@google.com's avatar
      2010-11-08 James Robinson <jamesr@chromium.org> · 079b9e3b
      jamesr@google.com authored
              Reviewed by Dimitri Glazkov.
      
              Input element with inner spin button set to display:none causes crash
              https://bugs.webkit.org/show_bug.cgi?id=49121
      
              Adds a test for dispatching mouse events at an <input type="number"> with
              the inner spin button set to display:none does not crash.
      
              * fast/forms/input-number-spinbutton-crash-expected.txt: Added.
              * fast/forms/input-number-spinbutton-crash.html: Added.
      2010-11-08  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Input element with inner spin button set to display:none causes crash
              https://bugs.webkit.org/show_bug.cgi?id=49121
      
              Null check the inner spin button's renderer before dereferencing it.
      
              Test: fast/forms/input-number-spinbutton-crash.html
      
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::forwardEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      079b9e3b
    • tony@chromium.org's avatar
      2010-11-08 Tony Chang <tony@chromium.org> · 935661f2
      tony@chromium.org authored
              Unreviewed.  Moving a plugin test into the plugins directory.
      
              * plugins/navigator-mimeTypes-length-expected.txt: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length-expected.txt.
              * plugins/navigator-mimeTypes-length.html: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      935661f2
    • xji@chromium.org's avatar
      2010-11-08 Xiaomei Ji <xji@chromium.org> · 32dbea58
      xji@chromium.org authored
              Reviewed by Dan Bernstein.
      
              Fix Unicode explicit bidi control characters are removed in editing operations,
              such as insert/copy/cut/paste.
              https://bugs.webkit.org/show_bug.cgi?id=25321
      
              Unicode explicit bidi control characters were excluded in BidiRun and
              consequently from InlineTextBoxes due to their effect on rendering complex
              text with ATSUI.
              The fix is including those characters in BidiRun and remove them from
              ComplexTextRun with ATSUI.
      
              Test: editing/inserting/insert-paste-bidi-control.html
                     fast/text/atsui-bidi-control.html
      
              * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
              (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
              * platform/text/BidiResolver.h:
              (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel):
              (WebCore::::lowerExplicitEmbeddingLevel):
              (WebCore::::raiseExplicitEmbeddingLevel):
              (WebCore::::createBidiRunsForLine):
      2010-11-08  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              Fix Unicode explicit bidi control characters are removed in editing operations,
              such as insert/copy/cut/paste.
              https://bugs.webkit.org/show_bug.cgi?id=25321
      
              Unicode explicit bidi control characters were excluded in BidiRun and
              consequently from InlineTextBoxes due to their effect on rendering complex
              text with ATSUI.
              The fix is including those characters in BidiRun and remove them from
              ComplexTextRun with ATSUI.
      
              * editing/inserting/insert-paste-bidi-control-expected.txt: Added.
              * editing/inserting/insert-paste-bidi-control.html: Added.
              * editing/selection/extend-selection-expected.txt:
              * editing/selection/home-end-expected.txt:
              * fast/text/atsui-bidi-control-expected.txt: Added.
              * fast/text/atsui-bidi-control.html: Added.
              * platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
              * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
              * platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
              * platform/mac/fast/text/international/bidi-explicit-embedding-expected.txt:
              * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
              * platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
              * platform/mac/fast/text/international/bidi-override-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32dbea58
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · a382d70c
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=49201
              Crash when closing a page
      
              Handle null frame by passing a 0 frame id (normal ones start from 1).
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::focusedFrameChanged):
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::focusedFrameChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a382d70c
    • japhet@chromium.org's avatar
      2010-11-08 Nate Chapin <japhet@chromium.org> · 20f8a027
      japhet@chromium.org authored
              Unreviewed, build fix.
      
              Clumsy typo in r71562.
      
              * Plugins/Hosted/HostedNetscapePluginStream.mm:
              (WebKit::HostedNetscapePluginStream::start):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20f8a027
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=49126 · 1a575c3a
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      RenderBlock::positionForPoint is not writing-mode aware.  Patch the function to examine lines in the correct
      writing-mode direction.  Patched and renamed a number of helpers used by positionForPoint.
              
      Fixed a bug with RenderReplaced's positionForPoint. There was a coordinate space mismatch between what the
      function expected (local coordinates) and what was passed in (containing block coords), which meant the function didn't even work.
              
      Fixed a bug with the propagation of selection state on RenderReplaced to its containing block.  The bit double propagated
      because both the base class function and the derived class function did the propagation, and the setter function did not
      do the right thing if this happened.
              
      Patched the localSelectionRect method on RenderReplaced so that selection draws in the right place in all writing modes.
              
      Added new tests of positionForPoint and replaced elements in fast/blockflow.
      
      WebCore: 
      
      * editing/visible_units.cpp:
      (WebCore::previousLinePosition):
      (WebCore::nextLinePosition):
      * platform/graphics/IntPoint.h:
      (WebCore::IntPoint::transpose):
      * rendering/InlineBox.cpp:
      (WebCore::InlineBox::paint):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::nodeAtPoint):
      (WebCore::RenderBlock::hitTestFloats):
      (WebCore::positionForPointRespectingEditingBoundaries):
      (WebCore::RenderBlock::positionForPointWithInlineChildren):
      (WebCore::RenderBlock::positionForPoint):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::positionForPoint):
      (WebCore::RenderReplaced::localSelectionRect):
      (WebCore::RenderReplaced::setSelectionState):
      * rendering/RenderReplaced.h:
      * rendering/RenderText.cpp:
      (WebCore::RenderText::positionForPoint):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition):
      * rendering/RootInlineBox.h:
      
      LayoutTests: 
      
      * fast/blockflow/horizontal-bt-replaced-selection.html: Added.
      * fast/blockflow/vertical-lr-replaced-selection.html: Added.
      * fast/blockflow/vertical-rl-replaced-selection.html: Added.
      * platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
      * platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
      * platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
      * platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
      * platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
      * platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
      * platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
      * platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
      * platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a575c3a
    • japhet@chromium.org's avatar
      2010-11-08 Nate Chapin <japhet@chromium.org> · 22e5436c
      japhet@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              Move connection-per-host counting and request prioritization out
              of Loader and down to the ResourceLoader level.
      
              https://bugs.webkit.org/show_bug.cgi?id=27165
      
              Refactor only, so no new tests.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::suspendPostAttachCallbacks):
              (WebCore::ContainerNode::resumePostAttachCallbacks):
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::loadRequest):
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::loadNow):
              * loader/NetscapePlugInStreamLoader.cpp:
              (WebCore::NetscapePlugInStreamLoader::create):
              * loader/NetscapePlugInStreamLoader.h:
              * loader/ResourceLoadScheduler.cpp: Added.
              (WebCore::ResourceLoadScheduler::hostForURL):
              (WebCore::resourceLoadScheduler): Returns the single ResourceLoadScheduler instance
              (WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
              (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad):
              (WebCore::ResourceLoadScheduler::schedulePluginStreamLoad):
              (WebCore::ResourceLoadScheduler::addMainResourceLoad):
              (WebCore::ResourceLoadScheduler::scheduleLoad):
              (WebCore::ResourceLoadScheduler::remove):
              (WebCore::ResourceLoadScheduler::crossOriginRedirectReceived):
              (WebCore::ResourceLoadScheduler::servePendingRequests):
              (WebCore::ResourceLoadScheduler::suspendPendingRequests):
              (WebCore::ResourceLoadScheduler::resumePendingRequests):
              (WebCore::ResourceLoadScheduler::scheduleServePendingRequests):
              (WebCore::ResourceLoadScheduler::requestTimerFired):
              (WebCore::ResourceLoadScheduler::assertLoaderBeingCounted):
              (WebCore::ResourceLoadScheduler::HostInformation::assertLoaderBeingCounted):
              (WebCore::ResourceLoadScheduler::HostInformation::HostInformation):
              (WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
              (WebCore::ResourceLoadScheduler::HostInformation::schedule):
              (WebCore::ResourceLoadScheduler::HostInformation::addLoadInProgress):
              (WebCore::ResourceLoadScheduler::HostInformation::remove):
              (WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
              * loader/ResourceLoadScheduler.h: Added.
              (WebCore::ResourceLoadScheduler::HostInformation::name):
              (WebCore::ResourceLoadScheduler::HostInformation::limitRequests):
              (WebCore::ResourceLoadScheduler::HostInformation::requestsPending):
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::releaseResources): Remove this from ResourceLoadScheduler's counting.
              (WebCore::ResourceLoader::load):
              (WebCore::ResourceLoader::start): Create the ResourceHandle, called by ResourceLoadScheduler.
              (WebCore::ResourceLoader::willSendRequest): Ensure ResourceLoadScheduler counts redirects
                  correctly.
              * loader/ResourceLoader.h:
              (WebCore::ResourceLoader::url):
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::startLoading):
              * loader/loader.cpp: Move scheduling to ResourceLoadScheduler, remove Host subclass
                  and make Loader the SubresourceLoaderClient instead.
              (WebCore::determinePriority):
              (WebCore::Loader::load): Schedule the creation of the ResourceHandle, rather than
                  doing it immediately.
              (WebCore::Loader::cancelRequests):
              (WebCore::Loader::didFinishLoading):
              (WebCore::Loader::didFail):
              (WebCore::Loader::didReceiveResponse):
              (WebCore::Loader::didReceiveData):
              (WebCore::Loader::didReceiveCachedMetadata):
              * loader/loader.h:
              * page/EventSource.cpp:
              (WebCore::EventSource::connect):
              (WebCore::EventSource::endRequest):
              * plugins/PluginStream.cpp:
              (WebCore::PluginStream::start):
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::XMLHttpRequest):
              (WebCore::XMLHttpRequest::~XMLHttpRequest):
              (WebCore::XMLHttpRequest::createRequest):
              (WebCore::XMLHttpRequest::didFail):
              (WebCore::XMLHttpRequest::didFinishLoading):
              * xml/XMLHttpRequest.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22e5436c
    • leandro@webkit.org's avatar
      2010-11-08 Rafael Antognolli <antognolli@profusion.mobi> · fa2bd348
      leandro@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [EFL] Change the usage of eina_iterator_next due to latest EFL changes.
              https://bugs.webkit.org/show_bug.cgi?id=49082
      
              A change on how the iterator for a tiler is used in EFL needs to be
              reflected in WebKit-EFL. The iterator now receives a pointer to an
              Eina_Rectangle and makes it point to its internal structure. The old
              usage was to receive a reference to a pre-allocated Eina_Rectangle.
      
              * ewk/ewk_view_single.c:
              (_ewk_view_single_smart_repaints_process):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa2bd348
    • mitz@apple.com's avatar
      Ignore the system scrollbar setting. · 6ba8b7e5
      mitz@apple.com authored
      Reviewed by Darin Adler.
      
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (resetDefaultsToConsistentValues): Set the scrollbar default.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ba8b7e5
    • andersca@apple.com's avatar
      NPClass::construct and NPClass::invokeDefault never called with out-of-process plug-ins in WebKit2 · 07b53168
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49198
      
      Reviewed by Adam Roben.
      
      WebKit2:
      
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      (WebKit::NPObjectMessageReceiver::invokeDefault):
      Call NPClass::invokeDefault.
      
      (WebKit::NPObjectMessageReceiver::construct):
      Call NPClass::construct
      
      * Shared/Plugins/NPObjectMessageReceiver.messages.in:
      Add InvokeDefault and Construct messages.
      
      * Shared/Plugins/NPObjectProxy.cpp:
      (WebKit::NPObjectProxy::invokeDefault):
      Send the InvokeDefault message.
      
      (WebKit::NPObjectProxy::construct):
      Send the Construct message.
      
      (WebKit::NPObjectProxy::NP_InvokeDefault):
      Call NPObjectProxy::invokeDefault.
      
      (WebKit::NPObjectProxy::NP_Construct):
      Call NPObjectProxy::construct.
      
      LayoutTests:
      
      Remove now passing tests.
      
      * platform/mac-snowleopard/Skipped:
      * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07b53168
    • tony@chromium.org's avatar
      2010-11-08 Tony Chang <tony@chromium.org> · b9244626
      tony@chromium.org authored
              Unreviewed, updating plugin expectations.
      
              * platform/chromium-mac/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
              * platform/chromium-win/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
              * platform/mac-snowleopard/Skipped: Only failing on SL.
              * platform/mac/Skipped:
              * platform/qt/plugins/nested-plugin-objects-expected.txt: Removed.
              * plugins/nested-plugin-objects-expected.txt: Made the main version
                    have a console error line of 0 since it seems to be a chromium
                    specific difference.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9244626
    • jberlin@webkit.org's avatar
      We should add a build step to comment out or remove the lines unsetting TEMP and TMP in the · 6f9b20dd
      jberlin@webkit.org authored
      .bashrc file.
      https://bugs.webkit.org/show_bug.cgi?id=49189
      
      Reviewed by Adam Roben.
      
      * building/tools.html:
      Add a line recommending bash shell users to comment out or remove those lines, with an
      explanation as to why.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f9b20dd
    • rniwa@webkit.org's avatar
      2010-11-08 Ryosuke Niwa <rniwa@webkit.org> · 0d96cf61
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove the remaining editing-style functions from ApplyStyleCommand
              https://bugs.webkit.org/show_bug.cgi?id=49155
      
              Replaced removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt,
              and removeStylesAddedByNode in ApplyStyleCommand.cpp by removeNonEditingProperties, EditingStyle::create,
              prepareToApplyAt, and removeStyleAddedByNode in EditingStyle.cpp.
      
              Also removed unnecessary header includes from various cpp files.
      
              No tests are added since this is a cleanup.
      
              * editing/ApplyStyleCommand.cpp: Removed removeNonEditingProperties, editingStyleAtPosition,
              prepareEditingStyleToApplyAt, and removeStylesAddedByNode.
              * editing/ApplyStyleCommand.h: Ditto.
              * editing/DeleteSelectionCommand.cpp: Removed removeEnclosingAnchorStyle.
              (WebCore::DeleteSelectionCommand::saveTypingStyleState): Calls removeStylesAddedByNode instead.
              * editing/EditingStyle.cpp:
              (WebCore::copyEditingProperties): Moved and renamed ApplyStyleCommand::removeNonEditingProperties.
              (WebCore::editingStyleFromComputedStyle): Calls copyEditingProperties. Changed the argument to PassRefPtr
              as supposed to a raw pointer for convenience.
              (WebCore::EditingStyle::init): Calls editingStyleFromComputedStyle.
              (WebCore::EditingStyle::removeStyleAddedByNode): Added.
              (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added.
              (WebCore::EditingStyle::removeNonEditingProperties): Added.
              (WebCore::editingStyleIncludingTypingStyle): Calls copyEditingProperties.
              * editing/EditingStyle.h: Added prototypes.
              * editing/Editor.cpp:
              (WebCore::Editor::selectionComputedStyle): Uses EditingStyle.
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Ditto.
              (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
              * editing/InsertParagraphSeparatorCommand.h:
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply): Ditto.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::handleStyleSpansBeforeInsertion): Ditto.
              (WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
              (WebCore::ReplaceSelectionCommand::doApply): Ditto.
              (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
              * editing/ReplaceSelectionCommand.h:
              * editing/markup.cpp: Removed removeEnclosingMailBlockquoteStyle and removeDefaultStyles.
              (WebCore::createMarkup): Uses EditingStyle.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d96cf61
    • dumi@chromium.org's avatar
      Unreviewed, updating Chromium expectations. · 0ffc60e2
      dumi@chromium.org authored
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
      * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
      * platform/chromium-mac/svg/custom/polyline-points-crash-expected.txt: Removed.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
      * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
      * platform/chromium-win/svg/custom/polyline-points-crash-expected.txt: Removed.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
      * platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ffc60e2
    • andersca@apple.com's avatar
      Plug-in views should not assume that plugins are RenderEmbeddedObjects · 13a85a7e
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49196
      <rdar://problem/8638467>
      
      Reviewed by Dan Bernstein.
      
      WebKit/mac:
      
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      (-[WebHostedNetscapePluginView pluginHostDied]):
      
      WebKit2:
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::pluginProcessCrashed):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13a85a7e
    • simon.fraser@apple.com's avatar
      2010-11-08 Simon Fraser <simon.fraser@apple.com> · 8a7f8012
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              Media objects in nested iframes showing above everything else in TinyMCE
              https://bugs.webkit.org/show_bug.cgi?id=44877
      
              Tests: compositing/iframes/become-composited-nested-iframes.html
                     compositing/iframes/overlapped-nested-iframes.html
      
              The overlap testing logic that connects compositing across iframe boundaries
              needed to be educated about nestd iframes, for platforms (i.e. Mac) where iframes
              are allowed to be independently composited.
      
              Also fix a bug that could cause iframes (and possibly other elements) that share
              style to fail to become composited.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::canShareStyleWithElement): Disable style sharing for elements
              that force synethetic style updates in order to gain RenderLayers, so they can become
              composited. This is tested by become-composited-nested-iframes.html, though it is very
              timing-dependent.
      
              * page/FrameView.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::hasCompositedContentIncludingDescendants): New method that
              is a "deep" version of hasCompositedContent() on platforms where that is necessary to ask.
      
              (WebCore::FrameView::hasCompositingAncestor): New method.
              (WebCore::FrameView::setIsOverlapped): If we can have independently composited iframes,
              we need to force all descendant iframes to update so that compositing gets hooked up across
              nested iframes.
      
              (WebCore::FrameView::isOverlappedIncludingAncestors): New method, only called on platforms
              where allowsIndependentlyCompositedIFrames() is true.
      
              * rendering/RenderLayerCompositor.h:
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::allowsIndependentlyCompositedIFrames): Utility method that
              returns true if an iframe can be a compositing root.
      
              (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Make use of
              allowsIndependentlyCompositedIFrames().
      
              (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): We need to notify all
              descendant frames, not just children.
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::setStyle): Add assert to ensure that we don't do style sharing
              for elements that play tricks with synthetic style changes.
      
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::paint): Run overlap testing if a frame has any composited
              descendants.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a7f8012
    • tony@chromium.org's avatar
      2010-11-08 Tony Chang <tony@chromium.org> · 750f3b5b
      tony@chromium.org authored
              Unreviewed, adding qt results for new test (only console line number
              is different).  Test failing for unknown reasons on mac-- will fix
              offline.
      
              * platform/mac/Skipped:
              * platform/qt/plugins/nested-plugin-objects-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      750f3b5b
    • andersca@apple.com's avatar
      NPN_Evaluate doesn't work with out-of-process plugins in WebKit2 · 48eb3672
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49193
      
      Reviewed by Adam Roben.
      
      WebKit2:
      
      * PluginProcess/PluginControllerProxy.cpp:
      (WebKit::PluginControllerProxy::evaluate):
      Send an Evaluate message.
      
      * WebProcess/Plugins/PluginProxy.cpp:
      (WebKit::PluginProxy::evaluate):
      Call Evaluate on the plug-in proxy.
      
      * WebProcess/Plugins/PluginProxy.h:
      * WebProcess/Plugins/PluginProxy.messages.in:
      Add Evaluate message.
      
      LayoutTests:
      
      Remove now passing tests.
      
      * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48eb3672
    • caseq@chromium.org's avatar
    • leandro@webkit.org's avatar
      2010-11-08 Leandro Pereira <leandro@profusion.mobi> · dbee8665
      leandro@webkit.org authored
              [EFL] Unreviewed. Build fix after r71496.
      
              * CMakeLists.txt: Add WebCore/loader/cache directory to WebKit's
              include directories list.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbee8665
    • ap@apple.com's avatar
      Windows build fix. · 9ee1dd76
      ap@apple.com authored
              * WebCoreSupport/WebChromeClient.h: Added namespace prefix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ee1dd76
    • aroben@apple.com's avatar
      Make webkitpy.common.system.executive_unittest pass when running under Win32 Python · c28c0b0a
      aroben@apple.com authored
      Fixes <http://webkit.org/b/49033>.
      
      Reviewed by Dave Levin and Eric Seidel.
      
      * Scripts/webkitpy/common/system/executive.py:
      (Executive._run_command_with_teed_output): Pass the arguments through
      encode_argument_if_needed rather than using Cygwin-specific code here.
      (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
      the output.
      (Executive.run_command): Use encode_argument_if_needed to encode the
      arguments and child_process_encoding to decode the output.
      (Executive._child_process_encoding): Returns the encoding that should be
      used when communicating with child processes. On Windows we use mbcs,
      which maps to the current code page. On all other platforms we use
      UTF-8.
      (Executive._should_encode_child_process_arguments): Returns True if
      arguments to child processes need to be encoded. This is currently
      only needed on Cygwin and Win32 Python 2.x.
      (Executive._encode_argument_if_needed): Encode the argument using
      child_process_encoding if we need to encode arguments to child
      processes on this platform.
      
      * Scripts/webkitpy/common/system/executive_unittest.py:
      (never_ending_command): Added. Returns arguments to run a command that
      will not quit until we kill it. On Windows we use wmic, on other
      platforms we use yes.
      (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
      mbcs encoding to be used and for output from the child processes to
      have been roundtripped through encode/decode on Win32 Python. When
      UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
      it's possible that some characters will not be able to be converted
      and will be replaced by question marks; the round-tripping allows us
      to expect this result.
      
      (ExecutiveTest.test_kill_process):
      (ExecutiveTest.test_kill_all):
      Use never_ending_command instead of invoking "yes" directly. Expect an
      exit code of 1 when using Win32 Python, as that's what seems to happen.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c28c0b0a