1. 24 Sep, 2013 40 commits
    • ap@apple.com's avatar
      SVG Animations are flaky · 1faf122e
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107018
      
      * platform/mac-wk2/TestExpectations: Marked some frequently failing tests
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1faf122e
    • ossy@webkit.org's avatar
      Unreviewed buildfix after r156350. · 33f5d8f3
      ossy@webkit.org authored
      * UIProcess/WebContext.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33f5d8f3
    • ap@apple.com's avatar
      [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold · 087b4bc0
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121854
      
      Reviewed by Anders Carlsson.
      
      * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
      (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
      settings in underlying frameworks.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      087b4bc0
    • zoltan@webkit.org's avatar
      [CSS Shapes] Modify updateSegmentsForShapes function to use logical coordinates · 3b30db7a
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121864
      
      Reviewed by David Hyatt.
      
      When I landed updateSegmentsForShapes in r156022, I didn't use logical coordinates. This change modifies the
      code to use coordinates for positioning the float and the content around the float in a shape-inside. Now I
      added only one writing mode tests, but I will add more later in bug #121866.
      
      Source/WebCore:
      
      Test: fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html
      
      * rendering/FloatingObjects.h:
      (WebCore::FloatingObject::logicalHeight):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::computeLogicalLocationForFloat):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::updateSegmentsForShapes):
      
      LayoutTests:
      
      * fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html: Added.
      * fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b30db7a
    • ossy@webkit.org's avatar
      Unreviewed buildfix after r156354 and r156360. · 8da0f4d2
      ossy@webkit.org authored
      * Platform/CoreIPC/unix/ConnectionUnix.cpp:
      (CoreIPC::Connection::processMessage):
      (CoreIPC::Connection::sendOutgoingMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8da0f4d2
    • ap@apple.com's avatar
      Flaky Test: fast/history/history-subframe-with-name.html · aba5890b
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51039
      
      Reviewed by Anders Carlsson.
      
      Speculative fix, I could not reproduce locally.
      
      * fast/history/resources/history-subframe-with-name-container.html: Added a check
      that onunload trick worked. 
      
      * fast/history/resources/history-subframe-with-name-2.html: Starting the navigation
      used to race with loading another iframe in the parent. Wait until the parent loads.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aba5890b
    • ossy@webkit.org's avatar
      Unreviewed buildfix after r156349. · 56e4c68d
      ossy@webkit.org authored
      * Platform/CoreIPC/unix/ConnectionUnix.cpp:
      (CoreIPC::Connection::processMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56e4c68d
    • andersca@apple.com's avatar
      Use std::unique_ptr for decoders as well · 98c09909
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121868
      
      Reviewed by Andreas Kling.
      
      * Platform/CoreIPC/Connection.cpp:
      (CoreIPC::Connection::SyncMessageState::processIncomingMessage):
      (CoreIPC::Connection::SyncMessageState::dispatchMessages):
      (CoreIPC::Connection::waitForMessage):
      (CoreIPC::Connection::sendSyncMessage):
      (CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
      (CoreIPC::Connection::waitForSyncReply):
      (CoreIPC::Connection::processIncomingSyncReply):
      (CoreIPC::Connection::processIncomingMessage):
      (CoreIPC::Connection::enqueueIncomingMessage):
      (CoreIPC::Connection::dispatchMessage):
      (CoreIPC::Connection::dispatchOneMessage):
      * Platform/CoreIPC/Connection.h:
      (CoreIPC::Connection::sendSync):
      (CoreIPC::Connection::waitForAndDispatchImmediately):
      * Platform/CoreIPC/mac/ConnectionMac.cpp:
      (CoreIPC::createMessageDecoder):
      (CoreIPC::Connection::receiveSourceEventHandler):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::postSynchronousMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98c09909
    • beidson@apple.com's avatar
      Remove IDBTransactionCallbacks.h from the .xcodeproj, as it's gone from the repository. · b4d48286
      beidson@apple.com authored
      Rubberstamped by Anders Carlsson and Alexey Proskuryakov.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4d48286
    • commit-queue@webkit.org's avatar
      Web Inspector: Using Breakpoint Actions Breaks iOS inspection · 518685ab
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121862
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-24
      Reviewed by Timothy Hatcher.
      
      Only use DebuggerAgent.BreakpointActionType if it is available.
      Otherwise leave options undefined for breakpoints since the backend
      does not support it.
      
      * UserInterface/DebuggerManager.js:
      (WebInspector.DebuggerManager.prototype._setBreakpoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      518685ab
    • commit-queue@webkit.org's avatar
      Web Inspector: Include iOS 7 Inspector.json Version · 41064308
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121852
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-24
      Reviewed by Timothy Hatcher.
      
      * UserInterface/Legacy/7.0/InspectorBackendCommands.js: Added.
      * Versions/Inspector-iOS-7.0.json: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41064308
    • dino@apple.com's avatar
      webgl/conformance/extensions/oes-element-index-uint.html failing after r156351 or 156352 · 7340b581
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121863
      <rdar://problem/15069481>
      
      Temporarily skipped while investigating.
      
      * TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7340b581
    • antti@apple.com's avatar
      Tighten table rendering code · 7f9196b6
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121860
      
      Reviewed by Andreas Kling.
      
      Hide firstChild/lastChild/nextSibling/previousSibling in table renderers, 
      expose correctly typed firstRow/nextCell etc instead.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f9196b6
    • andersca@apple.com's avatar
      Move MessageEncoder and ArgumentEncoder to std::unique_ptr · 9d03f001
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121861
      
      Reviewed by Andreas Kling.
      
      * NetworkProcess/NetworkConnectionToWebProcess.cpp:
      (WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
      * NetworkProcess/NetworkConnectionToWebProcess.h:
      * NetworkProcess/NetworkProcess.cpp:
      (WebKit::NetworkProcess::didReceiveSyncMessage):
      * NetworkProcess/NetworkProcess.h:
      * Platform/CoreIPC/Connection.cpp:
      (CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
      (CoreIPC::Connection::createSyncMessageEncoder):
      (CoreIPC::Connection::sendMessage):
      (CoreIPC::Connection::sendSyncReply):
      (CoreIPC::Connection::sendSyncMessage):
      (CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
      (CoreIPC::Connection::sendOutgoingMessages):
      (CoreIPC::Connection::dispatchSyncMessage):
      * Platform/CoreIPC/Connection.h:
      (CoreIPC::Connection::send):
      (CoreIPC::Connection::sendSync):
      * Platform/CoreIPC/HandleMessage.h:
      (CoreIPC::handleMessageDelayed):
      * Platform/CoreIPC/MessageReceiver.h:
      (CoreIPC::MessageReceiver::didReceiveSyncMessage):
      * Platform/CoreIPC/MessageReceiverMap.cpp:
      (CoreIPC::MessageReceiverMap::dispatchSyncMessage):
      * Platform/CoreIPC/MessageReceiverMap.h:
      * Platform/CoreIPC/MessageSender.cpp:
      (CoreIPC::MessageSender::sendMessage):
      * Platform/CoreIPC/MessageSender.h:
      (CoreIPC::MessageSender::send):
      * Platform/CoreIPC/mac/ConnectionMac.cpp:
      (CoreIPC::Connection::open):
      (CoreIPC::Connection::sendOutgoingMessage):
      * PluginProcess/PluginControllerProxy.h:
      * PluginProcess/WebProcessConnection.cpp:
      (WebKit::WebProcessConnection::didReceiveSyncMessage):
      * PluginProcess/WebProcessConnection.h:
      * Scripts/webkit2/messages.py:
      (message_to_struct_declaration):
      (generate_message_handler):
      * Scripts/webkit2/messages_unittest.py:
      * Shared/ChildProcessProxy.cpp:
      (WebKit::ChildProcessProxy::sendMessage):
      (WebKit::ChildProcessProxy::dispatchSyncMessage):
      (WebKit::ChildProcessProxy::didFinishLaunching):
      * Shared/ChildProcessProxy.h:
      (WebKit::ChildProcessProxy::send):
      * Shared/Plugins/NPObjectMessageReceiver.h:
      * Shared/Plugins/NPRemoteObjectMap.cpp:
      (WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
      * Shared/Plugins/NPRemoteObjectMap.h:
      * Shared/WebConnection.cpp:
      (WebKit::WebConnection::postMessage):
      * UIProcess/Downloads/DownloadProxy.h:
      * UIProcess/Network/NetworkProcessProxy.cpp:
      (WebKit::NetworkProcessProxy::didReceiveSyncMessage):
      * UIProcess/Network/NetworkProcessProxy.h:
      * UIProcess/Plugins/PluginProcessProxy.h:
      * UIProcess/Storage/StorageManager.h:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::dispatchSyncMessage):
      (WebKit::WebContext::didReceiveSyncMessage):
      * UIProcess/WebContext.h:
      * UIProcess/WebFullScreenManagerProxy.h:
      * UIProcess/WebIconDatabase.h:
      * UIProcess/WebInspectorProxy.h:
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::didReceiveSyncMessage):
      * UIProcess/WebProcessProxy.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::postMessage):
      (WebKit::InjectedBundle::postSynchronousMessage):
      * WebProcess/Network/NetworkProcessConnection.cpp:
      (WebKit::NetworkProcessConnection::didReceiveSyncMessage):
      * WebProcess/Network/NetworkProcessConnection.h:
      * WebProcess/Plugins/PluginProcessConnection.cpp:
      (WebKit::PluginProcessConnection::didReceiveSyncMessage):
      * WebProcess/Plugins/PluginProcessConnection.h:
      * WebProcess/Plugins/PluginProxy.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::didReceiveSyncMessage):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::didReceiveSyncMessage):
      * WebProcess/WebProcess.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d03f001
    • andersca@apple.com's avatar
      Remove encoder create functions · 80e28787
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121853
      
      Reviewed by Sam Weinig.
      
      Source/WebKit2:
      
      * Platform/CoreIPC/ArgumentEncoder.cpp:
      * Platform/CoreIPC/ArgumentEncoder.h:
      * Platform/CoreIPC/Connection.cpp:
      (CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
      (CoreIPC::Connection::createSyncMessageEncoder):
      (CoreIPC::Connection::dispatchSyncMessage):
      * Platform/CoreIPC/Connection.h:
      (CoreIPC::Connection::send):
      * Platform/CoreIPC/MessageEncoder.cpp:
      (CoreIPC::MessageEncoder::setIsSyncMessage):
      * Platform/CoreIPC/MessageEncoder.h:
      * Platform/CoreIPC/MessageSender.h:
      (CoreIPC::MessageSender::send):
      * Platform/CoreIPC/mac/ConnectionMac.cpp:
      (CoreIPC::Connection::open):
      * Shared/ChildProcessProxy.h:
      (WebKit::ChildProcessProxy::send):
      * Shared/WebConnection.cpp:
      (WebKit::WebConnection::postMessage):
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::createNewWebProcess):
      (WebKit::WebContext::postMessageToInjectedBundle):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::postMessage):
      * WebProcess/WebPage/EncoderAdapter.cpp:
      (WebKit::EncoderAdapter::EncoderAdapter):
      (WebKit::EncoderAdapter::dataReference):
      (WebKit::EncoderAdapter::encodeBytes):
      (WebKit::EncoderAdapter::encodeBool):
      (WebKit::EncoderAdapter::encodeUInt16):
      (WebKit::EncoderAdapter::encodeUInt32):
      (WebKit::EncoderAdapter::encodeUInt64):
      (WebKit::EncoderAdapter::encodeInt32):
      (WebKit::EncoderAdapter::encodeInt64):
      (WebKit::EncoderAdapter::encodeFloat):
      (WebKit::EncoderAdapter::encodeDouble):
      (WebKit::EncoderAdapter::encodeString):
      * WebProcess/WebPage/EncoderAdapter.h:
      
      Source/WTF:
      
      Add a variadic version of createOwned.
      
      * wtf/OwnPtr.h:
      (WTF::createOwned):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80e28787
    • dino@apple.com's avatar
      Implement symbol name hashing for WebGL shaders · d80a65d3
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121849
      
      Reviewed by Anders Carlsson.
      
      Turn on ANGLE's symbol name mapping for shader programs.
      This avoids compilation failures (or worse, crashers)
      on some hardware that doesn't like it when shaders redefine
      symbols like "sin", even though that is valid.
      
      The way ANGLE exposes this is via setting a pointer
      to a char* -> uint64_t hash function. Since we only have
      a 32-bit hash in WebKit, I combine the 32-bit value with
      a counter value that exists over the lifetime of a GC3D context.
      Before calling ANGLE, I point the global hash map to the local
      hash map, and then clean up after we're done. This introduces
      a memory hit, in that the symbol table will build up until
      the context is released.
      
      Covered by Khronos WebGL tests, including
      conformance/glsl/misc/shader-with-non-reserved-words.html
      
      * platform/graphics/GraphicsContext3D.h: Define a ShaderNameHash type,
      and add an OwnPtr to one as a member variable.
      * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
      (WebCore::nameHashForShader): Global function used for ANGLE hashing.
      (WebCore::GraphicsContext3D::compileShader): Set up the ANGLE properties,
      point to the local hash map, and call compile/translate.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d80a65d3
    • dino@apple.com's avatar
      Use mapped name in attribute location binding · 587d9714
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121847
      <rdar://problem/15067526>
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      The shader that we send down to OpenGL to compile
      may have been translated by ANGLE, so we keep a
      table around that maps input symbols to output symbols.
      We used the table when binding to and looking up
      uniforms, and when looking up attributes, but not
      when actually binding to attribute locations.
      
      Test: fast/canvas/webgl/gl-bind-attrib-mapped-names.html
      
      * platform/graphics/ANGLEWebKitBridge.cpp:
      (WebCore::getSymbolInfo): Add logging of symbol mapping.
      * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
      (WebCore::GraphicsContext3D::bindAttribLocation): Used the mapped name.
      (WebCore::GraphicsContext3D::getAttribLocation): Remove comment since
      we do the lookup everywhere.
      (WebCore::GraphicsContext3D::getUniformLocation): Ditto.
      
      LayoutTests:
      
      New test that has an attribute name long enough
      to trigger symbol mapping in all cases.
      
      * fast/canvas/webgl/gl-bind-attrib-mapped-names-expected.txt: Added.
      * fast/canvas/webgl/gl-bind-attrib-mapped-names.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      587d9714
    • enrica@apple.com's avatar
      Upstream changes to Pasteboard implementation for iOS. · 0c27b72f
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121818
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      * WebCore.xcodeproj/project.pbxproj:
      * editing/Editor.cpp:
      (WebCore::Editor::cut):
      (WebCore::Editor::copyImage):
      * editing/ios/EditorIOS.mm:
      (WebCore::attributedStringForRange):
      (WebCore::dataInRTFDFormat):
      (WebCore::dataInRTFFormat):
      (WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
      (WebCore::Editor::selectionInWebArchiveFormat):
      (WebCore::Editor::writeSelectionToPasteboard):
      (WebCore::getImage):
      (WebCore::Editor::writeImageToPasteboard):
      * platform/Pasteboard.h:
      * platform/PasteboardStrategy.h:
      * platform/PlatformPasteboard.h:
      * platform/ios/PasteboardIOS.mm:
      * platform/ios/PlatformPasteboardIOS.mm: Added.
      (WebCore::PlatformPasteboard::PlatformPasteboard):
      (WebCore::PlatformPasteboard::getTypes):
      (WebCore::PlatformPasteboard::bufferForType):
      (WebCore::PlatformPasteboard::getPathnamesForType):
      (WebCore::PlatformPasteboard::stringForType):
      (WebCore::PlatformPasteboard::color):
      (WebCore::PlatformPasteboard::url):
      (WebCore::PlatformPasteboard::copy):
      (WebCore::PlatformPasteboard::addTypes):
      (WebCore::PlatformPasteboard::setTypes):
      (WebCore::PlatformPasteboard::setBufferForType):
      (WebCore::PlatformPasteboard::setPathnamesForType):
      (WebCore::PlatformPasteboard::setStringForType):
      (WebCore::PlatformPasteboard::changeCount):
      (WebCore::PlatformPasteboard::uniqueName):
      (WebCore::PlatformPasteboard::write):
      
      Source/WebKit/mac: 
      
      * WebCoreSupport/WebPlatformStrategies.h:
      * WebCoreSupport/WebPlatformStrategies.mm:
      (WebPlatformStrategies::writeToPasteboard):
      
      Source/WebKit2: 
      
      * Scripts/webkit2/messages.py:
      (struct_or_class):
      (headers_for_type):
      * Shared/WebCoreArgumentCoders.cpp:
      (CoreIPC::encodeSharedBuffer):
      (CoreIPC::decodeSharedBuffer):
      (CoreIPC::::encode):
      (CoreIPC::::decode):
      * Shared/WebCoreArgumentCoders.h:
      * UIProcess/WebContext.h:
      * UIProcess/WebContext.messages.in:
      * UIProcess/mac/WebContextMac.mm:
      (WebKit::WebContext::writeWebContentToPasteboard):
      (WebKit::WebContext::writeImageToPasteboard):
      (WebKit::WebContext::writeStringToPasteboard):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::writeToPasteboard):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c27b72f
    • andersca@apple.com's avatar
      Remove create functions from MessageDecoder and ArgumentDecoder · 5852fc7d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121850
      
      Reviewed by Antti Koivisto.
      
      * Platform/CoreIPC/ArgumentDecoder.cpp:
      (CoreIPC::ArgumentDecoder::ArgumentDecoder):
      * Platform/CoreIPC/ArgumentDecoder.h:
      * Platform/CoreIPC/MessageDecoder.cpp:
      (CoreIPC::MessageDecoder::MessageDecoder):
      * Platform/CoreIPC/MessageDecoder.h:
      * Platform/CoreIPC/mac/ConnectionMac.cpp:
      (CoreIPC::createMessageDecoder):
      * WebProcess/WebPage/DecoderAdapter.cpp:
      (WebKit::DecoderAdapter::DecoderAdapter):
      (WebKit::DecoderAdapter::decodeBytes):
      (WebKit::DecoderAdapter::decodeBool):
      (WebKit::DecoderAdapter::decodeUInt16):
      (WebKit::DecoderAdapter::decodeUInt32):
      (WebKit::DecoderAdapter::decodeUInt64):
      (WebKit::DecoderAdapter::decodeInt32):
      (WebKit::DecoderAdapter::decodeInt64):
      (WebKit::DecoderAdapter::decodeFloat):
      (WebKit::DecoderAdapter::decodeDouble):
      (WebKit::DecoderAdapter::decodeString):
      * WebProcess/WebPage/DecoderAdapter.h:
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::postInjectedBundleMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5852fc7d
    • mrowe@apple.com's avatar
      <rdar://problem/14971518> WebKit should build against the Xcode default... · a862530c
      mrowe@apple.com authored
      <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
      
      Reviewed by Dan Bernstein.
      
      Source/JavaScriptCore:
      
      * Configurations/Base.xcconfig:
      
      Source/ThirdParty/ANGLE:
      
      * Configurations/Base.xcconfig:
      
      Source/WebCore:
      
      * Configurations/Base.xcconfig:
      
      Source/WebInspectorUI:
      
      * Configurations/Base.xcconfig:
      
      Source/WebKit/mac:
      
      * Configurations/Base.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/Base.xcconfig:
      
      Source/WTF:
      
      * Configurations/Base.xcconfig:
      
      Tools:
      
      * DumpRenderTree/mac/Configurations/Base.xcconfig:
      * MiniBrowser/Configurations/Base.xcconfig:
      * TestWebKitAPI/Configurations/Base.xcconfig:
      * WebKitLauncher/Configurations/Base.xcconfig:
      * WebKitTestRunner/Configurations/Base.xcconfig:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a862530c
    • dbates@webkit.org's avatar
      [iOS] Upstream -webkit-touch-callout · 9e6e6a5f
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121507
      
      Reviewed by Antti Koivisto.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::ComputedStyleExtractor::propertyValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/CSSPropertyNames.in: Added -webkit-touch-callout.
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::applyProperty):
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::willRespondToMouseClickEvents): Added.
      * html/HTMLImageElement.h:
      * rendering/style/RenderStyle.h:
      * rendering/style/StyleRareInheritedData.cpp:
      (WebCore::StyleRareInheritedData::StyleRareInheritedData):
      (WebCore::StyleRareInheritedData::operator==):
      * rendering/style/StyleRareInheritedData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e6e6a5f
    • bjonesbe@adobe.com's avatar
      Properly handle bottom margin on float with shape-outside · 0dca0505
      bjonesbe@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121808
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      When a float has a shape-outside, inline content must conform to the
      shape, not to the margin box. Thus, if a float with shape-outside has
      a bottom margin and the shape does not intrude into that margin, then
      the inline content should ignore the margin. Before this patch, inline
      content would drop below the margin box instead of obeying the shape.
      
      Note that content that should clear the float still clears the margin
      box, not the shape's contour.
      
      Tests: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html
             csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html
             csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html
      
      * rendering/LineWidth.cpp:
      (WebCore::LineWidth::fitBelowFloats): Compute the logical bottom based
      on the shape.
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::nextFloatLogicalBottomBelow): Add option to
      compute the logical bottom based on the shape instead of on the margin
      box.
      * rendering/RenderBlock.h:
      
      LayoutTests:
      
      Import new tests for floats wish shape-outside and bottom margins.
      
      * csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
      * csswg/contributors/adobe/submitted/shapes/shape-outside/resources/rounded-rectangle.js: Remove whitespace at ends of lines.
      * csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html: Added.
      * csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003-expected.html: Added.
      * csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html: Added.
      * csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dca0505
    • commit-queue@webkit.org's avatar
      [GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE · 97dbe758
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121782
      
      Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-09-24
      Reviewed by Martin Robinson.
      
      Disabled drag functions.
      
      Source/WebCore:
      
      * page/gtk/EventHandlerGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/DragClientGtk.cpp:
      * WebCoreSupport/DragClientGtk.h:
      
      Source/WebKit2:
      
      * UIProcess/API/gtk/WebKitWebViewBase.cpp:
      (webkit_web_view_base_class_init):
      * WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97dbe758
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed crash fix after r156321. · fa122520
      bfulgham@apple.com authored
      Fix a few mistakes in the use of Vectors and counting that introduced test crashes.
      
      * WebHistory.cpp:
      (WebHistory::removeAllItems): Loop termination tried to test an unsigned for negative size.
      (WebHistory::removeItemFromDateCaches): Vector was being created with empty entries.
      (WebHistory::addItemToDateCaches): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa122520
    • andersca@apple.com's avatar
      Begin adopting std::tuple for IPC decoding · 9f392e38
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121848
      
      Reviewed by Sam Weinig.
      
      This is the first step towards getting rid of the horrible Arguments class hierarchy.
      
      * Platform/CoreIPC/Arguments.h:
      (CoreIPC::TupleCoder::encode):
      (CoreIPC::TupleCoder::decode):
      * Platform/CoreIPC/HandleMessage.h:
      (CoreIPC::callMemberFunction):
      (CoreIPC::handleMessage):
      (CoreIPC::handleMessageVariadic):
      (CoreIPC::handleMessageDelayed):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f392e38
    • commit-queue@webkit.org's avatar
      Web Inspector: Breakpoint Actions input should disable spellchecking · 725aa05b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121846
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-09-24
      Reviewed by Timothy Hatcher.
      
      * UserInterface/BreakpointActionView.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      725aa05b
    • commit-queue@webkit.org's avatar
      AX: Replace AXObjectCache postNotification method boolean arguments with enum values. · 600a0cee
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121504
      
      Patch by Samuel White <samuel_white@apple.com> on 2013-09-24
      Reviewed by Chris Fleizach.
      
      No new tests, no functional changes. Changed argument type from bool
      to enum per "Names" rule #10 in the WebKit coding style guidelines.
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::textChanged):
      (WebCore::AXObjectCache::postNotification):
      (WebCore::AXObjectCache::checkedStateChanged):
      (WebCore::AXObjectCache::selectedChildrenChanged):
      (WebCore::AXObjectCache::handleAttributeChanged):
      * accessibility/AXObjectCache.h:
      (WebCore::AXObjectCache::postNotification):
      * accessibility/AccessibilityMenuList.cpp:
      (WebCore::AccessibilityMenuList::didUpdateActiveOption):
      * accessibility/AccessibilityMenuListPopup.cpp:
      (WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::childrenChanged):
      (WebCore::AccessibilityNodeObject::changeValueByStep):
      (WebCore::AccessibilityNodeObject::changeValueByPercent):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
      (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
      (WebCore::AccessibilityRenderObject::textChanged):
      * dom/Document.cpp:
      (WebCore::Document::implicitClose):
      * editing/Editor.cpp:
      (WebCore::Editor::respondToChangedContents):
      (WebCore::Editor::markAndReplaceFor):
      * editing/mac/FrameSelectionMac.mm:
      (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::setInnerTextValue):
      * html/InputType.cpp:
      (WebCore::InputType::applyStep):
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::handleKeydownEvent):
      * page/FocusController.cpp:
      (WebCore::FocusController::setInitialFocus):
      * page/FrameView.cpp:
      (WebCore::FrameView::layout):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      600a0cee
    • akling@apple.com's avatar
      Make hoverAncestor() a RenderElement concept. · 92af4256
      akling@apple.com authored
      <https://webkit.org/b/121845>
      
      Reviewed by Antti Koivisto.
      
      The hover ancestor renderer is always a RenderElement, we only ever
      ask RenderElements for their hover ancestors.
      
      Updated Document::updateHoverActiveState() to take advantage of the
      tighter typing, removing a few isElementNode() checks.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92af4256
    • dbates@webkit.org's avatar
      [iOS] Initialize settings mediaPlayback{AllowsInline, RequiresUserGesture} and · 6d760c41
      dbates@webkit.org authored
      shouldRespectImageOrientation as appropriate
      https://bugs.webkit.org/show_bug.cgi?id=121792
      
      Reviewed by Darin Adler.
      
      On iOS we explicitly want to disable mediaPlaybackAllowsInline, and enable
      mediaPlaybackRequiresUserGesture and shouldRespectImageOrientation by default.
      This differs from other platforms. We need to extract the initialization logic
      for these settings into constants whose definition is conditioned on the platform.
      
      * page/Settings.cpp:
      * page/Settings.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d760c41
    • commit-queue@webkit.org's avatar
      [WinCairo] Compile error. · b998fdb2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121839
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-24
      Reviewed by Brent Fulgham.
      
      * platform/graphics/GraphicsContext3DPrivate.cpp:
      (WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate): Added missing guard.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b998fdb2
    • akling@apple.com's avatar
      Cache continuation() in a local to avoid repeat hash lookups. · 194c6fc2
      akling@apple.com authored
      <https://webkit.org/b/121840>
      
      Reviewed by Geoffrey Garen.
      
      RenderBoxModelObject::continuation() does a hash lookup every time.
      Cache the result in a local instead of calling it repeatedly.
      
      * rendering/RenderBlock.h:
      (WebCore::RenderBlock::isAnonymousBlockContinuation):
      
          Reorder to check bitfield before hash map.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateDragState):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::absoluteRects):
      (WebCore::RenderInline::absoluteQuads):
      (WebCore::RenderInline::clippedOverflowRectForRepaint):
      (WebCore::RenderInline::updateDragState):
      (WebCore::RenderInline::addFocusRingRects):
      
          Cache continuation() in locals where it's used more than once.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      194c6fc2
    • changseok.oh@collabora.com's avatar
      [EFL] Build failed at ProcessLauncherEfl.cpp · 374b33fc
      changseok.oh@collabora.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121826
      
      Reviewed by Gyuyoung Kim.
      
      Fixed a build failure with adding socket.h.
      
      * UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      374b33fc
    • commit-queue@webkit.org's avatar
      [ATK] Missing WTR AccessibilityController::addNotificationListener implementation · 023fae33
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121674
      
      Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-24
      Reviewed by Mario Sanchez Prada.
      
      Tools:
      
      Implemented the global notification listener for
      AccessibilityController. The signal is generated by
      AXObjectCache::postPlatformNotification() and received by
      axObjectEventListener(). axObjectEventListener will then invoke
      JSObjectCallAsFunction() with the respective callback function.
      
      There is no additional test for this patch since its implementation will
      be tested by an accessibility layout test that is currently failing
      (accessibility/loading-iframe-sends-notification.html).
      
      * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
      stub implementations of addNotificationListener and
      removeNotificationListener for the GTK port.
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
      (WTR::AccessibilityController::addNotificationListener): Creates the
      notification handler and sets the notification function callback.
      (WTR::AccessibilityController::removeNotificationListener): Removes the
      global handler.
      
      LayoutTests:
      
      Updated the expectation of loading-iframe-sends-notification.html test,
      which was failing before this fix.
      
      * platform/gtk-wk2/TestExpectations: Removed
      loading-iframe-sends-notification.html because it now passes with this
      fix.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      023fae33
    • commit-queue@webkit.org's avatar
      [GTK] fast/images/exif-orientation-composited.html is failing · 9add2704
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119731
      
      Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-09-24
      Reviewed by Carlos Garcia Campos.
      
      Tools:
      
      Add handling respect image orientation property in DRT.
      
      * DumpRenderTree/gtk/TestRunnerGtk.cpp:
      (TestRunner::overridePreference):
      
      LayoutTests:
      
      Unskip fast/images/exif-orientation-composited.html for GTK WK1 and WK2.
      
      * platform/gtk/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9add2704
    • allan.jensen@digia.com's avatar
      [Qt] Crash when trying to download blob url · 8d09d9f5
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121681
      
      Reviewed by Simon Hausmann.
      
      Source/WebCore:
      
      Resolve any blob URLs before creating a QUrl.
      
      * platform/network/qt/ResourceRequestQt.cpp:
      (WebCore::appendBlobResolved):
      (WebCore::resolveBlobUrl):
      (WebCore::ResourceRequest::toNetworkRequest):
      
      Source/WebKit/qt:
      
      Do not crash if a download was triggered on a resource WebCore handles internally.
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::convertMainResourceLoadToDownload):
      
      LayoutTests:
      
      Unskip two tests that downloads blob URLs. Note the two tests do not use the download attribute feature.
      
      * platform/qt/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d09d9f5
    • allan.jensen@digia.com's avatar
      [Qt] RepaintRequested signal sometimes not emitted · 3a6f5cce
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121790
      
      Reviewed by Simon Hausmann.
      
      We should also emit repaintRequested after calling PageClient::update().
      
      * WidgetSupport/PageClientQt.cpp:
      (WebCore::PageClientQWidget::repaintViewport):
      (WebCore::PageClientQGraphicsWidget::repaintViewport):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a6f5cce
    • zandobersek@gmail.com's avatar
      [GTK] Enable the Wayland target if GTK+ dependency is found · 9735a353
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121704
      
      Reviewed by Gustavo Noronha Silva.
      
      The Wayland target should be enabled by default if the GTK+ dependency is of version 3.9.14 or later.
      
      * Source/autotools/FindDependencies.m4: If the Wayland target was not strictly disabled, the GTK+ dependency
      is tested if it can provide the Wayland GDK backend, and that the version of that backend matches the version
      of the master GTK+ dependency for which we already tested. If found, the target is enabled, otherwise we either
      warn or error out, depending on whether the build target was set to auto or completely disabled through configuration.
      * Source/autotools/ReadCommandLineArguments.m4: Switch the default Wayland target status to 'auto', meaning
      it will be disabled if the GTK+ dependency is not found.
      * Source/autotools/Versions.m4: Require GTK+ 3.9.14 for the Wayland target only.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9735a353
    • zandobersek@gmail.com's avatar
      [GTK] Fix accelerated compositing disabling under Wayland displays · 9d6ab081
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121788
      
      Reviewed by Gustavo Noronha Silva.
      
      * webkit/webkitwebview.cpp:
      (updateAcceleratedCompositingSetting): Fix a ridiculous early return in the case of disabling the accelerated
      compositing setting. There's no need to re-disable the setting if it was already disabled, but it should
      definitely be disabled if the setting was previously enabled.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d6ab081
    • zandobersek@gmail.com's avatar
      [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset · 75a28a82
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121787
      
      Reviewed by Gustavo Noronha Silva.
      
      * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
      with the Wayland target enabled to version 3.10.0.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75a28a82
    • antti@apple.com's avatar
      Move more style change code from RenderObject to RenderElement · 7aae1752
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121822
      
      Reviewed by Darin Adler.
      
      * rendering/RenderElement.cpp:
      (WebCore::RenderElement::~RenderElement):
              
          RenderTexts are no longer registered as image clients. They don't need be unregistered either.
      
      (WebCore::RenderElement::adjustStyleDifference):
      (WebCore::RenderElement::hasImmediateNonWhitespaceTextChild):
      (WebCore::RenderElement::shouldRepaintForStyleDifference):
      (WebCore::RenderElement::updateFillImages):
      (WebCore::RenderElement::updateImage):
      (WebCore::RenderElement::updateShapeImage):
      (WebCore::RenderElement::setStyle):
              
          Move from RenderObject and remove the text specific bits.
      
      * rendering/RenderElement.h:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::setStyle):
      (WebCore::RenderObject::arenaDelete):
      * rendering/RenderObject.h:
              
          Remove styleWill/DidChange which move to subclasses.
      
      * rendering/RenderText.cpp:
      (WebCore::RenderText::setStyle):
              
          Add simple text specific setStyle.
      
      * rendering/RenderText.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7aae1752