1. 20 Dec, 2010 40 commits
    • tonyg@chromium.org's avatar
      2010-12-20 Tony Gentilcore <tonyg@chromium.org> · 1f0da712
      tonyg@chromium.org authored
              Unreviewed build fix.
      
              Fix line breaks in fast/gradients/gradient-after-transparent-border expectations
              https://bugs.webkit.org/show_bug.cgi?id=51375
      
              * fast/gradients/gradient-after-transparent-border-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f0da712
    • tonyg@chromium.org's avatar
      2010-12-20 Tony Gentilcore <tonyg@chromium.org> · 09a665fd
      tonyg@chromium.org authored
              Unreviewed build fix.
      
              [chromium] Rebaseline inspector/console-dir-global and debugger-expand-scope
              https://bugs.webkit.org/show_bug.cgi?id=51373
      
              * platform/chromium-win/inspector/console-dir-global-expected.txt:
              * platform/chromium-win/inspector/debugger-expand-scope-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09a665fd
    • morrita@google.com's avatar
      2010-12-17 MORITA Hajime <morrita@google.com> · 95a52b82
      morrita@google.com authored
              Reviewed by James Robinson.
      
              https://bugs.webkit.org/show_bug.cgi?id=51240
              [Chromium][Skia] Border with a color with alpha != 1 breaks webkit gradient on skia.
      
              * fast/gradients/gradient-after-transparent-border-expected.txt: Added.
              * fast/gradients/gradient-after-transparent-border.html: Added.
              * platform/chromium-win/fast/gradients/gradient-after-transparent-border-expected.checksum: Added.
              * platform/chromium-win/fast/gradients/gradient-after-transparent-border-expected.png: Added.
      2010-12-17  MORITA Hajime  <morrita@google.com>
      
              Reviewed by James Robinson.
      
              https://bugs.webkit.org/show_bug.cgi?id=51240
              [Chromium][Skia] Border with a color with alpha != 1 breaks webkit gradient on skia.
      
              Even after a shader was set, old color value had been remaining and passed to Skia.
              Then Skia refered an alpha component of that color to make pixels transparent.
              This change invalidates existing color value when a shader is given,
              which means the renderer will paint shapes with gradients or patterns.
      
              Test: fast/gradients/gradient-after-transparent-border.html
      
              * platform/graphics/skia/PlatformContextSkia.cpp:
              (WebCore::PlatformContextSkia::setStrokeShader):
              (WebCore::PlatformContextSkia::setFillShader):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95a52b82
    • xji@chromium.org's avatar
      2010-12-20 Xiaomei Ji <xji@chromium.org> · e39e1560
      xji@chromium.org authored
              Reviewed by Dan Bernstein.
      
              Fix move left/right by character hang.
              https://bugs.webkit.org/show_bug.cgi?id=51344
      
              Test: editing/selection/51344.html
      
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
      2010-12-20  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              Fix move left/right by character hang.
              https://bugs.webkit.org/show_bug.cgi?id=51344
      
              * editing/selection/51344-expected.txt: Added.
              * editing/selection/51344.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e39e1560
    • weinig@apple.com's avatar
      WebKit2: Add resource load client API · f1a64aea
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51370
      
      Reviewed by Anders Carlsson.
      
      This just pipes through the basic resource load client data.
      
      * UIProcess/API/C/WKPage.cpp:
      (WKPageSetPageResourceLoadClient):
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::initializeResourceLoadClient):
      (WebKit::WebPageProxy::didInitiateLoadForResource):
      (WebKit::WebPageProxy::didSendRequestForResource):
      (WebKit::WebPageProxy::didReceiveResponseForResource):
      (WebKit::WebPageProxy::didReceiveContentLengthForResource):
      (WebKit::WebPageProxy::didFinishLoadForResource):
      (WebKit::WebPageProxy::didFailLoadForResource):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * UIProcess/WebResourceLoadClient.cpp: Added.
      (WebKit::WebResourceLoadClient::didInitiateLoadForResource):
      (WebKit::WebResourceLoadClient::didSendRequestForResource):
      (WebKit::WebResourceLoadClient::didReceiveResponseForResource):
      (WebKit::WebResourceLoadClient::didReceiveContentLengthForResource):
      (WebKit::WebResourceLoadClient::didFinishLoadForResource):
      (WebKit::WebResourceLoadClient::didFailLoadForResource):
      * UIProcess/WebResourceLoadClient.h: Added.
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest):
      (WebKit::WebFrameLoaderClient::dispatchWillSendRequest):
      (WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse):
      (WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
      (WebKit::WebFrameLoaderClient::dispatchDidFinishLoading):
      (WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
      * win/WebKit2.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1a64aea
    • tonyg@chromium.org's avatar
      2010-12-20 Tony Gentilcore <tonyg@chromium.org> · ca2db2ff
      tonyg@chromium.org authored
              Unreviewed build fix.
      
              [chromium] Add baseline for table-before-child-add.html
              https://bugs.webkit.org/show_bug.cgi?id=51369
      
              * platform/chromium-linux/fast/css-generated-content/table-before-child-add-expected.checksum: Added.
              * platform/chromium-linux/fast/css-generated-content/table-before-child-add-expected.png: Added.
              * platform/chromium-mac/fast/css-generated-content/table-before-child-add-expected.checksum: Added.
              * platform/chromium-mac/fast/css-generated-content/table-before-child-add-expected.png: Added.
              * platform/chromium-win/fast/css-generated-content/table-before-child-add-expected.checksum: Added.
              * platform/chromium-win/fast/css-generated-content/table-before-child-add-expected.png: Added.
              * platform/chromium-win/fast/css-generated-content/table-before-child-add-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca2db2ff
    • slewis@apple.com's avatar
      Committing for Gavin since he needed to leave. · e2249cfe
      slewis@apple.com authored
      PPC build fix; stop using std::swap on PageAllocation/PageReservation,
      this was failing on some compilers since the lack of default construction
      for the m_executable/m_writable fields meant the value being swapped may
      not have been fully initialized.
      
      Patch by Gavin Barraclough <barraclough@apple.com> on 2010-12-20
      * wtf/PageAllocation.h:
      (WTF::PageAllocation::deallocate):
      * wtf/PageBlock.h:
      * wtf/PageReservation.h:
      (WTF::PageReservation::deallocate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2249cfe
    • commit-queue@webkit.org's avatar
      2010-12-20 Steve Lacey <sjl@chromium.org> · a99586d0
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Add missing default styles in mediaControlsChromium.css to prevent
              user overrides.
              https://bugs.webkit.org/show_bug.cgi?id=51360
      
              No new tests needed as functionality is covered by existing layout
              tests.
      
              * css/mediaControlsChromium.css:
              (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
              (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a99586d0
    • jianli@chromium.org's avatar
      Add lastModifiedDate attribute to File interface per File API spec · 6d5a411f
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49895
      
      Reviewed by David Levin.
      
      WebCore:
      
      lastModifiedDate is not supported for GObject bindings because Date is
      not support in code generation.
      
      Test: http/tests/local/fileapi/file-last-modified.html
      
      * fileapi/File.cpp:
      (WebCore::File::lastModifiedDate):
      * fileapi/File.h:
      * fileapi/File.idl:
      
      LayoutTests:
      
      * http/tests/local/fileapi/file-last-modified-expected.txt: Added.
      * http/tests/local/fileapi/file-last-modified.html: Added.
      * http/tests/local/fileapi/script-tests/file-last-modified.js: Added.
      * http/tests/resources/file-last-modified.php: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d5a411f
    • enne@google.com's avatar
      2010-12-20 Adrienne Walker <enne@google.com> · c84a1d48
      enne@google.com authored
              Unreviewed. Adding myself to the list of committers.
      
              * webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c84a1d48
    • joepeck@webkit.org's avatar
      2010-12-20 Joseph Pecoraro <joepeck@webkit.org> · e5d344ab
      joepeck@webkit.org authored
              Reviewed by Darin Adler.
      
              Update .gitattributes for WebKitTools -> Tools change
              https://bugs.webkit.org/show_bug.cgi?id=51365
      
              * .gitattributes: WebKitTools -> Tools rename. Removed no longer existing file references.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5d344ab
    • oliver@apple.com's avatar
      2010-12-20 Oliver Hunt <oliver@apple.com> · 70ed3e19
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              |delete name| in strict mode code should be an early error
              https://bugs.webkit.org/show_bug.cgi?id=50431
      
              Disallow the |delete IDENTIFIER| production in strict mode, and removed
              a bunch of now unnecessary code.
      
              * parser/JSParser.cpp:
              (JSC::JSParser::Scope::collectFreeVariables):
              (JSC::jsParse):
              (JSC::JSParser::parseProgram):
              (JSC::JSParser::parseUnaryExpression):
              * parser/JSParser.h:
              * parser/Parser.cpp:
              (JSC::Parser::parse):
              * parser/Parser.h:
              (JSC::Parser::parse):
      2010-12-20  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              |delete name| in strict mode code should be an early error
              https://bugs.webkit.org/show_bug.cgi?id=50431
      
              Add a test to ensure that |delete IDENTIFIER| is disallowed, even if
              IDENTIFIER resolves to a deletable property.
      
              * fast/js/basic-strict-mode-expected.txt:
              * fast/js/script-tests/basic-strict-mode.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70ed3e19
    • andersca@apple.com's avatar
      2010-12-20 Anders Carlsson <andersca@apple.com> · 36f2f525
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Add a TextChecker class, hook up spelling and grammar toggling
              https://bugs.webkit.org/show_bug.cgi?id=51363
      
              * UIProcess/API/mac/WKView.mm:
              (-[WKView validateUserInterfaceItem:]):
              (-[WKView toggleContinuousSpellChecking:]):
              (-[WKView toggleGrammarChecking:]):
              * UIProcess/TextChecker.h: Added.
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::unmarkAllMisspellings):
              (WebKit::WebPageProxy::unmarkAllBadGrammar):
              * UIProcess/WebPageProxy.h:
              * UIProcess/mac/TextCheckerMac.mm: Added.
              (WebKit::TextChecker::isContinuousSpellCheckingAllowed):
              (WebKit::TextChecker::isContinuousSpellCheckingEnabled):
              (WebKit::TextChecker::setContinuousSpellCheckingEnabled):
              (WebKit::TextChecker::isGrammarCheckingEnabled):
              (WebKit::TextChecker::setGrammarCheckingEnabled):
              * UIProcess/qt/TextCheckerQt.cpp: Added.
              (WebKit::TextChecker::isContinuousSpellCheckingAllowed):
              (WebKit::TextChecker::isContinuousSpellCheckingEnabled):
              (WebKit::TextChecker::setContinuousSpellCheckingEnabled):
              (WebKit::TextChecker::isGrammarCheckingEnabled):
              (WebKit::TextChecker::setGrammarCheckingEnabled):
              * UIProcess/win/TextCheckerWin.cpp: Added.
              (WebKit::TextChecker::isContinuousSpellCheckingAllowed):
              (WebKit::TextChecker::isContinuousSpellCheckingEnabled):
              (WebKit::TextChecker::setContinuousSpellCheckingEnabled):
              (WebKit::TextChecker::isGrammarCheckingEnabled):
              (WebKit::TextChecker::setGrammarCheckingEnabled):
              * WebKit2.pro:
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::unmarkAllMisspellings):
              (WebKit::WebPage::unmarkAllBadGrammar):
              * WebProcess/WebPage/WebPage.h:
              * WebProcess/WebPage/WebPage.messages.in:
              * win/WebKit2.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36f2f525
    • mrowe@apple.com's avatar
      <rdar://problem/8757601> Don't install header files in to the Resources directory. · a47efaec
      mrowe@apple.com authored
      Reviewed by Dan Bernstein.
      
      Tools:
      
      * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
      Resources directory.
      
      WebCore:
      
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a47efaec
    • barraclough@apple.com's avatar
      Bug 51358 - Should check stack depth rather than using recursion limits in byte compilation · dd4a6e42
      barraclough@apple.com authored
      Reviewed by Olver Hunt.
      
      The current implementation of recursion limit checking is not safe on smaller stacks.
      Switch to using a common mechanism, shared with the parser, to check recursion limits.
      
      Make bytecompiler use StackBounds. Empirical testing shows emitStrcat to have the largest
      footprint on the stack, at just under 1k on x86-64.  Given this, the default recursion
      check (requiring 4k of available space to recurse) seems reasonable.
      
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::BytecodeGenerator):
      * bytecompiler/BytecodeGenerator.h:
      (JSC::BytecodeGenerator::emitNode):
      (JSC::BytecodeGenerator::emitNodeInConditionContext):
      * bytecompiler/NodesCodegen.cpp:
      (JSC::BinaryOpNode::emitStrcat):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd4a6e42
    • eric@webkit.org's avatar
      2010-12-20 Eric Seidel <eric@webkit.org> · 1ef080e2
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              commit-queue should include bot id when attaching failure diffs
              https://bugs.webkit.org/show_bug.cgi?id=51280
      
              This is a tiny change to include the bot id in the name of the attachment.
              Most of this diff is just changing the unit test expectations
              now that I hid the comment printing when the comment is None.
      
              * Scripts/webkitpy/tool/bot/flakytestreporter.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
              * Scripts/webkitpy/tool/commands/upload_unittest.py:
              * Scripts/webkitpy/tool/mocktool.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ef080e2
    • andreip@google.com's avatar
      2010-12-20 Andrei Popescu <andreip@google.com> · 683ff4f1
      andreip@google.com authored
              Reviewed by Jeremy Orlow.
      
              [Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
              https://bugs.webkit.org/show_bug.cgi?id=51338
      
              * fast/dom/Window/window-postmessage-args-expected.txt:
              * fast/dom/Window/window-postmessage-args.html:
              * platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt:
              * platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt:
      2010-12-20  Andrei Popescu  <andreip@google.com>
      
              Reviewed by Jeremy Orlow.
      
              [Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
              https://bugs.webkit.org/show_bug.cgi?id=51338
      
              * bindings/v8/SerializedScriptValue.cpp:
              (WebCore::ZigZag::Reader::readUint32):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      683ff4f1
    • tonyg@chromium.org's avatar
      2010-12-20 Tony Gentilcore <tonyg@chromium.org> · ccde5ff3
      tonyg@chromium.org authored
              Unreviewed build fix.
      
              Include pthread to fix chromium mac build (broken by r74360)
              https://bugs.webkit.org/show_bug.cgi?id=51356
      
              * wtf/StackBounds.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccde5ff3
    • bdakin@apple.com's avatar
      WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=51355 Crash in · 17eaa6eb
      bdakin@apple.com authored
      RenderMathMLSubSup::layout() because of null base
      -and corresponding-
      <rdar://problem/8712200>
      
      Reviewed by Ada Chan.
      
      Only use base inside if(base) block.
      * mathml/RenderMathMLSubSup.cpp:
      (WebCore::RenderMathMLSubSup::layout):
      
      LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=51355 Crash in 
      RenderMathMLSubSup::layout() because of null base
      -and corresponding-
      <rdar://problem/8712200>
      
      Reviewed by Ada Chan.
      
      * mathml/empty-msubsup-crash-expected.txt: Added.
      * mathml/empty-msubsup-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17eaa6eb
    • enrica@apple.com's avatar
      Crash at WebCore::SplitElementCommand::SplitElementCommand · ca1c95ff
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51278
      <rdar://problem/7347139> 
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Executing outdent command on an inline blockquote that is
      not the first element in a block causes a crash.
      The fix consists in chaging the was the start of block is
      calculated in case of the inline blockquote.
              
      Test: editing/execCommand/outdent-inline-blockquote.html
            editing/execCommand/outdent-inline-list.html
      
      * editing/IndentOutdentCommand.cpp:
      (WebCore::IndentOutdentCommand::outdentParagraph):
      
      LayoutTests: 
      
      * editing/execCommand/outdent-inline-blockquote-expected.txt: Added.
      * editing/execCommand/outdent-inline-blockquote.html: Added.
      * editing/execCommand/outdent-inline-list-expected.txt: Added.
      * editing/execCommand/outdent-inline-list.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca1c95ff
    • oliver@apple.com's avatar
      2010-12-20 Oliver Hunt <oliver@apple.com> · e864155a
      oliver@apple.com authored
              Reviewed by Darin Adler.
      
              Need to support serialisation of cyclic graphs in the internal structured cloning algorithm
              https://bugs.webkit.org/show_bug.cgi?id=51353
      
              Update test to cover correct behaviour, and extend to test for actual graph construction.
      
              * fast/dom/Window/window-postmessage-clone-expected.txt:
              * fast/dom/Window/window-postmessage-clone.html:
      2010-12-20  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Darin Adler.
      
              Need to support serialisation of cyclic graphs in the internal structured cloning algorithm
              https://bugs.webkit.org/show_bug.cgi?id=51353
      
              The Internal Structured Clone algorithm has been changed to allow (and
              correctly clone) cyclic graphs.  This patch updates our implementation
              to provide that functionality.
      
              I've bumped the serialization version number, and added ObjectReferenceTag
              to represent references to objects that have already been seen.
      
              * bindings/js/SerializedScriptValue.cpp:
              (WebCore::CloneSerializer::startObjectInternal):
                Now that we have something a bit more complex than cycle checking
                I've replaced the duplicate code in startObject and startArray with
                a shared function that implements that logic to plant an object
                reference
              (WebCore::CloneSerializer::startObject):
              (WebCore::CloneSerializer::startArray):
                Lift out duplicate code
              (WebCore::CloneSerializer::endObject):
                Can't remove objects from the gcbuffer now as they need to remain live
                so we can identify graphs
              (WebCore::CloneSerializer::writeStringIndex):
              (WebCore::CloneSerializer::writeObjectIndex):
              (WebCore::CloneSerializer::writeConstantPoolIndex):
              (WebCore::CloneSerializer::write):
              (WebCore::CloneSerializer::serialize):
              (WebCore::CloneDeserializer::readStringIndex):
              (WebCore::CloneDeserializer::readConstantPoolIndex):
              (WebCore::CloneDeserializer::readTerminal):
              (WebCore::CloneDeserializer::deserialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e864155a
    • kov@webkit.org's avatar
      2010-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 5e40f1ff
      kov@webkit.org authored
              Reviewed by Xan Lopez.
      
              Add WebPlugin, WebPluginDatabase, and ViewportAttributes to the
              documentation control files, in preparation for 1.3.8. Also take
              the opportunity to add descriptions to WebPlugin and
              WebPluginDatabase.
      
              * docs/GNUmakefile.am:
              * docs/webkitgtk-docs.sgml:
              * docs/webkitgtk-sections.txt:
              * webkit/webkitwebplugin.cpp:
              * webkit/webkitwebplugindatabase.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e40f1ff
    • xan@webkit.org's avatar
      2010-12-20 Xan Lopez <xlopez@igalia.com> · 6d6a743c
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              * configure.ac: bump version for 1.3.8 release.
      
      WebCore:
      
      2010-12-20  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              * GNUmakefile.am: add missing files.
      
      WebKit/gtk:
      
      2010-12-20  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              * GNUmakefile.am: add missing files.
              * NEWS: update for 1.3.8 release.
      
      JavaScriptCore:
      
      2010-12-20  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              * GNUmakefile.am: add missing files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d6a743c
    • mitz@apple.com's avatar
      Tools/vcbin/midl.exe needs to be rebuilt · d760511d
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51347
      
      Patch by Jeff Miller <jeffm@apple.com> on 2010-12-20
      Reviewed by Dan Bernstein.
      
      * vcbin/midl.exe: Rebuilt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d760511d
    • inferno@chromium.org's avatar
      2010-12-20 Abhishek Arya <inferno@chromium.org> · 53872efb
      inferno@chromium.org authored
              Reviewed by James Robinson.
      
              Pass the correct beforeChild value when adding a child to an anonymous table part.
              https://bugs.webkit.org/show_bug.cgi?id=50932
      
              When a "before" content child was added to an anonymous table part, it was added
              after the last child. This patch fixes the behavior by adding it properly before
              the first child.
      
              Test: fast/css-generated-content/table-before-child-add.html
      
              * rendering/RenderTableRow.cpp:
              (WebCore::RenderTableRow::addChild):
      2010-12-20  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by James Robinson.
      
              Tests that beforeChild is added to table correctly.
              https://bugs.webkit.org/show_bug.cgi?id=50932
      
              * fast/css-generated-content/table-before-child-add.html: Added.
              * platform/mac/fast/css-generated-content/table-before-child-add-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53872efb
    • levin@chromium.org's avatar
      2010-12-20 David Levin <levin@chromium.org> · 8bc6681d
      levin@chromium.org authored
              Reviewed by Ariya Hidayat.
      
              .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
              https://bugs.webkit.org/show_bug.cgi?id=51343
      
              Follow up from the WebKitTools -> Tools rename.
      
              * .gitignore:
      2010-12-20  David Levin  <levin@chromium.org>
      
              Reviewed by Ariya Hidayat.
      
              .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
              https://bugs.webkit.org/show_bug.cgi?id=51343
      
              Follow up from the WebKitTools -> Tools rename.
      
              * Scripts/webkit-tools-completion.sh:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bc6681d
    • jamesr@google.com's avatar
      2010-12-20 Cosmin Truta <ctruta@chromium.org> · 3bba2c48
      jamesr@google.com authored
              Reviewed by James Robinson.
      
              new-run-webkit-tests ignores trailing EOL differences in text tests
              https://bugs.webkit.org/show_bug.cgi?id=36983
      
              Changed the handling of new-line characters within new-run-webkit-tests
              to match old-run-webkit-tests.  Differences in leading and trailing empty
              lines in text expectation files are no longer ignored.
      
              * Scripts/webkitpy/layout_tests/port/base.py:
              * Scripts/webkitpy/layout_tests/port/test.py:
              Added unit tests.  Removed old duplicate unit test entries.
              * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bba2c48
    • jamesr@google.com's avatar
      2010-12-20 Cosmin Truta <ctruta@chromium.org> · e9a416f3
      jamesr@google.com authored
              Reviewed by James Robinson.
      
              Even more rebaselining needed for new-run-webkit-tests update
              https://bugs.webkit.org/show_bug.cgi?id=51340
      
              * http/tests/misc/webtiming-ssl-expected.txt:
              * storage/indexeddb/cursor-delete-expected.txt:
              * storage/indexeddb/cursor-index-delete-expected.txt:
              * storage/indexeddb/transaction-crash-on-abort-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9a416f3
    • barraclough@apple.com's avatar
      Bug 26276 - Need a mechanism to determine stack extent · 82395900
      barraclough@apple.com authored
      Reviewed by Oliver Hunt.
      
      JavaScriptCore: 
      
      This patch adds a class 'StackBounds', to hold information about the machine stack.
      The implementation of this class broadly adheres to the current implmentation of
      stack limit checking, and as such does not solve the problem of determining stack
      extent, but gives us a common place to do so.
      
      Currently two mechanism are provided to determine the stack origin (the point the
      stack is growing away from). currentThreadStackBase() in Collector provides a
      more accurate determination of the stack origin, so use this to calculate
      StackBounds::m_origin; WTFThreadData::approximatedStackStart is less accurate, and
      as such can be removed.  Cache the StackBounds on WTFThreadData such that they
      need only be determined once per thread, and for non-API contexts cache this
      information in JSGlobalData, to save a thread-specific access.
      
      For the time being retain the estimate of stack size used by JSC's parser
      (128 * sizeof(void*) * 1024), with a view to replacing this with something more
      accurate in the near future.
      
      * parser/JSParser.cpp:
      (JSC::JSParser::canRecurse):
      (JSC::JSParser::JSParser):
          Change to use StackBounds.
      * runtime/Collector.cpp:
      (JSC::Heap::registerThread):
      (JSC::Heap::markCurrentThreadConservativelyInternal):
          Change to use StackBounds, cached on JSGlobalData.
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSC::JSGlobalData::stack):
          Add a cached copy of StackBounds.
      * wtf/StackBounds.cpp: Copied from JavaScriptCore/runtime/Collector.cpp.
      (WTF::estimateStackBound):
      (WTF::StackBounds::initialize):
      (WTF::getStackMax):
          Copy code from Collector.cpp to determine stack origin.
      * wtf/StackBounds.h: Added.
      (WTF::StackBounds::StackBounds):
          No argument constructor; returns a null StackBounds.
      (WTF::StackBounds::currentThreadStackBounds):
          Returns a StackBounds object representing the stack limits
          of the current thread.
      (WTF::StackBounds::origin):
          Returns to stack origin (the point the stack is growing away
          from; the highest extent of the stack on machines where the
          stack grows downwards.
      (WTF::StackBounds::recursionLimit):
          Returns a limit value that is 'a comfortable distance from
          the end of the stack'. Our concept of this is currently 1 page
          away from the end, however the default value may be tuned in
          the future, and clients may override passing a larger delta;
          should only be called on StackBounds object representing the
          stack of the thread this method is called on (checked by
          checkConsistency).
      (WTF::StackBounds::recursionCheck):
          Checks whether we are currently 'a comfortable distance from
          the end of the stack'. Our concept of this is currently 1 page
          away from the end, however the default value may be tuned in
          the future, and clients may override passing a larger delta
          to apply when checking, if they wish to do so. This method
          should only be called on StackBounds object representing the
          stack of the thread this method is called on (checked by
          checkConsistency).
      (WTF::StackBounds::current):
          Approximate current stack position. On machines where the stack
          is growing downwards this is the lowest address that might need
          conservative collection.
      (WTF::StackBounds::isGrowingDownward):
          True for all platforms other than WINCE, which has to check.
      (WTF::StackBounds::checkConsistency):
          This is called in methods that shoulds only be operating on a
          valid set of bounds; as such we expect m_origin != m_bounds
          (i.e. stack size != zero) - we're really testing that this
          object is not null (the constructor initializes both fields
          to zero).  Also checks that current() is within the stack's
          bounds.
      * wtf/WTFThreadData.cpp:
      (WTF::WTFThreadData::WTFThreadData):
      * wtf/WTFThreadData.h:
      (WTF::WTFThreadData::stack):
          Add the StackBounds member variable.
      
      JavaScriptGlue: 
      
      Add forwarding header for StackBounds.h.
      
      * ForwardingHeaders/wtf/StackBounds.h: Added.
      
      WebCore: 
      
      Add forwarding header for StackBounds.h.
      
      * ForwardingHeaders/wtf/StackBounds.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82395900
    • andersca@apple.com's avatar
      2010-12-20 Anders Carlsson <andersca@apple.com> · b046b35d
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Flash plug-in does not work on YouTube video page when accelerated compositing is disabled
              https://bugs.webkit.org/show_bug.cgi?id=51348
              <rdar://problem/8787667>
      
              * Platform/CoreIPC/HandleMessage.h:
              (CoreIPC::callMemberFunction):
              Add new overload.
      
              * PluginProcess/PluginControllerProxy.cpp:
              (WebKit::PluginControllerProxy::create):
              (WebKit::PluginControllerProxy::PluginControllerProxy):
              These now take an additional isAcceleratedCompositingEnabled parameter.
      
              (WebKit::PluginControllerProxy::isAcceleratedCompositingEnabled):
              Return m_isAcceleratedCompositingEnabled.
      
              * PluginProcess/PluginControllerProxy.h:
              * PluginProcess/WebProcessConnection.cpp:
              (WebKit::WebProcessConnection::createPlugin):
              This now takes an additional isAcceleratedCompositingEnabled parameter.
      
              * PluginProcess/WebProcessConnection.messages.in:
              Add isAcceleratedCompositingEnabled parameter to the CreatePlugin message.
      
              * WebProcess/Plugins/PluginProxy.cpp:
              (WebKit::PluginProxy::initialize):
              Pass isAcceleratedCompositingEnabled when sending the CreatePlugin message.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b046b35d
    • jamesr@google.com's avatar
      2010-12-20 James Robinson <jamesr@chromium.org> · fa072193
      jamesr@google.com authored
              Unreviewed, rolling out r74278.
              http://trac.webkit.org/changeset/74278
              https://bugs.webkit.org/show_bug.cgi?id=50833
      
              [chromium] Causes many layout tests to crash
      
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::LayerRendererChromium):
              (WebCore::LayerRendererChromium::prepareToDrawLayers):
              (WebCore::LayerRendererChromium::drawLayers):
              (WebCore::LayerRendererChromium::useRenderSurface):
              (WebCore::LayerRendererChromium::setScissorToRect):
              * platform/graphics/chromium/LayerRendererChromium.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa072193
    • ggaren@apple.com's avatar
      2010-12-17 Geoffrey Garen <ggaren@apple.com> · 18a081c2
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
      
              Factored common page set management into a new PageBlock base class
              https://bugs.webkit.org/show_bug.cgi?id=51285
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * JavaScriptCore.gypi:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * interpreter/RegisterFile.h:
              (JSC::RegisterFile::RegisterFile):
              * jit/ExecutableAllocator.cpp:
              (JSC::ExecutableAllocator::intializePageSize):
              * wtf/PageAllocation.cpp: Removed.
              * wtf/PageAllocation.h:
              (WTF::PageAllocation::deallocate):
              (WTF::PageAllocation::PageAllocation):
              * wtf/PageReservation.h:
              (WTF::PageReservation::commit):
              (WTF::PageReservation::decommit):
              (WTF::PageReservation::deallocate):
              (WTF::PageReservation::PageReservation):
              * wtf/wtf.pri:
      2010-12-20  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Factored common page set management into a new PageBlock base class
              https://bugs.webkit.org/show_bug.cgi?id=51285
      
              * ForwardingHeaders/wtf/PageBlock.h: Added.
      2010-12-20  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Factored common page set management into a new PageBlock base class
              https://bugs.webkit.org/show_bug.cgi?id=51285
      
              * ForwardingHeaders/wtf/PageBlock.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18a081c2
    • levin@chromium.org's avatar
      check-webkit-style should detect function declarations (and trivial functions). · e8f82757
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=51303
      
      Reviewed by Shinichiro Hamaji.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (_FunctionState.begin): Add is_declaration and changed the line count
      start to begin at -1 (which will keep the results consistent, since
      the starting line number passed in is one less in this change).
      (detect_functions): changed function detection to now catch trivial
      functions and declarations.
      (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
      of the function as this may look at return values (when processing
      a declaration).
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (FunctionDetectionTest.perform_function_detection): Basic mechanics
      of testing the function detection.
      (FunctionDetectionTest.test_basic_function_detection): Test a simple
      function.
      (FunctionDetectionTest.test_function_declaration_detection): Test a
      declaration.
      (FunctionDetectionTest.test_non_functions): A test case for a case
      that caused the code to fail due to the { being in quotes.
      (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
      cases to help catch false alarms for return values.
      (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
      we don't get false alarms for member variables either.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8f82757
    • andersca@apple.com's avatar
      2010-12-20 Anders Carlsson <andersca@apple.com> · 23db083a
      andersca@apple.com authored
              Unreviewed, rolling out r74345.
              http://trac.webkit.org/changeset/74345
              https://bugs.webkit.org/show_bug.cgi?id=51115
      
              Not the correct fix.
      
              * Platform/CoreIPC/Connection.h:
              * Platform/CoreIPC/qt/ConnectionQt.cpp:
              (CoreIPC::Connection::open):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23db083a
    • steveblock@google.com's avatar
      2010-12-20 Steve Block <steveblock@google.com> · dc331127
      steveblock@google.com authored
              Reviewed by Jeremy Orlow.
      
              GeolocationPositionCache should do database access on background thread
              https://bugs.webkit.org/show_bug.cgi?id=50825
      
              Covered by existing Geolocation tests.
      
              * page/Coordinates.h:
              (WebCore::Coordinates::threadSafeCopy):
              * page/GeolocationPositionCache.cpp:
              (WebCore::GeolocationPositionCache::GeolocationPositionCache):
              (WebCore::GeolocationPositionCache::addUser):
              (WebCore::GeolocationPositionCache::removeUser):
              (WebCore::GeolocationPositionCache::setDatabasePath):
              (WebCore::GeolocationPositionCache::setCachedPosition):
              (WebCore::GeolocationPositionCache::cachedPosition):
              (WebCore::GeolocationPositionCache::startBackgroundThread):
              (WebCore::GeolocationPositionCache::threadEntryPoint):
              (WebCore::GeolocationPositionCache::threadEntryPointImpl):
              (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
              (WebCore::GeolocationPositionCache::readFromDatabase):
              (WebCore::GeolocationPositionCache::readFromDatabaseImpl):
              (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
              (WebCore::GeolocationPositionCache::writeToDatabase):
              (WebCore::GeolocationPositionCache::writeToDatabaseImpl):
              * page/GeolocationPositionCache.h:
              * page/Geoposition.h:
              (WebCore::Geoposition::threadSafeCopy):
              (WebCore::Geoposition::Geoposition):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc331127
    • abecsi@webkit.org's avatar
      2010-12-20 Andras Becsi <abecsi@webkit.org> · a9f05142
      abecsi@webkit.org authored
              Unreviewed build fix.
      
              [Qt][V8] Add  missing sources to the pro file and remove duplications to fix linking.
      
              No new tests needed.
      
              * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9f05142
    • apavlov@chromium.org's avatar
      2010-12-20 Alexander Pavlov <apavlov@chromium.org> · a186e1bd
      apavlov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Make CSSCompletions a real class rather than singleton
              https://bugs.webkit.org/show_bug.cgi?id=51332
      
              Drive-by: make use of keywords from re2js in the CSS tokenizer
              (apparently, various authors have presumed that re2js is processed at build time).
      
              No new tests, as this is a refactoring.
      
              * inspector/front-end/CSSCompletions.js:
              (WebInspector.CSSCompletions):
              (WebInspector.CSSCompletions.prototype.startsWith):
              (WebInspector.CSSCompletions.prototype.firstStartsWith):
              (WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
              (WebInspector.CSSCompletions.prototype.keySet):
              (WebInspector.CSSCompletions.prototype.next):
              (WebInspector.CSSCompletions.prototype.previous):
              (WebInspector.CSSCompletions.prototype._closest):
              * inspector/front-end/SourceCSSTokenizer.js:
              (WebInspector.SourceCSSTokenizer):
              * inspector/front-end/SourceCSSTokenizer.re2js:
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylePropertyTreeElement.prototype):
              * inspector/front-end/inspector.js:
              (WebInspector.doLoadedDone.propertyNamesCallback):
              (WebInspector.doLoadedDone):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a186e1bd
    • caseq@chromium.org's avatar
      2010-12-20 Andrey Kosyakov <caseq@chromium.org> · feb34a96
      caseq@chromium.org authored
              Unreviewed. Rebased platform-specific test expectations following default expectations change in r74234.
      
              * platform/mac-leopard/inspector/extensions-resources-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      feb34a96
    • podivilov@chromium.org's avatar
      2010-12-10 Pavel Podivilov <podivilov@chromium.org> · 4cf9da08
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: "Add conditional breakpoint" - create breakpoint only after condition is provided.
              https://bugs.webkit.org/show_bug.cgi?id=50813
      
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._addBreakpoint):
              (WebInspector.SourceFrame.prototype._breakpointRemoved):
              (WebInspector.SourceFrame.prototype._breakpointChanged):
              (WebInspector.SourceFrame.prototype._setBreakpointDecoration):
              (WebInspector.SourceFrame.prototype._removeBreakpointDecoration):
              (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
              (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
              (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
              (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
              (WebInspector.SourceFrame.prototype._contextMenu):
              (WebInspector.SourceFrame.prototype._editBreakpointCondition.finishEditing):
              (WebInspector.SourceFrame.prototype._editBreakpointCondition):
              (WebInspector.SourceFrame.prototype._continueToLine):
              (WebInspector.SourceFrame.prototype._setBreakpoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cf9da08
    • tonikitoo@webkit.org's avatar
      2010-12-19 Antonio Gomes <agomes@rim.com> · b1d6859d
      tonikitoo@webkit.org authored
              Reviewed by Xan Lopez.
      
              no-caret-repaint-in-non-content-editable-element.html does not need to disable CaretBrowsing
              https://bugs.webkit.org/show_bug.cgi?id=51308
      
              Patch removes the useless statement to disable caret browsing from
              no-caret-repaint-in-non-content-editable-element.html.
      
              Caret browsing gets toggled OFF before the execution of each test
              on the DRTs that support testing it (GTK+, Qt and Chromium). On Mac or
              Windows's DRT testing this feature is unsupport, so caret
              browsing is also disabled by default.
      
              * fast/repaint/no-caret-repaint-in-non-content-editable-element.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1d6859d