1. 30 Mar, 2007 4 commits
    • hausmann's avatar
      Fix Qt release builds · 1f0bfa23
      hausmann authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f0bfa23
    • antti's avatar
      Reviewed by bdash. · 70a5f8f9
      antti authored
              Spotted an int that should be float in previous patch.
      
              * platform/Font.cpp:
              (WebCore::WidthIterator::advance):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70a5f8f9
    • antti's avatar
      Reviewed by Hyatt. · abdc5919
      antti authored
              Render tree memory savings, part 1
              
              - Eliminate caching of monospace char width from RenderText. This optimization is not needed
                anymore since Font already caches space width (RenderText -4 bytes)
              - Eliminate caching of tab width from RenderBlock. Similary this optimization has become
                obsolete (RenderBlock -4 bytes)
      
              * platform/Font.cpp:
              (WebCore::WidthIterator::advance):
              (WebCore::Font::spaceWidth):
              * platform/Font.h:
              (WebCore::Font::tabWidth):
              * platform/TextStyle.h:
              (WebCore::TextStyle::TextStyle):
              (WebCore::TextStyle::allowTabs):
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::selectionRect):
              (WebCore::InlineTextBox::paint):
              (WebCore::InlineTextBox::paintSelection):
              (WebCore::InlineTextBox::paintMarkedTextBackground):
              (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
              (WebCore::InlineTextBox::paintTextMatchMarker):
              (WebCore::InlineTextBox::offsetForPosition):
              (WebCore::InlineTextBox::positionForOffset):
              * rendering/RenderBlock.cpp:
              (WebCore:::RenderFlow):
              (WebCore::RenderBlock::setStyle):
              * rendering/RenderBlock.h:
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderText.cpp:
              (WebCore::RenderText::RenderText):
              (WebCore::RenderText::setStyle):
              (WebCore::RenderText::widthFromCache):
              (WebCore::RenderText::trimmedMinMaxWidth):
              (WebCore::RenderText::calcMinMaxWidthInternal):
              (WebCore::RenderText::setTextInternal):
              (WebCore::RenderText::width):
              * rendering/RenderText.h:
              (WebCore::RenderText::allowTabs):
              * rendering/bidi.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abdc5919
    • hyatt's avatar
      Fix (take 2) for bug 4334, flickering when floating elements gain/lose transparency. · 57cac343
      hyatt authored
              Reviewed by mitz
      
              * rendering/RenderBlock.cpp:
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::setStyle):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57cac343
  2. 29 Mar, 2007 9 commits
    • weinig's avatar
      LayoutTests: · 4759b9cd
      weinig authored
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=13166
                REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table
      
              * fast/tokenizer/write-partial-entity-expected.txt: Added.
              * fast/tokenizer/write-partial-entity.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13166
                REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table
      
              Test: fast/tokenizer/write-partial-entity.html
      
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseTag): Reordered to avoid resetting the buffer position
              after script execution which can write to the buffer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4759b9cd
    • justing's avatar
      LayoutTests: · 7ddfeab4
      justing authored
              Reviewed by john
              
              <rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position
      
              Tests for the bug:
              * editing/deleting/5099303-expected.checksum: Added.
              * editing/deleting/5099303-expected.png: Added.
              * editing/deleting/5099303-expected.txt: Added.
              * editing/deleting/5099303.html: Added.
              Tests that extending an editable selection skips non-editable
              content:
              * editing/selection/5099303-expected.checksum: Added.
              * editing/selection/5099303-expected.png: Added.
              * editing/selection/5099303-expected.txt: Added.
              * editing/selection/5099303.html: Added.
      
      WebCore:
      
              Reviewed by john
      
              <rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position
              
              We were failing to create the correct selection 
              for DeleteSelectionCommand because the selection extension 
              operations don't skip over non-editable content for editable 
              selections.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingRightForward):
              When extending an editable selection, don't extend into
              non-editable content.
              (WebCore::SelectionController::modifyExtendingLeftBackward):
              Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ddfeab4
    • pyeh's avatar
      <rdar://problem/4918397> Exception raise inspecting note contents in the background · aa8721f0
      pyeh authored
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject subrole]):
              (-[WebCoreAXObject title]):
      	Check that attachment supports the attribute before requesting it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa8721f0
    • justing's avatar
      LayoutTests: · b7701503
      justing authored
              Reviewed by john
      
              <rdar://problem/5032066> <Delete> should work between To Dos
      
              Demonstrates the fix:
              * editing/deleting/5032066-expected.checksum: Added.
              * editing/deleting/5032066-expected.png: Added.
              * editing/deleting/5032066-expected.txt: Added.
              * editing/deleting/5032066.html: Added.
              
              Fixed:
              * editing/deleting/delete-block-table-expected.checksum:
              * editing/deleting/delete-block-table-expected.png:
              * editing/deleting/delete-block-table-expected.txt:
              
              shouldInsertNode:... now being called during moves:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-to-end-of-paragraph-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/execCommand/create-list-from-range-selection-expected.txt:
              * editing/execCommand/create-list-with-hr-expected.txt:
              * editing/execCommand/format-block-expected.txt:
              * editing/execCommand/format-block-from-range-selection-expected.txt:
              * editing/execCommand/format-block-with-braces-expected.txt:
              * editing/execCommand/format-block-with-trailing-br-expected.txt:
              * editing/execCommand/indent-list-item-expected.txt:
              * editing/execCommand/indent-selection-expected.txt:
              * editing/execCommand/insert-list-and-stitch-expected.txt:
              * editing/execCommand/insert-list-with-id-expected.txt:
              * editing/execCommand/nsresponder-indent-expected.txt:
              * editing/execCommand/outdent-selection-expected.txt:
              * editing/execCommand/queryCommandState-01-expected.txt:
              * editing/execCommand/remove-list-1-expected.txt:
              * editing/execCommand/remove-list-from-range-selection-expected.txt:
              * editing/execCommand/remove-list-item-1-expected.txt:
              * editing/execCommand/remove-list-items-expected.txt:
              * editing/execCommand/switch-list-type-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/inserting/multiple-lines-selected-expected.txt:
              * editing/inserting/return-key-with-selection-001-expected.txt:
              * editing/inserting/return-key-with-selection-002-expected.txt:
              * editing/pasteboard/4076267-2-expected.txt:
              * editing/pasteboard/4700297-expected.txt:
              * editing/pasteboard/8145-3-expected.txt:
              * editing/pasteboard/display-block-on-spans-expected.txt:
              * editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * editing/pasteboard/interchange-newline-1-expected.txt:
              * editing/pasteboard/interchange-newline-2-expected.txt:
              * editing/pasteboard/merge-after-delete-1-expected.txt:
              * editing/pasteboard/merge-after-delete-2-expected.txt:
              * editing/pasteboard/merge-after-delete-expected.txt:
              * editing/pasteboard/merge-end-1-expected.txt:
              * editing/pasteboard/merge-end-2-expected.txt:
              * editing/pasteboard/merge-end-3-expected.txt:
              * editing/pasteboard/merge-end-4-expected.txt:
              * editing/pasteboard/merge-end-5-expected.txt:
              * editing/pasteboard/merge-end-blockquote-expected.txt:
              * editing/pasteboard/merge-end-borders-expected.txt:
              * editing/pasteboard/merge-end-list-expected.txt:
              * editing/pasteboard/merge-end-table-expected.txt:
              * editing/pasteboard/paste-line-endings-007-expected.txt:
              * editing/pasteboard/paste-line-endings-008-expected.txt:
              * editing/pasteboard/paste-line-endings-009-expected.txt:
              * editing/pasteboard/paste-match-style-001-expected.txt:
              * editing/pasteboard/paste-text-002-expected.txt:
              * editing/pasteboard/paste-text-003-expected.txt:
              * editing/pasteboard/paste-text-004-expected.txt:
              * editing/pasteboard/paste-text-005-expected.txt:
              * editing/pasteboard/paste-text-006-expected.txt:
              * editing/pasteboard/paste-text-008-expected.txt:
              * editing/pasteboard/paste-text-009-expected.txt:
              * editing/pasteboard/paste-text-010-expected.txt:
              * editing/pasteboard/smart-paste-001-expected.txt:
              * editing/pasteboard/smart-paste-002-expected.txt:
              * editing/pasteboard/smart-paste-003-expected.txt:
              * editing/pasteboard/smart-paste-004-expected.txt:
              * editing/pasteboard/smart-paste-005-expected.txt:
              * editing/pasteboard/smart-paste-006-expected.txt:
              * editing/pasteboard/smart-paste-007-expected.txt:
              * editing/pasteboard/smart-paste-008-expected.txt:
              * editing/style/create-block-for-style-001-expected.txt:
              * editing/style/create-block-for-style-002-expected.txt:
              * editing/style/create-block-for-style-003-expected.txt:
              * editing/style/create-block-for-style-004-expected.txt:
              * editing/style/create-block-for-style-007-expected.txt:
              * editing/style/create-block-for-style-009-expected.txt:
              * editing/style/create-block-for-style-010-expected.txt:
              * editing/style/create-block-for-style-011-expected.txt:
              * editing/style/create-block-for-style-012-expected.txt:
              * editing/style/create-block-for-style-013-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/style-boundary-005-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
      
      WebCore:
      
              Reviewed by john
      
              <rdar://problem/5032066> Delete should work between ToDos
              
              Stop selecting the table when the user attempts to delete
              the line break just after it, instead, extend the selection
              into the last table cell.
              Let deletion merge content into table cells (as long as 
              its not from another table cell).  
              Start calling shouldInsertNode:replacingDOMRange:givenAction: 
              when moving content with moveParagraphs, so that Mail can 
              modify content before it is moved into a ToDo during a delete.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): Ask the
              delegate before performing the move.  This will let Mail
              prevent styles from entering a ToDo.
              Added a FIXME about adding a new WebViewInsertAction
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializePositionData):
              Allow merging into table cells from content not in a table.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingRightForward):
              Don't select the table when extending by character/word from
              just before it.  This code was here to make it easier to select
              tables in order to delete them, but the deletion UI makes it 
              largely unnecessary.
              (WebCore::SelectionController::modifyExtendingLeftBackward):
              Ditto.
              * editing/TypingCommand.cpp:
              (WebCore::isFirstPositionAfterTable): Added.
              (WebCore::isLastPositionBeforeTable): Ditto.
              (WebCore::TypingCommand::deleteKeyPressed): When pressing
              the delete key with a caret at the beginning of a paragraph
              just after a table, move the paragraph into the last table
              cell.
              Do not do this if it would mean moving a block table.
              Removed some old irrelevant comments.
              * editing/htmlediting.cpp: Removed unused functions.
              * editing/htmlediting.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7701503
    • staikos's avatar
      Remove redundant line. · 64c14577
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64c14577
    • staikos's avatar
      correct the changelog entry for the patch author. · 4eeb87ad
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4eeb87ad
    • staikos's avatar
      Take into account the entire run length to get a proper selection. · 4afb0159
      staikos authored
              Doesn't seem to affect the Mac build but is a problem for Qt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4afb0159
    • hyatt's avatar
      Fix for <rdar://problem/4545060>, technorati and arstechnica fail... · 3666feb9
      hyatt authored
              Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
              reporting display:none properly when it is set.  This is bugzilla bug 13103.
      
              Reviewed by mitz
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3666feb9
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 06d89a01
      oliver authored
              Reviewed by Hyatt.
      
              Rename DocLoader::setPasteInProgress, etc to more generic 
              setAllowStaleResources, etc
      
              * editing/Editor.cpp:
              (WebCore::Editor::paste):
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::DocLoader):
              (WebCore::DocLoader::checkForReload):
              * loader/DocLoader.h:
              (WebCore::DocLoader::setAllowStaleResources):
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06d89a01
  3. 28 Mar, 2007 9 commits
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 1c8a4876
      oliver authored
              Reviewed by Anders and Steve.
      
              Add a flag to DocLoader to prevent it from reloading 
              when performing a paste or drop operation.
              
              Remove m_cachePolicy from CachedResource as it is never used
              
              Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures 
              dragging image into GMail message in _web_writeImage and 
              documentFragmentFromDragData
      
              * editing/Editor.cpp:
              (WebCore::Editor::paste):
                prevent the docloader from reloading resources on paste
              * html/HTMLImageLoader.cpp:
              (WebCore::HTMLImageLoader::updateFromElement):
              * loader/Cache.cpp:
              (WebCore::createResource):
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
              * loader/CachedCSSStyleSheet.h:
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::CachedImage):
              * loader/CachedImage.h:
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::CachedResource):
              * loader/CachedResource.h:
              * loader/CachedScript.cpp:
              (WebCore::CachedScript::CachedScript):
              * loader/CachedScript.h:
              * loader/CachedXBLDocument.cpp:
              (WebCore::CachedXBLDocument::CachedXBLDocument):
              * loader/CachedXBLDocument.h:
              * loader/CachedXSLStyleSheet.cpp:
              (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
              * loader/CachedXSLStyleSheet.h:
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::DocLoader):
                 Tidy up constructor initialise new field
              (WebCore::DocLoader::checkForReload):
                 Prevent reload when pasting
              * loader/DocLoader.h:
              (WebCore::DocLoader::setPasteInProgress):
                new field and setter
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
                prevent the docloader from reloading resources on drop
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c8a4876
    • kjk's avatar
      Not reviewed - fix typo in gdk build. · b6a0acea
      kjk authored
              * platform/gdk/ScrollViewGdk.cpp:
              (WebCore::ScrollView::contentsToWindow):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6a0acea
    • mjs's avatar
      LayoutTests: · 14590a57
      mjs authored
              Reviewed by Darin.
              
              - <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
      
              * fast/overflow/scrollRevealButton-expected.checksum:
              * fast/overflow/scrollRevealButton-expected.png:
              * fast/overflow/scrollRevealButton-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
              
              - fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
                      
              Handle scrolling external scrollviews around the webview during
              autoscroll or when scrolling into view.
              
              This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::scrollRectIntoViewRecursively):
              * page/FrameView.h:
              * platform/ScrollView.h:
              * platform/gdk/ScrollViewGdk.cpp:
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              * platform/mac/ScrollViewMac.mm:
              (WebCore::ScrollView::visibleContentRect):
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              (WebCore::ScrollView::updateContents):
              * platform/qt/ScrollViewQt.cpp:
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              * platform/win/ScrollViewWin.cpp:
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              * platform/win/TemporaryLinkStubs.cpp:
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollRectToVisible):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14590a57
    • darin's avatar
      Reviewed and landed by Darin · 993602c1
      darin authored
              Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
              http://bugs.webkit.org/show_bug.cgi?id=13138
      
              * platform/StringImpl.cpp:
              (WebCore::StringImpl::isLower):
              (WebCore::StringImpl::lower):
              (WebCore::StringImpl::equalIgnoringCase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      993602c1
    • antti's avatar
      Reviewed by Hyatt. · 60c2cceb
      antti authored
              Fix <rdar://problem/5092653>
              REGRESSION: Image decoding making scrolling slow
              
              If decoder gave back a null frame (which I think happens regularly if you don't have full frame 
              data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
              led to massive growth in calculated image size and eventually made cache prune constantly. 
              
              No test, I don't know how to make one for this.
      
              * platform/graphics/BitmapImage.cpp:
              (WebCore::BitmapImage::cacheFrame):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60c2cceb
    • adele's avatar
      WebCore: · cc025d83
      adele authored
              Reviewed by Kevin M.
      
              WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
      
              * page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
              Convert return value to a string.  This matches the behavior in Safari 2.0.
      
      WebKit:
      
              Reviewed by Kevin M.
      
              WebKit part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
      
              Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings.  We used to allow this
              but now we throw a JavaScript exception for return statements that aren't in functions.
      
              Filed this evangelism bug so we can notify VitalSource of the problem:
              <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
      
              * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc025d83
    • ap's avatar
      Reviewed by Darin. · 16c9b5f7
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=13190
              XPath incorrectly handles namespaces on attributes
      
      WebCore:
              * xml/XPathStep.cpp:
              (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but 
              measurable performance improvement for bug 13021.
              (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.
      
              * xml/XPathStep.h:
              (WebCore::XPath::Step::NodeTest::NodeTest):
              (WebCore::XPath::Step::NodeTest::namespaceURI):
              (WebCore::XPath::Step::nodeTest):
              (WebCore::XPath::Step::setNodeTest):
              Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).
      
              * xml/XPathGrammar.y:
              * xml/XPathPath.cpp:
              (WebCore::XPath::LocationPath::optimizeStepPair):
              Accounted for the above change.
      
      LayoutTests:
              * fast/xpath/attr-namespace-expected.txt: Added.
              * fast/xpath/attr-namespace.html: Added.
      
              * fast/xpath/xpath-namespaces-expected.txt:
              * fast/xpath/xpath-namespaces.html:
              Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16c9b5f7
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 1c0320b6
      oliver authored
              rs=Hyatt.
      
              Rollout local changes :-/
      
              * loader/Cache.cpp:
              (WebCore::Cache::pruneAllResources):
              (WebCore::Cache::remove):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c0320b6
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 97c1d600
      oliver authored
              Reviewed by Hyatt.
      
              Roll out r20511 due to incredible badness
      
              * loader/Cache.cpp:
              (WebCore::Cache::pruneAllResources):
              (WebCore::Cache::remove):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97c1d600
  4. 27 Mar, 2007 12 commits
    • oliver's avatar
      2007-03-27 Oliver Hunt <oliver@apple.com> · 798912f8
      oliver authored
              Reviewed by Adam.
      
              Don't enforce text-selection drag delay when we are
              going to drag an image anyway.
      
              Fixes rdar://problem/4668935
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleDrag):
      Layout tests:
              Test to ensure there is no delay forced when dragging a selected image
      
              * editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum: Added.
              * editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
              * editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
              * editing/pasteboard/drag-selected-image-to-contenteditable.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      798912f8
    • justing's avatar
      Build fix · 7eaa01a4
      justing authored
              
              * editing/markup.cpp:
              (WebCore::startMarkup):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eaa01a4
    • justing's avatar
      LayoutTests: · 7d3dbfed
      justing authored
              Reviewed by darin
              
              <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family
      
              Demonstrates the bug fixed:
              * editing/style/5091898-expected.checksum: Added.
              * editing/style/5091898-expected.png: Added.
              * editing/style/5091898-expected.txt: Added.
              * editing/style/5091898.html: Added.
              Demonstrates a related bug fixed (deleting
              the line break before a paragraph could remove
              its underlining):
              * editing/deleting/5091898-expected.checksum: Added.
              * editing/deleting/5091898-expected.png: Added.
              * editing/deleting/5091898-expected.txt: Added.
              * editing/deleting/5091898.html: Added.
              Demonstrates that a link now (correctly) exists, 
              instead of just underlined text:
              * editing/pasteboard/4840662-expected.txt:
      
      WebCore:
      
              Reviewed by darin
              
              <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family
              
              createMarkup skipped elements if they were blocks
              when called from moveParagraphs (because that function 
              must receive only inline content).  This patch adds 
              code to inline these blocks instead of skipping them 
              so that we don't lose any of the style that they 
              contribute to the copied markup.
      
              * editing/markup.cpp:
              (WebCore::startMarkup): Add an inlineBlocks option.
              Make sure to overwrite display:block coming from
              a style sheet or the inline style declaration.
              (WebCore::createMarkup): Don't refuse to include a 
              specialCommonAncestor that's a block if we were asked 
              to include only inline content, since we can now inline 
              block elements in startMarkup.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d3dbfed
    • adele's avatar
      Reviewed by Hyatt. · 7c2f10dc
      adele authored
              Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery
      
              This disables the paint that occurs after WebCore finishes loading the document.  We should reenable this when we
              move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call.  See <rdar://problem/5092361>.
      
              * dom/Document.cpp: (WebCore::Document::implicitClose):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c2f10dc
    • justing's avatar
      LayoutTests: · dcdb2794
      justing authored
              Reviewed by darin
              
              <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
              <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
              <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
              <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented
      
              * editing/pasteboard/5065605-expected.checksum: Added.
              * editing/pasteboard/5065605-expected.png: Added.
              * editing/pasteboard/5065605-expected.txt: Added.
              * editing/pasteboard/5065605.html: Added.
              * editing/style/4916887-expected.checksum: Added.
              * editing/style/4916887-expected.png: Added.
              * editing/style/4916887-expected.txt: Added.
              * editing/style/4916887.html: Added.
              * editing/style/5065910-expected.checksum: Added.
              * editing/style/5065910-expected.png: Added.
              * editing/style/5065910-expected.txt: Added.
              * editing/style/5065910.html: Added.
              * editing/style/5084241-expected.checksum: Added.
              * editing/style/5084241-expected.png: Added.
              * editing/style/5084241-expected.txt: Added.
              * editing/style/5084241.html: Added.
      
      WebCore:
      
              Reviewed by darin
              
              <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
              <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
              <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
              <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
              If a node's text fill color is invalid, then its children use 
              their font-color as their text fill color (they don't inherit 
              it).  Likewise for stroke color.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcdb2794
    • andersca's avatar
      * platform/ScrollBar.h: · c3c0159f
      andersca authored
              Use wtf/MathExtras.h instead of math.h
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3c0159f
    • zack's avatar
      Fix the build · ad1986b4
      zack authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad1986b4
    • oliver's avatar
      2007-03-27 Oliver Hunt <oliver@apple.com> · 93990f86
      oliver authored
              Reviewed by Maciej.
      
              The WebArchiver needs all the subresources of a document to be accessible
              through the DocLoader, so we can't remove a CachedResource simultaneously
              from the global Cache and all DocLoaders, just because it needs to be 
              reloaded in one.
      
              Fixes rdar://problem/5044366
      
              * loader/Cache.cpp:
              (WebCore::Cache::remove):
                 Don't evict the resource from all DocLoaders
              * manual-tests/test-iframes-loading-the-same-resource.html: Added.
                 Alas it wasn't possible to make a nice layout test, even this manual test
                 is not entirely deterministic
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93990f86
    • bdash's avatar
      2007-03-27 Mark Rowe <mrowe@apple.com> · 0b93c7ef
      bdash authored
              Build fix.
      
              * platform/GlyphBuffer.h:
              (WebCore::GlyphBuffer::clear):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b93c7ef
    • hyatt's avatar
      Add support for glyph offsets to the GlyphBuffer. · 701900a4
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      701900a4
    • antti's avatar
      Keep buildbot happy. · 4e73c473
      antti authored
              * platform/mac/PlatformScrollBarMac.mm:
              (WebCore::PlatformScrollbar::scrollbarHit):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e73c473
    • antti's avatar
      WebCore: · 8a4614cf
      antti authored
              Reviewed by Darin.
              
              On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
              http://bugs.webkit.org/show_bug.cgi?id=13134
              <rdar://problem/5076249?
      
              * WebCore.exp:
                  Export _wkGetWheelEventDeltas
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleWheelEvent):
                  Remove (0, 0) scroll event hack, it is not needed anymore.
                  Do per-pixel scrolling for fine grained events.
              * platform/PlatformWheelEvent.h:
              (WebCore::PlatformWheelEvent::isContinuous):
                  Add new m_isContinuous boolean to indicate fine grained wheel events.
              * platform/ScrollBar.cpp:
              (WebCore::Scrollbar::Scrollbar):
              (WebCore::Scrollbar::setValue):
              (WebCore::Scrollbar::setSteps):
              (WebCore::Scrollbar::scroll):
              * platform/ScrollBar.h:
              (WebCore::Scrollbar::value):
                  Use float to represent current position to support finer grained scr...
      8a4614cf
  5. 26 Mar, 2007 6 commits