- 10 Jun, 2006 6 commits
-
-
ggaren authored
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8515 Linux porting compile bug Fix by Mike Emmel, Reviewed by Darin. * JavaScriptCoreSources.bkl: * jscore.bkl: * wtf/Platform.h: WebCore: - http://bugzilla.opendarwin.org/show_bug.cgi?id=8515 Linux porting compile bug Fix by Mike Emmel, Reviewed by Darin. * Projects/gdk/webcore-gdk.bkl: * WebCoreSources.bkl: * css/maketokenizer: * html/HTMLCanvasElement.cpp: * html/HTMLImageElement.h: * icon/IconDatabase.cpp: * make-generated-sources.sh: * page/Frame.h: * page/FramePrivate.h: * platform/Cursor.h: * platform/FontData.h: (WebCore::FontData::getGlyphIndex): * platform/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): * platform/GraphicsContext.h: * platform/PlatformKeyboardEvent.h: * platform/PlatformMouseEvent.h: * platform/PlatformWheelEvent.h: * platform/ScrollView.h: * platform/TransferJob.h: (WebCore::TransferJob::getInternal): * platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal): * platform/Widget.h: * platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::roundToDevicePixels): * webcore-base.bkl: * xpath/impl/XPathValue.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sullivan authored
WebKit support for computing but not highlighting rects for text matches. * WebView/WebHTMLViewPrivate.h: added markedTextMatchesAreHighlighted/setMarkedTextMatchesAreHighlighted and rectsForTextMatches, and renamed related methods for clarity/consistency * WebView/WebHTMLView.m: (-[WebHTMLView markAllMatchesForText:caseSensitive:]): renamed, calls similarly-renamed method (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): new method, calls through to bridge (-[WebHTMLView markedTextMatchesAreHighlighted]): ditto (-[WebHTMLView unmarkAllTextMatches]): renamed (-[WebHTMLView rectsForTextMatches]): new method, calls through to bridge * WebView/WebViewPrivate.h: added rectsForTextMatches, renamed other methods (and added highlight: parameter) * WebView/WebView.m: (-[WebView markAllMatchesForText:caseSensitive:highlight:]): renamed for clarity/consistency, and now has highlight: parameter, which is passed down (-[WebView unmarkAllTextMatches]): renamed for clarity/consistency, and calls similarly-renamed method lower down. diff got confused with the end of this and the end of the next method. (-[WebView rectsForTextMatches]): new method, calls through to WebHTMLView as related methods currently do git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sullivan authored
WebCore support for computing but not highlighting rects for text matches. * dom/Document.h: added setRenderedRectForMarker() and renderedRectsForMarkers(), and redefined MarkerMap to be a hashtable of node -> (pair of vectors), one vector of markers and one vector of rects * dom/Document.cpp: (placeholderRectForMarker()): new function, returns a recognizable degenerate rect used until a real rect has been set (WebCore::Document::addMarker): Reworked for new MarkerMap data structure; now adds parallel placeholder rect along with marker (WebCore::Document::copyMarkers): Reworked for new MarkerMap data structure (WebCore::Document::removeMarkers): Reworked for new MarkerMap data structure; now removed corresponding rect along with marker (WebCore::Document::markersForNode): Reworked for new MarkerMap data structure (WebCore::Document::renderedRectsForMarkers): New method, returns an array of all non-placeholder rects for the given marker type (WebCore::Document::repaintMarkers): Reworked for new MarkerMap data structure (WebCore::Document::setRenderedRectForMarker): New method, sets the rendered rect for a given marker (WebCore::Document::shiftMarkers): Reworked for new MarkerMap data structure; resets rendered rects to placeholders. * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): removed markedTextMatchesAreHighlighted guard; we always want to call paintTextMatchMarker now, but sometimes we will end up only computing the rect, not actually highlighting it. (Maybe some names should be improved here?) (WebCore::InlineTextBox::paintTextMatchMarker): Reorganized to move all the code that actually draws into a block that's guarded by markedTextMatchesAreHighlighted. The rest of the code computes where the highlight will go, and now we always use that computation in order to call setRenderedRectForMarker. * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rectsForTextMatches]): New method, returns an array of NSValues representing NSRects. Gets them from Document::renderedRectsForMarkers git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
http://bugzilla.opendarwin.org/show_bug.cgi?id=9384sullivan authored
WebView's initWithCoder: method does not set useBackForwardList correctly Reviewed by John Sullivan. * WebView/WebView.m: (-[WebView initWithCoder:]): Make sure that the function variable useBackForwardList is correctly set, so that the copy in the _private ivar is set. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap authored
Reviewed and landed by ap. - make DumpRenderTree build * DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Changed _updateFocusState to _updateActiveState (-[WaitUntilDoneDelegate webViewFocus:]): Ditto. (-[LayoutTestController setWindowIsKey:]): Ditto. (-[LayoutTestController setMainFrameIsFirstResponder:]): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca authored
Reviewed by Eric. * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::put): Call WebCore::JSHTMLElement::put so that autogenerated setters will work for HTMLElement. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 09 Jun, 2006 15 commits
-
-
ggaren authored
* JavaScriptCore.xcodeproj/project.pbxproj: * kjs/context.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
* bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
- Removed Context wrapper for ContextImp, renamed ContextImp to Context, split Context into its own file -- Context.cpp -- renamed _var to m_var, change ' *' to '* '. * JavaScriptCore.xcodeproj/project.pbxproj: * kjs/Context.cpp: Added. (KJS::Context::Context): (KJS::Context::~Context): (KJS::Context::mark): * kjs/context.h: (KJS::Context::scopeChain): (KJS::Context::variableObject): (KJS::Context::setVariableObject): (KJS::Context::thisValue): (KJS::Context::callingContext): (KJS::Context::activationObject): (KJS::Context::currentBody): (KJS::Context::function): (KJS::Context::arguments): (KJS::Context::pushScope): (KJS::Context::seenLabels): * kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::argumentsGetter): (KJS::GlobalFuncImp::callAsFunction): * kjs/internal.cpp: (KJS::InterpreterImp::evaluate): * kjs/internal.h: (KJS::InterpreterImp::setContext): (KJS::InterpreterImp::context): * kjs/interpreter.cpp: * kjs/interpreter.h: (KJS::ExecState::context): (KJS::ExecState::ExecState): * kjs/nodes.cpp: (currentSourceId): (currentSourceURL): (ThisNode::evaluate): (ResolveNode::evaluate): (FunctionCallResolveNode::evaluate): (PostfixResolveNode::evaluate): (DeleteResolveNode::evaluate): (TypeOfResolveNode::evaluate): (PrefixResolveNode::evaluate): (AssignResolveNode::evaluate): (VarDeclNode::evaluate): (VarDeclNode::processVarDecls): (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): (ForInNode::execute): (ContinueNode::execute): (BreakNode::execute): (ReturnNode::execute): (WithNode::execute): (SwitchNode::execute): (LabelNode::execute): (TryNode::execute): (FuncDeclNode::processFuncDecl): (FuncExprNode::evaluate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
* WebView/WebHTMLView.m: (-[WebHTMLView _updateActiveState]): (-[NSArray viewDidMoveToWindow]): (-[NSArray windowDidBecomeKey:]): (-[NSArray windowDidResignKey:]): (-[NSArray becomeFirstResponder]): (-[NSArray resignFirstResponder]): (-[WebHTMLView _formControlIsBecomingFirstResponder:]): (-[WebHTMLView _formControlIsResigningFirstResponder:]): * WebView/WebHTMLViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
about focus but is instead about whether or not the top-level window is active. Pull code that was incorrectly factored into Mac-only code out of FrameMac and back up into Frame. Reviewed by andersca * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: * page/Frame.cpp: (WebCore::Frame::setFocusNodeIfNeeded): (WebCore::Frame::isActive): (WebCore::Frame::setIsActive): * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
Rework selection coloring. Rename displaysWithFocusAttributes to isActive. Move the white-blending code onto the Color API to make it more convenient to mutate colors for selection blending. Eliminate all the selection state from the GraphicsContext and move it to the RenderTheme. Implement both Win32 and Mac theme selection colors. Reviewed by sfalken * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::setIsActive): * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]): (-[WebCoreFrameBridge setIsActive:]): (-[WebCoreFrameBridge selectionColor]): * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): * page/Frame.cpp: (WebCore::Frame::isActive): (WebCore::Frame::setIsActive): * page/Frame.h: * platform/Color.cpp: (WebCore::blend): (WebCore::Color::blendWithWhite): * platform/Color.h: (WebCore::Color::hasAlpha): * platform/GraphicsContext.cpp: (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): * platform/GraphicsContext.h: * platform/mac/GraphicsContextMac.mm: * platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::endTransparencyLayer): * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap): * rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint): * rendering/RenderImage.cpp: (WebCore::RenderImage::paint): * rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): * rendering/RenderListMarker.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::selectionColor): * rendering/RenderObject.h: * rendering/RenderReplaced.cpp: * rendering/RenderReplaced.h: * rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeSelectionColor): (WebCore::RenderTheme::inactiveSelectionColor): (WebCore::RenderTheme::platformActiveSelectionColor): (WebCore::RenderTheme::platformInactiveSelectionColor): * rendering/RenderTheme.h: * rendering/RenderThemeMac.h: * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformActiveSelectionColor): (WebCore::RenderThemeMac::platformInactiveSelectionColor): * rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::platformActiveSelectionColor): (WebCore::RenderThemeWin::platformInactiveSelectionColor): * rendering/RenderThemeWin.h: * rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): WebKit: Rename displaysWithFocusAttributes to isActive. Reviewed by sfalken * WebKit.xcodeproj/project.pbxproj: * WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
Reviewed by levi <rdar://problem/4549980> REGRESSION: "Find Again" can get stuck when searching for string with a trailing space * editing/execCommand/findString-expected.checksum: Added. * editing/execCommand/findString-expected.png: Added. * editing/execCommand/findString-expected.txt: Added. * editing/execCommand/findString.html: Added. WebCore: Reviewed by levi <rdar://problem/4549980> REGRESSION: "Find Again" can get stuck when searching for string with a trailing space * bridge/mac/FrameMac.h: Moved findString to Frame. * bridge/mac/FrameMac.mm: Ditto. * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:]): Convert the NSString to a String. * editing/JSEditor.cpp: Added execCommand(FindString, ...) * editing/Selection.cpp: Added a constructor for Ranges (WebCore::Selection::Selection): * editing/Selection.h: * page/Frame.cpp: (WebCore::Frame::findString): Moved from FrameMac. Compare a selection created using the found range with the current selection in case the current selection is the found range minus some collapsed whitespace on the edges. * page/Frame.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
http://bugzilla.opendarwin.org/show_bug.cgi?id=9350 Use pathcmp() when sorting paths in svn-create-patch * Scripts/run-webkit-tests: Fixed splitpath() to use File::Basename subroutines instead of regex. * Scripts/svn-create-patch: Copied numericcmp(), pathcmp() and splitpath() from run-webkit-tests. Changed sort() functions to use pathcmp(). Added subroutine prototypes. Added -h command-line switch and printUsage() subroutine. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken authored
Fix build break * WebCore.vcproj/WebCore/WebCore.vcproj: * css/MediaQueryEvaluator.cpp: * platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::addRoundedRectClip): (GraphicsContext::addInnerRoundedRectClip): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdakin authored
Landed by Beth. CSS3 Media Queries implementation. <http://bugzilla.opendarwin.org/show_bug.cgi?id=4127> * WebCore.xcodeproj/project.pbxproj: * bindings/js/kjs_css.cpp: (KJS::DOMMediaList::put): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction): * bindings/objc/DOMCSS.mm: (-[DOMMediaList setMediaText:]): (-[DOMMediaList deleteMedium:]): (-[DOMMediaList appendMedium:]): * css/CSSGrammar.y: * css/MediaFeatureNames.cpp: Added. (WebCore::MediaFeatureNames::init): * css/MediaFeatureNames.h: Added. * css/MediaList.cpp: (WebCore::MediaList::MediaList): (WebCore::MediaList::~MediaList): (WebCore::parseMediaDescriptor): (WebCore::MediaList::deleteMedium): (WebCore::MediaList::mediaText): (WebCore::MediaList::setMediaText): (WebCore::MediaList::item): (WebCore::MediaList::appendMedium): (WebCore::MediaList::appendMediaQuery): * css/MediaList.h: (WebCore::MediaList::MediaList): (WebCore::MediaList::length): (WebCore::MediaList::mediaQueries): * css/MediaQuery.cpp: Added. (WebCore::MediaQuery::MediaQuery): (WebCore::MediaQuery::~MediaQuery): (WebCore::MediaQuery::operator==): (WebCore::MediaQuery::cssText): * css/MediaQuery.h: Added. (WebCore::MediaQuery::): (WebCore::MediaQuery::restrictor): (WebCore::MediaQuery::expressions): (WebCore::MediaQuery::mediaType): (WebCore::MediaQuery::append): * css/MediaQueryEvaluator.cpp: Added. (WebCore::): (WebCore::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::~MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::mediaTypeMatch): (WebCore::applyRestrictor): (WebCore::MediaQueryEvaluator::eval): (WebCore::parseAspectRatio): (WebCore::cmpvalue): (WebCore::numberValue): (WebCore::colorMediaFeatureEval): (WebCore::monochromeMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::gridMediaFeatureEval): (WebCore::device_heightMediaFeatureEval): (WebCore::device_widthMediaFeatureEval): (WebCore::heightMediaFeatureEval): (WebCore::widthMediaFeatureEval): (WebCore::min_colorMediaFeatureEval): (WebCore::max_colorMediaFeatureEval): (WebCore::min_monochromeMediaFeatureEval): (WebCore::max_monochromeMediaFeatureEval): (WebCore::min_device_aspect_ratioMediaFeatureEval): (WebCore::max_device_aspect_ratioMediaFeatureEval): (WebCore::min_heightMediaFeatureEval): (WebCore::max_heightMediaFeatureEval): (WebCore::min_widthMediaFeatureEval): (WebCore::max_widthMediaFeatureEval): (WebCore::min_device_heightMediaFeatureEval): (WebCore::max_device_heightMediaFeatureEval): (WebCore::min_device_widthMediaFeatureEval): (WebCore::max_device_widthMediaFeatureEval): (WebCore::createFunctionMap): * css/MediaQueryEvaluator.h: Added. * css/MediaQueryExp.cpp: Added. (WebCore::MediaQueryExp::MediaQueryExp): (WebCore::MediaQueryExp::~MediaQueryExp): * css/MediaQueryExp.h: Added. (WebCore::MediaQueryExp::mediaFeature): (WebCore::MediaQueryExp::value): (WebCore::MediaQueryExp::operator==): * css/StyleSheet.cpp: (WebCore::StyleSheet::setMedia): * css/cssparser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseMediaQuery): (WebCore::CSSParser::createFloatingMediaQueryExp): (WebCore::CSSParser::sinkFloatingMediaQueryExp): (WebCore::CSSParser::createFloatingMediaQueryExpList): (WebCore::CSSParser::sinkFloatingMediaQueryExpList): (WebCore::CSSParser::createFloatingMediaQuery): (WebCore::CSSParser::sinkFloatingMediaQuery): * css/cssparser.h: * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::updateFont): (WebCore::CSSStyleSelector::cacheBorderAndBackground): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet): * css/cssstyleselector.h: * css/maketokenizer: * css/tokenizer.flex: * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createCSSStyleSheet): * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet): * html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged): * ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::createCSSStyleSheet): * ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged): * page/Frame.cpp: (WebCore::Frame::Frame): * platform/Screen.h: * platform/mac/ScreenMac.mm: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 08 Jun, 2006 9 commits
-
-
justing authored
Reviewed by levi <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468> Implement execCommand(Insert{Un}OrderedList) Added: * editing/execCommand/create-list-from-range-selection-expected.checksum: Added. * editing/execCommand/create-list-from-range-selection-expected.png: Added. * editing/execCommand/create-list-from-range-selection-expected.txt: Added. * editing/execCommand/create-list-from-range-selection.html: Added. * editing/execCommand/insert-list-and-stitch-expected.checksum: Added. * editing/execCommand/insert-list-and-stitch-expected.png: Added. * editing/execCommand/insert-list-and-stitch-expected.txt: Added. * editing/execCommand/insert-list-and-stitch.html: Added. * editing/execCommand/insert-list-with-id-expected.checksum: Added. * editing/execCommand/insert-list-with-id-expected.png: Added. * editing/execCommand/insert-list-with-id-expected.txt: Added. * editing/execCommand/insert-list-with-id.html: Added. * editing/execCommand/remove-list-from-range-selection-expected.checksum: Added. * editing/execCommand/remove-list-from-range-selection-expected.png: Added. * editing/execCommand/remove-list-from-range-selection-expected.txt: Added. * editing/execCommand/remove-list-from-range-selection.html: Added. * editing/execCommand/remove-list-items-expected.checksum: Added. * editing/execCommand/remove-list-items-expected.png: Added. * editing/execCommand/remove-list-items-expected.txt: Added. * editing/execCommand/remove-list-items.html: Added. * editing/execCommand/switch-list-type-expected.checksum: Added. * editing/execCommand/switch-list-type-expected.png: Added. * editing/execCommand/switch-list-type-expected.txt: Added. * editing/execCommand/switch-list-type.html: Added. Fixes: * editing/pasteboard/drag-drop-modifies-page-expected.txt: * editing/pasteboard/paste-list-001-expected.txt: * editing/selection/drag-to-contenteditable-iframe-expected.checksum: * editing/selection/drag-to-contenteditable-iframe-expected.png: * editing/selection/drag-to-contenteditable-iframe-expected.txt: * editing/style/block-style-005-expected.txt: * fast/text/textIteratorNilRenderer-expected.checksum: * fast/text/textIteratorNilRenderer-expected.png: * fast/text/textIteratorNilRenderer-expected.txt: * editing/deleting/delete-line-016-expected.checksum: * editing/deleting/delete-line-016-expected.png: * editing/deleting/delete-line-016-expected.txt: WebCore: Reviewed by levi <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468> Implement execCommand(Insert{Un}OrderedList) * WebCore.xcodeproj/project.pbxproj: Added InsertListCommand.{h,cpp} to the project. * dom/Position.cpp: (WebCore::hasRenderedNonAnonymousDescendantsWithHeight): Added. A block with height is only a candidate if this is false. This should fix the problems getting carets into empty blocks. (WebCore::Position::inRenderedContent): * editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply): * editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant): (WebCore::CompositeEditCommand::prune): A node can have DOM descendants that are rendered, yet have no rendered descendants. Fixed the pruning rule to avoid removing a node like this. (WebCore::CompositeEditCommand::mergeIdenticalElements): Put the two elements next to each other if they aren't already, as a convenience. (WebCore::CompositeEditCommand::moveParagraph): Added code to preserve the current selection. (WebCore::CompositeEditCommand::moveParagraphs): Ditto. * editing/CompositeEditCommand.h: * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Expansion for special elements should continue to happen until it is no longer possible. (WebCore::DeleteSelectionCommand::handleGeneralDelete): The code to adjust the start node wouldn't always avoid removing the start block. * editing/InsertListCommand.cpp: Added. (WebCore::InsertListCommand::fixOrphanedListChild): Puts a list item that isn't inside a list into a list. (WebCore::InsertListCommand::InsertListCommand): (WebCore::InsertListCommand::modifyRange): (WebCore::InsertListCommand::doApply): * editing/InsertListCommand.h: Added. (WebCore::InsertListCommand::): * editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): * editing/InsertParagraphSeparatorCommand.cpp: * editing/JSEditor.cpp: * editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't handle a node if the end of the range used to create the iterator ends at the start of that node. used to create the iterator. * editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): * editing/VisiblePosition.h: Added a parameter to next/previous to prevent them from going outside the current editable region. * editing/htmlediting.cpp: (WebCore::highestAncestor): (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::outermostEnclosingList): (WebCore::createListItemElement): * editing/htmlediting.h: * page/Frame.cpp: (WebCore::Frame::selectionListState): Added. * page/Frame.h: WebKit: Reviewed by levi <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468> Implement execCommand(Insert{Un}OrderedList) * WebView/WebFrame.m: (-[WebFrame _findFrameWithSelection]): Removed an assertion that we only have one frame with a selection. * WebView/WebView.m: (-[WebView selectedFrame]): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
Include our own copies of the BSD and LGPL licenses. * coding/bsd-license.html: Added. * coding/lgpl-license.html: Added. * nav.inc: link to our copies of the licenses git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
harrison authored
Reviewed by Geoff and John. <rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12) * fast/dom/setPrimitiveValue-expected.checksum: Added. * fast/dom/setPrimitiveValue-expected.png: Added. * fast/dom/setPrimitiveValue-expected.txt: Added. * fast/dom/setPrimitiveValue.html: Added. WebCore: Reviewed by Geoff and John. <rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12) Problem was the primitive value was getting reset to a generic state before the parameter check that relies on that state. Test: fast/dom/setPrimitiveValue.html * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::setFloatValue): (WebCore::CSSPrimitiveValue::setStringValue): Move parameter checks ahead of call to cleanup(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aliceli1 authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aliceli1 authored
- fixed <rdar://problem/4578115> support Range.isPointInRange - fixed <rdar://problem/4578123> support Range.comparePoint * dom/Range.cpp: (WebCore::Range::isPointInRange): added implementation (WebCore::Range::comparePoint): added implementation * dom/Range.h: added prototypes * dom/Range.idl: added bindings git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
thatcher authored
<rdar://problem/3600734> API: please add a way to turn vertical scrollbar always on (for Mail, to avoid reflow when typing) Adds new methods to lock the scrolling mode on WebDynamicScrollBarsView. Locking the scroll mode prevents WebCore from changing it as needed. Also adds an SPI on WebView that will lock the "always on" mode for each scroller. * WebKit.xcodeproj/project.pbxproj: * WebView/WebDynamicScrollBarsView.h: * WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]): (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]): (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]): (-[WebDynamicScrollBarsView setScrollingModesLocked:]): (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]): (-[WebDynamicScrollBarsView verticalScrollingModeLocked]): * WebView/WebView.m: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]): * WebView/WebViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
Reviewed by Justin. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616 REGRESSION: TinyMCE: Crash on Undo * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]): Changed to call nodeInfoAtPoint directly. (-[WebCoreFrameBridge _visiblePositionForPoint:]): Changed to call nodeInfoAtPoint directly. Also added code to convert coordinates so it works for points that are in nodes in subframes. * page/Frame.cpp: (WebCore::Frame::setMark): Added assertions to catch if we attempt to set selection endpoints in another document. (WebCore::Frame::setSelection): Ditto. WebKit: Reviewed by Justin. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616 REGRESSION: TinyMCE: Crash on Undo * WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]): Added. (-[WebHTMLView _isTopHTMLView]): Added. (-[WebHTMLView _insideAnotherHTMLView]): Changed to use _topHTMLView. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Forward to the top HTML view, so that only the top view ever starts a dragging operation. Change dragging code to not assume that the dragged node is in the current view's document. Added checks that the node is an element in a couple places and coordinate conversions. (-[WebHTMLView _mayStartDragAtEventLocation:]): Forward to the top HTML view. (-[NSArray addMouseMovedObserver]): Change to do nothing when the dataSource field is 0, since we now use the dataSource field to get to the WebView. (-[NSArray removeMouseMovedObserver]): Added a comment. (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Forward to the top HTML view. (-[NSArray draggingSourceOperationMaskForLocal:]): Assert that it's the top HTML view. (-[NSArray draggedImage:movedTo:]): Ditto. (-[NSArray draggedImage:endedAt:operation:]): Ditto. (-[NSArray namesOfPromisedFilesDroppedAtDestination:]): Ditto. (-[NSArray _canProcessDragWithDraggingInfo:]): Ditto. (-[NSArray _isMoveDrag]): Ditto. (-[NSArray draggingUpdatedWithDraggingInfo:actionMask:]): Ditto. (-[NSArray draggingCancelledWithDraggingInfo:]): Ditto. (-[NSArray concludeDragForDraggingInfo:actionMask:]): Ditto. Also added code to work with the appropriate bridge when receiving a drag. This fixes the problem where the top level frame got a selection intended for the inner frame; the source of the bug. (-[NSArray elementAtPoint:allowShadowContent:]): Added code to convert the coordinates so this works properly when returning an element from an inner frame. (-[NSArray setDataSource:]): Added a call to addMouseMovedObserver, needed now that addMouseMovedObserver won't do anything if called when dataSource is nil. (-[WebHTMLView _delegateDragSourceActionMask]): Forward to the top HTML view. * WebView/WebView.m: (-[WebViewPrivate dealloc]): Removed code to release dragCaretBridge since that field is now gone. (-[WebView moveDragCaretToPoint:]): Always call the main frame's bridge, since the drag caret is now a page-level item. Later we'll move it to the page bridge. (-[WebView removeDragCaret]): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 07 Jun, 2006 10 commits
-
-
justing authored
Reviewed by levi * editing/deleting/delete-4038408-fix-expected.txt: * editing/input/attributed-substring-from-range-lines-expected.txt: * editing/inserting/insert-3654864-fix-expected.txt: * editing/inserting/insert-3659587-fix-expected.txt: * editing/inserting/insert-3775316-fix-expected.txt: * editing/inserting/insert-at-end-01-expected.txt: * editing/inserting/insert-at-end-02-expected.txt: * editing/inserting/insert-br-001-expected.txt: * editing/inserting/insert-br-005-expected.txt: WebCore: Reviewed by levi Fixed some comments and removed an unused variable. * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeBlockPlaceholder): Don't remove a br if it isn't at the start of a block, since it isn't really a "block placeholder". * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply): * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): * editing/htmlediting.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
Reviewed by justin * WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:]): * WebView/WebHTMLView.m: (-[WebHTMLView _highlighterForType:]): * WebView/WebHTMLViewInternal.h: * WebView/WebHTMLViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
Reviewed by justin * WebCore.xcodeproj/project.pbxproj: * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::paintCustomHighlight): * bridge/mac/WebCoreFrameBridge.h: * platform/mac/ClipboardMac.h: * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight): * rendering/InlineTextBox.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
Reviewed by Hyatt Added support for cross-platform resize property. * platform/PlatformMouseEvent.h: Removed isMouseButtonDown, since we already cache this info when we handle mouse down and mouse up. * platform/mac/MouseEventMac.mm: ditto. * platform/win/TemporaryLinkStubs.cpp: ditto. * page/Frame.cpp: (WebCore::Frame::autoscrollTimerFired): Use d->m_bMousePressed instead of isMouseButtonDown. * page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent): Passes event to layer resize method. (WebCore::FrameView::mousePressed): Added. * page/FrameView.h: Added mousePressed. * rendering/RenderTheme.h: Removed paintResizeControl. Since its not dependent on the theme, the layer can just paint this. * rendering/RenderTheme.cpp: ditto. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): Initializes m_resizeCornerImage. (WebCore::RenderLayer::~RenderLayer): Deletes m_resizeCornerImage. (WebCore::RenderLayer::resize): Uses passed in event instead of creating a new one. (WebCore::RenderLayer::paintResizeControl): Now loads and paints the resize image. * rendering/RenderLayer.h: Added m_resizeCornerImage. Important to have one per-layer for when we allow more customization. * platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource): Loads image resources. WebKit: Reviewed by Hyatt. Added resources for missingImage and textAreaResizeCorner. * COM/WebKitDLL.cpp: (loadResourceIntoArray): Added. Returns a DeprecatedByteArray with the resource's data. * WebKit.vcproj/WebKit.rc: Added missing image and resize pngs as resources. * WebKit.vcproj/WebKit.vcproj: Added pngs. * WebKit.vcproj/missingImage.png: Added. * WebKit.vcproj/resource.h: Added entries for pngs. * WebKit.vcproj/textAreaResizeCorner.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
Reviewed by Tim H * WebView/WebHTMLView.m: (-[WebTextCompleteController dealloc]): (-[WebHTMLView _setHighlighter:ofType:]): (-[WebHTMLView _removeHighlighterOfType:]): * WebView/WebHTMLViewInternal.h: * WebView/WebHTMLViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
adds support for the parsing of the property. It doesn't do anything yet. Reviewed by beth * css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSPropertyNames.in: * css/cssparser.cpp: (WebCore::CSSParser::parseValue): * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): * rendering/render_style.cpp: (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): (WebCore::StyleCSS3InheritedData::operator==): (WebCore::RenderStyle::diff): * rendering/render_style.h: (WebCore::RenderStyle::highlight): (WebCore::RenderStyle::setHighlight): (WebCore::RenderStyle::initialHighlight): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
* API: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9341 REGRESSION: Repro crash caused by style="font:bold" Test: fast/css/font-shorthand-weight-only.html * css/cssparser.cpp: (WebCore::CSSParser::parseFont): Revert part of the change made to fix bug 5564. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
Reviewed by Hyatt, tweaked by Mitz. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9122 REGRESSION: Incorrect vertical position for text fields in a "display: table" block * fast/table/text-field-baseline-expected.checksum: Added. * fast/table/text-field-baseline-expected.png: Added. * fast/table/text-field-baseline-expected.txt: Added. * fast/table/text-field-baseline.html: Added. WebCore: Reviewed by Hyatt. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9122 REGRESSION: Incorrect vertical position for text fields in a "display: table" block Test: fast/table/text-field-baseline.html * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::baselinePosition): Do not descend into replaced objects, just use their baseline. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
Reviewed by Hyatt. - pixel test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4334 REGRESSION: Flickering when css-hover should change opacity on floating elements * fast/block/float/nopaint-after-layer-destruction-expected.checksum: Added. * fast/block/float/nopaint-after-layer-destruction-expected.png: Added. * fast/block/float/nopaint-after-layer-destruction-expected.txt: Added. * fast/block/float/nopaint-after-layer-destruction.html: Added. WebCore: Reviewed by Hyatt (concept) and Darin (some coding details). - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4334 REGRESSION: Flickering when css-hover should change opacity on floating elements Pixel test: fast/block/float/nopaint-after-layer-destruction.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::setPaintsFloatingObject): Added. Changes the noPaint flag in the block's FloatingObject for the given float and calls setChildNeedsLayout. * rendering/RenderBlock.h: * rendering/RenderBox.cpp: (WebCore::blockThatPaintsFloat): Added this helper function. (WebCore::RenderBox::setStyle): Added. Calls to setPaintsFloatingObject when a float gains or loses its layer. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-