- 16 Feb, 2010 26 commits
-
-
zimmermann@webkit.org authored
Reviewed by David Hyatt. SVG units don't stay consistently sized on zoom https://bugs.webkit.org/show_bug.cgi?id=14004 Large step towards making WebKit an usable SVG viewer. Make zooming into SVG documents work as expected, in both standalone and XHTML/SVG compound documents. SVG applies a global scale to the document, whereas CSS zooms all individual length units (on full-page-zoom). Scaling has to be avoided for all SVG specific CSS properties (already works) and for some selected CSS properties shared between CSS & SVG that explicitely need a different treatment in the context of SVG. To name a few: font-size, letter-spacing, etc. should stay invariant under zoom in SVG document fragments. Some new rules regarding zooming: - "Zoom text only" should never affect SVG documents, neither text nor content should zoom. This option doesn't make much sense for SVG, so it's wise to avoid side-effects and disable it. In compound documents the SVG would stay as-is and only text of surrounding XHTML content would zoom. - "Full page zoom" is the only zoom mode affecting SVG. (Panning only works in standalone documents.) Cover all mentioned cases above by a new set of layout tests. Tests: svg/zoom/page/absolute-sized-document-no-scrollbars.svg svg/zoom/page/absolute-sized-document-scrollbars.svg svg/zoom/page/relative-sized-document-scrollbars.svg svg/zoom/page/zoom-coords-viewattr-01-b.svg svg/zoom/page/zoom-foreignObject.svg svg/zoom/page/zoom-hixie-mixed-008.xml svg/zoom/page/zoom-hixie-mixed-009.xml svg/zoom/page/zoom-hixie-rendering-model-004.xhtml svg/zoom/page/zoom-svg-float-border-padding.xml svg/zoom/text/absolute-sized-document-no-scrollbars.svg svg/zoom/text/absolute-sized-document-scrollbars.svg svg/zoom/text/relative-sized-document-scrollbars.svg svg/zoom/text/zoom-coords-viewattr-01-b.svg svg/zoom/text/zoom-foreignObject.svg svg/zoom/text/zoom-hixie-mixed-008.xml svg/zoom/text/zoom-hixie-mixed-009.xml svg/zoom/text/zoom-hixie-rendering-model-004.xhtml svg/zoom/text/zoom-svg-float-border-padding.xml * css/CSSStyleSelector.cpp: Blacklist certain properties not to be zoomed for SVG elements. (WebCore::CSSStyleSelector::styleForDocument): Don't zoom font-sizes. (WebCore::CSSStyleSelector::applyProperty): Ditto (+ letter/word-spacing). (WebCore::CSSStyleSelector::setFontSize): Ditto. (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): Never apply text zoom to SVG. * css/CSSStyleSelector.h: * css/SVGCSSStyleSelector.cpp: -webkit-shadow + SVG was incorrectly respecting zoom factor. (WebCore::CSSStyleSelector::applySVGProperty): * page/Frame.cpp: (WebCore::Frame::shouldApplyTextZoom): Remove SVG special cases. (WebCore::Frame::shouldApplyPageZoom): Ditto. (WebCore::Frame::setZoomFactor): Don't force setZoomsTextOnly() - SVG now uses FPZ as well. * rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcReplacedWidth): CSSPropertyWidth is explicitely not scaled by CSSStyleSelector, fix that for outermost <svg> elements. (WebCore::RenderSVGRoot::calcReplacedHeight): Ditto for CSSPropertyHeight. (WebCore::RenderSVGRoot::layout): Simplify & cleanup code, take advantage of new calcWidth/Height functionality, no need to scale anything here. (WebCore::RenderSVGRoot::paint): Use parentOriginToBorderBox() instead of duplicating code. (WebCore::RenderSVGRoot::calcViewport): Simplify code. (WebCore::RenderSVGRoot::localToBorderBoxTransform): Calculate viewBoxToViewTransformation() against unscaled width()/height() values. * rendering/RenderSVGRoot.h: * svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport): Cleanup & document function. * svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): Return pageZoomFactor(), not just the zoomFactor() - as we want to ignore text-only zoom. (WebCore::SVGSVGElement::setCurrentScale): Pass isTextOnly=false to setZoomFactor(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Reviewed by David Hyatt. SVG units don't stay consistently sized on zoom https://bugs.webkit.org/show_bug.cgi?id=14004 * platform/mac/svg/zoom: Added. * platform/mac/svg/zoom/page: Added. * platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added. * platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added. * platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added. * platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Added. * platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added. * platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added. * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Added. * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added. * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added. * platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added. * platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added. * platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added. * platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added. * platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Added. * platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Added. * platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added. * platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added. * platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added. * platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added. * platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added. * platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added. * platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.checksum: Added. * platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added. * platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added. * platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Added. * platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added. * platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added. * platform/mac/svg/zoom/text: Added. * platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Added. * platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added. * platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added. * platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Added. * platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added. * platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added. * platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Added. * platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added. * platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added. * platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum: Added. * platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added. * platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added. * platform/mac/svg/zoom/text/zoom-foreignObject-expected.checksum: Added. * platform/mac/svg/zoom/text/zoom-foreignObject-expected.png: Added. * platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt: Added. * platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum: Added. * platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added. * platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added. * platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum: Added. * platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added. * platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added. * platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.checksum: Added. * platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added. * platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added. * platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Added. * platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added. * platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added. * svg/zoom: Added. * svg/zoom/NOTE: Added. * svg/zoom/page: Added. * svg/zoom/page/absolute-sized-document-no-scrollbars.svg: Added. * svg/zoom/page/absolute-sized-document-scrollbars.svg: Added. * svg/zoom/page/relative-sized-document-scrollbars.svg: Added. * svg/zoom/page/zoom-coords-viewattr-01-b.svg: Added. * svg/zoom/page/zoom-foreignObject.svg: Added. * svg/zoom/page/zoom-hixie-mixed-008.xml: Added. * svg/zoom/page/zoom-hixie-mixed-009.xml: Added. * svg/zoom/page/zoom-hixie-rendering-model-004.xhtml: Added. * svg/zoom/page/zoom-svg-float-border-padding.xml: Added. * svg/zoom/resources: Added. * svg/zoom/resources/testPageZoom.js: Added. * svg/zoom/resources/testTextZoom.js: Added. * svg/zoom/text: Added. * svg/zoom/text/absolute-sized-document-no-scrollbars.svg: Added. * svg/zoom/text/absolute-sized-document-scrollbars.svg: Added. * svg/zoom/text/relative-sized-document-scrollbars.svg: Added. * svg/zoom/text/zoom-coords-viewattr-01-b.svg: Added. * svg/zoom/text/zoom-foreignObject.svg: Added. * svg/zoom/text/zoom-hixie-mixed-008.xml: Added. * svg/zoom/text/zoom-hixie-mixed-009.xml: Added. * svg/zoom/text/zoom-hixie-rendering-model-004.xhtml: Added. * svg/zoom/text/zoom-svg-float-border-padding.xml: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric.carlson@apple.com authored
Reviewed by Simon Fraser. https://bugs.webkit.org/show_bug.cgi?id=34988 WebHTMLView.mm has two -willRemoveSubview: methods * WebView/WebHTMLView.mm: (-[WebHTMLView willRemoveSubview:]): Consolidate the two copies of this method. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jparent@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=34998 Move include of JavaScriptProfile.h behind if (USE_JSC). * inspector/InspectorController.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. re-factor Skipped list parsing code into multiple functions and unit test it https://bugs.webkit.org/show_bug.cgi?id=34986 * Scripts/test-webkitpy: Add new unit test. * Scripts/webkitpy/layout_tests/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. * Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing. * Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=34989 <rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content This fixes event dispatch for both Cocoa and Carbon event models (mouseEntered/mouseExited in the former case, and adjustCursor in the latter). * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView handleMouseEntered:]): (-[WebHostedNetscapePluginView handleMouseExited:]): * Plugins/WebBaseNetscapePluginView.h: * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView handleMouseEntered:]): (-[WebBaseNetscapePluginView handleMouseExited:]): * Plugins/WebNetscapePluginView.h: * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): (-[WebNetscapePluginView handleMouseExited:]): AppKit cannot reliably dispatch events for overlapping views. We are now asking WebCore to notify plug-in views of mouse entered/exited as part of DOM event dispatch. * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Besides mouse moved, dispatch plugin mouse entered/exit events in HTMLPlugInElement default event handler. Other mouse events are passed down by EventHandler. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Eric Carlson. With hardware acceleration turned off, video frames never display if poster image is specified https://bugs.webkit.org/show_bug.cgi?id=34965 HTMLVideoElement's m_shouldDisplayPosterImage was never updated after the movie supplied its first video frame, so the poster would continue to show. Fixed by calling updatePosterImage() from mediaPlayerRepaint(), which is called each time a new frame is available. updatePosterImage() is cheap. Also made updatePosterImage() virtual on HTMLMediaElement to avoid a number of ugly casts. Test: manual-tests/media-elements/video-replaces-poster.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::noneSupported): Call updatePosterImage() without video check. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::setReadyState): Ditto. (WebCore::HTMLMediaElement::mediaPlayerRepaint): Call udpatePosterImage(). * html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::updatePosterImage): Make this an empty virtual method on the base class. * html/HTMLVideoElement.h: Override updatePosterImage(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Build fix for platforms without ACCELERATED_COMPOSITING defined. mediaPlayerRenderingModeChanged() is only available when ACCELERATED_COMPOSITING is defined. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setUpVideoRendering): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Eric Carlson. Autoplaying video with poster doesn't reliably show up https://bugs.webkit.org/show_bug.cgi?id=34966 A timing issue with compositing updates when replacing the poster image with the video could cause the video to not display. Fix by making video layer hook up more similar to WebGL etc, by having the video kick off a recalcStyle() via a SyntheticStyleChange. This requires vending a PlaformLayer* from the media player, up through the element. Test: media/video-replaces-poster.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerRenderingModeChanged): Use setNeedsStyleRecalc() to kick off a compositing update. * html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::platformLayer): Export the media engine's layer. * platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::platformLayer): Method to vend the media layer. (WebCore::MediaPlayer::platformLayer): * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRenderingModeChanged): New client callback to indicate that the rendering mode changed. The element uses this to kick off a recalcStyle. * platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::platformLayer): Method to vend the media layer. * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Ditto * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): No longer parent the layer directly via setContentsToMedia(). (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): Ditto. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Tell the client that the rendering mode changed. (WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer. * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Call setContentsToMedia() here. * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: Add platformLayer(). * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Call mediaPlayerRenderingModeChanged() (WebCore::MediaPlayerPrivate::createLayerForMovie): Don't parent the layer ourselves any more. * rendering/RenderVideo.h: videoGraphicsLayer() is no longer needed. * rendering/RenderVideo.cpp: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Refreshed all localization-related files, so that they are up-to-date with the code. * de.po: Updated. * en_GB.po: Updated. * es.po: Updated. * it.po: Updated. * lt.po: Updated. * nl.po: Updated. * pt_BR.po: Updated. * ru.po: Updated. * sr.po: Updated. * sr@latin.po: Updated. * sv.po: Updated. * vi.po: Updated. * webkit.pot: Updated. * zh_CN.po: Updated. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Reviewed by Gustavo Noronha. Localization of WebKitGTK+ in Hebrew. * he.po: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pkasting@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=28751 Reviewed by Adam Barth. * Make code mostly comply with the style guide (switch indenting, use of "!" vs. "== 0", don't unnecessarily wrap lines, etc.) * Eliminate m_allDataReceived in ICO/BMP decoders since it's in the base ImageDecoder class * Remove some useless or wrong comments, add others * Wrap comments at 80 columns (most already were) for consistency/readability * Avoid casts by using correct variable types * Consistent naming of decode() function/args * Shorter code in some places * Make declaration and definition order match * platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::frameCount): (WebCore::ImageDecoderQt::frameBufferAtIndex): (WebCore::ImageDecoderQt::forceLoadEverything): * platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::setSize): * platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::ImageDecoder::ImageDecoder): * platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::setData): (WebCore::BMPImageDecoder::isSizeAvailable): (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decode): (WebCore::BMPImageDecoder::decodeHelper): (WebCore::BMPImageDecoder::processFileHeader): * platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32): * platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader): (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::readInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::isInfoHeaderValid): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData): * platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::pastEndOfImage): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::getComponent): (WebCore::BMPImageReader::getAlpha): (WebCore::BMPImageReader::setI): (WebCore::BMPImageReader::setRGBA): * platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::GIFImageDecoder): (WebCore::GIFImageDecoder::setData): (WebCore::GIFImageDecoder::isSizeAvailable): (WebCore::GIFImageDecoder::frameCount): (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::sizeNowAvailable): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete): (WebCore::GIFImageDecoder::decode): (WebCore::GIFImageDecoder::initFrameBuffer): * platform/image-decoders/gif/GIFImageDecoder.h: (WebCore::GIFImageDecoder::): (WebCore::GIFImageDecoder::filenameExtension): * platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::do_lzw): (GIFImageReader::read): * platform/image-decoders/gif/GIFImageReader.h: (GIFImageReader::~GIFImageReader): * platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::~ICOImageDecoder): (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::frameSizeAtIndex): (WebCore::ICOImageDecoder::frameCount): (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::compareEntries): (WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex): (WebCore::ICOImageDecoder::decode): (WebCore::ICOImageDecoder::decodeDirectory): (WebCore::ICOImageDecoder::decodeAtIndex): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::readDirectoryEntry): * platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32): * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::): (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::skipBytes): (WebCore::JPEGImageReader::decode): (WebCore::error_exit): (WebCore::fill_input_buffer): (WebCore::term_source): (WebCore::JPEGImageDecoder::setData): (WebCore::JPEGImageDecoder::setSize): (WebCore::JPEGImageDecoder::frameBufferAtIndex): (WebCore::JPEGImageDecoder::jpegComplete): (WebCore::JPEGImageDecoder::decode): * platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::filenameExtension): * platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::decodingFailed): (WebCore::decodingWarning): (WebCore::headerAvailable): (WebCore::rowAvailable): (WebCore::pngComplete): (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::decode): (WebCore::PNGImageReader::createInterlaceBuffer): (WebCore::PNGImageDecoder::setData): (WebCore::PNGImageDecoder::frameBufferAtIndex): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable): (WebCore::PNGImageDecoder::pngComplete): (WebCore::PNGImageDecoder::decode): * platform/image-decoders/png/PNGImageDecoder.h: (WebCore::PNGImageDecoder::filenameExtension): * platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::setDecodedImage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Reviewed by Xan Lopez. Check if the handle has a SoupMessage before trying to use it. This will be the case in non-HTTP(S) URLs. * webkit/webkitdownload.cpp: (webkit_download_new_with_handle): (webkit_download_start): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* WebCore.pro: Missing backslash added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
Reviewed by Pavel Feldman. Move JSC-specific wrappers for Profile and ProfileNode to bindings/js. https://bugs.webkit.org/show_bug.cgi?id=34848 * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JavaScriptProfile.cpp: Added. (WebCore::profileCache): (WebCore::getTitleCallback): (WebCore::getHeadCallback): (WebCore::getUniqueIdCallback): (WebCore::focus): (WebCore::exclude): (WebCore::restoreAll): (WebCore::finalize): (WebCore::ProfileClass): (WebCore::toJS): * bindings/js/JavaScriptProfile.h: Added. * bindings/js/JavaScriptProfileNode.cpp: Added. (WebCore::profileNodeCache): (WebCore::getFunctionName): (WebCore::getURL): (WebCore::getLineNumber): (WebCore::getTotalTime): (WebCore::getSelfTime): (WebCore::getNumberOfCalls): (WebCore::getChildren): (WebCore::getVisible): (WebCore::getCallUID): (WebCore::finalize): (WebCore::ProfileNodeClass): (WebCore::toJS): * bindings/js/JavaScriptProfileNode.h: Added. * inspector/JavaScriptProfile.cpp: Removed. * inspector/JavaScriptProfile.h: Removed. * inspector/JavaScriptProfileNode.cpp: Removed. * inspector/JavaScriptProfileNode.h: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: Elements Panel: Limit the number of initially loaded element children https://bugs.webkit.org/show_bug.cgi?id=34421 Test: inspector/elements-panel-limited-children.html WebCore: * English.lproj/localizedStrings.js: * inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._insertChild): * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateModifiedNodes): * inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor): (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.get expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.set expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.get expandedChildCount): (WebInspector.ElementsTreeElement.prototype.showChild): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.moveChild): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange): (WebInspector.ElementsTreeElement.prototype.handleLoadAllChildren): (): * inspector/front-end/inspector.css: LayoutTests: * inspector/elements-panel-limited-children-expected.txt: Added. * inspector/elements-panel-limited-children.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Reviewed by Gustavo Noronha. Bump version to 1.1.22 so we can depend on it in applications. * configure.ac: WebKit/gtk: 2010-02-16 Xan Lopez <xlopez@igalia.com> Reviewed by Gustavo Noronha. Add a new WebKitWebSettings setting, 'auto-resize-window', set to FALSE by default, that when enabled will apply any resizes or moves done by a page through various DOM methods (moveTo, resizeTo, moveBy, resizeBy). * WebCoreSupport/ChromeClientGtk.cpp: * webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy): WebKitTools: 2010-02-16 Xan Lopez <xlopez@igalia.com> Reviewed by Gustavo Noronha. Enable 'auto-resize-window' in our DRT. * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benm@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=34476 Reviewed by Simon Hausmann. Split the basic-touch-events test into two separate tests, one for single and another for multi touch. Also refactor the tests to run in an asynchronous manner. * fast/events/touch/basic-multi-touch-events.html: Copied from LayoutTests/fast/events/touch/basic-touch-events.html. Tests the same multi touch tests cases from the old basic-touch-events test. * fast/events/touch/basic-multi-touch-events-expected.txt: Added. * fast/events/touch/script-tests/basic-multi-touch-events.js: Added. * fast/events/touch/basic-single-touch-events.html: Copied from LayoutTests/fast/events/touch/basic-touch-events.html. Tests the same single touch tests cases from the old basic-touch-events test. * fast/events/touch/script-tests/basic-single-touch-events.js: Added. * fast/events/touch/basic-single-touch-events-expected.txt: Added. * fast/events/touch/basic-touch-events.html: Removed. * fast/events/touch/script-tests/basic-touch-events.js: Removed. * fast/events/touch/basic-touch-events-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
Updated the def file with two new exports used by QtLauncher. * symbian/eabi/QtWebKitu.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Pavel Feldman. Fix compilation with inspector disabled. https://bugs.webkit.org/show_bug.cgi?id=32724 * rendering/RenderLayerBacking.cpp: (WebCore::inspectorTimelineAgent): 2010-02-16 Ismail Donmez <ismail@namtrac.org> Reviewed by Pavel Feldman. Fix compilation with inspector disabled. https://bugs.webkit.org/show_bug.cgi?id=32724 * Api/qwebpage.cpp: (qt_drt_webinspector_executeScript): (qt_drt_webinspector_close): (qt_drt_webinspector_show): (qt_drt_setTimelineProfilingEnabled): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-02-16 Reviewed by Simon Hausman. * Api/DerivedSources.pro: Use relative paths for package builds and added some documentation. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: turn off line wrapping in source view. https://bugs.webkit.org/show_bug.cgi?id=34935 * inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.markAndRevealRange): (WebInspector.TextViewer.prototype._paintLine): * inspector/front-end/textViewer.css: * inspector/front-end/utilities.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: let search iterate over views in Resources and keep the view in Scripts. https://bugs.webkit.org/show_bug.cgi?id=34968 * inspector/front-end/Panel.js: (WebInspector.Panel.prototype.jumpToNextSearchResult): (WebInspector.Panel.prototype.jumpToPreviousSearchResult): (WebInspector.Panel.prototype.showSourceLineForURL): (WebInspector.Panel.prototype.searchIteratesOverViews): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get _resources): (WebInspector.ResourcesPanel.prototype.searchIteratesOverViews): * inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.showingLastSearchResult): * inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.focusSearchField): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Ariya Hidayat. [Qt] canvas clipping is buggy https://bugs.webkit.org/show_bug.cgi?id=32405 Apparently the bug was in GraphicsContext::roundToDevicePixels, we didn't take unto accounts rotation, so the device pixels were rounded incorrectly. The new formula is a 1:1 copy from GraphicsContextCG so it should be rather safe Test: http://glimr.rubyforge.org/cake/canvas.html#Polaroids now looks right * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Copy the formula from GraphicsContextCG git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Not Reviewed, build fix. * platform/graphics/FloatRect.h: (WebCore::FloatRect::center): make conversion from float to int explicit so that compiler doesn't complain about that. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Gavin Barraclough. Fix the SP at ctiOpThrowNotCaught on Thumb2 (JSVALUE32) https://bugs.webkit.org/show_bug.cgi?id=34939 * jit/JITStubs.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 15 Feb, 2010 14 commits
-
-
mrobinson@webkit.org authored
Reviewed by Darin Adler. check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin https://bugs.webkit.org/show_bug.cgi?id=34834 * Scripts/webkitpy/style/processors/cpp.py: * Scripts/webkitpy/style/processors/cpp_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/7645609mitz@apple.com authored
Reviewed by Simon Fraser. Refine the fix for https://bugs.webkit.org/show_bug.cgi?id=34923 by using the center of a quad’s bounding box, rather than its top left, as the reference point passed to offsetFromContainer(). This ensures that if a sliver off the top of the selection rect is in one column, but most of it is on another column, the single rect we return will be for the second column. * platform/graphics/FloatRect.h: (WebCore::FloatRect::center): Added. * rendering/RenderObject.cpp: (WebCore::RenderObject::localToContainerQuad): Use the center instead of the top left. LayoutTests: Add test case for <rdar://problem/7645609> [webView selectionRect] API is broken for multicolumn layout Reviewed by Simon Fraser. * fast/multicol/client-rects-expected.checksum: * fast/multicol/client-rects-expected.png: * fast/multicol/client-rects-expected.txt: * fast/multicol/client-rects.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Nikolas Zimmermann. SVG text refactor: reduce paint specific callbacks on SVGTextChunkWalker https://bugs.webkit.org/show_bug.cgi?id=34831 No new tests, no change of functionality. * rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): Removed setupBackground(), setupFill(), setupFillSelection(), setupStroke(), setupStrokeSelection(), setupForeground() and associated member variables. * rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::setupBackground): renamed from chunkSetupBackgroundCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupFill): renamed from chunkSetupFillCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection): renamed from chunkSetupFillSelectionCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupStroke): renamed from chunkSetupStrokeCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection): renamed from chunkSetupStrokeSelectionCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupForeground): renamed from chunkSetupForegroundCallback. (WebCore::SVGRootInlineBoxPaintWalker::paintChunk): renamed from chunkPortionCallback. (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): extracted from walkTextChunks. (WebCore::SVGRootInlineBox::paint): follow SVGTextChunkWalker change. (WebCore::SVGRootInlineBox::walkTextChunks): moved paint some specific code to SVGRootInlineBoxPaintWalker::chunkPortionCallback(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by NOBODY (Build Fix!). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by Oliver Hunt. Rename Rope::m_ropeLength to m_fiberCount, to be more descriptive. Rename Rope::m_stringLength to simply m_length (since this is the more conventional name for the length of a string). Move append behaviour out into a new RopeBuilder class, so that Rope no longer needs any knowledge of the JSString or UString implementation. Make Rope no longer be nested within JSString. (Rope now no-longer need reside within JSString.h, but leaving the change of moving this out to a different header as a separate change from these renames). * JavaScriptCore.exp: * jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): * runtime/JSString.cpp: (JSC::Rope::destructNonRecursive): (JSC::Rope::~Rope): (JSC::JSString::resolveRope): (JSC::JSString::toBoolean): (JSC::JSString::getStringPropertyDescriptor): * runtime/JSString.h: (JSC::Rope::Fiber::Fiber): (JSC::Rope::Fiber::deref): (JSC::Rope::Fiber::ref): (JSC::Rope::Fiber::refAndGetLength): (JSC::Rope::Fiber::isRope): (JSC::Rope::Fiber::rope): (JSC::Rope::Fiber::isString): (JSC::Rope::Fiber::string): (JSC::Rope::Fiber::nonFiber): (JSC::Rope::tryCreateUninitialized): (JSC::Rope::append): (JSC::Rope::fiberCount): (JSC::Rope::length): (JSC::Rope::fibers): (JSC::Rope::Rope): (JSC::Rope::operator new): (JSC::): (JSC::RopeBuilder::JSString): (JSC::RopeBuilder::~JSString): (JSC::RopeBuilder::length): (JSC::RopeBuilder::canGetIndex): (JSC::RopeBuilder::appendStringInConstruct): (JSC::RopeBuilder::appendValueInConstructAndIncrementLength): (JSC::RopeBuilder::isRope): (JSC::RopeBuilder::fiberCount): (JSC::JSString::getStringPropertySlot): * runtime/Operations.h: (JSC::jsString): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=34949 Reviewed by Darin Fisher. Chromium passes back NULL when you call WebStorageNamespace::proxy() but TestShell returns a valid object. Both need to work via the WebStorageNamespace. * src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespaceProxy::copy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
* rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::convertToPaintingRect): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by NOBODY (Build fix). * runtime/RegExp.cpp: (JSC::RegExp::match): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
Skipped glyph-reordering on Windows since it has failed since it was landed. Left a comment in <https://bugs.webkit.org/show_bug.cgi?id=34865> to track the failure. * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Many false leaks in release builds due to PtrAndFlags Reviewed by Darin Adler. JavaScriptCore: StructureTransitionTable was effectively a smart pointer type, one machine word in size and wholly contained as a member of of Structure. It either pointed to an actual table, or could be used to describe a single transtion entry without use of a table. This, however, worked by using a PtrAndFlags, which is not compatible with the leaks tool. Since there is no clear way to obtain another bit for 'free' here, and since there are bits available up in Structure, merge this functionality back up into Structure. Having this in a separate class was quite clean from an enacapsulation perspective, but this solution doesn't seem to bad - all table access is now intermediated through the Structure::structureTransitionTableFoo methods, keeping the optimization fairly well contained. This was the last use of PtrAndFlags, so removing the file too. * JavaScriptCore.xcodeproj/project.pbxproj: * bytecode/CodeBlock.h: * runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::hasTransition): * runtime/Structure.h: (JSC::Structure::): (JSC::Structure::structureTransitionTableContains): (JSC::Structure::structureTransitionTableGet): (JSC::Structure::structureTransitionTableHasTransition): (JSC::Structure::structureTransitionTableRemove): (JSC::Structure::structureTransitionTableAdd): (JSC::Structure::structureTransitionTable): (JSC::Structure::setStructureTransitionTable): (JSC::Structure::singleTransition): (JSC::Structure::setSingleTransition): * runtime/StructureTransitionTable.h: * wtf/PtrAndFlags.h: Removed. WebCore: PtrAndFlags has now been removed; remove forwarding header. * ForwardingHeaders/wtf/PtrAndFlags.h: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
Skip more plugin tests on Snow Leopard buildbot, as they need updated closed source components. * platform/mac-snowleopard/Skipped: Skip netscape-dom-access.html and netscape-browser-object-identity.html. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Fixes <http://webkit.org/b/34956> Add API to get a WebFrame's visible content rect Reviewed by Jon Honeycutt. * Interfaces/IWebFramePrivate.idl: Added visibleContentRect. * Interfaces/WebKit.idl: Touched to force a build. * WebFrame.cpp: (WebFrame::visibleContentRect): * WebFrame.h: Added. Calls through to FrameView::visibleContentRect. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Bug 34948 - tryMakeString should fail on error in length calculation Ooops! - "bool overflow" argument should have been "bool& overflow". * runtime/UString.h: (JSC::sumWithOverflow): (JSC::tryMakeString): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-