Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 10 May, 2008 2 commits
  3. 09 May, 2008 21 commits
    • weinig@apple.com's avatar
      WebCore: · 751ee9fb
      weinig@apple.com authored 
      2008-05-09  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18958
        NULL pointer dereference in NamedAttrMap::setNamedItem

        Test: fast/dom/NamedNodeMap-setNamedItem-crash.html

        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::setNamedItem): Null check the argument.

LayoutTests:

2008-05-09  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Test for https://bugs.webkit.org/show_bug.cgi?id=18958
        NULL pointer dereference in NamedAttrMap::setNamedItem

        * fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Added.
        * fast/dom/NamedNodeMap-setNamedItem-crash.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      751ee9fb
    • mrowe@apple.com's avatar
      Roll out r33018 as it broke the builds. · c219e9cb
      mrowe@apple.com authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c219e9cb
    • andersca@apple.com's avatar
      2008-05-09 Anders Carlsson <andersca@apple.com> · be4e18c4
      andersca@apple.com authored 
              Reviewed by Mark.

        Add x86_64 rule.
        
        * Makefile:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be4e18c4
    • mrowe@apple.com's avatar
      Update TestNetscapePlugIn to build 64-bit using the Cocoa event model. · a0bed7e7
      mrowe@apple.com authored 
      It currently does not attempt to print events which means that plugins/mouse-events.html
will fail when run 64-bit.  All other tests that use this plugin pass.

Reviewed by Anders Carlsson.

* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(testGetIntIdentifier):
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_HandleEvent):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0bed7e7
    • andersca@apple.com's avatar
      WebKit: · 52cae976
      andersca@apple.com authored 
      2008-05-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins
        
        Add nptextinput.h as a public header.
        
        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-05-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins
        
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView start]):
        Get the plug-in text input vtable pointer.
        
        (-[WebBaseNetscapePluginView stop]):
        Set the plug-in text input vtable pointer to 0.
        
        (-[WebBaseNetscapePluginView inputContext]):
        Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.
        
        (-[WebBaseNetscapePluginView hasMarkedText]):        
        (-[WebBaseNetscapePluginView insertText:]):
        (-[WebBaseNetscapePluginView markedRange]):
        (-[WebBaseNetscapePluginView selectedRange]):
        (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
        (-[WebBaseNetscapePluginView unmarkText]):
        (-[WebBaseNetscapePluginView validAttributesForMarkedText]):
        (-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
        (-[WebBaseNetscapePluginView characterIndexForPoint:]):
        (-[WebBaseNetscapePluginView doCommandBySelector:]):
        (-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
        (-[WebBaseNetscapePluginView conversationIdentifier]):
        Implement NSTextInput and call into the plug-in text input vtable.
        
        (browserTextInputFuncs):
        New method which returns the browser input vtable.
        
        (-[WebBaseNetscapePluginView getVariable:value:]):
        Support getting the browser input vtable pointer.
        
        * Plugins/WebNetscapePluginEventHandlerCocoa.h:
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::keyDown):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
        it means that the event should be passed on to the input manager.
         
        * Plugins/npapi.mm:
        (NPN_MarkedTextAbandoned):
        (NPN_MarkedTextSelectionChanged):
        Add implementations of browser input method methods.
        
        * Plugins/nptextinput.h: Added.
        Add file with new text input API.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52cae976
    • beidson@apple.com's avatar
      WebKit/win: · 2de2bcf0
      beidson@apple.com authored 
              Reviewed by Adam Roben

        Fix a hang-on-quit bug where in the DLL_PROCESS_DETACH DllMain callback, we assummed that
        we could cleanly shutdown WebKit but we couldn't because any background threads have already
        been uncleanly aborted at that point.
        
        * ForEachCoClass.cpp:
        (shutDownWebKit): Moved from WebKitDLL to here, to be exposed via WebKit.def
        * ForEachCoClass.h:
        
        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:
        
        * WebKitDLL.cpp:
        (DllMain): Don't call shutDownWebKit here
        
WebKitTools:
        Reviewed by Adam Roben

        Explicitly call shutDownWebKit() before quitting.

        * Drosera/win/Drosera.cpp:
        (_tWinMain):

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (main):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2de2bcf0
    • ddkilzer@apple.com's avatar
      Changed tabs into spaces for VPATH and DOM_CLASSES items. · 0d7bf053
      ddkilzer@apple.com authored 
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d7bf053
    • mrowe@apple.com's avatar
      Fix the Tiger build of Drosera. · 1f3830ac
      mrowe@apple.com authored 
      * Drosera/config.h: Define BUILDING_ON_TIGER when building on Tiger.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f3830ac
    • beidson@apple.com's avatar
      Build Fix · 6b7eb849
      beidson@apple.com authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b7eb849
    • kmccullough@apple.com's avatar
      2008-05-09 Kevin McCullough <kmccullough@apple.com> · 6b218430
      kmccullough@apple.com authored 
              Build fix.

        * page/Console.cpp:
        (WebCore::Console::profile):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b218430
    • weinig@apple.com's avatar
      WebCore: · ba6e665a
      weinig@apple.com authored 
      2008-05-09  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Mark Rowe.

        Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

        * Configurations/WebCore.xcconfig:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/build-generated-files.sh:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::customGetOwnPropertySlot):
        (WebCore::JSDOMWindow::postMessage):
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/objc/DOMEvents.mm:
        (+[DOMEvent _wrapEvent:WebCore::]):
        * dom/Document.cpp:
        (WebCore::Document::createEvent):
        * dom/Event.cpp:
        (WebCore::Event::isMessageEvent):
        * dom/Event.h:
        * dom/MessageEvent.cpp:
        * dom/MessageEvent.h:
        * dom/MessageEvent.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

WebKit/win:

2008-05-09  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Mark Rowe.

        Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

        * WebKit.vcproj/WebKit.vcproj:

WebKitTools:

2008-05-09  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Mark Rowe.

        Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

        * Scripts/build-webkit:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba6e665a
    • aroben@apple.com's avatar
      Build fix · 19e79c0b
      aroben@apple.com authored 
              * Interfaces/WebKit.idl: Touched.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19e79c0b
    • kmccullough@apple.com's avatar
      2008-05-09 Kevin McCullough <kmccullough@apple.com> · 320e01ec
      kmccullough@apple.com authored 
              Reviewed by Tim.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Add Profile class so that all profiles can be stored and retrieved by
        the WebInspector when that time comes.

        * JavaScriptCore.exp: Export the new function signatures.
        * JavaScriptCore.xcodeproj/project.pbxproj: Add the new files to the
        project
        * profiler/Profile.cpp: Added. This class represents a single run of the
        profiler.
        (KJS::Profile::Profile):
        (KJS::Profile::willExecute):
        (KJS::Profile::didExecute):
        (KJS::Profile::printDataInspectorStyle):
        (KJS::functionNameCountPairComparator):
        (KJS::Profile::printDataSampleStyle):
        * profiler/Profile.h: Added. Ditto
        (KJS::Profile::stopProfiling):
        * profiler/Profiler.cpp: Now the profiler keeps track of many profiles
        but only runs one at a time.
        (KJS::Profiler::startProfiling):
        (KJS::Profiler::stopProfiling):
        (KJS::Profiler::willExecute):
        (KJS::Profiler::didExecute):
        (KJS::Profiler::printDataInspectorStyle):
        (KJS::Profiler::printDataSampleStyle):
        * profiler/Profiler.h: Ditto.
        (KJS::Profiler::~Profiler):
        (KJS::Profiler::allProfiles):
        (KJS::Profiler::clearProfiles):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      320e01ec
    • weinig@apple.com's avatar
      WebCore: · c092b7ef
      weinig@apple.com authored 
      2008-05-09  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=18771

        Make postMessage generate an event on the window instead of the
        document.

        Test: http/tests/messaging/cross-domain-message-event-dispatch.html

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchWindowEvent):
        * dom/EventTargetNode.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

2008-05-09  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        Update tests to listen for message events on the window instead of
        the document.  Also, added a test that the event is sent to the
        window and not to the document.

        * http/tests/messaging/cross-domain-message-event-dispatch-expected.txt: Added.
        * http/tests/messaging/cross-domain-message-event-dispatch.html: Added.
        * http/tests/messaging/cross-domain-message-send.html:
        * http/tests/messaging/resources/cross-domain-message-receive.html:
        * http/tests/security/cross-frame-access-delete.html:
        * http/tests/security/cross-frame-access-history-put.html:
        * http/tests/security/cross-frame-access-location-put.html:
        * http/tests/security/postMessage/delivery-order.html:
        * http/tests/security/postMessage/invalid-origin-throws-exception.html:
        * http/tests/security/postMessage/javascript-page-still-sends-origin.html:
        * http/tests/security/postMessage/origin-unaffected-by-base-tag.html:
        * http/tests/security/postMessage/origin-unaffected-by-document-domain.html:
        * http/tests/security/postMessage/resources/post-message-listener.html:
        * http/tests/security/postMessage/target-origin.html:
        * http/tests/security/resources/cross-frame-iframe-for-delete-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-location-put-test.html:
        * http/tests/security/xss-eval.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c092b7ef
    • hausmann@webkit.org's avatar
      Simon Hausmann <hausmann@webkit.org> · ba4d9c1a
      hausmann@webkit.org authored 
      Removed explicit linkage against libxml and libxslt on Qt/Mac builds.

This dependency is completely unnecessary here and creates only problems by
propagating through WebCore.pro over libQtWebKit.prl right now customer
applications.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba4d9c1a
    • hausmann@webkit.org's avatar
      Thiago Macieira <tjmaciei@trolltech.com> · 6d61d17b
      hausmann@webkit.org authored 
      Fix bad includes in QtWebKit public headers.

Make sure to include qglobal.h using the QtCore prefix so that an explicit
include/QtCore is not needed in the application's build system. Also make sure
that qwebsettings.h includes the local qwebkitglobal.h.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d61d17b
    • hausmann@webkit.org's avatar
      2008-05-09 Tor Arne Vestbø <tavestbo@trolltech.com> · ce241dae
      hausmann@webkit.org authored 
              Reviewed by Simon.

        Replaced all instances of qDebug() with LOG(Media, ...)
        in MediaPlayerPrivatePhonon.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce241dae
    • hausmann@webkit.org's avatar
      2008-05-09 Tor Arne Vestbø <tavestbo@trolltech.com> · 29c511df
      hausmann@webkit.org authored 
              Reviewed by Simon

        Fix the Qt/Mac build.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29c511df
    • hausmann@webkit.org's avatar
      2008-05-08 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk> · 61f4ee65
      hausmann@webkit.org authored 
              Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=18935

        Based on work by Sriram Neelakandan for the Gtk port.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61f4ee65
    • mrowe@apple.com's avatar
      Another attempt at a Tiger build fix. · 847f080c
      mrowe@apple.com authored 
      Use DumpRenderTreeMac.h rather than DumpRenderTree.h as DumpRenderTreePasteboard is not an Obj-C++ file.

* DumpRenderTree/mac/DumpRenderTreePasteboard.m:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      847f080c
    • mrowe@apple.com's avatar
      Tiger build fix. Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined. · 0cbfa2a2
      mrowe@apple.com authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cbfa2a2
  5. 08 May, 2008 17 commits