- 18 Jan, 2011 35 commits
-
-
mjs@apple.com authored
Revert inadvertantly committed test changes. * editing/pasteboard/copy-null-characters.html: * fast/events/scroll-event-does-not-bubble.html: * platform/mac-wk2/Skipped: * transitions/remove-transition-style.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs@apple.com authored
Reviewed by Sam Weinig. WebKitTestRunner should track loading more like DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=52692 Change load tracking to track the current top loading frame, in the manner of DumpRenderTree. This makes some tests that call notifyDone multiple times pass. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): (WTR::InjectedBundle::done): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::topLoadingFrame): (WTR::InjectedBundle::setTopLoadingFrame): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::stopLoading): (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): (WTR::InjectedBundlePage::didFinishLoadForFrame): (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::notifyDone): * WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveMessageFromInjectedBundle): 2011-01-18 Maciej Stachowiak <mjs@apple.com> Reviewed by Sam Weinig. WebKitTestRunner should track loading more like DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=52692 Relax the message check in didSaveFrameToPageCache a bit more, since layout tests were still hitting the old one. * UIProcess/WebPageProxy.cpp: (WebKit::isDisconnectedFrame): (WebKit::WebPageProxy::didSaveFrameToPageCache): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Gavin Barraclough. [jsfunfuzz] Assertion asking activation for arguments when arguments is overridden https://bugs.webkit.org/show_bug.cgi?id=52690 Add a few more tests. * fast/js/function-dot-arguments-expected.txt: * fast/js/script-tests/function-dot-arguments.js: (overwroteArgumentsInDynamicScope1): (overwroteArgumentsInDynamicScope2): (overwroteArgumentsInDynamicScope3): 2011-01-18 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough. [jsfunfuzz] Assertion asking activation for arguments when arguments is overridden https://bugs.webkit.org/show_bug.cgi?id=52690 Clean up code to retrieve arguments from activation and function objects. Remove the incorrect assertion from JSActivation's argumentsGetter. * interpreter/Interpreter.cpp: (JSC::Interpreter::retrieveArguments): * runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dimich@chromium.org authored
* platform/chromium-mac/fast/css/background-clip-values-expected.checksum: Added. * platform/chromium-mac/fast/css/background-clip-values-expected.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
cause a crash. https://bugs.webkit.org/show_bug.cgi?id=52654 Reviewed by Adam Roben. * fast/dom/Window/open-window-empty-url-expected.txt: Added. * fast/dom/Window/open-window-empty-url.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
robert@webkit.org authored
Reviewed by Simon Hausmann. [Qt] http/tests/incremental/slow-utf8-text.pl fails https://bugs.webkit.org/show_bug.cgi?id=44282 * platform/qt/Skipped: 2011-01-18 Robert Hogan <robert@webkit.org> Reviewed by Simon Hausmann. [Qt] http/tests/incremental/slow-utf8-text.pl fails https://bugs.webkit.org/show_bug.cgi?id=44282 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::responseMimeType): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2011-01-18 Robert Hogan <robert@webkit.org> Reviewed by Simon Hausmann. [Qt] http/tests/incremental/slow-utf8-text.pl fails https://bugs.webkit.org/show_bug.cgi?id=44282 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
msaboff@apple.com authored
Reviewed by Oliver Hunt. <rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540) https://bugs.webkit.org/show_bug.cgi?id=52540 https://bugs.webkit.org/show_bug.cgi?id=52662 Directly use backtrack label with parentheses nested under a non-capturing parentheses. Also linked current parentheses tail code object for possible parens nested within a non-capturing parentheses. * yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::linkBacktrackToLabel): (JSC::Yarr::YarrGenerator::generateParenthesesSingle): 2011-01-18 Michael Saboff <msaboff@apple.com> Reviewed by Oliver Hunt. <rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540) https://bugs.webkit.org/show_bug.cgi?id=52540 https://bugs.webkit.org/show_bug.cgi?id=52662 New tests to check for proper linking of parentheses nested under a non-capturing parentheses. * fast/regex/parentheses-expected.txt: * fast/regex/script-tests/parentheses.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/8479998hyatt@apple.com authored
Reviewed by Dan Bernstein. Exclude floating objects from shrinking to avoid floats. They should never do this. Timing-related bugs could occur as a result of this mistake, and the change to rewrite pagination to defer layout of floats until they got encountered on the correct line exposed this issue. Source/WebCore: Added /fast/block/float/float-overflow-hidden-containing-block-width.html. * rendering/RenderBox.cpp: (WebCore::RenderBox::shrinkToAvoidFloats): LayoutTests: Added /fast/block/float/float-overflow-hidden-containing-block-width.html. * fast/block/float/float-overflow-hidden-containing-block-width.html: Added. * platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.checksum: Added. * platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.png: Added. * platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dimich@chromium.org authored
affected by http://trac.webkit.org/changeset/76047 * platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum: * platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png: * platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum: * platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png: * platform/chromium-win/fast/css/background-clip-values-expected.checksum: Added. * platform/chromium-win/fast/css/background-clip-values-expected.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbr@google.com authored
Reviewed by David Levin. Must strip comments from WebGL shaders before enforcing character set https://bugs.webkit.org/show_bug.cgi?id=52390 Strip comments from incoming shaders, preserving line numbers, before validating that they conform to the ESSL character set. Revert changes from http://trac.webkit.org/changeset/75735 which allowed invalid characters to be passed to certain APIs. Tested with WebGL layout tests, conformance test suite and several WebGL demos in both Safari and Chromium. * html/canvas/WebGLRenderingContext.cpp: (WebCore::StripComments::StripComments::process): (WebCore::WebGLRenderingContext::shaderSource): 2011-01-18 Kenneth Russell <kbr@google.com> Reviewed by David Levin. Must strip comments from WebGL shaders before enforcing character set https://bugs.webkit.org/show_bug.cgi?id=52390 Incorporated non-ASCII GLSL conformance tests from Khronos repository. Updated and synchronized invalid-passed-params.html with Khronos repository, undoing changes from http://trac.webkit.org/changeset/75735 . * fast/canvas/webgl/glsl-conformance-expected.txt: * fast/canvas/webgl/invalid-passed-params-expected.txt: * fast/canvas/webgl/invalid-passed-params.html: * fast/canvas/webgl/shaders/00_shaders.txt: * fast/canvas/webgl/shaders/misc: Added. * fast/canvas/webgl/shaders/misc/00_shaders.txt: Added. * fast/canvas/webgl/shaders/misc/non-ascii-comments.vert: Added. * fast/canvas/webgl/shaders/misc/non-ascii.vert: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cmarrin@apple.com authored
Reviewed by Simon Fraser. Add LayoutTests for new compositing layer logic https://bugs.webkit.org/show_bug.cgi?id=52657 Add 4 tests checking that the layer tree is properly constructed with nested layers. The first test is a simple static test of a layer with a 3D transform with a non-layered parent. It is a pixel test and is just looking for a correct image. The second test is similar but has a 4 deep hierarchy of <div> element where only the innermost layer has a 3D transform. It is also a pixel test. The other 2 tests are the same except that they add and then remove the innermost layer's transform. It makes sure the layer tree is correct before and after these changes. * compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added. * compositing/geometry/layer-due-to-layer-children-deep-switch.html: Added. * compositing/geometry/layer-due-to-layer-children-deep.html: Added. * compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added. * compositing/geometry/layer-due-to-layer-children-switch.html: Added. * compositing/geometry/layer-due-to-layer-children.html: Added. * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added. * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added. * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added. * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added. * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added. * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihaip@chromium.org authored
Reviewed by Ojan Vafai. [Chromium] Update Sputnik test expectations https://bugs.webkit.org/show_bug.cgi?id=52656 Mark Sputnik tests as WONTFIX, so that they don't artificially inflate our failing test count. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dimich@chromium.org authored
Added exclusion for new test fast/canvas/canvas-fillPath-alpha-shadow.html * platform/chromium-gpu/test_expectations.txt: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Antti Koivisto. [jsfunfuzz] Assertion in codegen for array of NaN constants https://bugs.webkit.org/show_bug.cgi?id=52643 Add a testcase to ensure we handle a large number of NaN literals in (0/0 is folded to NaN automatically during parsing). * fast/js/codegen-temporaries-expected.txt: * fast/js/script-tests/codegen-temporaries.js: 2011-01-18 Oliver Hunt <oliver@apple.com> Reviewed by Antti Koivisto. [jsfunfuzz] Assertion in codegen for array of NaN constants https://bugs.webkit.org/show_bug.cgi?id=52643 Don't cache NaN literals in the code generator, as NaN doesn't compare as equal to itself it causes problems when rehashing the number cache. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Simon Fraser. Support background-clip: content-box https://bugs.webkit.org/show_bug.cgi?id=48771 Addded content-box as a valid background-clip value. * WebCore/css/CSSParser.cpp: (WebCore::parseBackgroundClip): 2011-01-18 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com> Reviewed by Simon Fraser. Support background-clip: content-box https://bugs.webkit.org/show_bug.cgi?id=48771 Added test cases to check the various valid background-clip values. * fast/css/background-clip-text-expected.txt: * fast/css/background-clip-values-expected.checksum: Added. * fast/css/background-clip-values-expected.txt: Added. * fast/css/background-clip-values.html: Added. * fast/css/script-tests/background-clip-text.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=52324 Reviewed by Darin Adler. Source/WebCore: Fallout from recent change to make WebCore return its own scroll view. 1) There were two scroll views in the hierarchy, one which no needed to be ignored. 2) Hit tests for sub frames needed to be offset. 3) The check for whether an attachment is ignored must happen earlier than using the helpText to determine if an element should be ignored. Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::elementAccessibilityHitTest): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): * accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper scrollViewParent]): Source/WebKit/mac: * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView accessibilityIsIgnored]): LayoutTests: * platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added. * platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reviewed by Eric Seidel. [GTK] Filenames are converted to URLs during edit drags https://bugs.webkit.org/show_bug.cgi?id=52096 * platform/gtk/Skipped: Unskip passing test. Fix a misspelled drag and drop test on the list as well. 2011-01-18 Martin Robinson <mrobinson@igalia.com> Reviewed by Eric Seidel. [GTK] Filenames are converted to URLs during edit drags https://bugs.webkit.org/show_bug.cgi?id=52096 * platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the conversion policy allows it. (WebCore::DragData::containsURL): Ditto. (WebCore::DragData::asURL): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
[Chromium] Create baselines for svg/css/text-gradient-shadow.svg https://bugs.webkit.org/show_bug.cgi?id=52640 * platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum: Added. * platform/chromium-linux/svg/css/text-gradient-shadow-expected.png: Added. * platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Added. * platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum: Added. * platform/chromium-win/svg/css/text-gradient-shadow-expected.png: Added. * platform/chromium-win/svg/css/text-gradient-shadow-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Skip two tests which were incorrectly passing before GTK+ had support for beginDragWithFiles. * platform/gtk/Skipped: Skip failing tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jknotten@chromium.org authored
Reviewed by Jeremy Orlow. [Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux. https://bugs.webkit.org/show_bug.cgi?id=52633 Combine test expectations for the test into one line. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Incorrect shadow alpha with semi-transparent solid fillStyle https://bugs.webkit.org/show_bug.cgi?id=52611 This is related to bug 52559. The shadow color alpha must be multiplied by the context brush alpha. New test to ensure correct behavior of canvas with fillPath using a semi-transparent fillStyle color and a shadow. * fast/canvas/canvas-fillPath-alpha-shadow-expected.txt: Added. * fast/canvas/canvas-fillPath-alpha-shadow.html: Added. * fast/canvas/script-tests/canvas-fillPath-alpha-shadow.js: Added. 2011-01-18 Helder Correia <helder@sencha.com> Reviewed by Kenneth Rohde Christiansen. [Qt] Incorrect shadow alpha with semi-transparent solid fillStyle https://bugs.webkit.org/show_bug.cgi?id=52611 This is related to bug 52559. The shadow color alpha must be multiplied by the context brush alpha. Test: fast/canvas/canvas-fillPath-alpha-shadow.html * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jknotten@chromium.org authored
Unreviewed; updated chromium test expectations. [Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux. https://bugs.webkit.org/show_bug.cgi?id=52633 * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson <mrobinson@igalia.com> Reviewed by Gustavo Noronha Silva. [GTK] The GTK+ EventSender needs support for beginDragWithFiles https://bugs.webkit.org/show_bug.cgi?id=40833 Unskip passing tests, add in a GTK+-specific result and one more result which is necessary because GTK+ tests run in Xvfb. * platform/gtk/Skipped: Unskip tests that are now passing and organize the remaining skipped tests. * platform/gtk/fast/forms/input-file-re-render-expected.txt: Added. * platform/gtk/http/tests/security/clipboard/clipboard-file-access-expected.txt: Added. 2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson <mrobinson@igalia.com> Reviewed by Gustavo Noronha Silva. [GTK] The GTK+ EventSender needs support for beginDragWithFiles https://bugs.webkit.org/show_bug.cgi?id=40833 * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the GTK+ event sender. (dragWithFilesDragDataGetCallback): Added. (dragWithFilesDragEndCallback): Added. (beginDragWithFilesCallback): Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
caseq@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: fail resource.requestContent() immediately for WebSocket resources Remove webInspector.resources.Types from test expectations. https://bugs.webkit.org/show_bug.cgi?id=52628 * inspector/extensions-api-expected.txt: 2011-01-18 Andrey Kosyakov <caseq@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: fail resource.requestContent() immediately for WebSocket resources https://bugs.webkit.org/show_bug.cgi?id=52628 * English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too) * inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete) (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript): * inspector/front-end/Resource.js: (WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used. (WebInspector.Resource.Type.toString): ditto. (WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources. * inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Dirk Schulze. REGRESSION(75139): SVG gradients are not applied to texts https://bugs.webkit.org/show_bug.cgi?id=52531 r75139 caused a problem with filling and stroking text with a gradient fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect was mixed up. * platform/mac/svg/css/text-gradient-shadow-expected.checksum: Added. * platform/mac/svg/css/text-gradient-shadow-expected.png: Added. * platform/mac/svg/css/text-gradient-shadow-expected.txt: Added. * svg/css/text-gradient-shadow.svg: Added. 2011-01-18 Helder Correia <helder@sencha.com> Reviewed by Dirk Schulze. REGRESSION(75139): SVG gradients are not applied to texts https://bugs.webkit.org/show_bug.cgi?id=52531 r75139 caused a problem with filling and stroking text with a gradient fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect was mixed up. Test: svg/css/text-gradient-shadow.svg * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jknotten@chromium.org authored
Reviewed by Jeremy Orlow. Add pixel test baseline for svg/custom/use-inherit-style.svg https://bugs.webkit.org/show_bug.cgi?id=52630 * svg/custom/use-inherit-style-expected.checksum: Added. * svg/custom/use-inherit-style-expected.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Nikolas Zimmermann. Unable to indirectly animate visibility of SVGUseElement https://bugs.webkit.org/show_bug.cgi?id=50240 Test case to verify if SVGUseElement inherits parent's style change. * svg/custom/use-inherit-style-expected.txt: Added. * svg/custom/use-inherit-style.svg: Added. 2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn> Reviewed by Nikolas Zimmermann. Unable to indirectly animate visibility of SVGUseElement https://bugs.webkit.org/show_bug.cgi?id=50240 SVGUseElement::recalcStyle should take care of its shadow tree's style recalculation when it is called with change >= Inherit or when childNeedsStyleRecalc() is true because in these two cases needStyleRecalc() may not be true. Test: svg/custom/use-inherit-style.svg * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::recalcStyle): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Unreviewed, remove wrong chromium expectation for console-xhr-logging test. * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Unreviewed, test fix for r76019. * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt: * http/tests/inspector-enabled/console-log-before-frame-navigation.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: preserve pause on exception state in settings. https://bugs.webkit.org/show_bug.cgi?id=52619 * inspector/InspectorController.cpp: (WebCore::InspectorController::getInspectorState): * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): * inspector/InspectorDebuggerAgent.h: * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsState): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions): * inspector/front-end/Settings.js: (WebInspector.Settings): * inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: fix flaky debugger tests. https://bugs.webkit.org/show_bug.cgi?id=51320 * http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpoint): (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource): * inspector/debugger-pause-on-breakpoint-expected.txt: * inspector/debugger-pause-on-breakpoint.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
Reviewed by Dave Hyatt. https://bugs.webkit.org/show_bug.cgi?id=52370 <rdar://problem/8856808> Style sharing optimization no longer works on major web sites The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page. This patch gets the style sharing back to 25-40% range on most web sites. * css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::propertiesEqual): Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent. * css/CSSSelector.h: (WebCore::CSSSelector::isSiblingSelector): Test for selectors that are affected by the sibling elements. * css/CSSStyleSelector.cpp: (WebCore::elementCanUseSimpleDefaultStyle): (WebCore::collectSiblingRulesInDefaultStyle): (WebCore::assertNoSiblingRulesInDefaultStyle): Extract sibling rules from the MathML default stylesheet. Assert that no other default stylesheet has them. (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::matchesSiblingRules): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::styleForElement): (WebCore::collectIdsAndSiblingRulesFromList): (WebCore::CSSRuleSet::collectIdsAndSiblingRules): Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases where style sharing can't be used. * css/CSSStyleSelector.h: * dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::mappedMapsEquivalent): Check also for CSSValue mutation from DOM. * mathml/MathMLMathElement.cpp: (WebCore::MathMLMathElement::insertedIntoDocument): * mathml/MathMLMathElement.h: MathML default style sheet has sibling rules which don't get noticed by the normal document stylesheet parsing. * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setFirstChildState): (WebCore::InheritedFlags::setLastChildState): (WebCore::InheritedFlags::setChildIndex): These all make style non-shareable (unique). LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52370 Style sharing optimization no longer works on major web sites Reviewed by Dave Hyatt. These are progressions (with no noticable visual change). MathML code was improperly sharing style. * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt: * platform/mac/mathml/presentation/subsup-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Unreviewed, rolling out r76002. http://trac.webkit.org/changeset/76002 https://bugs.webkit.org/show_bug.cgi?id=49790 breaks a bunch of fast/forms tests on mac and GTK * fast/forms/select-option-background-color-change.html: Removed. * fast/forms/select-option-color-change.html: Removed. * fast/forms/select-option-visibility-change.html: Removed. * platform/mac/fast/forms/select-option-background-color-change-expected.checksum: Removed. * platform/mac/fast/forms/select-option-background-color-change-expected.png: Removed. * platform/mac/fast/forms/select-option-background-color-change-expected.txt: Removed. * platform/mac/fast/forms/select-option-color-change-expected.checksum: Removed. * platform/mac/fast/forms/select-option-color-change-expected.png: Removed. * platform/mac/fast/forms/select-option-color-change-expected.txt: Removed. * platform/mac/fast/forms/select-option-visibility-change-expected.checksum: Removed. * platform/mac/fast/forms/select-option-visibility-change-expected.png: Removed. * platform/mac/fast/forms/select-option-visibility-change-expected.txt: Removed. 2011-01-18 Philippe Normand <pnormand@igalia.com> Unreviewed, rolling out r76002. http://trac.webkit.org/changeset/76002 https://bugs.webkit.org/show_bug.cgi?id=49790 breaks a bunch of fast/forms tests on mac and GTK * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
[Qt] Fix LoadHTMLStringItem::invoke() after r75966 https://bugs.webkit.org/show_bug.cgi?id=52614 * platform/qt/Skipped: http/tests/navigation/go-back-to-error-page.html added until fix. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis@webkit.org authored
Reviewed by Kent Tamura. Color changes to option elements in a select multiple aren't drawn immediately https://bugs.webkit.org/show_bug.cgi?id=49790 Redirect style changes on <option> element to the owner <select> element. Tests: fast/forms/select-option-background-color-change.html fast/forms/select-option-color-change.html fast/forms/select-option-visibility-change.html * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 17 Jan, 2011 5 commits
-
-
commit-queue@webkit.org authored
Reviewed by David Levin. Rebaseline media/video-zoom-controls for chromium. https://bugs.webkit.org/show_bug.cgi?id=52415 * platform/chromium-linux/media/video-zoom-controls-expected.checksum: Added. * platform/chromium-linux/media/video-zoom-controls-expected.png: Added. * platform/chromium-mac/media/video-zoom-controls-expected.checksum: Added. * platform/chromium-mac/media/video-zoom-controls-expected.png: Added. * platform/chromium-mac/media/video-zoom-controls-expected.txt: Added. * platform/chromium-win/media/video-zoom-controls-expected.checksum: Added. * platform/chromium-win/media/video-zoom-controls-expected.png: Added. * platform/chromium-win/media/video-zoom-controls-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dimich@chromium.org authored
Added TIMEOUT to fast/canvas/canvas-fillPath-pattern-shadow.html * platform/chromium-gpu/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
msaboff@apple.com authored
Reviewed by Oliver Hunt. [regexfuzz] Crash running regex with lookahead https://bugs.webkit.org/show_bug.cgi?id=52548 Eliminated agressive chaining of backtracks. This code was overwriting already valid backtrack information. * yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks): 2011-01-17 Michael Saboff <msaboff@apple.com> Reviewed by Oliver Hunt. [regexfuzz] Crash running regex with lookahead https://bugs.webkit.org/show_bug.cgi?id=52548 New tests from regex fuzzer. * fast/regex/parentheses-expected.txt: * fast/regex/script-tests/parentheses.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dimich@chromium.org authored
Same as previous patch, now for -gpu file. * platform/chromium-gpu/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dimich@chromium.org authored
fast/canvas/canvas-fillPath-pattern-shadow.html fails on Win and Linux. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-