1. 18 Jan, 2011 40 commits
    • mjs@apple.com's avatar
      Not reviewed. · 1e83c546
      mjs@apple.com authored
      Revert inadvertantly committed test changes.
      
      * editing/pasteboard/copy-null-characters.html:
      * fast/events/scroll-event-does-not-bubble.html:
      * platform/mac-wk2/Skipped:
      * transitions/remove-transition-style.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e83c546
    • kbr@google.com's avatar
      2011-01-18 Kenneth Russell <kbr@google.com> · b6e8e5f0
      kbr@google.com authored
              Unreviewed, release build fix. Explicitly cast away const.
      
              * src/compiler/preprocessor/scanner.c:
              (ScanFromString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6e8e5f0
    • mjs@apple.com's avatar
      2011-01-18 Maciej Stachowiak <mjs@apple.com> · 54741f66
      mjs@apple.com authored
              Reviewed by Sam Weinig.
      
              WebKitTestRunner should track loading more like DumpRenderTree
              https://bugs.webkit.org/show_bug.cgi?id=52692
      
              Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
              This makes some tests that call notifyDone multiple times pass.
              
              * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
              (WTR::InjectedBundle::InjectedBundle):
              (WTR::InjectedBundle::done):
              * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
              (WTR::InjectedBundle::topLoadingFrame):
              (WTR::InjectedBundle::setTopLoadingFrame):
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::InjectedBundlePage::InjectedBundlePage):
              (WTR::InjectedBundlePage::stopLoading):
              (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
              (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
              (WTR::InjectedBundlePage::didFinishLoadForFrame):
              (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::notifyDone):
              * WebKitTestRunner/TestController.cpp:
              (WTR::TestController::didReceiveMessageFromInjectedBundle):
      2011-01-18  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKitTestRunner should track loading more like DumpRenderTree
              https://bugs.webkit.org/show_bug.cgi?id=52692
              
              Relax the message check in didSaveFrameToPageCache a bit more, since
              layout tests were still hitting the old one.
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::isDisconnectedFrame):
              (WebKit::WebPageProxy::didSaveFrameToPageCache):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54741f66
    • kbr@google.com's avatar
      2011-01-18 Ben Vanik <ben.vanik@gmail.com> · 4ab3da0f
      kbr@google.com authored
              Reviewed by Kenneth Russell.
      
              Updating ANGLE in WebKit to r533.
              https://bugs.webkit.org/show_bug.cgi?id=47194
      
              * platform/graphics/ANGLEWebKitBridge.cpp:
              (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
              (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge):
              (WebCore::ANGLEWebKitBridge::validateShaderSource):
              Update to new ANGLE API for shader validation.
              * platform/graphics/ANGLEWebKitBridge.h:
              (WebCore::ANGLEWebKitBridge::setResources): 
              Renaming types to new names.
              * platform/graphics/mac/GraphicsContext3DMac.mm:
              (WebCore::GraphicsContext3D::GraphicsContext3D):
              Initialize ANGLEResources with ANGLE init call to prevent uninitialized variables.
      2011-01-18  Ben Vanik  <ben.vanik@gmail.com>
      
              Reviewed by Kenneth Russell.
      
              Updating ANGLE in WebKit to r533.
              https://bugs.webkit.org/show_bug.cgi?id=47194
      
              * ANGLE.xcodeproj/project....
      4ab3da0f
    • oliver@apple.com's avatar
      2011-01-18 Oliver Hunt <oliver@apple.com> · 6b5d98b0
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              [jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
              https://bugs.webkit.org/show_bug.cgi?id=52690
      
              Add a few more tests.
      
              * fast/js/function-dot-arguments-expected.txt:
              * fast/js/script-tests/function-dot-arguments.js:
              (overwroteArgumentsInDynamicScope1):
              (overwroteArgumentsInDynamicScope2):
              (overwroteArgumentsInDynamicScope3):
      2011-01-18  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Gavin Barraclough.
      
              [jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
              https://bugs.webkit.org/show_bug.cgi?id=52690
      
              Clean up code to retrieve arguments from activation and function objects.
              Remove the incorrect assertion from JSActivation's argumentsGetter.
      
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::retrieveArguments):
              * runtime/JSActivation.cpp:
              (JSC::JSActivation::argumentsGetter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b5d98b0
    • beidson@apple.com's avatar
      <rdar://problem/8860833> and https://bugs.webkit.org/show_bug.cgi?id=52599 · 0e7ea9b0
      beidson@apple.com authored
      UIProcess crash in WebPageProxy::reattachToWebProcess when web process crashes with a new tab/window.
      
      Reviewed by Darin Adler.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::reattachToWebProcessWithItem): Null check item *both* places it is used.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e7ea9b0
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, adding pixel expectations for new test. · 713a1141
      dimich@chromium.org authored
      * platform/chromium-mac/fast/css/background-clip-values-expected.checksum: Added.
      * platform/chromium-mac/fast/css/background-clip-values-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      713a1141
    • beidson@apple.com's avatar
      <rdar://problem/8752200> and https://bugs.webkit.org/show_bug.cgi?id=52664 · 53329382
      beidson@apple.com authored
      Need WebKit2 API to asynchronously get the resource data for a URL
      
      Reviewed by Maciej Stachowiak. 
      
      Rename WKFrameGetMainResourceDataFunction to WKFrameGetResourceDataFunction, and add
      new API to get a resource by URL:
      * UIProcess/API/C/WKFrame.cpp:
      (WKFrameGetMainResourceData):
      (WKFrameGetResourceData):
      (callGetResourceDataBlockAndDispose):
      (WKFrameGetMainResourceData_b):
      (WKFrameGetResourceData_b):
      * UIProcess/API/C/WKFrame.h:
      
      Implement the new API in the UIProcess side:
      * UIProcess/WebFrameProxy.cpp:
      (WebKit::WebFrameProxy::getResourceData):
      * UIProcess/WebFrameProxy.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::getResourceDataFromFrame):
      * UIProcess/WebPageProxy.h:
      
      Have the WebProcess get the data and call back to the UIProcess:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::getResourceDataFromFrame):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53329382
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · 7e17fdb5
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              Make PageClientImpl::scrollView do hardware blitting
              https://bugs.webkit.org/show_bug.cgi?id=52689
      
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::scrollView):
              Clip the scroll rect and scroll the view.
      
              * UIProcess/DrawingAreaProxyImpl.cpp:
              (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
              Scroll before painting.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e17fdb5
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · 267e9fd7
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              Artifacts when scrolling with new drawing area
              https://bugs.webkit.org/show_bug.cgi?id=52682
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::scroll):
              When scrolling, we want the intersection of the scroll rect and clip rect.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      267e9fd7
    • jberlin@webkit.org's avatar
      Add a test that calling window.open with an empty URL does not trigger an assertion or · aabd7ed1
      jberlin@webkit.org authored
      cause a crash.
      https://bugs.webkit.org/show_bug.cgi?id=52654
      
      Reviewed by Adam Roben.
      
      * fast/dom/Window/open-window-empty-url-expected.txt: Added.
      * fast/dom/Window/open-window-empty-url.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aabd7ed1
    • morrita@google.com's avatar
      2011-01-18 MORITA Hajime <morrita@google.com> · e90fa1a9
      morrita@google.com authored
              Reviewed by Simon Fraser.
      
              Refactoring: Extract RoundedIntRect class
              https://bugs.webkit.org/show_bug.cgi?id=51664
      
              RoundedIntRect is a pair of rect and four IntSize objects which represent
              corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
              Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
              return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
              and other functions accept RoundedIntRect as an argument.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::addRoundedRectClip):
              (WebCore::GraphicsContext::clipOutRoundedRect):
              (WebCore::GraphicsContext::fillRoundedRect):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/RoundedIntRect.cpp: Added.
              (WebCore::RoundedIntRect::Radii::isZero):
              (WebCore::RoundedIntRect::Radii::scale):
              (WebCore::RoundedIntRect::Radii::expand):
              (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
              (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
              (WebCore::RoundedIntRect::RoundedIntRect):
              (WebCore::RoundedIntRect::includeLogicalEdges):
              (WebCore::RoundedIntRect::excludeLogicalEdges):
              * platform/graphics/RoundedIntRect.h: Added.
              (WebCore::RoundedIntRect::Radii::Radii):
              (WebCore::RoundedIntRect::Radii::setTopLeft):
              (WebCore::RoundedIntRect::Radii::setTopRight):
              (WebCore::RoundedIntRect::Radii::setBottomLeft):
              (WebCore::RoundedIntRect::Radii::setBottomRight):
              (WebCore::RoundedIntRect::Radii::topLeft):
              (WebCore::RoundedIntRect::Radii::topRight):
              (WebCore::RoundedIntRect::Radii::bottomLeft):
              (WebCore::RoundedIntRect::Radii::bottomRight):
              (WebCore::RoundedIntRect::Radii::expand):
              (WebCore::RoundedIntRect::Radii::shrink):
              (WebCore::RoundedIntRect::rect):
              (WebCore::RoundedIntRect::radii):
              (WebCore::RoundedIntRect::isRounded):
              (WebCore::RoundedIntRect::isEmpty):
              (WebCore::RoundedIntRect::setRect):
              (WebCore::RoundedIntRect::setRadii):
              (WebCore::RoundedIntRect::move):
              (WebCore::RoundedIntRect::inflate):
              (WebCore::RoundedIntRect::inflateWithRadii):
              (WebCore::RoundedIntRect::expandRadii):
              (WebCore::RoundedIntRect::shrinkRadii):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::pushContentsClip):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              (WebCore::RenderBoxModelObject::paintBorder):
              (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
              (WebCore::RenderBoxModelObject::paintBoxShadow):
              * rendering/RenderBoxModelObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::drawBoxSideFromPath):
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintMenuListButtonGradients):
              (WebCore::RenderThemeMac::paintSliderTrack):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
              (WebCore::RenderThemeSafari::paintSliderTrack):
              * rendering/RenderThemeWinCE.cpp:
              (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::paint):
              * rendering/style/BorderData.h:
              * rendering/style/RenderStyle.cpp:
              (WebCore::calcRadiiFor):
              (WebCore::calcConstraintScaleFor):
              (WebCore::RenderStyle::getRoundedBorderFor):
              (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::setBorderRadius):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e90fa1a9
    • ojan@chromium.org's avatar
      2011-01-18 Ojan Vafai <ojan@chromium.org> · c215f92c
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              make file expansion use the file at the svn revision the diff was created at
              https://bugs.webkit.org/show_bug.cgi?id=52650
      
              This only works for patches created with SVN for now since the git
              diff does not include SVN revision numbers in it.
      
              * PrettyPatch/PrettyPatch.rb:
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c215f92c
    • mihaip@chromium.org's avatar
      2011-01-18 Mihai Parparita <mihaip@chromium.org> · bd3302dc
      mihaip@chromium.org authored
              Reviewed by Kent Tamura.
      
              [Chromium] NRWT looking for DRT binary in the wrong path on Mac
              https://bugs.webkit.org/show_bug.cgi?id=52678
      
              Update path now that WebKit is inside Source.
      
              * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd3302dc
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · 9c57db95
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              Use a CGLayer for the backing store when possible
              https://bugs.webkit.org/show_bug.cgi?id=52679
      
              * UIProcess/mac/BackingStoreMac.mm:
              (WebKit::BackingStore::paint):
              If there is a layer, paint it into the given context.
      
              (WebKit::BackingStore::backingStoreContext):
              If we can get the containing window graphics context, use it to create a 
              CGLayer that we'll use for the backing store.
      
              (WebKit::BackingStore::scroll):
              Paint the layer into itself.
      
              * UIProcess/mac/WebPageProxyMac.mm:
              (WebKit::WebPageProxy::containingWindowGraphicsContext):
              Call the page client.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c57db95
    • robert@webkit.org's avatar
      2011-01-18 Robert Hogan <robert@webkit.org> · 584609ca
      robert@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] http/tests/incremental/slow-utf8-text.pl fails
              https://bugs.webkit.org/show_bug.cgi?id=44282
      
              * platform/qt/Skipped:
      2011-01-18  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Simon Hausmann.
      
              [Qt] http/tests/incremental/slow-utf8-text.pl fails
              https://bugs.webkit.org/show_bug.cgi?id=44282
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::responseMimeType):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-01-18  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Simon Hausmann.
      
              [Qt] http/tests/incremental/slow-utf8-text.pl fails
              https://bugs.webkit.org/show_bug.cgi?id=44282
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::dump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      584609ca
    • ggaren@apple.com's avatar
      2011-01-18 Geoffrey Garen <ggaren@apple.com> · f0eac6ef
      ggaren@apple.com authored
              Reviewed by Darin Adler.
      
              Removed RegisterFile::markGlobals because it was obtuse, and it
              unnecessarily relied on conservative marking.
              https://bugs.webkit.org/show_bug.cgi?id=52668
      
              * interpreter/RegisterFile.h: Removed markGlobals.
      
              * runtime/JSActivation.cpp:
              (JSC::JSActivation::markChildren): Added a comment explaning why some
              JSActivations don't always mark their registers arrays.
      
              * runtime/JSGlobalObject.cpp:
              (JSC::JSGlobalObject::markChildren): Instead of calling markGlobals, mark
              the registers array directly.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0eac6ef
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · 6b22b706
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              Pass the web page proxy to BackingStore::create
              https://bugs.webkit.org/show_bug.cgi?id=52673
      
              * UIProcess/BackingStore.cpp:
              (WebKit::BackingStore::create):
              Add WebPageProxy parameter.
          
              (WebKit::BackingStore::BackingStore):
              Add WebPageProxy parameter.
      
              * UIProcess/BackingStore.h:
              Add WebPageProxy member variable.
      
              * UIProcess/DrawingAreaProxyImpl.cpp:
              (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
              Pass the web page proxy when creating the backing store.
      
              * UIProcess/mac/BackingStoreMac.mm:
              (WebKit::BackingStore::backingStoreContext):
              Set the default blend mode.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b22b706
    • msaboff@apple.com's avatar
      2011-01-18 Michael Saboff <msaboff@apple.com> · 69e68d35
      msaboff@apple.com authored
              Reviewed by Oliver Hunt.
      
              <rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
              https://bugs.webkit.org/show_bug.cgi?id=52540
              https://bugs.webkit.org/show_bug.cgi?id=52662
      
              Directly use backtrack label with parentheses nested under a
              non-capturing parentheses.  Also linked current parentheses
              tail code object for possible parens nested within a non-capturing
              parentheses.
      
              * yarr/YarrJIT.cpp:
              (JSC::Yarr::YarrGenerator::BacktrackDestination::linkBacktrackToLabel):
              (JSC::Yarr::YarrGenerator::generateParenthesesSingle):
      2011-01-18  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
              https://bugs.webkit.org/show_bug.cgi?id=52540
              https://bugs.webkit.org/show_bug.cgi?id=52662
      
              New tests to check for proper linking of parentheses nested under
              a non-capturing parentheses.
      
              * fast/regex/parentheses-expected.txt:
              * fast/regex/script-tests/parentheses.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69e68d35
    • commit-queue@webkit.org's avatar
      2011-01-18 Victoria Kirst <vrk@chromium.org> · 684ea185
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              [chromium] Adding support for YV16 video frame formats.
              https://bugs.webkit.org/show_bug.cgi?id=52345
      
              * platform/graphics/chromium/VideoLayerChromium.cpp:
              (WebCore::VideoLayerChromium::determineTextureFormat):
              (WebCore::VideoLayerChromium::draw):
      2011-01-18  Victoria Kirst  <vrk@chromium.org>
      
              Reviewed by Kenneth Russell.
      
              [chromium] Adding support for YV16 video frame formats.
              https://bugs.webkit.org/show_bug.cgi?id=52345
      
              * src/VideoFrameChromiumImpl.cpp:
              (WebKit::VideoFrameChromiumImpl::requiredTextureSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      684ea185
    • hyatt@apple.com's avatar
      <rdar://problem/8479998> REGRESSION (r67660): broken button layout at devforums.apple.com · 6f7d9fb7
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      Exclude floating objects from shrinking to avoid floats.  They should never do this.  Timing-related bugs could
      occur as a result of this mistake, and the change to rewrite pagination to defer layout of floats until they
      got encountered on the correct line exposed this issue.
      
      Source/WebCore: 
      
      Added /fast/block/float/float-overflow-hidden-containing-block-width.html.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::shrinkToAvoidFloats):
      
      LayoutTests: 
      
      Added /fast/block/float/float-overflow-hidden-containing-block-width.html.
      * fast/block/float/float-overflow-hidden-containing-block-width.html: Added.
      * platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.checksum: Added.
      * platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.png: Added.
      * platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f7d9fb7
    • dpranke@chromium.org's avatar
      2011-01-18 Dirk Pranke <dpranke@chromium.org> · 3fd9a593
      dpranke@chromium.org authored
              Reviewed by Mihai Parparita.
      
              Fix a small race condition that could cause the unit tests for
              new-run-webkit-tests to fail in a multithreaded environment.
              There was a small window in the code where one thread would
              check to see if a thread had raised an exception, do something,
              and then check to see if the thread was alive. If the other
              thread raised an exception and exited in between these two
              steps, the exception would be lost. Flipping the order of the
              two checks fixes the race, since we will now always check for an
              exception on the thread before exiting.
      
              https://bugs.webkit.org/show_bug.cgi?id=51579
      
              * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fd9a593
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · 7bb3de43
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              Factor code to create the backing store bitmap context out into a new function
              https://bugs.webkit.org/show_bug.cgi?id=52670
      
              * UIProcess/BackingStore.h:
              * UIProcess/mac/BackingStoreMac.mm:
              (WebKit::BackingStore::backingStoreContext):
              Create the backing store context.
      
              (WebKit::BackingStore::incorporateUpdate):
              Call backingStoreContext.
      
              (WebKit::BackingStore::scroll):
              Assert that the context is not null.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bb3de43
    • eric@webkit.org's avatar
      2011-01-18 Eric Seidel <eric@webkit.org> · 4a699377
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              commit-queue dies when test archiving fails
              https://bugs.webkit.org/show_bug.cgi?id=52617
      
              I looked at the machine and it had 10 archives already
              thus find_unused_name was returning None.  I've upped
              the limit to 100 (per bug) and tested the case where
              find_unused_name returns None (making archive return None).
      
              * Scripts/webkitpy/common/system/workspace.py:
              * Scripts/webkitpy/common/system/workspace_unittest.py:
              * Scripts/webkitpy/tool/bot/commitqueuetask.py:
              * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
              * Scripts/webkitpy/tool/commands/queues.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a699377
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, updated expectations for tests · 4668a0de
      dimich@chromium.org authored
      affected by http://trac.webkit.org/changeset/76047
      
      * platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
      * platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
      * platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
      * platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
      * platform/chromium-win/fast/css/background-clip-values-expected.checksum: Added.
      * platform/chromium-win/fast/css/background-clip-values-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4668a0de
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · 5ad5e706
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              Add PageClientImpl::containingWindowGraphicsContext
              https://bugs.webkit.org/show_bug.cgi?id=52666
      
              * UIProcess/API/mac/PageClientImpl.h:
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::containingWindowGraphicsContext):
              * UIProcess/PageClient.h:
              * UIProcess/WebPageProxy.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ad5e706
    • dbates@webkit.org's avatar
      2011-01-18 Daniel Bates <dbates@rim.com> · 7e7c1874
      dbates@webkit.org authored
              Reviewed by Gavin Barraclough.
      
              Only use moving memory model assumption in ExecutableAllocator::intializePageSize() for Symbian OS
              https://bugs.webkit.org/show_bug.cgi?id=52517
      
              Patch by David Tapuska
      
              Currently, we compile code with respect to the Symbian-specific moving memory model
              assumption for all ARMv5 or lower architectures. Instead, we should only compile
              such code when building for Symbian OS on those architectures because this model
              is Symbian-specific.
      
              * jit/ExecutableAllocator.cpp:
              (JSC::ExecutableAllocator::intializePageSize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e7c1874
    • zmo@google.com's avatar
      2011-01-18 Zhenyao Mo <zmo@google.com> · 49a67de1
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              Make CheckedInt<long> and CheckedInt<unsigned long> work
              https://bugs.webkit.org/show_bug.cgi?id=52401
      
              * html/canvas/CheckedInt.h:
              (WebCore::CheckedInt::CheckedInt): Merge with the patch provided by Benoit Jacob.
              * html/canvas/WebGLBuffer.cpp:
              (WebCore::WebGLBuffer::associateBufferDataImpl): Use CheckedInt<long> instead of CheckedInt<int>.
              (WebCore::WebGLBuffer::associateBufferSubDataImpl): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49a67de1
    • commit-queue@webkit.org's avatar
      2011-01-18 Damian Kaleta <dkaleta@apple.com> · bcd26791
      commit-queue@webkit.org authored
              Reviewed by Sam Weinig.
      
              WK2 methods WKPageScaleWebView and WKPageGetViewScaleFactor need to have consistent names
              https://bugs.webkit.org/show_bug.cgi?id=52647
      
              * UIProcess/API/C/WKPage.cpp:
              (WKPageSetScaleFactor):
              (WKPageGetScaleFactor):
              * UIProcess/API/C/WKPage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcd26791
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · 987ad2e1
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              Ask the web page proxy to scroll the view when needed
              https://bugs.webkit.org/show_bug.cgi?id=52665
      
              * UIProcess/DrawingAreaProxyImpl.cpp:
              (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::scrollView):
              * UIProcess/WebPageProxy.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      987ad2e1
    • andersca@apple.com's avatar
      Fix build. · b17b6a77
      andersca@apple.com authored
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::scrollView):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b17b6a77
    • kbr@google.com's avatar
      2011-01-18 Kenneth Russell <kbr@google.com> · 592c4269
      kbr@google.com authored
              Reviewed by David Levin.
      
              Must strip comments from WebGL shaders before enforcing character set
              https://bugs.webkit.org/show_bug.cgi?id=52390
      
              Strip comments from incoming shaders, preserving line numbers,
              before validating that they conform to the ESSL character set.
              Revert changes from http://trac.webkit.org/changeset/75735 which
              allowed invalid characters to be passed to certain APIs.
      
              Tested with WebGL layout tests, conformance test suite and several
              WebGL demos in both Safari and Chromium.
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::StripComments::StripComments::process):
              (WebCore::WebGLRenderingContext::shaderSource):
      2011-01-18  Kenneth Russell  <kbr@google.com>
      
              Reviewed by David Levin.
      
              Must strip comments from WebGL shaders before enforcing character set
              https://bugs.webkit.org/show_bug.cgi?id=52390
      
              Incorporated non-ASCII GLSL conformance tests from Khronos
              repository. Updated and synchronized invalid-passed-params.html
              with Khronos repository, undoing changes from
              http://trac.webkit.org/changeset/75735 .
      
              * fast/canvas/webgl/glsl-conformance-expected.txt:
              * fast/canvas/webgl/invalid-passed-params-expected.txt:
              * fast/canvas/webgl/invalid-passed-params.html:
              * fast/canvas/webgl/shaders/00_shaders.txt:
              * fast/canvas/webgl/shaders/misc: Added.
              * fast/canvas/webgl/shaders/misc/00_shaders.txt: Added.
              * fast/canvas/webgl/shaders/misc/non-ascii-comments.vert: Added.
              * fast/canvas/webgl/shaders/misc/non-ascii.vert: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      592c4269
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · c5050644
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Add PageClient::scrollView
              https://bugs.webkit.org/show_bug.cgi?id=52663
      
              * UIProcess/API/mac/PageClientImpl.h:
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::scrollView):
              * UIProcess/API/qt/qwkpage.cpp:
              (QWKPagePrivate::scrollView):
              * UIProcess/API/qt/qwkpage_p.h:
              * UIProcess/PageClient.h:
              * UIProcess/win/WebView.cpp:
              (WebKit::PageClientImpl::scrollView):
              * UIProcess/win/WebView.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5050644
    • andersca@apple.com's avatar
      Rename scrollDelta to scrollOffset everywhere. · 3ca0a74d
      andersca@apple.com authored
      Reviewed by Sam Weinig.
      
      * Shared/UpdateInfo.cpp:
      (WebKit::UpdateInfo::encode):
      (WebKit::UpdateInfo::decode):
      * Shared/UpdateInfo.h:
      * UIProcess/BackingStore.h:
      * UIProcess/mac/BackingStoreMac.mm:
      (WebKit::BackingStore::incorporateUpdate):
      (WebKit::BackingStore::scroll):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::scroll):
      (WebKit::WebChromeClient::delegatedScrollRequested):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
      (WebKit::ChunkedUpdateDrawingArea::scroll):
      * WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
      * WebProcess/WebPage/DrawingArea.h:
      * WebProcess/WebPage/DrawingAreaImpl.cpp:
      (WebKit::DrawingAreaImpl::scroll):
      (WebKit::DrawingAreaImpl::display):
      * WebProcess/WebPage/DrawingAreaImpl.h:
      * WebProcess/WebPage/LayerBackedDrawingArea.cpp:
      (WebKit::LayerBackedDrawingArea::scroll):
      * WebProcess/WebPage/LayerBackedDrawingArea.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ca0a74d
    • commit-queue@webkit.org's avatar
      2011-01-18 Dimitry Andric <dim@freebsd.org> · bbe606b0
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              Fix linking JavaScriptCore on FreeBSD/amd64
              https://bugs.webkit.org/show_bug.cgi?id=52591
      
              Linking of JavaScriptCore on FreeBSD/amd64 fails, for the same reason as
              in bug 28422: cti_vm_throw needs a "@plt" suffix, otherwise the linker
              complains about the relocation type.
      
              * jit/JITStubs.cpp: use @plt suffix on x86_64 platforms, for both Linux
              and FreeBSD.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbe606b0
    • dpranke@chromium.org's avatar
      2011-01-18 Dirk Pranke <dpranke@chromium.org> · e6034d22
      dpranke@chromium.org authored
              Reviewed by Ojan Vafai.
      
              Update rebaseline-chromium-webkit-tests unit tests to use a mock
              filesystem. Also fix a couple of "with" statements missed by
              r76050.
      
              https://bugs.webkit.org/show_bug.cgi?id=52487
      
              * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6034d22
    • cmarrin@apple.com's avatar
      2011-01-18 Chris Marrin <cmarrin@apple.com> · c1e6b6bb
      cmarrin@apple.com authored
              Reviewed by Simon Fraser.
      
              Add LayoutTests for new compositing layer logic
              https://bugs.webkit.org/show_bug.cgi?id=52657
      
              Add 4 tests checking that the layer tree is properly constructed with nested
              layers. The first test is a simple static test of a layer with a 3D transform
              with a non-layered parent. It is a pixel test and is just looking for a correct
              image. The second test is similar but has a 4 deep hierarchy of <div> element where 
              only the innermost layer has a 3D transform. It is also a pixel test.
              The other 2 tests are the same except that they add and then remove the innermost
              layer's transform. It makes sure the layer tree is correct before and after
              these changes.
      
              * compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
              * compositing/geometry/layer-due-to-layer-children-deep-switch.html: Added.
              * compositing/geometry/layer-due-to-layer-children-deep.html: Added.
              * compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
              * compositing/geometry/layer-due-to-layer-children-switch.html: Added.
              * compositing/geometry/layer-due-to-layer-children.html: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
              * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1e6b6bb
    • rniwa@webkit.org's avatar
      2011-01-18 Ryosuke Niwa <rniwa@webkit.org> · 186f5bb6
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Stop instantiating legacy editing positions in DeleteSelectionCommand, IndentOudentCommand,
              InsertLineBreakCommand, InsertListCOmmand.cpp, InsertParagraphSeparatorCommand, and htmlediting.cpp
              https://bugs.webkit.org/show_bug.cgi?id=52644
      
              This is a cleanup to stop instantiating legacy editing positions in the following tests.
              firstDeepEditingPositionForNode and lastDeepEditingPositionForNode in htmlediting.h are not updated
              because doing so requires significant code changes. They are tracked on the bug 52642.
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd):
              (WebCore::updatePositionForNodeRemoval):
              (WebCore::DeleteSelectionCommand::removeNode):
              (WebCore::updatePositionForTextRemoval):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::outdentParagraph):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApplyForSingleParagraph):
              (WebCore::InsertListCommand::unlistifyParagraph):
              (WebCore::InsertListCommand::listifyParagraph):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/htmlediting.cpp:
              (WebCore::enclosingBlock):
              (WebCore::enclosingList):
              (WebCore::enclosingListChild):
              (WebCore::indexForVisiblePosition):
              (WebCore::isNodeVisiblyContainedWithin):
              (WebCore::avoidIntersectionWithNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      186f5bb6
    • mihaip@chromium.org's avatar
      2011-01-18 Mihai Parparita <mihaip@chromium.org> · 019aefe5
      mihaip@chromium.org authored
              Reviewed by Ojan Vafai.
      
              [Chromium] Update Sputnik test expectations
              https://bugs.webkit.org/show_bug.cgi?id=52656
      
              Mark Sputnik tests as WONTFIX, so that they don't artificially inflate
              our failing test count.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      019aefe5
    • sergio@webkit.org's avatar
      2011-01-18 Sergio Villar Senin <svillar@igalia.com> · a4150dd6
      sergio@webkit.org authored
              Reviewed by Martin Robinson.
      
              [Gtk] Build fixes for gtk3 build
              https://bugs.webkit.org/show_bug.cgi?id=52648
      
              * DumpRenderTree/gtk/EventSender.cpp:
              (beginDragWithFilesCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4150dd6