1. 06 Dec, 2013 37 commits
    • jer.noble@apple.com's avatar
      [MSE][Mac] Add a new MSE-compatible MediaPlayerPrivate implementation,... · 1dfc3a43
      jer.noble@apple.com authored
      [MSE][Mac] Add a new MSE-compatible MediaPlayerPrivate implementation, MediaPlayerPrivateMediaSourceAVFObjC
      https://bugs.webkit.org/show_bug.cgi?id=123378
      
      Reviewed by Eric Carlson.
      
      Add an AVFoundation implementation of MediaPlayerPrivate which creates and uses
      MediaSourcePrivate and SourceBufferPrivate subclasses.
      
      Add the new media engine to the list of installed engines:
      * platform/MediaSample.h:
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::installedMediaEngines):
      * platform/graphics/MediaPlayer.h:
      
      Add the new files to the project:
      * WebCore.xcodeproj/project.pbxproj:
      
      Drive by fix for ports who implement seekDouble():
      * platform/graphics/MediaPlayerPrivate.h:
      (WebCore::MediaPlayerPrivateInterface::seekWithTolerance):
      
      Add new Video and AudioTrackPrivate types which handle their own enable state:
      * platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.cpp: Added
      (WebCore::AudioTrackPrivateMediaSourceAVFObjC::AudioTrackPrivateMediaSourceAVFObjC):
      (WebCore::AudioTrackPrivateMediaSourceAVFObjC::resetPropertiesFromTrack):
      (WebCore::AudioTrackPrivateMediaSourceAVFObjC::setAssetTrack):
      (WebCore::AudioTrackPrivateMediaSourceAVFObjC::assetTrack):
      (WebCore::AudioTrackPrivateMediaSourceAVFObjC::setEnabled):
      * platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h: Added
      * platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.cpp: Added.
      (WebCore::VideoTrackPrivateMediaSourceAVFObjC::VideoTrackPrivateMediaSourceAVFObjC):
      (WebCore::VideoTrackPrivateMediaSourceAVFObjC::resetPropertiesFromTrack):
      (WebCore::VideoTrackPrivateMediaSourceAVFObjC::setAssetTrack):
      (WebCore::VideoTrackPrivateMediaSourceAVFObjC::assetTrack):
      (WebCore::VideoTrackPrivateMediaSourceAVFObjC::setSelected):
      * platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h: Added.
      
      Add a new MediaPlayerPrivate which can handle MediaSource objects:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: Added.
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: Added.
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::~MediaPlayerPrivateMediaSourceAVFObjC):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::create):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable):
      (WebCore::mimeTypeCache):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::getSupportedTypes):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cancelLoad):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::prepareToPlay):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::platformMedia):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::platformLayer):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::play):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pause):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pauseInternal):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paused):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsScanning):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::naturalSize):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasVideo):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasAudio):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVisible):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationDouble):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::startTimeDouble):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::initialTime):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seeking):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setRateDouble):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::networkState):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::readyState):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekable):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::maxTimeSeekableDouble):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::minTimeSeekable):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::didLoadingProgress):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setSize):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paint):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paintCurrentFrameInContext):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasAvailableVideoFrame):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsAcceleratedRendering):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::acceleratedRenderingStateChanged):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::movieLoadType):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::prepareForRendering):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::engineDescription):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::languageOfPrimaryAudioTrack):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::extraMemoryCost):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::destroyLayer):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateDuration):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateStates):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setReadyState):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setNetworkState):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer):
      (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeDisplayLayer):
      
      Add a new MediaSourcePrivate implementation:
      * platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h: Added.
      (WebCore::MediaSourcePrivateAVFObjC::player):
      (WebCore::MediaSourcePrivateAVFObjC::activeSourceBuffers):
      * platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm: Added.
      (WebCore::MediaSourcePrivateAVFObjC::create):
      (WebCore::MediaSourcePrivateAVFObjC::MediaSourcePrivateAVFObjC):
      (WebCore::MediaSourcePrivateAVFObjC::~MediaSourcePrivateAVFObjC):
      (WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer):
      (WebCore::MediaSourcePrivateAVFObjC::removeSourceBuffer):
      (WebCore::MediaSourcePrivateAVFObjC::duration):
      (WebCore::MediaSourcePrivateAVFObjC::setDuration):
      (WebCore::MediaSourcePrivateAVFObjC::markEndOfStream):
      (WebCore::MediaSourcePrivateAVFObjC::unmarkEndOfStream):
      (WebCore::MediaSourcePrivateAVFObjC::readyState):
      (WebCore::MediaSourcePrivateAVFObjC::setReadyState):
      (WebCore::MediaSourcePrivateAVFObjC::sourceBufferPrivateDidChangeActiveState):
      (WebCore::MediaSourcePrivateAVFObjCHasAudio):
      (WebCore::MediaSourcePrivateAVFObjC::hasAudio):
      (WebCore::MediaSourcePrivateAVFObjCHasVideo):
      (WebCore::MediaSourcePrivateAVFObjC::hasVideo):
      (WebCore::MediaSourcePrivateAVFObjC::seekToTime):
      
      Add a new SourceBufferPrivate implementation:
      * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: Added.
      * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: Added.
      (-[WebAVStreamDataParserListener initWithParser:parent:WebCore::]):
      (-[WebAVStreamDataParserListener dealloc]):
      (-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]):
      (-[WebAVStreamDataParserListener streamDataParser:didFailToParseStreamDataWithError:]):
      (-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]):
      (-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]):
      (WebCore::MediaSampleAVFObjC::create):
      (WebCore::MediaSampleAVFObjC::~MediaSampleAVFObjC):
      (WebCore::MediaSampleAVFObjC::MediaSampleAVFObjC):
      (WebCore::MediaSampleAVFObjC::platformSample):
      (WebCore::CMSampleBufferIsRandomAccess):
      (WebCore::MediaSampleAVFObjC::flags):
      (WebCore::MediaDescriptionAVFObjC::create):
      (WebCore::MediaDescriptionAVFObjC::~MediaDescriptionAVFObjC):
      (WebCore::MediaDescriptionAVFObjC::MediaDescriptionAVFObjC):
      (WebCore::SourceBufferPrivateAVFObjC::create):
      (WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
      (WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
      (WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset):
      (WebCore::SourceBufferPrivateAVFObjC::didFailToParseStreamDataWithError):
      (WebCore::callProcessCodedFrameForEachSample):
      (WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackID):
      (WebCore::SourceBufferPrivateAVFObjC::processCodedFrame):
      (WebCore::SourceBufferPrivateAVFObjC::didReachEndOfTrackWithTrackID):
      (WebCore::SourceBufferPrivateAVFObjC::setClient):
      (WebCore::SourceBufferPrivateAVFObjC::append):
      (WebCore::SourceBufferPrivateAVFObjC::abort):
      (WebCore::SourceBufferPrivateAVFObjC::removedFromMediaSource):
      (WebCore::SourceBufferPrivateAVFObjC::readyState):
      (WebCore::SourceBufferPrivateAVFObjC::setReadyState):
      (WebCore::SourceBufferPrivateAVFObjC::evictCodedFrames):
      (WebCore::SourceBufferPrivateAVFObjC::isFull):
      (WebCore::SourceBufferPrivateAVFObjC::hasVideo):
      (WebCore::SourceBufferPrivateAVFObjC::hasAudio):
      (WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
      (WebCore::createNonDisplayingCopy):
      (WebCore::SourceBufferPrivateAVFObjC::flushAndEnqueueNonDisplayingSamples):
      (WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
      (WebCore::SourceBufferPrivateAVFObjC::isReadyForMoreSamples):
      (WebCore::SourceBufferPrivateAVFObjC::setActive):
      (WebCore::SourceBufferPrivateAVFObjC::fastSeekTimeForMediaTime):
      (WebCore::SourceBufferPrivateAVFObjC::seekToTime):
      * platform/mac/PlatformClockCM.h:
      
      Add a SOFT_LINK_CLASS_OPTIONAL macro:
      * platform/mac/SoftLinking.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1dfc3a43
    • ap@apple.com's avatar
      Remove some duplicate checks from SerializedScriptValue · 49030778
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125358
      
      Reviewed by Geoffrey Garen.
      
      There is no need to call inherits() before WebCore's toXXX(JSValue) functions.
      
      Also, the result of toArrayBuffer() is a raw pointer, not a RefPtr (it's confusing
      because toArrayBufferView returns a RefPtr).
      
      * bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49030778
    • jer.noble@apple.com's avatar
      Unreviewed gardening; revert r160237 after r160247 made it unnecessary. · 98cdcaa0
      jer.noble@apple.com authored
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98cdcaa0
    • timothy_horton@apple.com's avatar
      Remove Image::decodedSize() · e0372e23
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125327
      
      Reviewed by Simon Fraser.
      
      Missed a comment when removing this code.
      
      * svg/graphics/SVGImage.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0372e23
    • jer.noble@apple.com's avatar
      Strip out extraneous logging from AppleGVA in media tests. · 57086a98
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125357
      
      Reviewed by Simon Fraser.
      
      Add a mechanism for stripping out abritrary regular expressions from test input and output.
      
      * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
      (SingleTestRunner._run_compare_test): Strip out logging
      * Scripts/webkitpy/port/base.py:
      (Port.logging_patterns_to_strip): Return an empty list by default.
      * Scripts/webkitpy/port/driver.py:
      (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
      * Scripts/webkitpy/port/mac.py:
      (MacPort.logging_patterns_to_strip): Return a complete list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57086a98
    • fpizlo@apple.com's avatar
      FTL should support hole/OOB array accesses · 5dba3f1b
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118077
      
      Reviewed by Oliver Hunt and Mark Hahnenberg.
      
      Source/JavaScriptCore: 
      
      * ftl/FTLCapabilities.cpp:
      (JSC::FTL::canCompile):
      * ftl/FTLIntrinsicRepository.h:
      * ftl/FTLLowerDFGToLLVM.cpp:
      (JSC::FTL::LowerDFGToLLVM::compileGetByVal):
      (JSC::FTL::LowerDFGToLLVM::baseIndex):
      
      LayoutTests: 
      
      * js/regress/double-get-by-val-out-of-bounds-expected.txt: Added.
      * js/regress/double-get-by-val-out-of-bounds.html: Added.
      * js/regress/get-by-val-out-of-bounds-expected.txt: Added.
      * js/regress/get-by-val-out-of-bounds.html: Added.
      * js/regress/script-tests/double-get-by-val-out-of-bounds.js: Added.
      (foo):
      * js/regress/script-tests/get-by-val-out-of-bounds.js: Added.
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dba3f1b
    • mitz@apple.com's avatar
      <rdar://problem/15606872> REGRESSION (r160148): Mail throws an exception during launch · 2da1741d
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125362
      
      Reviewed by Sam Weinig.
      
      There were two problems in how WKConnection was made to work with WKObject: first,
      API::Object::newObject() was not updated to allocate the correct wrapper class, and second,
      WebConnection has subclasses with additional data members, which don’t fit in the object
      storage ivar.
      
      * Shared/Cocoa/APIObject.mm:
      (API::Object::newObject): Changed to allocate a WKConnection of the required size.
      * UIProcess/API/Cocoa/WKConnection.mm:
      Removed _connection ivar.
      (-[WKConnection dealloc]): Changed to use -_connection accessor instead of ivar.
      (-[WKConnection setDelegate:]): Ditto.
      (-[WKConnection sendMessageWithName:body:]): Ditto.
      (-[WKConnection remoteObjectRegistry]): Ditto.
      (-[WKConnection _connection]): Added.
      (-[WKConnection _apiObject]): Changed to return the object in the instance extra storage.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2da1741d
    • msaboff@apple.com's avatar
      Split sizing of VarArgs frames from loading arguments for the frame · 75cc932a
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125331
      
      Reviewed by Filip Pizlo.
      
      Split loadVarargs into sizeAndAllocFrameForVarargs() and loadVarargs() in
      preparation for moving onto the C stack.  sizeAndAllocFrameForVarargs() will
      compute the size of the callee frame and allocate it, while loadVarargs()
      actually loads the argument values.
      
      As part of moving onto the C stack, sizeAndAllocFrameForVarargs() will be
      changed to a function that just computes the size.  The caller will use that
      size to allocate the new frame on the stack before calling loadVargs() and
      actually making the call.
      
      * interpreter/Interpreter.cpp:
      (JSC::sizeAndAllocFrameForVarargs):
      (JSC::loadVarargs):
      * interpreter/Interpreter.h:
      * jit/JIT.h:
      * jit/JITCall.cpp:
      (JSC::JIT::compileLoadVarargs):
      * jit/JITCall32_64.cpp:
      (JSC::JIT::compileLoadVarargs):
      * jit/JITInlines.h:
      (JSC::JIT::callOperation):
      * jit/JITOperations.cpp:
      * jit/JITOperations.h:
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::LLINT_SLOW_PATH_DECL):
      * llint/LLIntSlowPaths.h:
      * llint/LowLevelInterpreter.asm:
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      * runtime/VM.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75cc932a
    • commit-queue@webkit.org's avatar
      [CSS Shapes] ShapeOutsideInfo needs to use the parent's writing mode when calculating offsets · 3b5bb143
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124680
      
      Patch by Rob Buis <rob.buis@samsung.com> on 2013-12-06
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Do not take the writing-mode property on the float into account for shape-outside.
      Add a virtual method writingMode() in order to do this for shape-outside but
      keep old behavior (element writingMode) for shape-inside.
      
      Change existing test floats/shape-outside-floats-different-writing-modes.html to test the
      new behavior.
      
      * rendering/shapes/ShapeInfo.cpp:
      (WebCore::::computedShape):
      * rendering/shapes/ShapeInfo.h:
      (WebCore::ShapeInfo::writingMode):
      * rendering/shapes/ShapeOutsideInfo.cpp:
      (WebCore::ShapeOutsideInfo::writingMode):
      * rendering/shapes/ShapeOutsideInfo.h:
      
      LayoutTests:
      
      Make sure the writing-mode property on the float is not taken into account for shape-outside.
      Adapt highlight-shape-outside.html so it sets the writing-mode on the container div, not the float.
      However because of earlier unreliability in EFL/GTK, skip the test for now.
      
      * TestExpectations:
      * fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html:
      * inspector-protocol/model/highlight-shape-outside-expected.txt:
      * inspector-protocol/model/highlight-shape-outside.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b5bb143
    • fpizlo@apple.com's avatar
      FTL should support all of ValueToInt32 · 6f2bf6ca
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125283
      
      Reviewed by Mark Hahnenberg.
      
      Source/JavaScriptCore: 
      
      * ftl/FTLCapabilities.cpp:
      (JSC::FTL::canCompile):
      * ftl/FTLLowerDFGToLLVM.cpp:
      (JSC::FTL::LowerDFGToLLVM::compileValueToInt32):
      (JSC::FTL::LowerDFGToLLVM::compilePutByVal):
      (JSC::FTL::LowerDFGToLLVM::lowCell):
      (JSC::FTL::LowerDFGToLLVM::isCell):
      
      LayoutTests: 
      
      * js/regress/put-by-val-machine-int-expected.txt: Added.
      * js/regress/put-by-val-machine-int.html: Added.
      * js/regress/script-tests/put-by-val-machine-int.js: Added.
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f2bf6ca
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove Staging Workaround · db19be0f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125354
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-12-06
      Reviewed by Timothy Hatcher.
      
      * inspector/CodeGeneratorInspector.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db19be0f
    • commit-queue@webkit.org's avatar
      Simplify ScriptFunctionCall by removing dead code. · 3c255680
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125274
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-12-06
      Reviewed by Timothy Hatcher.
      
      * bindings/js/ScriptFunctionCall.cpp:
      (WebCore::ScriptFunctionCall::call):
      * bindings/js/ScriptFunctionCall.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c255680
    • dino@apple.com's avatar
      Updating ANGLE should point to instructions · bc8f5170
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125361
      
      Reviewed by Eric Carlson.
      
      Point to https://trac.webkit.org/wiki/UpdatingANGLE when
      someone wants to patch ANGLE.
      
      * Scripts/webkitpy/common/config/watchlist:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc8f5170
    • fpizlo@apple.com's avatar
      FTL shouldn't have a doubleToUInt32 path · a498a268
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125360
      
      Reviewed by Mark Hahnenberg.
              
      This code existed because I incorrectly thought it was necessary. It's now basically
      dead.
      
      * ftl/FTLLowerDFGToLLVM.cpp:
      (JSC::FTL::LowerDFGToLLVM::compilePutByVal):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a498a268
    • eric.carlson@apple.com's avatar
      Unreviewed gardening, correct previous fix. · 079910ef
      eric.carlson@apple.com authored
      * platform/mac-mountainlion/TestExpectations: Removed.
      * platform/mac/TestExpectations: Mark plugins/quicktime-plugin-replacement.html as flakey
          on Mavericks.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      079910ef
    • dbates@webkit.org's avatar
      [iOS] Upstream WebCore/rendering changes · 395fca7a
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125239
      
      Reviewed by Simon Fraser.
      
      * WebCore.xcodeproj/project.pbxproj:
      * rendering/InlineBox.cpp:
      (WebCore::InlineBox::previousOnLineExists): Added.
      * rendering/InlineBox.h:
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paintCompositionBackground): Modified to query RenderStyle
      on iOS for the composition fill color. Added FIXME to make this platform-independent.
      (WebCore::InlineTextBox::paintDecoration): Added iOS-specific decoration code.
      (WebCore::lineStyleForMarkerType):
      (WebCore::InlineTextBox::paintDocumentMarkers): Added iOS-specific code. Also, added
      FIXME to make this code platform-independent.
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::paint): Ditto.
      (WebCore::positionForPointRespectingEditingBoundaries): Added iOS-specific code.
      * rendering/RenderBlock.h: Changed access control of logical{Left, Right}SelectionOffset()
      from private to protected so that these methods can be used from RenderImage::collectSelectionRects().
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::borderRadii): Added.
      (WebCore::RenderBox::paintBoxDecorations): Added iOS-specific workaround. See <rdar://problem/6209763>
      for more details.
      (WebCore::RenderBox::computeRectForRepaint): Added iOS-specific code.
      (WebCore::customContainingBlockWidth): Added; guarded by PLATFORM(IOS).
      (WebCore::customContainingBlockHeight): Added; guarded by PLATFORM(IOS).
      (WebCore::customContainingBlockLogicalWidth): Added; guarded by PLATFORM(IOS).
      (WebCore::customContainingBlockLogicalHeight): Added; guarded by PLATFORM(IOS).
      (WebCore::customContainingBlockAvailableLogicalHeight): Added; guarded by PLATFORM(IOS).
      (WebCore::RenderBox::availableLogicalHeightUsing): Added iOS-specific code; calls customContainingBlockAvailableLogicalHeight().
      (WebCore::RenderBox::containingBlockLogicalWidthForPositioned): Added iOS-specific code; calls customContainingBlockLogicalWidth().
      (WebCore::RenderBox::containingBlockLogicalHeightForPositioned): Added iOS-specific code; calls customContainingBlockLogicalHeight().
      (WebCore::RenderBox::layoutOverflowRectForPropagation): Added iOS-specific code.
      * rendering/RenderBox.h:
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::stickyPositionOffset): Use FrameView::customFixedPositionLayoutRect()
      instead of FrameView::viewportConstrainedVisibleContentRect().
      * rendering/RenderButton.cpp:
      (WebCore::RenderButton::layout): Added; iOS-specific. Includes FIXME comment.
      See <rdar://problem/7675493> for more details.
      * rendering/RenderElement.cpp:
      (WebCore::RenderElement::styleWillChange): Added iOS-specific code.
      (WebCore::RenderElement::styleDidChange): Modified to only call areCursorsEqual() and
      EventHandler::scheduleCursorUpdate() on a non-iOS port.
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing): Added iOS-specific code.
      (WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason): This method has an empty implementation for iOS.
      (WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonWithDescription): Ditto.
      * rendering/RenderFileUploadControl.cpp:
      (WebCore::nodeHeight):
      (WebCore::RenderFileUploadControl::maxFilenameWidth): Added iOS-specific code.
      (WebCore::RenderFileUploadControl::paintObject): Ditto.
      (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::positionFrames): Ditto; Also added FIXME comment as this code may not
      be specific to iOS.
      * rendering/RenderIFrame.h: Added iOS-specific workaround to RenderObject::renderName(). Added
      FIXME comment to determine whether this workaround is still applicable.
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::collectSelectionRects): Added; guarded by PLATFORM(IOS).
      (WebCore::RenderImage::paintAreaElementFocusRing): This method has an empty implementation for iOS.
      * rendering/RenderImage.h:
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::absoluteQuadsForSelection): Added; guarded by PLATFORM(IOS).
      * rendering/RenderInline.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::RenderLayer): Added iOS-specific member initialization.
      (WebCore::RenderLayer::~RenderLayer): Added iOS-specific code.
      (WebCore::RenderLayer::willBeDestroyed): Added; iOS-specific.
      (WebCore::RenderLayer::hasAcceleratedTouchScrolling): Ditto.
      (WebCore::RenderLayer::handleTouchEvent): Ditto.
      (WebCore::RenderLayer::registerAsTouchEventListenerForScrolling): Ditto.
      (WebCore::RenderLayer::unregisterAsTouchEventListenerForScrolling): Ditto.
      (WebCore::RenderLayer::updateNeedsCompositedScrolling): Added iOS-specific code as we use UIKit
      to composite our scroll bars.
      (WebCore::RenderLayer::scrollTo): Added iOS-specific code.
      (WebCore::RenderLayer::scrollRectToVisible): Ditto.
      (WebCore::RenderLayer::styleChanged): Modified to make use of the passed StyleDifference on iOS.
      (WebCore::RenderLayer::visibleContentRect): Added; iOS-specific.
      (WebCore::RenderLayer::didStartScroll): Ditto.
      (WebCore::RenderLayer::didEndScroll): Ditto.
      (WebCore::RenderLayer::didUpdateScroll): Ditto.
      (WebCore::RenderLayer::invalidateScrollbarRect): Added iOS-specific code.
      (WebCore::RenderLayer::invalidateScrollCornerRect): Ditto.
      (WebCore::RenderLayer::verticalScrollbarWidth): Ditto.
      (WebCore::RenderLayer::horizontalScrollbarHeight): Ditto.
      (WebCore::RenderLayer::updateScrollableAreaSet): Ditto.
      (WebCore::RenderLayer::updateScrollInfoAfterLayout): Add iOS-specific workaround with FIXME. See
      <rdar://problem/15579797> for more details.
      (WebCore::RenderLayer::paintOverflowControls): Added iOS-specific code.
      (WebCore::RenderLayer::calculateClipRects): Ditto.
      * rendering/RenderLayer.h:
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): Modified to not apply page scale on iOS
      as we apply a page scale at a different time in the code.
      (WebCore::RenderLayerBacking::layerWillBeDestroyed): Added; guarded by PLATFORM(IOS).
      (WebCore::layerOrAncestorIsTransformedOrScrolling): Added iOS-specific variant with FIXME comment.
      (WebCore::RenderLayerBacking::shouldClipCompositedBounds): Added iOS-specific code.
      (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Ditto.
      (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Ditto.
      (WebCore::RenderLayerBacking::registerScrollingLayers): Ditto.
      (WebCore::RenderLayerBacking::updateScrollingLayers): Ditto.
      (WebCore::RenderLayerBacking::containsPaintedContent): Call RenderLayer::hasBoxDecorationsOrBackground()
      when building on iOS Simulator.
      (WebCore::RenderLayerBacking::parentForSublayers): Added iOS-specific code and FIXME comment.
      (WebCore::RenderLayerBacking::paintsIntoWindow): Opt-into coordinated graphics code path.
      (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Added iOS-specific code.
      (WebCore::RenderLayerBacking::paintIntoLayer): Compile-out ASSERT_NOT_REACHED for iOS and added FIXME comment.
      * rendering/RenderLayerBacking.h:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::scheduleLayerFlush): Added iOS-specific code.
      (WebCore::RenderLayerCompositor::chromeClient): Added; guarded by PLATFORM(IOS).
      (WebCore::RenderLayerCompositor::flushPendingLayerChanges): Added iOS-specific code.
      (WebCore::scrollbarHasDisplayNone): Added; iOS-specific.
      (WebCore::updateScrollingLayerWithClient): Ditto.
      (WebCore::RenderLayerCompositor::updateCustomLayersAfterFlush): Ditto.
      (WebCore::RenderLayerCompositor::didFlushChangesForLayer): Added iOS-specific code.
      (WebCore::RenderLayerCompositor::didChangeVisibleRect): Ditto.
      (WebCore::RenderLayerCompositor::addToOverlapMap): Don't apply page scale factor on iOS. We apply
      the page scale factor at a different time in the code. Also, added FIXME comment.
      (WebCore::RenderLayerCompositor::computeCompositingRequirements): Added iOS-specific workaround.
      See <rdar://problem/8348337> for more details.
      (WebCore::RenderLayerCompositor::setIsInWindow): Use non-Mac code path for iOS.
      (WebCore::RenderLayerCompositor::allowsIndependentlyCompositedFrames): Added iOS-specific code.
      (WebCore::RenderLayerCompositor::requiresCompositingLayer): Ditto.
      (WebCore::RenderLayerCompositor::requiresOwnBackingStore): Ditto.
      (WebCore::RenderLayerCompositor::reasonsForCompositing): Ditto.
      (WebCore::RenderLayerCompositor::requiresCompositingForAnimation): Opt-into calling
      AnimationController::isRunningAnimationOnRenderer() on iOS.
      (WebCore::RenderLayerCompositor::requiresCompositingForScrolling): Added; guarded by PLATFORM(IOS).
      (WebCore::isStickyInAcceleratedScrollingLayerOrViewport): Added iOS-specific code.
      (WebCore::isViewportConstrainedFixedOrStickyLayer): Ditto.
      (WebCore::RenderLayerCompositor::requiresCompositingForPosition): Use FrameView::customFixedPositionLayoutRect()
      instead of FrameView::viewportConstrainedVisibleContentRect().
      (WebCore::RenderLayerCompositor::contentsScaleMultiplierForNewTiles): Ditto.
      (WebCore::RenderLayerCompositor::ensureRootLayer): Ditto.
      (WebCore::RenderLayerCompositor::computeFixedViewportConstraints): Use FrameView::customFixedPositionLayoutRect()
      instead of FrameView::viewportConstrainedVisibleContentRect().
      (WebCore::RenderLayerCompositor::computeStickyViewportConstraints): Ditto.
      (WebCore::RenderLayerCompositor::registerOrUpdateViewportConstrainedLayer): This method has an empty implementation for iOS
      as we batch update viewport-constrained layers in the iOS-specific method, RenderLayerCompositor::updateCustomLayersAfterFlush().
      (WebCore::RenderLayerCompositor::unregisterViewportConstrainedLayer): Ditto.
      (WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers): Added; guarded by PLATFORM(IOS).
      (WebCore::RenderLayerCompositor::unregisterAllViewportConstrainedLayers): Ditto.
      (WebCore::RenderLayerCompositor::registerAllScrollingLayers): Ditto.
      (WebCore::RenderLayerCompositor::unregisterAllScrollingLayers): Ditto.
      (WebCore::RenderLayerCompositor::scrollingLayerAddedOrUpdated): Ditto.
      (WebCore::RenderLayerCompositor::scrollingLayerRemoved): Ditto.
      (WebCore::RenderLayerCompositor::startInitialLayerFlushTimerIfNeeded): Ditto.
      * rendering/RenderLayerCompositor.h:
      * rendering/RenderLayerFilterInfo.h: Added iOS-specific Clang workaround to ignore
      an unused private field.
      * rendering/RenderMenuList.cpp:
      (WebCore::selectedOptionCount): Added; guarded by PLATFORM(IOS).
      (WebCore::RenderMenuList::RenderMenuList): On iOS we don't make use of RenderMenuList::m_popupIsVisible.
      (WebCore::RenderMenuList::~RenderMenuList): On iOS we don't make use of RenderMenuList::m_popup.
      (WebCore::RenderMenuList::adjustInnerStyle): Add iOS-specific code.
      (RenderMenuList::updateFromElement): On iOS we don't make use of RenderMenuList::m_popup.
      (RenderMenuList::setTextFromOption): Add iOS-specific code.
      (RenderMenuList::showPopup): Define RenderMenuList::showPopup() to ASSERT_NOT_REACHED() on iOS as
      we don't make use of RenderMenuList::m_popup.
      (RenderMenuList::hidePopup): This method has an empty implementation for iOS as we don't make use
      of RenderMenuList::m_popup.
      (RenderMenuList::popupDidHide): This method has an empty implementation for iOS as we don't make use
      of RenderMenuList::m_popupIsVisible.
      * rendering/RenderMenuList.h:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::columnNumberForOffset): Added; guarded by PLATFORM(IOS). Also, added a FIXME comment to
      make this function return an unsigned integer instead of a signed integer.
      (WebCore::RenderObject::collectSelectionRects): Added; guarded by PLATFORM(IOS).
      (WebCore::RenderObject::destroy): Added iOS-specific code.
      (WebCore::RenderObject::innerLineHeight): Added.
      (WebCore::RenderObject::willRenderImage): Added iOS-specific code.
      * rendering/RenderObject.h: Change the access control of RenderObject::drawLineForBoxSide() from protected to
      public so that it can be used from RenderThemeIOS::adjustMenuListButtonStyle().
      (WebCore::RenderObject::absoluteQuadsForSelection):
      * rendering/RenderScrollbar.h: Change the access control of RenderScrollbar::getScrollbarPseudoStyle() from
      private to public so that it can be used from the iOS-specific static function, scrollbarHasDisplayNone,
      defined in RenderLayerCompositor.cpp.
      * rendering/RenderSearchField.cpp:
      (WebCore::RenderSearchField::itemText): Added iOS-specific code.
      * rendering/RenderText.cpp:
      (WebCore::RenderText::collectSelectionRects): Added; guarded by PLATFORM(IOS).
      (WebCore::RenderText::setTextInternal): Added iOS-specific code.
      * rendering/RenderText.h:
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::adjustInnerTextStyle): Ditto.
      (WebCore::RenderTextControl::canScroll): Added; guarded by PLATFORM(IOS).
      (WebCore::RenderTextControl::innerLineHeight): Ditto.
      * rendering/RenderTextControl.h:
      * rendering/RenderTextControlMultiLine.cpp:
      (WebCore::RenderTextControlMultiLine::getAvgCharWidth): Compile-out code when building for iOS.
      (WebCore::RenderTextControlMultiLine::createInnerTextStyle): Added iOS-specific code.
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::layout): Ditto.
      (WebCore::RenderTextControlSingleLine::getAvgCharWidth): Compile-out code when building for iOS.
      (WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth): Ditto.
      * rendering/RenderTextLineBoxes.cpp:
      (WebCore::lineDirectionPointFitsInBox): Ditto.
      (WebCore::RenderTextLineBoxes::positionForPoint): Added iOS-specific code.
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::paintBorderOnly): Ditto.
      (WebCore::RenderTheme::paintDecorations): Modified to call the control-specific paint*Decorations().
      * rendering/RenderTheme.h:
      (WebCore::RenderTheme::paintCheckboxDecorations): Added.
      (WebCore::RenderTheme::paintRadioDecorations): Added.
      (WebCore::RenderTheme::paintButtonDecorations): Added.
      (WebCore::RenderTheme::paintTextFieldDecorations): Added.
      (WebCore::RenderTheme::paintTextAreaDecorations): Added.
      (WebCore::RenderTheme::paintMenuListDecorations): Added.
      (WebCore::RenderTheme::paintPushButtonDecorations): Added.
      (WebCore::RenderTheme::paintSquareButtonDecorations): Added.
      (WebCore::RenderTheme::paintFileUploadIconDecorations): Added.
      (WebCore::RenderTheme::paintSliderThumbDecorations): Added.
      (WebCore::RenderTheme::paintSearchFieldDecorations): Added.
      * rendering/RenderThemeIOS.h: Added.
      * rendering/RenderThemeIOS.mm: Added.
      * rendering/RenderThemeMac.h: Don't compile the contents of this file when building for iOS.
      * rendering/RenderThemeMac.mm: Ditto.
      * rendering/RenderVideo.cpp:
      (WebCore::RenderVideo::calculateIntrinsicSize): Compile-out code when building for iOS.
      * rendering/RenderView.cpp:
      (WebCore::RenderView::availableLogicalHeight): Add iOS-specific workaround. See <rdar://problem/7166808>.
      (WebCore::fixedPositionOffset): Added; used in iOS-specific code (e.g. RenderView::mapLocalToContainer()).
      (WebCore::RenderView::mapLocalToContainer): Use WebCore::fixedPositionOffset() instead of
      FrameView::scrollOffsetForFixedPosition().
      (WebCore::RenderView::pushMappingToContainer): Ditto.
      (WebCore::RenderView::mapAbsoluteToLocalPoint): Ditto.
      (WebCore::RenderView::repaintViewRectangle): Ditto.
      (WebCore::RenderView::computeRectForRepaint): Ditto.
      (WebCore::isFixedPositionInViewport): Added; used in RenderView::hasCustomFixedPosition().
      (WebCore::RenderView::hasCustomFixedPosition): Added; guarded by PLATFORM(IOS).
      * rendering/RenderView.h:
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::willBeDestroyed): Added iOS-specific code.
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::ascentAndDescentForBox): Ditto.
      * rendering/break_lines.cpp: Only include header <CoreServices/CoreServices.h> when building for Mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      395fca7a
    • zoltan@webkit.org's avatar
      Clean up the includes of RenderBlock.h · 7b4eb627
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125351
      
      Reviewed by Darin Adler.
      
      I turned some header includes into forward declarations. I also removed /
      moved out some includes, which don't belong to RenderBlock.h anymore.
      
      No new tests, no behavior change.
      
      * editing/VisibleUnits.cpp:
      * html/HTMLInputElement.cpp:
      * html/HTMLTextAreaElement.cpp:
      * html/TextFieldInputType.cpp:
      * html/TextInputType.cpp:
      * rendering/InlineElementBox.cpp:
      * rendering/RenderBlock.h:
      * rendering/RenderBlockFlow.cpp:
      * rendering/line/LineBreaker.h:
      * rendering/line/LineWidth.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b4eb627
    • eric.carlson@apple.com's avatar
      plugins/quicktime-plugin-replacement.html is flakey on OS X Mavericks · a3ae78ee
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125356
      
      Reviewed by Jer Noble.
      
      * platform/mac-mountainlion/TestExpectations: Added. Mark test as flakey.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3ae78ee
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 8f52b91d
      m.pakula@samsung.com authored
      Add test expectations for failing tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f52b91d
    • mitz@apple.com's avatar
      [Mac] Transition MiniBrowser to the Cocoa API: load delegate · 3944ae26
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125334
      
      Reviewed by Darin Adler.
      
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
      title property.
      (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
      (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
      (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
      window title with the title property changes.
      (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
      set the load delegate instead of the load client.
      (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
      (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
      (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
      (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
      Implemented this load delegate method.
      (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
      Ditto.
      (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
      (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
      (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
      (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
      (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
      Ditto.
      (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
      Ditto.
      (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3944ae26
    • commit-queue@webkit.org's avatar
      Remove function from style/checkers/cpp.py. · d436eeb1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125341
      
      Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-06
      Reviewed by Darin Adler.
      
      Corrects a FIXME: by removing a function from cpp.py.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (CppChecker.__init__):
      (CppChecker.check):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (CppStyleTestBase.process_file_data):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d436eeb1
    • commit-queue@webkit.org's avatar
      check-webkit-style: false positive warning for indentation of #ifdef code. · 7c4fa02a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125254
      
      Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-06
      Reviewed by Darin Adler.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_member_initialization_list):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (WebKitStyleTest.test_member_initialization_list):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c4fa02a
    • commit-queue@webkit.org's avatar
      Define SHA1 hash size in SHA1.h and use it at various places. · fb09d390
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125345
      
      Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-12-06
      Reviewed by Darin Adler.
      
      Use SHA1::hashSize instead of local variables.
      
      Source/JavaScriptCore:
      
      * bytecode/CodeBlockHash.cpp:
      (JSC::CodeBlockHash::CodeBlockHash): use SHA1::hashSize
      
      Source/WebCore:
      
      * Modules/websockets/WebSocketHandshake.cpp:
      (WebCore::WebSocketHandshake::getExpectedWebSocketAccept):
      * platform/network/soup/ResourceHandleSoup.cpp:
      (WebCore::HostTLSCertificateSet::computeCertificateHash):
      
      Source/WTF:
      
      * wtf/SHA1.h: define SHA1 hash size
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb09d390
    • mitz@apple.com's avatar
      [Cocoa] Add load delegate methods for responding to authentication challenges · ae0fd005
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125333
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      * WebCore.exp.in: Exported core(NSURLCredential *).
      
      Source/WebKit2: 
      
      * Shared/Cocoa/APIObject.mm:
      (API::Object::newObject): Allocate a WKNSURLAuthenticationChallenge if the object is an
      AuthenticationChallengeProxy.
      
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      (canAuthenticateAgainstProtectionSpaceInFrame): Implemented this WKPageLoaderClient callback
      by calling the load delegate.
      (didReceiveAuthenticationChallengeInFrame): Ditto.
      (setUpPageLoaderClient): Set the above callbacks in the client structure.
      
      * UIProcess/API/Cocoa/WKBrowsingContextLoadDelegatePrivate.h: Added. Declares two new
      delegate methods.
      
      * UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.h: Added.
      (WebKit::wrapper): Added. Returns an AuthenticationChallengeProxy’s wrapper as an
      NSURLAuthenticationChallenge.
      * UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm: Added.
      (-[WKNSURLAuthenticationChallenge _web_createTarget]): Override this WKObject method to
      return a copy of the challenge with the sender set to a shared instance of
      WKNSURLAuthenticationChallengeSender.
      (-[WKNSURLAuthenticationChallenge _web_authenticationChallengeProxy]): Added. Returns the
      wrapped object.
      (-[WKNSURLAuthenticationChallengeSender cancelAuthenticationChallenge:]): Added. Calls
      AuthenticationDecisionListener::cancel.
      (-[WKNSURLAuthenticationChallengeSender continueWithoutCredentialForAuthenticationChallenge:]):
      Added. Calls AuthenticationDecisionListener::useCredential, passing nullptr.
      (-[WKNSURLAuthenticationChallengeSender useCredential:forAuthenticationChallenge:]): Added.
      Calls AuthenticationDecisionListener::useCredential, passing the credential.
      
      * WebKit2.xcodeproj/project.pbxproj: Added references to new files.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae0fd005
    • dbates@webkit.org's avatar
      Rename {adjust, paint}SearchFieldDecoration, {adjust, paint}SearchFieldResultsDecoration · 94374e8b
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125191
      
      Reviewed by Joseph Pecoraro.
      
      Towards upstreaming the iOS concept of render theme decorations, we should rename
      RenderTheme::{adjust, paint}SearchFieldDecorationStyle and RenderTheme::{adjust, paint}SearchFieldResultsDecoration
      to avoid ambiguity with the iOS concept.
      
      * platform/efl/RenderThemeEfl.cpp:
      * platform/efl/RenderThemeEfl.h:
      * platform/gtk/RenderThemeGtk.cpp:
      * platform/gtk/RenderThemeGtk.h:
      * rendering/RenderTheme.cpp:
      * rendering/RenderTheme.h:
      * rendering/RenderThemeMac.h:
      * rendering/RenderThemeMac.mm:
      * rendering/RenderThemeSafari.cpp:
      * rendering/RenderThemeSafari.h:
      * rendering/RenderThemeWin.cpp:
      * rendering/RenderThemeWin.h:
      * rendering/RenderThemeWinCE.cpp:
      * rendering/RenderThemeWinCE.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94374e8b
    • commit-queue@webkit.org's avatar
      Unreviewed ATK gardening · 489ac072
      commit-queue@webkit.org authored
      accessibility/document-attributes.html started failing after r160220.
      
      Patch by Lukasz Gajowy <l.gajowy@samsung.com> on 2013-12-06
      
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      489ac072
    • akling@apple.com's avatar
      Make remaining CSSValue constructors return PassRef. · a85072c5
      akling@apple.com authored
      <https://webkit.org/b/125337>
      
      Tweak the remaining CSSValue create() helpers to return PassRef
      instead of PassRefPtr in the cases where nullptr is never returned.
      
      Reviewed by Anders Carlsson.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a85072c5
    • roger_fong@apple.com's avatar
      Hook into some shader symbol logic following the ANGLE update in r159533. · e9526c4f
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125332.
      
      Reviewed by Brent Fulgham.
      
      No new functionality added.
      
      * html/canvas/WebGLRenderingContext.cpp: Add some error checking for errors related to
          shader symbols that exist across both vertex and fragment shaders.
      (WebCore::WebGLRenderingContext::linkProgram):
      * platform/graphics/ANGLEWebKitBridge.cpp: Add logic for handling varyings
          and add new fields to the ANGLEShaderSymbol struct.
      (WebCore::getSymbolInfo):
      * platform/graphics/ANGLEWebKitBridge.h:
      * platform/graphics/GraphicsContext3D.h: Add those same fields to the SymbolInfo struct
          as well so that we can access them from our shader source map.
          Also add a map of varyings along side the uniforms and attributes.
      (WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo):
      (WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap):
      * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
      (WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
      * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
      (WebCore::GraphicsContext3D::areProgramSymbolsValid): Will be filled in later, this method
          will use the shader source map to check for issues with unused varyings and precisions
          mismatches of shader symbols that exist across both the vertex and fragment shaders.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9526c4f
    • cfleizach@apple.com's avatar
      Fix spelling error in style checker: beggining · 135718ab
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125347
      
      Reviewed by Anders Carlsson.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_member_initialization_list):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (WebKitStyleTest.test_member_initialization_list):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      135718ab
    • msaboff@apple.com's avatar
      REGRESSION(r160213): Crash in js/dom/JSON-parse.html · d18fefdc
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125335
      
      Reviewed by Mark Lam.
      
      Changed _llint_op_catch to materialize the VM via the scope chain instead of 
      the CodeBlock.  CallFrames always have a scope chain, but may have a null CodeBlock.
      
      * llint/LowLevelInterpreter32_64.asm:
      (_llint_op_catch):
      * llint/LowLevelInterpreter64.asm:
      (_llint_op_catch):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d18fefdc
    • commit-queue@webkit.org's avatar
      [ATK] Missing aria roles mappings · b68dfdf2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117729
      
      Patch by Lukasz Gajowy <l.gajowy@samsung.com> on 2013-12-06
      Reviewed by Mario Sanchez Prada.
      
      Source/WebCore:
      
      Added a few mappings from ARIA roles to ATK roles.
      
      Test: accessibility/aria-mappings.html
      
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      
      Tools:
      
      Added new mappings to AccessibilityUIElementAtk.cpp.
      
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      
      LayoutTests:
      
      Added new test, checking whether ARIA roles to ATK roles mappings work properly.
      
      * accessibility/aria-mappings-expected.txt: Added.
      * accessibility/aria-mappings.html: Added.
      * platform/mac/accessibility/aria-mappings-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b68dfdf2
    • ossy@webkit.org's avatar
      Typo fix after r160218. · 05e344f6
      ossy@webkit.org authored
      * Scripts/webkitpy/test/main.py:
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05e344f6
    • ossy@webkit.org's avatar
      Unreviewed fix after r160206. · 28c5f212
      ossy@webkit.org authored
      * Scripts/webkitpy/test/main.py:
      (main): sys.platform can be win32 or cygwin too on Windows.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28c5f212
    • commit-queue@webkit.org's avatar
      Build fix after r160207, remove the BitmapImage::decodeSize symbol export · 7d772df5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125342
      
      Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-06
      Reviewed by Csaba Osztrogonác.
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d772df5
    • philn@webkit.org's avatar
      [GStreamer] webkitwebaudiosrc element needs to emit stream-start, caps and segment events · 55ae3aa9
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123015
      
      Reviewed by Martin Robinson.
      
      When the source element starts emitting buffers send along various
      events to notify downstream elements.
      
      No new tests, change covered by existing webaudio tests.
      
      * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
      (webkit_web_audio_src_init): Initialize segment.
      (webKitWebAudioSrcConstructed): Give an explicit name to each
      queue added in front of the interleave element.
      (webKitWebAudioSrcLoop): Before sending the first buffers push
      stream-start, caps and segment events on each queue's sinkpad.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55ae3aa9
    • berto@igalia.com's avatar
      [GTK] Enable web audio by default · 0dc4522f
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124888
      
      Reviewed by Martin Robinson.
      
      When building with ./configure, enable_web_audio defaults to
      "no". However the basic functionality has been working for months
      so it's safe to enable it now.
      
      * Source/autotools/ReadCommandLineArguments.m4:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dc4522f
    • philn@webkit.org's avatar
      [GStreamer] Audio/Video sink management is incoherent · 8f10d46f
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125304
      
      Reviewed by Gustavo Noronha Silva.
      
      Allow subclasses of MediaPlayerPrivateGStreamerBase to create
      custom audio/video sinks in a coherent manner using
      create{Audio,Video}Sink methods. Convenience getters are also
      available. Also removed some un-needed member variables in the
      playbin-based player.
      
      No new tests, existing media tests cover this change.
      
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
      (WebCore::MediaPlayerPrivateGStreamer::updateStates):
      (WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
      (WebCore::MediaPlayerPrivateGStreamer::audioSink):
      (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
      (WebCore::MediaPlayerPrivateGStreamerBase::createAudioSink):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f10d46f
  2. 05 Dec, 2013 3 commits
    • msaboff@apple.com's avatar
      JSC: Simplify interface between throw and catch handler · c3101eb3
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125328
      
      Reviewed by Geoffrey Garen.
      
      Simplified the throw - catch interface.  The throw side is only responsible for
      jumping to the appropriate op_catch handler or returnFromJavaScript for uncaught
      exceptions.  The handler uses the exception values like VM.callFrameForThrow
      as appropriate and no longer relies on the throw side putting anything in
      registers.
      
      * jit/CCallHelpers.h:
      (JSC::CCallHelpers::jumpToExceptionHandler):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_catch):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::emit_op_catch):
      * llint/LowLevelInterpreter32_64.asm:
      (_llint_op_catch):
      (_llint_throw_from_slow_path_trampoline):
      * llint/LowLevelInterpreter64.asm:
      (_llint_op_catch):
      (_llint_throw_from_slow_path_trampoline):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3101eb3
    • gyuyoung.kim@samsung.com's avatar
      Introduce IMAGE_TYPE_CASTS, and use it · 3886a9b6
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125330
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      As a step to use TYPE_CASTS_BASE, this cl introduce IMAGE_TYPE_CASTS.
      BitmapImage and SVGImage can use it to generate toFoo() type case helper functions.
      
      No new tests, no behavior changes.
      
      * loader/cache/CachedImage.cpp:
      (WebCore::CachedImage::imageSizeForRenderer):
      (WebCore::CachedImage::resumeAnimatingImagesForLoader):
      * platform/graphics/BitmapImage.h:
      * platform/graphics/Image.h:
      * platform/mac/DragImageMac.mm:
      (WebCore::createDragImageFromImage):
      * svg/graphics/SVGImage.h:
      
      Source/WebKit2:
      
      As a step to use TYPE_CASTS_BASE, this cl introduce IMAGE_TYPE_CASTS.
      BitmapImage, SVGImage can use it to generate toFoo() type case helper functions.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::pluginSnapshotTimerFired):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3886a9b6
    • mark.lam@apple.com's avatar
      C Loop LLINT layout test regressions. · f6c72967
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125314.
      
      Reviewed by Geoffrey Garen.
      
      The regression was due to the ENABLE_LLINT_C_LOOP flag not being included
      in the build of the WebKit and WebKit2 components. As a result, some fields
      in JSC::VM were ifdef'ed out in WebCore and JSC, but not in WebKit and
      WebKit2. This resulted in VM::m_initializingObjectClass having 2 different
      offsets depending on whether it is accessed from WebCore and JSC or from
      WebKit and WebKit2, and chaos ensued.
      
      This issue will manifest when we pass --cloop to build-webkit.
      The fix is simply to add ENABLE_LLINT_C_LOOP to FEATURE_DEFINES for WebKit
      and WebKit2.
      
      Source/WebKit/mac: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6c72967