GitLab

https://bugs.webkit.org/show_bug.cgi?id=76137

Source/WebCore:

Reviewed by Dave Hyatt.

When border-image-slice sizes add up to more than the height or width
of the border-image, the middle sections should not be rendered, per spec.

Test: fast/borders/border-image-slice-constrained.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

Reviewed by Dave Hyatt.

Testcase with border-image slices adding up to more than the height/width
of the border image.

Fixed cross-fade-webkit-mask-box-image.html to use slices that are half
of the image width.

* animations/cross-fade-webkit-mask-box-image.html:
* fast/borders/border-image-slice-constrained.html: Added.
* platform/mac/animations/cross-fade-webkit-mask-box-image-expected.png:
* platform/mac/fast/borders/border-image-slice-constrained-expected.png: Added.
* platform/mac/fast/borders/border-image-slice-constrained-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] [WebKit2] WebKitURIRequest and WebKitURIResponse should wrap the corresponding WebCore classes
https://bugs.webkit.org/show_bug.cgi?id=74478

Reviewed by Gustavo Noronha Silva.

Have WebKitURIRequest wrap a ResourceRquesst and WebKitURIResponse wrap a ResourceResponse.
They are the WebCore types they are meant to represent and we will need to expose more
information from them in the future to make them useful. Later we can have ResourceResponse
generate a SoupMessage lazily if necessary.

* GNUmakefile.am:
* UIProcess/API/gtk/WebKitURIRequest.cpp:
(webkit_uri_request_class_init): Remove the set property vmethod.
(webkit_uri_request_new): The URI property is no longer settable.
(webkitURIRequestCreateForResourceRequest): Added this private constructor.
(webkit_uri_request_get_uri): Now we just get the URI directly from the ResourceRequest.
* UIProcess/API/gtk/WebKitURIResponse.cpp:
(webkit_uri_response_class_init): Remove the set property vmethod.
(webkit_uri_response_get_uri): Get the URI directly from the ResourceReponse.
(webkit_uri_response_get_status_code): Get the status code directly from the ResourceResponse.
(webkit_uri_response_get_content_length): Get the content length directly from the ResourceResponse.
(webkitURIResponseCreateForResourceResponse): Added this private constructor.
* UIProcess/API/gtk/WebKitURIResponsePrivate.h: Removed unnecessary methods.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76204

Reviewed by Andreas Kling.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76186

Source/WebCore:

This code was landed in http://trac.webkit.org/changeset/104566 and
partially reverted in http://trac.webkit.org/changeset/104632 due
to problems with the Windows Shared builder.  Those problems have
been fixed in r3006, since rolled into Chrome.

Reviewed by Kenneth Russell.

Covered by SVG feColorMatrix tests.

* WebCore.gypi:
* platform/graphics/filters/FEColorMatrix.h:

LayoutTests:

Remove suppressions for tests which now pass.

Reviewed by Kenneth Russell.

* platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76202

Reviewed by Andreas Kling.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
* platform/mac/ScrollElasticityController.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76200

Reviewed by Andreas Kling.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::endScrollGesture):
* platform/mac/ScrollElasticityController.h:
* platform/mac/ScrollElasticityController.mm:
(systemUptime):
(WebCore::ScrollElasticityController::snapRubberBand):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76191

Source/WebCore: 

Reviewed by Andreas Kling.
        
Setting the user style sheet frees the existing user style sheet data structures. The code
in Document::updatePageGroupUserSheets then relies on styleSelectorChanged to clear the
style selector so it is not left with stale pointers. However under certain conditions
involving pending stylesheets it may bail out quickly without clearing.
        
Document::styleSelectorChanged has to take care that it never leaves the style selector stale
even when bailing out early.

Test: fast/css/user-stylesheet-crash.html

* dom/Document.cpp:
(WebCore::Document::styleSelectorChanged):

LayoutTests: 

Reviewed by Andreas Kling.

* fast/css/user-stylesheet-crash-expected.txt: Added.
* fast/css/user-stylesheet-crash.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76149

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
(WebCore::CCDelayBasedTimeSource::active):
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::setActive):
(WebCore::CCFrameRateController::onTimerTick):
* platform/graphics/chromium/cc/CCFrameRateController.h:
* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::setVisible):
(WebCore::CCScheduler::processScheduledActions):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
* platform/graphics/chromium/cc/CCTimeSource.h:

Source/WebKit/chromium:

* tests/CCDelayBasedTimeSourceTest.cpp:
(WebKitTests::TEST):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::timeout):
* tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
* tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):
* tests/CCSchedulerTestCommon.h:
(WebKitTests::FakeCCTimeSource::active):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76123

Reviewed by Adam Barth.

This change updates the unit tests to be more consistent in how
ports are created, in preparation for making port_name a
mandatory parameter to the constructor and removing any version
interpretation from it.

There should be no functional changes in this patch, but some
tests that are no longer relevant have been removed or reworked.

* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_get_option__default):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest):
(ChromiumLinuxPortTest.assert_architecture):
(ChromiumLinuxPortTest.test_determine_architecture_fails):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest):
(ChromiumPortTest.test_all_test_configurations):
(ChromiumPortTest.TestMacPort.__init__):
(ChromiumPortTest.TestLinuxPort.__init__):
(ChromiumPortTest.TestWinPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest):
* Scripts/webkitpy/layout_tests/port/efl_unittest.py:
(EflPortTest):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest):
(MockDRTPortTest.make_port):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._port_flag_for_scripts):
(QtPort.__init__):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):
(QtPortTest.test_operating_system):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitPortTest):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest):
(WinPortTest._assert_search_path):
(WinPortTest.test_baseline_search_path):
* Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
(get_test_config.TestMacPort.__init__):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76196

Reviewed by Andreas Kling.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
* platform/mac/ScrollElasticityController.h:
* platform/mac/ScrollElasticityController.mm:
(WebCore::elasticDeltaForTimeDelta):
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
(WebCore::ScrollElasticityController::snapRubberBandTimerFired):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76142

Reviewed by Adam Barth.

This test is mostly more refactoring - it calls objects in
unittest directly instead of routing through unittest.main() --
in order to gain more control over the logging and to provide a
correct --help message. This will also give us a better
foundation for adding more feautures down the road.

This patch adds different levels of logging controlled by the
'-s', '-q', and '-v' options (see --help for details), and
removes the --verbose-logging option.

* Scripts/test-webkitpy:
* Scripts/webkitpy/test/main.py:
(Tester):
(Tester.clean_packages):
(Tester.__init__):
(Tester.parse_args):
(Tester.configure):
(Tester._configure_logging):
(Tester.find_modules):
(Tester._exclude):
(Tester._modules_from_paths):
(Tester.run_tests):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76072

Source/WebCore:

Spec was updated to detail what should be thrown: http://www.w3.org/Bugs/Public/show_bug.cgi?id=11406

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-12
Reviewed by Tony Chang.

Tests: storage/indexeddb/transaction-basics.html

* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):

LayoutTests:

Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-12
Reviewed by Tony Chang.

* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-basics.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove the last non-ScrollElasticityController call from ScrollAnimatorMac::snapRubberBandTimerFired
https://bugs.webkit.org/show_bug.cgi?id=76193

Reviewed by Andreas Kling.

Use ScrollElasticityControllerClient::immediateScrollBy for the final scroll before the rubber-band timer stops.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=62320

Reviewed by Eric Carlson.

Source/WebCore:

Tests: fullscreen/full-screen-request-rejected.html
       fullscreen/full-screen-request-removed.html

When a request to enter full-screen is rejected, emit an event
(webkitfullscreenerror) in response.  But emit the event during the next
trip through the run-loop, like the webkitfullscreenchange event, and so a new
timer and queue are necessary.

* dom/Document.cpp:
(WebCore::Document::requestFullScreenForElement): Emit the error event
    if the request does not pass all our requirements.
* dom/Document.h: Add new ivars.
* dom/Document.idl: Add support for setting an onfullscreenerror attribute.
* dom/Element.h: Ditto.
* dom/Element.idl: Ditto.
* dom/EventNames.h: Add the name for the error event.

LayoutTests:

* fullscreen/full-screen-iframe-not-allowed-expected.txt:
* fullscreen/full-screen-iframe-not-allowed.html:
* fullscreen/full-screen-request-rejected-expected.txt: Added.
* fullscreen/full-screen-request-rejected.html: Added.
* fullscreen/full-screen-request-removed-expected: Added.
* fullscreen/full-screen-request-removed.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ScrollAnimatorMac::mouseEnteredScrollbar() and mouseExitedScrollbar() should 
only do stuff for legacy scrollbars
-and corresponding-
<rdar://problem/10603290>

Reviewed by Sam Weinig.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76148

Reviewed by Oliver Hunt.

Source/JavaScriptCore: 

AccessorDescriptor properties may have their get & set properties defined to reference a function
(Callable object) or be set to undefined. Valid PropertyDescriptors created by toPropertyDescriptor
(defined from JS code via Object.defineProperty, etc) have get and set properties that are in one of
three states (1) nonexistent, (2) set to undefined, or (3) a function (any Callable object).

On the PropertyDescriptor object these three states are represneted by JSValue(), jsUndefined(), and
any JSObject* (with a constraint that this must be callable).

Logically the get/set property of an accessor descriptor on an object might be in any of the three
states above, but in practice there is no way to distinguish between the first two states. As such
we stor the get/set values in property storage in a JSObject* field, with 0 indicating absent or
undefined. When unboxing to a PropertyDescriptor, map this back to a JS undefined value.

* runtime/GetterSetter.h:
(JSC::GetterSetter::setGetter):
(JSC::GetterSetter::setSetter):
    - Allow the getter/setter to be cleared.
* runtime/JSArray.cpp:
(JSC::JSArray::putDescriptor):
    - Changed to call getterObject/setterObject.
(JSC::JSArray::defineOwnNumericProperty):
    - Added ASSERT.
* runtime/JSObject.cpp:
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):
    - Changed to call getterObject/setterObject.
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyDescriptor):
    - getter/setter values read from properties on object are never missing, they will now be set as undefined by 'setDescriptor'.
(JSC::toPropertyDescriptor):
    - Do not translate undefined->empty, this loses an important distinction between a get/set property being absent, or being explicitly set to undefined.
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::getterObject):
(JSC::PropertyDescriptor::setterObject):
    - Accessors to convert the get/set property to an object pointer, converting undefined to 0.
(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):
    - Translate a getter/setter internally represented at 0 to undefined, indicating that it is present.
* runtime/PropertyDescriptor.h:
    - Declare getterObject/setterObject.

LayoutTests: 

* fast/js/Object-defineProperty-expected.txt:
* fast/js/script-tests/Object-defineProperty.js:
    - Update a couple of inaccurate tests (it is invalid for a property to have
      both a get: and value: field; AccessorDescritor properties do not have a
      writable property). Add more test cases.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fixes <http://webkit.org/b/76189>
[mac] When compiling WebCore with clang, llvm-gcc is used to generate derived sources

Reviewed by Mark Rowe.

* DerivedSources.make: Changed to use the CC environment variable instead of hardcoded gcc.
* WebCore.xcodeproj/project.pbxproj: Set the CC environment variable, if not already set,
according to TARGET_GCC_VERSION. CC is used by DerivedSources.make and some of the perl
scripts it invokes.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::StylePainterMobile::findComboButton):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/104829
https://bugs.webkit.org/show_bug.cgi?id=76188

it broke qt-minimal (Requested by loislo1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-12

* inspector/CodeGeneratorInspector.py:
(CodeGenerator):
(CodeGenerator.generate_type_builder):
(CodeGenerator.generate_type_builder.AdHocTypeContext):
(CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix):
(CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix):
(CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(CodeGenerator.generate_type_builder.AdHocTypeContext.call_generate_type_builder):
(CodeGenerator.register_use):
(RawTypesBinding):
(RawTypesBinding.get_code_generator):
(RawTypesBinding.get_in_c_type_text):
(RawTypesBinding.get_setter_value_expression_pattern):
(RawTypesBinding.reduce_to_raw_type):
(TypeData.__init__):
* inspector/InspectorValues.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=75883

Reviewed by Kenneth Rohde Christiansen.

Make sure masks and replica layers can access layerTreeTileClient. Let masks
have the right contents/visible rect so that they can render content tiles.
Default the mask's size to be the layer's size.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::setVisibleContentRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::updateTileBuffersRecursively):
(WebCore::WebGraphicsLayer::layerTreeTileClient):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::recreateBackingStoreIfNeeded):
(WebCore::WebGraphicsLayer::setLayerTreeTileClient):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebCore::WebGraphicsLayer::maskTarget):
(WebCore::WebGraphicsLayer::setMaskTarget):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=65532

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/source-url-comment.html

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::findMagicComment):
(WebCore::ContentSearchUtils::findSourceURL):
(WebCore::ContentSearchUtils::findSourceMapURL):
* inspector/ContentSearchUtils.h:

LayoutTests:

* inspector/debugger/source-url-comment-expected.txt: Added.
* inspector/debugger/source-url-comment.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::StylePainterMobile::findComboButton):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=75284

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-12
Reviewed by Yury Semikhatsky.

New classes are generated for ecah array type instance.

* inspector/CodeGeneratorInspector.py:
(ArrayBinding):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.call_generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_forward_declaration):
(ArrayBinding.get_code_generator.CodeGenerator.register_use):
(ArrayBinding.get_in_c_type_text):
(ArrayBinding.get_setter_value_expression_pattern):
(ArrayBinding.reduce_to_raw_type):
(RawTypeBinding):
(RawTypeBinding.__init__):
(RawTypeBinding.get_code_generator):
(RawTypeBinding.get_in_c_type_text):
(RawTypeBinding.get_setter_value_expression_pattern):
(RawTypeBinding.reduce_to_raw_type):
(TypeData.__init__):
(TypeData.get_binding):
* inspector/InspectorValues.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=75010

The string operations constantly performed in the mobile theme
to fetch or put controls in the pixmap cache can be pretty expensive.
The new mechanism harnesses the QPixmapCache::Key API instead.

Reviewed by Kenneth Rohde Christiansen.

No new tests, internal refactoring.

* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::qHash):
(WebCore::StylePainterMobile::findCachedControl):
(WebCore::StylePainterMobile::insertIntoCache):
(WebCore::StylePainterMobile::findCheckBox):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::findLineEdit):
(WebCore::StylePainterMobile::findPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::StylePainterMobile::drawSliderThumb):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::paintMenuList):
* platform/qt/RenderThemeQtMobile.h:
(WebCore::KeyIdentifier::KeyIdentifier):
(WebCore::KeyIdentifier::operator==):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/104805
https://bugs.webkit.org/show_bug.cgi?id=76180

Breaks apple win compilation. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-12

.:

* Source/autotools/symbols.filter:

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/SelectorQuery.cpp:
(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):
(WebCore::SelectorQuery::canUseIdLookup):
(WebCore::SelectorQuery::execute):
* dom/SelectorQuery.h:
* dom/ShadowContentElement.cpp:
(WebCore::ShadowContentElement::create):
(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::shouldInclude):
* dom/ShadowContentElement.h:
* dom/ShadowContentSelectorQuery.cpp: Removed.
* dom/ShadowContentSelectorQuery.h: Removed.
* dom/ShadowInclusionSelector.cpp:
(WebCore::ShadowInclusionSelector::select):
* dom/ShadowInclusionSelector.h:
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsContentElement::shouldInclude):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
(WebCore::DetailsSummaryElement::shouldInclude):
* html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
* testing/Internals.cpp:
(WebCore::Internals::createShadowContentElement):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* fast/dom/shadow/shadow-contents-select-expected.html: Removed.
* fast/dom/shadow/shadow-contents-select.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76175

Defining ENABLE_CSS_FILTERS leads to ambiguous references
due to MacTypes.h being included.
Defining CF_OPEN_SOURCE works around this problem.

Reviewed by Simon Hausmann.

* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76163

Reviewed by Tor Arne Vestbø.

.:

* WebKit.pro: Build the new WTF instead of the old one.

Source/JavaScriptCore:

* JavaScriptCore.pro: Removed wtf from the subdirs to build.

Source/WTF:

With this change the WTF sources are built _here_ but _from_ their old location using a VPATH.

* WTF.pri: Renamed from Source/JavaScriptCore/wtf/wtf.pri.
* WTF.pro: Renamed from Source/JavaScriptCore/wtf/wtf.pro.
* config.h: Bring this file in sync with JavaScriptCore/config.h with regards to the inclusion
/ definition of the export macros.

Tools:

* qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76042

Reviewed by Nikolas Zimmermann.

Source/WebCore: 

The width / height / wrap members are used by all threads
in the same time. The patch makes them local for all threads.

Fixes the layout fails in svg/dynamic-updates/SVGFETurbulence*

* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::noise2D):
(WebCore::Noise::if):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint):
(WebCore::FETurbulence::fillRegion):
* platform/graphics/filters/FETurbulence.h:
(WebCore::FETurbulence::PaintingData::PaintingData):
(WebCore::FETurbulence::StitchData::StitchData):

LayoutTests: 

Update mac expected files.

* platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
* platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Simon Hausmann.

Set the input method hints given the HTMLElement type and state.

* Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
* Shared/EditorState.h:
(WebKit::EditorState::EditorState):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::updateTextInputState):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76170

It was removed in order of transition from layout tests to perf tests.

Reviewed by Yury Semikhatsky.

PerformanceTests:

* inspector/console-300-lines.html: Added.

Source/WebCore:

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76071

Reviewed by Steve Block.

Source/WebCore:

Make sure that the text from speech input ends up in the correct
element even if focus has changed since the user clicked on it.

Test: fast/speech/change-focus.html

* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

LayoutTests:

Add test to make sure that the text from speech input ends up in the
correct element even if focus has moved away after the user clicked on it.

* fast/speech/change-focus-expected.txt: Added.
* fast/speech/change-focus.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:addMessageToConsole:withSource:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=74493

Unreviewed. Add flaky test to GTK's test_expectations.txt.

* platform/gtk/test_expectations.txt: Add flaky test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
* platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
* platform/chromium-win/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt:
* platform/chromium-win/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
* platform/mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
* platform/mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, rebaseline wk2 and http/tests/security/cross-frame-access-put.html test expectations after r104803.

* http/tests/security/cross-frame-access-put-expected.txt:
* platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt:
* platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove unnecessary "line 1" from expected files.

* platform/qt-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
* platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/gtk/plugins/invalidate-rect-with-null-npp-argument-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=76167

Reviewed by Csaba Osztrogonác.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::willAddMessageToConsole):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@104812 268f45cc-cd09-0410-ab3c-d52691b4dbfc