1. 06 Apr, 2012 35 commits
    • rwlbuis@webkit.org's avatar
      Fix cast-align warnings in JSC · 1cbadd97
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80790
      
      Reviewed by George Staikos.
      
      Source/JavaScriptCore:
      
      * assembler/ARMv7Assembler.h:
      (JSC::ARMv7Assembler::computeJumpType):
      (JSC::ARMv7Assembler::link):
      * assembler/LinkBuffer.h:
      (JSC::LinkBuffer::linkCode):
      * heap/MarkStack.cpp:
      (JSC::SlotVisitor::copyAndAppend):
      * runtime/JSArray.cpp:
      (JSC::JSArray::visitChildren):
      * wtf/RefCountedArray.h:
      (WTF::RefCountedArray::Header::payload):
      
      Source/WebCore:
      
      * platform/graphics/WOFFFileFormat.cpp:
      (WebCore::readUInt32):
      (WebCore::readUInt16):
      * platform/image-encoders/skia/JPEGImageEncoder.cpp:
      (WebCore::preMultipliedBGRAtoRGB):
      * platform/network/MIMESniffing.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cbadd97
    • darin@apple.com's avatar
      Streamline strtod and fix some related problems · 9be7456e
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=82857
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      * parser/Lexer.cpp:
      (JSC::Lexer<>::lex): Use parseDouble. Since we have already scanned the number
      and we know it has only correct characters, leading spaces, trailing junk, and
      trailing spaces are not a possibility. No need to add a trailing null character.
      
      * runtime/JSGlobalObjectFunctions.cpp:
      (JSC::parseInt): Changed overflow based 10 case to use parseDouble. No need
      to allow trailing junk since the code above already allows only numeric digits
      in the string. This code path is used only in unusual cases, so it's not
      optimized for 8-bit strings, but easily could be.
      (JSC::jsStrDecimalLiteral): Removed the allow trailing junk argument to this
      function template because all the callers are OK with trailing junk. Use the
      parseDouble function. No need to copy the data into a byte buffer, because
      parseDouble handles that.
      (JSC::toDouble): Got rid of the DisallowTrailingJunk argument to the
      jsStrDecimalLiteral function template. That's OK because this function
      already checks for trailing junk and handles it appropriately. The old code
      path was doing it twice.
      (JSC::parseFloat): Got rid of the AllowTrailingJunk argument to the
      jsStrDecimalLiteral function template; the template allows junk unconditionally.
      
      * runtime/LiteralParser.cpp:
      (JSC::::Lexer::lexNumber): Use parseDouble. Since we have already scanned the number
      and we know it has only correct characters, leading spaces, trailing junk, and
      trailing spaces are not a possibility. No need to add a trailing null character.
      No need to copy the data into a byte buffer, because parseDouble handles that.
      We could optimize the UChar case even more because we know all the characters
      are ASCII, but not doing that at this time.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated.
      
      Source/WebCore:
      
      Refactoring of code covered by existing tests.
      
      * dom/ViewportArguments.cpp:
      (WebCore::numericPrefix): Removed a confusing comment that just said
      "we tolerate extra characters" in a roundabout way. Made the "ok"
      argument optional. Changed to call the new version of charactersToFloat
      that returns the number of characters parsed rather than using the
      charactersToFloatIgnoringJunk/didReadNumber solution from before.
      (WebCore::findSizeValue): Since numericPrefix is guaranteed to return 0
      when it can't parse, removed the "ok" code. Also changed the unusual
      syntax "float(1.0)" to just "1", which works just as well.
      (WebCore::findScaleValue): Ditto.
      (WebCore::findUserScalableValue): Ditto.
      
      * html/parser/HTMLParserIdioms.cpp:
      (WebCore::parseToDoubleForNumberType): Removed an unneeded code path
      and replaced it with an assertion; toDouble no longer will return infinity
      or not-a-number values.
      
      Source/WTF:
      
      Replaced the strtod function template with a parseDouble function, eliminating
      the following unneeded features:
      
      - need for a trailing null character and a call to strlen
      - needless conversion of string lengths from size_t to int and back that created
        the possibility of incorrect truncation
      - one level of function call; use inlining instead
      - construction of the StringToDoubleConverter object; it was used to pass
        arguments that are known at compile time
      - most of the StringToDoubleConverter::StringToDouble function's body; it was
        code we did not need
      - parsing of Infinity and NaN at the strtod level; added recently when we moved
        from the old strtod to the new one, and not needed or helpful at this level
      - multiple copies of code to narrow to single byte strings; in many cases
        this was done even when starting with an LChar string that is already
        single-byte, now we handle this with an overload of parseDouble
      
      * wtf/dtoa.cpp:
      Removed a long comment about the original strtod function that no longer
      applies since we deleted that function long ago. Removed a lot of includes.
      Removed the strtod function templates and its instantiations, since they
      are now replaced by the parseDouble function.
      (WTF::Internal::parseDoubleFromLongString): Added.
      * wtf/dtoa.h:
      Added an include of ASCIICType.h so we can use isASCII in a function in this
      header. Left the heretofore unneeded include of double-conversion.h, since we
      now want to use it in a function in this header. Removed the AllowTrailingJunkTag
      and AllowTrailingSpacesTag enumerations and the strtod function template. Added
      new parseDouble function, and inline implementation of it.
      
      * wtf/dtoa/double-conversion.cc: Removed quite a bit of unused code, hardcoding
      all the StringToDouble function arguments that come from data members so it can
      be a much smaller static member function. Also changed the types of arguments
      from int to size_t.
      * wtf/dtoa/double-conversion.h: Removed most of the StringToDoubleConverter
      class, leaving only the conversion function as a static member function.
      
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::toDouble): Got rid of didReadNumber.
      (WTF::StringImpl::toFloat): Ditto.
      * wtf/text/StringImpl.h: Ditto.
      * wtf/text/WTFString.cpp:
      (WTF::String::toDouble): Got rid of didReadNumber.
      (WTF::String::toFloat): Ditto.
      (WTF::toDoubleType): Rewrote this function to use parseDouble. Moved the code
      to skip leading spaces here, because other callers of parseDouble don't want
      to do that. Repurposed the check for an empty string so it's now the same
      code shared by all the "parsed nothing" cases. Removed the code to convert
      the buffer to ASCII for two reasons: (1) We don't need that code at all when
      CharType is LChar, and (2) We now handle this through the two overloads for
      the parseDouble function. Disallowing trailing junk is now handled here,
      rather than inside parseDouble.
      (WTF::charactersToDouble): Updated for changes to toDoubleType. Removed the
      didReadNumber argument.
      (WTF::charactersToFloat): Ditto. Also added overloads that return the parsed
      length. These are a slightly more powerful way to do what didReadNumber was
      used for before.
      
      * wtf/text/WTFString.h: Added comments, eliminated didReadNumber, and added
      overloads of charactersToFloat that replace charactersToFloatIgnoringJunk.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9be7456e
    • commit-queue@webkit.org's avatar
      [chromium] Surface replica should have a separate quad in the render pass · 701d1bb7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83287
      
      Patch by Dana Jansens <danakj@chromium.org> on 2012-04-06
      Reviewed by Adrienne Walker.
      
      Generate separate quads for a RenderSurface and its replica. The replica
      quad is drawn independently of the surface itself. This allows us to
      cull each one independently.
      
      Covered by existing tests.
      
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
      (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
      * platform/graphics/chromium/cc/CCRenderPass.cpp:
      (WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
      * platform/graphics/chromium/cc/CCRenderSurface.cpp:
      (WebCore::CCRenderSurface::setScissorRect):
      (WebCore):
      (WebCore::CCRenderSurface::drawContents):
      (WebCore::CCRenderSurface::drawReplica):
      (WebCore::CCRenderSurface::hasReplica):
      * platform/graphics/chromium/cc/CCRenderSurface.h:
      (CCRenderSurface):
      * platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:
      (WebCore::CCRenderSurfaceDrawQuad::create):
      (WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):
      * platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:
      (CCRenderSurfaceDrawQuad):
      (WebCore::CCRenderSurfaceDrawQuad::isReplica):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      701d1bb7
    • schenney@chromium.org's avatar
      RenderSVGRoot should inherit from RenderReplaced · 8186e7b6
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76446
      
      Unreviewed Chromium expectations update.
      
      Second attempt, after the rebaseline tool put expectations in chromium-linux-x86 instead of chormium-linux.
      
      * platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
      * platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
      * platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
      * platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Removed.
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8186e7b6
    • paroga@webkit.org's avatar
      Remove JSC dependency from GregorianDateTime · feefd95a
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83290
      
      Reviewed by Geoffrey Garen.
      
      This allows us to move it to WTF later.
      
      * runtime/DateConstructor.cpp:
      (JSC::callDate):
      * runtime/JSDateMath.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      feefd95a
    • mrobinson@webkit.org's avatar
      [GObject bindings] Fix the coding style issues in the generated bindings · 10c17ef0
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82080
      
      Reviewed by Kentaro Hara.
      
      No new tests. This is covered by the binding tests.
      
      * bindings/scripts/CodeGeneratorGObject.pm: Fix most style errors in the generated
        GObject code.
      * bindings/scripts/test/GObject: Updated the expected results.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10c17ef0
    • adamk@chromium.org's avatar
      Remove bogus assert from ChildListMutationScope · a3557aa5
      adamk@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83336
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      This assert can trivially be triggered from script, but luckily the
      code already behaves correctly without it.
      
      * dom/ChildListMutationScope.cpp:
      (WebCore::ChildListMutationScope::MutationAccumulator::enqueueMutationRecord):
      
      LayoutTests:
      
      Added a test that would trigger the assert.
      
      * fast/mutation/observe-childList-expected.txt:
      * fast/mutation/observe-childList.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3557aa5
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r113442. · 047ecc8a
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/113442
      https://bugs.webkit.org/show_bug.cgi?id=83373
      
      for breaking JSC bindings compilation (Requested by pfeldman
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-06
      
      * GNUmakefile.list.am:
      * Target.pri:
      * UseJSC.cmake:
      * UseV8.cmake:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSMutationCallbackCustom.cpp: Added.
      (WebCore):
      (WebCore::JSMutationCallback::handleEvent):
      * bindings/scripts/CodeGenerator.pm:
      * bindings/scripts/CodeGeneratorJS.pm:
      (AddIncludesForTypeInImpl):
      (GenerateCallbackHeader):
      (GenerateCallbackImplementation):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateCallbackHeader):
      (GenerateCallbackImplementation):
      * bindings/scripts/test/JS/JSTestCallback.cpp:
      (WebCore::JSTestCallback::callbackWithBoolean):
      * bindings/scripts/test/JS/JSTestCallback.h:
      (JSTestCallback):
      * bindings/scripts/test/TestCallback.idl:
      * bindings/scripts/test/V8/V8TestCallback.cpp:
      (WebCore::V8TestCallback::callbackWithBoolean):
      * bindings/scripts/test/V8/V8TestCallback.h:
      (V8TestCallback):
      * bindings/v8/custom/V8MutationCallbackCustom.cpp: Added.
      (WebCore):
      (WebCore::V8MutationCallback::handleEvent):
      * dom/MutationCallback.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      047ecc8a
    • commit-queue@webkit.org's avatar
      [Gtk] Unskip the video track tests · f8edfd96
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82590
      
      Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-06
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Enable the video track runtime feature for the Gtk port as well.
      
      No new tests - existing ones will be unskipped.
      
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      (WebCore):
      
      LayoutTests:
      
      Unskip passing video track tests and update expectations
      where necessary.
      
      * platform/gtk/Skipped:
      * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8edfd96
    • msaboff@apple.com's avatar
      Call Heap::discardAllCompiledCode() in low memory situations · 03e811fc
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83335
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      Restructured Heap::discardAllCompiledCode() to do the "Is JavaScriptRunning?"
      check inline so that it can be called directly without this check.
      
      * heap/Heap.cpp:
      (JSC::Heap::discardAllCompiledCode):
      (JSC::Heap::collectAllGarbage):
      * heap/Heap.h: Added JS_EXPORT_PRIVATE to discardAllCompiledCode() so it can be
      called from WebCore.
      (Heap):
      * runtime/JSGlobalData.h: Removed unused " void discardAllCompiledCode()" declaration.
      (JSGlobalData):
      
      Source/WebCore: 
      
      Added call to discardAllCompiledCode() when under memory pressure.
      We can re-JIT as needed.  This is similar to what we used to do when we did
      a full GC which also cleaned up JIT code.  Doing a full GC typically didn't
      help our memory situation, in fact it made things worse in the really low
      memory situation as it caused more paging.
      
      Added pass through discardAllCompiledCode() method to GCController.
      
      * bindings/js/GCController.cpp:
      (WebCore::GCController::discardAllCompiledCode):
      (WebCore):
      * bindings/js/GCController.h:
      (GCController):
      * platform/mac/MemoryPressureHandlerMac.mm:
      (WebCore::MemoryPressureHandler::releaseMemory):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03e811fc
    • caseq@chromium.org's avatar
      Web Inspector: on a single click in Timeline overview, make a minimal... · fdc695c6
      caseq@chromium.org authored
      Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
      https://bugs.webkit.org/show_bug.cgi?id=82616
      
      Reviewed by Pavel Feldman.
      
      - center minimal selection on mouse cursor if the mouse hasn't moved (i.e. we had a click, not drag)
      
      * inspector/front-end/TimelineOverviewPane.js:
      (WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdc695c6
    • haraken@chromium.org's avatar
      Add CodeGenerator support for sequence<> in callbacks. · 882f5e3c
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83233
      
      Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-04-06
      Reviewed by Kentaro Hara.
      
      Tests: TestCallback.idl and fast/mutation/callback-arguments.html should pass even after
      the changes.
      
      * GNUmakefile.list.am: Removed unsued custom files V8MutationCallbackCustom.cpp
        and JSMutationCallbackCustom.cpp from builds.
      * Target.pri: Ditto.
      * UseJSC.cmake: Ditto.
      * UseV8.cmake: Ditto.
      * WebCore.gypi: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      * bindings/js/JSMutationCallbackCustom.cpp: Removed.
      * bindings/scripts/CodeGeneratorJS.pm:
      (AddIncludesForTypeInImpl): Add proper header type.
      (GenerateCallbackHeader): Generate declaration for the callback with sequence<T> argument.
      (GenerateCallbackImplementation): Generate implementation for the callback with sequence<T> argument.
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateCallbackHeader): Generate declaration for the callback with sequence<T> argument.
      (GenerateCallbackImplementation): Generate implementation for the callback with sequence<T> argument.
      * bindings/scripts/test/JS/JSTestCallback.cpp: Modified test results of run-bindings-tests.
      (WebCore):
      (WebCore::JSTestCallback::handleEvent):
      * bindings/scripts/test/JS/JSTestCallback.h: Modified test results of run-bindings-tests.
      (JSTestCallback):
      * bindings/scripts/test/TestCallback.idl: Added test callback with sequence<> argument.
      * bindings/scripts/test/V8/V8TestCallback.cpp: Modified test results of run-bindings-tests.
      (WebCore):
      (WebCore::V8TestCallback::handleEvent):
      * bindings/scripts/test/V8/V8TestCallback.h: Modified test results of run-bindings-tests.
      (V8TestCallback):
      * bindings/v8/custom/V8MutationCallbackCustom.cpp: Removed.
      * dom/MutationCallback.idl: Removed custom bindings using sequence<T>.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      882f5e3c
    • pfeldman@chromium.org's avatar
      Unreviewed, rolling out r113431. · a06a63f8
      pfeldman@chromium.org authored
      http://trac.webkit.org/changeset/113431
      https://bugs.webkit.org/show_bug.cgi?id=83372
      
      for breaking at least Chromium compilation (Requested by
      pfeldman on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-06
      
      * rendering/RenderView.cpp:
      (WebCore::RenderView::paint):
      (WebCore::RenderView::shouldRepaint):
      (WebCore::RenderView::repaintViewRectangle):
      (WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
      (WebCore::RenderView::computeRectForRepaint):
      (WebCore::RenderView::selectionBounds):
      (WebCore::RenderView::viewRect):
      (WebCore::RenderView::unscaledDocumentRect):
      * rendering/RenderView.h:
      (RenderView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a06a63f8
    • pfeldman@chromium.org's avatar
      Web Inspector: CodeGeneratorInspector.py: completely switch all domains to 'strict' mode · af108730
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83332
      
      Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-06
      Reviewed by Pavel Feldman.
      
      Hardcoded list of domains is removed from generator. Partial domain sorting is dropped as unneeded.
      Types with open propery list are introduced: validator allows undocumented properties for them.
      
      Timeline domain code is patched to do runtimeCast in the last moment because true switching to
      type-safe interfaces should take significant time and should be done separately.
      
      * inspector/CodeGeneratorInspector.py:
      (Generator.go):
      (Generator.process_event):
      (Generator.process_command):
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::willSendResourceRequest):
      (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af108730
    • schenney@chromium.org's avatar
      RenderSVGRoot should inherit from RenderReplaced · b8b467a9
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76446
      
      Unreviewed Chromium test expectations update.
      
      * platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-expected.png: Added.
      * platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
      * platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.png: Added.
      * platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
      * platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
      * platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.png: Added.
      * platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
      * platform/chromium-win-xp/svg/custom/mouse-move-on-svg-root-expected.png: Added.
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
      * platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.txt:
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8b467a9
    • pfeldman@chromium.org's avatar
      Web Inspector: CodeGeneratorInspector.py: stop accepting raw InspectorObject in generated setters · b77f5a46
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83327
      
      Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-06
      Reviewed by Pavel Feldman.
      
      Generator fixed to have strict types in generated setter methods.
      
      Client code is switched from InspectorObject's and String's to generated types where
      needed.
      
      * inspector/CodeGeneratorInspector.py:
      (AdHocTypeContext):
      (format_setter_value_expression):
      * inspector/ConsoleMessage.cpp:
      (WebCore::messageSourceValue):
      (WebCore::messageTypeValue):
      (WebCore::messageLevelValue):
      (WebCore::ConsoleMessage::addToFrontend):
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
      (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
      * inspector/InspectorApplicationCacheAgent.h:
      (InspectorApplicationCacheAgent):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::asInspectorStyleSheet):
      (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
      (WebCore::InspectorCSSAgent::detectOrigin):
      * inspector/InspectorCSSAgent.h:
      (InspectorCSSAgent):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::buildObjectForNode):
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore):
      * inspector/InspectorMemoryAgent.cpp:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::buildObjectForFrameTree):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::buildObjectForTiming):
      (WebCore::buildObjectForCachedResource):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyle::buildObjectForStyle):
      (WebCore::InspectorStyleSheet::create):
      (WebCore::InspectorStyleSheet::InspectorStyleSheet):
      (WebCore::InspectorStyleSheet::buildObjectForRule):
      (WebCore::InspectorStyleSheet::resourceStyleSheetText):
      (WebCore::InspectorStyleSheet::buildArrayForRuleList):
      (WebCore::InspectorStyleSheetForInlineStyle::create):
      (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
      * inspector/InspectorStyleSheet.h:
      (InspectorCSSId):
      (WebCore::InspectorCSSId::asProtocolValue): method is made template as now it returns 2 formally different types.
      (InspectorStyleSheet):
      (WebCore::InspectorStyleSheet::canBind):
      (InspectorStyleSheetForInlineStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b77f5a46
    • pfeldman@chromium.org's avatar
      Web Inspector: highlight diff in the gutter, not in the line content. · 650fff04
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83371
      
      Reviewed by Yury Semikhatsky.
      
      Now that the editing mode is enabled by default, diff highlighting gets annoying.
      I am moving it to the gutter (same decoration as before, but now coloring gutter only).
      
      * inspector/front-end/TextViewer.js:
      (WebInspector.TextEditorGutterPanel.prototype.textChanged):
      * inspector/front-end/textViewer.css:
      (.diff-container .webkit-added-line.webkit-line-number):
      (.diff-container .webkit-removed-line.webkit-line-number):
      (.diff-container .webkit-changed-line.webkit-line-number):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      650fff04
    • schenney@chromium.org's avatar
      Differentiate between SVG/CSS width/height attributes/properties · d8ecf346
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76447
      
      Unreviewed Chromium expectations update.
      
      * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-win-xp/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-win-xp/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
      * platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
      * platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
      * platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
      * platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
      * platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
      * platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
      * platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
      * platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8ecf346
    • pfeldman@chromium.org's avatar
      Web Inspector: remove url from the saved urls map before the save action. · c3bc6f3f
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83364
      
      Reviewed by Yury Semikhatsky.
      
      URL gets added back upon successful save anyways, but if user chooses cancel saving,
      we stop bugging him with the save-as dialog.
      
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkLogView.prototype._exportAll):
      (WebInspector.NetworkLogView.prototype._exportResource):
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
      (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):
      * inspector/front-end/TextViewer.js:
      (WebInspector.TextViewer.prototype._contextMenu):
      (WebInspector.TextViewer.prototype._commitEditing):
      * inspector/front-end/TimelineModel.js:
      (WebInspector.TimelineModel.prototype.saveToFile):
      * inspector/front-end/inspector.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3bc6f3f
    • caseq@chromium.org's avatar
      Web Inspector: display frame details in popover on frame strip in Timeline panel · d9eaa1ac
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83365
      
      Reviewed by Pavel Feldman.
      
      - added popovers for frame strips;
      - factored out generateAggregatedInfo for reuse in the above;
      - made frame event dividers thinner, darker and greyer.
      
      * English.lproj/localizedStrings.js: Added "FPS" and "Frame"
      * inspector/front-end/TimelineFrameController.js:
      (WebInspector.TimelineFrameController.prototype._flushFrame): added startTimeOffset.
      (WebInspector.TimelineFrameController.prototype._createSyntheticFrame): ditto.
      * inspector/front-end/TimelineModel.js:
      (WebInspector.TimelineModel.prototype._updateBoundaries):
      (WebInspector.TimelineModel.prototype.recordOffsetInSeconds):
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel.prototype._updateFrames): added link to frame to strip div.
      (WebInspector.TimelinePanel.prototype._refresh):
      (WebInspector.TimelinePanel.prototype._getPopoverAnchor): handle frame anchors separately.
      (WebInspector.TimelinePanel.prototype._mouseMove): ditto.
      (WebInspector.TimelinePanel.prototype._showPopover):
      * inspector/front-end/TimelinePresentationModel.js:
      (WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
      (WebInspector.TimelinePresentationModel._generateAggregatedInfo): factored out for reuse.
      (WebInspector.TimelinePresentationModel.generatePopupContentForFrame):
      * inspector/front-end/inspectorCommon.css:
      (.resources-dividers-label-bar):
      * inspector/front-end/timelinePanel.css:
      (.timeline .resources-event-divider.timeline-frame-divider): made divider thin and grey.
      (.timeline-frame-strip): bumped z-index, added pointer-events: auto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9eaa1ac
    • pfeldman@chromium.org's avatar
      Web Inspector: show "dirty" flag for CSS files edited in the resources panel. · 52da3bbf
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83363
      
      Reviewed by Yury Semikhatsky.
      
      Added TextEdited notification into the editable source frame, listening to it
      in the resources panel.
      
      * inspector/front-end/ResourceView.js:
      (WebInspector.EditableResourceSourceFrame.prototype._contentChanged):
      (WebInspector.EditableResourceSourceFrame.prototype.isDirty):
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.FrameResourceTreeElement.prototype._appendRevision):
      (WebInspector.FrameResourceTreeElement.prototype.sourceView):
      (WebInspector.FrameResourceTreeElement.prototype._sourceViewTextEdited):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52da3bbf
    • leviw@chromium.org's avatar
      Update LayoutUnit usage in RenderView · aba36ba0
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83147
      
      Reviewed by Julien Chaffraix.
      
      Updating the usage of LayoutUnits in RenderView in preparation for sub-pixel layout. This mostly
      affects paint and repaint functions, which take LayoutRects up to the RenderView level. This is
      necessary as we continue to accumulate sub-pixel offsets up to this level.
      
      No new tests. No change in behavior.
      
      * rendering/RenderView.cpp:
      (WebCore::RenderView::paint): Adding an assert that we're being called to paint on pixel
      boundaries. We don't currently ever position RenderViews at sub-pixel offsets.
      (WebCore::RenderView::shouldRepaint):
      (WebCore::RenderView::repaintViewRectangle): Switching to a LayoutRect and cleaning up a fixme
      that used decomposed offsets. Pixel snapping is applied before handing the rect up to the
      FrameView.
      (WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): Pixel snapping before handing
      the rect up to the Compositor.
      (WebCore::RenderView::computeRectForRepaint):
      (WebCore::RenderView::selectionBounds):
      (WebCore::RenderView::viewRect):
      (WebCore::RenderView::unscaledDocumentRect):
      * rendering/RenderView.h:
      (RenderView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aba36ba0
    • commit-queue@webkit.org's avatar
      [BlackBerry] Text selection - Can't select texts · 7023dcef
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83355
      
      Fix the problem of not sending out the result of the function
      SelectionHandler::regionForTextQuads(). This regression issue
      is introduced by the git commit f9446b7d.
      
      Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-04-06
      Reviewed by George Staikos.
      
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
          Add code to return the function result.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7023dcef
    • caseq@chromium.org's avatar
      Web Inspector: hide popover on mouseout from anchor · d938d0a8
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83362
      
      Reviewed by Pavel Feldman.
      
      - start hide popover timer when mouse moves out of popover anchor, as we won't receive mousemove events any more;
      - factored out starting of popover kill timer to a method.
      
      * inspector/front-end/Popover.js:
      (WebInspector.PopoverHelper):
      (WebInspector.PopoverHelper.prototype._mouseMove): Factored out StartHidePopoverTimer()
      (WebInspector.PopoverHelper.prototype._mouseOut): Just call StartHidePopoverTimer() when mouse moves out of anchor.
      (WebInspector.PopoverHelper.prototype._startHidePopoverTimer.doHide):
      (WebInspector.PopoverHelper.prototype._startHidePopoverTimer):
      (WebInspector.PopoverHelper.prototype._hidePopover): Reset hoverElement (aka anchor) when hiding popover.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d938d0a8
    • ossy@webkit.org's avatar
      [Qt] Unskipped some tests that now pass. · be92d27a
      ossy@webkit.org authored
      Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-06
      Reviewed by Csaba Osztrogonác.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be92d27a
    • caseq@chromium.org's avatar
      [Chromium] Web Inspector: getEventListeners(window) crashes on NTP · da5ed723
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83353
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
      (WebCore::V8InjectedScriptHost::getEventListenersCallback):
      
      LayoutTests:
      
      * inspector/console/command-line-api-getEventListeners-expected.txt:
      * inspector/console/command-line-api-getEventListeners.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da5ed723
    • tkent@chromium.org's avatar
      Touch ChromeClient.h to fix Chromium build. · 748ff745
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83258
      
      * page/ChromeClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      748ff745
    • ossy@webkit.org's avatar
      [Qt][Mac] Skip new failing tests to paing the bot green. · d024d2fd
      ossy@webkit.org authored
      * platform/qt-mac/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d024d2fd
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening. · d0d42416
      ossy@webkit.org authored
      * platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
      * platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
      * platform/qt-arm/Skipped: Skip new failing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0d42416
    • tkent@chromium.org's avatar
      Initial LocalizedDateICU.cpp implementation · a21d73a5
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=60868
      
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      Add LocalizedDateICU.cpp, which supports only Date type.  It uses a
      short format because a date field is keyboard-editable.
      e.g. 5/15/11 in US locale.
      
      * WebCore.gyp/WebCore.gyp: Exclude LocalizedDateNone.cpp.
      * WebCore.gypi: Add LocalizedDateICU.cpp.
      * platform/text/LocalizedDateICU.cpp: Added.
      (WebCore::parseLocalizedDate):
      (WebCore::formatLocalizedDate):
      
      LayoutTests:
      
      * platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt:
      * platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a21d73a5
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, update platform specific expected results. · 7d629290
      ossy@webkit.org authored
      * platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
      * platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
      * platform/qt/svg/as-object/object-box-sizing-no-width-height-expected.txt:
      * platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
      * platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d629290
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening. · de32ed43
      ossy@webkit.org authored
      * platform/qt/Skipped: Unskip tests after r113323.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de32ed43
    • apavlov@chromium.org's avatar
      [REGRESSION] Refreshed autofill popup renders garbage · 66a16fbf
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83255
      http://code.google.com/p/chromium/issues/detail?id=118374
      
      The code used to update only the PopupContainer coordinates as if they were the coordinates relative
      to the root view. Instead, a WebWidget positioned relative to the screen origin holds the PopupContainer,
      so it is the WebWidget that should be positioned in PopupContainer::refresh(), and the PopupContainer's
      location should be (0, 0) (and their sizes should always be equal).
      
      Reviewed by Kent Tamura.
      
      No new tests, as the popup appearance is not testable in WebKit.
      
      * platform/chromium/PopupContainer.cpp:
      (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Variable renamed.
      (WebCore::PopupContainer::showPopup): Use m_originalFrameRect rather than frameRect()
      for passing into chromeClient.
      (WebCore::PopupContainer::showInRect): Set up the correct frameRect() for the container.
      (WebCore::PopupContainer::refresh): Resize the container and position the WebWidget correctly.
      * platform/chromium/PopupContainer.h:
      (PopupContainer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66a16fbf
    • zherczeg@webkit.org's avatar
      [Qt] Unreviewed gardening after r113378. ENABLE(MUTATION_OBSERVERS) is disabled so · 74af8a4d
      zherczeg@webkit.org authored
      fast/mutation/clear-transient-without-delivery.html and
      fast/mutation/transient-gc-crash.html have been skipped.
      
      Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-06
      Reviewed by Zoltan Herczeg.
      
      * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74af8a4d
    • tkent@chromium.org's avatar
      Calendar Picker: Add code to open/close the calendar picker · 12262ad3
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83258
      
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      No new tests. This code is not used because of no ENABLE_INPUT_TYPE_DATE.
      
      * WebCore.gypi: Add existing header files.
      
      * html/DateInputType.cpp:
      (WebCore::DateInputType::DateInputType):
      Moved from DateInputType.h because the constructor depends on
      CalendarPickerElement.
      (WebCore::DateInputType::createShadowSubtree):
      Store a CalendarPickerElement object.
      (WebCore::DateInputType::destroyShadowSubtree):
      Release the CalendarPickerElement object.
      (WebCore::DateInputType::handleBlurEvent):
      Close the calendar picker when the input loses focus.
      * html/DateInputType.h:
      (DateInputType):
      - Move the constructor definition to DateInputType.cpp
      - Add function declarations
      - Add m_pickerElement data member.
      
      * html/shadow/CalendarPickerElement.cpp:
      (WebCore::CalendarPickerElement::hostInput): A helper to get the host <input>.
      (WebCore::CalendarPickerElement::defaultEventHandler):
      If the element is clicked, open a calendar picker.
      (WebCore::CalendarPickerElement::openPopup):
      Opens a calendar picker by ChromeClient::openPagePopup().
      (WebCore::CalendarPickerElement::closePopup):
      Closes a calendar picker by ChromeClient::closePagePopup().
      (WebCore::CalendarPickerElement::detach):
      Closes a calendar picker when the element loses a renderer.
      
      (WebCore::CalendarPickerElement::contentSize):
      Provides the initial size of a popup.
      (WebCore::addString): A helper for writeDocument().
      (WebCore::addJavaScriptString): ditto.
      (WebCore::addProperty): ditto.
      (WebCore::CalendarPickerElement::writeDocument):
      Provides the source of a popup. The function creates a complete HTML with:
      - WebCore/Resources/calendarPicker.css
      - WebCore/Resources/calendarPicker.js
      - An object to pass localization strings and <input> state
      (WebCore::CalendarPickerElement::setValueAndClosePopup):
      Sets the value from a calendar picker to the <input>.
      (WebCore::CalendarPickerElement::didClosePopup):
      Clear the popup object.
      * html/shadow/CalendarPickerElement.h:
      (CalendarPickerElement): Add declarations.
      
      * platform/text/LocalizedCalendarICU.cpp:
      (WebCore::getFirstDayOfWeek): Make sure this is 0-base. UCAL_SUNDAY is 1.
      
      Source/WebKit/chromium:
      
      * features.gypi: Enable ENABLE_PAGE_POPUP for non-Android
      platforms. This is needed because ENABLE_CALENDAR_PICKER now depends on
      ENABLE_PAGE_POPUP.
      * src/ChroemClientImpl.cpp: Add stubs.
      (WebKit::ChromeClientImpl::openPagePopup):
      (WebKit::ChromeClientImpl::closePagePopup):
      * src/ChromeClientImpl.h: Add declarations of openPagePopup() and closePagePopup().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12262ad3
  2. 05 Apr, 2012 5 commits
    • adele@apple.com's avatar
      <rdar://problem/11133179> and https://bugs.webkit.org/show_bug.cgi?id=74129 · 1e665bb2
      adele@apple.com authored
      REGRESSION (SnowLeopard, 5.1.4): All WK2 horizontal scrollbars look broken
      
      Patch by Dan Bernstein, Reviewed by Beth Dakin.
      
      This code assumed that the current CTM wouldn't have extraneous operations built into it, 
      but this bug is evidence that that assumption was wrong. We should just get the base CTM instead 
      and apply the device scale factor to it.
      
      No tests added since the SnowLeopard-style scrollbars aren't testable in our regression tests right now.
      
      * platform/graphics/GraphicsContext.cpp:
      (WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
      (WebCore::GraphicsContext::applyDeviceScaleFactor):
      * platform/graphics/GraphicsContext.h: (GraphicsContext):
      * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e665bb2
    • yutak@chromium.org's avatar
      Leak in WebSocketChannel with workers/worker-reload.html · 4d651e67
      yutak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83345
      
      Reviewed by David Levin.
      
      A speculative fix of memory leaks caused by worker-reload.html.
      
      No new tests, as this change imposes no functional change.
      
      * Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
      (WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
      Receive the peer as PassOwnPtr<> so the destructor of the task object can
      delete the peer even if the task didn't run before main thread's cleanup period.
      (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
      * Modules/websockets/WorkerThreadableWebSocketChannel.h:
      (WorkerThreadableWebSocketChannel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d651e67
    • commit-queue@webkit.org's avatar
      combine two arrays (coreExceptionNames and coreExceptionDescriptions) into one array · 1e429cdc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83141
      
      Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-05
      Reviewed by Adam Barth.
      
      No new tests required.
      
      * dom/DOMCoreException.cpp:
      (CoreException):
      (WebCore):
      (WebCore::DOMCoreException::initializeDescription):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e429cdc
    • mrobinson@webkit.org's avatar
      Rebaseline a couple tests for GTK+. · ca9196cf
      mrobinson@webkit.org authored
      * platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
      * platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca9196cf
    • rakuco@webkit.org's avatar
      [EFL] Gardening; update expctations in fast/css-generated-content. · 5e7a253f
      rakuco@webkit.org authored
      Mostly adapt to the size changes after the jhbuild and font
      commits.
      
      * platform/efl/fast/css-generated-content/003-expected.txt:
      * platform/efl/fast/css-generated-content/009-expected.png:
      * platform/efl/fast/css-generated-content/009-expected.txt:
      * platform/efl/fast/css-generated-content/013-expected.png:
      * platform/efl/fast/css-generated-content/013-expected.txt:
      * platform/efl/fast/css-generated-content/014-expected.png:
      * platform/efl/fast/css-generated-content/014-expected.txt:
      * platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.png:
      * platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.txt:
      * platform/efl/fast/css-generated-content/inline-display-types-expected.png:
      * platform/efl/fast/css-generated-content/inline-display-types-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e7a253f