1. 03 Jan, 2012 40 commits
    • dslomov@google.com's avatar
      Unreviewed: files bug CR109068 for appcache/interrupted-update.html crash. · 1c9ec2bf
      dslomov@google.com authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c9ec2bf
    • ojan@chromium.org's avatar
      Increment the code-review.js version number to bust browser · d7a50ecd
      ojan@chromium.org authored
      caches.
      
      * PrettyPatch/PrettyPatch.rb:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7a50ecd
    • jochen@chromium.org's avatar
      When showing results.html pass a correct URL to webbrowser.open · f89aa933
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75438
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/common/system/filesystem.py:
      (file_path_as_url):
      * Scripts/webkitpy/common/system/filesystem_mock.py:
      (file_path_as_url):
      * Scripts/webkitpy/common/system/filesystem_unittest.py:
      (test_file_path_as_url):
      * Scripts/webkitpy/layout_tests/port/base.py:
      (show_results_html_file):
      * Scripts/webkitpy/layout_tests/port/win_unittest.py:
      (test_show_results_html_file):
      * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
      (test_results_directory_relative):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f89aa933
    • ojan@chromium.org's avatar
      shrink the header on the flakiness dashboard · 9045a7f2
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65153
      
      Reviewed by Adam Roben.
      
      Move some of the "show" links to be to the right of the header
      instead of below the header when they content they're showing
      is hidden. That way we don't waste vertical space on them.
      
      No new tests. This code is covered by existing tests.
      
      * TestResultServer/static-dashboards/flakiness_dashboard.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9045a7f2
    • fpizlo@apple.com's avatar
      REGRESSION (r98196-98236): Incorrect layout of iGoogle with RSS feeds · 4c09900b
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75303
      <rdar://problem/10633533>
      
      Source/JavaScriptCore: 
      
      Reviewed by Gavin Barraclough.
              
      The this argument was not being kept alive in some cases during inlining and intrinsic
      optimizations.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::handleCall):
      (JSC::DFG::ByteCodeParser::emitFunctionCheck):
      (JSC::DFG::ByteCodeParser::handleInlining):
      
      LayoutTests: 
      
      Reviewed by Gavin Barraclough.
      
      * fast/js/dfg-inline-unused-this-expected.txt: Added.
      * fast/js/dfg-inline-unused-this-method-check-expected.txt: Added.
      * fast/js/dfg-inline-unused-this-method-check.html: Added.
      * fast/js/dfg-inline-unused-this.html: Added.
      * fast/js/dfg-intrinsic-unused-this-expected.txt: Added.
      * fast/js/dfg-intrinsic-unused-this-method-check-expected.txt: Added.
      * fast/js/dfg-intrinsic-unused-this-method-check.html: Added.
      * fast/js/dfg-intrinsic-unused-this.html: Added.
      * fast/js/script-tests/dfg-inline-unused-this-method-check.js: Added.
      (foo):
      (bar):
      (baz):
      * fast/js/script-tests/dfg-inline-unused-this.js: Added.
      (foo):
      (bar):
      (baz):
      * fast/js/script-tests/dfg-intrinsic-unused-this-method-check.js: Added.
      (bar):
      (baz):
      * fast/js/script-tests/dfg-intrinsic-unused-this.js: Added.
      (bar):
      (baz):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c09900b
    • tony@chromium.org's avatar
      [chromium] Fix compilation with clang and the shared build · eb349805
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75492
      
      Reviewed by Ojan Vafai.
      
      * WebKit.gyp: Turn off -Wglobal-constructors because test files using
      GTEST have global constructors.
      * tests/InnerGestureRecognizerTest.cpp:
      (TEST_F): Move global into test function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb349805
    • commit-queue@webkit.org's avatar
      v8 binding: npCreateV8ScriptObject() should not returned an existing... · 6bdb0925
      commit-queue@webkit.org authored
      v8 binding: npCreateV8ScriptObject() should not returned an existing V8NPObject if the rootObject doesn't match
      https://bugs.webkit.org/show_bug.cgi?id=74515
      
      Patch by Yuzhu Shen <yzshen@chromium.org> on 2012-01-03
      Reviewed by Nate Chapin.
      
      Source/WebCore:
      
      Test: http/tests/plugins/create-v8-script-objects.html
      
      * bindings/v8/NPV8Object.cpp:
      (WebCore::freeV8NPObject):
      (WebCore::npCreateV8ScriptObject):
      
      LayoutTests:
      
      * http/tests/plugins/create-v8-script-objects-expected.txt: Added.
      * http/tests/plugins/create-v8-script-objects.html: Added.
      * http/tests/plugins/resources/create-v8-script-objects-iframe.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bdb0925
    • enne@google.com's avatar
      [chromium] Revert accidentally removed chrome client compositing check · 4c831a9b
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75500
      
      Reviewed by James Robinson.
      
      This check was overzealously removed in r103968 as a part of
      re-enabling compositing for RTL pages. Add it back.
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::allowedCompositingTriggers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c831a9b
    • barraclough@apple.com's avatar
      Windows build fix. · a22a6952
      barraclough@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a22a6952
    • jonlee@apple.com's avatar
      Leak of WebNotificationClient when page is destroyed · 1039d923
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=74980
      <rdar://problem/10611231>
      
      Reviewed by Mark Rowe.
      
      Source/WebCore:
      
      * notifications/NotificationController.cpp:
      (WebCore::NotificationController::~NotificationController): Notify the client
      that the controller has been destroyed.
      * notifications/NotificationPresenter.h: Add notificationControllerDestroyed()
      callback to the client interface.
      
      Source/WebKit:
      
      * blackberry/WebCoreSupport/NotificationPresenterImpl.cpp:
      (WebKit::NotificationPresenterImpl::notificationControllerDestroyed): Empty implementation, because ownership
      model differs.
      * blackberry/WebCoreSupport/NotificationPresenterImpl.h:
      
      Source/WebKit/chromium:
      
      * src/NotificationPresenterImpl.cpp:
      (WebKit::NotificationPresenterImpl::notificationControllerDestroyed): Empty implementation because ownership
      model differs.
      * src/NotificationPresenterImpl.h:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/NotificationPresenterClientEfl.cpp:
      (WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed): Stub implementation, because
      the notification presenter is unimplemented.
      * WebCoreSupport/NotificationPresenterClientEfl.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebNotificationClient.h:
      * WebCoreSupport/WebNotificationClient.mm:
      (WebNotificationClient::notificationControllerDestroyed): Remove the instance.
      
      Source/WebKit/qt:
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::notificationControllerDestroyed): Empty implementation, because
      ownership model differs.
      * WebCoreSupport/NotificationPresenterClientQt.h:
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebNotificationClient.cpp:
      (WebKit::WebNotificationClient::notificationControllerDestroyed): Delete the instance.
      * WebProcess/WebCoreSupport/WebNotificationClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1039d923
    • alexis.menard@openbossa.org's avatar
      getComputedStyle for list-style is not implemented. · bd8fed80
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75443
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Implement getComputedStyle for list-style.
      
      Test: fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      LayoutTests:
      
      Add new tests to make sure we return the correct values.
      
      * fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt: Added.
      * fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd8fed80
    • tony@chromium.org's avatar
      [chromium] Unreviewed, rebaseline of svg/hixie/text/003.html. It · 9ef215b9
      tony@chromium.org authored
      doesn't look flaky on the flakiness dashboard.
      
      * platform/chromium-linux/svg/hixie/text/003-expected.png: Added.
      * platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.
      * platform/chromium-mac-snowleopard/svg/hixie/text/003-expected.png: Added.
      * platform/chromium-mac/svg/hixie/text/003-expected.png: Removed.
      * platform/chromium-win/svg/hixie/text/003-expected.png: Added.
      * platform/chromium-win/svg/hixie/text/003-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ef215b9
    • enne@google.com's avatar
      [chromium] Remove unneeded content vs. layer space distinction in tiled layers · 8c74d832
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75498
      
      Reviewed by James Robinson.
      
      Long ago, before scrollbars became their own layers, tiled layers had
      a distinction between content space (what's mostly called layer space
      elsewhere) and layer space (the transformed content space). It seemed
      like this transform could get reused for supporting RTL pages, but as
      that's not the case, it should be eradicated.
      
      Tiled layers now deal with everything in "layer space", which is a 2d
      rectangle starting at (0, 0) in the top left of the layer and
      extending to contentBounds() in the bottom right.
      
      As no code actually set the tiler position, this change should be a
      no-op.
      
      Test: LayoutTests/compositing/
      
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::UpdatableTile::isDirty):
      (WebCore::UpdatableTile::clearDirty):
      (WebCore::TiledLayerChromium::updateCompositorResources):
      (WebCore::TiledLayerChromium::createTile):
      (WebCore::TiledLayerChromium::invalidateRect):
      (WebCore::TiledLayerChromium::protectTileTextures):
      (WebCore::TiledLayerChromium::prepareToUpdateTiles):
      (WebCore::TiledLayerChromium::prepareToUpdate):
      (WebCore::TiledLayerChromium::prepareToUpdateIdle):
      (WebCore::TiledLayerChromium::needsIdlePaint):
      (WebCore::TiledLayerChromium::idlePaintRect):
      * platform/graphics/chromium/TiledLayerChromium.h:
      * platform/graphics/chromium/cc/CCLayerTilingData.cpp:
      (WebCore::CCLayerTilingData::operator=):
      (WebCore::CCLayerTilingData::layerRectToTileIndices):
      (WebCore::CCLayerTilingData::tileRect):
      * platform/graphics/chromium/cc/CCLayerTilingData.h:
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      (WebCore::CCTiledLayerImpl::appendQuads):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c74d832
    • jamesr@google.com's avatar
      [chromium] Remove WebLayerClient · 727ae2f0
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75481
      
      Reviewed by Darin Fisher.
      
      * WebKit.gyp:
      * public/platform/WebContentLayer.h:
      * public/platform/WebExternalTextureLayer.h:
      * public/platform/WebLayer.h:
      * public/platform/WebLayerClient.h: Removed.
      * src/WebContentLayer.cpp:
      * src/WebExternalTextureLayer.cpp:
      * src/WebLayer.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      727ae2f0
    • barraclough@apple.com's avatar
      Windows build fix. · 58bd432d
      barraclough@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58bd432d
    • enne@google.com's avatar
      [chromium] Support RTL pages and elements in the compositor · ca98f6dd
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56591
      
      Reviewed by James Robinson.
      
      Source/WebKit/chromium:
      
      As the noncomposited content host layer is created and managed by the
      Chromium compositor, adjust its transform appropriately in the layer
      tree and at paint time to handle the offset required due to the
      initial containing block of RTL pages.
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::allowedCompositingTriggers):
      * src/NonCompositedContentHost.cpp:
      (WebKit::NonCompositedContentHost::setViewport):
      (WebKit::NonCompositedContentHost::paintContents):
      * src/NonCompositedContentHost.h:
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::updateLayerTreeViewport):
      
      LayoutTests:
      
      Re-enable RTL tests for Chromium.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca98f6dd
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=75140 · cf553561
      barraclough@apple.com authored
      Reviewed by Sam Weinig.
      
      Rewrite JSArray::putSlowCase to be much cleaner & simpler.
      
      This rewrite only significantly changes behaviour for sparse array, specifically
      in how sparse arrays are reified back to vector form. This does not affect arrays
      with less than 10000 entries (since these always use a vector). The more common
      cases of sparse array behavior (though large sparse arrays are rare) - arrays that
      always remain sparse, and arrays that are filled in reverse sequential order -
      should be just as fast or faster (since reification is simpler & no longer
      requires map lookups) after these changes.
      
      Simplifying this code allows all cases of putByIndex that need to grow the vector
      to do so via increaseVectorLength, which means that this method can encapsulate
      the policy of determining how the vector should be grown.
      
      No performance impact.
      
      * runtime/JSArray.cpp:
      (JSC::isDenseEnoughForVector):
          - any array of length <= MIN_SPARSE_ARRAY_INDEX is dense enough for a vector.
      (JSC::JSArray::putByIndex):
          - simplify & comment.
      (JSC::JSArray::putByIndexBeyondVectorLength):
          - Re-written to be much clearer & simpler.
      (JSC::JSArray::increaseVectorLength):
      (JSC::JSArray::increaseVectorPrefixLength):
          - add explicit checks against MAX_STORAGE_VECTOR_LENGTH, so clients do not need do so.
      (JSC::JSArray::push):
          - simplify & comment.
      * runtime/JSArray.h:
          - removed SparseArrayValueMap::take.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf553561
    • barraclough@apple.com's avatar
      Windows build fix. · e67eb327
      barraclough@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e67eb327
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=75140 · 535d8bb7
      barraclough@apple.com authored
      Reviewed by Sam Weinig.
      
      Simplify JSArray creation - remove ArgsList/JSValue* create methods
      (this functionality can be implemented in terms of tryCreateUninitialized).
      
      * JavaScriptCore.exp:
      * runtime/ArrayConstructor.cpp:
          - use constructArray/constructEmptyArray instead of calling JSArray::create directly
      (JSC::constructArrayWithSizeQuirk):
      * runtime/JSArray.cpp:
      * runtime/JSArray.h:
          - removed ArgsList/JSValue* create methods
      * runtime/JSGlobalObject.h:
      (JSC::constructEmptyArray):
      (JSC::constructArray):
          - changed to be implemented in terms of JSArray::tryCreateUninitialized
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      535d8bb7
    • rniwa@webkit.org's avatar
      Add a tool to analyze change logs · c333760f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72243
      
      Reviewed by Eric Seidel.
      
      Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
      in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
      for visualizing json files.
      
      Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
      where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
      generates json files, and N is the number of changelogs to parse.
      
      * Scripts/webkitpy/common/config/contributionareas.py: Added names().
      * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
      * Scripts/webkitpy/tool/commands/__init__.py:
      * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
      * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
      * Scripts/webkitpy/tool/commands/data/summary.html: Added.
      * Scripts/webkitpy/tool/steps/options.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c333760f
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=75429 · bfdffec8
      barraclough@apple.com authored
      ThrowTypeError should be a singleton object
      
      Reviewed by Sam Weinig.
      
      Source/JavaScriptCore: 
      
      Per section 13.2.3 of the spec.
      We could change setAccessorDescriptor to be able to share the global
      GetterSetter object, rather than storing the accessor functions and
      creating a new GetterSetter in defineProperty - but this won't be a
      small change to PropertyDescriptors (and would probably mean making
      GetterSetter objects immutable?) - so I'll leave that for another
      patch.
      
      * JavaScriptCore.exp:
          - don't export setAccessorDescriptor
      * runtime/Arguments.cpp:
      (JSC::Arguments::createStrictModeCallerIfNecessary):
      (JSC::Arguments::createStrictModeCalleeIfNecessary):
          - call throwTypeErrorGetterSetter instead of createTypeErrorFunction
      * runtime/Error.cpp:
      * runtime/Error.h:
          - remove createTypeErrorFunction
      * runtime/JSFunction.cpp:
      * runtime/JSFunction.h:
          - remove unused createDescriptorForThrowingProperty
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::reset):
      (JSC::JSGlobalObject::visitChildren):
          - removed m_strictModeTypeErrorFunctionStructure.
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::internalFunctionStructure):
          - removed m_strictModeTypeErrorFunctionStructure.
      * runtime/PropertyDescriptor.cpp:
      (JSC::PropertyDescriptor::setAccessorDescriptor):
          - changed to take a GetterSetter
      * runtime/PropertyDescriptor.h:
          - changed to take a GetterSetter
      
      LayoutTests: 
      
      Per section 13.2.3 of the spec.
      
      * fast/js/basic-strict-mode-expected.txt:
          - ThrowTypeError is a singleton, so cannot generate
            property-specific error messages.
      * fast/js/script-tests/strict-throw-type-error.js: Added.
      * fast/js/strict-throw-type-error-expected.txt: Added.
      * fast/js/strict-throw-type-error.html: Added.
          - added test case that ThrowTypeError is a singleton
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfdffec8
    • joepeck@webkit.org's avatar
      <http://webkit.org/b/59951> Implement Date and Time Input Value Sanitization · 0a776807
      joepeck@webkit.org authored
      Source/WebCore:
      
      Sanitize non-parsable incoming strings to the empty string.
      
      Reviewed by Kent Tamura.
      
      Covered by existing tests.
      
      * html/BaseDateAndTimeInputType.h:
      * html/BaseDateAndTimeInputType.cpp:
      (WebCore::BaseDateAndTimeInputType::sanitizeValue): check if the
      incoming string is valid. If not just return the empty string.
      
      LayoutTests:
      
      Update ValidityState typeMismatch tests for date types, since
      setting an invalid value now sanitized to the empty string.
      So, what used to be an invalid value with a typeMismatch is
      now a valid empty string and there is never a typeMismatch.
      
        - for rangeOverflow / rangeUnderflow tests update the
          test to point out when a value was sanitized.
        - for typeMismatch tests, typeMismatch can no longer
          happen for sanitized values. Change the test to output
          if the value was sanitized or not and ensure that
          we are never in a typeMismatch state. Disabled inputs
          are also sanitized when their value changes.
      
      Reviewed by Kent Tamura.
      
      * fast/forms/date/ValidityState-rangeOverflow-date-expected.txt:
      * fast/forms/date/ValidityState-rangeOverflow-date.html:
      * fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt:
      * fast/forms/date/ValidityState-rangeUnderflow-date.html:
      * fast/forms/date/ValidityState-typeMismatch-date-expected.txt:
      * fast/forms/date/ValidityState-typeMismatch-date.html:
      * fast/forms/datetime/ValidityState-rangeOverflow-datetime-expected.txt:
      * fast/forms/datetime/ValidityState-rangeOverflow-datetime.html:
      * fast/forms/datetime/ValidityState-rangeUnderflow-datetime-expected.txt:
      * fast/forms/datetime/ValidityState-rangeUnderflow-datetime.html:
      * fast/forms/datetime/ValidityState-typeMismatch-datetime-expected.txt:
      * fast/forms/datetime/ValidityState-typeMismatch-datetime.html:
      * fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt:
      * fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html:
      * fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt:
      * fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html:
      * fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal-expected.txt:
      * fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html:
      * fast/forms/month/ValidityState-rangeOverflow-month-expected.txt:
      * fast/forms/month/ValidityState-rangeOverflow-month.html:
      * fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt:
      * fast/forms/month/ValidityState-rangeUnderflow-month.html:
      * fast/forms/month/ValidityState-typeMismatch-month-expected.txt:
      * fast/forms/month/ValidityState-typeMismatch-month.html:
      * fast/forms/time/ValidityState-rangeOverflow-time-expected.txt:
      * fast/forms/time/ValidityState-rangeOverflow-time.html:
      * fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt:
      * fast/forms/time/ValidityState-rangeUnderflow-time.html:
      * fast/forms/time/ValidityState-typeMismatch-time-expected.txt:
      * fast/forms/time/ValidityState-typeMismatch-time.html:
      * fast/forms/week/ValidityState-rangeOverflow-week-expected.txt:
      * fast/forms/week/ValidityState-rangeOverflow-week.html:
      * fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt:
      * fast/forms/week/ValidityState-rangeUnderflow-week.html:
      * fast/forms/week/ValidityState-typeMismatch-week-expected.txt:
      * fast/forms/week/ValidityState-typeMismatch-week.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a776807
    • weinig@apple.com's avatar
      Remove unnecessary forward declaration of Function · 548c2605
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75485
      
      Reviewed by Dan Bernstein.
      
      * Platform/WorkQueue.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      548c2605
    • jchaffraix@webkit.org's avatar
      RenderLayer::backgroundClipRect should not check parent() · 7aeef9de
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73731
      
      Reviewed by Simon Fraser.
      
      Clean-up only, no expected change in behavior.
      
      * rendering/RenderLayer.cpp:
      (WebCore::backgroundClipRectForPosition): Changed RenderObject::isPositioned() to
      a check for AbsolutePosition for consistency but also as this is equivalent due to:
      - the previous check for FixedPosition.
      - RenderView, which is positioned, will never goes to this code as it has no parent().
      
      (WebCore::RenderLayer::backgroundClipRect): Removed the parent() check. While at
      it, also moved the inline initialization of |backgroundClipRect| to its own function
      and removed a |view| check as the associated ASSERT seems to never have been reached.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7aeef9de
    • ap@apple.com's avatar
      <rdar://problem/10637779> REGRESSION (r102247): Focus ring is not drawn around a button · 76428a1f
      ap@apple.com authored
              Rubber-stamped by Dan Bernstein.
      
              * platform/mac/ThemeMac.mm: (WebCore::updateStates): Flip an incorrect conditional, this code
              should run on Snow Leopard and Lion.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76428a1f
    • alexis.menard@openbossa.org's avatar
      Source/WebCore: getComputedStyle should return shorthands property with the... · d8e1f645
      alexis.menard@openbossa.org authored
      Source/WebCore: getComputedStyle should return shorthands property with the minimum number of sides possible.
      https://bugs.webkit.org/show_bug.cgi?id=75434
      
      Reviewed by Tony Chang.
      
      As stated in http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
      return shorthands properties with the minimum number of sides possible.
      
      Existing tests have been updated accordingly.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      (WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
      * css/CSSComputedStyleDeclaration.h:
      
      LayoutTests: getComputedStyle should return shorthands properties with the minimum number of sides possible.
      https://bugs.webkit.org/show_bug.cgi?id=75434
      
      Reviewed by Tony Chang.
      
      As stated in http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
      return shorthands properties with the minimum number of sides possible.
      
      * fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt:
      * fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html:
      * fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt:
      * fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html:
      * fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt:
      * fast/css/getComputedStyle/getComputedStyle-border-width.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8e1f645
    • aroben@apple.com's avatar
      Make Port subclasses override the operating_system method rather than setting an attribute · 2b9314be
      aroben@apple.com authored
      Without this patch, any use of Port.operating_system() within a port's __init__ method would
      return the default value ("mac"). This was confusing the version-checking logic inside
      ApplePort.__init__ on Windows.
      
      Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
      crashes on launch on Windows 7 SP1
      
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/layout_tests/port/apple.py:
      (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
      
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
      should now override the operating_system method instead.
      (Port.operating_system): Changed to always return "mac". Subclasses should override to
      return something else.
      
      * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
      (ChromiumLinuxPort.__init__):
      (ChromiumLinuxPort.operating_system):
      * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
      (ChromiumMacPort.__init__):
      (ChromiumMacPort.operating_system):
      * Scripts/webkitpy/layout_tests/port/chromium_win.py:
      (ChromiumWinPort.__init__):
      (ChromiumWinPort.operating_system):
      * Scripts/webkitpy/layout_tests/port/mac.py:
      (MacPort.__init__):
      (MacPort.operating_system):
      * Scripts/webkitpy/layout_tests/port/win.py:
      (WinPort.__init__):
      (WinPort.operating_system):
      Changed to override the operating_system method rather than setting the _operating_system
      attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
      
      * Scripts/webkitpy/layout_tests/port/qt.py:
      (QtPort.__init__):
      (QtPort._path_to_webcore_library):
      Changed to use self.operating_system() instead of self._operating_system, for consistency
      with other Port-related code.
      
      (QtPort.operating_system): Added this override of Port.operating_system that returns the
      value we determined in our __init__ method.
      
      * Scripts/webkitpy/layout_tests/port/test.py:
      (TestPort.operating_system): Added this override of Port.operating_system that returns the
      value we determined in our __init__ method.
      
      * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      (PortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
      (ChromiumLinuxPortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
      (ChromiumMacPortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
      (ChromiumWinPortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
      (MacPortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
      (QtPortTest.test_operating_system):
      * Scripts/webkitpy/layout_tests/port/win_unittest.py:
      (WinPortTest.test_operating_system):
      Test that all ports return the expected operating system string.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b9314be
    • commit-queue@webkit.org's avatar
      [GTK] GTK+ 3 theming code does not use the GtkOrientable style class · e80b8c3a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72789
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-03
      Reviewed by Philippe Normand.
      
      No new tests. Testing GTK+ theming is quite difficult
      because no two distributions have the same set of themes.
      Current tests prevent regressions.
      
      * platform/gtk/RenderThemeGtk3.cpp:
      (WebCore::applySliderStyleContextClasses): Added this helper that
      properly handles the orientable style class.
      (WebCore::RenderThemeGtk::paintSliderTrack): Use the new helper.
      (WebCore::RenderThemeGtk::paintSliderThumb): Ditto.
      * platform/gtk/ScrollbarThemeGtk3.cpp:
      (WebCore::applyScrollbarStyleContextClasses): Added this helper that
      properly handles the orientable style class.
      (WebCore::ScrollbarThemeGtk::paintTrackBackground): Use the new helper.
      (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
      (WebCore::ScrollbarThemeGtk::paintThumb): Ditto.
      (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e80b8c3a
    • commit-queue@webkit.org's avatar
      NULL ptr in WebCore::SVGStyledTransformableElement::animatedLocalTransform · 8282a1d8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75227
      
      Patch by Florin Malita <fmalita@google.com> on 2012-01-03
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Test: svg/custom/webkit-transform-crash.html
      
      * svg/SVGStyledTransformableElement.cpp:
      (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
      Add a null-renderer check.
      
      LayoutTests:
      
      * svg/custom/webkit-transform-crash-expected.txt: Added.
      * svg/custom/webkit-transform-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8282a1d8
    • mitz@apple.com's avatar
      Fixed a typo in the change log · e1e2538c
      mitz@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1e2538c
    • alexis.menard@openbossa.org's avatar
      getComputedStyle for border is not implemented. · 8e973cb0
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75319
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Implement getComputedStyle for border.
      
      fast/css/getComputedStyle/getComputedStyle-border-shorthand.html was extented.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      LayoutTests:
      
      Extend existing test to cover that we return correct values.
      
      * fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt:
      * fast/css/getComputedStyle/getComputedStyle-border-shorthand.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e973cb0
    • alexis.menard@openbossa.org's avatar
      Sort the WebCore XCode project file · 38fec3dd
      alexis.menard@openbossa.org authored
      Reviewed by Dimitri Glazkov.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38fec3dd
    • enne@google.com's avatar
      [chromium] Set tiler bounds explicitly rather than growing them · 43e567e0
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75331
      
      Reviewed by James Robinson.
      
      Rather than only growing bounds, make the bounds on the tiler be set
      explicitly by TiledLayerChromium. This patch now properly invalidates
      regions when the bounds change.
      
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::updateBounds):
      (WebCore::TiledLayerChromium::prepareToUpdate):
      (WebCore::TiledLayerChromium::prepareToUpdateIdle):
      * platform/graphics/chromium/TiledLayerChromium.h:
      * platform/graphics/chromium/cc/CCLayerTilingData.cpp:
      (WebCore::CCLayerTilingData::setBounds):
      (WebCore::CCLayerTilingData::bounds):
      * platform/graphics/chromium/cc/CCLayerTilingData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43e567e0
    • commit-queue@webkit.org's avatar
      [GTK] Slider thumb is not centered on the track with the unico theme · e716ea06
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72802
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-03
      Reviewed by Philippe Normand.
      
      No new tests. This only applies to certain GTK+ themes.
      Existing tests cover the default GTK+ theme.
      
      * platform/gtk/RenderThemeGtk3.cpp:
      (WebCore::RenderThemeGtk::paintSliderThumb): Do not resize the
      slider thumb by the trough border.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e716ea06
    • enne@google.com's avatar
      [chromium] Make tiled layer's tiler always exist · 3b05343a
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75329
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      TiledLayerChromium has some awkward code to handle lazily creating the
      tiler, including lots of null checks and shadowing the tile size.
      Instead, always create the tiler up front. As values change that
      invalidate all tiles, reset it rather than clear the pointer.
      
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::setIsNonCompositedContent):
      * platform/graphics/chromium/LayerChromium.h:
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::TiledLayerChromium):
      (WebCore::TiledLayerChromium::cleanupResources):
      (WebCore::TiledLayerChromium::setTileSize):
      (WebCore::TiledLayerChromium::setBorderTexelOption):
      (WebCore::TiledLayerChromium::drawsContent):
      (WebCore::TiledLayerChromium::updateCompositorResources):
      (WebCore::TiledLayerChromium::setTilingOption):
      (WebCore::TiledLayerChromium::pushPropertiesTo):
      (WebCore::TiledLayerChromium::setIsNonCompositedContent):
      (WebCore::TiledLayerChromium::invalidateRect):
      (WebCore::TiledLayerChromium::protectTileTextures):
      (WebCore::TiledLayerChromium::prepareToUpdate):
      (WebCore::TiledLayerChromium::prepareToUpdateIdle):
      (WebCore::TiledLayerChromium::needsIdlePaint):
      (WebCore::TiledLayerChromium::idlePaintRect):
      * platform/graphics/chromium/TiledLayerChromium.h:
      * platform/graphics/chromium/cc/CCLayerTilingData.cpp:
      (WebCore::CCLayerTilingData::setBorderTexelOption):
      * platform/graphics/chromium/cc/CCLayerTilingData.h:
      * platform/graphics/gpu/TilingData.cpp:
      (WebCore::TilingData::setHasBorderTexels):
      * platform/graphics/gpu/TilingData.h:
      
      Source/WebKit/chromium:
      
      Update test due to changing API. Add a test for changing border
      texel option on TilingData.
      
      * tests/TiledLayerChromiumTest.cpp:
      (WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):
      * tests/TilingDataTest.cpp:
      (WebCore::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b05343a
    • mario@webkit.org's avatar
      [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix · e2f526f0
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75474
      
      Reviewed by Philippe Normand.
      
      * Scripts/run-gtk-tests: Ignore files whose name does not start
      with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2f526f0
    • commit-queue@webkit.org's avatar
      [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser · 6bb96c95
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75472
      
      Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-03
      Reviewed by Tor Arne Vestbø.
      
      * MiniBrowser/qt/MiniBrowser.pro:
      * MiniBrowser/qt/MiniBrowser.qrc:
      * MiniBrowser/qt/qml/BrowserWindow.qml:
      * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bb96c95
    • ddkilzer@apple.com's avatar
      Add Production configuration to gtest Xcode project · 89e9dc03
      ddkilzer@apple.com authored
      <http://webkit.org/b/75153>
      
      Reviewed by Adam Roben.
      
      * gtest/README.WebKit: Updated.
      * gtest/xcode/Config/ProductionProject.xcconfig: Added.
      * gtest/xcode/gtest.xcodeproj/project.pbxproj:
      - Added Production configuration based on Release configuration.
      - Made Production the default configuration.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89e9dc03
    • commit-queue@webkit.org's avatar
      [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser · ba0bd301
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75471
      
      Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-03
      Reviewed by Tor Arne Vestbø.
      
      Add simple UI for JavaScript Alert dialogs. This patch also adds a
      simple DialogButton QML type and a Dialog QML type which will be
      reusable for other JavaScript dialogs.
      
      * MiniBrowser/qt/MiniBrowser.qrc:
      * MiniBrowser/qt/qml/AlertDialog.qml: Added.
      * MiniBrowser/qt/qml/BrowserWindow.qml:
      * MiniBrowser/qt/qml/Dialog.qml: Added.
      * MiniBrowser/qt/qml/DialogButton.qml: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba0bd301
    • commit-queue@webkit.org's avatar
      [Qt][WK2] MiniBrowser doesn't show url bar · 614c2bfd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75470
      
      Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-03
      Reviewed by Tor Arne Vestbø.
      
      * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
      on QtDeclarative (QTBUG-23422).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      614c2bfd