- 17 Feb, 2006 3 commits
-
-
adele authored
Reviewed by Anders Carlsson. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7265 REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag * fast/parser/nofoo-tags-inside-paragraph-expected.checksum: Added. * fast/parser/nofoo-tags-inside-paragraph-expected.png: Added. * fast/parser/nofoo-tags-inside-paragraph-expected.txt: Added. * fast/parser/nofoo-tags-inside-paragraph.html: Added. WebCore: Test: fast/parser/nofoo-tags-inside-paragraph.html Reviewed by Anders Carlsson. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7265 REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag * khtml/html/htmlparser.cpp: (HTMLParser::isInline): Treat noframes, nolayer, noembed and skipped noscript as inline elements. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12871 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Reviewed by Maciej. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7218 Text underlined on mouse over * fast/css/universal-hover-quirk-expected.checksum: Added. * fast/css/universal-hover-quirk-expected.png: Added. * fast/css/universal-hover-quirk-expected.txt: Added. * fast/css/universal-hover-quirk.html: Added. WebCore: Test: fast/css/universal-hover-quirk.html Reviewed by Maciej. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7218 Text underlined on mouse over * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Prevent *:hover and *:active from matching anything in quirks mode. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12869 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Reviewed by Dave Hyatt. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7216 white-space: pre-wrap collapses leading whitespace following a newline * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added. * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added. * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Added. * fast/text/whitespace/pre-wrap-spaces-after-newline.html: Added. WebCore: Test: fast/text/whitespace/pre-wrap-spaces-after-newline.html Reviewed by Dave Hyatt. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7216 white-space: pre-wrap collapses leading whitespace following a newline * rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Use previousLineBrokeCleanly instead of resetBidiAtEnd now that the former is always correct. (khtml::RenderBlock::layoutInlineChildren): Use new skipTrailingNewline flag. (khtml::RenderBlock::findNextLineBreak): Set previousLineBrokeCleanly for line breaks caused by newlines as well. Added skipTrailingNewline flag. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 16 Feb, 2006 2 commits
-
-
adele authored
Updating results for fix: http://bugzilla.opendarwin.org/show_bug.cgi?id=6812 Missing focus ring on new text fields * fast/forms/input-appearance-focus-expected.checksum: * fast/forms/input-appearance-focus-expected.png: WebCore: Reviewed by Darin. - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6812 Missing focus ring on new text fields Tests: * fast/forms/input-appearance-focus.html: Updated. * rendering/render_object.cpp: (WebCore::RenderObject::paintOutline): call supportsFocusRing instead of checking the appearance. * rendering/render_theme.cpp: (khtml::RenderTheme::supportsFocusRing): Added. Checks appearance. Theme will draw focus ring if there's an appearance, but not for the new text fields. * rendering/render_theme.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12855 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7148> Add drag and drop support to DumpRenderTree * css1/basic/comments-expected.checksum: * css1/basic/comments-expected.png: * css1/basic/containment-expected.checksum: * css1/basic/containment-expected.png: * css1/basic/id_as_selector-expected.checksum: * css1/basic/id_as_selector-expected.png: * css1/basic/inheritance-expected.checksum: * css1/basic/inheritance-expected.png: * css1/box_properties/border-expected.checksum: * css1/box_properties/border-expected.png: * css1/box_properties/border_bottom-expected.checksum: * css1/box_properties/border_bottom-expected.png: * css1/box_properties/border_bottom_width-expected.checksum: * css1/box_properties/border_bottom_width-expected.png: * css1/box_properties/border_left-expected.checksum: * css1/box_properties/border_left-expected.png: * css1/box_properties/border_left_width-expected.checksum: * css1/box_properties/border_left_width-expected.png: * css1/box_properties/border_right_inline-expected.checksum: * css1/box_properties/border_right_inline-expected.png: * css1/box_properties/border_right_width-expected.checksum: * css1/box_properties/border_right_width-expected.png: * css1/box_properties/border_style-expected.checksum: * css1/box_properties/border_style-expected.png: * css1/box_properties/border_top-expected.checksum: * css1/box_properties/border_top-expected.png: * css1/box_properties/border_top_width-expected.checksum: * css1/box_properties/border_top_width-expected.png: * css1/box_properties/border_width-expected.checksum: * css1/box_properties/border_width-expected.png: * css1/box_properties/clear-expected.checksum: * css1/box_properties/clear-expected.png: * css1/box_properties/clear_float-expected.checksum: * css1/box_properties/clear_float-expected.png: * css1/box_properties/float_elements_in_series-expected.checksum: * css1/box_properties/float_elements_in_series-expected.png: * css1/box_properties/float_margin-expected.checksum: * css1/box_properties/float_margin-expected.png: * css1/box_properties/float_on_text_elements-expected.checksum: * css1/box_properties/float_on_text_elements-expected.png: * css1/box_properties/height-expected.checksum: * css1/box_properties/height-expected.png: * css1/box_properties/margin-expected.checksum: * css1/box_properties/margin-expected.png: * css1/box_properties/margin_bottom-expected.checksum: * css1/box_properties/margin_bottom-expected.png: * css1/box_properties/margin_inline-expected.checksum: * css1/box_properties/margin_inline-expected.png: * css1/box_properties/margin_left-expected.checksum: * css1/box_properties/margin_left-expected.png: * css1/box_properties/margin_right-expected.checksum: * css1/box_properties/margin_right-expected.png: * css1/box_properties/margin_top-expected.checksum: * css1/box_properties/margin_top-expected.png: * css1/box_properties/padding-expected.checksum: * css1/box_properties/padding-expected.png: * css1/box_properties/padding_bottom-expected.checksum: * css1/box_properties/padding_bottom-expected.png: * css1/box_properties/padding_inline-expected.checksum: * css1/box_properties/padding_inline-expected.png: * css1/box_properties/padding_left-expected.checksum: * css1/box_properties/padding_left-expected.png: * css1/box_properties/padding_right-expected.checksum: * css1/box_properties/padding_right-expected.png: * css1/box_properties/padding_top-expected.checksum: * css1/box_properties/padding_top-expected.png: * css1/box_properties/width-expected.checksum: * css1/box_properties/width-expected.png: * css1/cascade/cascade_order-expected.checksum: * css1/cascade/cascade_order-expected.png: * css1/classification/display-expected.checksum: * css1/classification/display-expected.png: * css1/classification/list_style_type-expected.checksum: * css1/classification/list_style_type-expected.png: * css1/classification/white_space-expected.checksum: * css1/classification/white_space-expected.png: * css1/color_and_background/background-expected.checksum: * css1/color_and_background/background-expected.png: * css1/color_and_background/background_attachment-expected.checksum: * css1/color_and_background/background_attachment-expected.png: * css1/color_and_background/background_position-expected.checksum: * css1/color_and_background/background_position-expected.png: * css1/color_and_background/background_repeat-expected.checksum: * css1/color_and_background/background_repeat-expected.png: * css1/conformance/forward_compatible_parsing-expected.checksum: * css1/conformance/forward_compatible_parsing-expected.png: * css1/font_properties/font-expected.checksum: * css1/font_properties/font-expected.png: * css1/font_properties/font_family-expected.checksum: * css1/font_properties/font_family-expected.png: * css1/font_properties/font_size-expected.checksum: * css1/font_properties/font_size-expected.png: * css1/font_properties/font_weight-expected.checksum: * css1/font_properties/font_weight-expected.png: * css1/formatting_model/floating_elements-expected.checksum: * css1/formatting_model/floating_elements-expected.png: * css1/formatting_model/height_of_lines-expected.checksum: * css1/formatting_model/height_of_lines-expected.png: * css1/formatting_model/horizontal_formatting-expected.checksum: * css1/formatting_model/horizontal_formatting-expected.png: * css1/formatting_model/inline_elements-expected.checksum: * css1/formatting_model/inline_elements-expected.png: * css1/formatting_model/replaced_elements-expected.checksum: * css1/formatting_model/replaced_elements-expected.png: * css1/formatting_model/vertical_formatting-expected.checksum: * css1/formatting_model/vertical_formatting-expected.png: * css1/pseudo/anchor-expected.checksum: * css1/pseudo/anchor-expected.png: * css1/pseudo/firstletter-expected.checksum: * css1/pseudo/firstletter-expected.png: * css1/pseudo/firstline-expected.checksum: * css1/pseudo/firstline-expected.png: * css1/pseudo/multiple_pseudo_elements-expected.checksum: * css1/pseudo/multiple_pseudo_elements-expected.png: * css1/text_properties/letter_spacing-expected.checksum: * css1/text_properties/letter_spacing-expected.png: * css1/text_properties/line_height-expected.checksum: * css1/text_properties/line_height-expected.png: * css1/text_properties/text-transCapitalize-expected.checksum: * css1/text_properties/text-transCapitalize-expected.png: * css1/text_properties/text_decoration-expected.checksum: * css1/text_properties/text_decoration-expected.png: * css1/text_properties/text_indent-expected.checksum: * css1/text_properties/text_indent-expected.png: * css1/text_properties/text_transform-expected.checksum: * css1/text_properties/text_transform-expected.png: * css1/text_properties/vertical_align-expected.checksum: * css1/text_properties/vertical_align-expected.png: * css1/text_properties/word_spacing-expected.checksum: * css1/text_properties/word_spacing-expected.png: * css1/units/color_units-expected.checksum: * css1/units/color_units-expected.png: * css1/units/length_units-expected.checksum: * css1/units/length_units-expected.png: * css2.1/t0801-c412-hz-box-00-b-a-expected.checksum: * css2.1/t0801-c412-hz-box-00-b-a-expected.png: * css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: * css2.1/t0803-c5502-mrgn-r-02-c-expected.png: * css2.1/t0803-c5505-mrgn-02-c-expected.checksum: * css2.1/t0803-c5505-mrgn-02-c-expected.png: * css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: * css2.1/t080301-c411-vt-mrgn-00-b-expected.png: * css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: * css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: * css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: * css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: * css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: * css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: * css2.1/t1002-c5523-width-02-b-g-expected.checksum: * css2.1/t1002-c5523-width-02-b-g-expected.png: * css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: * css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: * css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: * css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: * css2.1/t1508-c527-font-07-b-expected.checksum: * css2.1/t1508-c527-font-07-b-expected.png: * editing/deleting/delete-after-span-ws-001-expected.checksum: * editing/deleting/delete-after-span-ws-001-expected.png: * editing/deleting/delete-after-span-ws-002-expected.checksum: * editing/deleting/delete-after-span-ws-002-expected.png: * editing/deleting/delete-after-span-ws-003-expected.checksum: * editing/deleting/delete-after-span-ws-003-expected.png: * editing/deleting/delete-and-undo-expected.checksum: * editing/deleting/delete-and-undo-expected.png: * editing/deleting/delete-and-undo-expected.txt: * editing/deleting/delete-line-end-ws-001-expected.checksum: * editing/deleting/delete-line-end-ws-001-expected.png: * editing/deleting/delete-line-end-ws-002-expected.checksum: * editing/deleting/delete-line-end-ws-002-expected.png: * editing/inserting/insert-div-023-expected.checksum: * editing/inserting/insert-div-023-expected.png: * editing/selection/caret-and-focus-ring.html: * editing/selection/drag-to-contenteditable-iframe-expected.checksum: Added. * editing/selection/drag-to-contenteditable-iframe-expected.png: Added. * editing/selection/drag-to-contenteditable-iframe-expected.txt: Added. * editing/selection/drag-to-contenteditable-iframe.html: Added. * editing/selection/focus_editable_html-expected.checksum: * editing/selection/focus_editable_html-expected.png: * editing/selection/iframe-expected.checksum: * editing/selection/iframe-expected.png: * editing/selection/replaced-boundaries-3-expected.checksum: * editing/selection/replaced-boundaries-3-expected.png: * editing/selection/select-all-001-expected.checksum: * editing/selection/select-all-001-expected.png: * editing/selection/select-all-002-expected.checksum: * editing/selection/select-all-002-expected.png: * editing/selection/select-all-003-expected.checksum: * editing/selection/select-all-003-expected.png: * editing/selection/select-all-004-expected.checksum: * editing/selection/select-all-004-expected.png: * editing/selection/select-box-expected.checksum: * editing/selection/select-box-expected.png: * editing/selection/selection-background.html: * editing/selection/unrendered-001-expected.checksum: * editing/selection/unrendered-001-expected.png: * editing/selection/unrendered-002-expected.checksum: * editing/selection/unrendered-002-expected.png: * editing/selection/unrendered-003-expected.checksum: * editing/selection/unrendered-003-expected.png: * editing/selection/unrendered-004-expected.checksum: * editing/selection/unrendered-004-expected.png: * editing/selection/unrendered-005-expected.checksum: * editing/selection/unrendered-005-expected.png: * editing/undo/4063751-expected.txt: * editing/undo/redo-typing-001-expected.txt: * editing/undo/undo-typing-001-expected.checksum: * editing/undo/undo-typing-001-expected.png: * editing/undo/undo-typing-001-expected.txt: * fast/block/basic/016-expected.checksum: * fast/block/basic/016-expected.png: * fast/block/basic/text-indent-rtl-expected.checksum: * fast/block/float/008-expected.checksum: * fast/block/float/008-expected.png: * fast/block/float/013-expected.checksum: * fast/block/float/013-expected.png: * fast/block/float/019-expected.checksum: * fast/block/float/019-expected.png: * fast/block/float/021-expected.checksum: * fast/block/float/021-expected.png: * fast/block/float/025-expected.checksum: * fast/block/float/025-expected.png: * fast/block/float/026-expected.checksum: * fast/block/float/026-expected.png: * fast/block/float/027-expected.checksum: * fast/block/float/027-expected.png: * fast/block/float/028-expected.checksum: * fast/block/float/028-expected.png: * fast/block/float/032-expected.checksum: * fast/block/float/032-expected.png: * fast/block/float/033-expected.checksum: * fast/block/float/033-expected.png: * fast/block/margin-collapse/103-expected.checksum: * fast/block/margin-collapse/103-expected.png: * fast/block/margin-collapse/104-expected.checksum: * fast/block/margin-collapse/104-expected.png: * fast/block/positioning/047-expected.checksum: * fast/block/positioning/047-expected.png: * fast/block/positioning/051-expected.checksum: * fast/block/positioning/051-expected.png: * fast/block/positioning/055-expected.checksum: * fast/block/positioning/055-expected.png: * fast/block/positioning/auto/007-expected.checksum: * fast/block/positioning/auto/007-expected.png: * fast/block/positioning/relayout-on-position-change-expected.checksum: * fast/box-sizing/box-sizing-expected.checksum: * fast/box-sizing/box-sizing-expected.png: * fast/clip/014-expected.checksum: * fast/clip/014-expected.png: * fast/css-generated-content/014-expected.checksum: * fast/css-generated-content/014-expected.png: * fast/css/005-expected.checksum: * fast/css/005-expected.png: * fast/css/MarqueeLayoutTest-expected.checksum: * fast/css/MarqueeLayoutTest-expected.png: * fast/css/imageTileOpacity-expected.checksum: * fast/css/imageTileOpacity-expected.png: * fast/css/word-space-extra-expected.checksum: * fast/css/word-space-extra-expected.png: * fast/dom/HTMLObjectElement/object-as-frame.html: * fast/dom/focus-contenteditable-expected.checksum: * fast/dom/focus-contenteditable-expected.png: * fast/dom/window-onFocus.html: * fast/dynamic/008-expected.checksum: * fast/dynamic/008-expected.png: * fast/encoding/utf-16-big-endian-expected.checksum: * fast/encoding/utf-16-big-endian-expected.png: * fast/encoding/utf-16-little-endian-expected.checksum: * fast/encoding/utf-16-little-endian-expected.png: * fast/flexbox/009-expected.checksum: * fast/flexbox/009-expected.png: * fast/flexbox/016-expected.checksum: * fast/flexbox/016-expected.png: * fast/forms/001-expected.checksum: * fast/forms/001-expected.png: * fast/forms/003-expected.checksum: * fast/forms/003-expected.png: * fast/forms/004-expected.checksum: * fast/forms/004-expected.png: * fast/forms/HTMLOptionElement_label01-expected.checksum: * fast/forms/HTMLOptionElement_label01-expected.png: * fast/forms/HTMLOptionElement_label02-expected.checksum: * fast/forms/HTMLOptionElement_label02-expected.png: * fast/forms/HTMLOptionElement_label03-expected.checksum: * fast/forms/HTMLOptionElement_label03-expected.png: * fast/forms/HTMLOptionElement_label04-expected.checksum: * fast/forms/HTMLOptionElement_label04-expected.png: * fast/forms/button-sizes-expected.checksum: * fast/forms/button-sizes-expected.png: * fast/forms/checkbox-radio-onchange-expected.checksum: * fast/forms/checkbox-radio-onchange-expected.png: * fast/forms/form-element-geometry-expected.checksum: * fast/forms/form-element-geometry-expected.png: * fast/forms/indeterminate-expected.checksum: * fast/forms/indeterminate-expected.png: * fast/forms/option-script-expected.checksum: * fast/forms/option-script-expected.png: * fast/forms/option-strip-whitespace-expected.checksum: * fast/forms/option-strip-whitespace-expected.png: * fast/forms/radio_checked-expected.checksum: * fast/forms/radio_checked-expected.png: * fast/forms/radio_checked_dynamic-expected.checksum: * fast/forms/radio_checked_dynamic-expected.png: * fast/forms/textAreaLineHeight-expected.checksum: * fast/forms/textAreaLineHeight-expected.png: * fast/inline-block/tricky-baseline-expected.checksum: * fast/inline-block/tricky-baseline-expected.png: * fast/invalid/014-expected.checksum: * fast/invalid/014-expected.png: * fast/lists/008-expected.checksum: * fast/lists/008-expected.png: * fast/lists/li-br-expected.checksum: * fast/lists/li-br-expected.png: * fast/lists/olstart-expected.checksum: * fast/lists/olstart-expected.png: * fast/loader/form-events-back-forward.html: Removed. * fast/loader/form-events-back-forward.html-disabled: Added. * fast/overflow/002-expected.checksum: * fast/overflow/002-expected.png: * fast/overflow/003-expected.checksum: * fast/overflow/003-expected.png: * fast/overflow/005-expected.checksum: * fast/overflow/005-expected.png: * fast/overflow/006-expected.checksum: * fast/overflow/006-expected.png: * fast/overflow/007-expected.checksum: * fast/overflow/007-expected.png: * fast/overflow/image-selection-highlight-expected.checksum: * fast/overflow/image-selection-highlight-expected.png: * fast/overflow/overflow-auto-table-expected.checksum: * fast/overflow/overflow-auto-table-expected.png: * fast/overflow/overflow-rtl-expected.checksum: * fast/overflow/overflow-rtl-expected.png: * fast/overflow/overflow-text-hit-testing-expected.checksum: * fast/overflow/overflow-text-hit-testing-expected.png: * fast/overflow/scrollRevealButton-expected.checksum: * fast/overflow/scrollRevealButton-expected.png: * fast/parser/comments-expected.checksum: * fast/parser/comments-expected.png: * fast/parser/document-write-option-expected.checksum: * fast/parser/document-write-option-expected.png: * fast/parser/entities-in-xhtml-expected.checksum: * fast/parser/entities-in-xhtml-expected.png: * fast/replaced/005-expected.checksum: * fast/replaced/005-expected.png: * fast/replaced/width100percent-expected.checksum: * fast/replaced/width100percent-expected.png: * fast/selectors/166-expected.checksum: * fast/selectors/166-expected.png: * fast/table/023-expected.checksum: * fast/table/023-expected.png: * fast/table/034-expected.checksum: * fast/table/034-expected.png: * fast/table/040-expected.checksum: * fast/table/040-expected.png: * fast/table/border-collapsing/004-expected.checksum: * fast/table/border-collapsing/004-expected.png: * fast/table/edge-offsets-expected.checksum: * fast/table/edge-offsets-expected.png: * fast/table/height-percent-test-expected.checksum: * fast/table/height-percent-test-expected.png: * fast/table/overflowHidden-expected.checksum: * fast/table/overflowHidden-expected.png: * fast/table/wide-colspan-expected.checksum: * fast/table/wide-colspan-expected.png: * fast/table/wide-column-expected.checksum: * fast/table/wide-column-expected.png: * fast/text/softHyphen-expected.checksum: * fast/text/softHyphen-expected.png: * fast/text/whitespace/024-expected.checksum: * fast/text/whitespace/024-expected.png: * fast/tokenizer/004-expected.checksum: * fast/tokenizer/004-expected.png: * svg/custom/feDisplacementMap-01-expected.png: Removed. * svg/custom/junk-data-expected.checksum: * svg/custom/junk-data-expected.png: * svg/custom/missing-xlink-expected.checksum: * svg/custom/missing-xlink-expected.png: * svg/custom/path-bad-data-expected.checksum: * svg/custom/path-bad-data-expected.png: * traversal/tree-walker-004-expected.checksum: * traversal/tree-walker-004-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 15 Feb, 2006 4 commits
-
-
ggaren authored
Reviewed by Maciej, Eric. - WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type() WebCore and JavaScriptCore weren't sharing Instance objects very nicely. I made them use RefPtrs, and sent them to bed without dessert. * bindings/jni/jni_instance.cpp: Made _instance a RefPtr (JavaInstance::~JavaInstance): (JObjectWrapper::JObjectWrapper): * bindings/jni/jni_instance.h: (KJS::Bindings::JObjectWrapper::ref): (KJS::Bindings::JObjectWrapper::deref): * bindings/jni/jni_runtime.cpp: Made _array a RefPtr (JavaArray::~JavaArray): (JavaArray::JavaArray): * bindings/jni/jni_runtime.h: (KJS::Bindings::JavaArray::operator=): * bindings/objc/objc_runtime.h: - Prohibited copying because that would muss the ref count. - Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug. * bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::ObjcFallbackObjectImp): * bindings/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject): * bindings/runtime.h: (KJS::Bindings::Instance::ref): (KJS::Bindings::Instance::deref): * bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): * bindings/runtime_object.h: - Removed ownsInstance data member because RefPtr takes care of instance lifetime now. - Prohibited copying because that would muss the ref count. - Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug. (KJS::RuntimeObjectImp::getInternalInstance): LayoutTests: Reviewed by Eric. - Layout test for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type() * plugins: Added. * plugins/undefined-property-crash-expected.txt: Added. * plugins/undefined-property-crash.html: Added. WebCore: Reviewed by Maciej, Eric. - WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type() WebCore and JavaScriptCore weren't sharing Instance objects very nicely. I made them use RefPtrs, and sent them to bed without dessert. * khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::HTMLAppletElementImpl): Made appletInstance a RefPtr (WebCore::HTMLAppletElementImpl::getAppletInstance): (WebCore::HTMLAppletElementImpl::detach): (WebCore::HTMLEmbedElementImpl::HTMLEmbedElementImpl): Made embedInstance a RefPtr (WebCore::HTMLEmbedElementImpl::getEmbedInstance): (WebCore::HTMLEmbedElementImpl::detach): (WebCore::HTMLObjectElementImpl::HTMLObjectElementImpl): Made objectInstance a RefPtr (WebCore::HTMLObjectElementImpl::getObjectInstance): (WebCore::HTMLObjectElementImpl::detach): * bindings/js/JSDOMCore.cpp: * khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject): * khtml/html/html_objectimpl.h: WebKitTools: Reviewed by Eric. * DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]): Added a dummy method for the sake of LayoutTests/plugins/ undefined-property-crash.html. (It tests a crash due to fallback object use. WebCore won't create a fallback object if the method is not defined.) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12840 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Add files missing from previous commit. * svg/custom/feDisplacementMap-01-expected.checksum: Added. * svg/custom/feDisplacementMap-01-expected.png: Added. * svg/custom/feDisplacementMap-01-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12838 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Reviewed by eseidel. Landed by eseidel. Implemented feDisplacementMap. http://bugzilla.opendarwin.org/show_bug.cgi?id=5862 Test: svg/custom/feDisplacementMap-01.svg * WebCore.xcodeproj/project.pbxproj: added files. * kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFEDisplacementMap::externalRepresentation): * kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap): (WebCore::KCanvasFEDisplacementMap::xChannelSelector): (WebCore::KCanvasFEDisplacementMap::setXChannelSelector): (WebCore::KCanvasFEDisplacementMap::yChannelSelector): (WebCore::KCanvasFEDisplacementMap::setYChannelSelector): (WebCore::KCanvasFEDisplacementMap::scale): (WebCore::KCanvasFEDisplacementMap::setScale): * kcanvas/device/quartz/KCanvasFilterQuartz.h: * kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::getVectorForChannel): (WebCore::KCanvasFEDisplacementMapQuartz::getCIFilter): * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::createFilterEffect): * kcanvas/device/quartz/filters/WKDisplacementMapFilter.cikernel: Added. * kcanvas/device/quartz/filters/WKDisplacementMapFilter.h: Added. * kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: Added. (+[WKDisplacementMapFilter initialize]): (+[WKDisplacementMapFilter filterWithName:]): (-[WKDisplacementMapFilter init]): (-[WKDisplacementMapFilter outputImage]): * ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: Added. (SVGFEDisplacementMapElementImpl::SVGFEDisplacementMapElementImpl): (SVGFEDisplacementMapElementImpl::~SVGFEDisplacementMapElementImpl): (SVGFEDisplacementMapElementImpl::in1): (SVGFEDisplacementMapElementImpl::in2): (SVGFEDisplacementMapElementImpl::xChannelSelector): (SVGFEDisplacementMapElementImpl::yChannelSelector): (SVGFEDisplacementMapElementImpl::scale): (SVGFEDisplacementMapElementImpl::stringToChannel): (SVGFEDisplacementMapElementImpl::parseMappedAttribute): (SVGFEDisplacementMapElementImpl::filterEffect): * ksvg2/svg/SVGFEDisplacementMapElementImpl.h: Added. * ksvg2/svg/svgtags.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12819 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Update missing result from last commit. * fast/xsl/xslt-recursion-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 14 Feb, 2006 7 commits
-
-
ap authored
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6452 KURL::appendEscapingBadChars() doesn't know about %u-escaping. Test case: fast/encoding/percent-escaping.html * kwq/KWQKURL.mm: (appendEscapingBadChars): Rather than adding support for %u, remove the existing "do what I mean" escaping of percent characters that do not look like a result of prior escaping. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12814 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Reviewed by darin. Add incremental parsing support to XMLTokenizer. This patch also does a few other little things: - removes (unused) onHold support from Tokenizer - adds serialization of DOCTYPEs for xml documents - fixes xslt support to no longer depend on synchronous parsing - fixes css styling for pages where xsl recursion is blocked http://bugzilla.opendarwin.org/show_bug.cgi?id=6057 * dom/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::createProcessingInstruction): (WebCore::DocumentImpl::open): (WebCore::DocumentImpl::recalcStyleSelector): * dom/dom_xmlimpl.cpp: (WebCore::ProcessingInstructionImpl::checkStyleSheet): * dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::write): (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::error): (WebCore::XMLTokenizer::initializeParserContext): (WebCore::XMLTokenizer::finish): (WebCore::xmlDocPtrForString): (WebCore::parseAttributes): * dom/xml_tokenizer.h: * khtml/editing/markup.cpp: (khtml::startMarkup): DOCTYPE serialization * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): removed onHold (WebCore::HTMLTokenizer::reset): removed onHold (WebCore::HTMLTokenizer::begin): removed onHold (WebCore::HTMLTokenizer::write): removed onHold (WebCore::HTMLTokenizer::finish): removed onHold * khtml/html/htmltokenizer.h: removed onHold support * khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl): (WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl): (WebCore::XSLStyleSheetImpl::document): (WebCore::XSLStyleSheetImpl::setDocument): (WebCore::XSLStyleSheetImpl::parseString): (WebCore::XSLStyleSheetImpl::loadChildSheets): (WebCore::XSLStyleSheetImpl::compileStyleSheet): (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource): * khtml/xsl/xsl_stylesheetimpl.h: moved functions to .cpp file git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12812 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6815 Calculate correct width for new text fields * fast/forms/input-appearance-width.html: Added. * fast/forms/input-appearance-width-expected.txt: Added. * fast/forms/input-appearance-width-expected.png: Added. * fast/forms/input-appearance-width-expected.checksum: Added. * fast/forms/input-appearance-minWidth.html: Added. * fast/forms/input-appearance-minWidth-expected.txt: Added. * fast/forms/input-appearance-minWidth-expected.png: Added. * fast/forms/input-appearance-minWidth-expected.checksum: Added. WebCore: Reviewed by Maciej. http://bugzilla.opendarwin.org/show_bug.cgi?id=6815 Calculate correct width for new text fields Tests: fast/forms/input-appearance-width.html fast/forms/input-appearance-minWidth.html * rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Remove fixed width for text field. (WebCore::RenderTextField::calcMinMaxWidth): Added. This calls RenderBlock::calcMinMaxWidth and then uses the size attribute to determine what the maxWidth should be. * rendering/RenderTextField.h: Added calcMinMaxWidth. * rendering/render_theme_mac.h: Added adjustTextFieldStyle. * rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): Remove inflation of rect. This is no longer necessary. (WebCore::RenderThemeMac::paintTextField): ditto. (WebCore::RenderThemeMac::setTextFieldCellState): change true to YES. (WebCore::RenderThemeMac::adjustTextFieldStyle): Added. This is the temporary home of the code to set the right padding and margins. When we flip the switch, this will go in html4.css. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12810 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sullivan authored
* fast/forms/HTMLOptionElement_label05-expected.checksum: Added. * fast/forms/HTMLOptionElement_label05-expected.png: Added. * fast/forms/HTMLOptionElement_label05-expected.txt: Added. * fast/forms/HTMLOptionElement_label05.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12806 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sullivan authored
* fast/forms/HTMLOptionElement_label04-expected.checksum: Added. * fast/forms/HTMLOptionElement_label04-expected.png: Added. * fast/forms/HTMLOptionElement_label04-expected.txt: Added. * fast/forms/HTMLOptionElement_label04.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12805 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Moving these tests to a better location. * dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Removed. * dom/html/level2/html/HTMLOptionElement_label01-expected.png: Removed. * dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Removed. * dom/html/level2/html/HTMLOptionElement_label01.html: Removed. * dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Removed. * dom/html/level2/html/HTMLOptionElement_label02-expected.png: Removed. * dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Removed. * dom/html/level2/html/HTMLOptionElement_label02.html: Removed. * dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Removed. * dom/html/level2/html/HTMLOptionElement_label03-expected.png: Removed. * dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Removed. * dom/html/level2/html/HTMLOptionElement_label03.html: Removed. * fast/forms/HTMLOptionElement_label01-expected.checksum: Added. * fast/forms/HTMLOptionElement_label01-expected.png: Added. * fast/forms/HTMLOptionElement_label01-expected.txt: Added. * fast/forms/HTMLOptionElement_label01.html: Added. * fast/forms/HTMLOptionElement_label02-expected.checksum: Added. * fast/forms/HTMLOptionElement_label02-expected.png: Added. * fast/forms/HTMLOptionElement_label02-expected.txt: Added. * fast/forms/HTMLOptionElement_label02.html: Added. * fast/forms/HTMLOptionElement_label03-expected.checksum: Added. * fast/forms/HTMLOptionElement_label03-expected.png: Added. * fast/forms/HTMLOptionElement_label03-expected.txt: Added. * fast/forms/HTMLOptionElement_label03.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12804 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sullivan authored
- tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7255 label attribute in option elements is ignored * dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Added. * dom/html/level2/html/HTMLOptionElement_label01-expected.png: Added. * dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Added. * dom/html/level2/html/HTMLOptionElement_label01.html: Added. * dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Added. * dom/html/level2/html/HTMLOptionElement_label02-expected.png: Added. * dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Added. * dom/html/level2/html/HTMLOptionElement_label02.html: Added. * dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Added. * dom/html/level2/html/HTMLOptionElement_label03-expected.png: Added. * dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Added. * dom/html/level2/html/HTMLOptionElement_label03.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 13 Feb, 2006 1 commit
-
-
harrison authored
* selection/move-between-blocks-no-001-expected.txt: Updated. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 12 Feb, 2006 2 commits
-
-
darin authored
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7206 REGRESSION: PDF "images" no longer render within HTML pages * fast/replaced/page-as-image.html: Added. * fast/replaced/page-as-image-expected.txt: Added. * fast/replaced/page-as-image-expected.png: Added. * fast/replaced/page-as-image-expected.checksum: Added. * fast/replaced/resources/image.pdf: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12778 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
- comment out remote <base> URLs, these were making the tests hang for a long time This also made the affected tests start passing. * dom/xhtml/level2/html/HTMLBodyElement01-expected.checksum: Removed. * dom/xhtml/level2/html/HTMLBodyElement01-expected.png: Removed. * dom/xhtml/level2/html/HTMLBodyElement01-expected.txt: * dom/xhtml/level2/html/HTMLBodyElement01.xhtml: * dom/xhtml/level2/html/HTMLBodyElement02-expected.checksum: Removed. * dom/xhtml/level2/html/HTMLBodyElement02-expected.png: Removed. * dom/xhtml/level2/html/HTMLBodyElement02-expected.txt: * dom/xhtml/level2/html/HTMLBodyElement02.xhtml: * dom/xhtml/level2/html/HTMLBodyElement03-expected.checksum: Removed. * dom/xhtml/level2/html/HTMLBodyElement03-expected.png: Removed. * dom/xhtml/level2/html/HTMLBodyElement03-expected.txt: * dom/xhtml/level2/html/HTMLBodyElement03.xhtml: * dom/xhtml/level2/html/HTMLBodyElement04-expected.checksum: Removed. * dom/xhtml/level2/html/HTMLBodyElement04-expected.png: Removed. * dom/xhtml/level2/html/HTMLBodyElement04-expected.txt: * dom/xhtml/level2/html/HTMLBodyElement04.xhtml: * dom/xhtml/level2/html/HTMLBodyElement05-expected.checksum: Removed. * dom/xhtml/level2/html/HTMLBodyElement05-expected.png: Removed. * dom/xhtml/level2/html/HTMLBodyElement05-expected.txt: * dom/xhtml/level2/html/HTMLBodyElement05.xhtml: * dom/xhtml/level2/html/HTMLBodyElement06-expected.checksum: Removed. * dom/xhtml/level2/html/HTMLBodyElement06-expected.png: Removed. * dom/xhtml/level2/html/HTMLBodyElement06-expected.txt: * dom/xhtml/level2/html/HTMLBodyElement06.xhtml: * dom/xhtml/level2/html/body01-expected.checksum: Removed. * dom/xhtml/level2/html/body01-expected.png: Removed. * dom/xhtml/level2/html/body01-expected.txt: * dom/xhtml/level2/html/body01.xhtml: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 11 Feb, 2006 5 commits
-
-
eseidel authored
Reviewed by eseidel. - Fixing http://bugzilla.opendarwin.org/show_bug.cgi?id=6942 Implement support for "em" and "ex" relative lengths. - Layout tests changes: Fixed: svg/W3C-SVG-1.1/coords-units-03-b.svg New: svg/custom/coords-relative-units-transforms.svg git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12764 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
* fast/events/event-targets.html: Fixed a small mistake in this test, noticed while checking that bug 3609 is fixed in tip of tree. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12760 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Reviewed by Hyatt. - new test and updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=7054 Vertical scroll bars do not appear or do not scroll completely * fast/replaced/width100percent-expected.checksum: Updated. * fast/replaced/width100percent-expected.png: Updated. * fast/replaced/width100percent-expected.txt: Updated. * fast/table/edge-offsets-expected.checksum: Added. * fast/table/edge-offsets-expected.png: Added. * fast/table/edge-offsets-expected.txt: Added. * fast/table/edge-offsets.html: Added. WebCore: Test: fast/table/edge-offsets.html Reviewed by Hyatt. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7054 Vertical scroll bars do not appear or do not scroll completely * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::lowestPosition): Override the superclass implementation to return the lowest of all the cells' lowest positions and the section's. (WebCore::RenderTableSection::rightmostPosition): Ditto for rightmost. (WebCore::RenderTableSection::leftmostPosition): Ditto for leftmost. * rendering/RenderTableSection.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12758 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ap authored
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3400 setting the .src of an iframe to the same value does not reload page Test cases: * fast/frames/frame-set-same-location.html * fast/frames/frame-set-same-src.html * fast/frames/iframe-set-same-location.html * fast/frames/iframe-set-same-src.html * khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::setLocation): Remove the check for the new URL being different from the current one. Moved updateForNewURL() code into setLocation(). * khtml/html/html_baseimpl.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12753 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Reviewed by hyatt. Adding support for external entity declarations in XSLT. http://bugzilla.opendarwin.org/show_bug.cgi?id=7184 <rdar://problem/4271696> support external DTD references in XSLT * fast/parser/external-entities-expected.checksum: Added. * fast/parser/external-entities-expected.png: Added. * fast/parser/external-entities-expected.txt: Added. * fast/parser/external-entities-in-xslt-expected.txt: Added. * fast/parser/external-entities-in-xslt.xml: Added. * fast/parser/external-entities.xml: Added. * fast/parser/resources: Added. * fast/parser/resources/external-entities.dtd: Added. * fast/parser/resources/external-entities.xsl: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 10 Feb, 2006 1 commit
-
-
bdakin authored
Layout test for <rdar://problem/4149655> Frequently reported crash, repro at lastminute.se in khtml::RenderBlock::createLineBoxes git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 08 Feb, 2006 5 commits
-
-
mjs authored
* svg/custom/resources/link-target.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12700 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6648 Safari strips namespace prefix when using setAttribute(), but should treat it as part of name * fast/dom/Element: Added. * fast/dom/Element/setAttribute-with-colon.html: Added. * fast/dom/Element/setAttribute-with-colon-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12688 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7095 Removing positioning from an element does not relayout properly * fast/block/positioning/relayout-on-position-change-expected.checksum: Added. * fast/block/positioning/relayout-on-position-change-expected.png: Added. * fast/block/positioning/relayout-on-position-change-expected.txt: Added. * fast/block/positioning/relayout-on-position-change.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12682 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
* svg/custom/hit-test-path-expected.checksum: Added. * svg/custom/hit-test-path-expected.png: Added. * svg/custom/hit-test-path-expected.txt: Added. * svg/custom/hit-test-path.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12678 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Reviewed by Maciej. - test for <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums) * fast/events/window-events-bubble-expected.txt: Added. * fast/events/window-events-bubble.html: Added. * fast/events/window-events-bubble2-expected.txt: Added. * fast/events/window-events-bubble2.html: Added. * fast/events/window-events-capture-expected.txt: Added. * fast/events/window-events-capture.html: Added. WebCore: Reviewed by Maciej. - Fixed <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums) Tests: * fast/events/window-events-bubble.html * fast/events/window-events-bubble2.html * fast/events/window-events-capture.html * khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::handleWindowEvent): Added to send events directly to the window. This code used to be in defaultEventHandler, but that wasn't sending them at the right time. (WebCore::DocumentImpl::defaultEventHandler): Moved code to send window events to handleWindowEvent. * khtml/xml/DocumentImpl.h: Added handleWindowEvent. * khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchGenericEvent): fire window events in capture and bubble phases. (WebCore::NodeImpl::dispatchWindowEvent): call handleWindowEvent. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 07 Feb, 2006 5 commits
-
-
adele authored
- test for <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid * fast/encoding/decoder-allow-null-chars.html * fast/encoding/decoder-allow-null-chars-expected.txt WebCore: Reviewed by Maciej. - Fixed <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid Test: fast/encoding/decoder-allow-null-chars.html * kwq/KWQTextCodec.cpp: (KWQTextDecoder::convertLatin1): Removed stripping of null characters (unwanted): ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12652 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ap authored
Reviewed by Timothy. Convert JavaScript objects to appropriate AppleScript types, instead of only strings http://bugzilla.opendarwin.org/show_bug.cgi?id=7012 WebKit: * WebView/WebView.m: (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Added. * WebView/WebViewPrivate.h: WebCore: * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Added. (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): Added. WebKitTools: * DumpRenderTree/AppleScriptController.h: Added. * DumpRenderTree/AppleScriptController.m: Added. * DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]): * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: LayoutTests: * fast/AppleScript: Added. * fast/AppleScript/001-expected.txt: Added. * fast/AppleS... -
mjs authored
Reviewed by Eric. - test case that verifies that <object> containing html is treated like <iframe> in various respects http://bugzilla.opendarwin.org/show_bug.cgi?id=7125 * fast/dom/HTMLObjectElement/object-as-frame-expected.txt: Added. * fast/dom/HTMLObjectElement/object-as-frame.html: Added. - updated this test to reflect that the onload event now fires for iframes, including ones with empty src http://bugzilla.opendarwin.org/show_bug.cgi?id=3609 * fast/events/event-targets-expected.checksum: Removed. * fast/events/event-targets-expected.png: Removed. * fast/events/event-targets-expected.txt: * fast/events/event-targets.html: WebCore: Reviewed by Eric. - fixed "remove frame, renderer and completed flag from ChildFrame, make Frame track these" http://bugzilla.opendarwin.org/show_bug.cgi?id=7125 - fixed "onload event never called for iframe element with emtpy or about:blank src" http://bugzilla.opendarwin.org/show_bug.cgi?id=3609 * bridge/mac/MacFrame.h: * bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): pass along renderer (WebCore::MacFrame::nextKeyViewInFrameHierarchy): get owner element in newfangled way * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge removeChild:]): don't mess with renderer (-[WebCoreFrameBridge init]): call new designated initializer (-[WebCoreFrameBridge initWithRenderer:]): new designated initializer (-[WebCoreFrameBridge dealloc]): don't mess with renderer (-[WebCoreFrameBridge finalize]): ditto (-[WebCoreFrameBridge installInFrame:]): ditto * page/Frame.cpp: (WebCore::FrameList::find): get name from frame not ChildFrame (WebCore::Frame::init): take renderer parameter (WebCore::Frame::clear): clear m_plugins, not m_objects (WebCore::Frame::childBegin): updated comment (WebCore::Frame::stop): add check-completed for documentless case here (WebCore::Frame::checkCompleted): don't track separate completed flag in ChildFrame, use the sub Frame object's own (WebCore::Frame::checkEmitLoadEvent): ditto (WebCore::Frame::requestFrame): don't store renderer and name in ChildFrame, instead pass them along (WebCore::Frame::requestObject): ditto above (WebCore::Frame::loadPlugin): expect renderer parameter (WebCore::Frame::loadSubframe): expect renderer and name parameters (WebCore::Frame::slotChildStarted): don't mess with ChildFrame (WebCore::Frame::slotChildCompleted): ditto (WebCore::Frame::childFrame): don't check m_objects (WebCore::Frame::frameExists): fix spacing, remove obsolete check and comment (WebCore::Frame::frameNames): get name from frame (WebCore::Frame::ownerElement): simplify a lot since the Frame knows its owner renderer now (WebCore::Frame::ownerRenderer): added (WebCore::Frame::canCachePage): check m_plugins not m_objects * page/Frame.h: * page/FramePrivate.h: (WebCore::ChildFrame): Remove constructor, most fields. (WebCore::FramePrivate::FramePrivate): Pass ownerRenderer * rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Make sure to pass name attr to requestObject. WebKit: Reviewed by Eric. - fixed "remove frame, renderer and completed flag from ChildFrame, make Frame track these" http://bugzilla.opendarwin.org/show_bug.cgi?id=7125 - fixed "onload event never called for iframe element with emtpy or about:blank src" http://bugzilla.opendarwin.org/show_bug.cgi?id=3609 * WebCoreSupport/WebFrameBridge.h: * WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initWithPage:webView:renderer:frameName:view:]): Pass along renderer. (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Pass along renderer. * WebCoreSupport/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]): Pass null for renderer. * WebView/WebView.m: * WebView/WebViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12638 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Reviewed by Maciej. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6944 REGRESSION: crash when loading page w/ <link> that has a DOMSubtreeModified event listener * fast/events/event-listener-on-link.html: Added. * fast/events/event-listener-on-link-expected.txt: Added. * fast/events/event-listener-on-link-expected.png: Added. * fast/events/event-listener-on-link-expected.checksum: Added. WebCore: Reviewed by Maciej. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6944 REGRESSION: crash when loading page w/ <link> that has a DOMSubtreeModified event listener Test: fast/events/event-listener-on-link.html * khtml/xml/dom_elementimpl.h: Added createAttrImplIfNeeded, removed allocateImpl, changed AttrImpl contructor to remove createTextChild bool, added createTextChild method, changed getAttributeNode, getAttributeNodeNS, getNamedItem, getNamedItemNS, and item to return PassRefPtrs. (DOM::ElementImpl::getAttributeNode): * khtml/xml/dom_elementimpl.cpp: (WebCore::AttributeImpl::createAttrImplIfNeeded): New method to replace allocateImpl. This will use a RefPtr for the AttrImpl, check for an existing AttrImpl, create one if there isn't one, and will call the new createTextChild. (WebCore::AttrImpl::AttrImpl): Moved creation of text child to new createTextChild method. If done in the constructor, the ref count is still 0, and the act of appending the text node could cause the AttrImpl to be destroyed. (WebCore::AttrImpl::createTextChild): Moved code from AttrImpl contructor. Also, I've added an assert to make sure that any callers of this have ref'd the AttrImpl. (WebCore::AttrImpl::cloneNode): Used RefPtr instead of PassRefPtr, and then called release() on it before returning. (WebCore::ElementImpl::cloneNode): ditto. (WebCore::ElementImpl::getAttributeNodeNS): Changed return type to PassRefPtr. (WebCore::NamedAttrMapImpl::getNamedItemNS): ditto. (WebCore::NamedAttrMapImpl::getNamedItem): ditto. Changed use of allocateImpl to createAttrImplIfNeeded (WebCore::NamedAttrMapImpl::setNamedItem): ditto. (WebCore::NamedAttrMapImpl::removeNamedItem): ditto. (WebCore::NamedAttrMapImpl::item): ditto. * khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::createAttributeNS): Changed return type to PassRefPtr and removed bool from AttrImpl contructor call. * khtml/xml/DocumentImpl.h: Now returns a PassRefPtr for createAttribute and createAttributeNS. (WebCore::DocumentImpl::createAttribute): * khtml/xml/NamedNodeMapImpl.h: Now returns a PassRefPtr for getNamedItem, getNamedItemNS, and item. (WebCore::NamedNodeMapImpl::getNamedItem): * bindings/objc/DOM.mm: (-[DOMNamedNodeMap getNamedItem:]): Call get() since the methods discussed above now return PassRefPtrs. (-[DOMNamedNodeMap item:]): ditto. (-[DOMNamedNodeMap getNamedItemNS::]): ditto. (-[DOMDocument createAttribute:]): ditto. (-[DOMDocument createAttributeNS::]): ditto. (-[DOMElement getAttributeNode:]): ditto. (-[DOMElement getAttributeNodeNS::]): ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12637 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
- test for 7094: onfocus/onblur on non-form-controls bubble http://bugzilla.opendarwin.org/show_bug.cgi?id=7094 * fast/events/div-focus-expected.txt: Added. * fast/events/div-focus.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 06 Feb, 2006 1 commit
-
-
darin authored
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7071 REGRESSION: Jumping to an anchor identifier makes page scroll horizontally * fast/overflow/scroll-vertical-not-horizontal.html: Added. * fast/overflow/scroll-vectical-not-horizontal-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 05 Feb, 2006 4 commits
-
-
darin authored
* fast/dom/resources/top.html: Just straight conversion to ASCII. * fast/events/updateLayoutForHitTest.html: Converted one character to an entity, and reformatted the file a bit. * fast/text/line-breaks.html: Just straight conversion to ASCII. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12588 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
Reviewed by Darin. Re-landing test case for: - various event cleanup, including fixing of the load event for iframes http://bugzilla.opendarwin.org/show_bug.cgi?id=7079 * fast/events/iframe-object-onload-expected.txt: Added. * fast/events/iframe-object-onload.html: Added. - changed expected results and description for this test, unload should not fire in this case: * fast/events/onunload-body-property-expected.txt: * fast/events/onunload-body-property.html: - changed from UTF-16 to ASCII, there was no reason for this to be UTF-16. * fast/dom/attr_dead_doc.html: WebCore: Reviewed by Darin. Re-landed the following with more fixes so it does not break tests: - various event cleanup, including fixing of the load event for iframes http://bugzilla.opendarwin.org/show_bug.cgi?id=7079 Specific changes: - don't bother to nil-check the document, a node can never have a null document now - move temp event forgetting from dispatchEvent to dispatchGenericEvent - pass event down using RefPtr::release() to avoid ref thrashing - support default handlers even for non-bubbling events (only on target node) and skip calling default event handler explicitly in callers - dispatch a whole separate load event to a frame document's containing frame - don't let propagationStopped prevent this new event - remove bogus security check for iframe onload - dispatch window events on the document, not the body, and also for non-html - set onload, onunload, onbeforeunload from frameset tags on the window object - don't restrict load/unload events to HTML - send default handler to the dispatch object as previously * bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose): * khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::parseMappedAttribute): (WebCore::HTMLFrameSetElementImpl::parseMappedAttribute): * khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose): * khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): (WebCore::NodeImpl::dispatchGenericEvent): (WebCore::NodeImpl::dispatchWindowEvent): * khtml/xml/NodeImpl.h: * page/Frame.cpp: (WebCore::Frame::stopLoading): (WebCore::Frame::setWindowHasFocus): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12587 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6908 REGRESSION: Replacing existing <option> shuffles it to the end of the list * fast/forms/select-replace-option.html: Added. * fast/forms/select-replace-option-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12585 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6962 REGRESSION: www.usa.phillips.com crashes due to <param> with no name * fast/replaced/object-param-no-name.html: Added. * fast/replaced/object-param-no-name-expected.txt: Added. - fixed test that I landed incorrectly earlier * fast/overflow/onscroll-layer-self-destruct.html: Removed Subversion property junk. * fast/overflow/onscroll-layer-self-destruct-expected.txt: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
