1. 01 Oct, 2013 9 commits
    • jer.noble@apple.com's avatar
      Unreviewed build fix; The addedFunction and removedFunction arguments to... · 1c81affb
      jer.noble@apple.com authored
      Unreviewed build fix; The addedFunction and removedFunction arguments to determineChangedTracksFromNewTracksAndOldItems
      were reversed, exposing an underlying, existing bug in AudioTrackPrivate and VideoTrack private. Give a default (null)
      value to AudioTrackPrivate::m_client and VideoTrackPrivate::m_client and fix the ordering of arguments in
      determineChangedTracksFromNewTracksAndOldItems.
      
      * platform/graphics/AudioTrackPrivate.h:
      (WebCore::AudioTrackPrivate::AudioTrackPrivate):
      * platform/graphics/VideoTrackPrivate.h:
      (WebCore::VideoTrackPrivate::VideoTrackPrivate):
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::determineChangedTracksFromNewTracksAndOldItems):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c81affb
    • jer.noble@apple.com's avatar
      [Mac] Add support for VideoTrack to MediaPlayerPrivateAVFObjC · c5046445
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122122
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      Test: media/track/video-track.html
      
      Refactor the methods which query AVAssetTrack and AVPlayerItemTrack into an Impl class, and
      use that class to reset the properties of both AudioTrackAVFObjC and the new VideoTrackAVFObjC.
      
      Add new files to project:
      * WebCore.xcodeproj/project.pbxproj:
      
      Add the new implementation class, shared by AudioTrackAVFObjC and VideoTrackAVFObjC:
      * platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h: Added.
      (WebCore::AVTrackPrivateAVFObjCImpl::create): Simple factory.
      (WebCore::AVTrackPrivateAVFObjCImpl::playerItemTrack): Simple getter.
      * platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm: Added.
      (WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl): Simple constructor.
      (WebCore::AVTrackPrivateAVFObjCImpl::enabled): Pass to AVPlayerItemTrack.
      (WebCore::AVTrackPrivateAVFObjCImpl::setEnabled): Ditto.
      (WebCore::AVTrackPrivateAVFObjCImpl::audioKind): Distinguish between Alternative and Main content.
      (WebCore::AVTrackPrivateAVFObjCImpl::videoKind): Distinguish between Alternative, Main, Caption,
          and Description content.
      (WebCore::AVTrackPrivateAVFObjCImpl::id): Pass to AVAssetTrack.
      (WebCore::AVTrackPrivateAVFObjCImpl::label): Retrieve the Title metadata in the user's preferred
          language.
      (WebCore::AVTrackPrivateAVFObjCImpl::language): Pass to languageForAVAssetTrack.
      (WebCore::AVTrackPrivateAVFObjCImpl::languageForAVAssetTrack): Moved from AudioTrackPrivateAVFObjC.
      * platform/graphics/avfoundation/VideoTrackPrivateAVF.h: Copied from Source/WebCore/platform/graphics/avfoundation/AudioTrackPrivateAVF.h.
      (WebCore::VideoTrackPrivateAVF::kind): Simple getter.
      (WebCore::VideoTrackPrivateAVF::id): Ditto.
      (WebCore::VideoTrackPrivateAVF::label): Ditto.
      (WebCore::VideoTrackPrivateAVF::language): Ditto.
      (WebCore::VideoTrackPrivateAVF::setKind): Simple setter.
      (WebCore::VideoTrackPrivateAVF::setId): Ditto.
      (WebCore::VideoTrackPrivateAVF::setLabel): Ditto.
      (WebCore::VideoTrackPrivateAVF::setLanguage): Ditto.
      (WebCore::VideoTrackPrivateAVF::VideoTrackPrivateAVF): Simple constructor.
      * platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
      * platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
      (WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
      (WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
      (WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
      (WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
      (WebCore::AudioTrackPrivateAVFObjC::setEnabled): Ditto.
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Refactor implementation into
          template method determineChangedTracksFromNewTracksAndOldItems().
      (WebCore::determineChangedTracksFromNewTracksAndOldItems): Refactored.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Pass to determineChangedTracksFromNewTracksAndOldItems.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Ditto.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Changed class hosting
          languageForAVAssetTrack.
      * platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp: Added.
      (WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
      (WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
      (WebCore::VideoTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
      (WebCore::VideoTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
      (WebCore::VideoTrackPrivateAVFObjC::setSelected): Ditto.
      * platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h: Added.
      (WebCore::VideoTrackPrivateAVFObjC::create): Simple factory.
      
      LayoutTests:
      
      * media/track/video-track-expected.txt: Added.
      * media/track/video-track.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5046445
    • commit-queue@webkit.org's avatar
      Rename URL type variables in Curl network backend. · a858b32f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122158
      
      Patch by Szabolcs Dávid <davidsz@inf.u-szeged.hu> on 2013-10-01
      Reviewed by Darin Adler.
      
      I changed the name of the URL objects to match with the new class name.
      
      * platform/network/curl/ResourceHandleManager.cpp:
      (WebCore::getProtectionSpace):
      (WebCore::ResourceHandleManager::initializeHandle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a858b32f
    • commit-queue@webkit.org's avatar
      Center misspelling dots across width of word · e3e46d22
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122046
      
      Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-01
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Test: editing/spelling/spelling.html
      
      * platform/graphics/GraphicsContext.h:
      * platform/graphics/mac/GraphicsContextMac.mm:
      (WebCore::GraphicsContext::drawLineForDocumentMarker):
      
      LayoutTests:
      
      This patch only rebaselines a single test. I would have rebaselined
      the rest of the tests, but they seem to be affected by
      webkit.org/b/122146. I don't want to commit incorrect expected results.
      
      * platform/mac/editing/spelling/spelling-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3e46d22
    • dbates@webkit.org's avatar
      [iOS] WebCore fails to build with newer versions of clang · 04f92d1b
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122161
      
      Reviewed by Darin Adler.
      
      * editing/FrameSelection.cpp: Add ENABLE(TEXT_CARET)-guard around shouldStopBlinkingDueToTypingCommand().
      * page/EventHandler.cpp: Add !PLATFORM(IOS)-guard around constants cursorUpdateInterval and maximumCursorSize;
      also add touch event/gesture event guard around shouldGesturesTriggerActive().
      * platform/network/cf/ResourceResponseCFNet.cpp: Remove unused function filenameHasSaneExtension.
      * platform/network/mac/ResourceResponseMac.mm: Only define static variables commonHeaderFields when building
      without CFNetwork; also remove variable numCommonHeaderFields, instead use WTF_ARRAY_LENGTH(commonHeaderFields)
      to compute the size of the fixed-sized array commonHeaderFields.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04f92d1b
    • commit-queue@webkit.org's avatar
      [GStreamer] Support "chapter" text tracks · ab2cf3d7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122000
      
      Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-01
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      Test: media/track/in-band/track-in-band-mkv-chapters.html
      
      * platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h: New class, needed for cues that aren't associated with GstPads.
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Check for table of contents messages.
      (WebCore::MediaPlayerPrivateGStreamer::processTableOfContents): Parse table of contents messages into text tracks.
      (WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry): Recursive method for parsing all of the TOC entries.
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add the processTableOfContents functions.
      
      LayoutTests:
      
      * media/content/counting-subtitled-srt.mkv: Added chapters metadata.
      * media/track/in-band/track-in-band-mkv-chapters-expected.txt: New test, similar to cues-added-one, but uses "chapters" track.
      * media/track/in-band/track-in-band-mkv-chapters.html: Same.
      * media/in-band-cues.js: Updated tests to handle the new "chapters" track.
      * media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt: Same.
      * media/track/in-band/track-in-band-kate-ogg-cues-added-once.html: Same.
      * media/track/in-band/track-in-band-kate-ogg-mode-expected.txt: Same.
      * media/track/in-band/track-in-band-kate-ogg-mode.html: Same.
      * media/track/in-band/track-in-band-kate-ogg-style-expected.txt: Same.
      * media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt: Same.
      * media/track/in-band/track-in-band-kate-ogg-track-order.html: Same.
      * media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt: Same.
      * media/track/in-band/track-in-band-srt-mkv-cues-added-once.html: Same.
      * media/track/in-band/track-in-band-srt-mkv-kind-expected.txt: Same.
      * media/track/in-band/track-in-band-srt-mkv-kind.html: Same.
      * media/track/in-band/track-in-band-srt-mkv-language-expected.txt: Same.
      * media/track/in-band/track-in-band-srt-mkv-language.html: Same.
      * media/track/in-band/track-in-band-srt-mkv-mode-expected.txt: Same.
      * media/track/in-band/track-in-band-srt-mkv-mode.html: Same.
      * media/track/in-band/track-in-band-srt-mkv-style-expected.txt: Same.
      * media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt: Same.
      * media/track/in-band/track-in-band-srt-mkv-track-order.html: Same.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab2cf3d7
    • allan.jensen@digia.com's avatar
      [Texmap] CSS filter not working on software composited layers · 48545b58
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122159
      
      Reviewed by Noam Rosenthal.
      
      Tell the rendering layer we do not support CSS filters when we do not. This
      will make RenderLayer fall back to using its own software implementation.
      
      * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
      (WebCore::GraphicsLayerTextureMapper::setFilters):
      * platform/graphics/texmap/TextureMapperImageBuffer.cpp:
      (WebCore::BitmapTextureImageBuffer::applyFilters):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48545b58
    • darin@apple.com's avatar
      Try to fix AVFoundation crashes seen on Lion bot. · 4fb2cbf7
      darin@apple.com authored
      * platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
      Four AVFoundation string constants used in this file were new to 10.8.
      For older versions of OS X, use hard-coded string constants instead.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fb2cbf7
    • ryuan.choi@samsung.com's avatar
      Build fix for EFL, Qt, Gtk port after r156688 · e46de4d5
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122139
      
      Reviewed by Anders Carlsson.
      
      Get rid of more uses of OwnPtr and PassOwnPtr.
      
      Source/WebCore:
      
      * platform/graphics/surfaces/GraphicsSurface.cpp:
      (WebCore::GraphicsSurface::beginPaint):
      * platform/graphics/surfaces/GraphicsSurface.h:
      * platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
      (WebCore::GraphicsSurface::platformBeginPaint):
      * platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
      (WebCore::GraphicsSurface::platformBeginPaint):
      * platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
      (WebCore::GraphicsSurface::platformBeginPaint):
      
      Source/WebKit2:
      
      * Shared/API/c/cairo/WKImageCairo.cpp:
      (WKImageCreateFromCairoSurface):
      * Shared/API/c/qt/WKImageQt.cpp:
      (WKImageCreateFromQImage):
      * Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
      (WebKit::WebCoordinatedSurface::createGraphicsContext):
      (WebKit::WebCoordinatedSurface::paintToSurface):
      * Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
      * Shared/cairo/ShareableBitmapCairo.cpp:
      (WebKit::ShareableBitmap::createGraphicsContext):
      * Shared/gtk/ArgumentCodersGtk.cpp:
      (CoreIPC::encodeImage):
      * UIProcess/API/gtk/PageClientImpl.cpp:
      (WebKit::PageClientImpl::createDrawingAreaProxy):
      * UIProcess/API/gtk/PageClientImpl.h:
      * UIProcess/CoordinatedGraphics/WebView.cpp:
      (WebKit::WebView::createDrawingAreaProxy):
      * UIProcess/CoordinatedGraphics/WebView.h:
      * WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
      (WebKit::convertCairoSurfaceToShareableBitmap):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e46de4d5
  2. 30 Sep, 2013 6 commits
    • weinig@apple.com's avatar
      Remove support for DOMFileSystem · 7df82b33
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122137
      
      Reviewed by Anders Carlsson.
      
      .: 
      
      * Source/autotools/SetupWebKitFeatures.m4:
      * Source/cmake/OptionsBlackBerry.cmake:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/JavaScriptCore: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore: 
      
      * Files elided *
      
      Source/WebKit/blackberry: 
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::init):
      (BlackBerry::WebKit::WebPage::clearWebFileSystem):
      * WebCoreSupport/AboutDataEnableFeatures.in:
      
      Source/WebKit/efl: 
      
      * ewk/ewk_settings.cpp:
      (ewk_settings_file_system_path_set):
      
      Source/WebKit/mac: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WTF: 
      
      * wtf/FeatureDefines.h:
      
      Tools: 
      
      * Scripts/webkitperl/FeatureList.pm:
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_spacing):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (CppStyleTest.test_spacing_for_binary_ops):
      * qmake/mkspecs/features/features.pri:
      
      LayoutTests: 
      
      * fast/dom/MutationObserver/filesystem-callback-delivery-expected.txt: Removed.
      * fast/dom/MutationObserver/filesystem-callback-delivery.html: Removed.
      * fast/filesystem: Removed.
      * fast/filesystem/async-operations-expected.txt: Removed.
      * fast/filesystem/async-operations.html: Removed.
      * fast/filesystem/cross-filesystem-op-expected.txt: Removed.
      * fast/filesystem/cross-filesystem-op.html: Removed.
      * fast/filesystem/directory-entry-to-uri-expected.txt: Removed.
      * fast/filesystem/directory-entry-to-uri.html: Removed.
      * fast/filesystem/entry-points-missing-arguments-expected.txt: Removed.
      * fast/filesystem/entry-points-missing-arguments.html: Removed.
      * fast/filesystem/file-after-reload-crash-expected.txt: Removed.
      * fast/filesystem/file-after-reload-crash.html: Removed.
      * fast/filesystem/file-entry-to-uri-expected.txt: Removed.
      * fast/filesystem/file-entry-to-uri.html: Removed.
      * fast/filesystem/file-from-file-entry-expected.txt: Removed.
      * fast/filesystem/file-from-file-entry.html: Removed.
      * fast/filesystem/file-metadata-after-write-expected.txt: Removed.
      * fast/filesystem/file-metadata-after-write.html: Removed.
      * fast/filesystem/file-writer-abort-continue-expected.txt: Removed.
      * fast/filesystem/file-writer-abort-continue.html: Removed.
      * fast/filesystem/file-writer-abort-depth-expected.txt: Removed.
      * fast/filesystem/file-writer-abort-depth.html: Removed.
      * fast/filesystem/file-writer-abort-expected.txt: Removed.
      * fast/filesystem/file-writer-abort.html: Removed.
      * fast/filesystem/file-writer-empty-blob-expected.txt: Removed.
      * fast/filesystem/file-writer-empty-blob.html: Removed.
      * fast/filesystem/file-writer-events-expected.txt: Removed.
      * fast/filesystem/file-writer-events.html: Removed.
      * fast/filesystem/file-writer-gc-blob-expected.txt: Removed.
      * fast/filesystem/file-writer-gc-blob.html: Removed.
      * fast/filesystem/file-writer-truncate-extend-expected.txt: Removed.
      * fast/filesystem/file-writer-truncate-extend.html: Removed.
      * fast/filesystem/file-writer-write-overlapped-expected.txt: Removed.
      * fast/filesystem/file-writer-write-overlapped.html: Removed.
      * fast/filesystem/filesystem-missing-arguments-expected.txt: Removed.
      * fast/filesystem/filesystem-missing-arguments.html: Removed.
      * fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Removed.
      * fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Removed.
      * fast/filesystem/filesystem-reference-expected.txt: Removed.
      * fast/filesystem/filesystem-reference.html: Removed.
      * fast/filesystem/filesystem-unserializable-expected.txt: Removed.
      * fast/filesystem/filesystem-unserializable.html: Removed.
      * fast/filesystem/filesystem-uri-origin-expected.txt: Removed.
      * fast/filesystem/filesystem-uri-origin.html: Removed.
      * fast/filesystem/flags-passing-expected.txt: Removed.
      * fast/filesystem/flags-passing.html: Removed.
      * fast/filesystem/input-access-entries-expected.txt: Removed.
      * fast/filesystem/input-access-entries.html: Removed.
      * fast/filesystem/not-enough-arguments-expected.txt: Removed.
      * fast/filesystem/not-enough-arguments.html: Removed.
      * fast/filesystem/op-copy-expected.txt: Removed.
      * fast/filesystem/op-copy.html: Removed.
      * fast/filesystem/op-get-entry-expected.txt: Removed.
      * fast/filesystem/op-get-entry.html: Removed.
      * fast/filesystem/op-get-metadata-expected.txt: Removed.
      * fast/filesystem/op-get-metadata.html: Removed.
      * fast/filesystem/op-get-parent-expected.txt: Removed.
      * fast/filesystem/op-get-parent.html: Removed.
      * fast/filesystem/op-move-expected.txt: Removed.
      * fast/filesystem/op-move.html: Removed.
      * fast/filesystem/op-read-directory-expected.txt: Removed.
      * fast/filesystem/op-read-directory.html: Removed.
      * fast/filesystem/op-remove-expected.txt: Removed.
      * fast/filesystem/op-remove.html: Removed.
      * fast/filesystem/op-restricted-chars-expected.txt: Removed.
      * fast/filesystem/op-restricted-chars.html: Removed.
      * fast/filesystem/op-restricted-names-expected.txt: Removed.
      * fast/filesystem/op-restricted-names.html: Removed.
      * fast/filesystem/op-restricted-unicode-expected.txt: Removed.
      * fast/filesystem/op-restricted-unicode.html: Removed.
      * fast/filesystem/read-directory-expected.txt: Removed.
      * fast/filesystem/read-directory.html: Removed.
      * fast/filesystem/resources: Removed.
      * fast/filesystem/resources/async-operations.js: Removed.
      * fast/filesystem/resources/directory-entry-to-uri.js: Removed.
      * fast/filesystem/resources/file-entry-to-uri-sync.js: Removed.
      * fast/filesystem/resources/file-entry-to-uri.js: Removed.
      * fast/filesystem/resources/file-from-file-entry-sync.js: Removed.
      * fast/filesystem/resources/file-from-file-entry.js: Removed.
      * fast/filesystem/resources/file-writer-abort-continue.js: Removed.
      * fast/filesystem/resources/file-writer-abort-depth.js: Removed.
      * fast/filesystem/resources/file-writer-abort.js: Removed.
      * fast/filesystem/resources/file-writer-empty-blob.js: Removed.
      * fast/filesystem/resources/file-writer-events.js: Removed.
      * fast/filesystem/resources/file-writer-gc-blob.js: Removed.
      * fast/filesystem/resources/file-writer-sync-truncate-extend.js: Removed.
      * fast/filesystem/resources/file-writer-sync-write-overlapped.js: Removed.
      * fast/filesystem/resources/file-writer-truncate-extend.js: Removed.
      * fast/filesystem/resources/file-writer-utils.js: Removed.
      * fast/filesystem/resources/file-writer-write-overlapped.js: Removed.
      * fast/filesystem/resources/fs-test-util.js: Removed.
      * fast/filesystem/resources/fs-worker-common.js: Removed.
      * fast/filesystem/resources/op-copy.js: Removed.
      * fast/filesystem/resources/op-get-entry.js: Removed.
      * fast/filesystem/resources/op-get-metadata.js: Removed.
      * fast/filesystem/resources/op-get-parent.js: Removed.
      * fast/filesystem/resources/op-move.js: Removed.
      * fast/filesystem/resources/op-read-directory.js: Removed.
      * fast/filesystem/resources/op-remove.js: Removed.
      * fast/filesystem/resources/op-restricted-chars.js: Removed.
      * fast/filesystem/resources/op-restricted-names.js: Removed.
      * fast/filesystem/resources/op-restricted-unicode.js: Removed.
      * fast/filesystem/resources/op-tests-helper.js: Removed.
      * fast/filesystem/resources/shared-worker-stub.js: Removed.
      * fast/filesystem/resources/simple-persistent-sync.js: Removed.
      * fast/filesystem/resources/simple-persistent.js: Removed.
      * fast/filesystem/resources/simple-readonly.js: Removed.
      * fast/filesystem/resources/simple-required-arguments-getdirectory.js: Removed.
      * fast/filesystem/resources/simple-required-arguments-getfile.js: Removed.
      * fast/filesystem/resources/simple-required-arguments-getmetadata.js: Removed.
      * fast/filesystem/resources/simple-required-arguments-remove.js: Removed.
      * fast/filesystem/resources/simple-temporary-sync.js: Removed.
      * fast/filesystem/resources/simple-temporary.js: Removed.
      * fast/filesystem/resources/sync-operations.js: Removed.
      * fast/filesystem/script-tests: Removed.
      * fast/filesystem/script-tests/TEMPLATE.html: Removed.
      * fast/filesystem/script-tests/filesystem-reference.js: Removed.
      * fast/filesystem/script-tests/filesystem-unserializable.js: Removed.
      * fast/filesystem/script-tests/flags-passing.js: Removed.
      * fast/filesystem/script-tests/read-directory.js: Removed.
      * fast/filesystem/simple-persistent-expected.txt: Removed.
      * fast/filesystem/simple-persistent.html: Removed.
      * fast/filesystem/simple-readonly-expected.txt: Removed.
      * fast/filesystem/simple-readonly-file-object-expected.txt: Removed.
      * fast/filesystem/simple-readonly-file-object.html: Removed.
      * fast/filesystem/simple-readonly.html: Removed.
      * fast/filesystem/simple-required-arguments-getdirectory-expected.txt: Removed.
      * fast/filesystem/simple-required-arguments-getdirectory.html: Removed.
      * fast/filesystem/simple-required-arguments-getfile-expected.txt: Removed.
      * fast/filesystem/simple-required-arguments-getfile.html: Removed.
      * fast/filesystem/simple-required-arguments-getmetadata-expected.txt: Removed.
      * fast/filesystem/simple-required-arguments-getmetadata.html: Removed.
      * fast/filesystem/simple-required-arguments-remove-expected.txt: Removed.
      * fast/filesystem/simple-required-arguments-remove.html: Removed.
      * fast/filesystem/simple-temporary-expected.txt: Removed.
      * fast/filesystem/simple-temporary.html: Removed.
      * fast/filesystem/workers: Removed.
      * fast/filesystem/workers/async-operations-expected.txt: Removed.
      * fast/filesystem/workers/async-operations.html: Removed.
      * fast/filesystem/workers/detached-frame-crash-expected.txt: Removed.
      * fast/filesystem/workers/detached-frame-crash.html: Removed.
      * fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Removed.
      * fast/filesystem/workers/file-entry-to-uri-sync.html: Removed.
      * fast/filesystem/workers/file-from-file-entry-expected.txt: Removed.
      * fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Removed.
      * fast/filesystem/workers/file-from-file-entry-sync.html: Removed.
      * fast/filesystem/workers/file-from-file-entry.html: Removed.
      * fast/filesystem/workers/file-writer-empty-blob-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-empty-blob.html: Removed.
      * fast/filesystem/workers/file-writer-events-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-events-shared-worker-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-events-shared-worker.html: Removed.
      * fast/filesystem/workers/file-writer-events.html: Removed.
      * fast/filesystem/workers/file-writer-gc-blob-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-gc-blob.html: Removed.
      * fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-sync-truncate-extend.html: Removed.
      * fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-sync-write-overlapped.html: Removed.
      * fast/filesystem/workers/file-writer-truncate-extend-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-truncate-extend.html: Removed.
      * fast/filesystem/workers/file-writer-write-overlapped-expected.txt: Removed.
      * fast/filesystem/workers/file-writer-write-overlapped.html: Removed.
      * fast/filesystem/workers/resources: Removed.
      * fast/filesystem/workers/resources/detached-frame-crash-frame.html: Removed.
      * fast/filesystem/workers/resources/detached-frame-crash-worker.js: Removed.
      * fast/filesystem/workers/simple-persistent-expected.txt: Removed.
      * fast/filesystem/workers/simple-persistent-sync-expected.txt: Removed.
      * fast/filesystem/workers/simple-persistent-sync.html: Removed.
      * fast/filesystem/workers/simple-persistent.html: Removed.
      * fast/filesystem/workers/simple-temporary-expected.txt: Removed.
      * fast/filesystem/workers/simple-temporary-sync-expected.txt: Removed.
      * fast/filesystem/workers/simple-temporary-sync.html: Removed.
      * fast/filesystem/workers/simple-temporary.html: Removed.
      * fast/filesystem/workers/sync-operations-expected.txt: Removed.
      * fast/filesystem/workers/sync-operations.html: Removed.
      * fast/forms/file/input-file-entries-expected.txt: Removed.
      * fast/forms/file/input-file-entries.html: Removed.
      * http/tests/filesystem: Removed.
      * http/tests/filesystem/no-cache-filesystem-url-expected.txt: Removed.
      * http/tests/filesystem/no-cache-filesystem-url.html: Removed.
      * http/tests/filesystem/resolve-uri-expected.txt: Removed.
      * http/tests/filesystem/resolve-uri.html: Removed.
      * http/tests/filesystem/resources: Removed.
      * http/tests/filesystem/resources/fs-test-util.js: Removed.
      * http/tests/filesystem/resources/fs-worker-common.js: Removed.
      * http/tests/filesystem/resources/fs-worker-test-util.js: Removed.
      * http/tests/filesystem/script-tests: Removed.
      * http/tests/filesystem/script-tests/TEMPLATE.html: Removed.
      * http/tests/filesystem/script-tests/resolve-uri.js: Removed.
      * http/tests/filesystem/workers: Removed.
      * http/tests/filesystem/workers/resolve-url-expected.txt: Removed.
      * http/tests/filesystem/workers/resolve-url-sync-expected.txt: Removed.
      * http/tests/filesystem/workers/resolve-url-sync.html: Removed.
      * http/tests/filesystem/workers/resolve-url.html: Removed.
      * http/tests/filesystem/workers/script-tests: Removed.
      * http/tests/filesystem/workers/script-tests/TEMPLATE.html: Removed.
      * http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Removed.
      * http/tests/inspector/filesystem: Removed.
      * http/tests/inspector/filesystem/delete-entry-expected.txt: Removed.
      * http/tests/inspector/filesystem/delete-entry.html: Removed.
      * http/tests/inspector/filesystem/directory-tree-expected.txt: Removed.
      * http/tests/inspector/filesystem/directory-tree.html: Removed.
      * http/tests/inspector/filesystem/filesystem-test.js: Removed.
      * http/tests/inspector/filesystem/request-directory-content-expected.txt: Removed.
      * http/tests/inspector/filesystem/request-directory-content.html: Removed.
      * http/tests/inspector/filesystem/request-file-content-expected.txt: Removed.
      * http/tests/inspector/filesystem/request-file-content.html: Removed.
      * http/tests/inspector/filesystem/request-filesystem-root-expected.txt: Removed.
      * http/tests/inspector/filesystem/request-filesystem-root.html: Removed.
      * http/tests/inspector/filesystem/request-metadata-expected.txt: Removed.
      * http/tests/inspector/filesystem/request-metadata.html: Removed.
      * http/tests/security/contentSecurityPolicy/filesystem-urls-match-self-expected.txt: Removed.
      * http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html: Removed.
      * http/tests/security/filesystem-iframe-from-remote-expected.txt: Removed.
      * http/tests/security/filesystem-iframe-from-remote.html: Removed.
      * http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Removed.
      * http/tests/security/mixedContent/filesystem-url-in-iframe.html: Removed.
      * http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
      * http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
      * http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
      * http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
      * http/tests/workers/resources/sync-operations.js:
      (onmessage):
      * http/tests/workers/terminate-during-sync-operation-expected.txt: Removed.
      * http/tests/workers/terminate-during-sync-operation.html: Removed.
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7df82b33
    • andersca@apple.com's avatar
      Get rid of more uses of OwnPtr and PassOwnPtr · c5e54cd2
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122136
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::didReceiveBinaryData):
      * WebCore.exp.in:
      * fileapi/Blob.cpp:
      (WebCore::Blob::Blob):
      (WebCore::Blob::slice):
      * fileapi/Blob.h:
      (WebCore::Blob::create):
      * fileapi/File.cpp:
      (WebCore::createBlobDataForFileWithType):
      (WebCore::createBlobDataForFile):
      (WebCore::createBlobDataForFileWithName):
      * fileapi/ThreadableBlobRegistry.cpp:
      (WebCore::BlobRegistryContext::BlobRegistryContext):
      (WebCore::registerBlobURLTask):
      (WebCore::ThreadableBlobRegistry::registerBlobURL):
      * fileapi/ThreadableBlobRegistry.h:
      * fileapi/WebKitBlobBuilder.cpp:
      (WebCore::BlobBuilder::getBlob):
      * platform/network/BlobData.cpp:
      (WebCore::BlobDataHandle::BlobDataHandle):
      * platform/network/BlobData.h:
      (WebCore::BlobData::BlobData):
      (WebCore::BlobDataHandle::create):
      * platform/network/BlobRegistry.h:
      * platform/network/BlobRegistryImpl.cpp:
      (WebCore::BlobRegistryImpl::registerBlobURL):
      * platform/network/BlobRegistryImpl.h:
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::responseBlob):
      
      Source/WebKit2:
      
      * NetworkProcess/AsynchronousNetworkLoaderClient.h:
      * NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
      (WebKit::NetworkBlobRegistry::registerBlobURL):
      * NetworkProcess/FileAPI/NetworkBlobRegistry.h:
      * NetworkProcess/NetworkResourceLoader.cpp:
      (WebKit::NetworkResourceLoader::NetworkResourceLoader):
      * NetworkProcess/NetworkResourceLoader.h:
      * NetworkProcess/SynchronousNetworkLoaderClient.h:
      * NetworkProcess/mac/RemoteNetworkingContext.mm:
      * Platform/CoreIPC/ArgumentDecoder.h:
      * Platform/CoreIPC/ArgumentEncoder.h:
      * Platform/CoreIPC/MessageDecoder.cpp:
      (CoreIPC::MessageDecoder::setImportanceAssertion):
      * Platform/CoreIPC/MessageDecoder.h:
      * Platform/CoreIPC/mac/ConnectionMac.cpp:
      (CoreIPC::Connection::receiveSourceEventHandler):
      * Platform/CoreIPC/mac/ImportanceAssertion.h:
      (CoreIPC::ImportanceAssertion::ImportanceAssertion):
      * Platform/mac/LayerHostingContext.h:
      * Platform/mac/LayerHostingContext.mm:
      (WebKit::LayerHostingContext::createForPort):
      (WebKit::LayerHostingContext::createForWindowServer):
      * PluginProcess/PluginControllerProxy.cpp:
      (WebKit::PluginControllerProxy::paint):
      * PluginProcess/PluginControllerProxy.h:
      * PluginProcess/WebProcessConnection.cpp:
      (WebKit::WebProcessConnection::addPluginControllerProxy):
      (WebKit::WebProcessConnection::removePluginControllerProxy):
      (WebKit::WebProcessConnection::createPluginInternal):
      * PluginProcess/WebProcessConnection.h:
      * Shared/API/c/cg/WKImageCG.cpp:
      (WKImageCreateFromCGImage):
      * Shared/BlockingResponseMap.h:
      (BlockingResponseMap::waitForResponse):
      (BlockingResponseMap::didReceiveResponse):
      * Shared/Downloads/Download.cpp:
      * Shared/Downloads/Download.h:
      * Shared/Downloads/DownloadManager.cpp:
      (WebKit::DownloadManager::startDownload):
      (WebKit::DownloadManager::convertHandleToDownload):
      * Shared/FileAPI/BlobRegistrationData.cpp:
      (WebKit::BlobRegistrationData::BlobRegistrationData):
      (WebKit::BlobRegistrationData::releaseData):
      (WebKit::BlobRegistrationData::decode):
      * Shared/FileAPI/BlobRegistrationData.h:
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      * Shared/Plugins/NPObjectMessageReceiver.h:
      * Shared/Plugins/NPRemoteObjectMap.cpp:
      (WebKit::NPRemoteObjectMap::registerNPObject):
      * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
      (WebKit::NetscapePluginModule::tryLoad):
      * Shared/Plugins/Netscape/NetscapePluginModule.h:
      * Shared/ShareableBitmap.h:
      * Shared/WebURL.h:
      (WebKit::WebURL::create):
      (WebKit::WebURL::WebURL):
      (WebKit::WebURL::parseURLIfNecessary):
      * Shared/cg/ShareableBitmapCG.cpp:
      (WebKit::ShareableBitmap::createGraphicsContext):
      (WebKit::ShareableBitmap::makeCGImageCopy):
      * Shared/mac/SecItemShim.cpp:
      (WebKit::sendSecItemRequest):
      (WebKit::webSecItemCopyMatching):
      (WebKit::webSecItemAdd):
      (WebKit::webSecItemUpdate):
      (WebKit::webSecItemDelete):
      (WebKit::SecItemShim::secItemResponse):
      * UIProcess/API/mac/FindIndicatorWindow.h:
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::createDrawingAreaProxy):
      * UIProcess/API/mac/WKView.mm:
      (-[WKView std::WebKit::]):
      (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
      * UIProcess/API/mac/WKViewInternal.h:
      * UIProcess/BackingStore.cpp:
      * UIProcess/BackingStore.h:
      * UIProcess/DrawingAreaProxyImpl.cpp:
      (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
      * UIProcess/DrawingAreaProxyImpl.h:
      * UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.h:
      * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
      * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
      * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
      * WebProcess/FileAPI/BlobRegistryProxy.cpp:
      (WebKit::BlobRegistryProxy::registerBlobURL):
      * WebProcess/FileAPI/BlobRegistryProxy.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
      * WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
      (WKBundlePageBannerCreateBannerWithCALayer):
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::imageForRect):
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::scheduleTimer):
      (WebKit::NetscapePlugin::unscheduleTimer):
      (WebKit::NetscapePlugin::snapshot):
      * WebProcess/Plugins/Netscape/NetscapePlugin.h:
      * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      (WebKit::PDFPlugin::snapshot):
      * WebProcess/Plugins/PluginProxy.cpp:
      (WebKit::PluginProxy::paint):
      (WebKit::PluginProxy::update):
      * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
      (WebKit::convertImageToBitmap):
      * WebProcess/WebPage/DrawingArea.cpp:
      (WebKit::DrawingArea::create):
      * WebProcess/WebPage/DrawingArea.h:
      * WebProcess/WebPage/DrawingAreaImpl.cpp:
      (WebKit::DrawingAreaImpl::display):
      * WebProcess/WebPage/DrawingAreaImpl.h:
      * WebProcess/WebPage/FindController.cpp:
      (WebKit::FindController::getFindIndicatorBitmapAndRect):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::createWithCoreMainFrame):
      (WebKit::WebFrame::createSubframe):
      (WebKit::WebFrame::create):
      (WebKit::WebFrame::WebFrame):
      * WebProcess/WebPage/WebFrame.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::scaledSnapshotWithOptions):
      (WebKit::WebPage::drawRectToImage):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/mac/LayerTreeHostMac.h:
      * WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
      * WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
      * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
      * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
      (WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5e54cd2
    • commit-queue@webkit.org's avatar
      Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data. · 18b1da9f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122115
      
      Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-30
      Reviewed by Daniel Bates.
      
      With BitmapImage::create(PassNativeImagePtr, ImageObserver*), a BitmapImage could be created by
      passing a native image.  If this image is added to memory cache, we shouldn't attempt to destroy
      its decoded frames since there is no encoded raw data and we won't be able to reconstruct the image again.
      
      No new tests for now. Currently there isn't a code path to add to the memory cache a BitmapImage
      that was created by adopting a native image. We'll add such a code path in a subsequent patch.
      
      * platform/graphics/BitmapImage.cpp:
      (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18b1da9f
    • antti@apple.com's avatar
      Remove FontTranscoder · 7530ae1f
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122088
      
      Reviewed by Andreas Kling.
      
      This overly generic class just implements mapping of backslash to yen symbol for some legacy Japanese fonts.
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.pri:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/Font.cpp:
      (WebCore::useBackslashAsYenSignForFamily):
              
          Move the family set to Font.cpp.
      
      (WebCore::Font::Font):
      (WebCore::Font::operator=):
      (WebCore::Font::update):
              
          Keep the cached boolean up to date.
      
      * platform/graphics/Font.h:
      (WebCore::Font::useBackslashAsYenSymbol):
              
          Use descriptive name instead of talking about "transcoding".
      
      * platform/text/transcoder: Removed.
      * platform/text/transcoder/FontTranscoder.cpp: Removed.
      * platform/text/transcoder/FontTranscoder.h: Removed.
      * rendering/RenderText.cpp:
      (WebCore::RenderText::RenderText):
      (WebCore::RenderText::computeUseBackslashAsYenSymbol):
              
          Rename for clarity. 
          Avoid unnecessary hash lookup, just check the cached bit in Font.
      
      (WebCore::RenderText::styleDidChange):
      (WebCore::RenderText::setTextInternal):
              
          "Transcoding" here was just a simple character replacement.
      
      (WebCore::RenderText::textWithoutConvertingBackslashToYenSymbol):
              
          Renamed.
      
      * rendering/RenderText.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7530ae1f
    • jer.noble@apple.com's avatar
      Unreviewed Mac-Lion build fix. · b8dfb66a
      jer.noble@apple.com authored
      Use metadataItemsFromArray:withLocale: instead of
      metadataItemsFromArray:filteredAndSortedAccordingToPreferredLanguages:
      on Lion and earlier.
      
      * platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
      (WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8dfb66a
    • jer.noble@apple.com's avatar
      [Mac] Add AudioTrack support to MediaPlayerPrivateAVFObC. · 876b8519
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122043
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      Test: media/track/audio-track.html
      
      Add a new class AudioTrackPrivateAVF and subclass AudioTrackPrivateAVFObjC
      which are backed by a AVPlayerItemTrack. Create one of these tracks when
      we are notified that the list of available tracks has changed.
      
      * WebCore.xcodeproj/project.pbxproj:
      * html/track/AudioTrack.cpp:
      (WebCore::AudioTrack::setEnabled): Pass through to the AudioTrackPrivate
          so that the underlying media track can be (dis|en)abled.
      * platform/graphics/avfoundation/AudioTrackPrivateAVF.h: Added.
      (WebCore::AudioTrackPrivateAVF::kind): Simple getter.
      (WebCore::AudioTrackPrivateAVF::id): Ditto.
      (WebCore::AudioTrackPrivateAVF::label): Ditto.
      (WebCore::AudioTrackPrivateAVF::language): Ditto.
      (WebCore::AudioTrackPrivateAVF::setKind): Simple Setter.
      (WebCore::AudioTrackPrivateAVF::setId): Ditto.
      (WebCore::AudioTrackPrivateAVF::setLabel): Ditto.
      (WebCore::AudioTrackPrivateAVF::setLanguage): Ditto.
      (WebCore::AudioTrackPrivateAVF::AudioTrackPrivateAVF): Simple constructor.
      * platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h: Added.
      (WebCore::AudioTrackPrivateAVFObjC::create): Simple factory.
      (WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Simple getter.
      * platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm: Added.
      (WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Call resetPropertiesFromTrack.
      (WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Fill out the values from
          the associated AVPlayerItemTrack and its AVAssetTrack.
      (WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Call resetPropertiesFromTrack.
      (WebCore::AudioTrackPrivateAVFObjC::setEnabled): (En|Dis)able the AVPlayerItemTrack.
      (WebCore::AudioTrackPrivateAVFObjC::languageForAVAssetTrack): Refactored from
          MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack.
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Determine which tracks
          have been added or removed and notify the clients accordingly.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Refactor into
          AudioTrackPrivateAVFObjC::languageForAVAssetTrack.
      
      LayoutTests:
      
      * media/track/audio-track-expected.txt: Added.
      * media/track/audio-track.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      876b8519
  3. 29 Sep, 2013 1 commit
    • darin@apple.com's avatar
      Use RenderElement instead of RenderObject in many places · 8cdf7124
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122078
      
      Reviewed by Andreas Kling.
      
      Source/ThirdParty/ANGLE:
      
      * ANGLE.xcodeproj/project.pbxproj: Let Xcode do its thing to this file.
      
      Source/WebCore:
      
      * WebCore.exp.in: Updated for name changes.
      
      * dom/ContainerNode.h: Moved renderer() here from Element.
      * dom/Element.h: Moved renderer() from here to ContainerNode.
      * render/RenderElement.h: Moved renderer() from Element to ContainerNode.
      
      * accessibility/AccessibilityImageMapLink.cpp:
      (WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
      (WebCore::AccessibilityImageMapLink::detachFromParent):
      (WebCore::AccessibilityImageMapLink::elementPath):
      (WebCore::AccessibilityImageMapLink::elementRect):
      * accessibility/AccessibilityImageMapLink.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
      * bindings/objc/DOM.mm:
      (-[DOMElement image]):
      (-[DOMElement _font]):
      (-[DOMElement _imageTIFFRepresentation]):
      * css/CSSCanvasValue.cpp:
      (WebCore::CSSCanvasValue::canvasChanged):
      (WebCore::CSSCanvasValue::canvasResized):
      (WebCore::CSSCanvasValue::canvasDestroyed):
      (WebCore::CSSCanvasValue::fixedSize):
      (WebCore::CSSCanvasValue::image):
      * css/CSSCanvasValue.h:
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::computeRenderStyleForProperty):
      * css/CSSCrossfadeValue.cpp:
      (WebCore::subimageKnownToBeOpaque):
      (WebCore::CSSCrossfadeValue::fixedSize):
      (WebCore::CSSCrossfadeValue::knownToBeOpaque):
      (WebCore::CSSCrossfadeValue::image):
      (WebCore::CSSCrossfadeValue::crossfadeChanged):
      * css/CSSCrossfadeValue.h:
      * css/CSSFilterImageValue.cpp:
      (WebCore::CSSFilterImageValue::fixedSize):
      (WebCore::CSSFilterImageValue::knownToBeOpaque):
      (WebCore::CSSFilterImageValue::image):
      (WebCore::CSSFilterImageValue::filterImageChanged):
      * css/CSSFilterImageValue.h:
      * css/CSSFontSelector.cpp:
      * css/CSSGradientValue.cpp:
      (WebCore::CSSGradientValue::image):
      (WebCore::CSSGradientValue::addStops):
      (WebCore::CSSGradientValue::knownToBeOpaque):
      (WebCore::CSSLinearGradientValue::createGradient):
      (WebCore::CSSRadialGradientValue::createGradient):
      * css/CSSGradientValue.h:
      (WebCore::CSSGradientValue::fixedSize):
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::addClient):
      (WebCore::CSSImageGeneratorValue::removeClient):
      (WebCore::CSSImageGeneratorValue::image):
      (WebCore::CSSImageGeneratorValue::fixedSize):
      (WebCore::CSSImageGeneratorValue::knownToBeOpaque):
      * css/CSSImageGeneratorValue.h:
      (WebCore::CSSImageGeneratorValue::clients):
      * css/CSSImageValue.cpp:
      (WebCore::CSSImageValue::knownToBeOpaque):
      * css/CSSImageValue.h:
      * css/DeprecatedStyleBuilder.cpp:
      * dom/DocumentMarkerController.cpp:
      (WebCore::DocumentMarkerController::removeMarkersFromList):
      (WebCore::DocumentMarkerController::repaintMarkers):
      * dom/Element.cpp:
      (WebCore::localZoomForRenderer):
      (WebCore::adjustForLocalZoom):
      (WebCore::Element::offsetParent):
      (WebCore::Element::updateExistingPseudoElement):
      * dom/ElementRareData.h:
      (WebCore::ElementRareData::create):
      (WebCore::ElementRareData::ElementRareData):
      * dom/Node.cpp:
      (WebCore::Node::ensureRareData):
      * editing/DeleteButtonController.cpp:
      (WebCore::isDeletableElement):
      * editing/Editor.cpp:
      (WebCore::Editor::hasBidiSelection):
      (WebCore::Editor::baseWritingDirectionForSelectionStart):
      * editing/EditorCommand.cpp:
      (WebCore::verticalScrollDistance):
      * editing/htmlediting.cpp:
      (WebCore::directionOfEnclosingBlock):
      * editing/ios/EditorIOS.mm:
      (WebCore::Editor::fontForSelection):
      (WebCore::getImage):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontForSelection):
      (WebCore::getImage):
      * editing/markup.cpp:
      * html/HTMLAreaElement.cpp:
      (WebCore::HTMLAreaElement::computePath):
      (WebCore::HTMLAreaElement::computeRect):
      (WebCore::HTMLAreaElement::setFocus):
      * html/HTMLAreaElement.h:
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::reset):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::setInnerText):
      * html/HTMLFormControlElement.cpp:
      (WebCore::updateFromElementCallback):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::rendererIsNeeded):
      * html/HTMLFrameOwnerElement.h:
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::x):
      (WebCore::HTMLImageElement::y):
      (WebCore::HTMLImageElement::willRespondToMouseClickEvents):
      * html/HTMLMapElement.cpp:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::defaultEventHandler):
      * html/HTMLMeterElement.cpp:
      (WebCore::HTMLMeterElement::renderMeter):
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::didRecalcStyle):
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
      (WebCore::HTMLPlugInElement::defaultEventHandler):
      (WebCore::HTMLPlugInElement::isKeyboardFocusable):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::defaultEventHandler):
      * html/HTMLProgressElement.cpp:
      (WebCore::HTMLProgressElement::renderProgress):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::scrollToSelection):
      (WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
      (WebCore::HTMLSelectElement::selectOption):
      * html/HTMLTableCellElement.cpp:
      (WebCore::HTMLTableCellElement::cellAbove):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::hasVisibleTextArea):
      (WebCore::HTMLTextFormControlElement::setSelectionRange):
      * html/InputType.h:
      * html/parser/HTMLResourcePreloader.cpp:
      * html/shadow/MediaControlElementTypes.cpp:
      (WebCore::MediaControlElement::setDisplayType):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::startDrag):
      (WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
      * html/shadow/MeterShadowElement.cpp:
      (WebCore::MeterShadowElement::rendererIsNeeded):
      (WebCore::MeterInnerElement::rendererIsNeeded):
      * inspector/InspectorOverlay.cpp:
      * inspector/InspectorTimelineAgent.cpp:
      * inspector/InspectorTimelineAgent.h:
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::renderImageResource):
      * loader/cache/CachedImage.cpp:
      (WebCore::CachedImage::currentFrameKnownToBeOpaque):
      * loader/cache/CachedImage.h:
      * mathml/MathMLElement.cpp:
      * page/ContextMenuController.cpp:
      * page/DragController.cpp:
      (WebCore::DragController::draggableElement):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler):
      (WebCore::EventHandler::clear):
      (WebCore::EventHandler::startPanScrolling):
      (WebCore::EventHandler::autoscrollRenderer):
      (WebCore::EventHandler::scrollOverflow):
      (WebCore::EventHandler::logicalScrollOverflow):
      (WebCore::EventHandler::subframeForTargetNode):
      (WebCore::EventHandler::selectCursor):
      (WebCore::layerForNode):
      (WebCore::EventHandler::handleWheelEvent):
      (WebCore::EventHandler::clearGestureScrollNodes):
      * page/EventHandler.h:
      * page/FocusController.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::ownerRenderer):
      (WebCore::Frame::visiblePositionForPoint):
      (WebCore::Frame::nodeImage):
      * page/FrameView.cpp:
      (WebCore::FrameView::applyOverflowToViewport):
      (WebCore::FrameView::applyPaginationToViewport):
      (WebCore::FrameView::calculateScrollbarModesForLayout):
      (WebCore::FrameView::isEnclosedInCompositingLayer):
      (WebCore::FrameView::embeddedContentBox):
      (WebCore::FrameView::addSlowRepaintObject):
      (WebCore::FrameView::removeSlowRepaintObject):
      (WebCore::FrameView::addViewportConstrainedObject):
      (WebCore::FrameView::removeViewportConstrainedObject):
      (WebCore::FrameView::scrollContentsFastPath):
      (WebCore::FrameView::repaintSlowRepaintObjects):
      (WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
      (WebCore::FrameView::updateOverflowStatus):
      (WebCore::FrameView::updateScrollCorner):
      (WebCore::FrameView::paintContents):
      (WebCore::FrameView::convertFromRenderer):
      (WebCore::FrameView::convertToRenderer):
      * page/FrameView.h:
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::addImageToResources):
      * page/PageSerializer.h:
      * page/animation/AnimationBase.cpp:
      (WebCore::AnimationBase::AnimationBase):
      (WebCore::AnimationBase::updateStateMachine):
      * page/animation/AnimationBase.h:
      (WebCore::AnimationBase::renderer):
      * page/animation/AnimationController.cpp:
      (WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
      (WebCore::AnimationControllerPrivate::clear):
      (WebCore::AnimationControllerPrivate::updateAnimations):
      (WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
      (WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer):
      (WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
      (WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
      (WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
      (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
      (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
      (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
      (WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
      (WebCore::AnimationController::cancelAnimations):
      (WebCore::AnimationController::updateAnimations):
      (WebCore::AnimationController::getAnimatedStyleForRenderer):
      (WebCore::AnimationController::notifyAnimationStarted):
      (WebCore::AnimationController::pauseAnimationAtTime):
      (WebCore::AnimationController::pauseTransitionAtTime):
      (WebCore::AnimationController::isRunningAnimationOnRenderer):
      (WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):
      * page/animation/AnimationController.h:
      * page/animation/AnimationControllerPrivate.h:
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::crossfadeBlend):
      * page/animation/CompositeAnimation.cpp:
      (WebCore::CompositeAnimation::updateTransitions):
      (WebCore::CompositeAnimation::updateKeyframeAnimations):
      (WebCore::CompositeAnimation::animate):
      * page/animation/CompositeAnimation.h:
      * page/animation/ImplicitAnimation.cpp:
      (WebCore::ImplicitAnimation::ImplicitAnimation):
      (WebCore::ImplicitAnimation::animate):
      (WebCore::ImplicitAnimation::pauseAnimation):
      (WebCore::ImplicitAnimation::sendTransitionEvent):
      * page/animation/ImplicitAnimation.h:
      (WebCore::ImplicitAnimation::create):
      * page/animation/KeyframeAnimation.cpp:
      (WebCore::KeyframeAnimation::KeyframeAnimation):
      (WebCore::KeyframeAnimation::animate):
      (WebCore::KeyframeAnimation::pauseAnimation):
      (WebCore::KeyframeAnimation::endAnimation):
      (WebCore::KeyframeAnimation::sendAnimationEvent):
      * page/animation/KeyframeAnimation.h:
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
      (WebCore::EventHandler::passSubframeEventToSubframe):
      * page/mac/FrameSnapshottingMac.mm:
      (WebCore::snapshotDragImage):
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::paint):
      * rendering/CounterNode.cpp:
      (WebCore::CounterNode::CounterNode):
      (WebCore::CounterNode::create):
      * rendering/CounterNode.h:
      (WebCore::CounterNode::owner):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::buildReferenceFilter):
      (WebCore::FilterEffectRenderer::build):
      * rendering/FilterEffectRenderer.h:
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::spellingToolTip):
      (WebCore::HitTestResult::title):
      (WebCore::HitTestResult::innerTextIfTruncated):
      (WebCore::HitTestResult::image):
      * rendering/LayoutRepainter.cpp:
      (WebCore::LayoutRepainter::LayoutRepainter):
      * rendering/LayoutRepainter.h:
      * rendering/LayoutState.h:
      (WebCore::LayoutState::LayoutState):
      * rendering/LineWidth.h:
      * rendering/LogicalSelectionOffsetCaches.h:
      (WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject):
      (WebCore::isNonRenderBlockInline):
      (WebCore::containingBlockForFixedPosition):
      (WebCore::containingBlockForAbsolutePosition):
      (WebCore::containingBlockForObjectInFlow):
      (WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
      * rendering/PaintInfo.h:
      (WebCore::PaintInfo::PaintInfo):
      (WebCore::PaintInfo::updateSubtreePaintRootForChildren):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::paintFillLayers):
      (WebCore::RenderBox::paintFillLayer):
      * rendering/RenderBox.h:
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderCounter.cpp:
      (WebCore::nextInPreOrder):
      (WebCore::planCounter):
      (WebCore::makeCounterNode):
      (WebCore::RenderCounter::originalText):
      * rendering/RenderElement.cpp:
      (WebCore::RenderElement::~RenderElement):
      (WebCore::RenderElement::insertChildInternal):
      (WebCore::RenderElement::removeChildInternal):
      (WebCore::RenderElement::willBeDestroyed):
      (WebCore::RenderElement::rendererForRootBackground):
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::initialize):
      * rendering/RenderImageResource.h:
      * rendering/RenderImageResourceStyleImage.cpp:
      (WebCore::RenderImageResourceStyleImage::initialize):
      * rendering/RenderImageResourceStyleImage.h:
      (WebCore::RenderImageResourceStyleImage::create):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
      (WebCore::RenderLayerCompositor::requiresCompositingLayer):
      (WebCore::RenderLayerCompositor::canBeComposited):
      (WebCore::RenderLayerCompositor::requiresOwnBackingStore):
      (WebCore::RenderLayerCompositor::reasonsForCompositing):
      (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
      (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
      (WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
      (WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
      (WebCore::RenderLayerCompositor::requiresCompositingForFrame):
      (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
      (WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
      (WebCore::RenderLayerCompositor::requiresCompositingForFilters):
      (WebCore::RenderLayerCompositor::requiresCompositingForBlending):
      (WebCore::RenderLayerCompositor::requiresCompositingForPosition):
      (WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):
      * rendering/RenderLayerCompositor.h:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::containingBlock):
      (WebCore::mustRepaintFillLayers):
      (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered):
      (WebCore::RenderObject::willBeDestroyed):
      * rendering/RenderScrollbarPart.cpp:
      (WebCore::RenderScrollbarPart::rendererOwningScrollbar):
      * rendering/RenderScrollbarPart.h:
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::paintBackgroundsBehindCell):
      * rendering/RenderTableCell.h:
      * rendering/RenderView.cpp:
      (WebCore::RenderView::RenderView):
      * rendering/style/FillLayer.cpp:
      (WebCore::FillLayer::hasOpaqueImage):
      * rendering/style/FillLayer.h:
      * rendering/style/KeyframeList.h:
      (WebCore::KeyframeList::KeyframeList):
      * rendering/style/StyleCachedImage.cpp:
      (WebCore::StyleCachedImage::imageSize):
      (WebCore::StyleCachedImage::computeIntrinsicDimensions):
      (WebCore::StyleCachedImage::setContainerSizeForRenderer):
      (WebCore::StyleCachedImage::addClient):
      (WebCore::StyleCachedImage::removeClient):
      (WebCore::StyleCachedImage::image):
      (WebCore::StyleCachedImage::knownToBeOpaque):
      * rendering/style/StyleCachedImage.h:
      * rendering/style/StyleCachedImageSet.cpp:
      (WebCore::StyleCachedImageSet::imageSize):
      (WebCore::StyleCachedImageSet::computeIntrinsicDimensions):
      (WebCore::StyleCachedImageSet::setContainerSizeForRenderer):
      (WebCore::StyleCachedImageSet::addClient):
      (WebCore::StyleCachedImageSet::removeClient):
      (WebCore::StyleCachedImageSet::image):
      (WebCore::StyleCachedImageSet::knownToBeOpaque):
      * rendering/style/StyleCachedImageSet.h:
      * rendering/style/StyleGeneratedImage.cpp:
      (WebCore::StyleGeneratedImage::imageSize):
      (WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
      (WebCore::StyleGeneratedImage::addClient):
      (WebCore::StyleGeneratedImage::removeClient):
      (WebCore::StyleGeneratedImage::image):
      (WebCore::StyleGeneratedImage::knownToBeOpaque):
      * rendering/style/StyleGeneratedImage.h:
      * rendering/style/StyleImage.h:
      (WebCore::StyleImage::imagesEquivalent):
      * rendering/style/StylePendingImage.h:
      (WebCore::StylePendingImage::cssImageValue):
      (WebCore::StylePendingImage::cssImageGeneratorValue):
      (WebCore::StylePendingImage::cssCursorImageValue):
      (WebCore::StylePendingImage::cssImageSetValue):
      (WebCore::StylePendingImage::computeIntrinsicDimensions):
      * testing/Internals.cpp:
      (WebCore::Internals::boundingBox):
      (WebCore::Internals::isSelectPopupVisible):
      (WebCore::Internals::isPluginUnavailabilityIndicatorObscured):
      Use RenderElement instead of RenderObject where it was easy to do so.
      For local variables holding the return value of renderer() functions,
      use auto instead, so the most-specific possible type will be used,
      without having to figure out what that is in each case. Also use some
      more OVERRIDE and FINAL and use nullptr instead of 0. And replace some
      cryptic short local variable names with words.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cdf7124
  4. 28 Sep, 2013 2 commits
    • antti@apple.com's avatar
      Switch inline boxes to use const RenderStyle& · 78e56776
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122068
      
      Reviewed by Sam Weinig.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78e56776
    • mrowe@apple.com's avatar
      WebCore fails to build with newer versions of clang. · 00e249e3
      mrowe@apple.com authored
      Reviewed by Sam Weinig.
      
      * Modules/indexeddb/IDBIndex.cpp: Remove an unused constant.
      * Modules/indexeddb/IDBObjectStore.cpp: Ditto.
      * Modules/webaudio/AudioContext.cpp: Ditto.
      * Modules/webaudio/ScriptProcessorNode.cpp: Ditto.
      * Modules/webdatabase/SQLResultSet.cpp: Ditto.
      * Modules/webdatabase/SQLTransactionBackend.cpp: Ditto.
      * Modules/websockets/WebSocketHandshake.cpp: Ditto.
      * bindings/objc/DOM.mm: Disable a warning about overriding a protocol method in a cateogry around the one
      place we do it. I don't understand why this generates a warning, nor can I see a different approach that
      would not result in the warning being emitted.
      * css/CSSGrammar.y.in: #if a function that's only used inside an #if.
      * html/track/TextTrackCue.cpp: Remove an unused constant.
      * loader/TextResourceDecoder.cpp: Remove two unused functions.
      * page/ContentSecurityPolicy.cpp: Add #if's around constants and functions that are only used when CSP_NEXT is enabled.
      (WebCore::CSPDirectiveList::checkSourceAndReportViolation): Reorder the ifs slightly to make the #if'ing easier.
      * page/ContentSecurityPolicy.h: Add #if's around functions that are only used when CSP_NEXT is enabled.
      * page/DOMSecurityPolicy.cpp: Ditto.
      * page/DOMSecurityPolicy.h: Ditto.
      * page/animation/CSSPropertyAnimation.cpp: Remove an unused function.
      * platform/mac/DisplaySleepDisabler.cpp: Add an #if around a constant that's only used on iOS.
      * platform/mac/WebCoreFullScreenWarningView.mm: Remove three unused constants.
      * rendering/RenderLayer.cpp: Remove two unused constants.
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::compositingLogEnabled): Move the #if around the function definition.
      * svg/SVGAnimatedAngle.cpp: Remove an unused function.
      * svg/SVGUseElement.cpp: #if a function that's only used inside an ASSERT.
      * xml/XPathStep.cpp: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00e249e3
  5. 27 Sep, 2013 11 commits
    • enrica@apple.com's avatar
      Upstream changes to Pasteboard implementation for iOS. · 38848efa
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121818
      
      Reviewed by Benjamin Poulain.
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      * editing/Editor.cpp:
      (WebCore::Editor::dispatchCPPEvent):
      * editing/ios/EditorIOS.mm:
      (WebCore::Editor::WebContentReader::addFragment):
      (WebCore::Editor::WebContentReader::readWebArchive):
      (WebCore::Editor::WebContentReader::readFilenames):
      (WebCore::Editor::WebContentReader::readHTML):
      (WebCore::Editor::WebContentReader::readRTFD):
      (WebCore::Editor::WebContentReader::readRTF):
      (WebCore::uniqueURLWithRelativePart):
      (WebCore::Editor::WebContentReader::readImage):
      (WebCore::Editor::WebContentReader::readURL):
      (WebCore::Editor::WebContentReader::readPlainText):
      (WebCore::Editor::webContentFromPasteboard):
      (WebCore::Editor::pasteWithPasteboard):
      (WebCore::Editor::createFragmentAndAddResources):
      (WebCore::Editor::createFragmentForImageResourceAndAddResource):
      * platform/Pasteboard.h:
      * platform/PasteboardStrategy.h:
      * platform/PlatformPasteboard.h:
      * platform/ios/PasteboardIOS.mm:
      (WebCore::PasteboardWebContent::PasteboardWebContent):
      (WebCore::PasteboardWebContent::~PasteboardWebContent):
      (WebCore::PasteboardImage::PasteboardImage):
      (WebCore::PasteboardImage::~PasteboardImage):
      (WebCore::Pasteboard::Pasteboard):
      (WebCore::Pasteboard::clear):
      (WebCore::Pasteboard::readString):
      (WebCore::Pasteboard::writeString):
      (WebCore::Pasteboard::types):
      * platform/ios/PlatformPasteboardIOS.mm:
      (WebCore::PlatformPasteboard::changeCount):
      (WebCore::PlatformPasteboard::write):
      (WebCore::PlatformPasteboard::count):
      (WebCore::PlatformPasteboard::readBuffer):
      (WebCore::PlatformPasteboard::readString):
      (WebCore::PlatformPasteboard::readURL):
      * platform/mac/PasteboardMac.mm:
      (WebCore::PasteboardWebContent::PasteboardWebContent):
      (WebCore::PasteboardWebContent::~PasteboardWebContent):
      (WebCore::PasteboardImage::PasteboardImage):
      (WebCore::PasteboardImage::~PasteboardImage):
      * platform/mac/PlatformPasteboardMac.mm:
      
      Source/WebKit/mac: 
      
      * WebCoreSupport/WebPlatformStrategies.h:
      * WebCoreSupport/WebPlatformStrategies.mm:
      (WebPlatformStrategies::writeToPasteboard):
      (WebPlatformStrategies::getPasteboardItemsCount):
      (WebPlatformStrategies::readBufferFromPasteboard):
      (WebPlatformStrategies::readURLFromPasteboard):
      (WebPlatformStrategies::readStringFromPasteboard):
      (WebPlatformStrategies::changeCount):
      
      Source/WebKit2: 
      
      * Shared/WebCoreArgumentCoders.cpp:
      (CoreIPC::decodeSharedBuffer):
      * Shared/WebCoreArgumentCoders.h:
      * UIProcess/WebContext.h:
      * UIProcess/WebContext.messages.in:
      * UIProcess/mac/WebContextMac.mm:
      (WebKit::WebContext::writeWebContentToPasteboard):
      (WebKit::WebContext::writeImageToPasteboard):
      (WebKit::WebContext::writeStringToPasteboard):
      (WebKit::WebContext::readStringFromPasteboard):
      (WebKit::WebContext::readURLFromPasteboard):
      (WebKit::WebContext::readBufferFromPasteboard):
      (WebKit::WebContext::getPasteboardItemsCount):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::writeToPasteboard):
      (WebKit::WebPlatformStrategies::getPasteboardItemsCount):
      (WebKit::WebPlatformStrategies::readBufferFromPasteboard):
      (WebKit::WebPlatformStrategies::readURLFromPasteboard):
      (WebKit::WebPlatformStrategies::readStringFromPasteboard):
      (WebKit::WebPlatformStrategies::changeCount):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38848efa
    • hmuller@adobe.com's avatar
      Crash on shape-outside when using calc() · df9b2640
      hmuller@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121020
      
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      This change prevents a crash caused by specifying a CSS Shape geometry
      Length attribute with a calc() expression. It adds support for converting
      Lengths to CSSPrimitive Values, in large part by migrating Blink changes
      made to the calc classes since the split. Doing so required a few supporting
      changes in some related classes, notably CSSPrimitiveValue.
      
      Tests: fast/shapes/shape-inside/shape-inside-calc-crash.html
             css3/calc/simplification.html
      
      * css/BasicShapeFunctions.cpp:
      (WebCore::convertToCSSPrimitiveValue): Effectively use the new CSSPrimtiveValue(length,style) constructor to convert Lengths to CSSValues.
      (WebCore::valueForBasicShape): Use the convertToCSSPrimitiveValue() function.
      (WebCore::convertToLength): Added the CalculatedConversion convertToLength() flag to enable support for calc() valued Length Shape attributes.
      * css/BasicShapeFunctions.h:
      * css/CSSCalculationValue.cpp:
      (WebCore::hasDoubleValue):
      (WebCore::buildCssText):
      (WebCore::CSSCalcValue::clampToPermittedRange):
      (WebCore::CSSCalcValue::doubleValue):
      (WebCore::CSSCalcExpressionNode::~CSSCalcExpressionNode):
      (WebCore::CSSCalcPrimitiveValue::create):
      (WebCore::CSSCalcPrimitiveValue::toCalcValue):
      (WebCore::CSSCalcPrimitiveValue::doubleValue):
      (WebCore::CSSCalcPrimitiveValue::computeLengthPx):
      (WebCore::CSSCalcPrimitiveValue::primitiveType):
      (WebCore::CSSCalcPrimitiveValue::CSSCalcPrimitiveValue):
      (WebCore::determineCategory):
      (WebCore::isIntegerResult):
      (WebCore::CSSCalcBinaryOperation::create):
      (WebCore::CSSCalcBinaryOperation::createSimplified):
      (WebCore::CSSCalcBinaryOperation::doubleValue):
      (WebCore::CSSCalcBinaryOperation::buildCssText):
      (WebCore::CSSCalcBinaryOperation::primitiveType):
      (WebCore::CSSCalcBinaryOperation::CSSCalcBinaryOperation):
      (WebCore::CSSCalcBinaryOperation::getNumberSide):
      (WebCore::CSSCalcBinaryOperation::evaluate):
      (WebCore::CSSCalcBinaryOperation::evaluateOperator):
      (WebCore::CSSCalcExpressionNodeParser::parseValue):
      (WebCore::CSSCalcExpressionNodeParser::parseValueTerm):
      (WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
      (WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):
      (WebCore::CSSCalcValue::createExpressionNode):
      (WebCore::CSSCalcValue::create):
      * css/CSSCalculationValue.h:
      (WebCore::CSSCalcExpressionNode::category):
      (WebCore::CSSCalcValue::create):
      (WebCore::CSSCalcValue::isInt):
      (WebCore::CSSCalcValue::permittedValueRange):
      (WebCore::CSSCalcValue::expressionNode):
      (WebCore::CSSCalcValue::CSSCalcValue):
      (WebCore::toCSSCalcValue):
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::ComputedStyleExtractor::propertyValue): Pass the style along to the new valueForBasicShape() function.
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::unitCategory): Made this function public so that CSSCalculationValue could use it.
      (WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor): Ditto.
      (WebCore::CSSPrimitiveValue::primitiveType): Cleared trailing whitespace.
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Construct a CSSPrimitiveValue from a Length and a RenderStyle*.
      (WebCore::CSSPrimitiveValue::init): The common part of the two Length CSSPrimitiveValue constructors.
      (WebCore::CSSPrimitiveValue::computeLengthDouble): Moved the case labels to the left per check-webkit-style.
      (WebCore::CSSPrimitiveValue::getStringValue): Ditto.
      (WebCore::CSSPrimitiveValue::getDoubleValue): Removed trailing whitespace.
      * css/CSSPrimitiveValue.h:
      (WebCore::CSSPrimitiveValue::create): Construct a CSSPrimitiveValue from a Length and a RenderStyle*.
      (WebCore::toCSSPrimitiveValue): Check the CSSValue*'s validity with ASSERT_WITH_SECURITY_IMPLICATION before casting to CSSPrimitiveValue*.
      * css/CSSValuePool.h:
      (WebCore::CSSValuePool::createValue): A new overload that delegates to the new CSSPrimitiveValue(length,style) constructor.
      * platform/CalculationValue.h:
      (WebCore::CalculationValue::operator==):
      (WebCore::CalculationValue::isNonNegative):
      (WebCore::CalculationValue::expression):
      (WebCore::CalcExpressionNumber::value):
      (WebCore::toCalcExpressionNumber):
      (WebCore::CalcExpressionLength::CalcExpressionLength):
      (WebCore::CalcExpressionLength::length):
      (WebCore::toCalcExpressionLength):
      (WebCore::CalcExpressionBinaryOperation::leftSide):
      (WebCore::CalcExpressionBinaryOperation::rightSide):
      (WebCore::CalcExpressionBinaryOperation::getOperator):
      (WebCore::toCalcExpressionBinaryOperation):
      (WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
      (WebCore::CalcExpressionBlendLength::from):
      (WebCore::CalcExpressionBlendLength::to):
      (WebCore::CalcExpressionBlendLength::progress):
      (WebCore::toCalcExpressionBlendLength):
      
      LayoutTests:
      
      Specifying a CSS Shape geometry Length attribute with a calc() expression
      or looking up the value with getComputedStyle(), caused crashes.
      
      * fast/shapes/shape-inside/shape-inside-calc-crash-expected.txt: Added.
      * fast/shapes/shape-inside/shape-inside-calc-crash.html: Added.
      * css3/calc/simplification-expected.txt: Added
      * css3/calc/simplification.html: Added
      * LayoutTests/css3/calc/cssom-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df9b2640
    • commit-queue@webkit.org's avatar
      Get MediaStreamCenterGStreamer compiling again · 1857f563
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122029
      
      After MediaStream cleanup commit, it was not building anymore.
      
      Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
      Reviewed by Eric Carlson.
      
      No new tests needed.
      
      * platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1857f563
    • commit-queue@webkit.org's avatar
      Storing a reference to MediaStreamTrack in RTCStatsRequest · 13739695
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122030
      
      Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
      Reviewed by Eric Carlson.
      
      The spec[1] says that the stats is related to a MediaStreamTrack object.
      It also says: "Evaluate the need for other selectors than MediaStreamTrack".
      So a MediaStreamTrack object is more suitable in this case.
      
      [1]http://dev.w3.org/2011/webrtc/editor/webrtc.html#stats-selector
      
      No new tests needed.
      
      * Modules/mediastream/RTCStatsRequestImpl.cpp:
      (WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
      (WebCore::RTCStatsRequestImpl::hasSelector):
      (WebCore::RTCStatsRequestImpl::track):
      * Modules/mediastream/RTCStatsRequestImpl.h:
      * platform/mediastream/RTCStatsRequest.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13739695
    • commit-queue@webkit.org's avatar
      [Nix] Updating Nix trunk files · b4b8227d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121752
      
      Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
      Reviewed by Benjamin Poulain.
      
      Source/WebCore:
      
      No new tests needed.
      
      * page/nix/EventHandlerNix.cpp:
      (WebCore::EventHandler::focusDocumentView):
      (WebCore::EventHandler::passWheelEventToWidget):
      (WebCore::EventHandler::passMousePressEventToSubframe):
      (WebCore::EventHandler::passMouseMoveEventToSubframe):
      (WebCore::EventHandler::passMouseReleaseEventToSubframe):
      * platform/DragImage.h:
      * platform/graphics/GraphicsContext3D.h:
      * platform/nix/DragImageNix.cpp:
      (WebCore::createDragImageFromImage):
      * platform/nix/GamepadsNix.cpp:
      (WebCore::sampleGamepads):
      * platform/nix/LanguageNix.cpp:
      (WebCore::platformLanguage):
      * platform/nix/LocalizedStringsNix.cpp:
      (WebCore::unacceptableTLSCertificate):
      * platform/nix/PasteboardNix.cpp:
      (WebCore::Pasteboard::types):
      * platform/nix/RenderThemeNix.cpp:
      (WebCore::toColor):
      (WebCore::themeEngine):
      (WebCore::webCanvas):
      (WebCore::getWebThemeState):
      (WebCore::RenderThemeNix::paintButton):
      (WebCore::RenderThemeNix::paintTextField):
      (WebCore::RenderThemeNix::paintCheckbox):
      (WebCore::RenderThemeNix::paintRadio):
      (WebCore::RenderThemeNix::paintMenuList):
      (WebCore::RenderThemeNix::paintProgressBar):
      (WebCore::RenderThemeNix::paintInnerSpinButton):
      (WebCore::RenderThemeNix::paintMeter):
      
      Source/WTF:
      
      * wtf/nix/FeatureDefinesNix.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4b8227d
    • andersca@apple.com's avatar
      Use std::unique_ptr for GraphicsLayer creation · cc3b2dc6
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=122020
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      * platform/graphics/GraphicsLayer.h:
      * platform/graphics/GraphicsLayerFactory.h:
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayer::create):
      * platform/graphics/ca/GraphicsLayerCA.h:
      * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
      (WebCore::CompositingCoordinator::createGraphicsLayer):
      * platform/graphics/texmap/coordinated/CompositingCoordinator.h:
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::createGraphicsLayer):
      (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
      (WebCore::RenderLayerBacking::paintIntoLayer):
      * rendering/RenderLayerBacking.h:
      (WebCore::RenderLayerBacking::hasScrollingLayer):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::updateRootLayerPosition):
      * rendering/RenderLayerCompositor.h:
      
      Source/WebKit2:
      
      * UIProcess/mac/RemoteLayerTreeHost.h:
      * UIProcess/mac/RemoteLayerTreeHost.mm:
      (WebKit::RemoteLayerTreeHost::getOrCreateLayer):
      * WebProcess/WebPage/mac/LayerTreeHostMac.h:
      * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
      (WebKit::LayerTreeHostMac::paintContents):
      (WebKit::LayerTreeHostMac::createPageOverlayLayer):
      (WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
      * WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
      * WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
      * WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
      * WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
      (WebKit::RemoteLayerTreeContext::createGraphicsLayer):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::paintContents):
      (WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
      (WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc3b2dc6
    • bdakin@apple.com's avatar
      ScrollbarPainterController should adopt the api to lock overlay scrollbar state · 39ed951a
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121928
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      ScrollbarPainterController should adopt the api to lock overlay scrollbar state. 
      This will allow the ScrollbarPainterController and ScrollAnimatorMac to have 
      control over knowing whether or not the scrollbars are currently active, which 
      will allow us to remove a bunch of functions previously implemented in 
      ScrollableArea subclasses to answer that question.
      
      ScrollableArea::scrollbarsCanBeActive() is not longer virtual. It used to 
      implemented on ScrollableArea subclasses, but now ScrollableArea can just get the 
      information from the ScrollAnimator.
      * WebCore.exp.in:
      
      When ScrollableArea subclasses implemented scrollbarsCanBeActive(), they would 
      check to see if the document was in the page cache. Instead of that model, this 
      patch adopts a model where ScrollbarPainterController is told directly whether or 
      not it is active via shouldLockOverlayScrollbarsToHidden(bool).
      * dom/Document.cpp:
      (WebCore::Document::setInPageCache):
      
      setAnimatorsAreActive() is no longer necessary. The functionality can be bundled 
      into shouldLockOverlayScrollbarsToHidden(bool).
      (WebCore::Document::documentDidResumeFromPageCache):
      
      Remove implementations of scrollbarsCanBeActive(), setAnimatorsAreActive(), and 
      scrollbarAnimationsAreSuppressed(). 
      * page/FrameView.cpp:
      (WebCore::FrameView::notifyPageThatContentAreaWillPaint):
      * page/FrameView.h:
      
      setShouldSuppressScrollbarAnimations(bool) now calls 
      setShouldLockOverlayScrollbars(bool). 
      * page/Page.cpp:
      (WebCore::Page::setShouldSuppressScrollbarAnimations):
      (WebCore::Page::setShouldLockOverlayScrollbars):
      * page/Page.h:
      
      setIsActive() is now implemented in the ScrollAnimator instead of ScrollableArea 
      subclasses. finishCurrentScrollAnimations() is replaced by 
      lockOverlayScrollbarStateToHidden(bool).
      * platform/ScrollAnimator.h:
      (WebCore::ScrollAnimator::lockOverlayScrollbarStateToHidden):
      (WebCore::ScrollAnimator::scrollbarsCanBeActive):
      
      New enum ScrollbarOverlayState.
      * platform/ScrollTypes.h:
      
      Go to the animator for both of these functions.
      * platform/ScrollableArea.cpp:
      (WebCore::ScrollableArea::lockOverlayScrollbarStateToHidden):
      (WebCore::ScrollableArea::scrollbarsCanBeActive):
      * platform/ScrollableArea.h:
      (WebCore::ScrollableArea::setVisibleScrollerThumbRect):
      
      Three new pieces of ScrollbarPainterController api.
      * platform/mac/NSScrollerImpDetails.h:
      
      Instead of asking the ScrollableArea if scrollbars can be active, just find out if 
      the ScrollbarPaintController has been locked.
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
      (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
      (WebCore::ScrollAnimatorMac::contentAreaWillPaint):
      (WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
      (WebCore::ScrollAnimatorMac::mouseExitedContentArea):
      (WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
      (WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
      (WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
      (WebCore::ScrollAnimatorMac::willStartLiveResize):
      (WebCore::ScrollAnimatorMac::contentsResized):
      (WebCore::ScrollAnimatorMac::willEndLiveResize):
      (WebCore::ScrollAnimatorMac::contentAreaDidShow):
      (WebCore::ScrollAnimatorMac::contentAreaDidHide):
      (WebCore::ScrollAnimatorMac::didBeginScrollGesture):
      (WebCore::ScrollAnimatorMac::didEndScrollGesture):
      (WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
      (WebCore::ScrollAnimatorMac::lockOverlayScrollbarStateToHidden):
      (WebCore::ScrollAnimatorMac::scrollbarsCanBeActive):
      (WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
      (WebCore::ScrollAnimatorMac::updateScrollerStyle):
      
      Remove implementations of scrollbarsCanBeActive() and 
      scrollbarAnimationsAreSuppressed().
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayer.h:
      * rendering/RenderListBox.cpp:
      * rendering/RenderListBox.h:
      
      Source/WebKit2: 
      
      This function no longer needs to be implemented by ScrollablArea subclasses.
      * WebProcess/Plugins/PDF/PDFPlugin.h:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39ed951a
    • eric.carlson@apple.com's avatar
      [MediaStream API] update SourceInfo object to match spec · c43fc44d
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121941
      
      Reviewed by Dean Jackson.
      
      Source/WebCore: 
      
      No new tests, existing test updated.
      
      * Modules/mediastream/SourceInfo.cpp:
      (WebCore::SourceInfo::kind): Get rid of "none".
      * Modules/mediastream/SourceInfo.h:
      (WebCore::SourceInfo::sourceId): Renamed from "id".
      * Modules/mediastream/SourceInfo.idl:
      
      * platform/mediastream/MediaStreamTrackSourcesRequestClient.h:
      (WebCore::TrackSourceInfo::create):
      (WebCore::TrackSourceInfo::kind):
      (WebCore::TrackSourceInfo::TrackSourceInfo):
      
      * platform/mock/MockMediaStreamCenter.cpp:
      (WebCore::MockMediaStreamCenter::getMediaStreamTrackSources): "facing" isn't a part of sourceInfo.
          Return a non-NULL ID because a source must always have one.
      
      LayoutTests: 
      
      * fast/mediastream/MediaStreamTrack-getSources-expected.txt:
      * fast/mediastream/MediaStreamTrack-getSources.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c43fc44d
    • dino@apple.com's avatar
      Provide 2D Matrix decomposition for animation · 3a0b736f
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112824
      <rdar://problem/15091882>
      
      Reviewed by Eric Carlson (and Ian Henderson offline).
      
      Source/WebCore:
      
      Implement a new 2d matrix blend, which is triggered
      when animating between two affine 3d matrices. This
      is intended to be the official algorithm that gets
      put into the W3C Transforms specification.
      
      The old code is renamed with a 4 prefix (indicating
      it is a blend between 3d matrices using quaternions),
      and new methods and structures for 2d blending were added.
      
      I also took the opportunity to clean up a lot of
      bad WebKit style.
      
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::maxScaleFromTransform): Use 3d decomposition.
      * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
      (WebCore::PerspectiveTransformOperation::blend): Ditto.
      * platform/graphics/transforms/RotateTransformOperation.cpp:
      (WebCore::RotateTransformOperation::blend): Ditto.
      
      * platform/graphics/transforms/TransformationMatrix.cpp:
      (WebCore::decompose2): New method to decompose an affine 3d matrix
      into X/Y scale + translate, a rotation angle, plus some extracted
      a,b,c,d fields from the affine section.
      (WebCore::decompose4): New name for the old function.
      (WebCore::TransformationMatrix::blend2): Perform linear interpolation
      between two 2d decompositions.
      (WebCore::TransformationMatrix::blend4): New name for the old function.
      (WebCore::TransformationMatrix::blend): Call blend2 or blend4 depending
      on the type of matrix.
      (WebCore::TransformationMatrix::decompose2): Calls into the decompose2
      method above.
      (WebCore::TransformationMatrix::decompose4): New name.
      (WebCore::TransformationMatrix::recompose2): Recomposes a 3d matrix from
      a 2d decomposition.
      (WebCore::TransformationMatrix::recompose4): New name.
      * platform/graphics/transforms/TransformationMatrix.h: All the changes
      for the new methods above.
      
      LayoutTests:
      
      This test was only exercising the fact that our
      software decomposition did not match our hardware
      decomposition (although that required visual inspection).
      Now that our 2d decomposition is correct, update the
      test and its expected result.
      
      * animations/transform-non-accelerated-expected.txt:
      * animations/transform-non-accelerated.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a0b736f
    • darin@apple.com's avatar
      rename KURL to URL · 5ffbb5c7
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=16214
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * many files: Renamed, using script.
      
      Source/WebKit:
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      Let the script to try to rename here.
      
      Source/WebKit/blackberry:
      
      * many files: Renamed, using script.
      
      Source/WebKit/efl:
      
      * many files: Renamed, using script.
      
      Source/WebKit/gtk:
      
      * many files: Renamed, using script.
      
      Source/WebKit/mac:
      
      * many files: Renamed, using script.
      
      Source/WebKit/qt:
      
      * many files: Renamed, using script.
      
      Source/WebKit/win:
      
      * many files: Renamed, using script.
      
      Source/WebKit/wince:
      
      * many files: Renamed, using script.
      
      Source/WebKit2:
      
      * many files: Renamed, using script.
      
      Tools:
      
      * many files: Renamed, using script.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ffbb5c7
    • darin@apple.com's avatar
      Add empty MainFrame class · ade301ac
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121770
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      For now, MainFrame simply derives from Frame and adds nothing.
      Next, we will make each Frame point back to its MainFrame.
      
      * CMakeLists.txt: Added MainFrame.cpp/h.
      * GNUmakefile.list.am: Ditto.
      * Target.pri: Ditto.
      * WebCore.exp.in: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj: Ditto.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      
      * page/Frame.cpp:
      (WebCore::Frame::Frame): Use references instead of pointers for constructor.
      (WebCore::Frame::create): Pass references instead of pointers to constructor.
      * page/Frame.h: Made constructor protected instead of private, and marked
      destructor virtual explicitly. Also marked virtual functions OVERRIDE and FINAL.
      
      * page/MainFrame.cpp: Added.
      * page/MainFrame.h: Added.
      
      * page/Page.cpp:
      (WebCore::Page::Page): Use MainFrame::create instead of Frame::create.
      (WebCore::Page::frameIsMainFrame): Moved here, no longer inline.
      (WebCore::Page::renderTreeSize): Use const Frame* instead of Frame*.
      (WebCore::Page::checkSubframeCountConsistency): Ditto.
      * page/Page.h: Changed mainFrame() to return MainFrame& and m_mainFrame to
      be a RefPtr<MainFrame>.
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      * bindings/js/PageScriptDebugServer.cpp:
      * bindings/js/ScriptProfiler.cpp:
      * bindings/js/ScriptState.cpp:
      * css/MediaQueryEvaluator.cpp:
      * dom/Document.cpp:
      * history/CachedFrame.cpp:
      * history/CachedPage.cpp:
      * history/PageCache.cpp:
      * html/HTMLPlugInImageElement.cpp:
      * inspector/InspectorAgent.cpp:
      * inspector/InspectorCanvasAgent.cpp:
      * inspector/InspectorClient.cpp:
      * inspector/InspectorDOMAgent.cpp:
      * inspector/InspectorFrontendClientLocal.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInputAgent.cpp:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorOverlay.cpp:
      * inspector/InspectorPageAgent.cpp:
      * inspector/PageRuntimeAgent.cpp:
      * loader/FrameLoader.cpp:
      * loader/HistoryController.cpp:
      * loader/archive/mhtml/MHTMLArchive.cpp:
      * page/AutoscrollController.cpp:
      * page/Chrome.cpp:
      * page/ContextMenuController.cpp:
      * page/DOMWindow.cpp:
      * page/DragController.cpp:
      * page/EventHandler.cpp:
      * page/FocusController.cpp:
      * page/FrameTree.cpp:
      * page/FrameView.cpp:
      * page/GestureTapHighlighter.cpp:
      * page/PageGroup.cpp:
      * page/PageGroupLoadDeferrer.cpp:
      * page/PageSerializer.cpp:
      * page/PageThrottler.cpp:
      * page/Settings.cpp:
      * page/SpatialNavigation.cpp:
      * page/mac/DragControllerMac.mm:
      * page/mac/PageMac.cpp:
      * page/scrolling/ScrollingCoordinator.cpp:
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
      * plugins/DOMMimeType.cpp:
      * storage/StorageEventDispatcher.cpp:
      * svg/graphics/SVGImage.cpp:
      * testing/InternalSettings.cpp:
      * testing/Internals.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
      * WebCoreSupport/InspectorClientEfl.cpp:
      * ewk/ewk_view.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/AcceleratedCompositingContextGL.cpp:
      * WebCoreSupport/ChromeClientGtk.cpp:
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      * WebCoreSupport/GtkAdjustmentWatcher.cpp:
      * webkit/webkitwebframe.cpp:
      * webkit/webkitwebview.cpp:
      * webkit/webkitviewportattributes.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebDragClient.mm:
      * WebCoreSupport/WebInspectorClient.mm:
      * WebCoreSupport/WebPlatformStrategies.mm:
      * WebView/WebFrame.mm:
      * WebView/WebHTMLView.mm:
      * WebView/WebView.mm:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/qt:
      
      * Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:
      * Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:
      * Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit/win:
      
      * win/WebCoreSupport/WebDragClient.cpp:
      * win/WebCoreSupport/WebContextMenuClient.cpp:
      * win/WebDropSource.cpp:
      * win/WebFrame.cpp:
      * win/WebView.cpp:
      Include MainFrame.h instead of Frame.h as needed.
      
      Source/WebKit2:
      
      * WebProcess/FullScreen/WebFullScreenManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/Storage/StorageAreaMap.cpp:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
      * WebProcess/WebPage/FindController.cpp:
      * WebProcess/WebPage/PageOverlay.cpp:
      * WebProcess/WebPage/WebInspector.cpp:
      * WebProcess/WebPage/WebPage.cpp:
      * WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
      * WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
      * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
      * WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      * WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      Include MainFrame.h instead of Frame.h as needed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ade301ac
  6. 26 Sep, 2013 5 commits
    • eric.carlson@apple.com's avatar
      [MediaStream] make MediaStream testable · 01bf7eea
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121967
      
      Reviewed by Dean Jackson.
      
      Source/WebCore: 
      
      No new tests, existing tests updated.
      
      * CMakeLists.txt: Add MockMediaStreamCenter.
      * GNUmakefile.list.am: Ditto.
      
      * Modules/mediastream/MediaStreamTrack.idl: Add SkipVTableValidation.
      * Modules/mediastream/NavigatorUserMediaError.idl: Add JSGenerateToJSObject.
      * WebCore.exp.in: Export MockMediaStreamCenter::registerMockMediaStreamCenter.
      
      * WebCore.xcodeproj/project.pbxproj: Add MockMediaStreamCenter.
      * dom/DOMError.h: Make the destructor virtual because it has a derived class.
      * dom/DOMError.idl:
      
      * platform/mock/MockMediaStreamCenter.cpp: Added.
      * platform/mock/MockMediaStreamCenter.h: Added.
      
      * testing/Internals.cpp: Register the mock stream center.
      
      Source/WebKit: 
      
      * WebKit.xcodeproj/project.pbxproj: Add WebUserMediaClient.
      
      Source/WebKit/mac: 
      
      * WebCoreSupport/WebUserMediaClient.h: Added.
      * WebCoreSupport/WebUserMediaClient.mm: Added.
      
      * WebView/WebUIDelegatePrivate.h: Declare decidePolicyForUserMediaRequestFromOrigin:listener:
      
      * WebView/WebView.mm:
      (-[WebView _commonInitializationWithFrameName:groupName:]): Register WebUserMediaClient.
      (-[WebView _setUserMediaClient:]): New.
      (-[WebView _userMediaClient]): New.
      * WebView/WebViewData.h:
      * WebView/WebViewPrivate.h:
      
      Tools: 
      
      * DumpRenderTree/mac/UIDelegate.mm:
      (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
          user media request policy delegate.
      
      LayoutTests: 
      
      * fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
      * fast/mediastream/MediaStream-add-remove-tracks.html: Make the test results more understandable
          to simplify debugging failures.
      * fast/mediastream/MediaStream-onended-expected.txt:
      * fast/mediastream/MediaStream-onended.html: Ditto. Fix a test error: stopping stream A should
          not stop stream B even when it was created from stream A.
      * fast/mediastream/MediaStreamConstructor-expected.txt:
      * fast/mediastream/MediaStreamConstructor.html: Make the test results more understandable. Fix a
          logic errors: webkitMediaStream is an object, not a function. JSC does not support 
          object.constructor.name, use object.constructor.toString() instead.
      * fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
      * fast/mediastream/MediaStreamTrackEvent-constructor.html: Update now that getUserMedia() works.
      * fast/mediastream/argument-types-expected.txt: Updated with "Failing" results because the correct 
          behavior is unknown. The spec says "the syntax for getUserMedia() is still under discussion".
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01bf7eea
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r156510. · eea5bc46
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/156510
      https://bugs.webkit.org/show_bug.cgi?id=121989
      
      Landed in-progress code along with build fix. (Requested by
      bfulgham on #webkit).
      
      * bindings/js/JSEventListener.cpp:
      (WebCore::JSEventListener::JSEventListener):
      * bindings/js/JSEventListener.h:
      (WebCore::JSEventListener::jsFunction):
      * bridge/jsc/BridgeJSC.cpp:
      (JSC::Bindings::Instance::createRuntimeObject):
      * platform/graphics/filters/FEGaussianBlur.cpp:
      (WebCore::FEGaussianBlur::platformApplyGeneric):
      (WebCore::FEGaussianBlur::platformApply):
      * platform/graphics/win/DIBPixelData.cpp:
      (WebCore::DIBPixelData::writeToFile):
      * platform/graphics/win/DIBPixelData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eea5bc46
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build fix after r156487. · 9895ebde
      bfulgham@apple.com authored
      Add explicit casting needed by MSVC to compile this code. Much
      of this could probably be removed when we move to VS2012 or newer.
      
      * bindings/js/JSEventListener.cpp:
      (WebCore::JSEventListener::JSEventListener):
      * bindings/js/JSEventListener.h:
      (WebCore::JSEventListener::jsFunction):
      * bridge/jsc/BridgeJSC.cpp:
      (JSC::Bindings::Instance::createRuntimeObject):
      * platform/graphics/filters/FEGaussianBlur.cpp:
      (WebCore::FEGaussianBlur::platformApplyGeneric):
      (WebCore::FEGaussianBlur::platformApply):
      * platform/graphics/win/DIBPixelData.cpp:
      (WebCore::DIBPixelData::DIBPixelData):
      (WebCore::DIBPixelData::writeToFile):
      * platform/graphics/win/DIBPixelData.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9895ebde
    • eric.carlson@apple.com's avatar
      [MediaStream] Cleanup platform interface · 44da78ad
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121935
      
      Reviewed by Jer Noble.
      
      No new tests, tests will be updated in the next patch.
      
      * CMakeLists.txt: Remove MediaStreamComponent.cpp.
      * GNUmakefile.list.am: Remove MediaStreamComponent.h|cpp and MediaStreamSourcesQueryClient.h. 
          Add MediaStreamConstraintsValidationClient.h and MediaStreamCreationClient.h.
      
      * Modules/mediastream/MediaStream.cpp:
      (WebCore::processTrack): Duplicate MediaStreamSource when necessary to work around bug 121954.
      (WebCore::createFromSourceVectors): MediaStreamCenter::instance -> MediaStream::sharedStreamCenter.
      (WebCore::MediaStream::MediaStream): *Components -> *Streams.
      (WebCore::MediaStream::setEnded): New.
      (WebCore::MediaStream::stop):  MediaStreamCenter::instance -> MediaStream::sharedStreamCenter.
      (WebCore::MediaStream::addTrack): Append the track parameter rather than duplicating it, as per spec.
      (WebCore::MediaStream::removeTrack): *Components -> *Streams.
      (WebCore::MediaStream::trackDidEnd): Renamed from trackEnded.
      (WebCore::MediaStream::streamDidEnd): Renamed from streamEnded.
      (WebCore::MediaStream::addRemoteSource): Renamed from addRemoteTrack. *Components -> *Streams.
      (WebCore::MediaStream::removeRemoteSource): Renamed from removeRemoteTrack. *Components -> *Streams.
      * Modules/mediastream/MediaStream.h:
      
      * Modules/mediastream/MediaStreamTrack.cpp:
      (WebCore::MediaStreamTrack::create): *Component -> *Stream.
      (WebCore::MediaStreamTrack::MediaStreamTrack): Don't assume source is valid.
      (WebCore::MediaStreamTrack::~MediaStreamTrack): Ditto.
      (WebCore::MediaStreamTrack::kind): Ditto. AtomicString -> const AtomicString&.
      (WebCore::MediaStreamTrack::setSource): Moved from .h file.
      (WebCore::MediaStreamTrack::id): Don't assume source is valid. Create ID when the source doesn't have one.
      (WebCore::MediaStreamTrack::label): Don't assume source is valid.
      (WebCore::MediaStreamTrack::enabled): 
      (WebCore::MediaStreamTrack::setEnabled): *Component -> *Stream. MediaStreamCenter::instance -> MediaStreamCenter::shared.
      (WebCore::MediaStreamTrack::readyState): "muted" is not a readyState, but "new" is.
      (WebCore::MediaStreamTrack::getSources): MediaStreamCenter::instance -> MediaStreamCenter::shared.
      (WebCore::MediaStreamTrack::ended): *Component -> *Stream.
      (WebCore::MediaStreamTrack::sourceChangedState): Dispatch "started" and "unmuted" events.
      (WebCore::MediaStreamTrack::trackDidEnd): Renamed from didEndTrack. m_component -> m_source.
      * Modules/mediastream/MediaStreamTrack.h:
      
      * Modules/mediastream/RTCDTMFSender.cpp:
      (WebCore::RTCDTMFSender::create): track->component() -> track->source();
      
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::didRemoveRemoteStream): Ditto.
      
      * Modules/mediastream/RTCStatsRequestImpl.cpp:
      (WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl): Ditto.
      (WebCore::RTCStatsRequestImpl::component): Removed, it was unused.
      * Modules/mediastream/RTCStatsRequestImpl.h:
      
      * Modules/mediastream/UserMediaClient.h:
      * Modules/mediastream/UserMediaController.h:
      (WebCore::UserMediaController::requestPermission): Renamed from requestUserMedia, get rid of source
          vector parameters.
      (WebCore::UserMediaController::cancelRequest): Renamed from cancelUserMediaRequest.
      
      * Modules/mediastream/UserMediaRequest.cpp:
      (WebCore::parseOptions): MediaConstraintsImpl -> MediaConstraints.
      (WebCore::UserMediaRequest::create): Ditto.
      (WebCore::UserMediaRequest::UserMediaRequest): Ditto.
      (WebCore::UserMediaRequest::securityOrigin): New.
      (WebCore::UserMediaRequest::start): Request constraint validation.
      (WebCore::UserMediaRequest::constraintsValidated): New. Callback from media engine when constraints
          can be supported.
      (WebCore::UserMediaRequest::requestPermission): New. Ask user media client for permission to access media.
      (WebCore::UserMediaRequest::userMediaAccessGranted): New. Access has been granted.
      (WebCore::UserMediaRequest::createMediaStream): New. Allowed to access media, ask media engine
          to create stream sources.
      (WebCore::UserMediaRequest::userMediaAccessDenied): New. User media client has denied access request.
      (WebCore::UserMediaRequest::constraintsInvalid): New. Media engine can not support constraints.
      (WebCore::UserMediaRequest::didCreateStream): New. Media engine has created stream sources.
      (WebCore::UserMediaRequest::callSuccessHandler): New. Create stream from sources and call success handler.
      (WebCore::UserMediaRequest::failedToCreateStreamWithConstraintsError): Renamed from constraintFailure.
      (WebCore::UserMediaRequest::failedToCreateStreamWithPermissionError): Renamed from permissionFailure.
      (WebCore::UserMediaRequest::callErrorHandler): 
      (WebCore::UserMediaRequest::contextDestroyed): cancelUserMediaRequest -> cancelRequest.
      * Modules/mediastream/UserMediaRequest.h:
      
      * Modules/webaudio/AudioContext.cpp:
      (WebCore::AudioContext::createMediaStreamSource): localAudio->component()->source() -> localAudio->source().
      
      * Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
      (WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): MediaStreamSource::TypeAudio ->
          MediaStreamSource::Audio, MediaStreamSource::ReadyStateLive -> MediaStreamSource::Live.
          MediaStreamCenter::instance -> MediaStreamCenter::shared.
      
      * WebCore.exp.in: Export new symbols.
      
      * WebCore.xcodeproj/project.pbxproj: Add new files and remove deleted files.
      
      * dom/EventNames.h: Define "started" event.
      
      * platform/mediastream/MediaStreamCenter.cpp:
      (WebCore::mediaStreamCenterOverride): Make it possible to override the shared stream center. Will
          be used for testing in a later patch.
      (WebCore::MediaStreamCenter::shared): Renamed from instance. Return current stream center.
      (WebCore::MediaStreamCenter::setSharedStreamCenter): Override current stream center.
      (WebCore::MediaStreamCenter::endLocalMediaStream): Never call the descriptor client, always call
          the descriptor and let it deal with the client.
      * platform/mediastream/MediaStreamCenter.h:
      
      * platform/mediastream/MediaStreamComponent.cpp: Removed.
      * platform/mediastream/MediaStreamComponent.h: Removed.
      
      * platform/mediastream/MediaStreamConstraintsValidationClient.h: Added.
      * platform/mediastream/MediaStreamCreationClient.h: Added.
      
      * platform/mediastream/MediaStreamDescriptor.cpp:
      (WebCore::MediaStreamDescriptor::addSource): *Component -> *Source.
      (WebCore::MediaStreamDescriptor::removeSource): Ditto.
      (WebCore::MediaStreamDescriptor::addRemoteSource): Ditto.
      (WebCore::MediaStreamDescriptor::removeRemoteSource): Ditto.
      (WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Ditto.
      (WebCore::MediaStreamDescriptor::setEnded): Ditto. Set source readyStates to Ended.
      * platform/mediastream/MediaStreamDescriptor.h:
      
      * platform/mediastream/MediaStreamSource.cpp:
      (WebCore::MediaStreamSource::MediaStreamSource): Initialize new member variables.
      (WebCore::MediaStreamSource::setReadyState): Early return when the state hasn't changed.
      (WebCore::MediaStreamSource::setStream): New.
      (WebCore::MediaStreamSource::setMuted): New.
      * platform/mediastream/MediaStreamSource.h:
      
      * platform/mediastream/MediaStreamSourcesQueryClient.h: Removed.
      
      * platform/mediastream/RTCPeerConnectionHandler.h:
      * platform/mediastream/RTCStatsRequest.h:
      
      * platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp: Update for new MediaStreamCenter API.
      * platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
      
      * platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp: Ditto.
      * platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
      
      * platform/mediastream/mac/MediaStreamCenterMac.cpp: Ditto.
      * platform/mediastream/mac/MediaStreamCenterMac.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44da78ad
    • seokju@webkit.org's avatar
      Fix ordered comparison warnings in BitmapImage::drawPattern · 45b5ad99
      seokju@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121945
      
      Reviewed by Darin Adler.
      
      No new tests, no behavior change.
      
      * platform/graphics/BitmapImage.cpp:
      (WebCore::BitmapImage::drawPattern):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45b5ad99
  7. 25 Sep, 2013 6 commits