- 17 Apr, 2008 40 commits
-
-
jhoneycutt@apple.com authored
Reviewed by aliu. * page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::layoutCount): Check isRenderView() before casting to RenderView. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
Re-enable animation tests on windows. * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
Reviewed by Oliver. Fix https://bugs.webkit.org/show_bug.cgi?id=18551 Bug 18551: REGRESSION (r31801?): Crash in ContainerNode::removedFromDocument on many SVG tests under guard malloc Freeing a RefPtr that is the last ref to the parent from removedFromDocument() is a bad idea. Caching the target element is too dangerous, let's simply not do it. Getting it is very cheap anyway. * svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::removedFromDocument): (WebCore::SVGSMILElement::attributeChanged): (WebCore::SVGSMILElement::targetElement): * svg/animation/SVGSMILElement.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* Scripts/run-webkit-tests: Only remove the newline after #EOF, not whatever newline happens to be at the end of what we've read. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
2008-04-17 Sam Weinig <sam@webkit.org> Reviewed by Anders Carlsson. Autogenerate the XMLHttpRequest javascript binding. * GNUmakefile.am: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCoreSources.bkl: * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSDOMWindowBase.cpp: * bindings/js/JSXMLHttpRequest.cpp: Removed. * bindings/js/JSXMLHttpRequest.h: Removed. * bindings/js/JSXMLHttpRequestConstructor.cpp: Added. (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): (WebCore::JSXMLHttpRequestConstructor::implementsConstruct): (WebCore::JSXMLHttpRequestConstructor::construct): * bindings/js/JSXMLHttpRequestConstructor.h: Added. (WebCore::JSXMLHttpRequestConstructor::classInfo): * bindings/js/JSXMLHttpRequestCustom.cpp: Added. (WebCore::JSXMLHttpRequest::mark): (WebCore::JSXMLHttpRequest::onreadystatechange): (WebCore::JSXMLHttpRequest::setOnreadystatechange): (WebCore::JSXMLHttpRequest::onload): (WebCore::JSXMLHttpRequest::setOnload): (WebCore::JSXMLHttpRequest::responseXML): (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener): (WebCore::JSXMLHttpRequest::dispatchEvent): * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::readyState): (WebCore::XMLHttpRequest::responseText): * xml/XMLHttpRequest.h: * xml/XMLHttpRequest.idl: Added. LayoutTests: 2008-04-17 Sam Weinig <sam@webkit.org> Reviewed by Anders Carlsson. Update test result for additon of XMLHttpRequest constants. * fast/dom/Window/window-properties-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
run-webkit-tests takes care of this for us now Reviewed by Anders Carlsson. * DumpRenderTree/win/DumpRenderTree.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Previously we'd wait for a hang while reading both stdout and stderr from DRT. Now we'll only wait for one or the other. Reviewed by Anders Carlsson. * Scripts/run-webkit-tests: (top level): Don't wait for stderr to time out if stdout already timed out. (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit after the first read that returns no data. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Reviewed by Anders Carlsson. * Scripts/run-webkit-tests: (top level): Updated for changes to readFromDumpToolWithTimer. (readFromDumpToolWithTimer): Return a hash that contains both the output and whether or not the test timed out. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson@apple.com authored
Reviewed by Anders The SessionStorage for a Page has to be copied every time a new Page is created. I thought I had the right choke point for creating new Pages at FrameLoader::createWindow(), but it just so happens there was another - in the ContextMenuController. The *real* choke point for this, then, is in the Chrome itself. * loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Don't do the SessionStorage copy here... * page/Chrome.cpp: (WebCore::Chrome::createWindow): Do it here, instead! git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* Scripts/run-webkit-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alice.liu@apple.com authored
Reviewed by Jon Honeycutt. Added some asserts to catch undesirable usage of setWrapper and addChildren. * page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::addChildren): * page/AccessibilityObject.h: (WebCore::AccessibilityObject::setWrapper): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Reviewed by Eric Seidel. * DumpRenderTree/win/DumpRenderTree.cpp: (main): Mark stderr as binary like we already do for stdout. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
<https://bugs.webkit.org/show_bug.cgi?id=17678> We now abort tests that take longer than 60 seconds to produce output. This matches the watchdog timer in DRT/mac and DRT/win (which we can now remove). Reviewed by Eric Seidel. * Scripts/run-webkit-tests: (top level): Read DRT's output using the new readFromDumpToolWithTimer subroutine. If readFromDumpToolWithTimer returns undefined it means the test timed out, so we register the test as a hang and move on. (sub testCrashedOrTimedOut): Renamed from testCrashed. Now handles both crashed and timed out tests. If the test timed out, we kill DRT before returning. (sub linksForTimedOutTest): Added. We don't have any output to link to for tests that timed out. (sub recordActualResultsAndDiff): Don't call length on undefined. (sub readFromDumpToolWithTimer): Added. Performs non-blocking reads from a filehandle until an #EOF is reached or $maximumSecondsWithoutOutput have elapsed. (sub setFileHandleNonBlocking): Marks a filehandle as blocking or non-blocking. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Reviewed by Eric Seidel. * Scripts/run-webkit-tests: (sub htmlForResultsSection): Added. Takes a set of tests, a description, and a subroutine to generate the links for each test, and creates a HTML string containing a table of the tests and their links. (sub linksForExpectedAndActualResults): Added. Replaces the htmlForExpectedAndActualResults subroutine. (sub linksForMismatchTest): Added. (sub linksForCrashOrErrorTest): Added. (sub linksForNewTest): Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Reviewed by Eric Seidel. * Scripts/run-webkit-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Reviewed by Eric Seidel. * Scripts/run-webkit-tests: (sub countFinishedTest): Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Reviewed by Eric Seidel. * Scripts/run-webkit-tests: (sub testCrashed): Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/5863552mrowe@apple.com authored
Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring. Reviewed by Dan Bernstein. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Add applicationCache object. * fast/dom/Window/window-properties-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson@apple.com authored
Reviewed by the Mitzpettel Before things get much more intertwined, move away from a global LocalStorage model to a per-PageGroup LocalStorage model. * page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Get it from the current PageGroup, not the global LocalStorage (which doesn't exist anymore). * page/Page.cpp: * page/PageGroup.cpp: (WebCore::PageGroup::localStorage): Create a LocalStorage object on demand. * page/PageGroup.h: * storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): Hold a back pointer to the owning PageGroup. (WebCore::LocalStorage::storageArea): * storage/LocalStorage.h: (WebCore::LocalStorage::create): * storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): Hold a back pointer to the owning LocalStorage. * storage/LocalStorageArea.h: (WebCore::LocalStorageArea::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
GTK+ build fix. Back out the libjpeg check part of r32008 from bug #17865 (reopened). * configure.ac: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Fix indentation. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::scheduleArchiveLoad): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Brady. When in the web archive debug mode, don't call didFail immediately. Instead, add the loader to the substitute resource map, but with a null resource, which indicates to substituteResourceDeliveryTimerFired that the load should fail. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired): (WebCore::DocumentLoader::scheduleArchiveLoad): * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Rename RenderView to RenderViewport in the next rename patch. * Scripts/do-webcore-rename: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Sam. Add JS bindings for the DOMApplicationCache object. * bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener): (WebCore::JSDOMApplicationCache::dispatchEvent): (WebCore::JSDOMApplicationCache::setOnchecking): (WebCore::JSDOMApplicationCache::onchecking): (WebCore::JSDOMApplicationCache::setOnerror): (WebCore::JSDOMApplicationCache::onerror): (WebCore::JSDOMApplicationCache::setOnnoupdate): (WebCore::JSDOMApplicationCache::onnoupdate): (WebCore::JSDOMApplicationCache::setOndownloading): (WebCore::JSDOMApplicationCache::ondownloading): (WebCore::JSDOMApplicationCache::setOnprogress): (WebCore::JSDOMApplicationCache::onprogress): (WebCore::JSDOMApplicationCache::setOnupdateready): (WebCore::JSDOMApplicationCache::onupdateready): (WebCore::JSDOMApplicationCache::setOncached): (WebCore::JSDOMApplicationCache::oncached): (WebCore::JSDOMApplicationCache::mark): * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): * bindings/js/JSEventTargetBase.cpp: (WebCore::toJS): * loader/appcache/DOMApplicationCache.idl: * page/DOMWindow.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Rubber-stamped by Holger Freyther. Reduce hard-coded page-cache count to 3 based on research done for the Mac port on value / page. We will need to make this more dynamic or configurable at some point but for now it's best to keep closer to the behaviour before page caching was enabled. Issue spotted by Mark Rowe. * webkit/webkitprivate.cpp: (webkit_init): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele@apple.com authored
Reviewed by Adele. Fix for <rdar://problem/5861642> QTMovieWin returns uninitialized values * platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::rate): (QTMovieWin::setRate): (QTMovieWin::setVolume): (QTMovieWin::getNaturalSize): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Reviewed by Alp Toker. http://bugs.webkit.org/show_bug.cgi?id=18335 Pango font backend unable to display japanese properly Different fonts can have different glyph indices, so we need to pass the right font when retrieving a glyph index. * platform/graphics/gtk/GlyphPageTreeNodePango.cpp: (WebCore::pango_font_get_glyph): Temporarily override the font in the PangoAnalysis passed to pango_shape. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Reviewed by Alp Toker. http://bugs.webkit.org/show_bug.cgi?id=18543 DumpRenderTree gtk freeze fix DumpRenderTree gtk freeze * DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Reviewed by Alp Toker. http://bugs.webkit.org/show_bug.cgi?id=17865 [Gtk] Improve detection of jpeglib and glib tools Improve detecting jpeglib and glib tools * configure.ac: Throw an error if the dependencies above are currently not installed git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
According to Sam and David, it's "topLevel", not "toplevel". * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::topLevelApplicationCache): * loader/DocumentLoader.h: * loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::associatedCache): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Sam. Add DOMApplicationCache implementation. * dom/EventNames.h: Add new event names. * dom/EventTarget.cpp: (WebCore::EventTarget::toDOMApplicationCache): * dom/EventTarget.h: Add EventTarget conversion method. * loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::): (WebCore::ApplicationCacheGroup::status): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::newestCache): Add more stubs. * loader/appcache/DOMApplicationCache.cpp: * loader/appcache/DOMApplicationCache.h: * page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::applicationCache): * page/DOMWindow.h: (WebCore::DOMWindow::optionalApplicationCache): Add ApplicationCache member. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alp@webkit.org authored
Reviewed by Eric. Fixed a typo in the copyright header. * webkit/webkitprivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Build fix. * WebCore.vcproj/WebCore.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele@apple.com authored
2008-04-17 Dean Jackson <dino@apple.com> Reviewed by Hyatt. Fix for <rdar://problem/5849968> translate method should have Y=0 when only X is present Test: fast/css/transform-default-parameter.html * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): translate function with only X parameter now leaves the Y parameter as zero. LayoutTests: 2008-04-17 Dean Jackson <dino@apple.com> Reviewed by Hyatt. Test for <rdar://problem/5849968> translate method should have Y=0 when only X is present * fast/css/transform-default-parameter.html: Added. * platform/mac/fast/css/transform-default-parameter-expected.checksum: Added. * platform/mac/fast/css/transform-default-parameter-expected.png: Added. * platform/mac/fast/css/transform-default-parameter-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Sam. Add plumbing for associating document loaders with application caches. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::originalURL): (WebCore::DocumentLoader::requestURL): (WebCore::DocumentLoader::responseURL): (WebCore::DocumentLoader::responseMIMEType): (WebCore::DocumentLoader::setCandidateApplicationCacheGroup): (WebCore::DocumentLoader::setApplicationCache): (WebCore::DocumentLoader::toplevelApplicationCache): * loader/DocumentLoader.h: (WebCore::DocumentLoader::candidateApplicationCacheGroup): (WebCore::DocumentLoader::applicationCache): * loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@webkit.org authored
Thread static data destructors are not guaranteed to be called in any particular order; turn ThreadSpecific into a phoenix-style singleton to avoid accessing freed memory when deleted objects are interdependent (e.g. CommonIdentifiers and internal identifier tables). No change on SunSpider. * wtf/ThreadSpecific.h: (WTF::ThreadSpecific::Data::Data): (WTF::::get): (WTF::::set): (WTF::::destroy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
<https://bugs.webkit.org/show_bug.cgi?id=18544> r31951 changed XSLTProcessor::parseErrorFunc to expect a Console* as the context parameter. The caller in XSLTProcessor was changed, but the one in XSLStyleSheet was missed. Reviewed by Alexey Proskuryakov. * xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString): Pass the Console as the context to parseErrorFunc. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* dom/Document.idl: Omit getCSSCanvasContext from the COM bindings. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-