1. 19 May, 2010 40 commits
    • dpranke@chromium.org's avatar
      2010-05-19 Dirk Pranke <dpranke@chromium.org> · 1b7b4188
      dpranke@chromium.org authored
              Try again to roll out r58765
      
              * fast/notifications/notifications-replace-expected.txt: Removed.
              * fast/notifications/notifications-replace.html: Removed.
              * fast/notifications/notifications-rtl-expected.txt: Removed.
              * fast/notifications/notifications-rtl.html: Removed.
      2010-05-19  Dirk Pranke  <dpranke@chromium.org>
      
              Try again to roll out r58675.
      
              * notifications/Notification.h:
              * notifications/Notification.idl:
      2010-05-19  Dirk Pranke  <dpranke@chromium.org>
      
              Try again to roll out r58765.
      
              * public/WebNotification.h:
              * src/WebNotification.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b7b4188
    • enrica@apple.com's avatar
      WebCore: REGRESSION (r59385) crash destroying inline renderers · 69fdfe2e
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=39143
      <rdar://problem/8003662>
              
      Reviewed by Dave Hyatt.
      
      The goal of r59385 was to make sure that the layout of block after all its children had been removed produced the identical result
      as the one of a newly created empty block. In order to do so, we had to make sure that the m_inlineChildren flag was reset to true when
      the block had no children (as it is upon creation).
      I discovered that, by doing that for anonymous blocks it leads removeChild to conclude that the anonymous children can be removed,
      without considering that the anonymous block could be part of a continuation chain. For this reason, when RenderInline::destroy()
      tries to remove the continuations we are effectively deleting a renderer that had been deleted already.
              
      Test: fast/inline-block/anonymous-block-crash.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::layoutBlock): resetting the flag m_inlineChildren only for non anonymous blocks otherwise we incurr in
      a double deletion of the renderer that causes the crash.
      
      LayoutTests: REGRESSION (r59385) crash destroying inline renderers
      https://bugs.webkit.org/show_bug.cgi?id=39143
      <rdar://problem/8003662>
      
      Reviewed by Dave Hyatt.
      
      * fast/inline-block/anonymous-block-crash-expected.txt: Added.
      * fast/inline-block/anonymous-block-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69fdfe2e
    • dpranke@chromium.org's avatar
      2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com> · 01955d5c
      dpranke@chromium.org authored
              Unreviewed, rolling out r59782.
              http://trac.webkit.org/changeset/59782
              https://bugs.webkit.org/show_bug.cgi?id=39379
      
              broke DRT build (Requested by dpranke on #webkit).
      
              * fast/notifications/notifications-replace-expected.txt: Added.
              * fast/notifications/notifications-replace.html: Added.
              * fast/notifications/notifications-rtl-expected.txt: Added.
              * fast/notifications/notifications-rtl.html: Added.
      2010-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r59782.
              http://trac.webkit.org/changeset/59782
              https://bugs.webkit.org/show_bug.cgi?id=39379
      
              broke DRT build (Requested by dpranke on #webkit).
      
              * notifications/Notification.h:
              (WebCore::Notification::dir):
              (WebCore::Notification::setDir):
              (WebCore::Notification::replaceId):
              (WebCore::Notification::setReplaceId):
              * notifications/Notification.idl:
      2010-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r59782.
              http://trac.webkit.org/changeset/59782
              https://bugs.webkit.org/show_bug.cgi?id=39379
      
              broke DRT build (Requested by dpranke on #webkit).
      
              * public/WebNotification.h:
              * src/WebNotification.cpp:
              (WebKit::WebNotification::dir):
              (WebKit::WebNotification::replaceId):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01955d5c
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=21049, opacity and position:relative... · 892cfe00
      hyatt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=21049, opacity and position:relative fail in multi-column layouts.
              
      Reviewed by Oliver Hunt.
      
      Make layers split painting across columns just as normal flow content does.  This is actually very
      challenging, since intermediate multicol layers can exist between a child that has to be split and
      its enclosing stacking context.
              
      In order to properly paginate layers, a bit is set on all pagination roots, i.e., layers that will get
      split and thus split any descendant layers that they are also responsible for painting.  For a paginated
      root, we walk up the layer hierarchy and collect all intermediate multicol blocks between the child
      and the enclosing stacking context.
              
      We then recur from the outside in, applying clipping and translation as we break up the layer into strips.
              
      Composited layers remain unsplittable and have a hacked offset still in order to be placed in the right
      column.
              
      Painting and hit testing of columns has been simplified in all of the functions to use the x position of
      the column rect instead of trying to increment an x offset by adding in widths and column gaps.  This
      makes those functions directionality-independent (and the LTR/RTL code paths are now the same).
              
      Fix repainting of columns as well to make sure rects are split across columns only after relative position
      and transforms have been applied.
              
      Added fast/multicol/layers-split-across-columns.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::paintColumnContents):
      (WebCore::RenderBlock::adjustRectForColumns):
      (WebCore::RenderBlock::adjustForColumns):
      * rendering/RenderBlock.h:
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computeRectForRepaint):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::RenderLayer):
      (WebCore::RenderLayer::updateLayerPositions):
      (WebCore::RenderLayer::updatePagination):
      (WebCore::RenderLayer::updateLayerPosition):
      (WebCore::RenderLayer::paintLayer):
      (WebCore::RenderLayer::paintList):
      (WebCore::RenderLayer::paintPaginatedChildLayer):
      (WebCore::RenderLayer::paintChildLayerIntoColumns):
      (WebCore::RenderLayer::hitTestLayer):
      (WebCore::RenderLayer::hitTestList):
      (WebCore::RenderLayer::hitTestPaginatedChildLayer):
      (WebCore::RenderLayer::hitTestChildLayerColumns):
      * rendering/RenderLayer.h:
      (WebCore::RenderLayer::):
      (WebCore::RenderLayer::isPaginated):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      892cfe00
    • eric@webkit.org's avatar
      2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com> · 44972691
      eric@webkit.org authored
              Unreviewed, rolling out r59240.
              http://trac.webkit.org/changeset/59240
              https://bugs.webkit.org/show_bug.cgi?id=39377
      
              "Might cause crashes in GTK+ bots" (Requested by xan_ on
              #webkit).
      
              * WebCoreSupport/ContextMenuClientGtk.cpp:
              (WebKit::inputMethodsMenuItem):
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::setInputMethodState):
              (WebKit::EditorClient::respondToChangedSelection):
              (WebKit::EditorClient::handleInputMethodKeydown):
              (WebKit::EditorClient::EditorClient):
              (WebKit::EditorClient::~EditorClient):
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::postCommitFrameViewSetup):
              * webkit/webkitprivate.h:
              * webkit/webkitwebview.cpp:
              (destroy_menu_cb):
              (webkit_web_view_forward_context_menu_event):
              (webkit_web_view_key_release_event):
              (webkit_web_view_button_release_event):
              (webkit_web_view_focus_in_event):
              (webkit_web_view_focus_out_event):
              (webkit_web_view_realize):
              (webkit_web_view_set_scroll_adjustments):
              (webkit_web_view_dispose):
              (webkit_web_view_finalize):
              (webViewGetDPI):
              (webkit_web_view_screen_changed):
              (webkit_web_view_query_tooltip):
              (webkit_web_view_get_im_context):
              (webkit_web_view_update_settings):
              (webkit_web_view_init):
              (webkit_web_view_set_settings):
              (webkit_web_view_get_settings):
              (webkit_web_view_get_inspector):
              (webkit_web_view_set_window_features):
              (webkit_web_view_get_window_features):
              (webkit_web_view_get_back_forward_list):
              (webkit_web_view_zoom_in):
              (webkit_web_view_zoom_out):
              (webkit_web_view_get_encoding):
              (webkit_web_view_get_custom_encoding):
              (webkit_web_view_add_resource):
              (webkit_web_view_get_resource):
              (webkit_web_view_get_main_resource):
              (webkit_web_view_clear_resources):
              (webkit_web_view_get_subresources):
              (webkit_web_view_set_tooltip_text):
              (webkit_web_view_get_icon_uri):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44972691
    • dpranke@chromium.org's avatar
      2010-05-18 Dirk Pranke <dpranke@chromium.org> · cf58e8c3
      dpranke@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Attempt to revert r58765 to see if it was causing a performance
              regression.
      
              https://bugs.webkit.org/show_bug.cgi?id=39328
      
              * fast/notifications/notifications-replace-expected.txt: Removed.
              * fast/notifications/notifications-replace.html: Removed.
              * fast/notifications/notifications-rtl-expected.txt: Removed.
              * fast/notifications/notifications-rtl.html: Removed.
      2010-05-18  Dirk Pranke  <dpranke@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Attempt to revert r58765 to see if it was causing a performance
              regression.
      
              https://bugs.webkit.org/show_bug.cgi?id=39328
      
              * notifications/Notification.h:
              * notifications/Notification.idl:
      2010-05-18  Dirk Pranke  <dpranke@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Attempt to revert r58765 to see if it was causing a performance
              regression.
      
              https://bugs.webkit.org/show_bug.cgi?id=39328
      
              * public/WebNotification.h:
              * src/WebNotification.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf58e8c3
    • ggaren@apple.com's avatar
      2010-05-19 Geoffrey Garen <ggaren@apple.com> · 3a0bf1f8
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
      
              Don't build the Interpreter into JIT builds.
              https://bugs.webkit.org/show_bug.cgi?id=39373
      
              SunSpider says no change.
      
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::privateExecute):
              * interpreter/Interpreter.h:
              * wtf/Platform.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a0bf1f8
    • kevino@webkit.org's avatar
      Reviewed by Kevin Ollivier. · a1bb8510
      kevino@webkit.org authored
      [wx] Ensure m_nsFont is initialized properly, and tweak fallback font handling
      to handle more cases.
      https://bugs.webkit.org/show_bug.cgi?id=39365
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1bb8510
    • eric@webkit.org's avatar
      2010-05-19 Marcus Bulach <bulach@chromium.org> · c7e00792
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Fixes Windows Qt Release post r59772.
              https://bugs.webkit.org/show_bug.cgi?id=39369
      
              * platform/GeolocationService.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7e00792
    • eric@webkit.org's avatar
      2010-05-19 Eric Seidel <eric@webkit.org> · ab9e7384
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Add support for handling basic <script> tags in the HTML5 Parser
              https://bugs.webkit.org/show_bug.cgi?id=39350
      
              WebKit currently executes scripts from HTMLTokenizer in one giagantic
              hack.  HTML 5 requires that we execute scripts from the tree-builders/parser.
      
              It will take me a while to re-factor enough of HTMLTokenizer to be able to
              move the script execution logic without breaking things.  In the interest
              of allowing Adam to continue improving the HTML 5 lexer I've added this
              very basic (and very incomplete) <script> support to the HTML 5 parser code
              path so the he can run the HTML5 parser test suite.
      
              <script> support is tested by most of the layout tests.
      
              * dom/ScriptElement.cpp:
              (WebCore::useHTML5Parser):
              (WebCore::ScriptElement::finishParsingChildren):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab9e7384
    • ggaren@apple.com's avatar
      Standardized naming: "bytecode offset" wins; "bytecode index" loses. · 1ba49818
      ggaren@apple.com authored
              
      Reviewed by Gavin Barraclough.
      
      Also renamed getBytecodeOffset to bytecodeOffset, to match the WebKit
      naming style.
      
      * bytecode/CodeBlock.h:
      (JSC::CallReturnOffsetToBytecodeOffset::CallReturnOffsetToBytecodeOffset):
      (JSC::getCallReturnOffset):
      (JSC::CodeBlock::bytecodeOffset):
      (JSC::CodeBlock::callReturnIndexVector):
      * interpreter/Interpreter.cpp:
      (JSC::bytecodeOffsetForPC):
      * jit/JIT.cpp:
      (JSC::JIT::JIT):
      (JSC::JIT::privateCompileMainPass):
      (JSC::JIT::privateCompileLinkPass):
      (JSC::JIT::privateCompileSlowCases):
      (JSC::JIT::privateCompile):
      * jit/JIT.h:
      (JSC::CallRecord::CallRecord):
      (JSC::JumpTable::JumpTable):
      (JSC::SwitchRecord::SwitchRecord):
      * jit/JITCall.cpp:
      (JSC::JIT::compileOpCallVarargsSlowCase):
      (JSC::JIT::compileOpCall):
      * jit/JITInlineMethods.h:
      (JSC::JIT::emitNakedCall):
      (JSC::JIT::addSlowCase):
      (JSC::JIT::addJump):
      (JSC::JIT::emitJumpSlowToHot):
      (JSC::JIT::isLabeled):
      (JSC::JIT::map):
      (JSC::JIT::unmap):
      (JSC::JIT::isMapped):
      (JSC::JIT::getMappedPayload):
      (JSC::JIT::getMappedTag):
      (JSC::JIT::emitGetVirtualRegister):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_switch_imm):
      (JSC::JIT::emit_op_switch_char):
      (JSC::JIT::emit_op_switch_string):
      (JSC::JIT::emit_op_new_error):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::emit_op_mov):
      (JSC::JIT::emit_op_get_global_var):
      (JSC::JIT::emit_op_put_global_var):
      (JSC::JIT::emit_op_get_scoped_var):
      (JSC::JIT::emit_op_put_scoped_var):
      (JSC::JIT::emit_op_to_primitive):
      (JSC::JIT::emit_op_resolve_global):
      (JSC::JIT::emit_op_to_jsnumber):
      (JSC::JIT::emit_op_catch):
      (JSC::JIT::emit_op_switch_imm):
      (JSC::JIT::emit_op_switch_char):
      (JSC::JIT::emit_op_switch_string):
      (JSC::JIT::emit_op_new_error):
      (JSC::JIT::emit_op_convert_this):
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::emit_op_method_check):
      (JSC::JIT::emitSlow_op_method_check):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::emit_op_method_check):
      (JSC::JIT::emitSlow_op_method_check):
      (JSC::JIT::emit_op_get_by_val):
      (JSC::JIT::emit_op_get_by_id):
      (JSC::JIT::emit_op_get_by_pname):
      * jit/JITStubCall.h:
      (JSC::JITStubCall::call):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ba49818
    • andersca@apple.com's avatar
      2010-05-19 Anders Carlsson <andersca@apple.com> · ffb2ba85
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Move member variables from NamedMappedAttrMap to its base class NamedNodeMap
              https://bugs.webkit.org/show_bug.cgi?id=39367
              <rdar://problem/8003304>
      
              This lets us get rid of the vtable pointer in NamedNodeMap which saves 8 bytes, and also allows us to
              fit the m_mappedAttributeCount unsigned int in the RefCounted padding (in 64-bit).
              
              The net result is that we shrink the NamedMappedAttrMap size by 16 bytes, while keeping the size of NamedNodeMap the same.
      
              * dom/Element.cpp:
              (WebCore::Element::createAttributeMap):
              * dom/Element.h:
              * dom/NamedMappedAttrMap.cpp:
              * dom/NamedMappedAttrMap.h:
              (WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
              * dom/NamedNodeMap.cpp:
              (WebCore::NamedNodeMap::clearAttributes):
              * dom/NamedNodeMap.h:
              (WebCore::NamedNodeMap::NamedNodeMap):
              * dom/Node.cpp:
              (WebCore::Node::dumpStatistics):
              * dom/StyledElement.cpp:
              * dom/StyledElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffb2ba85
    • weinig@apple.com's avatar
      Use ASSERT_UNUSED instead of UNUSED_PARAM. · 95912484
      weinig@apple.com authored
      Reviewed by Anders Carlsson.
      
      * dom/Attribute.cpp:
      (WebCore::Attribute::unbindAttr):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95912484
    • jianli@chromium.org's avatar
      Remove obsolete ChromiumBridge code that routes FileSystem calls to WebKitClient. · 2fc97f62
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39332
      
      Reviewed by Darin Fisher.
      
      * public/WebKitClient.h:
      * src/ChromiumBridge.cpp:
      (WebCore::ChromiumBridge::fileExists):
      (WebCore::ChromiumBridge::deleteFile):
      (WebCore::ChromiumBridge::deleteEmptyDirectory):
      (WebCore::ChromiumBridge::getFileSize):
      (WebCore::ChromiumBridge::getFileModificationTime):
      (WebCore::ChromiumBridge::directoryName):
      (WebCore::ChromiumBridge::pathByAppendingComponent):
      (WebCore::ChromiumBridge::makeAllDirectories):
      (WebCore::ChromiumBridge::getAbsolutePath):
      (WebCore::ChromiumBridge::isDirectory):
      (WebCore::ChromiumBridge::filePathToURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fc97f62
    • weinig@apple.com's avatar
      Complete the merge of MappedAttribute and Attribute. · c360893c
      weinig@apple.com authored
      Rubber-stamped by Anders Carlsson.
      
      Files elided for brevity.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c360893c
    • eric@webkit.org's avatar
      2010-05-19 Marcus Bulach <bulach@chromium.org> · 5517b2f8
      eric@webkit.org authored
              Reviewed by Steve Block.
      
              [chromium] Adds supports for layout tests using GeolocationServiceMock.
              https://bugs.webkit.org/show_bug.cgi?id=39081
      
              Allows injection of GeolocationServiceMock factory.
      
              Tests: existing fast/dom/Geolocation/*
      
              * platform/GeolocationService.cpp:
              (WebCore::GeolocationService::useMock):
              (WebCore::GeolocationService::useMockFactory):
              * platform/GeolocationService.h:
              * platform/chromium/GeolocationServiceChromium.cpp:
              (WebCore::GeolocationServiceChromium::GeolocationServiceChromium):
      2010-05-19  Marcus Bulach  <bulach@chromium.org>
      
              Reviewed by Steve Block.
      
              [chromium] Adds supports for layout tests using GeolocationServiceMock.
              https://bugs.webkit.org/show_bug.cgi?id=39081
      
              Allows injection of GeolocationServiceMock factory.
              Tests: existing fast/dom/Geolocation/*
      
              * WebKit.gyp:
              * public/WebGeolocationServiceMock.h: Added.
              * src/WebGeolocationServiceMock.cpp: Added.
              (WebCore::GeolocationServiceChromiumMock::create):
              (WebCore::GeolocationServiceChromiumMock::GeolocationServiceChromiumMock):
              (WebCore::GeolocationServiceChromiumMock::startUpdating):
              (WebCore::GeolocationServiceChromiumMock::stopUpdating):
              (WebCore::GeolocationServiceChromiumMock::lastPosition):
              (WebCore::GeolocationServiceChromiumMock::lastError):
              (WebCore::GeolocationServiceChromiumMock::geolocationServicePositionChanged):
              (WebCore::GeolocationServiceChromiumMock::geolocationServiceErrorOccurred):
              (WebKit::WebGeolocationServiceMock::setMockGeolocationPosition):
              (WebKit::WebGeolocationServiceMock::setMockGeolocationError):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5517b2f8
    • eric@webkit.org's avatar
      2010-05-19 Eric Seidel <eric@webkit.org> · cbd4f453
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              user.py throws exception when readline module is missing
              https://bugs.webkit.org/show_bug.cgi?id=39239
      
              * Scripts/webkitpy/common/system/user.py:
               - The error handling path requires the "sys" module,
                 so added an import sys at the top of the file.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbd4f453
    • mrobinson@webkit.org's avatar
      2010-05-19 Martin Robinson <mrobinson@igalia.com> · 78b17a64
      mrobinson@webkit.org authored
              Not reviewed.
      
              Add baselines for new multi-column tests.
      
              * platform/gtk/fast/multicol/column-count-with-rules-expected.txt: Added.
              * platform/gtk/fast/multicol/layers-in-multicol-expected.txt: Added.
              * platform/gtk/fast/multicol/nested-columns-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78b17a64
    • yaar@chromium.org's avatar
      2010-05-19 Justin Schuh <jschuh@chromium.org> · a4b82d8b
      yaar@chromium.org authored
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              Moved JavaScript frame.src checks out of bindings and into
              HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
              so ExecState is available inside core DOM. Updated affected bindings
              (except for GObject, which will need to be updated to avoid origin
              failures inside native code).
      
              * Android.jscbindings.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSCallbackData.cpp:
              (WebCore::JSCallbackData::invokeCallback):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::handleEvent):
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              * bindings/js/JSMainThreadExecState.cpp: Added.
              * bindings/js/JSMainThreadExecState.h: Added.
              (WebCore::JSMainThreadExecState::currentState):
              (WebCore::JSMainThreadExecState::call):
              (WebCore::JSMainThreadExecState::evaluate):
              (WebCore::JSMainThreadExecState::JSMainThreadExecState):
              (WebCore::JSMainThreadExecState::~JSMainThreadExecState):
              (WebCore::JSMainThreadNullState::JSMainThreadNullState):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::executeFunctionInContext):
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScheduledAction.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/js/ScriptController.h:
              * bindings/js/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::call):
              * bindings/objc/ObjCEventListener.mm:
              * bindings/objc/WebScriptObject.mm:
              (-[WebScriptObject callWebScriptMethod:withArguments:]):
              (-[WebScriptObject evaluateWebScript:]):
              * bindings/scripts/CodeGeneratorObjC.pm:
              * bindings/scripts/test/ObjC/DOMTestCallback.mm:
              (-[DOMTestCallback callbackWithClass1Param:]):
              (-[DOMTestCallback callbackWithClass2Param:strArg:]):
              (-[DOMTestCallback callbackWithNonBoolReturnType:]):
              (-[DOMTestCallback customCallback:class6Param:]):
              * bindings/scripts/test/ObjC/DOMTestInterface.mm:
              * bindings/scripts/test/ObjC/DOMTestObj.mm:
              (-[DOMTestObj readOnlyIntAttr]):
              (-[DOMTestObj readOnlyStringAttr]):
              (-[DOMTestObj readOnlyTestObjAttr]):
              (-[DOMTestObj intAttr]):
              (-[DOMTestObj setIntAttr:]):
              (-[DOMTestObj longLongAttr]):
              (-[DOMTestObj setLongLongAttr:]):
              (-[DOMTestObj unsignedLongLongAttr]):
              (-[DOMTestObj setUnsignedLongLongAttr:]):
              (-[DOMTestObj stringAttr]):
              (-[DOMTestObj setStringAttr:]):
              (-[DOMTestObj testObjAttr]):
              (-[DOMTestObj setTestObjAttr:]):
              (-[DOMTestObj attrWithException]):
              (-[DOMTestObj setAttrWithException:]):
              (-[DOMTestObj attrWithSetterException]):
              (-[DOMTestObj setAttrWithSetterException:]):
              (-[DOMTestObj attrWithGetterException]):
              (-[DOMTestObj setAttrWithGetterException:]):
              (-[DOMTestObj customAttr]):
              (-[DOMTestObj setCustomAttr:]):
              (-[DOMTestObj scriptStringAttr]):
              (-[DOMTestObj voidMethod]):
              (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj intMethod]):
              (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj objMethod]):
              (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
              (-[DOMTestObj serializedValue:]):
              (-[DOMTestObj methodWithException]):
              (-[DOMTestObj customMethod]):
              (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj customArgsAndException:]):
              (-[DOMTestObj addEventListener:listener:useCapture:]):
              (-[DOMTestObj removeEventListener:listener:useCapture:]):
              (-[DOMTestObj withDynamicFrame]):
              (-[DOMTestObj withDynamicFrameAndArg:]):
              (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
              (-[DOMTestObj withDynamicFrameAndUserGesture:]):
              (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
              (-[DOMTestObj withScriptStateVoid]):
              (-[DOMTestObj withScriptStateObj]):
              (-[DOMTestObj withScriptStateVoidException]):
              (-[DOMTestObj withScriptStateObjException]):
              (-[DOMTestObj methodWithOptionalArg:]):
              (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
              (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/v8/ScriptController.h:
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::isURLAllowed):
      2010-05-19  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
              * http/tests/security/xss-DENIED-iframe-src-alias.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4b82d8b
    • chang.shu@nokia.com's avatar
      2010-05-19 Andreas Kling <andreas.kling@nokia.com> · cf579f5e
      chang.shu@nokia.com authored
              Reviewed by Darin Adler.
      
              CanvasRenderingContext2D's property getters that return colors should
              serialize them in accordance with the HTML5 spec (4.8.11.1.4)
              Setters should ignore invalid colors.
      
              Also, shadowColor should initially be transparent black (4.8.11.1.6)
      
              https://bugs.webkit.org/show_bug.cgi?id=38845
      
              Refactored CanvasStyle to store an RGBA32 instead of RGBA components and/or the color string.
      
              Spec links:
              http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color
              http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-shadowcolor
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::State::State):
              (WebCore::CanvasRenderingContext2D::shadowColor):
              (WebCore::CanvasRenderingContext2D::setShadowColor):
              (WebCore::CanvasRenderingContext2D::setShadow):
              (WebCore::CanvasRenderingContext2D::clearShadow):
              (WebCore::CanvasRenderingContext2D::applyShadow):
              * html/canvas/CanvasRenderingContext2D.h:
              * html/canvas/CanvasStyle.cpp:
              (WebCore::CanvasStyle::CanvasStyle):
              (WebCore::CanvasStyle::create):
              (WebCore::CanvasStyle::applyStrokeColor):
              (WebCore::CanvasStyle::applyFillColor):
              * html/canvas/CanvasStyle.h:
              (WebCore::CanvasStyle::create):
              (WebCore::CanvasStyle::color):
              (WebCore::CanvasStyle::):
              (WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
              * platform/graphics/Color.cpp:
              (WebCore::Color::serialized):
              * platform/graphics/Color.h:
      
      
      2010-05-19  Andreas Kling  <andreas.kling@nokia.com>
      
              Reviewed by Darin Adler.
      
              Added a test to verify proper color serialization in CanvasRenderingContext2D's getters.
              https://bugs.webkit.org/show_bug.cgi?id=38845
      
              Spec link:
              http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color
      
              * fast/canvas/canvas-color-serialization-expected.txt: Added.
              * fast/canvas/canvas-color-serialization.html: Added.
              * fast/canvas/canvas-set-properties-with-non-invertible-ctm-expected.txt: Updated baseline.
              * fast/canvas/script-tests/canvas-color-serialization.js: Added.
              (trySettingStrokeStyle):
              (trySettingFillStyle):
              (trySettingShadowColor):
              (trySettingColor):
              (trySettingStrokeColorWithSetter):
              (trySettingFillColorWithSetter):
              (trySettingShadowWithSetter):
              (trySettingColorWithSetter):
              (trySettingFillColorRGBA):
              (trySettingStrokeColorRGBA):
              (trySettingShadowRGBA):
              (trySettingRGBA):
              (trySettingFillColorCMYKA):
              (trySettingStrokeColorCMYKA):
              (trySettingShadowCMYKA):
              (trySettingCMYKA):
              (trySettingFillColorWithOverrideAlpha):
              (trySettingStrokeColorWithOverrideAlpha):
              (trySettingShadowWithOverrideAlpha):
              (trySettingColorWithOverrideAlpha):
              (trySettingFillColorGrayLevel):
              (trySettingStrokeColorGrayLevel):
              (trySettingShadowGrayLevel):
              (trySettingGrayLevel):
              (trySettingFillColorGrayLevelWithAlpha):
              (trySettingStrokeColorGrayLevelWithAlpha):
              (trySettingShadowGrayLevelWithAlpha):
              (trySettingGrayLevelWithAlpha):
              (tryClearShadowAfterSettingColor):
              (checkDefaultValue):
              * fast/canvas/script-tests/canvas-set-properties-with-non-invertible-ctm.js:
              * fast/dom/canvasContext2d-element-attribute-js-null-expected.txt: Updated baseline.
              * fast/dom/canvasContext2d-element-attribute-js-null.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf579f5e
    • chang.shu@nokia.com's avatar
      2010-05-19 Andreas Kling <andreas.kling@nokia.com> · 92749a8e
      chang.shu@nokia.com authored
              Reviewed by Simon Hausmann.
      
              [Qt] REGRESSION: CoolClock isn't rendered properly
      
              https://bugs.webkit.org/show_bug.cgi?id=38526
      
              CanvasRenderingContext2D's arc() should connect to the previous point
              with a straight line (HTML5 spec 4.8.11.1.8), but if the path is empty
              to begin with, we don't want a line back to (0,0)
              This also fixes the rendering artifact discussed in bug 36226.
      
              Spec link:
              http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc
      
              Test: fast/canvas/canvas-arc-connecting-line.html
      
              * platform/graphics/qt/PathQt.cpp:
              (WebCore::Path::addArc):
      
      2010-05-19  Andreas Kling  <andreas.kling@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              Add test to verify that CanvasRenderingContext2D's arc() connects arcs
              by a straight line (unless it's the first element in the path.)
              https://bugs.webkit.org/show_bug.cgi?id=38526
      
              * fast/canvas/canvas-arc-connecting-line-expected.txt: Added.
              * fast/canvas/canvas-arc-connecting-line.html: Added.
              * fast/canvas/script-tests/canvas-arc-connecting-line.js: Added.
              (deg2rad):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92749a8e
    • abecsi@webkit.org's avatar
      The backtrackParenthesesOnceEnd function should store the start position · a3e99255
      abecsi@webkit.org authored
      of the subpattern's non-greedy match at the place of the subpattern's
      start index in the output array instead of the place of the
      subpattern's end index.
      Add layout test for checking of non-greedy matching of subpattern in
      regular expressions.
      https://bugs.webkit.org/show_bug.cgi?id=39289
      
      Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-05-19
      Reviewed by Darin Adler.
      
      JavaScriptCore: 
      
      * yarr/RegexInterpreter.cpp:
      (JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
      
      LayoutTests: 
      
      * fast/js/regexp-non-greedy-parentheses-expected.txt: Added.
      * fast/js/regexp-non-greedy-parentheses.html: Added.
      * fast/js/script-tests/regexp-non-greedy-parentheses.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3e99255
    • antti.j.koivisto@nokia.com's avatar
      [Qt] TiledBackingStore updates broken when not using resizesToContents mode · 821a6300
      antti.j.koivisto@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=39359
              
      Rubber-stamped by Kenneth Rohde Christiansen.
      
      Put the back logic that was lost in refactoring.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::visibleRectForTiledBackingStore):
      * WebCoreSupport/PageClientQt.cpp:
      (WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):
      * WebCoreSupport/PageClientQt.h:
      (WebCore::PageClientQWidget::viewResizesToContentsEnabled):
      (WebCore::PageClientQGraphicsWidget::viewResizesToContentsEnabled):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      821a6300
    • eric@webkit.org's avatar
      2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com> · 1f931caa
      eric@webkit.org authored
              Unreviewed, rolling out r59758.
              http://trac.webkit.org/changeset/59758
              https://bugs.webkit.org/show_bug.cgi?id=39361
      
              This patch adds a test that fails on Leopard (Requested by
              abarth on #webkit).
      
              * fast/canvas/webgl/texture-npot-expected.txt:
              * fast/canvas/webgl/texture-npot.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f931caa
    • hausmann@webkit.org's avatar
      Symbian build fix. · ffa75e6f
      hausmann@webkit.org authored
      [Qt] Updated the def file with exports needed for DumpRenderTree.
      
      * symbian/eabi/QtWebKitu.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffa75e6f
    • apavlov@chromium.org's avatar
      2010-05-19 Alexander Pavlov <apavlov@chromium.org> · d946bee4
      apavlov@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Fix whitespace for the bug 38906
              https://bugs.webkit.org/show_bug.cgi?id=39351
      
              No new tests required (no code change).
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::~CSSParser):
              (WebCore::CSSParser::setupParser):
              (WebCore::CSSParser::parseSheet):
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseSelector):
              (WebCore::unitFromString):
              (WebCore::CSSParser::checkForOrphanedUnits):
              (WebCore::CSSParser::parseWCSSInputProperty):
              (WebCore::CSSParser::parseFillShorthand):
              (WebCore::CSSParser::parseAnimationShorthand):
              (WebCore::CSSParser::parseTransitionShorthand):
              (WebCore::CSSParser::parseShorthand):
              (WebCore::CSSParser::parse4Values):
              (WebCore::CSSParser::parseAttr):
              (WebCore::CSSParser::parseFillPositionXY):
              (WebCore::CSSParser::parseFillPosition):
              (WebCore::CSSParser::parseFillRepeat):
              (WebCore::CSSParser::parseFillProperty):
              (WebCore::CSSParser::parseAnimationTimingFunction):
              (WebCore::CSSParser::parseAnimationProperty):
              (WebCore::CSSParser::parseDashboardRegions):
              (WebCore::CSSParser::parseCounterContent):
              (WebCore::CSSParser::parseShape):
              (WebCore::CSSParser::parseFont):
              (WebCore::CSSParser::parseFontFamily):
              (WebCore::CSSParser::parseFontFaceSrc):
              (WebCore::parseInt):
              (WebCore::CSSParser::parseColor):
              (WebCore::CSSParser::parseShadow):
              (WebCore::CSSParser::parseReflect):
              (WebCore::BorderImageParseContext::commitNumber):
              (WebCore::BorderImageParseContext::commitBorderImage):
              (WebCore::CSSParser::parseBorderImage):
              (WebCore::CSSParser::parseCounter):
              (WebCore::parseGradientPoint):
              (WebCore::parseGradientColorStop):
              (WebCore::CSSParser::parseGradient):
              (WebCore::CSSParser::parseCanvas):
              (WebCore::CSSParser::parseTransform):
              (WebCore::CSSParser::parseTransformOrigin):
              (WebCore::CSSParser::parsePerspectiveOrigin):
              (WebCore::CSSParser::text):
              (WebCore::CSSParser::createRuleList):
              (WebCore::CSSParser::createVariablesRule):
              (WebCore::CSSParser::parseVariable):
              (WebCore::CSSParser::parsePropertyWithResolvedVariables):
              (WebCore::CSSParser::checkForVariables):
              (WebCore::CSSParser::createKeyframeRule):
              * css/CSSParser.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setFrontend):
              (WebCore::InspectorController::show):
              (WebCore::InspectorController::unbindAllResources):
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::scriptImported):
              (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
              (WebCore::InspectorController::removeBreakpoint):
              (WebCore::drawOutlinedQuad):
              (WebCore::InspectorController::stopTiming):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::didRemoveDOMNode):
              (WebCore::InspectorDOMAgent::getStyles):
              (WebCore::InspectorDOMAgent::applyStyleText):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d946bee4
    • kenneth@webkit.org's avatar
      When creating the UA, do not sassmue the language code is a · 3bd9398d
      kenneth@webkit.org authored
      two-letter iso639-1 code.
      
      Patch by Denis Dzyubenko <denis.dzyubenko@nokia.com> on 2010-05-19
      Reviewed by Kenneth Rohde Christiansen.
      
      * Api/qwebpage.cpp:
      (QWebPage::userAgentForUrl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bd9398d
    • antti.j.koivisto@nokia.com's avatar
      [Qt] Move visible rect calculation from QGraphicsWebViewPrivate to PageClientQGraphicsWidget · 1e528ad5
      antti.j.koivisto@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=39294
      
      Reviewed by Kenneth Rohde Christiansen.
      
      * Api/qgraphicswebview.cpp:
      * WebCoreSupport/PageClientQt.cpp:
      (WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):
      * WebCoreSupport/PageClientQt.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e528ad5
    • eric@webkit.org's avatar
      2010-05-19 Dan Winship <danw@gnome.org> · 75797eb6
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Install introspection files in our prefix, not
              gobject-introspection's prefix
      
              * GNUmakefile.am:
              * configure.ac:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75797eb6
    • eric@webkit.org's avatar
      2010-05-19 Zhenyao Mo <zmo@google.com> · c32d3816
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              fast/canvas/webgl/texture-npot.html failed on leopard bot
              https://bugs.webkit.org/show_bug.cgi?id=39128
      
              * fast/canvas/webgl/texture-npot-expected.txt: Skip pixel (0, 0); print out actual color when failing.
              * fast/canvas/webgl/texture-npot.html: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c32d3816
    • eric@webkit.org's avatar
      2010-05-19 Steve Block <steveblock@google.com> · 11eb0070
      eric@webkit.org authored
              Reviewed by Nate Chapin.
      
              V8 code generator does not add ENABLE guards around attribute getters and setters
              https://bugs.webkit.org/show_bug.cgi?id=39222
      
              No new tests, build fix only.
      
              * bindings/scripts/CodeGeneratorV8.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11eb0070
    • jorlow@chromium.org's avatar
      2010-05-19 Jeremy Orlow <jorlow@chromium.org> · 950c1a58
      jorlow@chromium.org authored
              Unreviewed build fix for Chromium.
      
              * storage/IndexedDatabaseImpl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      950c1a58
    • jorlow@chromium.org's avatar
      2010-05-17 Jeremy Orlow <jorlow@chromium.org> · cf3ce045
      jorlow@chromium.org authored
              Reviewed by Darin Fisher.
      
              Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
              https://bugs.webkit.org/show_bug.cgi?id=39216
      
              All of these functions are supposed to be passing around the origin since
              the caller of IndexedDatabaseImpl might not be able to pass in a Frame*
              object.  I tried to fix this in an ealier patch, but obviously messed up.
      
              Also change passing security origin strings to passing SecurityOrigin
              objects.
      
              No behavior change because Chromium was emulating the old behavior before
              even though the code wasn't properly hooked up.
      
              * storage/IndexedDatabase.h:
              * storage/IndexedDatabaseImpl.cpp:
              (WebCore::IndexedDatabaseImpl::open):
              * storage/IndexedDatabaseImpl.h:
              * storage/IndexedDatabaseRequest.cpp:
              (WebCore::IndexedDatabaseRequest::open):
      2010-05-17  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
              https://bugs.webkit.org/show_bug.cgi?id=39216
      
              Web____Impl is for re-entering the WebKit layer from the browser layer.
              Thus the previous IDBCallbacksProxy was mis-named (and should have been
              WebIDBCallbacksImpl).  This patch renames it and then implements the
              proper proxy (which is for going from WebCore to WebKit).
      
              Also change using security origin strings to using WebSecurityOrigin
              objects.
      
              This patch also implements the glue between WebIndexedDatabaseImpl and
              IndexedDatabaseImpl.
      
              * WebKit.gyp:
              * src/IDBCallbacksProxy.cpp:
              (WebCore::IDBCallbacksProxy::create):
              (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
              (WebCore::IDBCallbacksProxy::onError):
              (WebCore::IDBCallbacksProxy::onSuccess):
              * src/IDBCallbacksProxy.h:
              * src/IndexedDatabaseProxy.cpp:
              (WebCore::IndexedDatabaseProxy::open):
              * src/IndexedDatabaseProxy.h:
              * src/WebIDBCallbacksImpl.cpp: Added.
              (WebCore::WebIDBCallbacksImpl::WebIDBCallbacksImpl):
              (WebCore::WebIDBCallbacksImpl::~WebIDBCallbacksImpl):
              (WebCore::WebIDBCallbacksImpl::onError):
              (WebCore::WebIDBCallbacksImpl::onSuccess):
              * src/WebIDBCallbacksImpl.h: Added.
              * src/WebIDBDatabaseImpl.cpp: Added.
              (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
              (WebKit::WebIDBDatabaseImpl::~WebIDBDatabaseImpl):
              * src/WebIDBDatabaseImpl.h: Added.
              * src/WebIndexedDatabaseImpl.cpp:
              (WebKit::WebIndexedDatabaseImpl::WebIndexedDatabaseImpl):
              (WebKit::WebIndexedDatabaseImpl::open):
              * src/WebIndexedDatabaseImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf3ce045
    • eric@webkit.org's avatar
      2010-05-19 Ben Murdoch <benm@google.com> · 7aa1ae77
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Touch events are marked DontEnum in DOMWindow.idl
              https://bugs.webkit.org/show_bug.cgi?id=39118
      
              Update the expected results for enumerating the window object
              properties now touch event listeners are no longer marked DontEnum.
      
              * platform/qt/fast/dom/Window/window-properties-expected.txt:
      2010-05-19  Ben Murdoch  <benm@google.com>
      
              Reviewed by Darin Adler.
      
              Touch events are marked DontEnum in DOMWindow.idl
              https://bugs.webkit.org/show_bug.cgi?id=39118
      
              Touch events are the only attribute event listeners on the
              window object that are marked DontEnum. For consistency allow
              them to be enumerated.
      
              * page/DOMWindow.idl: Remove DontEnum from touchcancel, touchend,
                  touchstart and touchmove attributes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7aa1ae77
    • hausmann@webkit.org's avatar
      [Qt] Fix build warning · 2b3ad06a
      hausmann@webkit.org authored
      NamedAttrMap.h has been renamed to NamedNodeMap.h
      
      * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b3ad06a
    • eric@webkit.org's avatar
      2010-05-19 Eric Seidel <eric@webkit.org> · a1aedc1a
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Add an HTML parsing benchmark
              https://bugs.webkit.org/show_bug.cgi?id=39338
      
              This benchmark parses the HTML5 specification 10 times and
              reports how long it takes.  It does this 21 times, discarding
              the first warm-up run, and then prints the average time and
              standard deviation.
      
              Sharking the benchmark correctly shows over 60% of the time spent under HTMLTokenizer::write().
              The numbers from the benchmark are rather consistent.  On my
              Mac Book Pro, I consistently see standard deviations < 2% of total time.
      
              * benchmarks/parser/html-parser.html: Added.
              * benchmarks/parser/resources/html5.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1aedc1a
    • yuzo@google.com's avatar
      2010-05-18 Yuzo Fujishima <yuzo@google.com> · 87d4a841
      yuzo@google.com authored
              Reviewed by Shinichiro Hamaji.
      
              Make CSS Parser properly handle only-for-pages pseudo-classes.
      
              https://bugs.webkit.org/show_bug.cgi?id=38731
      
              * fast/css/misplaced-paged-media-pseudo-expected.txt: Removed.
              * fast/css/misplaced-paged-media-pseudo.html: Removed.
              * printing/page-rule-css-text-expected.txt:
              * printing/page-rule-css-text.html:
              * printing/pseudo-class-outside-page-expected.txt:
              * printing/pseudo-class-outside-page.html:
      2010-05-18  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Shinichiro Hamaji.
      
              Make CSS Parser properly handle only-for-pages pseudo-classes.
      
              A new Match category, PagePseudoClass, is introduced to distinguish
              only-for-pages pseudo-classes from others. A new symbol, pseudo_page,
              is introduced to handle them separately.
      
              https://bugs.webkit.org/show_bug.cgi?id=38731
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::createMarginAtRule):
              * css/CSSParser.h:
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType):
              (WebCore::CSSSelector::selectorText):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87d4a841
    • abarth@webkit.org's avatar
      2010-05-19 Adam Barth <abarth@webkit.org> · c0b247de
      abarth@webkit.org authored
              Reviewed by David Hyatt.
      
              Change the API of nextToken to distinguish between emitting a token and just running out of input
              https://bugs.webkit.org/show_bug.cgi?id=39349
      
              I'm not sure there's a functional difference with this patch yet, but
              as discussed with Eric, we need this to handle attributes.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::reset):
              (WebCore::HTML5Lexer::nextToken):
              * html/HTML5Lexer.h:
              * html/HTML5Token.h:
              (WebCore::HTML5Token::HTML5Token):
              (WebCore::HTML5Token::clear):
              (WebCore::HTML5Token::beginStartTag):
              (WebCore::HTML5Token::beginEndTag):
              (WebCore::HTML5Token::beginCharacter):
              * html/HTML5Tokenizer.cpp:
              (WebCore::HTML5Tokenizer::write):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0b247de
    • eric@webkit.org's avatar
      2010-05-18 Eric Seidel <eric@webkit.org> · 01c1ac1e
      eric@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Refactor HTMLTokenizer::write to make it more readable and split out the lexer bits from flow control bits
              https://bugs.webkit.org/show_bug.cgi?id=39318
      
              No functional changes, only moving code into smaller functions.
      
              This code is already covered by numerous layout tests.
      
              HTML parsing benchmark shows this to be a wash.
      
              * dom/Tokenizer.h:
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::advance):
               - New funtion to encapulate code which will move into HTMLLexer eventually.
               - Use ALWAYS_INLINE to make sure compilers inline this large
                 function (otherwise this patch is a regression).
              (WebCore::HTMLTokenizer::willWriteHTML):
               - New function to handle calling any pre-write delegates.
              (WebCore::HTMLTokenizer::didWriteHTML):
               - New function to handle calling any post-write delegates.
              (WebCore::HTMLTokenizer::write):
               - Call the new functions.
              * html/HTMLTokenizer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01c1ac1e
    • alex@webkit.org's avatar
      2010-05-18 Alejandro G. Castro <alex@igalia.com> · b6e58433
      alex@webkit.org authored
              Unreviewed, skip test.
      
              Skipping fast/workers/storage
              https://bugs.webkit.org/show_bug.cgi?id=39346
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6e58433