1. 14 Sep, 2012 24 commits
    • ojan@chromium.org's avatar
      Complete forgotten rebaseline. See https://bugs.webkit.org/show_bug.cgi?id=96751. · 1add1d00
      ojan@chromium.org authored
      The results all look like they pass.
      
      * platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      * platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1add1d00
    • ojan@chromium.org's avatar
      Complete some forgotten rebaselines. See https://bugs.webkit.org/show_bug.cgi?id=94916. · 2d098aef
      ojan@chromium.org authored
      All the differences were anti-aliasing/form-controls.
      
      * platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
      * platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
      * platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
      * platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
      * platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
      * platform/chromium-win/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
      * platform/chromium-win/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d098aef
    • dgrogan@chromium.org's avatar
      IndexedDB: Print console warning about setVersion · 6ad96a41
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96575
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      setVersion has been out of the spec for almost a year but there are
      still a lot of users.
      
      We show the warning once per database object as an approximation for
      once per page.
      
      No new tests, but 150-something rebaselines.
      
      * Modules/indexeddb/IDBDatabase.cpp:
      (WebCore::IDBDatabase::IDBDatabase):
      (WebCore::IDBDatabase::setVersion):
      * Modules/indexeddb/IDBDatabase.h:
      (IDBDatabase):
      
      LayoutTests:
      
      * http/tests/inspector/indexeddb/database-data-expected.txt:
      * http/tests/inspector/indexeddb/database-structure-expected.txt:
      * http/tests/inspector/indexeddb/resources-panel-expected.txt:
      * storage/indexeddb/create-and-remove-object-store-expected.txt:
      * storage/indexeddb/create-object-store-options-expected.txt:
      * storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
      * storage/indexeddb/createObjectStore-null-name-expected.txt:
      * storage/indexeddb/cursor-added-bug-expected.txt:
      * storage/indexeddb/cursor-advance-expected.txt:
      * storage/indexeddb/cursor-continue-dir-expected.txt:
      * storage/indexeddb/cursor-continue-expected.txt:
      * storage/indexeddb/cursor-continue-validity-expected.txt:
      * storage/indexeddb/cursor-delete-expected.txt:
      * storage/indexeddb/cursor-inconsistency-expected.txt:
      * storage/indexeddb/cursor-index-delete-expected.txt:
      * storage/indexeddb/cursor-key-order-expected.txt:
      * storage/indexeddb/cursor-overloads-expected.txt:
      * storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
      * storage/indexeddb/cursor-primary-key-order-expected.txt:
      * storage/indexeddb/cursor-reverse-bug-expected.txt:
      * storage/indexeddb/cursor-skip-deleted-expected.txt:
      * storage/indexeddb/cursor-update-expected.txt:
      * storage/indexeddb/cursor-update-value-argument-required-expected.txt:
      * storage/indexeddb/cursor-value-expected.txt:
      * storage/indexeddb/data-corruption-expected.txt:
      * storage/indexeddb/database-basics-expected.txt:
      * storage/indexeddb/database-close-expected.txt:
      * storage/indexeddb/database-closepending-flag-expected.txt:
      * storage/indexeddb/database-deletepending-flag-expected.txt:
      * storage/indexeddb/delete-closed-database-object-expected.txt:
      * storage/indexeddb/delete-range-expected.txt:
      * storage/indexeddb/deleteIndex-expected.txt:
      * storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
      * storage/indexeddb/deleteObjectStore-null-name-expected.txt:
      * storage/indexeddb/deleted-objects-expected.txt:
      * storage/indexeddb/deletedatabase-transaction-expected.txt:
      * storage/indexeddb/duplicates-expected.txt:
      * storage/indexeddb/error-causes-abort-by-default-expected.txt:
      * storage/indexeddb/exception-in-event-aborts-expected.txt:
      * storage/indexeddb/exceptions-expected.txt:
      * storage/indexeddb/factory-deletedatabase-expected.txt:
      * storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
      * storage/indexeddb/get-keyrange-expected.txt:
      * storage/indexeddb/index-basics-expected.txt:
      * storage/indexeddb/index-basics-workers-expected.txt:
      * storage/indexeddb/index-count-expected.txt:
      * storage/indexeddb/index-cursor-expected.txt:
      * storage/indexeddb/index-duplicate-keypaths-expected.txt:
      * storage/indexeddb/index-get-key-argument-required-expected.txt:
      * storage/indexeddb/index-multientry-expected.txt:
      * storage/indexeddb/index-population-expected.txt:
      * storage/indexeddb/index-unique-expected.txt:
      * storage/indexeddb/intversion-and-setversion-expected.txt:
      * storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
      * storage/indexeddb/intversion-long-queue-expected.txt:
      * storage/indexeddb/invalid-keys-expected.txt:
      * storage/indexeddb/key-generator-expected.txt:
      * storage/indexeddb/key-sort-order-across-types-expected.txt:
      * storage/indexeddb/key-sort-order-date-expected.txt:
      * storage/indexeddb/key-type-array-expected.txt:
      * storage/indexeddb/key-type-infinity-expected.txt:
      * storage/indexeddb/keypath-arrays-expected.txt:
      * storage/indexeddb/keypath-basics-expected.txt:
      * storage/indexeddb/keypath-edges-expected.txt:
      * storage/indexeddb/keypath-fetch-key-expected.txt:
      * storage/indexeddb/keypath-intrinsic-properties-expected.txt:
      * storage/indexeddb/lazy-index-population-expected.txt:
      * storage/indexeddb/legacy-constants-expected.txt:
      * storage/indexeddb/list-ordering-expected.txt:
      * storage/indexeddb/metadata-expected.txt:
      * storage/indexeddb/mozilla/add-twice-failure-expected.txt:
      * storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
      * storage/indexeddb/mozilla/bad-keypath-expected.txt:
      * storage/indexeddb/mozilla/clear-expected.txt:
      * storage/indexeddb/mozilla/create-index-unique-expected.txt:
      * storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
      * storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
      * storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
      * storage/indexeddb/mozilla/cursor-mutation-expected.txt:
      * storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
      * storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
      * storage/indexeddb/mozilla/cursors-expected.txt:
      * storage/indexeddb/mozilla/delete-result-expected.txt:
      * storage/indexeddb/mozilla/event-source-expected.txt:
      * storage/indexeddb/mozilla/global-data-expected.txt:
      * storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
      * storage/indexeddb/mozilla/indexes-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
      * storage/indexeddb/mozilla/object-cursors-expected.txt:
      * storage/indexeddb/mozilla/object-identity-expected.txt:
      * storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
      * storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
      * storage/indexeddb/mozilla/objectstorenames-expected.txt:
      * storage/indexeddb/mozilla/odd-result-order-expected.txt:
      * storage/indexeddb/mozilla/put-get-values-expected.txt:
      * storage/indexeddb/mozilla/readonly-transactions-expected.txt:
      * storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
      * storage/indexeddb/mozilla/readyState-expected.txt:
      * storage/indexeddb/mozilla/remove-index-expected.txt:
      * storage/indexeddb/mozilla/remove-objectstore-expected.txt:
      * storage/indexeddb/mozilla/versionchange-abort-expected.txt:
      * storage/indexeddb/mozilla/versionchange-expected.txt:
      * storage/indexeddb/mutating-cursor-expected.txt:
      * storage/indexeddb/noblobs-expected.txt:
      * storage/indexeddb/objectStore-required-arguments-expected.txt:
      * storage/indexeddb/objectstore-autoincrement-expected.txt:
      * storage/indexeddb/objectstore-basics-expected.txt:
      * storage/indexeddb/objectstore-basics-workers-expected.txt:
      * storage/indexeddb/objectstore-clear-expected.txt:
      * storage/indexeddb/objectstore-count-expected.txt:
      * storage/indexeddb/objectstore-cursor-expected.txt:
      * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
      * storage/indexeddb/odd-strings-expected.txt:
      * storage/indexeddb/open-close-version-expected.txt:
      * storage/indexeddb/open-cursor-expected.txt:
      * storage/indexeddb/open-during-transaction-expected.txt:
      * storage/indexeddb/opencursor-key-expected.txt:
      * storage/indexeddb/pending-activity-expected.txt:
      * storage/indexeddb/pending-activity-workers-expected.txt:
      * storage/indexeddb/pending-version-change-on-exit-expected.txt:
      * storage/indexeddb/persistence-expected.txt:
      * storage/indexeddb/prefetch-bugfix-108071-expected.txt:
      * storage/indexeddb/queued-commands-expected.txt:
      * storage/indexeddb/readonly-expected.txt:
      * storage/indexeddb/readonly-properties-expected.txt:
      * storage/indexeddb/request-continue-abort-expected.txt:
      * storage/indexeddb/request-event-propagation-expected.txt:
      * storage/indexeddb/setVersion-null-expected.txt:
      * storage/indexeddb/set_version_blocked-expected.txt:
      * storage/indexeddb/set_version_queue-expected.txt:
      * storage/indexeddb/structured-clone-expected.txt:
      * storage/indexeddb/three-setversion-calls-expected.txt:
      * storage/indexeddb/transaction-abort-expected.txt:
      * storage/indexeddb/transaction-active-flag-expected.txt:
      * storage/indexeddb/transaction-after-close-expected.txt:
      * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
      * storage/indexeddb/transaction-basics-expected.txt:
      * storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
      * storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
      * storage/indexeddb/transaction-complete-workers-expected.txt:
      * storage/indexeddb/transaction-crash-on-abort-expected.txt:
      * storage/indexeddb/transaction-error-expected.txt:
      * storage/indexeddb/transaction-event-propagation-expected.txt:
      * storage/indexeddb/transaction-read-only-expected.txt:
      * storage/indexeddb/transaction-rollback-expected.txt:
      * storage/indexeddb/transaction-storeNames-required-expected.txt:
      * storage/indexeddb/tutorial-expected.txt:
      * storage/indexeddb/two-version-changes-expected.txt:
      * storage/indexeddb/value-undefined-expected.txt:
      * storage/indexeddb/values-odd-types-expected.txt:
      * storage/indexeddb/version-change-abort-expected.txt:
      * storage/indexeddb/version-change-exclusive-expected.txt:
      * storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ad96a41
    • michelangelo@webkit.org's avatar
      Use arrays in shaders · 0c8994e6
      michelangelo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95223
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Custom Filters' support for array() is introduced. Values within
      the array() function will be passed as uniforms to shaders.
      
      Values within array() are comma-separated; the specification will be
      updated accordingly: https://www.w3.org/Bugs/Public/show_bug.cgi?id=18839
      
      Test: css3/filters/custom/custom-filter-array.html
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::valueForCustomFilterArrayParameter):
      (WebCore):
      (WebCore::valueForCustomFilterParameter):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * css/StyleResolver.h:
      (StyleResolver):
      * platform/graphics/filters/CustomFilterArrayParameter.h: Container for array()
      parameter values.
      (WebCore):
      (CustomFilterArrayParameter):
      (WebCore::CustomFilterArrayParameter::create):
      (WebCore::CustomFilterArrayParameter::size):
      (WebCore::CustomFilterArrayParameter::valueAt):
      (WebCore::CustomFilterArrayParameter::addValue):
      (WebCore::CustomFilterArrayParameter::blend):
      (WebCore::CustomFilterArrayParameter::operator==):
      (WebCore::CustomFilterArrayParameter::CustomFilterArrayParameter):
      * platform/graphics/filters/CustomFilterParameter.h:
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::bindProgramArrayParameters):
      (WebCore):
      (WebCore::FECustomFilter::bindProgramParameters):
      * platform/graphics/filters/FECustomFilter.h:
      (WebCore):
      (FECustomFilter):
      
      LayoutTests:
      
      New tests have been added for checking the correctness of array()
      within shaders.
      
      * css3/filters/custom/custom-filter-array-expected.html: Added.
      * css3/filters/custom/custom-filter-array.html: Added.
      * css3/filters/custom/custom-filter-property-computed-style-expected.txt:
      * css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
      * css3/filters/resources/fragment-color.fs: Added.
      * css3/filters/script-tests/custom-filter-property-computed-style.js:
      * css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
      * platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c8994e6
    • commit-queue@webkit.org's avatar
      WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks · 4c837870
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57570
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Add new didExceedDatabaseQuota callback to WKBundlePageUIClient
      and call it from WebChromeClient::exceededDatabaseQuota().
      This is needed by WebKitTestRunner to dump information about
      database callbacks.
      
      * Shared/APIClientTraits.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setDatabaseQuota): Call WebDatabaseManager::setQuotaForOrigin()
      with "file__0" instead of "file:///" as origin identifier. WebDatabaseManager expects
      a database identifier, not a string representation of the security origin. "file__0" is
      the string that is used as databaseIdentifier of local files. This bug was causing the
      database quota not to be set. The test cases would therefore fail due to the quota being
      0 instead of the value explicitly set.
      * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
      (WebKit::InjectedBundlePageUIClient::didExceedDatabaseQuota):
      (WebKit):
      * WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
      (InjectedBundlePageUIClient):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::exceededDatabaseQuota):
      
      Tools:
      
      Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
      and dump the information expected by the test cases.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting): Explicitly set the default
      database quota.
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::securityOriginToStr): New convenience function to convert
      a security origin to the string expected in test results.
      (WTR):
      (WTR::InjectedBundlePage::InjectedBundlePage):
      (WTR::InjectedBundlePage::didExceedDatabaseQuota):
      (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
      refactoring to share code with didExceedDatabaseQuota.
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
      (InjectedBundlePage):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::TestRunner):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (WTR::TestRunner::dumpDatabaseCallbacks):
      (WTR::TestRunner::shouldDumpDatabaseCallbacks):
      (TestRunner):
      
      LayoutTests:
      
      Unskip several test cases which require implementation of
      testRunner.dumpDatabaseCallbacks in WebKitTestRunner.
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c837870
    • commit-queue@webkit.org's avatar
      [EFL] Gardening of the WK2 Debug Bot failing tests · 808cdde9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96795
      
      Unreviewed EFL gardening.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      808cdde9
    • sergio@webkit.org's avatar
      [GTK] [WK2] Unreviewed gardening. · 89d8408a
      sergio@webkit.org authored
      Added a bunch of tests failing in the WK2 tests bot to the Skipped
      list with the proper links to each bug.
      
      * platform/gtk-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89d8408a
    • commit-queue@webkit.org's avatar
      Gesture events sent to wrong node when page is scrolled · 585f6a68
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96788
      
      Patch by Rick Byers <rbyers@chromium.org> on 2012-09-14
      Reviewed by Antonio Gomes.
      
      Source/WebCore:
      
      Adjust the co-ordinate space correctly when doing hit testing for
      gesture events (as for all other event handling code here).
      
      Test: platform/chromium/plugins/gesture-events-scrolled.html
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleGestureEvent):
      
      LayoutTests:
      
      Add layout test based on gesture-events.html which tests the case when
      the document is scrolled (so that client co-ordinates don't equal page
      co-ordinates).
      * platform/chromium/plugins/gesture-events-scrolled-expected.txt: Added.
      * platform/chromium/plugins/gesture-events-scrolled.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      585f6a68
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Unskip test cases that are now passing · 7cff57c4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96762
      
      Unreviewed EFL gardening, unskip now passing tests.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cff57c4
    • commit-queue@webkit.org's avatar
      WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads · 29bba910
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=42691
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Add WKBundleFrame private API to stop loading of a frame.
      This is needed by WebKitTestRunner to implement
      testrunner.setStopProvisionalFrameLoads.
      
      Original patch by Alexey Proskuryakov.
      
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      (WKBundleFrameStopLoading):
      * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::stopLoading):
      (WebKit):
      * WebProcess/WebPage/WebFrame.h:
      (WebFrame):
      
      Tools:
      
      Add implementation for testrunner.setStopProvisionalFrameLoads()
      in WebKitTestRunner.
      
      Original patch by Alexey Proskuryakov.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::TestRunner):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      (WTR::TestRunner::setStopProvisionalFrameLoads):
      (WTR::TestRunner::shouldStopProvisionalFrameLoads):
      
      LayoutTests:
      
      Unskip fast/loader/stop-provisional-loads.html now that WebKitTestRunner
      implements testrunner.setStopProvisionalFrameLoads().
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29bba910
    • commit-queue@webkit.org's avatar
      [EFL] Attempt to create a theme for 0 sized element leads to assertion hit · 62681d7b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96743
      
      Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
      on that causing crash in debug mode.
      
      Test: fast/forms/range/slider-zero-size-crash.html
      
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
      
      LayoutTests:
      
      RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
      on that causing crash in debug mode.
      
      * fast/forms/range/slider-zero-size-crash-expected.txt: Added.
      * fast/forms/range/slider-zero-size-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62681d7b
    • commit-queue@webkit.org's avatar
      [EFL] Gardening of failing tests · 98aed1f2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96646
      
      Unreviewed EFL gardening of flaky tests on wk1.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      
      * platform/efl-wk1/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98aed1f2
    • commit-queue@webkit.org's avatar
      WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements · 45d63361
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=42687
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Implement testRunner.setTabKeyCyclesThroughElements for
      WebKitTestRunner.
      
      * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
      (WKBundleSetTabKeyCyclesThroughElements):
      * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setTabKeyCyclesThroughElements):
      (WebKit):
      * WebProcess/InjectedBundle/InjectedBundle.h:
      (InjectedBundle):
      
      Tools:
      
      Implement testRunner.setTabKeyCyclesThroughElements for
      WebKitTestRunner.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::setTabKeyCyclesThroughElements):
      (WTR):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests:
      
      fast/events/keypress-insert-tab.html is passing now on wk2. So, unskip
      in common skipped files and re-skip it on efl-wk1 until WK82864 is fixed.
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl/Skipped:
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45d63361
    • commit-queue@webkit.org's avatar
      EventSendingController::keyDown does not support non-array modifier arguments · ee09aa21
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96727
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools:
      
      Add support for handling a string as modifier argument to
      EventSendingController::keyDown.
      
      * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
      (WTR::parseModifierArray):
      
      LayoutTests:
      
      Unskip passing test fast/forms/legend-access-key.html
      
      * platform/efl-wk2/TestExpectations:
      * platform/gtk-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee09aa21
    • vsevik@chromium.org's avatar
      Unreviewed skipping failing test. · 81115fed
      vsevik@chromium.org authored
      * http/tests/inspector/network/network-xhr-replay.html_disabled: Renamed from LayoutTests/http/tests/inspector/network/network-xhr-replay.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81115fed
    • commit-queue@webkit.org's avatar
      WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate · 52ee8d2b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=42546
      
      Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools:
      
      Exported TestRunner::setCustomPolicyDelegate() method.
      Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
      
      LayoutTests:
      
      Unskipped corresponding test cases. Distributed those which still not passing to appropriate groups in Skipped file.
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52ee8d2b
    • tkent@chromium.org's avatar
      Make time input lang attribute aware for testing · aff3c93e
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96728
      
      Patch by Keishi Hattori <keishi@webkit.org> on 2012-09-14
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      This patch implements partial lang attribute support for input type=time
      that turns on only when enabled through InternalSettings.
      
      Test: fast/forms/time-multiple-fields/time-multiple-fields-localization.html
      
      * dom/Document.cpp:
      (WebCore::Document::getLocalizer): Returns a localizer for a given locale. Localizers are cached for repeated use.
      (WebCore):
      * dom/Document.h:
      (WebCore):
      (Document):
      * html/TimeInputType.cpp:
      (WebCore::TimeInputType::updateInnerTextValue): Use the locale for the input element.
      * html/shadow/DateTimeEditElement.cpp:
      (DateTimeEditBuilder):
      (WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
      (WebCore::DateTimeEditBuilder::visitField):
      (WebCore::DateTimeEditElement::layout):
      (WebCore::DateTimeEditElement::setValueAsDate):
      (WebCore::DateTimeEditElement::setEmptyValue):
      * html/shadow/DateTimeEditElement.h:
      (WebCore):
      (DateTimeEditElement):
      
      Source/WebKit/chromium:
      
      * tests/LocalizedDateICUTest.cpp:
      (LocalizedDateICUTest::localizedDateFormatText):
      (LocalizedDateICUTest::localizedShortDateFormatText):
      
      LayoutTests:
      
      * fast/forms/resources/common.js:
      (getUserAgentShadowTextContent): Used to get the text inside an input element.
      * fast/forms/time-multiple-fields/time-multiple-fields-localization.html: Added.
      * platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aff3c93e
    • yosin@chromium.org's avatar
      REGRESSION(r128575):... · cf26a9fd
      yosin@chromium.org authored
      REGRESSION(r128575): fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html is failed on Chromium-Win
      https://bugs.webkit.org/show_bug.cgi?id=96754
      
      Reviewed by Kent Tamura.
      
      The root cause of this failure is Chromium-Win port has a second field
      event if step=60 due by Windows platform API.
      
      This patch changes test sample to have a second field to get rid of
      such difference.
      
      * fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Updates expectation.
      * fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Changed to add "step=1" to
      test sample and to add a second field value to expectation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf26a9fd
    • commit-queue@webkit.org's avatar
      [WK2][WKTR] TestRunner is not dumping some frame load callbacks information · f6db33ac
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96740
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools:
      
      Dump information expected by the test cases about the following
      frame load callbacks:
      "didDisplayInsecureContentForFrame"
      "didRunInsecureContentForFrame"
      "didDetectXSSForFrame"
      
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
      as expected by test results by calling pathSuitableForTestResult() instead
      of printing raw URL.
      (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
      (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
      (WTR::InjectedBundlePage::didDetectXSSForFrame):
      
      LayoutTests:
      
      Unskip test cases which were failing due to missing
      frame load callbacks information dumping with
      WebKitTestRunner.
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6db33ac
    • vsevik@chromium.org's avatar
      Web Inspector: Add ability to replay XHR in network panel. · c5c37b9a
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95187
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Patch based on Pavel Chadnov's patch.
      This patch implements Replay XHR feature in web inspector.
      XMLHttpRequest's ThreadableLoaderClient is now used to map XMLHttpRequest object to ResourceLoader request identifiers.
      Before initiating load all XHR parameters are now sent to inspector.
      XMLHttpRequest parameters are stored in inspector's network request cache in XHRReplayData class.
      When XHR replay is requested, a new XMLHttpRequest is created based on stored data.
      
      Test: http/tests/inspector/network/network-xhr-replay.html
      
      * inspector/Inspector.json:
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
      * inspector/InspectorConsoleAgent.h:
      (InspectorConsoleAgent):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClientImpl):
      (WebCore::InspectorInstrumentation::willLoadXHRImpl):
      (WebCore::InspectorInstrumentation::didFailXHRLoadingImpl):
      (WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClient):
      (WebCore::InspectorInstrumentation::willLoadXHR):
      (WebCore::InspectorInstrumentation::didFailXHRLoading):
      (WebCore::InspectorInstrumentation::didFinishXHRLoading):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
      (WebCore::InspectorResourceAgent::documentThreadableLoaderStartedLoadingForClient):
      (WebCore):
      (WebCore::InspectorResourceAgent::willLoadXHR):
      (WebCore::InspectorResourceAgent::didFailXHRLoading):
      (WebCore::InspectorResourceAgent::didFinishXHRLoading):
      (WebCore::InspectorResourceAgent::replayXHR):
      * inspector/InspectorResourceAgent.h:
      (WebCore):
      (InspectorResourceAgent):
      * inspector/NetworkResourcesData.cpp:
      (WebCore::XHRReplayData::create):
      (WebCore):
      (WebCore::XHRReplayData::addHeader):
      (WebCore::XHRReplayData::XHRReplayData):
      (WebCore::NetworkResourcesData::xhrReplayData):
      (WebCore::NetworkResourcesData::setXHRReplayData):
      (WebCore::NetworkResourcesData::reuseXHRReplayData):
      (WebCore::NetworkResourcesData::clear):
      * inspector/NetworkResourcesData.h:
      (XHRReplayData):
      (WebCore::XHRReplayData::method):
      (WebCore::XHRReplayData::url):
      (WebCore::XHRReplayData::async):
      (WebCore::XHRReplayData::formData):
      (WebCore::XHRReplayData::headers):
      (WebCore::XHRReplayData::includeCredentials):
      (WebCore):
      (WebCore::NetworkResourcesData::ResourceData::xhrReplayData):
      (WebCore::NetworkResourcesData::ResourceData::setXHRReplayData):
      (ResourceData):
      (NetworkResourcesData):
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkLogView.prototype._contextMenu):
      (WebInspector.NetworkLogView.prototype._replayXHR):
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::loadRequest): added documentThreadableLoaderStartedLoadingForClient instrumentation
      so that inspector could map XMLHttpRequest to ResourceLoader's identifiers.
      * loader/cache/CachedResource.h:
      (WebCore::CachedResource::loader): DocumentThreadableLoader uses CachedResource::loader() to get ResourceLoader identifier.
      (CachedResource):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::sendFromInspector): Added a method for sending XMLHttpRequests based on request body stored in inspector.
      (WebCore):
      (WebCore::XMLHttpRequest::createRequest): Replaced will/didLoadXHRSynchonously instrumentations with willLoadXHR instrumentation.
      (WebCore::XMLHttpRequest::internalAbort): Added didFailXHRLoadingInstrumentation
      (WebCore::XMLHttpRequest::didFinishLoading): Added didFinishXHRLoading instrumentation
      * xml/XMLHttpRequest.h:
      (XMLHttpRequest):
      
      LayoutTests:
      
      Added XHR replay test.
      
      * http/tests/inspector/network/network-xhr-replay-expected.txt: Added.
      * http/tests/inspector/network/network-xhr-replay.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5c37b9a
    • commit-queue@webkit.org's avatar
      [WK2] Move globalhistory tests to their correct section in Skipped list · 9b058ca6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96738
      
      Unreviewed gardening.
      
      Move 2 globalhistory tests to their correct section in WK2
      Skipped list.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-14
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b058ca6
    • yosin@chromium.org's avatar
      [Forms] multiple fields time input UI should save/restore its value even if it has an empty field. · 2d3b21f3
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96714
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      This patch changes multiple fields time input UI to save/restore value
      of fields rather than time value. For this change, storage format of
      input type "time" is also changed.
      
      Before this patch, if user populates time fiels partially, all fields
      are reset to initial value after back/forward navigation.
      
      After this patch, partially populated fields are preserved after
      back/forward navigation.
      
      Fields of DateTimeEditElement are represented as 9 elements of
      string vector in FormControlState regardless actual fields in
      DateTimeEditElement for ease of restoring/saving.
      
      This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
      ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
      
      No new tests. Existing test fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html
      convers this change.
      
      * WebCore.gypi: Chagned to add DateTimeFieldsState.{cpp.h}
      * html/DateTimeFieldsState.cpp: Added.
      (WebCore::getNumberFromFormControlState): Extracts unsigned integer or empty value from FormControlState.
      (WebCore::getAMPMFromFormControlState): Extracts AM/PM value or empty value from FormControlState.
      (WebCore::DateTimeFieldsState::DateTimeFieldsState): Initializes fields with empty value.
      (WebCore::DateTimeFieldsState::restoreFormControlState): Makes DateTimeFieldsState instance from FormControlState.
      (WebCore::DateTimeFieldsState::saveFormControlState): Makes FormControlState from DateTimeFieldsState.
      * html/DateTimeFieldsState.h: Added.
      (DateTimeFieldsState):
      (WebCore::DateTimeFieldsState::ampm): Returns AM/PM field value.
      (WebCore::DateTimeFieldsState::dayOfMonth): Returns day of month field value.
      (WebCore::DateTimeFieldsState::hour): Reutrns hour field value.
      (WebCore::DateTimeFieldsState::millisecond): Returns millisecond field value.
      (WebCore::DateTimeFieldsState::minute): Returns minute field value.
      (WebCore::DateTimeFieldsState::month): Returns month field value.
      (WebCore::DateTimeFieldsState::second): Returns second field value.
      (WebCore::DateTimeFieldsState::weekOfYear): Returns week of year field.
      (WebCore::DateTimeFieldsState::year): Returns year field value.
      (WebCore::DateTimeFieldsState::hasAMPM): Returns true if AM/PM field has value.
      (WebCore::DateTimeFieldsState::hasDayOfMonth): Returns true if day of month field has value.
      (WebCore::DateTimeFieldsState::hasHour): Returns true if hour field has value.
      (WebCore::DateTimeFieldsState::hasMillisecond): Returns true if millisecond field has value.
      (WebCore::DateTimeFieldsState::hasMinute): Returns true if minute field has value.
      (WebCore::DateTimeFieldsState::hasMonth): Returns true if month field has value.
      (WebCore::DateTimeFieldsState::hasSecond): Returns true if second field has value.
      (WebCore::DateTimeFieldsState::hasWeekOfYear): Returns true if week of year field has value.
      (WebCore::DateTimeFieldsState::hasYear): Returns true if year field has value.
      (WebCore::DateTimeFieldsState::setAMPM): Sets AM/PM field.
      (WebCore::DateTimeFieldsState::setDayOfMonth): Sets day of month field.
      (WebCore::DateTimeFieldsState::setHour): Sets hour field.
      (WebCore::DateTimeFieldsState::setMillisecond): Sets millisecond field.
      (WebCore::DateTimeFieldsState::setMinute): Sets minute field.
      (WebCore::DateTimeFieldsState::setMonth): Sets month field.
      (WebCore::DateTimeFieldsState::setSecond): Set second field.
      (WebCore::DateTimeFieldsState::setWeekOfYear): Sets week of year field.
      (WebCore::DateTimeFieldsState::setYear): Sets year field.
      * html/FormController.cpp:
      (WebCore::formStateSignature): Increment version number to 8 for incompatible change of FormControlState.
      * html/TimeInputType.cpp:
      (WebCore::TimeInputType::restoreFormControlState): Added to call DateTimeFieldsState::restoreFormControlState().
      (WebCore::TimeInputType::saveFormControlState): Added to call DateTimeFieldsState::saveFormControlState().
      * html/TimeInputType.h:
      (TimeInputType): Added declarations for restoreFormControlState() and saveFormControlState().
      * html/shadow/DateTimeEditElement.cpp:
      (WebCore::DateTimeEditElement::setValueAsDateTimeFieldsState): Added to set fields from DateTimeFieldsState.
      (WebCore::DateTimeEditElement::valueAsDateTimeFieldsState): Added to make DateTimeFieldsState from fields.
      * html/shadow/DateTimeEditElement.h:
      (DateTimeEditElement): Added declarations for setValueAsDateTimeFieldsState() and valueAsDateTimeFieldsState().
      * html/shadow/DateTimeFieldElement.h:
      (DateTimeFieldElement): Added declarations for populateDateTimeFieldsState() and setValueAsDateTimeFieldsState().
      * html/shadow/DateTimeFieldElements.cpp:
      (WebCore::DateTimeAMPMFieldElement::populateDateTimeFieldsState): Added to set AM/PM value to DateTimeFieldsState.
      (WebCore::DateTimeAMPMFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
      (WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState): Added to set hour value to DateTimeFieldsState.
      (WebCore::DateTimeHourFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
      (WebCore::DateTimeMillisecondFieldElement::populateDateTimeFieldsState): Added to set millisecond value to DateTimeFieldsState.
      (WebCore::DateTimeMillisecondFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
      (WebCore::DateTimeMinuteFieldElement::populateDateTimeFieldsState): Added to set minute value to DateTimeFieldsState.
      (WebCore::DateTimeMinuteFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
      (WebCore::DateTimeSecondFieldElement::populateDateTimeFieldsState): Added to set second value to DateTimeFieldsState.
      (WebCore::DateTimeSecondFieldElement::setValueAsDateTimeFieldsState): Added to set field value from DateTimeFieldsState.
      * html/shadow/DateTimeFieldElements.h:
      (DateTimeAMPMFieldElement): Added declarations of populateDateTimeFieldsState() and setValueAsDateTimeFieldsState().
      (DateTimeHourFieldElement): ditto.
      (DateTimeMillisecondFieldElement): ditto.
      (DateTimeMinuteFieldElement): ditto.
      (DateTimeSecondFieldElement): ditto.
      * html/shadow/DateTimeNumericFieldElement.h:
      (DateTimeNumericFieldElement): Extend accessibility of maximum() and setEmptyValue() to protected.
      * html/shadow/DateTimeSymbolicFieldElement.h:
      (DateTimeSymbolicFieldElement): Extend accessibility of hasValue(), setEmptyValue() and valueAsInteger() to protected.
      
      LayoutTests:
      
      This patch changes time-multiple-fields-preserve-value-after-history-back.html
      to check partial value is saved and restored rather than resetting value.
      
      This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
      ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
      
      * fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Updated for new expectation.
      * fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Changed to check partially populated fields of input element.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d3b21f3
    • vsevik@chromium.org's avatar
      Web Inspector: [Tests] Extract a common method for sending XHRs from tests. · 818040c0
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96662
      
      Reviewed by Alexander Pavlov.
      
      Extracted InspectorTest.makeXHR() methods to simplify tests.
      
      * http/tests/inspector/appcache/appcache-swap-expected.txt:
      * http/tests/inspector/appcache/appcache-swap.html:
      * http/tests/inspector/console-xhr-logging-async-expected.txt:
      * http/tests/inspector/console-xhr-logging-async.html:
      * http/tests/inspector/console-xhr-logging.html:
      * http/tests/inspector/network-test.js:
      (xhrLoadedCallback):
      (initialize_NetworkTest.InspectorTest.makeSimpleXHR):
      (initialize_NetworkTest.InspectorTest.makeSimpleXHRWithPayload):
      (initialize_NetworkTest.InspectorTest.makeXHR.innerCallback):
      (initialize_NetworkTest.InspectorTest.makeXHR):
      (doSimpleXHR):
      (doSimpleXHRWithPayload):
      (doXHR):
      (makeXHR):
      * http/tests/inspector/network/async-xhr-json-mime-type-expected.txt:
      * http/tests/inspector/network/async-xhr-json-mime-type.html:
      * http/tests/inspector/network/network-clear-cache.html-disabled:
      * http/tests/inspector/network/network-clear-cookies.html-disabled:
      * http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
      * http/tests/inspector/network/network-content-replacement-xhr.html:
      * http/tests/inspector/network/network-cyrillic-xhr-expected.txt:
      * http/tests/inspector/network/network-cyrillic-xhr.html:
      * http/tests/inspector/network/network-disable-cache-xhrs-expected.txt:
      * http/tests/inspector/network/network-disable-cache-xhrs.html:
      * http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt:
      * http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
      * http/tests/inspector/network/network-empty-xhr-expected.txt:
      * http/tests/inspector/network/network-empty-xhr.html:
      * http/tests/inspector/network/network-sidebar-width-expected.txt:
      * http/tests/inspector/network/network-sidebar-width.html:
      * http/tests/inspector/network/network-size-sync.html:
      * http/tests/inspector/network/network-xhr-async-double-expected.txt:
      * http/tests/inspector/network/network-xhr-async-double.html:
      * http/tests/inspector/network/network-xhr-async-expected.txt:
      * http/tests/inspector/network/network-xhr-async.html:
      * http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt:
      * http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
      * http/tests/inspector/network/network-xhr-sync-expected.txt:
      * http/tests/inspector/network/network-xhr-sync.html:
      * http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt:
      * http/tests/inspector/resource-tree/resource-tree-no-xhrs.html:
      * platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt:
      * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      818040c0
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, remove an unnecessary expected file. · 4c510d5d
      ossy@webkit.org authored
      * platform/qt/fast/events/keyevent-iframe-removed-crash-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c510d5d
  2. 13 Sep, 2012 16 commits
    • commit-queue@webkit.org's avatar
      [Qt][WK2] qt-5.0-wk2 Skipped file can be updated after bug #73917 got fixed · c684d1ae
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96675
      
      Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-09-13
      Reviewed by Simon Hausmann.
      
      Update Skipped list after userAgent proper support.
      
      * platform/qt-5.0-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c684d1ae
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · 824be805
      tkent@chromium.org authored
      * platform/chromium/TestExpectations:
      Fix an error in the previous change.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      824be805
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · 9bec1558
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96725
      
      * platform/chromium/TestExpectations:
      http/tests/media/media-source/video-media-source-state-changes.html is flaky
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bec1558
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · 66c5b9cd
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93589
      
      * platform/chromium/TestExpectations:
      script-change-externalResourcesRequired-while-loading.svg is flaky on all platforms.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66c5b9cd
    • tkent@chromium.org's avatar
      [Chromium] Test expectation udpate. · b08bee03
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96720
      
      * platform/chromium/TestExpectations:
      time-multiple-fields-preserve-value-after-history-back.html is flaky.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b08bee03
    • fpizlo@apple.com's avatar
      DFG: Dead GetButterfly's shouldn't be subject to CSE · 00298b98
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96707
      <rdar://problem/12296311>
      
      Source/JavaScriptCore: 
      
      Reviewed by Oliver Hunt.
              
      There were a number of cases of this that creeped into the CSE: it would
      match something even though it was dead.
      
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
      (JSC::DFG::CSEPhase::checkArrayElimination):
      (JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
      (JSC::DFG::CSEPhase::getScopeChainLoadElimination):
      (JSC::DFG::CSEPhase::getLocalLoadElimination):
      
      LayoutTests: 
      
      Reviewed by Oliver Hunt.
      
      * fast/js/dfg-dead-redundant-get-array-length-expected.txt: Added.
      * fast/js/dfg-dead-redundant-get-array-length.html: Added.
      * fast/js/jsc-test-list:
      * fast/js/script-tests/dfg-dead-redundant-get-array-length.js: Added.
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00298b98
    • ojan@chromium.org's avatar
      Test rebaselines after http://trac.webkit.org/changeset/128517. · 2f341ec5
      ojan@chromium.org authored
      * fast/table/height-percent-test-expected.txt:
      * platform/chromium-mac-snowleopard/fast/table/height-percent-test-expected.png:
      * platform/chromium-mac-snowleopard/tables/mozilla/core/cell_heights-expected.png:
      * platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
      * platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
      * platform/chromium-mac/fast/table/height-percent-test-expected.png:
      * platform/chromium-mac/tables/mozilla/core/cell_heights-expected.png:
      * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
      * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
      * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
      * platform/chromium-win/fast/table/height-percent-test-expected.png:
      * platform/chromium-win/tables/mozilla/core/cell_heights-expected.png:
      * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
      * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/efl/fast/table/height-percent-test-expected.txt: Removed.
      * platform/gtk/TestExpectations:
      * platform/gtk/fast/table/height-percent-test-expected.txt: Removed.
      * platform/gtk/tables/mozilla/core/cell_heights-expected.txt:
      * platform/gtk/tables/mozilla_expected_failures/bugs/bug19526-expected.txt: Removed.
      * platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
      * platform/mac/TestExpectations:
      * platform/mac/tables/mozilla/core/cell_heights-expected.txt:
      * platform/mac/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
      * platform/qt/TestExpectations:
      * platform/qt/fast/table/height-percent-test-expected.txt: Renamed from LayoutTests/platform/mac/fast/table/height-percent-test-expected.txt.
      * platform/qt/tables/mozilla/core/cell_heights-expected.txt:
      * platform/qt/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
      * platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
      * platform/win-future/fast/table/height-percent-test-expected.txt: Copied from LayoutTests/fast/table/height-percent-test-expected.txt.
      * tables/mozilla_expected_failures/bugs/bug19526-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug19526-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f341ec5
    • ojan@chromium.org's avatar
      Rebaseline fast/css/percentage-height-auto-sized-body-quirks.html after · f78ff22c
      ojan@chromium.org authored
      http://trac.webkit.org/changeset/128517. The results are now consistent
      across platforms.
      
      * platform/efl/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
      * platform/gtk/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
      * platform/mac/TestExpectations:
      * platform/qt/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f78ff22c
    • ojan@chromium.org's avatar
      Remove lines for fast/table/bad-replaced-sizing-preferred-logical-widths.html · 13215252
      ojan@chromium.org authored
      fixed in http://trac.webkit.org/changeset/128528.
      
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13215252
    • jamesr@google.com's avatar
      Unreviewed gardening for r128516/r128517: · 6761ad72
      jamesr@google.com authored
        remove the now-unnecessary cr-mac expectations for fast/writing-mode test.
        fix baseline for fast/table/bad-replaced-sizing-preferred-logical-widths.html
      
      * platform/chromium-mac/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6761ad72
    • tsepez@chromium.org's avatar
      Source/WebCore: ASSERT(!eventDispatchForbidden()) fires when removed plugin... · 43056c5f
      tsepez@chromium.org authored
      Source/WebCore: ASSERT(!eventDispatchForbidden()) fires when removed plugin re-inserted as part of readyStateChange.
      https://bugs.webkit.org/show_bug.cgi?id=93639
      
      Reviewed by Ryosuke Niwa.
      
      Removing a plugin causes a detach which can cancel the last remaining load on a page,
      resulting in a readyStateChange event during a time when things are inconsisent. Defer
      the detach which triggers this chain of events until after the node is fully removed
      from the document's elementsById map.
      
      Test: plugins/plugin-remove-readystatechange.html
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::removeChild):
      (WebCore::ContainerNode::removeChildren):
      
      LayoutTests: ASSERT(!eventDispatchForbidden()) firest when removed plugin re-inserted as part of readyStateChange.
      https://bugs.webkit.org/show_bug.cgi?id=93639
      
      Reviewed by Ryosuke Niwa.
      
      Add a new testcase to cover this issue.  Test passes if assert doesn't fire in debug builds.
      
      * plugins/plugin-remove-readystatechange-expected.txt: Added.
      * plugins/plugin-remove-readystatechange.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43056c5f
    • ojan@chromium.org's avatar
      percentage heights in quirks mode with auto-sized body are computed incorrectly · f766954f
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96426
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      In quirks mode, for the body element, we need to keep walking up to the html element
      if the body's height is auto. Also, we need to subtract the body/html elements
      margin/border/padding so that we properly get the body's content height.
      
      This behavior matches IE9, FF and Opera.
      
      None of this applies to standards mode since we don't walk up the
      containingBlock chain for auto-sized elements.
      
      Test: fast/css/percentage-height-auto-sized-body-quirks.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computePercentageLogicalHeight):
      
      LayoutTests:
      
      * fast/css/percentage-height-auto-sized-body-quirks-expected.txt: Added.
      * fast/css/percentage-height-auto-sized-body-quirks.html: Added.
      Verified that this matches IE9, FF15 and Opera12.
      
      * fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt:
      * platform/chromium-linux/fast/table/height-percent-test-expected.png:
      * platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
      * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
      * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
      * platform/chromium-win/tables/mozilla/core/cell_heights-expected.txt:
      * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.txt:
      * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
      * platform/mac/fast/table/height-percent-test-expected.txt:
      Verified that all the changes match FF15.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f766954f
    • ojan@chromium.org's avatar
      fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on... · f63ec8c9
      ojan@chromium.org authored
      fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chromium-Mac, GTK, EFL
      https://bugs.webkit.org/show_bug.cgi?id=96594
      
      Reviewed by Tony Chang.
      
      Remove the text so that this test gets metrics the same across platforms.
      
      * fast/table/bad-replaced-sizing-preferred-logical-widths.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f63ec8c9
    • jamesr@google.com's avatar
      Unreviewed gardening. Fix lint error in my last TestExpectations patch - whoops! · 04dcede3
      jamesr@google.com authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04dcede3
    • enne@google.com's avatar
      Hide all ancestors of the full screen element when going full screen · e489e468
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96332
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Since fixed position elements can now sometimes become stacking
      contexts, explicitly set position: static on full-screen ancestors so
      that there are no stacking context ancestors that could cause the full
      screen element to become incorrectly sorted.
      
      Test: fullscreen/full-screen-fixed-pos-parent.html
      
      * css/fullscreen.css:
      (:-webkit-full-screen-ancestor:not(iframe)):
      
      LayoutTests:
      
      This test has an all red image that (without this patch) incorrectly
      sorts on top of the full screen element. With this patch, the all
      green full screen element appears on top.
      
      * fullscreen/full-screen-fixed-pos-parent-expected.png: Added.
      * fullscreen/full-screen-fixed-pos-parent-expected.txt: Added.
      * fullscreen/full-screen-fixed-pos-parent.html: Added.
      * fullscreen/resources/green.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e489e468
    • abarth@webkit.org's avatar
      REGRESSION(r125126): It made fast/events/keyevent-iframe-removed-crash.html assert · 1e498553
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93654
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      When wrapping a Document, we need to ensure that the global object for
      the wrapper actually exists before trying to create the wrapper. In
      other cases in the DOM, we always touch the global object before trying
      to wrap a given DOM object. For Document, however,
      HTMLFrameElement.contentDocument is a rare way to get at a DOM object
      for a global object without first touching the Window object.
      
      Rather than writing custom bindings for
      HTMLFrameElement.contentDocument, this patch just makes toJS for
      Document ensure that toJS for DOMWindow has been called first. The V8
      bindings have some similar code.
      
      Test: fast/dom/content-document-prototype.html
      
      * bindings/js/JSDocumentCustom.cpp:
      (WebCore::toJS):
      
      LayoutTests:
      
      * fast/dom/content-document-prototype-expected.txt: Added.
      * fast/dom/content-document-prototype.html: Added.
          - Check that HTMLFrameElement.contentDocument ends up with the
            right prototype chain. This is a tricky case because not only the
            prototype chain of the property different from the holder, we
            never actually touch the DOMWindow in this test case so the
            prototype chain leads to a global object that doesn't even exist
            yet!
      * fast/events/keyevent-iframe-removed-crash.html:
          - Add a call to gc() so that this test will ASSERT reliabily if we
            cause a similar problem in the future.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e498553