1. 03 Nov, 2008 2 commits
  2. 02 Nov, 2008 3 commits
  3. 01 Nov, 2008 3 commits
    • abarth@webkit.org's avatar
      WebCore: · a796cc07
      abarth@webkit.org authored
      2008-11-01  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Be sure to check the final URLs of requested resources to make sure we
              don't get fooled by HTTP redirects.
      
              https://bugs.webkit.org/show_bug.cgi?id=21963
      
              Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml
                     http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml
      
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::openFunc):
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::canRequest):
              (WebCore::DocLoader::requestResource):
              * loader/DocLoader.h:
              * xml/XSLTProcessor.cpp:
              (WebCore::docLoaderFunc):
      
      LayoutTests:
      
      2008-11-01  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              Test that we properly block non-same-origin redirects for these
              esoteric loads.
      
              https://bugs.webkit.org/show_bug.cgi?id=21963
      
              * http/tests/security/resources/xsl-using-document-redirect.xsl: Added.
              * http/tests/security/resources/xsl-using-external-entity-redirect.xsl: Added.
              * http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-document-expected.txt.
              * http/tests/security/xss-DENIED-xsl-document-redirect.xml: Added.
              * http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt.
              * http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a796cc07
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · ec7365b9
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=22001
              AtomicStringImpl* keys of event listener maps can outlive their strings
      
              Test: fast/events/destroyed-atomic-string.html
      
              * dom/MessagePort.cpp:
              (WebCore::MessagePort::addEventListener):
              (WebCore::MessagePort::removeEventListener):
              (WebCore::MessagePort::dispatchEvent):
              * dom/MessagePort.h:
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::addEventListener):
              (WebCore::DOMApplicationCache::removeEventListener):
              (WebCore::DOMApplicationCache::dispatchEvent):
              * loader/appcache/DOMApplicationCache.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::addEventListener):
              (WebCore::XMLHttpRequest::removeEventListener):
              (WebCore::XMLHttpRequest::dispatchEvent):
              * xml/XMLHttpRequest.h:
              * xml/XMLHttpRequestUpload.cpp:
              (WebCore::XMLHttpRequestUpload::addEventListener):
              (WebCore::XMLHttpRequestUpload::removeEventListener):
              (WebCore::XMLHttpRequestUpload::dispatchEvent):
              * xml/XMLHttpRequestUpload.h:
              Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec7365b9
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · f319b265
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=21998
              Use JSDOMGlobalObject in EventListener-related bindings
      
              * dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.
      
              * bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS
              bindings for inline event handlers.
      
              * bindings/js/JSDOMApplicationCacheCustom.cpp:
              (WebCore::JSDOMApplicationCache::addEventListener):
              (WebCore::JSDOMApplicationCache::removeEventListener):
              * bindings/js/JSEventTargetNodeCustom.cpp:
              (WebCore::JSEventTargetNode::addEventListener):
              (WebCore::JSEventTargetNode::removeEventListener):
              * bindings/js/JSMessagePortCustom.cpp:
              (WebCore::JSMessagePort::removeEventListener):
              * bindings/js/JSSVGElementInstanceCustom.cpp:
              (WebCore::JSSVGElementInstance::addEventListener):
              (WebCore::JSSVGElementInstance::removeEventListener):
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::addEventListener):
              (WebCore::JSXMLHttpRequest::removeEventListener):
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              (WebCore::JSXMLHttpRequestUpload::addEventListener):
              (WebCore::JSXMLHttpRequestUpload::removeEventListener):
              Use ScriptExecutionContext and JSDOMGlobalObject in bindings.
      
              * dom/EventTarget.h:
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::scriptExecutionContext):
              * dom/EventTargetNode.h:
              * dom/MessagePort.cpp:
              * dom/MessagePort.h:
              (WebCore::MessagePort::scriptExecutionContext):
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::scriptExecutionContext):
              * loader/appcache/DOMApplicationCache.h:
              * svg/SVGElementInstance.cpp:
              (WebCore::SVGElementInstance::scriptExecutionContext):
              * svg/SVGElementInstance.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::scriptExecutionContext):
              * xml/XMLHttpRequest.h:
              * xml/XMLHttpRequestUpload.cpp:
              (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
              * xml/XMLHttpRequestUpload.h:
              Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't
              available yet.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f319b265
  4. 31 Oct, 2008 32 commits
    • slewis@apple.com's avatar
      2008-10-31 Stephanie Lewis <slewis@apple.com> · 487c452c
      slewis@apple.com authored
              Fix build by including right files.
      
              * JSRun.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      487c452c
    • cwzwarich@webkit.org's avatar
      2008-10-31 Cameron Zwarich <zwarich@apple.com> · 16e3891a
      cwzwarich@webkit.org authored
              Rubber-stamped by Geoff Garen.
      
              Rename SourceRange.h to SourceCode.h.
      
              JavaScriptCore:
      
              * API/JSBase.cpp:
              * GNUmakefile.am:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * VM/CodeBlock.h:
              * kjs/SourceCode.h: Copied from kjs/SourceRange.h.
              * kjs/SourceRange.h: Removed.
              * kjs/grammar.y:
              * kjs/lexer.h:
              * kjs/nodes.cpp:
              (JSC::ForInNode::ForInNode):
              * kjs/nodes.h:
              (JSC::ThrowableExpressionData::setExceptionSourceCode):
      
              WebCore:
      
              * ForwardingHeaders/kjs/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceRange.h.
              * ForwardingHeaders/kjs/SourceRange.h: Removed.
              * bindings/js/StringSourceProvider.h:
              * bridge/NP_jsobject.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16e3891a
    • cwzwarich@webkit.org's avatar
      2008-10-31 Cameron Zwarich <zwarich@apple.com> · 7d328d5f
      cwzwarich@webkit.org authored
              Reviewed by Darin Adler.
      
              Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
              <https://bugs.webkit.org/show_bug.cgi?id=22019>
      
              The JSC::Interpreter::shouldPrintExceptions() function is not used at
              all in JavaScriptCore, so it should be moved to WebCore::Console, its
              only user.
      
              JavaScriptCore:
      
              * JavaScriptCore.exp:
              * kjs/interpreter.cpp:
              * kjs/interpreter.h:
      
              WebCore:
      
              * WebCore.base.exp:
              * page/Console.cpp:
              (WebCore::printToStandardOut):
              (WebCore::Console::shouldPrintExceptions):
              (WebCore::Console::setShouldPrintExceptions):
              * page/Console.h:
      
              WebKit/mac:
      
              * Misc/WebCoreStatistics.mm:
              (+[WebCoreStatistics shouldPrintExceptions]):
              (+[WebCoreStatistics setShouldPrintExceptions:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d328d5f
    • christian@webkit.org's avatar
      Reviewed by Mark Rowe. · 354387a2
      christian@webkit.org authored
      http://bugs.webkit.org/show_bug.cgi?id=22018
      enable-developer-extras doesn't toggle WebInspector
      
      * webkit/webkitwebview.cpp:
      Add missing 'if' in notification for 'enable-developer-extras'.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      354387a2
    • mitz@apple.com's avatar
      WebCore: · b7f8848d
      mitz@apple.com authored
              Reviewed by John Sullivan.
      
              - WebCore part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
      
              * dom/Document.cpp:
              (WebCore::Document::cookie): Added checking if cookies are disabled.
              (WebCore::Document::setCookie): Ditto.
              * page/Navigator.cpp:
              (WebCore::Navigator::cookieEnabled): Ditto.
              * page/Page.cpp:
              (WebCore::Page::Page): Initialize m_cookieEnabled to true.
              * page/Page.h:
              (WebCore::Page::cookieEnabled): Added.
              (WebCore::Page::setCookieEnabled): Added.
      
      WebKit/mac:
      
              Reviewed by John Sullivan.
      
              - WebKit/mac part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
      
              * WebView/WebView.mm:
              (-[WebView _cookieEnabled]):
              (-[WebView _setCookieEnabled:]):
              * WebView/WebViewPrivate.h:
      
      WebKit/win:
      
              Reviewed by John Sullivan.
      
              - WebKit/win part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
      
              * Interfaces/IWebViewPrivate.idl:
              * WebView.cpp:
              (WebView::setCookieEnabled):
              (WebView::cookieEnabled):
              * WebView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7f8848d
    • adele@apple.com's avatar
      WebCore: · ae80b36e
      adele@apple.com authored
      2008-10-31  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              WebCore Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
              https://bugs.webkit.org/show_bug.cgi?id=22008
      
              * platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon): 
              Rename newIconForFile and newIconForFiles to createIconForFile and createIconForFiles.
              * platform/graphics/Icon.h: ditto.
              * platform/graphics/gtk/IconGtk.cpp:
              (WebCore::Icon::createIconForFile): ditto.
              (WebCore::Icon::createIconForFiles): ditto.
              * platform/graphics/mac/IconMac.mm:
              (WebCore::Icon::createIconForFile): ditto.
              (WebCore::Icon::createIconForFiles): ditto.
              * platform/graphics/qt/IconQt.cpp:
              (WebCore::Icon::createIconForFile): ditto.
              (WebCore::Icon::createIconForFiles): ditto.
              * platform/wx/TemporaryLinkStubs.cpp:
              (Icon::createIconForFile): ditto.
              (Icon::createIconForFiles): ditto.
              * platform/graphics/win/IconWin.cpp:
              (WebCore::Icon::createIconForFile): ditto.
              (WebCore::Icon::createIconForFiles): Add creation of an icon for multiple files.
      
              * rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):        
              Improve icon creation code to match new code in Icon::createIconForFiles
      
      WebKit/win:
      
      2008-10-31  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              WebKit Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
              https://bugs.webkit.org/show_bug.cgi?id=22008
              
              * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel): 
              Add support for mulitple file selection.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae80b36e
    • andersca@apple.com's avatar
      2008-10-31 Anders Carlsson <andersca@apple.com> · 21b18256
      andersca@apple.com authored
              Reviewed by Kevin Decker.
      
              Move WebNetscapePluginEventHandler classes to a subgroup of Netscape Plug-Ins.
              
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21b18256
    • cwzwarich@webkit.org's avatar
      2008-10-31 Cameron Zwarich <zwarich@apple.com> · 47fadbce
      cwzwarich@webkit.org authored
              Not reviewed.
      
              Windows build fix.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47fadbce
    • cwzwarich@webkit.org's avatar
      2008-10-31 Cameron Zwarich <zwarich@apple.com> · ae91ebda
      cwzwarich@webkit.org authored
              Rubber-stamped by Sam Weinig.
      
              Remove the call to Interpreter::setShouldPrintExceptions() from the
              GlobalObject constructor in the shell. The shouldPrintExceptions()
              information is not used anywhere in JavaScriptCore, only in WebCore.
      
              * kjs/Shell.cpp:
              (GlobalObject::GlobalObject):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae91ebda
    • kevino@webkit.org's avatar
      A couple wxMSW build fixes. · 8ca114ef
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ca114ef
    • cwzwarich@webkit.org's avatar
      2008-10-31 Cameron Zwarich <zwarich@apple.com> · 06128761
      cwzwarich@webkit.org authored
              Rubber-stamped by Sam Weinig.
      
              Move more files from the kjs subdirectory of JavaScriptCore to the
              runtime subdirectory.
      
              * GNUmakefile.am:
              * JavaScriptCore.pri:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * JavaScriptCoreSources.bkl:
              * kjs/AllInOneFile.cpp:
              * kjs/RegExpConstructor.cpp: Removed.
              * kjs/RegExpConstructor.h: Removed.
              * kjs/RegExpMatchesArray.h: Removed.
              * kjs/RegExpObject.cpp: Removed.
              * kjs/RegExpObject.h: Removed.
              * kjs/RegExpPrototype.cpp: Removed.
              * kjs/RegExpPrototype.h: Removed.
              * runtime/RegExpConstructor.cpp: Copied from kjs/RegExpConstructor.cpp.
              * runtime/RegExpConstructor.h: Copied from kjs/RegExpConstructor.h.
              * runtime/RegExpMatchesArray.h: Copied from kjs/RegExpMatchesArray.h.
              * runtime/RegExpObject.cpp: Copied from kjs/RegExpObject.cpp.
              * runtime/RegExpObject.h: Copied from kjs/RegExpObject.h.
              * runtime/RegExpPrototype.cpp: Copied from kjs/RegExpPrototype.cpp.
              * runtime/RegExpPrototype.h: Copied from kjs/RegExpPrototype.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06128761
    • mrowe@apple.com's avatar
      Revert an incorrect portion of r38034. · 47fd327a
      mrowe@apple.com authored
      * profiler/ProfilerServer.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47fd327a
    • mrowe@apple.com's avatar
      Fix the 64-bit build. · 1ed7e07d
      mrowe@apple.com authored
      Disable strict aliasing in ProfilerServer.mm as it leads to the compiler being unhappy
      with the common Obj-C idiom self = [super init];
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ed7e07d
    • cwzwarich@webkit.org's avatar
      2008-10-31 Cameron Zwarich <zwarich@apple.com> · b0b7e69d
      cwzwarich@webkit.org authored
              Not reviewed.
      
              * Scripts/do-webcore-rename:
      
              Add some renames to contemplate for the future.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0b7e69d
    • cwzwarich@webkit.org's avatar
      2008-10-31 Cameron Zwarich <zwarich@apple.com> · 87dea548
      cwzwarich@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Change a header guard to match our coding style.
      
              * kjs/InitializeThreading.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87dea548
    • ggaren@apple.com's avatar
      2008-10-30 Geoffrey Garen <ggaren@apple.com> · 4dbab809
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
              
              Fixed a small bit of https://bugs.webkit.org/show_bug.cgi?id=21962
              AST uses way too much memory
              
              Removed a word from StatementNode by nixing LabelStack and turning it
              into a compile-time data structure managed by CodeGenerator.
              
              v8 tests and SunSpider, run by Gavin, report no change.
      
              * GNUmakefile.am:
              * JavaScriptCore.order:
              * JavaScriptCore.pri:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * kjs/AllInOneFile.cpp:
              * JavaScriptCoreSources.bkl: I sure hope this builds!
              
              * VM/CodeGenerator.cpp:
              (JSC::CodeGenerator::CodeGenerator):
              (JSC::CodeGenerator::newLabelScope):
              (JSC::CodeGenerator::breakTarget):
              (JSC::CodeGenerator::continueTarget):
              * VM/CodeGenerator.h: Nixed the JumpContext system because it depended
              on a LabelStack in the AST, and it was a little cumbersome on the client
              side. Replaced with LabelScope, which tracks all break / continue
              information in the CodeGenerator, just like we track LabelIDs and other
              stacks of compile-time data.
      
              * kjs/LabelScope.h: Added.
              (JSC::LabelScope::):
              (JSC::LabelScope::LabelScope):
              (JSC::LabelScope::ref):
              (JSC::LabelScope::deref):
              (JSC::LabelScope::refCount):
              (JSC::LabelScope::breakTarget):
              (JSC::LabelScope::continueTarget):
              (JSC::LabelScope::type):
              (JSC::LabelScope::name):
              (JSC::LabelScope::scopeDepth): Simple abstraction for holding everything
              you might want to know about a break-able / continue-able scope.
      
              * kjs/LabelStack.cpp: Removed.
              * kjs/LabelStack.h: Removed.
      
              * kjs/grammar.y: No need to push labels at parse time -- we don't store
              LabelStacks in the AST anymore.
      
              * kjs/nodes.cpp:
              (JSC::DoWhileNode::emitCode):
              (JSC::WhileNode::emitCode):
              (JSC::ForNode::emitCode):
              (JSC::ForInNode::emitCode):
              (JSC::ContinueNode::emitCode):
              (JSC::BreakNode::emitCode):
              (JSC::SwitchNode::emitCode):
              (JSC::LabelNode::emitCode):
              * kjs/nodes.h:
              (JSC::StatementNode::):
              (JSC::LabelNode::): Use LabelScope where we used to use JumpContext.
              Simplified a bunch of code. Touched up label-related error messages a
              bit.
      
              * kjs/nodes2string.cpp:
              (JSC::LabelNode::streamTo): Updated for rename.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dbab809
    • cwzwarich@webkit.org's avatar
      2008-10-31 Cameron Zwarich <zwarich@apple.com> · 147f10ea
      cwzwarich@webkit.org authored
              Reviewed by Darin Adler.
      
              Bug 22005: Move StructureIDChain into its own file
              <https://bugs.webkit.org/show_bug.cgi?id=22005>
      
              * GNUmakefile.am:
              * JavaScriptCore.pri:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * JavaScriptCoreSources.bkl:
              * runtime/StructureID.cpp:
              * runtime/StructureID.h:
              * runtime/StructureIDChain.cpp: Copied from runtime/StructureID.cpp.
              * runtime/StructureIDChain.h: Copied from runtime/StructureID.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      147f10ea
    • darin@apple.com's avatar
      2008-10-31 Darin Adler <darin@apple.com> · c204a5a6
      darin@apple.com authored
              Requested by Mark Rowe.
      
              * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c204a5a6
    • sfalken@apple.com's avatar
      2008-10-31 Steve Falkenburg <sfalken@apple.com> · dabab3e8
      sfalken@apple.com authored
              Build fix.
      
              * JavaScriptCore.vcproj/jsc/jsc.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dabab3e8
    • beidson@apple.com's avatar
      Expand that name! · fa290c84
      beidson@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa290c84
    • beidson@apple.com's avatar
      2008-10-31 Brady Eidson <beidson@apple.com> · eecc8283
      beidson@apple.com authored
              Reviewed by Darin
      
              [WebHistory setLastVisitedTimeInterval:forItem] was internal to WebHistory.mm and 
              completely unused.  Nuke it!
      
              * History/WebHistory.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eecc8283
    • sfalken@apple.com's avatar
      2008-10-31 Steve Falkenburg <sfalken@apple.com> · bb48a6e6
      sfalken@apple.com authored
              Build fix.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb48a6e6
    • timothy@apple.com's avatar
      Emit the WillExecuteStatement debugger hook before the for loop body when the... · fae1018f
      timothy@apple.com authored
      Emit the WillExecuteStatement debugger hook before the for loop body when the statement node for the body isn't a block. This allows breakpoints on those statements in the Web Inspector.
      
      JavaScriptCore:
      
      2008-10-31  Timothy Hatcher  <timothy@apple.com>
      
              Emit the WillExecuteStatement debugger hook before the for loop body
              when the statement node for the body isn't a block. This allows
              breakpoints on those statements in the Web Inspector.
      
              https://bugs.webkit.org/show_bug.cgi?id=22004
      
              Reviewed by Darin Adler.
      
              * kjs/nodes.cpp:
              (JSC::ForNode::emitCode): Emit the WillExecuteStatement
              debugger hook before the statement node if isn't a block.
              Also emit the WillExecuteStatement debugger hook for the
              loop as the first op-code.
              (JSC::ForInNode::emitCode): Ditto.
      
      WebCore:
      
      2008-10-31  Timothy Hatcher  <timothy@apple.com>
      
              Add manual tests that check breakpoints on a blockless body of "for" loops.
      
              https://bugs.webkit.org/show_bug.cgi?id=22004
      
              Reviewed by Darin Adler.
      
              * manual-tests/inspector/debugger-pause-on-for-in-statements.html: Added.
              * manual-tests/inspector/debugger-pause-on-for-statements.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fae1018f
    • darin@apple.com's avatar
      2008-10-31 Darin Adler <darin@apple.com> · 61934917
      darin@apple.com authored
              - fix build
      
              * platform/win/WCDataObject.cpp: Added missing include of "config.h".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61934917
    • ddkilzer@apple.com's avatar
      Bug 21997: prepare-ChangeLog should filter out ChangeLog files · bc07ef4b
      ddkilzer@apple.com authored
              <https://bugs.webkit.org/show_bug.cgi?id=21997>
      
              Reviewed by Darin Adler.
      
              * Scripts/prepare-ChangeLog:
              (generateFileList): Don't add ChangeLog files to %{$functionLists}.
              This prevents them from showing up in the new ChangeLog entry.  They
              were already excluded from @{$changedFiles}.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc07ef4b
    • darin@apple.com's avatar
      2008-10-31 Darin Adler <darin@apple.com> · 03e46324
      darin@apple.com authored
              Reviewed by Dan Bernstein.
      
              - fix storage leak seen on buildbot
      
              Some other cleanup too. The storage leak was caused by the fact
              that HashTraits<CallIdentifier>::needsDestruction was false, so
              the call identifier objects didn't get deleted.
      
              * profiler/CallIdentifier.h:
              
              Added a default constructor to create empty call identifiers.
      
              Changed the normal constructor to use const UString&
              to avoid extra copying and reference count thrash.
              
              Removed the explicit copy constructor definition, since it's what
              the compiler will automatically generate. (Rule of thumb: Either
              you need both a custom copy constructor and a custom assignment
              operator, or neither.)
      
              Moved the CallIdentifier hash function out of the WTF namespace;
              there's no reason to put it there.
      
              Changed the CallIdentifier hash function to be a struct rather than
              a specialization of the IntHash struct template. Having it be
              a specialization made no sense, since CallIdentifier is not an integer,
              and did no good.
      
              Removed explicit definition of emptyValueIsZero in the hash traits,
              since inheriting from GenericHashTraits already makes that false.
      
              Removed explicit definition of emptyValue, instead relying on the
              default constructor and GenericHashTraits.
      
              Removed explicit definition of needsDestruction, because we want it
              to have its default value: true, not false. This fixes the leak!
      
              Changed constructDeletedValue and isDeletedValue to use a line number
              of numeric_limits<unsigned>::max() to indicate a value is deleted.
              Previously this used empty strings for the empty value and null strings
              for the deleted value, but it's more efficient to use null for both.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03e46324
    • darin@apple.com's avatar
      2008-10-31 Darin Adler <darin@apple.com> · 89b67884
      darin@apple.com authored
              - try to fix build
      
              * WebView.cpp:
              (WebView::setCacheModel): Roll out the part of my last change
              that involved no longer using wkCopyFoundationCacheDirectory.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89b67884
    • cfleizach@apple.com's avatar
      Bug 22002: AX: scroll bars show should not appear in AX hierarchy when... · 2c534eaf
      cfleizach@apple.com authored
      Bug 22002: AX: scroll bars show should not appear in AX hierarchy when WebFrameView does not allow scrolling
      https://bugs.webkit.org/show_bug.cgi?id=22002
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c534eaf
    • timothy@apple.com's avatar
      Fixes console warnings about not having an autorelease pool. · dafe8e51
      timothy@apple.com authored
              Also fixes the build for Snow Leopard, by including individual
              Foundation headers instead of Foundation.h.
      
              https://bugs.webkit.org/show_bug.cgi?id=21995
      
              Reviewed by Oliver Hunt.
      
              * profiler/ProfilerServer.mm:
              (-[ProfilerServer init]): Create a NSAutoreleasePool and drain it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dafe8e51
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · be35d511
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=21970
              Make MessagePort event dispatch work in workers
      
              * bindings/js/JSDOMGlobalObject.cpp:
              (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
              (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
              (WebCore::JSDOMGlobalObject::findJSEventListener):
              (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
              (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
              (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
              (WebCore::JSDOMGlobalObject::jsEventListeners):
              (WebCore::JSDOMGlobalObject::jsInlineEventListeners):
              (WebCore::JSDOMGlobalObject::jsUnprotectedEventListeners):
              (WebCore::JSDOMGlobalObject::jsUnprotectedInlineEventListeners):
              (WebCore::JSDOMGlobalObject::setCurrentEvent):
              (WebCore::JSDOMGlobalObject::currentEvent):
              (WebCore::toJSDOMGlobalObject):
              * bindings/js/JSDOMGlobalObject.h:
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
              (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
              (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
              * bindings/js/JSDOMWindowBase.h:
              Moved event listener tracking from JSDOMWindow to JSDOMGlobalObject.
      
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSAbstractEventListener::handleEvent):
              (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
              (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
              (WebCore::JSUnprotectedEventListener::globalObject):
              (WebCore::JSUnprotectedEventListener::clearGlobalObject):
              (WebCore::JSEventListener::JSEventListener):
              (WebCore::JSEventListener::~JSEventListener):
              (WebCore::JSEventListener::globalObject):
              (WebCore::JSEventListener::clearGlobalObject):
              (WebCore::JSLazyEventListener::JSLazyEventListener):
              (WebCore::JSLazyEventListener::parseCode):
              * bindings/js/JSEventListener.h:
              (WebCore::JSUnprotectedEventListener::create):
              (WebCore::JSEventListener::create):
              (WebCore::JSLazyEventListener::create):
              Changed to use JSDOMGlobalObject and ScriptExecutionContext.
      
              * bindings/js/JSMessagePortCustom.cpp:
              (WebCore::JSMessagePort::startConversation):
              (WebCore::JSMessagePort::addEventListener):
              (WebCore::JSMessagePort::removeEventListener):
              (WebCore::JSMessagePort::setOnmessage):
              (WebCore::JSMessagePort::setOnclose):
              Updated bindings to work with JSDOMGlobalObject. Next step is to make code generator emit
              such code, and stop using a custom implementation for JSMessagePort inline event handler
              getters and setters.
      
              * dom/Document.cpp:
              (WebCore::Document::virtualURL):
              * dom/Document.h:
              * dom/ScriptExecutionContext.h:
              Expose url() method on ScriptExecutionContext (necessary for compiling scripts in
              JSLazyEventListener).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be35d511
    • cwzwarich@webkit.org's avatar
      2008-10-31 Cameron Zwarich <zwarich@apple.com> · efc1b115
      cwzwarich@webkit.org authored
              Not reviewed.
      
              Speculative wxWindows build fix.
      
              * webcore-base.bkl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efc1b115
    • cwzwarich@webkit.org's avatar
      2008-10-31 Cameron Zwarich <zwarich@apple.com> · 560aae89
      cwzwarich@webkit.org authored
              Not reviewed.
      
              Speculative wxWindows build fix.
      
              * JavaScriptCoreSources.bkl:
              * jscore.bkl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      560aae89