1. 10 Dec, 2012 40 commits
    • fpizlo@apple.com's avatar
      JSC profiling and debug dump code should use inferred names when possible · 1a6da216
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104519
      
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore: 
      
      This does as advertised: the profiler now knows the inferred name of all code blocks,
      and all uses of CodeBlock::dump() dump it along with the hash.
              
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::inferredName):
      (JSC::CodeBlock::dumpAssumingJITType):
      * bytecode/CodeBlock.h:
      * profiler/ProfilerBytecodes.cpp:
      (JSC::Profiler::Bytecodes::Bytecodes):
      (JSC::Profiler::Bytecodes::toJS):
      * profiler/ProfilerBytecodes.h:
      (JSC::Profiler::Bytecodes::inferredName):
      * profiler/ProfilerDatabase.cpp:
      (JSC::Profiler::Database::addBytecodes):
      (JSC::Profiler::Database::ensureBytecodesFor):
      * profiler/ProfilerDatabase.h:
      * runtime/CommonIdentifiers.h:
      
      Tools: 
      
      The format I'm using for referring to a code block is now name#hash. For example,
      v8-crypto has something called bnpSquareTo#B5QFbU. The profiler allows you to use
      either the hash, the inferred name, or the combined hash and full name when referring
      to blocks.
      
      * Scripts/display-profiler-output:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a6da216
    • cfleizach@apple.com's avatar
      AX: Crash in NSAccessibilityUnignoredDescendant · c7039b18
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104468
      
      Reviewed by Anders Carlsson.
      
      This crash occurred because AccessibilityScrollView stopped retaining it's ScrollView pointer.
      
      Unfortunately, there was still a case that didn't correctly clear that variable.
      
      That case was when a Frame had a new FrameView associated with it. The old FrameView didn't inform the
      accessibility object cache that it should be removed. As a result, when the FrameView deallocated and
      did try to remove, it used the wrong AXObjectCache because it was no longer correctly hooked into the
      document tree.
      
      No new tests. Existing tests will stop crashing.
      
      * page/Frame.cpp:
      (WebCore::Frame::setView): change the name of the method that tells the FrameView to detach
      * page/FrameView.cpp:
      (WebCore::FrameView::~FrameView):
      (WebCore::FrameView::removeFromAXObjectCache): add a method that can be called in multiple places
      (WebCore::FrameView::isFrameView):
      (WebCore::FrameView::prepareForDetach): detaches scrollbars and accessibility
      * page/FrameView.h:
      (FrameView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7039b18
    • pilgrim@chromium.org's avatar
      [Chromium] Move getPluginsList out of PlatformSupport · f2122884
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96507
      
      Reviewed by Darin Fisher.
      
      Part of a refactoring series. See tracking bug 82948.
      
      Source/Platform:
      
      * Platform.gypi:
      * chromium/public/Platform.h:
      (WebKit):
      (Platform):
      (WebKit::Platform::getPluginList):
      * chromium/public/WebPluginListBuilder.h: Added.
      (WebKit):
      (WebPluginListBuilder):
      
      Source/WebCore:
      
      * WebCore.gypi:
      * platform/chromium/PlatformSupport.h:
      (PlatformSupport):
      * plugins/chromium/PluginDataChromium.cpp:
      (WebCore::PluginCache::plugins):
      * plugins/chromium/PluginListBuilder.cpp: Added.
      (WebKit):
      (WebKit::PluginListBuilder::addPlugin):
      (WebKit::PluginListBuilder::addMediaTypeToLastPlugin):
      (WebKit::PluginListBuilder::addFileExtensionToLastMediaType):
      * plugins/chromium/PluginListBuilder.h: Added.
      (WebKit):
      (PluginListBuilder):
      (WebKit::PluginListBuilder::PluginListBuilder):
      
      Source/WebKit/chromium:
      
      * WebKit.gyp:
      * public/WebPluginListBuilder.h:
      * public/platform/WebKitPlatformSupport.h:
      (WebKit):
      (WebKit::WebKitPlatformSupport::idbFactory):
      * src/PlatformSupport.cpp:
      (WebCore::PlatformSupport::idbFactory):
      * src/WebPluginListBuilderImpl.cpp: Removed.
      * src/WebPluginListBuilderImpl.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2122884
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · e2c8aeb7
      zandobersek@gmail.com authored
      Fixing most of the expectations added in r137153, the baselines are missing so the expectations
      are changed according to that. The a11y gurus will have a look at them and determine what the
      baselines should look like and whether the tests can be fixed.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2c8aeb7
    • fpizlo@apple.com's avatar
      Profiler should say things about OSR exits · d2deec81
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104497
      
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore: 
      
      This adds support for profiling OSR exits. For each exit that is taken, the profiler
      records the machine code address that the exit occurred on, the exit kind, the origin
      stack, and the number of times that it happened.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * assembler/AbstractMacroAssembler.h:
      (Jump):
      (JSC::AbstractMacroAssembler::Jump::label):
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::saveCompilation):
      (CodeBlock):
      (JSC::CodeBlock::compilation):
      (DFGData):
      * bytecode/DFGExitProfile.h:
      (DFG):
      * bytecode/ExitKind.cpp: Added.
      (JSC):
      (JSC::exitKindToString):
      (JSC::exitKindIsCountable):
      (WTF):
      (WTF::printInternal):
      * bytecode/ExitKind.h: Added.
      (JSC):
      (WTF):
      * dfg/DFGGraph.h:
      (Graph):
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::linkOSRExits):
      (JSC::DFG::JITCompiler::link):
      (JSC::DFG::JITCompiler::compile):
      (JSC::DFG::JITCompiler::compileFunction):
      * dfg/DFGJITCompiler.h:
      (JITCompiler):
      * dfg/DFGOSRExitCompiler.cpp:
      * jit/JIT.cpp:
      (JSC::JIT::JIT):
      (JSC::JIT::privateCompile):
      * jit/JIT.h:
      (JIT):
      * jit/JumpReplacementWatchpoint.h:
      (JSC::JumpReplacementWatchpoint::sourceLabel):
      (JumpReplacementWatchpoint):
      * profiler/ProfilerCompilation.cpp:
      (JSC::Profiler::Compilation::addOSRExitSite):
      (Profiler):
      (JSC::Profiler::Compilation::addOSRExit):
      (JSC::Profiler::Compilation::toJS):
      * profiler/ProfilerCompilation.h:
      (Compilation):
      * profiler/ProfilerDatabase.cpp:
      (JSC::Profiler::Database::newCompilation):
      * profiler/ProfilerDatabase.h:
      (Database):
      * profiler/ProfilerOSRExit.cpp: Added.
      (Profiler):
      (JSC::Profiler::OSRExit::OSRExit):
      (JSC::Profiler::OSRExit::~OSRExit):
      (JSC::Profiler::OSRExit::toJS):
      * profiler/ProfilerOSRExit.h: Added.
      (Profiler):
      (OSRExit):
      (JSC::Profiler::OSRExit::id):
      (JSC::Profiler::OSRExit::origin):
      (JSC::Profiler::OSRExit::exitKind):
      (JSC::Profiler::OSRExit::isWatchpoint):
      (JSC::Profiler::OSRExit::counterAddress):
      (JSC::Profiler::OSRExit::count):
      * profiler/ProfilerOSRExitSite.cpp: Added.
      (Profiler):
      (JSC::Profiler::OSRExitSite::toJS):
      * profiler/ProfilerOSRExitSite.h: Added.
      (Profiler):
      (OSRExitSite):
      (JSC::Profiler::OSRExitSite::OSRExitSite):
      (JSC::Profiler::OSRExitSite::codeAddress):
      * runtime/CommonIdentifiers.h:
      
      Tools: 
      
      Adds support for displaying OSR exit information for full summary (just displays the
      counts and the number of recompilations), bytecode display (says which bytecodes
      exited), and DFG display (annotates disassembly with taken OSR exits and their
      counts).
      
      * Scripts/display-profiler-output:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2deec81
    • adamk@chromium.org's avatar
      inspector/styles/styles-computed-trace still times out after r137156. · 28215dbd
      adamk@chromium.org authored
      Unreviewed gardening.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28215dbd
    • carlosgc@webkit.org's avatar
      [GTK] Build GObject DOM bindings as a separate library · 86676b8a
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104527
      
      Reviewed by Xan Lopez.
      
      Source/WebCore:
      
      * bindings/gobject/GNUmakefile.am: Add libWebCoreDOM library.
      * bindings/gobject/WebKitDOMBinding.h: Define private macros.
      * bindings/gobject/WebKitDOMCustom.h: Don't include webkit/webkitdefines.h.
      * bindings/gobject/WebKitDOMEventTarget.h: Ditto.
      * bindings/gobject/WebKitDOMObject.h: Ditto.
      * bindings/scripts/CodeGeneratorGObject.pm:
      (Generate): Don't include webkitglobalsprivate.h.
      (WriteData): Don't include webkit/webkitdefines.h.
      * bindings/scripts/gobject-generate-headers.pl: Define WEBKIT_API
      macro in webkitdomdefines.h.
      * bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
      * bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
      * bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
      * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
      * bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
      * bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
      * bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
      * bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestException.h:
      * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
      * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
      * bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
      * bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestNode.h:
      * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
      * bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
      * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
      
      Source/WebKit/gtk:
      
      * GNUmakefile.am: Link to libWebCoreDOM.la.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86676b8a
    • rniwa@webkit.org's avatar
      Removed failing test expectations for GTK+ port after r137107. · 1b70b8fe
      rniwa@webkit.org authored
      * platform/gtk/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b70b8fe
    • adamk@chromium.org's avatar
      In InbandTextTrackPrivate, return emptyAtoms instead of emptyString() by default. · 023a48ce
      adamk@chromium.org authored
      Unreviewed build fix.
      
      * platform/graphics/InbandTextTrackPrivate.h:
      (WebCore::InbandTextTrackPrivate::label):
      (WebCore::InbandTextTrackPrivate::language):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      023a48ce
    • adamk@chromium.org's avatar
      Chromium test expectations update after r137152. · 445c9def
      adamk@chromium.org authored
      Unreviewed gardening.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      445c9def
    • loislo@chromium.org's avatar
      Web Inspector: Native Memory Instrumentation: instrument RenderBox descendants. · 9c8fa0f9
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104026
      
      Reviewed by Eric Seidel.
      
      Plain vanilla instrumentation for RenderBox descendants.
      
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::reportMemoryUsage):
      (WebCore):
      (WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):
      * rendering/RenderFrameSet.h:
      (RenderFrameSet):
      (GridAxis):
      * rendering/RenderListMarker.cpp:
      (WebCore::RenderListMarker::reportMemoryUsage):
      (WebCore):
      * rendering/RenderListMarker.h:
      (RenderListMarker):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::reportMemoryUsage):
      (WebCore):
      * rendering/RenderReplaced.h:
      (RenderReplaced):
      * rendering/RenderTableCol.cpp:
      (WebCore::RenderTableCol::reportMemoryUsage):
      (WebCore):
      * rendering/RenderTableCol.h:
      (RenderTableCol):
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::reportMemoryUsage):
      (WebCore):
      * rendering/RenderTableRow.h:
      (RenderTableRow):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::reportMemoryUsage):
      (WebCore):
      (WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
      (WebCore::RenderTableSection::CellStruct::reportMemoryUsage):
      * rendering/RenderTableSection.h:
      (CellStruct):
      (RowStruct):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c8fa0f9
    • commit-queue@webkit.org's avatar
      AX: wrong Enabled states on a ListBox · 0257f0fd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104483
      
      Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-12-10
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Test: accessibility/listbox-enabled-states.html
      
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::isEnabled): taking into
      account the DISABLED attribute and the aria-disabled attribute to
      decide if the item is enabled or not.
      
      LayoutTests:
      
      * accessibility/listbox-enabled-states-expected.txt: Added.
      * accessibility/listbox-enabled-states.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0257f0fd
    • adamk@chromium.org's avatar
      cr-win build fix after r137161. · 2d2b2013
      adamk@chromium.org authored
      Unreviewed.
      
      * platform/graphics/MediaPlayer.h: Replace forward-decl of
      InbandTextTrackPrivate with #include as the definition is required.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d2b2013
    • alexis@webkit.org's avatar
      [CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag. · 67ab9926
      alexis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104539
      
      Reviewed by Antonio Gomes.
      
      .:
      
      As discussed on webkit-dev it is not needed to keep this feature flag
      as support for <position> type is a small feature that is already
      implemented by three other UAs. It was useful while landing this
      feature as partial bits were landed one after one.
      
      * Source/cmake/OptionsEfl.cmake:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      * configure.ac:
      
      Source/JavaScriptCore:
      
      As discussed on webkit-dev it is not needed to keep this feature flag
      as support for <position> type is a small feature that is already
      implemented by three other UAs. It was useful while landing this
      feature as partial bits were landed one after one.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      As discussed on webkit-dev it is not needed to keep this feature flag
      as support for <position> type is a small feature that is already
      implemented by three other UAs. It was useful while landing this
      feature as partial bits were landed one after one.
      
      No new tests : the feature is covered by various tests and it is already enabled in many ports.
      
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * GNUmakefile.features.am:
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFillPosition):
      (WebCore::CSSParser::parseFillProperty):
      * css/CSSParser.h:
      * css/CSSToStyleMap.cpp:
      (WebCore::CSSToStyleMap::mapFillXPosition):
      (WebCore::CSSToStyleMap::mapFillYPosition):
      * rendering/style/FillLayer.cpp:
      (SameSizeAsFillLayer):
      (WebCore::FillLayer::FillLayer):
      (WebCore::FillLayer::operator=):
      (WebCore::FillLayer::operator==):
      (WebCore::FillLayer::fillUnsetProperties):
      * rendering/style/FillLayer.h:
      (WebCore::FillLayer::backgroundXOrigin):
      (WebCore::FillLayer::backgroundYOrigin):
      (WebCore::FillLayer::isBackgroundOriginSet):
      (WebCore::FillLayer::clearXPosition):
      (WebCore::FillLayer::clearYPosition):
      (FillLayer):
      
      Source/WebKit/chromium:
      
      As discussed on webkit-dev it is not needed to keep this feature flag
      as support for <position> type is a small feature that is already
      implemented by three other UAs. It was useful while landing this
      feature as partial bits were landed one after one.
      
      * features.gypi:
      
      Source/WebKit/mac:
      
      As discussed on webkit-dev it is not needed to keep this feature flag
      as support for <position> type is a small feature that is already
      implemented by three other UAs. It was useful while landing this
      feature as partial bits were landed one after one.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      As discussed on webkit-dev it is not needed to keep this feature flag
      as support for <position> type is a small feature that is already
      implemented by three other UAs. It was useful while landing this
      feature as partial bits were landed one after one.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Tools:
      
      As discussed on webkit-dev it is not needed to keep this feature flag
      as support for <position> type is a small feature that is already
      implemented by three other UAs. It was useful while landing this
      feature as partial bits were landed one after one.
      
      * Scripts/webkitperl/FeatureList.pm:
      * qmake/mkspecs/features/features.pri:
      
      WebKitLibraries:
      
      As discussed on webkit-dev it is not needed to keep this feature flag
      as support for <position> type is a small feature that is already
      implemented by three other UAs. It was useful while landing this
      feature as partial bits were landed one after one.
      
      * win/tools/vsprops/FeatureDefines.vsprops:
      * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      LayoutTests:
      
      Unskip the related CSS3 <position> type tests for background-position
      as now the feature is enabled by default.
      
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67ab9926
    • adamk@chromium.org's avatar
      Remove expectation of previously failing test. · 3ae4c943
      adamk@chromium.org authored
      It passes after r137152.
      
      Unreviewed gardening.
      
      * platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ae4c943
    • commit-queue@webkit.org's avatar
      WebKitWebViewBase produces a warning if compiled with gcc · 8588e191
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104561
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2012-12-10
      Reviewed by Carlos Garcia Campos.
      
      * UIProcess/API/gtk/WebKitWebViewBase.h:
      since this file can be included from C code, use void to
      explicitly specify that webkit_web_view_base_get_type() doesn't
      have parameters. Otherwise we get "warning: function declaration
      isn't a prototype" with -Wstrict-prototypes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8588e191
    • nghanavatian@rim.com's avatar
      [BlackBerry] Fix warning for comparison between signed and unsigned · 96c6ef32
      nghanavatian@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104563
      
      Reviewed by Rob Buis.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96c6ef32
    • jocelyn.turcotte@digia.com's avatar
      [Qt] Remove the support for building a debug WebKit with a release Qt · a0636a74
      jocelyn.turcotte@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104560
      
      Reviewed by Tor Arne Vestbø.
      
      This creates issues with non-framework builds of Qt (necessary for debug-only
      builds) since a Qt5 prefix is now added to the base target name.
      
      * Source/api.pri:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0636a74
    • eric.carlson@apple.com's avatar
      Add support for in-band text tracks to Mac port · 134ccfc9
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=103663
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Test: media/track/track-in-band.html
      
      * GNUmakefile.list.am: Move InbandTextTrackPrivate.h to platform/graphics. Add InbandTextTrackPrivateClient.h.
      * Target.pri: Ditto.
      * WebCore.gypi: Ditto.
      
      * WebCore.xcodeproj/project.pbxproj: Add new files.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::setReadyState): No need to call processInbandTextTracks, in-band tracks
          are now registered by the media engine as they are discovered.
      (WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): New, called by the media player when a new
          in-band track is found.
      (WebCore::HTMLMediaElement::mediaPlayerDidRemoveTrack): New, called by the media player when an
          in-band track goes away.
      * html/HTMLMediaElement.h:
      
      * html/track/InbandTextTrack.cpp:
      (WebCore::InbandTextTrack::InbandTextTrack): Use m_private instead of tracksPrivate because
          it is zeroed during assignment.
      
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::addTextTrack): New MediaPlayerClient method to allow MediaPlayerPrivate subclasses
          to add a new in-band track.
      (WebCore::MediaPlayer::removeTextTrack): New MediaPlayerClient method to allow MediaPlayerPrivate subclasses
          to remove a new in-band track.
      * platform/graphics/MediaPlayer.h:
      * platform/graphics/MediaPlayerPrivate.h:
      
      * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Added.
      (WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF):
      (WebCore::InbandTextTrackPrivateAVF::~InbandTextTrackPrivateAVF):
      (WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Convert an attribute string into WebVTT 
          cue setting and content strings.
      (WebCore::InbandTextTrackPrivateAVF::processCue): Process a new cue.
      (WebCore::InbandTextTrackPrivateAVF::disconnect): Clear member variables.
      (WebCore::InbandTextTrackPrivateAVF::resetCueValues): Reset cue values to defaults.
      (WebCore::InbandTextTrackPrivateAVF::setMode): Set track mode and call player's trackModeChanged.
      * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Added.
      
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Initialize 
          m_inbandTrackConfigurationPending.
      (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
      (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Flush the currently accumulating
          cue so it doesn't get the wrong duration.
      (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Handle InbandTracksNeedConfiguration.
      (WebCore::MediaPlayerPrivateAVFoundation::flushCurrentCue): New, pass the current cue up to the client.
      (WebCore::MediaPlayerPrivateAVFoundation::configureInbandTracks): Configure in-band tracks.
      (WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Schedule a call to configureInbandTracks.
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
      
      * platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h: Added.
      * platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm: Added.
      (WebCore::InbandTextTrackPrivateAVFObjC::InbandTextTrackPrivateAVFObjC):
      (WebCore::InbandTextTrackPrivateAVFObjC::disconnect):
      (WebCore::InbandTextTrackPrivateAVFObjC::kind): Return track kind.
      (WebCore::InbandTextTrackPrivateAVFObjC::label): Return track label.
      (WebCore::InbandTextTrackPrivateAVFObjC::language): Return track language.
      (WebCore::InbandTextTrackPrivateAVFObjC::isDefault): 
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      (MediaPlayerPrivateAVFoundationObjC):
      (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItem):
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize m_currentTrack.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Clear m_legibleOutput.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Create and initialize m_legibleOutput.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Called when the player item's
          "tracks" changes, add and remove in-band text tracks as necessary.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::processCue): Pass an attributed string to the current 
          track to be processed.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Tell AVFoundation to select an in-band track.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::currentTrack): Return the current track.
      (-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]): Legible
          output delegate.
      
      Source/WTF: 
      
      * wtf/Platform.h: Define HAVE_AVFOUNDATION_TEXT_TRACK_SUPPORT.
      
      LayoutTests: 
      
      Test for initial support for in-band text tracks. New test skipped on all ports that don't 
      have support in the media engine.
      
      * media/content/counting-subtitled.m4v: Added.
      * media/track/track-in-band-expected.txt: Added.
      * media/track/track-in-band.html: Added.
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      134ccfc9
    • pfeldman@chromium.org's avatar
      Web Inspector: fix front-end compilation warnings · 407048b1
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104557
      
      Reviewed by Alexander Pavlov.
      
      Corresponding annotations added.
      
      * inspector/Inspector.json:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::highlightNode):
      * inspector/InspectorDOMAgent.h:
      (InspectorDOMAgent):
      * inspector/front-end/CSSStyleModel.js:
      (WebInspector.CSSStyleDeclaration.prototype.):
      (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
      * inspector/front-end/ConsoleMessage.js:
      (WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):
      * inspector/front-end/DOMAgent.js:
      (WebInspector.DOMAgent.prototype.highlightDOMNode):
      * inspector/front-end/DOMPresentationUtils.js:
      (WebInspector.DOMPresentationUtils.linkifyNodeReference):
      * inspector/front-end/ObjectPropertiesSection.js:
      (WebInspector.ObjectPropertyTreeElement.prototype.update):
      * inspector/front-end/Toolbar.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      407048b1
    • zeno.albisser@digia.com's avatar
      [Qt] MediaPlayerQTKit broken after switching QPainter to raster engine. · b7d3b252
      zeno.albisser@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104550
      
      With Qt5 QPainter changed to using the raster engine.
      Therefore we no longer have an NSGraphicsContext that we can
      use for drawing video frames.
      With this patch we are rendering the video frame into an image buffer
      and then paint it manually using QPainter.
      
      Reviewed by Simon Hausmann.
      
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore):
      (WebCore::swapBgrToRgb):
          Swap the color format from BGR to RGB,
          since BGR is not supported by QImage.
      (WebCore::MediaPlayerPrivateQTKit::paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7d3b252
    • commit-queue@webkit.org's avatar
      [WinCairo] Link fix in InspectorController.cpp · b0b765d7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104556
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2012-12-10
      Reviewed by Pavel Feldman.
      
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController): Added missing #if check.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0b765d7
    • mkwst@chromium.org's avatar
      [chromium] Add 'WebKit/chromium/win8' to .gitignore · 36e06aec
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104534
      
      Reviewed by Jochen Eisinger.
      
      I've now added it via 'git add' once, and via 'git commit -a' twice.
      Let's make that more difficult, shall we?
      
      * .gitignore:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36e06aec
    • loislo@chromium.org's avatar
      Unreviewed: Web Inspector: update test expectation for inspector/styles/styles-computed-trace.html. · 61ad68ee
      loislo@chromium.org authored
      it is slow in debug version. ~20 sec on linux.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61ad68ee
    • mrobinson@webkit.org's avatar
      Build fix. · 07a45a1a
      mrobinson@webkit.org authored
      Add a patchfile missing from my previous commit.
      
      * gtk/patches/harfbuzz-icu-detection-fix.patch: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07a45a1a
    • pfeldman@chromium.org's avatar
      Web Inspector: remove the Overrides / Settings context menu from gear icon · a3bc53d3
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104546
      
      Reviewed by Alexander Pavlov.
      
      It sounds like too many people don't like the way it works. Bringing things back: overrides will be a tab in settings for now.
      Moving present behavior to under experiment.
      
      * inspector/front-end/OverridesView.js:
      (WebInspector.OverridesView):
      * inspector/front-end/Settings.js:
      (WebInspector.ExperimentsSettings):
      * inspector/front-end/SettingsScreen.js:
      (WebInspector.OverridesSettingsTab):
      (WebInspector.SettingsController):
      (WebInspector.SettingsController.prototype.get statusBarItem):
      (WebInspector.SettingsController.prototype._mouseDown.showSettings):
      (WebInspector.SettingsController.prototype._mouseDown):
      (WebInspector.SettingsController.prototype._mouseUp):
      * inspector/front-end/helpScreen.css:
      (#settings-screen .tabbed-pane-header):
      (#settings-screen .tabbed-pane-header-tabs):
      (#settings-screen .tabbed-pane-header-tab):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3bc53d3
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · a8e91f3c
      zandobersek@gmail.com authored
      Unskipping 8 failing accessibility tests, adding expected failures for them.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8e91f3c
    • tkent@chromium.org's avatar
      Visual order of empty value placeholder in INPUT_MULTIPLE_FIELDS_UI is wrong in RTL · 4b52f605
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104438
      
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      No new tests. This updates datetimelocal-appearance-l10n.html for he-il
      and ar-eg locales.
      
      * html/shadow/DateTimeNumericFieldElement.cpp:
      (WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
      We should not append Right-to-left-mark to each of placeholder
      strings. It makes numeric field separators such as ':' and '/' RTL, and
      makes a wrong visual order. We use unicode-bidi:bidi-override and
      direction:ltr instead. It means we force LTR only to this element
      * html/shadow/DateTimeNumericFieldElement.h:
      Makes m_placeholder const again.
      * html/shadow/DateTimeEditElement.cpp:
      (WebCore::DateTimeEditBuilder::visitLiteral):
      Explicitly set right-to-left-mark before S, WS, ON types according to
      Unicod Bidirectional Algorithm Table 4 [1]. This is needed because we
      don't have context like "This literal follows European/Arabic numbers"
      in a case of showing placeholders.
      [1] http://www.unicode.org/reports/tr9/#Bidirectional_Character_Types
      
      LayoutTests:
      
      * platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
      * platform/chromium/TestExpectations:
      Update bug numbers and add time-multiple-fields-localization.html.
      * fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
      Adjust test scenario for the new behavior.
      * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
      * fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html:
      * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b52f605
    • commit-queue@webkit.org's avatar
      REGRESSION(137127): Causes assertion failures on the debug bots · c70ea0f8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104549
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2012-12-10
      Reviewed by Alejandro G. Castro.
      
      After handling the new TextOutput message we should return the method
      handling messages received.
      
      * WebKitTestRunner/TestInvocation.cpp:
      (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a missing early return.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c70ea0f8
    • kov@webkit.org's avatar
      [Soup] utilize multipart/x-mixed-replace support recently added to libsoup · deb6f0ca
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94515
      
      Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-12-09
      Reviewed by Martin Robinson.
      
      .:
      
      * configure.ac: require soup 2.40.0, which adds the new support.
      
      Source/WebCore:
      
      The multipart/x-mixed-replace content type is often used for providing
      "push" server support, with each part in the multipart response
      replacing the previous one in the rendering. Soup recently acquired
      support for multipart/x-mixed replace, which this change utilizes.
      
      Covered by existing multipart/x-mixed-replace tests.
      
      * platform/network/ResourceHandleInternal.h:
      (ResourceHandleInternal): add new member to this class, the multipart input stream
      * platform/network/soup/ResourceHandleSoup.cpp:
      (WebCore::cleanupSoupRequestOperation): also clear the multipart input stream on
      cleanup
      (WebCore::nextPartCallback): callback that handles reporting the new response delivered
      with the new part, if any; uses the factored out updateFromSoupMessageHeaders method
      (WebCore::sendRequestCallback): handle multipart/x-mixed-replace responses by
      requesting the next part
      (WebCore::readCallback): when reading has finished, request the next part when
      handling a multipart/x-mixed-replace response
      * platform/network/soup/ResourceResponse.h:
      (ResourceResponse): add declaration for new method
      * platform/network/soup/ResourceResponseSoup.cpp:
      (WebCore::ResourceResponse::updateFromSoupMessage): call new updateFromSoupMessageHeaders
      method, instead of dealing with the message headers directly
      (WebCore::ResourceResponse::updateFromSoupMessageHeaders): new method, factored out from
      updateFromSoupMessage, so this same code can be reused for updating responses for
      multipart/x-mixed-replace responses parts
      
      Tools:
      
      This change requires a very recent libsoup, so update our jhbuild
      requirements.
      
      * gtk/jhbuild.modules: depend on soup version that adds the multipart/x-mixed-replace
      support
      * efl/jhbuild.modules: ditto
      
      LayoutTests:
      
      * platform/efl/TestExpectations: adjust expectations for tests that now pass.
      * platform/gtk/TestExpectations: ditto.
      * platform/gtk-wk2/TestExpectations: add missing multipart tests expectations.
      * platform/gtk/http/tests/multipart/invalid-image-data-expected.png: new baseline
      * platform/gtk/http/tests/multipart/invalid-image-data-expected.txt: ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      deb6f0ca
    • commit-queue@webkit.org's avatar
      [WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from... · be355dea
      commit-queue@webkit.org authored
      [WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale
      https://bugs.webkit.org/show_bug.cgi?id=104544
      
      Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-12-10
      Reviewed by Kenneth Rohde Christiansen.
      
      Removed 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale()
      as it was not used by anyone.
      
      * UIProcess/PageViewportController.cpp:
      (WebKit::PageViewportController::didRenderFrame):
      * UIProcess/PageViewportControllerClient.h:
      (PageViewportControllerClient):
      * UIProcess/efl/PageViewportControllerClientEfl.cpp:
      (WebKit::PageViewportControllerClientEfl::setContentsScale):
      * UIProcess/efl/PageViewportControllerClientEfl.h:
      (PageViewportControllerClientEfl):
      * UIProcess/qt/PageViewportControllerClientQt.cpp:
      (WebKit::PageViewportControllerClientQt::setContentsScale):
      * UIProcess/qt/PageViewportControllerClientQt.h:
      (PageViewportControllerClientQt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be355dea
    • commit-queue@webkit.org's avatar
      Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner · ea31e6b3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103886
      
      Patch by Zoltan Nyul <zoltan.nyul@intel.com> on 2012-12-10
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Export symbol for WebCore::Page::setViewMode on Mac.
      
      No new tests, no behavior change for layout tests.
      
      * WebCore.exp.in:
      
      Source/WebKit2:
      
      Add support for TestRunner::setViewModeMediaFeature().
      This functionality is needed by the following LayoutTests:
      fast/media/media-query-list-02.html
      fast/media/media-query-list-03.html
      fast/media/media-query-list-04.html
      fast/media/media-query-list-05.html
      fast/media/media-query-list-06.html
      fast/media/media-query-list-07.html
      fast/media/view-mode-media-feature.html
      
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      (WKBundlePageSetViewMode):
      * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setViewMode):
      (WebKit):
      * WebProcess/WebPage/WebPage.h:
      (WebPage):
      
      Tools:
      
      Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner.
      This API is required by layout tests.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::setViewModeMediaFeature):
      (WTR):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests:
      
      Unskipping the following tests for EFL WebKit2:
      fast/media/media-query-list-02.html
      fast/media/media-query-list-03.html
      fast/media/media-query-list-04.html
      fast/media/media-query-list-05.html
      fast/media/media-query-list-06.html
      fast/media/media-query-list-07.html
      fast/media/view-mode-media-feature.html
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea31e6b3
    • hausmann@webkit.org's avatar
      [Qt] Fix QtWebProcess discovery on Windows · 701da71a
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104552
      
      Reviewed by Jocelyn Turcotte.
      
      Make sure to look for QtWebProcess.exe on Windows instead of QtWebProcess.
      
      * Shared/qt/ProcessExecutablePathQt.cpp:
      (WebKit::executablePath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      701da71a
    • mrobinson@webkit.org's avatar
      [GTK] Bring Harfbuzz-ng support to Gtk · 20d7454c
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92098
      
      Reviewed by Gustavo Noronha Silva.
      
      .:
      
      Add support for detecting HarfBuzz during configuration phase. Add these
      flags to the FreeType ones since HarfBuzz support is part of the FreeType
      backend.
      
      * configure.ac: Detect HarfBuzz.
      
      Source/WebCore:
      
      Enable HarfBuzz support by default. With the Freetype backend we no longer
      fall back to Pango for rendering complex text.
      
      No new tests. This is covered by existing tests.
      
      * GNUmakefile.am: Add HarfBuzz include directories and define.
      * GNUmakefile.list.am: Add HarfBuzz files to source list and remove
      Pango ones.
      * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
      (WebCore::FontPlatformData::operator==): To properly render fallback
      fonts via HarfBuzz , it's important that we actually ask Fontconfig
      whether or not two patterns are the same. This ensures that when patterns
      are just copies of one another they only take up one slot in the font cache
      and appear to be the same font to HarfBuzzShaper.
      
      Source/WebKit/gtk:
      
      Add HarfBuzz dependency.
      
      * GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the library.
      
      Source/WebKit2:
      
      Add a HarfBuzz dependency.
      
      * GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS/LIBS to the libraries.
      
      Tools:
      
      Add HarfBuzz dependency.
      
      * GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the WebCore Internals library.
      * gtk/jhbuild.modules: Add HarfBuzz to the JHbuild and remove Pango, since it
      should no longer affect layout test results.
      
      LayoutTests:
      
      Update tests results that have changed due to the switch to HarfBuzz.
      In general, these are progressions or harmless metrics differences.
      
      * platform/gtk: Update test results that have changed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20d7454c
    • hausmann@webkit.org's avatar
      [Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally · 8d480e3a
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104541
      
      Reviewed by Jocelyn Turcotte.
      
      We now depend on a Qt 5 version that is guaranteed to have this API, so we
      can remove the configure checks for it.
      
      Source/WebKit2:
      
      * PluginProcess.pro:
      * Shared/qt/ProcessExecutablePathQt.cpp:
      (WebKit::executablePath):
      * WebProcess.pro:
      
      Tools:
      
      * qmake/config.tests/libexecdir/libexecdir.cpp: Removed.
      * qmake/config.tests/libexecdir/libexecdir.pro: Removed.
      * qmake/mkspecs/features/features.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d480e3a
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · 86f729fb
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104548
      
      * platform/chromium/TestExpectations:
      Hyphenation tests failure on WebKit-only checkout Linux
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86f729fb
    • loislo@chromium.org's avatar
      Unreviewed: update expectation for inspector/styles/svg-style.xhtml · d6858df1
      loislo@chromium.org authored
      * inspector/styles/svg-style-expected.txt:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6858df1
    • apavlov@chromium.org's avatar
      Web Inspector: [Overrides] Unable to change values in Device Metrics override setting · 46fe2119
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104542
      
      Reviewed by Vsevolod Vlasov.
      
      Remove inadvertent object property assignment.
      
      * inspector/front-end/OverridesView.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46fe2119
    • commit-queue@webkit.org's avatar
      REGRESSION(r135863): GtkLauncher --help no longer displays all help options · 501d3331
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104382
      
      Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2012-12-10
      Reviewed by Philippe Normand.
      
      Remove gst_init() because it steals the GOptionContext.
      gst_init_get_option_group() already does the initialization job.
      
      * GtkLauncher/main.c:
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      501d3331
    • charles.wei@torchmobile.com.cn's avatar
      [BlackBerry] Webkit crashes sometimes (even though very rarely) when deleting a webview · ea29cf59
      charles.wei@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=104504
      
      Reviewed by George Staikos.
      
      When deleting a webview, the webkit thread will send a sync message to userInterfaceThread
      to delete handlers, including the viewport accessor. But the UserInterfaceThread could be
      doing a blit after it has deleted the viewport accessor and before the webkit thread gets
      the time slot to resume it's operation to clean up the webview, which leaves a very short
      time that viewport accessor of a webpage has been deleted while the webpage is still in
      the process of deleting, and the viewport accessor is referenced in the UserInterfaceThread.
      
      So we need to check if the viewport accessor is NULL before using it in the backingstore code.
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
      (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea29cf59