1. 02 Oct, 2009 1 commit
    • hyatt@apple.com's avatar
      Add support for blacklist patterns to user stylesheets and scripts in addition... · 19fd5912
      hyatt@apple.com authored
      Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.
      
      Reviewed by Adam Roben.
      
      WebCore: 
      
      * WebCore.base.exp:
      * dom/Document.cpp:
      (WebCore::Document::pageGroupUserSheets):
      * page/Frame.cpp:
      (WebCore::Frame::injectUserScriptsForWorld):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::addUserScript):
      (WebCore::PageGroup::addUserStyleSheet):
      (WebCore::PageGroup::removeUserContentWithURLForWorld):
      (WebCore::PageGroup::removeUserContentForWorld):
      * page/PageGroup.h:
      * page/UserContentURLPattern.cpp:
      (WebCore::UserContentURLPattern::matchesPatterns):
      * page/UserContentURLPattern.h:
      * page/UserScript.h:
      (WebCore::UserScript::UserScript):
      (WebCore::UserScript::whitelist):
      (WebCore::UserScript::blacklist):
      * page/UserStyleSheet.h:
      (WebCore::UserStyleSheet::UserStyleSheet):
      (WebCore::UserStyleSheet::whitelist):
      (WebCore::UserStyleSheet::blacklist):
      
      WebKit/mac: 
      
      * WebView/WebView.mm:
      (toStringVector):
      (+[WebView _addUserScriptToGroup:source:url:worldID:whitelist:blacklist:injectionTime:]):
      (+[WebView _addUserStyleSheetToGroup:source:url:worldID:whitelist:blacklist:]):
      * WebView/WebViewPrivate.h:
      
      WebKit/win: 
      
      * Interfaces/IWebViewPrivate.idl:
      * WebView.cpp:
      (toStringVector):
      (WebView::addUserScriptToGroup):
      (WebView::addUserStyleSheetToGroup):
      * WebView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19fd5912
  2. 01 Oct, 2009 1 commit
  3. 30 Sep, 2009 1 commit
  4. 29 Sep, 2009 3 commits
    • beidson@apple.com's avatar
      WebKit Mac API should provide a delegate interface for global history. · b0b8ef70
      beidson@apple.com authored
      <rdar://problem/7042773> and https://webkit.org/b/29904
      
      Reviewed by John Sullivan.
      
      WebKit: 
      
      * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac: 
      
      * WebView/WebHistoryDelegate.h: Added. New interface for WebKit clients to implement to manage 
        their own global history store.
      
      Object to store all of the bits of data relevant to a page visit:
      * WebView/WebNavigationData.h: Added.
      * WebView/WebNavigationData.mm: Added.
      (-[WebNavigationDataPrivate dealloc]):
      (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
      (-[WebNavigationData url]):
      (-[WebNavigationData title]):
      (-[WebNavigationData originalRequest]):
      (-[WebNavigationData response]):
      (-[WebNavigationData hasSubstituteData]):
      (-[WebNavigationData clientRedirectSource]):
      (-[WebNavigationData dealloc]):
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::updateGlobalHistory): If the delegate exists, don't use the built-in WebHistory.
        If the implementation for this method exists, call it.
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Ditto
      
      * WebView/WebDelegateImplementationCaching.h:
      * WebView/WebDelegateImplementationCaching.mm:
      (WebViewGetHistoryDelegateImplementations):
      (CallHistoryDelegate):
      
      * WebView/WebView.mm:
      (-[WebView _cacheHistoryDelegateImplementations]):
      (-[WebView setHistoryDelegate:]):
      (-[WebView historyDelegate]):
      * WebView/WebViewData.h:
      * WebView/WebViewPrivate.h:
      
      WebKitTools: 
      
      Adding the dumping of global history delegate callbacks.
      
      * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      
      Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (createWebViewAndOffscreenWindow):
      (allocateGlobalControllers):
      (shouldLogFrameLoadDelegates):
      (shouldLogHistoryDelegates):
      (runTest):
      
      Dump history delegate callbacks:
      * DumpRenderTree/mac/HistoryDelegate.h: Added.
      * DumpRenderTree/mac/HistoryDelegate.mm: Added.
      (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
      (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
      (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
      
      LayoutTests: 
      
      * http/tests/globalhistory: Added.
      * http/tests/globalhistory/history-delegate-basic-302-redirect-expected.txt: Added.
      * http/tests/globalhistory/history-delegate-basic-302-redirect.html: Added.
      * http/tests/globalhistory/history-delegate-basic-refresh-redirect-expected.txt: Added.
      * http/tests/globalhistory/history-delegate-basic-refresh-redirect.html: Added.
      * http/tests/resources/notify-done.html: Added.
      * http/tests/resources/redirect.php: Augment to optionally do "Refresh:"-style redirects.
      
      Skip these new tests on all platforms that don't have history delegates (yet):
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0b8ef70
    • dglazkov@chromium.org's avatar
      WebCore: · 5063cff9
      dglazkov@chromium.org authored
      2009-09-29  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Add support for run-time flag for 3D canvas
              https://bugs.webkit.org/show_bug.cgi?id=29826
      
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::getContext): Check page settings for
              experimental WebGL flag before returning 3D graphics context.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Initialize new flag to false.
              (WebCore::Settings::setExperimentalWebGLEnabled):
              * page/Settings.h: Set new flag.
              (WebCore::Settings::experimentalWebGLEnabled): Return new flag.
      
      WebKit/mac:
      
      2009-09-29  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Add support for run-time flag for 3D canvas
              https://bugs.webkit.org/show_bug.cgi?id=29826
      
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Enable experimental
              WebGL flag when 3D_CANVAS is enabled in the build.
      
      WebKit/win:
      
      2009-09-29  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Add support for run-time flag for 3D canvas
              https://bugs.webkit.org/show_bug.cgi?id=29826
      
              * WebView.cpp:
              (WebView::notifyPreferencesChanged): Enable experimental WebGL
              flag when 3D_CANVAS is enabled in the build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5063cff9
    • ukai@chromium.org's avatar
      2009-09-28 Fumitoshi Ukai <ukai@chromium.org> · bf4fada3
      ukai@chromium.org authored
              Reviewed by Eric Seidel.
      
              Add experimentalWebSocketsEnabled in Settings.
              https://bugs.webkit.org/show_bug.cgi?id=28941
      
              * WebCore.base.exp:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::webSocket):
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::getConstructor):
              * bindings/v8/custom/V8WebSocketCustom.cpp:
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setExperimentalWebSocketsEnabled):
              * page/Settings.h:
              (WebCore::Settings::experimentalWebSocketsEnabled):
      
      2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Add experimentalWebSocketsEnabled in WebPreferences.
              https://bugs.webkit.org/show_bug.cgi?id=28941
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences experimentalWebSocketsEnabled]):
              (-[WebPreferences setExperimentalWebSocketsEnabled:]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      
      2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Add experimentalWebSocketsEnabled in WebPreferences.
              https://bugs.webkit.org/show_bug.cgi?id=28941
      
              * Interfaces/IWebPreferencesPrivate.idl:
              * WebPreferenceKeysPrivate.h:
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
              (WebPreferences::setExperimentalWebSocketsEnabled):
              (WebPreferences::experimentalWebSocketsEnabled):
              * WebPreferences.h:
              * WebView.cpp:
              (WebView::notifyPreferencesChanged):
              (core):
      
      2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Add experimentalWebSocketsEnabled in WebPreferences.
              https://bugs.webkit.org/show_bug.cgi?id=28941
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf4fada3
  5. 25 Sep, 2009 1 commit
    • jhoneycutt@apple.com's avatar
      Add a mechanism for automatically halting plug-ins. · 45f50cee
      jhoneycutt@apple.com authored
      Reviewed by Oliver Hunt and Alice Liu.
      
      WebCore:
      
      * GNUmakefile.am:
      
      * WebCore.base.exp:
      Update export of Page constructor.
      
      * WebCore.gypi:
      
      * WebCore.pro:
      
      * WebCore.vcproj/WebCore.vcproj:
      Add PluginHalter.{h,cpp}, PluginHalterClient.h, and
      HaltablePlugin.h.
      
      * WebCore.xcodeproj/project.pbxproj:
      Add files to Mac project.
      
      * loader/EmptyClients.h:
      Added an empty PluginHalterClient.
      (WebCore::EmptyPluginHalterClient::shouldHaltPlugin):
      Return false.
      
      * page/PluginHalter.cpp: Added.
      (WebCore::PluginHalter::PluginHalter):
      (WebCore::PluginHalter::didStartPlugin):
      Add the object to the plug-in set. If this is the only item in the set,
      set m_oldestStartTime to this object's time, and start the timer.
      (WebCore::PluginHalter::didStopPlugin):
      Remove the plug-in from the set.
      (WebCore::PluginHalter::timerFired):
      Find the cut-off time as the current time minus the allowed run time;
      plug-ins older than this may be halted. Iterate over the plug-ins. Find
      the object with the oldest start time that is too young to be halted;
      we'll use its start time to set the timer's next fire time. For all
      plug-ins that are candidates to be halted, call the
      PluginHalterClient's shouldHaltPlugin(). If this function returns true,
      call the plug-in's halt() function. Remove these objects from the set
      of tracked plug-ins. Call startTimerIfNecessary() to restart the timer.
      (WebCore::PluginHalter::startTimerIfNecessary):
      If the timer is set to fire, or the set of tracked plug-ins is empty,
      return early. Set the timer to fire after the oldest plug-in has run
      for the allowed run time.
      
      * page/PluginHalter.h: Added.
      (WebCore::PluginHalter::setPluginAllowedRunTime):
      
      * page/PluginHalterClient.h: Added.
      (WebCore::PluginHalterClient::~PluginHalterClient)
      
      * page/Page.cpp:
      (WebCore::Page::Page):
      Initialize m_pluginHalterClient. Call pluginHalterEnabledStateChanged()
      to create the PluginHalter if necessary.
      (WebCore::Page::pluginHalterEnabledStateChanged):
      If plug-in halting is enabled, create the PluginHalter. If it is
      disabled, clear it.
      (WebCore::Page::pluginAllowedRunTimeChanged):
      If there is a plug-in halter, call its setPluginAllowedRunTime().
      (WebCore::Page::didStartPlugin):
      If there is a plug-in halter, call its didStartPlugin().
      (WebCore::Page::didStopPlugin):
      If there is a plug-in halter, call its didStopPlugin().
      
      * page/Page.h:
      Add a parameter to the Page constructor for the PluginHalterClient.
      Added declarations for didStartPlugin() and didStopPlugin(), which are
      called when HaltablePlugins are added to or removed from the page. Adds
      pluginAllowedRunTimeChanged() and pluginHalterEnabledStateChanged() to
      notify the Page when these settings are changed. Added members to hold
      the PluginHalter and the PluginHalterClient.
      
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore::Settings::setPluginHalterEnabled):
      If the enabled state has changed, call the Page's
      pluginHalterEnabledStateChanged().
      (WebCore::Settings::setPluginAllowedRunTime):
      Call the Page's pluginAllowedRunTimeChanged().
      
      * page/Settings.h:
      (WebCore::Settings::pluginHalterEnabled):
      (WebCore::Settings::pluginAllowedRunTime):
      
      * page/HaltablePlugin.h: Added. Defines an interface for plug-ins that
      can be automatically halted.
      (WebCore::HaltablePlugin::~HaltablePlugin)
      
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::dataChanged):
      Pass a dummy PluginHalterClient.
      
      WebKit/gtk/:
      
      * webkit/webkitwebview.cpp:
      (webkit_web_view_init):
      Pass 0 for new Page constructor argument.
      
      WebKit/mac/:
      
      * WebView/WebView.mm:
      (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
      Pass 0 for new Page constructor argument.
      
      WebKit/qt/:
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::QWebPagePrivate):
      Pass 0 for new Page constructor argument.
      
      WebKit/win:
      
      * Interfaces/IWebPluginHalterDelegate.idl: Added. Defines an interface
      for a delegate that determines whether plug-ins should be halted.
      
      * Interfaces/IWebPreferencesPrivate.idl:
      Declare functions to get and set the enabled state of the plug-in
      halter and the plug-in allowed run time.
      
      * Interfaces/IWebViewPrivate.idl:
      Declare functions to get and set the IWebPluginHalterDelegate.
      
      * Interfaces/WebKit.idl:
      
      * WebCoreSupport/WebPluginHalterClient.cpp: Added.
      (WebPluginHalterClient::WebPluginHalterClient):
      (WebPluginHalterClient::shouldHaltPlugin):
      Get the IWebPluginHalterDelegate for the WebView. Create a WebKit
      DOMNode for the WebCore Node. Call the delegate's shouldHaltPlugin().
      If the call fails, return false. Otherwise, return the result of the
      call.
      
      * WebCoreSupport/WebPluginHalterClient.h: Added.
      
      * WebKit.vcproj/Interfaces.vcproj:
      Add IWebPluginHalterDelegate.idl.
      
      * WebKit.vcproj/WebKit.vcproj:
      Add WebPluginHalterClient.{h,cpp}.
      
      * WebPreferenceKeysPrivate.h:
      Define WebKitPluginHalterEnabledPreferenceKey and
      WebKitPluginAllowedRunTimePreferenceKey.
      
      * WebPreferences.cpp:
      (WebPreferences::initializeDefaultSettings):
      Leave plug-in halting disabled by default. Set the default value for
      the plug-in allowed run time to the max value of an unsigned int.
      (WebPreferences::setPluginHalterEnabled):
      (WebPreferences::pluginHalterEnabled):
      (WebPreferences::setPluginAllowedRunTime):
      (WebPreferences::pluginAllowedRunTime):
      
      * WebPreferences.h:
      
      * WebView.cpp:
      (WebView::close):
      Clear the IWebPluginHalterDelegate.
      (WebView::initWithFrame):
      Pass a WebPluginHalterClient when creating the Page.
      (WebView::notifyPreferencesChanged):
      Set the new settings when the preferences changed notification is
      received.
      (WebView::setPluginHalterDelegate):
      (WebView::pluginHalterDelegate):
      
      * WebView.h:
      Declare overrides of setPluginHalterDelegate() and
      pluginHalterDelegate(). Added a member to track the
      IWebPluginHalterDelegate.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45f50cee
  6. 24 Sep, 2009 1 commit
    • atwilson@chromium.org's avatar
      WebCore: isEnabled switch for notifications (experimental) in Page Settings · 046e502c
      atwilson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28930
      
      Patch by John Gregg <johnnyg@google.com> on 2009-09-14
      Reviewed by Eric Seidel.
      
      Adds a run-time flag in Settings object that controls whether
      to expose desktop notifications.
      
      No new test, but test code also modified to set this preference.
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::webkitNotifications): check preference before returning notifications object
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore::Settings::setExperimentalNotificationsEnabled):
      * page/Settings.h:
      (WebCore::Settings::experimentalNotificationsEnabled):
      
      WebKit/mac: isEnabled switch for notifications (experimental) in Page Settings
      https://bugs.webkit.org/show_bug.cgi?id=28930
      
      Patch by John Gregg <johnnyg@google.com> on 2009-09-14
      Reviewed by Eric Seidel.
      
      Adds support for the experimentalNotificationsEnabled flag in Settings
      through WebPreferencesPrivate.
      
      * WebView/WebPreferenceKeysPrivate.h:
      * WebView/WebPreferences.mm:
      (+[WebPreferences initialize]):
      (-[WebPreferences experimentalNotificationsEnabled]):
      (-[WebPreferences setExperimentalNotificationsEnabled:]):
      * WebView/WebPreferencesPrivate.h:
      * WebView/WebView.mm:
      (-[WebView _preferencesChangedNotification:]):
      
      WebKit/win: Enable switch for notifications (experimental) in Page Settings
      https://bugs.webkit.org/show_bug.cgi?id=28930
      
      Patch by John Gregg <johnnyg@google.com> on 2009-09-14
      Reviewed by Eric Seidel.
      
      Adds support for the experimentalNotificationsEnabled flag in Settings through
      WebPreferencesPrivate interface.  Also cleans up some issues accessing the
      notification delegate through DumpRenderTree.
      
      * Interfaces/IWebPreferencesPrivate.idl:
      * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
      (WebDesktopNotificationsDelegate::hasNotificationDelegate):
      (WebDesktopNotificationsDelegate::notificationDelegate):
      * WebPreferenceKeysPrivate.h:
      * WebPreferences.cpp:
      (WebPreferences::initializeDefaultSettings):
      (WebPreferences::setExperimentalNotificationsEnabled):
      (WebPreferences::experimentalNotificationsEnabled):
      * WebPreferences.h:
      * WebView.cpp:
      (WebView::notifyPreferencesChanged):
      
      WebKitTools: Enable switch for notifications (experimental) in Page Settings
      https://bugs.webkit.org/show_bug.cgi?id=28930
      
      Patch by John Gregg <johnnyg@google.com> on 2009-09-14
      Reviewed by Eric Seidel.
      
      Now that desktop notifications are controlled by run-time switch,
      set that switch to true for DumpRenderTree.
      
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (resetDefaultsToConsistentValues):
      * DumpRenderTree/win/DumpRenderTree.cpp:
      (resetDefaultsToConsistentValues):
      * DumpRenderTree/win/UIDelegate.cpp:
      (UIDelegate::QueryInterface):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      046e502c
  7. 09 Sep, 2009 1 commit
    • hyatt@apple.com's avatar
      WebCore: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user... · 63e0ac2f
      hyatt@apple.com authored
      WebCore: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection.  This is similar
      to user script injection but allows for user stylesheets to be added.  The stylesheets are applied immediately
      to all Frames in the PageGroup.
      
      Reviewed by Adam Roben.
      
      Added userscripts/simple-stylesheet.html test case.
      
      * WebCore.base.exp:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::CSSStyleSelector):
      * css/CSSStyleSelector.h:
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::attach):
      (WebCore::Document::pageGroupUserSheets):
      (WebCore::Document::clearPageGroupUserSheets):
      (WebCore::Document::recalcStyleSelector):
      * dom/Document.h:
      * loader/PlaceholderDocument.cpp:
      (WebCore::PlaceholderDocument::attach):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::addUserStyleSheet):
      (WebCore::PageGroup::removeUserContentForWorld):
      (WebCore::PageGroup::removeAllUserContent):
      * page/PageGroup.h:
      (WebCore::PageGroup::userStyleSheets):
      * page/UserStyleSheet.h: Added.
      (WebCore::UserStyleSheet::UserStyleSheet):
      (WebCore::UserStyleSheet::source):
      (WebCore::UserStyleSheet::url):
      (WebCore::UserStyleSheet::patterns):
      (WebCore::UserStyleSheet::worldID):
      * page/UserStyleSheetTypes.h: Added.
      
      WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection.  This is similar
      to user script injection but allows for user stylesheets to be added.  The stylesheets are applied immediately
      to all Frames in the PageGroup.
      
      Reviewed by Adam Roben.
      
      Added userscripts/simple-stylesheet.html test case.
      
      * WebView/WebView.mm:
      (+[WebView _addUserStyleSheetToGroup:source:url:worldID:patterns:]):
      * WebView/WebViewPrivate.h:
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection.  This is similar
      to user script injection but allows for user stylesheets to be added.  The stylesheets are applied immediately
      to all Frames in the PageGroup.
      
      Reviewed by Adam Roben.
      
      Added userscripts/simple-stylesheet.html test case.
      
      * platform/mac/userscripts/simple-stylesheet-expected.checksum: Added.
      * platform/mac/userscripts/simple-stylesheet-expected.png: Added.
      * platform/mac/userscripts/simple-stylesheet-expected.txt: Added.
      * userscripts/simple-stylesheet.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63e0ac2f
  8. 04 Sep, 2009 2 commits
    • hyatt@apple.com's avatar
      WebCore: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work. · 71960d78
      hyatt@apple.com authored
              
      Reviewed by Adam Roben.
      
      This patch adds new API for adding and removing user scripts from page groups.  User scripts
      are bundled together in isolated worlds (you can have multiple scripts together in the same
      world).
      
      Added userscripts/ directory for holding new tests (along with a simple test of script injection).
      
      * WebCore.base.exp:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::evaluateInIsolatedWorld):
      * bindings/js/ScriptController.h:
      * bindings/v8/ScriptController.cpp:
      (WebCore::ScriptController::evaluateInIsolatedWorld):
      * bindings/v8/ScriptController.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::finishedParsing):
      (WebCore::FrameLoader::dispatchDocumentElementAvailable):
      * page/Frame.cpp:
      (WebCore::Frame::injectUserScripts):
      (WebCore::Frame::injectUserScriptsForWorld):
      * page/Frame.h:
      * page/PageGroup.cpp:
      (WebCore::PageGroup::~PageGroup):
      (WebCore::PageGroup::addUserScript):
      (WebCore::PageGroup::removeUserContentForWorld):
      (WebCore::PageGroup::removeAllUserContent):
      * page/PageGroup.h:
      (WebCore::PageGroup::userScripts):
      * page/UserScript.h: Added.
      (WebCore::UserScript::UserScript):
      (WebCore::UserScript::source):
      (WebCore::UserScript::url):
      (WebCore::UserScript::patterns):
      (WebCore::UserScript::worldID):
      (WebCore::UserScript::injectionTime):
      * page/UserScriptTypes.h: Added.
      (WebCore::):
      
      WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.
              
      Reviewed by Adam Roben.
      
      This patch adds new API for adding and removing user scripts from page groups.  User scripts
      are bundled together in isolated worlds (you can have multiple scripts together in the same
      world).
      
      Added userscripts/ directory for holding new tests (along with a simple test of script injection).
      
      * WebView/WebView.mm:
      (+[WebView _addUserScriptToGroup:source:url:worldID:patterns:injectionTime:]):
      (+[WebView _removeUserContentFromGroup:worldID:]):
      (+[WebView _removeAllUserContentFromGroup:]):
      * WebView/WebViewPrivate.h:
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28890, make simple user script injection work.
              
      Reviewed by Adam Roben.
      
      This patch adds new API for adding and removing user scripts from page groups.  User scripts
      are bundled together in isolated worlds (you can have multiple scripts together in the same
      world).
      
      Added userscripts/ directory for holding new tests (along with a simple test of script injection).
      
      * platform/mac/userscripts: Added.
      * platform/mac/userscripts/script-run-at-end-expected.txt: Added.
      * userscripts: Added.
      * userscripts/script-run-at-end.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71960d78
    • abarth@webkit.org's avatar
      2009-09-04 Adam Barth <abarth@webkit.org> · 92c46c18
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Plumb mixed content notifications to WebFrameLoadDelegatePrivate.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::didDisplayInsecureContent):
              (WebFrameLoaderClient::didRunInsecureContent):
              * WebView/WebDelegateImplementationCaching.h:
              * WebView/WebFrameLoadDelegatePrivate.h: Added.
      2009-09-04  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Plumb mixed content notifications to IWebFrameLoadDelegatePrivate.
      
              * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added.
              * Interfaces/WebKit.idl:
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::didDisplayInsecureContent):
              (WebFrameLoaderClient::didRunInsecureContent):
              * WebKit.vcproj/Interfaces.vcproj:
      2009-09-04  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=24696
      
              Add testing instrumentation for mixed content.
      
              * DumpRenderTree/mac/FrameLoadDelegate.mm:
              (-[FrameLoadDelegate webView:]):
              (-[FrameLoadDelegate webView:didRunInsecureContent:]):
              * DumpRenderTree/win/FrameLoadDelegate.cpp:
              (descriptionSuitableForTestResult):
              (FrameLoadDelegate::QueryInterface):
              (FrameLoadDelegate::didDisplayInsecureContent):
              (FrameLoadDelegate::didRunInsecureContent):
              * DumpRenderTree/win/FrameLoadDelegate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92c46c18
  9. 20 Aug, 2009 1 commit
    • levin@chromium.org's avatar
      WebCore: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to · 234cc228
      levin@chromium.org authored
      specify a more granular policy for cross-origin XHR access.
      
      Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
      Reviewed by David Levin.
      
      Tests: http/tests/xmlhttprequest/origin-whitelisting-all.html
             http/tests/xmlhttprequest/origin-whitelisting-exact-match.html
             http/tests/xmlhttprequest/origin-whitelisting-https.html
             http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html
             http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html
             http/tests/xmlhttprequest/origin-whitelisting-subdomains.html
      
      * WebCore.base.exp: Export methods to manipulate origin access whitelists to enable
      testing via layout tests.
      
      * WebCore.xcodeproj/project.pbxproj: Add OriginAccessEntry.*
      * GNUmakefile.am: Ditto.
      * WebCore.gypi: Ditto.
      * WebCore.pro: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCoreSources.blk: Ditto.
      
      * page/SecurityOrigin.h: Implement origin access whitelists.
      (WebCore::originAccessMap): Static getter for access whitelists.
      (WebCore::SecurityOrigin::canRequest): Modify request checking logic to check whitelists.
      (WebCore::SecurityOrigin::whiteListAccessFromOrigin): Add an entry to a whitelist.
      (WebCore::SecurityOrigin::resetOriginAccessWhiteLists): Clear all the whitelists.
      
      * page/OriginAccessEntry.h: Added. An entry in an origin access whitelist.
      * page/OriginAccessEntry.cpp: Ditto.
      
      WebKit/gtk: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
      specify a more granular policy for cross-origin XHR access.
      
      Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
      Reviewed by David Levin.
      
      * webkit/webkitprivate.cpp:
      (webkit_white_list_access_to_origin): Add API to manipulate origin access whitelists.
      (webkit_reset_origin_access_white_lists): Ditto.
      * webkit/webkitprivate.h: Ditto.
      
      WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
      specify a more granular policy for cross-origin XHR access.
      
      Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
      Reviewed by David Levin.
      
      * WebView/WebView.mm: Add SPI to manipulate origin access whitelists.
      (+[WebView _whiteListAccessFromOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]): Ditto.
      (+[WebView _resetOriginAccessWhiteLists]): Ditto.
      * WebView/WebViewPrivate.h: Ditto.
      
      WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
      specify a more granular policy for cross-origin XHR access.
      
      Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
      Reviewed by David Levin.
      
      * Api/qwebsecurityorigin.cpp: Add API to manipulate origin access whitelists.
      (QWebSecurityOrigin::whiteListAccessFromOrigin): Ditto.
      (QWebSecurityOrigin::resetOriginAccessWhiteLists): Ditto.
      * Api/qwebsecurityorigin.h: Ditto.
      
      WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
      specify a more granular policy for cross-origin XHR access.
      
      Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
      Reviewed by David Levin.
      
      * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
      (whiteListAccessFromOriginCallback): Ditto.
      (LayoutTestController::staticFunctions): Ditto.
      * DumpRenderTree/LayoutTestController.h: Ditto.
      * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
      (LayoutTestController::whiteListAccessToOrigin): Ditto.
      * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
      (LayoutTestController::whiteListAccessFromOrigin): Ditto.
      * DumpRenderTree/qt/jsobjects.cpp: Ditto.
      (LayoutTestController::whiteListAccessFromOrigin): Ditto.
      * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
      (LayoutTestController::whiteListAccessFromOrigin): Ditto.
      * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
      (resetWebViewToConsistentStateBeforeTesting): Ditto.
      * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
      (resetWebViewToConsistentStateBeforeTesting): Ditto.
      * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
      (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
      specify a more granular policy for cross-origin XHR access.
      
      Patch by Aaron Boodman <aa@chromium.org> on 2009-08-19
      Reviewed by David Levin.
      
      * http/tests/xmlhttprequest/origin-whitelisting-all-expected.txt: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-all.html: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-exact-match-expected.txt: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-exact-match.html: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-https.html: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-expected.txt: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-subdomains-expected.txt: Added.
      * http/tests/xmlhttprequest/origin-whitelisting-subdomains.html: Added.
      * http/tests/xmlhttprequest/resources/origin-whitelisting-ip-address-test.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      234cc228
  10. 12 Aug, 2009 1 commit
  11. 31 Jul, 2009 1 commit
    • simon.fraser@apple.com's avatar
      2009-07-31 Simon Fraser <simon.fraser@apple.com> · 8717fee1
      simon.fraser@apple.com authored
              Reviewed by Anders Carlsson.
      
              Accelerated animations stutter on pages with lots of animations and 3d transforms
              https://bugs.webkit.org/show_bug.cgi?id=27884
      
              This patch changes the strategy for synchronizing painting view the view,
              and compositing layer updates. Previously the strategy was to disable screen
              updates between the time we updated the layer tree, and painted the view. That
              left screen updates disabled for too long (hundreds of milliseconds) in some
              cases, causing animation stutter.
      
              The new strategy is to batch up changes to the CA layer tree, and commit them
              all at once just before painting happens (referred to as a "sync" in the code).
              GraphicsLayerCA now keeps a bitmask of changed properties, and then migrates
              the values stored in GraphicsLayer into the CA layer tree at commit time.
      
              Compositing layers are then synced in FrameView::paintContents(). However, not
              all style/layout changes will result in painting; to deal with style changes that
              touch only compositing properties, we set up a runloop observer that takes care
              of comitting layer changes when no painting happens.
      
              * WebCore.base.exp: Export FrameView::syncCompositingStateRecursive()
      
              * loader/EmptyClients.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
              * page/ChromeClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
      
              * page/FrameView.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::syncCompositingStateRecursive): syncCompositingState() on the
              view and all subviews. Like layoutIfNeededRecursive(). If layout is pending, does not
              sync and returns false, since we only want to sync when layout is done.
      
              (WebCore::FrameView::paintContents): syncCompositingState() before painting.
      
              * page/animation/KeyframeAnimation.cpp:
              (WebCore::KeyframeAnimation::endAnimation):
              Call animationPaused() to notify the graphics layers about animation pausing.
      
              * platform/graphics/FloatPoint3D.h:
              (WebCore::operator==):
              (WebCore::operator!=):
              Add missing comparison operators.
      
              * platform/graphics/GraphicsLayer.cpp:
              (WebCore::GraphicsLayer::setOpacity):
              (WebCore::GraphicsLayer::setBackgroundColor): Simple setters no longer care about animation info.
      
              (WebCore::GraphicsLayer::paintGraphicsLayerContents): Null-check client.
      
              * platform/graphics/GraphicsLayer.h:
              (WebCore::AnimationValue:):
              (WebCore::TransformAnimationValue:):
              (WebCore::KeyframeValueList:):
              (WebCore::KeyframeValueList::insert):
              Cleaned up versions of FloatValue and TransformValue, used to store information
              about keyframes values.
      
              (WebCore::GraphicsLayer::contentsRect):
              (WebCore::GraphicsLayer::setContentsRect):
              ContentsRect is now a simple setter.
      
              (WebCore::GraphicsLayer::addAnimation):
              (WebCore::GraphicsLayer::removeAnimationsForProperty):
              (WebCore::GraphicsLayer::removeAnimationsForKeyframes):
              (WebCore::GraphicsLayer::pauseAnimation):
              Simplified animation api.
      
              (WebCore::GraphicsLayer::setGeometryOrientation):
              (WebCore::GraphicsLayer::geometryOrientation):
              setGeometryOrientation is now just a normal member variable.
      
              (WebCore::GraphicsLayer::contentsOrientation): add a getter.
              (WebCore::GraphicsLayer::syncCompositingState): Entry into the layer sync code.
      
              * platform/graphics/GraphicsLayerClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive)
      
              * platform/graphics/mac/GraphicsLayerCA.h:
              * platform/graphics/mac/GraphicsLayerCA.mm:
              Lots of cleanup and refactoring. Main points:
              - Layer changes are all batched, and only committed to the CA layer on syncCompositingState().
              - Bitmask is used to store which properties have changed. More efficient than before.
              - Simpler animation interface; simple setters are no longer confounded with animations.
              - Refactored code that creates CA animations, and stores which animations are running.
      
              * platform/graphics/transforms/TransformOperations.h:
              (WebCore::TransformOperations::size):
              (WebCore::TransformOperations::at): Useful accessors for size and indexed access.
      
              * rendering/RenderLayerBacking.h:
              * rendering/RenderLayerBacking.cpp:
              Renamed 'contentsLayer' to 'foregroundLayer' to avoid confusion with GraphicsLayer's
              contentsLayer.
              Adapt to GraphicsLayer's simpler animation API.
              Pass animation pausing through to the graphics layers.
              contentsBox() is no longer a callback via GraphicsLayerClient.
      
              * rendering/RenderLayerCompositor.h:
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild):
              (WebCore::RenderLayerCompositor::scheduleSync):
              (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
              scheduleViewUpdate() is no longer required. Instead, we plumb through "compositingLayerSync"
              notifications, which travel up to WebKit and set up a runloop observer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8717fee1
  12. 29 Jul, 2009 1 commit
    • kmccullough@apple.com's avatar
      WebCore: · 907d84c4
      kmccullough@apple.com authored
      2009-07-29  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Darin Adler.
      
              Added foundation work to allow a testing infrastructure for the Web
              Inspector.
      
              * inspector/InspectorClient.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::scriptObjectReady): Tell the testing
              harness that the window object is ready.
              * loader/EmptyClients.h: Empty class support for SVG.
              (WebCore::EmptyInspectorClient::inspectorWindowObjectCleared):
      
      WebKit/gtk:
      
      2009-07-29  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Darin Adler.
      
              Added foundation work to allow a testing infrastructure for the Web
              Inspector.
       
              * WebCoreSupport/InspectorClientGtk.cpp:
              (WebKit::InspectorClient::inspectorWindowObjectCleared):
              * WebCoreSupport/InspectorClientGtk.h:
      
      WebKit/mac:
      
      2009-07-29  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Darin Adler.
      
              Added foundation work to allow a testing infrastructure for the Web
              Inspector.
      
              * WebCoreSupport/WebInspectorClient.h:
              * WebCoreSupport/WebInspectorClient.mm:
              (WebInspectorClient::inspectorWindowObjectCleared): Send the delegate
              callback.
              * WebView/WebDelegateImplementationCaching.h:
              * WebView/WebView.mm:
              (-[WebView _cacheFrameLoadDelegateImplementations]):
              * WebView/WebViewPrivate.h: The delegate SPI.
      
      WebKit/qt:
      
      2009-07-29  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Darin Adler.
      
              Added foundation work to allow a testing infrastructure for the Web
              Inspector.
      
              * WebCoreSupport/InspectorClientQt.cpp:
              (WebCore::InspectorClientQt::inspectorWindowObjectCleared):
              * WebCoreSupport/InspectorClientQt.h:
      
      WebKit/win:
      
      2009-07-29  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Darin Adler.
      
              Added foundation work to allow a testing infrastructure for the Web
              Inspector.
      
              * WebCoreSupport/WebInspectorClient.cpp:
              (WebInspectorClient::inspectorWindowObjectCleared): Empty definition
              to let Windows compile but we should implement this at some point so
              that the tests can be run on Windows too.
              * WebCoreSupport/WebInspectorClient.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      907d84c4
  13. 27 Jul, 2009 1 commit
  14. 11 Jul, 2009 1 commit
    • ddkilzer@apple.com's avatar
      Bug 27007: Build fixes when ICONDATABASE is disabled · 8c80d4f2
      ddkilzer@apple.com authored
              <https://bugs.webkit.org/show_bug.cgi?id=27007>
      
              Reviewed by Sam Weinig.
      
      WebCore:
      
              * WebCore.xcodeproj/project.pbxproj: Added IconDatabaseNone.cpp
              to the project.
              * loader/icon/IconDatabase.cpp: Added
              #if ENABLE(ICONDATABASE)/#endif macro guard.
              * loader/icon/IconDatabase.h: Removed three public methods from
              #if ENABLE(ICONDATABASE)/#endif macro so that they may be
              stubbed out in IconDatabaseNone.cpp.
              * loader/icon/IconDatabaseNone.cpp: Added
              #if !ENABLE(ICONDATABASE)/#endif macro guard.
              (WebCore::IconDatabase::importIconURLForPageURL): Added.
              (WebCore::IconDatabase::importIconDataForIconURL): Added.
              (WebCore::IconDatabase::shouldStopThreadActivity): Added.
      
      WebKit/mac:
      
              * Misc/WebIconDatabase.mm:
              (defaultClient): Return 0 if ICONDATABASE is disabled.
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchDidReceiveIcon): Commented out
              the body of the method if ICONDATABASE is disabled.
              (WebFrameLoaderClient::registerForIconNotification): Ditto.
              * WebCoreSupport/WebIconDatabaseClient.mm: Added #if
              ENABLE(ICONDATABASE)/#endif guard to source.
              * WebView/WebView.mm:
              (-[WebView setFrameLoadDelegate:]): Wrapped code that starts the
              icon database machinery in #if ENABLE(ICONDATABASE)/#endif.
              (-[WebView _registerForIconNotification:]): Wrapped method in
              #if ENABLE(ICONDATABASE)/#endif guard.
              (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Ditto.
              * WebView/WebViewInternal.h: Wrapped methods in #if
              ENABLE(ICONDATABASE)/#endif guard.
              (-[WebView _registerForIconNotification:]):
              (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c80d4f2
  15. 10 Jul, 2009 1 commit
    • simon.fraser@apple.com's avatar
      2009-07-10 Simon Fraser <simon.fraser@apple.com> · 7507c6a3
      simon.fraser@apple.com authored
              Reviewed by John Sullivan.
      
              Flashing as hardware layers are created and destroyed in some content
              <rdar://problem/7032246>
      
              There's a window of time between the end of one runloop cycle, after CA layers changes
              have been committed, and the window display at the start of the next cycle when
              CA may push updates to the screen before AppKit has drawn the view contents. If
              we know that we need to do drawing synchronization (which we do when content moves
              between a layer and the view), then we need to call -disableScreenUpdatesUntilFlush
              from the existing runloop observer that is set up when layers need repainting to
              ensure that layer updates don't reach the screen before view-based painting does.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView drawRect:]):
              Tweak the comments
      
              * WebView/WebView.mm:
              (viewUpdateRunLoopObserverCallBack):
              (-[WebView _scheduleViewUpdate]):
              Add a big comment to explain the timing of things.
              Call -disableScreenUpdatesUntilFlush when the view _needsOneShotDrawingSynchronization.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7507c6a3
  16. 09 Jul, 2009 2 commits
    • bdakin@apple.com's avatar
      WebCore: · 33a4d05b
      bdakin@apple.com authored
      2009-07-09  Beth Dakin and Jon Honeycutt <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix or make fixable:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::createPlugin):
              Changed to return PassRefPtr
              (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
              Ditto.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadSubframe):
              (WebCore::FrameLoader::loadPlugin):
              Make the widget variable a RefPtr. Use .get() when passing it to
              RenderPart::setWidget().
              (WebCore::FrameLoader::createJavaAppletWidget):
              Make the widget variable a RefPtr.
      
              * loader/FrameLoader.h:
              Changed the return type of createJavaAppletWidget().
      
              * loader/FrameLoaderClient.h:
              Change the return types of createPlugin() and 
              createJavaAppletWidget().
      
              * page/Frame.cpp:
              (WebCore::Frame::createView):
              No need to call .get() since setWidget() takes a RefPtr.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::layoutIfNeededRecursive):
              children() now returns a HashSet of RefPtrs.
      
              * page/FrameView.h:
              Remove inheritance from RefCounted; we pick this up from ScrollView
              through Widget.
      
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::addChild):
              addChild() now takes a PassRefPtr and m_children now keeps a 
              HashSet of RefPtrs.
      
              * platform/ScrollView.h:
              ScrollView constructor is now protected.
              (WebCore::ScrollView::children):
              m_children is now a HashSet of RefPtrs.
      
              * platform/Scrollbar.h:
              Remove inheritance from RefCounted; we pick this up from ScrollView
              through Widget.
      
              * platform/Widget.h:
              Inherit from RefCounted. Cleaned up some whitespace. Make m_widget 
              a RefPtr.
      
              * plugins/PluginView.cpp:
              (WebCore::PluginView::create):
              Adopt the PluginView when returning it.
      
              * plugins/PluginView.h:
              Changed create() to return a PassRefPtr.
      
              * rendering/RenderApplet.cpp:
              Receive result in a RefPtr when calling createJavaAppletWidget().
      
              * rendering/RenderPart.cpp:
              (WebCore::RenderPart::setWidget): 
              setWidget() now takes a PassRefPtr. Also removed the manual ref of 
              FrameViews. This is handled by having m_widget be a RefPtr. Removed 
              deleteWidget().
      
              * rendering/RenderPart.h:
              Removed override of deleteWidget().
      
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::destroy):
              (WebCore::RenderWidget::setWidget):
              (WebCore::RenderWidget::paint):
              (WebCore::RenderWidget::setOverlapTestResult):
              (WebCore::RenderWidget::updateWidgetPosition):
              Use .get().
              (WebCore::RenderWidget::clearWidget):
              Don't call deleteWidget(). It was removed. 
      
              * rendering/RenderWidget.h:
              Removed deleteWidget(). Made m_widget a RefPtr.
              (WebCore::RenderWidget::widget):
              Use .get().
      
      WebKit/gtk:
      
      2009-07-09  Beth Dakin and Jon Honeycutt <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::createPlugin):
              (WebKit::FrameLoaderClient::createJavaAppletWidget):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/mac:
      
      2009-07-09  Beth Dakin and Jon Honeycutt <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::createPlugin):
      
      WebKit/qt:
      
      2009-07-09  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::createPlugin):
              (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win:
      
      2009-07-09  Beth Dakin and Jon Honeycutt <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::createPlugin):
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebFrame.cpp:
              (WebFrame::createJavaAppletWidget):
              * WebFrame.h:
      
      WebKit/wx:
      
      2009-07-09  Beth Dakin and Jon Honeycutt <bdakin@apple.com>
      
              Reviewed by Dave Hyatt.
      
              Make Widget RefCounted to fix:
      
              <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 
              at WebCore::Widget::afterMouseDown() after clicking To Do's close 
              box
              <rdar://problem/6978804> WER #16: Repro Access Violation in 
              WebCore::PluginView::bindingInstance (1310178023)
              -and-
              <rdar://problem/6991251> WER #13: Crash in WebKit!
              WebCore::PluginView::performRequest+203 (1311461169) 
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::createPlugin):
              (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
              * WebKitSupport/FrameLoaderClientWx.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33a4d05b
    • weinig@apple.com's avatar
      WebKit/mac: · d5fc90a8
      weinig@apple.com authored
      2009-07-09  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Steve Falkenburg.
      
              Roll out r43848. The quirk is no longer necessary.
      
              * WebView/WebView.mm:
              (-[WebView WebCore::_userAgentForURL:WebCore::]):
      
      WebKit/win:
      
      2009-07-09  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Steve Falkenburg.
      
              Roll out r43848. The quirk is no longer necessary.
      
              * WebView.cpp:
              (WebView::userAgentForKURL):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5fc90a8
  17. 08 Jul, 2009 1 commit
    • bolsinga@apple.com's avatar
      WebCore: · 2c174ef2
      bolsinga@apple.com authored
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      WebCore:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Rename FrameLoader::userGestureHint() to FrameLoader::isProcessingUserGesture()
              for clarity.
      
              * WebCore.base.exp: Add WebCore::FrameLoader::isProcessingUserGesture()
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::processingUserGesture):
              * loader/FrameLoader.cpp: 
              (WebCore::FrameLoader::requestFrame):
              (WebCore::FrameLoader::isProcessingUserGesture):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
      2009-07-08  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin Adler.
      
              Add -[WebView _isProcessingUserGesture]
              https://bugs.webkit.org/show_bug.cgi?id=27084
      
              Add -_isProcessingUserGesture that calls into WebCore::FrameLoader::isProcessingUserGesture()
              so that WebView code can determine if a user gesture is in progress.
      
              * WebView/WebView.mm:
              (-[WebView _isProcessingUserGesture]):
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c174ef2
  18. 01 Jul, 2009 2 commits
    • beidson@apple.com's avatar
      WebCore: · b16bd43e
      beidson@apple.com authored
      2009-07-01  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Sam Weinig.
      
              Add a preference/setting to toggle whether content sniffing is enabled for file URLs.
      
              * WebCore.base.exp:
      
              * page/Settings.cpp:
              (WebCore::Settings::setLocalFileContentSniffingEnabled):
              * page/Settings.h:
              (WebCore::Settings::localFileContentSniffingEnabled):
      
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::ResourceHandle::start):
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
      
      WebKit/mac:
      
      2009-07-01  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Sam Weinig.
      
              Add a preference/setting to toggle whether content sniffing is enabled for file URLs.
      
              * WebView/WebPreferenceKeysPrivate.h:
      
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences localFileContentSniffingEnabled]):
              (-[WebPreferences setLocalFileContentSniffingEnabled:]):
              * WebView/WebPreferencesPrivate.h:
      
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b16bd43e
    • adele@apple.com's avatar
      2009-06-30 Adele Peterson <adele@apple.com> · 1a0bd629
      adele@apple.com authored
              Reviewed by Dan Bernstein.
      
              Fix for <rdar://problem/7014389> REGRESSION(4-TOT): Hyperlinks have no tooltips in Mail unless you first click in the message body
      
              Updated these new methods (added as part of the viewless WebKit effort) that call through to WebHTMLView to use _selectedOrMainFrame, 
              instead of just selectedFrame.  When the selection changes, I don't think there is a situation where there's no selected frame, but
              it seems better to keep these two uses the same, since if there is a case, this will be more like the old behavior, before there was
              a version of _selectionChanged in WebView. 
      
              * WebView/WebView.mm:
              (-[WebView _setToolTip:]):
              (-[WebView _selectionChanged]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a0bd629
  19. 30 Jun, 2009 1 commit
    • mitz@apple.com's avatar
      WebCore: · 43db8bfc
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/6946611> REGRESSION (r30673): Shade10:" D_Snap
                to Grid" window is clipping
      
              Added an app-specific quirk to revert the behavior of <link> elements
              to the way it was before r30673, namely that if the rel attribute
              is not "stylesheet" but the type attribute contains "text/css", the
              link behaves as a stylesheet link.
      
              * WebCore.base.exp: Exported setTreatsAnyTextCSSLinkAsStylesheet().
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::process): Check
                  Settings::treatsAnyTextCSSLinkAsStylesheet() and if true, allow a
                  style sheet link if the type contains "text/css".
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
                  Initialize m_treatsAnyTextCSSLinkAsStylesheet.
              (WebCore::Settings::setTreatsAnyTextCSSLinkAsStylesheet): Added.
              * page/Settings.h:
              (WebCore::Settings::treatsAnyTextCSSLinkAsStylesheet): Added.
      
      WebKit/mac:
      
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/6946611> REGRESSION (r30673): Shade10:" D_Snap
                to Grid" window is clipping
      
              * Misc/WebKitVersionChecks.h: Added
                  WEBKIT_FIRST_VERSION_WITHOUT_SHADE10_QUIRK
              * WebView/WebView.mm:
              (-[WebView _needsLinkElementTextCSSQuirk]): Added. Returns YES if the
                  client app is a version of Shade 10 earlier than 10.6 and it was
                  linked against a version of WebKit earlier than 531.2.
              (-[WebView _preferencesChangedNotification:]): Added a call to
                  Settings::setTreatsAnyTextCSSLinkAsStylesheet().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43db8bfc
  20. 25 Jun, 2009 1 commit
    • cmarrin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=26651 · 89072a08
      cmarrin@apple.com authored
              
              Preference is named "WebKitAcceleratedCompositingEnabled"
              and is a boolean value. When false, prevents compositing layers from
              being created, which prevents hardware animation from running.
              Also forces video to do software rendering. Added a cache for
              the flag in RenderLayerCompositing and made it all work
              on-the-fly when the flag is changed while a page is loaded.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89072a08
  21. 23 Jun, 2009 1 commit
    • beidson@apple.com's avatar
      2009-06-23 Brady Eidson <beidson@apple.com> · 3040ad0f
      beidson@apple.com authored
              Reviewed by Darin Adler.
      
              <rdar://problem/6950660> REGRESSION: iSale 5.5.3 crashes after I click a template to load
      
              Due to some subtle WebKit changes - presumably some delegate callback behavior - a latent bug in 
              iSale was uncovered where they aren't properly retaining their FrameLoadDelegate, and we ended up
              calling back to a dealloc'ed object.
      
              * WebView/WebView.mm:
              (-[WebView _needsAdobeFrameReloadingQuirk]): Use more intelligent C++-style initialization.
              (-[WebView _needsKeyboardEventDisambiguationQuirks]): Ditto.
              (-[WebView _needsFrameLoadDelegateRetainQuirk]): YES for iSale versions under 5.6
              (-[WebView dealloc]): Release the delegate if the quirk is in effect.
              (-[WebView setFrameLoadDelegate:]): Retain the new delegate if the quirk is in effect.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3040ad0f
  22. 22 Jun, 2009 2 commits
  23. 19 Jun, 2009 1 commit
    • abarth@webkit.org's avatar
      WebCore: · 33c12c69
      abarth@webkit.org authored
      2009-06-18  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=26199
      
              Added an experimental reflective XSS filter.  The filter is disabled by
              default.
      
              Test: http/tests/security/xssAuditor/script-tag.html
      
              * GNUmakefile.am:
              * WebCore.base.exp:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::ScriptController):
              (WebCore::ScriptController::evaluate):
              * bindings/js/ScriptController.h:
              (WebCore::ScriptController::xssAuditor):
              * bindings/js/ScriptEventListener.cpp:
              (WebCore::createAttributeEventListener):
              * dom/Tokenizer.h:
              (WebCore::Tokenizer::xssAuditor):
              (WebCore::Tokenizer::setXSSAuditor):
              (WebCore::Tokenizer::Tokenizer):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::scriptHandler):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::begin):
              (WebCore::FrameLoader::requestObject):
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setXSSAuditorEnabled):
              * page/Settings.h:
              (WebCore::Settings::xssAuditorEnabled):
              * page/XSSAuditor.cpp: Added.
              (WebCore::isControlCharacter):
              (WebCore::XSSAuditor::XSSAuditor):
              (WebCore::XSSAuditor::~XSSAuditor):
              (WebCore::XSSAuditor::canEvaluate):
              (WebCore::XSSAuditor::canCreateInlineEventListener):
              (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
              (WebCore::XSSAuditor::canLoadObject):
              (WebCore::XSSAuditor::decodeURL):
              (WebCore::XSSAuditor::findInRequest):
              * page/XSSAuditor.h: Added.
              (WebCore::XSSAuditor::isEnabled):
              (WebCore::XSSAuditor::setXSSAuditorEnabled):
      
      WebKit/mac:
      
      2009-06-18  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=26199
      
              Added preference to enable the XSSAuditor.
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              (-[WebPreferences isXSSAuditorEnabled]):
              (-[WebPreferences setXSSAuditorEnabled:]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      
      WebKit/win:
      
      2009-06-18  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=26199
      
              Added preference to enable the XSSAuditor.
      
              * Interfaces/IWebPreferencesPrivate.idl:
              * WebPreferenceKeysPrivate.h:
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings):
              (WebPreferences::isXSSAuditorEnabled):
              (WebPreferences::setXSSAuditorEnabled):
              * WebPreferences.h:
              * WebView.cpp:
              (WebView::notifyPreferencesChanged):
      
      WebKitTools:
      
      2009-06-18  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=26199
      
              Add support for testing the XSSAuditor.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setXSSAuditorEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setXSSAuditorEnabled):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetWebViewToConsistentStateBeforeTesting):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setXSSAuditorEnabled):
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetWebViewToConsistentStateBeforeTesting):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setXSSAuditorEnabled):
              (LayoutTestController::setPopupBlockingEnabled):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setXSSAuditorEnabled):
      
      LayoutTests:
      
      2009-06-18  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=26199
      
              Added a basic test for the XSSAuditor.
      
              * http/tests/security/xssAuditor/resources/echo-intertag.php: Added.
              * http/tests/security/xssAuditor/script-tag-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33c12c69
  24. 13 Jun, 2009 1 commit
    • abarth@webkit.org's avatar
      WebCore: · 116c0883
      abarth@webkit.org authored
      2009-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24492
      
              Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from
              FrameLoader to SecurityOrigin.
      
              * WebCore.base.exp:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadFrameRequest):
              (WebCore::FrameLoader::canLoad):
              * loader/FrameLoader.h:
              * page/SecurityOrigin.cpp:
              (WebCore::localSchemes):
              (WebCore::noAccessSchemes):
              (WebCore::SecurityOrigin::SecurityOrigin):
              (WebCore::SecurityOrigin::isLocal):
              (WebCore::SecurityOrigin::registerURLSchemeAsLocal):
              (WebCore::SecurityOrigin::shouldTreatURLAsLocal):
              (WebCore::SecurityOrigin::shouldTreatURLSchemeAsLocal):
              (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess):
              (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
              * page/SecurityOrigin.h:
      
      WebKit/mac:
      
      2009-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24492
      
              Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin
      
              * WebView/WebView.mm:
              (+[WebView registerURLSchemeAsLocal:]):
      
      WebKit/qt:
      
      2009-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24492
      
              Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.
      
              * Api/qwebpage.cpp:
              (QWebPage::acceptNavigationRequest):
      
      WebKit/win:
      
      2009-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24492
      
              Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.
      
              * WebView.cpp:
              (WebView::registerURLSchemeAsLocal):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      116c0883
  25. 05 Jun, 2009 1 commit
  26. 04 Jun, 2009 3 commits
    • weinig@apple.com's avatar
      WebKit: · 7245ca7c
      weinig@apple.com authored
      2009-06-04  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Alice Liu.
      
              Move WebView internal data into WebViewData.h/mm.
      
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac:
      
      2009-06-04  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Alice Liu.
      
              Move WebView internal data into WebViewData.h/mm.
      
              * WebView/WebDelegateImplementationCaching.mm:
              * WebView/WebView.mm:
              * WebView/WebViewData.h: Copied from mac/WebView/WebViewInternal.h.
              * WebView/WebViewData.mm: Copied from mac/WebView/WebViewInternal.mm.
              * WebView/WebViewInternal.h:
              * WebView/WebViewInternal.mm: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7245ca7c
    • hyatt@apple.com's avatar
      WebCore: · 94c51658
      hyatt@apple.com authored
      2009-06-04  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Sam Weinig.
      
              Move DOM window focus/blur out of SelectionController and into FocusController.  Make sure it
              fires on the focused frame when the page activation state changes also.  This is covered by an existing
              layout test (albeit badly).  I have modified the test to be correct.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setFocused):
              * page/FocusController.cpp:
              (WebCore::FocusController::setFocusedFrame):
              (WebCore::FocusController::setActive):
      
      WebKit/mac:
      
      2009-06-04  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Sam Weinig.
      
              Remove _updateFocusedStateForFrame, since it's actually not even necessary now that I made
              setFocusedFrame get called explicitly from become/ResignFirstResponder.  setFocusedFrame does
              the work of focusing the selection already.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::transitionToCommittedForNewPage):
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView becomeFirstResponder]):
              (-[WebHTMLView resignFirstResponder]):
              * WebView/WebView.mm:
              * WebView/WebViewInternal.h:
      
      LayoutTests:
      
      2009-06-04  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Sam Weinig.
      
              Fix the Window focus test to not resign first responder, since that actually made the test
              incorrect.  An unfocused WebHTMLView's DOM window should not receive focus/blur events when the activation
              changes.
      
              Now the test just checks that a first responder WebHTMLView will actually fire focus/blur on the DOM window
              as the window gains/loses key.
      
              * fast/dom/Window/window-onFocus.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94c51658
    • hyatt@apple.com's avatar
      WebCore: · d4bc96cc
      hyatt@apple.com authored
      2009-06-03  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Sam Weinig.
      
              Improvements in how selection behaves with focus/activation and a reversion back to using isActive
              in the scrollbar theme code to remove a Chromium ifdef.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::SelectionController):
              Make the controller set its focused state correctly upon initial creation.
      
              (WebCore::SelectionController::setSelection):
              Make selection willing to shift the focus node if the selection is focused even if the
              selection is not active.  Whether or not the Page is active is irrelevant to focus changes.
      
              (WebCore::SelectionController::setFocused):
              * editing/SelectionController.h:
              (WebCore::SelectionController::isFocused):
              Add a new isFocused() method so that code can check if the Selection is focused without caring
              about the active state.
      
              * page/Frame.cpp:
              (WebCore::Frame::setFocusedNodeIfNeeded):
              Allow focus shifts even when the selection is not active.
      
              * platform/mac/ScrollbarThemeMac.mm:
              (WebCore::ScrollbarThemeMac::paint):
              Revert Dan's change to directly talk to AppKit for checking active state.  Now that the WebCore isActive
              method works, ditch the Chromium-specific #ifdef and go back to the original code.
      
      WebKit/mac:
      
      2009-06-03  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Sam Weinig.
      
              Reworking of focus and active state updating for WebHTMLViews so that it actually works instead of reporting wrong answers.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::transitionToCommittedForNewPage):
              WebHTMLViews become first responders before they are able to reach their Frames/Pages.  This happens because the NSClipView
              becomes first responder when the WebHTMLView gets destroyed, and then we transfer the responder state back to the new WebHTMLView
              when it is first connected.  Once we have transitioned to a new page and have the Frame/Page available, go ahead and explicitly
              focus the frame in WebCore and update our focused state.  This change allows us to remove the updateFocusedActive timer and the
              code from viewDidMoveToWindow.
              
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView close]):
              (-[WebHTMLView addWindowObservers]):
              (-[WebHTMLView viewWillMoveToWindow:]):
              (-[WebHTMLView viewDidMoveToWindow]):
              (-[WebHTMLView _removeWindowObservers]):
              Remove all the updateFocusedActiveState timer code, since it no longer exists.
      
              (-[WebHTMLView windowDidBecomeKey:]):
              (-[WebHTMLView windowDidResignKey:]):
              Active state updating is no longer done by WebHTMLViews.   It is handled by the WebView instead.
          
              (-[WebHTMLView becomeFirstResponder]):
              (-[WebHTMLView resignFirstResponder]):
              Reworking of WebHTMLView's code for gaining/losing responder status.  No longer update active state here, since the active state
              can never change just because of responder changes.  Make sure that the focused frame gets updated properly (and most importantly
              actually cleared when a WebHTMLView resigns responder status).
      
              * WebView/WebHTMLViewInternal.h:
              * WebView/WebHTMLViewPrivate.h:
              State updating for focused and active states has been made independent.
      
              * WebView/WebView.mm:
              (-[WebView _updateActiveState]):
              WebView now handles updating of active state in _updateActiveState.  It is now purely based off whether the window is key and nothing
              else.
      
              (-[WebView addWindowObserversForWindow:]):
              (-[WebView removeWindowObservers]):
              Start listening for the window becoming/losing key even in the usesDocumentViews case.
      
              (-[WebView _updateFocusedStateForFrame:]):
              Focused state updating is split into its own method now and called when WebHTMLViews gain and lose responder status.
      
              (-[WebView _windowDidBecomeKey:]):
              (-[WebView _windowDidResignKey:]):
              Make sure to call _updateActiveState as the window gains/loses key.
      
              (-[WebView _windowWillOrderOnScreen:]):
              Run this code now that WebHTMLView no longer does it.
      
              * WebView/WebViewInternal.h:
              * WebView/WebViewPrivate.h:
              Updating for the split of focused and active state updating into separate methods.
      
      WebKitTools:
      
      2009-06-03  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Sam Weinig.
      
              * DumpRenderTree/mac/FrameLoadDelegate.mm:
              (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setMainFrameIsFirstResponder):
              Remove explicit calls to _updateFocusedActiveState when the view is made first responder.
              Focused state already properly updates when views become first responders, so these calls
              are unnecessary.
      
              (LayoutTestController::setWindowIsKey):
              Explicitly call _updateActiveState when our window becomes key, since we're just faking it
              and the notification won't be sent.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4bc96cc
  27. 03 Jun, 2009 6 commits
    • weinig@apple.com's avatar
      WebKit: · bcc82b6a
      weinig@apple.com authored
      2009-06-03  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Mark Rowe.
      
              Added WebDelegateImplementationCaching.h/mm
      
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac:
      
      2009-06-03  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Mark Rowe.
      
              Move delegate implementation caching logic into its own files.
      
              * WebView/WebDelegateImplementationCaching.h: Copied from mac/WebView/WebViewInternal.h.
              * WebView/WebDelegateImplementationCaching.mm: Copied from mac/WebView/WebView.mm.
              (WebViewGetResourceLoadDelegateImplementations):
              (WebViewGetFrameLoadDelegateImplementations):
              (WebViewGetScriptDebugDelegateImplementations):
              * WebView/WebView.mm:
              * WebView/WebViewInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcc82b6a
    • weinig@apple.com's avatar
      WebKit: · 07925675
      weinig@apple.com authored
      2009-06-03  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Mark Rowe.
      
              Add WebViewInternal.mm.
      
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac:
      
      2009-06-03  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Mark Rowe.
      
              Move WebViewPrivate structure to WebViewInternal.h/mm.
      
              * WebView/WebView.mm:
              * WebView/WebViewInternal.h:
              * WebView/WebViewInternal.mm: Added.
              (+[WebViewPrivate initialize]):
              (-[WebViewPrivate init]):
              (-[WebViewPrivate dealloc]):
              (-[WebViewPrivate finalize]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07925675
    • weinig@apple.com's avatar
      2009-06-03 Sam Weinig <sam@webkit.org> · f3391e5a
      weinig@apple.com authored
              Reviewed by Darin Adler.
      
              Small cleanup in WebView.
              - Move global data initialization to WebView's initialization method.
              - Move _clearViewUpdateRunLoopObserver from WebViewPrivate to WebView (FileInternal)
      
              * WebView/WebView.mm:
              (-[WebViewPrivate init]): Remove global initializers.
              (-[WebViewPrivate dealloc]): Cleanup whitespace.
              (-[WebViewPrivate finalize]): Ditto.
              (-[WebView _close]): Call [self _clearViewUpdateRunLoopObserver] instead of
              [_private _clearViewUpdateRunLoopObserver]
              (+[WebView initialize]): Move global initializers here.
              (-[WebView _clearViewUpdateRunLoopObserver]): Moved from WebViewPrivate.
              (viewUpdateRunLoopObserverCallBack): Call [self _clearViewUpdateRunLoopObserver]
              instead of [_private _clearViewUpdateRunLoopObserver]
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3391e5a
    • mitz@apple.com's avatar
      WebCore: · 1fa9548a
      mitz@apple.com authored
              Reviewed by Anders Carlsson.
      
              - eliminate WebCoreTextRenderer
      
              * WebCore.base.exp: Updated.
              * WebCore.xcodeproj/project.pbxproj: Removed WebCoreTextRenderer.{h,mm}
                  and promoted WebFontCache.h to private.
              * platform/graphics/Font.cpp:
              (WebCore::Font::setShouldUseSmoothing): Added this static setter for
                  a new file-static boolean.
              (WebCore::Font::shouldUseSmoothing): Added this static getter.
              * platform/graphics/Font.h: Decleared setShouldUseSmoothing() and
                  shouldUseSmoothing().
              * platform/graphics/mac/FontMac.mm:
              (WebCore::Font::drawGlyphs): Use Font::shouldUseSmoothing() instead of
              WebCoreShouldUseFontSmoothing().
              * platform/graphics/mac/WebLayer.mm: Removed unneeded #import.
              * platform/mac/WebCoreTextRenderer.h: Removed.
              * platform/mac/WebCoreTextRenderer.mm: Removed.
      
      WebKit:
      
              Reviewed by Anders Carlsson.
      
              - WebKit project part of eliminating WebCoreTextRenderer
      
              * WebKit.xcodeproj/project.pbxproj: Changed WebKitNSStringExtras.m to
                  compile as Objective-C++.
      
      WebKit/mac:
      
              Reviewed by Anders Carlsson.
      
              - WebKit part of eliminating WebCoreTextRenderer
      
              * Misc/WebKitNSStringExtras.m:
              (webkit_CGCeiling): Added.
              (-[NSString _web_drawAtPoint:font:textColor:]): Replaced the malloc()ed
                  string buffer with a Vector. Moved code from
                  WebCoreDrawTextAtPoint() to here.
              (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]):
              (-[NSString _web_widthWithFont:]): Replaced the malloc()ed string buffer
                  with a Vector. Moved code from WebCoreTextFloatWidth() to here.
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _addToStyle:fontA:fontB:]): Replaced call to
                  WebCoreFindFont() with use of
                  +[WebFontCache fontWithFamily:traits:weight:size:].
              * WebView/WebView.mm:
              (+[WebView _setAlwaysUsesComplexTextCodePath:]): Changed to call
                  Font::setCodePath() directly.
              (+[WebView _setShouldUseFontSmoothing:]): Changed to call
                  Font::setShouldUseSmoothing().
              (+[WebView _shouldUseFontSmoothing]): Changed to call 
                  Font::shouldUseSmoothing().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fa9548a
    • mitz@apple.com's avatar
      Rubber-stamped by Mark Rowe. · cae9ba6a
      mitz@apple.com authored
              - remove a private method that was used only by Safari 3.0.
      
              * WebView/WebView.mm: Removed +_minimumRequiredSafariBuildNumber.
              * WebView/WebViewPrivate.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cae9ba6a
    • mitz@apple.com's avatar
      Reviewed by Anders Carlsson. · 90bf758c
      mitz@apple.com authored
              - build fix
      
              * WebView/WebHTMLView.mm:
              * WebView/WebView.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90bf758c