- 27 May, 2010 40 commits
-
-
bdakin@apple.com authored
Reviewed by Simon Fraser. * WebView/WebHTMLView.mm: (-[WebHTMLView viewDidMoveToWindow]): (-[WebHTMLView attachRootLayer:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. Add v8 bindings for async DB API in workers https://bugs.webkit.org/show_bug.cgi?id=39145 No new tests. This should share layout tests with JSC. Tweak the callback generation to switch lots of Frame* to ScriptExecutionContext*, and use the context passed in to handleEvent where possible. * bindings/scripts/CodeGeneratorV8.pm: As with CodeGeneratorV8; these are pretty much all tiny tweaks. We do have to use a slightly different patch for callback invocation in invokeCallback, as V8Proxy::retrieve() doesn't work in the worker context. * bindings/v8/custom/V8CustomPositionCallback.cpp: (WebCore::V8CustomPositionCallback::handleEvent): * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: (WebCore::V8CustomPositionErrorCallback::handleEvent): * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8SQLStatementErrorCallback::handleEvent): * bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::V8CustomVoidCallback::V8CustomVoidCallback): (WebCore::V8CustomVoidCallback::handleEvent): (WebCore::invokeCallback): * bindings/v8/custom/V8CustomVoidCallback.h: (WebCore::V8CustomVoidCallback::create): * bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openDatabaseCallback): * bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::V8Database::changeVersionCallback): (WebCore::createTransaction): * bindings/v8/custom/V8DatabaseSyncCustom.cpp: (WebCore::V8DatabaseSync::changeVersionCallback): (WebCore::createTransaction): * bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::requestPermissionCallback): * bindings/v8/custom/V8SQLTransactionCustom.cpp: (WebCore::V8SQLTransaction::executeSqlCallback): Add openDatabaseCallback. * bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::V8WorkerContext::openDatabaseCallback): Remove an obsolete parameter. (WebCore::V8WorkerContext::openDatabaseSyncCallback): 2010-05-27 Eric Uhrhane <ericu@chromium.org> Reviewed by Adam Barth. Add v8 bindings for async DB API in workers https://bugs.webkit.org/show_bug.cgi?id=39145 * src/DatabaseObserver.cpp: We should check that we're on the context thread now, not the main thread. (WebCore::DatabaseObserver::databaseOpened): (WebCore::DatabaseObserver::databaseModified): (WebCore::DatabaseObserver::databaseClosed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
Reviewed by Kent Tamura. Null characters handled incorrectly in ToNumber conversion https://bugs.webkit.org/show_bug.cgi?id=38088 * runtime/JSGlobalObjectFunctions.cpp: (JSC::parseInt): Changed code to use UTF8String().data() instead of ascii() to fix the thread safety issue. Code path is covered by existing tests in run-javascriptcore-tests. (JSC::parseFloat): Moved comment to UString::toDouble since the issue affects all clients, not just parseFloat. Specifically, this also affects standard JavaScript numeric conversion, ToNumber. * runtime/UString.cpp: (JSC::UString::toDouble): Added a comment about incorrect space skipping. Changed trailing junk check to use the length of the CString instead of checking for a null character. Also got rid of a little unneeded logic in the case where we tolerate trailing junk. 2010-05-26 Darin Adler <darin@apple.com> Reviewed by Kent Tamura. Null characters handled incorrectly in ToNumber conversion https://bugs.webkit.org/show_bug.cgi?id=38088 * fast/js/ToNumber-expected.txt: Updated for new tests and to expect PASS for two null character tests. * fast/js/ToNumber.js: Added more test cases. * fast/js/parseFloat-expected.txt: Updated for new test case. * fast/js/script-tests/parseFloat.js: Added a test case. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Yury Semikhatsky. Web Inspector: [REGRESSION] Query parameters are not displayed in the resources headers section. https://bugs.webkit.org/show_bug.cgi?id=39848 * inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._refreshRequestPayload): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Eric Seidel https://bugs.webkit.org/show_bug.cgi?id=39092 Add Yank support to chromium mac. Do this by moving WebKit Mac's implementation of Editor::yankFromKillRing() into its own class and then using that. * editing/Editor.cpp: Use new KillRing class. * editing/Editor.h: (WebCore::Editor::killRing): Use new KillRing class. * editing/EditorCommand.cpp: (WebCore::executeYankAndSelect): Use new KillRing class. * platform/KillRing.h: Add new KillRing class, which acts as null object. (WebCore::KillRing::~KillRing): * platform/mac/KillRingMac.h: Add new KillRingMac class, which writes to the mac's kill ring. * platform/mac/KillRingMac.mm: Add new KillRingMac class, which writes to the mac's kill ring. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60326 268f45cc-cd09-...
-
eric@webkit.org authored
Reviewed by Jian Li. Build break in FileStream.cpp https://bugs.webkit.org/show_bug.cgi?id=39841 When ENABLE_BLOB_SLICE is not defined, an undefined variable is used in FileStream.cpp:114. Fix by using the correct variable. Build fix so no new tests. * html/FileStream.cpp: (WebCore::FileStream::openForRead): Replace undefined variable with a defined one. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Jeremy Orlow. [Chromium] Default popup window size should not depend on zoom level https://bugs.webkit.org/show_bug.cgi?id=39835 V8DOMWindow::openCallback should not set width and height of new window unless specified in the function's arguments. There is already code to reset the new window's origin coordinates, but the same thing should be done to its dimensions as well. Otherwise, a new popup with unspecified size will have its size depending on the parent's zoom level, which is not desirable. This is the same as what is done in bindings/js/JSDOMWindowCustom.cpp:826. * bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openCallback): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Geoffrey Garen. Search for the new allocation one word at a time. Improves performance on SunSpider by approximately 1%. http://bugs.webkit.org/show_bug.cgi?id=39758 * runtime/Collector.cpp: (JSC::Heap::allocate): * runtime/Collector.h: (JSC::CollectorBitmap::advanceToNextPossibleFreeCell): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. qt_instance.cpp has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=39744 Fix webkit coding style issues in qt_instance.cpp * bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getQtInstance): (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate): (JSC::Bindings::QtInstance::getPropertyNames): (JSC::Bindings::QtInstance::stringValue): (JSC::Bindings::QtField::name): (JSC::Bindings::QtField::valueFromInstance): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jparent@chromium.org authored
Update Chromium expectations for runner.html after r60278. * platform/chromium-mac/html5lib/runner-expected.txt: * platform/chromium-win/html5lib/runner-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. qt_instance.h has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=39743 Fix webkit coding style issues in qt_instance.h * bridge/qt/qt_instance.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. qt_class.h has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=39742 Fix webkit coding style issues in qt_class.h * bridge/qt/qt_class.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric.carlson@apple.com authored
Reviewed by Darin Adler. <rdar://problem/8016158> Crash in CVPixelBufferCreateResolvedAttributesDictionary with RLE compressed movie. Configure the visual context to generate Direct3D compatible pixel buffers when we are able to use a CAImageQueue so there will be less conversion required before display. This change also works around the issue that causes the RLE compressed movie to crash. * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): Pass enum to QTMovieVisualContext constructor instead of CFDictionary. * platform/graphics/win/QTMovieVisualContext.cpp: (SetNumberValue): (getPixelBufferCreationOptions): New, create options dictionary appropriate for the visual context type. (pixelBufferCreationOptions): New, return options dictionary appropriate for the visual context type. (QTMovieVisualContextPriv::QTMovieVisualContextPriv): Get the options dictionary from getPixelBufferCreationOptions insteaad of taking it as a parameter. (QTMovieVisualContext::QTMovieVisualContext): Take enum instead of CFDictionary for visual context configuration type. * platform/graphics/win/QTMovieVisualContext.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Adam Roben. [Qt] REGRESSION(r60258): It broke 10 tests. https://bugs.webkit.org/show_bug.cgi?id=39819 * plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins): Append the MimeClassInfo object after it's been initialized. 2010-05-27 Anders Carlsson <andersca@apple.com> Reviewed by Adam Roben. [Qt] REGRESSION(r60258): It broke 10 tests. https://bugs.webkit.org/show_bug.cgi?id=39819 Remove tests from the skipped list. * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kevino@webkit.org authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=39852ap@apple.com authored
[Qt] fast/encoding/yentest.html fails * platform/Qt/Skipped: Disabling the new tests for backslash transcoding. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Update documentation control files, and fix Since tags for 1.3.1. * docs/webkitgtk-docs.sgml: * docs/webkitgtk-sections.txt: * webkit/webkitwebbackforwardlist.cpp: * webkit/webkitwebview.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Final make distcheck fix - clean up generated GDOM files on distclean. * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=39606 Land tests for <rdar://problem/3277733>: \ in JavaScript mishandled when encoding is Japanese * fast/encoding/resources/yentestexternal.js: Added. * fast/encoding/resources/yentestexternal2.js: Added. * fast/encoding/yentest-expected.txt: Added. * fast/encoding/yentest.html: Added. * fast/encoding/yentest2-expected.txt: Added. * fast/encoding/yentest2.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
Bug 39324 - AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameter$ https://bugs.webkit.org/show_bug.cgi?id=39324 No review, build fixage. Rolling out change from r60307 until a better fix is ready. * accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. [v8] Web Inspector: check that ScriptDebugListener was not removed while messages were dispatched in the nested loop. https://bugs.webkit.org/show_bug.cgi?id=39838 * bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::handleV8DebugEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. [v8] Web Inspector: undefined script URL value should be converted to an emtpy WebCore::String instead of "undefined" string. Otherwise it's shown in the Scripts panel with "undefined:<line no>" URL. https://bugs.webkit.org/show_bug.cgi?id=39845 * bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameterized attribute that it doesn't handle. https://bugs.webkit.org/show_bug.cgi?id=39324 Reviewed by Darin Adler. Make sure that accessibilityAttributeValue:forParameter: will default to its super's implementation. This is how AppKit expects objects to behave. * accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
More GTK+ distcheck fixes. * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Reviewed by Gustavo Noronha. Bump for 1.3.1 release. * configure.ac: WebKit/gtk: 2010-05-27 Xan Lopez <xlopez@igalia.com> Reviewed by Gustavo Noronha. Update for 1.3.1 release. * NEWS: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
More build fixage for make dist. * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Resume script execution if user tries to navigate to another URL https://bugs.webkit.org/show_bug.cgi?id=39842 * src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::didNavigate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. [v8] Web Inspector: notify ScriptDebugListener when execution is resumed https://bugs.webkit.org/show_bug.cgi?id=39838 * bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::handleV8DebugEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Ojan Vafai. Mark some SVG tests as flaky on Windows https://bugs.webkit.org/show_bug.cgi?id=39790 The following SVG tests have been failing intermittently on the chromium console for the past 2+ days. - svg/clip-path/clip-path-childs-clipped.svg - svg/clip-path/clip-path-evenodd-nonzero.svg - svg/clip-path/clip-path-text-and-shape.svg - svg/text/text-text-04-t.svg - svg/text/text-text-05-t.svg * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. qt_pixmapruntime.cpp has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=39745 Fix webkit coding style issues in qt_pixmapruntime.cpp * bridge/qt/qt_pixmapruntime.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Reviewed by Steve Block. Clean up IndexedDB layout tests https://bugs.webkit.org/show_bug.cgi?id=39748 Split basics.js into a common library plus 2 other tests. This will make it easier to ensure good test coverage as we go forward without too much cut and paste coding. For the most part, each IndexedDB idl file should have its own test in the future (at a minimum). Also switching the 'description' portion of the test expectation to reflect the build fix from last night (which breaks the feature). * storage/indexeddb/basics-expected.txt: Removed. * storage/indexeddb/basics.html: Removed. * storage/indexeddb/idb-database-request-expected.txt: Added. * storage/indexeddb/idb-database-request.html: Added. * storage/indexeddb/indexed-database-request-expected.txt: Added. * storage/indexeddb/indexed-database-request.html: Added. * storage/indexeddb/resources/shared.js: Added. (init): (done): (verifyEventCommon): (verifyErrorEvent): (verifySuccessEvent): (verifyResult): (unexpectedErrorCallback): * storage/indexeddb/script-tests/TEMPLATE.html: * storage/indexeddb/script-tests/basics.js: Removed. * storage/indexeddb/script-tests/idb-database-request.js: Added. (openSuccess): (test): * storage/indexeddb/script-tests/indexed-database-request.js: Added. (openCallback): (test): 2010-05-26 Jeremy Orlow <jorlow@chromium.org> Reviewed by Steve Block. Clean up IndexedDB layout tests https://bugs.webkit.org/show_bug.cgi?id=39748 Remove an assert that always fires. Tests: storage/indexeddb/idb-database-request.html storage/indexeddb/indexed-database-request.html * storage/IDBDatabaseImpl.cpp: (WebCore::IDBDatabaseImpl::objectStores): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Reviewed by Xan Lopez. Build fix for introspection support - make sure DOM headers are included by the GI scanner. * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: Get CSS rule offsets lazily. https://bugs.webkit.org/show_bug.cgi?id=39832 * inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::getStartEndOffsets): * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForRule): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. qt_class.cpp has coding-style errors https://bugs.webkit.org/show_bug.cgi?id=39741 Fix webkit coding style issues in qt_class.cpp * bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fieldNamed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Brady Eidson. New Layout test for the history.pushState function. The test checks if history.length property is correct after a few pushState calls. history.pushState doesn't work for the first page in a window. https://bugs.webkit.org/show_bug.cgi?id=39418 * fast/loader/stateobjects/pushstate-without-history-expected.txt: Added. * fast/loader/stateobjects/pushstate-without-history.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Darin Adler. RVCT does not have strnstr. https://bugs.webkit.org/show_bug.cgi?id=39719 Add COMPILER(RVCT) guard to strnstr in StringExtras.h as RVCT does not provide strnstr. * wtf/StringExtras.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Reviewed by Shinichiro Hamaji. check-webkit-style complains about use of NULL in GTK function calls that require sentinels https://bugs.webkit.org/show_bug.cgi?id=39372 Don't warn about NULL in g_*() calls. Zero can't be used instead for calls like g_build_filename and g_object_get/set. * Scripts/webkitpy/style/checkers/cpp.py: * Scripts/webkitpy/style/checkers/cpp_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Darin Adler. Remove bit-rotten INSTRUMENT_LAYOUT_SCHEDULING code from HTMLTokenizer https://bugs.webkit.org/show_bug.cgi?id=39714 This came from a discussion on #webkit with Hyatt about this code being old and no longer used to either of our knowledge. No functional changes, thus no tests. I also removed a bogus FIXME I had added in an earlier patch before I understood what the HTMLTokenizer was trying to do. * html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::continueProcessing): (WebCore::HTMLTokenizer::willWriteHTML): (WebCore::HTMLTokenizer::didWriteHTML): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. Add callbacks to ScriptController to allow notifications on named items additions and removals https://bugs.webkit.org/show_bug.cgi?id=39679 * bindings/js/ScriptController.h: Callbacks with empty implementation added. (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved): * bindings/v8/ScriptController.cpp: Empty implementation of callbacks. (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved): * bindings/v8/ScriptController.h: Callbacks added. * html/HTMLDocument.cpp: Hooking in callbacks. (WebCore::HTMLDocument::addItemToMap): (WebCore::HTMLDocument::removeItemFromMap): * html/HTMLDocument.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Dimitri Glazkov. Implement lazy clearing of renderbuffers https://bugs.webkit.org/show_bug.cgi?id=36248 * fast/canvas/webgl/renderbuffer-initialization-expected.txt: Added. * fast/canvas/webgl/renderbuffer-initialization.html: Added. 2010-05-27 Zhenyao Mo <zmo@google.com> Reviewed by Dimitri Glazkov. Implement lazy clearing of renderbuffers https://bugs.webkit.org/show_bug.cgi?id=36248 Test: fast/canvas/webgl/renderbuffer-initialization.html * html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::WebGLFramebuffer): Init added members. (WebCore::WebGLFramebuffer::setAttachment): Set attachment object. (WebCore::WebGLFramebuffer::onBind): Perform buffer clearing if needed. (WebCore::WebGLFramebuffer::onAttachedObjectChange): Ditto. (WebCore::WebGLFramebuffer::isUninitialized): Check whether an attached object is uninitialized renderbuffer. (WebCore::WebGLFramebuffer::setInitialized): After initialize a renderbuffer, set the flag. (WebCore::WebGLFramebuffer::initializeRenderbuffers): Clear un-initialized renderbuffers if framebuffer is complete. * html/canvas/WebGLFramebuffer.h: (WebCore::WebGLFramebuffer::isDepthAttached): Changed to check object. (WebCore::WebGLFramebuffer::isStencilAttached): Ditto. (WebCore::WebGLFramebuffer::isDepthStencilAttached): Ditto. * html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::WebGLRenderbuffer): Init added members. * html/canvas/WebGLRenderbuffer.h: (WebCore::WebGLRenderbuffer::isInitialized): As the function name. (WebCore::WebGLRenderbuffer::setInitialized): Ditto. * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bindFramebuffer): Call onBind(). (WebCore::WebGLRenderingContext::copyTexImage2D): Call onAttachedObjectChange(). (WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::deleteTexture): Ditto. (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Call setAttachment. (WebCore::WebGLRenderingContext::framebufferTexture2D): Call onAttachedObjectChange(). (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. * platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::reshape): Initialize internal buffers. 2010-05-27 Zhenyao Mo <zmo@google.com> Reviewed by Dimitri Glazkov. Implement lazy clearing of renderbuffers https://bugs.webkit.org/show_bug.cgi?id=36248 * src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::reshape): Clear WebGL internal buffers. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-