1. 21 Mar, 2013 40 commits
    • mkwst@chromium.org's avatar
      Drop full URLs from cross-origin access errors caused by protocol mismatches. · 18b6035c
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112894
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Following up on http://wkbug.com/112813, this patch brings protocol
      mismatch errors into line with the new origin-only hotness. The message
      is also changed to display the URL's protocol rather than the origin's
      protocol: it makes a big difference for 'data:' URLs, for instance.
      
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::crossDomainAccessErrorMessage):
      
      LayoutTests:
      
      * http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
      * http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
      * http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
      * http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
      * http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
      * http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
      * http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
      * http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
      * http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
      * http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt:
      * http/tests/security/cross-frame-access-protocol-expected.txt:
      * http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
      * http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
      * http/tests/security/view-source-no-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
      * http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
      * http/tests/security/xssAuditor/full-block-base-href-expected.txt:
      * http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
      * http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
      * http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
      * http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
      * http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
      * http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
      * platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
      * platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
      * platform/chromium/http/tests/security/window-named-proto-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18b6035c
    • schenney@chromium.org's avatar
      SVG text path referencing parent text infinite loops · 6f1de057
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112078
      
      Reviewed by Philip Rogers.
      
      Source/WebCore:
      
      We do not check the target type when adding a resource reference for
      SVG Text Path's URI. This goes horribly wrong when the target is the
      text path's parent text element. In this patch we check that the target
      element of the text path is indeed a path element, as the spec
      requires. No other element type is allowed.
      
      Note that RenderSVGTextPath enforces this check in the renderer code
      also, so if we get past this check via pending resources, it doesn't
      matter. You can't get into this situation with a pending reference
      because, by definition, the parent must be defined before the text
      path child.
      
      Test: svg/text/textpath-referencing-text-crash.svg
      
      * svg/SVGTextPathElement.cpp:
      (WebCore::SVGTextPathElement::buildPendingResource):
      
      LayoutTests:
      
      * svg/text/textpath-referencing-text-crash-expected.txt: Added.
      * svg/text/textpath-referencing-text-crash.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f1de057
    • dpranke@chromium.org's avatar
      [chromium] add missing project dependencies to DRT to fix Mac Valgrind · 93ad3e30
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112953
      
      Reviewed by Tony Chang.
      
      When I created the DumpRenderTree_resources target in r144863 I
      forgot to declare the needed dependencies on the other resource
      targets. Due to a quirk of ordering, this appears to have been fine
      w/ ninja but not w/ Xcode (which is still being used on the chromium
      mac valgrind bots). Declaring the dependencies fixes the build
      failures.
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93ad3e30
    • ap@apple.com's avatar
      Build fix. · bc899baf
      ap@apple.com authored
              * NetworkProcess/mac/NetworkResourceLoaderMac.mm: Include CurrentTime.h, as needed
              to call currentTime().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc899baf
    • pilgrim@chromium.org's avatar
      [Chromium] Removed unused WEBKIT_USE_NEW_WEBFILESYSTEMTYPE flag · 192bd054
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112931
      
      Reviewed by Adam Barth.
      
      Migration complete; flag no longer needed.
      
      * chromium/public/WebFileSystemType.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      192bd054
    • jsbell@chromium.org's avatar
      IndexedDB: Remove onVersionChange(string) plumbing · 0e6a82c1
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112712
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Delete unused onVersionChange(string) overload.
      
      No new tests - just deleting dead code.
      
      * Modules/indexeddb/IDBDatabase.cpp: Delete onVersionChange(string) overload.
      * Modules/indexeddb/IDBDatabase.h: Ditto.
      * Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Ditto.
      * Modules/indexeddb/IDBDatabaseCallbacks.h: Ditto.
      * Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: Ditto.
      * Modules/indexeddb/IDBDatabaseCallbacksImpl.h: Ditto.
      
      Source/WebKit/chromium:
      
      * public/WebIDBDatabaseCallbacks.h: Remove onVersionChange(string) overload.
      * src/IDBDatabaseCallbacksProxy.cpp: Ditto.
      * src/IDBDatabaseCallbacksProxy.h: Ditto.
      * src/WebIDBDatabaseCallbacksImpl.cpp: Ditto.
      * src/WebIDBDatabaseCallbacksImpl.h: Ditto.
      * tests/IDBAbortOnCorruptTest.cpp: Ditto.
      * tests/IDBDatabaseBackendTest.cpp: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e6a82c1
    • pdr@google.com's avatar
      Correct bisector angle calculation for markers · bd2e9785
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112054
      
      Reviewed by Stephen Chenney.
      
      Source/WebCore:
      
      The SVG marker spec states that mid markers with orient=auto should be aligned with their
      x-axis along the bisector of the incoming (in) and outgoing (out) angles. Previously we
      calculated this bisector angle as:
          bisector = (in + out) / 2;
      Angles cannot be averaged this way! Consider in=90deg and out=-180deg: the bisector should
      be 135deg but a naive average gives -45deg. This patch corrects for the discontinuity in
      angle values with:
          bisector = (in + out + 360) / 2   // if |in - out| > 180
          bisector = (in + out) / 2         // otherwise
      This patch includes an exhaustive test of angle values.
      
      Test: svg/custom/marker-orient-auto.html
      
      * rendering/svg/SVGMarkerData.h:
      (WebCore::SVGMarkerData::currentAngle):
      
      LayoutTests:
      
      * platform/chromium-linux/svg/custom/marker-orient-auto-expected.png: Added.
      * platform/chromium-linux/svg/custom/marker-orient-auto-expected.txt: Added.
      * platform/chromium/TestExpectations:
      * svg/custom/marker-orient-auto.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd2e9785
    • commit-queue@webkit.org's avatar
      Expose the Type field of an RTCStatsReport · 8fb659c1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112951
      
      Patch by Harald Alvestrand <hta@google.com> on 2013-03-21
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Covered by an extension of an existing test.
      
      * Modules/mediastream/RTCStatsReport.h:
      (WebCore::RTCStatsReport::type):
      * Modules/mediastream/RTCStatsReport.idl:
      
      LayoutTests:
      
      * fast/mediastream/RTCPeerConnection-stats-expected.txt:
      * fast/mediastream/RTCPeerConnection-stats.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fb659c1
    • ap@apple.com's avatar
      Move non-trivial virtual functions out of ResourceHandleClient.h · 47ed39b0
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=112950
      
              Reviewed by Brady Eidson.
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * Target.pri:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/network/ResourceHandleClient.cpp: Added.
              (WebCore::ResourceHandleClient::ResourceHandleClient):
              (WebCore::ResourceHandleClient::~ResourceHandleClient):
              (WebCore::ResourceHandleClient::didReceiveBuffer):
              (WebCore::ResourceHandleClient::getBuffer):
              * platform/network/ResourceHandleClient.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47ed39b0
    • bfulgham@webkit.org's avatar
      [WinCairo] Correct assert in Empty BitmapImage Test. · 8dddec75
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112934
      
      Reviewed by Tim Horton.
      
      * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
      (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
      to avoid ref counting assertion when leaving test scope.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dddec75
    • rniwa@webkit.org's avatar
      Windows rebaseline after r146469. · 68b03cfb
      rniwa@webkit.org authored
      * platform/win/css3/filters/effect-reference-expected.txt:
      * platform/win/css3/filters/effect-reference-hw-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68b03cfb
    • mark.lam@apple.com's avatar
      Fix lexer charPosition computation when "rewind"ing the lexer. · 4f75bbeb
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112952.
      
      Reviewed by Michael Saboff.
      
      Changed the Lexer to no longer keep a m_charPosition. Instead, we compute
      currentCharPosition() from m_code and m_codeStartPlusOffset, where
      m_codeStartPlusOffset is the SourceProvider m_codeStart + the SourceCode
      start offset. This ensures that the charPosition is always in sync with
      m_code.
      
      * parser/Lexer.cpp:
      (JSC::::setCode):
      (JSC::::internalShift):
      (JSC::::shift):
      (JSC::::lex):
      * parser/Lexer.h:
      (JSC::Lexer::currentCharPosition):
      (JSC::::lexExpectIdentifier):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f75bbeb
    • zandobersek@gmail.com's avatar
      [GTK] generate-feature-defines-files is incompatible with Python3 · 70410638
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112956
      
      Reviewed by Martin Robinson.
      
      Make the generate-feature-defines-files compatible with Python3 by calling the items()
      method on the dictionary objects when iterating through said dictionaries.
      
      * gtk/generate-feature-defines-files:
      (write_feature_defines_header):
      (write_flattened_feature_defines_file):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70410638
    • fmalita@chromium.org's avatar
      [SVG] Remove explicit LightSource dispatchers · 96b9c2db
      fmalita@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112827
      
      Reviewed by Stephen Chenney.
      
      Convert LightSource setters to dynamic dispatch. This allows us to remove LightSource.cpp
      altogether.
      
      No new tests: refactoring only.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/filters/DistantLightSource.h:
      (DistantLightSource):
      * platform/graphics/filters/LightSource.cpp: Removed.
      * platform/graphics/filters/LightSource.h:
      (WebCore::LightSource::setAzimuth):
      (WebCore::LightSource::setElevation):
      (WebCore::LightSource::setX):
      (WebCore::LightSource::setY):
      (WebCore::LightSource::setZ):
      (WebCore::LightSource::setPointsAtX):
      (WebCore::LightSource::setPointsAtY):
      (WebCore::LightSource::setPointsAtZ):
      (WebCore::LightSource::setSpecularExponent):
      (WebCore::LightSource::setLimitingConeAngle):
      * platform/graphics/filters/PointLightSource.h:
      (PointLightSource):
      * platform/graphics/filters/SpotLightSource.h:
      (SpotLightSource):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96b9c2db
    • commit-queue@webkit.org's avatar
      [BlackBerry] GCActivityCallback: replace JSLock with JSLockHolder · eb79cda9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112448
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
      Reviewed by Xan Lopez.
      
      This changed in r121381.
      
      * runtime/GCActivityCallbackBlackBerry.cpp:
      (JSC::DefaultGCActivityCallback::doWork):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb79cda9
    • igor.o@sisa.samsung.com's avatar
      [Texmap] Implement support for OpenGLES EXT_unpack_subimage extension · 15ab1ab2
      igor.o@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108716
      
      If the extension GL_EXT_unpack_subimage is supported, it adds GL_UNPACK_ROW_LENGTH,
      GL_UNPACK_SKIP_ROWS and GL_UNPACK_SKIP_PIXELS as valid enums to PixelStore.
      
      Reviewed by Noam Rosenthal.
      
      * platform/graphics/texmap/TextureMapperGL.cpp:
      (WebCore::driverSupportsSubImage):
      (WebCore::BitmapTextureGL::updateContentsNoSwizzle):
      (WebCore::BitmapTextureGL::updateContents):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15ab1ab2
    • commit-queue@webkit.org's avatar
      Web Inspector: Regression: drawer resizes slowly with animation. · a7e76827
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112920
      
      Drawer status bar opacity wasn't set to zero on inialization, so no transition event
      was fired on first time drawer appeared,thus animation styles wasn't removed properly.
      
      Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-21
      Reviewed by Vsevolod Vlasov.
      
      * inspector/front-end/Drawer.js:
      (WebInspector.Drawer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7e76827
    • commit-queue@webkit.org's avatar
      [BlackBerry] GraphicsLayer: fix code that was accidentally reverted · 3eb581b5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112143
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
      Reviewed by Rob Buis.
      
      Several changes were accidentally reverted in r144465 due to the
      upstreaming of some new code:
      
      - clearBackgroundColor() and m_contentsLayerHasBackgroundColor had
        been removed in r137798.
      
      - showDebugBorders() had been renamed to isShowingDebugBorder() in
        r133517.
      
      - A new GraphicsLayer::create() overload had been introduced in
        r130185.
      
      This patch fixes them all.
      
      * platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
      (WebCore::GraphicsLayer::create):
      (WebCore):
      (WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
      (WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
      (WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
      (WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
      * platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
      (GraphicsLayerBlackBerry):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3eb581b5
    • zandobersek@gmail.com's avatar
      [GTK] Move libLevelDB.la setup into a separate GNUmakefile.am · 24838de9
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112947
      
      Reviewed by Martin Robinson.
      
      .: 
      
      * GNUmakefile.am: Include the new GNUmakefile.am, located under Source/ThirdParty/leveldb.
      
      Source/ThirdParty: 
      
      * leveldb/GNUmakefile.am: Added, sets up the libLevelDB.la library.
      
      Source/WebCore: 
      
      No new tests - no new functionality.
      
      * GNUmakefile.am: Move the libLevelDD.la setup into the new GNUmakefile.am that's placed in
      the third-party leveldb source directory.
      * GNUmakefile.list.am: Move the LevelDB sources listing there as well.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24838de9
    • commit-queue@webkit.org's avatar
      [BlackBerry] DrawingBuffer: add clearPlatformLayer() implementation · 59e18270
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112696
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
      Reviewed by Rob Buis.
      
      DrawingBuffer::clearPlatformLayer() was added in r139142.
      
      This is not needed in the BlackBerry port, so this patch only
      contains a dummy implementation.
      
      * platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
      (WebCore):
      (WebCore::DrawingBuffer::clearPlatformLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59e18270
    • rniwa@webkit.org's avatar
      kill-old-processes spits out error messages on Mac · 702321a8
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112878
      
      Reviewed by Jessie Berlin.
      
      Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
      included in the list of options grep --help shows.
      
      Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
      
      * BuildSlaveSupport/kill-old-processes:
      (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      702321a8
    • fmalita@chromium.org's avatar
      [SVG] Suppress painting when an empty viewBox is specified · 9e4854cb
      fmalita@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112623
      
      Reviewed by Philip Rogers.
      
      Source/WebCore:
      
      Per spec, elements with an empty viewBox should not be rendered:
      http://www.w3.org/TR/SVG/coords.html#ViewBoxAttribute.
      
      This patch adds the missing viewBox checks to RenderSVGRoot, RenderSVGViewPortContainer,
      RenderSVGResourceMarker and RenderSVGResourceMarker's paint methods.
      
      In order to detect the case of "viewBox present but invalid", the patch also introduces
      SVGAnimatedProperty plumbing for tracking property validity: the baseVal setter now takes
      an additional optional 'validValue' boolean parameter, which can later be queried via a
      macroed getter (LowerProperty##IsValid()).
      
      Test: svg/custom/viewBox-empty.html
      
      * rendering/svg/RenderSVGResourceMarker.cpp:
      (WebCore::RenderSVGResourceMarker::draw):
      * rendering/svg/RenderSVGResourcePattern.cpp:
      (WebCore::RenderSVGResourcePattern::buildPattern):
      * rendering/svg/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::paintReplaced):
      * rendering/svg/RenderSVGViewportContainer.cpp:
      (WebCore::RenderSVGViewportContainer::paint):
      (WebCore):
      * rendering/svg/RenderSVGViewportContainer.h:
      (RenderSVGViewportContainer):
      * svg/SVGPatternElement.cpp:
      (WebCore::SVGPatternElement::collectPatternAttributes):
      * svg/SVGSVGElement.h:
      (WebCore::SVGSVGElement::hasEmptyViewBox):
      (SVGSVGElement):
      Suppress painting if a valid empty viewBox is found.
      
      * svg/SVGFitToViewBox.h:
      (WebCore::SVGFitToViewBox::parseAttribute):
      Mark the viewBox property as invalid if not successfully parsed.
      
      * svg/SVGExternalResourcesRequired.h:
      (SVGExternalResourcesRequired):
      * svg/SVGURIReference.h:
      (SVGURIReference):
      * svg/properties/SVGAnimatedPropertyMacros.h:
      (WebCore::SVGSynchronizableAnimatedProperty::SVGSynchronizableAnimatedProperty):
      (SVGSynchronizableAnimatedProperty):
      (WebCore):
      Plumbing for tracking property value validation.
      
      LayoutTests:
      
      * svg/custom/script-tests/svg-viewBox-dynamic.js:
      * svg/custom/svg-viewBox-dynamic-expected.txt:
      * svg/custom/viewBox-empty-expected.html: Added.
      * svg/custom/viewBox-empty.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e4854cb
    • mhahnenberg@apple.com's avatar
      Objective-C API: wrapperClass holds a static JSClassRef, which causes JSGlobalObjects to leak · ff81d056
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112856
      
      Reviewed by Geoffrey Garen.
      
      Through a very convoluted path that involves the caching of prototypes on the JSClassRef, we can leak 
      JSGlobalObjects when inserting an Objective-C object into multiple independent JSContexts.
      
      * API/JSAPIWrapperObject.cpp: Removed.
      * API/JSAPIWrapperObject.h:
      (JSAPIWrapperObject):
      * API/JSAPIWrapperObject.mm: Copied from Source/JavaScriptCore/API/JSAPIWrapperObject.cpp. Made this an
      Objective-C++ file so that we can call release on the wrappedObject. Also added a WeakHandleOwner for 
      JSAPIWrapperObjects. This will also be used in a future patch for https://bugs.webkit.org/show_bug.cgi?id=112608.
      (JSAPIWrapperObjectHandleOwner):
      (jsAPIWrapperObjectHandleOwner):
      (JSAPIWrapperObjectHandleOwner::finalize): This finalize replaces the old finalize that was done through
      the C API.
      (JSC::JSAPIWrapperObject::finishCreation): Allocate the WeakImpl. Balanced in finalize.
      (JSC::JSAPIWrapperObject::setWrappedObject): We now do the retain of the wrappedObject here rather than in random
      places scattered around JSWrapperMap.mm
      * API/JSObjectRef.cpp: Added some ifdefs for platforms that don't support the Obj-C API.
      (JSObjectGetPrivate): Ditto.
      (JSObjectSetPrivate): Ditto.
      (JSObjectGetPrivateProperty): Ditto.
      (JSObjectSetPrivateProperty): Ditto.
      (JSObjectDeletePrivateProperty): Ditto.
      * API/JSValueRef.cpp: Ditto.
      (JSValueIsObjectOfClass): Ditto.
      * API/JSWrapperMap.mm: Remove wrapperClass().
      (objectWithCustomBrand): Change to no longer use a parent class, which was only used to give the ability to 
      finalize wrapper objects.
      (-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]): Change to no longer use wrapperClass(). 
      (-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): Ditto.
      (tryUnwrapObjcObject): We now check if the object inherits from JSAPIWrapperObject.
      * API/tests/testapi.mm: Added a test that exports an Objective-C object to two different JSContexts and makes 
      sure that the first one is collected properly by using a weak JSManagedValue for the wrapper in the first JSContext.
      * CMakeLists.txt: Build file modifications.
      * GNUmakefile.list.am: Ditto.
      * JavaScriptCore.gypi: Ditto.
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Ditto.
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
      * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
      * runtime/JSGlobalObject.cpp: More ifdefs for unsupported platforms.
      (JSC::JSGlobalObject::reset): Ditto.
      (JSC::JSGlobalObject::visitChildren): Ditto.
      * runtime/JSGlobalObject.h: Ditto.
      (JSGlobalObject): Ditto.
      (JSC::JSGlobalObject::objcCallbackFunctionStructure): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff81d056
    • commit-queue@webkit.org's avatar
      Web Inspector: Hide toolbar customization experimental setting · 5d709c14
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112942
      
      Patch by Alexei Filippov <alph@chromium.org> on 2013-03-21
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/Settings.js:
      (WebInspector.ExperimentsSettings):
      * inspector/front-end/Toolbar.js:
      (WebInspector.Toolbar):
      (WebInspector.Toolbar.prototype._isToolbarCustomizable):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d709c14
    • senorblanco@chromium.org's avatar
      [Chromium] Unreviewed gardening. · 7cb66535
      senorblanco@chromium.org authored
      New test results for effect-reference and effect-reference-hw.
      
      * platform/chromium-linux-x86/css3/filters/effect-reference-expected.png: Removed.
      * platform/chromium-linux-x86/css3/filters/effect-reference-expected.txt: Removed.
      * platform/chromium-linux/css3/filters/effect-reference-expected.png: Removed.
      * platform/chromium-linux/css3/filters/effect-reference-expected.txt: Removed.
      * platform/chromium-mac-lion/css3/filters/effect-reference-expected.png: Removed.
      * platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.png: Removed.
      * platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Removed.
      * platform/chromium-mac/css3/filters/effect-reference-expected.png:
      * platform/chromium-mac/css3/filters/effect-reference-expected.txt:
      * platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
      * platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
      * platform/chromium-win-xp/css3/filters/effect-reference-expected.png: Removed.
      * platform/chromium-win-xp/css3/filters/effect-reference-expected.txt: Removed.
      * platform/chromium-win/css3/filters/effect-reference-expected.png:
      * platform/chromium-win/css3/filters/effect-reference-expected.txt:
      * platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
      * platform/chromium-win/css3/filters/effect-reference-hw-expected.txt:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cb66535
    • commit-queue@webkit.org's avatar
      [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods · 2643450a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112597
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
      Reviewed by Xan Lopez.
      
      These were introduced for the Chromium port in r105295. We need
      dummy implementations in order to compile the BlackBerry port.
      
      * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
      (AccessibilityUIElement::scrollToMakeVisible):
      (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
      (AccessibilityUIElement::scrollToGlobalPoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2643450a
    • csaavedra@igalia.com's avatar
      Unreviewed GTK+ gardening. · 763c38ae
      csaavedra@igalia.com authored
      * platform/gtk/TestExpectations: Remove redundant entry.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      763c38ae
    • antonm@chromium.org's avatar
      Unreviewed, rolling out r146483. · 59a21b56
      antonm@chromium.org authored
      http://trac.webkit.org/changeset/146483
      https://bugs.webkit.org/show_bug.cgi?id=111695
      
      Source/JavaScriptCore: 
      
      Breaks debug builds.
      
      * bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.
      
      Source/Platform: 
      
      Breaks
      
      * Platform.gypi:
      * chromium/public/Platform.h:
      (WebKit):
      (Platform):
      * chromium/public/WebSpeechSynthesisUtterance.h: Removed.
      * chromium/public/WebSpeechSynthesisVoice.h: Removed.
      * chromium/public/WebSpeechSynthesizer.h: Removed.
      * chromium/public/WebSpeechSynthesizerClient.h: Removed.
      
      Source/WebCore: 
      
      Breaks
      
      * Modules/speech/SpeechSynthesis.cpp:
      (WebCore::SpeechSynthesis::boundaryEventOccurred):
      (WebCore::SpeechSynthesis::didStartSpeaking):
      (WebCore::SpeechSynthesis::didPauseSpeaking):
      (WebCore::SpeechSynthesis::didResumeSpeaking):
      (WebCore::SpeechSynthesis::didFinishSpeaking):
      (WebCore::SpeechSynthesis::speakingErrorOccurred):
      (WebCore):
      * Modules/speech/SpeechSynthesis.h:
      (SpeechSynthesis):
      * Modules/speech/SpeechSynthesisUtterance.cpp:
      (WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
      (WebCore::SpeechSynthesisUtterance::setVoice):
      * Modules/speech/SpeechSynthesisUtterance.h:
      (WebCore::SpeechSynthesisUtterance::text):
      (WebCore::SpeechSynthesisUtterance::setText):
      (WebCore::SpeechSynthesisUtterance::lang):
      (WebCore::SpeechSynthesisUtterance::setLang):
      (WebCore::SpeechSynthesisUtterance::volume):
      (WebCore::SpeechSynthesisUtterance::setVolume):
      (WebCore::SpeechSynthesisUtterance::rate):
      (WebCore::SpeechSynthesisUtterance::setRate):
      (WebCore::SpeechSynthesisUtterance::pitch):
      (WebCore::SpeechSynthesisUtterance::setPitch):
      (WebCore::SpeechSynthesisUtterance::startTime):
      (WebCore::SpeechSynthesisUtterance::setStartTime):
      (WebCore::SpeechSynthesisUtterance::platformUtterance):
      (SpeechSynthesisUtterance):
      * Modules/speech/SpeechSynthesisVoice.h:
      (SpeechSynthesisVoice):
      * WebCore.exp.in:
      * WebCore.gypi:
      * platform/PlatformSpeechSynthesis.h:
      (PlatformSpeechSynthesis):
      * platform/PlatformSpeechSynthesisUtterance.cpp:
      * platform/PlatformSpeechSynthesisUtterance.h:
      (PlatformSpeechSynthesisUtterance):
      (WebCore::PlatformSpeechSynthesisUtterance::client):
      * platform/PlatformSpeechSynthesisVoice.cpp:
      (WebCore::PlatformSpeechSynthesisVoice::create):
      (WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
      * platform/PlatformSpeechSynthesisVoice.h:
      (PlatformSpeechSynthesisVoice):
      (WebCore::PlatformSpeechSynthesisVoice::voiceURI):
      (WebCore::PlatformSpeechSynthesisVoice::name):
      (WebCore::PlatformSpeechSynthesisVoice::lang):
      (WebCore::PlatformSpeechSynthesisVoice::localService):
      * platform/PlatformSpeechSynthesizer.cpp:
      (WebCore::PlatformSpeechSynthesizer::create):
      (WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
      (WebCore):
      * platform/PlatformSpeechSynthesizer.h:
      (PlatformSpeechSynthesizerClient):
      (WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
      (PlatformSpeechSynthesizer):
      * platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Removed.
      * platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Removed.
      * platform/chromium/support/WebSpeechSynthesisVoice.cpp: Removed.
      * platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Removed.
      * platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Removed.
      * platform/mac/PlatformSpeechSynthesizerMac.mm:
      (-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
      (-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
      (WebCore):
      (WebCore::PlatformSpeechSynthesizer::speak):
      * platform/mock/PlatformSpeechSynthesizerMock.cpp:
      (WebCore::PlatformSpeechSynthesizerMock::create):
      (WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
      (WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
      (WebCore::PlatformSpeechSynthesizerMock::speak):
      * platform/mock/PlatformSpeechSynthesizerMock.h:
      (PlatformSpeechSynthesizerMock):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59a21b56
    • ap@apple.com's avatar
      [Mac] Consolidate bits of willSendRequest implementation · 9be06489
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=112932
      
              Reviewed by Brady Eidson.
      
              Moved some logic from WebCoreResourceHandleAsDelegate to ResourceHandle for clarity.
      
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::ResourceHandle::willSendRequest):
              (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9be06489
    • danakj@chromium.org's avatar
      [chromium] Add isOrphan() to the WebLayer API · 696dd770
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112649
      
      Reviewed by James Robinson.
      
      This method will be used by WebMediaPlayerClientImpl to tell
      if the compositing video layer is currently being used to
      display the video content or not.
      
      * chromium/public/WebLayer.h:
      (WebLayer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      696dd770
    • commit-queue@webkit.org's avatar
      Remove AudioGain.idl from compilation. · a8e2d43b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112650
      
      Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-03-21
      Reviewed by Chris Rogers.
      
      Source/WebCore:
      
      Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#GainNode
            https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBufferSourceNode
      
      AudioParam serves the same purpose as AudioGain. Infact, AudioGain inherits
      AudioParam class and doesn't have its own member functions/parameters. Also,
      AudioGain is not part of WebAudio W3C specifications.
      
      Test: webaudio/gain-basic.html
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * Modules/webaudio/AudioBufferSourceNode.cpp:
      (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
      * Modules/webaudio/AudioBufferSourceNode.h:
      (AudioBufferSourceNode):
      (WebCore::AudioBufferSourceNode::gain):
      * Modules/webaudio/AudioBufferSourceNode.idl:
      * Modules/webaudio/AudioGain.h: Removed.
      * Modules/webaudio/AudioGain.idl: Removed.
      * Modules/webaudio/GainNode.cpp:
      (WebCore::GainNode::GainNode):
      * Modules/webaudio/GainNode.h:
      (WebCore):
      (WebCore::GainNode::create):
      (GainNode):
      (WebCore::GainNode::gain):
      * Modules/webaudio/GainNode.idl:
      * Modules/webaudio/PannerNode.cpp:
      (WebCore::PannerNode::PannerNode):
      * Modules/webaudio/PannerNode.h:
      (WebCore::PannerNode::distanceGain):
      (WebCore::PannerNode::coneGain):
      * Target.pri:
      * WebCore.gypi:
      * WebCore.xcodeproj/project.pbxproj:
      
      LayoutTests:
      
      Test to verify GainNode attributes.
      
      * webaudio/gain-basic-expected.txt: Added.
      * webaudio/gain-basic.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8e2d43b
    • roger_fong@apple.com's avatar
      Re-enable WinEWS tests following r146376. · e56504c4
      roger_fong@apple.com authored
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (WinEWS):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e56504c4
    • antonm@chromium.org's avatar
      Unreviewed Chromium gardening. · 19f4d67c
      antonm@chromium.org authored
      Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19f4d67c
    • dmazzoni@google.com's avatar
      Implement Web Speech Synthesis for Chromium · 00dd10cf
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111695
      
      Reviewed by Adam Barth.
      
      Source/Platform:
      
      Exposes a platform API that the embedder can implement to
      provide speech synthesis for the Chromium port.
      
      * Platform.gypi:
      * chromium/public/Platform.h:
      (WebKit):
      (Platform):
      (WebKit::Platform::speechSynthesizer):
      * chromium/public/WebSpeechSynthesisUtterance.h: Added.
      (WebKit):
      (WebSpeechSynthesisUtterance):
      (WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
      (WebKit::WebSpeechSynthesisUtterance::~WebSpeechSynthesisUtterance):
      (WebKit::WebSpeechSynthesisUtterance::operator=):
      (WebKit::WebSpeechSynthesisUtterance::isNull):
      * chromium/public/WebSpeechSynthesisVoice.h: Added.
      (WebCore):
      (WebKit):
      (WebSpeechSynthesisVoice):
      (WebKit::WebSpeechSynthesisVoice::WebSpeechSynthesisVoice):
      (WebKit::WebSpeechSynthesisVoice::~WebSpeechSynthesisVoice):
      (WebKit::WebSpeechSynthesisVoice::operator=):
      * chromium/public/WebSpeechSynthesizer.h: Added.
      (WebKit):
      (WebSpeechSynthesizer):
      (WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):
      * chromium/public/WebSpeechSynthesizerClient.h: Added.
      (WebKit):
      (WebSpeechSynthesizerClient):
      (WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):
      
      Source/WebCore:
      
      Straightforward implementation of speech synthesis
      for Chromium by exposing interfaces for the platform
      to implement.
      
      * Modules/speech/SpeechSynthesis.cpp:
      (WebCore::SpeechSynthesis::boundaryEventOccurred):
      (WebCore::SpeechSynthesis::didStartSpeaking):
      (WebCore::SpeechSynthesis::didPauseSpeaking):
      (WebCore::SpeechSynthesis::didResumeSpeaking):
      (WebCore::SpeechSynthesis::didFinishSpeaking):
      (WebCore::SpeechSynthesis::speakingErrorOccurred):
      (WebCore):
      * Modules/speech/SpeechSynthesis.h:
      (SpeechSynthesis):
      * Modules/speech/SpeechSynthesisUtterance.cpp:
      (WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
      (WebCore):
      (WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
      (WebCore::SpeechSynthesisUtterance::setVoice):
      * Modules/speech/SpeechSynthesisUtterance.h:
      (SpeechSynthesisUtterance):
      (WebCore::SpeechSynthesisUtterance::text):
      (WebCore::SpeechSynthesisUtterance::setText):
      (WebCore::SpeechSynthesisUtterance::lang):
      (WebCore::SpeechSynthesisUtterance::setLang):
      (WebCore::SpeechSynthesisUtterance::volume):
      (WebCore::SpeechSynthesisUtterance::setVolume):
      (WebCore::SpeechSynthesisUtterance::rate):
      (WebCore::SpeechSynthesisUtterance::setRate):
      (WebCore::SpeechSynthesisUtterance::pitch):
      (WebCore::SpeechSynthesisUtterance::setPitch):
      (WebCore::SpeechSynthesisUtterance::startTime):
      (WebCore::SpeechSynthesisUtterance::setStartTime):
      (WebCore::SpeechSynthesisUtterance::platformUtterance):
      * Modules/speech/SpeechSynthesisVoice.h:
      (WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):
      * WebCore.exp.in:
      * WebCore.gypi:
      * platform/PlatformSpeechSynthesis.h:
      (PlatformSpeechSynthesis):
      * platform/PlatformSpeechSynthesisUtterance.cpp:
      (WebCore):
      (WebCore::PlatformSpeechSynthesisUtterance::create):
      * platform/PlatformSpeechSynthesisUtterance.h:
      (PlatformSpeechSynthesisUtterance):
      (WebCore::PlatformSpeechSynthesisUtterance::setClient):
      * platform/PlatformSpeechSynthesisVoice.cpp:
      (WebCore):
      (WebCore::PlatformSpeechSynthesisVoice::create):
      (WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
      * platform/PlatformSpeechSynthesisVoice.h:
      (PlatformSpeechSynthesisVoice):
      (WebCore::PlatformSpeechSynthesisVoice::setVoiceURI):
      (WebCore::PlatformSpeechSynthesisVoice::setName):
      (WebCore::PlatformSpeechSynthesisVoice::setLang):
      (WebCore::PlatformSpeechSynthesisVoice::setLocalService):
      (WebCore::PlatformSpeechSynthesisVoice::setIsDefault):
      * platform/PlatformSpeechSynthesizer.cpp:
      (WebCore::PlatformSpeechSynthesizer::create):
      (WebCore::PlatformSpeechSynthesizer::setVoiceList):
      (WebCore):
      * platform/PlatformSpeechSynthesizer.h:
      (WebKit):
      (PlatformSpeechSynthesizerClient):
      (PlatformSpeechSynthesizer):
      * platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.
      (WebCore):
      (WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
      (WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
      (WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
      (WebCore::PlatformSpeechSynthesizer::speak):
      (WebCore::PlatformSpeechSynthesizer::pause):
      (WebCore::PlatformSpeechSynthesizer::resume):
      (WebCore::PlatformSpeechSynthesizer::cancel):
      * platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.
      (WebKit):
      (WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
      (WebKit::WebSpeechSynthesisUtterance::operator=):
      (WebKit::WebSpeechSynthesisUtterance::assign):
      (WebKit::WebSpeechSynthesisUtterance::reset):
      (WebKit::WebSpeechSynthesisUtterance::operator PassRefPtr<PlatformSpeechSynthesisUtterance>):
      (WebKit::WebSpeechSynthesisUtterance::operator PlatformSpeechSynthesisUtterance*):
      (WebKit::WebSpeechSynthesisUtterance::text):
      (WebKit::WebSpeechSynthesisUtterance::lang):
      (WebKit::WebSpeechSynthesisUtterance::voice):
      (WebKit::WebSpeechSynthesisUtterance::volume):
      (WebKit::WebSpeechSynthesisUtterance::rate):
      (WebKit::WebSpeechSynthesisUtterance::pitch):
      (WebKit::WebSpeechSynthesisUtterance::startTime):
      * platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.
      (WebKit):
      (WebKit::WebSpeechSynthesisVoice::assign):
      (WebKit::WebSpeechSynthesisVoice::reset):
      (WebKit::WebSpeechSynthesisVoice::setVoiceURI):
      (WebKit::WebSpeechSynthesisVoice::setName):
      (WebKit::WebSpeechSynthesisVoice::setLanguage):
      (WebKit::WebSpeechSynthesisVoice::setIsLocalService):
      (WebKit::WebSpeechSynthesisVoice::setIsDefault):
      (WebKit::WebSpeechSynthesisVoice::operator PassRefPtr<WebCore::PlatformSpeechSynthesisVoice>):
      * platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.
      (WebCore):
      (WebCore::WebSpeechSynthesizerClientImpl::WebSpeechSynthesizerClientImpl):
      (WebCore::WebSpeechSynthesizerClientImpl::~WebSpeechSynthesizerClientImpl):
      (WebCore::WebSpeechSynthesizerClientImpl::setVoiceList):
      (WebCore::WebSpeechSynthesizerClientImpl::didStartSpeaking):
      (WebCore::WebSpeechSynthesizerClientImpl::didFinishSpeaking):
      (WebCore::WebSpeechSynthesizerClientImpl::didPauseSpeaking):
      (WebCore::WebSpeechSynthesizerClientImpl::didResumeSpeaking):
      (WebCore::WebSpeechSynthesizerClientImpl::speakingErrorOccurred):
      (WebCore::WebSpeechSynthesizerClientImpl::wordBoundaryEventOccurred):
      (WebCore::WebSpeechSynthesizerClientImpl::sentenceBoundaryEventOccurred):
      * platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.
      (WebCore):
      (WebSpeechSynthesizerClientImpl):
      * platform/mac/PlatformSpeechSynthesizerMac.mm:
      (-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
      (-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
      (WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
      (WebCore):
      (WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
      (WebCore::PlatformSpeechSynthesizer::speak):
      * platform/mock/PlatformSpeechSynthesizerMock.cpp:
      (WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
      (WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
      (WebCore::PlatformSpeechSynthesizerMock::speak):
      * platform/mock/PlatformSpeechSynthesizerMock.h:
      (PlatformSpeechSynthesizerMock):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00dd10cf
    • jchaffraix@webkit.org's avatar
      [CSS Grid Layout] Properly layout spanning grid items with minmax grid tracks · 65cbfbd7
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112389
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      This change updates our core minmax resolution function to be spanning grid
      items aware. The new implementation of the algorithm doesn't totally match
      the specification but it is fairly close that it's a good first pass. The
      extra complexity in the specification needs to be carefully examinated
      first (not to mention the probable change in the core layout algorithm).
      
      Tests: fast/css-grid-layout/minmax-spanning-resolution-columns.html
             fast/css-grid-layout/minmax-spanning-resolution-rows.html
      
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
      Updated this function to account for spanning grid items by:
      - iterating over all spanned grid tracks.
      - removing any used breadth from all spanned grid tracks.
      
      LayoutTests:
      
      * fast/css-grid-layout/grid-item-spanning-resolution.html:
      * fast/css-grid-layout/resources/grid.css:
      (.firstRowBothColumn):
      (.secondRowBothColumn):
      (.bothRowFirstColumn):
      (.bothRowSecondColumn):
      (.bothRowBothColumn):
      Moved the previous classes for maximum reuse.
      
      * fast/css-grid-layout/minmax-spanning-resolution-columns-expected.txt: Added.
      * fast/css-grid-layout/minmax-spanning-resolution-columns.html: Added.
      * fast/css-grid-layout/minmax-spanning-resolution-rows-expected.txt: Added.
      * fast/css-grid-layout/minmax-spanning-resolution-rows.html: Added.
      New tests.
      
      * fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
      * fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:
      Unintended consistent progression from this change, it's unclear why these baselines
      change as the tests involve no spanning.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65cbfbd7
    • antonm@chromium.org's avatar
      Unreviewed Chromium gardening. · a1a236e7
      antonm@chromium.org authored
      Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1a236e7
    • zoltan@webkit.org's avatar
      Unreviewed. Add Bem Jones-Bey to the list of contributors. · 0080e0e6
      zoltan@webkit.org authored
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0080e0e6
    • commit-queue@webkit.org's avatar
      [GStreamer] New reference returned by g_main_context_new() must be freed · 2c668930
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112899
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-21
      Reviewed by Kenneth Rohde Christiansen.
      
      Fix a memory leak by adopting the new reference returned
      by g_main_context_new().
      
      No new tests. No change in behavior.
      
      * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
      (WebCore::AudioFileReader::createBus):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c668930
    • commit-queue@webkit.org's avatar
      [BlackBerry] Add ScrollingCoordinatorBlackBerry implementation · 42a27e13
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112915
      
      Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-03-21
      Reviewed by Rob Buis.
      
      * PlatformBlackBerry.cmake: Add page/scrolling/blackberry to the
      indlude dir list.
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::ScrollingCoordinator::create): Create a
      ScrollingCoordinatorBlackBerry for the BlackBerry platform.
      * page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp: Added.
      (WebCore):
      (WebCore::ScrollingCoordinatorBlackBerry::ScrollingCoordinatorBlackBerry):
      (WebCore::ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers):
      (WebCore::ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer):
      (WebCore::ScrollingCoordinatorBlackBerry::setLayerFixedToContainerLayerEdge):
      (WebCore::ScrollingCoordinatorBlackBerry::frameViewFrameRectDidChange):
      (WebCore::ScrollingCoordinatorBlackBerry::frameViewContentsSizeDidChange):
      * page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.h: Added.
      (WebCore):
      (ScrollingCoordinatorBlackBerry):
      (WebCore::ScrollingCoordinatorBlackBerry::supportsFixedPositionLayers):
      * platform/graphics/PlatformLayer.h:
      (WebCore): Add PlatformLayer definition for BlackBerry.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42a27e13
    • antonm@chromium.org's avatar
      Unreviewed Chromium gardening. · 6944d781
      antonm@chromium.org authored
      Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6944d781