- 27 Aug, 2013 7 commits
-
-
ch.dumez@sisa.samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=94081 Reviewed by Darin Adler. Source/WebCore: Add support for DOM Level 3 WheelEvent: http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent Firefox, IE10 and since recently Blink already support it so it increases our cross-browser compatibility. The non-standard 'mousewheel' event is still supported for backward compatibility. Note that the deltas returned by the mousewheel and the wheel events are not identical: - They have opposite signs. - The wheel event reports the actual amount of pixels that should be scrolled while the legacy mousewheel event reports a factor of the number of mouse wheel ticks (using a constant multiplier). Tests: fast/events/wheelevent-basic.html fast/events/wheelevent-constructor.html fast/events/wheelevent-mousewheel-interaction.html * dom/Document.h: * dom/Document.idl: * dom/Element.h: * dom/Element.idl: * dom/EventNames.h: * dom/EventTarget.cpp: (WebCore::legacyType): (WebCore::EventTarget::shouldObserveLegacyType): (WebCore::EventTarget::setupLegacyTypeObserverIfNeeded): (WebCore::EventTarget::fireEventListeners): * dom/EventTarget.h: * dom/Node.cpp: (WebCore::Node::didMoveToNewDocument): (WebCore::tryAddEventListener): (WebCore::tryRemoveEventListener): (WebCore::Node::defaultEventHandler): * dom/WheelEvent.cpp: (WebCore::WheelEventInit::WheelEventInit): (WebCore::WheelEvent::WheelEvent): (WebCore::WheelEvent::initWheelEvent): * dom/WheelEvent.h: (WebCore::WheelEvent::deltaX): (WebCore::WheelEvent::deltaY): (WebCore::WheelEvent::deltaZ): (WebCore::WheelEvent::wheelDelta): (WebCore::WheelEvent::wheelDeltaX): (WebCore::WheelEvent::wheelDeltaY): * dom/WheelEvent.idl: * html/HTMLAttributeNames.in: * html/HTMLElement.cpp: (WebCore::HTMLElement::eventNameForAttributeName): * page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): * page/DOMWindow.h: * page/DOMWindow.idl: * page/EventHandler.cpp: (WebCore::EventHandler::defaultWheelEventHandler): * plugins/blackberry/PluginViewBlackBerry.cpp: (WebCore::PluginView::handleWheelEvent): * svg/SVGElementInstance.cpp: * svg/SVGElementInstance.h: * svg/SVGElementInstance.idl: LayoutTests: Add several layout tests to check support for DOM3 wheel event. * fast/events/wheelevent-basic-expected.txt: Added. * fast/events/wheelevent-basic.html: Added. * fast/events/wheelevent-constructor-expected.txt: Added. * fast/events/wheelevent-constructor.html: Added. * fast/events/wheelevent-mousewheel-interaction-expected.txt: Added. * fast/events/wheelevent-mousewheel-interaction.html: Added. * platform/efl/fast/events/wheelevent-basic-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
allan.jensen@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=115303 Reviewed by Anders Carlsson. Do not relayout when accessing script elements during painting. * html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::renderWidgetForJSBindings): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120349 Adjust to latest changes in WebCore::Page to create the main frame. Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-08-27 Reviewed by Simon Hausmann. * WebCoreSupport/QWebFrameAdapter.cpp: (QWebFrameData::QWebFrameData): * WebCoreSupport/QWebPageAdapter.cpp: (QWebPageAdapter::initializeWebCorePage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
* TestWebKitAPI/GNUmakefile.am: Remove mac specific file from compilation added by mistake in r154601. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benjamin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120341 Reviewed by Ryosuke Niwa. Little refactoring to make other cleanups easier. Instead of modifying SpaceSplitString directly, rely on DOMTokenList ultimately changing the value, which in turn updates the tokens. * html/DOMSettableTokenList.cpp: * html/DOMSettableTokenList.h: * html/DOMTokenList.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
calvaris@igalia.com authored
https://bugs.webkit.org/show_bug.cgi?id=120253 Reviewed by Philippe Normand. When painting the volume bar, consider that it could be muted even then volume is different than zero. * platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign painted volume as 0 when media is muted. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
* WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): Remove an assertion that was not removed in r154658. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 26 Aug, 2013 33 commits
-
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120340 Reviewed by Andreas Kling. Only isSupportedFromDOM still takes a Frame*, as it still has callers that expect null to work. * dom/UserTypingGestureIndicator.cpp: * dom/UserTypingGestureIndicator.h: * editing/Editor.cpp: * editing/EditorCommand.cpp: * page/EventHandler.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120279 Reviewed by Darin Adler. Source/WebCore: Don't add the element in the named items to the past names map when there are multiple elements. This matches IE10's behavior and the specified behavior in HTML5: http://www.w3.org/TR/2013/WD-html51-20130528/forms.html#dom-form-nameditem Test: fast/forms/past-names-map-should-not-contain-nodelist-item.html * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::getNamedElements): LayoutTests: Add a regression test. * fast/forms/past-names-map-should-not-contain-nodelist-item-expected.txt: Added. * fast/forms/past-names-map-should-not-contain-nodelist-item.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
* WebView.cpp: (WebView::shouldClose): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120205 Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-08-26 Reviewed by Anders Carlsson. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::findPlugin): (WebKit::WebPageProxy::didBlockInsecurePluginVersion): Added UNUSED_PARAM to avoid warning. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
* page/AutoscrollController.cpp: (WebCore::getMainFrame): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<http://webkit.org/b/119677> Reviewed by Antti Koivisto. Page always creates the main Frame by itself now, so it will never be null during the Page's lifetime. Let Page::mainFrame() return Frame& and remove a sea of null checks. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aestes@apple.com authored
Objective-C GC is disabled at runtime. Reviewed by Darin Adler. * wtf/ObjcRuntimeExtras.h: (HardAutorelease): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Reviewed by Anders Carlsson. * editing/Editor.h: (WebCore::Editor::killRing): (WebCore::Editor::spellChecker): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=113094 * platform/mac-wk2/TestExpectations: * platform/mac/TestExpectations: Updated expectations, these tests should be good now. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=81419 <rdar://problem/11066794> Reviewed by Darin Adler. Mostly a copy/paste of DRT code. Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html doesn't interfere with my clipboard while being run in a loop. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/mac/PoseAsClass.h: Added. * WebKitTestRunner/mac/PoseAsClass.mm: Added. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize): (WTR::TestController::platformDestroy): * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added. * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
joepeck@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120242 Reviewed by NOBODY (OOPS!). Source/WebCore: - Update the Inspector.json CodeGenerator to include an output_js_dir. - Cleanup multiple trailing newlines in some of the generated files. - Provide a way to not verify runtime casts, needed for Legacy inputs. * CMakeLists.txt: * DerivedSources.make: * DerivedSources.pri: * GNUmakefile.am: * inspector/CodeGeneratorInspector.py: (resolve_all_types): (SmartOutput.close): Source/WebInspectorUI: - Include the iOS 6.0 Inspector.json which maps to Legacy/6.0/InspectorBackendCommands.js. - Provide a helper script to regenerate the backend commands file for trunk and Versions. - Regenerated file now includes enums and other minor changes. * Scripts/update-InspectorBackendCommands.rb: Added. * UserInterface/InspectorBackendCommands.js: * UserInterface/Legacy/6.0/InspectorBackendCommands.js: * Versions/Inspector-iOS-6.0.json: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
http://trac.webkit.org/changeset/154640 https://bugs.webkit.org/show_bug.cgi?id=120329 Caused flaky crashes on a lot of editing tests (Requested by rniwa on #webkit). * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/mac/PoseAsClass.h: Removed. * WebKitTestRunner/mac/PoseAsClass.mm: Removed. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize): (WTR::TestController::platformDestroy): * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed. * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120330 Reviewed by Anders Carlsson. * Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to “fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120327 Reviewed by Andreas Kling. While in the area I also: - Reference-ified Editor::killRing(). - Const-ified Editor::m_killRing, Editor::m_spellChecker, and Editor::m_alternativeTextController. * editing/AlternativeTextController.cpp: (WebCore::AlternativeTextController::AlternativeTextController): (WebCore::AlternativeTextController::stopPendingCorrection): (WebCore::AlternativeTextController::isSpellingMarkerAllowed): (WebCore::AlternativeTextController::applyAlternativeTextToRange): (WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate): (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection): (WebCore::AlternativeTextController::timerFired): (WebCore::AlternativeTextController::handleAlternativeTextUIResult): (WebCore::AlternativeTextController::rootViewRectForRange): (WebCore::AlternativeTextController::respondToChangedSelection): (WebCore::AlternativeTextController::respondToAppliedEditing): (WebCore::AlternativeTextController::respondToUnappliedEditing): (WebCore::AlternativeTextController::alternativeTextClient): (WebCore::AlternativeTextController::editorClient): (WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand): (WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult): (WebCore::AlternativeTextController::respondToMarkerAtEndOfWord): (WebCore::AlternativeTextController::insertDictatedText): (WebCore::AlternativeTextController::applyDictationAlternative): * editing/AlternativeTextController.h: (WebCore::AlternativeTextController::UNLESS_ENABLED): * editing/Editor.cpp: (WebCore::Editor::Editor): (WebCore::Editor::addToKillRing): * editing/Editor.h: (WebCore::Editor::killRing): * editing/EditorCommand.cpp: (WebCore::executeYank): (WebCore::executeYankAndSelect): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aestes@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120230 Reviewed by Darin Adler. Source/JavaScriptCore: * API/JSValue.mm: (valueToString): Don't leak every CFStringRef when in Objective-C GC. * API/ObjCCallbackFunction.mm: (JSC::ObjCCallbackFunctionImpl::~ObjCCallbackFunctionImpl): Don't release m_invocation's target since NSInvocation will do it for us on -dealloc. (objCCallbackFunctionForBlock): Tell NSInvocation to retain its target and -release our reference to the copied block. * API/tests/minidom.c: (createStringWithContentsOfFile): Free buffer before returning. * API/tests/testapi.c: (createStringWithContentsOfFile): Ditto. Source/WebCore: * WebCore.xcodeproj/project.pbxproj: Removed FoundationExtras.h. * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Removed CFAutoreleaseHelper(). (AXTextMarkerRange): Used HardAutorelease() instead of CFAutoreleaseHelper(). (AXTextMarkerRangeStart): Ditto. (AXTextMarkerRangeEnd): Ditto. (textMarkerForVisiblePosition): Ditto. * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (-[WebCoreAVFMovieObserver initWithCallback:]): Called [super init] first so that we don't later use ivars from the wrong self. (-[WebCoreAVFLoaderDelegate initWithCallback:]): Ditto. * platform/mac/FoundationExtras.h: Removed. * platform/mac/KURLMac.mm: (WebCore::KURL::operator NSURL *): Used WTF's HardAutorelease(). * platform/mac/WebCoreNSURLExtras.mm: (WebCore::mapHostNameWithRange): Used HardAutorelease() instead of WebCoreCFAutorelease(). (WebCore::URLWithData): Ditto. (WebCore::userVisibleString): Ditto. (WebCore::URLByRemovingComponentAndSubsequentCharacter): Used Vector<> with an inline capacity rather than heap-allocating a buffer. * platform/mac/WebCoreObjCExtras.h: Used HardAutorelease() instead of WebCoreCFAutorelease(). * platform/text/mac/StringImplMac.mm: (WTF::StringImpl::operator NSString *): Used WTF's HardAutorelease(). Source/WebKit/mac: * Misc/WebNSFileManagerExtras.mm: (-[NSFileManager _webkit_startupVolumeName]): Used HardAutorelease() instead of WebCFAutorelease(). * Misc/WebNSObjectExtras.h: Removed definition of WebCFAutorelease(). * Misc/WebNSURLExtras.mm: (-[NSURL _web_URLWithLowercasedScheme]): Used HardAutorelease() instead of WebCFAutorelease(). * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPluginLayer]): Stop leaking CGColors (CALayer retains its backgroundColor property despite the property attributes claiming otherwise). * Plugins/WebBasePluginPackage.mm: (+[WebBasePluginPackage preferredLocalizationName]): Used HardAutorelease() instead of WebCFAutorelease(). * WebView/WebDeviceOrientationProviderMock.mm: (-[WebDeviceOrientationProviderMockInternal lastOrientation]): Stop leaking WebDeviceOrientations. * WebView/WebPDFRepresentation.mm: (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Used HardAutorelease() instead of WebCFAutorelease(). * WebView/WebView.mm: (+[WebView _setCacheModel:]): Ditto. (-[WebView _removeObjectForIdentifier:]): Ditto. Source/WebKit2: * UIProcess/API/mac/WKBrowsingContextController.mm: (autoreleased): Don't leak CFURLs when in Objective-C GC. * WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: (-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]): Don't leak CFStrings when in Objective-C GC. Source/WTF: * wtf/ObjcRuntimeExtras.h: (HardAutorelease): Added a canonical implementation of HardAutorelease. Tools: * DumpRenderTree/mac/DumpRenderTreePasteboard.m: (-[LocalPasteboard initWithName:]): Called [super init] first so that we don't later use ivars from the wrong self. * DumpRenderTree/mac/TestRunnerMac.mm: (-[APITestDelegate initWithCompletionCondition:]): Ditto. * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: (TestWebKitAPI::TEST): Don't leak WKProcessGroups, WKBrowsingContextGroups, and WKViews. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120294 Reviewed by Darin Adler. * NetworkProcess/AsynchronousNetworkLoaderClient.cpp: (WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer): * NetworkProcess/NetworkResourceLoader.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
psolanki@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120320 Reviewed by Darin Adler. Page::m_console is never NULL so console() can just return a reference. * css/CSSParser.cpp: (WebCore::CSSParser::logError): * dom/Document.cpp: (WebCore::Document::addConsoleMessage): (WebCore::Document::addMessage): * page/DOMWindow.cpp: (WebCore::DOMWindow::pageConsole): * page/Page.h: (WebCore::Page::console): * xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::parseString): * xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=87964 Reviewed by Darin Adler. Source/WebCore: Provide a nodeAtFloatPoint implementation for RenderSVGGradientStop to avoid hitting the assert in RenderObject::nodeAtFloatPoint. Test: svg/custom/stop-crash-hittest.svg * rendering/svg/RenderSVGGradientStop.h: LayoutTests: Add testcase by taking stop-crash.svg and adding hittest instructions. * svg/custom/stop-crash-hittest-expected.txt: Added. * svg/custom/stop-crash-hittest.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120325 Reviewed by Anders Carlsson. * editing/Editor.cpp: (WebCore::Editor::Editor): * editing/Editor.h: (WebCore::Editor::spellChecker): * editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::client): (WebCore::SpellChecker::isAsynchronousEnabled): (WebCore::SpellChecker::didCheck): (WebCore::SpellChecker::didCheckSucceed): * editing/SpellChecker.h: * page/EditorClient.h: * testing/Internals.cpp: (WebCore::Internals::lastSpellCheckRequestSequence): (WebCore::Internals::lastSpellCheckProcessedSequence): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
roger_fong@apple.com authored
* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bjonesbe@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=120237 Reviewed by David Hyatt. Source/WebCore: This is a port of 3 Blink patches: https://codereview.chromium.org/22463002 (By shatch@chromium.org) https://chromiumcodereview.appspot.com/22909005 (By me) https://chromiumcodereview.appspot.com/23084002 (By me) shatch optimized FloatIntervalSearchAdapter by having it store the outermost float instead of making a bunch of calls to logical(Left/Right/Bottom)ForFloat, and then only making that call once when heightRemaining needs to be computed. I noticed that now we were storing both the last float encountered and the outermost float, and that the behavior for shape-outside wasn't significantly changed by using the outermost float instead of the last float encountered (and in most cases, using the outermost float gives more reasonable behavior). Since this isn't covered in the spec yet, I changed shape-outside to use the outermost float, making it so that we only need to store one float pointer when walking the placed floats tree, and keeping the performance win. Also while changing updateOffsetIfNeeded, removed const, since that is a lie. Nothing about that method is const. Test: fast/shapes/shape-outside-floats/shape-outside-floats-outermost.html * rendering/RenderBlock.cpp: (WebCore::::updateOffsetIfNeeded): (WebCore::::collectIfNeeded): (WebCore::::getHeightRemaining): (WebCore::RenderBlock::logicalLeftFloatOffsetForLine): (WebCore::RenderBlock::logicalRightFloatOffsetForLine): * rendering/RenderBlock.h: (WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter): (WebCore::RenderBlock::FloatIntervalSearchAdapter::outermostFloat): LayoutTests: Test shape-outside behavior when there is more than one float on a given line. * fast/shapes/shape-outside-floats/shape-outside-floats-outermost-expected.html: Added. * fast/shapes/shape-outside-floats/shape-outside-floats-outermost.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=81419 <rdar://problem/11066794> Reviewed by Darin Adler. Mostly a copy/paste of DRT code. Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html doesn't interfere with my clipboard while being run in a loop. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/mac/PoseAsClass.h: Added. * WebKitTestRunner/mac/PoseAsClass.mm: Added. * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize): (WTR::TestController::platformDestroy): * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added. * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=113094 Reviewed by Darin Adler. Mac platform implementation has checks for pasteboard change count, but it didn't use to update the count when writing to pasteboad from JavaScript. * platform/PasteboardStrategy.h: Changed changeCount function to return a long instead of an int, as the underlying Mac type is NSInteger. Changed all methods that modify the pasteboard to return a new change count. * platform/PlatformPasteboard.h: Changed all methods that modify the pasteboard to return a new change count. * platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::clear): Update m_changeCount. (WebCore::Pasteboard::writeSelectionForTypes): Ditto. (WebCore::Pasteboard::writePlainText): Ditto. (WebCore::writeURLForTypes): Ditto. (WebCore::Pasteboard::writeURL): Ditto. (WebCore::writeFileWrapperAsRTFDAttachment): Ditto. (WebCore::Pasteboard::writeImage): Ditto. (WebCore::Pasteboard::writePasteboard): Ditto. (WebCore::addHTMLClipboardTypesForCocoaType): Ditto. (WebCore::Pasteboard::writeString): Ditto. * platform/mac/PlatformPasteboardMac.mm: (WebCore::PlatformPasteboard::changeCount): Changed returned type to long to avoid data loss. (WebCore::PlatformPasteboard::copy): Return new change count. (WebCore::PlatformPasteboard::addTypes): Ditto. (WebCore::PlatformPasteboard::setTypes): Ditto. (WebCore::PlatformPasteboard::setBufferForType): Ditto. (WebCore::PlatformPasteboard::setPathnamesForType): Ditto. (WebCore::PlatformPasteboard::setStringForType): Ditto. Replaced -[NSURL writeToPasteboard:] with an equivalent implemnentation that tells use whether writing was successful. There is difference with invalid URL string handling - we used to silently ignore such requets, but set pasteboard content to empty URL now. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add missing build files. * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
* WebCoreSupport/FrameLoaderClientGtk.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
* webkit/webkitwebframe.cpp: (webkit_web_frame_new): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
roger_fong@apple.com authored
* Interfaces/Accessible2/AccessibleEditableText.idl: Added. * Interfaces/Accessible2/AccessibleText.idl: Added. * Interfaces/Accessible2/AccessibleText2.idl: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage does a check on the length of the ArrayStorage after possible reallocing it https://bugs.webkit.org/show_bug.cgi?id=120278 Reviewed by Geoffrey Garen. Source/JavaScriptCore: * runtime/JSObject.cpp: (JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage): LayoutTests: * fast/js/put-direct-index-beyond-vector-length-resize-expected.txt: Added. * fast/js/put-direct-index-beyond-vector-length-resize.html: Added. * fast/js/script-tests/put-direct-index-beyond-vector-length-resize.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
Rubber stamped by Mark Hahnenberg. * runtime/Executable.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120323 Reviewed by Anders Carlsson. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::WebFrameLoaderClient): Remove assertion that frame is passed as construction argument. (WebFrameLoaderClient::createFrame): Call new 'createSubframeWithOwnerElement' * WebCoreSupport/WebFrameLoaderClient.h: Update constructor to handle case of no default frame argument. (WebFrameLoaderClient::setWebFrame): Added. * WebFrame.cpp: (WebFrame::createSubframeWithOwnerElement): Renamed from 'init'. (WebFrame::initWithWebFrameView): Added for new page-driven load path. * WebFrame.h: Added new method signatures. * WebView.cpp: (WebView::initWithFrame): Update to match behavior of other ports. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120314 Reviewed by Darin Adler. Currently with the way that defineProperty works, we leave a stray low bit set in PropertyDescriptor::m_attributes in the following code: var o = {}; Object.defineProperty(o, 100, {writable:true, enumerable:true, configurable:true, value:"foo"}); This is due to the fact that the lowest non-zero attribute (ReadOnly) is represented as 1 << 1 instead of 1 << 0. We then calculate the default attributes as (DontDelete << 1) - 1, which is 0xF, but only the top three bits mean anything. Even in the case above, the top three bits are set to 0 but the bottom bit remains set, which causes us to think m_attributes is non-zero. Since some of these attributes and their corresponding values are exposed in the JavaScriptCore framework's public C API, it's safer to just change how we calculate the default value, which is where the weirdness was originating from in the first place. * runtime/PropertyDescriptor.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120260 Reviewed by Darin Adler. Source/JavaScriptCore: Add an initial implementation of Promises - http://dom.spec.whatwg.org/#promises. - Despite Promises being defined in the DOM, the implementation is being put in JSC in preparation for the Promises eventually being defined in ECMAScript. * CMakeLists.txt: * DerivedSources.make: * DerivedSources.pri: * GNUmakefile.list.am: * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: * JavaScriptCore.xcodeproj/project.pbxproj: * Target.pri: Add new files. * jsc.cpp: Update jsc's GlobalObjectMethodTable to stub out the new QueueTaskToEventLoop callback. This mean's you can't quite use Promises with with the command line tool yet. * interpreter/CallFrame.h: (JSC::ExecState::promisePrototypeTable): (JSC::ExecState::promiseConstructorTable): (JSC::ExecState::promiseResolverPrototypeTable): * runtime/VM.cpp: (JSC::VM::VM): (JSC::VM::~VM): * runtime/VM.h: Add supporting code for the new static lookup tables. * runtime/CommonIdentifiers.h: Add 3 new identifiers, "Promise", "PromiseResolver", and "then". * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::visitChildren): Add supporting code Promise and PromiseResolver's constructors and structures. * runtime/JSGlobalObject.h: (JSC::TaskContext::~TaskContext): Add a new callback to the GlobalObjectMethodTable to post a task on the embedder's runloop. (JSC::JSGlobalObject::promisePrototype): (JSC::JSGlobalObject::promiseResolverPrototype): (JSC::JSGlobalObject::promiseStructure): (JSC::JSGlobalObject::promiseResolverStructure): (JSC::JSGlobalObject::promiseCallbackStructure): (JSC::JSGlobalObject::promiseWrapperCallbackStructure): Add supporting code Promise and PromiseResolver's constructors and structures. * runtime/JSPromise.cpp: Added. * runtime/JSPromise.h: Added. * runtime/JSPromiseCallback.cpp: Added. * runtime/JSPromiseCallback.h: Added. * runtime/JSPromiseConstructor.cpp: Added. * runtime/JSPromiseConstructor.h: Added. * runtime/JSPromisePrototype.cpp: Added. * runtime/JSPromisePrototype.h: Added. * runtime/JSPromiseResolver.cpp: Added. * runtime/JSPromiseResolver.h: Added. * runtime/JSPromiseResolverConstructor.cpp: Added. * runtime/JSPromiseResolverConstructor.h: Added. * runtime/JSPromiseResolverPrototype.cpp: Added. * runtime/JSPromiseResolverPrototype.h: Added. Add Promise implementation. Source/WebCore: Add an initial implementation of Promises - http://dom.spec.whatwg.org/#promises. - Despite Promises being defined in the DOM, the implementation is being put in JSC in preparation for the Promises eventually being defined in ECMAScript. Tests: fast/js/Promise-already-fulfilled.html fast/js/Promise-already-rejected.html fast/js/Promise-already-resolved.html fast/js/Promise-catch-in-workers.html fast/js/Promise-catch.html fast/js/Promise-chain.html fast/js/Promise-exception.html fast/js/Promise-fulfill-in-workers.html fast/js/Promise-fulfill.html fast/js/Promise-init-in-workers.html fast/js/Promise-init.html fast/js/Promise-reject-in-workers.html fast/js/Promise-reject.html fast/js/Promise-resolve-chain.html fast/js/Promise-resolve-in-workers.html fast/js/Promise-resolve-with-then-exception.html fast/js/Promise-resolve-with-then-fulfill.html fast/js/Promise-resolve-with-then-reject.html fast/js/Promise-resolve.html fast/js/Promise-simple-fulfill-inside-callback.html fast/js/Promise-simple-fulfill.html fast/js/Promise-simple-in-workers.html fast/js/Promise-simple.html fast/js/Promise-static-fulfill.html fast/js/Promise-static-reject.html fast/js/Promise-static-resolve.html fast/js/Promise-then-in-workers.html fast/js/Promise-then-without-callbacks-in-workers.html fast/js/Promise-then-without-callbacks.html fast/js/Promise-then.html fast/js/Promise-types.html fast/js/Promise.html * GNUmakefile.list.am: * Target.pri: * UseJSC.cmake: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSBindingsAllInOne.cpp: Add new files. * bindings/js/JSDOMGlobalObjectTask.cpp: Added. (WebCore::JSGlobalObjectCallback::create): (WebCore::JSGlobalObjectCallback::~JSGlobalObjectCallback): (WebCore::JSGlobalObjectCallback::call): (WebCore::JSGlobalObjectCallback::JSGlobalObjectCallback): (WebCore::JSGlobalObjectTask::JSGlobalObjectTask): (WebCore::JSGlobalObjectTask::~JSGlobalObjectTask): (WebCore::JSGlobalObjectTask::performTask): * bindings/js/JSDOMGlobalObjectTask.h: Added. (WebCore::JSGlobalObjectTask::create): Add a new task type to be used with the GlobalObjectMethodTable's new QueueTaskToEventLoop callback. * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::queueTaskToEventLoop): * bindings/js/JSDOMWindowBase.h: Implement the GlobalObjectMethodTable callback, QueueTaskToEventLoop. * bindings/js/JSMainThreadExecState.h: All using JSMainThreadExecState as a simple RAII object. * bindings/js/JSWorkerGlobalScopeBase.cpp: (WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase): (WebCore::JSWorkerGlobalScopeBase::allowsAccessFrom): (WebCore::JSWorkerGlobalScopeBase::supportsProfiling): (WebCore::JSWorkerGlobalScopeBase::supportsRichSourceInfo): (WebCore::JSWorkerGlobalScopeBase::shouldInterruptScript): (WebCore::JSWorkerGlobalScopeBase::javaScriptExperimentsEnabled): (WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop): * bindings/js/JSWorkerGlobalScopeBase.h: Add a GlobalObjectMethodTable and implement QueueTaskToEventLoop. Forward the other callbacks to JSGlobalObject so they retain their existing behavior. LayoutTests: Add tests adapted from the Mozilla and Blink projects. * fast/js/Promise-already-fulfilled-expected.txt: Added. * fast/js/Promise-already-fulfilled.html: Added. * fast/js/Promise-already-rejected-expected.txt: Added. * fast/js/Promise-already-rejected.html: Added. * fast/js/Promise-already-resolved-expected.txt: Added. * fast/js/Promise-already-resolved.html: Added. * fast/js/Promise-catch-expected.txt: Added. * fast/js/Promise-catch-in-workers-expected.txt: Added. * fast/js/Promise-catch-in-workers.html: Added. * fast/js/Promise-catch.html: Added. * fast/js/Promise-chain-expected.txt: Added. * fast/js/Promise-chain.html: Added. * fast/js/Promise-exception-expected.txt: Added. * fast/js/Promise-exception.html: Added. * fast/js/Promise-expected.txt: Added. * fast/js/Promise-fulfill-expected.txt: Added. * fast/js/Promise-fulfill-in-workers-expected.txt: Added. * fast/js/Promise-fulfill-in-workers.html: Added. * fast/js/Promise-fulfill.html: Added. * fast/js/Promise-init-expected.txt: Added. * fast/js/Promise-init-in-workers-expected.txt: Added. * fast/js/Promise-init-in-workers.html: Added. * fast/js/Promise-init.html: Added. * fast/js/Promise-reject-expected.txt: Added. * fast/js/Promise-reject-in-workers-expected.txt: Added. * fast/js/Promise-reject-in-workers.html: Added. * fast/js/Promise-reject.html: Added. * fast/js/Promise-resolve-chain-expected.txt: Added. * fast/js/Promise-resolve-chain.html: Added. * fast/js/Promise-resolve-expected.txt: Added. * fast/js/Promise-resolve-in-workers-expected.txt: Added. * fast/js/Promise-resolve-in-workers.html: Added. * fast/js/Promise-resolve-with-then-exception-expected.txt: Added. * fast/js/Promise-resolve-with-then-exception.html: Added. * fast/js/Promise-resolve-with-then-fulfill-expected.txt: Added. * fast/js/Promise-resolve-with-then-fulfill.html: Added. * fast/js/Promise-resolve-with-then-reject-expected.txt: Added. * fast/js/Promise-resolve-with-then-reject.html: Added. * fast/js/Promise-resolve.html: Added. * fast/js/Promise-simple-expected.txt: Added. * fast/js/Promise-simple-fulfill-expected.txt: Added. * fast/js/Promise-simple-fulfill-inside-callback-expected.txt: Added. * fast/js/Promise-simple-fulfill-inside-callback.html: Added. * fast/js/Promise-simple-fulfill.html: Added. * fast/js/Promise-simple-in-workers-expected.txt: Added. * fast/js/Promise-simple-in-workers.html: Added. * fast/js/Promise-simple.html: Added. * fast/js/Promise-static-fulfill-expected.txt: Added. * fast/js/Promise-static-fulfill.html: Added. * fast/js/Promise-static-reject-expected.txt: Added. * fast/js/Promise-static-reject.html: Added. * fast/js/Promise-static-resolve-expected.txt: Added. * fast/js/Promise-static-resolve.html: Added. * fast/js/Promise-then-expected.txt: Added. * fast/js/Promise-then-in-workers-expected.txt: Added. * fast/js/Promise-then-in-workers.html: Added. * fast/js/Promise-then-without-callbacks-expected.txt: Added. * fast/js/Promise-then-without-callbacks-in-workers-expected.txt: Added. * fast/js/Promise-then-without-callbacks-in-workers.html: Added. * fast/js/Promise-then-without-callbacks.html: Added. * fast/js/Promise-then.html: Added. * fast/js/Promise-types-expected.txt: Added. * fast/js/Promise-types.html: Added. * fast/js/Promise.html: Added. * fast/js/resources/Promise-catch-in-workers.js: Added. * fast/js/resources/Promise-fulfill-in-workers.js: Added. * fast/js/resources/Promise-init-in-workers.js: Added. * fast/js/resources/Promise-reject-in-workers.js: Added. * fast/js/resources/Promise-resolve-in-workers.js: Added. * fast/js/resources/Promise-simple-in-workers.js: Added. * fast/js/resources/Promise-then-in-workers.js: Added. * fast/js/resources/Promise-then-without-callbacks-in-workers.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-