1. 26 Sep, 2013 26 commits
    • msaboff@apple.com's avatar
      VirtualRegister should be a class · 1796ad0f
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121732
      
      Reviewed by Geoffrey Garen.
      
      This is a refactoring change.  Changed VirtualRegister from an enum to a class.
      Moved Operands::operandIsArgument(), operandToArgument(), argumentToOperand()
      and the similar functions for locals to VirtualRegister class.
      
      This is in preparation for changing the offset for the first local register from
      0 to -1.  This is needed since most native calling conventions have the architected
      frame pointer (e.g. %rbp for X86) point at the slot that stores the previous frame
      pointer.  Local values start below that address.
      
      * bytecode/CodeBlock.cpp:
      * bytecode/CodeBlock.h:
      * bytecode/Instruction.h:
      * bytecode/LazyOperandValueProfile.h:
      * bytecode/MethodOfGettingAValueProfile.cpp:
      * bytecode/Operands.h:
      * bytecode/UnlinkedCodeBlock.cpp:
      * bytecode/UnlinkedCodeBlock.h:
      * bytecode/ValueRecovery.h:
      * bytecode/VirtualRegister.h:
      * bytecompiler/BytecodeGenerator.cpp:
      * bytecompiler/BytecodeGenerator.h:
      * bytecompiler/RegisterID.h:
      * debugger/DebuggerCallFrame.cpp:
      * dfg/DFGAbstractHeap.h:
      * dfg/DFGAbstractInterpreterInlines.h:
      * dfg/DFGArgumentPosition.h:
      * dfg/DFGArgumentsSimplificationPhase.cpp:
      * dfg/DFGByteCodeParser.cpp:
      * dfg/DFGCFGSimplificationPhase.cpp:
      * dfg/DFGCPSRethreadingPhase.cpp:
      * dfg/DFGCapabilities.cpp:
      * dfg/DFGConstantFoldingPhase.cpp:
      * dfg/DFGFlushLivenessAnalysisPhase.cpp:
      * dfg/DFGGraph.cpp:
      * dfg/DFGGraph.h:
      * dfg/DFGJITCode.cpp:
      * dfg/DFGNode.h:
      * dfg/DFGOSREntry.cpp:
      * dfg/DFGOSREntrypointCreationPhase.cpp:
      * dfg/DFGOSRExit.h:
      * dfg/DFGOSRExitCompiler32_64.cpp:
      * dfg/DFGOSRExitCompiler64.cpp:
      * dfg/DFGRegisterBank.h:
      * dfg/DFGScoreBoard.h:
      * dfg/DFGSpeculativeJIT.cpp:
      * dfg/DFGSpeculativeJIT.h:
      * dfg/DFGSpeculativeJIT64.cpp:
      * dfg/DFGValidate.cpp:
      * dfg/DFGValueRecoveryOverride.h:
      * dfg/DFGVariableAccessData.h:
      * dfg/DFGVariableEvent.h:
      * dfg/DFGVariableEventStream.cpp:
      * dfg/DFGVirtualRegisterAllocationPhase.cpp:
      * ftl/FTLExitArgumentForOperand.h:
      * ftl/FTLLink.cpp:
      * ftl/FTLLowerDFGToLLVM.cpp:
      * ftl/FTLOSREntry.cpp:
      * ftl/FTLOSRExit.cpp:
      * ftl/FTLOSRExit.h:
      * ftl/FTLOSRExitCompiler.cpp:
      * interpreter/CallFrame.h:
      * interpreter/Interpreter.cpp:
      * jit/AssemblyHelpers.h:
      * jit/JIT.h:
      * jit/JITCall.cpp:
      * jit/JITInlines.h:
      * jit/JITOpcodes.cpp:
      * jit/JITOpcodes32_64.cpp:
      * jit/JITStubs.cpp:
      * llint/LLIntSlowPaths.cpp:
      * profiler/ProfilerBytecodeSequence.cpp:
      * runtime/CommonSlowPaths.cpp:
      * runtime/JSActivation.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1796ad0f
    • eric.carlson@apple.com's avatar
      [MediaStream] Cleanup platform interface · 44da78ad
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121935
      
      Reviewed by Jer Noble.
      
      No new tests, tests will be updated in the next patch.
      
      * CMakeLists.txt: Remove MediaStreamComponent.cpp.
      * GNUmakefile.list.am: Remove MediaStreamComponent.h|cpp and MediaStreamSourcesQueryClient.h. 
          Add MediaStreamConstraintsValidationClient.h and MediaStreamCreationClient.h.
      
      * Modules/mediastream/MediaStream.cpp:
      (WebCore::processTrack): Duplicate MediaStreamSource when necessary to work around bug 121954.
      (WebCore::createFromSourceVectors): MediaStreamCenter::instance -> MediaStream::sharedStreamCenter.
      (WebCore::MediaStream::MediaStream): *Components -> *Streams.
      (WebCore::MediaStream::setEnded): New.
      (WebCore::MediaStream::stop):  MediaStreamCenter::instance -> MediaStream::sharedStreamCenter.
      (WebCore::MediaStream::addTrack): Append the track parameter rather than duplicating it, as per spec.
      (WebCore::MediaStream::removeTrack): *Components -> *Streams.
      (WebCore::MediaStream::trackDidEnd): Renamed from trackEnded.
      (WebCore::MediaStream::streamDidEnd): Renamed from streamEnded.
      (WebCore::MediaStream::addRemoteSource): Renamed from addRemoteTrack. *Components -> *Streams.
      (WebCore::MediaStream::removeRemoteSource): Renamed from removeRemoteTrack. *Components -> *Streams.
      * Modules/mediastream/MediaStream.h:
      
      * Modules/mediastream/MediaStreamTrack.cpp:
      (WebCore::MediaStreamTrack::create): *Component -> *Stream.
      (WebCore::MediaStreamTrack::MediaStreamTrack): Don't assume source is valid.
      (WebCore::MediaStreamTrack::~MediaStreamTrack): Ditto.
      (WebCore::MediaStreamTrack::kind): Ditto. AtomicString -> const AtomicString&.
      (WebCore::MediaStreamTrack::setSource): Moved from .h file.
      (WebCore::MediaStreamTrack::id): Don't assume source is valid. Create ID when the source doesn't have one.
      (WebCore::MediaStreamTrack::label): Don't assume source is valid.
      (WebCore::MediaStreamTrack::enabled): 
      (WebCore::MediaStreamTrack::setEnabled): *Component -> *Stream. MediaStreamCenter::instance -> MediaStreamCenter::shared.
      (WebCore::MediaStreamTrack::readyState): "muted" is not a readyState, but "new" is.
      (WebCore::MediaStreamTrack::getSources): MediaStreamCenter::instance -> MediaStreamCenter::shared.
      (WebCore::MediaStreamTrack::ended): *Component -> *Stream.
      (WebCore::MediaStreamTrack::sourceChangedState): Dispatch "started" and "unmuted" events.
      (WebCore::MediaStreamTrack::trackDidEnd): Renamed from didEndTrack. m_component -> m_source.
      * Modules/mediastream/MediaStreamTrack.h:
      
      * Modules/mediastream/RTCDTMFSender.cpp:
      (WebCore::RTCDTMFSender::create): track->component() -> track->source();
      
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::didRemoveRemoteStream): Ditto.
      
      * Modules/mediastream/RTCStatsRequestImpl.cpp:
      (WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl): Ditto.
      (WebCore::RTCStatsRequestImpl::component): Removed, it was unused.
      * Modules/mediastream/RTCStatsRequestImpl.h:
      
      * Modules/mediastream/UserMediaClient.h:
      * Modules/mediastream/UserMediaController.h:
      (WebCore::UserMediaController::requestPermission): Renamed from requestUserMedia, get rid of source
          vector parameters.
      (WebCore::UserMediaController::cancelRequest): Renamed from cancelUserMediaRequest.
      
      * Modules/mediastream/UserMediaRequest.cpp:
      (WebCore::parseOptions): MediaConstraintsImpl -> MediaConstraints.
      (WebCore::UserMediaRequest::create): Ditto.
      (WebCore::UserMediaRequest::UserMediaRequest): Ditto.
      (WebCore::UserMediaRequest::securityOrigin): New.
      (WebCore::UserMediaRequest::start): Request constraint validation.
      (WebCore::UserMediaRequest::constraintsValidated): New. Callback from media engine when constraints
          can be supported.
      (WebCore::UserMediaRequest::requestPermission): New. Ask user media client for permission to access media.
      (WebCore::UserMediaRequest::userMediaAccessGranted): New. Access has been granted.
      (WebCore::UserMediaRequest::createMediaStream): New. Allowed to access media, ask media engine
          to create stream sources.
      (WebCore::UserMediaRequest::userMediaAccessDenied): New. User media client has denied access request.
      (WebCore::UserMediaRequest::constraintsInvalid): New. Media engine can not support constraints.
      (WebCore::UserMediaRequest::didCreateStream): New. Media engine has created stream sources.
      (WebCore::UserMediaRequest::callSuccessHandler): New. Create stream from sources and call success handler.
      (WebCore::UserMediaRequest::failedToCreateStreamWithConstraintsError): Renamed from constraintFailure.
      (WebCore::UserMediaRequest::failedToCreateStreamWithPermissionError): Renamed from permissionFailure.
      (WebCore::UserMediaRequest::callErrorHandler): 
      (WebCore::UserMediaRequest::contextDestroyed): cancelUserMediaRequest -> cancelRequest.
      * Modules/mediastream/UserMediaRequest.h:
      
      * Modules/webaudio/AudioContext.cpp:
      (WebCore::AudioContext::createMediaStreamSource): localAudio->component()->source() -> localAudio->source().
      
      * Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
      (WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): MediaStreamSource::TypeAudio ->
          MediaStreamSource::Audio, MediaStreamSource::ReadyStateLive -> MediaStreamSource::Live.
          MediaStreamCenter::instance -> MediaStreamCenter::shared.
      
      * WebCore.exp.in: Export new symbols.
      
      * WebCore.xcodeproj/project.pbxproj: Add new files and remove deleted files.
      
      * dom/EventNames.h: Define "started" event.
      
      * platform/mediastream/MediaStreamCenter.cpp:
      (WebCore::mediaStreamCenterOverride): Make it possible to override the shared stream center. Will
          be used for testing in a later patch.
      (WebCore::MediaStreamCenter::shared): Renamed from instance. Return current stream center.
      (WebCore::MediaStreamCenter::setSharedStreamCenter): Override current stream center.
      (WebCore::MediaStreamCenter::endLocalMediaStream): Never call the descriptor client, always call
          the descriptor and let it deal with the client.
      * platform/mediastream/MediaStreamCenter.h:
      
      * platform/mediastream/MediaStreamComponent.cpp: Removed.
      * platform/mediastream/MediaStreamComponent.h: Removed.
      
      * platform/mediastream/MediaStreamConstraintsValidationClient.h: Added.
      * platform/mediastream/MediaStreamCreationClient.h: Added.
      
      * platform/mediastream/MediaStreamDescriptor.cpp:
      (WebCore::MediaStreamDescriptor::addSource): *Component -> *Source.
      (WebCore::MediaStreamDescriptor::removeSource): Ditto.
      (WebCore::MediaStreamDescriptor::addRemoteSource): Ditto.
      (WebCore::MediaStreamDescriptor::removeRemoteSource): Ditto.
      (WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Ditto.
      (WebCore::MediaStreamDescriptor::setEnded): Ditto. Set source readyStates to Ended.
      * platform/mediastream/MediaStreamDescriptor.h:
      
      * platform/mediastream/MediaStreamSource.cpp:
      (WebCore::MediaStreamSource::MediaStreamSource): Initialize new member variables.
      (WebCore::MediaStreamSource::setReadyState): Early return when the state hasn't changed.
      (WebCore::MediaStreamSource::setStream): New.
      (WebCore::MediaStreamSource::setMuted): New.
      * platform/mediastream/MediaStreamSource.h:
      
      * platform/mediastream/MediaStreamSourcesQueryClient.h: Removed.
      
      * platform/mediastream/RTCPeerConnectionHandler.h:
      * platform/mediastream/RTCStatsRequest.h:
      
      * platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp: Update for new MediaStreamCenter API.
      * platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
      
      * platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp: Ditto.
      * platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
      
      * platform/mediastream/mac/MediaStreamCenterMac.cpp: Ditto.
      * platform/mediastream/mac/MediaStreamCenterMac.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44da78ad
    • timothy_horton@apple.com's avatar
      Tiled drawing should not imply threaded scrolling · 017ef58c
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121874
      <rdar://problem/15071494>
      
      Reviewed by Sam Weinig.
      
      * Shared/DrawingAreaInfo.h:
      We can have DrawingAreaTypeTiledCoreAnimation without threaded scrolling.
      
      * Shared/WebPreferencesStore.h:
      * UIProcess/API/C/WKPreferences.cpp:
      (WKPreferencesSetThreadedScrollingEnabled):
      (WKPreferencesGetThreadedScrollingEnabled):
      * UIProcess/API/C/WKPreferencesPrivate.h:
      Add a preference for threaded scrolling.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView WebKit::]):
      * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
      * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
      * WebProcess/WebPage/DrawingArea.cpp:
      (WebKit::DrawingArea::create):
      * WebProcess/WebPage/DrawingArea.h:
      Make it so we can use TiledCoreAnimationDrawingArea without ENABLE(THREADED_SCROLLING).
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::shouldUseTiledBackingForFrame):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      Override shouldUseTiledBackingForFrame; ask the drawing area if we want a tiled backing for the given frame.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      (WebKit::WebPage::~WebPage):
      * WebProcess/WebPage/WebPage.h:
      Move attaching and detaching the scrolling tree into WebPage.
      Store whether or not this page is going to use threaded scrolling once, as this
      cannot change through the life of a page.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
      (WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
      Move attaching and detaching the scrolling tree into WebPage.
      
      (WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
      (WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
      (WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
      (WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
      Only do scrolling coordinator work if we have a scrolling coordinator.
      
      (WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrame):
      TiledCoreAnimationDrawingArea always wants a tiled backing for the main frame.
      
      No new tests; a near-future patch is going to put the majority of layout
      tests into the tiled-drawing-without-threaded-scrolling mode.
      
      * page/ChromeClient.h:
      (WebCore::ChromeClient::shouldUseTiledBackingForFrame):
      Add a ChromeClient callback to determine whether a given frame wants a TiledBacking for its contents.
      
      * page/FrameView.h:
      * WebCore.exp.in:
      Make isMainFrameView public and export it for use in WebKit2.
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::RenderLayerBacking):
      Make use of shouldUseTiledBackingForFrame instead of predicating the
      main frame using a tile cache on whether we have a scrolling coordinator.
      
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::mainFrameBackingIsTiled): Added.
      
      (WebCore::RenderLayerCompositor::shouldCompositeOverflowControls):
      (WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
      (WebCore::RenderLayerCompositor::requiresContentShadowLayer):
      All of these checks for existence of a scrollingCoordinator should actually
      key off whether we're using tiled drawing at the root; they have nothing
      to do with threaded scrolling.
      
      * rendering/RenderLayerCompositor.h:
      
      * WebKitTestRunner/mac/PlatformWebViewMac.mm:
      (WTR::PlatformWebView::PlatformWebView):
      The existing tiled-drawing layout tests require threaded scrolling to be enabled.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      017ef58c
    • beidson@apple.com's avatar
      Mark IDBDatabase "FINAL" now that http://webkit.org/b/121747 is fixed. · c4c6b82c
      beidson@apple.com authored
      Rubberstamped by Andreas Kling
      
      * Modules/indexeddb/IDBDatabase.h: Mark this class FINAL.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4c6b82c
    • akling@apple.com's avatar
      One more IndexedDB rebaseline. · 97036e89
      akling@apple.com authored
      * js/dom/global-constructors-attributes-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97036e89
    • andersca@apple.com's avatar
      Weak should have a move constructor and move assignment operator · b366a0c2
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121963
      
      Reviewed by Oliver Hunt.
      
      This is the first step towards getting rid of PassWeak.
      
      * API/JSClassRef.cpp:
      (OpaqueJSClass::prototype):
      * heap/Weak.h:
      * heap/WeakInlines.h:
      (JSC::::Weak):
      (JSC::::leakImpl):
      * runtime/SimpleTypedArrayController.cpp:
      (JSC::SimpleTypedArrayController::toJS):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b366a0c2
    • mhahnenberg@apple.com's avatar
      op_to_this shouldn't use value profiling · c5684714
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121920
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Currently it's the only opcode that uses m_singletonValue, which is unnecessary. Our current plan is
      to remove m_singletonValue so that GenGC can have a simpler story for handling CodeBlocks/FunctionExecutables
      during nursery collections.
      
      This patch adds an inline cache for the Structure of to_this so it no longer depends on the ValueProfile's
      m_singletonValue. Since nobody uses m_singletonValue now, this patch also removes m_singletonValue from
      ValueProfile.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::CodeBlock):
      (JSC::CodeBlock::finalizeUnconditionally):
      (JSC::CodeBlock::stronglyVisitStrongReferences):
      (JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
      (JSC::CodeBlock::updateAllValueProfilePredictions):
      (JSC::CodeBlock::updateAllPredictions):
      (JSC::CodeBlock::shouldOptimizeNow):
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::updateAllValueProfilePredictions):
      (JSC::CodeBlock::updateAllPredictions):
      * bytecode/LazyOperandValueProfile.cpp:
      (JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
      * bytecode/LazyOperandValueProfile.h:
      * bytecode/ValueProfile.h:
      (JSC::ValueProfileBase::ValueProfileBase):
      (JSC::ValueProfileBase::briefDescription):
      (JSC::ValueProfileBase::dump):
      (JSC::ValueProfileBase::computeUpdatedPrediction):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::BytecodeGenerator):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_to_this):
      (JSC::JIT::emitSlow_op_to_this):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::emit_op_to_this):
      (JSC::JIT::emitSlow_op_to_this):
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      * runtime/CommonSlowPaths.cpp:
      (JSC::SLOW_PATH_DECL):
      
      LayoutTests:
      
      Updated a couple tests that waited for two DFG compiles, but with this patch we
      don't do two compiles any more, so we don't want to wait forever.
      
      * js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-other.js:
      * js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-string.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5684714
    • akling@apple.com's avatar
      Rebaseline some tests after IndexedDB was enabled. · 0169d5fc
      akling@apple.com authored
      * js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
      * js/dom/global-constructors-attributes-shared-worker-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0169d5fc
    • commit-queue@webkit.org's avatar
      Inset box-shadows fail to round around corners when border-radius is set in vh/vw units. · 87a8fabf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119187
      
      Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-26
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Border-radius properties were not applied incase its values
      were given in vh, vw, vmax, vmin units.
      
      Tests: fast/css/border-radius-inset-box-shadow-viewportlength.html
             fast/css/border-radius-viewport-height.html
             fast/css/border-radius-viewport-vmax.html
             fast/css/border-radius-viewport-vmin.html
      
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::ApplyPropertyBorderRadius::applyValue):
      (WebCore::ApplyPropertyComputeLength::applyValue):
      * css/StyleResolver.h:
      Calculating the border-radius values which has been specified
      in viewport units.The vh/vw units are calcultated as percent of
      viewport height and viewport width respectively. 1vmax: 1vw or 1vh,
      whatever is largest.1vmin: 1vw or 1vh, whatever is smallest.
      
      LayoutTests:
      
      * fast/css/border-radius-inset-box-shadow-viewportlength-expected-mismatch.html: Added.
      * fast/css/border-radius-inset-box-shadow-viewportlength.html: Added.
      * fast/css/border-radius-viewport-height-expected-mismatch.html: Added.
      * fast/css/border-radius-viewport-height.html: Added.
      * fast/css/border-radius-viewport-vmax-expected-mismatch.html: Added.
      * fast/css/border-radius-viewport-vmax.html: Added.
      * fast/css/border-radius-viewport-vmin-expected-mismatch.html: Added.
      * fast/css/border-radius-viewport-vmin.html: Added.
      Added new tests for verifying that box-shadow and border-radius properties
      are applied when its values are viewport units.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87a8fabf
    • seokju@webkit.org's avatar
      Fix ordered comparison warnings in BitmapImage::drawPattern · 45b5ad99
      seokju@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121945
      
      Reviewed by Darin Adler.
      
      No new tests, no behavior change.
      
      * platform/graphics/BitmapImage.cpp:
      (WebCore::BitmapImage::drawPattern):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45b5ad99
    • oliver@apple.com's avatar
      Implement prefixed-destructuring assignment · aeca5dcd
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121930
      
      Reviewed by Mark Hahnenberg.
      
      Source/JavaScriptCore:
      
      This is mostly simple - the semantics of deconstruction are already
      present in the language, so most of the complexity (if you call it
      that) is addition of new AST nodes, and parsing the syntax.
      
      In order to get correct semantics for the parameter lists, FunctionParameters
      now needs to store refcounted references to the parameter patterns.
      There's also a little work to ensure that variable creation and assignment
      occurs in the correct order while the BytecodeGenerator is being constructed.
      
      * bytecode/UnlinkedCodeBlock.cpp:
      (JSC::UnlinkedFunctionExecutable::paramString):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::BytecodeGenerator):
      * bytecompiler/BytecodeGenerator.h:
      (JSC::BytecodeGenerator::emitExpressionInfo):
      * bytecompiler/NodesCodegen.cpp:
      (JSC::ForInNode::emitBytecode):
      (JSC::DeconstructingAssignmentNode::emitBytecode):
      (JSC::DeconstructionPatternNode::~DeconstructionPatternNode):
      (JSC::ArrayPatternNode::emitBytecode):
      (JSC::ArrayPatternNode::emitDirectBinding):
      (JSC::ArrayPatternNode::toString):
      (JSC::ArrayPatternNode::collectBoundIdentifiers):
      (JSC::ObjectPatternNode::toString):
      (JSC::ObjectPatternNode::emitBytecode):
      (JSC::ObjectPatternNode::collectBoundIdentifiers):
      (JSC::BindingNode::emitBytecode):
      (JSC::BindingNode::toString):
      (JSC::BindingNode::collectBoundIdentifiers):
      * parser/ASTBuilder.h:
      (JSC::ASTBuilder::createFormalParameterList):
      (JSC::ASTBuilder::createForInLoop):
      (JSC::ASTBuilder::addVar):
      (JSC::ASTBuilder::createDeconstructingAssignment):
      (JSC::ASTBuilder::createArrayPattern):
      (JSC::ASTBuilder::appendArrayPatternSkipEntry):
      (JSC::ASTBuilder::appendArrayPatternEntry):
      (JSC::ASTBuilder::createObjectPattern):
      (JSC::ASTBuilder::appendObjectPatternEntry):
      (JSC::ASTBuilder::createBindingLocation):
      * parser/NodeConstructors.h:
      (JSC::CommaNode::CommaNode):
      (JSC::ParameterNode::ParameterNode):
      (JSC::ForInNode::ForInNode):
      (JSC::DeconstructionPatternNode::DeconstructionPatternNode):
      (JSC::ArrayPatternNode::ArrayPatternNode):
      (JSC::ArrayPatternNode::create):
      (JSC::ObjectPatternNode::ObjectPatternNode):
      (JSC::ObjectPatternNode::create):
      (JSC::BindingNode::create):
      (JSC::BindingNode::BindingNode):
      (JSC::DeconstructingAssignmentNode::DeconstructingAssignmentNode):
      * parser/Nodes.cpp:
      (JSC::FunctionParameters::create):
      (JSC::FunctionParameters::FunctionParameters):
      (JSC::FunctionParameters::~FunctionParameters):
      * parser/Nodes.h:
      (JSC::ExpressionNode::isDeconstructionNode):
      (JSC::ArrayNode::elements):
      (JSC::CommaNode::append):
      (JSC::ParameterNode::pattern):
      (JSC::FunctionParameters::at):
      (JSC::FunctionParameters::patterns):
      (JSC::DeconstructionPatternNode::isBindingNode):
      (JSC::DeconstructionPatternNode::emitDirectBinding):
      (JSC::ArrayPatternNode::appendIndex):
      (JSC::ObjectPatternNode::appendEntry):
      (JSC::ObjectPatternNode::Entry::Entry):
      (JSC::BindingNode::boundProperty):
      (JSC::BindingNode::isBindingNode):
      (JSC::DeconstructingAssignmentNode::bindings):
      (JSC::DeconstructingAssignmentNode::isLocation):
      (JSC::DeconstructingAssignmentNode::isDeconstructionNode):
      * parser/Parser.cpp:
      (JSC::::Parser):
      (JSC::::parseVarDeclaration):
      (JSC::::parseVarDeclarationList):
      (JSC::::createBindingPattern):
      (JSC::::parseDeconstructionPattern):
      (JSC::::parseForStatement):
      (JSC::::parseFormalParameters):
      (JSC::::parseAssignmentExpression):
      * parser/Parser.h:
      (JSC::Scope::declareBoundParameter):
      (JSC::Parser::declareBoundParameter):
      * parser/SyntaxChecker.h:
      (JSC::SyntaxChecker::createFormalParameterList):
      (JSC::SyntaxChecker::addVar):
      (JSC::SyntaxChecker::operatorStackPop):
      * runtime/JSONObject.cpp:
      (JSC::escapeStringToBuilder):
      * runtime/JSONObject.h:
      
      LayoutTests:
      
      Add enw tests, and update old ones.
      
      * js/destructuring-assignment-expected.txt: Added.
      * js/destructuring-assignment.html: Added.
      * js/mozilla/strict/13.1-expected.txt:
      * js/mozilla/strict/regress-532254-expected.txt:
      * js/mozilla/strict/script-tests/13.1.js:
      * js/regress/destructuring-arguments-expected.txt: Added.
      * js/regress/destructuring-arguments-length-expected.txt: Added.
      * js/regress/destructuring-arguments-length.html: Added.
      * js/regress/destructuring-arguments.html: Added.
      * js/regress/destructuring-swap-expected.txt: Added.
      * js/regress/destructuring-swap.html: Added.
      * js/regress/script-tests/destructuring-arguments-length.js: Added.
      (foo):
      * js/regress/script-tests/destructuring-arguments.js: Added.
      (foo):
      * js/regress/script-tests/destructuring-swap.js: Added.
      (foo):
      * js/script-tests/destructuring-assignment.js: Added.
      (testDestructuring):
      (testDeconstructArgs):
      (testDeconstructArgLength):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aeca5dcd
    • berto@igalia.com's avatar
      Unreviewed GTK gardening. · 64ab338c
      berto@igalia.com authored
      Unskip media/context-menu-actions.html which is passing now.
      
      * platform/gtk-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64ab338c
    • kov@webkit.org's avatar
      [GTK] Tons of warnings caused by using FORTIFY_SOURCE in an unoptimized build · 07e17265
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121836
      
      Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-09-26
      Reviewed by Martin Robinson.
      
      * Source/autotools/SetupCompilerFlags.m4: only consider enabling FORTIFY_SOURCE if optimizations have
      been enabled, since they are required for FORTIFY_SOURCE to work, and enabling FORTIFY_SOURCE unconditionally
      generates warnings in newer glibc.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07e17265
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r156457. · ace2fd28
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/156457
      https://bugs.webkit.org/show_bug.cgi?id=121960
      
      Broke webkitpy tests. (Requested by kling on #webkit).
      
      * Scripts/webkitpy/port/xvfbdriver.py:
      (XvfbDriver._start):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ace2fd28
    • mario@webkit.org's avatar
      [GTK][WK2] Logging of accessibility events is not disabled between tests · ee242d91
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121957
      
      Unreviewed gardening again. Now moving the expected flakiness to
      the WebKit2GTK+ port, where it actually belongs to.
      
      * platform/gtk-wk2/TestExpectations: Added expectations.
      * platform/gtk/TestExpectations: Removed expectations.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee242d91
    • mario@webkit.org's avatar
      [GTK] Logging of accessibility events is not disabled between tests · 70a54ced
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121957
      
      Unreviewed gardening. Marking accessibility tests as flaky while
      an issue with the logging of accessibility events is investigated.
      
      * platform/gtk/TestExpectations: Added flaky expectations.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70a54ced
    • akling@apple.com's avatar
      Remove empty JSFooCustom.cpp files. · ef24047f
      akling@apple.com authored
      <https://webkit.org/b/121955>
      
      Reviewed by Anders Carlsson.
      
      There's no sense in slowing down build times with empty files that
      still include a bunch of headers.
      
      * bindings/js/JSAudioBufferCustom.cpp: Removed.
      * bindings/js/JSCSSFontFaceRuleCustom.cpp: Removed.
      * bindings/js/JSCSSImportRuleCustom.cpp: Removed.
      * bindings/js/JSCSSMediaRuleCustom.cpp: Removed.
      * bindings/js/JSCSSPageRuleCustom.cpp: Removed.
      * bindings/js/JSCSSStyleRuleCustom.cpp: Removed.
      * bindings/js/JSDOMImplementationCustom.cpp: Removed.
      * bindings/js/JSDOMTokenListCustom.cpp: Removed.
      * bindings/js/JSHTMLStyleElementCustom.cpp: Removed.
      * bindings/js/JSMediaListCustom.cpp: Removed.
      * bindings/js/JSProcessingInstructionCustom.cpp: Removed.
      * bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp: Removed.
      * bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp: Removed.
      * bindings/js/JSXMLHttpRequestUploadCustom.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef24047f
    • zandobersek@gmail.com's avatar
      XvfbDriver should set up Xvfb instances providing screens of 8-bit depth · 4b2bd98a
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121951
      
      Reviewed by Carlos Garcia Campos.
      
      Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
      software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
      500 layout tests that trigger accelerated compositing to be used.
      
      * Scripts/webkitpy/port/xvfbdriver.py:
      (XvfbDriver._start):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b2bd98a
    • commit-queue@webkit.org's avatar
      [Qt] Remove PassTraits.h from WTF.pro. · bedbe27b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121946
      
      Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-26
      Reviewed by Andreas Kling.
      
      * WTF.pro: Remove PassTraits.h as this file disappeared in r156298.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bedbe27b
    • mario@webkit.org's avatar
      REGRESSION(r144831-r144846):Crashes in... · 0afb4996
      mario@webkit.org authored
      REGRESSION(r144831-r144846):Crashes in accessibility/aria-hidden-with-elements.html, accessibility/table-with-hidden-head-section.html
      https://bugs.webkit.org/show_bug.cgi?id=112152
      
      Unreviewed GTK gardening. Removed crash expectations now passing.
      
      * platform/gtk/TestExpectations: Removed crashing expectations
      that are now passing after r156141-r156209.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0afb4996
    • mario@webkit.org's avatar
      Unreviewed GTK gardening. Remove failure expectation for test passing after r156209. · 3f925f4e
      mario@webkit.org authored
      * platform/gtk-wk2/TestExpectations: Removed failure expectation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f925f4e
    • commit-queue@webkit.org's avatar
      [EFL] Remove inappropriate expectations for tests that are now passing on EFL port · 83e22f4c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121897
      
      Unreviewed EFL gardening.
      
      Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-26
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83e22f4c
    • commit-queue@webkit.org's avatar
      [EFL] Add baselines for editing/selection/paragraph-granularity.html · ac96e44e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121842
      
      Unreviewed EFL gardening.
      
      Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-26
      
      * platform/efl/TestExpectations: Removing the corresponding entry.
      * platform/efl/editing/selection/paragraph-granularity-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac96e44e
    • commit-queue@webkit.org's avatar
      [CSS Regions] The layers from the flow thread should be collected under the regions' layers. · e858b116
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120457
      
      Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-09-26
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      This patch is based on the work of Alexandru Chiculita at https://bugs.webkit.org/attachment.cgi?id=203872&action=review
      
      The composited layers inside the named flow threads are collected as part of the regions.
      When a region displays a layer that needs accelerated compositing we activate the accelerated compositing for
      that region too (inside RenderFlowThread::updateAllLayerToRegionMappings).
      
      Tests: fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html
             fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html
             fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html
             fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html
             fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html
             fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html
             fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html
             fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html
             fast/regions/layers/accelerated-compositing/z-index.html: Added.
             fast/regions/layers/accelerated-compositing/z-index-update.html: Added.
      
      * rendering/FlowThreadController.cpp:
      (WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::layout): When the layout of the flow thread is over (including the 2 phase layout),
      we update all the mappings between the layers inside the flow thread and the regions where those layers will be
      painted.
      (WebCore::RenderFlowThread::hasCompositingRegionDescendant): Whether any of the regions has a compositing descendant.
      (WebCore::RenderFlowThread::getLayerListForRegion):
      (WebCore::RenderFlowThread::regionForCompositedLayer):
      (WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
      (WebCore::RenderFlowThread::updateLayerToRegionMappings): Triggers an update of the layers if a layer has moved
      from a region to another since the last update.
      (WebCore::RenderFlowThread::updateAllLayerToRegionMappings):
      * rendering/RenderFlowThread.h:
      * rendering/RenderGeometryMap.cpp:
      (WebCore::RenderGeometryMap::pushRenderFlowThread):
      * rendering/RenderGeometryMap.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::calculateLayerBounds): The RenderNamedFlowThread is ignored when we calculate the bounds
      of the RenderView.
      * rendering/RenderLayer.h:
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::shouldClipCompositedBounds): Not if it's inside an out of flow Flow Thread.
      (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Now adjusts the ancestorCompositingBounds for the FlowThread.
      (WebCore::enclosingFlowThreadAncestor):
      (WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Make sure that the region propagates
      its borders, paddings, outlines or box-shadows to layers inside it.
      * rendering/RenderLayerBacking.h:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::computeCompositingRequirements): Now calls computeRegionCompositingRequirements.
      (WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
      (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Do not iterate the RenderFlowThread directly. We
      are going to collect composited layers as part of regions.
      (WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree):
      (WebCore::RenderLayerCompositor::canBeComposited): CSS Regions flow threads do not need to be composited as we
      use composited RenderRegions to render the background of the RenderFlowThread.
      (WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): If it's a region.
      * rendering/RenderLayerCompositor.h:
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):
      * rendering/RenderMultiColumnSet.h:
      * rendering/RenderElement.cpp:
      (WebCore::RenderObject::propagateStyleToAnonymousChildren): Not for RenderFlowThreads, as they are updated
      through the RenderView::styleDidChange function.
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::setRequiresLayerForCompositing):
      (WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect):
      * rendering/RenderRegion.h:
      (WebCore::toRenderRegion):
      * rendering/RenderRegionSet.h:
      (WebCore::RenderRegionSet::requiresLayer): Never.
      * rendering/RenderTreeAsText.cpp:
      (WebCore::writeLayers):
      
      LayoutTests:
      
      * fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html: Added.
      * fast/regions/layers/accelerated-compositing/crash-transform-inside-region-expected.html: Added.
      * fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html: Added.
      * fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child-expected.html: Added.
      * fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html: Added.
      * fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another-expected.html: Added.
      * fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html: Added.
      * fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-expected.html: Added.
      * fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html: Added.
      * fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video-expected.html: Added.
      * fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html: Added.
      * fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread-expected.html: Added.
      * fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html: Added.
      * fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer-expected.html: Added.
      * fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html: Added.
      * fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region-expected.html: Added.
      * fast/regions/layers/accelerated-compositing/z-index.html: Added.
      * fast/regions/layers/accelerated-compositing/z-index-expected.html: Added.
      * fast/regions/layers/accelerated-compositing/z-index-update-expected.html: Added.
      * fast/regions/layers/accelerated-compositing/z-index-update.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e858b116
    • mihnea@adobe.com's avatar
      [CSSRegions] Unable to collect html element in a named flow · 94ad2f42
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121878
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Tests: fast/regions/collect-html-in-named-flow.html
             fast/regions/iframe-html-collected.html
      
      It should be possible to collect the html element in a named flow.
      However, before we check whether adding a child is not restricted
      by its original parent, we have to make sure that the original parent
      is an element to safely perform the check.
      
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::isChildAllowed):
      
      LayoutTests:
      
      Use an iframe with a html element collected in a named flow
      to test that is does not crash or assert.
      
      * fast/regions/collect-html-in-named-flow-expected.txt: Added.
      * fast/regions/collect-html-in-named-flow.html: Added.
      * fast/regions/iframe-html-collected-expected.txt: Added.
      * fast/regions/iframe-html-collected.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94ad2f42
    • commit-queue@webkit.org's avatar
      8 bytes memory leaks in WebProcessMainQt.cpp when proxy is initialized · 965788cf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118515
      
      Patch by Minju Kim <pmuarteo@gmail.com> on 2013-09-25
      Reviewed by Christophe Dumez.
      
      * WebProcess/qt/WebProcessMainQt.cpp:
      (WebKit::initializeProxy): Handled EnvHttpProxyFactory by using OwnPtr
      to avoid memory leak when it isn't handled by NetworkProxyFactory
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      965788cf
  2. 25 Sep, 2013 14 commits