1. 08 Dec, 2008 7 commits
  2. 07 Dec, 2008 12 commits
  3. 06 Dec, 2008 15 commits
    • simon.fraser@apple.com's avatar
      2008-12-06 Simon Fraser <simon.fraser@apple.com> · c7cac524
      simon.fraser@apple.com authored
              Reviewed by Antti Koivisto, Dan Bernstein
      
              https://bugs.webkit.org/show_bug.cgi?id=22088
      
              Fix logic related to repainting when transform changes:
              If an object has a layer, and the transform changes, then we need
              to do a repaintIncludingDescendants(), not just a repaint.
      
              Test: fast/repaint/transform-repaint-descendants.html
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::styleWillChange):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7cac524
    • weinig@apple.com's avatar
      2008-12-06 Sam Weinig <sam@webkit.org> · e015719b
      weinig@apple.com authored
              Fix the Gtk build.
      
              * jit/JITPropertyAccess.cpp:
              (JSC::JIT::compileGetByIdHotPath):
              (JSC::JIT::compilePutByIdHotPath):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e015719b
    • antti@apple.com's avatar
      2008-12-06 Antti Koivisto <antti@apple.com> · 8212ee56
      antti@apple.com authored
              Reviewed by Darin Adler.
      
              Also copy m_implicit field. Darin wanted this change commited separately.
      
              * css/CSSProperty.h:
              (WebCore::CSSProperty::operator=):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8212ee56
    • antti@apple.com's avatar
      WebCore: · 8115fb95
      antti@apple.com authored
      2008-12-06  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=22379
              Make CSSOM use less memory
              
              Use vector instead of a double linked list for properties in CSSMutableStyleDeclaration.
              
              Taught setter functions to use existing slots to avoid memory moves, plus some
              other optimizations.
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
              (WebCore::CSSMutableStyleDeclaration::operator=):
              (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
              (WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):
              (WebCore::CSSMutableStyleDeclaration::removeProperty):
              (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
              (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
              (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
              (WebCore::CSSMutableStyleDeclaration::setProperty):
              (WebCore::CSSMutableStyleDeclaration::setPropertyInternal):
              (WebCore::CSSMutableStyleDeclaration::setStringProperty):
              (WebCore::CSSMutableStyleDeclaration::setImageProperty):
              (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
              (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
              (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
              (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
              (WebCore::CSSMutableStyleDeclaration::length):
              (WebCore::CSSMutableStyleDeclaration::item):
              (WebCore::CSSMutableStyleDeclaration::cssText):
              (WebCore::CSSMutableStyleDeclaration::setCssText):
              (WebCore::CSSMutableStyleDeclaration::merge):
              (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
              (WebCore::CSSMutableStyleDeclaration::copy):
              (WebCore::CSSMutableStyleDeclaration::findPropertyWithId):
              * css/CSSMutableStyleDeclaration.h:
              (WebCore::CSSMutableStyleDeclarationConstIterator::operator*):
              (WebCore::CSSMutableStyleDeclarationConstIterator::operator->):
              (WebCore::CSSMutableStyleDeclarationConstIterator::operator!=):
              (WebCore::CSSMutableStyleDeclarationConstIterator::operator==):
              (WebCore::CSSMutableStyleDeclaration::create):
              (WebCore::CSSMutableStyleDeclaration::begin):
              (WebCore::CSSMutableStyleDeclaration::end):
              (WebCore::CSSMutableStyleDeclarationConstIterator::CSSMutableStyleDeclarationConstIterator):
              (WebCore::CSSMutableStyleDeclarationConstIterator::~CSSMutableStyleDeclarationConstIterator):
              (WebCore::CSSMutableStyleDeclarationConstIterator::operator=):
              (WebCore::CSSMutableStyleDeclarationConstIterator::operator++):
              (WebCore::CSSMutableStyleDeclarationConstIterator::operator--):
              * css/CSSProperty.h:
              (WTF::):
              * css/CSSStyleDeclaration.cpp:
              (WebCore::CSSStyleDeclaration::diff):
              (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::resolveVariablesForDeclaration):
              (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
              (WebCore::CSSStyleSelector::applyDeclarations):
              * dom/EventTarget.h:
              * editing/ApplyStyleCommand.cpp:
              (WebCore::StyleChange::init):
              (WebCore::ApplyStyleCommand::isHTMLStyleNode):
              (WebCore::ApplyStyleCommand::removeHTMLFontStyle):
              (WebCore::ApplyStyleCommand::removeCSSStyle):
              * editing/Editor.cpp:
              (WebCore::Editor::selectionStartHasStyle):
              (WebCore::updateState):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::handleStyleSpans):
              * editing/markup.cpp:
              (WebCore::appendStartMarkup):
      
      LayoutTests:
      
      2008-12-06  Antti Koivisto  <antti@apple.com>
      
              Reusing property slots changed property ordering in this text.
      
              * editing/pasteboard/5780697-2-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8115fb95
    • simon.fraser@apple.com's avatar
      2008-12-06 Simon Fraser <simon.fraser@apple.com> · 75efff32
      simon.fraser@apple.com authored
              Update expected image now that the caret renders in transformed
              content.
      
              https://bugs.webkit.org/show_bug.cgi?id=15671
      
              * platform/mac/fast/forms/search-transformed-expected.checksum:
              * platform/mac/fast/forms/search-transformed-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75efff32
    • simon.fraser@apple.com's avatar
      2008-12-06 Simon Fraser <simon.fraser@apple.com> · 41705c6d
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein
      
              https://bugs.webkit.org/show_bug.cgi?id=15739
      
              When painting the selection on a replaced element, paint
              using local coordinates so that the selection is correctly
              painted for transformed elements.
      
              Test: fast/replaced/selection-rect-transform.html
      
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41705c6d
    • weinig@apple.com's avatar
      2008-12-06 Sam Weinig <sam@webkit.org> · 0e9a7ee0
      weinig@apple.com authored
              Reviewed by Cameron Zwarich,
      
              Move CodeBlock constructor into the .cpp file.
      
              Sunspider reports a .7% progression, but I can only assume this
              is noise.
      
              * bytecode/CodeBlock.cpp:
              (JSC::CodeBlock::CodeBlock):
              * bytecode/CodeBlock.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e9a7ee0
    • weinig@apple.com's avatar
      2008-12-06 Sam Weinig <sam@webkit.org> · 466a745c
      weinig@apple.com authored
              Reviewed by Cameron Zwarich.
      
              Split JumpTable code into its own file.
      
              * GNUmakefile.am:
              * JavaScriptCore.pri:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * JavaScriptCoreSources.bkl:
              * bytecode/CodeBlock.cpp:
              * bytecode/CodeBlock.h:
              * bytecode/JumpTable.cpp: Copied from bytecode/CodeBlock.cpp.
              * bytecode/JumpTable.h: Copied from bytecode/CodeBlock.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      466a745c
    • weinig@apple.com's avatar
      2008-12-05 Sam Weinig <sam@webkit.org> · cb26d81f
      weinig@apple.com authored
              Reviewed by Cameron Zwarich.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=22715
              Encapsulate more CodeBlock members in preparation
              of moving some of them to a rare data structure.
      
              * bytecode/CodeBlock.cpp:
              (JSC::locationForOffset):
              (JSC::printConditionalJump):
              (JSC::printGetByIdOp):
              (JSC::printPutByIdOp):
              (JSC::CodeBlock::printStructure):
              (JSC::CodeBlock::printStructures):
              (JSC::CodeBlock::dump):
              (JSC::CodeBlock::~CodeBlock):
              (JSC::CodeBlock::unlinkCallers):
              (JSC::CodeBlock::derefStructures):
              (JSC::CodeBlock::refStructures):
              (JSC::CodeBlock::mark):
              (JSC::CodeBlock::getHandlerForVPC):
              (JSC::CodeBlock::nativeExceptionCodeForHandlerVPC):
              (JSC::CodeBlock::lineNumberForVPC):
              (JSC::CodeBlock::expressionRangeForVPC):
              (JSC::CodeBlock::shrinkToFit):
              * bytecode/CodeBlock.h:
              (JSC::CodeBlock::CodeBlock):
              (JSC::CodeBlock::addCaller):
              (JSC::CodeBlock::removeCaller):
              (JSC::CodeBlock::isKnownNotImmediate):
              (JSC::CodeBlock::isConstantRegisterIndex):
              (JSC::CodeBlock::getConstant):
              (JSC::CodeBlock::isTemporaryRegisterIndex):
              (JSC::CodeBlock::getStubInfo):
              (JSC::CodeBlock::getCallLinkInfo):
              (JSC::CodeBlock::instructions):
              (JSC::CodeBlock::setJITCode):
              (JSC::CodeBlock::jitCode):
              (JSC::CodeBlock::ownerNode):
              (JSC::CodeBlock::setGlobalData):
              (JSC::CodeBlock::setThisRegister):
              (JSC::CodeBlock::thisRegister):
              (JSC::CodeBlock::setNeedsFullScopeChain):
              (JSC::CodeBlock::needsFullScopeChain):
              (JSC::CodeBlock::setUsesEval):
              (JSC::CodeBlock::usesEval):
              (JSC::CodeBlock::setUsesArguments):
              (JSC::CodeBlock::usesArguments):
              (JSC::CodeBlock::codeType):
              (JSC::CodeBlock::source):
              (JSC::CodeBlock::sourceOffset):
              (JSC::CodeBlock::addGlobalResolveInstruction):
              (JSC::CodeBlock::numberOfPropertyAccessInstructions):
              (JSC::CodeBlock::addPropertyAccessInstruction):
              (JSC::CodeBlock::propertyAccessInstruction):
              (JSC::CodeBlock::numberOfCallLinkInfos):
              (JSC::CodeBlock::addCallLinkInfo):
              (JSC::CodeBlock::callLinkInfo):
              (JSC::CodeBlock::numberOfJumpTargets):
              (JSC::CodeBlock::addJumpTarget):
              (JSC::CodeBlock::jumpTarget):
              (JSC::CodeBlock::lastJumpTarget):
              (JSC::CodeBlock::numberOfExceptionHandlers):
              (JSC::CodeBlock::addExceptionHandler):
              (JSC::CodeBlock::exceptionHandler):
              (JSC::CodeBlock::addExpressionInfo):
              (JSC::CodeBlock::numberOfLineInfos):
              (JSC::CodeBlock::addLineInfo):
              (JSC::CodeBlock::lastLineInfo):
              (JSC::CodeBlock::jitReturnAddressVPCMap):
              (JSC::CodeBlock::numberOfIdentifiers):
              (JSC::CodeBlock::addIdentifier):
              (JSC::CodeBlock::identifier):
              (JSC::CodeBlock::numberOfConstantRegisters):
              (JSC::CodeBlock::addConstantRegister):
              (JSC::CodeBlock::constantRegister):
              (JSC::CodeBlock::addFunction):
              (JSC::CodeBlock::function):
              (JSC::CodeBlock::addFunctionExpression):
              (JSC::CodeBlock::functionExpression):
              (JSC::CodeBlock::addUnexpectedConstant):
              (JSC::CodeBlock::unexpectedConstant):
              (JSC::CodeBlock::addRegExp):
              (JSC::CodeBlock::regexp):
              (JSC::CodeBlock::symbolTable):
              (JSC::CodeBlock::evalCodeCache):
              New inline setters/getters.
      
              (JSC::ProgramCodeBlock::ProgramCodeBlock):
              (JSC::ProgramCodeBlock::~ProgramCodeBlock):
              (JSC::ProgramCodeBlock::clearGlobalObject):
              * bytecode/SamplingTool.cpp:
              (JSC::ScopeSampleRecord::sample):
              (JSC::SamplingTool::dump):
              * bytecompiler/BytecodeGenerator.cpp:
              * bytecompiler/BytecodeGenerator.h:
              * bytecompiler/Label.h:
              * interpreter/CallFrame.cpp:
              * interpreter/Interpreter.cpp:
              * jit/JIT.cpp:
              * jit/JITCall.cpp:
              * jit/JITInlineMethods.h:
              * jit/JITPropertyAccess.cpp:
              * parser/Nodes.cpp:
              * runtime/Arguments.h:
              * runtime/ExceptionHelpers.cpp:
              * runtime/JSActivation.cpp:
              * runtime/JSActivation.h:
              * runtime/JSGlobalObject.cpp:
              Change direct access to use new getter/setters.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb26d81f
    • simon.fraser@apple.com's avatar
      2008-12-06 Simon Fraser <simon.fraser@apple.com> · 2b2b6ce0
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt
      
              https://bugs.webkit.org/show_bug.cgi?id=15671
      
              Fix caret rendering to behave correctly with transforms:
              * Rename caretRect() methods to localCaretRect() and
                absoluteCaretBounds() as appropriate
              * Fix localCaretRect() methods to return a rect in the
                appropriate coordinates.
              * Pass tx, ty down through the paintCaret() methods, after fixing them
                up to account for differences between contents coords, and renderer-local
                coords (via RenderBlock::offsetForContents()).
              * Remove m_caretPositionOnLayout from SelectionController, and instead
                call invalidateSelection() from RenderLayer::scrollToOffset(), because
                we can no longer assume simple x/y offsets from scrolling with transforms.
              * Move the logic to compute which RenderObject actually paints the caret into
                SelectionController::caretRenderer(), rather than having it in RenderBlock.
              * SelectionController now computes and caches a local caret rect. For invalidation,
                it computes the absolute bounds of that (possibly transformed) local rect.
                The local rect is computed in the coordinate system of the RenderObject that
                will paint the caret (this may require offsetting from the actual renderer
                at the start of the selection).
              * Fix LayoutState(RenderObject* root) to take transforms into account
              * Make offsetFromContainer() a virtual method on RenderObject, and implement
                the RenderObject version. It's used to map from selection start renderer
                to caret renderer.
      
              Test: fast/transforms/transformed-caret.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b2b6ce0
    • ddkilzer@apple.com's avatar
      Added reference to bugs.webkit.org bug. · 37783ff3
      ddkilzer@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37783ff3
    • ddkilzer@apple.com's avatar
      BUILD FIX for r39065: Forgot parentheses after "document". · dafbf5ee
      ddkilzer@apple.com authored
              Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
              <https://bugs.webkit.org/show_bug.cgi?id=22666>
      
              * svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Changed
              document to document().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dafbf5ee
    • ap@webkit.org's avatar
      2008-12-06 Dmitry Titov <dimich@chromium.org> · fd887d46
      ap@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              https://bugs.webkit.org/show_bug.cgi?id=22710
              Memory leak due to circular reference Document->DOMTimer->ScheduledAction->[JS objects]->Document
      
              * bindings/js/DOMTimer.cpp:
              (WebCore::DOMTimer::stop): Delete ScheduledAction, which contains a protected object.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd887d46
    • ddkilzer@apple.com's avatar
      Bug 22666: Clean up data structures used when collecting URLs of... · b27ae033
      ddkilzer@apple.com authored
              Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
      
              <https://bugs.webkit.org/show_bug.cgi?id=22666>
      
              Reviewed by Darin Adler.
      
      WebCore:
      
              When creating a webarchive from WebCore::LegacyWebArchive::create(),
              HashSet<String>, Vector<KURL> and Vector<String> were all used to
              store a list of URLs for resources found in the document.  Instead
              use a single ListHashSet<KURL> to store the list and resolve the
              relative URLs as they're added.  We use a new inline method called
              WebCore::addSubresourceURL() to add KURL objects to the ListHashSet
              to prevent "null" KURL objects from crashing in the KURL hashing
              function.
      
              * WebCore.base.exp: Changed export of
              WebCore::Node::getSubresourceURLs() to take a ListHashSet<KURL>
              argument instead of a Vector<KURL>.
      
              * WebCore.xcodeproj/project.pbxproj: Marked KURLHash.h as a private
              header for use in WebKit.
      
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Renamed from
              addSubresourceURLStrings().  Changed to use ListHashSet<KURL>
              instead of HashSet<String>.  Cleaned up code.
              * css/CSSStyleSheet.h:
              (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Ditto.
              * css/StyleSheet.h:
              (WebCore::StyleSheet::addSubresourceStyleURLs): Ditto.
      
              * dom/Node.cpp:
              (WebCore::Node::getSubresourceURLs): Changed to use
              ListHashSet<KURL> instead of Vector<KURL>.  Cleaned up code.
              * dom/Node.h:
              (WebCore::Node::getSubresourceURLs): Ditto.
              (WebCore::Node::addSubresourceAttributeURLs): Renamed from
              getSubresourceAttributeStrings().  Changed to use ListHashSet<KURL>
              instead of Vector<String>.
              (WebCore::addSubresourceURL): Added.  Safely adds new KURL objects
              to a ListHashSet<KURL> object.  A "null" KURL object will cause the
              hash function to crash since it contains a null StringImpl.  Used in
              Node::addSubresourceAttributeURLs() and addSubresourceStyleURLs() in
              the style subsystem.
      
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::addSubresourceAttributeURLs):
              Renamed from getSubresourceAttributeStrings().  Changed to use
              ListHashSet<KURL> instead of Vector<String>.  Use
              WebCore::addSubresourceURL() to add new KURL objects.
              * dom/ProcessingInstruction.h: Ditto.
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLBodyElement.h: Ditto.
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLEmbedElement.h: Ditto.
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLImageElement.h: Ditto.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLInputElement.h: Ditto.
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLLinkElement.h: Ditto.
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLObjectElement.h: Ditto.
              * html/HTMLParamElement.cpp:
              (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLParamElement.h: Ditto.
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLScriptElement.h: Ditto.
              * html/HTMLStyleElement.cpp:
              (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLStyleElement.h: Ditto.
              * html/HTMLTableCellElement.cpp:
              (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLTableCellElement.h: Ditto.
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
              * html/HTMLTableElement.h: Ditto.
      
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::create): Changed from using
              HashSet<String> to ListHashSet<KURL> for tracking unique
              subresources.  Changed from using Vector<KURL> to ListHashSet<KURL>
              when calling WebCore::Node::getSubresourceURLs().  Cleaned up code.
      
              * svg/SVGCursorElement.cpp:
              (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Renamed
              from getSubresourceAttributeStrings().  Changed to use
              ListHashSet<KURL> instead of Vector<String>.  Use
              WebCore::addSubresourceURL() to add new KURL objects.
              * svg/SVGCursorElement.h: Ditto.
              * svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
              * svg/SVGFEImageElement.h: Ditto.
              * svg/SVGImageElement.cpp:
              (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
              * svg/SVGImageElement.h: Ditto.
              * svg/SVGScriptElement.cpp:
              (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
              * svg/SVGScriptElement.h: Ditto.
      
      WebKit/mac:
      
              * DOM/WebDOMOperations.mm:
              (-[DOMNode _subresourceURLs]): Changed from using Vector<KURL> to
              ListHashSet<KURL> when calling WebCore::Node::getSubresourceURLs().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b27ae033
    • ddkilzer@apple.com's avatar
      Fixed ChangeLog date. · dc88a763
      ddkilzer@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc88a763
  4. 05 Dec, 2008 6 commits
    • barraclough@apple.com's avatar
      Mis-commit in ChangeLog entry · 65b6957f
      barraclough@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65b6957f
    • barraclough@apple.com's avatar
      2008-12-05 Gavin Barraclough <barraclough@apple.com> · 940e6a55
      barraclough@apple.com authored
              Reviewed by Oliver Hunt.
      
              Please don't die in a fire while trying to compile Interpreter.cpp on GCC 4.2.
              Added "-fno-var-tracking" compiler flag.
      
              https://bugs.webkit.org/show_bug.cgi?id=22704
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      940e6a55
    • barraclough@apple.com's avatar
      2008-12-05 Gavin Barraclough <barraclough@apple.com> · 969d15eb
      barraclough@apple.com authored
              Reviewed by Oliver Hunt.
      
              Ordering of branch operands in MacroAssembler in unnecessarily  inconsistent.
      
              je, jg etc take an immediate operand as the second argument, but for the
              equality branches (je, jne) the immediate operand was the first argument.  This
              was unnecessarily inconsistent.  Change je, jne methods to take the immediate
              as the second argument.
      
              https://bugs.webkit.org/show_bug.cgi?id=22703
      
              * assembler/MacroAssembler.h:
              (JSC::MacroAssembler::je32):
              (JSC::MacroAssembler::jne32):
              * jit/JIT.cpp:
              (JSC::JIT::compileOpStrictEq):
              * wrec/WRECGenerator.cpp:
              (JSC::WREC::Generator::generateEnter):
              (JSC::WREC::Generator::generateNonGreedyQuantifier):
              (JSC::WREC::Generator::generateGreedyQuantifier):
              (JSC::WREC::Generator::generatePatternCharacterPair):
              (JSC::WREC::Generator::generatePatternCharacter):
              (JSC::WREC::Generator::generateCharacterClassInvertedRange):
              (JSC::WREC::Generator::generateCharacterClassInverted):
              (JSC::WREC::Generator::generateAssertionBOL):
              (JSC::WREC::Generator::generateAssertionWordBoundary):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      969d15eb
    • brettw@chromium.org's avatar
      Reviewed by Darin Adler. · 6af05ad4
      brettw@chromium.org authored
      Make the page group use the proper link hashing functions rather than
      calling the string hash functions directly. Add Chromium-specfic ifdefs
      in the visited link computation functions to allow integration.
      
      * page/PageGroup.cpp:
      (WebCore::PageGroup::isLinkVisited):
      (WebCore::PageGroup::addVisitedLink):
      * platform/LinkHash.cpp:
      (WebCore::visitedLinkHash):
      * platform/LinkHash.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6af05ad4
    • cmarrin@apple.com's avatar
      2008-12-05 Chris Marrin <cmarrin@apple.com> · e625a40e
      cmarrin@apple.com authored
              Reviewed by Dave Hyatt.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=22635
              For iteration and end events, previous fixes to prevent the deletion of
              Animation objects (ref counting and hanging onto a ref during event callbacks)
              was sufficient to prevent dangling pointers. But start events are sent in
              the styleAvailable() call, which iterates over CompositeAnimation objects,
              which are not ref counted. So that object can get destroyed in the event
              handler while still active. So I added refcounting for CompositeAnimations.
      
              Additionally, when am iterating over the CompositingAnimation list, it can
              be deleted, which mutates the list. So I now make one pass over the list
              building a vector of CompositeAnimation objects that need to be called and
              then iterate over that vector to make the actual calls.
      
              Finally, to make sure the lifetime of the CompositeAnimation exceeds that of
              the Animation objects it owns, I now keep a ref to the CompositeAnimation
              in the timer callback for the iteration and end events. That means I no
              longer need to keep a ref to the Animation objects themselves in that timer
              callback, since the CompositeAnimation already has one.
      
              Tests: animations/animation-iteration-event-destroy-renderer.html
                     animations/animation-start-event-destroy-renderer.html
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e625a40e
    • barraclough@apple.com's avatar
      2008-12-05 Gavin Barraclough <barraclough@apple.com> · 6955d3c7
      barraclough@apple.com authored
              Reviewed by Geoff Garen.
      
              Second tranche of porting JIT.cpp to MacroAssembler interface.
      
              * assembler/MacroAssembler.h:
              (JSC::MacroAssembler::mul32):
              (JSC::MacroAssembler::jl32):
              (JSC::MacroAssembler::jnzSub32):
              (JSC::MacroAssembler::joAdd32):
              (JSC::MacroAssembler::joMul32):
              (JSC::MacroAssembler::jzSub32):
              * jit/JIT.cpp:
              (JSC::JIT::emitSlowScriptCheck):
              (JSC::JIT::privateCompileMainPass):
              (JSC::JIT::privateCompileSlowCases):
              (JSC::JIT::privateCompileCTIMachineTrampolines):
              * jit/JIT.h:
              * jit/JITInlineMethods.h:
              (JSC::JIT::emitJumpIfNotJSCell):
              (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6955d3c7