1. 27 Jan, 2011 18 commits
    • yuzo@google.com's avatar
      2011-01-27 Yuzo Fujishima <yuzo@google.com> · 1709389d
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1709389d
    • yuzo@google.com's avatar
      2011-01-27 Yuzo Fujishima <yuzo@google.com> · cc48c3cb
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
      
              * platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed.
              * platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.png: Removed.
              * platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.txt: Removed.
              * platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
              * platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc48c3cb
    • mjs@apple.com's avatar
      Unreviewed. · 5d6eb99b
      mjs@apple.com authored
      Fix mistake in my previous commit; I accidentally copied the old mac results instead
      of the new mac results for this test.
      
      * platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d6eb99b
    • ossy@webkit.org's avatar
      Unreviewed. · e9e8720e
      ossy@webkit.org authored
      Add Qt specific expected results for new passing tests introduced in r76726.
      Compared to Mac png files and Mac expected files.
      
      * platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
      * platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
      * platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-lr/column-rules-expected.png: Added.
      * platform/qt/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
      * platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
      * platform/qt/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
      * platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
      * platform/qt/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
      * platform/qt/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
      * platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
      * platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
      * platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-rl/column-rules-expected.png: Added.
      * platform/qt/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
      * platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
      * platform/qt/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
      * platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
      * platform/qt/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
      * platform/qt/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
      * platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
      * platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
      * platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9e8720e
    • zoltan@webkit.org's avatar
      [Qt] Add simple zooming features to MiniBrowser · 66cccf23
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53231
      
      Reviewed by Andreas Kling.
      
      Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
      
      * MiniBrowser/qt/BrowserWindow.cpp:
      (BrowserWindow::BrowserWindow):
      (BrowserWindow::zoomIn):
      (BrowserWindow::zoomOut):
      (BrowserWindow::resetZoom):
      (BrowserWindow::updateUserAgentList):
      (BrowserWindow::applyZoom):
      * MiniBrowser/qt/BrowserWindow.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66cccf23
    • philn@webkit.org's avatar
      2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com> · 542b6fc3
      philn@webkit.org authored
              Unreviewed, rolling out r76773.
              http://trac.webkit.org/changeset/76773
              https://bugs.webkit.org/show_bug.cgi?id=53230
      
              breaks multiple GTK media tests (Requested by philn-tp on
              #webkit).
      
              * platform/gtk/Skipped:
      2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r76773.
              http://trac.webkit.org/changeset/76773
              https://bugs.webkit.org/show_bug.cgi?id=53230
      
              breaks multiple GTK media tests (Requested by philn-tp on
              #webkit).
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::mimeTypeCache):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      542b6fc3
    • yuzo@google.com's avatar
      2011-01-27 Yuzo Fujishima <yuzo@google.com> · af607330
      yuzo@google.com authored
              Unreviewed Chromium test expectaion change.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af607330
    • yurys@chromium.org's avatar
      2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com> · ffb351e8
      yurys@chromium.org authored
              Unreviewed, rolling out r76770.
              http://trac.webkit.org/changeset/76770
              https://bugs.webkit.org/show_bug.cgi?id=53229
      
              Some inspector tests fail (Requested by yurys on #webkit).
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
              * bindings/js/ScriptDebugServer.h:
              * bindings/js/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
              * bindings/js/ScriptProfiler.h:
              * bindings/v8/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
              * bindings/v8/ScriptDebugServer.h:
              * bindings/v8/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
              * bindings/v8/ScriptProfiler.h:
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::restoreDebugger):
              (WebCore::InspectorAgent::restoreProfiler):
              (WebCore::InspectorAgent::ensureSettingsLoaded):
              (WebCore::InspectorAgent::enableProfiler):
              (WebCore::InspectorAgent::disableProfiler):
              (WebCore::InspectorAgent::showAndEnableDebugger):
              (WebCore::InspectorAgent::enableDebugger):
              (WebCore::InspectorAgent::disableDebugger):
              * inspector/InspectorAgent.h:
              (WebCore::InspectorAgent::settings):
              * inspector/InspectorConsoleAgent.cpp:
              (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::isDebuggerAlwaysEnabled):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
              (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              * inspector/InspectorSettings.cpp: Added.
              (WebCore::InspectorSettings::InspectorSettings):
              (WebCore::InspectorSettings::getBoolean):
              (WebCore::InspectorSettings::setBoolean):
              (WebCore::InspectorSettings::getLong):
              (WebCore::InspectorSettings::setLong):
              (WebCore::InspectorSettings::registerBoolean):
              (WebCore::InspectorSettings::registerLong):
              * inspector/InspectorSettings.h: Copied from Source/WebCore/bindings/v8/ScriptProfiler.h.
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged):
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
              (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype._toggleProfiling):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
              * inspector/front-end/inspector.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffb351e8
    • mjs@apple.com's avatar
      2011-01-27 Maciej Stachowiak <mjs@apple.com> · 813b208e
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Add or update WebKit2-specific results to account for different reporting of scroll position
              https://bugs.webkit.org/show_bug.cgi?id=53226
      
              * platform/mac-wk2/fast/multicol: Added.
              * platform/mac-wk2/fast/multicol/vertical-rl: Added.
              * platform/mac-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
              * platform/mac-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      813b208e
    • philn@webkit.org's avatar
      2011-01-26 Philippe Normand <pnormand@igalia.com> · 3bb4744a
      philn@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] LayoutTests/media/audio-mpeg4-supported.html fails
              https://bugs.webkit.org/show_bug.cgi?id=53125
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.
      
      2011-01-26  Philippe Normand  <pnormand@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] LayoutTests/media/audio-mpeg4-supported.html fails
              https://bugs.webkit.org/show_bug.cgi?id=53125
      
              * platform/gtk/Skipped: Unskip fixed test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bb4744a
    • philn@webkit.org's avatar
      2011-01-27 Philippe Normand <pnormand@igalia.com> · a600e9fe
      philn@webkit.org authored
              Unreviewed, updated GTK baselines after r76726.
      
              * platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
              * platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.txt:
              * platform/gtk/fast/lists/002-vertical-expected.txt:
              * platform/gtk/fast/lists/003-vertical-expected.txt:
              * platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt:
              * platform/gtk/fast/table/028-vertical-expected.txt:
              * platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt:
              * platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a600e9fe
    • yuzo@google.com's avatar
      2011-01-27 Yuzo Fujishima <yuzo@google.com> · 16932867
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
      
              Update expectation for r76760.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16932867
    • yurys@chromium.org's avatar
      2011-01-26 Yury Semikhatsky <yurys@chromium.org> · 84d95409
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: store all settings related to the agents on the frontend side
              https://bugs.webkit.org/show_bug.cgi?id=53174
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored
              on the front-end side and will be pushed to the backend when the frontend is loaded.
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::restoreDebugger):
              (WebCore::InspectorAgent::restoreProfiler):
              (WebCore::InspectorAgent::enableProfiler):
              (WebCore::InspectorAgent::disableProfiler):
              (WebCore::InspectorAgent::showAndEnableDebugger):
              (WebCore::InspectorAgent::enableDebugger):
              (WebCore::InspectorAgent::disableDebugger):
              * inspector/InspectorAgent.h:
              * inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only
              if the front-end was opened during current browser session and XHR logging is turned on
              there.
              (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
              (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::enable):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              * inspector/InspectorProfilerAgent.h:
              * inspector/InspectorSettings.cpp: Removed.
              * inspector/InspectorSettings.h: Removed.
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared):
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
              (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction):
              (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype._toggleProfiling):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
              * inspector/front-end/inspector.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84d95409
    • mjs@apple.com's avatar
      2011-01-26 Maciej Stachowiak <mjs@apple.com> · ccbb681c
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
              https://bugs.webkit.org/show_bug.cgi?id=42319
              
              Unskip inspector tests (except the few that mysteriously fail).
      
              * platform/mac-wk2/Skipped:
      2011-01-26  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
              https://bugs.webkit.org/show_bug.cgi?id=42319
              
              Add evaluateInWebInspector and other APIs needed for inspector tests to run.
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::showWebInspector):
              (WTR::LayoutTestController::closeWebInspector):
              (WTR::LayoutTestController::evaluateInWebInspector):
              (WTR::LayoutTestController::setTimelineProfilingEnabled):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
              * WebKitTestRunner/TestInvocation.cpp:
              (WTR::shouldOpenWebInspector):
              (WTR::TestInvocation::invoke):
              * WebKitTestRunner/WebKitTestRunnerPrefix.h:
      2011-01-26  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
              https://bugs.webkit.org/show_bug.cgi?id=42319
      
              Add WKBundleInspector and APIs needed to implement WebKitTestRunner APIs.
              
              * GNUmakefile.am:
              * Shared/API/c/WKBase.h:
              * Shared/APIObject.h:
              * WebKit2.pro:
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
              * WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: Added.
              (WKBundleInspectorGetTypeID):
              (WKBundleInspectorShow):
              (WKBundleInspectorClose):
              (WKBundleInspectorEvaluateScriptForTest):
              (WKBundleInspectorSetPageProfilingEnabled):
              * WebProcess/InjectedBundle/API/c/WKBundleInspector.h: Added.
              * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
              (WKBundlePageGetInspector):
              * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
              * WebProcess/WebPage/WebInspector.cpp:
              (WebKit::WebInspector::create):
              (WebKit::WebInspector::evaluateScriptForTest):
              * WebProcess/WebPage/WebInspector.h:
              (WebKit::WebInspector::type):
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::inspector):
              * WebProcess/WebPage/WebPage.h:
              * win/WebKit2.vcproj:
              * win/WebKit2Generated.make:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccbb681c
    • mitz@apple.com's avatar
      REGRESSION (r76743): Uneven spacing in right-to-left justified text · 1b0578db
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53225
      
      Reviewed by Sam Weinig.
      
      Fixes failure in fast/text/atsui-spacing-features.html
      
      There was an inconsistency between rendering code and font code in the interpretation of
      'after expansion' and 'trailing expansion'. Changed all code to interpret these in terms of
      visual order rather than logical.
      
      * platform/graphics/Font.cpp:
      (WebCore::Font::expansionOpportunityCount): Added a text direction parameter and changed to
      iterate in visual order accordingly.
      * platform/graphics/Font.h:
      * platform/graphics/WidthIterator.cpp:
      (WebCore::WidthIterator::WidthIterator): Pass the run direction to expansionOpportunityCount().
      (WebCore::WidthIterator::advance): For right-to-left runs, evaluate the trailing expansion
      condition with respect to the first character, which is the trailing character in visual order.
      * platform/graphics/mac/ComplexTextController.cpp:
      (WebCore::ComplexTextController::ComplexTextController): Pass the run direction to
      expansionOpportunityCount().
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b0578db
    • yuzo@google.com's avatar
      2011-01-27 Yuzo Fujishima <yuzo@google.com> · a3be8f70
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
      
              Another test expectation update for r76743.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3be8f70
    • ossy@webkit.org's avatar
      Unreviewed. · 42df7bf2
      ossy@webkit.org authored
      [Qt] Update test expectations after r76726.
      
      * platform/qt/fast/lists/002-vertical-expected.checksum:
      * platform/qt/fast/lists/002-vertical-expected.png:
      * platform/qt/fast/lists/002-vertical-expected.txt:
      * platform/qt/fast/lists/003-vertical-expected.checksum:
      * platform/qt/fast/lists/003-vertical-expected.png:
      * platform/qt/fast/lists/003-vertical-expected.txt:
      * platform/qt/fast/overflow/overflow-rtl-vertical-expected.checksum:
      * platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
      * platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
      * platform/qt/fast/table/028-vertical-expected.checksum:
      * platform/qt/fast/table/028-vertical-expected.png:
      * platform/qt/fast/table/028-vertical-expected.txt:
      * platform/qt/fast/table/border-collapsing/003-vertical-expected.checksum:
      * platform/qt/fast/table/border-collapsing/003-vertical-expected.png:
      * platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
      * platform/qt/fast/table/height-percent-test-vertical-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42df7bf2
    • yuzo@google.com's avatar
      2011-01-26 Yuzo Fujishima <yuzo@google.com> · 42f8d300
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
      
              Update test expectations for r76743
      
              * platform/chromium-linux/css1/box_properties/clear_float-expected.checksum:
              * platform/chromium-linux/css1/box_properties/clear_float-expected.png:
              * platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.checksum:
              * platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.png:
              * platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.checksum:
              * platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
              * platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
              * platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
              * platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
              * platform/chromium-linux/fast/multicol/shadow-breaking-expected.png: Added.
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.checksum:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.checksum:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.checksum:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.checksum:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.checksum:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.checksum:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.checksum:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.checksum:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.checksum:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
              * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
              * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
              * platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
              * platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
              * platform/chromium-mac/css1/box_properties/clear_float-expected.checksum: Added.
              * platform/chromium-mac/css1/box_properties/clear_float-expected.png: Added.
              * platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.checksum: Added.
              * platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png: Added.
              * platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
              * platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
              * platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
              * platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Added.
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
              * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
              * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
              * platform/chromium-win/css1/box_properties/clear_float-expected.checksum:
              * platform/chromium-win/css1/box_properties/clear_float-expected.png:
              * platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
              * platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
              * platform/chromium-win/css1/box_properties/float_on_text_elements-expected.checksum:
              * platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
              * platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
              * platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
              * platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
              * platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.checksum:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.checksum:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.checksum:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.checksum:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.checksum:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.checksum:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.checksum:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.checksum:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.checksum:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
              * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
              * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
              * platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
              * platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42f8d300
  2. 26 Jan, 2011 22 commits
    • aroben@apple.com's avatar
      Don't create the Direct3D device before it's first needed · e751eb2c
      aroben@apple.com authored
      We only need the device once we decide to render. There's no point in creating it before
      then.
      
      Reviewed by Sam Weinig.
      
      * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
      (WebCore::CACFLayerTreeHost::setWindow): Removed the call to createRenderer() from here.
      We already have code to create it when we first try to draw.
      (WebCore::CACFLayerTreeHost::createRenderer): Flush the context after we set our layer's
      bounds so that the bounds will take effect the next time we render (which could be just
      after this function returns).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e751eb2c
    • aroben@apple.com's avatar
      Add assertions that CACFLayerTreeHost gains and loses an HWND only once · 5f544946
      aroben@apple.com authored
      CACFLayerTreeHost doesn't support any other use pattern.
      
      Reviewed by Sam Weinig.
      
      * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
      (WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
      (WebCore::CACFLayerTreeHost::setWindow): Assert that we transition from not having a window,
      to having a window, to not having a window just once over the lifetime of this object.
      
      * platform/graphics/ca/win/CACFLayerTreeHost.h: Added m_state.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f544946
    • aroben@apple.com's avatar
      Notify layers that their animations have started when we flush the context, not when we render · 9e3fd540
      aroben@apple.com authored
      r76372 separated context flushing from rendering, but this bit of code got left behind.
      
      Reviewed by Sam Weinig.
      
      * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
      (WebCore::CACFLayerTreeHost::render): Moved code to notify the layers from here to
      notifyAnimationsStarted.
      (WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added a call to
      notifyAnimationsStarted after we flush the context.
      (WebCore::CACFLayerTreeHost::notifyAnimationsStarted): Added. Code came from render. Changed
      to call PlatformCALayer::animationStarted rather than calling through to the client
      directly.
      
      * platform/graphics/ca/win/CACFLayerTreeHost.h: Added notifyAniamtionsStarted.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e3fd540
    • aroben@apple.com's avatar
      Small cleanup in MediaPlayerPrivateFullscreenWindow · ca766f78
      aroben@apple.com authored
      Reviewed by Sam Weinig.
      
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
      (WebCore::MediaPlayerPrivateFullscreenWindow::~MediaPlayerPrivateFullscreenWindow): Moved
      code here from close(), since this was the only place that called it after the following
      change to createWindow.
      (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Replaced code that handled the
      case where we had already created the window with an assertion that we have not already done
      so. Our single caller (FullscreenVideoController) did not require this behavior.
      
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Removed layerView.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca766f78
    • mitz@apple.com's avatar
      Updated results for the html.css changes in r76726. The old results were prepared before · 971b4cdf
      mitz@apple.com authored
      r76726.
      
      * platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
      * platform/mac/fast/text/justify-ideograph-vertical-expected.png:
      * platform/mac/fast/text/justify-ideograph-vertical-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      971b4cdf
    • yuzo@google.com's avatar
      2011-01-26 Yuzo Fujishima <yuzo@google.com> · 1cb179de
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
      
              fast/text/justify-ideograph-vertical.html crashes on LINUX.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cb179de
    • yuzo@google.com's avatar
      2011-01-26 Yuzo Fujishima <yuzo@google.com> · 78ec3bfb
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
      
              Mark the tests started failing at http://trac.webkit.org/changeset/76726 as such.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78ec3bfb
    • weinig@apple.com's avatar
      Move ScrollView scroll wheel code to ScrollAnimator. · 10187a97
      weinig@apple.com authored
      Reviewed by Adam Roben.
      
      * platform/ScrollAnimator.cpp:
      (WebCore::ScrollAnimator::handleWheelEvent):
      * platform/ScrollAnimator.h:
      Moved implementation of handleWheelEvent from ScrollView::wheelEvent.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::wheelEvent):
      Call down to the ScrollableArea.
      
      * platform/ScrollableArea.cpp:
      (WebCore::ScrollableArea::handleWheelEvent):
      Call down to the ScrollAnimator.
      
      * platform/ScrollableArea.h:
      (WebCore::ScrollableArea::scrollPosition):
      (WebCore::ScrollableArea::minimumScrollPosition):
      (WebCore::ScrollableArea::maximumScrollPosition):
      (WebCore::ScrollableArea::visibleContentRect):
      (WebCore::ScrollableArea::visibleHeight):
      (WebCore::ScrollableArea::visibleWidth):
      Add functions needed to implement wheel event in the animator.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10187a97
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork · e2501bd4
      ddkilzer@apple.com authored
      <rdar://problem/8821760>
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      This adds support for HTTP pipelining in CFNetwork, but does not
      enable it.  To enable it post-SnowLeopard, use this command:
      
          defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
      
      Once enabled, it is possible to force the same load priority
      (high) to be sent to CFNetwork to allow WebCore to handle the
      scheduling:
      
          defaults write BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh -bool YES
      
      * WebCore.exp.in: Export _wkGetHTTPPipeliningPriority and
      _wkSetHTTPPipeliningPriority.
      
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
      Copy the priority to preflightRequest.
      
      * loader/ResourceLoadScheduler.cpp:
      (WebCore::ResourceLoadScheduler::scheduleLoad): Refactored code
      at the end of the method to use an early return.
      
      * loader/cache/CachedResourceRequest.cpp:
      (WebCore::Cache...
      e2501bd4
    • rniwa@webkit.org's avatar
      2011-01-26 Ryosuke Niwa <rniwa@webkit.org> · b91537df
      rniwa@webkit.org authored
              Reviewed Chromium Mac rebaselines for r76726.
      
              * platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
              * platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
              * platform/chromium-mac/fast/multicol/vertical-rl: Added.
              * platform/chromium-mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
              * platform/chromium-mac/fast/table/028-vertical-expected.checksum: Added.
              * platform/chromium-mac/fast/table/028-vertical-expected.png: Added.
              * platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Added.
              * platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b91537df
    • bdakin@apple.com's avatar
      Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics · 5ce11413
      bdakin@apple.com authored
      when using WKScrollbars.
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      New WebKitSystemInterface Functionality.
      * WebCore.exp.in:
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      
      Some of the terrible static arrays are now only needed in the 
      old non-WK code, so they are if-def'd now.
      * platform/mac/ScrollbarThemeMac.mm:
              
      Just patching this function in a better way than I did
      before.
      (WebCore::updateArrowPlacement):
              
      Call into WK for the right values.
      (WebCore::ScrollbarThemeMac::scrollbarThickness):
      (WebCore::ScrollbarThemeMac::hasThumb):
      (WebCore::ScrollbarThemeMac::minimumThumbLength):
              
      Return false if there are no buttons.
      (WebCore::ScrollbarThemeMac::hasButtons):
      
      Return an empty IntRect if there are not buttons.
      (WebCore::buttonRepaintRect):
      
      Source/WebKit/mac: 
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      Source/WebKit2: 
      
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ce11413
    • rniwa@webkit.org's avatar
      2011-01-26 Ryosuke Niwa <rniwa@webkit.org> · d495d9e7
      rniwa@webkit.org authored
              Reviewed Chromium Windows/Linux rebaselines for r76726.
      
              * platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
              * platform/chromium-linux/fast/table/028-vertical-expected.checksum:
              * platform/chromium-linux/fast/table/028-vertical-expected.png:
              * platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.checksum:
              * platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.png:
              * platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.
              * platform/chromium-win/fast/table/028-vertical-expected.checksum:
              * platform/chromium-win/fast/table/028-vertical-expected.png:
              * platform/chromium-win/fast/table/028-vertical-expected.txt:
              * platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.checksum:
              * platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png:
              * platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d495d9e7
    • rniwa@webkit.org's avatar
      2011-01-26 Ryosuke Niwa <rniwa@webkit.org> · 6ffcf50c
      rniwa@webkit.org authored
              Reviewed Chromium Windows/Linux rebaselines for r76726.
      
              * platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-rl: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ffcf50c
    • rniwa@webkit.org's avatar
      2011-01-26 Ryosuke Niwa <rniwa@webkit.org> · e9693fb9
      rniwa@webkit.org authored
              Reviewed Chromium Windows/Linux rebaselines for r76726.
      
              * platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum:
              * platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png:
              * platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
              * platform/chromium-linux/fast/lists/002-vertical-expected.png:
              * platform/chromium-linux/fast/lists/002-vertical-expected.txt: Removed.
              * platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
              * platform/chromium-linux/fast/lists/003-vertical-expected.png:
              * platform/chromium-linux/fast/multicol/vertical-lr: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
              * platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
              * platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.checksum:
              * platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png:
              * platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.txt:
              * platform/chromium-win/fast/lists/002-vertical-expected.checksum:
              * platform/chromium-win/fast/lists/002-vertical-expected.png:
              * platform/chromium-win/fast/lists/002-vertical-expected.txt:
              * platform/chromium-win/fast/lists/003-vertical-expected.checksum:
              * platform/chromium-win/fast/lists/003-vertical-expected.png:
              * platform/chromium-win/fast/lists/003-vertical-expected.txt:
              * platform/chromium-win/fast/multicol/vertical-lr: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
              * platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9693fb9
    • bweinstein@apple.com's avatar
      Rebaseline Windows fast/blockfow results after r76726. · 66b5fb6e
      bweinstein@apple.com authored
      * platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
      * platform/win/fast/blockflow/vertical-baseline-alignment-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66b5fb6e
    • mrobinson@webkit.org's avatar
      2011-01-26 Martin Robinson <mrobinson@igalia.com> · 3ce973c3
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Pixel dumps do not include scrollbars in output images
              https://bugs.webkit.org/show_bug.cgi?id=53216
      
              Update expected results which should show scrollbars.
      
              * platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
              * platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
              * platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
              * platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.png:
              * platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
              * platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
              * platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum:
              * platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
              * platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum:
              * platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
              * platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
              * platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
              * platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum:
              * platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
              * platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.checksum:
              * platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.png:
              * platform/gtk/css2.1/t1202-counters-08-b-expected.checksum:
              * platform/gtk/css2.1/t1202-counters-08-b-expected.png:
              * platform/gtk/css2.1/t1202-counters-09-b-expected.checksum:
              * platform/gtk/css2.1/t1202-counters-09-b-expected.png:
              * platform/gtk/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum:
              * platform/gtk/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
              * platform/gtk/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum:
              * platform/gtk/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
              * platform/gtk/css2.1/t1508-c527-font-07-b-expected.checksum:
              * platform/gtk/css2.1/t1508-c527-font-07-b-expected.png:
      2011-01-26  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] Pixel dumps do not include scrollbars in output images
              https://bugs.webkit.org/show_bug.cgi?id=53216
      
              Show scrollbars in pixel dumps. This will fix pixel dumps for tests
              that have scrollbars.
      
              * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
              (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
              instead of the web view itself.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ce973c3
    • mrobinson@webkit.org's avatar
      2011-01-26 Martin Robinson <mrobinson@igalia.com> · 132c61da
      mrobinson@webkit.org authored
              [GTK] Text input controls do not react properly to CSS styling
              https://bugs.webkit.org/show_bug.cgi?id=40855
      
              Unskip tests which were previously skipped due to issue #40855.
              The bug is closed now, so it's safe to rebaseline the tests and
              unskip them.
      
              * platform/gtk/Skipped: Unskip tests.
              * platform/gtk/fast/forms/basic-selects-expected.checksum:
              * platform/gtk/fast/forms/basic-selects-expected.png:
              * platform/gtk/fast/forms/basic-selects-expected.txt:
              * platform/gtk/fast/forms/basic-textareas-quirks-expected.checksum:
              * platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
              * platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      132c61da
    • mrobinson@webkit.org's avatar
      2011-01-26 Martin Robinson <mrobinson@igalia.com> · aaf24c20
      mrobinson@webkit.org authored
              [GTK] media/unsupported-rtsp.html fails after timing out
              https://bugs.webkit.org/show_bug.cgi?id=53056
      
              * platform/gtk/Skipped: Update the skipped list to explain why this
              test is skipped and should remain skipped.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aaf24c20
    • dpranke@chromium.org's avatar
      2011-01-26 Dirk Pranke <dpranke@chromium.org> · c2257daa
      dpranke@chromium.org authored
              Reviewed by Mihai Parparita.
      
              Fix regression introduced in r76322 ... new-run-webkit-tests
              was attempting to save the image diff output as a UTF-8-encoded
              file.
      
              https://bugs.webkit.org/show_bug.cgi?id=53210
      
              * Scripts/webkitpy/layout_tests/port/webkit.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2257daa
    • weinig@apple.com's avatar
      Add events to represent the start/end of a gesture scroll · 99b7847a
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53215
      
      Reviewed by Maciej Stachowiak.
      
      Source/JavaScriptCore: 
      
      * wtf/Platform.h: Add ENABLE for gesture events. 
      
      Source/WebCore: 
      
      * WebCore.exp.in: 
      Add new file.
      
      * WebCore.xcodeproj/project.pbxproj:
      Add new file.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleGestureEvent):
      * page/EventHandler.h:
      Add entry point for handling gesture events.
      
      * platform/PlatformGestureEvent.h: Added.
      (WebCore::PlatformGestureEvent::PlatformGestureEvent):
      (WebCore::PlatformGestureEvent::type):
      (WebCore::PlatformGestureEvent::position):
      (WebCore::PlatformGestureEvent::globalPosition):
      (WebCore::PlatformGestureEvent::timestamp):
      Add platform agnostic representation of a gesture event.
      
      Source/WebKit2: 
      
      * Scripts/webkit2/messages.py:
      * Shared/WebEvent.h:
      (WebKit::WebGestureEvent::WebGestureEvent):
      (WebKit::WebGestureEvent::position):
      (WebKit::WebGestureEvent::globalPosition):
      * Shared/WebEventConversion.cpp:
      (WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
      (WebKit::platform):
      * Shared/WebEventConversion.h:
      * Shared/WebGestureEvent.cpp: Added.
      (WebKit::WebGestureEvent::WebGestureEvent):
      (WebKit::WebGestureEvent::encode):
      (WebKit::WebGestureEvent::decode):
      (WebKit::WebGestureEvent::isGestureEventType):
      * Shared/mac/WebEventFactory.h:
      * Shared/mac/WebEventFactory.mm:
      (WebKit::gestureEventTypeForEvent):
      (WebKit::WebEventFactory::createWebGestureEvent):
      * UIProcess/API/mac/WKView.mm:
      (-[WKView shortCircuitedEndGestureWithEvent:]):
      (-[WKView beginGestureWithEvent:]):
      (-[WKView viewDidMoveToWindow]):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::handleGestureEvent):
      (WebKit::WebPageProxy::didReceiveEvent):
      * UIProcess/WebPageProxy.h:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::handleGestureEvent):
      (WebKit::WebPage::gestureEvent):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      Pipe gesture events down to WebCore.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99b7847a
    • tkent@chromium.org's avatar
      2011-01-26 Kent Tamura <tkent@chromium.org> · 04df567e
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [Chromium] WebFrame::forms() should not return empty WebFormElements
              https://bugs.webkit.org/show_bug.cgi?id=53204
      
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::forms):
               - Should iterate by forms->length(), not the number of HTMLElements.
               - Do not increment the index for "temp" if a node is not an HTMLElement.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04df567e
    • mitz@apple.com's avatar
      <rdar://problem/8446709> Allow inter-ideograph justification for CJK · 86470c87
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53184
      
      Reviewed by Dave Hyatt.
      
      Source/WebCore: 
      
      Tests: fast/text/justify-ideograph-complex.html
             fast/text/justify-ideograph-simple.html
             fast/text/justify-ideograph-vertical.html
      
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawTextInternal): Corrected the type of the third parameter
      passed to the TextRun constructor and added the trailingExpansionBehavior parameter.
      * platform/graphics/Font.cpp:
      (WebCore::Font::expansionOpportunityCount): Added. Returns the number of expansion opportunities
      for text justification. On entry, isAfterExpansion says whether an expansion opportunity exists
      before the first character. On return, isAfterExpansion says whether an expansion opportunity
      exists after the last character.
      * platform/graphics/Font.h: 
      * platform/graphics/GlyphBuffer.h:
      (WebCore::GlyphBuffer::expandLastAdvance): Added.
      * platform/graphics/TextRun.h:
      (WebCore::TextRun::TextRun): Added a TrailingExpansionBehavior parameter to the constructors.
      Renamed padding to expansion.
      (WebCore::TextRun::expansion): Renamed padding() to this.
      (WebCore::TextRun::allowsTrailingExpansion): Added this accessor.
      * platform/graphics/WidthIterator.cpp:
      (WebCore::WidthIterator::WidthIterator): Initialize m_isAfterExpansion. Use Font::expansionOpportunityCount()
      and adjust the count if it includes a trailing expansion opportunity but the run disallows trailing
      expansion.
      (WebCore::WidthIterator::advance): Apply expansion before and after CJK ideographs.
      (WebCore::WidthIterator::advanceOneCharacter): Changed to not clear the GlyphBuffer so that advance()
      can expand the last advance if it is followed by a CJK ideograph.
      * platform/graphics/WidthIterator.h: Renamed m_padding to m_expansion and m_padPerSpace
      to m_expansionPerOpportunity.
      * platform/graphics/chromium/FontChromiumWin.cpp:
      (WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
      * platform/graphics/chromium/FontLinux.cpp:
      (WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
      * platform/graphics/efl/FontEfl.cpp:
      (WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
      * platform/graphics/gtk/FontGtk.cpp:
      (WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
      * platform/graphics/haiku/FontHaiku.cpp:
      (WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
      * platform/graphics/mac/ComplexTextController.cpp:
      (WebCore::ComplexTextController::ComplexTextController): Initialize m_isAfterExpansion. Use
      Font::expansionOpportunityCount() and adjust the count if it includes a trailing expansion
      opportunity but the run disallows trailing expansion.
      (WebCore::ComplexTextController::adjustGlyphsAndAdvances): Moved the definition and initialization
      of hasExtraSpacing outside the loop. Apply expansion before and after CJK ideographs.
      * platform/graphics/mac/ComplexTextController.h: Renamed m_padding to m_expansion and m_padPerSpace
      to m_expansionPerOpportunity.
      * platform/graphics/mac/FontMac.mm:
      (WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
      * platform/graphics/qt/FontQt.cpp:
      (WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
      * platform/graphics/win/FontWin.cpp:
      (WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
      * platform/graphics/win/UniscribeController.cpp:
      (WebCore::UniscribeController::UniscribeController): Updated for rename.
      * platform/graphics/wince/FontWinCE.cpp:
      (WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
      * platform/graphics/wx/FontWx.cpp:
      (WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
      * rendering/EllipsisBox.cpp:
      (WebCore::EllipsisBox::paint): Pass a TrailingExpansionBehavior to the TextRun constructor.
      (WebCore::EllipsisBox::selectionRect): Ditto.
      (WebCore::EllipsisBox::paintSelection): Ditto.
      * rendering/InlineBox.h:
      (WebCore::InlineBox::InlineBox): Renamed m_toAdd to m_expansion.
      (WebCore::InlineBox::expansion): Renamed toAdd() to this.
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::selectionRect): Pass a TrailingExpansionBehavior to the TextRun constructor.
      (WebCore::InlineTextBox::paint): Ditto.
      (WebCore::InlineTextBox::paintSelection): Ditto.
      (WebCore::InlineTextBox::paintCompositionBackground): Ditto.
      (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
      (WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
      (WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
      (WebCore::InlineTextBox::offsetForPosition): Ditto.
      (WebCore::InlineTextBox::positionForOffset): Ditto.
      * rendering/InlineTextBox.h:
      (WebCore::InlineTextBox::setExpansion): Renamed setSpaceAdd() to this.
      (WebCore::InlineTextBox::trailingExpansionBehavior): Added. Trailing expansion is allowed if this
      is not the last leaf box on the line.
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Keep expansion opportunity counts
      in a vector instead of computing them twice. Discard the trailing expansion opportunity in the
      last text box.
      * rendering/RenderFileUploadControl.cpp:
      (WebCore::RenderFileUploadControl::paintObject): Pass a TrailingExpansionBehavior to the TextRun constructor.
      (WebCore::RenderFileUploadControl::computePreferredLogicalWidths): Ditto.
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::updateFromElement): Ditto.
      (WebCore::RenderListBox::paintItemForeground): Ditto. Also corrected the type of the second parameter.
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::getAvgCharWidth): Ditto.
      (WebCore::RenderTextControl::paintPlaceholder): Ditto.
      * rendering/svg/SVGInlineTextBox.cpp:
      (WebCore::SVGInlineTextBox::constructTextRun): Ditto.
      
      Source/WebKit/chromium: 
      
      * src/WebTextRun.cpp:
      (WebKit::WebTextRun::operator WebCore::TextRun): Added a TrailingExpansionBehavior parameter to the
      RenderText constructor.
      
      Source/WebKit2: 
      
      * WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
      (WebKit::WebPopupMenu::setUpPlatformData): Added a TrailingExpansionBehavior parameter to the
      RenderText constructor.
      
      LayoutTests: 
      
      * fast/text/justify-ideograph-complex.html: Added.
      * fast/text/justify-ideograph-simple.html: Added.
      * fast/text/justify-ideograph-vertical.html: Added.
      * platform/mac/fast/text/justify-ideograph-complex-expected.checksum: Added.
      * platform/mac/fast/text/justify-ideograph-complex-expected.png: Added.
      * platform/mac/fast/text/justify-ideograph-complex-expected.txt: Added.
      * platform/mac/fast/text/justify-ideograph-simple-expected.checksum: Added.
      * platform/mac/fast/text/justify-ideograph-simple-expected.png: Added.
      * platform/mac/fast/text/justify-ideograph-simple-expected.txt: Added.
      * platform/mac/fast/text/justify-ideograph-vertical-expected.checksum: Added.
      * platform/mac/fast/text/justify-ideograph-vertical-expected.png: Added.
      * platform/mac/fast/text/justify-ideograph-vertical-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86470c87