1. 24 Jul, 2013 2 commits
  2. 23 Jul, 2013 1 commit
    • akling@apple.com's avatar
      REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may... · d483f707
      akling@apple.com authored
      REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
      <rdar://problem/14324895>
      <http://webkit.org/b/119023>
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      The bug happened when FrameView::autoSizeIfEnabled() was getting called below FrameLoader::checkCompleted()
      triggered by an incorrect loadDone() callback originating in SubresourceLoader::didCancel().
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::loadPendingResources):
      
          Add an assertion that this function is not getting re-entered. If a similar bug occurs
          in the future, this will help the lucky person debugging.
      
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::didCancel):
      
          Don't notifyDone() if the SubresourceLoader is in Uninitialized state.
      
      Tools:
      
      Add a test for this rather specific problem.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
      (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
      (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
      (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d483f707
  3. 21 Jul, 2013 1 commit
  4. 19 Jul, 2013 2 commits
    • slewis@apple.com's avatar
      <rdar://problem/14499595> pagination wk2 api test failing on ML (118928) · f24fdd39
      slewis@apple.com authored
      Unreviewed.
      
      Rebaseline pagination test after http://trac.webkit.org/changeset/152911
      
      * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
      (TestWebKitAPI::didLayout):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f24fdd39
    • achristensen@apple.com's avatar
      Added x64 configuration to Visual Studio build. · e39f7656
      achristensen@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118888
      
      Reviewed by Brent Fulgham.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
      * JavaScriptCore.vcxproj/jsc/jsc.vcxproj:
      * JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
      * JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
      
      Source/ThirdParty:
      
      * gtest/msvc/gtest-md.vcxproj:
      
      Source/WebCore:
      
      * WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCoreGenerated.vcxproj:
      * WebCore.vcxproj/WebCoreTestSupport.vcxproj:
      
      Source/WebKit:
      
      * WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
      * WebKit.vcxproj/WebKit.sln:
      * WebKit.vcxproj/WebKit/WebKit.vcxproj:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
      
      Source/WTF:
      
      * WTF.vcxproj/WTF.vcxproj:
      * WTF.vcxproj/WTF.vcxproj.filters:
      * WTF.vcxproj/WTFGenerated.vcxproj:
      
      Tools:
      
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
      * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
      * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
      * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
      * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
      * win/record-memory/record-memory.vcxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e39f7656
  5. 17 Jul, 2013 1 commit
    • kbalazs@webkit.org's avatar
      [CMake] Undefined references should be detected at build time · d50a83e0
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110236
      
      Patch by Balazs Kelemen <kbalazs@webkit.org> on 2013-07-16
      Reviewed by Christophe Dumez.
      
      .:
      
      Pass the --no-undefined argument to the linker on platforms where it is available.
      
      * Source/cmake/OptionsCommon.cmake:
      
      Source/WebKit:
      
      Add library dependencies that were not defined explicitly before.
      
      * CMakeLists.txt:
      * PlatformEfl.cmake:
      
      Source/WebKit2:
      
      Add library dependencies that were not defined explicitly before.
      
      * CMakeLists.txt:
      * PlatformEfl.cmake:
      
      Tools:
      
      Add library dependencies that were not defined explicitly before.
      
      * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
      * TestWebKitAPI/CMakeLists.txt:
      * WebKitTestRunner/CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d50a83e0
  6. 15 Jul, 2013 1 commit
  7. 09 Jul, 2013 1 commit
  8. 08 Jul, 2013 1 commit
  9. 06 Jul, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Update list of EFL WK2 API tests · 409bf26a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118443
      
      Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-07-06
      Reviewed by Christophe Dumez.
      
      The following tests were included:
      
      Passing:
      - CloseThenTerminate
      - DidAssociateFormControls
      - PageVisibilityState
      - ResponsivenessTimerDoesntFireEarly
      - TerminateTwice
      - WillLoad
      
      Failing:
      - ResizeReversePaginatedWebView
      - ScrollPinningBehaviors
      
      This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
      alphabetical order.
      
      * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
      * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      409bf26a
  10. 05 Jul, 2013 2 commits
    • timothy_horton@apple.com's avatar
      Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong · 719e255a
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118439
      <rdar://problem/14366120>
      
      Reviewed by Anders Carlsson.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::maximumScrollPosition):
      - Test both Page and FrameView's pagination modes.
      - *Don't* clamp negatives to zero if we are paginated with scroll offset set,
          like the original changelog claimed, but the code did the opposite.
      - Don't clamp in *all* pagination modes; with 'direction: RTL' it's still possible
          to have a negative maximum position in LTR/TB pagination modes.
      
      * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
      (TestWebKitAPI::didLayout):
      (TestWebKitAPI::TEST):
      - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
      - Assert that we got the right number of pages for sanity.
      - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
          so much memory that SharedMemory asserts and makes the test time out.
      - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
          because paint doesn't fire if the window is offscreen.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      719e255a
    • timothy_horton@apple.com's avatar
      [wk2] Add API to lock the scroll position at the top or bottom of the page · 8685d4e7
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118429
      <rdar://problem/14120323>
      
      Reviewed by Anders Carlsson.
      
      Test (API): WebKit2.ScrollPinningBehaviors
      
      * WebCore.exp.in:
      Expose FrameView::setScrollPinningBehavior.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::FrameView):
      Our pinning behavior should be DoNotPin by default.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::minimumScrollPosition):
      (WebCore::FrameView::maximumScrollPosition):
      * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
      (WebCore::ScrollingTreeScrollingNodeMac::minimumScrollPosition):
      (WebCore::ScrollingTreeScrollingNodeMac::maximumScrollPosition):
      Fix the minimum scroll position's vertical location to the maximum if
      we're pinned to the bottom, and vice-versa if we're pinned to the top.
      
      (WebCore::FrameView::setScrollPinningBehavior): Added.
      If scroll pinning behavior has changed, inform ScrollingCoordinator
      and update scrollbars (which will also re-pin the scroll position).
      
      * page/FrameView.h:
      Override minimumScrollPosition, add setScrollPinningBehavior,
      and storage for m_scrollPinningBehavior.
      
      * page/scrolling/ScrollingCoordinator.h:
      (WebCore::ScrollingCoordinator::setScrollPinningBehavior): Added.
      
      * page/scrolling/ScrollingTree.cpp:
      (WebCore::ScrollingTree::ScrollingTree):
      Our pinning behavior should be DoNotPin by default.
      
      (WebCore::ScrollingTree::setScrollPinningBehavior):
      (WebCore::ScrollingTree::scrollPinningBehavior):
      Getter/setter for m_scrollPinningBehavior, scrolling-thread-safe.
      
      * page/scrolling/ScrollingTree.h:
      * page/scrolling/mac/ScrollingCoordinatorMac.h:
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      (WebCore::ScrollingCoordinatorMac::setScrollPinningBehavior):
      Inform ScrollingTree of the scroll pinning behavior change.
      
      * platform/ScrollTypes.h:
      Add ScrollPinningBehavior enum.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
      (TestWebKitAPI::didFinishDocumentLoadForFrame):
      (TestWebKitAPI::TEST):
      Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
      all work correctly in the face of resizing the view and scrolling from JS.
      
      * Shared/WebPageCreationParameters.cpp:
      (WebKit::WebPageCreationParameters::encode):
      (WebKit::WebPageCreationParameters::decode):
      * Shared/WebPageCreationParameters.h:
      Pass the current ScrollPinningBehavior across to the WebPage upon creation.
      
      * UIProcess/API/C/WKPage.cpp:
      (WKPageGetScrollPinningBehavior):
      (WKPageSetScrollPinningBehavior):
      * UIProcess/API/C/WKPagePrivate.h:
      SPI to get/set the WebPageProxy's current ScrollPinningBehavior.
      Convert between WK API type and WebCore enum.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      (WebKit::WebPageProxy::creationParameters):
      Send ScrollPinningBehavior when creating a WebPage.
      
      (WebKit::WebPageProxy::setScrollPinningBehavior):
      Pass ScrollPinningBehavior changes across to the WebProcess (and save it
      in WebPageProxy so it can be sent back across if the WebProcess crashes).
      
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::scrollPinningBehavior):
      Getter/setter and storage for m_scrollPinningBehavior.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
      Inform new FrameViews of the current ScrollPinningBehavior.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      Set our ScrollPinningBehavior based on our creation parameters.
      
      (WebKit::WebPage::setScrollPinningBehavior):
      Inform the FrameView of ScrollPinningBehavior changes.
      
      * WebProcess/WebPage/WebPage.h:
      (WebKit::WebPage::scrollPinningBehavior): Added.
      (WebKit::WebPage::setScrollPinningBehavior): Added.
      Add storage for m_scrollPinningBehavior.
      
      * WebProcess/WebPage/WebPage.messages.in:
      Add SetScrollPinningBehavior message.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8685d4e7
  11. 01 Jul, 2013 1 commit
    • timothy_horton@apple.com's avatar
      Maximum scroll position can be negative in some cases · ed528286
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118175
      <rdar://problem/14301217>
      
      Reviewed by Anders Carlsson.
      
      Test (API): WebKit2.ResizeReversePaginatedWebView
      
      * page/FrameView.cpp:
      (WebCore::FrameView::maximumScrollPosition):
      * page/FrameView.h:
      Override maximumScrollPosition() in FrameView and don't clamp to zero if
      a reverse pagination mode is enabled, as it is possible (and common) to
      have a negative maximum scroll position with reverse pagination.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars):
      Drive-by adoption of toIntSize().
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
      (TestWebKitAPI::didRunJavaScript):
      (TestWebKitAPI::didLayout):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
      Add a test that loads a vertical-lr document, paginates it horizontally
      from right to left, resizes the view to fit the entire document, and
      verifies that the scroll position is negative, as it must be for the
      document to be enclosed by the view.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed528286
  12. 28 Jun, 2013 3 commits
  13. 27 Jun, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Fixing some compiler warnings · e5994d3a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117791
      
      Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-27
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      No new tests needed.
      
      * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
      (webkitAccessibleTextGetTextForOffset): Fixed warning about
      uninitialized variable.
      
      Source/WebKit2:
      
      * UIProcess/API/gtk/tests/WebExtensionTest.cpp: Properly
      initialized GDBusInterfaceVTable.
      * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
      (webkitWebPageCreate): Added missing fields to the
      WKBundlePageLoaderClient.
      
      Tools:
      
      * GNUmakefile.am: Silenced format warning.
      * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
      (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
      Solved warning about uninitialized variable.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5994d3a
  14. 18 Jun, 2013 2 commits
  15. 14 Jun, 2013 1 commit
    • enrica@apple.com's avatar
      WKPageFindStringMatches ignores the kWKFindOptionsBackwards option. · 3dec912d
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117647
      <rdar://problem/13881024>
      
      Source/WebCore: 
      
      Reviewed by Darin Adler.
              
      The API returns the matched ranges in the DOM order regardless of the
      find direction, but the index of the first match after the user selection
      should take the find direction into account.
      
      Extended existing test in TestWebKitAPI.
      
      * page/Page.cpp:
      (WebCore::Page::findStringMatchingRanges): Added handling of the Backwards case.
      * page/Page.h: Fixed incorrect name of the enum.
      
      Source/WebKit2: 
      
      Reviewed by Darin Adler.
              
      The API returns the matched ranges in the DOM order regardless of the
      find direction, but the index of the first match after the user selection
      should take the find direction into account.
      
      Extended existing test in TestWebKitAPI.
      
      * Shared/API/c/WKFindOptions.h: Added enum for the case where there are
      no matches after the user selection in the direction of the find.
      
      Tools: 
      
      Reviewed by Darin Adler.
              
      The test now uses content with a selection and tests both
      forwards and backward find as well as the case of a find
      that has no matches after the user selection.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
      (TestWebKitAPI::didFindStringMatches):
      * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dec912d
  16. 12 Jun, 2013 1 commit
    • zandobersek@gmail.com's avatar
      [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them · 1978f085
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116723
      
      Reviewed by Carlos Garcia Campos.
      
      Source/WebKit2: 
      
      * GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the
      current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
      to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
      and produces a working archive without problems even on incremental builds.
      
      Tools: 
      
      * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
      remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
      and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
      not expensive and produces a working archive without problems even on incremental builds.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1978f085
  17. 08 Jun, 2013 1 commit
  18. 05 Jun, 2013 1 commit
    • abecsi@webkit.org's avatar
      [Qt][WK2] Fix layout testing with Qt 5.1 · f8672fe9
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117203
      
      Reviewed by Jocelyn Turcotte.
      
      With Qt 5.1 synchronous requests via QNetworkAccessManager do not
      go into loading state but directly call handler functions for
      finished state instead of relying on a connection.
      Our wrapper QQuickView uses a data URI scheme to create the root
      item for testing which results in a synchronous request when loading
      the QML data, therefore the state of the QQuickWindow immediately
      becomes Ready.
      Since the final initialization of the root item depended on the
      emission of QQuickView::statusChanged(QQuickView::Ready) we ended
      up with a partially initialized wrapper window, thus most of our
      layout tests were failing.
      For compatibility with pre-5.1 Qt versions keep the old behaviour
      in case the WrapperWindow is not ready in the constructor yet.
      
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::WrapperWindow::WrapperWindow):
      * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
      (TestWebKitAPI::WrapperWindow::WrapperWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8672fe9
  19. 04 Jun, 2013 1 commit
  20. 03 Jun, 2013 2 commits
  21. 31 May, 2013 4 commits
  22. 30 May, 2013 1 commit
    • roger_fong@apple.com's avatar
      Get rid of JavaScript exports file on AppleWin port. · 0f04ad38
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117050.
      
      Reviewed by Darin Adler.
      
      This requires turning WTF into a shared library and adding the WTF_EXPORT_PRIVATE to some methods where it was missed.
      Start linking in WTF.lib now that it's a shared library.
      Also, delete the JavaScriptCoreExportGenerator folder and remove dependencies.
      
      * JavaScriptCore.vcxproj/JavaScriptCore.submit.sln:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      * JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPreBuild.cmd: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorProduction.props: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Removed.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/make-export-file-generator: Removed.
      * JavaScriptCore.vcxproj/jsc/jscCommon.props:
      * JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
      * JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters:
      * JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props:
      * JavaScriptCore.vcxproj/testapi/testapiCommon.props:
      * WTF.vcxproj/WTF.vcxproj:
      * WTF.vcxproj/WTFCommon.props:
      * wtf/DateMath.h:
      * wtf/ExportMacros.h:
      * wtf/FilePrintStream.h:
      * wtf/OSAllocator.h:
      * wtf/PageAllocationAligned.h:
      * wtf/Platform.h:
      * wtf/PrintStream.h:
      * wtf/StackBounds.h:
      * wtf/StringPrintStream.h:
      * wtf/ThreadSpecific.h:
      * wtf/WTFThreadData.h:
      * wtf/dtoa/cached-powers.h:
      * wtf/dtoa/double-conversion.h:
      * wtf/text/WTFString.h:
      * wtf/unicode/Collator.h:
      * wtf/unicode/UTF8.h:
      * WebKit.vcxproj/WebKit.sln:
      * WebKit.vcxproj/WebKit/WebKitCommon.props:
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
      * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
      * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f04ad38
  23. 29 May, 2013 2 commits
    • marcelo.lira@openbossa.org's avatar
      [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says · d8e2fb69
      marcelo.lira@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116683
      
      Reviewed by Noam Rosenthal.
      
      Source/WebKit2:
      
      WKViewUserViewportToContents now converts WebView coordinates to
      page contents coordinates, taking into account factors as content
      scale and scroll, and also device scale.
      
      The function WKViewUserViewportToScene was added to convert WebView
      coordinates to the coordinates of the canvas/scene where the view
      is drawn, and EwkView was fixed to use it, instead of
      WKViewUserViewportToContents.
      
      * UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
      (WKViewUserViewportToScene):
      * UIProcess/API/C/CoordinatedGraphics/WKView.h:
      * UIProcess/API/efl/EwkView.cpp:
      (EwkView::createGLSurface):
      * UIProcess/CoordinatedGraphics/WebView.cpp:
      (WebKit::WebView::userViewportToContents):
      (WebKit):
      (WebKit::WebView::userViewportToScene):
      (WebKit::WebView::transformToScene):
      * UIProcess/CoordinatedGraphics/WebView.h:
      (WebView):
      
      Tools:
      
      A coordinates conversion test for WKViewUserViewportToContents was
      added to WebKit2 API tests.
      
      * TestWebKitAPI/PlatformEfl.cmake:
      * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
      (TestWebKitAPI):
      (TestWebKitAPI::TEST):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8e2fb69
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix make distcheck. · 6e607b30
      carlosgc@webkit.org authored
      .:
      
      * GNUmakefile.am: Add WebKitFeatures.h and WebKitFeatures.txt to
      DISTCLEANFILES.
      
      Source/WebKit2:
      
      * GNUmakefile.am: Add WebCoreLayerGtk2.a to DISTCLEANFILES.
      
      Tools:
      
      * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
      DISTCLEANFILES.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e607b30
  24. 25 May, 2013 1 commit
    • simon.fraser@apple.com's avatar
      Unprefix Page Visibility API · dc674b34
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102340
      
      Source/WebCore:
      
      Reviewed by Tim Horton.
      
      Remove prefixes from the document properties, and the visibilitychanged event.
      
      Rename the "preview" state to "unloaded". The "unloaded" state is never
      reached yet (see https://bugs.webkit.org/show_bug.cgi?id=116769).
      
      Add some comments to places where we should update the visibility state
      when going in and out of the page cache, but cannot safely do so yet.
      
      Tested by existing Page Visibility tests.
      
      * dom/Document.cpp:
      (WebCore::Document::pageVisibilityState):
      (WebCore::Document::visibilityState):
      (WebCore::Document::hidden):
      (WebCore::Document::dispatchVisibilityStateChangeEvent):
      * dom/Document.h:
      * dom/Document.idl:
      * dom/EventNames.h:
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::restore):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::stopLoading):
      * page/Page.cpp:
      (WebCore::Page::setVisibilityState):
      * page/PageVisibilityState.cpp:
      (WebCore::pageVisibilityStateString):
      * page/PageVisibilityState.h:
      
      Source/WebKit/efl:
      
      Reviewed by Tim Horton.
      
      Rename "preview" state to "unloaded" state.
      
      * WebCoreSupport/AssertMatchingEnums.cpp:
      * ewk/ewk_view.h:
      
      Source/WebKit/mac:
      
      Reviewed by Tim Horton.
      
      Renaming of the "preview" state to "unloaded".
      
      * WebView/WebView.mm:
      * WebView/WebViewPrivate.h:
      
      Source/WebKit2:
      
      Reviewed by Tim Horton.
      
      Renaming of the "preview" state to "unloaded".
      
      * Shared/API/c/WKPageVisibilityTypes.h:
      * Shared/API/c/WKSharedAPICast.h:
      (WebKit::toPageVisibilityState):
      
      Tools:
      
      Reviewed by Tim Horton.
      
      Rename "preview" state to "unloaded" state, and adjust the tests
      to test for it.
      
      * DumpRenderTree/mac/TestRunnerMac.mm:
      (TestRunner::setPageVisibility):
      * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
      (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
      (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
      (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
      (TestWebKitAPI::didRunStep4InStateUnloaded):
      * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
      * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
      (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::setPageVisibility):
      
      LayoutTests:
      
      Reviewed by Tim Horton.
      
      Remove prefixes, adjust to state name changes.
      
      * fast/events/page-visibility-iframe-delete-test.html:
      * fast/events/page-visibility-iframe-move-test-expected.txt:
      * fast/events/page-visibility-iframe-move-test.html:
      * fast/events/page-visibility-iframe-propagation-test-expected.txt:
      * fast/events/page-visibility-iframe-propagation-test.html:
      * fast/events/page-visibility-null-view-expected.txt:
      * fast/events/page-visibility-null-view.html:
      * fast/events/page-visibility-transition-test-expected.txt:
      * fast/events/page-visibility-transition-test.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc674b34
  25. 22 May, 2013 1 commit
  26. 21 May, 2013 4 commits
    • rniwa@webkit.org's avatar
      REGRESSION(r150369): WebKit2WillLoadTest tests are failing · d2b7c8df
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116585
      
      Reviewed by Alexey Proskuryakov.
      
      willLoadURLRequest and willLoadDataRequest require the API version 6.
      
      * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2b7c8df
    • jberlin@webkit.org's avatar
      Expose a way to know when forms are added to a page or when form controls are added to a form · f13d0a3d
      jberlin@webkit.org authored
      in the injected bundle
      https://bugs.webkit.org/show_bug.cgi?id=116334
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebKit2:
      
      Add shouldNotifyOnFormChanges and didAssociateFormControls to the WKBundlePageFormClient.
      
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      Add the new callbacks as part of version 2 of the WKBundlePageFormClient.
      
      * WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
      (WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
      Pass the message along to the client if the client has a handler.
      (WebKit::InjectedBundlePageFormClient::shouldNotifyOnFormChanges):
      Ditto.
      * WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::didAssociateFormControls):
      Tell the injected bundle form client for the page.
      (WebKit::WebChromeClient::shouldNotifyOnFormChanges):
      Ditto.
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      Tools:
      
      Add tests for the new callbacks.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
      
      * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
      (TestWebKitAPI::nullJavaScriptCallback):
      A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
      being passed in for the callback.
      (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
      After receiving the message that didAssociateFormControls callback was invoked from adding
      the form in the onload handler, tell the page to add a password field to the form, which
      should also invoke didAssociateFormControls callback.
      (TestWebKitAPI::setInjectedBundleClient):
      Register to receive messages.
      (TestWebKitAPI::TEST):
      Load associate-form-controls.html and wait until the didAssociateFormControls callback has
      been invoked for both adding the form and for adding a password field to the form.
      
      * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
      (TestWebKitAPI::shouldNotifyOnFormChanges):
      Return true so the didAssociateFormControls callback is invoked.
      (TestWebKitAPI::didAssociateFormControls):
      Tell the UI process.
      (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
      (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
      Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
      
      * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
      Add a form in response to the onload event. Add a button that will add the password field
      for manual testing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f13d0a3d
    • lforschler@apple.com's avatar
      Source/WebKit2: Rollout r150398. · b4f5bdcd
      lforschler@apple.com authored
      Tools:     Rollout 150398.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4f5bdcd
    • zandobersek@gmail.com's avatar
      [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time · 3df5d07b
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116450
      
      Reviewed by Martin Robinson.
      
      The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
      programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
      default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
      TestWebKitAPI programs when compiling them.
      
      * TestWebKitAPI/GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3df5d07b