1. 24 Jul, 2013 4 commits
  2. 23 Jul, 2013 2 commits
    • akling@apple.com's avatar
      REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may... · d483f707
      akling@apple.com authored
      REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
      <rdar://problem/14324895>
      <http://webkit.org/b/119023>
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      The bug happened when FrameView::autoSizeIfEnabled() was getting called below FrameLoader::checkCompleted()
      triggered by an incorrect loadDone() callback originating in SubresourceLoader::didCancel().
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::loadPendingResources):
      
          Add an assertion that this function is not getting re-entered. If a similar bug occurs
          in the future, this will help the lucky person debugging.
      
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::didCancel):
      
          Don't notifyDone() if the SubresourceLoader is in Uninitialized state.
      
      Tools:
      
      Add a test for this rather specific problem.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
      (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
      (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
      (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d483f707
    • timothy_horton@apple.com's avatar
      Add a test for plug-in unavailability indicator obscurity detection · b0aa0e2d
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119007
      
      Reviewed by Anders Carlsson.
      
      Test: plugins/unavailable-plugin-indicator-obscurity.html
      
      Expose the ability to test whether the unavailable plugin indicator
      is obscured via the internals object.
      
      * testing/Internals.cpp:
      (WebCore::Internals::isPluginUnavailabilityIndicatorObscured):
      * testing/Internals.h:
      * testing/Internals.idl:
      Expose RenderEmbeddedObject::isReplacementObscured as
      internals.isPluginUnavailabilityIndicatorObscured for testing purposes.
      
      Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::setBlockAllPlugins):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      * WebKitTestRunner/TestInvocation.cpp:
      (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
      Add testRunner.setBlockAllPlugins function (and corresponding message to
      forward it through to TestController).
      
      * WebKitTestRunner/TestController.cpp:
      Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
      
      (WTR::TestController::createWebViewWithOptions):
      Register our pluginLoadPolicy callback.
      
      (WTR::TestController::resetStateToConsistentValues):
      Reset m_shouldBlockAllPlugins to false.
      
      (WTR::TestController::pluginLoadPolicy):
      Return the existing plugin load policy, unless setBlockAllPlugins(true)
      was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
      
      * WebKitTestRunner/TestController.h:
      (WTR::TestController::setBlockAllPlugins):
      
      Add a test that ensures that RenderEmbeddedObject accurately detects the
      various different ways the unavailable plugin dialog can be obscured.
      
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      * plugins/unavailable-plugin-indicator-obscurity-expected.txt: Added.
      * plugins/unavailable-plugin-indicator-obscurity.html: Added.
      
      * Source/autotools/symbols.filter:
      Expose RenderEmbeddedObject::isReplacementObscured to internals.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0aa0e2d
  3. 21 Jul, 2013 1 commit
  4. 19 Jul, 2013 7 commits
    • cfleizach@apple.com's avatar
      AX: VoiceOver not detecting misspelled words don't work in all cases · acc39f51
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118924
      
      Reviewed by Tim Horton.
      
      Source/WebCore: 
      
      VoiceOver is now looking for a new misspelled attribute.
      
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (AXAttributeStringSetSpelling):
      (AXAttributedStringAppendText):
      
      Tools: 
      
      Make the misspelled detection dependent on both types of attributes being present.
      
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::attributedStringRangeIsMisspelled):
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
      (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acc39f51
    • slewis@apple.com's avatar
      <rdar://problem/14499595> pagination wk2 api test failing on ML (118928) · f24fdd39
      slewis@apple.com authored
      Unreviewed.
      
      Rebaseline pagination test after http://trac.webkit.org/changeset/152911
      
      * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
      (TestWebKitAPI::didLayout):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f24fdd39
    • achristensen@apple.com's avatar
      Improved code coverage generation. · 016228d7
      achristensen@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118926
      
      Reviewed by Tim Horton.
      
      * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
      * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
      (generateReport): Moved report generation to a subroutine.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      016228d7
    • dbates@webkit.org's avatar
      Make Perl tools work when using git bisect with Git branch build setup · 6e3b077c
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118512
      
      Reviewed by Martin Robinson.
      
      The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
      during a git bisect session with a Git branch build setup (i.e. git config
      core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
      specific build of WebKit because they cannot determine the branch Git is on (since
      git bisect puts Git into a detached HEAD state). We should teach our tooling to
      parse the file .git/BISECT_START (created by git bisect start) for the name of the
      branch Git was on when we began a git bisect session. Then the tools can determine
      the path to the built WebKit.
      
      * Scripts/VCSUtils.pm:
      (gitDirectory): Added.
      (gitBisectStartBranch): Added.
      (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
      HEAD (e.g. running git bisect).
      (determineVCSRoot): Modified to call gitDirectory() to determine the path to
      the .git directory in the Git checkout.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e3b077c
    • achristensen@apple.com's avatar
      Added x64 configuration to Visual Studio build. · e39f7656
      achristensen@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118888
      
      Reviewed by Brent Fulgham.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
      * JavaScriptCore.vcxproj/jsc/jsc.vcxproj:
      * JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
      * JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
      
      Source/ThirdParty:
      
      * gtest/msvc/gtest-md.vcxproj:
      
      Source/WebCore:
      
      * WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCoreGenerated.vcxproj:
      * WebCore.vcxproj/WebCoreTestSupport.vcxproj:
      
      Source/WebKit:
      
      * WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
      * WebKit.vcxproj/WebKit.sln:
      * WebKit.vcxproj/WebKit/WebKit.vcxproj:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
      
      Source/WTF:
      
      * WTF.vcxproj/WTF.vcxproj:
      * WTF.vcxproj/WTF.vcxproj.filters:
      * WTF.vcxproj/WTFGenerated.vcxproj:
      
      Tools:
      
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
      * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
      * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
      * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
      * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
      * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
      * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
      * win/record-memory/record-memory.vcxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e39f7656
    • mrobinson@webkit.org's avatar
      Add a couple people to the MathML watchlist · e3d51e3a
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118909
      
      Reviewed by Andreas Kling.
      
      Add a couple people to the MathML watchlist and add Kalyan's other
      email address to fix style checker warnings about the watchlist
      contents.
      
      * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
      list of contributors and add Kalyan's second email address.
      * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
      watchlist.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3d51e3a
    • commit-queue@webkit.org's avatar
      [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid · 38a48159
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118895
      
      Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-19
      Reviewed by Philippe Normand.
      
      In r152782 an uri is used to create an string representation without checking first if it
      is valid. That fails later when the string is used to check for existing redirections. This
      patch ensures that the uri is valid before using it.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (willSendRequestCallback): Ensure an uri is valid before using it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38a48159
  5. 18 Jul, 2013 6 commits
  6. 17 Jul, 2013 6 commits
    • timothy_horton@apple.com's avatar
      Update blocked/missing plug-in UI · 07d4588b
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118347
      <rdar://problem/14209318>
      
      Reviewed by Sam Weinig.
      
      * WebCore.exp.in:
      Export RenderEmbeddedObject::setPluginUnavailabilityReasonWithDescription.
      
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::replacementTextRoundedRectPressedColor):
      (WebCore::replacementTextRoundedRectColor):
      (WebCore::replacementTextColor):
      Change colors to new design and add some more constants.
      
      (WebCore::shouldUnavailablePluginMessageBeButton): Added.
      
      (WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonWithDescription): Added.
      (WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
      Call through to the -WithDescription variant.
      
      (WebCore::RenderEmbeddedObject::paintReplaced):
      Fill the background, and otherwise match the new design.
      
      (WebCore::addReplacementArrowPath):
      Add an arrow to the given path, inside the given rect.
      
      (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
      Add a 1px padding to the bottom of the text.
      Add a circle and an arrow into the indicator as per the new design.
      
      (WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
      Hit-test the indicator arrow as well; otherwise, the fact that the arrow
      is a hole in the path means it won't be hit.
      
      * rendering/RenderEmbeddedObject.h:
      
      * Platform/CoreIPC/HandleMessage.h:
      (CoreIPC::callMemberFunction):
      Add a 6 argument -> 4 reply message handler.
      (It seems that FindPlugin is getting a little out of hand.)
      
      * Shared/APIClientTraits.cpp:
      * Shared/APIClientTraits.h:
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebLoaderClient.cpp:
      (WebKit::WebLoaderClient::pluginLoadPolicy):
      * UIProcess/WebLoaderClient.h:
      Add an unavailability description out-argument to a new version of
      pluginLoadPolicy, so clients can override the text of the unavailable
      plugin indicator. Bump the WKPageLoaderClient version and update APIClientTraits.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::findPlugin):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      Plumb the unavailability description through to the WebProcess via
      the FindPlugin message.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      Acquire the unavailability description from the client
      (via FindPlugin) and hand it to the RenderEmbeddedObject.
      
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController awakeFromNib]):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::createWebViewWithOptions):
      Match new WKPageLoaderClient entry.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07d4588b
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r152701, r152703, r152739, r152754, · eab043f9
      commit-queue@webkit.org authored
      and r152756.
      http://trac.webkit.org/changeset/152701
      http://trac.webkit.org/changeset/152703
      http://trac.webkit.org/changeset/152739
      http://trac.webkit.org/changeset/152754
      http://trac.webkit.org/changeset/152756
      https://bugs.webkit.org/show_bug.cgi?id=118821
      
      this was a buggy fix and we're going to try something
      different (Requested by thorton on #webkit).
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.am:
      * WebCore.exp.in:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSDefaultStyleSheets.cpp:
      (WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
      * css/unavailablePlugIns.css: Removed.
      * dom/EventListener.h:
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::updateWidget):
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::defaultEventHandler):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
      * loader/SubframeLoader.cpp:
      (WebCore::SubframeLoader::createJavaAppletWidget):
      * page/ChromeClient.h:
      (WebCore::ChromeClient::shouldUnavailablePluginMessageBeButton):
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::replacementTextRoundedRectPressedColor):
      (WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
      (WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
      (WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsPressed):
      (WebCore::RenderEmbeddedObject::paint):
      (WebCore::RenderEmbeddedObject::paintReplaced):
      (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
      (WebCore::RenderEmbeddedObject::replacementTextRect):
      (WebCore::RenderEmbeddedObject::isReplacementObscured):
      (WebCore::RenderEmbeddedObject::layout):
      (WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
      (WebCore::shouldUnavailablePluginMessageBeButton):
      (WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
      (WebCore::RenderEmbeddedObject::getCursor):
      (WebCore::RenderEmbeddedObject::canHaveChildren):
      * rendering/RenderEmbeddedObject.h:
      * rendering/RenderWidget.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::shouldUnavailablePluginMessageBeButton):
      
      Source/WebKit2:
      
      * Platform/CoreIPC/HandleMessage.h:
      * Shared/APIClientTraits.cpp:
      * Shared/APIClientTraits.h:
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebLoaderClient.cpp:
      (WebKit::WebLoaderClient::pluginLoadPolicy):
      * UIProcess/WebLoaderClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::findPlugin):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * WebProcess/Plugins/PluginProcessConnection.cpp:
      (WebKit::PluginProcessConnection::didClose):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::pluginProcessCrashed):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      (WebKit::WebPage::canPluginHandleResponse):
      
      Tools:
      
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController awakeFromNib]):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::createWebViewWithOptions):
      
      LayoutTests:
      
      * editing/pasteboard/paste-noplugin-expected.txt:
      * http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt:
      * platform/mac/accessibility/plugin-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eab043f9
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r151535. · 0fdaa385
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/151535
      https://bugs.webkit.org/show_bug.cgi?id=118804
      
      Re-disable WinEWS tests (Requested by rfong on #webkit).
      
      * Scripts/webkitpy/common/config/ews.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fdaa385
    • commit-queue@webkit.org's avatar
      [GTK] Make DRT obbey testRunner's addURLToRedirect · 9bcbd6ec
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118239
      
      Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-17
      Reviewed by Gustavo Noronha Silva.
      
      Tools:
      
      Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
      to the proper URI when indicated.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (willSendRequestCallback):
      
      LayoutTests:
      
      Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html now that DRT obbeys
      testRunner's addURLToRedirect.
      
      * platform/gtk/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bcbd6ec
    • ossy@webkit.org's avatar
      Add a new find-resolved-bugs command to webkit-patch. · 7f417e39
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118060
      
      Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-17
      Reviewed by Csaba Osztrogonác.
      
      * Scripts/webkitpy/tool/commands/queries.py:
      (PrintBaselines._platform_for_path):
      (FindResolvedBugs):
      (FindResolvedBugs.execute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f417e39
    • kbalazs@webkit.org's avatar
      [CMake] Undefined references should be detected at build time · d50a83e0
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110236
      
      Patch by Balazs Kelemen <kbalazs@webkit.org> on 2013-07-16
      Reviewed by Christophe Dumez.
      
      .:
      
      Pass the --no-undefined argument to the linker on platforms where it is available.
      
      * Source/cmake/OptionsCommon.cmake:
      
      Source/WebKit:
      
      Add library dependencies that were not defined explicitly before.
      
      * CMakeLists.txt:
      * PlatformEfl.cmake:
      
      Source/WebKit2:
      
      Add library dependencies that were not defined explicitly before.
      
      * CMakeLists.txt:
      * PlatformEfl.cmake:
      
      Tools:
      
      Add library dependencies that were not defined explicitly before.
      
      * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
      * TestWebKitAPI/CMakeLists.txt:
      * WebKitTestRunner/CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d50a83e0
  7. 16 Jul, 2013 7 commits
  8. 15 Jul, 2013 6 commits
    • timothy_horton@apple.com's avatar
      Update blocked/missing plug-in UI · 7a561711
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118347
      <rdar://problem/14209318>
      
      Reviewed by Sam Weinig.
      Patch by Anders Carlsson, Antoine Quint, Sam Weinig, and myself.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.am:
      * WebCore.exp.in:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSDefaultStyleSheets.cpp:
      * css/unavailablePlugIns.css: Added.
      Add new Source/WebCore/css/unavailablePlugIns.css stylesheet.
      
      * dom/EventListener.h:
      New event listener type to support the creation of an event listener
      for the label and icon for missing / blocked plug-in UI.
      
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::defaultEventHandler):
      Remove explicit event handling since we're now using a DOM event handler
      on the label and icon in the shadow root.
      
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
      Don't populate the shadow root with plugin snapshotting elements
      if we're not planning on showing a snapshot, because this means that
      the shadow root was created for the unavailable plugin indicator instead.
      
      * page/ChromeClient.h:
      (WebCore::ChromeClient::shouldUnavailablePluginMessageIncludeButton):
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
      (WebCore::shouldUnavailablePluginMessageIncludeButton):
      Rename from shouldUnavailablePluginMessageBeButton to
      shouldUnavailablePluginMessageIncludeButton for accuracy.
      
      (WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonDescription):
      Set custom text to be displayed in the unavailability indicator.
      
      (WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
      (WebCore::RenderEmbeddedObject::handleUnavailablePluginButtonClickEvent):
      (WebCore::RenderEmbeddedObject::willBeDestroyed):
      (WebCore::RenderEmbeddedObject::isReplacementObscured):
      (WebCore::RenderEmbeddedObjectEventListener::handleEvent):
      (WebCore::RenderEmbeddedObjectEventListener::operator==):
      Remove the old code used to render the missing / blocked plug-in UI in C++ in favor
      of populating a shadow root in setPluginUnavailabilityReason(). We add a DOM event
      listener in the shadow root to eventually call into unavailablePluginButtonClicked()
      on the ChromeClient.
      
      (WebCore::RenderEmbeddedObject::paint):
      (WebCore::RenderEmbeddedObject::layout):
      Paint and lay out UA shadow root children.
      
      (WebCore::RenderEmbeddedObject::canHaveChildren):
      canHaveChildren can use the existence of a UA shadow root to decide
      whether a RenderEmbeddedObject can have children.
      
      * rendering/RenderEmbeddedObject.h:
      (WebCore::RenderEmbeddedObjectEventListener::create):
      (WebCore::RenderEmbeddedObjectEventListener::cast):
      (WebCore::RenderEmbeddedObjectEventListener::RenderEmbeddedObjectEventListener):
      Create the new event listener class necessary to handle events in the shadow root.
      
      (WebCore::RenderEmbeddedObject::pluginUnavailabilityReasonDescription): Added.
      
      * rendering/RenderWidget.h:
      Promote willBeDestroyed() to be public so we may override it in the RenderEmbeddedObject subclass.
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::shouldUnavailablePluginMessageIncludeButton):
      Rename from shouldUnavailablePluginMessageBeButton to
      shouldUnavailablePluginMessageIncludeButton for accuracy.
      
      * Platform/CoreIPC/HandleMessage.h:
      (CoreIPC::callMemberFunction):
      Add a 6 argument -> 4 reply message handler.
      (It seems that FindPlugin is getting a little out of hand.)
      
      * Shared/APIClientTraits.cpp:
      * Shared/APIClientTraits.h:
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebLoaderClient.cpp:
      (WebKit::WebLoaderClient::pluginLoadPolicy):
      * UIProcess/WebLoaderClient.h:
      Add an unavailability description out-argument to a new version of
      pluginLoadPolicy, so clients can override the text of the unavailable
      plugin indicator. Bump the WKPageLoaderClient version and update APIClientTraits.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::findPlugin):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      Plumb the unavailability description through to the WebProcess via
      the FindPlugin message.
      
      * WebProcess/Plugins/PluginProcessConnection.cpp:
      (WebKit::PluginProcessConnection::didClose):
      Make a strongly referencing copy of the list of PluginProxies, so we can
      throw them away without the HashMap being mutated underneath us (see the comment).
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::pluginProcessCrashed):
      Invalidate the plug-in's widget before setting the plugin unavailability reason,
      because doing so would cause the plug-in's renderer to be torn down, making
      invalidate() crash.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::shouldUnavailablePluginMessageIncludeButton):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      Rename from shouldUnavailablePluginMessageBeButton to
      shouldUnavailablePluginMessageIncludeButton for accuracy.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      Acquire the unavailability description from the client
      (via FindPlugin) and hand it to the RenderEmbeddedObject.
      (WebKit::WebPage::canPluginHandleResponse):
      Re-acquire the plugin's renderer, in case setPluginUnavailabilityReason destroyed it.
      
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController awakeFromNib]):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::createWebViewWithOptions):
      Match new WKPageLoaderClient entry.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a561711
    • kseo@webkit.org's avatar
      Unreviewed. Add Gwang Yoon Hwang to contributor list. · e81711eb
      kseo@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e81711eb
    • cfleizach@apple.com's avatar
      Update James Craig's email address. · ba55cad5
      cfleizach@apple.com authored
      * Scripts/webkitpy/common/config/contributors.json:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba55cad5
    • commit-queue@webkit.org's avatar
      [EFL] Add fallback for TestWebKitAPI if opengl is not available. · 0c0ecda4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118583
      
      Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-15
      Reviewed by Christophe Dumez.
      
      There're many fails on efl webkit2 API test if opengl is not available.
      So, add fallback to non-opengl evas engine.
      
      * TestWebKitAPI/efl/PlatformWebView.cpp:
      (TestWebKitAPI::initEcoreEvas):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c0ecda4
    • commit-queue@webkit.org's avatar
      check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member · 43e4154a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118592
      
      Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-15
      Reviewed by Martin Robinson.
      
      Added a suppression for pylint false positives and a unit test.
      
      * Scripts/webkitpy/style/checkers/python.py:
      (Pylinter):
      * Scripts/webkitpy/style/checkers/python_unittest.py:
      (PythonCheckerTest.test_check):
      (PythonCheckerTest):
      (PythonCheckerTest.test_pylint_false_positives):
      (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
      * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
      (test_popen):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43e4154a
    • commit-queue@webkit.org's avatar
      [GTK] Increase the JHBuild version of GStreamer to 1.0.7 · 867a054c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115166
      
      Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-15
      Reviewed by Philippe Normand.
      
      * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      867a054c
  9. 12 Jul, 2013 1 commit