1. 23 Jan, 2013 40 commits
    • oliver@apple.com's avatar
      Add RELEASE_ASSERT (and a few friends) · 1682c0f6
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107725
      
      Reviewed by Filip Pizlo.
      
      Adding a few macros to make release mode assertions easier and more readable.
      Also makes same assertions more useful in debug builds.
      
      * wtf/Assertions.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1682c0f6
    • tony@chromium.org's avatar
      Incorrect scrollable height during simplified layout · c65268d5
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107193
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      When computing overflow we need the height of the block before
      it was clamped (i.e., before updateLogicalHeight() has been called).
      
      During simplified layout, we don't have this information and we were
      using the clamped height by mistake. To fix this, we now store the
      pre-clamped height on RenderOverflow so we can properly compute
      overflow.
      
      Test: fast/overflow/height-during-simplified-layout.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::computeOverflow): Save the height if we have overflow.
      (WebCore::RenderBlock::simplifiedLayout): If we have overflow, use the height that we saved
      in computeOverflow.
      * rendering/RenderOverflow.h:
      (WebCore::RenderOverflow::layoutClientAfterEdge):
      (WebCore::RenderOverflow::setLayoutClientAfterEdge):
      (RenderOverflow): Add a member variable to save the height.
      
      LayoutTests:
      
      * fast/overflow/height-during-simplified-layout-expected.txt: Added.
      * fast/overflow/height-during-simplified-layout.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c65268d5
    • tsepez@chromium.org's avatar
      [chromium] harden ScriptWrappable::m_wrapper against tampering · f1550185
      tsepez@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107318
      
      Reviewed by Adam Barth.
      
      Patch is correct if existing tests past without crashing.
      
      * bindings/v8/ScriptWrappable.h:
      (WebCore::ScriptWrappable::ScriptWrappable):
      (WebCore::ScriptWrappable::wrapper):
      (WebCore::ScriptWrappable::setWrapper):
      (WebCore::ScriptWrappable::clearWrapper):
      (WebCore::ScriptWrappable::disposeWrapper):
      (WebCore::ScriptWrappable::reportMemoryUsage):
      (ScriptWrappable):
      (WebCore::ScriptWrappable::maskOrUnmaskPointer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1550185
    • roger_fong@apple.com's avatar
      WebCore property sheets, modified build scripts, and project files for compiling in VS2010. · 2d59f5ef
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106988
      
      Reviewed by Brent Fulgham.
      
      * WebCore.vcproj/WebCore.sln:
      * WebCore.vcxproj: Added.
      * WebCore.vcxproj/MigrateScripts: Added.
      * WebCore.vcxproj/QTMovieWin: Added.
      * WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj: Added.
      * WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj.filters: Added.
      * WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj.user: Added.
      * WebCore.vcxproj/QTMovieWin/QTMovieWinCommon.props: Added.
      * WebCore.vcxproj/QTMovieWin/QTMovieWinDebug.props: Added.
      * WebCore.vcxproj/QTMovieWin/QTMovieWinRelease.props: Added.
      * WebCore.vcxproj/WebCore.vcxproj: Added.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Added.
      * WebCore.vcxproj/WebCore.vcxproj.user: Added.
      * WebCore.vcxproj/WebCoreCFNetwork.props: Added.
      * WebCore.vcxproj/WebCoreCG.props: Added.
      * WebCore.vcxproj/WebCoreCommon.props: Added.
      * WebCore.vcxproj/WebCoreDebug.props: Added.
      * WebCore.vcxproj/WebCoreGenerated.make: Added.
      * WebCore.vcxproj/WebCoreGenerated.vcxproj: Added.
      * WebCore.vcxproj/WebCoreGenerated.vcxproj.filters: Added.
      * WebCore.vcxproj/WebCoreGenerated.vcxproj.user: Added.
      * WebCore.vcxproj/WebCoreGeneratedCommon.props: Added.
      * WebCore.vcxproj/WebCoreGeneratedDebug.props: Added.
      * WebCore.vcxproj/WebCoreGeneratedRelease.props: Added.
      * WebCore.vcxproj/WebCoreMediaQT.props: Added.
      * WebCore.vcxproj/WebCorePostBuild.cmd: Added.
      * WebCore.vcxproj/WebCorePreBuild.cmd: Added.
      * WebCore.vcxproj/WebCorePreLink.cmd: Added.
      * WebCore.vcxproj/WebCorePthreads.props: Added.
      * WebCore.vcxproj/WebCoreQuartzCore.props: Added.
      * WebCore.vcxproj/WebCoreRelease.props: Added.
      * WebCore.vcxproj/build-generated-files.sh: Added.
      * WebCore.vcxproj/copyForwardingHeaders.cmd: Added.
      * WebCore.vcxproj/copyWebCoreResourceFiles.cmd: Added.
      * WebCore.vcxproj/migrate-scripts.sh: Added.
      * WebCore.vcxproj/xcopy.excludes: Added.
      * WebCorePrefix.h:
      * config.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d59f5ef
    • eric@webkit.org's avatar
      HTMLCompactToken needs to include the forceQuirks bool from HTMLToken · ede568f2
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107713
      
      Reviewed by Tony Gentilcore.
      
      Before we were only getting "quirks mode" when the system/public identifiers
      were known quirks identifiers.  Now we'll correctly get quirks mode for any
      parse error during DOCTYPE parsing.
      This passes a bunch more tests.
      
      * html/parser/CompactHTMLToken.cpp:
      (WebCore::CompactHTMLToken::CompactHTMLToken):
      * html/parser/CompactHTMLToken.h:
      (WebCore::CompactHTMLToken::doctypeForcesQuirks):
      (CompactHTMLToken):
      * html/parser/HTMLToken.h:
      (WebCore::AtomicHTMLToken::AtomicHTMLToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ede568f2
    • beidson@apple.com's avatar
      Recursion handling cancelled authentication challenges in NetworkProcess · 44925771
      beidson@apple.com authored
      <rdar://problem/13024541> and https://bugs.webkit.org/show_bug.cgi?id=107702
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      
      Source/WebKit2:
      
      This turned in to both a bug fix with authentication and a minimal refactoring of NetworkResourceLoader.
      
      - Rename ::stop to ::resourceHandleStopped
      - Move all cleanup code to ::resourceHandleStopped
      - Schedule a resourceHandleStopped call when an authentication cancellation occurs
      - Tell the WebResourceLoader to cancel when an authentication cancellation occurs
      
      * NetworkProcess/NetworkResourceLoader.cpp:
      (WebKit::NetworkResourceLoader::~NetworkResourceLoader):
      (WebKit::NetworkResourceLoader::start):
      (WebKit::NetworkResourceLoader::performStops):
      (WebKit::NetworkResourceLoader::resourceHandleStopped):
      (WebKit::NetworkResourceLoader::didFail):
      (WebKit::NetworkResourceLoader::receivedAuthenticationCancellation):
      * NetworkProcess/NetworkResourceLoader.h:
      
      * WebProcess/Network/WebResourceLoader.cpp:
      (WebKit::WebResourceLoader::cancelResourceLoader):
      * WebProcess/Network/WebResourceLoader.h:
      * WebProcess/Network/WebResourceLoader.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44925771
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=107628 · c975f556
      bdakin@apple.com authored
      Sometimes scroll position is jerky during rubber-band, affects nytimes.com
      -and corresponding-
      <rdar://problem/12679549>
      
      Reviewed by Simon Fraser.
      
      The basic problem here is that isRubberBandInProgress() was only implemented for 
      main thread scrolling. So when we were actually scrolling on the scrolling thread, 
      that function would always return false regardless.
      
      New ScrollableArea virtual function isRubberBandInProgress() will allow us to ask 
      the ScrollingCoordinator when the scrolling thread is scrolling, or the 
      ScrollAnimator otherwise.
      * page/FrameView.cpp:
      (WebCore::FrameView::isRubberBandInProgress):
      * page/FrameView.h:
      (FrameView):
      * platform/ScrollableArea.h:
      (WebCore::ScrollableArea::isRubberBandInProgress):
      
      New ScrollingCoordinator function isRubberBandInProgress() always returns false 
      for non-Mac ports, and is overridden in ScrollingCoordinatorMac to consult the 
      ScrollingTree.
      * page/scrolling/ScrollingCoordinator.h:
      (WebCore::ScrollingCoordinator::isRubberBandInProgress):
      * page/scrolling/mac/ScrollingCoordinatorMac.h:
      (ScrollingCoordinatorMac):
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      (WebCore::ScrollingCoordinatorMac::isRubberBandInProgress):
      
      New variable m_mainFrameIsRubberBanding keeps track of whether there is currently 
      a rubber-band happening on the scrolling thread.
      * page/scrolling/ScrollingTree.cpp:
      (WebCore::ScrollingTree::ScrollingTree):
      (WebCore::ScrollingTree::isRubberBandInProgress):
      (WebCore::ScrollingTree::setMainFrameIsRubberBanding):
      * page/scrolling/ScrollingTree.h:
      (ScrollingTree):
      (WebCore::ScrollingTree::rootNode):
      
      Call setMainFrameIsRubberBanding() whenever the stretchAmount is calculated and 
      whenever we stop the rubber-band timer.
      * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
      (WebCore::ScrollingTreeScrollingNodeMac::stretchAmount):
      (WebCore::ScrollingTreeScrollingNodeMac::stopSnapRubberbandTimer):
      
      Consult FrameView for isRubberBandInProgress().
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c975f556
    • robert@webkit.org's avatar
      Abspos Inline block not positioned correctly in text-aligned container · 83f864f8
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105695
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Inline positioned elements should still obey the text-alignment of their container
      even when we don't do a line layout.
      
      Test: fast/text/container-align-with-inlines.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::adjustPositionedBlock):
      (WebCore::RenderBlock::updateStaticInlinePositionForChild):
      (WebCore):
      * rendering/RenderBlock.h:
      (RenderBlock):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::setStaticPositions):
      
      LayoutTests:
      
      * fast/text/container-align-with-inlines-expected.txt: Added.
      * fast/text/container-align-with-inlines.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83f864f8
    • eric@webkit.org's avatar
      Remove DocType support from MarkupTokenBase now that NEW_XML is gone · 3dba811f
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107709
      
      Reviewed by Adam Barth.
      
      Just moving code out of MarkupTokenBase and into HTMLToken.
      The test for this change is if it compiles. :)  Which it does.
      
      * html/parser/HTMLToken.h:
      (DoctypeData):
      (WebCore::DoctypeData::DoctypeData):
      (WebCore):
      (WebCore::HTMLToken::appendToName):
      (WebCore::HTMLToken::name):
      (HTMLToken):
      (WebCore::HTMLToken::beginDOCTYPE):
      (WebCore::HTMLToken::publicIdentifier):
      (WebCore::HTMLToken::systemIdentifier):
      (WebCore::HTMLToken::setPublicIdentifierToEmptyString):
      (WebCore::HTMLToken::setSystemIdentifierToEmptyString):
      (WebCore::HTMLToken::appendToPublicIdentifier):
      (WebCore::HTMLToken::appendToSystemIdentifier):
      (WebCore::HTMLToken::releaseDoctypeData):
      (WebCore::AtomicHTMLToken::AtomicHTMLToken):
      (AtomicHTMLToken):
      * html/parser/HTMLTokenTypes.h:
      * xml/parser/MarkupTokenBase.h:
      (WebCore):
      (MarkupTokenBase):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dba811f
    • roger_fong@apple.com's avatar
      Add the VS2010 WebKit solution folder and solution file. · b637c8b7
      roger_fong@apple.com authored
      The solution of course will not load until the dependent projects are all completed.
      https://bugs.webkit.org/show_bug.cgi?id=106949.
      
      Reviewed by Brent Fulgham.
      
      * WebKit.vcxproj: Added.
      * WebKit.vcxproj/WebKit.sln: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b637c8b7
    • roger_fong@apple.com's avatar
      Add WebKitLibraries property sheets for compiling WebKit in VS2010. · 5e0bbf62
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106949
      
      Reviewed by Brent Fulgham.
      
      * win/tools/vsprops/FeatureDefines.props: Added.
      * win/tools/vsprops/common.props: Added.
      * win/tools/vsprops/debug.props: Added.
      * win/tools/vsprops/release.props: Added.
      * win/tools/vsprops/releaseproduction.props: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e0bbf62
    • pilgrim@chromium.org's avatar
      [Chromium] Fix some #includes for WebSerializedScriptValue · 8072fb67
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107697
      
      Reviewed by Adam Barth.
      
      WebSerializedScriptValue has been moved to chromium/public/.
      
      * public/WebDOMCustomEvent.h:
      * public/WebDOMMessageEvent.h:
      * public/WebIDBCursor.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8072fb67
    • pilgrim@chromium.org's avatar
      [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory · 213c0a7d
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107145
      
      Reviewed by Adam Barth.
      
      Part of a larger refactoring series; see tracking bug 82948.
      
      * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
      * DumpRenderTree/chromium/DRTDevToolsAgent.h:
      * DumpRenderTree/chromium/DRTDevToolsClient.h:
      * DumpRenderTree/chromium/DRTTestRunner.cpp:
      * DumpRenderTree/chromium/DRTTestRunner.h:
      * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
      * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
      * DumpRenderTree/chromium/MockWebSpeechInputController.h:
      * DumpRenderTree/chromium/NotificationPresenter.cpp:
      * DumpRenderTree/chromium/TestNavigationController.h:
      * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
      * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
      * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
      * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
      (WebTestRunner):
      * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
      * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
      * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
      * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
      * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
      * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
      * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
      * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
      * DumpRenderTree/chromium/TestShell.cpp:
      * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
      * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
      * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
      * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
      * DumpRenderTree/chromium/WebViewHost.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      213c0a7d
    • nghanavatian@rim.com's avatar
      [BlackBerry] Take a better guess as to what text the user wants learned · 55af1a7c
      nghanavatian@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107706
      
      Reviewed by Rob Buis.
      
      If we still have a valid caret position, use it to give priority to a region
      of text.  We now take the text before the caret, instead of the text at the end
      of the field.  If the caret is not present, we start from the beginning of the field.
      This helps learning in email where the region of interest is generally at the start,
      not end of the field.
      
      Internally reviewed by Mike Fenton
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::learnText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55af1a7c
    • zandobersek@gmail.com's avatar
      Unreviewed. · 9dbe1cc8
      zandobersek@gmail.com authored
      Speculative build fix for the GTK port after 140539.
      
      * Source/autotools/symbols.filter:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9dbe1cc8
    • nghanavatian@rim.com's avatar
      [BlackBerry] Optimize spellchecking by coalescing messages · 31cc0900
      nghanavatian@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107707
      
      Reviewed by Rob Buis.
      
      PR233604
      Instead of taking chunks one line at a time, coalesce them together
      to fire off messages as close to our character limit as possible.
      This should dramatically reduce the total number of messages in email
      giving us a little performance bump.
      
      Internally reviewed by Mike Fenton and Gen Mak.
      
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
      (DOMSupport):
      * WebKitSupport/DOMSupport.h:
      * WebKitSupport/InputHandler.cpp:
      * WebKitSupport/InputHandler.h:
      (InputHandler):
      * WebKitSupport/SpellingHandler.cpp:
      (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
      (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
      (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
      (BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
      * WebKitSupport/SpellingHandler.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31cc0900
    • jochen@chromium.org's avatar
      [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html · 481a49d6
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107556
      
      Reviewed by Tony Chang.
      
      WebViewHost initiates a navigation to about:blank in its destructor.
      However, since WebTestProxy inherits from WebViewHost, at this point
      the WebViewClient and WebFrameClient interfaces are already partially
      destructed resulting in the use after free.
      
      This does not affect the chromium implementation since it doesn't
      invoke WebKit API methods in its destructor.
      
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::~TestShell):
      (TestShell::closeWindow):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::WebViewHost):
      (WebViewHost::~WebViewHost):
      (WebViewHost::shutdown):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      481a49d6
    • alexis@webkit.org's avatar
      transition-property accepts incorrect "all, none" as value · c2303abf
      alexis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105428
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      http://www.w3.org/TR/css3-transitions/#transition-property-property
      disallows any value like none, all or all, none as it doesn't make
      sense. This patch fixes the problem by rejecting the value if set by
      the user.
      
      Test: transitions/transitions-parsing.html
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseAnimationProperty):
      * css/CSSParser.h:
      
      LayoutTests:
      
      Extend the existing tests to cover the bug.
      
      * transitions/transitions-parsing-expected.txt:
      * transitions/transitions-parsing.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2303abf
    • eric@webkit.org's avatar
      Clarify some usage of shouldUseThreading vs m_haveBackgroundParser, fixing about:blank parsing · 209109c8
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107664
      
      Reviewed by Adam Barth.
      
      The HTMLDocumentParser can be "supposed" to use a background parser
      but not end up ever doing so for blank documents.  It's important
      that we spin the forground parser at least once, so we end up
      actually creating the about:blank document.
      
      shouldUseThreading() means that threading is enabled and we should use it if we can.
      m_haveBackgroundParser means that we actually are already using threading.
      When we add full document.write support this will get a bit trickier still as
      we'll need to be using both the foreground and background parsers.
      
      This fixes about 20 tests in fast/frames and many others outside of fast/frames. :)
      
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::prepareToStopParsing):
      (WebCore::HTMLDocumentParser::resumeParsingAfterYield):
      (WebCore::HTMLDocumentParser::finish):
      (WebCore::HTMLDocumentParser::lineNumber):
      (WebCore::HTMLDocumentParser::textPosition):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      209109c8
    • roger_fong@apple.com's avatar
      [Win] Remove dependence on Microsoft Embedded OpenType Font Engine... · 70f4208c
      roger_fong@apple.com authored
      [Win] Remove dependence on Microsoft Embedded OpenType Font Engine (T2EMBED.DLL)  from FontCustomPlatformData.cpp.
      https://bugs.webkit.org/show_bug.cgi?id=107153
      
      Reviewed by Dan Bernstein.
      
      * platform/graphics/win/FontCustomPlatformData.cpp:
      (WebCore):
      (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
      (WebCore::FontCustomPlatformData::fontPlatformData):
      (WebCore::createFontCustomPlatformData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70f4208c
    • commit-queue@webkit.org's avatar
      [GTK] Avoid reset title for navigation within the page · f54743a8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106908
      
      Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-01-23
      Reviewed by Martin Robinson.
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchDidNavigateWithinPage): Call
      dispatchDidCommitLoad with true as param.
      (WebKit::FrameLoaderClient::dispatchDidCommitLoad): The method has been
      overloaded. The default implementation (without params) simply calls
      dispatchDidCommitLoad with false. The new private method with
      isNavigatingWithinPage as param will avoid to reset the title for
      navigation within the page.
      * WebCoreSupport/FrameLoaderClientGtk.h:
      (FrameLoaderClient): Add new private method dispatchDidCommitLoad with a
      boolean parameter to know if it is navigating withing the same page or
      not.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f54743a8
    • commit-queue@webkit.org's avatar
      Web Inspector: speedup highlight regex API in DefaultTextEditor · 4320567c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107238
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-23
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Move overlay highlight measurement (highlight regex API) from DefaultTextEditor._paintLine
      method to the DefaultTextEditor._paintLines method which allows to relayout dom only
      once. This is a significant improvement to the current state of the
      art which does relayout on each regex occurence.
      In addition, use "left" css attribute instead of "margin-left": this
      way it will be possible to avoid an unnecessary relayouting during
      appending overlay highlight.
      
      No new tests: no change in behaviour.
      
      * inspector/front-end/DefaultTextEditor.js:
      (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
      (WebInspector.TextEditorMainPanel.prototype._paintLines):
      (WebInspector.TextEditorMainPanel.prototype._measureRegexHighlight):
      (WebInspector.TextEditorMainPanel.prototype._measureSpans):
      (WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
      (WebInspector.TextEditorMainPanel.prototype._paintLine):
      (WebInspector.TextEditorMainPanel.ElementMetrics):
      (WebInspector.TextEditorMainPanel.LineOverlayHighlight):
      (WebInspector.TextEditorMainChunk.prototype.expand):
      
      LayoutTests:
      
      Corrected layout test expectations to correspond to refactoring.
      
      * inspector/editor/text-editor-highlight-regexp-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4320567c
    • ojan@chromium.org's avatar
      Assert that computePreferredLogicalWidths never calls setNeedsLayout · 29795f57
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107613
      
      Reviewed by Eric Seidel.
      
      computePreferredLogicalWidths should only set m_minPreferredLogicalWidth
      and m_maxPreferredLogicalWidth. It shouldn't have other side-effects.
      The mathml bits can be removed once https://bugs.webkit.org/show_bug.cgi?id=107353
      is resolved.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::minPreferredLogicalWidth):
      * rendering/mathml/RenderMathMLOperator.cpp:
      (WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
      * rendering/mathml/RenderMathMLRoot.cpp:
      (WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
      * rendering/mathml/RenderMathMLRow.cpp:
      (WebCore::RenderMathMLRow::computePreferredLogicalWidths):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29795f57
    • pfeldman@chromium.org's avatar
      Follow up to 140539, adding exports for Win build. · 7b8ba498
      pfeldman@chromium.org authored
      Not reviewed.
      
      * WebKit.vcproj/WebKitExports.def.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b8ba498
    • commit-queue@webkit.org's avatar
      [GTK][WK2] Unflag tests related to layoutTestController.setViewModeMediaFeature · a6aa7bb4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107660
      
      Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-01-23
      Reviewed by Philippe Normand.
      
      * platform/gtk-wk2/TestExpectations: Remove tests related to
      layoutTestController.setViewModeMediaFeature as they are passing now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6aa7bb4
    • commit-queue@webkit.org's avatar
      REGRESSION(r140518): Broke Chromium Win build (gyp file not updated) (Requested by arv on #webkit). · 9a73d970
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107691
      
      Unreviewed build fix. Removed TextureMapperShaderManager.* from WebCore.gypi.
      
      Patch by Noam Rosenthal <noam@webkit.org> on 2013-01-23
      
      * WebCore.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a73d970
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r140307, r140411, and r140512. · 80403143
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/140307
      http://trac.webkit.org/changeset/140411
      http://trac.webkit.org/changeset/140512
      https://bugs.webkit.org/show_bug.cgi?id=107689
      
      Perf regression on DOMDivWalk (bug 106726) (Requested by
      falken on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-23
      
      Source/WebCore:
      
      * dom/Element.cpp:
      (WebCore::Element::removedFrom):
      (WebCore):
      (WebCore::Element::isInTopLayer):
      (WebCore::Element::setIsInTopLayer):
      * dom/Element.h:
      * dom/ElementRareData.h:
      (ElementRareData):
      (WebCore::ElementRareData::isInTopLayer):
      (WebCore::ElementRareData::setIsInTopLayer):
      (WebCore::ElementRareData::ElementRareData):
      * dom/Node.cpp:
      * dom/Node.h:
      (Node):
      * dom/NodeRenderingContext.cpp:
      (WebCore::isRendererReparented):
      (WebCore::NodeRenderingContext::previousRenderer):
      (WebCore::NodeRenderingContext::parentRenderer):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::isInTopLayer):
      (WebCore::RenderLayer::rebuildZOrderLists):
      
      LayoutTests:
      
      * fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Removed.
      * fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Removed.
      * fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Removed.
      * fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80403143
    • commit-queue@webkit.org's avatar
      Source/WebCore: Web Inspector: allow user to resize inspector window by dragging the toolbar · 39863838
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107648
      
      Patch by Dmitry Gozman <dgozman@chromium.org> on 2013-01-23
      Reviewed by Pavel Feldman.
      
      This did not work before you click dock button once.
      Also, last drag position was not respected.
      
      No new tests, because of pure inspector UI change.
      
      * inspector/front-end/DockController.js:
      (WebInspector.DockController.prototype.isDockedToBottom):
      * inspector/front-end/Toolbar.js:
      (WebInspector.Toolbar.prototype._isDockedToBottom):
      (WebInspector.Toolbar.prototype._toolbarDragStart):
      (WebInspector.Toolbar.prototype._toolbarDragEnd):
      (WebInspector.Toolbar.prototype._toolbarDrag):
      
      Source/WebKit/chromium: Added changeAttachedWindowHeight method to inspector frontend API, which
      allows to change inspector window height from inside.
      https://bugs.webkit.org/show_bug.cgi?id=107648
      
      Patch by Dmitry Gozman <dgozman@chromium.org> on 2013-01-23
      Reviewed by Pavel Feldman.
      
      * public/WebDevToolsFrontendClient.h:
      (WebKit::WebDevToolsFrontendClient::changeAttachedWindowHeight):
      * src/InspectorFrontendClientImpl.cpp:
      (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39863838
    • christophe.dumez@intel.com's avatar
      [EFL][WK2] Use C API inside ewk_cookie_manager · f7343e00
      christophe.dumez@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107661
      
      Reviewed by Alexey Proskuryakov.
      
      Use C API inside ewk_cookie_manager instead of
      accessing C++ classes directly and violating
      layering.
      
      * PlatformEfl.cmake:
      * UIProcess/API/C/soup/WKCookieManagerSoup.cpp: Added.
      (toSoupCookiePersistentStorageType):
      (WKCookieManagerSetCookiePersistentStorage): Add C API for setting
      the persistent storage path and type when using libsoup.
      * UIProcess/API/C/soup/WKCookieManagerSoup.h: Added.
      * UIProcess/API/efl/ewk_context.cpp:
      (EwkContext::cookieManager):
      * UIProcess/API/efl/ewk_cookie_manager.cpp:
      (EwkCookieManager::EwkCookieManager):
      (EwkCookieManager::~EwkCookieManager):
      (EwkCookieManager::setPersistentStorage):
      (EwkCookieManager::setHTTPAcceptPolicy):
      (EwkCookieManager::clearHostnameCookies):
      (EwkCookieManager::clearAllCookies):
      (EwkCookieManager::watchChanges):
      (EwkCookieManager::getHostNamesWithCookies):
      (EwkCookieManager::getHTTPAcceptPolicy):
      (ewk_cookie_manager_persistent_storage_set):
      (ewk_cookie_manager_hostname_cookies_clear):
      * UIProcess/API/efl/ewk_cookie_manager_private.h:
      (EwkCookieManager::create):
      (EwkCookieManager):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7343e00
    • shinyak@chromium.org's avatar
      shadowAncestorNode() should be renamed to deprecatedShadowAncestorNode() · 659784bf
      shinyak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107624
      
      Reviewed by Dimitri Glazkov.
      
      Since Node::shadowAncestorNode() is deprecated, we would like to rename it to prevent from further use.
      
      Source/WebCore:
      
      No new tests, simple refactoring.
      
      * WebCore.order:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      * dom/Document.cpp:
      (WebCore::Document::handleZeroPadding):
      * dom/Node.cpp:
      (WebCore::Node::deprecatedShadowAncestorNode):
      * dom/Node.h:
      (Node):
      * editing/Editor.cpp:
      (WebCore::Editor::rangeOfString):
      (WebCore::Editor::countMatchesForText):
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplacementFragment::ReplacementFragment):
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMouseReleaseEvent):
      (WebCore::EventHandler::bestClickableNodeForTouchPoint):
      * page/FocusController.cpp:
      (WebCore::clearSelectionIfNeeded):
      * platform/blackberry/RenderThemeBlackBerry.cpp:
      (WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::setToNonShadowAncestor):
      (WebCore::HitTestResult::addNodeToRectBasedTestResult):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      * WebKitSupport/FatFingers.h:
      (BlackBerry::WebKit::FatFingersResult::node):
      * WebKitSupport/InPageSearchManager.cpp:
      (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::scopeStringMatches):
      (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::inputMethodEvent):
      (QWebPageAdapter::inputMethodQuery):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      659784bf
    • commit-queue@webkit.org's avatar
      [CSS Regions] Create Regions watchlist · 6b5762c4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107281
      
      Patch by Andrei Bucur <abucur@adobe.com> on 2013-01-23
      Reviewed by Adam Barth.
      
      This patch adds 4 new definitions:
      - RegionsDevelopment - used to track the development progress for regions
      - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
      - RegionsUsage - used to track changes that make use of regions in all the code base
      
      For now, the Adobe internal tracker is the only email address listening for these patterns.
      
      * Scripts/webkitpy/common/config/watchlist:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b5762c4
    • pfeldman@chromium.org's avatar
      Web Inspector: only allow evaluateForTestInFrontend for front-ends under test. · 71544975
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107523
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::isUnderTest):
      (WebCore):
      (WebCore::InspectorController::evaluateForTestInFrontend):
      * inspector/InspectorController.h:
      (InspectorController):
      * inspector/InspectorFrontendClient.h:
      (InspectorFrontendClient):
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::canAttachWindow):
      (WebCore::InspectorFrontendClientLocal::isUnderTest):
      (WebCore):
      * inspector/InspectorFrontendClientLocal.h:
      (InspectorFrontendClientLocal):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::InspectorFrontendHost::isUnderTest):
      (WebCore):
      * inspector/InspectorFrontendHost.h:
      (InspectorFrontendHost):
      * inspector/InspectorFrontendHost.idl:
      * inspector/front-end/DOMExtension.js:
      * inspector/front-end/InspectorFrontendHostStub.js:
      (.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers):
      (.WebInspector.InspectorFrontendHostStub.prototype.isUnderTest):
      * inspector/front-end/TestController.js:
      (.invokeMethod):
      (WebInspector.evaluateForTestInFrontend):
      * inspector/front-end/externs.js:
      
      Source/WebKit/chromium:
      
      * public/WebDevToolsFrontendClient.h:
      (WebKit::WebDevToolsFrontendClient::isUnderTest):
      (WebDevToolsFrontendClient):
      * src/InspectorFrontendClientImpl.cpp:
      (WebKit::InspectorFrontendClientImpl::isUnderTest):
      * src/InspectorFrontendClientImpl.h:
      (InspectorFrontendClientImpl):
      
      Tools:
      
      * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
      (DRTDevToolsClient::isUnderTest):
      (DRTDevToolsClient::call):
      * DumpRenderTree/chromium/DRTDevToolsClient.h:
      (DRTDevToolsClient):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71544975
    • commit-queue@webkit.org's avatar
      Web Inspector: remove invisibleLineRow code from paintLines DTE method · 171767c3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107649
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-23
      Reviewed by Pavel Feldman.
      
      Remove invisibleLineRow logic from TextEditorMainPanel._paintLines method.
      
      No new tests: no change in behaviour.
      
      * inspector/front-end/DefaultTextEditor.js:
      (WebInspector.TextEditorMainPanel.prototype._paintLines):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      171767c3
    • dominicc@chromium.org's avatar
      REGRESSION(r140101): caused debug asserts in... · 568f5931
      dominicc@chromium.org authored
      REGRESSION(r140101): caused debug asserts in fast/forms/associated-element-crash.html and html5lib/run-template.html
      https://bugs.webkit.org/show_bug.cgi?id=107237
      
      Patch by Rafael Weinstein <rafaelw@chromium.org> on 2013-01-23
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      No new tests needed.
      
      When the parser foster-parent's a node out of a table context and the foster parent is a template element, set the Task.parent
      to be the template element's content, rather than the element itself. This ensures the foster-parented node isn't errorenously
      reparented.
      
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::findFosterSite):
      
      LayoutTests:
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      568f5931
    • arv@chromium.org's avatar
      [chromium] Layout test rebaselines · 1a64ce44
      arv@chromium.org authored
      Unreviewed rebaseline
      
      * platform/chromium-linux-x86/media/media-can-play-ogg-expected.txt: Added.
      * platform/chromium-linux/media/media-can-play-ogg-expected.txt: Added.
      * platform/chromium-mac-lion/media/media-can-play-ogg-expected.txt: Added.
      * platform/chromium-mac-snowleopard/media/media-can-play-ogg-expected.txt: Added.
      * platform/chromium-mac/media/media-can-play-ogg-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a64ce44
    • yurys@chromium.org's avatar
      Web Inspector: heap profiler shows nodes with distance 0 · 725acc45
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107425
      
      Reviewed by Pavel Feldman.
      
      "Document DOM tree" entities now have distance 1. So if there is a DOM
      wrapper that is not referenced from javascript it will anyways be shown
      in the heap snapshot and will have distance 2. Also such DOM wrappers
      are considered to be reachable from user roots (e.g. global Window objects)
      otherwice they are not event shown in the heap snapshots.
      
      * inspector/front-end/HeapSnapshot.js:
      (WebInspector.HeapSnapshot.prototype.distanceForUserRoot):
      (WebInspector.HeapSnapshot.prototype._calculateDistances):
      * inspector/front-end/JSHeapSnapshot.js:
      (WebInspector.JSHeapSnapshot.prototype.distanceForUserRoot): distance for
      "(Document DOM trees)" is set to 0 to make sure distance of "Ddocument DOM tree" is 1.
      (WebInspector.JSHeapSnapshot.prototype._markPageOwnedNodes):
      (WebInspector.JSHeapSnapshotNode.prototype.isDocumentDOMTreesRoot):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      725acc45
    • yurys@chromium.org's avatar
      Web Inspector: some measurements are missing in PerformanceTests/inspector/heap-*.html · 0d1a084d
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107687
      
      Reviewed by Pavel Feldman.
      
      * inspector/heap-snapshot-performance-test.js: override methods on JSHeapSnapshot instead
      of HeapSnapshot, otherwise overrides from JSHeapSnapshot will rule.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d1a084d
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · df6b865a
      kadam@inf.u-szeged.hu authored
      Rebaselining after r140448, r140459 and r140493.
      
      Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-23
      
      * platform/qt-5.0/fast/js/global-constructors-expected.txt:
      * platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df6b865a
    • philn@webkit.org's avatar
      [GStreamer] Add Opus MIME type to the list of supported ones · 84f6e716
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98759
      
      Patch by Adrian Perez de Castro <aperez@igalia.com> on 2013-01-23
      Reviewed by Philippe Normand.
      
      Source/WebCore:
      
      GStreamer has support for the Opus codec (http://opus-codec.org) by
      using a plugin present in the "gst-plugins-bad" repository. Opus
      streams may be embedded in a Ogg container, or standalone. The case
      of the Ogg container is already covered by the "*/ogg" MIME types
      declared as supported by the GStreamer media playing code, but for
      standalone streams to work, "audio/opus" has to be added.
      
      With this, and the needed GStreamer plugin installed, the GTK+
      launcher is able to correctly play the example streams from
      http://opus-codec.org/examples
      
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      
      LayoutTests:
      
      Opus (http://opus-codec.org) streams are typically embedded into
      Ogg containers, so add a check for it in the test case.
      
      * media/media-can-play-ogg-expected.txt:
      * media/media-can-play-ogg.html:
      * platform/chromium-android/media/media-can-play-ogg-expected.txt:
      * platform/chromium/media/media-can-play-ogg-expected.txt: Copied from LayoutTests/media/media-can-play-ogg-expected.txt.
      * platform/efl/media/media-can-play-ogg-expected.txt: Copied from LayoutTests/media/media-can-play-ogg-expected.txt.
      * platform/gtk/media/media-can-play-ogg-expected.txt: Copied from LayoutTests/media/media-can-play-ogg-expected.txt.
      * platform/qt-linux/media/media-can-play-ogg-expected.txt: Copied from LayoutTests/media/media-can-play-ogg-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84f6e716
    • tasak@google.com's avatar
      [Refactoring] Remove elementParentStyle from SelectorCheckerContext · df1a47d0
      tasak@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107496
      
      Reviewed by Darin Adler.
      
      Since childrenAffectedBy bits were moved from RenderStyle to element,
      now elementParentStyle is not used in SelectorChecker and
      StyleResolver. We should remove the member varaiable from
      SelectorCheckerContext.
      
      No new tests, because just refactoring.
      
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::match):
      * css/SelectorChecker.h:
      (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
      (SelectorCheckingContext):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::ruleMatches):
      Removed elementParentStyle.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df1a47d0