1. 05 Sep, 2013 22 commits
    • commit-queue@webkit.org's avatar
      [CSS Regions] Convert existing pixel tests in ref tests · 14f46fda
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120760
      
      Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-09-05
      Reviewed by Antti Koivisto.
      
      I have also removed text-align:justify from the tests because its not relevant to the tested functionality and
      it makes creating the expected results very difficult because of the way fragmented text is rendered when
      it's aligned justified.
      
      * fast/regions/overflow-in-uniform-regions-dynamic-expected.html: Added.
      * fast/regions/overflow-in-uniform-regions-dynamic.html:
      * fast/regions/overflow-in-variable-width-regions-expected.html: Added.
      * fast/regions/overflow-in-variable-width-regions.html:
      * fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.html: Added.
      * fast/regions/overflow-moving-below-floats-in-variable-width-regions.html:
      * fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.html: Added.
      * fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html:
      * fast/regions/overflow-rtl-in-variable-width-regions-expected.html: Added.
      * fast/regions/overflow-rtl-in-variable-width-regions.html:
      * fast/regions/overflow-size-change-in-variable-width-regions-expected.html: Added.
      * fast/regions/overflow-size-change-in-variable-width-regions.html:
      * platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
      * platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed.
      * platform/efl/fast/regions/overflow-in-variable-width-regions-expected.png: Removed.
      * platform/efl/fast/regions/overflow-in-variable-width-regions-expected.txt: Removed.
      * platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
      * platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
      * platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed.
      * platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Removed.
      * platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed.
      * platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed.
      * platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
      * platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed.
      * platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.png: Removed.
      * platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt: Removed.
      * platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
      * platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
      * platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed.
      * platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Removed.
      * platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed.
      * platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed.
      * platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
      * platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed.
      * platform/mac/fast/regions/overflow-in-variable-width-regions-expected.png: Removed.
      * platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt: Removed.
      * platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
      * platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
      * platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed.
      * platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Removed.
      * platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed.
      * platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed.
      * platform/qt-wk2/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
      * platform/qt-wk2/fast/regions/overflow-in-variable-width-regions-expected.png: Removed.
      * platform/qt-wk2/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
      * platform/qt-wk2/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed.
      * platform/qt-wk2/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed.
      * platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
      * platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed.
      * platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png: Removed.
      * platform/qt/fast/regions/overflow-in-variable-width-regions-expected.txt: Removed.
      * platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
      * platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
      * platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed.
      * platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Removed.
      * platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed.
      * platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14f46fda
    • commit-queue@webkit.org's avatar
      [GTK] Assertion fails when the mouse pointer is styled with a custom cursor · d971d446
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118905
      
      Patch by Enrique Ocaña González <eocanha@igalia.com> on 2013-09-05
      Reviewed by Philippe Normand.
      
      Checked that the custom cursor image and its pixbuf is valid and create a null
      cursor otherwise.
      
      * platform/gtk/CursorGtk.cpp:
      (WebCore::createCustomCursor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d971d446
    • commit-queue@webkit.org's avatar
      Precision updates in WebAudio. · b09f27ad
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119739
      
      Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-09-05
      Reviewed by Philippe Normand.
      
      WebAudio Specification suggests to use 'double' datatypes
      for minDecibels, maxDecibels and smoothingTimeConstant in
      AnalyserNode.idl and currentTime in AudioContext.idl.
      Current WebKit implementation has declared these attributes
      as 'float' type.
      
      Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioContext-section
            https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AnalyserNode
      
      No new tests, covered by existing tests.
      
      * Modules/webaudio/AnalyserNode.cpp:
      (WebCore::AnalyserNode::setMinDecibels):
      (WebCore::AnalyserNode::setMaxDecibels):
      (WebCore::AnalyserNode::setSmoothingTimeConstant):
      * Modules/webaudio/AnalyserNode.h:
      (WebCore::AnalyserNode::minDecibels):
      (WebCore::AnalyserNode::maxDecibels):
      (WebCore::AnalyserNode::smoothingTimeConstant):
      * Modules/webaudio/AnalyserNode.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/webaudio/RealtimeAnalyser.h:
      (WebCore::RealtimeAnalyser::setMinDecibels):
      (WebCore::RealtimeAnalyser::minDecibels):
      (WebCore::RealtimeAnalyser::setMaxDecibels):
      (WebCore::RealtimeAnalyser::maxDecibels):
      (WebCore::RealtimeAnalyser::setSmoothingTimeConstant):
      (WebCore::RealtimeAnalyser::smoothingTimeConstant):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b09f27ad
    • commit-queue@webkit.org's avatar
      [GTK] media/track/in-band/ layout tests introduced in r154908 are failing · 896ad3b6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120665
      
      Patch by Brendan Long <b.long@cablelabs.com> on 2013-09-05
      Reviewed by Philippe Normand.
      
      * platform/efl/TestExpectations: Skip new media/track/in-band tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      896ad3b6
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · 02297189
      zarvai@inf.u-szeged.hu authored
      * platform/qt-wk1/TestExpectations: Unskipping after 155104.
      * platform/qt/TestExpectations: Unskipping after r155061.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02297189
    • mihnea@adobe.com's avatar
      Replace node() calls with generatingNode() for RenderRegion code · 754ee5c8
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120397
      
      Reviewed by Darin Adler.
      
      As regions will become anonymous blocks nested inside elements with the flow-from property, a first step
      would be to change the calls to node() with calls to generatingNode(). In the case of regions, generatingNode()
      will always return an Element* and not a Node*. Therefore, to get rid of toElement() casts, i created
      a specific method RenderRegion::generatingElement that will return the generating node as Element.
      No new tests as no functional change was introduced.
      
      Original patch by Catalin Badea.
      
      * css/ElementRuleCollector.cpp:
      (WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
      * dom/WebKitNamedFlow.cpp:
      (WebCore::WebKitNamedFlow::getRegionsByContent):
      (WebCore::WebKitNamedFlow::getRegions):
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::regionOversetState):
      (WebCore::RenderRegion::setRegionOversetState):
      (WebCore::RenderRegion::checkRegionStyle):
      * rendering/RenderRegion.h:
      (WebCore::RenderRegion::generatingElement):
      * rendering/RenderTreeAsText.cpp:
      (WebCore::writeRenderRegionList): For pseudo-elements as regions, i want to print
      {pseudo} instead of {div} marker for the parent.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      754ee5c8
    • ossy@webkit.org's avatar
      Fix SynchronousLoaderClient class for !USE(CFNETWORK) platforms · 202ca8e7
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120532
      
      Reviewed by Darin Adler.
      
      * CMakeLists.txt:
      * PlatformEfl.cmake:
      * PlatformGTK.cmake:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * platform/network/SynchronousLoaderClient.cpp:
      * platform/network/cf/SynchronousLoaderClientCFNet.cpp: Added.
      (WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge):
      (WebCore::SynchronousLoaderClient::platformBadResponseError):
      * platform/network/soup/SynchronousLoaderClientSoup.cpp: Added.
      (WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge):
      (WebCore::SynchronousLoaderClient::platformBadResponseError):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      202ca8e7
    • jinwoo7.song@samsung.com's avatar
      Fix unused parameter warning in WebKitAccessibleInterfaceText.cpp · 0305f656
      jinwoo7.song@samsung.com authored
      <https://webkit.org/b/120761>
      
      Reviewed by Gyuyoung Kim.
      
      Fix warning by removing unused parameter.
      
      * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
      (sentenceAtPositionForAtkBoundary):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0305f656
    • ljaehun.lim@samsung.com's avatar
      Unreviewed. Fix build after r155083 · 42e8095a
      ljaehun.lim@samsung.com authored
      Source/WTF/wtf/Vector.h:1210:48: error: ‘>>’ should be ‘> >’ within a nested template argument list
      
      * wtf/Vector.h: Add missing space.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42e8095a
    • krit@webkit.org's avatar
      NULL ptr in WebCore::RefCountedPropertyWrapper<WebCore::ClipPathOperation>::blend · 73f41409
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105408
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Adding an early return if from or to clip-path values are 'none'. According to the
      specification we shall just interpolate between two basic shapes.
      
      http://dev.w3.org/csswg/css-shapes/#basic-shape-interpolation
      
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::blendFunc):
      
      LayoutTests:
      
      Test that animation from none to a basic shape on -webkit-clip-path doesn't crash.
      
      * css3/masking/clip-path-animation-expected.txt:
      * css3/masking/clip-path-animation.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73f41409
    • commit-queue@webkit.org's avatar
      [Qt][WK1] REGRESSION(r154988): compositing/video/video-with-invalid-source.html · e547636f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120683
      
      Patch by Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk> on 2013-09-05
      Reviewed by Philippe Normand.
      
      Do not set pipeline state to NULL on MediaPlayerPrivateGStreamer::loadingFailed()
      otherwise the bus is flushed and we never get a GST_MESSAGE_ERROR when failing to
      load uris.
      Also restore previous behaviour (before r154988) of not invoking loadingFailed() for
      all failed manual state change attempts.
      
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
      Do not call loadingFailed() if state change fails as all manual state changes are
      now done with changePipelineState().
      (WebCore::MediaPlayerPrivateGStreamer::play):
      (WebCore::MediaPlayerPrivateGStreamer::pause):
      (WebCore::MediaPlayerPrivateGStreamer::seek):
      (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
      Restore previous behaviour (before changeset r154988) when calling changePipelineState().
      (WebCore::MediaPlayerPrivateGStreamer::updateStates):
      Do nothing if changing to READY on EOS (same behaviour as setting to NULL as it was before
      changeset r154988).
      (WebCore::MediaPlayerPrivateGStreamer::loadingFailed):
      Do not set pipeline state to NULL so we properly get GST_MESSAGE_ERROR on loading failures.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e547636f
    • fpizlo@apple.com's avatar
      Unreviewed, don't run fast/js tests in run-javascriptcore-tests on platforms that · 96a266c6
      fpizlo@apple.com authored
      can't support it because if non-bourne shells. This fixes part #2 of the Linux
      bot breakage.
      
      * Scripts/run-javascriptcore-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96a266c6
    • berto@igalia.com's avatar
      [GTK] MediaControlsGtk: fix warning in constructor due to incorrect order of attributes · 78105644
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120703
      
      Reviewed by Carlos Garcia Campos.
      
      Fix member initialization so it matches their declaration [-Wreorder].
      
      * html/shadow/MediaControlsGtk.cpp:
      (WebCore::MediaControlsGtk::MediaControlsGtk):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78105644
    • fpizlo@apple.com's avatar
      Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage. · 01c87550
      fpizlo@apple.com authored
      * Scripts/run-javascriptcore-tests:
      (readAllLines):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01c87550
    • krit@webkit.org's avatar
      Support interpolation between cross-fade() images · 50fa7026
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119955
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      With this patch, CSS can animate from one -webkit-cross-fade
      function to another, when the input images are the same in the
      same order.
      
      * css/CSSCrossfadeValue.cpp: Added blend function.
      (WebCore::blendFunc):
      (WebCore::CSSCrossfadeValue::blend):
      (WebCore::CSSCrossfadeValue::equals):
      (WebCore::CSSCrossfadeValue::equalInputImages):
      * css/CSSCrossfadeValue.h: Added save casting functions.
      (WebCore::toCSSCrossfadeValue):
      * css/CSSValue.h:
      (WebCore::CSSValue::isCrossfadeValue):
      * page/animation/CSSPropertyAnimation.cpp: Add another condition to
          interpolate between two -webkit-cross-fade functions.
      (WebCore::blendFunc):
      
      LayoutTests:
      
      Test interpolation from one cross-fade function to another. Changed pixel test
      to a ref test.
      
      * animations/cross-fade-background-image.html:
      * animations/cross-fade-background-image-expected.html: Added.
      * platform/mac/animations/cross-fade-background-image-expected.png: Removed.
      * platform/mac/animations/cross-fade-background-image-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50fa7026
    • zherczeg@webkit.org's avatar
      <https://webkit.org/b/118553> Hash navigation doesn't affect history when the... · 8398cfb2
      zherczeg@webkit.org authored
      <https://webkit.org/b/118553> Hash navigation doesn't affect history when the page is retrieved from appcache
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      A new flag called keepInHistory is added to allow keeping
      certain pages in the history even if they have substitute data.
      
      Test: http/tests/appcache/history-test.html
      
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::urlForHistory):
      * loader/SubstituteData.h:
      (WebCore::SubstituteData::SubstituteData):
      (WebCore::SubstituteData::shouldRevealToSessionHistory):
      (WebCore::SubstituteData::setShouldRevealToSessionHistory):
      * loader/appcache/ApplicationCacheHost.cpp:
      (WebCore::ApplicationCacheHost::maybeLoadMainResource):
      
      LayoutTests: 
      
      * http/tests/appcache/history-test-expected.txt: Added.
      * http/tests/appcache/history-test.html: Added.
      * http/tests/appcache/resources/history-test.html: Added.
      * http/tests/appcache/resources/history-test.manifest: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8398cfb2
    • fpizlo@apple.com's avatar
      jsc tests should have timeouts · c88e14c6
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120725
      
      Source/JavaScriptCore: 
      
      Reviewed by Geoffrey Garen.
              
      Add the timeout logic directly to 'jsc' because that's easier to do than
      writing shell/perl code for it.
      
      * jsc.cpp:
      (timeoutThreadMain):
      (main):
      
      Tools: 
      
      Reviewed by Geoffrey Garen.
              
      Set the timeout to 20 seconds per test for now.
      
      * Scripts/run-javascriptcore-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c88e14c6
    • commit-queue@webkit.org's avatar
      Test background blend modes with animated gif background layers. · 9565c1f8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120057
      
      Patch by Mihai Tica <mitica@adobe.com> on 2013-09-04
      Reviewed by Darin Adler.
      
      * css3/compositing/background-blend-mode-gif-color-2.html: Added.
      * css3/compositing/background-blend-mode-gif-color.html: Added.
      * css3/compositing/resources/squares.gif: Added.
      * platform/mac/css3/compositing/background-blend-mode-gif-color-2-expected.png: Added.
      * platform/mac/css3/compositing/background-blend-mode-gif-color-2-expected.txt: Added.
      * platform/mac/css3/compositing/background-blend-mode-gif-color-expected.png: Added.
      * platform/mac/css3/compositing/background-blend-mode-gif-color-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9565c1f8
    • fpizlo@apple.com's avatar
      fast/js/dfg-* tests should wait for the concurrent JIT · 4bc850b4
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120723
      
      Source/JavaScriptCore: 
      
      Reviewed by Geoffrey Garen.
              
      * runtime/TestRunnerUtils.cpp:
      (JSC::numberOfDFGCompiles): This should also handle constructors.
      
      LayoutTests: 
      
      Reviewed by Geoffrey Garen.
              
      Add dfgShouldBe(), a handy function that covers a lot of common cases.
      Also convert a bunch of tests.
      
      * fast/js/dfg-activation-register-overwritten-in-throw-expected.txt:
      * fast/js/dfg-add-not-number-expected.txt:
      * fast/js/dfg-allocation-profile-watch-point-exit-expected.txt:
      * fast/js/dfg-arguments-alias-escape-expected.txt:
      * fast/js/dfg-arguments-cross-code-origin-expected.txt:
      * fast/js/dfg-arguments-mixed-alias-expected.txt:
      * fast/js/dfg-arguments-strict-mode-expected.txt:
      * fast/js/dfg-arguments-unexpected-escape-expected.txt:
      * fast/js/dfg-array-dead-expected.txt:
      * fast/js/dfg-array-length-dead-expected.txt:
      * fast/js/dfg-array-pop-value-clearing-expected.txt:
      * fast/js/dfg-array-push-bad-time-expected.txt:
      * fast/js/dfg-array-push-slow-put-expected.txt:
      * fast/js/dfg-arrayify-when-late-prevent-extensions-expected.txt:
      * fast/js/dfg-arrayify-when-prevent-extensions-expected.txt:
      * fast/js/dfg-bool-to-int32-reuse-expected.txt:
      * fast/js/jsc-test-list:
      * fast/js/resources/js-test-pre.js:
      (dfgShouldBe):
      * fast/js/resources/standalone-pre.js:
      (dfgShouldBe):
      * fast/js/script-tests/dfg-activation-register-overwritten-in-throw.js:
      (g):
      * fast/js/script-tests/dfg-add-not-number.js:
      * fast/js/script-tests/dfg-allocation-profile-watch-point-exit.js:
      (foo):
      * fast/js/script-tests/dfg-arguments-alias-escape.js:
      * fast/js/script-tests/dfg-arguments-cross-code-origin.js:
      * fast/js/script-tests/dfg-arguments-mixed-alias.js:
      * fast/js/script-tests/dfg-arguments-strict-mode.js:
      * fast/js/script-tests/dfg-arguments-unexpected-escape.js:
      * fast/js/script-tests/dfg-array-dead.js:
      * fast/js/script-tests/dfg-array-length-dead.js:
      * fast/js/script-tests/dfg-array-pop-value-clearing.js:
      * fast/js/script-tests/dfg-array-push-bad-time.js:
      * fast/js/script-tests/dfg-array-push-slow-put.js:
      * fast/js/script-tests/dfg-arrayify-when-late-prevent-extensions.js:
      * fast/js/script-tests/dfg-arrayify-when-prevent-extensions.js:
      * fast/js/script-tests/dfg-bool-to-int32-reuse.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bc850b4
    • g.czajkowski@samsung.com's avatar
      Remove deprecated markersForNode(Node* node). · 10624356
      g.czajkowski@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120679
      
      Reviewed by Ryosuke Niwa.
      
      DocumentMarkerController::markersForNode(Node* node) has been marked as
      deprecated in favor of markersFor(Node*, MarkerTypes = AllMarkers()).
      
      No new tests, no behavior change.
      
      * dom/DocumentMarkerController.cpp:
      * dom/DocumentMarkerController.h:
      Remove never used markersForNode(Node*).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10624356
    • akling@apple.com's avatar
      CachedPage construction should begin with a Page&. · 50b1d4d7
      akling@apple.com authored
      <https://webkit.org/b/120721>
      
      Reviewed by Anders Carlsson.
      
      We can't create a CachedPage from a null Page anyway.
      
      * history/CachedPage.cpp:
      (WebCore::CachedPage::create):
      (WebCore::CachedPage::CachedPage):
      (WebCore::CachedPage::restore):
      * history/CachedPage.h:
      * history/PageCache.cpp:
      (WebCore::PageCache::add):
      * history/PageCache.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::commitProvisionalLoad):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50b1d4d7
    • a.bah@samsung.com's avatar
      setAttributeNode() does not set the new value to an existing attribute if... · 03dcfec5
      a.bah@samsung.com authored
      setAttributeNode() does not set the new value to an existing attribute if specified attribute is in a different case.
      https://bugs.webkit.org/show_bug.cgi?id=120293
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      setAttributeNode() performs a case-insensitive search for an existing
      attribute. If an existing attribute is found, it retrieves the index of
      such an attribute. For setting the attribute's new value, we call upon
      setAttributeInternal() to which both the index as well as the name of
      the attribute is passed.
      The name passed to this method is the same as the one passed to the
      setAttributeNode() API from the webpage and thus can be in any case.
      
      However, setAttributeInternal() uses this name to get the corresponding
      existing attribute node. Since this retrieval is not case-insensitive,
      the existing node is not returned and thus the new value is not set on
      the existing node.
      We should instead use the passed index and use that to retrieve the
      existing node.
      
      Note that obtaining the attribute's value using getAttributeNode() would
      still return the correct value, i.e. the new one.
      
      Also, this change shall make our behavior similar to that of FF and IE.
      
      Test: fast/dom/Element/setAttributeNode-for-existing-attribute.html
      
      * dom/Element.cpp:
      (WebCore::Element::setAttributeInternal):
      If the passed index is not equal to attributeNotFound, we use that index
      to retrieve the existing attribute.
      
      LayoutTests:
      
      * fast/dom/Element/setAttributeNode-for-existing-attribute-expected.txt: Added.
      * fast/dom/Element/setAttributeNode-for-existing-attribute.html: Added.
      Layout testcase for verifying that the new attribute value is set properly
      if an existing attribute with the same name exists.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03dcfec5
  2. 04 Sep, 2013 18 commits
    • fpizlo@apple.com's avatar
      run-javascriptcore-tests should run-fast-jsc as well · 8f0cca86
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120722
      
      Tools: 
      
      Reviewed by Geoffrey Garen.
              
      Makes run-javascriptcore-tests run the fast/js tests via run-fast-jsc tool.
      Integrates run-fast-jsc's error reporting into run-javascriptcore-tests.
      
      * Scripts/run-javascriptcore-tests:
      (printThingsFound):
      
      LayoutTests: 
      
      Reviewed by Geoffrey Garen.
              
      Make all run-fast-jsc tests pass:
              
      - We should always define successfullyParsed and we shouldn't falsify it
        when a test fails. This was already true in js-test-pre.
              
      - Object-defineProperty() depends on DOM-like global object behavior.
        Remove the test from the run-fast-jsc list.
      
      * fast/js/jsc-test-list:
      * fast/js/resources/standalone-pre.js:
      (testFailed):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f0cca86
    • akling@apple.com's avatar
      CachedFrame construction should begin with a Frame&. · 63b87084
      akling@apple.com authored
      <https://webkit.org/b/120719>
      
      Reviewed by Anders Carlsson.
      
      We can't create a CachedFrame from a null Frame anyway.
      
      * bindings/js/ScriptCachedFrameData.cpp:
      (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
      (WebCore::ScriptCachedFrameData::restore):
      * bindings/js/ScriptCachedFrameData.h:
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::CachedFrameBase):
      (WebCore::CachedFrameBase::restore):
      (WebCore::CachedFrame::CachedFrame):
      * history/CachedFrame.h:
      (WebCore::CachedFrame::create):
      * history/CachedPage.cpp:
      (WebCore::CachedPage::CachedPage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63b87084
    • fpizlo@apple.com's avatar
      run-fast-jsc should work with new-school fast/js tests that loop until the DFG tiers up · 44225e60
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120697
      
      Reviewed by Mark Hahnenberg.
      
      Source/JavaScriptCore: 
      
      * API/JSCTestRunnerUtils.cpp:
      (JSC::numberOfDFGCompiles):
      (JSC::setNeverInline):
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * jsc.cpp:
      (GlobalObject::finishCreation):
      (functionNeverInlineFunction):
      (functionNumberOfDFGCompiles):
      * runtime/TestRunnerUtils.cpp: Added.
      (JSC::getExecutable):
      (JSC::numberOfDFGCompiles):
      (JSC::setNeverInline):
      * runtime/TestRunnerUtils.h: Added.
      
      LayoutTests: 
      
      * fast/js/resources/standalone-pre.js:
      (testPassed):
      (testFailed):
      (dfgCompiled):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44225e60
    • akling@apple.com's avatar
      Set "render tree being torn down" flag a bit earlier. · 22cadaf7
      akling@apple.com authored
      <https://webkit.org/b/120717>
      
      Reviewed by Anders Carlsson.
      
      Set the flag at the start of Document::detach() so everyone can get a chance
      to avoid unnecessary work, not just renderers.
      
      * dom/Document.cpp:
      (WebCore::Document::detach):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22cadaf7
    • fpizlo@apple.com's avatar
      Introduce a version of SunSpider that runs for a really long time (about 1 sec on my machine) · b144d21c
      fpizlo@apple.com authored
      Rubber stamped by Mark Hahnenberg.
              
      This isn't meant for serious VM-to-VM performance comparisons, but it is useful
      to see how these benchmarks behave when they're completely warmed up.
      
      * LongSpider: Added.
      * LongSpider/3d-cube.js: Added.
      (DrawLine):
      (CalcCross):
      (CalcNormal):
      (CreateP):
      (MMulti):
      (VMulti):
      (VMulti2):
      (MAdd):
      (Translate):
      (RotateX):
      (RotateY):
      (RotateZ):
      (DrawQube):
      (Loop):
      (Init):
      * LongSpider/3d-morph.js: Added.
      (loops.3500.nx.120.nz.120.morph):
      * LongSpider/3d-raytrace.js: Added.
      (createVector):
      (sqrLengthVector):
      (lengthVector):
      (addVector):
      (subVector):
      (scaleVector):
      (normaliseVector):
      (add):
      (sub):
      (scalev):
      (dot):
      (scale):
      (cross):
      (normalise):
      (transformMatrix):
      (invertMatrix):
      (Triangle):
      (Triangle.prototype.intersect):
      (Scene):
      (Scene.prototype.intersect):
      (Scene.prototype.blocked):
      (Camera):
      (Camera.prototype.generateRayPair):
      (renderRows):
      (Camera.prototype.render):
      (raytraceScene.floorShader):
      (raytraceScene):
      (arrayToCanvasCommands):
      * LongSpider/access-binary-trees.js: Added.
      (TreeNode):
      (TreeNode.prototype.itemCheck):
      (bottomUpTree):
      * LongSpider/access-fannkuch.js: Added.
      (fannkuch):
      * LongSpider/access-nbody.js: Added.
      (Body):
      (Body.prototype.offsetMomentum):
      (Jupiter):
      (Saturn):
      (Uranus):
      (Neptune):
      (Sun):
      (NBodySystem):
      (NBodySystem.prototype.advance):
      (NBodySystem.prototype.energy):
      * LongSpider/access-nsieve.js: Added.
      (pad):
      (nsieve):
      (sieve):
      * LongSpider/bitops-3bit-bits-in-byte.js: Added.
      (fast3bitlookup):
      (TimeFunc):
      * LongSpider/bitops-bits-in-byte.js: Added.
      (bitsinbyte):
      (TimeFunc):
      * LongSpider/bitops-nsieve-bits.js: Added.
      (pad):
      (primes):
      (sieve):
      * LongSpider/controlflow-recursive.js: Added.
      (ack):
      (fib):
      (tak):
      * LongSpider/crypto-aes.js: Added.
      (Cipher):
      (SubBytes):
      (ShiftRows):
      (MixColumns):
      (AddRoundKey):
      (KeyExpansion):
      (SubWord):
      (RotWord):
      (AESEncryptCtr):
      (AESDecryptCtr):
      (escCtrlChars):
      * LongSpider/crypto-md5.js: Added.
      (hex_md5):
      (b64_md5):
      (str_md5):
      (hex_hmac_md5):
      (b64_hmac_md5):
      (str_hmac_md5):
      (md5_vm_test):
      (core_md5):
      (md5_cmn):
      (md5_ff):
      (md5_gg):
      (md5_hh):
      (md5_ii):
      (core_hmac_md5):
      (safe_add):
      (bit_rol):
      (str2binl):
      (binl2str):
      (binl2hex):
      (binl2b64):
      * LongSpider/crypto-sha1.js: Added.
      (hex_sha1):
      (b64_sha1):
      (str_sha1):
      (hex_hmac_sha1):
      (b64_hmac_sha1):
      (str_hmac_sha1):
      (sha1_vm_test):
      (core_sha1):
      (sha1_ft):
      (sha1_kt):
      (core_hmac_sha1):
      (safe_add):
      (rol):
      (str2binb):
      (binb2str):
      (binb2hex):
      (binb2b64):
      * LongSpider/date-format-tofte.js: Added.
      (arrayExists):
      (.a):
      (.A):
      (.B):
      (.d):
      (.D):
      (.F):
      (.g):
      (.G):
      (.h):
      (.H):
      (.i):
      (.j):
      (.l):
      (.L):
      (.m):
      (.M):
      (.n):
      (.O):
      (.r):
      (.S):
      (.s):
      (.t):
      (.U):
      (.W):
      (.w):
      (.Y):
      (.y):
      (.z):
      (Date.prototype.formatDate):
      * LongSpider/date-format-xparb.js: Added.
      (Date.prototype.dateFormat):
      (Date.createNewFormat):
      (Date.getFormatCode):
      (Date.parseDate):
      (Date.createParser):
      (Date.formatCodeToRegex):
      (Date.prototype.getTimezone):
      (Date.prototype.getGMTOffset):
      (Date.prototype.getDayOfYear):
      (Date.prototype.getWeekOfYear):
      (Date.prototype.isLeapYear):
      (Date.prototype.getFirstDayOfMonth):
      (Date.prototype.getLastDayOfMonth):
      (Date.prototype.getDaysInMonth):
      (Date.prototype.getSuffix):
      (String.escape):
      * LongSpider/math-cordic.js: Added.
      (FIXED):
      (FLOAT):
      (DEG2RAD):
      (cordicsincos):
      (cordic):
      * LongSpider/math-partial-sums.js: Added.
      (partial):
      * LongSpider/math-spectral-norm.js: Added.
      (A):
      (Au):
      (Atu):
      (AtAu):
      (spectralnorm):
      * LongSpider/string-base64.js: Added.
      (toBase64):
      (base64ToString):
      * LongSpider/string-fasta.js: Added.
      (rand):
      (makeCumulative):
      (fastaRepeat):
      (fastaRandom):
      * LongSpider/string-tagcloud.js: Added.
      (.Array.prototype.toJSONString):
      (.Boolean.prototype.toJSONString):
      (.Date.prototype.toJSONString):
      (.Number.prototype.toJSONString):
      (.Object.prototype.toJSONString):
      (.):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b144d21c
    • mrowe@apple.com's avatar
      Fix AutodrainedPool.h to compile without errors under ARC. · 2a27d25a
      mrowe@apple.com authored
      Rubber-stamped by Anders Carlsson.
      
      * wtf/AutodrainedPool.h: Some versions of Clang complain about any use of NSAutoreleasePool under ARC.
      Change the type of the member variable to id to work around this. Since the implementation file is compiled
      under manual reference counting, everything will work fine.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a27d25a
    • akling@apple.com's avatar
      Cached Page and Frame don't need to be ref-counted. · e70178de
      akling@apple.com authored
      <https://webkit.org/b/120710>
      
      Reviewed by Anders Carlsson.
      
      - CachedPage is owned by HistoryItem.
      - CachedFrame is owned by CachedPage.
      
      Remove the ref counting from these objects to make the code less confusing.
      
      The only place that used this was in FrameLoader::commitProvisionalLoad() which
      took a temporary ref on the CachedPage. Switched this to using a raw pointer.
      
      * history/CachedFrame.h:
      (WebCore::CachedFrame::create):
      * history/CachedPage.cpp:
      (WebCore::CachedPage::create):
      * history/CachedPage.h:
      * history/HistoryItem.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::commitProvisionalLoad):
      (WebCore::FrameLoader::transitionToCommitted):
      * loader/FrameLoader.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e70178de
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Move ShouldGoToBackForwardListItem to the list of passing API tests · 2d38e9c0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120646
      
      Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-09-04
      Reviewed by Gyuyoung Kim.
      
      * TestWebKitAPI/PlatformEfl.cmake: Move ShouldGoToBackForwardListItem to the
      list of passing tests, since it started to pass after r154045.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d38e9c0
    • roger_fong@apple.com's avatar
      Unreviewed. Windows build fix and WebCore project cleanup. · 2684506a
      roger_fong@apple.com authored
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * rendering/RenderingAllInOne.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2684506a
    • andersca@apple.com's avatar
      De-indent Vector.h. · b88f8235
      andersca@apple.com authored
      Rubber-stamped by Andreas Kling.
      
      I'm cleaning up Vector and making it work with move-only objects, and the namespace WTF
      indentation is driving me crazy.
      
      * wtf/Vector.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b88f8235
    • mrowe@apple.com's avatar
      <https://webkit.org/b/120707> Make WebKit's localizable strings mechanism usable under ARC · 63990846
      mrowe@apple.com authored
      WebKit's localizable strings mechanism is also used outside of WebKit so it needs to work
      both with and without ARC.
      
      Reviewed by Anders Carlsson.
      
      * Misc/WebLocalizableStrings.h: Mark the bundle member as unretained. This matches how the
      member is used within WebLocalizableStrings.mm.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63990846
    • mark.lam@apple.com's avatar
      Renamed StackIterator to StackVisitor. · fa2a142f
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120706.
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      Also did some minor refactoring:
      - Renamed StackIterator::iterate() to StackVisitor::visit().
      - Make StackVisitor::visit() a static method.
      - Move the instantiation of the StackVisitor instance into StackVisitor::visit()
        from CallFrame::iterate().
      - Removed StackIterator::resetIterator() and inline its body into the
        StackVisitor constructor since this is the only remaining caller of it.
      
      * API/JSContextRef.cpp:
      (BacktraceFunctor::operator()):
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * interpreter/CallFrame.h:
      (JSC::ExecState::iterate):
      * interpreter/Interpreter.cpp:
      (JSC::DumpRegisterFunctor::operator()):
      (JSC::unwindCallFrame):
      (JSC::getStackFrameCodeType):
      (JSC::GetStackTraceFunctor::operator()):
      (JSC::UnwindFunctor::operator()):
      * interpreter/Interpreter.h:
      * interpreter/StackIterator.cpp: Removed.
      * interpreter/StackIterator.h: Removed.
      * interpreter/StackVisitor.cpp: Copied from Source/JavaScriptCore/interpreter/StackIterator.cpp.
      (JSC::StackVisitor::StackVisitor):
      (JSC::StackVisitor::gotoNextFrame):
      (JSC::StackVisitor::readFrame):
      (JSC::StackVisitor::readNonInlinedFrame):
      (JSC::StackVisitor::readInlinedFrame):
      (JSC::StackVisitor::Frame::codeType):
      (JSC::StackVisitor::Frame::functionName):
      (JSC::StackVisitor::Frame::sourceURL):
      (JSC::StackVisitor::Frame::toString):
      (JSC::StackVisitor::Frame::arguments):
      (JSC::StackVisitor::Frame::computeLineAndColumn):
      (JSC::StackVisitor::Frame::retrieveExpressionInfo):
      (JSC::StackVisitor::Frame::setToEnd):
      (JSC::StackVisitor::Frame::print):
      (DebugPrintFrameFunctor::operator()):
      * interpreter/StackVisitor.h: Copied from Source/JavaScriptCore/interpreter/StackIterator.h.
      (JSC::StackVisitor::visit):
      * jsc.cpp:
      (FunctionJSCStackFunctor::operator()):
      * profiler/ProfileGenerator.cpp:
      (JSC::AddParentForConsoleStartFunctor::operator()):
      * runtime/JSFunction.cpp:
      (JSC::RetrieveArgumentsFunctor::operator()):
      (JSC::RetrieveCallerFunctionFunctor::operator()):
      * runtime/JSGlobalObjectFunctions.cpp:
      (JSC::GlobalFuncProtoGetterFunctor::operator()):
      (JSC::GlobalFuncProtoSetterFunctor::operator()):
      * runtime/ObjectConstructor.cpp:
      (JSC::ObjectConstructorGetPrototypeOfFunctor::operator()):
      
      Source/WebCore: 
      
      No new tests.
      
      * ForwardingHeaders/interpreter/StackIterator.h: Removed.
      * ForwardingHeaders/interpreter/StackVisitor.h: Copied from Source/WebCore/ForwardingHeaders/interpreter/StackIterator.h.
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::SendFunctor::operator()):
      * bindings/js/ScriptCallStackFactory.cpp:
      (WebCore::CreateScriptCallStackFunctor::operator()):
      (WebCore::CreateScriptCallStackForConsoleFunctor::operator()):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa2a142f
    • commit-queue@webkit.org's avatar
      AX: when no other label on provided on form elements, WebKit should fall back to using @title · a23b6f92
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112842
      
      Patch by Samuel White <samuel_white@apple.com> on 2013-09-04
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Don't let input elements include empty labels in their accessibility title.
      
      Test: platform/mac/accessibility/input-title.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::titleElementText):
      
      LayoutTests:
      
      Added test to ensure that input elements are computing their
      accessibility title as expected.
      
      * platform/mac/accessibility/input-title-expected.txt: Added.
      * platform/mac/accessibility/input-title.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a23b6f92
    • akling@apple.com's avatar
      Make ImageQualityController per-RenderView. · 0eadccd7
      akling@apple.com authored
      <https://webkit.org/b/120702>
      
      Reviewed by Anders Carlsson.
      
      Move ImageQualityController to its own files and add a RenderView::imageQualityController()
      getter instead of using a global map for all render trees.
      
      This avoids having to unregister every renderer (well, every RenderBoxModelObject) from the
      global hash map during render tree teardown.
      
      It also simplifies the live resize optimization a bit since it can now short-circuit if
      the RenderView's FrameView is being resized. (Previously there could be any number of
      RenderViews present in the map.)
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.xcodeproj/project.pbxproj:
      * rendering/ImageQualityController.cpp: Added.
      * rendering/ImageQualityController.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0eadccd7
    • roger_fong@apple.com's avatar
      Unreviewed Build fix for Windows DebugSuffix configuration. · a4be6512
      roger_fong@apple.com authored
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4be6512
    • mark.lam@apple.com's avatar
      Refining the StackIterator callback interface. · 99c89d43
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120695.
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      Introduce CallFrame::iterate() which instantiates a StackIterator and
      invoke its iterate() method with the passed in functor. The only place
      where the client code gets access to the StackIterator now is as an
      argument to the client's functor.
      
      * API/JSContextRef.cpp:
      (JSContextCreateBacktrace):
      * interpreter/CallFrame.cpp:
      * interpreter/CallFrame.h:
      (JSC::ExecState::iterate):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::dumpRegisters):
      (JSC::Interpreter::getStackTrace):
      (JSC::Interpreter::unwind):
      * interpreter/StackIterator.cpp:
      (JSC::StackIterator::StackIterator):
      (DebugPrintFrameFunctor::DebugPrintFrameFunctor):
      (DebugPrintFrameFunctor::operator()):
      (debugPrintCallFrame):
      (debugPrintStack):
      * interpreter/StackIterator.h:
      (JSC::StackIterator::iterate):
      * jsc.cpp:
      (functionJSCStack):
      * profiler/ProfileGenerator.cpp:
      (JSC::ProfileGenerator::addParentForConsoleStart):
      * runtime/JSFunction.cpp:
      (JSC::retrieveArguments):
      (JSC::RetrieveCallerFunctionFunctor::operator()):
      (JSC::retrieveCallerFunction):
      * runtime/JSGlobalObjectFunctions.cpp:
      (JSC::globalFuncProtoGetter):
      (JSC::globalFuncProtoSetter):
      * runtime/ObjectConstructor.cpp:
      (JSC::objectConstructorGetPrototypeOf):
      
      Source/WebCore: 
      
      No new tests.
      
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::SendFunctor::SendFunctor):
      (WebCore::SendFunctor::line):
      (WebCore::SendFunctor::url):
      (WebCore::SendFunctor::operator()):
      (WebCore::JSXMLHttpRequest::send):
      * bindings/js/ScriptCallStackFactory.cpp:
      (WebCore::createScriptCallStack):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99c89d43
    • akling@apple.com's avatar
      Remove unnecessary RenderView.h inclusion from headers. · 3b72a14e
      akling@apple.com authored
      <https://webkit.org/b/120365>
      
      Reviewed by Anders Carlsson.
      
      RenderView.h was overzealously included by RenderText and RenderTextTrackCue,
      making it unpleasant to edit on my laptop.
      
      * rendering/RenderText.h:
      * rendering/RenderTextTrackCue.h:
      
          Don't include RenderView.h here, do it in .cpp files.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b72a14e
    • bdakin@apple.com's avatar
      Fixing a typo in demo files and screenshot. · 7ac1d86f
      bdakin@apple.com authored
      * blog-files/regions/pizza-is-amazing.png: Replaced.
      * demos/regions/pizza-regions-manifesto-regionstyling.html:
      * demos/regions/pizza-regions-manifesto.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ac1d86f