1. 14 Sep, 2012 40 commits
    • jamesr@google.com's avatar
      Unreviewed gardening - more position:fixed stacking context rebaselines. · 14e823cb
      jamesr@google.com authored
      * fast/block/positioning/016-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/016-expected.txt.
      * fast/block/positioning/025-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/025-expected.txt.
      * platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
      * platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
      * platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
      * platform/chromium-mac/fast/block/positioning/016-expected.txt: Removed.
      * platform/chromium-mac/fast/block/positioning/025-expected.txt: Removed.
      * platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
      * platform/chromium-win/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.png.
      * platform/chromium-win/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.png.
      * platform/chromium-win/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png.
      * platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt.
      * platform/chromium/fast/block/positioning/016-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.txt.
      * platform/chromium/fast/block/positioning/025-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.txt.
      * platform/chromium/fast/block/positioning/fixed-position-stacking-context-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt.
      * platform/efl/fast/block/positioning/016-expected.txt: Removed.
      * platform/efl/fast/block/positioning/025-expected.txt: Removed.
      * platform/gtk/fast/block/positioning/016-expected.txt: Removed.
      * platform/gtk/fast/block/positioning/025-expected.txt: Removed.
      * platform/qt/fast/block/positioning/016-expected.txt: Removed.
      * platform/qt/fast/block/positioning/025-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14e823cb
    • fpizlo@apple.com's avatar
      All of the things in SparseArrayValueMap should be out-of-line · 9cedb5d0
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96854
      
      Reviewed by Andy Estes.
      
      Those inline methods were buying us nothing.
      
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * runtime/JSArray.cpp:
      * runtime/JSGlobalData.cpp:
      * runtime/JSObject.cpp:
      * runtime/RegExpMatchesArray.cpp:
      * runtime/SparseArrayValueMap.cpp:
      (JSC::SparseArrayValueMap::SparseArrayValueMap):
      (JSC):
      (JSC::SparseArrayValueMap::~SparseArrayValueMap):
      (JSC::SparseArrayValueMap::finishCreation):
      (JSC::SparseArrayValueMap::create):
      (JSC::SparseArrayValueMap::destroy):
      (JSC::SparseArrayValueMap::createStructure):
      (JSC::SparseArrayValueMap::add):
      (JSC::SparseArrayValueMap::putEntry):
      (JSC::SparseArrayValueMap::putDirect):
      (JSC::SparseArrayEntry::get):
      (JSC::SparseArrayEntry::getNonSparseMode):
      (JSC::SparseArrayValueMap::visitChildren):
      * runtime/SparseArrayValueMapInlineMethods.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cedb5d0
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r128673. · 6b54085e
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/128673
      https://bugs.webkit.org/show_bug.cgi?id=96847
      
      Makes plugins/document-open.html crash (Requested by jamesr_
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14
      
      * dom/ContainerNode.cpp:
      (WebCore):
      (WebCore::ContainerNode::insertBeforeCommon):
      (WebCore::ContainerNode::replaceChild):
      (WebCore::ContainerNode::removeBetween):
      (WebCore::ContainerNode::removeChildren):
      (WebCore::ContainerNode::appendChild):
      (WebCore::ContainerNode::parserAddChild):
      (WebCore::dispatchChildInsertionEvents):
      (WebCore::dispatchChildRemovalEvents):
      * dom/ContainerNode.h:
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
      (WebCore::ChildNodeInsertionNotifier::notify):
      (WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
      * dom/Document.cpp:
      (WebCore::Document::dispatchWindowEvent):
      (WebCore::Document::dispatchWindowLoadEvent):
      * dom/EventDispatcher.cpp:
      (WebCore::EventDispatcher::dispatchEvent):
      * dom/EventTarget.cpp:
      (WebCore):
      (WebCore::forbidEventDispatch):
      (WebCore::allowEventDispatch):
      (WebCore::eventDispatchForbidden):
      (WebCore::EventTarget::fireEventListeners):
      * dom/EventTarget.h:
      (WebCore):
      (WebCore::forbidEventDispatch):
      (WebCore::allowEventDispatch):
      * dom/Node.cpp:
      (WebCore::Node::dispatchSubtreeModifiedEvent):
      (WebCore::Node::dispatchFocusInEvent):
      (WebCore::Node::dispatchFocusOutEvent):
      (WebCore::Node::dispatchDOMActivateEvent):
      * dom/WebKitNamedFlow.cpp:
      (WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::loadInternal):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b54085e
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=96846 · 6f3c90be
      bdakin@apple.com authored
      Tests failing on WK2 bots after giving fixed positioning its own 
      stacking context
      
      Reviewed by Geoffrey Garen.
      
      Tests are failing because I checked in updated results that expect 
      fixed positioning to create a stacking context. However, 
      WebKitTestRunner does not enable ScrollingCoordinator, so the code 
      that I added to enable stacking contexts for fixedPos is never 
      actually running. This patch moves that code to a place where it will 
      run for the testing tools, which matches the patch for WK1.
      * WebProcess/WebPage/DrawingAreaImpl.cpp:
      (WebKit::DrawingAreaImpl::updatePreferences):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f3c90be
    • jchaffraix@webkit.org's avatar
      Revert r127457 and following fixes due to several hit-testing regressions · 5083f636
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96830
      
      Reviewed by Antonio Gomes.
      
      .:
      
      This change reverts r127457, r127863 and r128505.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      This change reverts r127457, r127863 and r128505.
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::hitTestResultAtPoint):
      * rendering/HitTestRequest.h:
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestLocation::HitTestLocation):
      * rendering/HitTestResult.h:
      (HitTestLocation):
      * rendering/RenderFrameBase.cpp:
      * rendering/RenderFrameBase.h:
      (RenderFrameBase):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::hitTest):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit/chromium:
      
      This change reverts r127457, r127863 and r128505.
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
      
      Source/WebKit2:
      
      This change reverts r127457, r127863 and r128505.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      This change reverts r127457, r127863 and r128505. As the tests relies on the extended API
      after r127457, we cannot keep them.
      
      * fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Removed.
      * fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Removed.
      * fast/dom/nodesFromRect/resources/child-frame.html: Removed.
      * fast/dom/nodesFromRect/resources/nodesFromRect.js:
      (check):
      (checkShadowContent):
      * touchadjustment/iframe-boundary-expected.txt: Removed.
      * touchadjustment/iframe-boundary.html: Removed.
      * touchadjustment/resources/inner-content-page.html: Removed.
      * touchadjustment/resources/inner-navigation-frame.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5083f636
    • commit-queue@webkit.org's avatar
      Skip image load tests that requires queueReload in WebKit2 · fe91d738
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96832
      
      Tests added in reivison 128645.
      
      Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe91d738
    • dpranke@chromium.org's avatar
      nrwt: --additional-platform-dir is broken on chromium ports · 880eca66
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96840
      
      Reviewed by Ojan Vafai.
      
      Looks like I broke this when cleaning things up as part of
      adding ML support. Fixing and adding a test.
      
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      (ChromiumPort.default_baseline_search_path):
      * Scripts/webkitpy/layout_tests/port/chromium_android.py:
      (ChromiumAndroidPort.default_baseline_search_path):
      * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
      (ChromiumLinuxPort.default_baseline_search_path):
      * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
      (ChromiumMacPort.__init__):
      * Scripts/webkitpy/layout_tests/port/chromium_win.py:
      (ChromiumWinPort.setup_environ_for_server):
      * Scripts/webkitpy/layout_tests/port/port_testcase.py:
      (test_check_build):
      (test_additional_platform_directory):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      880eca66
    • jsbell@chromium.org's avatar
      IndexedDB: Calling close() during upgradeneeded handler should fire error at open request · bd1cfeab
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96807
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Per spec, if the database connection is closed before the success event fires, the request
      should have an error event of type AbortError fired at it.
      
      Test: storage/indexeddb/intversion-close-in-upgradeneeded.html
      
      * Modules/indexeddb/IDBDatabase.h:
      (WebCore::IDBDatabase::isClosePending): Expose this state so an in-flight success can be morphed.
      * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
      (WebCore::IDBDatabaseBackendImpl::close): Fire the appropriate error at connections that are mid-opening.
      * Modules/indexeddb/IDBOpenDBRequest.cpp:
      (WebCore::IDBOpenDBRequest::onSuccess): If the connection was closed before the success is enqueued -
      which can happen in multi-process ports with asynchronous messaging - convert the success to an error.
      
      LayoutTests:
      
      Update the test to match the spec behavior.
      
      * storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
      * storage/indexeddb/resources/intversion-close-in-upgradeneeded.js:
      (deleteSuccess):
      (upgradeNeeded.transaction.oncomplete):
      (upgradeNeeded):
      (openError):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd1cfeab
    • rniwa@webkit.org's avatar
      Turn forbidEventDispatch and allowEventDispatch into a RAII object · 3f29758a
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96717
      
      Reviewed by Abhishek Arya.
      
      Replaced forbidEventDispatch and allowEventDispatch by AssertNoEventDispatch.
      
      * dom/ContainerNode.cpp:
      (WebCore):
      (WebCore::ContainerNode::insertBeforeCommon):
      (WebCore::ContainerNode::replaceChild):
      (WebCore::ContainerNode::removeBetween):
      (WebCore::ContainerNode::removeChildren):
      (WebCore::ContainerNode::appendChild):
      (WebCore::ContainerNode::parserAddChild):
      (WebCore::dispatchChildInsertionEvents):
      (WebCore::dispatchChildRemovalEvents):
      * dom/ContainerNode.h:
      (AssertNoEventDispatch):
      (WebCore::AssertNoEventDispatch::AssertNoEventDispatch):
      (WebCore::AssertNoEventDispatch::~AssertNoEventDispatch):
      (WebCore::AssertNoEventDispatch::isEventDispatchForbidden):
      (WebCore):
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
      (WebCore::ChildNodeInsertionNotifier::notify):
      (WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
      * dom/Document.cpp:
      (WebCore::Document::dispatchWindowEvent):
      (WebCore::Document::dispatchWindowLoadEvent):
      * dom/EventDispatcher.cpp:
      (WebCore::EventDispatcher::dispatchEvent):
      * dom/EventTarget.cpp:
      (WebCore):
      (WebCore::EventTarget::fireEventListeners):
      * dom/EventTarget.h:
      (WebCore):
      * dom/Node.cpp:
      (WebCore::Node::dispatchSubtreeModifiedEvent):
      (WebCore::Node::dispatchFocusInEvent):
      (WebCore::Node::dispatchFocusOutEvent):
      (WebCore::Node::dispatchDOMActivateEvent):
      * dom/WebKitNamedFlow.cpp:
      (WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::loadInternal):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f29758a
    • ojan@chromium.org's avatar
      Mark svg/carto.net/selectionlist.svg as flaky because it depends on svg/carto.net/button.svg · 37842cc9
      ojan@chromium.org authored
      running first in order to pass.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37842cc9
    • ojan@chromium.org's avatar
      The cr-linux-ews thinks http/tests/cache/post-redirect-get.php and... · cadbeb92
      ojan@chromium.org authored
      The cr-linux-ews thinks http/tests/cache/post-redirect-get.php and http/tests/cache/post-with-cached-subresources.php are MISSING results
      https://bugs.webkit.org/show_bug.cgi?id=95215
      
      Reviewed by Adam Barth.
      
      Apparently, marking these as missing did not fix the EWS problem,
      so remove them from TestExpectations.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cadbeb92
    • commit-queue@webkit.org's avatar
      JSC should throw a more descriptive exception when blocking 'eval' via CSP. · 7415e10e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94331
      
      Patch by Mike West <mkwst@chromium.org> on 2012-09-14
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Unless explicitly whitelisted, the 'script-src' Content Security Policy
      directive blocks 'eval' and 'eval'-like constructs such as
      'new Function()'. When 'eval' is encountered in code, an 'EvalError' is
      thrown, but the associated message is poor: "Eval is disabled" doesn't
      give developers enough information about why their code isn't behaving
      as expected.
      
      This patch adds an 'errorMessage' parameter to the JavaScriptCore method
      used to disable 'eval'; ContentSecurityPolicy has the opportunity to
      pass in a more detailed and descriptive error that contains more context
      for the developer.
      
      * runtime/Executable.cpp:
      (JSC::EvalExecutable::compileInternal):
          Drop the hard-coded "Eval is disabled" error message in favor of
          reading the error message off the global object.
      * runtime/FunctionConstructor.cpp:
      (JSC::FunctionConstructor::getCallData):
          Drop the hard-coded "Function constructor is disabled" error message
          in favor of reading the error message off the global object.
      * runtime/JSGlobalObject.h:
      (JSGlobalObject):
      (JSC::JSGlobalObject::evalEnabled):
          Making this accessor method const.
      (JSC::JSGlobalObject::evalDisabledErrorMessage):
          Accessor for the error message set via 'setEvalDisabled'.
      (JSC::JSGlobalObject::setEvalEnabled):
          Adding an 'errorMessage' parameter which is stored on the global
          object, and used when exceptions are thrown.
      
      Source/WebCore:
      
      Unless explicitly whitelisted, the 'script-src' Content Security Policy
      directive blocks 'eval' and 'eval'-like constructs such as
      'new Function()'. When 'eval' is encountered in code, an 'EvalError' is
      thrown, but the associated message is poor: "Eval is disabled" doesn't
      give developers enough information about why their code isn't behaving
      as expected.
      
      This patch adds an 'errorMessage' parameter to the JavaScriptCore method
      used to disable 'eval'; ContentSecurityPolicy has the opportunity to
      pass in a more detailed and descriptive error that contains more context
      for the developer.
      
      The new error message is tested by adjusting existing tests; nothing new
      is required.
      
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::initScript):
          Read the error message off the document's ContentSecurityPolicy.
      (WebCore::ScriptController::disableEval):
      * bindings/js/ScriptController.h:
      (ScriptController):
          Pipe the error message through to JSGlobalObject when disabling eval
      * bindings/js/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::disableEval):
      * bindings/js/WorkerScriptController.h:
      (WorkerScriptController):
          Pipe the error message through to JSGlobalObject when disabling eval
      * bindings/v8/ScriptController.cpp:
      (WebCore::ScriptController::disableEval):
      * bindings/v8/ScriptController.h:
      (ScriptController):
      * bindings/v8/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::disableEval):
      * bindings/v8/WorkerScriptController.h:
      (WorkerScriptController):
          Placeholder for V8 piping to be built in webk.it/94332.
      * dom/Document.cpp:
      (WebCore::Document::disableEval):
      * dom/Document.h:
      (Document):
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
          Pipe the error message through to the ScriptController when
          disabling eval.
      * page/ContentSecurityPolicy.cpp:
      (WebCore::CSPDirectiveList::evalDisabledErrorMessage):
          Accessor for the error message that ought be displayed to developers
          when 'eval' used while disabled for a specific directive list.
      (WebCore::CSPDirectiveList::setEvalDisabledErrorMessage):
          Mutator for the error message that ought be displayed to developers
          when 'eval' used while disabled for a specific directive list.
      (CSPDirectiveList):
      (WebCore::CSPDirectiveList::create):
          Upon creation of a CSPDirectiveList, set the error message if the
          directive list disables 'eval'.
      (WebCore::ContentSecurityPolicy::didReceiveHeader):
          Pass the error message into ScriptExecutionContext::disableEval.
      (WebCore::ContentSecurityPolicy::evalDisabledErrorMessage):
          Public accessor for the policy's error message; walks the list of
          directive lists and returns the first error message found.
      (WebCore):
      * page/ContentSecurityPolicy.h:
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::disableEval):
      * workers/WorkerContext.h:
      (WorkerContext):
          Pipe the error message through to the ScriptController when
          disabling eval.
      
      LayoutTests:
      
      * http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe-expected.txt:
      * http/tests/security/contentSecurityPolicy/function-constructor-blocked-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7415e10e
    • commit-queue@webkit.org's avatar
      Remove V8DOMWindowShell::getEntered · 6e720dd4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96637
      
      Patch by Dan Carney <dcarney@google.com> on 2012-09-14
      Reviewed by Adam Barth.
      
      V8DOMWindowShell::getEntered was refactored so that the window shell
      no longer has to be kept alive by a v8 context but rather a smaller
      object.
      
      No new tests. No change in functionality.
      
      * bindings/v8/DOMData.cpp:
      (WebCore::DOMData::getCurrentStore):
      * bindings/v8/ScopedPersistent.h:
      (WebCore::ScopedPersistent::leakHandle):
      (ScopedPersistent):
      * bindings/v8/ScriptController.cpp:
      (WebCore::ScriptController::resetIsolatedWorlds):
      (WebCore::ScriptController::evaluateInIsolatedWorld):
      (WebCore::ScriptController::currentWorldContext):
      * bindings/v8/V8Binding.cpp:
      (WebCore::perContextDataForCurrentWorld):
      * bindings/v8/V8DOMWindowShell.cpp:
      (WebCore::setIsolatedWorldField):
      (WebCore::V8DOMWindowShell::toIsolatedContextData):
      (WebCore::isolatedContextWeakCallback):
      (WebCore::V8DOMWindowShell::disposeContext):
      (WebCore::V8DOMWindowShell::clearIsolatedShell):
      (WebCore):
      (WebCore::V8DOMWindowShell::initializeIfNeeded):
      (WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
      * bindings/v8/V8DOMWindowShell.h:
      (V8DOMWindowShell):
      (IsolatedContextData):
      (WebCore::V8DOMWindowShell::IsolatedContextData::create):
      (WebCore::V8DOMWindowShell::IsolatedContextData::world):
      (WebCore::V8DOMWindowShell::IsolatedContextData::perContextData):
      (WebCore::V8DOMWindowShell::IsolatedContextData::setSecurityOrigin):
      (WebCore::V8DOMWindowShell::IsolatedContextData::securityOrigin):
      (WebCore::V8DOMWindowShell::IsolatedContextData::IsolatedContextData):
      (WebCore::V8DOMWindowShell::enteredIsolatedContext):
      (WebCore::V8DOMWindowShell::enteredIsolatedContextData):
      * bindings/v8/V8DOMWrapper.h:
      (WebCore::V8DOMWrapper::getCachedWrapper):
      * bindings/v8/WorldContextHandle.cpp:
      (WebCore::WorldContextHandle::WorldContextHandle):
      * bindings/v8/custom/V8DocumentCustom.cpp:
      (WebCore::toV8):
      * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
      (WebCore::toV8):
      * bindings/v8/custom/V8SVGDocumentCustom.cpp:
      (WebCore::toV8):
      * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
      (WebCore::V8XMLHttpRequest::constructorCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e720dd4
    • ojan@chromium.org's avatar
      Mark compositing/geometry/fixed-position-transform-composited-page-scale.html flaky · a978e2b2
      ojan@chromium.org authored
      as it's flaky on all the Chromium bots.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a978e2b2
    • fpizlo@apple.com's avatar
      bbc homepage crashes immediately · c9f16125
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96812
      <rdar://problem/12081386>
      
      Reviewed by Oliver Hunt.
      
      If you use the old storage pointer to write to space you thought was newly allocated,
      you're going to have a bad time.
      
      * runtime/JSArray.cpp:
      (JSC::JSArray::unshiftCount):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9f16125
    • michelangelo@webkit.org's avatar
      [CSS Shaders] u_textureSize uniform should be set to the size of the texture. · 65db9806
      michelangelo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95914
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      This adds support for the following shader uniform variables:
      
          uniform vec2 u_textureSize
          uniform vec4 u_meshBox
          uniform vec2 u_tileSize
          uniform vec2 u_meshSize
      
      The relevant section of the specification is:
      http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables
      
      Tests: css3/filters/custom/custom-filter-u-mesh-box.html
             css3/filters/custom/custom-filter-u-mesh-size.html
             css3/filters/custom/custom-filter-u-texture-size.html
             css3/filters/custom/custom-filter-u-tile-size.html
      
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::bindProgramAndBuffers):
      
      LayoutTests:
      
      Tests for the following uniform variables:
          uniform vec2 u_textureSize
          uniform vec4 u_meshBox
          uniform vec2 u_tileSize
          uniform vec2 u_meshSize
      
      The relevant section of the specification is:
      http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables
      
      * css3/filters/custom/custom-filter-u-mesh-box-expected.html: Added.
      * css3/filters/custom/custom-filter-u-mesh-box.html: Added.
      * css3/filters/custom/custom-filter-u-mesh-size-expected.html: Added.
      * css3/filters/custom/custom-filter-u-mesh-size.html: Added.
      * css3/filters/custom/custom-filter-u-texture-size-expected.html: Added.
      * css3/filters/custom/custom-filter-u-texture-size.html: Added.
      * css3/filters/custom/custom-filter-u-tile-size-expected.html: Added.
      * css3/filters/custom/custom-filter-u-tile-size.html: Added.
      * css3/filters/resources/u-mesh-box-is-unit-square.fs: Added.
      * css3/filters/resources/u-mesh-size.fs: Added.
      * css3/filters/resources/u-texture-size.fs: Added.
      * css3/filters/resources/u-tile-size.fs: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65db9806
    • ap@apple.com's avatar
      Unreviewed. · 59de8d92
      ap@apple.com authored
              
              A small improvement to this flaky test: use a correct URL, so that the test fails
              quickly and understandably instead of timing out. This code path didn't use to be
              taken before, so the URL was always wrong.
      
              * fast/loader/resources/submit-form-while-parsing-subframe.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59de8d92
    • slewis@apple.com's avatar
      new fast/loader tests from r128645 fail on Mac-wk2. · 4d73308c
      slewis@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96832.
      
      Unreviewed.
      
      Update TestExpectations
      
      * platform/mac-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d73308c
    • ojan@chromium.org's avatar
      Provide a runtime setting to disable position:sticky · 52498d7e
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96827
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Have it be on by default so that only ports that both enable
      the define and don't want it on by default need to do something special.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParserContext::CSSParserContext):
      (WebCore::operator==):
      (WebCore::isValidKeywordPropertyAndValue):
      * css/CSSParserMode.h:
      (CSSParserContext):
      * dom/Document.cpp:
      (WebCore::Document::cssStickyPositionEnabled):
      (WebCore):
      * dom/Document.h:
      (Document):
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      * page/Settings.h:
      (Settings):
      (WebCore::Settings::setCSSStickyPositionEnabled):
      (WebCore::Settings::cssStickyPositionEnabled):
      
      Source/WebKit/chromium:
      
      * public/WebSettings.h:
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::setCSSStickyPositionEnabled):
      (WebKit):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52498d7e
    • slewis@apple.com's avatar
      mac-future ignores previous platform TestExpectations. · 160c1356
      slewis@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96718.
      
      Reviewed by Dirk Pranke.
      
      TestExpectations match an expectation's configuraton against a list of configurations that are
      valid for that port.  That list does not contain mac-future so none of the expectations can be
      applied.
      
      * Scripts/webkitpy/layout_tests/port/apple.py:
      (ApplePort._generate_all_test_configurations):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      160c1356
    • ojan@chromium.org's avatar
      Add expectations for tests that depend on other tests running before them. · 9cf0a964
      ojan@chromium.org authored
      Filed a bug for each with information on which test it depends on.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cf0a964
    • simon.fraser@apple.com's avatar
      Fix builds with CSS_IMAGE_RESOLUTION enabled after r128656. · 7793b456
      simon.fraser@apple.com authored
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyImageResolution::applyInheritValue):
      (WebCore::ApplyPropertyImageResolution::applyInitialValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7793b456
    • jamesr@google.com's avatar
      Unreviewed gardening. · fb5d20a1
      jamesr@google.com authored
      Update fixpos layout test results. Chromium currently doesn't set the fixpos-forms-stacking-context setting in
      DumpRenderTree.
      
      * fast/block/positioning/016-expected.png: Copied from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
      * fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/025-expected.png.
      * platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
      * platform/chromium-linux-x86/fast/block/positioning/016-expected.txt: Added.
      * platform/chromium-linux-x86/fast/block/positioning/025-expected.txt: Added.
      * platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
      * platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
      * platform/chromium-linux/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/016-expected.png.
      * platform/chromium-linux/fast/block/positioning/016-expected.txt: Added.
      * platform/chromium-linux/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/025-expected.png.
      * platform/chromium-linux/fast/block/positioning/025-expected.txt: Added.
      * platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
      * platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
      * platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
      * platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Added.
      * platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Added.
      * platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
      * platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
      * platform/chromium-mac/fast/block/positioning/016-expected.png: Added.
      * platform/chromium-mac/fast/block/positioning/016-expected.txt: Added.
      * platform/chromium-mac/fast/block/positioning/025-expected.png: Added.
      * platform/chromium-mac/fast/block/positioning/025-expected.txt: Added.
      * platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
      * platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb5d20a1
    • abarth@webkit.org's avatar
      Remove webkitPostMessage · 79bb5ebb
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96577
      
      Reviewed by Ojan Vafai.
      
      .:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/JavaScriptCore:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      webkitPostMessage works the same as postMessage. The spec and the
      implementation have been stable for a while. We should no longer be
      exposing this vendor-prefixed API.
      
      This patch places the webkitPostMessage API behind an ENABLE flag.
      We're going to try removing this API in the Chromium port. If we don't
      run into trouble, we'll remove it in all the other ports as well.
      
      This topic has been discussed on webkit-dev in
      http://lists.webkit.org/pipermail/webkit-dev/2012-April/020237.html and
      http://lists.webkit.org/pipermail/webkit-dev/2012-September/022189.html
      
      This patch introduces the ENABLE(LEGACY_VENDOR_PREFIXES) flag. Rather
      than having a flag for each vendor-prefixed API we're experimenting
      with removing, we'll add vendor prefixed APIs to this ENABLE when we
      want to try removing them. If we succeed, we'll just delete the APIs.
      If we fail, we'll remove them from the ENABLE. That way we avoid the
      churn of adding and removing many ENABLE macros.
      
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * GNUmakefile.features.am:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore):
      * bindings/js/JSDedicatedWorkerContextCustom.cpp:
      (WebCore):
      * bindings/js/JSMessagePortCustom.cpp:
      (WebCore):
      * bindings/js/JSWorkerCustom.cpp:
      (WebCore):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore):
      * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
      (WebCore):
      * bindings/v8/custom/V8MessagePortCustom.cpp:
      (WebCore):
      * bindings/v8/custom/V8WorkerCustom.cpp:
      (WebCore):
      * dom/MessagePort.idl:
      * page/DOMWindow.idl:
      * workers/DedicatedWorkerContext.idl:
      * workers/Worker.idl:
      
      Source/WebKit/chromium:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * features.gypi:
      
      Source/WebKit/mac:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Tools:
      
      Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
      
      * Scripts/webkitperl/FeatureList.pm:
      * qmake/mkspecs/features/features.pri:
      
      LayoutTests:
      
      Update tests to rely only upon the unprefixed API.
      
      * fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js:
      (wrapSend):
      (wrapFailSend):
      * fast/dom/Window/post-message-crash.html:
      * fast/dom/Window/window-postmessage-args-expected.txt:
      * fast/dom/Window/window-postmessage-args.html:
      * fast/events/message-port.html:
      * fast/events/resources/message-port-multi.js:
      * fast/workers/resources/worker-call.js:
      * fast/workers/worker-call-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79bb5ebb
    • ap@apple.com's avatar
      Minimize collisions when hashing pairs · 73a1c7fd
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=96022
      
              Build fix (with newer clang?)
      
              * wtf/HashFunctions.h: (WTF::pairIntHash): Be explicit about casting from
              64 bit to 32 bit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73a1c7fd
    • simon.fraser@apple.com's avatar
      REGRESSION: transition doesn’t always override transition-property · 04224074
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96658
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Setting the animation property on an Animation in CSSToStyleMap::mapAnimationProperty()
      is special because we have to call setAnimationMode(Animation::AnimateAll) as well
      as setting the property to CSSPropertyInvalid if it's for the initial state
      of the transition-property property.
      
      In order to fix this via StyleBuilder PropertyHandlers, we have to know,
      in ApplyPropertyAnimation::applyInitialValue(), which property is getting applied.
      This requires passing the CSSPropertyID down through all of the "apply" methods.
      
      Do some unrelated cleanup in CSSParser::parseTransitionShorthand(); the existing code
      was not safe with respect to adding new properties to the shorthand.
      
      Test: transitions/longhand-vs-shorthand-initial.html
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseTransitionShorthand):
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyExpanding::applyInheritValue):
      (WebCore::ApplyPropertyExpanding::applyInitialValue):
      (WebCore::ApplyPropertyExpanding::applyValue):
      (WebCore::ApplyPropertyDefaultBase::applyInheritValue):
      (WebCore::ApplyPropertyDefaultBase::applyInitialValue):
      (WebCore::ApplyPropertyDefaultBase::applyValue):
      (WebCore::ApplyPropertyDefault::applyValue):
      (WebCore::ApplyPropertyNumber::applyValue):
      (WebCore::ApplyPropertyStyleImage::applyValue):
      (WebCore::ApplyPropertyAuto::applyInheritValue):
      (WebCore::ApplyPropertyAuto::applyInitialValue):
      (WebCore::ApplyPropertyAuto::applyValue):
      (WebCore::ApplyPropertyClip::applyInheritValue):
      (WebCore::ApplyPropertyClip::applyInitialValue):
      (WebCore::ApplyPropertyClip::applyValue):
      (WebCore::ApplyPropertyColor::applyInheritValue):
      (WebCore::ApplyPropertyColor::applyInitialValue):
      (WebCore::ApplyPropertyColor::applyValue):
      (WebCore::ApplyPropertyDirection::applyValue):
      (WebCore::ApplyPropertyLength::applyValue):
      (WebCore::ApplyPropertyString::applyValue):
      (WebCore::ApplyPropertyBorderRadius::applyValue):
      (WebCore::ApplyPropertyFillLayer::applyInheritValue):
      (WebCore::ApplyPropertyFillLayer::applyInitialValue):
      (WebCore::ApplyPropertyFillLayer::applyValue):
      (WebCore::ApplyPropertyComputeLength::applyValue):
      (WebCore::ApplyPropertyFont::applyInheritValue):
      (WebCore::ApplyPropertyFont::applyInitialValue):
      (WebCore::ApplyPropertyFont::applyValue):
      (WebCore::ApplyPropertyFontSize::applyInheritValue):
      (WebCore::ApplyPropertyFontSize::applyInitialValue):
      (WebCore::ApplyPropertyFontSize::applyValue):
      (WebCore::ApplyPropertyFontWeight::applyValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyValue):
      (WebCore::ApplyPropertyBorderImage::applyValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyValue):
      (WebCore::ApplyPropertyBorderImageSource::applyValue):
      (WebCore::ApplyPropertyCounter::emptyFunction):
      (WebCore::ApplyPropertyCounter::applyInheritValue):
      (WebCore::ApplyPropertyCounter::applyValue):
      (WebCore::ApplyPropertyCursor::applyInheritValue):
      (WebCore::ApplyPropertyCursor::applyInitialValue):
      (WebCore::ApplyPropertyCursor::applyValue):
      (WebCore::ApplyPropertyTextAlign::applyValue):
      (WebCore::ApplyPropertyTextDecoration::applyValue):
      (WebCore::ApplyPropertyLineHeight::applyValue):
      (WebCore::ApplyPropertyPageSize::applyInheritValue):
      (WebCore::ApplyPropertyPageSize::applyInitialValue):
      (WebCore::ApplyPropertyPageSize::applyValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
      (WebCore::ApplyPropertyAnimation::applyInheritValue):
      (WebCore::ApplyPropertyAnimation::applyInitialValue): If the property is
      CSSPropertyWebkitTransitionProperty, call setAnimationMode(Animation::AnimateAll).
      (WebCore::ApplyPropertyAnimation::applyValue):
      (WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
      (WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
      (WebCore::ApplyPropertyOutlineStyle::applyValue):
      (WebCore::ApplyPropertyResize::applyValue):
      (WebCore::ApplyPropertyVerticalAlign::applyValue):
      (WebCore::ApplyPropertyAspectRatio::applyInheritValue):
      (WebCore::ApplyPropertyAspectRatio::applyInitialValue):
      (WebCore::ApplyPropertyAspectRatio::applyValue):
      (WebCore::ApplyPropertyZoom::applyInheritValue):
      (WebCore::ApplyPropertyZoom::applyInitialValue):
      (WebCore::ApplyPropertyZoom::applyValue):
      (WebCore::ApplyPropertyDisplay::applyInheritValue):
      (WebCore::ApplyPropertyDisplay::applyInitialValue):
      (WebCore::ApplyPropertyDisplay::applyValue):
      (WebCore::ApplyPropertyClipPath::applyValue):
      (WebCore::ApplyPropertyWrapShape::applyValue):
      (WebCore::ApplyPropertyImageResolution::applyInheritValue):
      (WebCore::ApplyPropertyImageResolution::applyInitialValue):
      (WebCore::ApplyPropertyImageResolution::applyValue):
      * css/StyleBuilder.h:
      (PropertyHandler):
      (WebCore::PropertyHandler::applyInheritValue):
      (WebCore::PropertyHandler::applyInitialValue):
      (WebCore::PropertyHandler::applyValue):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList): Pass in the property ID.
      
      LayoutTests:
      
      Test with longhand transition-property rule, followed by shorthand
      with missing property value. This test should pass, and not assert.
      
      * transitions/longhand-vs-shorthand-initial-expected.txt: Added.
      * transitions/longhand-vs-shorthand-initial.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04224074
    • commit-queue@webkit.org's avatar
      Support constructor-type attribute in idls other than DOMWindow. · 6cb79daf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96821
      
      Patch by Chang Shu <cshu@webkit.org> on 2012-09-14
      Reviewed by Kentaro Hara.
      
      In CodeGeneratorJS.pm, we should not assume only DOMWindow uses Constructor
      attribute. So for other interfaces, we should pass castedThis->globalObject()
      instead of castedThis.
      
      Test: bindings/scripts/test/JS/JSTestObj.idl
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::jsTestObjConstructorTestSubObj):
      (WebCore::jsTestObjConditionalAttr4Constructor):
      (WebCore::jsTestObjConditionalAttr5Constructor):
      (WebCore::jsTestObjConditionalAttr6Constructor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cb79daf
    • tsepez@chromium.org's avatar
      ImageLoader can't be cleared when video element poster attribute removed. · ccd1e0c0
      tsepez@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96301
      
      Reviewed by Abhishek Arya.
      
      Source/WebCore:
      
      Same problem as in https://bugs.webkit.org/show_bug.cgi?id=90801. We can't
      clear the image loader when the src attribute is cleared, because we might be
      inside a handler called on top of an image loader event dispatch. Instead we
      will rely on the OwnPtr relationship between the Element and the Image Loader
      to limit the lifetime of the loader to that of the element.
      
      Test: fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html
      
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::parseAttribute):
      Remove permature clearing of m_imageLoader.
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::parseAttribute):
      Remove permature clearing of m_imageLoader.
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parseAttribute):
      Remove permature clearing of m_imageLoader.
      
      LayoutTests:
      
      Added test case.
      
      * fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt: Added.
      * fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccd1e0c0
    • jpfau@apple.com's avatar
      Allow third-party storage blocking setting to change while a page is loaded · aaef7311
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95790
      
      Reviewed by Brady Eidson.
      
      .:
      
      Update exported symbols.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Pipe through changes to the storage blocking policy to each document and plugin.
      
      Tests: http/tests/security/storage-blocking-loosened-local-storage.html
             http/tests/security/storage-blocking-loosened-plugin.html
             http/tests/security/storage-blocking-loosened-private-browsing-plugin.html
             http/tests/security/storage-blocking-loosened-shared-worker.html
             http/tests/security/storage-blocking-loosened-websql.html
             http/tests/security/storage-blocking-strengthened-local-storage.html
             http/tests/security/storage-blocking-strengthened-plugin.html
             http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html
             http/tests/security/storage-blocking-strengthened-shared-worker.html
             http/tests/security/storage-blocking-strengthened-websql.html
      
      * WebCore.exp.in:
      * dom/Document.cpp: Pipe changes through to the Document's SecurityOrigin.
      (WebCore::Document::storageBlockingStateDidChange):
      (WebCore):
      * dom/Document.h:
      (Document):
      * page/DOMWindow.cpp: Check to make sure access is allowed before returning a cached storage area.
      (WebCore::DOMWindow::sessionStorage):
      (WebCore::DOMWindow::localStorage):
      * page/Page.cpp:
      (WebCore::Page::collectPluginViews): Refactored out into a function.
      (WebCore):
      (WebCore::Page::storageBlockingStateChanged): Pipe changes through to each PluginView.
      (WebCore::Page::privateBrowsingStateChanged):
      * page/Page.h:
      (Page):
      * page/Settings.cpp:
      (WebCore::Settings::setStorageBlockingPolicy): Tell Pages about changes to the storage blocking policy.
      (WebCore):
      * page/Settings.h:
      (Settings):
      * plugins/PluginViewBase.h:
      (WebCore::PluginViewBase::storageBlockingStateChanged):
      
      Source/WebKit2:
      
      Inform plugins about changes to the storage blocking policy by way of the private browsing feature.
      
      * PluginProcess/PluginControllerProxy.cpp:
      (WebKit::PluginControllerProxy::storageBlockingStateChanged):
      (WebKit):
      * PluginProcess/PluginControllerProxy.h:
      (PluginControllerProxy):
      * PluginProcess/PluginControllerProxy.messages.in: Add WK2 message for storageBlockingStateChanged.
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::storageBlockingStateChanged):
      (WebKit):
      (WebKit::NetscapePlugin::privateBrowsingStateChanged):
      (WebKit::NetscapePlugin::updateNPNPrivateMode): Set plugin's private browsing if either private browsing or storage blocking is enabled.
      * WebProcess/Plugins/Netscape/NetscapePlugin.h:
      (NetscapePlugin):
      * WebProcess/Plugins/PDF/BuiltInPDFView.h:
      (BuiltInPDFView):
      * WebProcess/Plugins/PDF/BuiltInPDFView.mm: Treat storageBlockingStateChanged as a no-op.
      (WebKit::BuiltInPDFView::storageBlockingStateChanged):
      (WebKit):
      * WebProcess/Plugins/Plugin.h: Add pure virtual storageBlockingStateChanged method.
      (Plugin):
      * WebProcess/Plugins/PluginProxy.cpp:
      (WebKit::PluginProxy::storageBlockingStateChanged):
      (WebKit):
      * WebProcess/Plugins/PluginProxy.h:
      (PluginProxy):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::storageBlockingStateChanged):
      (WebKit):
      * WebProcess/Plugins/PluginView.h:
      (PluginView):
      * win/WebKit2.def:
      
      LayoutTests:
      
      Tested combinations of loosening and strengthening the storage blocking policy on various types of storage.
      
      * http/tests/security/resources/iframe-for-storage-blocking-changed-local-storage.html: Added.
      * http/tests/security/resources/iframe-for-storage-blocking-changed-shared-worker.html: Added.
      * http/tests/security/resources/iframe-for-storage-blocking-changed-websql.html: Added.
      * http/tests/security/storage-blocking-loosened-local-storage-expected.txt: Added.
      * http/tests/security/storage-blocking-loosened-local-storage.html: Added.
      * http/tests/security/storage-blocking-loosened-plugin-expected.txt: Added.
      * http/tests/security/storage-blocking-loosened-plugin.html: Added.
      * http/tests/security/storage-blocking-loosened-private-browsing-plugin-expected.txt: Added.
      * http/tests/security/storage-blocking-loosened-private-browsing-plugin.html: Added.
      * http/tests/security/storage-blocking-loosened-shared-worker-expected.txt: Added.
      * http/tests/security/storage-blocking-loosened-shared-worker.html: Added.
      * http/tests/security/storage-blocking-loosened-websql-expected.txt: Added.
      * http/tests/security/storage-blocking-loosened-websql.html: Added.
      * http/tests/security/storage-blocking-strengthened-local-storage-expected.txt: Added.
      * http/tests/security/storage-blocking-strengthened-local-storage.html: Added.
      * http/tests/security/storage-blocking-strengthened-plugin-expected.txt: Added.
      * http/tests/security/storage-blocking-strengthened-plugin.html: Added.
      * http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt: Added.
      * http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html: Added.
      * http/tests/security/storage-blocking-strengthened-shared-worker-expected.txt: Added.
      * http/tests/security/storage-blocking-strengthened-shared-worker.html: Added.
      * http/tests/security/storage-blocking-strengthened-websql-expected.txt: Added.
      * http/tests/security/storage-blocking-strengthened-websql.html: Added.
      * platform/chromium/TestExpectations: Skip shared worker and plugin tests.
      * platform/mac-wk2/http/tests/security/storage-blocking-strengthened-plugin-expected.txt: Added.
      * platform/mac-wk2/http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aaef7311
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=96688 · 2b20219a
      bdakin@apple.com authored
      Put position:fixed elements in their own layers and allow them to 
      create a stacking context
      -and corresponding-
      <rdar://problem/11467961>
      
      Reviewed by Simon Fraser.
      
      Source/WebKit/mac: 
      
      Enable these settings in WK1 too for consistency. 
      * WebView/WebView.mm:
      (-[WebView _preferencesChanged:]):
      
      Source/WebKit2: 
      
      Soon we want pages with fixed positioned elements to be able to be 
      scrolled by the ScrollingCoordinator. As a part of that work, we have 
      to composite fixed position elements, and we have to allow those
      elements to create a stacking context.
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
      
      LayoutTests: 
      
      A few test result differences. These first three tests actually
      render differently now.
      * platform/mac/fast/block/positioning/016-expected.png:
      * platform/mac/fast/block/positioning/016-expected.txt:
      * platform/mac/fast/block/positioning/025-expected.png:
      * platform/mac/fast/block/positioning/025-expected.txt:
      * platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
      * platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
      
      These tests just have different layer trees. 
      * platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
      * platform/mac/compositing/rtl: Added.
      * platform/mac/compositing/rtl/rtl-fixed-expected.txt: Added.
      * platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b20219a
    • commit-queue@webkit.org's avatar
      Prevent workers from calling back into other worlds · 41cab7c7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96790
      
      Patch by Dan Carney <dcarney@google.com> on 2012-09-14
      Reviewed by Adam Barth.
      
      Added a few sanity checks to ensure callbacks are always using the correct world.
      
      No new tests. No new change in functionality.
      
      * bindings/v8/V8DOMWrapper.cpp:
      (WebCore::V8DOMWrapper::getEventListener):
      * bindings/v8/V8LazyEventListener.cpp:
      (WebCore::V8LazyEventListener::prepareListenerObject):
      * bindings/v8/WorldContextHandle.cpp:
      (WebCore::WorldContextHandle::WorldContextHandle):
      (WebCore::WorldContextHandle::adjustedContext):
      * bindings/v8/WorldContextHandle.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41cab7c7
    • danakj@chromium.org's avatar
      Minimize collisions when hashing pairs · a9d74b51
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96022
      
      Reviewed by Adrienne Walker.
      
      Source/WebCore:
      
      Use WTF::pairIntHash() to hash pairs of integers.
      
      * dom/Document.cpp:
      (WebCore::ImmutableAttributeDataCacheKey::hash):
      * dom/StyledElement.cpp:
      (WebCore::computePresentationAttributeCacheHash):
      * platform/graphics/Gradient.cpp:
      (WebCore::Gradient::hash):
      * platform/graphics/IntPointHash.h:
      (WTF::IntPointHash::hash):
      * platform/graphics/IntRectHash.h:
      * platform/graphics/IntSizeHash.h:
      * platform/graphics/blackberry/LayerTileIndex.h:
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::SubimageCacheHash::hash):
      
      Source/WebKit/blackberry:
      
      Use WTF::pairIntHash() to hash a pair of integers.
      
      * WebKitSupport/TileIndexHash.h:
      
      Source/WTF:
      
      The current hash function for pairs has poor performance as it does a
      nice hash function on 64 bits, but then just drops the top 32 bits. The
      hash method for pairs tries to use Thomas Wang's 64 bit Mix Function,
      but this requires not dropping any bits in order to retain the
      characteristics mentioned by Thomas.
      
      A better method of hashing sets of 32-bit integers is to use
      multiplication in 64 bits with random integers. This method is a
      provably almost-universal hash function. Testing shows that this
      method decreases the time required, when compared with the current
      method, by more than 20% due to better hashing characteristics.
      
      * wtf/HashFunctions.h:
      (WTF):
      (WTF::pairIntHash):
      Implments the hashing method for a pair of unsigned integers.
      
      (WTF::PairHash::hash):
      Use pairIntHash() on the hash results of each object in the pair.
      
      (WTF::IntPairHash::hash):
      Implement an integer-specific PairHash class that does not need to
      hash each object in the pair. It uses pairIntHash on the two
      integers in the pair directly.
      
      (WTF::IntPairHash::equal):
      (IntPairHash):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9d74b51
    • rniwa@webkit.org's avatar
      Use performance.webkitNow in PerfTestRunner · e688af02
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92826
      
      Reviewed by Eric Seidel.
      
      Use performance.webkitNow with Date.now as a fallback for more accurate time measurements.
      
      * resources/runner.js:
      (PerfTestRunner._runner):
      (PerfTestRunner._perSecondRunnerIterator):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e688af02
    • commit-queue@webkit.org's avatar
      Unreviewed. Rolled DEPS. · 10ca3256
      commit-queue@webkit.org authored
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-14
      
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10ca3256
    • rwlbuis@webkit.org's avatar
      [BlackBerry] Use StringBuilder more in BlackBerry RSS classes · 34cecc60
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96820
      
      Reviewed by Antonio Gomes.
      
      Use append/appendLiteral where possible.
      
      * platform/MIMETypeRegistry.cpp:
      (WebCore::mimeTypeAssociationMap):
      * platform/network/blackberry/rss/RSSAtomParser.cpp:
      (WebCore::RSSAtomParser::parseContent):
      (WebCore::RSSAtomParser::parseAuthor):
      * platform/network/blackberry/rss/RSSGenerator.cpp:
      (WebCore::RSSGenerator::generateHtml):
      * platform/network/blackberry/rss/RSSParserBase.cpp:
      (WebCore::textFromXMLAttr):
      (WebCore::textFromXMLNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34cecc60
    • achicu@adobe.com's avatar
      [CSS Shaders] Enable anti-aliasing on the FECustomFilter · b6b4aac1
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96668
      
      Reviewed by Dean Jackson.
      
      Added multisample frame buffer for the FECustomFilter. It will try to allocate a multisample framebuffer
      with a maximum sample count of 4. At the end it will blit the samples back to the original frame buffer,
      so that we can read the pixels back.
      
      This patch uses extensions GL_ANGLE_framebuffer_multisample, GL_ANGLE_framebuffer_blit
      and GL_OES_rgb8_rgba8.
      
      No new tests, multisampling is not working in Chromium DRT and has not pixel effect on WebKit Mac.
      
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::FECustomFilter):
      (WebCore::FECustomFilter::deleteRenderBuffers):
      (WebCore):
      (WebCore::FECustomFilter::deleteMultisampleRenderBuffers):
      (WebCore::FECustomFilter::drawFilterMesh):
      (WebCore::FECustomFilter::createMultisampleBuffer):
      (WebCore::FECustomFilter::resolveMultisampleBuffer):
      (WebCore::FECustomFilter::canUseMultisampleBuffers):
      (WebCore::FECustomFilter::resizeMultisampleBuffers):
      (WebCore::FECustomFilter::resizeContext):
      * platform/graphics/filters/FECustomFilter.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6b4aac1
    • commit-queue@webkit.org's avatar
      Add in-place reload behavior to ImagesEnabled setting · d0a50678
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95478
      
      .:
      
      Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      Export WebCore::Settings::setImagesEnabled symbol.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      Store ImagesEnabled setting in CachedResourceLoader similar to
      AutoLoadImages. Move FrameLoaderClient::allowImage to after a
      CachedImage has been created and store the cache for reload if it is
      blocked.
      
      Make sure when image loads are deferred by either ImagesEnabled or
      LoadImagesAutomatically, onload is not called.
      
      Added ImagesEnabled to InternalSettings for layout tests.
      
      Tests: fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
             fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html
      
      * WebCore.exp.in:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::didBeginDocument):
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::willSendRequest):
      * loader/cache/CachedImage.cpp:
      (WebCore::CachedImage::load):
      * loader/cache/CachedImage.h:
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::didAddClient):
      * loader/cache/CachedResource.h:
      (WebCore::CachedResource::stillNeedsLoad):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::CachedResourceLoader):
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      (WebCore::CachedResourceLoader::setAutoLoadImages):
      (WebCore):
      (WebCore::CachedResourceLoader::setImagesEnabled):
      (WebCore::CachedResourceLoader::shouldDeferImageLoad):
      (WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):
      * loader/cache/CachedResourceLoader.h:
      (CachedResourceLoader):
      (WebCore::CachedResourceLoader::imagesEnabled):
      * page/Settings.cpp:
      (WebCore::setImageLoadingSettings):
      (WebCore::Settings::Settings):
      (WebCore::Settings::setLoadsImagesAutomatically):
      (WebCore::Settings::imageLoadingSettingsTimerFired):
      (WebCore::Settings::setImagesEnabled):
      * page/Settings.h:
      (Settings):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::setImagesEnabled):
      (WebCore):
      * testing/InternalSettings.h:
      (InternalSettings):
      * testing/InternalSettings.idl:
      
      Source/WebKit2:
      
      Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      Export WebCore::Settings::setImagesEnabled symbol.
      
      * win/WebKit2.def:
      
      LayoutTests:
      
      Add tests to check autoLoadImages and imagesEnabled can block
      images and can reload them in place when setting is set to unblock.
      
      image-permissions tests are updated to reflect that onerror will no
      longer be called when images are blocked.
      
      Patch by Bo Liu <boliu@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
      * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
      * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
      * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
      * platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
      * platform/chromium/permissionclient/image-permissions-expected.txt:
      * platform/chromium/permissionclient/image-permissions.html:
      * platform/chromium/permissionclient/resources/image.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0a50678
    • eae@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=96226 · 957a0d9b
      eae@chromium.org authored
      REGRESSION (r128006): Three spatial navigation tests are failing
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Fix spatial navigation regression by reverting parts of r128006.
      Specifically the change to remove the overridden boundingBox
      method in ContainerNode.
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::getUpperLeftCorner):
      (WebCore):
      (WebCore::ContainerNode::getLowerRightCorner):
      (WebCore::ContainerNode::boundingBox):
      * dom/ContainerNode.h:
      (ContainerNode):
      
      LayoutTests:
      
      Remove spatial navigation tests from Skipped list.
      
      * platform/mac/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      957a0d9b
    • commit-queue@webkit.org's avatar
      [chromium] add touch area to gestureTapDown data · da4fc77b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96806
      
      Patch by Rick Byers <rbyers@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      Add width/height for GestureTapDown as for GestureTap/LongPress so that
      we can eventually do fuzzing on it.
      * public/WebInputEvent.h:
      * src/WebInputEventConversion.cpp:
      (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da4fc77b
    • jamesr@google.com's avatar
      Unreviewed, rolling out r128627. · cd3fc72f
      jamesr@google.com authored
      http://trac.webkit.org/changeset/128627
      https://bugs.webkit.org/show_bug.cgi?id=96575
      
      Breaks indexeddb content_browsertests in chromium
      
      Source/WebCore:
      
      * Modules/indexeddb/IDBDatabase.cpp:
      (WebCore::IDBDatabase::IDBDatabase):
      (WebCore::IDBDatabase::setVersion):
      * Modules/indexeddb/IDBDatabase.h:
      (IDBDatabase):
      
      LayoutTests:
      
      * http/tests/inspector/indexeddb/database-data-expected.txt:
      * http/tests/inspector/indexeddb/database-structure-expected.txt:
      * http/tests/inspector/indexeddb/resources-panel-expected.txt:
      * storage/indexeddb/create-and-remove-object-store-expected.txt:
      * storage/indexeddb/create-object-store-options-expected.txt:
      * storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
      * storage/indexeddb/createObjectStore-null-name-expected.txt:
      * storage/indexeddb/cursor-added-bug-expected.txt:
      * storage/indexeddb/cursor-advance-expected.txt:
      * storage/indexeddb/cursor-continue-dir-expected.txt:
      * storage/indexeddb/cursor-continue-expected.txt:
      * storage/indexeddb/cursor-continue-validity-expected.txt:
      * storage/indexeddb/cursor-delete-expected.txt:
      * storage/indexeddb/cursor-inconsistency-expected.txt:
      * storage/indexeddb/cursor-index-delete-expected.txt:
      * storage/indexeddb/cursor-key-order-expected.txt:
      * storage/indexeddb/cursor-overloads-expected.txt:
      * storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
      * storage/indexeddb/cursor-primary-key-order-expected.txt:
      * storage/indexeddb/cursor-reverse-bug-expected.txt:
      * storage/indexeddb/cursor-skip-deleted-expected.txt:
      * storage/indexeddb/cursor-update-expected.txt:
      * storage/indexeddb/cursor-update-value-argument-required-expected.txt:
      * storage/indexeddb/cursor-value-expected.txt:
      * storage/indexeddb/data-corruption-expected.txt:
      * storage/indexeddb/database-basics-expected.txt:
      * storage/indexeddb/database-close-expected.txt:
      * storage/indexeddb/database-closepending-flag-expected.txt:
      * storage/indexeddb/database-deletepending-flag-expected.txt:
      * storage/indexeddb/delete-closed-database-object-expected.txt:
      * storage/indexeddb/delete-range-expected.txt:
      * storage/indexeddb/deleteIndex-expected.txt:
      * storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
      * storage/indexeddb/deleteObjectStore-null-name-expected.txt:
      * storage/indexeddb/deleted-objects-expected.txt:
      * storage/indexeddb/deletedatabase-transaction-expected.txt:
      * storage/indexeddb/duplicates-expected.txt:
      * storage/indexeddb/error-causes-abort-by-default-expected.txt:
      * storage/indexeddb/exception-in-event-aborts-expected.txt:
      * storage/indexeddb/exceptions-expected.txt:
      * storage/indexeddb/factory-deletedatabase-expected.txt:
      * storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
      * storage/indexeddb/get-keyrange-expected.txt:
      * storage/indexeddb/index-basics-expected.txt:
      * storage/indexeddb/index-basics-workers-expected.txt:
      * storage/indexeddb/index-count-expected.txt:
      * storage/indexeddb/index-cursor-expected.txt:
      * storage/indexeddb/index-duplicate-keypaths-expected.txt:
      * storage/indexeddb/index-get-key-argument-required-expected.txt:
      * storage/indexeddb/index-multientry-expected.txt:
      * storage/indexeddb/index-population-expected.txt:
      * storage/indexeddb/index-unique-expected.txt:
      * storage/indexeddb/intversion-and-setversion-expected.txt:
      * storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
      * storage/indexeddb/intversion-long-queue-expected.txt:
      * storage/indexeddb/invalid-keys-expected.txt:
      * storage/indexeddb/key-generator-expected.txt:
      * storage/indexeddb/key-sort-order-across-types-expected.txt:
      * storage/indexeddb/key-sort-order-date-expected.txt:
      * storage/indexeddb/key-type-array-expected.txt:
      * storage/indexeddb/key-type-infinity-expected.txt:
      * storage/indexeddb/keypath-arrays-expected.txt:
      * storage/indexeddb/keypath-basics-expected.txt:
      * storage/indexeddb/keypath-edges-expected.txt:
      * storage/indexeddb/keypath-fetch-key-expected.txt:
      * storage/indexeddb/keypath-intrinsic-properties-expected.txt:
      * storage/indexeddb/lazy-index-population-expected.txt:
      * storage/indexeddb/legacy-constants-expected.txt:
      * storage/indexeddb/list-ordering-expected.txt:
      * storage/indexeddb/metadata-expected.txt:
      * storage/indexeddb/mozilla/add-twice-failure-expected.txt:
      * storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
      * storage/indexeddb/mozilla/bad-keypath-expected.txt:
      * storage/indexeddb/mozilla/clear-expected.txt:
      * storage/indexeddb/mozilla/create-index-unique-expected.txt:
      * storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
      * storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
      * storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
      * storage/indexeddb/mozilla/cursor-mutation-expected.txt:
      * storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
      * storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
      * storage/indexeddb/mozilla/cursors-expected.txt:
      * storage/indexeddb/mozilla/delete-result-expected.txt:
      * storage/indexeddb/mozilla/event-source-expected.txt:
      * storage/indexeddb/mozilla/global-data-expected.txt:
      * storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
      * storage/indexeddb/mozilla/indexes-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
      * storage/indexeddb/mozilla/object-cursors-expected.txt:
      * storage/indexeddb/mozilla/object-identity-expected.txt:
      * storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
      * storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
      * storage/indexeddb/mozilla/objectstorenames-expected.txt:
      * storage/indexeddb/mozilla/odd-result-order-expected.txt:
      * storage/indexeddb/mozilla/put-get-values-expected.txt:
      * storage/indexeddb/mozilla/readonly-transactions-expected.txt:
      * storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
      * storage/indexeddb/mozilla/readyState-expected.txt:
      * storage/indexeddb/mozilla/remove-index-expected.txt:
      * storage/indexeddb/mozilla/remove-objectstore-expected.txt:
      * storage/indexeddb/mozilla/versionchange-abort-expected.txt:
      * storage/indexeddb/mozilla/versionchange-expected.txt:
      * storage/indexeddb/mutating-cursor-expected.txt:
      * storage/indexeddb/noblobs-expected.txt:
      * storage/indexeddb/objectStore-required-arguments-expected.txt:
      * storage/indexeddb/objectstore-autoincrement-expected.txt:
      * storage/indexeddb/objectstore-basics-expected.txt:
      * storage/indexeddb/objectstore-basics-workers-expected.txt:
      * storage/indexeddb/objectstore-clear-expected.txt:
      * storage/indexeddb/objectstore-count-expected.txt:
      * storage/indexeddb/objectstore-cursor-expected.txt:
      * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
      * storage/indexeddb/odd-strings-expected.txt:
      * storage/indexeddb/open-close-version-expected.txt:
      * storage/indexeddb/open-cursor-expected.txt:
      * storage/indexeddb/open-during-transaction-expected.txt:
      * storage/indexeddb/opencursor-key-expected.txt:
      * storage/indexeddb/pending-activity-expected.txt:
      * storage/indexeddb/pending-activity-workers-expected.txt:
      * storage/indexeddb/pending-version-change-on-exit-expected.txt:
      * storage/indexeddb/persistence-expected.txt:
      * storage/indexeddb/prefetch-bugfix-108071-expected.txt:
      * storage/indexeddb/queued-commands-expected.txt:
      * storage/indexeddb/readonly-expected.txt:
      * storage/indexeddb/readonly-properties-expected.txt:
      * storage/indexeddb/request-continue-abort-expected.txt:
      * storage/indexeddb/request-event-propagation-expected.txt:
      * storage/indexeddb/setVersion-null-expected.txt:
      * storage/indexeddb/set_version_blocked-expected.txt:
      * storage/indexeddb/set_version_queue-expected.txt:
      * storage/indexeddb/structured-clone-expected.txt:
      * storage/indexeddb/three-setversion-calls-expected.txt:
      * storage/indexeddb/transaction-abort-expected.txt:
      * storage/indexeddb/transaction-active-flag-expected.txt:
      * storage/indexeddb/transaction-after-close-expected.txt:
      * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
      * storage/indexeddb/transaction-basics-expected.txt:
      * storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
      * storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
      * storage/indexeddb/transaction-complete-workers-expected.txt:
      * storage/indexeddb/transaction-crash-on-abort-expected.txt:
      * storage/indexeddb/transaction-error-expected.txt:
      * storage/indexeddb/transaction-event-propagation-expected.txt:
      * storage/indexeddb/transaction-read-only-expected.txt:
      * storage/indexeddb/transaction-rollback-expected.txt:
      * storage/indexeddb/transaction-storeNames-required-expected.txt:
      * storage/indexeddb/tutorial-expected.txt:
      * storage/indexeddb/two-version-changes-expected.txt:
      * storage/indexeddb/value-undefined-expected.txt:
      * storage/indexeddb/values-odd-types-expected.txt:
      * storage/indexeddb/version-change-abort-expected.txt:
      * storage/indexeddb/version-change-exclusive-expected.txt:
      * storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd3fc72f