1. 13 May, 2011 40 commits
    • oliver@apple.com's avatar
      Build fix. · 14c5dd6c
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14c5dd6c
    • oliver@apple.com's avatar
      2011-05-13 Oliver Hunt <oliver@apple.com> · d369c8cd
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Make GC validation more aggressive
              https://bugs.webkit.org/show_bug.cgi?id=60802
      
              This patch makes the checks performed under GC_VALIDATION
              much more aggressive, and adds the checks to more places
              in order to allow us to catch GC bugs much closer to the
              point of failure.
      
              * JavaScriptCore.exp:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * debugger/DebuggerActivation.cpp:
              (JSC::DebuggerActivation::visitChildren):
              * heap/MarkedBlock.cpp:
              (JSC::MarkedBlock::MarkedBlock):
              * heap/MarkedSpace.cpp:
              * runtime/Arguments.cpp:
              (JSC::Arguments::visitChildren):
              * runtime/Executable.cpp:
              (JSC::EvalExecutable::visitChildren):
              (JSC::ProgramExecutable::visitChildren):
              (JSC::FunctionExecutable::visitChildren):
              * runtime/Executable.h:
              * runtime/GetterSetter.cpp:
              (JSC::GetterSetter::visitChildren):
              * runtime/GetterSetter.h:
              * runtime/JSAPIValueWrapper.h:
              (JSC::JSAPIValueWrapper::createStructure):
              (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
              * runtime/JSActivation.cpp:
              (JSC::JSActivation::visitChildren):
              * runtime/JSArray.cpp:
              (JSC::JSArray::visitChildren):
              * runtime/JSCell.cpp:
              (JSC::slowValidateCell):
              * runtime/JSCell.h:
              (JSC::JSCell::JSCell::unvalidatedStructure):
              (JSC::JSCell::JSCell::JSCell):
              * runtime/JSFunction.cpp:
              (JSC::JSFunction::visitChildren):
              * runtime/JSGlobalObject.cpp:
              (JSC::JSGlobalObject::visitChildren):
              (JSC::slowValidateCell):
              * runtime/JSONObject.h:
              * runtime/JSObject.cpp:
              (JSC::JSObject::visitChildren):
              * runtime/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::visitChildren):
              * runtime/JSPropertyNameIterator.h:
              * runtime/JSStaticScopeObject.cpp:
              (JSC::JSStaticScopeObject::visitChildren):
              * runtime/JSString.h:
              (JSC::RopeBuilder::JSString):
              * runtime/JSWrapperObject.cpp:
              (JSC::JSWrapperObject::visitChildren):
              * runtime/NativeErrorConstructor.cpp:
              (JSC::NativeErrorConstructor::visitChildren):
              * runtime/PropertyMapHashTable.h:
              (JSC::PropertyMapEntry::PropertyMapEntry):
              * runtime/RegExpObject.cpp:
              (JSC::RegExpObject::visitChildren):
              * runtime/ScopeChain.cpp:
              (JSC::ScopeChainNode::visitChildren):
              * runtime/ScopeChain.h:
              (JSC::ScopeChainNode::ScopeChainNode):
              * runtime/Structure.cpp:
              (JSC::Structure::Structure):
              (JSC::Structure::addPropertyTransition):
              (JSC::Structure::visitChildren):
              * runtime/Structure.h:
              (JSC::JSCell::classInfo):
              * runtime/StructureChain.cpp:
              (JSC::StructureChain::visitChildren):
              * runtime/StructureChain.h:
              * runtime/WriteBarrier.h:
              (JSC::validateCell):
              (JSC::JSCell):
              (JSC::JSGlobalObject):
              (JSC::WriteBarrierBase::set):
              (JSC::WriteBarrierBase::setMayBeNull):
              (JSC::WriteBarrierBase::setEarlyValue):
              (JSC::WriteBarrierBase::get):
              (JSC::WriteBarrierBase::operator*):
              (JSC::WriteBarrierBase::operator->):
              (JSC::WriteBarrierBase::unvalidatedGet):
              (JSC::WriteBarrier::WriteBarrier):
              * wtf/Assertions.h:
      2011-05-13  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Make GC validation more aggressive
              https://bugs.webkit.org/show_bug.cgi?id=60802
      
              This makes GC_VALIDATION much more aggressive in webcore,
              adding logic to every visitChildren method to ensure that
              the structure still has correct flags.
      
              Additionally every function generated for the dom bindings
              makes use of the new GC_VALIDATION object assertions to further
              ensure that the object appears to be sensible.
      
              * bindings/js/JSAttrCustom.cpp:
              (WebCore::JSAttr::visitChildren):
              * bindings/js/JSAudioContextCustom.cpp:
              (WebCore::JSAudioContext::visitChildren):
              * bindings/js/JSCSSRuleCustom.cpp:
              (WebCore::JSCSSRule::visitChildren):
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::JSCSSStyleDeclaration::visitChildren):
              * bindings/js/JSCanvasRenderingContextCustom.cpp:
              (WebCore::JSCanvasRenderingContext::visitChildren):
              * bindings/js/JSDOMGlobalObject.cpp:
              (WebCore::JSDOMGlobalObject::visitChildren):
              (WebCore::JSDOMGlobalObject::setInjectedScript):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::visitChildren):
              * bindings/js/JSDOMWindowShell.cpp:
              (WebCore::JSDOMWindowShell::visitChildren):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::JSEventListener):
              * bindings/js/JSEventListener.h:
              (WebCore::JSEventListener::jsFunction):
              * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
              (WebCore::JSJavaScriptAudioNode::visitChildren):
              * bindings/js/JSMessageChannelCustom.cpp:
              (WebCore::JSMessageChannel::visitChildren):
              * bindings/js/JSMessagePortCustom.cpp:
              (WebCore::JSMessagePort::visitChildren):
              * bindings/js/JSNamedNodeMapCustom.cpp:
              (WebCore::JSNamedNodeMap::visitChildren):
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::visitChildren):
              * bindings/js/JSNodeFilterCustom.cpp:
              (WebCore::JSNodeFilter::visitChildren):
              * bindings/js/JSNodeIteratorCustom.cpp:
              (WebCore::JSNodeIterator::visitChildren):
              * bindings/js/JSSVGElementInstanceCustom.cpp:
              (WebCore::JSSVGElementInstance::visitChildren):
              * bindings/js/JSSharedWorkerCustom.cpp:
              (WebCore::JSSharedWorker::visitChildren):
              * bindings/js/JSStyleSheetCustom.cpp:
              (WebCore::JSStyleSheet::visitChildren):
              * bindings/js/JSTreeWalkerCustom.cpp:
              (WebCore::JSTreeWalker::visitChildren):
              * bindings/js/JSWebGLRenderingContextCustom.cpp:
              (WebCore::JSWebGLRenderingContext::visitChildren):
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::visitChildren):
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::visitChildren):
              * bindings/js/JSXPathResultCustom.cpp:
              (WebCore::JSXPathResult::visitChildren):
              * bindings/scripts/CodeGeneratorJS.pm:
      2011-05-13  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Make GC validation more aggressive
              https://bugs.webkit.org/show_bug.cgi?id=60802
      
              Add GC_VALIDATION calls to all the JSNPObject methods.
      
              * WebProcess/Plugins/Netscape/JSNPObject.cpp:
              (WebKit::JSNPObject::invalidate):
              (WebKit::JSNPObject::callMethod):
              (WebKit::JSNPObject::callObject):
              (WebKit::JSNPObject::callConstructor):
              (WebKit::JSNPObject::getCallData):
              (WebKit::JSNPObject::getConstructData):
              (WebKit::JSNPObject::getOwnPropertySlot):
              (WebKit::JSNPObject::getOwnPropertyDescriptor):
              (WebKit::JSNPObject::put):
              (WebKit::JSNPObject::getOwnPropertyNames):
              (WebKit::JSNPObject::propertyGetter):
              (WebKit::JSNPObject::methodGetter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d369c8cd
    • andersca@apple.com's avatar
      Build fix. · 9bc6caa7
      andersca@apple.com authored
      * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bc6caa7
    • andersca@apple.com's avatar
      2011-05-13 Anders Carlsson <andersca@apple.com> · 4c8ba961
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              NPN_GetURL with a javascript: URL doesn't send back the result in the stream
              https://bugs.webkit.org/show_bug.cgi?id=60810
      
              In NetscapePluginStream::sendJavaScriptStream, we were incorrectly passing the result URL
              to the stream, instead of the result. Also, store the request URL in the NetscapePluginStream object
              to avoid sending it over the wire.
      
              * PluginProcess/PluginControllerProxy.cpp:
              (WebKit::PluginControllerProxy::didEvaluateJavaScript):
              * PluginProcess/PluginControllerProxy.h:
              * PluginProcess/PluginControllerProxy.messages.in:
              * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
              (WebKit::NetscapePlugin::loadURL):
              (WebKit::NetscapePlugin::didEvaluateJavaScript):
              (WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
              * WebProcess/Plugins/Netscape/NetscapePlugin.h:
              * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
              (WebKit::NetscapePluginStream::NetscapePluginStream):
              (WebKit::NetscapePluginStream::sendJavaScriptStream):
              * WebProcess/Plugins/Netscape/NetscapePluginStream.h:
              (WebKit::NetscapePluginStream::create):
              * WebProcess/Plugins/Plugin.h:
              * WebProcess/Plugins/PluginProxy.cpp:
              (WebKit::PluginProxy::didEvaluateJavaScript):
              * WebProcess/Plugins/PluginProxy.h:
              * WebProcess/Plugins/PluginView.cpp:
              (WebKit::PluginView::performJavaScriptURLRequest):
      2011-05-13  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
      
              NPN_GetURL with a javascript: URL doesn't send back the result in the stream
              https://bugs.webkit.org/show_bug.cgi?id=60810
      
              Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
      
              * plugins/get-url-with-javascript-url-expected.txt: Added.
              * plugins/get-url-with-javascript-url.html: Added.
      2011-05-13  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
      
              NPN_GetURL with a javascript: URL doesn't send back the result in the stream
              https://bugs.webkit.org/show_bug.cgi?id=60810
      
              Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
      
              * DumpRenderTree/DumpRenderTree.gypi:
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
              * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
              * GNUmakefile.am:
              Add files.
      
              * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
              * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
              Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
      
              * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
              (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
              (GetURLWithJavaScriptURL::NPP_New):
              (GetURLWithJavaScriptURL::NPP_NewStream):
              (GetURLWithJavaScriptURL::NPP_DestroyStream):
              (GetURLWithJavaScriptURL::NPP_WriteReady):
              (GetURLWithJavaScriptURL::NPP_Write):
              * DumpRenderTree/TestNetscapePlugIn/main.cpp:
              (NPP_NewStream):
              (NPP_WriteReady):
              (NPP_Write):
              (NPP_URLNotify):
              call the PluginTest NPP wrappers.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c8ba961
    • commit-queue@webkit.org's avatar
      2011-05-13 Mark Pilgrim <pilgrim@chromium.org> · 1bee0824
      commit-queue@webkit.org authored
              Reviewed by Tony Chang.
      
              Port Mozilla's IndexedDB tests: remove objectstore
              https://bugs.webkit.org/show_bug.cgi?id=60768
      
              This test creates an objectstore, populates it with 100 records,
              deletes the objectstore, and checks that the objectStoreNames array
              is updated properly at each step.
      
              * storage/indexeddb/mozilla/remove-objectstore-expected.txt: Added.
              * storage/indexeddb/mozilla/remove-objectstore.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bee0824
    • atwilson@chromium.org's avatar
      Removed chromium border-fit-lines.html suppression as it seems to pass now. Unreviewed. · 353d4773
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      353d4773
    • commit-queue@webkit.org's avatar
      2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com> · 725013a7
      commit-queue@webkit.org authored
              Unreviewed, rolling out r86447.
              http://trac.webkit.org/changeset/86447
              https://bugs.webkit.org/show_bug.cgi?id=60809
      
              "Broke some uses of EventSender object on Qt" (Requested by
              mwenge on #webkit).
      
              * platform/qt/Skipped:
              * platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Removed.
      2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r86447.
              http://trac.webkit.org/changeset/86447
              https://bugs.webkit.org/show_bug.cgi?id=60809
      
              "Broke some uses of EventSender object on Qt" (Requested by
              mwenge on #webkit).
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r86447.
              http://trac.webkit.org/changeset/86447
              https://bugs.webkit.org/show_bug.cgi?id=60809
      
              "Broke some uses of EventSender object on Qt" (Requested by
              mwenge on #webkit).
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::initJSObjects):
              (WebCore::DumpRenderTree::createWindow):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              (WebCore::DumpRenderTree::eventSender):
              * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
              (webkit_test_plugin_new_instance):
              (webkit_test_plugin_set_window):
              (webkit_test_plugin_handle_event):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      725013a7
    • mnaganov@chromium.org's avatar
      2011-05-13 Mikhail Naganov <mnaganov@chromium.org> · c2bcfc8b
      mnaganov@chromium.org authored
              Web Inspector: Unreviewed image glyph position fix in CSS after r85588.
      
              * inspector/front-end/heapProfiler.css:
              (.heapshot-help-status-bar-item .glyph):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2bcfc8b
    • abarth@webkit.org's avatar
      2011-05-13 Adam Barth <abarth@webkit.org> · 56813fa6
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              iframe sandbox doesn't properly block popups
              https://bugs.webkit.org/show_bug.cgi?id=60784
      
              Test that we block popup windows from inside sandbox.
      
              * http/tests/security/no-popup-from-sandbox-expected.txt: Added.
              * http/tests/security/no-popup-from-sandbox-top-expected.txt: Added.
              * http/tests/security/no-popup-from-sandbox-top.html: Added.
              * http/tests/security/no-popup-from-sandbox.html: Added.
      2011-05-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              iframe sandbox doesn't properly block popups
              https://bugs.webkit.org/show_bug.cgi?id=60784
      
              Previously, we weren't implementing this requirement from the spec:
      
              "This flag also prevents content from creating new auxiliary browsing
              contexts, e.g. using the target attribute or the window.open() method."
      
              Tests: http/tests/security/no-popup-from-sandbox-top.html
                     http/tests/security/no-popup-from-sandbox.html
      
              * loader/PolicyChecker.cpp:
              (WebCore::PolicyChecker::checkNewWindowPolicy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56813fa6
    • rniwa@webkit.org's avatar
      2011-05-13 Ryosuke Niwa <rniwa@webkit.org> · 91cc070e
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              click event shouldn't fire when the target is ever removed in mouseup
              https://bugs.webkit.org/show_bug.cgi?id=60600
      
              Added tests to ensure WebKit does not fire click event when the target node
              is removed in mouseup event.
      
              * fast/events/remove-target-in-mouseup-deep-expected.txt: Added.
              * fast/events/remove-target-in-mouseup-deep.html: Added.
              * fast/events/remove-target-in-mouseup-expected.txt: Added.
              * fast/events/remove-target-in-mouseup-insertback-expected.txt: Added.
              * fast/events/remove-target-in-mouseup-insertback.html: Added.
              * fast/events/remove-target-in-mouseup-twice-expected.txt: Added.
              * fast/events/remove-target-in-mouseup-twice.html: Added.
              * fast/events/remove-target-in-mouseup.html: Added.
      2011-05-13  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              click event shouldn't fire when the target is ever removed in mouseup
              https://bugs.webkit.org/show_bug.cgi?id=60600
      
              Fixed the bug by invalidating m_clickNode when it or one of its ancestors has been removed
              from the document. New behavior matches Internet Explorer and Firefox.
      
              Tests: fast/events/remove-target-in-mouseup-deep.html
                     fast/events/remove-target-in-mouseup-insertback.html
                     fast/events/remove-target-in-mouseup-twice.html
                     fast/events/remove-target-in-mouseup.html
      
              * dom/Document.cpp:
              (WebCore::Document::nodeChildrenWillBeRemoved): Calls EventHandler::nodeWillBeRemoved.
              (WebCore::Document::nodeWillBeRemoved): Calls EventHandler::nodeWillBeRemoved.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::nodeWillBeRemoved): Added; invalidates m_clickNode when m_clickNode
              or one of its ancestor is removed from the document.
              * page/EventHandler.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91cc070e
    • ap@apple.com's avatar
      Reviewed by Joseph Pecoraro. · 05fdb04b
      ap@apple.com authored
              Hide appcache status bar items
              https://bugs.webkit.org/show_bug.cgi?id=60799
      
              We have a number of non-trivial bugs that make these more misleading than helpful to developers.
      
              * inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView):
              Just hide the items for now. Removing all support code would be complicated, and not helpful.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05fdb04b
    • jeffm@apple.com's avatar
      2011-05-13 Jeff Miller <jeffm@apple.com> · 7bea0541
      jeffm@apple.com authored
              Reviewed by Darin Adler.
      
              Make some page() member functions const
              https://bugs.webkit.org/show_bug.cgi?id=60794
      
              * UIProcess/ChunkedUpdateDrawingAreaProxy.h: Make page() const.
              * UIProcess/WebFrameProxy.h:
              (WebKit::WebFrameProxy::page): Make page() const.
              * UIProcess/WebInspectorProxy.h:
              (WebKit::WebInspectorProxy::page): Make page() const.
              * UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:
              (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
              * UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
              (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
              * UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
              (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
              * UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:
              (WebKit::ChunkedUpdateDrawingAreaProxy::page): Make page() const.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bea0541
    • abarth@webkit.org's avatar
      2011-05-13 Adam Barth <abarth@webkit.org> · c46976c3
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              indexedDB is visible inside iframe sandbox
              https://bugs.webkit.org/show_bug.cgi?id=60785
      
              * http/tests/security/no-indexeddb-from-sandbox-expected.txt: Added.
              * http/tests/security/no-indexeddb-from-sandbox.html: Added.
      2011-05-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              indexedDB is visible inside iframe sandbox
              https://bugs.webkit.org/show_bug.cgi?id=60785
      
              We're supposed to return a null indexedDB factory when inside an iframe
              sandbox.
      
              Test: http/tests/security/no-indexeddb-from-sandbox.html
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::webkitIndexedDB):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c46976c3
    • commit-queue@webkit.org's avatar
      2011-05-13 Mark Pilgrim <pilgrim@chromium.org> · 0cad0fe3
      commit-queue@webkit.org authored
              Reviewed by Tony Chang.
      
              Port Mozilla's IndexedDB tests: indexes with keys and key ranges
              https://bugs.webkit.org/show_bug.cgi?id=60733
      
              This megatest creates an object store with several rows of data,
              creates indexes on each key, then iterates each index in a variety
              of ways (keys, key ranges, etc).
      
              * storage/indexeddb/mozilla/indexes-expected.txt: Added.
              * storage/indexeddb/mozilla/indexes.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cad0fe3
    • aroben@apple.com's avatar
      Load plugins in the order they're found · 937468a0
      aroben@apple.com authored
      Fixes <http://webkit.org/b/60788> <rdar://problem/9435787> REGRESSION (r69790): WebKit2
      doesn't prefer plugins in the additional plugins directory
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/Plugins/PluginInfoStore.cpp:
      (WebKit::addFromVector):
      Changed to use a ListHashSet instead of a HashSet to store the plugin paths.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      937468a0
    • aroben@apple.com's avatar
      Fix manual tests that got broken by the move of WebCore into Source · 23768d21
      aroben@apple.com authored
      * manual-tests/plugins/object-clipping.html:
      * manual-tests/pointer-events.html:
      * manual-tests/video-waiting-seeking.html:
      Updated some paths.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23768d21
    • commit-queue@webkit.org's avatar
      2011-05-13 Nat Duca <nduca@chromium.org> · 920a1b69
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              [chromium] compositing tests are failing
              https://bugs.webkit.org/show_bug.cgi?id=60738
      
              Remove supression for previously failing compositor tests.
      
              * platform/chromium/test_expectations.txt:
      2011-05-13  Nat Duca  <nduca@chromium.org>
      
              Reviewed by James Robinson.
      
              [chromium] compositing tests are failing
              https://bugs.webkit.org/show_bug.cgi?id=60738
      
              Bind texture before setting its filtering state.
      
              * platform/graphics/chromium/LayerTilerChromium.cpp:
              (WebCore::LayerTilerChromium::updateFromPixels):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      920a1b69
    • ap@apple.com's avatar
      Reviewed by Dan Bernstein. · e3f870c8
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=60787
              Add some assertions to ApplicationCacheGroup
      
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Check that count doesn't underflow.
              (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
              (WebCore::ApplicationCacheGroup::stopLoading): Check that we are the handle's client before
              resetting it.
              (WebCore::ApplicationCacheGroup::update): Check that there isn't a stale current handle or
              resource hanging around.
              (WebCore::ApplicationCacheGroup::didFail): Check that the handle is either manifest or current one.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3f870c8
    • commit-queue@webkit.org's avatar
      2011-05-13 Tao Bai <michaelbai@chromium.org> · 946fd683
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              Handle the touch icon.
              https://bugs.webkit.org/show_bug.cgi?id=60247
      
              Added WebIconURL for the corresponding IconURL.
              Added method iconURLs() to specify the type of icon need to return.
              The favIconURL() is deprecated and will be removed later.
      
              * WebKit.gyp:
              * features.gypi:
              * public/WebFrame.h:
              * public/WebFrameClient.h:
              (WebKit::WebFrameClient::didChangeIcons):
              * public/WebIconURL.h: Added.
              (WebKit::WebIconURL::WebIconURL):
              (WebKit::WebIconURL::iconType):
              (WebKit::WebIconURL::iconURL):
              * src/AssertMatchingEnums.cpp:
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::favIconURL):
              * src/WebFrameImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      946fd683
    • weinig@apple.com's avatar
      2011-05-13 Sam Weinig <sam@webkit.org> · c5b2001d
      weinig@apple.com authored
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * src/AutoFillPopupMenuClient.cpp:
              * src/PlatformBridge.cpp:
              * src/WebPopupMenuImpl.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * Api/qgraphicswebview.cpp:
              * WebCoreSupport/ChromeClientQt.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebCoreSupport/GtkAdjustmentWatcher.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebCoreSupport/WebChromeClient.cpp:
              * WebCoreSupport/WebDragClient.cpp:
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              * WebFrame.cpp:
              (WebFrame::setPrinting):
              * WebView.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebView/WebClipView.mm:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Replace #includes in FrameView.h of Frame.h and Page.h
                with Color.h, wtf/text/WTFString.h, and the new AdjustViewSizeOrNot.h
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * GNUmakefile.list.am:
              * WebCore.exp.in:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/AccessibilityRenderObject.cpp:
              * accessibility/AccessibilityScrollView.cpp:
              * accessibility/chromium/AXObjectCacheChromium.cpp:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              * css/MediaQueryMatcher.cpp:
              * dom/Range.cpp:
              * editing/SpellingCorrectionController.cpp:
              * history/CachedFrame.cpp:
              * html/HTMLBodyElement.cpp:
              * html/canvas/WebGLRenderingContext.cpp:
              * html/parser/HTMLParserScheduler.cpp:
              * page/AdjustViewSizeOrNot.h: Added.
              * page/EditorClient.h:
              * page/Frame.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::forceLayoutForPagination):
              * page/FrameView.h:
              * page/PrintContext.cpp:
              (WebCore::PrintContext::begin):
              (WebCore::PrintContext::end):
              * page/chromium/FrameChromium.cpp:
              * page/win/FrameCGWin.cpp:
              * page/win/FrameWin.cpp:
              * platform/efl/PopupMenuEfl.cpp:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
              * platform/gtk/WidgetGtk.cpp:
              * plugins/IFrameShimSupport.cpp:
              * rendering/RenderBlock.cpp:
              * rendering/RenderBoxModelObject.cpp:
              * rendering/RenderFrameBase.cpp:
              * rendering/RenderIFrame.cpp:
              * rendering/RenderMenuList.cpp:
              * rendering/RenderTextControlSingleLine.cpp:
              * rendering/RenderWidget.cpp:
              * svg/SVGSVGElement.cpp:
      2011-05-13  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Prune #includes from FrameView.h (Part 2)
              https://bugs.webkit.org/show_bug.cgi?id=60748
      
              - Update files that were depending on FrameView.h #including Frame.h or
                Page.h.
      
              * WebProcess/Plugins/PluginView.cpp:
              * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
              * WebProcess/WebPage/WebContextMenu.cpp:
              * WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5b2001d
    • atwilson@chromium.org's avatar
      Suppress crasher in chromium. Unreviewed. · ae7323f2
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae7323f2
    • leviw@chromium.org's avatar
      2011-05-13 Levi Weintraub <leviw@chromium.org> · 649a5eb7
      leviw@chromium.org authored
              Reviewed by Eric Seidel.
      
              Switch paintCollapsedBorder to use IntRect
              https://bugs.webkit.org/show_bug.cgi?id=60739
      
              Updating the last offending paint function that takes four ints
              instead of an IntRect.
      
              No new tests as this is simple refactoring.
      
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paint):
              (WebCore::RenderTableCell::paintCollapsedBorder):
              * rendering/RenderTableCell.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      649a5eb7
    • inferno@chromium.org's avatar
      2011-05-13 Abhishek Arya <inferno@chromium.org> · 28ed1a04
      inferno@chromium.org authored
              Reviewed by Dave Hyatt.
      
              Regression(r75823): Revert initialization back to the first RenderBlock
              in the parent chain.
              https://bugs.webkit.org/show_bug.cgi?id=60780
      
              Test: fast/block/float/float-not-removed-crash.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
              In r75823, I forgot to initialize parentBlock, when the original code
              did and Hyatt did mention in c#5. Now, initializing parentBlock to the
              first RenderBlock in the parent chain.
      2011-05-13  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              Tests that we do not crash when trying to access a deleted float.
              https://bugs.webkit.org/show_bug.cgi?id=60780
      
              * fast/block/float/float-not-removed-crash-expected.txt: Added.
              * fast/block/float/float-not-removed-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28ed1a04
    • robert@webkit.org's avatar
      2011-05-13 Robert Hogan <robert@webkit.org> · cb31a816
      robert@webkit.org authored
              Reviewed by Benjamin Poulain.
      
              [Qt] fix http/tests/plugins/plugin-document-has-focus.html
      
              For some reason the platform-independent expected result has
              no newline at the end of the file. The unix test plugin also
              reports the event from a different line. These are harmless
              differences, so create platform-specific result.
      
              Note that nearly every platform skips this test at the moment.
      
              https://bugs.webkit.org/show_bug.cgi?id=60722
      
              * platform/qt/Skipped:
              * platform/qt/http/tests/plugins/plugin-document-has-focus-expected.txt: Added.
      2011-05-13  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Benjamin Poulain.
      
              [Qt] fix http/tests/plugins/plugin-document-has-focus.html
              https://bugs.webkit.org/show_bug.cgi?id=60722
      
              QWebPage::setView() will display the browser window, so
              implement a private version that does just enough to
              satisfy EventSender's requirement to install an event
              filter on a page's web view.
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::setView):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-05-13  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Benjamin Poulain.
      
              [Qt] fix http/tests/plugins/plugin-document-has-focus.html
      
              The support for this test added to the unix test plugin here
              may allow other platforms to pass it (nearly everyone
              skips it). On Qt it required a bit of trickiness with
              the page's EventSender object to get it working fully though,
              so only unskipping Qt here.
      
              https://bugs.webkit.org/show_bug.cgi?id=60722
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::WebPage::eventSender):
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::initJSObjects):
              (WebCore::DumpRenderTree::createWindow):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
              (webkit_test_plugin_new_instance):
              (webkit_test_plugin_set_window):
              (webkit_test_plugin_handle_event):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb31a816
    • podivilov@chromium.org's avatar
      2011-05-05 Pavel Podivilov <podivilov@chromium.org> · 0100aa66
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: TextEditor should support editing a range.
              https://bugs.webkit.org/show_bug.cgi?id=59688
      
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
              (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
              (WebInspector.TextEditorMainPanel.prototype.setEditableRange):
              (WebInspector.TextEditorMainPanel.prototype.clearEditableRange):
              (WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine):
              (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
              (WebInspector.TextEditorMainChunk):
              (WebInspector.TextEditorMainChunk.prototype.set expanded):
              (WebInspector.TextEditorMainChunk.prototype.set readOnly):
              (WebInspector.TextEditorMainChunk.prototype.get readOnly):
              (WebInspector.TextEditorMainChunk.prototype._updateElementReadOnlyState):
              * inspector/front-end/textViewer.css:
              (.text-editor-read-only):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0100aa66
    • aroben@apple.com's avatar
      Exclude the Leopard NRWT bot from the core builder set · da8c998e
      aroben@apple.com authored
      Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
      
      Reviewed by Darin Adler.
      
      * Scripts/webkitpy/common/net/buildbot/buildbot.py:
      (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
      in the core builder set.
      
      * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
      (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
      regexps.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da8c998e
    • aroben@apple.com's avatar
      Group all the NRWT bots together · 46ee2b84
      aroben@apple.com authored
      This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
      bots are experimental, it seems best not to clutter up the non-experimental bots with
      experimental ones.
      
      Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
      on build.webkit.org
      
      Reviewed by Dan Bernstein.
      
      * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
      Chromium testers, which also use new-run-webkit-tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46ee2b84
    • podivilov@chromium.org's avatar
      2011-05-05 Pavel Podivilov <podivilov@chromium.org> · f06f4cf6
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix source mapping for formatted scripts.
              https://bugs.webkit.org/show_bug.cgi?id=60263
      
              * inspector/debugger/resources/obfuscated.js:
              (formatted1):
              (formatted2):
              * inspector/debugger/script-formatter.html:
      2011-05-05  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix source mapping for formatted scripts.
              https://bugs.webkit.org/show_bug.cgi?id=60263
      
              Source mapping is broken for script chunks that are already formatted at the beginning
              and at the end of the script (see script-formatter.html).
      
              * inspector/front-end/ScriptFormatter.js:
              (WebInspector.ScriptFormatter.prototype._didFormatContent):
              (WebInspector.FormattedSourceMapping):
              (WebInspector.FormattedSourceMapping.prototype.originalToFormatted):
              (WebInspector.FormattedSourceMapping.prototype.formattedToOriginal):
              (WebInspector.FormattedSourceMapping.prototype._convertPosition):
              * inspector/front-end/ScriptFormatterWorker.js:
              (onmessage):
              (HTMLScriptFormatter.prototype.format):
              * inspector/front-end/SourceFile.js:
              (WebInspector.FormattedSourceFile.prototype._didRequestContent):
              (WebInspector.SourceMappingForFormattedSourceFile):
              (WebInspector.SourceMappingForFormattedSourceFile.prototype.scriptLocationToSourceLine):
              (WebInspector.SourceMappingForFormattedSourceFile.prototype.sourceLineToScriptLocation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f06f4cf6
    • aroben@apple.com's avatar
      Tell ScrollView's child Widgets that their frame rects have changed when its own frame rect changes · 9f9a70a7
      aroben@apple.com authored
      r79167 moved some code from setFrameRect to setBoundsSize, including a call to
      frameRectsChanged. This was done because positionScrollbarLayers, which is called by
      frameRectsChanged, only needs to be called when the bounds change, not when the frame rect
      changes. But the recursive calls inside frameRectsChanged *do* need to be called when the
      frame rect changes.
      
      This patch moves the positionScrollbarLayers call out of frameRectsChanged, since it needs
      to be called at different times from frameRectsChanged. Then it restores the
      frameRectsChanged call to setFrameRect, which fixes the bug.
      
      Test: platform/win/plugins/iframe-inside-overflow.html
      
      Fixes <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION (r79167): Windowed
      plugins in Google Reader don't move when the article list is scrolled
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars): Added a positionScrollbarLayers call here now that
      frameRectsChanged doesn't call it for us. Also added a FIXME because it seems strange to
      call frameRectsChanged here when our frame rect hasn't changed.
      (WebCore::ScrollView::setFrameRect): Added back the frameRectsChanged call that was removed
      in r79167.
      (WebCore::ScrollView::setBoundsSize): Replaced a frameRectsChanged call with a call to
      positionScrollbarLayers. We were only calling frameRectsChanged here in order to get
      positionScrollbarLayers to be called.
      (WebCore::ScrollView::frameRectsChanged): Removed the call to positionScrollbarLayers. All
      callers of frameRectsChanged have been updated to call positionScrollbarLayers if needed.
      
      Tools:
      
      Add a plugin test that dumps the plugin window's rect
      
      * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
      (DumpWindowRect::DumpWindowRect): Just call up to the base class.
      (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
      harness window and log it.
      
      * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
      
      LayoutTests:
      
      Add a test for windowed plugins inside iframes inside scrolled overflow areas
      
      * platform/win/plugins/iframe-inside-overflow-expected.txt: Added.
      * platform/win/plugins/iframe-inside-overflow.html: Added.
      (loaded): Scrolls the div and tells the plugin to start its test (which will cause its
      window rect to be logged).
      * platform/win/plugins/resources/dump-window-rect-iframe.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f9a70a7
    • aroben@apple.com's avatar
      Move code required for most tests of plugin window geometry into a base class · 6d09c98a
      aroben@apple.com authored
      WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
      having all the trickiness in a shared base class, writing new window geometry tests will be
      much easier.
      
      Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
      
      Reviewed by Anders Carlsson.
      
      * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
      (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
      WindowGeometryTest base class. Most of the code from this class was moved to the new base
      class.
      (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
      This is called by the base class when it is safe to check the window's geometry. Note that
      the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
      just vestigial code from an earlier version of this test.
      
      * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
      WindowGeometryTest class.
      
      * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
      WindowRegionIsSetToClipRect.
      (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
      We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
      Subclasses can implement that function to perform their own tests.
      
      * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d09c98a
    • robert@webkit.org's avatar
      2011-05-02 Robert Hogan <robert@webkit.org> · 7e68d0bd
      robert@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make fast/dom/object-embed-plugin-scripting.html compatible with non-Mac ports
      
              https://bugs.webkit.org/show_bug.cgi?id=59930
      
              * fast/dom/resources/articles.m4a: Removed.
              * platform/chromium/test_expectations.txt: Unskip object-embed-plugin-scripting.html on Linux
              * platform/qt/Skipped: Unskip object-embed-plugin-scripting.html
              * plugins/object-embed-plugin-scripting-expected.txt: Renamed from LayoutTests/fast/dom/object-embed-plugin-scripting-expected.txt.
              * plugins/object-embed-plugin-scripting.html: Renamed from LayoutTests/fast/dom/object-embed-plugin-scripting.html.
              * plugins/resources/apple.gif: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e68d0bd
    • brettw@chromium.org's avatar
      2011-05-13 Brett Wilson <brettw@chromium.org> · 5bffb145
      brettw@chromium.org authored
              Reviewed by Adam Barth.
      
              Don't destroy a null FcPattern when failing to do a FontConfig match.
              This crashes, and there's nothing FcDestroy could do with a null
              pointer even if it didn't crash.
              https://bugs.webkit.org/show_bug.cgi?id=60777
      
              * src/gtk/WebFontInfo.cpp:
              (WebKit::WebFontInfo::renderStyleForStrike):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bffb145
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Fix build on MSVC. · 0e9846f4
      jocelyn.turcotte@nokia.com authored
      Reviewed by nobody, build fix.
      
      qobject_cast<> requires the class to be exported on MSVC,
      removing it since the code that needs it is commented out for
      the same reason.
      
      * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
      (tst_QDeclarativeWebView::elementAreaAt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e9846f4
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux. · 9737b0aa
      jocelyn.turcotte@nokia.com authored
      Reviewed by nobody, build fix.
      
      * tests/tests.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9737b0aa
    • mrobinson@webkit.org's avatar
      2011-05-13 Martin Robinson <mrobinson@igalia.com> · 800f02d5
      mrobinson@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=59765
      
              Move the keybinding code form WebKit1/WebKit2 to this utility class. This code is
              almost directly moved from the WebKit layer.
      
              No new tests. This is covered by the editing tests.
      
              * GNUmakefile.list.am:
              * platform/gtk/KeyBindingTranslator.cpp: Added.
              (WebCore::backspaceCallback):Added.
              (WebCore::selectAllCallback):Added.
              (WebCore::cutClipboardCallback):Added.
              (WebCore::copyClipboardCallback):Added.
              (WebCore::pasteClipboardCallback):Added.
              (WebCore::toggleOverwriteCallback):Added.
              (WebCore::popupMenuCallback):Added.
              (WebCore::showHelpCallback):Added.
              (WebCore::deleteFromCursorCallback):Added.
              (WebCore::moveCursorCallback):Added.
              (WebCore::KeyBindingTranslator::KeyBindingTranslator):Added.
              (WebCore::KeyBindingTranslator::getEditorCommandsForKeyEvent):Added.
              * platform/gtk/KeyBindingTranslator.h: Added.
              (WebCore::KeyBindingTranslator::addPendingEditorCommand):Added.
      2011-05-13  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=59765
      
              Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
              class we can now share the code with WebKit2.
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::executePendingEditorCommands): Updated to reflect the fact that
              the command vector now contains WTF::string.
              (WebKit::EditorClient::handleKeyboardEvent): Use the new helper utility class.
              (WebKit::EditorClient::EditorClient):
              * WebCoreSupport/EditorClientGtk.h: Remove unnecessary member. Add the utility class.
      2011-05-13  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=59765
      
              Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
              class we can now share the code with WebKit2.
      
              * UIProcess/API/gtk/PageClientImpl.cpp:
              (WebKit::PageClientImpl::PageClientImpl): No longer need to initialize keybinding code.
              (WebKit::PageClientImpl::getEditorCommandsForKeyEvent): Use the new utility class.
              * UIProcess/API/gtk/PageClientImpl.h: Remove unnecessary members. Add utility class member.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      800f02d5
    • antonm@chromium.org's avatar
      2011-05-13 Steve VanDeBogart <vandebo@chromium.org> · 5ed523f8
      antonm@chromium.org authored
              Unreviewed.
      
              Update expectations for GPU tests that use shadows after fix (Skia rev 1297).
              https://bugs.webkit.org/show_bug.cgi?id=60742
      
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ed523f8
    • zherczeg@webkit.org's avatar
      2011-05-13 Zoltan Herczeg <zherczeg@webkit.org> · 338e1fb6
      zherczeg@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              Missing 2nd #EOF if WebProcess is killed.
              https://bugs.webkit.org/show_bug.cgi?id=60761
      
              If the WebProcess is killed, only one #EOF is yielded
              by WebKitTestRunner. However, run-webkit-test wait for
              a second #EOF, which signals the finishing of pixel dump.
              Since this never happens, run-webkit-test waits forever.
      
              * WebKitTestRunner/TestInvocation.cpp:
              (WTR::TestInvocation::dump):
              (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
              * WebKitTestRunner/TestInvocation.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      338e1fb6
    • zecke@webkit.org's avatar
      [android] Forward declare types for PlatformWidget and DragImage · 42ff713f
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=59890
      
      This is fixing the compilation of files that include Widget.h or
      DragImage.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42ff713f
    • zecke@webkit.org's avatar
      [android] OS(ANDROID) does not imply PLATFORM(ANDROID) · e156cd77
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=59888
      
      It is possible to build QtWebKit and others for OS(ANDROID). Let
      the buildsystem decide which platform is to be build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e156cd77
    • ossy@webkit.org's avatar
      [Qt] Unreviewed fix after r86357, r86374, r86376. Skip failing tests. · 735b62a0
      ossy@webkit.org authored
      * platform/qt-wk2/Skipped: Add 4 failing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      735b62a0