1. 17 Apr, 2012 30 commits
    • schenney@chromium.org's avatar
      [Chromium] Rebaseline svg/carto.net/colourpicker.svg · 14b285cd
      schenney@chromium.org authored
      Unreviewed Chromium test expectations update.
      
      This test has been marked as failing for so long that its result is
      always wrong. Rebaselining to review flakiness.
      
      * platform/chromium-linux/svg/carto.net/colourpicker-expected.png: Added.
      * platform/chromium-linux/svg/carto.net/colourpicker-expected.txt: Removed.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14b285cd
    • schenney@chromium.org's avatar
      [Chromium] Rebaseline after fix/improve bitmap sampling (matrixproc) · 8fa50f5a
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84150
      
      Unreviewed Chromium test expectations update.
      
      * fast/repaint/background-misaligned-expected.txt: Added.
      * platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png: Added.
      * platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Added.
      * platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
      * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
      * platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
      * platform/chromium-linux/svg/custom/pattern-skew-transformed-expected.png: Added.
      * platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
      * platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Modified property svn:mime-type.
      * platform/chromium-mac-leopard/fast/gradients/background-clipped-expected.txt: Added.
      * platform/chromium-mac-leopard/fast/repaint/background-misaligned-expected.png: Added.
      * platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png:
      * platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
      * platform/chromium-mac-leopard/svg/custom/pattern-rotate-expected.png:
      * platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
      * platform/chromium-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
      * platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.txt: Added.
      * platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png:
      * platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png:
      * platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
      * platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
      * platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
      * platform/chromium-mac/fast/gradients/background-clipped-expected.txt:
      * platform/chromium-mac/fast/repaint/background-misaligned-expected.png: Modified property svn:mime-type.
      * platform/chromium-mac/fast/repaint/backgroundSizeRepaint-expected.png:
      * platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
      * platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
      * platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Added.
      * platform/chromium-mac/svg/custom/pattern-in-defs-expected.png:
      * platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
      * platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png: Modified property svn:mime-type.
      * platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
      * platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
      * platform/chromium-win-vista/fast/repaint: Added.
      * platform/chromium-win-vista/fast/repaint/background-misaligned-expected.png: Added.
      * platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png: Added.
      * platform/chromium-win-xp/svg/as-border-image: Removed.
      * platform/chromium-win/fast/repaint/background-misaligned-expected.png:
      * platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
      * platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
      * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
      * platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
      * platform/chromium-win/svg/custom/pattern-in-defs-expected.png:
      * platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
      * platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
      * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
      * platform/chromium/test_expectations.txt:
      * platform/efl/fast/repaint/background-misaligned-expected.txt: Removed.
      * platform/gtk/fast/repaint/background-misaligned-expected.txt: Removed.
      * platform/mac/fast/repaint/background-misaligned-expected.txt: Removed.
      * platform/qt/fast/repaint/background-misaligned-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fa50f5a
    • commit-queue@webkit.org's avatar
      [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks() · d25d40ba
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83030
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
      Reviewed by Antonio Gomes.
      
      Source/WebKit/efl:
      
      Implement support for LayoutTestController's dumpFrameLoadCallbacks()
      in EFL's DumpRenderTree. We no longer emit the "load,finished" signal
      from postProgressFinishedNotification() since it is already emitted
      from dispatchDidFinishLoad(). This avoids unwanted extra signals we
      prevent some tests from passing (e.g.
      http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html).
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
      (WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
      (WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
      (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
      * WebCoreSupport/FrameLoaderClientEfl.h:
      (FrameLoaderClientEfl):
      * ewk/ewk_frame.cpp:
      (ewk_frame_load_committed):
      * ewk/ewk_frame.h:
      * ewk/ewk_private.h:
      * ewk/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      (ewk_view_onload_event):
      * ewk/ewk_view.h:
      
      Tools:
      
      Implement support for LayoutTestController's dumpFrameLoadCallbacks()
      in EFL's DumpRenderTree.
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::createView):
      (DumpRenderTreeChrome::processWork):
      (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
      (DumpRenderTreeChrome::onWebViewOnloadEvent):
      (DumpRenderTreeChrome::onInsecureContentRun):
      (DumpRenderTreeChrome::onInsecureContentDisplayed):
      (DumpRenderTreeChrome::onFrameCreated):
      (DumpRenderTreeChrome::onFrameProvisionalLoad):
      (DumpRenderTreeChrome::onFrameLoadCommitted):
      (DumpRenderTreeChrome::onFrameLoadFinished):
      (DumpRenderTreeChrome::onFrameLoadError):
      * DumpRenderTree/efl/DumpRenderTreeChrome.h:
      (DumpRenderTreeChrome):
      
      LayoutTests:
      
      Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
      support in the DumpRenderTree now that it is implemented.
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d25d40ba
    • kbalazs@webkit.org's avatar
      [Qt] Unreviewed ARM build fix · c177e078
      kbalazs@webkit.org authored
      * PluginProcess/qt/PluginProcessMainQt.cpp:
      (WebKit::PluginProcessMain): Export this function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c177e078
    • commit-queue@webkit.org's avatar
      Asserts in XMLHttpRequestProgressEventThrottle · d0241e6c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81506
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
      Reviewed by Julien Chaffraix.
      
      Source/WebCore:
      
      The asserts were incorrectly triggered because suspending active DOM objects
      (which suspends the XMLHttpRequestProgressEventThrottle) doesn't stop JavaScript
      from running or suspend any running loader we may have. The previous code would
      assume those 2 cases were impossible.
      
      When XmlHttpRequest::open is called or data is received while the XmlHttpRequest object
      is suspended the object may attempt to dispatch events. This patch defers these events
      until the object is resumed.
      
      Progress events are coalesced similar to normal throttling, and readystate-change events
      are coalesced to avoid identical events emitted right after eachother.
      
      On resume the events are dispatched after a timer to avoid interfering with
      ScriptExecutionContext which is iterating over suspended objects.
      
      Test: fast/events/pagehide-xhr-open.html
      
      * xml/XMLHttpRequestProgressEventThrottle.cpp:
      (WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent):
      (WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
      (WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
      (WebCore::XMLHttpRequestProgressEventThrottle::fired):
      (WebCore::XMLHttpRequestProgressEventThrottle::suspend):
      (WebCore::XMLHttpRequestProgressEventThrottle::resume):
      * xml/XMLHttpRequestProgressEventThrottle.h:
      (XMLHttpRequestProgressEventThrottle):
      
      LayoutTests:
      
      Tests that xmlhttprequest.open does not assert in when called from onpagehide.
      
      * fast/events/pagehide-xhr-open-expected.txt: Added.
      * fast/events/pagehide-xhr-open.html: Added.
      * fast/events/resources/subframe-xmlhttprequest.html: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0241e6c
    • vsevik@chromium.org's avatar
      Web Inspector: [Chromium] Crash when inspecting empty IndexedDB object store. · ea02a220
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84035
      
      Reviewed by Pavel Feldman.
      
      Added a check that m_idbCursor is not null before calling postSuccessHandlerCallback() on it.
      
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea02a220
    • loislo@chromium.org's avatar
      Web Inspector: the fix for test after massive rename in r114271. · 57d7cab7
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84147
      
      Drive by fix. The test was renamed to heap-snapshot.html
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/heap-snapshot.html: Renamed from PerformanceTests/inspector/detailed-heapshots-smoke-test.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57d7cab7
    • commit-queue@webkit.org's avatar
      [Qt] Fix builds with force_static_libs_as_shared for non-linux builds. · e61e3b5c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83035
      
      Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-04-17
      Reviewed by Simon Hausmann.
      
      The force_static_libs_as_shared feature for the Qt port will remove
      hide_symbols from Qt's CONFIG in order to make them visible to other
      libraries again.
      
      Due to an evaluation order problem in qmake, the flags for the C++ compiler
      that are set by adding hide_symbols to the CONFIG variables get applied
      to qmake's C++ compiler flags directly and hence trying to remove these
      later will not work and cause build failures when using the force_static_libs_as_shared
      feature of the Qt port.
      
      This is fixed by removing the flags that hide the exports from the compiler flags directly.
      
      * qmake/mkspecs/features/force_static_libs_as_shared.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e61e3b5c
    • commit-queue@webkit.org's avatar
      [Qt] Zoom out on second double-tap. · f2f064b1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84145
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
      Reviewed by Simon Hausmann.
      
      * UIProcess/qt/QtViewportInteractionEngine.cpp:
      (WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
      (WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
      (WebKit::QtViewportInteractionEngine::pinchGestureStarted):
      * UIProcess/qt/QtViewportInteractionEngine.h:
      (QtViewportInteractionEngine):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2f064b1
    • reed@google.com's avatar
      Need to rebaseline these images after skia 3695 lands · fa5d0b16
      reed@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84144
      
      Unreviewed. Expectations change only
      
      
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa5d0b16
    • pfeldman@chromium.org's avatar
      Web Inspector: [regression r112413]content scripts tree outline is not added to the tab. · f62bee0f
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84146
      
      Reviewed by Vsevolod Vlasov.
      
      Adding the tree to the container.
      
      * inspector/front-end/ScriptsNavigator.js:
      (WebInspector.ScriptsNavigator):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f62bee0f
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Fix build break when CONTEXT_MENUS is disabled. · ea3b59fc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83285
      
      Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-04-17
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      * platform/ContextMenuItem.h: Remove macro around enums - needed by InjectedBundle.
      (WebCore):
      * platform/Widget.h: Remove namespace WebCore for PlatformPageClient typedef.
      
      Source/WebKit/efl:
      
      Remove WebCore namespace from PageClientEfl.
      
      * WebCoreSupport/PageClientEfl.cpp:
      (WebCore):
      * WebCoreSupport/PageClientEfl.h:
      * ewk/ewk_private.h:
      (EWKPrivate):
      * ewk/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      (_ewk_view_priv_new):
      (EWKPrivate::corePageClient):
      
      Source/WebKit2:
      
      Surround code related to context menu with ENABLE(CONTEXT_MENUS) macro.
      Add dummy functions for public API implementation related to context menu.
      
      * Shared/API/c/WKContextMenuItem.cpp:
      (WKContextMenuItemGetTypeID):
      (WKContextMenuItemCreateAsAction):
      (WKContextMenuItemCreateAsCheckableAction):
      (WKContextMenuItemCreateAsSubmenu):
      (WKContextMenuItemSeparatorItem):
      (WKContextMenuItemGetTag):
      (WKContextMenuItemGetType):
      (WKContextMenuItemCopyTitle):
      (WKContextMenuItemGetEnabled):
      (WKContextMenuItemGetChecked):
      (WKContextMenuCopySubmenuItems):
      (WKContextMenuItemGetUserData):
      (WKContextMenuItemSetUserData):
      * Shared/WebContextMenuItem.cpp:
      * Shared/WebContextMenuItem.h:
      * Shared/WebContextMenuItemData.cpp:
      * Shared/WebContextMenuItemData.h:
      * UIProcess/API/C/WKPage.cpp:
      (WKPageSetPageContextMenuClient):
      * UIProcess/WebPageContextMenuClient.cpp:
      * UIProcess/WebPageContextMenuClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit):
      * UIProcess/WebPageProxy.h:
      (WebPageProxy):
      * UIProcess/WebPageProxy.messages.in:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      (WKBundlePageSetContextMenuClient):
      * WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
      * WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.h:
      * WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp:
      * WebProcess/WebPage/WebContextMenu.cpp:
      * WebProcess/WebPage/WebContextMenu.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      (WebKit):
      (WebKit::handleMouseEvent):
      (WebKit::WebPage::mouseEvent):
      * WebProcess/WebPage/WebPage.h:
      (WebPage):
      * WebProcess/WebPage/WebPage.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea3b59fc
    • mario@webkit.org's avatar
      Unreviewed, fix wrong paths to JS resources in GTK tests. · a0e27965
      mario@webkit.org authored
      * platform/gtk/accessibility/aria-list-and-listitem.html:
      * platform/gtk/accessibility/aria-option-role.html:
      * platform/gtk/accessibility/aria-option-role-expected.txt: Fixed
      typo in the expected output.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0e27965
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening. Skipped this test because of missing test fonts. · 4204ab40
      ossy@webkit.org authored
      Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-17
      
      * platform/qt-5.0/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4204ab40
    • ossy@webkit.org's avatar
      [Qt] Rebaseline and add platform specific expectations, after r114283. · 077c41b9
      ossy@webkit.org authored
      Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-04-17
      Reviewed by Csaba Osztrogonác.
      
      * platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-expected.txt: Added.
      * platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
      * platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt: Added.
      * platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      077c41b9
    • toyoshim@chromium.org's avatar
      Unreviewed, update expectations for worker WebSocket tests · 6ea6c2c0
      toyoshim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84125
      
      Add BUGWK84125 and mark as CRASH.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ea6c2c0
    • mario@webkit.org's avatar
      Unreviewed, GTK rebaseline after r113981. · 584a6abe
      mario@webkit.org authored
      * accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-on-input-expected.txt.
      * accessibility/aria-labelledby-stay-within-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-stay-within-expected.txt.
      * platform/gtk/accessibility/aria-list-and-listitem-expected.txt: Added.
      * platform/gtk/accessibility/aria-list-and-listitem.html: Added.
      * platform/gtk/accessibility/aria-option-role-expected.txt: Added.
      * platform/gtk/accessibility/aria-option-role.html: Added.
      * platform/gtk/accessibility/lists-expected.txt: Added.
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      584a6abe
    • staikos@webkit.org's avatar
      Export the initialization function so it can be called earlier. · 89ffe0a3
      staikos@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84134
      
      Reviewed by Nikolas Zimmermann.
      
      * Api/BlackBerryGlobal.h: export globalInitialize()
      (WebKit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89ffe0a3
    • tkent@chromium.org's avatar
      Introduce an internal feature for a fixed placeholder · 6f547be3
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84009
      
      Reviewed by Hajime Morita.
      
      This change adds a framework to support fixed placeholder string for
      textfield-like <input> without the palceholder attribute support. This
      doesn't change any behavior of input types which support the
      'placeholder' attribute.
      
      According to the standard, <input type=date> doesn't support the
      'placeholder' attribute. However it is a kind of text field in WebKit
      platforms with ENABLE_CALENDAR_PICKER, and we may show something useful
      information as the default placeholder.
      
      No new tests because of no behavior changes.
      
      * html/HTMLTextFormControlElement.h:
      (HTMLTextFormControlElement): Make isPlaceholderEmpty() virtual.
      * html/HTMLInputElement.h:
      (HTMLInputElement): Overrides isPlaceholderEmpty().
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::isPlaceholderEmpty):
      Check InputType::defaultPlaceholder() if InputType::usesFixedPlaceholder().
      * html/InputType.cpp:
      (WebCore::InputType::usesFixedPlaceholder): Added. Returns false.
      (WebCore::InputType::fixedPlaceholder): Added. Returns a null string.
      * html/InputType.h:
      (InputType): Add usesFixedPlaceholder() and fixedPlaceholder().
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::updatePlaceholderText):
      Uses fixedPlaceholder() instead of strippedPlaceholder() if usesFixedPlaceholder().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f547be3
    • tkent@chromium.org's avatar
      Move some code of LocalizedNumberICU.cpp to ICULocale.cpp · 5284a78e
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84128
      
      Reviewed by Hajime Morita.
      
      No new tests. No behavior change.
      
      * WebCore.gypi: Add ICULocale.cpp
      * platform/text/ICULocale.cpp:
      Added. Move some code from LocalizedNumberICU.cpp
      * platform/text/ICULocale.h:
      (ICULocale): Add currentLocale().
      * platform/text/LocalizedNumberICU.cpp:
      (WebCore::convertToLocalizedNumber): Use ICULocale::currentLocale().
      (WebCore::convertFromLocalizedNumber): ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5284a78e
    • hausmann@webkit.org's avatar
      [Plugins] delete ws_info regardless of window mode. · 125293f9
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83004
      
      Patch by Bang Kwang min <justine.bang@samsung.com> on 2012-04-17
      Reviewed by Simon Hausmann.
      
      m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak.
      Every plugin works well after this patch without any crash.
      Additionally, change casting syntax to C++ style.
      
      * plugins/PluginView.cpp:
      (WebCore::PluginView::stop):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      125293f9
    • tkent@chromium.org's avatar
      [Chromium] Calendar Picker: Popup position is wrong when there are · 143f93b8
      tkent@chromium.org authored
      no enough space below the target date field
      https://bugs.webkit.org/show_bug.cgi?id=84007
      
      Reviewed by Hajime Morita.
      
      The popup was detached from the origin element because
      calendarPicker.js resizes its window. To fix this bug, we move the
      window position vertically when it is resized.
      
      No new tests. This is not testable in WebKit.
      
      * src/WebPagePopupImpl.cpp:
      (WebKit::PagePopupChromeClient::setWindowRect):
      If this request is just a resize and m_isPutAboveOrigin is true,
      update the vertical position so that the popup attaches to the
      origin rectangle.
      (WebKit::WebPagePopupImpl::WebPagePopupImpl):
      Initialize m_isPutAboveOrigin with false.
      (WebKit::WebPagePopupImpl::init): Set m_isPutAboveOrigin true.
      * src/WebPagePopupImpl.h:
      (WebPagePopupImpl): Add m_isPutAboveOrigin.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      143f93b8
    • tkent@chromium.org's avatar
      Calendar Picker: Support RTL layout · 9e77b414
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83668
      
      Reviewed by Hajime Morita.
      
      .:
      
      * ManualTests/forms/calendar-picker.html:
      Add Arabic parameters.
      Add <select> to select a locale.
      
      Source/WebCore:
      
      Manual test: ManualTests/forms/calendar-picker.html
      
      * Resources/calendarPicker.js:
      (layout): If params.isRTL, add dir=rtl to the body.
      (DaysTable.prototype._handleKey): Reverse Left and Right cursor keys if RTL.
      * html/shadow/CalendarPickerElement.cpp:
      (WebCore::addProperty): Add addProperty() with a bool value.
      (WebCore::CalendarPickerElement::writeDocument):
      Check the direction of the first character of localized January label,
      and pass it as isRTL property.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e77b414
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, skip tests because ENABLE(SHADOW_DOM) is disabled. · 3f73b48a
      ossy@webkit.org authored
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f73b48a
    • toyoshim@chromium.org's avatar
      Unreviewed, update chromium expectations. · 55722438
      toyoshim@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55722438
    • rniwa@webkit.org's avatar
      Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot · cb0ee099
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84068
      
      Reviewed by Eric Seidel.
      
      Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
      automatically creates the build directory if needed.
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (DownloadAndPerfTestFactory.__init__):
      (DownloadAndPerfTestWebKit2Factory.__init__):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb0ee099
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix make distcheck issues. · 602a45bb
      carlosgc@webkit.org authored
      Source/JavaScriptCore:
      
      * GNUmakefile.list.am: Add missing files.
      
      Source/WebCore:
      
      * GNUmakefile.list.am: Add missing files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      602a45bb
    • commit-queue@webkit.org's avatar
      insertedIntoDocument and insertedIntoTree should be unitifed. · 9ea0080a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82701
      
      Patch by Hajime Morrita <morrita@chromium.org> on 2012-04-16
      Reviewed by Ryosuke Niwa.
      
      Both Node::insertedIntoTree() and Node::insertedIntoDocument() are
      served as lifecycle callbacks which are invoked when a node is
      inserted into its new parent. There are also removedFromTree()
      and removedFromDocument() respectively. Considering that this pair
      of virtual functions are laid onto the hot path, it's worth
      merging them into one, to gain some speedup. Such
      unification could clarify the semantics as well.
      
      This change makes following change to merge these functions.
      
      - pulling the tree traversal out from ContainerNode to ChildNodeInsertionNotifier.
      - letting new Node::insertInto() do the job for its own, but not
        for its children and
      - Pass the parent of each insertion root as a parameter of insertedInto().
        This root node can tell inserted node where it is inserted,
        specifically whetehr the insertion is to the document or not.
      
      Same pattern is also applied to Node::removedFromDocument() and
      Node::removedFromTree(), which are factored to Node::removedFrom()
      and ChildNodeRemovalNotifier respectively.
      
      Speed up on Dromaeo/dom-modify.html is about 2%.
      Further speed-up by de-virtulization would be possible.
      
      Caveat:
      
      There is possible situation where a node need to invoke
      insertedInto() after its children is nofitied, instead of before
      that.  It was represented naturally with previous
      traversal-by-ContainerNode pattern, but is no longer simple with
      this new external traversal. To support this scenario, we
      introduced the InsertionNotificationRequest as a return value of insertedInto()
      and a supplemental hook Node::didNotifyDescendantInseretions(). See for
      example HTMLFormElement.cpp to learn how it works.
      
      No new tests. Covered by existing tests.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::parserInsertBefore):
      (WebCore::ContainerNode::removeChild):
      (WebCore::ContainerNode::parserRemoveChild):
      (WebCore::ContainerNode::removeChildren):
      (WebCore::ContainerNode::parserAddChild):
      (WebCore::updateTreeAfterInsertion):
      * dom/ContainerNode.h:
      (ContainerNode):
      (WebCore::Node::highestAncestor):
      (WebCore):
      * dom/ContainerNodeAlgorithms.cpp: Added.
      (WebCore):
      (WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
      (WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
      (WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
      (WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):
      * dom/ContainerNodeAlgorithms.h:
      (ChildNodeInsertionNotifier):
      (WebCore::ChildNodeInsertionNotifier::ChildNodeInsertionNotifier):
      (WebCore):
      (ChildNodeRemovalNotifier):
      (WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
      (WebCore::removeAllChildrenInContainer):
      (WebCore::appendChildToContainer):
      (Private):
      (WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
      (WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
      (WebCore::ChildNodeInsertionNotifier::notifyInsertedIntoDocument):
      (WebCore::ChildNodeInsertionNotifier::notify):
      (WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
      (WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
      (WebCore::ChildNodeRemovalNotifier::notify):
      * dom/DOMAllInOne.cpp:
      * dom/DocumentType.cpp:
      (WebCore::DocumentType::insertedInto):
      (WebCore::DocumentType::removedFrom):
      * dom/DocumentType.h:
      (DocumentType):
      * dom/Element.cpp:
      (WebCore::Element::insertedInto):
      (WebCore::Element::removedFrom):
      * dom/Element.h:
      (Element):
      * dom/Node.cpp:
      (WebCore::Node::insertedInto):
      (WebCore::Node::removedFrom):
      * dom/Node.h:
      (Node):
      (WebCore::Node::didNotifyDescendantInseretions):
      * dom/ProcessingInstruction.cpp:
      (WebCore::ProcessingInstruction::insertedInto):
      (WebCore::ProcessingInstruction::removedFrom):
      * dom/ProcessingInstruction.h:
      (ProcessingInstruction):
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::insertedInto):
      * dom/ScriptElement.h:
      (WebCore):
      (ScriptElement):
      * dom/ShadowTree.cpp:
      (WebCore::ShadowTree::addShadowRoot):
      (WebCore::ShadowTree::removeAllShadowRoots):
      * dom/ShadowTree.h:
      (ShadowTree):
      (ShadowRootVector):
      (WebCore::ShadowRootVector::ShadowRootVector):
      (WebCore):
      * html/FormAssociatedElement.cpp:
      (WebCore::FormAssociatedElement::insertedInto):
      (WebCore::FormAssociatedElement::removedFrom):
      (WebCore::FormAssociatedElement::formRemovedFromTree):
      * html/FormAssociatedElement.h:
      (FormAssociatedElement):
      * html/HTMLBaseElement.cpp:
      (WebCore::HTMLBaseElement::insertedInto):
      (WebCore::HTMLBaseElement::removedFrom):
      * html/HTMLBaseElement.h:
      (HTMLBaseElement):
      * html/HTMLBodyElement.cpp:
      (WebCore::HTMLBodyElement::insertedInto):
      (WebCore::HTMLBodyElement::didNotifyDescendantInseretions):
      * html/HTMLBodyElement.h:
      (HTMLBodyElement):
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::insertedInto):
      (WebCore::HTMLFormControlElement::removedFrom):
      * html/HTMLFormControlElement.h:
      (HTMLFormControlElement):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::insertedInto):
      (WebCore::HTMLFormElement::didNotifyDescendantInseretions):
      (WebCore::HTMLFormElement::removedFrom):
      * html/HTMLFormElement.h:
      (HTMLFormElement):
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::insertedInto):
      (WebCore):
      (WebCore::HTMLFrameElementBase::didNotifyDescendantInseretions):
      * html/HTMLFrameElementBase.h:
      (HTMLFrameElementBase):
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::insertedInto):
      (WebCore::HTMLFrameSetElement::removedFrom):
      * html/HTMLFrameSetElement.h:
      (HTMLFrameSetElement):
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::insertedInto):
      (WebCore::HTMLIFrameElement::removedFrom):
      * html/HTMLIFrameElement.h:
      (HTMLIFrameElement):
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::insertedInto):
      (WebCore::HTMLImageElement::removedFrom):
      * html/HTMLImageElement.h:
      (HTMLImageElement):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::insertedInto):
      (WebCore::HTMLInputElement::removedFrom):
      * html/HTMLInputElement.h:
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::insertedInto):
      (WebCore::HTMLLinkElement::removedFrom):
      * html/HTMLLinkElement.h:
      (HTMLLinkElement):
      * html/HTMLMapElement.cpp:
      (WebCore::HTMLMapElement::insertedInto):
      (WebCore::HTMLMapElement::removedFrom):
      * html/HTMLMapElement.h:
      (HTMLMapElement):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::insertedInto):
      (WebCore::HTMLMediaElement::removedFrom):
      * html/HTMLMediaElement.h:
      (HTMLMediaElement):
      * html/HTMLMetaElement.cpp:
      (WebCore::HTMLMetaElement::insertedInto):
      * html/HTMLMetaElement.h:
      (HTMLMetaElement):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::insertedInto):
      (WebCore::HTMLObjectElement::removedFrom):
      * html/HTMLObjectElement.h:
      (HTMLObjectElement):
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::insertedInto):
      * html/HTMLOptionElement.h:
      (HTMLOptionElement):
      * html/HTMLQuoteElement.cpp:
      (WebCore::HTMLQuoteElement::insertedInto):
      * html/HTMLQuoteElement.h:
      (HTMLQuoteElement):
      * html/HTMLScriptElement.cpp:
      (WebCore::HTMLScriptElement::insertedInto):
      * html/HTMLScriptElement.h:
      (HTMLScriptElement):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::insertedInto):
      * html/HTMLSelectElement.h:
      * html/HTMLSourceElement.cpp:
      (WebCore::HTMLSourceElement::insertedInto):
      * html/HTMLSourceElement.h:
      (HTMLSourceElement):
      * html/HTMLStyleElement.cpp:
      (WebCore::HTMLStyleElement::insertedInto):
      (WebCore::HTMLStyleElement::removedFrom):
      * html/HTMLStyleElement.h:
      (HTMLStyleElement):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::insertedInto):
      * html/HTMLTextFormControlElement.h:
      * html/HTMLTitleElement.cpp:
      (WebCore::HTMLTitleElement::insertedInto):
      (WebCore::HTMLTitleElement::removedFrom):
      * html/HTMLTitleElement.h:
      (HTMLTitleElement):
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::insertedInto):
      * html/HTMLTrackElement.h:
      (HTMLTrackElement):
      * mathml/MathMLMathElement.cpp:
      (WebCore::MathMLMathElement::insertedInto):
      * mathml/MathMLMathElement.h:
      (MathMLMathElement):
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::removedFrom):
      * svg/SVGElement.h:
      (SVGElement):
      * svg/SVGFEImageElement.cpp:
      (WebCore::SVGFEImageElement::insertedInto):
      (WebCore::SVGFEImageElement::removedFrom):
      * svg/SVGFEImageElement.h:
      (SVGFEImageElement):
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::insertedInto):
      (WebCore::SVGFontFaceElement::removedFrom):
      * svg/SVGFontFaceElement.h:
      (SVGFontFaceElement):
      * svg/SVGFontFaceUriElement.cpp:
      (WebCore::SVGFontFaceUriElement::insertedInto):
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGGlyphElement.cpp:
      (WebCore::SVGGlyphElement::insertedInto):
      (WebCore::SVGGlyphElement::removedFrom):
      * svg/SVGGlyphElement.h:
      (SVGGlyphElement):
      * svg/SVGHKernElement.cpp:
      (WebCore::SVGHKernElement::insertedInto):
      (WebCore::SVGHKernElement::removedFrom):
      * svg/SVGHKernElement.h:
      (SVGHKernElement):
      * svg/SVGImageElement.cpp:
      (WebCore::SVGImageElement::insertedInto):
      * svg/SVGImageElement.h:
      (SVGImageElement):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::insertedInto):
      (WebCore::SVGSVGElement::removedFrom):
      * svg/SVGSVGElement.h:
      (SVGSVGElement):
      * svg/SVGScriptElement.cpp:
      (WebCore::SVGScriptElement::insertedInto):
      * svg/SVGScriptElement.h:
      (SVGScriptElement):
      * svg/SVGStyleElement.cpp:
      (WebCore::SVGStyleElement::insertedInto):
      (WebCore::SVGStyleElement::removedFrom):
      * svg/SVGStyleElement.h:
      (SVGStyleElement):
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::insertedInto):
      (WebCore::SVGStyledElement::removedFrom):
      (WebCore::SVGStyledElement::updateRelativeLengthsInformation):
      * svg/SVGStyledElement.h:
      (SVGStyledElement):
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::buildPendingResource):
      (WebCore::SVGTRefElement::insertedInto):
      (WebCore::SVGTRefElement::removedFrom):
      * svg/SVGTRefElement.h:
      (SVGTRefElement):
      * svg/SVGTextPathElement.cpp:
      (WebCore::SVGTextPathElement::insertedInto):
      * svg/SVGTextPathElement.h:
      * svg/SVGTitleElement.cpp:
      (WebCore::SVGTitleElement::insertedInto):
      (WebCore::SVGTitleElement::removedFrom):
      * svg/SVGTitleElement.h:
      (SVGTitleElement):
      * svg/SVGUseElement.cpp:
      (WebCore::SVGUseElement::insertedInto):
      (WebCore::SVGUseElement::removedFrom):
      * svg/SVGUseElement.h:
      (SVGUseElement):
      * svg/SVGVKernElement.cpp:
      (WebCore::SVGVKernElement::insertedInto):
      (WebCore::SVGVKernElement::removedFrom):
      * svg/SVGVKernElement.h:
      (SVGVKernElement):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::insertedInto):
      (WebCore::SVGSMILElement::removedFrom):
      * svg/animation/SVGSMILElement.h:
      (SVGSMILElement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ea0080a
    • commit-queue@webkit.org's avatar
      Stack overflow in CSS parser caused by recursive stylesheet import · 3b5b6ced
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83545
      
      Patch by David Barr <davidbarr@chromium.org> on 2012-04-16
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Test: http/tests/css/css-imports-redirect-cycle.html
      
      * css/CSSImportRule.cpp:
      (WebCore::StyleRuleImport::requestStyleSheet):
      
      LayoutTests:
      
      * http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
      * http/tests/css/css-imports-redirect-cycle.css: Added.
      * http/tests/css/css-imports-redirect-cycle.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b5b6ced
    • tkent@chromium.org's avatar
      [Chromium] Fix Chromium-Mac build · 57ea3f3b
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80054
      
      * chromium/public/WebFilterOperations.h:
      (WebKit): WebFilterOperation is a struct, not a class.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57ea3f3b
  2. 16 Apr, 2012 10 commits