1. 31 Oct, 2013 40 commits
    • ap@apple.com's avatar
      Enable WebCrypto on Mac · 13a73330
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123587
      
      Reviewed by Anders Carlsson.
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig: Do it.
      
      Source/WebCore:
      
      * Configurations/FeatureDefines.xcconfig: Enable it.
      
      * bindings/js/JSCryptoAlgorithmDictionary.cpp: Build fix.
      
      * crypto/CryptoAlgorithmRegistry.cpp: (WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
      Special case empty keys to avoid upsetting HashMap.
      
      * crypto/algorithms/CryptoAlgorithmSHA1.cpp: (WebCore::CryptoAlgorithmSHA1::create):
      Build fix. Can't use make_unique, because constructor is private.
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig: Do it.
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig: Do it.
      
      LayoutTests:
      
      * TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      Only skipping on specific platforms now.
      
      * crypto: Added.
      * crypto/crypto-gc-expected.txt: Copied from LayoutTests/security/crypto-gc-expected.txt.
      * crypto/crypto-gc.html: Copied from LayoutTests/security/crypto-gc.html.
      * crypto/crypto-random-values-expected.txt: Copied from LayoutTests/security/crypto-random-values-expected.txt.
      * crypto/crypto-random-values-limits-expected.txt: Copied from LayoutTests/security/crypto-random-values-limits-expected.txt.
      * crypto/crypto-random-values-limits.html: Copied from LayoutTests/security/crypto-random-values-limits.html.
      * crypto/crypto-random-values-types-expected.txt: Copied from LayoutTests/security/crypto-random-values-types-expected.txt.
      * crypto/crypto-random-values-types.html: Copied from LayoutTests/security/crypto-random-values-types.html.
      * crypto/crypto-random-values.html: Copied from LayoutTests/security/crypto-random-values.html.
      * crypto/subtle: Added.
      * crypto/subtle/argument-conversion-expected.txt: Copied from LayoutTests/security/crypto-subtle-arguments-expected.txt.
      * crypto/subtle/argument-conversion.html: Copied from LayoutTests/security/crypto-subtle-arguments.html.
      * crypto/subtle/gc-2-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-2-expected.txt.
      * crypto/subtle/gc-2.html: Copied from LayoutTests/security/crypto-subtle-gc-2.html.
      * crypto/subtle/gc-3-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-3-expected.txt.
      * crypto/subtle/gc-3.html: Copied from LayoutTests/security/crypto-subtle-gc-3.html.
      * crypto/subtle/gc-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-expected.txt.
      * crypto/subtle/gc.html: Copied from LayoutTests/security/crypto-subtle-gc.html.
      * crypto/subtle/resources: Added.
      * crypto/subtle/resources/common.js: Copied from LayoutTests/security/resources/common.js.
      * crypto/subtle/sha-1-expected.txt: Copied from LayoutTests/security/crypto-subtle-sha1-expected.txt.
      * crypto/subtle/sha-1.html: Copied from LayoutTests/security/crypto-subtle-sha1.html.
      * security/crypto-gc-expected.txt: Removed.
      * security/crypto-gc.html: Removed.
      * security/crypto-random-values-expected.txt: Removed.
      * security/crypto-random-values-limits-expected.txt: Removed.
      * security/crypto-random-values-limits.html: Removed.
      * security/crypto-random-values-types-expected.txt: Removed.
      * security/crypto-random-values-types.html: Removed.
      * security/crypto-random-values.html: Removed.
      * security/crypto-subtle-arguments-expected.txt: Removed.
      * security/crypto-subtle-arguments.html: Removed.
      * security/crypto-subtle-gc-2-expected.txt: Removed.
      * security/crypto-subtle-gc-2.html: Removed.
      * security/crypto-subtle-gc-3-expected.txt: Removed.
      * security/crypto-subtle-gc-3.html: Removed.
      * security/crypto-subtle-gc-expected.txt: Removed.
      * security/crypto-subtle-gc.html: Removed.
      * security/crypto-subtle-sha1-expected.txt: Removed.
      * security/crypto-subtle-sha1.html: Removed.
      * security/resources/common.js: Removed.
      Moved tests from security/ to crypto/.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13a73330
    • rniwa@webkit.org's avatar
      build.webkit.org should have a clean build button · 3c4928f1
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123559
      
      Reviewed by Darin Adler.
      
      Add a new "clean" forced scheduler. When a build was created by this scheduler, CleanBuildIfScheduled
      step executes clean-build script that removes the WebKitBuild directory.
      
      Also added make-passwords-json.py which creates a fake passwords.json from config.json for testing purposes.
      
      * BuildSlaveSupport/build.webkit.org-config/make-passwords-json.py: Added.
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (CleanBuildIfScheduled): Added.
      (CleanBuildIfScheduled.start): Added. Don't do a clean build if if this build wasn't schecueld by
      the clean build scheduler.
      (DeleteStaleBuildFiles): Added.
      (DeleteStaleBuildFiles.start): Added. Don't delete stale build files if this build was scheduled by
      the clean build scheduler since everything in the WebKitBuild directory had already been removed.
      (Factory.__init__): Always add CleanBuildIfScheduled.  The step itself checks whether to run
      clean-build script or hide itself.
      (loadBuilderConfig): Added the new clean build scheduler. Also make ForceScheduler future proof; in newer
      versions of buildbot, builderNames needs to be a list of regular strings.
      * BuildSlaveSupport/clean-build: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c4928f1
    • commit-queue@webkit.org's avatar
      Underline bounds cannot be queried before underline itself is drawn · 83eb8a7c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123310
      
      Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
      Reviewed by Dean Jackson.
      
      GraphicsContext's drawLineForText function is used to draw underlines,
      strikethroughs, and overlines. Before drawing the line, this function
      modifies the bounds given to it in order to make underlines crisp. However,
      this means that it is impossible to know where an underline will be drawn
      before drawing it. This patch pulls out this adjustment computation into
      GraphicsContext::computeLineBoundsForText, then passes the result to
      drawLineForText
      
      Because there should be no observable difference, no tests need to be updated.
      
      * platform/graphics/GraphicsContext.h: Signature of new computeLineBoundsForText
      function
      * platform/graphics/blackberry/PathBlackBerry.cpp:
      (WebCore::GraphicsContext::computeLineBoundsForText): Implement new function
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::GraphicsContext::computeLineBoundsForText): Ditto
      (WebCore::GraphicsContext::drawLineForText): Use computeLineBoundsForText
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::computeLineBoundsAndAntialiasingModeForText): Static function that
      performs the actual bounds computation
      (WebCore::GraphicsContext::computeLineBoundsForText): Calls
      computeLineBoundsAndAntialiasingModeForText
      (WebCore::GraphicsContext::drawLineForText): Use new function
      * platform/graphics/wince/GraphicsContextWinCE.cpp:
      (WebCore::GraphicsContext::computeLineBoundsForText): Implement new function
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83eb8a7c
    • bdakin@apple.com's avatar
      Repro scrolling crash with scrollbars that use setPresentationValue on the · a221fc71
      bdakin@apple.com authored
      scrolling thread
      https://bugs.webkit.org/show_bug.cgi?id=123549
      -and corresponding-
      <rdar://problem/15246606>
      
      Reviewed by Brady Eidson.
      
      Here's another speculative fix. If a scrollbar was removed, we would not properly 
      inform the scrolling thread. Instead of checking supportsUpdateOnSecondaryThread() 
      before calling setScrollbarPaintersFromScrollbars(), check it from within 
      setScrollbarPaintersFromScrollbars(), and this will allow the ScrollbarPainter to 
      be properly updated.
      
      * page/scrolling/mac/ScrollingCoordinatorMac.mm:
      (WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
      * page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
      (WebCore::ScrollingStateScrollingNode::setScrollbarPaintersFromScrollbars):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a221fc71
    • ossy@webkit.org's avatar
      Unreviewed typo fix after 158386. (buildfix after r158365) · 82e55067
      ossy@webkit.org authored
      * Modules/mediastream/UserMediaRequest.cpp:
      (WebCore::UserMediaRequest::callSuccessHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82e55067
    • commit-queue@webkit.org's avatar
      Move CSS3 text decoration implementation behind ENABLE(CSS3_TEXT_DECORATION) · 897022bd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123541
      
      Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      Enabled CSS3 text decoration tests
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::renderTextDecorationStyleFlagsToCSSValue): Mapping internal
      representation to a CSSValue
      (WebCore::ComputedStyleExtractor::propertyValue): Ditto
      * css/CSSParser.cpp: Moving parsing functions behind new flag
      (WebCore::isColorPropertyID):
      (WebCore::CSSParser::parseValue):
      (WebCore::CSSParser::addTextDecorationProperty):
      (WebCore::CSSParser::parseTextDecorationSkip):
      (WebCore::CSSParser::parseTextUnderlinePosition):
      * css/CSSParser.h:
      * css/CSSPrimitiveValueMappings.h:
      * css/CSSPropertyNames.in: Marking the new properties behind new flag
      * css/CSSValueKeywords.in: Marking new values behind new flag
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
      * css/StylePropertyShorthand.cpp:
      (WebCore::shorthandForProperty): Move text decoration shorthand
      (WebCore::matchingShorthandsForLonghand):
      * css/StylePropertyShorthand.h:
      * css/StyleResolver.cpp:
      (WebCore::isValidVisitedLinkProperty):
      (WebCore::StyleResolver::applyProperty):
      * platform/graphics/GraphicsContext.h:
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::GraphicsContext::setPlatformStrokeStyle):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::drawLine):
      * platform/graphics/wince/GraphicsContextWinCE.cpp:
      (WebCore::createPen):
      * rendering/InlineFlowBox.cpp:
      * rendering/InlineFlowBox.h:
      * rendering/InlineTextBox.cpp:
      (WebCore::textDecorationStyleToStrokeStyle):
      (WebCore::computeUnderlineOffset):
      (WebCore::InlineTextBox::paintDecoration):
      * rendering/RenderObject.cpp:
      (WebCore::decorationColor):
      * rendering/RootInlineBox.cpp:
      * rendering/RootInlineBox.h:
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
      (WebCore::RenderStyle::colorIncludingFallback):
      (WebCore::RenderStyle::visitedDependentColor):
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h:
      * rendering/style/StyleRareInheritedData.cpp:
      (WebCore::StyleRareInheritedData::StyleRareInheritedData):
      (WebCore::StyleRareInheritedData::operator==):
      * rendering/style/StyleRareInheritedData.h:
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
      (WebCore::StyleRareNonInheritedData::operator==):
      * rendering/style/StyleRareNonInheritedData.h:
      
      LayoutTests:
      
      * platform/mac/TestExpectations: Enable CSS3 text decoration tests
      (since CSS3_TEXT_DECORATION is enabled by default)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      897022bd
    • commit-queue@webkit.org's avatar
      [WK2] Convert SeccompFilters to using unique_ptr instead of OwnPtr/PassOwnPtr · be85573f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122883
      
      Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-10-31
      Reviewed by Darin Adler.
      
      * Shared/linux/SeccompFilters/OpenSyscall.cpp:
      (WebKit::OpenSyscall::createFromOpenatContext):
      (WebKit::OpenSyscall::createFromCreatContext):
      (WebKit::OpenSyscall::execute):
      * Shared/linux/SeccompFilters/OpenSyscall.h:
      * Shared/linux/SeccompFilters/SeccompBroker.cpp:
      (WebKit::SIGSYSHandler):
      (WebKit::SeccompBrokerClient::dispatch):
      (WebKit::SeccompBroker::runLoop):
      * Shared/linux/SeccompFilters/SigactionSyscall.cpp:
      (WebKit::SigactionSyscall::createFromContext):
      * Shared/linux/SeccompFilters/SigactionSyscall.h:
      * Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp:
      (WebKit::SigprocmaskSyscall::createFromContext):
      * Shared/linux/SeccompFilters/SigprocmaskSyscall.h:
      * Shared/linux/SeccompFilters/Syscall.cpp:
      (WebKit::Syscall::createFromContext):
      (WebKit::Syscall::createFromDecoder):
      (WebKit::SyscallResult::createFromDecoder):
      * Shared/linux/SeccompFilters/Syscall.h:
      * Shared/linux/SeccompFilters/SyscallPolicy.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be85573f
    • ap@apple.com's avatar
      [WebCrypto] Add SHA-1 · d23ff7fa
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123582
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Tests: security/crypto-subtle-arguments.html
             security/crypto-subtle-sha1.html
      
      * WebCore.xcodeproj/project.pbxproj: Added new files.
      
      * bindings/js/JSSubtleCryptoCustom.cpp:
      (WebCore::createAlgorithmFromJSValue):
      (WebCore::sequenceOfCryptoOperationDataFromJSValue):
      (WebCore::JSSubtleCrypto::digest):
      * crypto/SubtleCrypto.idl:
      Added bindings for crypto.digest.
      
      * crypto/algorithms: Added.
      * crypto/algorithms/CryptoAlgorithmSHA1.cpp: Added.
      * crypto/algorithms/CryptoAlgorithmSHA1.h: Added.
      * crypto/mac/CryptoAlgorithmRegistryMac.cpp:
      (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register SHA-1.
      
      * crypto/mac/CryptoAlgorithmSHA1Mac.cpp: Added.
      (WebCore::CryptoAlgorithmSHA1::digest): Performs the work synchronously, because
      otherwise we'd have to copy the data first, which is crazy for something as simple
      as hashing. We can change to a dispatch queue later if we find that it's actually
      better to copy and do the work asynchronously.
      
      LayoutTests: 
      
      * security/resources/common.js: Added from Blink.
      (importTestKeys):
      (asciiToArrayBuffer):
      (printRejectedResult):
      (printAcceptedResult):
      (failAndFinishJSTest):
      
      * security/crypto-subtle-arguments-expected.txt: Added.
      * security/crypto-subtle-arguments.html: Added.
      Added tests for how bindings treat crazy arguments. Heavily based on a test from Blink.
      
      * security/crypto-subtle-sha1-expected.txt: Added.
      * security/crypto-subtle-sha1.html: Added.
      Test that SHA-1 works.
      
      * TestExpectations: Skip these tests everywhere for now.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d23ff7fa
    • ossy@webkit.org's avatar
      One more speculative buildfix after r158365. · 3269d71f
      ossy@webkit.org authored
      * Modules/mediastream/UserMediaRequest.cpp:
      (WebCore::UserMediaRequest::callSuccessHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3269d71f
    • fpizlo@apple.com's avatar
      Unreviewed, really remove CachedTranscendentalFunction.h. · 7003c5e6
      fpizlo@apple.com authored
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7003c5e6
    • fpizlo@apple.com's avatar
      Remove CachedTranscendentalFunction because caching math functions is an ugly idea · b3336c7b
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123574
      
      Source/JavaScriptCore: 
      
      Reviewed by Mark Hahnenberg.
              
      This is performance-neutral because I also make Math.cos/sin intrinsic. This means that
      we gain the "overhead" of actually computing sin and cos but we lose the overhead of
      going through the native call thunks.
              
      Caching transcendental functions is a really ugly idea. It works for SunSpider because
      that benchmark makes very predictable calls into Math.sin. But I don't believe that this
      is representative of any kind of reality, and so for sensible uses of Math.sin/cos all
      that this was doing was adding more call overhead and some hashing overhead.
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * dfg/DFGAbstractInterpreterInlines.h:
      (JSC::DFG::::executeEffects):
      * dfg/DFGBackwardsPropagationPhase.cpp:
      (JSC::DFG::BackwardsPropagationPhase::propagate):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::handleIntrinsic):
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::performNodeCSE):
      * dfg/DFGClobberize.h:
      (JSC::DFG::clobberize):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      * dfg/DFGNodeType.h:
      * dfg/DFGPredictionPropagationPhase.cpp:
      (JSC::DFG::PredictionPropagationPhase::propagate):
      (JSC::DFG::PredictionPropagationPhase::doDoubleVoting):
      * dfg/DFGSafeToExecute.h:
      (JSC::DFG::safeToExecute):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::callOperation):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * jit/JITOperations.h:
      * runtime/CachedTranscendentalFunction.h: Removed.
      * runtime/DateInstanceCache.h:
      * runtime/Intrinsic.h:
      * runtime/MathObject.cpp:
      (JSC::MathObject::finishCreation):
      (JSC::mathProtoFuncCos):
      (JSC::mathProtoFuncSin):
      * runtime/VM.h:
      
      Tools: 
      
      Reviewed by Mark Hahnenberg.
      
      Make it easier to see that a test doesn't have an -expected file.
      
      * Scripts/run-jsc-stress-tests:
      
      LayoutTests: 
      
      Reviewed by Mark Hahnenberg.
      
      * js/dfg-cos-constant-expected.txt: Added.
      * js/dfg-cos-constant.html: Added.
      * js/dfg-sin-constant-expected.txt: Added.
      * js/dfg-sin-constant.html: Added.
      * js/script-tests/dfg-cos-constant.js: Added.
      (foo):
      * js/script-tests/dfg-sin-constant.js: Added.
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3336c7b
    • commit-queue@webkit.org's avatar
      REGRESSION(r158348): Breaks Debug build · 53abe1aa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123562
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-10-31
      Reviewed by Brady Eidson.
      
      Remove an unnecessary check that cause compilation failure.
      
      No new tests since this just fixes the build failure.
      
      * Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
      (WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53abe1aa
    • ossy@webkit.org's avatar
      One more speculative buildfix after r158365. · 64ff8b81
      ossy@webkit.org authored
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::didAddRemoteStream):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64ff8b81
    • ossy@webkit.org's avatar
      Speculative buildfix after r158365. · 733d6b84
      ossy@webkit.org authored
      * Modules/mediastream/VideoStreamTrack.cpp:
      (WebCore::VideoStreamTrack::create):
      (WebCore::VideoStreamTrack::VideoStreamTrack):
      * Modules/mediastream/VideoStreamTrack.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      733d6b84
    • commit-queue@webkit.org's avatar
      Decorated text sometimes does not draw its decorations · 51491e0a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123539
      
      Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
      Reviewed by Antti Koivisto.
      
      Decorated text should opt-out of the simple line layout, because
      SimpleLineLayout::paintFlow doesn't draw decorations
      
      Fixes fast/css3-text/css3-text-decoration/text-decoration-color.html
      
      * rendering/SimpleLineLayout.cpp:
      (WebCore::SimpleLineLayout::canUseFor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51491e0a
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove last member variable uses of InspectorState from Agents · 094c7973
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123540
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-31
      Reviewed by Timothy Hatcher.
      
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMDebuggerAgent.cpp:
      (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
      (WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
      (WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
      (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
      (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
      (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
      (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
      DOMDebuggerAgentState::eventListenerBreakpoints -> m_eventListenerBreakpoints.
      DOMDebuggerAgentState::xhrBreakpoints -> m_xhrBreakpoints.
      
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
      (WebCore::InspectorDebuggerAgent::disable):
      (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
      (WebCore::InspectorDebuggerAgent::removeBreakpoint):
      (WebCore::InspectorDebuggerAgent::didParseSource):
      DebuggerAgentState::javaScriptBreakpoints -> m_javaScriptBreakpoints.
      
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::disable):
      (WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
      (WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
      (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
      PageAgentState::pageAgentScriptsToEvaluateOnLoad -> m_scriptsToEvaluateOnLoad.
      This is a lazily created InspectorObject member variable.
      
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::willSendRequest):
      (WebCore::InspectorResourceAgent::disable):
      (WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
      ResourceAgentState::extraRequestHeaders -> m_extraRequestHeaders.
      This is a lazily created InspectorObject member variable.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      094c7973
    • philn@webkit.org's avatar
      Unreviewed, one more build fix after r158365. · c2100fb6
      philn@webkit.org authored
      * Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
      (WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2100fb6
    • bdakin@apple.com's avatar
      Repro scrolling crash with scrollbars that use setPresentationValue on the · 56dd376c
      bdakin@apple.com authored
      scrolling thread
      https://bugs.webkit.org/show_bug.cgi?id=123549
      -and corresponding-
      <rdar://problem/15246606>
      
      Reviewed by Darin Adler.
      
      Speculative fix. I think if we retain the ScrollbarPainters, we should avoid this 
      crash.
      
      * page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56dd376c
    • philn@webkit.org's avatar
      Unreviewed, MediaStream build fix after r158365. · 5ef1013e
      philn@webkit.org authored
      * Modules/mediastream/MediaStream.cpp:
      (WebCore::MediaStream::clone):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ef1013e
    • commit-queue@webkit.org's avatar
      Run tests as if they are expected to pass when --force is given. · 30995d48
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112890
      
      Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-10-31
      Reviewed by Ryosuke Niwa.
      
      The --force switch of new-run-webkit-tests is now forces all tests to
      be run with 'PASS' as expected result.
      
      * Scripts/webkitpy/layout_tests/controllers/manager.py:
      (Manager.run):
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      (TestExpectations.__init__):
      (TestExpectations._add_expectations):
      * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      (parse_args):
      (_set_up_derived_options):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30995d48
    • barraclough@apple.com's avatar
      Change WebPage, WebPageProxy, WebPageCreationParameters to use ViewState · 1355a70a
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123379
      
      Reviewed by Darin Adler.
      
      Visibility state of the Page should be stored and communicated consistently.
      
      Remove individual visibility flags from WebPageProxy, WebPageCreationParameters,
      and replace them with a ViewState, and add a ViewState member to WebPage.
      Merge together all messages that convey and individual aspect of the ViewState.
      
      Restructure WebPageProxy::viewStateDidChange to break the operation down into
      three steps: 1) update m_viewState, 2) send the new ViewState to the WebProcess,
      and 3) perform any further work necessary in the UIProcess.
      
      This patch fixes a problem that if the web process crashes m_isVisible &
      m_isInWindow in WebPageProxy were not updated, and could have held stale values
      on reattach.
      
      In WebPage, add a new message to update the entire ViewState - diff the prior
      value against the new one to detect changes, call existing methods accordingly.
      
      * Shared/ViewState.h:
          - Add constants 'Reset', 'AllFlags'
      * Shared/WebPageCreationParameters.cpp:
      (WebKit::WebPageCreationParameters::encode):
      (WebKit::WebPageCreationParameters::decode):
      * Shared/WebPageCreationParameters.h:
          - Removed boolean visibility flags, added viewState.
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
          - Constructor calls updateViewState to initialize m_viewState.
      (WebKit::WebPageProxy::reattachToWebProcess):
          - ViewStaet is not updated while detatched; recalculate.
      (WebKit::WebPageProxy::initializeWebPage):
          - m_isVisible -> isViewVisible()
      (WebKit::WebPageProxy::updateViewState):
          - Added, update m_viewState by querying the page client.
      (WebKit::WebPageProxy::viewStateDidChange):
          - Restructured to use m_viewState, reordered to combine messages.
      (WebKit::WebPageProxy::creationParameters):
          - Removed boolean visibility flags, added viewState.
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::isInWindow):
      (WebKit::WebPageProxy::isViewVisible):
          - Removed boolean visibility flags, added viewState.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
          - initial state now passed as a ViewState.
      (WebKit::WebPage::setIsInWindow):
          - Remove code to send reply (this is handled by setViewState).
      (WebKit::WebPage::setViewState):
          - Set m_viewState - diff from prior & call methods to update.
      * WebProcess/WebPage/WebPage.h:
          - Added setViewState, m_viewState.
      * WebProcess/WebPage/WebPage.messages.in:
          - Add SetViewState, remove individual messages.
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
          - initial state now passed as a ViewState.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1355a70a
    • ggaren@apple.com's avatar
      2013-10-31 Geoffrey Garen <ggaren@apple.com> · 5e77638e
      ggaren@apple.com authored
              Added Mark Lam as a reviewer.
      
              Unreviewed.
      
              * Scripts/webkitpy/common/config/contributors.json:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e77638e
    • paroga@webkit.org's avatar
      [WIN] Make WebHistory compile without USE(CF) · 32ff66f7
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122010
      
      Reviewed by Brent Fulgham.
      
      Add an alternative code path for !USE(CF) to be able to
      compile WebHistory without the CoreFoundation library.
      
      * COMVariantSetter.h: Add support for setting a Vector.
      * WebHistory.cpp:
      (createUserInfoFromArray):
      (createUserInfoFromHistoryItem):
      (WebHistory::removeAllItems):
      (WebHistory::removeItem):
      (WebHistory::addItem):
      (WebHistory::visitedURL):
      * WebHistory.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32ff66f7
    • barraclough@apple.com's avatar
      WebPageCreationParameters should be consistent in Window.open · 9c620b2e
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123557
      
      Reviewed by Sam Weinig.
      
      When Window.open in called in WebKit2 the WebProcess sends a synchronous request to open
      a page (WebPageProxy::createNewPage). The UIProcess creates a WebpageProxy, and responds
      with instructions to the WebProcess to create the WebPage. The initial creation state of
      the WebPage is communicated to the WebProcess via two routes (firstly an asynchronous
      WebProcess::CreateWebPage message, and secondly in the synchronous response from
      WebPageProxy::createNewPage). Unfortunately these responses are inconsistent with each
      other. The creationParameters() for the page are calculated twice, and since the WKView
      will be added to a window between the async message being sent and the synchronous reply
      being returned the visibility state of the page can change.
      
      To fix the inconsistency we can set the creation parameters at the point that the
      WebPageProxy is instantiated. This will result in a functional change that is web
      visible, since the page will initially be opened in a hidden/blurred state, and may
      later become visible/focussed. This change is consistent with the direction we want to
      evolve in. Whilst we will still probably require a synchronous message from the
      WebProcess to the UIProcess on Window.open, we'll probably make this return much earlier
      – having just created the WebPageProxy, but avoiding blocking the WebProcess over the
      client delegate callback that opens the new window.
      
      This fix results in a layout test result change, due to the change in behavior (page is
      created blurred, and becomes focussed, resulting in a focus event being fired – rather
      than the window opening directly into a focussed state). This is reported as a
      progression (test is broken in WebKit1, fixed in WebKit2 after this change). In reality
      the test is actually slightly broken in DRT/test-runner – the test runs differently than
      in browser, since there is is no visible main window. In-browser this patch results in
      no change in behavior on dom/Window/mozilla-focus-blur.html (the affected test).
      
      Source/WebKit2: 
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::initializeWebPage):
          - call initializeCreationParameters
      (WebKit::WebPageProxy::initializeCreationParameters):
          - calculate m_creationParameters
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::creationParameters):
          - Added m_creationParameters, initializeCreationParameters,
            creationParameters returns m_creationParameters
      
      LayoutTests: 
      
      * platform/mac-wk2/fast/dom/Window: Added.
      * platform/mac-wk2/fast/dom/Window/mozilla-focus-blur-expected.txt: Added.
          - This test now reports a pass on WebKit2
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c620b2e
    • weinig@apple.com's avatar
      Pass an Element by reference to the PseudoElement constructor · f4e61fe5
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123576
      
      Reviewed by Andreas Kling.
      
      * dom/Element.cpp:
      (WebCore::Element::createPseudoElementIfNeeded):
      * dom/PseudoElement.cpp:
      (WebCore::PseudoElement::PseudoElement):
      * dom/PseudoElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4e61fe5
    • ap@apple.com's avatar
      Fix a mis-merge. · c09b2a6c
      ap@apple.com authored
      * WebCore.xcodeproj/project.pbxproj: Remove duplicate CryptoAlgorithmRegistryMac.cpp.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c09b2a6c
    • ap@apple.com's avatar
      Add bindings code for crypto algorithm dictionaries · 8a1f7540
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123476
      
      Reviewed by Sam Weinig.
      
      JSCryptoAlgorithmDictionary reads the Algorithm, much like JSDictionary does in
      simpler cases. We should see about bringing them closer together (perhaps replacing
      with autogenerated code).
      
      * crypto/parameters: Added.
      * crypto/parameters/CryptoAlgorithmHmacKeyParams.h: Added.
      * crypto/parameters/CryptoAlgorithmHmacParams.h: Added.
      Added a couple specific dictionaries as an example.
      
      * WebCore.xcodeproj/project.pbxproj: Added JSCryptoAlgorithmDictionary.
      * bindings/js/JSCryptoAlgorithmDictionary.cpp: Added.
      (WebCore::JSCryptoAlgorithmDictionary::getAlgorithmIdentifier):
      (WebCore::getHashAlgorithm):
      (WebCore::createHmacParams):
      (WebCore::createHmacKeyParams):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
      (WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
      * bindings/js/JSCryptoAlgorithmDictionary.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a1f7540
    • weinig@apple.com's avatar
      Pass ScriptExecutionContext by reference to from the bindings constructors · a9481f01
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123575
      
      Reviewed by Andreas Kling.
      
      Since we null check the ScriptExecutionContext before creating the c++ class,
      we should be passing by reference.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9481f01
    • commit-queue@webkit.org's avatar
      Paint the input tag of range type on WinCE port. · 1874cd05
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123199
      
      Patch by Zhuang Zhigang <zhuangzg@cn.fujitsu.com> on 2013-10-31
      Reviewed by Brent Fulgham.
      
      * rendering/RenderThemeWinCE.cpp:
      (WebCore::RenderThemeWinCE::paintSliderTrack):
      (WebCore::RenderThemeWinCE::paintSliderThumb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1874cd05
    • ap@apple.com's avatar
      Add a crypto algorithm abstraction · ed822f80
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123474
      
      Reviewed by Sam Weinig.
      
      This works slightly differently than WebCrypto implies. We have separate classes
      for algorithm and its parameters, while WebCrypto puts them in the same dictionary.
      
      * WebCore.xcodeproj/project.pbxproj: Added new files.
      
      * crypto/CryptoAlgorithm.cpp: Added. As most algorithms don't implement most
      operations, default implementations just raise an exception.
      * crypto/CryptoAlgorithm.h: Added.
      
      * crypto/CryptoAlgorithmParameters.h: Added. Base class for numerous future parameter
      dictionaries, such as HmacParams or HmacKeyParams.
      
      * crypto/CryptoAlgorithmRegistry.cpp: Added.
      * crypto/CryptoAlgorithmRegistry.h: Added.
      The registry decouples universal bindings code from algorithms that may or may not
      be implemented on each platform.
      
      * crypto/mac: Added.
      * crypto/mac/CryptoAlgorithmRegistryMac.cpp: Added.
      (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Algorithms implemented
      on Mac will be registered by this function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed822f80
    • ap@apple.com's avatar
      REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and... · 2a262349
      ap@apple.com authored
      REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and xmlhttprequest-overridemimetype-content-type-header.html are failing
      https://bugs.webkit.org/show_bug.cgi?id=123548
      
      Reviewed by Brady Eidson.
      
      Source/WebCore:
      
      We had code that made sure that cached 200 responses weren't used for conditional
      requests. But it didn't work the other way - cached 304 responses got reused for
      subsequent unconditional requests!
      
      Adding the test uncovered this bug.
      
      * loader/cache/CachedRawResource.cpp: (WebCore::shouldIgnoreHeaderForCacheReuse):
      Should never ignore conditional headers. Code in determineRevalidationPolicy
      was already undoing this for conditional requests, but we also shouldn't use
      WebCore cache if it holds a 304 response to conditional request.
      
      * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      Even though the changed code is only for raw resources, I think that we can never
      get a conditional request here any more.
      
      LayoutTests:
      
      * TestExpectations: Unskip tests that used to be affected by response-empty-arraybuffer.html
      
      * http/tests/xmlhttprequest/response-empty-arraybuffer-expected.txt:
      * http/tests/xmlhttprequest/response-empty-arraybuffer.html:
      Fix a stupid typo. This test actually fully passes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a262349
    • ap@apple.com's avatar
      CryptoAlgorithmDescriptionBuilder should support producing nested algorithms · e5455c00
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123461
      
      Reviewed by Darin Adler.
      
      To add a nested algorithm, clone a builder with createEmptyClone(), fill it,
      and add it using add().
      
      * bindings/js/JSCryptoAlgorithmBuilder.h:
      * crypto/CryptoAlgorithmDescriptionBuilder.h:
      * bindings/js/JSCryptoAlgorithmBuilder.cpp:
      (WebCore::JSCryptoAlgorithmBuilder::createEmptyClone):
      (WebCore::JSCryptoAlgorithmBuilder::add): Keep VM in a local variable for marginally
      better performance.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5455c00
    • philn@webkit.org's avatar
      [WK2][GTK] enable-media-stream Setting · 877a94da
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123145
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      * page/Settings.in: new mediaStreamEnabled setting.
      
      Source/WebKit2:
      
      * Shared/WebPreferencesStore.h: New MediaStreamEnabled boolean preference.
      * UIProcess/API/C/WKPreferences.cpp: MediaStreamEnabled getter and
      setter functions.
      (WKPreferencesSetMediaStreamEnabled):
      (WKPreferencesGetMediaStreamEnabled):
      * UIProcess/API/C/WKPreferences.h:
      * UIProcess/API/gtk/WebKitSettings.cpp: Add a enable-media-stream
      property to the GTK WebKitSettings class. It will act as a facade
      to the MediaStreamEnabled preference.
      (webKitSettingsSetProperty):
      (webKitSettingsGetProperty):
      (webkit_settings_class_init):
      (webkit_settings_get_enable_media_stream):
      (webkit_settings_set_enable_media_stream):
      * UIProcess/API/gtk/WebKitSettings.h:
      * UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
      * UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
      (testWebKitSettings): Test enable-media-stream websetting.
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
      Allow WKTR to override the MediaStreamEnabled preference.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences): Update MediaStreamEnabled
      along with the other settings.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      877a94da
    • zandobersek@gmail.com's avatar
      Manage SVGPathByteStream through std::unique_ptr · 1ebce45b
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123467
      
      Reviewed by Anders Carlsson.
      
      Manage SVGPathByteStream objects through std::unique_ptr. Constructors for the class are made public
      so std::make_unique can be used with the class.
      
      * svg/SVGAnimatedPath.cpp:
      (WebCore::SVGAnimatedPathAnimator::constructFromString):
      (WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
      (WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):
      * svg/SVGAnimatedType.cpp:
      (WebCore::SVGAnimatedType::createPath):
      * svg/SVGAnimatedType.h:
      * svg/SVGPathByteStream.h:
      (WebCore::SVGPathByteStream::SVGPathByteStream): Takes a const Data object that's then copied.
      (WebCore::SVGPathByteStream::copy): Made const.
      * svg/SVGPathByteStreamBuilder.cpp: Remove an unnecessary include.
      * svg/SVGPathByteStreamBuilder.h: Ditto.
      * svg/SVGPathElement.cpp:
      (WebCore::SVGPathElement::SVGPathElement):
      * svg/SVGPathElement.h:
      * svg/SVGPathUtilities.cpp:
      (WebCore::appendSVGPathByteStreamFromSVGPathSeg):
      (WebCore::addToSVGPathByteStream):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ebce45b
    • commit-queue@webkit.org's avatar
      [EFL] Rebaselining after r158186 · 6a4834eb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123571
      
      Unreviewed gardening.
      
      Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-31
      
      * platform/efl/editing/deleting/smart-delete-003-expected.txt: Rebaselining after r158186.
      * platform/efl/editing/deleting/smart-delete-004-expected.txt: Rebaselining after r158186.
      * platform/efl/editing/selection/after-line-wrap-expected.txt: Rebaselining after r157851.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a4834eb
    • commit-queue@webkit.org's avatar
      Removing m_maxDeadCapacity condition in fast path in MemoryCache::prune(). · 8bca99e9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115631
      
      Patch by Marcin Bychawski <m.bychawski@samsung.com> on 2013-10-31
      Reviewed by Brent Fulgham.
      
      If the m_maxDeadSize and m_deadSize are both 0, the method unnecessairly tries to prune resources.
      
      No new tests, covered by existing ones.
      
      * loader/cache/MemoryCache.cpp:
      (WebCore::MemoryCache::prune):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bca99e9
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove stale optional native memory instrumentation protocol params · 29c0c619
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123552
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-31
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      * inspector/Inspector.json:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::start):
      * inspector/InspectorTimelineAgent.h:
      
      Source/WebInspectorUI:
      
      * UserInterface/InspectorBackendCommands.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29c0c619
    • zandobersek@gmail.com's avatar
      [GTK] Undefined references to RenderObject::style() when disabling video support · f5fe8cb3
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123492
      
      Reviewed by Carlos Garcia Campos.
      
      * platform/gtk/RenderThemeGtk2.cpp: Disabling video support removes indirect inclusion of the RenderElement.h
      header, causing undefined references to RenderObject::style(). The RenderElement.h header should be included
      instead of RenderObject.h as the former defines the RenderObject::style() inline and also includes the latter.
      * platform/gtk/RenderThemeGtk3.cpp: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5fe8cb3
    • g.czajkowski@samsung.com's avatar
      [EFL] Add baselines for spelling tests added in r157900. · 233f6ed2
      g.czajkowski@samsung.com authored
      Unreviewed gardening.
      
      * platform/efl/editing/spelling/centering-misspelling-dots-expected.png: Added.
      * platform/efl/editing/spelling/centering-misspelling-dots-expected.txt: Added.
      * platform/efl/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.png: Added.
      * platform/efl/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      233f6ed2
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed EFL gardening. Add 5 printing tests to EFL TestExpectations. · 936a6347
      gyuyoung.kim@samsung.com authored
      EFL port doesn't fully support printing functionality yet.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      936a6347