Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 02 Nov, 2009 2 commits
    • mitz@apple.com's avatar
      Made the remaining time display show negative zero at the end of the · 12da8133
      mitz@apple.com authored 
      video.

Reviewed by Anders Carlsson.

Made other cleanup.

* WebView/WebVideoFullscreenHUDWindowController.h: Reverted the types of
_timeline and _volumeSlider to the more generic NSControl.
* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Cleaned
up style.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Added an
assertion that the cast to NSButton * is legal. Removed casts.
(-[WebVideoFullscreenHUDWindowController updateTime]): Use
-setValue:forKey: instead of an NSSlider method.
(timeToString): Changed to support only non-negative values and
simplified.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Always
prepend a “-” to the time.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12da8133
    • mitz@apple.com's avatar
      WebKit/mac: WebKit part of making the appearance of the full-screen video HUD match · 36413e0b
      mitz@apple.com authored 
      QuickTime Player X’s HUD.

Reviewed by John Sullivan.

* WebView/WebVideoFullscreenHUDWindowController.h: Removed unnecessary
#import statements, cleaned up style, and changed _timeline,
_volumeSlider and _playButton to have more specific types.
* WebView/WebVideoFullscreenHUDWindowController.mm: Updated #import
statements.
(webkit_CGFloor): Added this helper function.
(-[WebVideoFullscreenHUDWindowController init]): Cleaned up style.
(createTimeTextField): Changed to use the bold system font.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
subviews’ metrics and the text fields’ text alignment.
(-[WebVideoFullscreenHUDWindowController updateTime]): Avoid conversion
from double to float.
(stringToTimeTextAttributed): Removed this useless function that
returned an NSAttributedString masquerading as an NSString.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Removed
call to stringToTimeTextAttributed().
(-[WebVideoFullscreenHUDWindowController elapsedTimeText]): Ditto.

WebKitLibraries: WebKitSystemInterface part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36413e0b
  3. 01 Nov, 2009 2 commits
    • mitz@apple.com's avatar
      Made the space bar toggle playing state in full-screen video when · 1abefe3c
      mitz@apple.com authored 
      modifier keys are down. Made it do so without highlighting the
Play/Pause button.

Reviewed by Mark Rowe.

* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController keyDown:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1abefe3c
    • mitz@apple.com's avatar
      Made the full-screen video HUD respond to the up and down arrow keys by · f1fdedb9
      mitz@apple.com authored 
      increasing and decreasing the volume by 1/10 of the range or, when
combined with the Option key, all the way up or down.

Reviewed by Mark Rowe.

Made the volume buttons in the full-screen video HUD match the behavior
of their equivalents in the QuickTime Player HUD by turning the volume
all the way up or down.

Made the volume slider update immediately when the keyboard or volume
buttons are used to change the volume, rather than at the nearest 1/4
second interval.

Made the elapsed and remaining time displays update immediately when the
play head is dragged across the timeline, rather than at 1/4 second
intervals.

* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController keyDown:]): Handle the up and
down arrow keys.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
actions of the volume up and volume down buttons.
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]): Call
-updateTime.
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]): Added this
action for the volume down button.
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]): Added
this action for the volume up button.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): No longer
and action method.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Call
-updateVolume.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1fdedb9
  5. 28 Oct, 2009 1 commit
    • eric.carlson@apple.com's avatar
      2009-10-28 Eric Carlson <eric.carlson@apple.com> · 9bfaaa38
      eric.carlson@apple.com authored 
              Reviewed by Simon Fraser.

        <rdar://problem/7303145> 
        Can't exit full screen mode or restart movie after pressing command -R.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::removedFromDocument):
        (WebCore::HTMLMediaElement::documentWillBecomeInactive):
            Exit from fullscreen if necessary.
        * html/HTMLMediaElement.h:

2009-10-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7303145> 
        Can't exit full screen mode or restart movie after pressing command -R.

        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController _requestExit]): 
            New, call media element's exitFullscreen method.
        (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]): 
            Call mediaElement->exitFullscreen() after a delay as it turns around and calls
            WebVideoFullscreenController:exitFullscreen.

        * WebView/WebVideoFullscreenHUDWindowController.h:
        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
            New, don't give up responder status.
        (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
            New, block all command key events.
        (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
            Remember when we are in the process of exiting fullscreen, don't allow recursion.

        * WebView/WebView.mm:
        (-[WebView _exitFullscreen]):
            Early return if fullscreen controller is nil.

        * WebView/WebWindowAnimation.h: 
            Correct comment about _window retain status.
        * WebView/WebWindowAnimation.m:
        (-[WebWindowScaleAnimation dealloc]):
            Don't release _window, we never reatained it.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bfaaa38
  7. 23 Oct, 2009 1 commit
  9. 22 Oct, 2009 1 commit
    • eric.carlson@apple.com's avatar
      2009-10-22 Eric Carlson <eric.carlson@apple.com> · 73e866e6
      eric.carlson@apple.com authored 
              Reviewed by Dan Bernstein & Simon Fraser.

        <rdar://problem/7297717>
        https://bugs.webkit.org/show_bug.cgi?id=30323
        Play/pause button in full-screen video controller does not reflect current state

        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenController setMediaElement:WebCore::]): Register for QTMovieRateDidChangeNotification
        (-[WebVideoFullscreenController rateChanged:]): Call HUD controller when rate changes.

        * WebView/WebVideoFullscreenHUDWindowController.h:
        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Call updateRate so play button
        reflects playback state.
        (-[WebVideoFullscreenHUDWindowController updateRate]): New, set play button state according to
        movie state.
        (-[WebVideoFullscreenHUDWindowController playingChanged:]): Only call [self playing] once.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73e866e6
  11. 15 Oct, 2009 2 commits
  13. 05 Oct, 2009 3 commits