Commits · 12da81330c332c9654ec7979353f3f3c6f98fde0 · App_Technologies / webkit

02 Nov, 2009 21 commits

Made the remaining time display show negative zero at the end of the · 12da8133

mitz@apple.com authored Nov 02, 2009

video.

Reviewed by Anders Carlsson.

Made other cleanup.

* WebView/WebVideoFullscreenHUDWindowController.h: Reverted the types of
_timeline and _volumeSlider to the more generic NSControl.
* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Cleaned
up style.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Added an
assertion that the cast to NSButton * is legal. Removed casts.
(-[WebVideoFullscreenHUDWindowController updateTime]): Use
-setValue:forKey: instead of an NSSlider method.
(timeToString): Changed to support only non-negative values and
simplified.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Always
prepend a “-” to the time.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12da8133

2009-11-02 Philippe Normand <pnormand@igalia.com> · 5c31137e

eric@webkit.org authored Nov 02, 2009

        Reviewed by Jan Alonzo.

        [GTK] Failing media/video-played-reset.html
        https://bugs.webkit.org/show_bug.cgi?id=30589

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5c31137e

2009-11-02 Philippe Normand <pnormand@igalia.com> · e9ffc86d

eric@webkit.org authored Nov 02, 2009

        Reviewed by Jan Alonzo.

        [GTK] Failing media/video-played-reset.html
        https://bugs.webkit.org/show_bug.cgi?id=30589

        new m_seekTime attribute to keep track of the seek position

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::currentTime):
        (WebCore::MediaPlayerPrivate::seek):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e9ffc86d

2009-11-02 Xan Lopez <xlopez@igalia.com> · 6dd8adca

xan@webkit.org authored Nov 02, 2009

        Reviewed by Jan Alonzo.

        [GTK] Remove Referer when redirecting to non-secure site
        https://bugs.webkit.org/show_bug.cgi?id=31021

        Remove referer from HTTP headers when redirecting to a non-secure
        site.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6dd8adca

2009-11-02 Xan Lopez <xlopez@igalia.com> · df308cb4

xan@webkit.org authored Nov 02, 2009

        Bump version before release (or post-release, depending on your
        point of view) so that we can make applications depending on
        unreleased APIs in WebKit svn fail at configure time when the
        requirements are not met.

        * configure.ac:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

df308cb4

Reviewed by Dan Bernstein. · bfd0fcbd

ap@apple.com authored Nov 02, 2009

        https://bugs.webkit.org/show_bug.cgi?id=18539
        multipart/form-data not being parsed correctly on server due to '+' in boundary string

        No test - the characters that the boundary is made of are not deterministic.

        * platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString):
        Don't ever put a '+' in boundary string, either. Removed a FIXME to bring '/' back once
        GMail is fixed - I don't think we'll ever want to allow non-alphanumeric characters, as
        they cause problems on many web sites.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bfd0fcbd

2009-11-02 Andrew Scherkus <scherkus@chromium.org> · 85a2a771

eric@webkit.org authored Nov 02, 2009

        Reviewed by Eric Carlson.

        Increase the timeout of media/video-currentTime-set.html from 800ms to 2000ms.

        Also fix call to logResult() as parameters were reversed, resulting in
        printing an error message of "false".

        https://bugs.webkit.org/show_bug.cgi?id=31017

        * media/video-currentTime-set.html: Timeout increased to 2000ms.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

85a2a771

Reviewed by Darin Adler. · 84ab1196

ap@apple.com authored Nov 02, 2009

        https://bugs.webkit.org/show_bug.cgi?id=30969
        A no-prefix XPath node test should not match no-namespace elements in HTML document

        Test: fast/xpath/null-namespace-in-html.html

        * xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): Special case non-HTML elements
        in HTML documents (as these are the ones that can have null namespace).



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

84ab1196

2009-11-02 Pavel Feldman <pfeldman@chromium.org> · dae154c7

pfeldman@chromium.org authored Nov 02, 2009

        Reviewed by Timothy Hatcher.

        Web Inspector: [REGRESSION] No timeline marks on resources panel.

        https://bugs.webkit.org/show_bug.cgi?id=31013

        * inspector/front-end/AbstractTimelinePanel.js:
        (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

dae154c7

Possible crash in RenderSlider::layout. · 9d61cd66

levin@chromium.org authored Nov 02, 2009

https://bugs.webkit.org/show_bug.cgi?id=31016

Patch by David Levin <levin@chromium.org> on 2009-11-02
Reviewed by Dan Bernstein.

Fix out of place line of code.

Test: scrollbars/overflow-scrollbar-combinations.html
This crash only seems to repro when WebKit draws the play controls,
so the crash repros in chromium running this test but not WebKit
nightlies which use QuickTime to draw the controls.

* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9d61cd66

2009-11-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> · 1e2dd43d

eric@webkit.org authored Nov 02, 2009

        Reviewed by Tor Arne Vestbø.

        [Qt] Fix Qt build on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=30905

        * WebCore.pro:
        * platform/graphics/BitmapImage.h:
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1e2dd43d

2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> · bc291090

eric@webkit.org authored Nov 02, 2009

        Reviewed by Adam Barth.

        QWebView crash fix.

        The QWebView should not crash if the stop() method is called from
        a function triggered by the loadProgress signal.

        A null pointer protection was added in the ProgressTracker::incrementProgress.

        New autotest was created.

        https://bugs.webkit.org/show_bug.cgi?id=29425

        * loader/ProgressTracker.cpp:
        (WebCore::ProgressTracker::incrementProgress):
2009-11-02  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Adam Barth.

        QWebView crash fix.

        The QWebView should not crash if the stop() method is called from
        a function triggered by the loadProgress signal.

        A null pointer protection was added in the ProgressTracker::incrementProgress.

        New autotest was created.

        https://bugs.webkit.org/show_bug.cgi?id=29425

        * tests/qwebview/tst_qwebview.cpp:
        (WebViewCrashTest::WebViewCrashTest):
        (WebViewCrashTest::loading):
        (tst_QWebView::crashTests):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bc291090

2009-11-02 Mikhail Naganov <mnaganov@chromium.org> · 81aba6eb

eric@webkit.org authored Nov 02, 2009

        Reviewed by Pavel Feldman.

        Fix a leftover from profiles panel generalization.

        https://bugs.webkit.org/show_bug.cgi?id=31010

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.get searchableViews):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

81aba6eb

2009-11-02 Kai Koehne <kai.koehne@nokia.com> · 521a54fb

eric@webkit.org authored Nov 02, 2009

        Reviewed by Holger Freyther.

        Remove implementation of ImageDecocerQt::clearFrameBufferCache.
        The implementation was buggy, and will visually break repeating
        animations anyway.

        https://bugs.webkit.org/show_bug.cgi?id=31009

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::clearFrameBufferCache):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

521a54fb

2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com> · 3f87e8de

eric@webkit.org authored Nov 02, 2009

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=30964
        [Gtk] Implemment AtkDocument

        Provides access to the reported content language.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_document_get_locale):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3f87e8de

2009-11-02 Keishi Hattori <casey.hattori@gmail.com> · 337129e3

eric@webkit.org authored Nov 02, 2009

        Reviewed by Timothy Hatcher.

        Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
        https://bugs.webkit.org/show_bug.cgi?id=30907

        * inspector/css-syntax-highlight-expected.txt: Added.
        * inspector/css-syntax-highlight.html: Added.
        * inspector/javascript-syntax-highlight-expected.txt:
2009-11-02  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
        https://bugs.webkit.org/show_bug.cgi?id=30907

        Test: inspector/css-syntax-highlight.html

        * inspector/front-end/ElementsTreeOutline.js:
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
        (WebInspector.SourceSyntaxHighlighter):
        (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk):
        (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine):
        (WebInspector.SourceSyntaxHighlighter.prototype.process):
        (WebInspector.SourceSyntaxHighlighter.prototype.lex):
        (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
        (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
        (WebInspector.CSSSourceSyntaxHighlighter):
        * inspector/front-end/inspectorSyntaxHighlight.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

337129e3

WebKit/mac: WebKit part of making the appearance of the full-screen video HUD match · 36413e0b

mitz@apple.com authored Nov 02, 2009

QuickTime Player X’s HUD.

Reviewed by John Sullivan.

* WebView/WebVideoFullscreenHUDWindowController.h: Removed unnecessary
#import statements, cleaned up style, and changed _timeline,
_volumeSlider and _playButton to have more specific types.
* WebView/WebVideoFullscreenHUDWindowController.mm: Updated #import
statements.
(webkit_CGFloor): Added this helper function.
(-[WebVideoFullscreenHUDWindowController init]): Cleaned up style.
(createTimeTextField): Changed to use the bold system font.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
subviews’ metrics and the text fields’ text alignment.
(-[WebVideoFullscreenHUDWindowController updateTime]): Avoid conversion
from double to float.
(stringToTimeTextAttributed): Removed this useless function that
returned an NSAttributedString masquerading as an NSString.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Removed
call to stringToTimeTextAttributed().
(-[WebVideoFullscreenHUDWindowController elapsedTimeText]): Ditto.

WebKitLibraries: WebKitSystemInterface part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

36413e0b

Support ARIA "tab" roles · 60f0160e

cfleizach@apple.com authored Nov 02, 2009

https://bugs.webkit.org/show_bug.cgi?id=30842

Reviewed by Beth Dakin.

WebCore: 

Implement support for ARIA "tab", "tabpanel" and "tablist".
As a consequence, we also needed to implement aria-selected
and aria-controls.

Tests: accessibility/aria-controls-with-tabs.html
       accessibility/aria-tab-roles.html

* accessibility/AXObjectCache.cpp:
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
* html/HTMLAttributeNames.in:

WebKit: 

Add a localizable string for tab panel.

* English.lproj/Localizable.strings:
* StringsNotToBeLocalized.txt:

WebKit/mac: 

* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):

WebKitTools: 

* DumpRenderTree/AccessibilityUIElement.cpp:
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:

LayoutTests: 

* accessibility/aria-controls-with-tabs-expected.txt: Added.
* accessibility/aria-controls-with-tabs.html: Added.
* accessibility/aria-tab-roles.html: Added.
* platform/gtk/Skipped:
* platform/mac/accessibility/aria-tab-roles-expected.txt: Added.
* platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

60f0160e

This is the WebKit-side change needed to fix canvas.getImageData() for · df622ebc

senorblanco@chromium.org authored Nov 02, 2009

Chromium.  The unpremultiply code in Skia assumes that unpremultiplied
values should be rounded, while CG does not.  In addition, the fixed
point inversion used by Skia introduces slight inaccuracies that make
us fail this test.  This change brings Chromium in line with
the CG path.
https://bugs.webkit.org/show_bug.cgi?id=30825

Reviewed by Dmitry Titov.

Covered by LayoutTests/fast/canvas/canvas-getImageData.html

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

df622ebc

2009-11-01 Kelly Norton <knorton@google.com> · 01c47789

pfeldman@chromium.org authored Nov 02, 2009

        Reviewed by Timothy Hatcher.

        Adds window event dispatches to InspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=31002

        * English.lproj/localizedStrings.js:
        * dom/Node.cpp: Updated call site to willDispatchEvent and didDispatchEvent.
        (WebCore::Node::dispatchGenericEvent):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::willDispatchEvent): Renamed.
        (WebCore::InspectorTimelineAgent::didDispatchEvent): Renamed.
        * inspector/InspectorTimelineAgent.h:
        (WebCore::):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createEventDispatchRecord): Renamed.
        * inspector/TimelineRecordFactory.h:
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._formatRecord):
        (WebInspector.TimelinePanel.prototype._getRecordDetails):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchEvent):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

01c47789

2009-11-01 Pavel Feldman <pfeldman@chromium.org> · faeb18cd

pfeldman@chromium.org authored Nov 02, 2009

        Reviewed by Timothy Hatcher.

        Web Inspector: Convert script tag event into a more generic
        script eval event in timeline.

        https://bugs.webkit.org/show_bug.cgi?id=30999

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluateInWorld):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluate):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptExecution):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::willEvaluateScript):
        (WebCore::InspectorTimelineAgent::didEvaluateScript):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createEvaluateScriptTimelineRecord):
        * inspector/TimelineRecordFactory.h:
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._formatRecord):
        (WebInspector.TimelinePanel.prototype._getRecordDetails):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

faeb18cd

01 Nov, 2009 19 commits

Rubber-stamped by Mark Rowe. · 32d0158a

bweinstein@apple.com authored Nov 02, 2009

Fix for loop to use an size_t instead of unsigned and some spacing
style fixes.

* dom/Node.cpp:
(WebCore::eventHasListeners):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

32d0158a

Re-fix the Mac build. Sorry :-(. · ba6bab1d

bweinstein@apple.com authored Nov 02, 2009


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ba6bab1d

Change ssize_t to unsigned to try and fix Windows build. · 5a116d3e
bweinstein@apple.com authored Nov 02, 2009
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
5a116d3e

Made the space bar toggle playing state in full-screen video when · 1abefe3c

mitz@apple.com authored Nov 02, 2009

modifier keys are down. Made it do so without highlighting the
Play/Pause button.

Reviewed by Mark Rowe.

* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController keyDown:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1abefe3c

2009-11-01 Eric Seidel <eric@webkit.org> · 105639a8

eric@webkit.org authored Nov 02, 2009

        Reviewed by David Levin.

        buildbots should use --exit-after-N-failures
        https://bugs.webkit.org/show_bug.cgi?id=30809

        Make the bots exit after 20 failures to prevent never-ending
        test runs where every test spends a minute crashing.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

105639a8

2009-11-01 Kelly Norton <knorton@google.com> · 07e726dd

eric@webkit.org authored Nov 02, 2009

        Reviewed by Timothy Hatcher.

        Does not send DOM dispatches to the InspectorTimelineAgent if there
        are no event listeners.
        https://bugs.webkit.org/show_bug.cgi?id=30995

        * dom/Node.cpp:
        (WebCore::eventHasListeners):
        (WebCore::Node::dispatchGenericEvent):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

07e726dd

Made the full-screen video HUD respond to the up and down arrow keys by · f1fdedb9

mitz@apple.com authored Nov 02, 2009

increasing and decreasing the volume by 1/10 of the range or, when
combined with the Option key, all the way up or down.

Reviewed by Mark Rowe.

Made the volume buttons in the full-screen video HUD match the behavior
of their equivalents in the QuickTime Player HUD by turning the volume
all the way up or down.

Made the volume slider update immediately when the keyboard or volume
buttons are used to change the volume, rather than at the nearest 1/4
second interval.

Made the elapsed and remaining time displays update immediately when the
play head is dragged across the timeline, rather than at 1/4 second
intervals.

* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController keyDown:]): Handle the up and
down arrow keys.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
actions of the volume up and volume down buttons.
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]): Call
-updateTime.
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]): Added this
action for the volume down button.
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]): Added
this action for the volume up button.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): No longer
and action method.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Call
-updateVolume.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f1fdedb9

No review (build fix). · 169de674

rolandsteiner@chromium.org authored Nov 02, 2009

Add missing files for Ruby implementation to WebCore.vcproj
(Fix build break after 50397)
https://bugs.webkit.org/show_bug.cgi?id=31001

No new tests. (No functional change)

* WebCore.vcproj/WebCore.vcproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

169de674

Bug 28420 - Implement HTML5 <ruby> rendering · 58b328f6

rolandsteiner@chromium.org authored Nov 02, 2009

(https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support.

WebCore: 

Following the HTML 5 spec, the box object model for a <ruby> element allows several runs of ruby
bases with their respective ruby texts looks as follows:

1 RenderRuby object, corresponding to the whole <ruby> HTML element
     1+ RenderRubyRun (anonymous)
         0 or 1 RenderRubyText - shuffled to the front in order to re-use existing block layouting
             0-n inline object(s)
         0 or 1 RenderRubyBase - contains the inline objects that make up the ruby base
             1-n inline object(s)

Note: <rp> elements are defined as having 'display:none' and thus normally are not assigned a renderer.
        
New layout tests will be committed in a follow-up patch under fast/ruby.

Makefiles, etc.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:

CSS
* css/html.css: Added <ruby> and <rt>

Existing render files:
* rendering/RenderBlock.cpp: make moveChild a member function moveChildTo
(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeChild):
* rendering/RenderBlock.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject): instantiate ruby renderers based on element name
* rendering/RenderObject.h: add query methods for ruby renderers
(WebCore::RenderObject::isRuby):
(WebCore::RenderObject::isRubyBase):
(WebCore::RenderObject::isRubyRun):
(WebCore::RenderObject::isRubyText):

New ruby renderers:
* rendering/RenderRuby.cpp: Added.
(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsInline::~RenderRubyAsInline):
(WebCore::RenderRubyAsInline::isChildAllowed):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::~RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::isChildAllowed):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):
* rendering/RenderRuby.h: Added.
(WebCore::RenderRubyAsInline::renderName):
(WebCore::RenderRubyAsInline::isRuby):
(WebCore::RenderRubyAsBlock::renderName):
(WebCore::RenderRubyAsBlock::isRuby):
* rendering/RenderRubyBase.cpp: Added.
(WebCore::RenderRubyBase::RenderRubyBase):
(WebCore::RenderRubyBase::~RenderRubyBase):
(WebCore::RenderRubyBase::isChildAllowed):
(WebCore::RenderRubyBase::splitToLeft):
(WebCore::RenderRubyBase::mergeWithRight):
* rendering/RenderRubyBase.h: Added.
(WebCore::RenderRubyBase::renderName):
(WebCore::RenderRubyBase::isRubyBase):
* rendering/RenderRubyRun.cpp: Added.
(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::~RenderRubyRun):
(WebCore::RenderRubyRun::hasRubyText):
(WebCore::RenderRubyRun::hasRubyBase):
(WebCore::RenderRubyRun::isEmpty):
(WebCore::RenderRubyRun::rubyText):
(WebCore::RenderRubyRun::rubyBase):
(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::firstLineBlock):
(WebCore::RenderRubyRun::updateFirstLetter):
(WebCore::RenderRubyRun::isChildAllowed):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):
* rendering/RenderRubyRun.h: Added.
(WebCore::RenderRubyRun::renderName):
(WebCore::RenderRubyRun::isRubyRun):
* rendering/RenderRubyText.cpp: Added.
(WebCore::RenderRubyText::RenderRubyText):
(WebCore::RenderRubyText::~RenderRubyText):
(WebCore::RenderRubyText::isChildAllowed):
* rendering/RenderRubyText.h: Added.
(WebCore::RenderRubyText::renderName):
(WebCore::RenderRubyText::isRubyText):

LayoutTests: 

Further layout tests will be committed in a follow-up patch under fast/ruby.

* fast/ruby/parse-rp-expected.txt: result changed due to <rt> being rendered as block within <ruby>



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

58b328f6

Reviewed by Dan Bernstein. · e7a24f50

ap@apple.com authored Nov 02, 2009

        https://bugs.webkit.org/show_bug.cgi?id=30992
        Node.isDefaultNamespace doesn't convert empty strings to null

        Test: fast/dom/Node/default-namespace-empty-argument.html

        * dom/Node.cpp: (WebCore::Node::isDefaultNamespace): Per DOM 3 Core, treat empty input
        as null.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e7a24f50

2009-11-01 Yael Aharon <yael.aharon@nokia.com> · 11c616df

eric@webkit.org authored Nov 01, 2009

        Reviewed by Darin Adler.

        Don't add '/' to the URL path if the it does not include '/' after the protocol component
        https://bugs.webkit.org/show_bug.cgi?id=30971

        Updating the expected result to reflect the change.

        * fast/loader/url-parse-1-expected.txt:
2009-11-01  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        Don't add '/' to the URL path if the it does not include '/' after the protocol component
        https://bugs.webkit.org/show_bug.cgi?id=30971

        Match IE8 behaviour, that does not add '/' if there is none after the protocol component.

        * platform/KURL.cpp:
        (WebCore::KURL::parse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11c616df

Fix layering violations in GraphicsContext3D · 1de7bf21

oliver@apple.com authored Nov 01, 2009

https://bugs.webkit.org/show_bug.cgi?id=30986

Reviewed by Darin Adler.

Remove uses of HTMLImageElement and HTMLCanvasElement

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1de7bf21

2009-11-01 Joanmarie Diggs <joanmarie.diggs@gmail.com> · 65e12bac

eric@webkit.org authored Nov 01, 2009

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=30964
        [Gtk] Implemment AtkDocument

        Implements what has been implemented in AT-SPI.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (GetAtkInterfaceTypeFromWAIType):
        (getInterfaceMaskFromObject):
        (atk_document_interface_init):
        (webkit_accessible_document_get_document_attribute_value):
        (webkit_accessible_document_get_document_attributes):
        (webkit_accessible_document_get_locale):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

65e12bac

2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com> · a5df25e6

eric@webkit.org authored Nov 01, 2009

        Reviewed by Eric Seidel.

        Turn on warnings for QtWebKit for gcc
        https://bugs.webkit.org/show_bug.cgi?id=30958

        * WebKit.pri: Turn on warnings for the GCC compiler
2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Turn on warnings for QtWebKit for gcc
        https://bugs.webkit.org/show_bug.cgi?id=30958

        No new tests as there is no functional change.

        * platform/image-decoders/qt/RGBA32BufferQt.cpp:
        (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder
        initialization list to fix compiler warnings.

2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Turn on warnings for QtWebKit for gcc
        https://bugs.webkit.org/show_bug.cgi?id=30958

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate): Reorder initialization list
        to fix compiler warnings.
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Ditto.
2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Turn on warnings for QtWebKit for gcc
        https://bugs.webkit.org/show_bug.cgi?id=30958

        * DumpRenderTree/qt/main.cpp:
        (crashHandler): Mark function NO_RETURN

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a5df25e6

2009-11-01 Keishi Hattori <casey.hattori@gmail.com> · 62efd777

eric@webkit.org authored Nov 01, 2009

        Reviewed by Pavel Feldman.

        [Regression] monitorEvent doesn't work

        * inspector/front-end/InjectedScript.js:
        (InjectedScript._ensureCommandLineAPIInstalled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

62efd777

2009-11-01 Keishi Hattori <casey.hattori@gmail.com> · dbb67a1d

eric@webkit.org authored Nov 01, 2009

        Reviewed by Pavel Feldman.

        Fix Web Inspector: Bug with Message Bubble in Syntax Highlighter
        https://bugs.webkit.org/show_bug.cgi?id=30990

        * inspector/front-end/SourceFrame.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

dbb67a1d

Reviewed by John Sullivan. · 1b6aea3d

ap@apple.com authored Nov 01, 2009

        https://bugs.webkit.org/show_bug.cgi?id=30982
        createHTMLDocument doesn't escape ampersand and less-than in title

        Test: fast/dom/DOMImplementation/createHTMLDocument-title.html

        * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument):
        Set document title after creating the document, avoiding parser intricacies.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1b6aea3d

2009-11-01 Hironori Bono <hbono@chromium.org> · ae2cf70c

eric@webkit.org authored Nov 01, 2009

        Reviewed by Darin Adler.

        Bug 30902: Need a layout test for Bug 28284
        This change just adds a simple test that calls TextInputController.firstRectForCharacterRange()
        before and after inserting a Thai character and compare their results.
        https://bugs.webkit.org/show_bug.cgi?id=30902

        * fast/text/international/thai-cursor-position-expected.txt: Added.
        * fast/text/international/thai-cursor-position.html: Added.
        * platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
        * platform/qt/Skipped: ditto.
        * platform/win/Skipped: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ae2cf70c

2009-11-01 Keishi Hattori <casey.hattori@gmail.com> · fe9ebf93

eric@webkit.org authored Nov 01, 2009

        Reviewed by Timothy Hatcher.

        Web Inspector: Double clicking on a breakpoints should not select text
        https://bugs.webkit.org/show_bug.cgi?id=30950

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._documentMouseDown):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fe9ebf93