1. 21 Nov, 2012 40 commits
    • simonjam@chromium.org's avatar
      [Resource Timing] Populate PerformanceResourceTiming structs with timing data · 11d3e453
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102862
      
      Reviewed by Tony Gentilcore.
      
      This allows CachedResourceLoader to pass in all of the necessary values and populates
      them in the PerformanceResourceTiming struct. A follow up patch will actually call
      addResourceTiming() as necessary.
      
      Tests: http/tests/w3c/webperf/submission/resource-timing
      
      * page/Performance.cpp:
      (WebCore::Performance::addResourceTiming): Accept all necessary timing data.
      * page/Performance.h:
      (WebCore):
      (Performance):
      * page/PerformanceEntry.cpp:
      (WebCore::PerformanceEntry::PerformanceEntry):
      * page/PerformanceEntry.h:
      (PerformanceEntry):
      * page/PerformanceResourceTiming.cpp:
      (WebCore::monotonicTimeToDocumentMilliseconds):
      (WebCore):
      (WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
      (WebCore::PerformanceResourceTiming::initiatorType): Return the spec'd values.
      (WebCore::PerformanceResourceTiming::fetchStart):
      (WebCore::PerformanceResourceTiming::domainLookupStart):
      (WebCore::PerformanceResourceTiming::domainLookupEnd):
      (WebCore::PerformanceResourceTiming::connectStart):
      (WebCore::PerformanceResourceTiming::connectEnd):
      (WebCore::PerformanceResourceTiming::secureConnectionStart):
      (WebCore::PerformanceResourceTiming::requestStart):
      (WebCore::PerformanceResourceTiming::responseStart):
      (WebCore::PerformanceResourceTiming::responseEnd):
      (WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):
      * page/PerformanceResourceTiming.h:
      (WebCore::PerformanceResourceTiming::create):
      (PerformanceResourceTiming):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11d3e453
    • fpizlo@apple.com's avatar
      Baseline JIT's disassembly should be just as pretty as the DFG's · 1949f329
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102873
      
      Reviewed by Sam Weinig.
      
      Integrated the CodeBlock's bytecode dumper with the JIT's disassembler. Also fixed
      some type goof-ups (instructions are not in a Vector<Instruction> so using a Vector
      iterator makes no sense) and stream-lined some things (you don't actually need a
      full-fledged ExecState* to dump bytecode).
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::printUnaryOp):
      (JSC::CodeBlock::printBinaryOp):
      (JSC::CodeBlock::printConditionalJump):
      (JSC::CodeBlock::printGetByIdOp):
      (JSC::CodeBlock::printCallOp):
      (JSC::CodeBlock::printPutByIdOp):
      (JSC::CodeBlock::dump):
      (JSC):
      (JSC::CodeBlock::CodeBlock):
      * bytecode/CodeBlock.h:
      (CodeBlock):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::dumpCallFrame):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileMainPass):
      (JSC::JIT::privateCompileSlowCases):
      (JSC::JIT::privateCompile):
      * jit/JIT.h:
      (JIT):
      * jit/JITDisassembler.cpp: Added.
      (JSC):
      (JSC::JITDisassembler::JITDisassembler):
      (JSC::JITDisassembler::~JITDisassembler):
      (JSC::JITDisassembler::dump):
      (JSC::JITDisassembler::dumpForInstructions):
      (JSC::JITDisassembler::dumpDisassembly):
      * jit/JITDisassembler.h: Added.
      (JSC):
      (JITDisassembler):
      (JSC::JITDisassembler::setStartOfCode):
      (JSC::JITDisassembler::setForBytecodeMainPath):
      (JSC::JITDisassembler::setForBytecodeSlowPath):
      (JSC::JITDisassembler::setEndOfSlowPath):
      (JSC::JITDisassembler::setEndOfCode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1949f329
    • morrita@google.com's avatar
      [Shadow DOM][V8] Assertion failure when shadow host is reclaimed before ShadowRoot · 723ec09f
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102893
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      Due to bug 88834, shadow hosts can be reclaimed before
      corresponding ShadowRoots are.  This breaks an invariant, that is,
      the host is always available for any ShadowRoot.  This change adds
      guards for the possibly broken invariant.
      
      Since bug 88834 is planned to be fixed shortly, this change
      doesn't aim to fix this problem by make it work correctly, but
      just lays a safety net which is needed until the root cause is
      gone.
      
      Test: fast/dom/shadow/host-wrapper-reclaimed.html
      
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::setInnerHTML):
      (WebCore::ShadowRoot::setApplyAuthorStyles):
      (WebCore::ShadowRoot::setResetStyleInheritance):
      (WebCore::ShadowRoot::childrenChanged):
      
      LayoutTests:
      
      * fast/dom/shadow/host-wrapper-reclaimed-expected.txt: Added.
      * fast/dom/shadow/host-wrapper-reclaimed.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      723ec09f
    • krit@webkit.org's avatar
      Make CachedSVGDocumentReference independent of FilterOperation · 12fd8b15
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102967
      
      Reviewed by Antti Koivisto.
      
      Make CachedSVGDocumentReference independent of FilterOperation to reuse the code for clip-path and masking.
      
      No new tests, refactoring.
      
      * GNUmakefile.list.am: Move CachedSVGDocumentReference to it's proper location and it to the projects.
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::loadPendingSVGDocuments):
      (WebCore::StyleResolver::createFilterOperations):
      * loader/cache/CachedSVGDocumentReference.h: Renamed from Source/WebCore/css/CachedSVGDocumentReference.h.
      (WebCore):
      (CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::document):
      * platform/graphics/filters/FilterOperation.h: Rename data() and setData() to
          cachedSVGDocumentReference() and its setter. Adapt other classes.
      (WebCore::FilterOperation::ReferenceFilterOperation::cachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (ReferenceFilterOperation):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::buildReferenceFilter):
      * rendering/RenderLayerFilterInfo.cpp:
      (WebCore::RenderLayerFilterInfo::updateReferenceFilterClients):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12fd8b15
    • dbates@webkit.org's avatar
      JavaScript fails to concatenate large strings · ec471f16
      dbates@webkit.org authored
      <https://bugs.webkit.org/show_bug.cgi?id=102963>
      
      Reviewed by Michael Saboff.
      
      Source/JavaScriptCore: 
      
      Fixes an issue where we inadvertently didn't check the length of
      a JavaScript string for overflow.
      
      * runtime/Operations.h:
      (JSC::jsString):
      (JSC::jsStringFromArguments):
      
      LayoutTests: 
      
      Add tests to ensure that we handle concatenating large strings.
      
      * fast/js/concat-large-strings-crash-expected.txt: Added.
      * fast/js/concat-large-strings-crash.html: Added.
      * fast/js/concat-large-strings-crash2-expected.txt: Added.
      * fast/js/concat-large-strings-crash2.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec471f16
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Remove #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp · 73d7ea0d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102773
      
      Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-21
      Reviewed by Gyuyoung Kim.
      
      PageViewportControllerClientEfl.cpp doesn't need to include ewk_view_private.h.
      
      * UIProcess/efl/PageViewportControllerClientEfl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73d7ea0d
    • simonjam@chromium.org's avatar
      Remove the concept of initiatorDocument from CachedResourceRequest · 5928faa7
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102855
      
      Reviewed by Sam Weinig.
      
      It turns out this isn't necessary for the new implementation of Resource Timing. Instead,
      we can get at it from the CachedResourceLoader. I don't think anyone else needed it either.
      
      No new tests. This was never used.
      
      * css/CSSFontFaceSrcValue.cpp:
      (WebCore::CSSFontFaceSrcValue::cachedFont):
      * css/CSSImageSetValue.cpp:
      (WebCore::CSSImageSetValue::cachedImageSet):
      * css/CSSImageValue.cpp:
      (WebCore::CSSImageValue::cachedImage):
      * css/StyleRuleImport.cpp:
      (WebCore::StyleRuleImport::requestStyleSheet):
      * css/WebKitCSSSVGDocumentValue.cpp:
      (WebCore::WebKitCSSSVGDocumentValue::load):
      * css/WebKitCSSShaderValue.cpp:
      (WebCore::WebKitCSSShaderValue::cachedShader):
      * html/parser/CSSPreloadScanner.cpp:
      (WebCore::CSSPreloadScanner::emitRule):
      * html/parser/HTMLPreloadScanner.cpp:
      (WebCore::PreloadTask::preload):
      * loader/cache/CachedResourceRequest.cpp:
      (WebCore::CachedResourceRequest::setInitiator):
      * loader/cache/CachedResourceRequest.h:
      (CachedResourceRequest):
      * loader/icon/IconLoader.cpp:
      (WebCore::IconLoader::startLoading):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5928faa7
    • fsamuel@chromium.org's avatar
      Add fast/events/context-nodrag.html to Chromium Mac TestExpectations · a8c79c7c
      fsamuel@chromium.org authored
      No review.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8c79c7c
    • simonjam@chromium.org's avatar
      [Resource Timing] Create W3C-style test suite · c83e0b33
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84883
      
      Reviewed by Tony Gentilcore.
      
      The tests are designed to be upstreamed. Eventually, the local ones will be replaced by the official upstream versions.
      
      * http/tests/w3c/webperf/resources/Ahem.ttf: Added.
      * http/tests/w3c/webperf/resources/all_resource_types.htm: Added.
      * http/tests/w3c/webperf/resources/blank_image.png: Added.
      * http/tests/w3c/webperf/resources/empty_script.js: Added.
      * http/tests/w3c/webperf/resources/generate_resource.php: Added.
      * http/tests/w3c/webperf/resources/gray_bg.css: Added.
      (body):
      * http/tests/w3c/webperf/resources/green_frame.htm: Added.
      * http/tests/w3c/webperf/resources/inject_resource_test.html: Added.
      * http/tests/w3c/webperf/resources/nested.css: Added.
      (@font-face):
      (ol):
      * http/tests/w3c/webperf/resources/webperftestharness.js:
      (test_greater_or_equals):
      (test_fail):
      (test_resource_entries):
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order-expected.txt: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion-expected.txt: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type-expected.txt: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type.html: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects-expected.txt: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting-expected.txt: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting.html: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types-expected.txt: Added.
      * http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types.html: Added.
      * platform/chromium/TestExpectations: Skip these new tests until the flag is flipped.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c83e0b33
    • allan.jensen@digia.com's avatar
      Position in QWebHitTestResult does not match documentation · b1e95f6e
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102909
      
      Reviewed by Simon Hausmann.
      
      Correct documentation and simplify using the new innerNodeFrame method.
      
      * Api/qwebframe.cpp:
      (QWebHitTestResultPrivate::QWebHitTestResultPrivate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1e95f6e
    • fsamuel@chromium.org's avatar
      Add fast/events/context-nodrag.html to Mac TestExpectations · 9586ddab
      fsamuel@chromium.org authored
      No review.
      
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9586ddab
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r135437. · 5765e3c7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/135437
      https://bugs.webkit.org/show_bug.cgi?id=102986
      
      This patch causes crash to some layout tests (Requested by
      jianli on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21
      
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::createRendererIfNeeded):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::createObject):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5765e3c7
    • commit-queue@webkit.org's avatar
      [BlackBerry] Drop Synchronous Mouse Events · d9f2aa31
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102980
      
      Patch by Genevieve Mak <gmak@rim.com> on 2012-11-21
      Reviewed by Rob Buis.
      
      Reviewed Internally by George Staikos, Mike Lattanzio and Mike Fenton.
      Get rid of unneeded methods and simplify code.
      Send click if getting context over an empty text field
      so that it will be focused and have a caret.
      PR #242781
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      (BlackBerry::WebKit::WebPage::touchEvent):
      (BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
      (BlackBerry::WebKit::WebPage::touchEventCancel):
      * Api/WebPage.h:
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
      (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
      (BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
      (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
      (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
      * WebKitSupport/TouchEventHandler.h:
      (TouchEventHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9f2aa31
    • akling@apple.com's avatar
      Style sharing: Compare class lists via SpaceSplitString instead of string comparison. · 884288db
      akling@apple.com authored
      <http://webkit.org/b/102982>
      
      Reviewed by Antti Koivisto.
      
      Add an operator!= to SpaceSplitString and use that check if two elements are eligible
      for style sharing instead of comparing the fastGetAttribute(classAttr) return values.
      This works because SpaceSplitString maps equal strings to the same data internally.
      
      * css/StyleResolver.cpp:
      (WebCore::haveIdenticalStyleAffectingAttributes):
      * dom/SpaceSplitString.h:
      (WebCore::SpaceSplitString::operator!=):
      (SpaceSplitString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      884288db
    • commit-queue@webkit.org's avatar
      Multi-frame CUR file test hangs on mac port · 622946e8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101811
      
      Patch by Rick Byers <rbyers@chromium.org> on 2012-11-21
      Reviewed by Alexey Proskuryakov.
      
      Fix tests to not hang on unexpected image load failure.
      Expect multi-frame CUR files to fail to load on Mac.
      
      * fast/events/mouse-cursor.html:
      * fast/events/mouse-cursor-multiframecur.html:
      * platform/mac/TestExpectations:
      * platform/mac/fast/events/mouse-cursor-multiframecur-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      622946e8
    • commit-queue@webkit.org's avatar
      Coordinated Graphics: refactor changing children code in CoordinatedGraphicsLayer. · 308f0055
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102896
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
      Reviewed by Noam Rosenthal.
      
      When changing children, we don't need to sync a layer state because
      there is no more need to send the parent ID every time the layer tree
      hierarchy changes. So this patch removes didChangeLayerState() in
      methods which change children.
      
      In addition, purgeBackingStores() does not need to call didChangeChildren()
      because purgeBackingStores() does not change children.
      
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
      (WebCore::CoordinatedGraphicsLayer::setChildren):
      (WebCore::CoordinatedGraphicsLayer::addChild):
      (WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
      (WebCore::CoordinatedGraphicsLayer::addChildAbove):
      (WebCore::CoordinatedGraphicsLayer::addChildBelow):
      (WebCore::CoordinatedGraphicsLayer::replaceChild):
      (WebCore::CoordinatedGraphicsLayer::removeFromParent):
      (WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      308f0055
    • commit-queue@webkit.org's avatar
      Use m_webView->size() for viewport update · 698295e8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102764
      
      Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-21
      Reviewed by Adam Barth.
      
      m_webView->client()->windowRect() returns the outer rect of the browser
      window, which includes the decorations such as the title bar.
      We should use the size of the WebView for layout and rendering purpose.
      
      Existing tests are updated to work without windowRect().
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
      * tests/WebFrameTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      698295e8
    • kpiascik@rim.com's avatar
      [BlackBerry] Prevent screen from dimming on device when inspector front-end is connected · afdc6278
      kpiascik@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102978
      
      Reviewed by Rob Buis.
      
      Internal PR 200848
      We prevent screen from going dim when the front-end is connected and return to normal when
      the front-end disconnects.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPage::enableWebInspector):
      (BlackBerry::WebKit::WebPage::disableWebInspector):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afdc6278
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r135338, r135359, and r135378. · 5a13378f
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/135338
      http://trac.webkit.org/changeset/135359
      http://trac.webkit.org/changeset/135378
      https://bugs.webkit.org/show_bug.cgi?id=102981
      
      Likely caused a 10% regression in
      dromaeo_domcoreattr/dom_attr_getAttribute (Requested by abarth
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateEventConstructorCallback):
      (ConvertToV8Parameter):
      * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
      (WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
      * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
      (WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
      * bindings/scripts/test/V8/V8TestEventConstructor.cpp:
      (WebCore::V8TestEventConstructor::constructorCallback):
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
      (WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetter):
      (WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
      (WebCore::V8TestInterface::constructorCallback):
      * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
      (WebCore::V8TestNamedConstructorConstructorCallback):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
      (WebCore::TestObjV8Internal::stringAttrAttrSetter):
      (WebCore::TestObjV8Internal::reflectedStringAttrAttrSetter):
      (WebCore::TestObjV8Internal::reflectedURLAttrAttrSetter):
      (WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetter):
      (WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
      (WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
      (WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
      (WebCore::TestObjV8Internal::longMethodWithArgsCallback):
      (WebCore::TestObjV8Internal::objMethodWithArgsCallback):
      (WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
      (WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
      (WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
      (WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
      (WebCore::TestObjV8Internal::overloadedMethod1Callback):
      (WebCore::TestObjV8Internal::overloadedMethod3Callback):
      (WebCore::TestObjV8Internal::overloadedMethod11Callback):
      (WebCore::TestObjV8Internal::overloadedMethod12Callback):
      (WebCore::TestObjV8Internal::strictFunctionCallback):
      (WebCore::TestObjV8Internal::variadicStringMethodCallback):
      * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
      (WebCore::V8TestOverloadedConstructors::constructor4Callback):
      * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
      (WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
      * bindings/v8/V8BindingMacros.h:
      * bindings/v8/V8StringResource.h:
      (WebCore::V8Parameter::V8Parameter):
      (V8Parameter):
      (WebCore::V8Parameter::prepareBase):
      (WebCore::V8Parameter::object):
      (WebCore::::prepare):
      * bindings/v8/custom/V8ConsoleCustom.cpp:
      (WebCore::V8Console::profileCallback):
      (WebCore::V8Console::profileEndCallback):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::handlePostMessageCallback):
      * bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
      (WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):
      * bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
      (WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):
      * bindings/v8/custom/V8HistoryCustom.cpp:
      (WebCore::V8History::pushStateCallback):
      (WebCore::V8History::replaceStateCallback):
      * bindings/v8/custom/V8IntentCustom.cpp:
      (WebCore::V8Intent::constructorCallbackCustom):
      * bindings/v8/custom/V8SQLTransactionCustom.cpp:
      (WebCore::V8SQLTransaction::executeSqlCallback):
      * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
      (WebCore::V8SQLTransactionSync::executeSqlCallback):
      * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
      (WebCore::V8WebGLRenderingContext::getExtensionCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a13378f
    • commit-queue@webkit.org's avatar
      Invalidate non-composited content host when page scale factor changes · 54fd8140
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100718
      
      Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-21
      Reviewed by Adam Barth.
      
      During a scale change, non-composited content layer doesn't get invalidated
      automatically by the transformation change on RenderView. Need to force
      update non-composited contents ourself.
      
      Source/WebCore:
      
      Test: compositing/repaint/page-scale-repaint.html
      
      * page/Page.cpp:
      (WebCore::Page::setPageScaleFactor):
      
      LayoutTests:
      
      * compositing/repaint/page-scale-repaint-expected.png: Added.
      * compositing/repaint/page-scale-repaint-expected.txt: Added.
      * compositing/repaint/page-scale-repaint.html: Added.
      * compositing/repaint/resources/grid.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54fd8140
    • rniwa@webkit.org's avatar
      Yet another EFL & GTK+ build fix after r135429. · 1b4406a8
      rniwa@webkit.org authored
      * html/HTMLPropertiesCollection.cpp:
      (WebCore::HTMLPropertiesCollection::create):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b4406a8
    • commit-queue@webkit.org's avatar
      Node::createRenderer should never return null · a5a883f2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102975
      
      Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-21
      Reviewed by Ojan Vafai.
      
      Node::createRenderer should never return null, instead Node::rendererIsNeeded
      should return false if a node doesn't wish to have a renderer. This method
      never actually returns null right now, but the code makes it look like it
      could.
      
      No new tests, just refactoring.
      
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::createRendererIfNeeded):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::createObject):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5a883f2
    • fsamuel@chromium.org's avatar
      Clear MousePressed state on context menu to avoid initiating a drag · 9bc88f2b
      fsamuel@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101786
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      If a user initiates a drag via left mouse down, brings up the context menu,
      and then cancels the context menu while keeping the left mouse button down,
      then the drag operation will continue. This does not match the platform
      conventions on Windows, Linux or Mac .
      
      This change cancels the drag if the context menu is about to be displayed.
      
      Test: fast/events/context-nodrag.html
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::sendContextMenuEvent):
      
      Tools:
      
      * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
      (WebTestRunner):
      (WebTestRunner::EventSender::EventSender):
      (WebTestRunner::EventSender::contextClick):
      Only send a MouseUp on Windows. Keep the current mouse pressed state when
      calling up a context menu.
      
      LayoutTests:
      
      If a user initiates a drag via left mouse down, brings up the context menu,
      and then cancels the context menu while keeping the left mouse button down,
      then the drag operation will continue. This does not match the platform
      conventions on Windows, Linux or Mac .
      
      This change cancels the drag if the context menu is about to be displayed.
      
      * fast/events/context-nodrag.html: Added.
      * fast/events/context-nodrag-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bc88f2b
    • paroga@webkit.org's avatar
      Use MIMETypeRegistryWin for WinCE port too · d15a201c
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102977
      
      Reviewed by Laszlo Gombos.
      
      r135217 made MIMETypeRegistryWin compile on WinCE too,
      which allows us to get rid of MIMETypeRegistryWinCE.
      
      * PlatformWinCE.cmake:
      * WebCore.gypi:
      * platform/wince/MIMETypeRegistryWinCE.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d15a201c
    • commit-queue@webkit.org's avatar
      REGRESSION(r135212): Fix crash due to an infinite rect. · 79bcee79
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102891
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
      Reviewed by Noam Rosenthal.
      
      Source/WebKit2:
      
      When CoordinatedGraphicsLayer has a 3D transform, tiledBackingStoreVisibleRect()
      can calculate an infinite rect. However, TiledBackingStore cannot handle the
      infinite rect. This patch clamps the infinite rect to avoid crash in
      TiledBackingStore.
      
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
      (WebCore::clampToContentsRectIfRectIsInfinite):
      (WebCore):
      (WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
      
      LayoutTests:
      
      fast/multicol/span/positioned-child-not-removed-crash.html now passes on
      EFL.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79bcee79
    • commit-queue@webkit.org's avatar
      [V8] Add context checks to WorldContextHandle and V8DOMWindowShell · 9b3391e5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101573
      
      Patch by Dan Carney <dcarney@google.com> on 2012-11-21
      Reviewed by Adam Barth.
      
      Added a bunch of assertions to ensure the problems with IndexedDB
      contexts cannot reemerge.
      
      No new tests. No change in functionality.
      
      * bindings/v8/V8DOMWindowShell.cpp:
      (WebCore):
      (WebCore::V8DOMWindowShell::assertContextHasCorrectPrototype):
      * bindings/v8/V8DOMWindowShell.h:
      (V8DOMWindowShell):
      (WebCore::V8DOMWindowShell::isolated):
      * bindings/v8/WorldContextHandle.cpp:
      (WebCore::WorldContextHandle::WorldContextHandle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b3391e5
    • commit-queue@webkit.org's avatar
      Remove unnecessary ternaries in createRendererIfNeeded · bc4a2932
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102974
      
      Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-21
      Reviewed by Ojan Vafai.
      
      parentRenderer, nextRenderer and previousRenderer all handle flow
      threads automatically so there's no reason to duplicate the check in
      createRendererIfNeeded.
      
      Note that while these methods first check the node for a renderer and
      then delegate to the flow thread the node never has a renderer when
      calling createRendererIfNeeded per the assertion at the top so this
      change is equivalent.
      
      No new tests, just refactoring.
      
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::createRendererIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc4a2932
    • rniwa@webkit.org's avatar
      EFL and GTK+ build fix after r135429. · 617baa74
      rniwa@webkit.org authored
      * dom/Element.cpp:
      (WebCore::ElementRareData::ensureCachedHTMLCollection):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      617baa74
    • jianli@chromium.org's avatar
      Unreviewed. Updated chromium test expectations to resolve lint failures. · 52f9d63d
      jianli@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52f9d63d
    • rniwa@webkit.org's avatar
      HTMLCollection should use the same storage as DynamicNodeList · e0640214
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102886
      
      Reviewed by Antti Koivisto.
      
      This patch removes ElementRareData::m_collection. HTMLCollections are now held by
      NodeListNodeData in NodeRareData like DynamicNodeLists. This simplifies several
      Element and Node functions where we used to call into both ElementRareData and
      NodeRareData to invalidate caches.
      
      This is a refactoring and there should be no behavioral change.
      
      * dom/DynamicNodeList.h:
      * dom/Element.cpp:
      (WebCore::ElementRareData::ensureCachedHTMLCollection):
      * dom/ElementRareData.cpp:
      (WebCore::ElementRareData::reportMemoryUsage):
      * dom/ElementRareData.h:
      (ElementRareData):
      (WebCore::ElementRareData::cachedHTMLCollection):
      (WebCore::ElementRareData::removeCachedHTMLCollection):
      * dom/Node.cpp:
      (WebCore::Node::invalidateNodeListCachesInAncestors):
      * dom/NodeRareData.h:
      (NodeListsNodeData):
      (WebCore::NodeListsNodeData::addCacheWithAtomicName):
      (WebCore::NodeListsNodeData::cacheWithAtomicName):
      (WebCore::NodeListsNodeData::removeCacheWithAtomicName):
      (WebCore::NodeListsNodeData::adoptTreeScope):
      (WebCore::NodeListsNodeData::namedNodeListKey):
      * dom/TreeScopeAdopter.cpp:
      (WebCore::TreeScopeAdopter::moveTreeToNewScope):
      * html/HTMLFormControlsCollection.cpp:
      (WebCore::HTMLFormControlsCollection::create):
      * html/HTMLFormControlsCollection.h:
      (HTMLFormControlsCollection):
      * html/HTMLOptionsCollection.cpp:
      (WebCore::HTMLOptionsCollection::create):
      * html/HTMLOptionsCollection.h:
      (HTMLOptionsCollection::create):
      * html/HTMLPropertiesCollection.h:
      (HTMLPropertiesCollection::create):
      * html/HTMLTableRowsCollection.cpp:
      (WebCore::HTMLTableRowsCollection::create):
      * html/HTMLTableRowsCollection.h:
      (HTMLTableRowsCollection):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0640214
    • akling@apple.com's avatar
      Update incorrect assertion in ImmutableElementAttributeData(MutableElementAttributeData). · ea26fa2b
      akling@apple.com authored
      <http://webkit.org/b/102972>
      
      Reviewed by Antti Koivisto.
      
      Manipulation by editing code may cause an element to have mutable inline style, and this is fine.
      
      Change the assertion to confirm that the inline style doesn't have a CSSOM wrapper attached,
      which is where real problems would happen.
      
      Fixes an assertion on editing/undo/replace-by-span-then-remove.html
      
      * dom/ElementAttributeData.cpp:
      (WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea26fa2b
    • kpiascik@rim.com's avatar
      [BlackBerry] Don't add empty rects to the tap highlight region. · 52c36335
      kpiascik@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102966
      
      Reviewed by George Staikos.
      
      Internal PR 246960
      Tap highlight is way too large sometimes.
      When we add an empty rect it inflates by 2 and causes the tap region to extend to the origin.
      
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52c36335
    • haraken@chromium.org's avatar
      Remove $outputDir and $outputHeadersDir from global variables of code generators · 0471b789
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102492
      
      Reviewed by Adam Barth.
      
      $outputDir and $outputHeadersDir are used in WriteData() only.
      We don't need to use global variables for them.
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGenerator.pm:
      (ProcessDocument):
      (FileNamePrefix):
      * bindings/scripts/CodeGeneratorCPP.pm:
      (new):
      (GenerateInterface):
      (WriteData):
      * bindings/scripts/CodeGeneratorGObject.pm:
      (new):
      (WriteData):
      (GenerateInterface):
      * bindings/scripts/CodeGeneratorJS.pm:
      (new):
      (GenerateInterface):
      (WriteData):
      * bindings/scripts/CodeGeneratorObjC.pm:
      (new):
      (GenerateInterface):
      (WriteData):
      * bindings/scripts/CodeGeneratorV8.pm:
      (new):
      (GenerateInterface):
      (WriteData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0471b789
    • commit-queue@webkit.org's avatar
      Source/WTF/wtf/Assertions.cpp: fix build on a uClibc system · f5041a21
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102946
      
      Patch by Anthony G. Basile <blueness@gentoo.org> on 2012-11-21
      Reviewed by Tony Chang.
      
      Webkit-Gtk fails to build on a uClibc system because
      Assertions.cpp assumes that all Linux systems have execinfo.h
      and provide backtrace(). This is not necessarily the case for
      uClibc which can be configured without these.  This patch
      refines the check for OS(LINUX) to prevent this breakage.
      Originally reported at https://bugs.gentoo.org/441674
      
      * wtf/Assertions.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5041a21
    • jsbell@chromium.org's avatar
      Remove IDBDatabaseException · f03a4627
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102514
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      After the WebKit implementation landed, the IndexedDB spec changed from defining new
      exception codes with constants hanging off an interface to using DOM4-styled named
      DOMExceptions. Remove the IDBDatabaseException interface and set codes for IDB-specific
      exceptions to 0. (The .idl file is retained pending general ExceptionCode cleanup.)
      
      Also remove IDBRequest.errorCode which was used for reporting asynchronous errors;
      IDBRequest.error - a DOMError - should be used instead.
      
      No new tests - covered by plenty of existing tests which have been updated.
      
      * Modules/indexeddb/DOMWindowIndexedDatabase.idl: Don't expose the interface.
      * Modules/indexeddb/IDBCursor.idl: Remove reference to IDBDatabaseException.
      * Modules/indexeddb/IDBDatabase.idl: Ditto.
      * Modules/indexeddb/IDBDatabaseException.cpp:
      (IDBDatabaseExceptionNameDescription): Use either a DOMException code or 0.
      (WebCore::IDBDatabaseException::initializeDescription):
      (WebCore::IDBDatabaseException::getLegacyErrorCode):
      * Modules/indexeddb/IDBFactory.idl: Remove reference to IDBDatabaseException.
      * Modules/indexeddb/IDBIndex.idl: Ditto.
      * Modules/indexeddb/IDBKeyRange.idl: Ditto.
      * Modules/indexeddb/IDBObjectStore.idl: Ditto.
      * Modules/indexeddb/IDBRequest.idl: Ditto.
      * Modules/indexeddb/IDBTransaction.idl: Ditto.
      * Modules/indexeddb/WorkerContextIndexedDatabase.idl: Don't expose the interface.
      * bindings/v8/IDBBindingUtilities.cpp: Remove unneeded #include.
      
      LayoutTests:
      
      Remove references to IDBDatabaseException - DOMExceptions should be thrown with code 0 and
      a name. Remove references to IDBRequest.errorCode - IDBRequest.error is the new hawtness,
      and already tested for. Ensure those objects/properties are gone in removed.html
      
      * storage/indexeddb/basics-expected.txt:
      * storage/indexeddb/basics-workers-expected.txt:
      * storage/indexeddb/constants.html: Removed.
      * storage/indexeddb/constants-expected.txt: Removed.
      * storage/indexeddb/create-and-remove-object-store-expected.txt:
      * storage/indexeddb/cursor-continue-dir-expected.txt:
      * storage/indexeddb/cursor-continue-expected.txt:
      * storage/indexeddb/cursor-update-expected.txt:
      * storage/indexeddb/deleteIndex-expected.txt:
      * storage/indexeddb/exceptions-expected.txt:
      * storage/indexeddb/factory-cmp-expected.txt:
      * storage/indexeddb/get-keyrange-expected.txt:
      * storage/indexeddb/index-basics-expected.txt:
      * storage/indexeddb/index-basics-workers-expected.txt:
      * storage/indexeddb/index-count-expected.txt:
      * storage/indexeddb/index-unique-expected.txt:
      * storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
      * storage/indexeddb/invalid-keys-expected.txt:
      * storage/indexeddb/key-generator-expected.txt:
      * storage/indexeddb/key-type-array-expected.txt:
      * storage/indexeddb/keypath-edges-expected.txt:
      * storage/indexeddb/keyrange-expected.txt:
      * storage/indexeddb/mozilla/add-twice-failure-expected.txt:
      * storage/indexeddb/mozilla/bad-keypath-expected.txt:
      * storage/indexeddb/mozilla/clear-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
      * storage/indexeddb/mozilla/readonly-transactions-expected.txt:
      * storage/indexeddb/mozilla/resources/add-twice-failure.js:
      * storage/indexeddb/mozilla/resources/bad-keypath.js:
      * storage/indexeddb/mozilla/resources/clear.js:
      * storage/indexeddb/mozilla/resources/indexes.js: Elide obsolete comment.
      * storage/indexeddb/mozilla/resources/key-requirements-delete-null-key.js:
      * storage/indexeddb/mozilla/resources/key-requirements-inline-and-passed.js:
      * storage/indexeddb/mozilla/resources/key-requirements-put-no-key.js:
      * storage/indexeddb/mozilla/resources/key-requirements-put-null-key.js:
      * storage/indexeddb/mozilla/resources/readonly-transactions.js:
      * storage/indexeddb/objectstore-autoincrement-expected.txt:
      * storage/indexeddb/objectstore-basics-expected.txt:
      * storage/indexeddb/objectstore-basics-workers-expected.txt:
      * storage/indexeddb/objectstore-count-expected.txt:
      * storage/indexeddb/open-cursor-expected.txt:
      * storage/indexeddb/readonly-expected.txt:
      * storage/indexeddb/removed-expected.txt:
      * storage/indexeddb/resources/basics.js:
      * storage/indexeddb/resources/constants.js: Removed.
      * storage/indexeddb/resources/create-and-remove-object-store.js:
      * storage/indexeddb/resources/cursor-continue-dir.js:
      * storage/indexeddb/resources/cursor-continue.js:
      * storage/indexeddb/resources/cursor-update.js:
      * storage/indexeddb/resources/deleteIndex.js:
      * storage/indexeddb/resources/exceptions.js:
      * storage/indexeddb/resources/factory-cmp.js:
      * storage/indexeddb/resources/get-keyrange.js:
      * storage/indexeddb/resources/index-basics.js:
      * storage/indexeddb/resources/index-count.js:
      * storage/indexeddb/resources/index-unique.js:
      * storage/indexeddb/resources/intversion-close-in-upgradeneeded.js:
      * storage/indexeddb/resources/invalid-keys.js:
      * storage/indexeddb/resources/key-generator.js:
      * storage/indexeddb/resources/key-type-array.js:
      * storage/indexeddb/resources/keypath-edges.js:
      * storage/indexeddb/resources/keyrange.js:
      * storage/indexeddb/resources/objectstore-autoincrement.js:
      * storage/indexeddb/resources/objectstore-basics.js:
      * storage/indexeddb/resources/objectstore-count.js:
      * storage/indexeddb/resources/open-cursor.js:
      * storage/indexeddb/resources/readonly.js:
      * storage/indexeddb/resources/removed.js:
      * storage/indexeddb/resources/shared.js:
      * storage/indexeddb/resources/transaction-abort.js:
      * storage/indexeddb/resources/transaction-active-flag.js:
      * storage/indexeddb/resources/transaction-basics.js:
      * storage/indexeddb/resources/transaction-complete-workers.js:
      * storage/indexeddb/resources/transaction-error.js:
      * storage/indexeddb/resources/transaction-read-only.js:
      * storage/indexeddb/transaction-abort-expected.txt:
      * storage/indexeddb/transaction-active-flag-expected.txt:
      * storage/indexeddb/transaction-basics-expected.txt:
      * storage/indexeddb/transaction-complete-workers-expected.txt:
      * storage/indexeddb/transaction-error-expected.txt:
      * storage/indexeddb/transaction-read-only-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f03a4627
    • wjmaclean@chromium.org's avatar
      [chromium] Fix indenting in RenderThemeChromiumSkia.h. · 084b3e77
      wjmaclean@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102965
      
      Reviewed by Adam Barth.
      
      Much of RenderThemeChromiumSkia.h was indented too far, making the
      file confusing to read. This CL removes the extra indents.
      
      * rendering/RenderThemeChromiumSkia.h:
      (RenderThemeChromiumSkia):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      084b3e77
    • mifenton@rim.com's avatar
      [BlackBerry] Switch to point instead of VisiblePosition comparison for input bounds check · 7661e08b
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102962
      
      Reviewed by Rob Buis.
      
      PR 247270.
      
      Switch from using VisiblePosition to determine if we are in a node
      to a comparison of the field bounds.  This fixes the case where
      there is no node before the target node to match.
      
      Reviewed Internally by Gen Mak.
      
      * WebKitSupport/DOMSupport.cpp:
      * WebKitSupport/DOMSupport.h:
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7661e08b
    • akling@apple.com's avatar
      Make it possible for elements with different tag names to share attribute data. · 538726ff
      akling@apple.com authored
      <http://webkit.org/b/102845>
      
      Reviewed by Antti Koivisto.
      
      Allow all elements to share ElementAttributeData with one another. This means that the elements
      in this hypothetical markup will all point to the same attribute data:
      
          <div class="foo">
              <span class="foo">
                  <hr class="foo"/>
              </span>
          </div>
      
      This optimization happens at the expense of an old one. We no longer share attribute data
      between elements that have presentation attributes, since they map to different CSS properties
      depending on what tag they're attached to. These are mostly used in ye olde web 1.0 content
      though, and we should prefer optimizing in favor of modern markup. The global cache for
      presentation attribute style in StyledElement.cpp still prevents redundant parsing.
      
      On the upside, excluding elements with presentation attributes from the data cache means that
      we can move one pointer (m_presentationAttributeStyle) from ImmutableElementAttributeData
      to MutableElementAttributeData.
      
      800kB progression on Membuster3.
      
      * dom/Document.h:
      * dom/Document.cpp:
      (WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
      (WebCore::ImmutableAttributeDataCacheKey::operator!=):
      (WebCore::ImmutableAttributeDataCacheKey::hash):
      (ImmutableAttributeDataCacheKey):
      (WebCore::Document::cachedImmutableAttributeData):
      * dom/Element.cpp:
      (WebCore::Element::parserSetAttributes):
      
          Don't use the element's tag name in the key for the immutable attribute data cache.
      
      (WebCore::Element::cloneAttributesFromElement):
      
          Prevent cloneNode() from converting mutable attribute data to immutable if it has
          presentation attributes.
      
      * dom/ElementAttributeData.cpp:
      (WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):
      
          Add an assertion that mutable-to-immutable conversion never happens with presentation
          attribute style present.
      
      (WebCore::ElementAttributeData::ElementAttributeData):
      (WebCore::MutableElementAttributeData::MutableElementAttributeData):
      (WebCore::ElementAttributeData::reportMemoryUsage):
      * dom/ElementAttributeData.h:
      (ElementAttributeData):
      (MutableElementAttributeData):
      (WebCore::ElementAttributeData::presentationAttributeStyle):
      (WebCore):
      (WebCore::ElementAttributeData::setPresentationAttributeStyle):
      
          Move the RefPtr<StylePropertySet> that holds presentation attribute-derived style
          from the common ElementAttributeData base class to MutableElementAttributeData.
      
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::attributeChanged):
      
          Always dirty the presentation attribute style when a presentation attribute changes.
      
      (WebCore::StyledElement::rebuildPresentationAttributeStyle):
      
          Force promotion to mutable attribute data when it turns out that we need to hang a
          StylePropertySet with the presentation attribute style off of it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      538726ff
    • reed@google.com's avatar
      update expectations in advance of skia deps roll · bf453d28
      reed@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102964
      
      Reviewed by NOBODY. expectations change only.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf453d28
    • antti@apple.com's avatar
      Replace NodeRendererFactory class with a function · f3e39858
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=102950
      
      Reviewed by Andreas Kling.
      
      Simplify the code by turning NodeRendererFactory single-use class into function of NodeRenderingContext.
      
      * dom/Node.cpp:
      (WebCore::Node::createRendererIfNeeded):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore):
      (WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
      (WebCore::NodeRenderingContext::createRendererIfNeeded):
      * dom/NodeRenderingContext.h:
      (NodeRenderingContext):
      (WebCore::NodeRenderingContext::style):
      (WebCore):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3e39858