1. 04 Jun, 2010 40 commits
    • barraclough@apple.com's avatar
      Bug 40187 - Change function signature of NativeConstructor to match NativeFunction · 11d351a9
      barraclough@apple.com authored
      Reviewed by Oliver Hunt.
      
      Mostly for consistency, but constructor & args arguments are redundant,
      and this will help if we wish to be able to JIT calls to more constructors.
      
      JavaScriptCore: 
      
      * API/JSCallbackConstructor.cpp:
      (JSC::constructJSCallback):
      * API/JSCallbackObject.h:
      * API/JSCallbackObjectFunctions.h:
      (JSC::::construct):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::executeConstruct):
      * interpreter/Interpreter.h:
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * runtime/ArrayConstructor.cpp:
      (JSC::constructWithArrayConstructor):
      * runtime/BooleanConstructor.cpp:
      (JSC::constructWithBooleanConstructor):
      * runtime/ConstructData.cpp:
      (JSC::construct):
      * runtime/ConstructData.h:
      * runtime/DateConstructor.cpp:
      (JSC::constructWithDateConstructor):
      * runtime/Error.cpp:
      (JSC::constructNativeError):
      (JSC::Error::create):
      * runtime/ErrorConstructor.cpp:
      (JSC::constructWithErrorConstructor):
      * runtime/FunctionConstructor.cpp:
      (JSC::constructWithFunctionConstructor):
      * runtime/NativeErrorConstructor.cpp:
      (JSC::constructWithNativeErrorConstructor):
      * runtime/NativeErrorConstructor.h:
      (JSC::NativeErrorConstructor::errorStructure):
      * runtime/NumberConstructor.cpp:
      (JSC::constructWithNumberConstructor):
      * runtime/ObjectConstructor.cpp:
      (JSC::constructWithObjectConstructor):
      * runtime/RegExpConstructor.cpp:
      (JSC::constructWithRegExpConstructor):
      * runtime/StringConstructor.cpp:
      (JSC::constructWithStringConstructor):
      
      WebCore: 
      
      * bindings/js/JSArrayBufferConstructor.cpp:
      (WebCore::constructCanvasArrayBuffer):
      * bindings/js/JSAudioConstructor.cpp:
      (WebCore::constructAudio):
      * bindings/js/JSEventSourceConstructor.cpp:
      (WebCore::constructEventSource):
      * bindings/js/JSFloatArrayConstructor.cpp:
      (WebCore::constructCanvasFloatArray):
      * bindings/js/JSImageConstructor.cpp:
      (WebCore::constructImage):
      * bindings/js/JSInt16ArrayConstructor.cpp:
      (WebCore::constructCanvasShortArray):
      * bindings/js/JSInt32ArrayConstructor.cpp:
      (WebCore::constructCanvasIntArray):
      * bindings/js/JSInt8ArrayConstructor.cpp:
      (WebCore::constructCanvasByteArray):
      * bindings/js/JSMessageChannelConstructor.cpp:
      (WebCore::JSMessageChannelConstructor::construct):
      * bindings/js/JSMessageChannelConstructor.h:
      * bindings/js/JSOptionConstructor.cpp:
      (WebCore::constructHTMLOptionElement):
      * bindings/js/JSSharedWorkerConstructor.cpp:
      (WebCore::constructSharedWorker):
      * bindings/js/JSUint16ArrayConstructor.cpp:
      (WebCore::constructCanvasUnsignedShortArray):
      * bindings/js/JSUint32ArrayConstructor.cpp:
      (WebCore::constructCanvasUnsignedIntArray):
      * bindings/js/JSUint8ArrayConstructor.cpp:
      (WebCore::constructCanvasUnsignedByteArray):
      * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
      (WebCore::constructWebKitCSSMatrix):
      * bindings/js/JSWebKitPointConstructor.cpp:
      (WebCore::constructWebKitPoint):
      * bindings/js/JSWebSocketConstructor.cpp:
      (WebCore::constructWebSocket):
      * bindings/js/JSWorkerConstructor.cpp:
      (WebCore::constructWorker):
      * bindings/js/JSXMLHttpRequestConstructor.cpp:
      (WebCore::constructXMLHttpRequest):
      * bindings/js/JSXSLTProcessorConstructor.cpp:
      (WebCore::constructXSLTProcessor):
      * bindings/scripts/CodeGeneratorJS.pm:
      * bridge/runtime_object.cpp:
      (JSC::Bindings::callRuntimeConstructor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11d351a9
    • senorblanco@chromium.org's avatar
      2010-06-04 Stephen White <senorblanco@chromium.org> · 960c575d
      senorblanco@chromium.org authored
              Unreviewed; expectations fix.
      
              Fix chromium test expectations, post-r60693.  We are still failing the test in the same way, but since there are now fallback results, our results are no longer MISSING, but TEXT.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      960c575d
    • adachan@apple.com's avatar
      Reviewed by Anders Carlsson. · 20c78167
      adachan@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=40186
              
              Need to close WebPageProxy when the WebView is destroyed.
              Also, WebPageProxy shouldn't hold an OwnPtr to the PageClient, which is the WebView on Windows.
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::WebPageProxy):
              (WebKit::WebPageProxy::setPageClient):
              * UIProcess/WebPageProxy.h:
              * UIProcess/win/WebView.cpp:
              (WebKit::WebView::close):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20c78167
    • abarth@webkit.org's avatar
      2010-06-04 Adam Barth <abarth@webkit.org> · 68ce28d4
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make HTML5Lexer go fast
              https://bugs.webkit.org/show_bug.cgi?id=40048
      
              Change the intent of the loop to match what it's going to be once we
              remove the loop.  This is a whitespace only change that will make the
              final diff much, much smaller.  Sorry for the transient ugly style.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::nextToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68ce28d4
    • abarth@webkit.org's avatar
      2010-06-04 Adam Barth <abarth@webkit.org> · e1007685
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make HTML5Lexer go fast
              https://bugs.webkit.org/show_bug.cgi?id=40048
      
              Introduce ADVANCE_TO macro.  This is the last macro we need to
              introduce.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::nextToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1007685
    • abarth@webkit.org's avatar
      2010-06-04 Adam Barth <abarth@webkit.org> · 6119e482
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make HTML5Lexer go fast
              https://bugs.webkit.org/show_bug.cgi?id=40048
      
              Fix the rest of the RECONSUME_IN cases that were missed by our script.
              Also, reorder some assigment to prepare for the ADVANCE_TO patch.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::nextToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6119e482
    • abarth@webkit.org's avatar
      2010-06-04 Adam Barth <abarth@webkit.org> · d59e97e1
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make HTML5Lexer go fast
              https://bugs.webkit.org/show_bug.cgi?id=40048
      
              This patch handles the FLUSH_AND_ADVANCE_TO case.  Again, this patch
              introduces style errors that will be fixed shortly.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::nextToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d59e97e1
    • mrobinson@webkit.org's avatar
      2010-06-04 Martin Robinson <mrobinson@igalia.com> · ee7d9c38
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
              https://bugs.webkit.org/show_bug.cgi?id=40182
      
              Instead of invoking signal handlers directly via g_signal_emit_by_name, call
              gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
              without breaking DRT.
      
              * DumpRenderTree/gtk/EventSender.cpp:
              (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
              (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee7d9c38
    • abarth@webkit.org's avatar
      2010-06-04 Adam Barth <abarth@webkit.org> · c5702186
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make HTML5Lexer go fast
              https://bugs.webkit.org/show_bug.cgi?id=40048
      
              This patch handles the FLUSH_EMIT_AND_RESUME_IN case.  This patch
              introduces some bad style w.r.t. one-line if statements, but we'll fix
              them all automatically in cleanup patch when we're done.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::nextToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5702186
    • senorblanco@chromium.org's avatar
      2010-06-04 Stephen White <senorblanco@chromium.org> · ffc2a1fb
      senorblanco@chromium.org authored
              Unreviewed; build fix.
      
              [CHROMIUM] Add new chromium test results for new layout test svg/filters/filter-on-filter-for-text.svg
      
              * platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
              * platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
              * platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.png: Added.
              * platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffc2a1fb
    • abarth@webkit.org's avatar
      2010-06-04 Adam Barth <abarth@webkit.org> · fa4a8307
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make HTML5Lexer go fast
              https://bugs.webkit.org/show_bug.cgi?id=40048
      
              More small steps.  This patch deals with emitting tokens.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::nextToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa4a8307
    • abarth@webkit.org's avatar
      2010-06-04 Adam Barth <abarth@webkit.org> · 8e179b93
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make HTML5Lexer go fast
              https://bugs.webkit.org/show_bug.cgi?id=40048
      
              The next step: using macros to delimit each state.  Evetually, we're
              going to change what these macros expand to.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::nextToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e179b93
    • eric@webkit.org's avatar
      2010-06-04 Jay Civelli <jcivelli@chromium.org> · 762a4295
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Accessibility focus change notifications are now sent from
              ChromeClientImpl::focusedNodeChanged().
              https://bugs.webkit.org/show_bug.cgi?id=39792
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::focus):
              (WebKit::ChromeClientImpl::focusedNodeChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      762a4295
    • abarth@webkit.org's avatar
      2010-06-04 Adam Barth <abarth@webkit.org> · 88ce5b4f
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make HTML5Lexer go fast
              https://bugs.webkit.org/show_bug.cgi?id=40048
      
              We're going to do this patch in small steps to make it easier to verify correctness.
      
              * html/HTML5Lexer.cpp:
              (WebCore::HTML5Lexer::nextToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88ce5b4f
    • andersca@apple.com's avatar
      2010-06-04 Anders Carlsson <andersca@apple.com> · 87dbb021
      andersca@apple.com authored
              Reviewed by David Hyatt.
      
              Make the editing/spelling/context-menu-suggestions.html test more robust
              https://bugs.webkit.org/show_bug.cgi?id=40178
      
              * editing/spelling/context-menu-suggestions-expected.txt: Added.
              Add new expected test result.
              
              * editing/spelling/context-menu-suggestions.html:
              Instead of dumping the menu item titles, check the length and check that the number of items is greater when
              there are spell checker suggestions.
      
              * platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Removed.
              * platform/mac-snowleopard/editing/spelling/context-menu-suggestions-expected.txt: Removed.
              * platform/mac-tiger/editing/spelling/context-menu-suggestions-expected.txt: Removed.
              Remove platform specific versions.
      2010-06-04  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by David Hyatt.
      
              Make the editing/spelling/context-menu-suggestions.html test more robust
              https://bugs.webkit.org/show_bug.cgi?id=40178
      
              Change the contextClick method to return an array of strings describing the context menu items.
      
              * DumpRenderTree/mac/EventSendingController.mm:
              (+[EventSendingController isSelectorExcludedFromWebScript:]):
              (+[EventSendingController webScriptNameForSelector:]):
              (-[EventSendingController contextClick]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87dbb021
    • eric@webkit.org's avatar
      2010-06-04 Jay Civelli <jcivelli@chromium.org> · 8fa8410b
      eric@webkit.org authored
              Reviewed by David Levin.
      
              [chromium] Adding support for the left and right Windows keys to the
                         NativeWebKeyboardEvent.
              https://bugs.webkit.org/show_bug.cgi?id=39752
      
              * platform/chromium/KeyCodeConversionGtk.cpp:
              (WebCore::windowsKeyCodeForKeyEvent):
      2010-06-04  Jay Civelli  <jcivelli@chromium.org>
      
              Reviewed by David Levin.
      
              [chromium] Adding support for the left and right Windows keys to the
                         NativeWebKeyboardEvent.
              https://bugs.webkit.org/show_bug.cgi?id=39752
      
              * src/gtk/WebInputEventFactory.cpp:
              (WebKit::gdkEventToWindowsKeyCode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fa8410b
    • adachan@apple.com's avatar
      Reviewed by Adam Roben. · 518865ab
      adachan@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=40152
              
              Need to remove the WebView from WindowMessageBroadcaster's listeners list when the WebView is destroyed.
      
              * UIProcess/API/win/WKView.cpp:
              (WKViewSetHostWindow): Expose API to change the host window of a WKView.
              (WKViewWindowAncestryDidChange): Expose API to allow clients to notify WebKit when a WKView's window ancestry has changed.
              * UIProcess/API/win/WKView.h:
              * UIProcess/win/WebView.cpp:
              (WebKit::WebView::wndProc): Set the WebView's host window to 0 when it's destroyed.  setHostWindow() will call 
              windowAncestryDidChange(), which will remove this WebView from the WindowMessageBroadcaster's listeners list.
              (WebKit::WebView::WebView): Initialize m_isBeingDestroyed.
              (WebKit::WebView::setHostWindow): Update the window's parent window and call windowAncestryDidChange().
              (WebKit::WebView::close): Set the host window to 0.
              * UIProcess/win/WebView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      518865ab
    • kinuko@chromium.org's avatar
      2010-06-03 Kinuko Yasuda <kinuko@chromium.org> · c2257ae5
      kinuko@chromium.org authored
              Reviewed by Shinichiro Hamaji.
      
              Clean up chromium-specific code from json_results_generator.py.
              https://bugs.webkit.org/show_bug.cgi?id=39665
      
              * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
              * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
              * Scripts/webkitpy/layout_tests/port/base.py:
              * Scripts/webkitpy/layout_tests/port/chromium.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2257ae5
    • krit@webkit.org's avatar
      2010-06-04 Dirk Schulze <krit@webkit.org> · 07954685
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG filter on filter don't work
              https://bugs.webkit.org/show_bug.cgi?id=32708
              
              Any child of <text> was not allowed to use the same filter as the text root. 
              I couldn't found any reason in the SVG specification that legimitate this.
              Only batik also doesn't allow the same filter on the text root as on it's childs,
              while any other effect is still allowed.
              I removed this limitation so that the result looks like the result on Firefox.
      
              Test: svg/filters/filter-on-filter-for-text.svg
      
              * rendering/SVGRenderSupport.cpp:
              (WebCore::SVGRenderBase::prepareToRenderSVGContent):
              * rendering/SVGRenderSupport.h:
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
              (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
              (WebCore::SVGRootInlineBox::paint):
      2010-06-04  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              SVG filter on filter don't work
              https://bugs.webkit.org/show_bug.cgi?id=32708
              
              Test that a filter can be used by the text root as well as on it's childs.
      
              * platform/mac/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
              * platform/mac/svg/filters/filter-on-filter-for-text-expected.png: Added.
              * platform/mac/svg/filters/filter-on-filter-for-text-expected.txt: Added.
              * svg/filters/filter-on-filter-for-text.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07954685
    • japhet@chromium.org's avatar
      2010-06-04 Nate Chapin <japhet@chromium.org> · d48109cb
      japhet@chromium.org authored
              Reviewed by Adam Barth.
      
              Factor PageCache functionality out of FrameLoader and into
              PageCache itself.
      
              https://bugs.webkit.org/show_bug.cgi?id=39382
      
              Refactor only, so no new tests.
      
              * history/PageCache.cpp:
              (WebCore::pageCacheLogPrefix):
              (WebCore::pageCacheLog):
              (WebCore::logCanCacheFrameDecision):
              (WebCore::logCanCachePageDecision):
              (WebCore::PageCache::canCachePageContainingThisFrame):
              (WebCore::PageCache::canCache):
              (WebCore::PageCache::add):
              (WebCore::PageCache::get):
              * history/PageCache.h:
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::commitIfReady):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::prepareForCachedPageRestore):
              (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
              (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
              (WebCore::FrameLoader::navigateToDifferentDocument):
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::quickRedirectComing):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d48109cb
    • loislo@chromium.org's avatar
      2010-06-04 Ilya Tikhonovsky <loislo@chromium.org> · 4bfbcc11
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              WebInspector: Web Inspector: it would be better to push object properties to JSON string in order of insertion.
              https://bugs.webkit.org/show_bug.cgi?id=40140
      
              * inspector/InspectorValues.cpp:
              (WebCore::InspectorObject::writeJSON):
              * inspector/InspectorValues.h:
              (WebCore::InspectorObject::setBool):
              (WebCore::InspectorObject::setNumber):
              (WebCore::InspectorObject::setString):
              (WebCore::InspectorObject::set):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bfbcc11
    • laszlo.1.gombos@nokia.com's avatar
      2010-06-04 Laszlo Gombos <laszlo.1.gombos@nokia.com> · b3ff92dd
      laszlo.1.gombos@nokia.com authored
              Symbian build fix.
      
              [Qt] Updated the def file with recent new exports.
      
              * symbian/eabi/QtWebKitu.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3ff92dd
    • ap@apple.com's avatar
      Unreviewed. · 6988a5ee
      ap@apple.com authored
              Unskip fast/dom/Window/window-properties-geolocation.html - a comment says it should be
              enabled once bug 34025 is fixed, which happened long ago. The test passes for me.
      
              * platform/mac/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6988a5ee
    • eric@webkit.org's avatar
      2010-06-04 Tony Gentilcore <tonyg@chromium.org> · aadf2de8
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Persist V8's ScriptData to the memory cache.
              https://bugs.webkit.org/show_bug.cgi?id=38661
      
              This stores V8's ScriptData in the memory cache and also causes the
              network platform layer to be notified of the available cacheable
              metadata.
      
              Chromium's morejs benchmark shows a 3-4% improvement on fast hardware.
      
              No new tests because no new functionality.
      
              * bindings/v8/ScriptSourceCode.h:
              (WebCore::ScriptSourceCode::ScriptSourceCode):
              (WebCore::ScriptSourceCode::cachedScript):
              * bindings/v8/V8Proxy.cpp:
              (WebCore::V8Proxy::compileScript):
              (WebCore::V8Proxy::precompileScript):
              (WebCore::V8Proxy::evaluate):
              * bindings/v8/V8Proxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aadf2de8
    • eric@webkit.org's avatar
      2010-06-04 Tony Gentilcore <tonyg@chromium.org> · 2a276abe
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Add a takeFirst() method to Deque and use it where appropriate.
              https://bugs.webkit.org/show_bug.cgi?id=40089
      
              * wtf/Deque.h:
              (WTF::::takeFirst):
              * wtf/MainThread.cpp:
              (WTF::dispatchFunctionsFromMainThread):
              * wtf/MessageQueue.h:
              (WTF::::tryGetMessage):
      2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Adam Barth.
      
              Utilize new takeFirst() method where appropriate.
              https://bugs.webkit.org/show_bug.cgi?id=40089
      
              No new tests because no new functionality.
      
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::addSubresourceStyleURLs):
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::PendingCallbacks::callAndRemoveFirstCallback):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::reset):
              (WebCore::HTMLTokenizer::executeExternalScriptsIfReady):
              * platform/text/SegmentedString.cpp:
              (WebCore::SegmentedString::advanceSubstring):
              * storage/Database.cpp:
              (WebCore::Database::scheduleTransaction):
              * storage/SQLTransaction.cpp:
              (WebCore::SQLTransaction::getNextStatement):
              * storage/SQLTransactionCoordinator.cpp:
              (WebCore::SQLTransactionCoordinator::processPendingTransactions):
      2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Adam Barth.
      
              Utilize new takeFirst() method where appropriate.
              https://bugs.webkit.org/show_bug.cgi?id=40089
      
              * Platform/CoreIPC/ArgumentDecoder.cpp:
              (CoreIPC::ArgumentDecoder::removeAttachment):
      2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
      
              Reviewed by Adam Barth.
      
              Utilize new takeFirst() method where appropriate.
              https://bugs.webkit.org/show_bug.cgi?id=40089
      
              * DumpRenderTree/chromium/EventSender.cpp:
              (EventSender::replaySavedEvents):
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::WorkQueue::processWork):
              (LayoutTestController::WorkQueue::reset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a276abe
    • eric@webkit.org's avatar
      2010-06-04 Nikita Vasilyev <me@elv1s.ru> · 36f3c5b6
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: better Function.prototype.bind for the internal code.
      
              In the "Event Listeners" pane show handler function instead of Function.prototype.bind.
      
              https://bugs.webkit.org/show_bug.cgi?id=40080
      
              * inspector/front-end/utilities.js:
              (Function.prototype.bind.bound):
              (Function.prototype.bind.bound.toString):
              (Function.prototype.bind):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36f3c5b6
    • apavlov@chromium.org's avatar
      2010-06-04 Alexander Pavlov <apavlov@chromium.org> · 6956858f
      apavlov@chromium.org authored
              Unreviewed, fix Qt build.
      
              Add references to a new file.
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/front-end/WebKit.qrc:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6956858f
    • apavlov@chromium.org's avatar
      2010-06-04 Alexander Pavlov <apavlov@chromium.org> · 8ec76011
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Eliminate direct dependency of StylesSidebarPane on InspectorBackend
              https://bugs.webkit.org/show_bug.cgi?id=40069
      
              No new tests are needed, as this is a refactoring.
      
              * inspector/front-end/CSSStyleModel.js: Added.
              (WebInspector.CSSStyleModel):
              (WebInspector.CSSStyleModel.prototype.getStylesAsync):
              (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
              (WebInspector.CSSStyleModel.prototype.setRuleSelector):
              (WebInspector.CSSStyleModel.prototype.addRule):
              (WebInspector.CSSStyleModel.prototype.toggleStyleEnabled):
              (WebInspector.CSSStyleModel.prototype.setCSSText):
              (WebInspector.CSSStyleModel.prototype.applyStyleText):
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylesSidebarPane.prototype.update.stylesCallback):
              (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback):
              (WebInspector.StylesSidebarPane.prototype.update):
              (WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty):
              (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
              (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
              (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
              (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
              (WebInspector.StylePropertyTreeElement.prototype.):
              (WebInspector.StylePropertyTreeElement.prototype):
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector.loaded):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ec76011
    • yurys@chromium.org's avatar
      2010-06-04 Pavel Podivilov <podivilov@chromium.org> · 2b50586e
      yurys@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Create resource for DebuggerScript.js.
              https://bugs.webkit.org/show_bug.cgi?id=40122
      
              * WebKit.grd:
              * public/WebDevToolsAgentClient.h:
              (WebKit::WebDevToolsAgentClient::debuggerScriptSource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b50586e
    • yael.aharon@nokia.com's avatar
      [Qt] QtTestLauncher should allow notifications by default. · c5164ad9
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=40078
      
      Reviewed by Simon Hausmann.
      
      * QtTestBrowser/main.cpp:
      (NotificationsPermissionController::NotificationsPermissionController):
      (NotificationsPermissionController::checkPermission):
      (NotificationsPermissionController::requestPermission):
      (LauncherWindow::LauncherWindow):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5164ad9
    • hausmann@webkit.org's avatar
      [Qt] Compilation fails when compiling against Qt 4.7 and Qt Mobility is installed · a8302ac6
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=40116
      
      Reviewed by Tor Arne Vestbø.
      
      CONFIG += mobility has the side-effect of pulling in mobility includes, which conflict
      with Qt 4.7's bearer managenent includes and break the build.
      
      * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8302ac6
    • eric@webkit.org's avatar
      2010-06-04 Vangelis Kokkevis <vangelis@chromium.org> · cb723533
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [chromium] Fix scrolling bug with pages using accelerated compositing.
              https://bugs.webkit.org/show_bug.cgi?id=40037
      
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::LayerRendererChromium):
              (WebCore::LayerRendererChromium::drawLayers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb723533
    • eric@webkit.org's avatar
      2010-06-04 Matthew Delaney <mdelaney@apple.com> · 01c309b8
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              CG implementation needed for compression quality in canvas.toDataURL
              https://bugs.webkit.org/show_bug.cgi?id=38492
      
              * platform/mac/Skipped:
      2010-06-04  Matthew Delaney  <mdelaney@apple.com>
      
              Reviewed by Darin Adler.
      
              CG implementation needed for compression quality in canvas.toDataURL
              https://bugs.webkit.org/show_bug.cgi?id=38492
      
              Took toDataURL.jpeg.quality.basic.html test off of Skipped list. Passes.
      
              Went the route of avoiding in-band signaling to flag the use of a quality
              parameter or not. So, instead of simply passing the quality down as a
              double, instead I pass a reference to the quality parameter from where
              it comes in just after the JS bindings. Thus, no need for any global
              constants to signify when the quality is not specified. Updated the other
              platforms to support this (qt was on the only one currently with any
              implementation).
      
              * bindings/js/JSHTMLCanvasElementCustom.cpp: Moved range check logic for quality parameter down lower. Updated
              call to toDataURL to use double* instead of just passing the quality directly.
              (WebCore::JSHTMLCanvasElement::toDataURL):
              * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Updated toDataURL call to pass double*
              (WebCore::V8HTMLCanvasElement::toDataURLCallback):
              * dom/CanvasSurface.cpp: Updated method prototype.
              (WebCore::CanvasSurface::toDataURL):
              * dom/CanvasSurface.h: Updated method prototype.
              (WebCore::CanvasSurface::toDataURL):
              * platform/graphics/ImageBuffer.h: Updated method signature to use double* for quality param.
              * platform/graphics/cairo/ImageBufferCairo.cpp: Updated prototype for consistency.
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/cg/ImageBufferCG.cpp: Implemented support for quality parametejr when jpeg MIME type used.
              (WebCore::jpegUTI):
              (WebCore::utiFromMIMEType):
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/haiku/ImageBufferHaiku.cpp: Updated prototype for consistency.
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/qt/ImageBufferQt.cpp: Updated prototype for consistency.
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/skia/ImageBufferSkia.cpp: Updated prototype for consistency.
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/wince/ImageBufferWince.cpp: Updated prototype for consistency.
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/wx/ImageBufferWx.cpp: Updated prototype for consistency.
              (WebCore::ImageBuffer::toDataURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01c309b8
    • tkent@chromium.org's avatar
      Unreviewed. Rolling out r60671 because it caused a lot of test · e195240d
      tkent@chromium.org authored
      failures on Chromium.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e195240d
    • alex@webkit.org's avatar
      2010-06-04 Alejandro G. Castro <alex@igalia.com> · ba91eca4
      alex@webkit.org authored
              Reviewed by Xan Lopez.
      
              Leaks in listDirectory
              https://bugs.webkit.org/show_bug.cgi?id=40008
      
              Fixed both leaks.
      
              * platform/gtk/FileSystemGtk.cpp:
              (WebCore::listDirectory):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba91eca4
    • steveblock@google.com's avatar
    • eric@webkit.org's avatar
      2010-06-04 Victoria Kirst <vrk@google.com> · 93a64066
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Modifying the WebMediaPlayer interface to be compatible with
              a change in chrome.
              This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
              has been updated, so this commit should NOT break chromium anymore.
              https://bugs.webkit.org/show_bug.cgi?id=39445
      
              * public/WebMediaPlayer.h: Changed buffered() to be non-const.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93a64066
    • eric@webkit.org's avatar
      2010-06-04 Anton Muhin <antonm@chromium.org> · 69429752
      eric@webkit.org authored
              Reviewed by Nate Chapin.
      
              [Chromium] get rid of named interceptor on HTMLDocument and introduce/remove accessors when named items get deleted/removed
              https://bugs.webkit.org/show_bug.cgi?id=39877
      
              This patch makes callbacks invoked on named items addition/removal
              install API accessors and thus there is no more need in
              named and indexed interceptors on HTMLDocument which
              speeds up invocation of methods on document.
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::namedItemAdded):
              (WebCore::ScriptController::namedItemRemoved):
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::checkDocumentWrapper):
              (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
              (WebCore::getter):
              (WebCore::V8DOMWindowShell::namedItemAdded):
              (WebCore::V8DOMWindowShell::namedItemRemoved):
              * bindings/v8/V8DOMWindowShell.h:
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::instantiateV8Object):
              * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
              (WebCore::V8HTMLDocument::WrapInShadowObject):
              (WebCore::V8HTMLDocument::GetNamedProperty):
              (WebCore::V8HTMLDocument::allAccessorSetter):
              (WebCore::toV8):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69429752
    • steveblock@google.com's avatar
      2010-06-04 Steve Block <steveblock@google.com> · 8f81b0f4
      steveblock@google.com authored
              Reviewed by Jeremy Orlow.
      
              Geolocation needs more LayoutTests to test making callbacks to remote frames
              https://bugs.webkit.org/show_bug.cgi?id=40146
      
              This test is similar to callback-to-remote-context.html in that it test making a callback
              from a Geolocation object to a remote frame. In callback-to-remote-context.html, the call
              chain to the Geolocation method is started from the owning frame. In this test, however,
              the call chain is started from the remote frame.
      
              * fast/dom/Geolocation/callback-to-remote-context2-expected.txt: Added.
              * fast/dom/Geolocation/callback-to-remote-context2.html: Added.
              * fast/dom/Geolocation/script-tests/callback-to-remote-context2.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f81b0f4
    • eric@webkit.org's avatar
      2010-06-04 Kwang Yul Seo <skyul@company100.net> · 65d65358
      eric@webkit.org authored
              Reviewed by Kent Tamura.
      
              Change filenameFromString to return CString
              https://bugs.webkit.org/show_bug.cgi?id=39494
      
              filenameFromString returns a newly allocated string and the caller must
              free the string. GTK and EFL ports use g_free while all others ports use
              fastFree. This is confusing because the same function behaves
              differently with respect to ports. Change filenameFromString to return
              CString.
      
              * platform/FileSystem.cpp:
              (WebCore::filenameFromString):
              * platform/FileSystem.h:
              * platform/efl/FileSystemEfl.cpp:
              (WebCore::filenameFromString):
              * platform/gtk/FileChooserGtk.cpp:
              (WebCore::FileChooser::basenameForWidth):
              * platform/gtk/FileSystemGtk.cpp:
              (WebCore::filenameFromString):
              (WebCore::filenameForDisplay):
              (WebCore::fileExists):
              (WebCore::deleteFile):
              (WebCore::deleteEmptyDirectory):
              (WebCore::getFileSize):
              (WebCore::getFileModificationTime):
              (WebCore::makeAllDirectories):
              (WebCore::pathGetFileName):
              (WebCore::directoryName):
              (WebCore::listDirectory):
              * platform/gtk/SharedBufferGtk.cpp:
              (WebCore::SharedBuffer::createWithContentsOfFile):
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::startHttp):
              * platform/posix/SharedBufferPOSIX.cpp:
              (WebCore::SharedBuffer::createWithContentsOfFile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65d65358