1. 28 Dec, 2002 6 commits
    • kocienda's avatar
      WebCore: · 11bb1581
      kocienda authored
              Reviewed by Gramps and Richard.
      
      	Fix for this bug:
      
      	Radar 3112233 (400 response when attaching files at mail.yahoo.com)
      
      	KHTML multipart form code called into KMimeType class to determine
      	the mime type for file attachments, however, our implementation of
      	KMimeType has only stubs which call ERROR.
      
      	I added some code into KWQKHTMLPart and WebCoreBridge so that the
      	code in html_formimpl can call through to the WebFoundation mime
      	file map we maintain.
      
              * khtml/html/html_formimpl.cpp:
              (HTMLFormElementImpl::formData)
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::mimeTypeForFileName)
              * kwq/WebCoreBridge.h:
      
      WebKit:
      
               Reviewed by Gramps and Richard
      
               Fix for this bug:
      
               Radar 3112233 (400 response when attaching files at mail.yahoo.com)
      
               I added the MIMETypeForPath method which accesses the WebFoundation mime
               file map we maintain. KHTML can now access this map by using the bridge.
      
               * WebCoreSupport.subproj/WebBridge.m:
               (-[WebBridge MIMETypeForPath:])
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11bb1581
    • kocienda's avatar
      Corrected checkin date that I cut and pasted incorrectly. · c2318740
      kocienda authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2318740
    • kocienda's avatar
      Reviewed by Gramps and Ken · e0825e86
      kocienda authored
      	Checked in by Ken
      
      	- fixed 3133207 -- crash in HTMLFrameElementImpl updateForNewURL at home.real.com
      
      	My previous attempt to fix this dealt with the case where a RenderFrame object was
      	not yet created, but not with the case where a RenderFrame object was created without
      	a corresponding part. Somehow I overlooked this last time when I was doing testing.
      	Testing this time confirms this takes care of the remaining problem at movies.real.com.
      
              * khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL):
      	Use the same kind of requestFrame call here as in attach when there's a RenderFrame,
      	but no corresponding part. Maybe we can fix this an even more elegant way later.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0825e86
    • kocienda's avatar
      Reviewed by Gramps and Ken. · 69335a5d
      kocienda authored
      	Checked in by Ken.
      
      	- fixed 3134693 -- carsdirect.com crash on used car search, due to large JavaScript array
      
      	The parser was using recursion to handle many types of lists.
      	This meant that we crashed out of stack space when any of the lists were extra big.
      	I applied the same sort of fix we had already applied a while back for argument lists for
      	all the other types of lists, including the list of ElementNode that was the reason for
      	the crash reported here.
      
              * kjs/grammar.y: Removed ElisionNode altogether and just use a count.
      	Use specific node types for PropertyNameAndValueList and PropertyName.
      
              * kjs/grammar.cpp: Regenerated.
              * kjs/grammar.cpp.h: Regenerated.
              * kjs/grammar.h: Regenerated.
      
              * kjs/nodes.h: Elide "ElisionNode", changing objects to keep elision counts instead.
      	Make the ObjectLiteralNode list field be PropertyValueNode, not just Node.
      	Make PropertyValueNode fields have specific types. Add new reverse list functions, calls
      	to those functions in the constructors, and friend declarations as needed so the class
      	that holds the head of a list can reverse the list during parsing.
              * kjs/nodes.cpp:
              (ElementNode::ref): Use iteration instead of recursion. Also elide "elision".
              (ElementNode::deref): Ditto.
              (ElementNode::evaluate): Use iteration instead of recursion, taking advantage of
      	the fact that the linked list is reversed. Also use the elision count rather than
      	an elision list.
              (ArrayNode::reverseElementList): Reverse the list so we can iterate normally.
              (ArrayNode::ref): Elide "elision".
              (ArrayNode::deref): Ditto.
              (ArrayNode::evaluate): Use elision count instead of elision list.
              (ObjectLiteralNode::reverseList): Reverse the list so we can iterate normally.
              (PropertyValueNode::ref): Use iteration instead of recursion.
              (PropertyValueNode::deref): Use iteration instead of recursion.
              (PropertyValueNode::evaluate): Use iteration instead of recursion, taking advantage
      	of the fact that the linked list is reversed.
              (ArgumentListNode::ref): Change code to match the other similar cases we had to revise.
              (ArgumentListNode::deref): Ditto.
              (ArgumentListNode::evaluateList): Ditto.
              (ArgumentsNode::reverseList): Ditto.
              (VarDeclListNode::ref): Use iteration instead of recursion.
              (VarDeclListNode::deref): Ditto.
              (VarDeclListNode::evaluate): Use iteration instead of recursion, taking advantage
      	of the fact that the linked list is reversed.
              (VarDeclListNode::processVarDecls): Ditto.
              (VarStatementNode::reverseList): Reverse the list so we can iterate normally.
              (FunctionBodyNode::FunctionBodyNode): Use BlockNode as the base class, removing
      	most of the FunctionBodyNode class.
      
              * kjs/nodes2string.cpp:
              (ElementNode::streamTo): Update for using a count for elision, and reverse linking.
              (ArrayNode::streamTo): Update for using a count for elision.
              (PropertyValueNode::streamTo): Update for reverse linking.
              (ArgumentListNode::streamTo): Update for reverse linking. This has been wrong for
      	a while, since we added the reverse a long time ago.
              (VarDeclListNode::streamTo): Update for reverse linking.
              (ParameterNode::streamTo): Update for reverse linking.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69335a5d
    • darin's avatar
      Reviewed by Don. · 7570c92e
      darin authored
      	- fixed 3136206 -- Can't display images in Ambrosia Software image viewer
      
      	WebKit wasn't creating the frames correctly when they weren't HTML.
      
              * WebView.subproj/WebFramePrivate.m: (-[WebFrame _makeDocumentView]): Added. Calls the
      	WebView to make the document view and then installs the new view, as WebHTMLView used to do.
              (-[WebFrame _transitionToCommitted:]): Call _makeDocumentView instead of calling WebView
      	directly. These are all the calls to _makeDocumentViewForDataSource:.
      
              * WebView.subproj/WebViewPrivate.h: Add return value to _makeDocumentViewForDataSource:.
              * WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):
      	Return the newly-created view.
      
              * WebView.subproj/WebHTMLView.m: (-[WebHTMLView setDataSource:]): Removed the code here
      	since it's done by WebFrame now.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7570c92e
    • darin's avatar
      Reviewed by Don. · ee114f40
      darin authored
      	- fixed 3136262 -- Shockwave Flash at movies.yahoo.com does not work
      
              * khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
      	Moved the class ID special case MIME types out of the if statement so they can be shared
      	in the case where we have an embed tag but no MIME type.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee114f40
  2. 26 Dec, 2002 2 commits
  3. 25 Dec, 2002 2 commits
    • darin's avatar
      Reviewed by Darin. · 5af885b5
      darin authored
      	- fixed 3133611 -- Java "ticker" applet renders badly when scrolling page
      
              * Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewHasMoved:]):
      	Call setWindow so we make a call to the plugin each time it moves, rather than just adjusting
      	the data structure we had passed to it earlier.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5af885b5
    • rjw's avatar
      Fix for 3134543 (and widely reported dupes). Don't use render_text · 8f03ce2d
      rjw authored
              widths cache except for whitespace == PRE.  The problem was that additional
              spaces in the RenderText's string were being inappropiately measured.
              An alternate, more complex and risky, fix would account for the whitespace
              properties during scanning of the RenderText width buffer.  Considering
              the scenario for which this optimization was added (3133261), this
              simpler fix is adequate.
      
              Reviewed by Darin and Don.
      
              * khtml/rendering/render_text.cpp:
              (RenderText::computeWidths):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f03ce2d
  4. 24 Dec, 2002 3 commits
    • darin's avatar
      Reviewed by Don. · 523f0cbf
      darin authored
      	- fixed 3135010 -- nil-dereference in KHTMLPart::xmlDocImpl() at channels.netscape.com
      
              * khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::contentDocument):
              Add missing nil check. Also added lots of FIXME comments about problems I observed here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      523f0cbf
    • darin's avatar
      Reviewed by Richard and Don. · 418f83ec
      darin authored
      	- fixed 3132192 -- HOMEPAGE: Quicktime plug in with AVI content brings Plug-ins not found panel
      
              * Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
      	Lower-case the key before searching for it. This is needed for both MIME types and extensions,
      	since we want case insensitive comparison in both cases.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      418f83ec
    • darin's avatar
      Reviewed by Richard and Don. · a02ae6d8
      darin authored
      	- fixed 3133207 -- crash in HTMLFrameElementImpl updateForNewURL at home.real.com
      
      	My previous attempt to fix this dealt with the case where a RenderFrame object was
      	not yet created, but not with the case where a RenderFrame object was created without
      	a corresponding part. Somehow I overlooked this last time when I was doing testing.
      	Testing this time confirms this takes care of the remaining problem at movies.real.com.
      
              * khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL):
      	Use the same kind of requestFrame call here as in attach when there's a RenderFrame,
      	but no corresponding part. Maybe we can fix this an even more elegant way later.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a02ae6d8
  5. 23 Dec, 2002 8 commits
    • kocienda's avatar
      Alexander 46u commit · 8724c85b
      kocienda authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8724c85b
    • kocienda's avatar
      Building Alex-45 · a193bff1
      kocienda authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a193bff1
    • kocienda's avatar
      Reviewed by me · 5c565391
      kocienda authored
      	Fixed ChangeLog typos in previous commit.
      
              * ChangeLog
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c565391
    • kocienda's avatar
      Reviewed by Darin and Gramps · 60fef03f
      kocienda authored
      	Workaround for this bug:
      
      	Radar 3134219 (MPEG-4 files don't work with the QuickTime plugin in Safari,
      	work fine in Mozilla, IE)
      
      	For beta 1, we For beta 1, when getting the MIME information for the QuickTime
      	plugin, we directly insert the information to handle MP4.
      
      	In the future, we will use the additional plugin entry points to dynamically load
      	this information from the plugin itself.
      
              * Plugins.subproj/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage getMIMEInformation])
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60fef03f
    • darin's avatar
      Reviewed by Don and John. · 92285d33
      darin authored
      	- fixed 3134449 -- Date.UTC returns NaN (invalid date)
      
      	Did more testing of the date functions and made them behave like the other browsers.
      	There were three problems:
      
                  1) We did a validity check that other browsers don't do (hence the NaN).
                  2) We treated passed-in dates as local time even in Date.UTC (hence a wrong result
                     once I fixed the NaN).
                  3) The results of ToUTCString (and ToGMTString) weren't formatted quite the same
      	       as other browsers.
      
      	Also found a couple of silly but unrelated coding mistakes.
      
              * kjs/date_object.cpp:
              (timetUsingCF): Added. Has the guts of mktimeUsingCF, but without the CFGregorianDateIsValid
              check. Other browsers accept invalid dates. Also takes a time zone parameter.
              (mktimeUsingCF): Calls timetUsingCF with the current time zone.
              (timegmUsingCF): Calls timetUsingCF with the UTC time zone.
              (formatDate): Remove the includeComma flag.
              (formatDateUTCVariant): Added. For use instead of formatDate with the includeComma flag.
      	Puts the day before the month name.
              (DateProtoFuncImp::call): Use the new formatDateUTCVariant for ToGMTString and ToUTCString.
      	Without this change the date didn't match other browsers.
              (DateObjectImp::DateObjectImp): Use UTCPropertyName. Somehow I declared this and didn't use
      	it before.
              (DateObjectImp::construct): Pass -1 for is_dst literally instead of using invalidDate.
      	Changing this to invalidDate was just a mistake (although no real difference in compiled
      	code since invalidDate is just -1).
              (DateObjectFuncImp::call): Call timegm for the UTC case instead of mktime.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92285d33
    • darin's avatar
      Reviewed by John and Don. · e72b8ee6
      darin authored
      	- fixed 3134282 -- REGRESSION: text encoding setting reverts when you go to a new location
      
              * WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): Propagate an override encoding if there
      	was an existing data source and it had an override encoding.
              * WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadRequest:triggeringAction:loadType:]): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e72b8ee6
    • darin's avatar
      Reviewed by John. · a5de1758
      darin authored
      	- fixed 3134558 -- REGRESSION: Lord of the Rings site problems
      
      	This regression was caused when we fixed the abcnews.com problem (3124933).
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createEmptyDocument):
      	Despite its name, this function was never intended to overwrite an existing document with
      	an empty document. When we changed it do do the creation in a better way, we lost the
      	check that prevents it from doing anything at all if we already have a document.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5de1758
    • darin's avatar
      Reviewed by NOBODY (OOPS!). · 34039077
      darin authored
      	- fixed 3134558 -- REGRESSION: Lord of the Rings site problems
      
      	This regression was caused when we fixed the abcnews.com problem (3124933).
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createEmptyDocument):
      	Despite its name, this function was never intended to overwrite an existing document with
      	an empty document. When we changed it do do the creation in a better way, we lost the
      	check that prevents it from doing anything at all if we already have a document.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34039077
  6. 22 Dec, 2002 2 commits
  7. 20 Dec, 2002 17 commits
    • sheridan's avatar
      alex-44 · 650f7017
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      650f7017
    • trey's avatar
      Do not add empty URLs to the back forward list. · 044b1280
      trey authored
      	Reviewed by Richard, Darin
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _transitionToCommitted:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      044b1280
    • darin's avatar
      Reviewed by Trey and Don. · 5de7095d
      darin authored
      	- fixed 3132160 -- meta refresh does not work if there's a space after the refresh interval value
      
              * khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv):
      	Added a call to stripWhiteSpace here. The other places that processes delays for
      	meta refresh already had the stripWhiteSpace call, but this was missing it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5de7095d
    • hyatt's avatar
      Fix for 3134163, a regression from the reduction of · dc56b2e8
      hyatt authored
      	styleForElement calls.  Make sure image buttons
      	get the width attribute and add it to style info
      	before styleForElement gets called.
      
              Reviewed by rjw
      
              * khtml/html/html_formimpl.cpp:
              (HTMLInputElementImpl::attach):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc56b2e8
    • hyatt's avatar
      Fix for 3134133. Back out the render_text code I gave to rjw · a18024a4
      hyatt authored
      	to check in.  It wasn't filling in a value for hasBreak, so it
      	became random whether or not you'd break or not.
      
              Reviewed by rjw
      
              * khtml/rendering/render_text.cpp:
              (RenderText::trimmedMinMaxWidth):
              (RenderText::calcMinMaxWidth):
              * khtml/rendering/render_text.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a18024a4
    • darin's avatar
      Reviewed by Trey. · 38a9e98d
      darin authored
      	- fixed 3133801 -- REGRESSION: Japanese page comes up hash
      
              * khtml/khtml_part.cpp: (KHTMLPart::write): Roll back to original KHTML code here,
      	removing the "all ASCII" optimization.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38a9e98d
    • hyatt's avatar
      Fix for 3133081, slashdot messed up when changing font sizes. · 385c7722
      hyatt authored
      	setStyle in RenderFlow was messed up for continuations.  A
      	block in the middle of a continuation incorrectly propagated
      	its style to the following inlines.
      
              Reviewed by darin
      
              * khtml/rendering/render_flow.cpp:
              (RenderFlow::setStyle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      385c7722
    • trey's avatar
      3133829 - crash leaving page with a running applet · 4188fde0
      trey authored
      	This fixes some holes in how we teardown plugins.  An additional fix is expected
      	from Mike Hay to finish the issue. (3133981)
      
              Reviewed by Richard
      
              * Plugins.subproj/WebPluginController.m:
              (-[WebPluginController destroyAllPlugins]):  frame=nil, so we don't do any more
      	messaging back to WK after this step.
              (-[WebPluginController showURL:inFrame:]):  bail if !frame
              (-[WebPluginController showStatus:]):  bail if !frame
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _detachFromParent]):  destroy plugins here.  We were only doing it
      	in the non-frame case.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4188fde0
    • darin's avatar
      Remove stray change marker. · 76dbe9c5
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76dbe9c5
    • rjw's avatar
      i Fix for 3133601. Play the same trick we do in · 1674abf2
      rjw authored
              KHTMLPartBrowserExtension::openURLRequest to create an empty
              document if necessary.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1674abf2
    • hyatt's avatar
      Remove the clip hack from setLayout and make it · f3f98f68
      hyatt authored
      	asynchronous instead.  This fixes the crasher
      	on autosite.com, which had a sync layout occur
      	while in the middle of making a block box's
      	children get wrapped in anonymous boxes.  It
      	was only half done when the layout got
      	triggered, which is what caused the assert to fire.
      
      	The bug # is 3129534.
      
              Reviewed by rjw
      
              * khtml/khtmlview.cpp:
              (KHTMLView::KHTMLView):
              (KHTMLView::timerEvent):
              (KHTMLView::scheduleRelayout):
              * khtml/khtmlview.h:
              * khtml/rendering/render_object.cpp:
              (RenderObject::setLayouted):
              (RenderObject::scheduleRelayout):
              * khtml/rendering/render_object.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3f98f68
    • darin's avatar
      Reviewed by John. · 46c72fa8
      darin authored
      	- fixed 3129387 -- Stopped responding to controls while filling out form (exception in KWQTextArea)
      
              * kwq/KWQTextArea.mm:
              (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): Fix code that was returning the wrong
      	paragraph number along with the index within the paragraph. Also made it return a paragraph one
      	past the end with an index of 0 for cases where you are at the end of the text.
              (-[KWQTextArea setCursorPositionToIndex:inParagraph:]): Range check the passed-in index. This
      	would also have prevented the exception.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46c72fa8
    • sheridan's avatar
      version 44u · c2069e55
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2069e55
    • sheridan's avatar
      alexander-43 · b0b73243
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0b73243
    • darin's avatar
      Reviewed by John. · 7ca1166d
      darin authored
      	- fixed 3132382 -- crash in khtml::CachedImage
      
      	The source of this bug was my long-ago fix to bug 3079499.
      	I changed the code to copy the clients list. But this doesn't work if
      	one of the clients is removed while iterating because it's deleted.
      	So I made a new class, CachedObjectClientWalker, that does the iterating safely.
      	Now both this new bug and the original are fixed.
      
              * khtml/misc/loader.cpp:
              (CachedCSSStyleSheet::checkNotify): Use CachedObjectClientWalker to walk the list.
              (CachedScript::checkNotify): Ditto.
              (CachedImage::do_notify): Ditto.
              (CachedImage::movieStatus): Ditto.
              (CachedImage::checkNotify): Ditto.
              (CachedObjectClientWalker::next): Walk the list using a list iterator, which is
      	safe against the current item being removed. But go that safety one better by making
      	sure you don't miss the item after one that's removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ca1166d
    • trey's avatar
      3131841 - crash when switching encodings on a page with frames · 5c764a80
      trey authored
              Reviewed by rjw
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _transitionToCommitted:]):  Create a docView in the LoadStale case, like
      	every other kind of load does.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c764a80
    • kocienda's avatar
      Reviewed by Darin · 51317c14
      kocienda authored
      	Fix for this bug:
      
      	Radar 3132171 (trying to login at mypage.apple.com gives "Already Connected" message)
      
      	The issue is that we submit the login form more than once when the user hits
      	the return key to submit rather than clicking the submit button. We are also
      	susceptible to double form submissions from buggy scripts that ask to submit
      	more than one form.
      
      	The fix is to prevent the KWQKHTMLPart from submitting more than one form by
      	setting and checking a flag.
      
              * kwq/KWQKHTMLPart.h: Add a form submit flag.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::submitForm): Check form submit flag. Return if a form
      	has already been submitted.
              (KWQKHTMLPart::setView): Reset form flag. This is done since the part
      	may have been retrieved for reuse from the bac/forward cache.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51317c14