1. 18 Mar, 2013 40 commits
    • bfulgham@webkit.org's avatar
      [WinCairo] Build WinCairo port under VS2010 · 10dca391
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112604
      
      Reviewed by Tim Horton.
      
      * WebKit.vcxproj/WebKit.sln: Add Debug_WinCairo and Release_WinCairo
      build targets. No other changes in this patch.
      * WebKit.vcxproj/FeatureDefinesCairo.props: Add parallel property
      sheet for WinCairo version of build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10dca391
    • simon.fraser@apple.com's avatar
      06b1731b
    • simon.fraser@apple.com's avatar
    • hans@chromium.org's avatar
      Fix GridTrackSize::operator== · 276e90d2
      hans@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112501
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      There was a missing "other." in the function.
      
      This was found by experimenting with a potential new Clang warning.
      
      Test: fast/css-grid-layout/grid-dynamic-updates-relayout.html
      
      * rendering/style/GridTrackSize.h:
      (WebCore::GridTrackSize::operator==):
      
      LayoutTests:
      
      Add a test to check that style changes cause relayout correctly.
      
      * fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt: Added.
      * fast/css-grid-layout/grid-dynamic-updates-relayout.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      276e90d2
    • alecflett@chromium.org's avatar
      Inspector: [Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT... · 0aa24de4
      alecflett@chromium.org authored
      Inspector: [Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT on Win7 following r133855
      https://bugs.webkit.org/show_bug.cgi?id=101618
      
      Deactivate transactions created by the inspector, before
      they are reactivated by IndexedDB. This puts transactions
      in an identical state as when they are created by scripts.
      
      Reviewed by Vsevolod Vlasov.
      
      Test: http/tests/inspector/indexeddb/database-data.html
      
      * inspector/InspectorIndexedDBAgent.cpp: Make transactions inactive upon leaving the inspector code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0aa24de4
    • jpfau@apple.com's avatar
      Allow blocking of application cache in third-party contexts · 398b1b59
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112288
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Return early if we can't access the application cache due to security
      restrictions.
      
      Tests: http/tests/security/cross-origin-appcache-allowed.html
             http/tests/security/cross-origin-appcache.html
             http/tests/security/same-origin-appcache-blocked.html
      
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::selectCache):
      (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
      * page/SecurityOrigin.h:
      (WebCore::SecurityOrigin::canAccessApplicationCache):
      
      LayoutTests:
      
      * http/tests/security/cross-origin-appcache-allowed-expected.txt: Added.
      * http/tests/security/cross-origin-appcache-allowed.html: Added.
      * http/tests/security/cross-origin-appcache-expected.txt: Added.
      * http/tests/security/cross-origin-appcache.html: Added.
      * http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html: Added.
      * http/tests/security/resources/cross-origin-iframe-for-appcache.html: Added.
      * http/tests/security/resources/manifest-for-appcache-allowed.manifest: Added.
      * http/tests/security/resources/manifest-for-appcache-blocked.manifest: Added.
      * http/tests/security/resources/manifest-for-appcache.manifest: Added.
      * http/tests/security/resources/same-origin-iframe-for-appcache-blocked.html: Added.
      * http/tests/security/same-origin-appcache-blocked-expected.txt: Added.
      * http/tests/security/same-origin-appcache-blocked.html: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      398b1b59
    • simon.fraser@apple.com's avatar
      plugins/plugin-clip-subframe.html is flakey · 6b804da3
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112616
      
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b804da3
    • vsevik@chromium.org's avatar
      Web Inspector: Script should know nothing about disabled source mappings. · 56e39b1d
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112580
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      ResourceScriptMapping handles diverged uiSourceCodes internally now.
      
      Tested in inspector/debugger/live-edit-breakpoints.html already.
      
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
      (WebInspector.ResourceScriptMapping.prototype._hasMergedToVM):
      (WebInspector.ResourceScriptMapping.prototype._hasDivergedFromVM):
      * inspector/front-end/Script.js:
      (WebInspector.Script.prototype.rawLocationToUILocation):
      
      LayoutTests:
      
      * inspector/debugger/breakpoint-manager.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56e39b1d
    • pilgrim@chromium.org's avatar
      [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring · e97e459b
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112571
      
      Reviewed by Adam Barth.
      
      Source/Platform:
      
      New top-level enum (not tied to WebFileSystem class) will allow
      easier refactoring of filesystem methods within the Platform/
      directory. (All changes are behind an #ifdef so we can sync
      required changes in embedders.)
      
      * chromium/public/WebFileSystemType.h: new file
      (WebKit):
      
      * Platform.gypi:
      * chromium/public/WebFileSystem.h:
      * chromium/public/WebFileSystemType.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
      (WebKit):
      
      Source/WebKit/chromium:
      
      Update function declarations for new WebFileSystemType enum. (All
      changes are behind an #ifdef so we can sync required changes in embedders.)
      
      * public/WebCommonWorkerClient.h:
      (WebCommonWorkerClient):
      (WebKit::WebCommonWorkerClient::openFileSystem):
      * public/WebFrame.h:
      (WebFrame):
      * public/WebFrameClient.h:
      (WebFrameClient):
      (WebKit::WebFrameClient::openFileSystem):
      (WebKit::WebFrameClient::deleteFileSystem):
      * src/LocalFileSystemChromium.cpp:
      (WebCore):
      (WebCore::openFileSystemHelper):
      (WebCore::LocalFileSystem::deleteFileSystem):
      * src/WebFrameImpl.cpp:
      (WebKit):
      (WebKit::WebFrameImpl::createFileSystem):
      (WebKit::WebFrameImpl::createSerializableFileSystem):
      (WebKit::WebFrameImpl::createFileEntry):
      * src/WebFrameImpl.h:
      (WebFrameImpl):
      * src/WebWorkerClientImpl.cpp:
      (WebKit):
      (WebKit::WebWorkerClientImpl::openFileSystem):
      * src/WebWorkerClientImpl.h:
      * src/WorkerFileSystemCallbacksBridge.cpp:
      (WebKit):
      (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
      (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
      * src/WorkerFileSystemCallbacksBridge.h:
      (WorkerFileSystemCallbacksBridge):
      
      Tools:
      
      Update function declarations for new WebFileSystemType enum. (All
      changes are behind an #ifdef so we can sync required changes in embedders.)
      
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::openFileSystem):
      (WebViewHost::deleteFileSystem):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e97e459b
    • ap@apple.com's avatar
      Update MessagePort terminology to match HTML5 · d2a6ad0a
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112611
      
      Reviewed by Anders Carlsson.
      
      Transferable objects are "neutered" when transfered. Cloning is a different operation.
      
      * dom/MessagePort.cpp:
      (WebCore::MessagePort::disentanglePorts):
      * dom/MessagePort.h:
      (WebCore::MessagePort::isEntangled):
      (WebCore::MessagePort::isNeutered):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2a6ad0a
    • roger_fong@apple.com's avatar
      AppleWin VS2010 build fix. · 2fc3d13a
      roger_fong@apple.com authored
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fc3d13a
    • simon.fraser@apple.com's avatar
      Another asserting test. · f23c8ad7
      simon.fraser@apple.com authored
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f23c8ad7
    • simon.fraser@apple.com's avatar
      Mark a couple of asserty tests as such. · 9f1ce107
      simon.fraser@apple.com authored
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f1ce107
    • jparent@chromium.org's avatar
      Cleanup: Move timeline_exporer js out of html file into js. · b2b98f4a
      jparent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112188
      
      Reviewed by Dirk Pranke.
      
      Moves the javascript out of the html file and into a new js file.
      This follows the format of flakiness_dashboard.{html|js}.
      
      Also moves code from dashboard_base that is used only by this one
      dashboard, and makes it private to the dashboard.
      
      * TestResultServer/static-dashboards/dashboard_base.js:
      * TestResultServer/static-dashboards/timeline_explorer.html:
      * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
      (generatePage):
      (initCurrentBuilderTestResults):
      (shouldShowWebKitRevisionsOnly):
      (updateTimelineForBuilder.):
      (updateTimelineForBuilder):
      (selectBuild):
      (updateBuildIndicator):
      (.addRow):
      (.addNumberRow):
      (.inspectorNode.getElementsByTagName.0.onclick):
      (.inspectorNode.getElementsByTagName.1.onclick):
      (.inspectorNode.getElementsByTagName.2.onclick):
      (updateBuildInspector):
      (showResultsDelta):
      (decompressResults.addFlakyDelta):
      (decompressResults):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2b98f4a
    • kbr@google.com's avatar
      Unreviewed gardening. Added expectation for failing test. · c3239e30
      kbr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112610
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3239e30
    • commit-queue@webkit.org's avatar
      [css3-text] Add rendering support for -webkit-text-underline-position · ba7c7004
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102795
      
      Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-18
      Reviewed by Levi Weintraub.
      
      Source/WebCore:
      
      This patch implements rendering support for values [ auto | alphabetic | under ]
      of CSS3 property text-underline-position. We don't fully match the specification
      as we don't support [ left | right ] and this is left for another implementation
      as the rendering will need to be added.
      
      Tests: fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html
             fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html
             fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html
             fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html
             fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::computeMaxLogicalTop): Added method to compute maximal logical top among all chidren of
      this InlineTextBox.
      * rendering/InlineFlowBox.h:
      (InlineFlowBox):
      * rendering/InlineTextBox.cpp:
      (WebCore::computeUnderlineOffset): Added method to compute offset for text-underline-position property.
      (WebCore::InlineTextBox::paintDecoration): Paint decoration at position calculated using computeUnderlineOffset().
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::RootInlineBox):
      (WebCore::RootInlineBox::alignBoxesInBlockDirection): Call method to compute maximal logical top among all
      children of this RootInlineBox.
      * rendering/RootInlineBox.h:
      (RootInlineBox):
      (WebCore::RootInlineBox::maxLogicalTop): Added getter for m_maxLogicalTop class member.
      * rendering/style/RenderStyle.h: Added the usual getter / setter / initial methods for text-underline-position
      property
      
      LayoutTests:
      
      Added text-underline-position tests for 'text-underline-position' CSS3
      property, with 'webkit' prefix.
      
      * fast/css3-text/css3-text-decoration/text-underline-position/style.css: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.txt: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.txt: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.txt: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.txt: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.txt: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html: Added.
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.png: Added.
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png: Added.
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.png: Added.
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.png: Added.
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba7c7004
    • commit-queue@webkit.org's avatar
      Convert old flexbox uses in html.css to new flexbox (non-<select>) · d52f5ae3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110837
      
      Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-18
      Reviewed by Ojan Vafai.
      
      No new tests (No change in behaviour)
      
      * css/html.css:
      (input::-webkit-clear-button):
      Missed this one in the original patch.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d52f5ae3
    • james.wei@intel.com's avatar
      AudioBasicProcessorNode need to check for deferred updating of output channels · 6a1c5a90
      james.wei@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112544
      
      There can in rare cases be a slight delay before the output
      bus is updated to the new number of channels because of tryLocks() in the
      context's updating system but the processor already updated to the new
      number of channels, so need to check the channel number before processing.
      
      Reviewed by Chris Rogers.
      
      * Modules/webaudio/AudioBasicProcessorNode.cpp:
      (WebCore::AudioBasicProcessorNode::process):
      * Modules/webaudio/WaveShaperProcessor.cpp:
      (WebCore::WaveShaperProcessor::process):
      * platform/audio/AudioDSPKernelProcessor.cpp:
      (WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):
      * platform/audio/AudioDSPKernelProcessor.h:
      (WebCore::AudioDSPKernelProcessor::numberOfChannels):
      (AudioDSPKernelProcessor):
      * platform/audio/AudioProcessor.h:
      (WebCore::AudioProcessor::AudioProcessor):
      (AudioProcessor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a1c5a90
    • dpranke@chromium.org's avatar
      Unreviewed, rolling out r145272. · 97ecb968
      dpranke@chromium.org authored
      http://trac.webkit.org/changeset/145272
      https://bugs.webkit.org/show_bug.cgi?id=111884
      
      Turns out the ASAN build is still broken; possibly there's
      something still setting LD_LIBRARY_PATH, or possibly there's
      something else wrong. In the meantime, we need it to work again.
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97ecb968
    • msaboff@apple.com's avatar
      Potentially unsafe register allocations in DFG code generation · 4bf9c30e
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112477
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      Moved allocation of temporary GPRs to be before any generated branches in the functions below.
      
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
      (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
      (JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
      (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
      (JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
      
      LayoutTests: 
      
      New tests added to verify proper operation of
      SpeculativeJIT::compileObjectToObjectOrOtherEquality,
      SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality
      and SpeculativeJIT::compileObjectOrOtherLogicalNot.
      
      * fast/js/dfg-compare-final-object-to-final-object-or-other-expected.txt: Added.
      * fast/js/dfg-compare-final-object-to-final-object-or-other.html: Added.
      * fast/js/dfg-logical-not-final-object-or-other-expected.txt: Added.
      * fast/js/dfg-logical-not-final-object-or-other.html: Added.
      * fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-expected.txt: Added.
      * fast/js/dfg-peephole-compare-final-object-to-final-object-or-other.html: Added.
      * fast/js/script-tests/dfg-compare-final-object-to-final-object-or-other.js: Added.
      * fast/js/script-tests/dfg-logical-not-final-object-or-other.js: Added.
      * fast/js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bf9c30e
    • jchaffraix@webkit.org's avatar
      [CSS Grid Layout] Fix StyleGridData::operator== · 0fc3953a
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112574
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Test: fast/css-grid-layout/grid-auto-flow-update.html
      
      * rendering/style/StyleGridData.h:
      (WebCore::StyleGridData::operator==):
      Fixed a bad comparison that would make us ignore grid-auto-flow changes.
      
      LayoutTests:
      
      * fast/css-grid-layout/grid-auto-flow-update-expected.txt: Added.
      * fast/css-grid-layout/grid-auto-flow-update.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fc3953a
    • roger_fong@apple.com's avatar
      Fix typo on Windows following r145849 that was causing DRT to crash 100% of the time. · 7ec59dc0
      roger_fong@apple.com authored
      * WebView.cpp:
      (WebView::setSmartInsertDeleteEnabled):
      (WebView::setSelectTrailingWhitespaceEnabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ec59dc0
    • kbr@google.com's avatar
    • beidson@apple.com's avatar
      Mac build fix after http://trac.webkit.org/changeset/146088 · 5d53ee16
      beidson@apple.com authored
      * NetworkProcess/mac/NetworkResourceLoaderMac.mm:
      (WebKit::NetworkResourceLoader::platformDidReceiveResponse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d53ee16
    • rafaelw@chromium.org's avatar
      [HTMLTemplateElement] parseError check in processTemplateEndTag should use... · bd9cd618
      rafaelw@chromium.org authored
      [HTMLTemplateElement] parseError check in processTemplateEndTag should use hasTagName, not hasLocalName
      https://bugs.webkit.org/show_bug.cgi?id=112591
      
      Reviewed by Adam Barth.
      
      No tests needed, change is unobservable.
      
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processTemplateEndTag):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd9cd618
    • rniwa@webkit.org's avatar
      delete-stale-build-files is too aggressive · 2c9f7be4
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112595
      
      Reviewed by Tim Horton.
      
      It appears that whitelisting file extensions to keep is not a good idea.
      Blacklist files to delete instead, and only delete .o files for now.
      We can add more file extensions as needed.
      
      * BuildSlaveSupport/delete-stale-build-files:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c9f7be4
    • commit-queue@webkit.org's avatar
      [BlackBerry] Prevent text selection inside Colour and Date/Time input fields · ad53ad4a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111733
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
      Reviewed by Rob Buis.
      
      Fix missing brace.
      
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad53ad4a
    • jknotten@chromium.org's avatar
      [Chromium] Compositor is applying scroll offset using 'programmatic' API · 5942d437
      jknotten@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109712
      
      Reviewed by James Robinson.
      
      Ensure that the compositor uses non-programmatic APIs to scroll and
      scale.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setPageScaleFactor):
      (WebKit::WebViewImpl::updateMainFrameScrollPosition):
      (WebKit):
      (WebKit::WebViewImpl::applyScrollAndScale):
      * src/WebViewImpl.h:
      (WebViewImpl):
      * tests/WebFrameTest.cpp:
      * tests/WebViewTest.cpp:
      * tests/data/long_scroll.html: Added.
      * tests/data/short_scroll.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5942d437
    • commit-queue@webkit.org's avatar
      [BlackBerry] Add Proximity Detector. · 4e1f683f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112278
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
      Reviewed by Rob Buis.
      
      Fix variable names so they actually match the function
      declarations.
      
      Fix call to rectForPoint(), which was moved from HitTestResult to
      HitTestLocation in r117091 and r126859.
      
      * WebKitSupport/ProximityDetector.cpp:
      (BlackBerry::WebKit::ProximityDetector::findBestPoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e1f683f
    • fpizlo@apple.com's avatar
      DFG string conversions and allocations should be inlined · 0e6e1542
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112376
      
      Source/JavaScriptCore: 
      
      Reviewed by Geoffrey Garen.
              
      This turns new String(), String(), String.prototype.valueOf(), and
      String.prototype.toString() into intrinsics. It gives the DFG the ability to handle
      conversions from StringObject to JSString and vice-versa, and also gives it the
      ability to handle cases where a variable may be either a StringObject or a JSString.
      To do this, I added StringObject to value profiling (and removed the stale
      distinction between Myarguments and Foreignarguments). I also cleaned up ToPrimitive
      handling, using some of the new functionality but also taking advantage of the
      existence of Identity(String:@a).
              
      This is a 2% SunSpider speed-up. Also there are some speed-ups on V8v7 and Kraken.
      On microbenchmarks that stress new String() this is a 14x speed-up.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * bytecode/CodeBlock.h:
      (CodeBlock):
      (JSC::CodeBlock::hasExitSite):
      (JSC):
      * bytecode/DFGExitProfile.cpp:
      (JSC::DFG::ExitProfile::hasExitSite):
      (DFG):
      * bytecode/DFGExitProfile.h:
      (ExitProfile):
      (JSC::DFG::ExitProfile::hasExitSite):
      * bytecode/ExitKind.cpp:
      (JSC::exitKindToString):
      * bytecode/ExitKind.h:
      * bytecode/SpeculatedType.cpp:
      (JSC::dumpSpeculation):
      (JSC::speculationToAbbreviatedString):
      (JSC::speculationFromClassInfo):
      * bytecode/SpeculatedType.h:
      (JSC):
      (JSC::isStringObjectSpeculation):
      (JSC::isStringOrStringObjectSpeculation):
      * create_hash_table:
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::executeEffects):
      * dfg/DFGAbstractState.h:
      (JSC::DFG::AbstractState::filterEdgeByUse):
      * dfg/DFGByteCodeParser.cpp:
      (ByteCodeParser):
      (JSC::DFG::ByteCodeParser::handleCall):
      (JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
      (DFG):
      (JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::putStructureStoreElimination):
      * dfg/DFGEdge.h:
      (JSC::DFG::Edge::shift):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      (JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
      (FixupPhase):
      (JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):
      (JSC::DFG::FixupPhase::observeUseKindOnNode):
      * dfg/DFGGraph.h:
      (JSC::DFG::Graph::hasGlobalExitSite):
      (Graph):
      (JSC::DFG::Graph::hasExitSite):
      (JSC::DFG::Graph::clobbersWorld):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::convertToToString):
      (Node):
      (JSC::DFG::Node::hasStructure):
      (JSC::DFG::Node::shouldSpeculateStringObject):
      (JSC::DFG::Node::shouldSpeculateStringOrStringObject):
      * dfg/DFGNodeType.h:
      (DFG):
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h:
      * dfg/DFGPredictionPropagationPhase.cpp:
      (JSC::DFG::PredictionPropagationPhase::propagate):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileToStringOnCell):
      (DFG):
      (JSC::DFG::SpeculativeJIT::compileNewStringObject):
      (JSC::DFG::SpeculativeJIT::speculateObject):
      (JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
      (JSC::DFG::SpeculativeJIT::speculateString):
      (JSC::DFG::SpeculativeJIT::speculateStringObject):
      (JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
      (JSC::DFG::SpeculativeJIT::speculate):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::callOperation):
      (SpeculativeJIT):
      (JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
      (DFG):
      (JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::fillSpeculateCell):
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::fillSpeculateCell):
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGUseKind.cpp:
      (WTF::printInternal):
      * dfg/DFGUseKind.h:
      (JSC::DFG::typeFilterFor):
      * interpreter/CallFrame.h:
      (JSC::ExecState::regExpPrototypeTable):
      * runtime/CommonIdentifiers.h:
      * runtime/Intrinsic.h:
      * runtime/JSDestructibleObject.h:
      (JSDestructibleObject):
      (JSC::JSDestructibleObject::classInfoOffset):
      * runtime/JSGlobalData.cpp:
      (JSC):
      (JSC::JSGlobalData::JSGlobalData):
      (JSC::JSGlobalData::~JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSGlobalData):
      * runtime/JSObject.cpp:
      * runtime/JSObject.h:
      (JSC):
      * runtime/JSWrapperObject.h:
      (JSC::JSWrapperObject::allocationSize):
      (JSWrapperObject):
      (JSC::JSWrapperObject::internalValueOffset):
      (JSC::JSWrapperObject::internalValueCellOffset):
      * runtime/StringPrototype.cpp:
      (JSC):
      (JSC::StringPrototype::finishCreation):
      (JSC::StringPrototype::create):
      * runtime/StringPrototype.h:
      (StringPrototype):
      
      LayoutTests: 
      
      Reviewed by Geoffrey Garen.
      
      * fast/js/dfg-to-string-bad-toString-expected.txt: Added.
      * fast/js/dfg-to-string-bad-toString.html: Added.
      * fast/js/dfg-to-string-bad-valueOf-expected.txt: Added.
      * fast/js/dfg-to-string-bad-valueOf.html: Added.
      * fast/js/dfg-to-string-int-expected.txt: Added.
      * fast/js/dfg-to-string-int-or-string-expected.txt: Added.
      * fast/js/dfg-to-string-int-or-string.html: Added.
      * fast/js/dfg-to-string-int.html: Added.
      * fast/js/dfg-to-string-side-effect-clobbers-toString-expected.txt: Added.
      * fast/js/dfg-to-string-side-effect-clobbers-toString.html: Added.
      * fast/js/dfg-to-string-side-effect-expected.txt: Added.
      * fast/js/dfg-to-string-side-effect.html: Added.
      * fast/js/dfg-to-string-toString-becomes-bad-expected.txt: Added.
      * fast/js/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype-expected.txt: Added.
      * fast/js/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.html: Added.
      * fast/js/dfg-to-string-toString-becomes-bad.html: Added.
      * fast/js/dfg-to-string-toString-in-string-expected.txt: Added.
      * fast/js/dfg-to-string-toString-in-string.html: Added.
      * fast/js/dfg-to-string-valueOf-becomes-bad-expected.txt: Added.
      * fast/js/dfg-to-string-valueOf-becomes-bad.html: Added.
      * fast/js/dfg-to-string-valueOf-in-string-expected.txt: Added.
      * fast/js/dfg-to-string-valueOf-in-string.html: Added.
      * fast/js/jsc-test-list:
      * fast/js/regress/script-tests/string-concat-object.js: Added.
      (foo):
      * fast/js/regress/script-tests/string-concat-pair-object.js: Added.
      (foo):
      * fast/js/regress/script-tests/string-concat-pair-simple.js: Added.
      (foo):
      * fast/js/regress/script-tests/string-concat-simple.js: Added.
      (foo):
      * fast/js/regress/script-tests/string-cons-repeat.js: Added.
      (foo):
      * fast/js/regress/script-tests/string-cons-tower.js: Added.
      (foo):
      * fast/js/regress/string-concat-object-expected.txt: Added.
      * fast/js/regress/string-concat-object.html: Added.
      * fast/js/regress/string-concat-pair-object-expected.txt: Added.
      * fast/js/regress/string-concat-pair-object.html: Added.
      * fast/js/regress/string-concat-pair-simple-expected.txt: Added.
      * fast/js/regress/string-concat-pair-simple.html: Added.
      * fast/js/regress/string-concat-simple-expected.txt: Added.
      * fast/js/regress/string-concat-simple.html: Added.
      * fast/js/regress/string-cons-repeat-expected.txt: Added.
      * fast/js/regress/string-cons-repeat.html: Added.
      * fast/js/regress/string-cons-tower-expected.txt: Added.
      * fast/js/regress/string-cons-tower.html: Added.
      * fast/js/script-tests/dfg-to-string-bad-toString.js: Added.
      (String.prototype.toString):
      (foo):
      * fast/js/script-tests/dfg-to-string-bad-valueOf.js: Added.
      (String.prototype.valueOf):
      (foo):
      * fast/js/script-tests/dfg-to-string-int-or-string.js: Added.
      (foo):
      * fast/js/script-tests/dfg-to-string-int.js: Added.
      (foo):
      * fast/js/script-tests/dfg-to-string-side-effect-clobbers-toString.js: Added.
      (foo):
      * fast/js/script-tests/dfg-to-string-side-effect.js: Added.
      (foo):
      * fast/js/script-tests/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.js: Added.
      (foo):
      (.String.prototype.toString):
      * fast/js/script-tests/dfg-to-string-toString-becomes-bad.js: Added.
      (foo):
      (.String.prototype.toString):
      * fast/js/script-tests/dfg-to-string-toString-in-string.js: Added.
      (foo):
      (.argument.toString):
      * fast/js/script-tests/dfg-to-string-valueOf-becomes-bad.js: Added.
      (foo):
      (.String.prototype.valueOf):
      * fast/js/script-tests/dfg-to-string-valueOf-in-string.js: Added.
      (foo):
      (.argument.valueOf):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e6e1542
    • beidson@apple.com's avatar
      NetworkProcess should send vm_copied, mmap'ed memory to WebProcesses when a · 472f6d2b
      beidson@apple.com authored
      resource is already in the disk cache.
      <rdar://problem/13414153> and https://bugs.webkit.org/show_bug.cgi?id=112387
      
      Reviewed by Geoff Garen.
      
      Source/WebCore:
      
      No new tests (No change in behavior).
      
      * WebCore.exp.in:
      
      Add a CFURLRequestRef accessor even in the mac NSURL-based loader:
      * platform/network/cf/ResourceRequest.h:
      * platform/network/mac/ResourceRequestMac.mm:
      (WebCore::ResourceRequest::cfURLRequest):
      
      Source/WebKit2:
      
      * NetworkProcess/NetworkResourceLoader.cpp:
      (WebKit::NetworkResourceLoader::sendAbortingOnFailure):
      (WebKit::NetworkResourceLoader::didReceiveResponse): After notifying about the response,
        call platformDidReceiveResponse.
      * NetworkProcess/NetworkResourceLoader.h:
      
      * NetworkProcess/mac/NetworkResourceLoaderMac.mm: Added.
      (WebKit::NetworkResourceLoader::platformDidReceiveResponse): Attempt to pull a filesystem
        mmap'ed buffer from the CFNetwork cache and - if it exists - abort the traditional load
        and send that to the WebProcess instead.
      (WebKit::NetworkResourceLoader:: fileBackedResourceMinimumSize): For now, use the VM page size.
      
      * NetworkProcess/mac/NetworkProcessMac.mm:
      (WebKit::NetworkProcess::platformInitializeNetworkProcess): Set the threshold for what
        should be backed by a file on disk instead of stored in the database.
      
      Change SharedMemory to do a vm_copy if a previously existing buffer is being passed in:
      * Platform/SharedMemory.h:
      * Platform/mac/SharedMemoryMac.cpp:
      (WebKit::SharedMemory::create):
      (WebKit::SharedMemory::createWithVMCopy):
      
      * WebProcess/Network/WebResourceLoader.cpp:
      (WebKit::shareableResourceDeallocate):
      (WebKit::createShareableResourceDeallocator):
      (WebKit::WebResourceLoader::didReceiveResource): Create a special CFDataRef whose buffer is
        backed by a ShareableResource to send to the ResourceLoader in one chunk.
      
      * Shared/ShareableResource.h: Fix some comments.
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      472f6d2b
    • dino@apple.com's avatar
      Only add wordspacing when kerning to actual word ends · 7c50e7cf
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112507
      <rdar://problem/12945869>
      
      Reviewed by Enrica Casucci.
      
      Source/WebCore:
      
      When measuring text, we currently include any word spacing in
      the result (it's removed later). When kerning is active, we
      were adding the word spacing to every wordMeasurement instance
      whether or not it is a separate word. For example, a nested
      <span> element would get a wordMeasurement, even though it
      should not always get word spacing.
      
      Test: fast/text/word-space-with-kerning-3.html
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::setLogicalWidthForTextRun): Test if the current character
      referenced by the wordMeasurement is a space character, and add word
      spacing only then.
      
      LayoutTests:
      
      * fast/text/word-space-with-kerning-3-expected.html: Added.
      * fast/text/word-space-with-kerning-3.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c50e7cf
    • tony@chromium.org's avatar
      [chromium] Default background color of listboxes should be white · 01628c66
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112480
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      I think it was an accident that list boxes got the grey background color as a
      side effect of trying to get the button styling. In the default GTK+ theme on
      Ubuntu, list boxes get a white background. Win and OS X also use white as the
      default color.
      
      No new tests, covered by existing pixel tests.
      
      * css/themeChromiumLinux.css:
      Narrow the CSS rule that overrides the background color specified in html.css.
      We only want to use the button color when a select is using button styling.
      
      LayoutTests:
      
      Update pixel results with list boxes.
      
      * platform/chromium-linux/fast/css/text-transform-select-expected.png:
      * platform/chromium-linux/fast/css/text-transform-select-expected.txt:
      * platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.png:
      * platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.txt:
      * platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
      * platform/chromium-linux/fast/forms/disabled-select-change-index-expected.txt:
      * platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
      * platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
      * platform/chromium-linux/fast/forms/hidden-listbox-expected.txt:
      * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png:
      * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.txt:
      * platform/chromium-linux/fast/forms/listbox-clip-expected.png:
      * platform/chromium-linux/fast/forms/listbox-clip-expected.txt:
      * platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.png:
      * platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.txt:
      * platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.png:
      * platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
      * platform/chromium-linux/fast/forms/listbox-width-change-expected.png:
      * platform/chromium-linux/fast/forms/listbox-width-change-expected.txt:
      * platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
      * platform/chromium-linux/fast/forms/option-strip-whitespace-expected.txt:
      * platform/chromium-linux/fast/forms/select-block-background-expected.png:
      * platform/chromium-linux/fast/forms/select-block-background-expected.txt:
      * platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
      * platform/chromium-linux/fast/forms/select-change-listbox-size-expected.txt:
      * platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.png:
      * platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.txt:
      * platform/chromium-linux/fast/forms/select-initial-position-expected.png:
      * platform/chromium-linux/fast/forms/select-initial-position-expected.txt:
      * platform/chromium-linux/fast/forms/select-item-background-clip-expected.png:
      * platform/chromium-linux/fast/forms/select-item-background-clip-expected.txt:
      * platform/chromium-linux/fast/forms/select-list-box-with-height-expected.png:
      * platform/chromium-linux/fast/forms/select-list-box-with-height-expected.txt:
      * platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.png:
      * platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
      * platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png:
      * platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt:
      * platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png:
      * platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt:
      * platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png:
      * platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt:
      * platform/chromium-linux/fast/repaint/select-option-background-color-expected.png:
      * platform/chromium-linux/fast/repaint/select-option-background-color-expected.txt:
      * platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
      * platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
      * platform/chromium-linux/fast/text/drawBidiText-expected.png:
      * platform/chromium-linux/fast/text/drawBidiText-expected.txt:
      * platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.png:
      * platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.txt:
      * platform/chromium-linux/fast/text/international/bidi-listbox-expected.png:
      * platform/chromium-linux/fast/text/international/bidi-listbox-expected.txt:
      * platform/chromium-linux/fast/text/updateNewFont-expected.png:
      * platform/chromium-linux/fast/text/updateNewFont-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01628c66
    • kbr@google.com's avatar
      Unreviewed, rolling out r146079. · 4b506952
      kbr@google.com authored
      http://trac.webkit.org/changeset/146079
      https://bugs.webkit.org/show_bug.cgi?id=112594
      
      many timeline tests failed. (Requested by loislo on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-18
      
      * inspector/front-end/TimelineOverviewPane.js:
      (WebInspector.TimelineOverviewPane):
      (WebInspector.TimelineOverviewPane.prototype.setMode):
      (WebInspector.TimelineOverviewPane.prototype._setFrameMode):
      (WebInspector.TimelineOverviewPane.prototype._update):
      (WebInspector.TimelineOverviewPane.prototype.sidebarResized):
      (WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
      (WebInspector.TimelineOverviewPane.prototype._reset):
      (WebInspector.TimelineOverviewPane.prototype.windowLeft):
      (WebInspector.TimelineOverviewPane.prototype.windowRight):
      (WebInspector.TimelineOverviewPane.prototype._updateWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b506952
    • peter@chromium.org's avatar
      [Chromium] The <select> element on Android should also switch to new-flexbox · 82fc82bb
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112559
      
      Reviewed by Ojan Vafai.
      
      Following r145959, also update themeChromiumAndroid.css to use the new
      flexible box CSS properties. Covered by existing tests.
      
      * css/themeChromiumAndroid.css:
      (select[size][multiple]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82fc82bb
    • reni@webkit.org's avatar
      Source/WebCore: Assertion faulire in SVGAnimatedPath. · ac3a94d8
      reni@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106428
      
      Reviewed by Allan Sandfeld Jensen.
      
      The asserts are too restricted. The size must be greater or equal to 1.
      
      Test: svg/animations/animated-path-via-use-debug-crash.svg
      
      * svg/SVGAnimatedPath.cpp:
      (WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
      (WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
      
      LayoutTests: Assertion faulire in SVGAnimatedPath
      https://bugs.webkit.org/show_bug.cgi?id=106428
      
      Reviewed by Allan Sandfeld Jensen.
      
      * svg/animations/animated-path-via-use-debug-crash.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac3a94d8
    • simon.fraser@apple.com's avatar
      [Mac] Some tests intermittently asserts in SharedBuffer::releasePurgeableBuffer() · 38b3719c
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105986
      
      Source/WebCore:
      
      Reviewed by Brady Eidson.
      
      A ResourceBuffer's SharedBuffer can be vended out to other clients,
      for example Images, so there's no guarantee that when the
      ResourceBuffer only has one ref its SharedBuffer will also have just one.
      When this assumption was broken, SharedBuffer::releasePurgeableBuffer()
      would assert.
      
      Ideally SharedBuffer would be entirely encapsulated by ResourceBuffer to
      avoid this problem, but ResourceBuffer can't be used by code in platform/.
      
      Fix by having ResourceBuffer::createPurgeableBuffer() refuse to make
      a purgeable buffer if the sharedBuffer has more than one ref.
      
      Tested by existing tests.
      
      * loader/ResourceBuffer.cpp:
      (WebCore::ResourceBuffer::createPurgeableBuffer):
      
      LayoutTests:
      
      Reviewed by Brady Eidson.
      
      Remove expected Crashes for tests which should be fixed by this change.
      
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38b3719c
    • simon.fraser@apple.com's avatar
      Disable accessibility notifications after each test · be576ac6
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112579
      
      Reviewed by Tim Horton.
      
      In WebKitTestRunner, if any tests triggered accessibility notifications,
      the global notification handler would thereafter be active, and fire
      notifications for all subsequent tests.
      
      Fix by implementing AccessibilityController::resetToConsistentState() for
      Mac, and using it to clear the global notification handler.
      
      * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
      (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
      (WTR::AccessibilityController::removeNotificationListener): Explicitly call
      -stopObserving so that unregistering the observer doesn't rely on object lifetimes
      (e.g. because of -autorelease).
      (WTR::AccessibilityController::logAccessibilityEvents): Stub.
      (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
      if there is one.
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
      Add -stopObserving
      * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
      (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
      (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
      center.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be576ac6
    • kbr@google.com's avatar
      Unreviewed. Added new test expectations after r146072. · 6c19ad4a
      kbr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112562
      
      * platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.png:
      * platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
      * platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
      * platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c19ad4a
    • loislo@chromium.org's avatar
      Web Inspector: move _timelineGrid && _timelineOverviewWindow from... · b629a62a
      loislo@chromium.org authored
      Web Inspector: move _timelineGrid && _timelineOverviewWindow from TimelineOverviewPane into a new class OverviewGrid.
      https://bugs.webkit.org/show_bug.cgi?id=112584
      
      Reviewed by Pavel Feldman.
      
      It is the first path in the set.
      The end goal is to extract OverviewGrid with window selectors
      into a separate class in separate file and reuse it in CPU FlameChart.
      
      * inspector/front-end/TimelineOverviewPane.js:
      (WebInspector.TimelineOverviewPane):
      (WebInspector.OverviewGrid):
      (WebInspector.OverviewGrid.prototype.get grid):
      (WebInspector.OverviewGrid.prototype.get clientWidth):
      (WebInspector.OverviewGrid.prototype.showItemsGraphsElement):
      (WebInspector.OverviewGrid.prototype.hideItemsGraphsElement):
      (WebInspector.OverviewGrid.prototype.updateDividers):
      (WebInspector.OverviewGrid.prototype.addEventDividers):
      (WebInspector.OverviewGrid.prototype.removeEventDividers):
      (WebInspector.OverviewGrid.prototype.setWindowPosition):
      (WebInspector.OverviewGrid.prototype.reset):
      (WebInspector.OverviewGrid.prototype.get windowLeft):
      (WebInspector.OverviewGrid.prototype.get windowRight):
      (WebInspector.OverviewGrid.prototype.setWindow):
      (WebInspector.OverviewGrid.prototype.addEventListener):
      (WebInspector.TimelineOverviewPane.prototype.setMode):
      (WebInspector.TimelineOverviewPane.prototype._setFrameMode):
      (WebInspector.TimelineOverviewPane.prototype._update):
      (WebInspector.TimelineOverviewPane.prototype.sidebarResized):
      (WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
      (WebInspector.TimelineOverviewPane.prototype._reset):
      (WebInspector.TimelineOverviewPane.prototype.windowLeft):
      (WebInspector.TimelineOverviewPane.prototype.windowRight):
      (WebInspector.TimelineOverviewPane.prototype._updateWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b629a62a