1. 17 Dec, 2010 40 commits
    • mitz@apple.com's avatar
      Rename WebKitTools to Tools · 10955a5a
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49861
      
      Reviewed by Simon Fraser.
      
      .: 
      
      * DerivedSources.pro:
      * GNUmakefile.am:
      * MakeFile:
      * MakeFile.shared:
      * Tools: Renamed from WebKitTools.
      * WebKit.pro:
      * cmake/WebKitPackaging.cmake:
      * wscript:
      
      BugsSite: 
      
      * PrettyPatch/PrettyPatch.rb:
      * committers-autocomplete.js:
      
      Tools: 
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      * CodeCoverage/README:
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::initializeFonts):
      * EWSTools/start-commit-queue.sh:
      * EWSTools/start-queue.sh:
      * GNUmakefile.am:
      * MIDLWrapper/MIDLWrapper.cpp:
      (wmain):
      * MiniBrowser/qt/MiniBrowser.pro:
      * Scripts/build-api-tests:
      * Scripts/build-dumprendertree:
      * Scripts/build-webkit:
      * Scripts/build-webkittestrunner:
      * Scripts/generate-coverage-data:
      * Scripts/old-run-webkit-tests:
      * Scripts/run-api-tests:
      * Scripts/run-iexploder-tests:
      * Scripts/run-javascriptcore-tests:
      * Scripts/run-mangleme-tests:
      * Scripts/run-sunspider:
      * Scripts/run-webkit-websocketserver:
      * Scripts/sunspider-compare-results:
      * Scripts/test-webkitperl:
      * Scripts/test-webkitpy:
      * Scripts/update-iexploder-cssproperties:
      * Scripts/update-webkit:
      * Scripts/update-webkit-localizable-strings:
      * Scripts/webkitdirs.pm:
      * Scripts/webkitpy/common/checkout/scm.py:
      * Scripts/webkitpy/common/checkout/scm_unittest.py:
      * Scripts/webkitpy/common/config/committervalidator.py:
      * Scripts/webkitpy/common/config/committervalidator_unittest.py:
      * Scripts/webkitpy/common/config/ports.py:
      * Scripts/webkitpy/common/config/ports_unittest.py:
      * Scripts/webkitpy/common/system/logutils_unittest.py:
      * Scripts/webkitpy/common/system/ospath_unittest.py:
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      * Scripts/webkitpy/layout_tests/port/config.py:
      * Scripts/webkitpy/layout_tests/port/config_unittest.py:
      * Scripts/webkitpy/layout_tests/port/http_server.py:
      * Scripts/webkitpy/layout_tests/port/test.py:
      * Scripts/webkitpy/style/checker.py:
      * Scripts/webkitpy/style/checker_unittest.py:
      * Scripts/webkitpy/tool/bot/feeders_unittest.py:
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      * Scripts/webkitpy/tool/steps/steps_unittest.py:
      * WebKitTestRunner/DerivedSources.pro:
      * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
      (WTR::activateFonts):
      * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
      * wx/build/build_utils.py:
      
      WebKitSite: 
      
      * asking_questions.html:
      * building/tools.html:
      * coding/scripts.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10955a5a
    • andersca@apple.com's avatar
      Clean up ChunkedUpdateDrawingAreaProxy · 61bfa372
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51277
      
      Reviewed by Simon Fraser.
      
      Get rid of m_lastSetViewSize since it was always equal to m_size.
      
      * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
      (WebKit::ChunkedUpdateDrawingAreaProxy::sizeDidChange):
      Call sendSetSize().
      
      (WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):
      Call sendSetSize if the size differs.
      
      (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
      Move code from sizeDidChange over here.
      
      * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
      * UIProcess/DrawingAreaProxy.cpp:
      (WebKit::DrawingAreaProxy::setSize):
      Add back the early return if the sizes are equal.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61bfa372
    • ariya@webkit.org's avatar
      2010-12-17 Ariya Hidayat <ariya@sencha.com> · a2a8ced6
      ariya@webkit.org authored
              Reviewed by Oliver Hunt.
      
              [JSC] parseAssignmentExpression should use TreeBuilder::CreatesAST
              https://bugs.webkit.org/show_bug.cgi?id=51268
      
              * parser/JSParser.cpp:
              (JSC::JSParser::parseAssignmentExpression):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2a8ced6
    • bfulgham@webkit.org's avatar
      Unreviewed build fix. · 26db6e94
      bfulgham@webkit.org authored
      * WebProcess/WebPage/win/WebPageWin.cpp:
      (WebKit::WebPage::canHandleRequest): Provide alternative for
      non-CFNetwork implementation.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26db6e94
    • ggaren@apple.com's avatar
      2010-12-17 Geoffrey Garen <ggaren@apple.com> · 4e1b079f
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              Removed RChunk from PageAllocation/PageReservation, since it's now unused.
              https://bugs.webkit.org/show_bug.cgi?id=51276
      
              * wtf/PageAllocation.h:
              (WTF::PageAllocation::PageAllocation):
              * wtf/PageReservation.h:
              (WTF::PageReservation::PageReservation):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e1b079f
    • adachan@apple.com's avatar
      Reviewed by Anders Carlsson. · 80df4493
      adachan@apple.com authored
              Implement WKView::setInitialFocus().
              https://bugs.webkit.org/show_bug.cgi?id=51274
      
              * UIProcess/API/C/win/WKView.cpp:
              (WKViewSetInitialFocus):
              * UIProcess/API/C/win/WKView.h:
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::setInitialFocus): Send message to the Web Process to set
              initial focus.
              * UIProcess/WebPageProxy.h:
              * UIProcess/win/WebView.cpp:
              (WebKit::WebView::setInitialFocus):
              * UIProcess/win/WebView.h:
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::setInitialFocus): Set the focused node to null initially.  Then
              ask FocusController to set the initial focus based on the focus direction.
              * WebProcess/WebPage/WebPage.h:
              * WebProcess/WebPage/WebPage.messages.in: Add a new message for SetInitialFocus.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80df4493
    • andersca@apple.com's avatar
      Remove a check that probably uncovered a resizing bug. · 31d421d8
      andersca@apple.com authored
      Reviewed by Sam Weinig.
      
      * UIProcess/DrawingAreaProxy.cpp:
      (WebKit::DrawingAreaProxy::setSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31d421d8
    • andersca@apple.com's avatar
      2010-12-17 Brian Weinstein <bweinstein@apple.com> · 4e1adc4e
      andersca@apple.com authored
              Qt build fix.
      
              * UIProcess/qt/WebPopupMenuProxyQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e1adc4e
    • simon.fraser@apple.com's avatar
      2010-12-17 Simon Fraser <simon.fraser@apple.com> · 65f7bb11
      simon.fraser@apple.com authored
              Change this test to use the pause API by testing the individual properties,
              rather than the compound property.
      
              * transitions/mask-transitions-expected.txt: Removed.
              * transitions/mask-transitions.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65f7bb11
    • carol.szabo@nokia.com's avatar
      2010-12-17 Carol Szabo <carol.szabo@nokia.com> · 1cbfead4
      carol.szabo@nokia.com authored
              Reviewed by Darin Adler.
      
              A corrupted counter tree is created when renderers are added to the
              tree bypassing RenderObject::addChild
              https://bugs.webkit.org/show_bug.cgi?id=51270
      
              This patch replaces the hack introduced for fixing bug 43812
              with code that addresses the underlying problem for that bug.
              No new layout tests provided as there is no identified scenario when
              visible behavior would be different, the internal datastructures
              are maintained properly through this fix so the previous hack
              introduced for bug 43812 is now removed. The fact that the
              layout test introduced for 43812 continues to pass is proof that the
              code works.
      
              * rendering/RenderCounter.cpp:
              (WebCore::findPlaceForCounter):
                Removed hack.
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::addChild):
                Moved call to counter nodes updater to lower level
                functions to avoid bypass.
              * rendering/RenderObjectChildList.cpp:
              (WebCore::RenderObjectChildList::appendChildNode):
              (WebCore::RenderObjectChildList::insertChildNode):
                Changed to update the values of the counters that
                may be inserted in the tree.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cbfead4
    • oliver@apple.com's avatar
      2010-12-17 Oliver Hunt <oliver@apple.com> · 7cb46cbe
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Incorrect encoding of some constants in ARMv7 JIT
              https://bugs.webkit.org/show_bug.cgi?id=51273
              <rdar://problem/8650210>
      
              When using immediate encoding 3 we need to write the byte
              that holds a duplicated value.
      
              * assembler/ARMv7Assembler.h:
              (JSC::ARMThumbImmediate::makeEncodedImm):
      2010-12-17  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Gavin Barraclough.
      
              Incorrect encoding of some constants in ARMv7 JIT
              https://bugs.webkit.org/show_bug.cgi?id=51273
      
              Add a few tests for different byte patterns in immediates.
      
              * fast/js/constant-encoding-expected.txt: Added.
              * fast/js/constant-encoding.html: Added.
              * fast/js/script-tests/constant-encoding.js: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cb46cbe
    • jberlin@webkit.org's avatar
      Add Windows-specific expected results for the the tests added in · be9278fd
      jberlin@webkit.org authored
      http://trac.webkit.org/changeset/74281.
      
      Rubber-stamped by Dan Bernstein.
      
      * platform/win/fast/text/emphasis-expected.checksum: Added.
      * platform/win/fast/text/emphasis-expected.png: Added.
      * platform/win/fast/text/emphasis-expected.txt: Added.
      * platform/win/fast/text/emphasis-vertical-expected.checksum: Added.
      * platform/win/fast/text/emphasis-vertical-expected.png: Added.
      * platform/win/fast/text/emphasis-vertical-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be9278fd
    • bweinstein@apple.com's avatar
      Qt build fix. · fe1e9204
      bweinstein@apple.com authored
      * UIProcess/qt/WebPopupMenuProxyQt.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe1e9204
    • commit-queue@webkit.org's avatar
      2010-12-17 Shimeng (Simon) Wang <swang@google.com> · e38b3c80
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              Fix V8 JNI binding.
              https://bugs.webkit.org/show_bug.cgi?id=51156
      
              There're LayoutTests in:
              http://trac.webkit.org/browser/trunk/LayoutTests/java/lc3/JSNumber
              to exercise these code paths.
              Though Chromium don't run them.
              Tested on Android fast/events/touch tests.
      
              * bridge/jni/v8/JNIUtilityPrivate.cpp:
              (JSC::Bindings::convertNPVariantToJValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e38b3c80
    • simon.fraser@apple.com's avatar
      2010-12-17 Simon Fraser <simon.fraser@apple.com> · 99ff95d9
      simon.fraser@apple.com authored
              Reviewed by Chris Marrin.
      
              Interrupted accelerated animation can break later transitions
              <rdar://problem/8767714>
              https://bugs.webkit.org/show_bug.cgi?id=51264
      
              If we're still waiting for the 'animationDidStart' callback when renderers
              get destroyed, then the m_waitingForStartTimeResponse flag could be left
              set to 'true', which causes later transitions to never start.
      
              Fix by clearing the m_waitingForStartTimeResponse flag when the m_startTimeResponseWaiters
              becomes empty.
      
              Test: transitions/interrupted-accelerated-transition.html
      
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99ff95d9
    • simon.fraser@apple.com's avatar
      2010-12-17 Simon Fraser <simon.fraser@apple.com> · 0aa5fe3e
      simon.fraser@apple.com authored
              Reviewed by Chris Marrin.
      
              Interrupted accelerated animation can break later transitions
              https://bugs.webkit.org/show_bug.cgi?id=51264
      
              Step 1: code cleanup.
              Rename "responseWait" variables to "startTimeResponseWait", to make it clear
              the kind of response that is being waited for.
      
              Make a couple of methods private.
      
              No behavioral changes, so no tests.
      
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
              (WebCore::AnimationControllerPrivate::endAnimationUpdate):
              (WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
              (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
              (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
              (WebCore::AnimationControllerPrivate::startTimeResponse):
              * page/animation/AnimationControllerPrivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0aa5fe3e
    • bweinstein@apple.com's avatar
      Text area does not update when you arrow through a <select> in WebKit2 · 818cf708
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51269
      <rdar://problem/8612853>
              
      Reviewed by Anders Carlsson.
      
      Patch by Sam Weinig.
              
      Insteaed of keeping track of the selected index of a <select> just in the UI process, we
      need to pass this information along to the web process so that the web process can draw
      the correct text in the text field at the top of the select, when the selection changes (via
      the arrows or other typing while the select is opened).
              
      When the selected item in a popup changes, the UI process sends a message to the web process, telling
      it about the new selected index. The web process gets this message, and then sets the text that
      is visible in the select element.
      
      * UIProcess/API/mac/PageClientImpl.h: CreatePopupMenuProxy now takes a WebPageProxy.
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::createPopupMenuProxy): Pass the WebPageProxy to create.
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPagePrivate::createPopupMenuProxy):
      * UIProcess/API/qt/qwkpage_p.h: CreatePopupMenuProxy now takes a WebPageProxy.
      * UIProcess/PageClient.h: CreatePopupMenuProxy now takes a WebPageProxy.
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::valueChangedForPopupMenu): Send that the selected index changed to the 
          web process.selected
      (WebKit::WebPageProxy::setTextFromItemForPopupMenu): Send that we should update the text for the
          active popup menu (with the index of the item to show).
      (WebKit::WebPageProxy::showPopupMenu): Pass the WebPageProxy to createPopupMenuProxy.
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPopupMenuProxy.h: Add a client who has virtual functions for the state changing of the
          popup menu. ShowPopupMenu doesn't take a new selected index anymore, that is handled by the client,
          and calling down to the web process.
      (WebKit::WebPopupMenuProxy::Client::~Client):
      (WebKit::WebPopupMenuProxy::WebPopupMenuProxy): Initialize the client.
      * UIProcess/mac/WebPopupMenuProxyMac.h:
      (WebKit::WebPopupMenuProxyMac::create): Takes a WebPopupMenuProxy::Client, and passes it to the constructor.
      * UIProcess/mac/WebPopupMenuProxyMac.mm:
      (WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac): Update what's initialized by the constructor.
      (WebKit::WebPopupMenuProxyMac::showPopupMenu): Call through to the web process that the value changed.
      * UIProcess/qt/WebPopupMenuProxyQt.cpp:
      (WebKit::WebPopupMenuProxyQt::WebPopupMenuProxyQt): Update what's initialized by the constructor.
      * UIProcess/win/WebPopupMenuProxyWin.cpp:
      (WebKit::WebPopupMenuProxyWin::WebPopupMenuProxyWin): Ditto.
      (WebKit::WebPopupMenuProxyWin::showPopupMenu): Call through to the web process that the value changed.
      (WebKit::WebPopupMenuProxyWin::setFocusedIndex): Resolve a FIXME to set the text of the popup menu.
      * UIProcess/win/WebPopupMenuProxyWin.h:
      (WebKit::WebPopupMenuProxyWin::create): Take in a WebPopupMenuProxy::client, and pass it to the constructor.
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::createPopupMenuProxy): Pass the WebPageProxy to create.
      * UIProcess/win/WebView.h:
      * WebProcess/WebCoreSupport/WebPopupMenu.cpp:
      (WebKit::WebPopupMenu::setTextForIndex): Call through to setTextFromItem to set the select text.
      * WebProcess/WebCoreSupport/WebPopupMenu.h:
      * WebProcess/WebPage/WebPage.cpp: Call through to setTextForIndex on the active popup menu.
      (WebKit::WebPage::setTextForActivePopupMenu):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in: Add a new message.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      818cf708
    • andersca@apple.com's avatar
      Add a WebPageProxy parameter to the DrawingAreaProxy constructor · 2914d3da
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51271
      
      Reviewed by Sam Weinig.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView initWithFrame:contextRef:pageGroupRef:]):
      (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
      * UIProcess/API/qt/qgraphicswkview.cpp:
      (QGraphicsWKView::QGraphicsWKView):
      * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
      (WebKit::ChunkedUpdateDrawingAreaProxy::create):
      (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
      * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
      * UIProcess/DrawingAreaProxy.cpp:
      (WebKit::DrawingAreaProxy::DrawingAreaProxy):
      * UIProcess/DrawingAreaProxy.h:
      * UIProcess/LayerBackedDrawingAreaProxy.cpp:
      (WebKit::LayerBackedDrawingAreaProxy::create):
      (WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):
      * UIProcess/LayerBackedDrawingAreaProxy.h:
      * UIProcess/TiledDrawingAreaProxy.cpp:
      (WebKit::TiledDrawingAreaProxy::create):
      (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
      * UIProcess/TiledDrawingAreaProxy.h:
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::WebView):
      (WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2914d3da
    • mitz@apple.com's avatar
      Add API for "Always Use the Complex Text Code Path" · f8ff23a1
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51265
      
      Reviewed by Darin Adler.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Initialize shouldAlwaysUseComplexTextCodePath.
      (WebKit::WebProcessCreationParameters::encode): Encode shouldAlwaysUseComplexTextCodePath.
      (WebKit::WebProcessCreationParameters::decode): Decode shouldAlwaysUseComplexTextCodePath.
      * Shared/WebProcessCreationParameters.h:
      * UIProcess/API/C/WKContext.cpp: 
      (_WKContextSetAlwaysUsesComplexTextCodePath): Added.
      * UIProcess/API/C/WKContextPrivate.h:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::WebContext): Initialize m_alwaysUsesComplexTextCodePath.
      (WebKit::WebContext::ensureWebProcess): Set shouldAlwaysUseComplexTextCodePath in the creation parameters.
      (WebKit::WebContext::setAlwaysUsesComplexTextCodePath): Added. Sets m_alwaysUsesComplexTextCodePath and
      sends a message to the WebProcess.
      * UIProcess/WebContext.h:
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess): Call setAlwaysUsesComplexTextCodePath() based on the creation
      parameters.
      (WebKit::WebProcess::setAlwaysUsesComplexTextCodePath): Added.
      * WebProcess/WebProcess.h:
      * WebProcess/WebProcess.messages.in: Added SetAlwaysUsesComplexTextCodePath.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8ff23a1
    • weinig@apple.com's avatar
      WebKit2: Implement a title attribute per frame · 6e2d323e
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51266
      
      Reviewed by Darin Adler.
      
      Cache the title of each frame on the WebFrameProxy. Removes
      the WebPageProxy's cache of the main frame title to just
      access the main frame.
      
      We clear the cached title on new committed loads and on failures
      to load.
      
      * UIProcess/API/C/WKFrame.cpp:
      (WKFrameCopyTitle):
      * UIProcess/API/C/WKFrame.h:
      * UIProcess/WebFrameProxy.cpp:
      (WebKit::WebFrameProxy::didCommitLoad):
      (WebKit::WebFrameProxy::didFailLoad):
      (WebKit::WebFrameProxy::didChangeTitle):
      * UIProcess/WebFrameProxy.h:
      (WebKit::WebFrameProxy::title):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::close):
      (WebKit::WebPageProxy::pageTitle):
      (WebKit::WebPageProxy::didReceiveTitleForFrame):
      (WebKit::WebPageProxy::processDidCrash):
      * UIProcess/WebPageProxy.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e2d323e
    • mitz@apple.com's avatar
      WebCore: Layout and rendering of CSS text-emphasis · 3672d9e7
      mitz@apple.com authored
      Final part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
      https://bugs.webkit.org/show_bug.cgi?id=48539
      
      Reviewed by Dave Hyatt.
      
      Tests: fast/text/emphasis-vertical.html
             fast/text/emphasis.html
      
      Emphasis marks behave like they are stuck just above the ascender (or just below the
      descender). They occupy space in the leading and in padding, and only grow the line space
      if they cannot fit.
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::placeBoxesInBlockDirection): Renamed the containsRuby parameter to
      hasAnnotationsBefore, and added hasAnnotationsAfter. Line annotations include ruby and text emphasis
      marks.
      (WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added overflow from emphasis marks.
      (WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Remaned computeBlockDirectionRubyAdjustment()
      to this and added adjustment for text emphasis marks.
      (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment): Added. Similar to the previous function,
      but for annotations under the glyphs. These can only be text emphasis marks.
      * rendering/InlineFlowBox.h:
      * rendering/InlineTextBox.cpp:
      (WebCore::paintTextWithShadows): Paint emphasis marks.
      (WebCore::InlineTextBox::paint): Ditto.
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::layoutInlineChildren): Generalized the code that adjusts the last line for
      ruby in flipped writing mode to also adjust the last line for emphasis marks under the line in non-
      flipped writing mode.
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::selectionColor): Added this helper method which generalizes selectionForegroundColor().
      (WebCore::RenderObject::selectionForegroundColor): Moved most of the code to selectionColor().
      (WebCore::RenderObject::selectionEmphasisMarkColor): Added.
      * rendering/RenderObject.h:
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::RootInlineBox): Updated initialization for new members.
      (WebCore::RootInlineBox::alignBoxesInBlockDirection): Update new members.
      (WebCore::RootInlineBox::beforeAnnotationsAdjustment): Renamed blockDirectionRubyAdjustment() to this
      and extended to deal with annotations over and under the line and the previous line. If both lines have
      annotations into the space between the lines, maintain separation so that the annotations do not overlap.
      * rendering/RootInlineBox.h:
      (WebCore::RootInlineBox::hasAnnotationsBefore): Added this accessor.
      (WebCore::RootInlineBox::hasAnnotationsAfter): Ditto.
      
      LayoutTests: <rdar://problem/7720300> Support the CSS3 text-emphasis property
      https://bugs.webkit.org/show_bug.cgi?id=48539
      
      Reviewed by Dave Hyatt.
      
      * fast/text/emphasis-vertical.html: Added.
      * fast/text/emphasis.html: Added.
      * platform/mac/fast/text/emphasis-expected.checksum: Added.
      * platform/mac/fast/text/emphasis-expected.png: Added.
      * platform/mac/fast/text/emphasis-expected.txt: Added.
      * platform/mac/fast/text/emphasis-vertical-expected.checksum: Added.
      * platform/mac/fast/text/emphasis-vertical-expected.png: Added.
      * platform/mac/fast/text/emphasis-vertical-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3672d9e7
    • tonikitoo@webkit.org's avatar
      2010-12-17 Antonio Gomes <agomes@rim.com> · cc669eae
      tonikitoo@webkit.org authored
              Unreviewed fix for Windows bots.
      
              r74270 removed the windows specific result for extend-selection-home-end.html
              since it was matching the cross platform expectation result. However, when there is
              no win specific test result but there is a mac one for the same test, the later
              is picked before the cross platform one.
      
              * platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc669eae
    • rniwa@webkit.org's avatar
      2010-12-17 Ryosuke Niwa <rniwa@webkit.org> · 9e9ef41f
      rniwa@webkit.org authored
              Reviewed by Antonio Gomes.
      
              editing/execCommand/toggle-compound-styles-expected should use LayoutTestController::setEditingBehavior
              https://bugs.webkit.org/show_bug.cgi?id=51261
      
              Modified the test to run each test case using each editing behavior, eliminating the need for
              platform-specific expected results.
      
              * editing/execCommand/script-tests/toggle-compound-styles.js:
              (testSingleToggle):
              * platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
              * platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
              * platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
              * platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e9ef41f
    • commit-queue@webkit.org's avatar
      2010-12-17 W. James MacLean <wjmaclean@chromium.org> · 3c25411f
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              [chromium] Add support to compositor to composite to offscreen texture.
              https://bugs.webkit.org/show_bug.cgi?id=50833
      
              A patch to extend compositor to be able to composite into an offscreen texture instead
              of just directly to the display buffer. Builds on RenderSurfaceChromium support.
      
              External behaviour not changed, so no tests.
      
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::LayerRendererChromium):
              (WebCore::LayerRendererChromium::prepareToDrawLayers):
              (WebCore::LayerRendererChromium::drawLayers):
              (WebCore::LayerRendererChromium::setCompositeOffscreen):
              (WebCore::LayerRendererChromium::useRenderSurface):
              (WebCore::LayerRendererChromium::setScissorToRect):
              * platform/graphics/chromium/LayerRendererChromium.h:
              (WebCore::LayerRendererChromium::isCompositingOffscreen):
              (WebCore::LayerRendererChromium::getOffscreenLayerTexture):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c25411f
    • ojan@chromium.org's avatar
      2010-12-17 Ojan Vafai <ojan@chromium.org> · 3bc3182a
      ojan@chromium.org authored
              Increment psuedo-version number to avoid pulling cached version.
      
              * PrettyPatch/PrettyPatch.rb:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bc3182a
    • ojan@chromium.org's avatar
      2010-12-17 Ojan Vafai <ojan@chromium.org> · 325916cb
      ojan@chromium.org authored
              Speculative fix for the code review tool in Firefox.
              Fixes a JS error and makes the status bubble mostly work
              if postMessage is not supported.
      
              * PrettyPatch/PrettyPatch.rb:
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      325916cb
    • darin@apple.com's avatar
      2010-12-16 Darin Adler <darin@apple.com> · 7d47c0ec
      darin@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Add text encoding menu API for WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=51226
      
              * UIProcess/API/C/WKPage.cpp:
              (WKPageSupportsTextEncoding): Added.
              (WKPageCopyCustomTextEncodingName): Added.
              (WKPageSetCustomTextEncodingName): Added.
              * UIProcess/API/C/WKPage.h: Added the functions above.
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::WebPageProxy): Initialize
              m_mainFrameHasCustomRepresentation to false.
              (WebKit::WebPageProxy::supportsTextEncoding): Added.
              (WebKit::WebPageProxy::setCustomTextEncodingName): Added.
              (WebKit::WebPageProxy::didCommitLoadForFrame): Set
              m_mainFrameHasCustomRepresentation.
      
              * UIProcess/WebPageProxy.h: Added supportsTextEncoding,
              setCustomTextEncodingName, customTextEncodingName, and
              m_mainFrameHasCustomRepresentation.
      
              * UIProcess/WebPageProxy.messages.in: Tweaked formatting
              (added a blank line).
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::setCustomTextEncodingName): Added.
              * WebProcess/WebPage/WebPage.h: Added setCustomTextEncodingName.
      
              * WebProcess/WebPage/WebPage.messages.in: Added the
              SetCustomTextEncodingName message. Tweaked formatting of the
              dummy message.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d47c0ec
    • commit-queue@webkit.org's avatar
      2010-12-17 John Knottenbelt <jknotten@chromium.org> · 452bbf52
      commit-queue@webkit.org authored
              Reviewed by Jeremy Orlow.
      
              Fix test failures where NULL GeolocationClient is provided
              https://bugs.webkit.org/show_bug.cgi?id=51256
      
              * src/GeolocationClientProxy.cpp:
              (WebKit::GeolocationClientProxy::geolocationDestroyed):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      452bbf52
    • tonikitoo@webkit.org's avatar
      2010-12-17 Antonio Gomes <agomes@rim.com> · cf681cdb
      tonikitoo@webkit.org authored
              Unreviewed expectation result update.
      
              editing/execCommand/toggle-compound-styles.html needs new expected results after r74269.
      
              Default editing behavior of GTK+ DRT was changed from Mac to Unix, and this test is wrongly
              going through platform specific editing behavior code path without making calls to
              LayoutTestController::setEditingBehavior. Filed bug 51261 for the proper fix.
      
              * platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf681cdb
    • ariya@webkit.org's avatar
      2010-12-17 Ariya Hidayat <ariya@sencha.com> · 48b57642
      ariya@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Default image interpolation should reset the render hint
              https://bugs.webkit.org/show_bug.cgi?id=51233
      
              Save initial SmoothPixmapTransform render hint so that it can be used
              with default image interpolation quality to reset back the render hints.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
              (WebCore::GraphicsContext::setImageInterpolationQuality):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48b57642
    • ariya@webkit.org's avatar
      2010-12-17 Ariya Hidayat <ariya@sencha.com> · cd8257ee
      ariya@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [Qt] GraphicsContext should respect QWebView render hints
              https://bugs.webkit.org/show_bug.cgi?id=51208
      
              Adjust the test since SmoothPixmapTransform is set by default.
      
              * tests/qwebview/tst_qwebview.cpp:
              (tst_QWebView::renderHints):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd8257ee
    • tonikitoo@webkit.org's avatar
      2010-12-05 Antonio Gomes <agomes@rim.com> · 6866d312
      tonikitoo@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              [Qt] Fix caret browsing navigation mode
              https://bugs.webkit.org/show_bug.cgi?id=50536
      
              WebKit/qt:
      
              Caret browsing can consume editing commands even when the start
              of current selection is not a editable content. r69582 missed this
              case because caret browsing feature testing is very poor today.
      
              This commit reintroduces part of the removed code in r69582 but
              guarded by a isCaretBrowsingEnabled() check. No regression found.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::handleKeyboardEvent):
      
              LayoutTests:
      
              /platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html
              is one of the few tests actually tests the caret browsing feature.
              Patch makes the test not Gtk+ specific, and Qt now passes on it.
      
              * editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.tx       t.
              * editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html.
              * fast/events/multiline-link-arrow-navigation.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6866d312
    • tonikitoo@webkit.org's avatar
      2010-12-16 Antonio Gomes <agomes@rim.com> · 2238abfc
      tonikitoo@webkit.org authored
              Reviewed by Martin Robinson.
      
              Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
              https://bugs.webkit.org/show_bug.cgi?id=51163
      
              WebKitTools:
              Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
              GTK+'s DRT should also reset to UNIX after each test execution.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
      
              LayoutTests:
              Removed platform specific expected result files for gtk and windows
              for editing/selection/extend-selection-home-end.html, since they all match
              the cross platform result file.
      
              Note: chromium-win and mac still have their own expected file each.
      
              * platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Removed.
              * platform/win/editing/selection/extend-selection-home-end-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2238abfc
    • commit-queue@webkit.org's avatar
      2010-12-17 Sheriff Bot <webkit.review.bot@gmail.com> · 54a275ae
      commit-queue@webkit.org authored
              Unreviewed, rolling out r74201.
              http://trac.webkit.org/changeset/74201
              https://bugs.webkit.org/show_bug.cgi?id=51248
      
              It broke ~6000 layout tests (Requested by Ossy_ on #webkit).
      
              * UIProcess/API/qt/qgraphicswkview.cpp:
              (QGraphicsWKView::setGeometry):
              (QGraphicsWKView::itemChange):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54a275ae
    • yurys@chromium.org's avatar
      2010-12-17 Yury Semikhatsky <yurys@chromium.org> · 4ce5c5e4
      yurys@chromium.org authored
              Unreviewed. Remove custom expectations for fast/js/regexp-ranges-and-escaped-hyphens.html
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ce5c5e4
    • hans@chromium.org's avatar
      2010-12-17 Hans Wennborg <hans@chromium.org> · 7e775392
      hans@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Support Date objects as keys.
              https://bugs.webkit.org/show_bug.cgi?id=51193
      
              Update layout tests to check that having Date objects as keys work.
      
              * storage/indexeddb/objectstore-basics-expected.txt:
              * storage/indexeddb/objectstore-basics.html:
      2010-12-17  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Support Date objects as keys.
              https://bugs.webkit.org/show_bug.cgi?id=51193
      
              * bindings/v8/IDBBindingUtilities.cpp:
              (WebCore::createIDBKeyFromValue):
              Use the new IDBKey factory functions, and support Date objects.
              * bindings/v8/custom/V8IDBKeyCustom.cpp:
              (WebCore::toV8):
              Create Date objects from DateType keys.
              * storage/IDBKey.cpp:
              (WebCore::IDBKey::fromQuery):
              (WebCore::IDBKey::isEqual):
              (WebCore::IDBKey::whereSyntax):
              (WebCore::IDBKey::lowerCursorWhereFragment):
              (WebCore::IDBKey::upperCursorWhereFragment):
              (WebCore::IDBKey::bind):
              (WebCore::IDBKey::bindWithNulls):
              Update all SQL related functions to handle Date keys.
              * storage/IDBKey.h:
              (WebCore::IDBKey::createNull):
              (WebCore::IDBKey::createNumber):
              (WebCore::IDBKey::createString):
              (WebCore::IDBKey::createDate):
              Rename the create factories; since both number and date is just a
              double, function overloading can't be used to discriminate between
              the factories.
              (WebCore::IDBKey::date):
              Add getter for the date value.
      2010-12-17  Hans Wennborg  <hans@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB: Support Date objects as keys.
              https://bugs.webkit.org/show_bug.cgi?id=51193
      
              Update to match the underlying WebCore IDBKey class:
              add the DateType, add create() functions for each type,
              deprecate the public constructors (will be removed once
              Chromium side is updated).
      
              * public/WebIDBKey.h:
              (WebKit::WebIDBKey::WebIDBKey):
              * src/AssertMatchingEnums.cpp:
              * src/WebIDBKey.cpp:
              (WebKit::WebIDBKey::createString):
              (WebKit::WebIDBKey::createDate):
              (WebKit::WebIDBKey::createNumber):
              (WebKit::WebIDBKey::assignNull):
              (WebKit::WebIDBKey::assignString):
              (WebKit::WebIDBKey::assignDate):
              (WebKit::WebIDBKey::assignNumber):
              (WebKit::WebIDBKey::date):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e775392
    • sergio@webkit.org's avatar
      2010-12-17 Sergio Villar Senin <svillar@igalia.com> · 6e972867
      sergio@webkit.org authored
              Unreviewed, tests were skipped due to a bug in libsoup
              https://bugzilla.gnome.org/show_bug.cgi?id=631679. Now that it was
              fixed we can safely unskip them again.
      
              [GTK] Failing http/tests/xmlhttprequest tests
              https://bugs.webkit.org/show_bug.cgi?id=30582
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e972867
    • podivilov@chromium.org's avatar
      2010-12-17 Pavel Podivilov <podivilov@chromium.org> · d9038300
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: add scripts parsed after resource load to SourceFrame.
              https://bugs.webkit.org/show_bug.cgi?id=51243
      
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._addScript):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype.addScript):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9038300
    • antonm@chromium.org's avatar
      2010-12-17 Anton Muhin <antonm@chromium.org> · 58ca85ac
      antonm@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              [v8] The last portion of CSS GC work: fixing fast/dom/StyleSheet/gc-stylesheet-wrapper.html
              https://bugs.webkit.org/show_bug.cgi?id=51121
      
              Properly group style elements of HTML links, style elements and processing instructions.
      
              * bindings/v8/V8GCController.cpp:
              (WebCore::NodeGrouperVisitor::visitDOMWrapper):
              (WebCore::NodeGrouperVisitor::addDOMObjectToGroup):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58ca85ac
    • podivilov@chromium.org's avatar
      2010-12-17 Pavel Podivilov <podivilov@chromium.org> · 3185b856
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [REGRESSION] scripts in scripts panel are not updated on reload.
              https://bugs.webkit.org/show_bug.cgi?id=51101
      
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3185b856