1. 15 Jan, 2011 3 commits
  2. 14 Jan, 2011 37 commits
    • simon.fraser@apple.com's avatar
      2011-01-14 Simon Fraser <simon.fraser@apple.com> · 8c9d5403
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              Plugins render incorrectly with transformed ancestors
              https://bugs.webkit.org/show_bug.cgi?id=52507
      
              -[NSView visibleRect] gives the wrong answer if there are CSS transforms
              in the ancestor chain of a plugin.
      
              So use of this method with calls to -actualVisibleRectInWindow, which
              maps rects through the render tree to compute the correct rect,
              clipping via windowClipRect() if necessary.
      
              Not testable, because doing so relies on the behavior of some
              plugins, which stop rendering if setWindow passes an empty rect.
      
              * Plugins/Hosted/WebHostedNetscapePluginView.mm:
              (-[WebHostedNetscapePluginView updateAndSetWindow]):
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
              * Plugins/WebNetscapePluginView.mm:
              (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c9d5403
    • oliver@apple.com's avatar
      2011-01-14 Oliver Hunt <oliver@apple.com> · edebdc12
      oliver@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              [jsfunfuzz] Incorrect handling of consecutive duplicate labels
              https://bugs.webkit.org/show_bug.cgi?id=52505
      
              Add a few tests of consecutive labels containing duplicates to the parser check.
      
              * fast/js/parser-syntax-check-expected.txt:
              * fast/js/script-tests/parser-syntax-check.js:
      2011-01-14  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              [jsfunfuzz] Incorrect handling of consecutive duplicate labels
              https://bugs.webkit.org/show_bug.cgi?id=52505
      
              Compare StringImpl*'s instead of Identifier*'s when looking for duplicate
              labels.
      
              * parser/JSParser.cpp:
              (JSC::JSParser::parseExpressionOrLabelStatement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edebdc12
    • commit-queue@webkit.org's avatar
      2011-01-14 Xiyuan Xia <xiyuan@chromium.org> · d8df37f3
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              Prepare Linux WebThemeEngine interface to support new theme parts.
              https://bugs.webkit.org/show_bug.cgi?id=52413
      
              * public/linux/WebThemeEngine.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8df37f3
    • commit-queue@webkit.org's avatar
      2011-01-14 Sam Magnuson <smagnuso@gmail.com> · 61b414ce
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Compile with QT_NO_GRAPHICSVIEW
              https://bugs.webkit.org/show_bug.cgi?id=49750
      
              * platform/graphics/qt/GraphicsLayerQt.cpp:
              * platform/graphics/qt/GraphicsLayerQt.h:
              * platform/qt/PlatformMouseEventQt.cpp:
      2011-01-14  Sam Magnuson  <smagnuso@gmail.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Compile with QT_NO_GRAPHICSVIEW
              https://bugs.webkit.org/show_bug.cgi?id=49750
      
              * Api/qgraphicswebview.cpp:
              * Api/qgraphicswebview.h:
              * Api/qwebpage.cpp:
              (QWebPage::event):
              * Api/qwebpage_p.h:
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::createPlugin):
              * WebCoreSupport/PageClientQt.cpp:
              * WebCoreSupport/PageClientQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61b414ce
    • dimich@chromium.org's avatar
      Not reviewed, update of Chromium test expectations. · c22dfbbb
      dimich@chromium.org authored
      Update of files affected by mass rebaseline in r75828 and r75838
      
      * platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.checksum:
      * platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png:
      * platform/chromium-mac/plugins/embed-attributes-style-expected.txt: Removed.
      * platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
      * platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c22dfbbb
    • simon.fraser@apple.com's avatar
      2011-01-14 Simon Fraser <simon.fraser@apple.com> · 554e1d06
      simon.fraser@apple.com authored
              No review.
      
              Initialize m_operationInProgress after r75855.
      
              * runtime/Heap.cpp:
              (JSC::Heap::Heap):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      554e1d06
    • ggaren@apple.com's avatar
      Reverted accidentally committed code from my last checkin. · edf34a60
      ggaren@apple.com authored
      * runtime/Heap.cpp:
      (JSC::Heap::markRoots):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edf34a60
    • ggaren@apple.com's avatar
      Try to fix the GTK bot. · 2029c2ad
      ggaren@apple.com authored
      Reviewed by Sam Weinig.
      
      * runtime/Heap.cpp:
      (JSC::Heap::Heap):
      (JSC::Heap::markRoots): Kids, remember to initialize your data members.
      Knowing is half the battle.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2029c2ad
    • dimich@chromium.org's avatar
      Not reviewed, update of test expectations. · 223f0eb4
      dimich@chromium.org authored
      Ignore new test fast/js/js-continue-break-restrictions.html, it fails for V8.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      223f0eb4
    • ericu@chromium.org's avatar
      2011-01-14 Eric Uhrhane <ericu@chromium.org> · bc3647f0
      ericu@chromium.org authored
              Reviewed by David Levin.
      
              Add tests for FileWriterSync
              https://bugs.webkit.org/show_bug.cgi?id=50720
      
              * fast/filesystem/resources/file-writer-sync-truncate-extend.js: Added.
              * fast/filesystem/workers/file-writer-sync-truncate-extend.html: Added.
              * fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Added.
              * fast/filesystem/resources/file-writer-sync-write-overlapped.js: Added.
              * fast/filesystem/workers/file-writer-sync-write-overlapped.html: Added.
              * fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Added.
              * fast/filesystem/resources/file-writer-utils.js:
              (assert): Make assert throw, rather than continue.
              (cleanUp): Always call finishJSTest, even without fileEntryForCleanup.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc3647f0
    • paroga@webkit.org's avatar
      2011-01-14 Patrick Gansterer <paroga@webkit.org> · c9b0ca94
      paroga@webkit.org authored
              Unreviewed. Try to fix EFL build.
      
              * ewk/ewk_frame.cpp:
              (ewk_frame_scroll_add): Added WebCore namespace to IntSize.
              * ewk/ewk_view.cpp:
              (_ewk_view_viewport_attributes_compute): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9b0ca94
    • oliver@apple.com's avatar
      2011-01-14 Oliver Hunt <oliver@apple.com> · 03954a3f
      oliver@apple.com authored
              Reviewed by Stephanie Lewis.
      
              [jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
              https://bugs.webkit.org/show_bug.cgi?id=52501
      
              Add checks for correct behaviour when the strict mode token is immediately followed
              by a value that needs a temporary buffer in the lexer.
      
              * fast/js/basic-strict-mode-expected.txt:
              * fast/js/script-tests/basic-strict-mode.js:
      2011-01-14  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Stephanie Lewis.
      
              [jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
              https://bugs.webkit.org/show_bug.cgi?id=52501
      
              Clear the temporary character buffers used for reading escaped characters and
              numbers.
      
              * parser/Lexer.h:
              (JSC::Lexer::setOffset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03954a3f
    • tony@chromium.org's avatar
      2011-01-14 Tony Chang <tony@chromium.org> · 1e26d554
      tony@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              Strip NUL character when copying text on Windows
              https://bugs.webkit.org/show_bug.cgi?id=52236
      
              * editing/pasteboard/copy-null-characters-expected.txt: Added.
              * editing/pasteboard/copy-null-characters.html: Added.
      2011-01-14  Tony Chang  <tony@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Strip NUL character when copying text on Windows
              https://bugs.webkit.org/show_bug.cgi?id=52236
      
              Test: editing/pasteboard/copy-null-characters.html
      
              * editing/Editor.cpp:
              (WebCore::Editor::selectedText):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e26d554
    • yuzo@google.com's avatar
      2011-01-14 Yuzo Fujishima <yuzo@google.com> · 13694ec6
      yuzo@google.com authored
              Reviewed by Antti Koivisto.
      
              Rename cache() to memoryCache()
              https://bugs.webkit.org/show_bug.cgi?id=52433
      
              No new tests because the behavior remains the same.
      
              * WebCore.exp.in:
              * WebCore.order:
              * history/PageCache.cpp:
              (WebCore::PageCache::releaseAutoreleasedPagesNow):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::cachedResource):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::create):
              * loader/cache/CachedImage.cpp:
              (WebCore::CachedImage::allClientsRemoved):
              (WebCore::CachedImage::data):
              * loader/cache/CachedResource.cpp:
              (WebCore::CachedResource::~CachedResource):
              (WebCore::CachedResource::addClientToSet):
              (WebCore::CachedResource::removeClient):
              (WebCore::CachedResource::setDecodedSize):
              (WebCore::CachedResource::setEncodedSize):
              (WebCore::CachedResource::didAccessDecodedData):
              * loader/cache/CachedResourceLoader.cpp:
              (WebCore::CachedResourceLoader::CachedResourceLoader):
              (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
              (WebCore::CachedResourceLoader::requestResource):
              (WebCore::CachedResourceLoader::revalidateResource):
              (WebCore::CachedResourceLoader::loadResource):
              (WebCore::CachedResourceLoader::clearPreloads):
              (WebCore::CachedResourceLoader::printPreloadStats):
              * loader/cache/CachedResourceRequest.cpp:
              (WebCore::CachedResourceRequest::load):
              (WebCore::CachedResourceRequest::didFail):
              (WebCore::CachedResourceRequest::didReceiveResponse):
              * loader/cache/MemoryCache.cpp:
              (WebCore::memoryCache):
              * loader/cache/MemoryCache.h:
      2011-01-14  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Antti Koivisto.
      
              Rename cache() to memoryCache()
              https://bugs.webkit.org/show_bug.cgi?id=52433
      
              * src/WebCache.cpp:
              (WebKit::WebCache::setCapacities):
              (WebKit::WebCache::clear):
              (WebKit::WebCache::getUsageStats):
              (WebKit::WebCache::getResourceTypeStats):
      2011-01-14  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Antti Koivisto.
      
              Rename cache() to memoryCache()
              https://bugs.webkit.org/show_bug.cgi?id=52433
      
              * webkit/webkitglobals.cpp:
              (webkit_set_cache_model):
      2011-01-14  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Antti Koivisto.
      
              Rename cache() to memoryCache()
              https://bugs.webkit.org/show_bug.cgi?id=52433
      
              * Misc/WebCache.mm:
              (+[WebCache statistics]):
              (+[WebCache setDisabled:]):
              (+[WebCache isDisabled]):
              * WebView/WebView.mm:
              (+[WebView _setCacheModel:]):
      2011-01-14  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Antti Koivisto.
      
              Rename cache() to memoryCache()
              https://bugs.webkit.org/show_bug.cgi?id=52433
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::_q_cleanupLeakMessages):
              * Api/qwebsettings.cpp:
              (QWebSettings::clearMemoryCaches):
              (QWebSettings::setObjectCacheCapacities):
      2011-01-14  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Antti Koivisto.
      
              Rename cache() to memoryCache()
              https://bugs.webkit.org/show_bug.cgi?id=52433
      
              * WebCache.cpp:
              (WebCache::statistics):
              (WebCache::empty):
              (WebCache::setDisabled):
              (WebCache::disabled):
              * WebView.cpp:
              (WebView::setCacheModel):
      2011-01-14  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Antti Koivisto.
      
              Rename cache() to memoryCache()
              https://bugs.webkit.org/show_bug.cgi?id=52433
      
              * WebView.cpp:
              (wxWebView::SetCachePolicy):
      2011-01-14  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Antti Koivisto.
      
              Rename cache() to memoryCache()
              https://bugs.webkit.org/show_bug.cgi?id=52433
      
              * WebProcess/WebProcess.cpp:
              (WebKit::WebProcess::shutdownIfPossible):
              (WebKit::WebProcess::didClose):
              * WebProcess/mac/WebProcessMac.mm:
              (WebKit::WebProcess::platformSetCacheModel):
              * WebProcess/win/WebProcessWin.cpp:
              (WebKit::WebProcess::platformSetCacheModel):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13694ec6
    • ggaren@apple.com's avatar
      Try to fix non-Dtrace builds: #include Tracing.h instead of TracingDtrace.h. · c2c80282
      ggaren@apple.com authored
      * runtime/Heap.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2c80282
    • ggaren@apple.com's avatar
      2011-01-13 Geoffrey Garen <ggaren@apple.com> · 7c622bc0
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              Split out a MarkedSpace strategy object from Heap.
              https://bugs.webkit.org/show_bug.cgi?id=52421
      
              * Misc/WebCoreStatistics.mm:
              (+[WebCoreStatistics memoryStatistics]): Updated for class move.
      2011-01-13  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Split out a MarkedSpace strategy object from Heap.
              https://bugs.webkit.org/show_bug.cgi?id=52421
              
              SunSpider reports no change.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * JavaScriptCore.gypi:
              * JavaScriptCore.pro:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj: Updated our 7 build systems. Which is cool.
      
              * runtime/Heap.cpp:
              (JSC::Heap::Heap):
              (JSC::Heap::destroy):
              (JSC::Heap::recordExtraCost):
              (JSC::Heap::allocate):
              (JSC::Heap::markConservatively):
              (JSC::Heap::markRoots):
              (JSC::Heap::objectCount):
              (JSC::Heap::statistics):
              (JSC::Heap::size):
              (JSC::Heap::isBusy):
              (JSC::Heap::collectAllGarbage):
              (JSC::Heap::primaryHeapBegin):
              (JSC::Heap::primaryHeapEnd):
              * runtime/Heap.h:
              (JSC::Heap::globalData):
              (JSC::Heap::markedSpace):
              (JSC::Heap::isCellMarked):
              (JSC::Heap::checkMarkCell):
              (JSC::Heap::markCell): Moved all code pertaining to managing chunks of
              collector memory out of this class. Heap now just delegates to MarkedSpace.
      
              * runtime/JSCell.h:
              (JSC::JSCell::Heap::heap): Updated for MarkedSpace delegation.
      
              * runtime/JSValue.h: Moved the ValueStringPair typedef to help with #includes.
      
              * runtime/MarkedSpace.cpp: Copied from runtime/Heap.cpp.
              (JSC::MarkedSpace::MarkedSpace):
              (JSC::MarkedSpace::destroy):
              (JSC::MarkedSpace::allocateBlock):
              (JSC::MarkedSpace::freeBlock):
              (JSC::MarkedSpace::allocate):
              (JSC::MarkedSpace::resizeBlocks):
              (JSC::MarkedSpace::growBlocks):
              (JSC::MarkedSpace::shrinkBlocks):
              (JSC::MarkedSpace::markConservatively):
              (JSC::MarkedSpace::clearMarkBits):
              (JSC::MarkedSpace::markedCells):
              (JSC::MarkedSpace::sweep):
              (JSC::MarkedSpace::objectCount):
              (JSC::MarkedSpace::addToStatistics):
              (JSC::MarkedSpace::statistics):
              (JSC::MarkedSpace::size):
              (JSC::MarkedSpace::reset):
              (JSC::MarkedSpace::primaryHeapBegin):
              (JSC::MarkedSpace::primaryHeapEnd):
              * runtime/MarkedSpace.h: Copied from runtime/Heap.h.
              (JSC::MarkedSpace::globalData):
              (JSC::MarkedSpace::didShrink):
              (JSC::MarkedSpace::cellBlock):
              (JSC::MarkedSpace::cellOffset):
              (JSC::MarkedSpace::isCellMarked):
              (JSC::MarkedSpace::checkMarkCell):
              (JSC::MarkedSpace::markCell): Moved all code pertaining to managing chunks of
              collector memory into this class.
      
              * runtime/MemoryStatistics.cpp:
              (JSC::heapStatistics):
              * runtime/MemoryStatistics.h: Updated for MarkedSpace delegation.
      2011-01-13  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Split out a MarkedSpace strategy object from Heap.
              https://bugs.webkit.org/show_bug.cgi?id=52421
      
              * Shared/mac/WebMemorySampler.mac.mm:
              (WebKit::WebMemorySampler::sampleWebKit): Updated for class move.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c622bc0
    • thakis@chromium.org's avatar
      2011-01-14 Nico Weber <thakis@chromium.org> · 198efcf7
      thakis@chromium.org authored
              Unreviewed, test expectations.
      
              Rebaseline gradient test due to updated skia. reed checked the test and
              says the new look is right and is an intentional change.
              https://bugs.webkit.org/show_bug.cgi?id=52105
      
              * platform/chromium-linux/svg/batik/paints/gradientLimit-expected.checksum:
              * platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
              * platform/chromium-win/svg/batik/paints/gradientLimit-expected.checksum:
              * platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      198efcf7
    • andersca@apple.com's avatar
      2011-01-14 Anders Carlsson <andersca@apple.com> · 452c40ce
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              Add a new PageClient::displayView function and expose it on WebPageProxy
              https://bugs.webkit.org/show_bug.cgi?id=52500
      
              * UIProcess/API/mac/PageClientImpl.h:
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::displayView):
              * UIProcess/API/qt/qwkpage.cpp:
              (QWKPagePrivate::displayView):
              * UIProcess/API/qt/qwkpage_p.h:
              * UIProcess/PageClient.h:
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::displayView):
              * UIProcess/WebPageProxy.h:
              * UIProcess/win/WebView.cpp:
              (WebKit::WebView::displayView):
              * UIProcess/win/WebView.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      452c40ce
    • oliver@apple.com's avatar
      2011-01-14 Oliver Hunt <oliver@apple.com> · 1a6a9f7b
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              [jsfunfuzz] parser doesn't enforce continue restrictions correctly.
              https://bugs.webkit.org/show_bug.cgi?id=52493
      
              Add a few tests for continue to cover the cases where continue
              isn't syntactically valid.
      
              * fast/js/js-continue-break-restrictions-expected.txt: Added.
              * fast/js/js-continue-break-restrictions.html: Added.
              * fast/js/script-tests/js-continue-break-restrictions.js: Added.
      2011-01-14  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Gavin Barraclough.
      
              [jsfunfuzz] parser doesn't enforce continue restrictions correctly.
              https://bugs.webkit.org/show_bug.cgi?id=52493
      
              This patch reworks handling of break, continue and label statements
              to correctly handle all the valid and invalid cases.  Previously certain
              errors would be missed by the parser in strict mode, but the bytecode
              generator needed to handle those cases for non-strict code so nothing
              failed, it simply became non-standard behaviour.
      
              Now that we treat break and continue errors as early faults in non-strict
              mode as well that safety net has been removed so the parser bugs result in
              crashes at codegen time.
      
              * parser/JSParser.cpp:
              (JSC::JSParser::ScopeLabelInfo::ScopeLabelInfo):
              (JSC::JSParser::next):
              (JSC::JSParser::nextTokenIsColon):
              (JSC::JSParser::continueIsValid):
                  Continue is only valid in loops so we can't use breakIsValid()
              (JSC::JSParser::pushLabel):
                  We now track whether the label is for a loop (and is therefore a
                  valid target for continue.
              (JSC::JSParser::popLabel):
              (JSC::JSParser::getLabel):
                  Replace hasLabel with getLabel so that we can validate the target
                  when parsing continue statements.
              (JSC::JSParser::Scope::continueIsValid):
              (JSC::JSParser::Scope::pushLabel):
              (JSC::JSParser::Scope::getLabel):
              (JSC::JSParser::JSParser):
              (JSC::JSParser::parseBreakStatement):
              (JSC::JSParser::parseContinueStatement):
              (JSC::LabelInfo::LabelInfo):
              (JSC::JSParser::parseExpressionOrLabelStatement):
                  Consecutive labels now get handled iteratively so that we can determine
                  whether they're valid targets for continue.
              * parser/Lexer.cpp:
              (JSC::Lexer::nextTokenIsColon):
              * parser/Lexer.h:
              (JSC::Lexer::setOffset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a6a9f7b
    • mitz@apple.com's avatar
      Source/WebCore: WebCore part of <rdar://problem/8441312> Crash in -[NSView... · 660edfe5
      mitz@apple.com authored
      Source/WebCore: WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
      
      Reviewed by Simon Fraser.
      
      * WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and
      RenderWidget::resumeWidgetHierarchyUpdates().
      * manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
      are disabled. When this assertion was added, this condition was a subset of the “calling out to
      plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
      change now suspends widget hierarchy updates even at times where plug-in code is expected to be
      called, which invalidates the assertion.
      
      WebKit/mac: WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
      
      Reviewed by Simon Fraser.
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
      to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
      that the NSView tree doesn’t change from under AppKit as it traverses it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      660edfe5
    • commit-queue@webkit.org's avatar
      2011-01-14 Ahmad Sharif <asharif.tools@gmail.com> · 912c3d7d
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              When inlining is performed, the progress variable is
              declared as uninitialized.
              https://bugs.webkit.org/show_bug.cgi?id=51084
      
              * WebCore: Copied from WebCore.
              * WebCore/page/animation/KeyframeAnimation.cpp:
              (WebCore::KeyframeAnimation::animate):
              (WebCore::KeyframeAnimation::getAnimatedStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      912c3d7d
    • andersca@apple.com's avatar
      2011-01-14 Anders Carlsson <andersca@apple.com> · e1db25f2
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Implement the "should paint bounds instead of indiviual rects" algorithm from WebKit1
              https://bugs.webkit.org/show_bug.cgi?id=52499
      
              * WebProcess/WebPage/DrawingAreaImpl.cpp:
              (WebKit::shouldPaintBoundsRect):
              Port code from -[WebView _mustDrawUnionedRect:singleRects:count:].
      
              (WebKit::DrawingAreaImpl::display):
              If shouldPaintBoundsRect returns true, clear the rects vector and append the bounds rect.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1db25f2
    • tonyg@chromium.org's avatar
      2011-01-14 Tony Gentilcore <tonyg@chromium.org> · bf817302
      tonyg@chromium.org authored
              Unreviewed build fix.
      
              Fix Qt build after r75837
              https://bugs.webkit.org/show_bug.cgi?id=52494
      
              * rendering/style/StyleRareInheritedData.cpp:
              * rendering/style/StyleRareNonInheritedData.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf817302
    • ojan@chromium.org's avatar
      2011-01-14 Ojan Vafai <ojan@chromium.org> · ce11f2ef
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              fix expanded lines in the code review tool
              https://bugs.webkit.org/show_bug.cgi?id=52498
      
              Fixes them to work now that we have wrapper divs.
              Also fixes the long-standing bug that the line numbers
              were incorrect sometimes.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce11f2ef
    • tonyg@chromium.org's avatar
      2011-01-14 Tony Gentilcore <tonyg@chromium.org> · 24a1a309
      tonyg@chromium.org authored
              Unreviewed build fix.
      
              Fix Qt build after r75837
              https://bugs.webkit.org/show_bug.cgi?id=52494
      
              * rendering/style/RenderStyle.cpp:
      2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
      
              Unreviewed build fix.
      
              Fix Qt build after r75837
              https://bugs.webkit.org/show_bug.cgi?id=52494
      
              * ewk/ewk_view.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24a1a309
    • ojan@chromium.org's avatar
      2011-01-14 Ojan Vafai <ojan@chromium.org> · b82085ba
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              put remove lines to the left of add lines in sidebyside view
              https://bugs.webkit.org/show_bug.cgi?id=52458
      
              Also, sneaking in a fix to make long lines with no whitespace wrap.
      
              * PrettyPatch/PrettyPatch.rb:
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b82085ba
    • tonyg@chromium.org's avatar
      2011-01-14 Tony Gentilcore <tonyg@chromium.org> · 3c5e4bdf
      tonyg@chromium.org authored
              Unreviewed build fix.
      
              Fix Qt build after r75837
              https://bugs.webkit.org/show_bug.cgi?id=52494
      
              * editing/EditorCommand.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c5e4bdf
    • tonyg@chromium.org's avatar
      2011-01-14 Tony Gentilcore <tonyg@chromium.org> · 106795af
      tonyg@chromium.org authored
              Unreviewed build fix.
      
              Fix Qt build after r75837
              https://bugs.webkit.org/show_bug.cgi?id=52494
      
              * editing/ApplyStyleCommand.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      106795af
    • tonyg@chromium.org's avatar
      2011-01-14 Tony Gentilcore <tonyg@chromium.org> · 707f732c
      tonyg@chromium.org authored
              Unreviewed build fix.
      
              Fix Qt build after r75837
              https://bugs.webkit.org/show_bug.cgi?id=52494
      
              * css/CSSStyleSelector.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      707f732c
    • mjs@apple.com's avatar
      2011-01-14 Maciej Stachowiak <mjs@apple.com> · b4fe755c
      mjs@apple.com authored
              Reviewed by Anders Carlsson.
      
              Fix a few things in the WebKit2 skipped list
              https://bugs.webkit.org/show_bug.cgi?id=52484
      
              * platform/mac-wk2/Skipped: Add/remove some tests to the WK2 skipped list.
              * editing/style/stylewithcss-without-selection.html: Fix this test to avoid
              referencing an undefined variable in the failure case.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4fe755c
    • tonyg@chromium.org's avatar
      2011-01-14 Tony Gentilcore <tonyg@chromium.org> · 9e5da7c8
      tonyg@chromium.org authored
              Unreviewed build fix.
      
              Fix Qt build after r75837
              https://bugs.webkit.org/show_bug.cgi?id=52494
      
              * rendering/InlineFlowBox.h:
              * rendering/RenderBoxModelObject.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e5da7c8
    • paroga@webkit.org's avatar
      2011-01-14 Patrick Gansterer <paroga@webkit.org> · 20c03ed0
      paroga@webkit.org authored
              Reviewed by Adam Roben.
      
              Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
              https://bugs.webkit.org/show_bug.cgi?id=45186
      
              * wtf/FastMalloc.cpp:
              (WTF::TCMalloc_PageHeap::scheduleScavenger): Added missing this pointer to CreateTimerQueueTimer().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20c03ed0
    • mihaip@chromium.org's avatar
      2011-01-14 Mihai Parparita <mihaip@chromium.org> · faec159a
      mihaip@chromium.org authored
              Update the svg/ pixel expectations for the chromium-mac port.
      
              For the pixel tests that currently fail on Snow Leopard, this moves the
              current pixel results to platform/chromium-mac-leopard and adds new
              results to platform/chromium-mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/chromium-mac to platform/chromium-mac-leopard and newly added
              files in platform/chromium-mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faec159a
    • tonyg@chromium.org's avatar
      2011-01-14 Tony Gentilcore <tonyg@chromium.org> · b138b1e3
      tonyg@chromium.org authored
              Reviewed by David Levin.
      
              Do some forward declaration in RenderStyle.h
              https://bugs.webkit.org/show_bug.cgi?id=52453
      
              No new tests because no new functionality.
      
              * css/CSSComputedStyleDeclaration.cpp:
              * css/CSSStyleSelector.cpp:
              * editing/Editor.cpp:
              * page/EventHandler.cpp:
              * rendering/EllipsisBox.cpp:
              * rendering/InlineBox.cpp:
              * rendering/InlineTextBox.cpp:
              * rendering/RenderBlock.cpp:
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              * rendering/RenderBox.h:
              * rendering/RenderEmbeddedObject.cpp:
              * rendering/RenderFieldset.cpp:
              * rendering/RenderFileUploadControl.cpp:
              * rendering/RenderFrameSet.cpp:
              * rendering/RenderHTMLCanvas.cpp:
              * rendering/RenderImageResource.cpp:
              * rendering/RenderInputSpeech.cpp:
              * rendering/RenderLayer.h:
              * rendering/RenderLineBoxList.cpp:
              * rendering/RenderListBox.cpp:
              * rendering/RenderMediaControlsChromium.cpp:
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderObjectChildList.cpp:
              * rendering/RenderProgress.cpp:
              * rendering/RenderScrollbarPart.cpp:
              * rendering/RenderTable.cpp:
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
              * rendering/RenderTableRow.cpp:
              * rendering/RenderTableSection.cpp:
              * rendering/RenderTheme.cpp:
              * rendering/RenderThemeChromiumSkia.cpp:
              * rendering/RenderThemeChromiumWin.cpp:
              * rendering/RootInlineBox.cpp:
              * rendering/style/RenderStyle.cpp:
              * rendering/style/RenderStyle.h:
              * rendering/style/StyleRareInheritedData.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b138b1e3
    • jochen@chromium.org's avatar
      2011-01-14 Jochen Eisinger <jochen@chromium.org> · 5878483e
      jochen@chromium.org authored
              Unreviewed, roll chromium deps to r71432.
      
              * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5878483e
    • rniwa@webkit.org's avatar
      2011-01-14 Ryosuke Niwa <rniwa@webkit.org> · e3957692
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp,
              BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp
              https://bugs.webkit.org/show_bug.cgi?id=52481
      
              Removed instantiation of legacy editing positions.
              Calls to Position::Position are replaced by calls to Position's convenience functions.
              
              Also fixed firstPositionInOrBeforeNode and lastPositionInOrAfterNode so that
              they instantiate right positions for text nodes.
      
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::setSelectedTextRange):
              * dom/Element.cpp:
              (WebCore::Element::updateFocusAppearance):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::inputText):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
              (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
              (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
              (WebCore::CompositeEditCommand::splitTreeToNode):
              * editing/DeleteButtonController.cpp:
              (WebCore::enclosingDeletableElement):
              * editing/htmlediting.h:
              (WebCore::firstPositionInOrBeforeNode): Instantiates firstPositionInNode instead of
              positionBeforeNode for a text node.
              (WebCore::lastPositionInOrAfterNode): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3957692
    • commit-queue@webkit.org's avatar
      2011-01-14 Helder Correia <helder@sencha.com> · 7240bdcc
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              Shadow is not drawn when filling a path with a gradient
              https://bugs.webkit.org/show_bug.cgi?id=51982
      
              This happens in CG and is related to bug 51869, this time to be fixed
              in GraphicsContext::fillPath(const Path& path). We need to draw the
              gradient clipped to the path on a CGLayer first, and then draw the
              layer on the GraphicsContext.
      
              * fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Added.
              * fast/canvas/canvas-fillPath-gradient-shadow.html: Added.
              * fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Added.
              * platform/chromium/test_expectations.txt: Skipping new test since it fails.
              * platform/qt/Skipped: Ditto.
      2011-01-14  Helder Correia  <helder@sencha.com>
      
              Reviewed by Simon Fraser.
      
              Shadow is not drawn when filling a path with a gradient
              https://bugs.webkit.org/show_bug.cgi?id=51982
      
              This happens in CG and is related to bug 51869, this time to be fixed
              in GraphicsContext::fillPath(const Path& path). We need to draw the
              gradient clipped to the path on a CGLayer first, and then draw the
              layer on the GraphicsContext.
      
              Test: fast/canvas/canvas-fillPath-gradient-shadow.html
      
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7240bdcc